[G1 Android Development] Firerat:
so , if I'm reading this correctly, 2.3 is the fastest froyo because it has options, and this speed is because the user has options and has nothing to do with the options the user elects to have...

got to hand it to you Sparksco , that is incredibly innovative, pure genius

anyway, I've had a look at the options, and tbh I'm at a loss

you are doing some very crazy things

this is used a few times

if [ "`mount /data`" = "" ];
then

what are you trying to do with this?

mount /data

will try and mount /data

its output will go to stderr, you are testing stdout .. it will always 'pass'

now, onto some other stuff

if [ -e /data/local/bootanimation.zip ];
then
rm -f /data/local/bootanimation.zip;
cp /tmp/bootanimation.zip /data/local/bootanimation.zip;
else
cp /tmp/bootanimation.zip /data/local/bootanimation.zip;
fi;

so, if /data/local/bootanimation.zip exists you delete it and cp /tmp/bootanimation.zip to it

no need to delete it

you could replace all of that with

install -D /tmp/bootanimation.zip /data/local/bootanimation.zip

unless the file was a link, in which case

if [ -L /data/local/bootanimation.zip ];
then
rm /data/local/bootanimation.zip
fi
install -D /tmp/bootanimation.zip /data/local/bootanimation.zip

now, your bootanimation.zip is 3mb , we all know G1s are starved of space on data, why are you wasting it on a bootanimation which will work fine on sd-ext ?

install -D /tmp/bootanimation.zip /sd-ext/bootanimation.zip
ln -s /sd-ext/bootanimation.zip /data/local/bootanimation.zip

you repeat this for data/app/goLauncher

and here is the really messed up bit

You have exactly the same thing as an else to the if which will always be true

here is the bit which is even more messed up

before you do that , you test if /dev/block/mmcblk0p2 exists, and only do the above if it does

if it doesn't exist , you don't do the bootanimation bit, just the golauncher

you then check if /dev/block/mmcblk0p2 exists, again , and dump the google apps to sd-ext

you then test /dev/block/mmcblk0p2 yet again, and install my init.d scripts and swappy to system

Made me laugh , so thanks for that

Oh, that was a2sd

the dalvik-cache to sd-ext script is the same redundant

if [ "`mount /data`" = "" ];
then
do stuff
else
do the same stuff
fi

, ok dd binds now

if [ -e /dev/block/mmcblk0p2 ];
then
mount /sd-ext;
if [ -d /sd-ext/userinit.d ];
then
cp /tmp/11datadata-binds /sd-ext/userinit.d/11datadata-binds;
chmod 755 /sd-ext/userinit.d/11datadata-binds;
umount /sd-ext;
else
cp /tmp/11datadata-binds /sd-ext/userinit.d/11datadata-binds;
chmod 755 /sd-ext/userinit.d/11datadata-binds;
umount /sd-ext;
fi;
else
echo "no ext partition detected, Skipping dd binds!";
fi;

hmm, so if /sd-ext/userinit.d exists, and is a directory , do stuff, if not then do the same stuff anyway

Arrrrhhhhhhhhggggg,,, do you have any clue about what you are doing?

doing the same thing if the test results in true or false is just pointless

And that will fall over if /sd-ext/userinit.d doesn't exist

install -m 700 -D /tmp/11datadata-binds /sd-ext/userinit.d/11datadata-binds

you should also make sure that sd-ext did actually mount

anyway, from what I can gather , you say that your 2.3 is the fastest FroYo because of the options

So what you actually mean is it is the fastest because it uses My scripts, which end users can install themselves anyway , so without my scripts your rom is ? CM6.1 with a theme applied?

Its great that you are trying to integrate my script into your rom, but if your delivery scripts work it is happy accident more than anything else

Honestly , I would advise people to just opt out of your delivery scripts and just use the AIO

It will be more likely to work properly

--

is the glass full?

if A = no , pour water into glass

if A = yes , pour water into glass