yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
My post did NOT addresses you or your situation... You haven't said if TEE was in that state before using the module or anything else about what you did either... And I don't know about the error, sorry. 😬 PW
[Magisk] BlackWater$:
Oh sorry 😔, My TEE still in this situation after installing modules and I don't know why TEE State give this error, but maybe flash my phone with qfil did this flashing persist partition
[Magisk] pndwal:
Yup, if it wasn't like that before, flashing /persist can do it... Many ROMs won't flash and restore that except by using an EDL mode... Generic persist images in ROM may or may not restore unique numbers (depending on how damaged was done) anyway...

Did you take a nandroid backup including /persist before adding mods in addition to custom recovery?... Or does ROM contain /persistbak of similar for restoring?... These will be your best bet for a proper fix as they do contact unique device info unlike generic persist image from ROM... I gave a method here:

https://xdaforums.com/t/module-play-integrity-fix-safetynet-fix.4607985/post-89419068

If the above doesn't work or aren't an option, as it's Qcom you might have success (last resort) with @chiteroman's method Reprogram-TEE-on-Qualcomm-devices, Guide to reprogram the TEE on Qualcomm devices to fix lost attestation keys...

...

😬 PW
[Magisk] osm0sis:
Yep, anything more than empty json makes it go BASIC evaluationType (but still full pass) in SafetyNet, and fail STRONG in Play Integrity.

So, to be clear, I tried:

{
}

And:

{
"TAGS": "release-keys"
}

And then:

{
//"TAGS": "release-keys"
}

And the middle one is the one which fell back to BASIC evaluationType and failed STRONG.
[Magisk] pndwal:
mmm... Good test with innocuous "release-keys"... And agree it's a strange result. 👍

... So no JSON and correctly formatted but empty JSON behaves the same...

Still would be surprised if PIF is rigged to kill injection of fake keystore data just for lack of props/fields to spoof... Doesn't really make sense...

Logically we should always have fallback to basic attestation if PIF w/ Zygisk is running and hardware key backed attestation if it can work otherwise. At least that would enable people to diagnose without being mislead by unnecessary behaviour, so I hope we get an answer... Do you know how to test on-device attestation type definitively? (I suspect even backend can't actually see this and can only test the attestation measurements themselves.) 🙃 PW
[Magisk] MitzaBobitza:
Can anyone help me? I can't install this module. When I try installing it in Magisk, nothing happens. (see attached screenshot)

Could it be because I'm running Magisk Canary?
[Magisk] Vision:
Some news.

Maybe the successor of all.

GitHub - 5ec1cff/TrickyStore

Contribute to 5ec1cff/TrickyStore development by creating an account on GitHub.

github.com
[Magisk] trevtdogg:
is there a thread for tricky store discussion here on XDA?
[Magisk] casouzaj:
Tricky Store - The Next Generation PIF

IMPORTANT: I'm not the dev. of this module or have any affiliated with the dev. All the credits for the images and apps and modules, go to the original devs. A Big Thanks to @chiteroman and @osm0sis for his create project PIF and PIFork, and...

xdaforums.com
[Magisk] Vision:
Exactly, you have right, for those who ask.

This excellent module, do all the job for us, take all the guide of frameworkpatch and do it for us from the device, the only we must do is to compile with Android Studio (and add keybox, if not want the default) as release and after extract the classes.dex from the apk and put it inside in the META-INF/com/google/android/magisk/dex.

So if is not work for us, not blame this module.
[Magisk] MR.EXPLAINT:
i got error (failed ) on samsung A04E ANDROID 14

SEE ATTACHMENT

how to edit class dex...

@changhuapeng
[Magisk] Captain_Throwback:
Maybe read the links in the OP?
[Magisk] yoohoo55:
its my framework. im got the problem
[Magisk] changhuapeng:
What kind of problem? Installation problem? Facing problems after the module was installed?

Can you provide the installation log or at the very least, explain a little about the problem?

From your framework.jar, and I assumed that's an unmodified one, I can only see that your device is on a custom ROM with PixelPropsUtils implementation.
[Magisk] nullnor:
When trying to install the module, it seems to work with no apparent errors. However, when I select the reboot option, it seems to enter a state where it does not boot. I then have to press and hold the power button to reboot it, and then it boots into the system. After it boots, the module is not installed on APatch. The same behavior occurs whether I select the 'ApplicationPackageManager' option or not.

I'm using the classes.dex provided in the github repo. I'm on crDroid 10 ROM.

I've attached the install log from APatch.
[Magisk] changhuapeng:
You seem to have encountered bootloops after installing the module but everything looks fine from your installation log. Have you tried wiping dalvik cache?

From looking at the source, crDroid has implemented native bootloader and fingerprint spoofers in their ROM so that's really no need for you to use this module unless you have your own keybox or fingerprint.
[Magisk] nullnor:
I've tried clearing the Dalvik cache, but the issue still persists.

I tried installing this module because when I check with the 'Key Attestation' app, it shows me the following error, which I thought might be fixed by this module:
[Magisk] bilalrajput:
my WhatsApp has been banned on my phone but works on other devices

I tried changing IMEI, changing even roms, installed custom roms but the device still banned

can it help me to unban WhatsApp as some said WhatsApp checks fingerprint data, if I can change it, I can again reuse WhatsApp

thank you
[Magisk] AntarcticShaurant:
Are the other devices you're talking about unrooted?
[Magisk] changhuapeng:
You can try if this test version works to stop the bootloop. If the test version isn't working then your device most probably won't work with FrameworkPatch.

That's showing that your TEE is broken. Any modules that you used can only spoof that you have a locked bootloader but otherwise, won't be able to fix the real underlying problem.

Alternatively, you could try this LSPosed module which serves as the foundation upon which FrameworkPatch is built on: https://xdaforums.com/t/spoof-locked-bootloader-bypass-tee-check.4586251/

Edit: remove test version
[Magisk] Vision:
Wrong thread, this is only to create a patch framework.jar from this https://github.com/chiteroman/FrameworkPatch.

You must search here on XDA for Whatsapp problem like yours.
[Magisk] changhuapeng:
I can't give you an definite answer if this module can help with your case or not, but I've heard people using BootloaderSpoofer successfully to get WhatsApp to work. Since BootloaderSpoofer and FrameworkPatch work essentially the same, you could probably try either of these.
[Magisk] nullnor:
I've tried that test version, but the issue still persists. I'm guessing there's nothing more that can be done.
[Magisk] Vision:
Yeah is relative with this.

Besides this you pass 0/3?
[Magisk] nullnor:
I pass 1/3. It meets basic integrity:
[Magisk] borisSweden:
So this is a more advanced option and alternative to the constant fingerprint banning a dev is doing with his project? Still, this doesn't emulate any random G-Apps package that is required for Wallet, RCS etc usage without Google wrath.
[Magisk] Vision:
Please read the 1 page.

This is only to create a patch framework.jar from this https://github.com/chiteroman/FrameworkPatch.
[Magisk] Captain_Throwback:
This is simply an alternative to PIF, for users that may have apps that detect Zygisk. It still requires a working fingerprint, just like PIF, and will likewise be affected by any fingerprint "bans".
[Magisk] Vision:
Interesting, because other users, can pass 2/3 with the default, maybe something in your custom Rom.

Have you tried to disabled all modules?

And to see what pass by default?
[Magisk] bilalrajput:
i tried other rooted devices where WhatsApp isn't banned,it works in them

in my phone I have dual whatsapp two sim cards,only one phone number is banned ,other is not

if I add another number on my phone WhatsApp,it works, but not the previous number which was banned.

that banned phone number however works in every other phone but not in my phone
[Magisk] bilalrajput:
i searched everywhere but couldnt find any answer anywhere
[Magisk] bilalrajput:
thanks i can try but all my banking apps do work though
[Magisk] Vision:
Maybe Whatsapp, look for match device & number if the same with previous have banned.

But if different device or reverse number, it's work, something like that.

And about BootloaderSpoofer and Whatsapp.

Read here: https://xdaforums.com/t/spoof-locked-bootloader-bypass-tee-check.4586251/page-14#post-89545093
[Magisk] bilalrajput:
so how can we do something that makes it look like some other new device but not my device
[Magisk] Vision:
I'm not sure, only with global spoof, but that break other features of the device.

And about BootloaderSpoofer and Whatsapp.

Read here: https://xdaforums.com/t/spoof-locked-bootloader-bypass-tee-check.4586251/page-14#post-89545093
[Magisk] HarshaPraveen:
Hello😊,

i Cannot pass key attestation app but i installed framework patcher go module on Android 10 . Is there any way to pass key attestation app Thank you.
[Magisk] changhuapeng:
What does the app shows, before and after you installed the module?
[Magisk] HarshaPraveen:
Key attestation app shows "not supported by your device" even after install framework patcher go module.
[Magisk] Vision:
A screenshot?

And yeah before A14 is probably not working full, for me A11 only say BL is locked, but pass 0/0
[Magisk] Captain_Throwback:
Works fine on A13 for me as well.
[Magisk] Vision:
So my first thought, before change is right.

Need A13+.

What device? And Rom?
[Magisk] Vision:
Yeah is relative with this.

Besides this you pass 0/3?

What device and Rom?
[Magisk] Captain_Throwback:
ZenFone 8 stock Android 13.

I tried to test on my ROG II (Android 11), but TEE is broken as I messed up persist partition on that one a long time ago. So Key Attestation Demo can't work, so stuck with PIF there for Device Integrity.

EDIT: I have a ROG 3 on Android 12 I can test on once I buy and install a display for it. That won't be for a while, though.
[Magisk] flobo09:
SUPER easy to use ! Amazing job.

I thought i had a working keybox a nice member shared with me a few weeks back.

I guess not :D

Still it took 10 minutes to read the github explaination & do the whole process so very user friendly !
[Magisk] Vision:
Thanks for info.

Oh understand.

Oh good.

Because @chiteroman say not working for A11.
[Magisk] Captain_Throwback:
All that message says is that it doesn't pass Strong. That's doesn't mean it won't (or can't) pass Device.
[Magisk] Vision:
With default frameworkpatch classes.dex have you tried?
[Magisk] Vision:
This little confused me, because I ask @chiteroman but never get a clear answer.

Because I have A11 and pass 0/3.
[Magisk] HarshaPraveen:
On android 13, this module is not working and i cannot pass key attestation app.
[Magisk] Vicep83:
Edit : I have no problem using this module when rooted with KernelSU
[Magisk] Vicep83:
Is there any difference if I build myself classes.dex with real framework.jar pulled out of my device instead of the one included by default, cause I can't pass device integrity, and is it possible to include keybox and fingerprint of another phone like an S8 ? Thanks
[Magisk] Vision:
Not much, the same process is classes.dex compile by other users with Android Studio.

And this module, take your real framework.jar and add inside all the guide from frameworkpatch.

If you have a valid keybox, then yes, you must compile on Android Studio.
[Magisk] Vicep83:
But I must not include the classes.dex in the module file like before ? As I've seen that in new version you don't need to , do it take automaticaly the framework of your device like this ?
[Magisk] Vision:
You can add it manually in /dex folder.

Is the default classes.dex, if you want your own FP and keybox, must put it and compile on Android Studio.

And the auto, is only for the add lines, not for FP or keybox.

Read here: https://github.com/changhuapeng/FrameworkPatcherGO
[Magisk] changhuapeng:
That's because your TEE is broken.

@Captain_Throwback has the same issue with one of his TEE broken phone too.
[Magisk] changhuapeng:
There's no difference if you build everything on your own following chiteroman's FrameworkPatch tutorial.

It's not possible to include keybox and fingerprint of another phone. Keyboxes are private keys that Google provides to phone manufacturers so they cannot be extracted from any phones. Fingerprints are just properties in build.prop and you can learn more about them from the PIF FAQ.

The module still requires classes.dex. To make the module friendly to users, the classes.dex file will be downloaded if it is found missing during installation.
[Magisk] Captain_Throwback:
Has anyone that uses RCS tried this mod instead of PIF to confirm whether it still works? That would help to isolate whether it's the combination of PIF and the sailfish print that is causing the issue, or whether it's the fingerprint alone.

It seems to be working in my Chat with Gemini, but I'm not sure if that's a valid test or not.
[Magisk] Rana260492:
Hi

First of all thank you for this great module however the patch works great on both of my devices Pixel 7 pro and Pixel 7 (may 2024 update) with Magisk Alpha and ket attestaion shows BL locked with AOSP root certificate warning which is normal but i cannot pass device integrity,i tried these module versions from 0.2-1.00 with linked classes.dex file in github and patching of Appmanager.smali with Vol+ but still no luck. I am attaching my modified framework.jar from Pixel 7 pro please take a look when you have time.
[Magisk] Vision:
What Rom you have?
[Magisk] Rana260492:
Stock Google rom Pixel 7 pro May 2024 Update

Android 14
[Magisk] Vision:
Strange, because on A14 (stock) have lot success.

Because I have A11, and say the same BL is locked with AOSP, but can't pass, 0/0.
[Magisk] Rana260492:
Weird let's wait for developer to be online
[Magisk] Vision:
Yeah, he know better than me.
[Magisk] changhuapeng:
The patched methods in your framework.jar are looking good, modified to the exact specs from chiteroman's FrameworkPatch. You can follow through FrameworkPatch's tutorial and patch it manually and the results would likely be the same. So I really have no solution to the issue you encountered.
[Magisk] Rezoss:
First, thanks for your module it's really make it simple for me to have all the dexs modification done automatically.

Secondly, could you please point me out (suggestion or link) on how to find / to extract keybox from my device? and how to put that inside Android Studio, in which menu? I'm sorry i really noobs on compiling apk with android studio. Many thanks in advance.
[Magisk] changhuapeng:
There are quite a number of leaked keyboxes that you can find online but all of them have been revoked by Google. Your best bet to get a valid and non-revoked keybox will be to buy it from the dark web or an OEM who is willing to leak their keyboxes, since these keyboxes are provided by Google to their OEM partners and are stored securely.

If you do find a valid and non-revoked keybox, here are the info on how to modify FrameworkPatch with your own keybox or fingerprint: https://github.com/changhuapeng/FrameworkPatcherGO/issues/2#issuecomment-2150593602

You can then simply Make Project or build APK as a release build variant after modifying the files.
[Magisk] eac5:
I don't believe it will work on Pixel 7 and many other recent phones using RKP and StrongBox implementation. Either more framework patches are necessary than currently exist, or it's just downright impossible. I've run plenty of tests, the module does a great job patching, everything is applied correctly and bootloops are rare. Tried with a valid StrongBox keybox, a revoked one, and AOSP default, plus switching around fingerprints including the device's original, it's all the same. KeyAttestation is properly patched, but PlayIntegrity is always BASIC.
[Magisk] casouzaj:
This module installed without errors in my Xperia 1 II, running LineageOS 21 (A14). I answered yes (volume up) to all queries it made. As I already had PlayIntegrityFork and Zygisk Assistant, nothing changed for me regarding PI. Nevertheless, I faced media picker crashing all the time, and all file managers I had installed had problems accessing files. I uninstalled this module, and the issue was gone. Waiting for a new update.
[Magisk] chiteroman:
Good job :)
[Magisk] Captain_Throwback:
Strong Integrity with revoked keybox? How? Does it require some additional modification?
[Magisk] Vision:
Me to I try to see what wrong on A11.

Still can't get even the basic 😂🤣
[Magisk] Vision:
Maybe, you have already patch framework on your custom Rom?
[Magisk] yhs0331:
Installation shows error
[Magisk] chiteroman:
I'm not using revoked keybox 🤭
[Magisk] changhuapeng:
These days besides a working fingerprint, Google is also checking a couple of other things such as the kernel strings and ROM signatures for Play Integrity. Those things are beyond what FrameworkPatch does to fingerprint spoofing so you will have to fix them outside of FrameworkPatch.

Have you tried Play Integrity Fix/Fork and is DEVICE integrity passing when using it? If it is, then the issue is the incompatibility between FrameworkPatch and your devices. There's probably other areas in your devices framework that we don't know about, that needs to be modified for FrameworkPatch to work properly on it.
[Magisk] immortalwon:
The real question is: where / how are you getting all these unbanned keyboxes? :unsure:
[Magisk] changhuapeng:
The issue you're encountering are due to the way this module works by overlaying framework and not overwriting your system files permanently.

The inherent problem of overlaying framework is that whatever optimisation that the system has for the overlaid components are disabled so that will sometimes cause unexpected outcomes like system lagging or crashes. That's really the limit of this module.
[Magisk] changhuapeng:
Thanks for the installation log. I have received a few issue reports from users facing error like yours when the installation script failed to load dependencies. As of now, I am unable to reproduce such errors and do not have a fix for these issues yet. I do have a vague idea of the cause and am working on a solution.
[Magisk] changhuapeng:
LOL strong from you as usual, this must the reason this module has quite a bit of traffic today.
[Magisk] eac5:
It is, that's why I said more framework patches are necessary. Stock A14 on Pixels should have a pretty standard framework, so I've no idea what's lacking, but whatever it is, nobody knowledgeable enough will likely take time to find out, so I'll leave this be and settle for DEVICE via PIF.

If anybody wants my keybox to run tests, offer is still open, quite a few people have it now, but so far so good.
[Magisk] Vision:
A interesting thing i found, just mentioned if any users try test and have the same.
[Magisk] Vicep83:
Hi, I've also Pixel 7 and same problems
[Magisk] Vision:
So, I'm not the only one, who can't make it to work?

The main difference is I'm on A11 and can't even pass basic, and other users A13+ and pass only basic.
[Magisk] badabing2003:
I'm on A14 stock rooted with Magisk, no other modules other than systemless hosts, and not even Basic passes
[Magisk] Vision:
That is interesting, until now I thought only older Android version have this problem.

Me to on A11 stock rooted with Kitsune Mask, only PIF, no other modules.
[Magisk] casouzaj:
I grabbed the install log. I'm the one for whom media picker crashes all the time. Moreover, I noticed that media attached in WhatsApp messages aren't being saved to the internal storage. Edit: can't attach files. Both xda app and browser crash when I try to attach the file. Will have to uninstall this module again.

Edit2: after having uninstalled the nodule, here is the installation log.
[Magisk] eac5:
Seems something's going on with RKP as I suspected. HARDWARE_TYPE_UNAVAILABLE would mean either security level is not what's expected (either TRUSTED_ENVIRONMENT or STRONGBOX), or the component name of IRemotelyProvisionedComponent is wrong/None. Former is less likely as SOFTWARE level would make sense when using AOSP keybox, but not a TEE or StrongBox one, plus it's strange that KeyAttestation shows everything correctly. Since rkpd_client tries to get IRPC name then immediately this error occurs I'd bet it's whatever with the component name, though who knows what since in the aidl the only relevant bit is RpcHardwareInfo getHardwareInfo(); which I can't find good definitions on regarding what names might even be possible.

keystore2/src/globals.rs - platform/system/security - Git at Google

security/rkp/aidl/android/hardware/security/keymint/IRemotelyProvisionedComponent.aidl - platform/hardware/interfaces - Git at Google

https://android.googlesource.com/pl...ads/main/keystore2/src/remote_provisioning.rs says

" // Depending on the Android release, RKP may not have been mandatory for the

// TEE or StrongBox KM instances. In such cases, lookup failure for the IRPC

// HAL service is WAI and should not cause a failure. The error should be caught

// by the calling function and allow for natural fallback to the factory key."

In which case it might indeed be the PI spoofing part that's failing, as that should be changing the Android version to below RKP-mandated among other things, avoiding this error.

Though I don't understand how is Strong possible to begin with on a device print that supposedly doesn't support hardware attestation at all.
[Magisk] badabing2003:
Sorry if I didn't mention this before.

I don't have unbanned keybox, so I was not expecting strong.

But I was expecting PI Device to pass
[Magisk] Vision:
Yeah the same with default classes.dex.

Pass 0/0
[Magisk] eac5:
I mean just in general, supposing keybox is unbanned and at least TEE, how does DG square the fact that the print shows device that has no hardware attestation, yet the bootloader status and all that is backed by it
[Magisk] Vision:
Interesting.

The strange is the frameworkpatch method, work even on emulators, of course pass 0/0 (like my device 😂🤣) but show in key attestation the same results, BL is locked.
[Magisk] eac5:
Since KeyAttestation is local, fooling it is pretty simple with code essentially ported verbatim from BootloaderSpoofer. It showing correctly is likely an indication that the framework patches have been applied properly, but then the DroidGuard stuff is going south. That'll be difficult to troubleshoot even with logs, since we can't add extra logging to the relevant keystore bits without recompiling the whole thing as an unsigned/self-signed build, defeating the purpose. Poking around in framework more could help, but smali is very troublesome to read.
[Magisk] Vision:
Very interesting.

Thanks for info. I appreciate.
[Magisk] badabing2003:
It would have been very useful to get PIF logs from logcat similar to the PIF module, to troubleshoot if DG is getting the spoofed print or not.
[Magisk] Vision:
The interesting is @chiteroman have success with this on his Xiaomi Poco Pro.

What he does more than us and succeeds?
[Magisk] eac5:
There's some rudimentary logging in logcat under "chiteroman" if there's an error setting the props fields inside DG

FrameworkPatch/app/src/main/java/com/android/internal/util/framework/Android.java at 69e08eff494b68ccd3ec71ffb04e0a798d7c686e · chiteroman/FrameworkPatch

Modify framework.jar to build on system level a valid certificate chain - chiteroman/FrameworkPatch

github.com

But PIF's version is much more verbose and useful. Also there's way more injections and hijacks. Some are superfluous due to patching framework directly, but perhaps not all.
[Magisk] badabing2003:
I don't see those logs at all, probably an indication that spoof part is broken.