yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 & 5T Cross Device Development] wannabegt4:
Sorry if this is the wrong place to ask this but I found your name mentioned in some re-locking bootloader threads and figured you'd probably know. Given that the OnePlus 5(t)'s bootloader doesn't check who signed boot.img and only cares that it is signed, can I assume that since Magisk re-signs the boot.img I should be able to flash your rom, Magisk, and GApps then relock the bootloader as long as I do all of this before encryption?
[OnePlus 5 & 5T Cross Device Development] robertogl:
No idea what Magisk does :)

I usually suggest to simply not lock the device, there is no real advantage on op5. The boot.img shipped with this rom is already signed anyway if you want to try.
[OnePlus 5 & 5T Cross Device Development] robertogl:
New release, 02/07/2024

- Cheesburger

- Dumpling

Changelog:

Synced with AOSP android-14.0.0_r53 (July security patches)

Upgrade to kernel 4.14.348 (OpenELA)

Fix an issue causing the dialer to not be working after installing gapps
[OnePlus 5 & 5T Cross Device Development] spuiqr:
Any way to use oneplus Card Package app ( which in H2OS ) to add NFC Access card?

Or any other advice? I've tried some app and not found a good one.
[OnePlus 5 & 5T Cross Device Development] wannabegt4:
Working great with a re-locked bootloader and Magisk. OrangeFox Recovery is password protected so should be secure enough unless someone has some edl/firehose experience and even then my data is encrypted so some trust zone exploitation is going to be needed to get to it. Probably not stopping a state sponsored threat actor but good enough for me unless I've overlooked something simple. Let me know if that is the case as I've tried all the simple lockscreen/fingerprint bypasses I could find and nothing seems to work anymore.

I still have the issue with the dialer after installing nikgapps-omni so I'm just using core for now and giving the Fossify apps a chance. Also, USB file transfer is greyed out unless I enable adb debugging in dev options; I'm not sure if that is normal. Other than that, there was some weirdness with nav bar disapearing and gestures only partially working but after turning gestures on and rebooting it seems fine now.
[OnePlus 5 & 5T Cross Device Development] robertogl:
Are you using the latest release?

A reboot is needed to apply those settings, a popup should appears when the nav bar option changes.

If you have magisk and root access with adb, a user can flash their own recovery and bypass password protection most probably. They can't read your data directly anyway of course but they can edit stuff in /system for example, and in that case even install malicious apps. The platform key is not public though (unless you rebuilt Android), so at least they can't get system priviliges.
[OnePlus 5 & 5T Cross Device Development] wannabegt4:
Yes, I'm on the latest release.

The nav bar issues were happening before configuring gestures... configuring gestures and rebooting is just how I fixed the issue.

I've found no working password bypasses for A14 and the only way to get past the password protected recovery is through edl mode with firehose since the locked bootloader prevents fastboot boot and flash commands. Firehose is a valid scenario I've tested but an evil maid scenario with this level of expertise is outside of my threat model. I'm more concerned with data being protected if my phone is lost or stolen.
[OnePlus 5 & 5T Cross Device Development] robertogl:
Like I said, with root access you can overwrite the recovery :) The user needs access to adb with root though, so maybe that helps.
[OnePlus 5 & 5T Cross Device Development] robertogl:
Anyway the dialer issue should be solved in the latest release, can you check the kernel version from the settings?
[OnePlus 5 & 5T Cross Device Development] wannabegt4:
4.14.348-openela-g88749696489c-dirty

#25 Mon Jul 1 00:01:07 CEST 2024
[OnePlus 5 & 5T Cross Device Development] robertogl:
Apparently nikgapps only replace the default AOSP Dialer and it does not set the Google Dialer as default one.

I will restore the AOSP dialer to prevent these issues, as I can't control nikgapps and a workaound would be quite complex :)

Regarding the USB issue, the options are greyed out only after installing the Nikgapps packages: without it, they works fine so I guess the gapps are doing something strange here.
[OnePlus 5 & 5T Cross Device Development] satand:
I don't get tge custom led manager working. when it is activated, the notification led stops working. the file is the same as on A13.
[OnePlus 5 & 5T Cross Device Development] robertogl:
It works fine here, can you share the logcat?

Does the led work while charging?
[OnePlus 5 & 5T Cross Device Development] satand:
ok, I will make a logcat

I have another problem as well and tried to track it down. the device is randomly freezing and rebooting from time to time. It seems that the fingerprint is causing the reboot. i will try to provide a logcat as well.
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Thanks for the update. When you get a chance, can you push the local_manifests commit that states r53 is validated?
[OnePlus 5 & 5T Cross Device Development] satand:
yes, the led works while charging (green).

this is my settings file. file name is "SettingsExtraLedConfiguration.conf" and it is stored under system/sdcard

the log file is attached to this post.

i futher managed to get a log about the fingerprint issue. sometimes, probably when phone is in deep sleep, when i'm touching the fingerprint the phone just freezes and restarts. the OP5 is running on your latest rom version. here are the last entries from this logcat:

many thanks in advance!
[OnePlus 5 & 5T Cross Device Development] robertogl:
system/sdcard?

Did you use adb to get the logcat?
[OnePlus 5 & 5T Cross Device Development] satand:
i don't know how the folder structure is. in FX file explorer under the "# SYSTEM (ROOT)" view is one folder called "sdcard". it is the folder where DCIM, TWRP, downloads, etc. are stored.

i used the logcat extreme app (root) for the log.
[OnePlus 5 & 5T Cross Device Development] robertogl:
You should get the logs with adb, otherwise a lot of stuff will be missing (like in this case).

Also, how did you get the log if you said that the device reboots?
[OnePlus 5 & 5T Cross Device Development] satand:
I can't reproduce the fingerprint issue. it happens once or twice a day. which means I can't have the phone corded to a pc all the day.

logcat extreme records the logs. but obviously insufficient. is there a app which can record full logs?
[OnePlus 5 & 5T Cross Device Development] robertogl:
Only adb is reliable to get the full logcat :) For now you can get the logcat for the led issue.

Also, it is not clear to me: if you have the phone charging, yellow led, what happens if you get a notification? No LED? The LED stays yellow?
[OnePlus 5 & 5T Cross Device Development] Deion86:
I think I have the same issue. The phone randomly hardlocks for ~3 seconds then reboots. I do also feel it has something to do with the fingerprint-reader.

This happens between 0 to 3 times per day.

I don't have time to do the logcat thing at the moment but I will in ~2 weeks.
[OnePlus 5 & 5T Cross Device Development] robertogl:
If the device reboots, the only way after the reboot to get the logcat is to share the content of the "/sys/fs/pstore" directory, which requires root access.
[OnePlus 5 & 5T Cross Device Development] satand:
is the log in this file automatically generated?
[OnePlus 5 & 5T Cross Device Development] satand:
Can I share the files any time or do I need to copy the files right after rebooting?
[OnePlus 5 & 5T Cross Device Development] robertogl:
Every reboot will overwrite the files, so the logs should be after a reboot caused by the issue. They can be copied even days after it if you don't reboot again.
[OnePlus 5 & 5T Cross Device Development] satand:
please find the files attached. thanks!

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io
[OnePlus 5 & 5T Cross Device Development] robertogl:
Can you clarify the issue? Is this correct:

- device is sleeping, screen off

- you touch the fingerprint reader

- the screen turns on but the device reboots after it

Do you see the oneplus logo?
[OnePlus 5 & 5T Cross Device Development] satand:
1. device sleeps (at least screen off)

2. I touch the fingerprint

3. the device freeces less than a second (probably milliseconds) after touching the fingerprint. sometimes it freezes during the homescreen opening motion. in this case it gets stuck with this picture of opening the homescreen. sometimes it freezes during the "incorrect fingerprint vibration" and does not stop vibrating.

4. in any case, after approximately three seconds the device reboots like when pressing the power button for a long time.

5. next screen is the unlocked bootloader notice and a regular restart.
[OnePlus 5 & 5T Cross Device Development] robertogl:
Mmm I can't really see any reboot from the log though, quite strangely.

Did the issue appear with a specific release?
[OnePlus 5 & 5T Cross Device Development] satand:
I'm using this rom since June (full wipe) and experienced the issue since the beginning. now, I'm using the latest release.

would it help to share the files after a regular reboot?
[OnePlus 5 & 5T Cross Device Development] satand:
a moment ago, I had the same issue while the device was in use (screen on). I toucht the home button / fingerprint and it freezed and rebooted.
[OnePlus 5 & 5T Cross Device Development] robertogl:
Well try to share the log again, maybe this time it will contain more info.
[OnePlus 5 & 5T Cross Device Development] satand:
here are the files after two different reboots

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io

Easyupload.io - Upload Files and Share Them Easily

Uplaod files easily and share them with your friends and colleagues. File upload solution for everyone. Upload big files and get a link to share effortlesly.

easyupload.io
[OnePlus 5 & 5T Cross Device Development] Deion86:
I have the logs from 2 crashes. I didn't get a dmesg file though. Second crash includes an adb logcat. I just continuously unlocked the phone to trigger the crashes.
[OnePlus 5 & 5T Cross Device Development] robertogl:
How many attempt did this require?
[OnePlus 5 & 5T Cross Device Development] robertogl:
Android 13 had some hacks that were useful for this, but magisk can do the same stuff in a more clean way so I didn't add them on Android 14. I may add them back in the future, maybe.
[OnePlus 5 & 5T Cross Device Development] Slamb:
this would be nice for those who don't root :giggle:
[OnePlus 5 & 5T Cross Device Development] robertogl:
Yeah, it makes sense. I'll add back the changes.
[OnePlus 5 & 5T Cross Device Development] JnManso:
+1 vote. Thank you!
[OnePlus 5 & 5T Cross Device Development] aldosu:
Thanks for the work. The pixel launcher does not work for me
[OnePlus 5 & 5T Cross Device Development] robertogl:
Well it is not included in the ROM, maybe it needs to be updated to support Android 14.
[OnePlus 5 & 5T Cross Device Development] aldosu:
Thanks for the reply. But forgive my ignorance, how can I update it?
[OnePlus 5 & 5T Cross Device Development] aldosu:
I answer myself.

The latest version is in the apkmirror and it works.

Thank you.
[OnePlus 5 & 5T Cross Device Development] sunblade7:
I noticed this ROM has different kernel repos for Android 13/14 (kernel_oneplus_msm8998 / 4.14-kernel-oneplus-msm8998) and that the kernel.deny_new_usb sysctl is present in the a13 kernel but not the a14 kernel. Is there anything I can do to make this available on a14? I'd like to enable it by default.
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Looks like a kernel patch would be needed. One like this:

add toggle for disabling newly added USB devices · LineageOS/android_kernel_oneplus_msm8998@4f0999a

Based on the public grsecurity patches. Change-Id: I2cbea91b351cda7d098f4e1aa73dff1acbd23cce Signed-off-by: Daniel Micay <danielmicay@gmail.com>

github.com

In case you are interested, I have prepared a patch for the 4.14-kernel-oneplus-msm8998 repo
[OnePlus 5 & 5T Cross Device Development] robertogl:
Yes, the patch is needed.

The Lineage maintainer already has a patch for 4.14 actually:

Add toggle for disabling newly added USB devices · trautamaki/4.14-android_kernel_oneplus_msm8998@ca8c18e

Based on the public grsecurity patches. Change-Id: I2cbea91b351cda7d098f4e1aa73dff1acbd23cce Signed-off-by: Daniel Micay <danielmicay@gmail.com>

github.com
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Ok. Good to know. Would you be open to cherry-picking that commit back into your 4.14-kernel-oneplus-msm8998 repo so the next prebuilt kernel exposes the deny_new_usb sysctl?

The corresponding SELinux policy for the proc_deny_new_usb context already exists in device/lineage/sepolicy/common/dynamic
[OnePlus 5 & 5T Cross Device Development] robertogl:
I'll add it in the kernel starting with the next release.

I don't think I'll add an option to write on that sysfs node from the rom however, so you'll have to implement your own way :)
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Perfect. I greatly appreciate it.

Yes, I already have my own mechanism for controlling that sysctl. Just need it exposed ;)
[OnePlus 5 & 5T Cross Device Development] robertogl:
22/10/2028:

- Cheesburger

- Dumpling

Changelog:

Synced with AOSP android-14.0.0_r10

Updated to kernel 4.14.304

Removed some flags from the cmdline to trick safetynet

Added 'deny_usb' proc node

Started working on the support for Android 14 QPR1
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Confirmed build. No runtime issues. deny_new_usb is working! :cool:
[OnePlus 5 & 5T Cross Device Development] Slamb:
and banking apps work fine, no need for rooting and fixing safetynet 😊
[OnePlus 5 & 5T Cross Device Development] robertogl:
Perfect :)
[OnePlus 5 & 5T Cross Device Development] Slamb:
i found two minor bugs 🤔

when i take a screenshot, the image doesnt have a file extension 😮

and the device represents itself as android 10 in useragent 🤔
[OnePlus 5 & 5T Cross Device Development] robertogl:
1) The screenshot has the png file extension on the /sdcard/Pictures/Screenshots directory. Some apps may not show it. I just tried and the default Gallery app does not show the extension, but it shows the full name (with extension) in the 'details' section of the photo.

2) Same as Lineage, for some reason. It should not cause any issue though. Also it appears that the Android version in the user agent is correct using Firefox, but not using Chrome.
[OnePlus 5 & 5T Cross Device Development] Biiibi:
Hi, I think my TWRP version is not good. When I turn on the phone in normal mode, I have access to all my files. In recovery mode, they are encrypted. (I haven't set a lock yet).

Which version are you using (twrp)? Do you have a link please? THANKS
[OnePlus 5 & 5T Cross Device Development] robertogl:
@faoliveira did prepare a build supporting Android 14, not sure if he did provide it on XDA though.
[OnePlus 5 & 5T Cross Device Development] faoliveira:
Yes, I posted it here too

https://xdaforums.com/t/recovery-tw...ger-dumpling-11-10-2023.4351795/post-89095247
[OnePlus 5 & 5T Cross Device Development] billsz:
i tried bootanimation replacement for /data/local,system/media,product/media, all failed,any advice?thanks in advance
[OnePlus 5 & 5T Cross Device Development] robertogl:
/system/media and /product/media should work, do you still have the android logo?
[OnePlus 5 & 5T Cross Device Development] robertogl:
New release, 07/11/2028:

- Cheesburger

- Dumpling

Changelog:

November 2023 security patches

Synced with AOSP android-14.0.0_r12

Updated to kernel 4.14.314

Various kernel fixes
[OnePlus 5 & 5T Cross Device Development] aldosu:
Just installed. All right. Thanks a lot
[OnePlus 5 & 5T Cross Device Development] aldosu:
The only thing I have seen is that the device appears as not certified. I attach an image but it is in Spanish just as I have the device
[OnePlus 5 & 5T Cross Device Development] robertogl:
Wait some time, certification may require to wait (for some reason).
[OnePlus 5 & 5T Cross Device Development] aldosu:
ok, thank you very much for the response, I will wait a while, but this happened to me since I installed version 14 the previous month, with version 13, it was certified
[OnePlus 5 & 5T Cross Device Development] sunblade7:
When you have a chance, can you please push the r12 commit up? Thanks!
[OnePlus 5 & 5T Cross Device Development] robertogl:
Here https://github.com/roberto-sartori-...mmit/d47219990bf3732d782235083b232a493a51f1c3
[OnePlus 5 & 5T Cross Device Development] nirbhk:
Thanks for your continued support. I did clean flash. I do not get the option to restore my Google backup when I try to set up the phone.

Would you know how I can get the option to restore during setup?
[OnePlus 5 & 5T Cross Device Development] robertogl:
I forgot to push this commit:

aosp_patches/frameworks/base/0002-Replace-strings-with-strings.patch at a14 · roberto-sartori-gl/aosp_patches

Contribute to roberto-sartori-gl/aosp_patches development by creating an account on GitHub.

github.com

It is a fix from google, but not included in a14 for some reason yet.
[OnePlus 5 & 5T Cross Device Development] robertogl:
Did you flash gapps?
[OnePlus 5 & 5T Cross Device Development] nirbhk:
I did. Tried litegapps and nikgapps for A14. I can see playstore on booting. But factory reset also takes me directly to main screen and doesn't ask for phone setp
[OnePlus 5 & 5T Cross Device Development] robertogl:
Which nikgapps version? ROM side there is nothing particular, as setup wizard is all part of gapps.
[OnePlus 5 & 5T Cross Device Development] nirbhk:
I did the basic/core one. The full version did not flash/returned an error.
[OnePlus 5 & 5T Cross Device Development] robertogl:
I'm pretty sure basic and core don't have the setup wizard included.
[OnePlus 5 & 5T Cross Device Development] nirbhk:
Tried stock/full NikGapps but it skips Setup wizard installation. Strange. Did a clean flash, butsays no space is left.
[OnePlus 5 & 5T Cross Device Development] Frol185:
Flash Omni gapps
[OnePlus 5 & 5T Cross Device Development] robertogl:
You can create a custom nikgapps package from core with the setup wizard (but you may ask in the nikgapps community for help on this).
[OnePlus 5 & 5T Cross Device Development] lifeijn:
This package runs smoothly。
[OnePlus 5 & 5T Cross Device Development] totomo26:
Which Gcam is everyone using? I've been having issues with the selfie cam with the ones I've installed.
[OnePlus 5 & 5T Cross Device Development] DuckDodger70:
Stock app works quite fine
[OnePlus 5 & 5T Cross Device Development] sunblade7:
@robertogl I noticed that all of the full OTAs published for A14 on SourceForge are failing to boot after bootloader relock. Boot fails at bootloader stage with red state error "Your device is corrupt.". Android 13 had no issues with with bootloader relock. Do you know what it required to get successful boot on A14 after bootloader relock?
[OnePlus 5 & 5T Cross Device Development] robertogl:
There is no support for that since some A13 tag.

Google removed support for signing the boot image, so I would have to manually sign that. There is no real benefit in locking the bootloader, so I just didn't change this and I removed support for booting with locked bootloader.
[OnePlus 5 & 5T Cross Device Development] robertogl:
I just use opencamera.
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Ok thanks for the explanation. I wasn't sure if it was known/intentional. In any case, I'd like to sign and relock the bootloader for my custom ROM. Can you please summarize the steps involved? I'd really appreciate it.
[OnePlus 5 & 5T Cross Device Development] robertogl:
You can use the BootSignature.jar jar from the out/ directory, but I don't even know if that exists on a14. And you would have to do that manually after building the OTA.
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Thanks for pointing me in the right directoin. BootSignature.jar is not built anymore but the boot_signer binary executable is equivalent. I have it working with incremental/full OTAs. Boots with yellow state.
[OnePlus 5 & 5T Cross Device Development] DuckDodger70:
@robertogl since upgrading to A14 when trying to connect to a Wi-Fi connection where i need to sign in, i keep getting a Captive Portal Login keeps stopping.

Have tried clearing data/cache but keeps happening to be all the time.

Is this an OS thing or a gapps issue?
[OnePlus 5 & 5T Cross Device Development] robertogl:
No idea, can you get a logcat?
[OnePlus 5 & 5T Cross Device Development] DuckDodger70:
Yeah for sure, ill see what i can get, although will have to try and get later on.
[OnePlus 5 & 5T Cross Device Development] robertogl:
New release, 07/12/2023:

- Cheesburger

- Dumpling

Changelog:

December 2023 security patches

Synced with AOSP android-14.0.0_r17

Various kernel fixes
[OnePlus 5 & 5T Cross Device Development] sunblade7:
Much appreciated! When you have a moment, can you please push up local_manifests?
[OnePlus 5 & 5T Cross Device Development] aldosu:
First of all, thank you.

Now I tell you problems that I have found.

The update has not kept my phone data but has behaved as if it were an installation from scratch, I don't know the reason.

After proceeding to install everything and leaving everything as I want, I have encountered several problems:

-Once again it does not come with a pixel launcher (corrected by downloading it from apkmirror)

-The cell phone comes without being certified with the consequent problem of installing bank cards. I know this resolves over time but the last time it took me almost 10 days. There is no way to solve this?

-The at a glance does not show time or pending tasks, only date.

-When searching for anything it shows me my history but I can't see it because the font and the background appear the same color. I have tried changing the colors but it always makes the font the same color, the only thing is to force high contrast text, but it affects the entire system and it doesn't look very good

All of this worked fine before.

Let's see if you can help me

Thank you very much and sorry for my English