yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Awesometic:
Hello,

I need a logcat file while the issue occurs. :)

For me, I can use the WiFi after switching the airplane mode.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Luiggi Piumbu:
Thank you for all this great work !

I installed it on my T820, I encountered no installation problem and now the rom is running perfectly and fast since yesterday. 👍

In TWRP I formated everything before install, installed the rom, then the gapps without rebooting. Then reboot to system and voilà 😀
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] shatlykbs:
Hi Awesometic. Thank you for your hard work.

I tried to flash Lineage OS 19.1 sadly couldn't get past Samsung Tab S3 logo.

Device: SM-T825

Baseband Version: T825XXU3CTA1

File system: ext4

I attached log file which I took while it was stuck on boot logo.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] sirgilmour:
Any S-PEN options in Lineage Os?

To map an eraser to the button or turn off the little circle that appears when the pen approaches the screen, I saw paying apps that could add options within its own app for a monthly fee but it would prefer a universal tool that would work with those who don't have these options like Sketchbook which I use a lot.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
Does Odin say "pass"?

After flashing it it's essential to reboot into TWRP directly.

"auto reboot" should be disabled in Odin as it's easier to reboot manually.

Stock recovery will be restored if not booted into TWRP after flashing.

If that fails you gotta reflash it.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Juergen_Zahn:
I forgot to tell you, sorry: Odin says "pass"

I didn't know that I have to boot into TWRP directly.

I will try tomorrow.

I will keep you informed
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
My 1st attempt seem to have increased the volume but for me it isn't enough.

2nd attempt after increasing to 120 let me stay there.

btw. headphone jack output sound for music is much better than speaker or USB with headphone jack adapter output.

More bass while the other two just sound flat like set only for speach. Therefore music sounds imo much better using jack output.

Switching Dolby Atmos on or off doesn't change a thing on jack or USB.

Tested with "Greta van Fleet" (y)(y) via VLC.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
I'm about to bet it will work then.

btw. just saw your signature.

Why not bringing your T315 to LOS14.1 after flashing the T825?;)
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Juergen_Zahn:
I am able to boot TWRP ! First at all I backup my device: Boot, System, EFS. If I choose Data Backup failed!

I flashed lineage-19.1-20220715-UNOFFICIAL-gts3llte and NikGapps-omni-arm64-12.1-20220413-signed. Now my device is restarting...

Sorry, my signature was wrong: T315 didn't exists anymore.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
Important is imo just EFS.

The rest will be restored when flashing stock firmware if ever necessary.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Juergen_Zahn:
Unfortunatly I have had a boot loop. After formating Data partition nearly everthing is doing well.

One thing isn't working: Speech Services by google. Do you have an idea how to get it work? I need it for Mosalingua
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
"format data" I always recommend when doing a clean flash.

Sorry, no idea about Speech. As I use only smallest Gapps available it's usually not included and I don't need it anyway.

Microfone access granted?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] LedgendaryEpics:
Quick question, sorry if this has been answered but would this ROM perform better if it was flashed under f2fs data partition?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Yase62:
I have a question. When you apply new improvements, how can we update without loosing anything or without backup? OTA is available? Because when you update with OTA, you don't need back up. For example: I have apps and photos. When I want to update june to july version, I don't want to back up, I want to update without loosing photos/files or no need install my apps again.

What's your suggestion? I have to back up? (If yes, how?) or can I upload without loosing any photos/files?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Awesometic:
It will be, but maybe not noticeable for some people. For the best stability, I recommend using EXT4 format because F2FS is not matured on our kernel which I merged some modern patches but maybe not enough to be fully stable compared to the recent kernel like 5.10 or above.

You don't have to make a backup and clean up the whole system. You can update by doing 'dirty-flashing' that means flashing the new ROM zip file using TWRP without formatting the current system, and data partitions. One thing that you should do is wipe out the cache partitions.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Juergen_Zahn:
Microphone access already granted. Thanks for your assitance.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
I've done this 30 times without success.

825 here... i don't know if i'm missing something or whatever... bloody taskbar is always there.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
How you get to pixel developer options?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
Uhm, isn't it possible to install Netflix using this rom?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Brennusbr:
1) Go to default apps and select the Pixel Launcher

2) Long press the home screen and select Settings

3) Go to Developer Options

4) Disable "ENABLE_TASKBAR"

5) Go back to your previous launcher

Hope that helps.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
I don't have any "Developer Options" in Pixel settings... already tried haha.

Version 12 of launcher here, you too?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] jtrakx:
Could you please try installing Nova Launcher first and set it as default launcher? I dont know but maybe that could help.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] jtrakx:
Yes, you can but you need the ff:

1. Magisk with zygist enabled

2. Universal safetynet fix installed (magisk module)

3. Magiskhide props config (magisk module). You will need a terminal emulator to configure magiskhide. In the config select Samsung Galaxy Tab S3 as your device.

4. Reboot afterwards. Give google play store a few hours (this is consistent in my case). Then later search Netflix in playstore you will find it there.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
Yep, done that already, no changes. I've freezed pixel launcher with titanium backup and the bar is gone.... but recent apps button ha stopped working lol.

Done it yesterday, i just had to wait a few hours, it's working now hehe.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Stogie87:
Or you just install Aurora Store and install it from there. ;)
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] solemgar:
I would like very much to try this rom as a daily driver (and since it supports encryption), but the lack of selinux enforcing worries me in terms of security . Is there any work towards having full selinux enforcing support? Thanks !
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
Performance with this rom is like using a brand new tablet.

Stock android on this is bloody laggy.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] solemgar:
Indeed, but selinux permissive is having door wide open to any kind of malware.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
That is somewhat right but on a more than 2 years old non patched stock the security isn't that much better imho.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] solemgar:
Also somewhat true, but with selinux permissive the chances of hitting exploits are even higher. I am not planning using secure apps , but at least would like to use Gmail with some peace of mind.

Also,

https://www.reddit.com/r/Android/comments/lfye5r
explains it better than me.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] solemgar:
Btw, does Dolby Atmos work and USB OTG is fixed already?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
T825:

Atmos idk as I don't hear any difference when turning on or off.

OTG works. (@Awesometic imho you can delete that on the "What's not working" list)
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
@Awesometic changed them two lines (RX1+2 Mix Digital Volume) back to original values as I have the impression that when using speakers these are quite over amplified.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Awesometic:
How did you test OTG? I still can't use it 🤔

Ah okay, will not change the speaker volume (RXx Mix Digital Volume)
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
Inserted stick and copied a file onto it.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
Access is a bit awkward but Total-Commander (root access granted in Magisk) copies to and from.

So it can write to it although USB is not selectable as target folder.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bradzand:
I'm also interested in this question. Running with selinux=permissive is high risk, and it seems irresponsible that such a large proportion of unofficial ROMs disable selinux. LineageOS makes it mandatory to run selinux in enforcing mode in their official ROMs for good reason.

With selinux disabled, it is trivial for malicious code in an app to permanently root the device and gain full control over it, giving malicious actors the ability to access and exploit your personal information that exists within your other apps or perform other malicious activity without the user knowing. Given that there is a PoC on github that shows how to do this, you can bet that this exploit is already out in the wild.

@Awesometic, I appreciate and respect that you put a lot of your personal time and effort into this (it's a lot more than I do), but I think this concern is valid. Can you eli5 why you haven't set selinux=enforcing in your builds, and if it is possible, what it would take to achieve this?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Malykont:
I've had the same issue since installing the alpha, these instructions helped. Thanks!
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Brennusbr:
Yes, 12, the same one that came with NikGapps.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] lsalines:
Thank you, finally the solution!
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] 908070:
Hi,

TWRP does not run for me.

ODIN installs without errors, but the recovery remains stock.

Where could be the problem?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
If not rebooting to newly flashed recovery DIRECTLY after the process revives old stock recovery..
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] 908070:
OK, thanks!

It runs excellent!
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Awesometic:
Hello,

You're right, SELinux permissive is not safe from hacking. I know why making it enforce is important, but the reason is the time for sure.

As the main purpose of this development is to make the tablet usable again, SELinux enforcing is not a priority one since we all know the SELinux job takes so much time while that is not that important for normal use of the tablet.

So for now I wouldn't say that I will do that job in the future. 😅
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Awesometic:
The new version of LineageOS 19 is uploaded now.

This version has upstream LineageOS changes that comes with Android 12.1 r22, and a fix for Keystore to use hardware encryption in Samsung way properly.

In the first LineageOS 19.1 version, it uses some special files from the other partition but for some reason, it broke the boot sequence because of the delay and the permission issues. So I broke the loading of that special files and it would fix that boot failure problem.

Now, thanks to @masdaster , I can fix the boot failure and finally we can use the proper hardware encryption.

Thank you, and please note that the changelogs to fix the lock screen issue caused by changing the Keystore method.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
Will a dirty flash work? Or is a clean flash mandatory?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
I assume that the changes are to big for a dirty flash.

For me it mostly worked to flash cleanly and restore data afterwards.

Edit: dirty flash worked but some apps don't work properly or at all, so now I'm installing cleanly.

Edit2: clean + restoring worked, although (until now) one app had to be reinstalled.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] MachineMasher:
I got lineage-19.1-20220815-UNOFFICIAL-gts3lwifi.zip installed successfully with my modified version of FlameGApps-12.1-basic-arm64-20220612.zip (modified per this post: https://xdaforums.com/t/rom-unoffic...-19-1-for-galaxy-tab-s3.4418855/post-87020709).

I'm still having the issue with the green bar in Zoom (per https://xdaforums.com/t/rom-unoffic...-18-1-for-galaxy-tab-s3.4293069/post-86517463). One additional thing that I noticed, though, is that in addition to having the distorted colours in Zoom, I also don't have any microphone sound even after enabling microphone and connecting audio with WiFi.

The Zoom microphone sound issue also happened in lineage-19.1-20220611-UNOFFICIAL-gts3lwifi.zip. Not sure about versions earlier than that.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Awesometic:
Dirty flash will work but as @bmwdroid said it might break some apps that use any lock method.

It can be fixed by removing the '/data/system/locksettings.db' file, but still, the best way is the clean installation.

Yeah I know there is a malfunction in the Zoom app, but I think it is quite hard to fix. 😅

The suspicious thing I think is the camera implementation on our device tree, but we have to use the old Samsung camera binaries due to some changes of Samsung in HAL and kernel.

Or, there may be a kind of quick magic for fixing this thing, but I don't know yet..
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] Awesometic:
I updated the "Known issues" section of this thread for some malfunction on voice chat apps for now. :)
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] martinedu:
Hello. I just installed the new version of the firmware but I run into a problem. When unlocking the tablet by entering the corresponding PIN, it asks me again to complete the PIN for unlocking. I tried to install the previous version of the firmware but again it behaves the same. Does anyone know a solution that does not perform a factory reset? From already thank you very much.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
that's somewhat peculiar as on my dirty flash it didn't ask.

Hope you made a TWRP backup of Data as I doubt you'll have a chance otherwise.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] martinedu:
My bad operation. I forgot to make a backup of the tablet. Install everything as if it just came out of the box.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] 908070:
Please write an info text on the start page of thread, if a clean installation is necessary. Dirty-Installation denies access after PIN entry.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
Sorry to hear that. Perhaps it's worth a try:

backup Data as it's probably still untouched.

then:

1. just wipe System and flash new ROM and Gapps -> test it

2. to do 1 and wipe internal storage as well before flashing ROM and Gapps -> test it

if these two still don't work i think you will have to make a clean install.

Then try if restoring data makes it work again.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] martinedu:
In the end I chose to perform a clean installation.

I also use the tablet for multimedia and the occasional game/social network before going to sleep.

Regardless of my problem, it is a great job that they are doing with this ROM.

I ended up convincing myself that it was not necessary to renew it.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
Clean flashed last saturday.

Great work.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] castoruser:
Hello @Awesometic ;

thanks for your great work on this tablet also on Android 12.

I tried to build myself again and got always this error with the kernel by round about 57%:

I have tried your trick for Android 11 but it didn't work. What is your trick for Android 12?

thanks for your support.

greets

Castoruser
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] masdaster:
Hello,

do you have an error message, please? I have several 'fixes'/patches applied at the moment. 4 of them are critical and my build fails if I revert them...
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] castoruser:
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2523:2: error: invalid pr
eprocessing directive
#void audio_extn_utils_release_snd_device(snd_device_t snd_device)
^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2524:2: error: invalid pr
eprocessing directive
#{
^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2525:6: error: invalid pr
eprocessing directive
# audio_extn_dev_arbi_release(snd_device);
^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2526:6: error: invalid pr
eprocessing directive
# audio_extn_sound_trigger_update_device_status(snd_device,
^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2527:38: error: invalid p
reprocessing directive
# ST_EVENT_SND_DEVICE_FREE);
^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2528:6: error: invalid pr
eprocessing directive
# audio_extn_listen_update_device_status(snd_device,
^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2529:38: error: invalid p
reprocessing directive
# LISTEN_EVENT_SND_DEVICE_FREE);
^
hardware/qcom-caf/msm8996/audio/hal/audio_extn/utils.c:2530:2: error: invalid pr
eprocessing directive
#}
^
8 errors generated.
[ 57% 73999/128461] Building Kernel Image (Image.gz-dtb)

DEPMOD 3.18.140-awesometic-kernel-v0.10+
make[1]: Verzeichnis „/home/michael/Compilieren/lineageos191/android/lineage/out
/target/product/gts3llte/obj/KERNEL_OBJ“ wird verlassen
make: Verzeichnis „/home/michael/Compilieren/lineageos191/android/lineage/kernel
/samsung/msm8996“ wird verlassen
depmod: WARNING: could not open modules.order at /home/michael/Compilieren/linea
geos191/android/lineage/out/target/product/gts3llte/obj/PACKAGING/depmod_vendor_
intermediates/lib/modules/0.0: No such file or directory
depmod: WARNING: could not open modules.builtin at /home/michael/Compilieren/lin
eageos191/android/lineage/out/target/product/gts3llte/obj/PACKAGING/depmod_vendo
r_intermediates/lib/modules/0.0: No such file or directory
16:37:10 ninja failed with: exit status 1

#### failed to build some targets (15:35 (mm:ss)) ####

Hello @Awesometic and @masdaster

This is the error message
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] retiredtab:
If you are trying to comment out that code, it's not# for .c files.

It's

/*

* all this stuff
* in
* between
* is commented
* out

*/
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] boedster:
Can't install the rom. Get a Error 21 and now the tables is in a bootloop! How to recover the bootloop so I can retry to install the rom.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
So you flashed just the ROM as you wrote and that gives you a bootloop?

When it reboots tried button combos to get into TWRP or Download Mode.

Which TWRP?

Did you "Format Data"?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] boedster:
The bootloop is fixed by flashing original rom from samsung an used odin.

TWRP 3.6.0_9-gts3lwifi

Lineage 19.1 20220815 unofficial gts3lwifi (rom)

Yes format data, did OEM unlock for the bootloader.

Now is stock, going to start again.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] the_bartman:
Problems with AudioFX...

It seems, that AudioFX doesn't have any effect on the audio output.

I use it with an vibration speaker which needs a bit adjustment. On my old Telekom Puls tablet with LieageOS 14.1 the AudioFX worked very well, but now with my Galaxy Tab S3 and LineageOS 19.1 it is without effect.

Any idea what to do?

Regards, Bart
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] andgest:
Hello,

First of all, thank you very much for this ROM.

It gives this tablet a new lease of life, and above all it makes it much more powerful than it ever was with the official Samsung ROM... It's a shame from samsung...

I'm writing to you because I'm having trouble getting Netflix to work.

I have done the operations suggested by jtrakx, I can find Netflix in the playstore and I can install it.

Unfortunately, once I run Netflix I get an error message -93

I am now stuck on it

Any ideas?

Thanks in advance
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] bmwdroid:
@andgest I don't use Netflix but was interested in the problem.

When searching the net for "netflix error -93" I get a link even to XDA.

Did you try all suggested there?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] jtrakx:
I suggest you do the following:

1. Uninstall netflix.

2. Download the latest stable netflix version from any alternative sites like APKMirror, F-droid, etc.

3. Install your downloaded apk.

4. Clear the netflix cache.

5. run netflix. If it works, you may update it using playstore.

If you have YASNAC installed, make sure you pass both the basic integrity test and the CTS profile test.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] andgest:
Hello,

Thank you for your answers :)

I have tried the different solutions found on this forum related to my 5001 -93 error but nothing works...

By going through another store I have the same error. I can update on the PlayStore but it does not change anything.

On YASNAC, the basic and CTS profile integration tests go well.

However my tablet is a sm-t820 and not a sm-t825 as displayed on YASNAC.

I used the MagiskHide Props Config module to change my tablet footprint, but I did not find the sm-t820 in the list, so I selected the sm-t825.

Could this be the problem?

Do I have to install a particular magisk module?

Thanks in advance ;)
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] djy:
I have an SM-T820. Installed twrp-3.6.0_9-0 and flashed this rom. Magisk 25.2 (25200) app is installed but it's not rooted yet. Ramdisk shows Yes. Only option I have is to "select and patch a file". I tried extracting the boot.img from this ROM, patching it, then flashing in TWRP but that broke the kernal and resulted in a bootloop. ADB won't recognize the device in download mode. I've reflashed TWRP in Odin, then reflashed this ROM in TWRP, and it boots normal again.

Can someone please explain how to get root with Magisk or point me to a guide that works?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
Did that and worked like a charm.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] djy:
I got an error when flashing the patched boot image. Do you remember the steps you took?
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] jtrakx:
Hmm. That's weird.

Could you please try to install first an old version (2-3 months old) of Netflix to see if its gonna work? If it does, then you may update the old version using playstore.

or maybe you need to add Netflix in the magisk denylist.
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] jtrakx:
Install Magisk using TWRP. Just rename magisk.apk to magisk.zip. After reboot, the magisk will update to latest version and there will be an option to activate root. No need to use "select and patch a file."
[Samsung Galaxy Tab S3 ROMs, Kernels, Recoveries, &] yagueitor:
I Just followed magisk instructions on github.