yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Yup, but clearly for debugging purposes...

Looking at it from dev perspective, vvb2060 does an enormous amount of the fixes / inovative changes in her Alpha that then trickle down (PRs submitted) to TJW Magisk...

Many here lose sight of real purpose of Canary: it's the official debug built for public releases! ... appcenter is a debugging tool. - And as she states in PR, it won't be in public releases.

What are Canary builds for if not to assist w/ testing pre-public release builds and assist with the debugging they're designed for?

What are Alpha builds for? To restore MagiskHide in the Zygisk era?

Wrong! Users may have commandeered them for such purposes / assumed that. But in reality they are to assist w/ testing pre-TJW Canary test builds and assist with the debugging they're designed for.

Alpha is the only fork I know of having tacit TJW approval, and is a debug build for testing / feedback on numerous fixes intended for submission to Magisk master branch.

vvb2060 and others like RikkaW, Shana and Caynie, associated w/ LSPosed (uni students girls club? 🥰), do untold / groundbreaking work with very little proper feedback / logs even from these debug builds. 99% (am I being generous?) of debug build users never debug!

Appcenter telemetry is probably seen by them as a no-brainer! Suddenly, all those 'signing up' for Alpha / Canary (but not public Beta) 'non-public' builds will supplying useful logging data! Debug will finally be doing what it was designed for! ... Didn't know this?; then why did you download it?

Think about it from a Gals point of view Guys; they want to 'work smarter, not harder'... not to mention faster!

All this property selected, categorised and targeted data can only speed up Magisk development by eliminating wasted time helping inexperienced users provide proper logs, providing data from multiple devices / OSs for easy comparison on each issue, drastically reducing wait time / time wasted asking for logs from unresponsive users, allowing devs more time to focus on other issues / innovations...

What dev wouldn't want this?... And shouldn't users?

Implementation is all open source also of course; Anyone can check commits made / functions in Telemetry.java file for instance; where's the worry here? (Many here happily trusted closed source USNF patreon builds from @kdrag0n because they couldn't wait for public release or simply trust such custom mod devs... Isn't that far more risky?)

I think there may be too many conspiracy theorists among Canary / Alpha users personally... Did they ever make the moon landing?... Surely they couldn't have!... Not without telemetry!!!

Please prove me wrong, but telemetry looks like a boon to me... 😁

... Let's wait and see what John thinks. 😜

🤠 PW
[Magisk] ephemunch:
I have installed Magisk v24 through oldschool zip in TWRP. And after that I found Magisk Alpha and deleted Magisk v24 Manager, installed Magisk Alpha.apk.

Is that bad?

However Zygisk is not activated although I've checked it in Magisk-Settings and rebooted hundred times.

Ah yeah, safetypass failed, root detected although YASNAC, RootBeer, RootChecker are in Denylist.

Since when do you have to install Magisk as awkwardly as it says on Magisk-github?

First time seeing this as I've always installed via TWRP.

But everything seems to be getting more and more complicated.
[Magisk] Stillhard:
i see you have seen their member cards 😍
[Magisk] pndwal:
...Guess you can't download Momo? PW
[Magisk] Stillhard:
Call this OOT, but can someone please write some better words if Canary will clogged with logger here

Like:

No bugs reports required as we have implemented a self reporting bug hunter mechanisme in your device and you don't have to worry about the data it sent
[Magisk] pndwal:
... mechanisme not implemented yet! (Doubt telemetry will cover / double for all types of logs...) 😁 PW
[Magisk] pndwal:
Not if it works! (Nb. Manager is no more - see 22.0 release notes).

What device / ROM / Magisk version?

It's actually Google's Android boot implementations that has got complex (4 basic types now, each with subtypes), and John has done an amazing job analysing and supporting these. 😁

He puts a basic account of how this has affected Magisk init / booting / installation methods here:

https://topjohnwu.github.io/Magisk/boot.html

Deprecated Custom Recovery installation Is affected by twrp implementation which is often flawed. It is also fraught when users use twrp features such as Wipe cache partition (deletes sepolicy.rule) etc.

https://topjohnwu.github.io/Magisk/install.html#custom-recovery

New Patch Image in-app / flash method eliminates these issues and, with exceptions, is also plum necessary for type III (A-only, legacy SAR) devices mentioned in the "boot" document above. (Xiaomi type III devices are generally an exception where twrp flashing is possible.)

🤠 PW
[Magisk] pndwal:
I'd say quite safe...

And you did 'Remove' Riru? PW
[Magisk] zgfg:
Only couple of comments:

- For the (old) devices that have proper TWRP, you can still install Magisk through.

But TJW described the method of patching and flashing back in 2017 (I use it since then), on his Gitthub documentation

It just means that you never bothered to reaad documentation, as so many other users (and also didn't follow what was discussed in the general Magisk thread since then, etc)

-Although it can work (specially now when many differences in Alpha from Canary (Stable) are removed (e.g., up to relatively recently Alpha had different format for magisk.db), but generally Magisk app and Magisk itself come in pairs, and you should be better to run both Magisk app and Magisk Alpha, or both Canary (or both Stable)
[Magisk] avalx:
OK, I'll remove them an see what happens.

And yes I did remove riru module.
[Magisk] bricca:
Hi Prof_Shekhar, now it works, thank you very much! The only thing is that, after following your directions, I also have to uninstall magisk. At this point the bank app works perfectly. The next time the phone is restarted, the magisk icon reappears and if I have to use it I have to reinstall it or uninstall it again to enter the bank application. Thank you very much and have a good weekend!
[Magisk] pndwal:
You mean Magisk App only of course...

Magisk Daemon installs stub to call app if app is missing on reboot.

You should use Hide the Magisk app in magisk settings and select the renamed app in HMA under bank app in 'additional apps invisible' or template and save configuration. PW
[Magisk] ephemunch:
- Samsung Galaxy S7 herolte (Exynos) SM-G930F

- lineage-19.0-20220209-UNOFFICIAL-herolte + BiTGApps-arm64-12.0.0-R45_signed

- twrp-3.6.0_9-0-herolte.img

- At first flashed through TWRP TopJohnWu's Magisk-v24.1 and shortly after that installed within Lineage "app-release.apk" (vvb2060's Magisk d021bca6-alpha

Should I go back to Stock-ROM to flash Magisk through Odin?
[Magisk] pndwal:
Are both Magisk Installed and App Installed d021bca6-alpha (24102), matching?

Also, what kernel version is your LOS 19.1 using? PW
[Magisk] ephemunch:
Installing both at the same time didn't work.

So I tried to install Magisk Alpha while Wo's Magisk v24 was on it. But it didn't work to install Alpha. I then just deleted Wo's Magisk through Magisk Appmanager and then tried Magisk Alpha again. Which then installed without errors. According to the Magisk Appmanager I only have Magisk Alpha left.

But well, Zygisk doesn't work.

Kernel:

3.18.140-ge9bd7e5c868f

#1 Wed Feb 9 10:05:49 UTC 2022

Build-Nr.:

lineage_herolte-userdebug 12 SQ1D.220105.007

eng.ivanme.20220209.095807 test-keys
[Magisk] pndwal:
Bit confused by all that; simply, if the two 'Installed' versions don't match, take Magisk Install (or Update), then direct install to flash Magisk core/mask from App archive. Then they'll match.

Anyway, that's what I suspected.

Zygisk was not working for S8, S7 and some other Samsung devices from the beginning.

https://github.com/topjohnwu/Magisk/issues/5353

This was just fixed in this merged PR 6 days ago:

https://github.com/topjohnwu/Magisk/pull/5372

and was built in last Canary (24102), but fexecve workaround only fixes Kernel versions 3.19+.

A new pinned issue is here:

[Wontfix] Zygisk cannot activate on some old Samsung devices with old kernel (3.19-) #5395​

https://github.com/topjohnwu/Magisk/issues/5395

It is possible earlier kernels work depending on what Samsung added per device (some don't have the exec ELF limitation), but if not working with 24102+ this is undoubtedly your problem.

Issue states your options: "Users with those devices should use a custom kernel bypassing such a restriction or a newer version."

Seems there may be a number of custom kernel options available for S7.

🤠 PW
[Magisk] zgfg:
Sorry but it is all very confusing

Could you simply provide screenshots:

- main window Magisk app

- Magisk app settings

- Magisk app modules

as below
[Magisk] Gamlerr:
do you have a link for both, so I can install or on my op9 pro?
[Magisk] zgfg:
Not quite clear which links are you looking for

But sorry, it's also not clear did you take time to read OP posts in this thread - practically all LINKS you need you should find there

Generally, guys please don't ask for things that are clearly provided in the OP posts. Read, study, before asking (if something is really not clear)
[Magisk] Gamlerr:
for safetynetfix and denylist. I have op9 pro with android 11 but don't know where the links are in these 35 pages thread...
[Magisk] Slim2none4u:
You didn't read ****! Do some work for yourself ffs!
[Magisk] zgfg:
OP posts are only the first handful of posts at the beginning, provided by ipdev who opened this thread.

You could also read post #14

There is no such thing as link for DenyList - DenyList is a feature in the new Magisk app settings - obviously you didn't even try to do your homework

What does it mean, link for Safety Net?!

Again, in the OP posts you have instructions how to set Magisk to pass SafetyNet and the link for YASNAC (to know what is that, you should sgain first study the OP posts)

If you are too lazy to read and learn, or if all that is too complicated to understand, please better stay away from Magisk v24 - for your phone's and your own good (and ours)
[Magisk] Prof_Shekhar:
@bricca

I'm happy that I could help you.

Enjoy your weekend 🙂
[Magisk] ephemunch:
Thx, so without a custom kernel it will probably not work with Zygisk. I have to ask the developer of lineage-19.0-20220209-UNOFFICIAL-herolte which custom kernel is compatible.

Or I'm forced to do without Zygisk and go back to older Lineage and Magisk versions. I don't think there is any other choice.

Thx, I'll go back to stock ROM first until I either find an alternative kernel or then later go back to older Lineage and Magisk version without Zygisk, and btw flash Magisk properly.
[Magisk] HutchGuy:
Does anyone know how to fix this issue? (Please see the attached image)

Things I have installed:

Lineage 15

Magisk 24.1 stable (with hide function enabled to avoid detection)

Magisk modules:

- MagiskHide Props Config

- Shamiko

- Systemless Hosts

- Universal SafetyNet Fix

I don't even know if it is magisk's fault or my roms since I couldn't find ANYTHING on xda or google.

Any solutions?
[Magisk] bricca:
It works! Thank you and enjoy Your weekend! :)
[Magisk] zgfg:
Momo tells you what it finds unsecure (considered unsecure environment for eg banking apps). Your Data partition is not protected by encryption - old ROM. Not sure could it help if you set the Android unlock pin (try if you didn't yet, and reboot). Otherwise, you can not 'fix'
[Magisk] ephemunch:
So I wanted to do it properly with flashing Magisk. As it is to be read here (https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root)

Before this I flashed back Stock-ROM with Odin. And after this I done it like there.

Until here it went smoothly:

After downloading, install and launch it's stuck in Magisk start-screen.

It's latest Magisk Alpha build.

So now it does not even start even though I did as in the Magisk-tutorial for Samsung. The whole day I spent now with magisk.

Ok, now I have wipe & mount-problems with /data.

Oh, I can forget it... :)
[Magisk] pndwal:
Why are you messing with Alpha? PW
[Magisk] asripath:
Currently on stable 24.1.

How do I move to canary?

Uninstall current stable and

install canary apk and then upgrade magisk?

What are the steps to reinstall and retain modules?
[Magisk] Prof_Shekhar:
@asripath

First download Magisk 24.1 app Canary version from GitHub.

Hope you have the firmware for your phone with you. If so, first install the Magisk 24.1 canary and then select the 'patch from file' option under install. Navigate to your firmware, select AP file and patch it.

Now you need to pull your patched AP file from your device download folder, using adb pull command.

Using, ODIN3, flash your patched AP file. System would boot itself. Magisk app will upgrade itself to 24.1 canary version.

Hope, it meets your expectations.
[Magisk] asripath:
Thanks for the info.

Non Sammy,

magisk friendly device(xiaomi Raphael)
[Magisk] Prof_Shekhar:
@asripath

Don't forget to first uninstall your present Magisk 24.1 stable using the uninstall option given in the Magisk app.
[Magisk] zgfg:
I switched from Alpha 24102 to Canary 24102, and everything went ok (DenyList, Shamiko, SafetyNet, Magisk and LSPosed modules, SafetyNet, root grants):

- from the existing Magisk apk, follow the link to Github and manually download Canary (debug) apk

- uninstall Stable/Alpha APK ONLY

(it does not uninstall Magisk, DenyList, Modules, etc)

- install Canary apk

(without uninstalling relesse apk as in the previous step, you could not install this new debug apk)

- Direct install or patch & flash Magisk Canary from the Canary apk

(once the Canary apk was installed, Update channel was automatically reset to Canary)

- Reboot and enjoy Magisk Canary
[Magisk] asripath:
Should it not be as simple as(wishing)

1. Install Canary Magisk APP

2. From installed Canary Magisk App

update Magisk stable to Canary?
[Magisk] Prof_Shekhar:
@asripath

I have told you from my experience as I had 24.1 stable installed but I was not able to get to talk to Magisk 24.1 canary version. I wasted good 3 days trying various permutations and combinations but nothing worked.

Finally, one of the very senior member showed me the correct way to do it.

However, my experience is limited only with Sammy and not with any other device.
[Magisk] zgfg:
I replied you similarly - but probably without uninstalling Stable apk it won't let you install Canary apk - hence that extra simple step that will not affect your modules, DenyList, etc
[Magisk] asripath:
miss the age of using custom canary channel json
[Magisk] zgfg:
Instaling Canary apk will change your channel

It is assumed that you have to manually download Canary apk from Github

Of course, before you uninstall Stable apk - you have link from apk to Github (and channel is irrelevant for your manual download)

But such steps are really trivial, wasting time to describe
[Magisk] ashish1989:
Google play services is unchecking automatically by itself after every restart

I am using v24.1 stable build

And is it necessary to rename magisk with random package name, when we have zygisk now

My modules online list are not loading too
[Magisk] zgfg:
It's been asked/answered through other posts - USNF module removes GMS from DenyList, but don't worry about

Do you want/need to hide Magisk app? - It's up to you and your banking apps (some look for Magisk app but for some even harder hiding by HMA is required).

Nevertheless, hiding Magisk app is irrelevant for passing SafetyNet (SN does not look for Magisk apk, end never did)
[Magisk] ashish1989:
So should I remove usnf module then
[Magisk] zgfg:
I said don't worry (about its removing of GMS from DenyList - it does its job)

If you can pass SN without USINF 2.2.1, then remove (some custom ROMs integrate USNF functionality to their code, hence USNF for them is not required) - but if you need USNF to pass SN then obviously keep it
[Magisk] musicalmindz:
I've Googled a ton and read most of this thread but can't find anything about tethering. The existing Tethering Enabler Magisk module seems ancient and not sure if it works on v24. I already installed this but doesn't seem to help: https://github.com/cyborg-one/nfqttl

Anyone with tips on how to hide my tethering from my carrier?
[Magisk] alecxs:
so Magisk v23 is the final NG release - can we expect still troubleshooting support if we stay on? where is support thread v23?
[Magisk] hungtinglung:
if tehering on,and cannot surfing internet at another device connect to the hotspot.

just change the APN.

then it will be normal again.

it happen at my mobile internet provider.
[Magisk] zgfg:
It's questionable what do you mean by support

This thread here and the old one Magisk General thread are run by users (like you) who help one to the other. Magisk developers are not participating (except, very, very rarely, some of the collaborators)

However, this thread was opened for the new Magisk v24+, hence for v23 please use the old Magisk General thread

If you want to report bugs to the Magisk developers (hoping for the fix in future releases) - you have to use Github.

But pndwal opened one issue related to v23 and it was immediately closed, saying they don't support the old Magisk

I.e, if you stay on the old Magisk v23, do not expect any hot-fixes (like support for new devices and Android versions) or so.

Use, as is, if it's good for you, and expect that over time less and less users will stay on, hence there will be less peer users in that old Magisk General thread to help/support
[Magisk] musicalmindz:
I can connect on my other device sometimes but at some pointmy mobile provider notices and I get a warning saying "Purchase a plan with tethering". I had no issues with Magisk v23 tethering on my old Pixel 3. Anyone got any tips?
[Magisk] DuskGolem:
Hello, so I tried again the latest magisk canary build on my Samsung A8 2018 (latest stock 9.0 rom) and it works as mentioned in this thread and on github.

Now I am getting the following reponse in momo app.

I am aware of selinux and art modifications not being hidden on samsung phones issue. About the remaining two;

1) the "found magisk or twrp files" detection is due to twrp folder in /sdcard being detected. What is the best way to hide it without deleting or modifying folder name since I use custom twrp theme and they are placed inside that folder.

2) the "data not encrypted" prompt is for obvious reasons. Now I would like to know how to get data encryption with magisk, dm-verity is not needed. If someone is using this config, do let me know the basic steps to use magisk with encrypted data and no dm verity.
[Magisk] zgfg:
C'mon everybody to the new party
[Magisk] Spartacus500:
This is new version 🤔
[Magisk] Spartacus500:
@Adil Tariq

Hide TWRP folder like this ".TWRP"

Selinux modified by Magisk like you, waiting and looking for a solution to hide it.
[Magisk] alecxs:
2) on samsung devices one can't have encrypted userdata along with TWRP (lack of encryption support) - however there is one deviation maybe can reproduced to other samsung models as well

https://xdaforums.com/showthread.php?t=4054225&page=5
[Magisk] rodken:
What would be the purpose of this versus utilizing 'Hide My Applist'?
[Magisk] zgfg:
To learn how to configure HMA
[Magisk] sir_overthrow:
Lineageos 18.1 security patch 2022-01-05

Just restarted the terminal, with yasnac, the safetynet passed, but after a two minutes, it doesn't passed . and I can not even see the internal storage of the mobile. Does someone know how to solve this problem? Thanks in advance.
[Magisk] pndwal:
You just took OTA or downloaded update? ... Did you download update package and extract / Magisk-patch / flash new boot image? PW
[Magisk] sir_overthrow:
Lineageos 18.1 is updated every week. Even if I reinstall Magisk safetynet, configure props, it only works first few minutes after boot. I can use deny-protected apps, but I can't see the internal memory.
[Magisk] martyfender:
I see the commits for this new version on github, but not a release newer than 2.0. Where did you download it?
[Magisk] applesucksLmao:
why the heck is magisk killing a32 4g and 5g? after some time they get unknown baseband
[Magisk] pndwal:
I'm just trying to understand; is root gone after LOS update? If so, how do you restore it? PW
[Magisk] neilth:
I have a Pixel 2XL running LOS 18.1 configured with the latest Magisk 24.1 software. I did the weekly update last Thursday and everything is still working as before. Installing the update caused no issues whatsoever. Both root and Safetynet are still intact.
[Magisk] m0han:
i'd like to know too. besides, there are differences. how come? (btw, i got the apk from hma telegram channel)

also, https://xdaforums.com/t/discussion-magisk-the-age-of-zygisk.4393877/post-86392221

edit: adding another comparison screenshot
[Magisk] DuskGolem:
Like I said I can't do that since TWRP looks into that folder for custom theme zip files and I am using a custom dark theme. Just checked to verify that renaming twrp folder as ".twrp" makes it invisible for twrp to use themes.

More like this if I understand correctly, I can encrypt data and have magisk installed (patching the AP.tar.md5 instead of boot image and flashing it in odin) just no twrp in this case. However, this method is targetted for system-as-root samsung devices and my A8 2018 has its ramdisk in boot.img instead of being merged with system.img. Also I doubt that dm verity will allow me to boot a modified AP.tar.md5 without disabling it first somehow (maybe customizing the stock firmware beforehand).
[Magisk] zgfg:
Mine is

Applist Detector v2.1

icu.nullptr.applistdetector

What is your one?
[Magisk] alecxs:
Magisk will and always has supported samsung encryption. patching whole AP_*.tar.md5 is official rooting method for samsung devices and will work along with dm-verity. TWRP doesn't.
[Magisk] DuskGolem:
I am aware of that. What I meant by dm-verity not permitting boot of modified AP.tar.md5 was, I usually remove system apps (minor debloat) using twrp, and am using a few buildprop tweaks, cscfeature.xml and floatingfeature.xml tweaks and also little init script to keep nav bar color black at all times (I use dark mode overall but since some apps do not modify navigation bar color hence I found this method to be working, also it persists after reboot since it is essentially an "at-boot" running service). Is it possible to use these tweaks without twrp, like directly modifying stock firmware files and still keep dm-verity? I don't think it's possible.

On the contrary, may be a magisk module for these tweaks will solve this problem.
[Magisk] pndwal:
Sorry, double-posted...
[Magisk] pndwal:
It's in Alpha thread here:

https://t.me/c/1414270883

But apparently we can't link files hosted there on XDA. (I commented on recent mod ruling

here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86412945 )

Anyway, hit group heading and you'll find 2.1 version under 'files', near top of list if you have access... or find the post from HMA dev @nu11ptr today at 1.11 am. 😛

No idea why only 2.0 is on GitHub... Only 2.0 on HMA TG group also... Alpha channel does seem to be becoming a popular place to release early Shamiko, Applist Detector etc... PW
[Magisk] beeshyams:
Thanks to @zgfg , who gave pointers on how to configure HMA, I wrote up on that which may help others reading this thread.

I hope it's not against the rules to link from outside XDA

Bypassing advanced root / modded framework detection

In the past,solutions for preventing root detection were centered around safety-net, Magisk hide or XPosed modules like Sudo hide. With Magisk 24.1 plus Magisk Hide isn't an option and modules like...

android.stackexchange.com
[Magisk] Oswald Boelcke:
I've removed the link from your above thread. It seems to me that it's unnecessary to make you aware why as you permanently show you are aware. Please rethink your intentions.

Regards

Oswald Boelcke