yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] GROOVYJOSHCLARK:
I do not have this DTBO question, nor do I have bootloop issues, and if your only end goal, is to have ROOTed ROM with MAGISK (ROOT working with safetynet) plus MAGISKHIDE enabled, its super easy and stable, this is how I do it, and it works perfectly.

-ADB TWRP (I do not install TWRP)

-FROM TWRP, FORMAT partitions

-REBOOT to BL

-ADB TWRP again (still I do not install it, no need)

-INSTALL ROM (I used the GAPP'd version to make it easier)

-Boot to OS, configure or setup

-(boot.img can be ROOT patched at any time)

Boot to OS, install MAGISK canary, extract payload.bin from ROM zip, use python to extract boot.img from payload.bin, open MAGISK canary, select install, select patch boot.img, browse to the boot.img python just created, patch it, then enable MAGISKHIDE in the manager (may need to reboot OS for MAGISKHIDE to show up, but it will once you are running the modified BOOT.IMG with MAGISK), reboot to BL, fastboot the new boot.img you just patched (you have to transfer it from droid to PC so do it before you reboot to BL - I.E. bootloader - or you will have to ADB pull but its easier from OS), and boot (start from BL), now you are now ROOT'ed with MAGISK hide enabled.

Here are the commands needed, you will need python 3.8 and the payload_dumper.py script:

fastboot boot twrp-3.4.0-0-taimen.img

payload_dumper.py payload.bin

fastboot flash boot magisk_patched.img

View attachment 5107627

View attachment 5107629

View attachment 5107631

I would also add, dont rename MAGISK, it is never detected for anything I use (and I have client banking apps, multiple MFA tokens, multiple DUO profiles, ETC) and MAGISK itself is never detected, but not having MAGISKHIDE enabled, breaks CTS (safetynet). Enabling MAGISKHIDE is enough for safetynet. Only rename MAGISK IF you have a SPECIFIC requirement to do so.

Here is my DUO profile security checkup, notice it shows I am clean as a whistle, but I am ROOT'd, this is ONLY possible with MAGISKHIDE enabled, then DUO is hidden. I do NOT hide the MAGISK app itself, only the apps within MAGISKHIDE (like DUO, my exchange email client, and so on, my work has no idea I am ROOTd). DUO does a health check for security on ROOT'd devices, mine is clean, BECAUSE I hide ROOT from DUO:

View attachment 5107633

I suspect your issue is with renaming (repacking the MAGISK app), dont bother, just enable MAGISKHIDE then hide the apps from ROOT you dont want detected (like banking apps, exchange apps, and so on).
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] AndroidClone:
You have no Idea how much I appreciate your thorough, concise and complete guide. I figured out what the issue was and it is magisk manager not showing up as canary even though I flashed the debug canary build. I had to manually add the canary URL as Custom for it to upgrade itself. Only stable, beta, custom available. https://github.com/topjohnwu/magisk_files/blob/canary/debug.json is the URL for anyone that runs into this issue. I used python to unpack the payload as decribed and loaded the patched boot image without an issue.

Thanks again [MENTION=6423569]GROOVYJOSHCLARK[/MENTION] :cool:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] GROOVYJOSHCLARK:
My pleasure! Glad you sorted it out and I could be of some help!

If I could offer just one more piece of advice, I do not have to modify URLs for canary (or stable for that matter), I only have to download the latest canary version from GitHub then install and perform the steps I laid out previously. My hunch is you had an older version that didn't work yet with 11, so you needed to manually apply the URL for canary repo to see the updates. That's my best guess, as I do not specifically know your version of magisk canary used, but I didn't have to modify anything URL related to get it working, I simply used the most recent version found on GitHub. I will also note, the GitHub service (download) failed almost every time with not found errors (one can only assume devs were updating the canary app/repo at the time I was trying) so that may be part of why yours was so outdated (unable to download that latest from GitHub) but again, only a best guess. It took me a few tries to finally get it working, I can post (upload) the version I used, if needed.

Here is the current version and what I downloaded and used:

View attachment 5107887
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] GROOVYJOSHCLARK:
I am definitely glad I made the jump to LOS 18 (Android 11), I am really liking this OS! No bugs really (except for little ones here and there, like profiles in settings), but who care about that?! Any other bugs that may exist in the ROM, I cant seem to find! I tested every aspect of this ROM as thoroughly as I possibly could and aside from the settings/profile, I dont see any other bugs! This ROM is running smooth, fast, and decent battery life (although I didnt get as good as I did with 10), so I tested EX Kernel after using the stock one for a few days, EX seems to give me longer standby so its working great for me! I thoroughly endorse this ROM and recommend anyone reading these words to try it, definitely try it! Its good and only getting better! This is my new daily driver without a doubt.

Eamo5 I owe you a beer/coffee! Keep em coming, you are definitely doing the Pixel 2XL community a huge service by providing these for us, and I for one, am extremely thankful!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] 73sydney:
Installed to test just now...doddle

From current ROM (BlissROM):

backup userdata (anything you love on internal sdcard)

adb reboot bootloader

fastboot format userdata

fastboot boot twrp.img

adb push lineage-18.0-20200928-UNOFFICIAL-taimen-gapps.zip /tmp

adb shell twrp install /tmp/lineage-18.0-20200928-UNOFFICIAL-taimen-gapps.zip

adb reboot system

-once at setup screen on device:

adb reboot bootloader

fastboot boot twrp.img

adb push magisk-xxxx.zip /tmp

adb shell twrp install /tmp/magisk-xxxx.zip

adb reboot system

-setup ROM

Magisk manager installed automatically (sometimes you need to install manually)

CTS pass out of the box, nice.....

get on with life

only test for me (that failed on stock 11 - Migrate needs some work) will be seeing if restoring from my migrate backup works

ROM looks good so far thanks dev

Okay thats not super annoying, cant get google asssitant to work full time (voice match) because its installed as a user app (needs to be a system app), because its not included in the ROM with the gapps build. Grrr, so theres a minus right there. Guess ill try finding an 11 gapps package and trying again in a few days....

Trying Migrate restore

remove PIN

adb reboot bootloader

fastboot boot twrp.img

flash Migrate zips - ok

reboot

run Migrate Helper

Split APKS again failign to be restored - failing verification

Not the ROMS fault this one, but yeah, Android 11 showing it needlessly breaks stuff again

Back to Android 10 again, for now...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] GROOVYJOSHCLARK:
I am not trying to start a battle or debate with you, but what doesnt work for you? I was on 10 for a long time, then found LOS 18 (this ROM) and moved over to it, there is not a thing that doesnt work and would need 10.

My 2 cents, you are WAY overthinking and WAY overdoing the install process, it does not have to be as complicated as you are doing it. ADB boot TWRP, install ROM from TWRP, wipe partitions from TWRP, format /DATA from TWRP, then patch boot.img and ADB it for MAGISK install/ROOT. No command line needed for the entire install process (only when you ADB MAGISK boot.img and BOOT TWRP or push files after formatting /data).

Google Assistant works, but what issues are you having? It detects everything I am saying, or do you mean its not coming up when you say OK Google (please elaborate):

View attachment 5108769

View attachment 5108771

No idea why you are restoring data that way, I havent seen migrate scripts work across OS versions in quite a few release versions (again way over complicated for no reason). You'd be better off using TiB, and do as I do, copy the entire SD to PC prior, and back after, this covers your SD Card /Android directory and all configs (user specific configs/cache/files/ETC), then TiB anything left for app data (or allow Google's restore app function to do whatever is compatible). You only need to restore the app data (not SD Card /Android) but the actual app data using ROOT methods (which there are a zillion options out there). TiB works flawlessly for this piece, I restore all my apps (200+ at least) using TiB then my apps are as they were before I moved ROMs, and reconfigure anything like my MFA/DUO profiles as they cant be restored.

I am a longtime dev, long time Senior Sys Architect, and the one thing I tell all my engineers under me, K.I.S.S, Keep It Simple Stupid (not calling you stuipid), but keep it simple and easy. Dont over complicate things just because you can, especially when it doesnt work. Instead, find better, more robust methods and use what works, not scripts, and shortcuts that are designed for other devices, ROMs, OS levels, ETC. I have not successfully used a restore zip like you are trying to use, in many many Android versions (like JB I think), use TiB, and you wont have an issue!

Take or leave my advice, Its fine either way, and I am NOT attacking you at all. Just pointing out a few things, and my reply is more geared towards others who may read it and fear there is something wrong, then miss out on this fantastic Android 11 ROM!

Final thought, with the latest TWRP, you do not need to remove PIN, it decrypts /data now. Make sure you are using the absolute latest TWRP.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] amandeepparmar:
If you guys are done writing essays, can we please get some peace, testing and real development going on here during such a horrible pandemic time? Much love, respect and appreciation to both of you.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] KennyG123:
Thread cleaned of posts containing name calling

If people want to debate factually with out disrespect, please feel free

Rule 2.3 needs to be adhered to

Be respectful of others in this thread that are reading

Thank you all for your cooperation

Friendly Neighborhood Moderator
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] GROOVYJOSHCLARK:
Thank you!

Now if we get back to it and helping users, I'd be happy. My one and ONLY follow-up point is to follow the OP steps. Don't change or add steps to the process until you test the OP steps and get them working first. Then you can get fancy with the process but first, get it working by carefully following the steps. The OP steps are laid out by the dev for a reason, they work and are tested!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] 73sydney:
For the record my information as previously posted was 100% factually correct, every line and comment, and users can use the steps provided if you want an easy way to install the ROM and magisk.

Again, and very clearly, as already posted, my issues were not with ROM, but with issues brought on by Android 11

Thanks again to dev, hoping to revisit soon when the few issues with Android 11 and the main apps i use are cleared up
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] AndroidClone:
[MENTION=6423569]GROOVYJOSHCLARK[/MENTION] is android auto working for you? App is not launched when connecting through USB on my Mazda. Also the google assistant is broken even after systemizing it through terminal. Microphone listening seems to be broken. I can only use the voice assistant if I physically open the app.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] KennyG123:
Thread cleaned again!

As [MENTION=9317193]73sydney[/MENTION] just made it clear he has no issue with the ROM but with his chosen apps and Android 11 I suggest he take this to the Q&A section to get help with those apps.

I strongly urge members to use the "Ignore user" function of vBulletin to no longer see posts of other members that offend them
[MENTION=6423569]GROOVYJOSHCLARK[/MENTION] it seems he does not want your help at this time so please do not respond further to him

Thanks for all your cooperation

Trying to remain your Friendly Neighborhood Moderator......:rolleyes:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] KennyG123:
Android Auto has major issues with Android 11 as reported to Google. What you described is exactly most of the issues.

Android Auto not working on Android 11 properly
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] GROOVYJOSHCLARK:
MOD EDIT: Removed comment

[/COLOR]

I'll have to check on my son's car when I see him next, my Jeep is to old and doesn't have the function but his does. It probably won't be until next week (he's in med school so I barely see him anymore) but I'll do my best to confirm it for you.

Android Auto is optional for me and not embedded into the ROM, so I don't consider it part of my testing. I'll add it to the list since it keeps coming up and start testing against AA and the ROMs. I'll start to test AA when I report on ROM successes.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] AndroidClone:
Thanks for the update. AA is working on the latest 11 ota.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
Hmm, so go and try it and write a report with more details here. I am currently running LOS18 on a Samsung S5/klte, a Pixel2 and a Pixel3 togehter with LOS and TWRP recovery. Never had any real problem with LOS since version 14. The LOS Maintainers are working very accurate they do a very good job in supporting their "babies"! i will stay with LOS !!!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Strephon Alkhalikoi:
I've never had to do this and still have root after the update. I believe Magisk has scripts to restore root after an update.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dcarvil:
Sorry, my wording could have been better. You are correct, Magisk has scripts to restore root after an update. What I was trying to say is you need to install the full Magisk package (not just a patched boot image) to install those scripts. I didn't mean to imply "adb sideload" was the only Magisk installation method that installed those scripts.

Actually, this may be moot now that Magisk is packaged as an apk instead of a zip. I would expect installing the apk would also install those scripts.

Just out of curiosity, what installation method did you use?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Strephon Alkhalikoi:
Renamed the APK to ZIP and flashed via TWRP. That installs the scripts, but I seem to recall that method only installs stub files, which you have to update upon opening the Magisk app itself in Android.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dcarvil:
Yes, I think you still have to update upon opening Magisk when using the "adb sideload" method. The end result is the same using either method.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ViperX85:
Is it just me or it's not possible to pass safety net (CTS) with this ROM? I tried everything but safety fails every time.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wbgenetic:
Any idea why some banking apps don't work?

Me and my wife run a pixel 2xl.

I use a bank app (UBB) and it works fine.

Hers does not work. It crashes on the login screen (before logging in... UNICREDIT BANK)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dcarvil:
SafetyNet passes for me with Magisk 23.0 and the modules Universal SafetyNet Fix, MagiskHide Props Config. I don't know if it will pass without Magisk and those modules.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ViperX85:
I have all of those. Can you share your props config?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
Some more config details might be helpful. i am using the ING banking app on my Pixel2 without any problem. Beside this, 2 other german banks tan generators are working as expected. I have the pure LOS Rom including the LOS recovery installed. No gapps and no root (magisk). As far as i understand, most problems with banking apps have their origin in rooted phones as the apps are checking for traces of "rooting" software.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dcarvil:
I can share it if you can tell me how to do it. When I go to props option 1, it says my current fingerprint is "Google Pixel 2 XL".

My Universal SafetyNet Fix version is 1.2.0. It is not the latest, but it works for me.

You can find a lot of fixes for SafetyNet in the Magisk support thread at https://xdaforums.com/t/magisk-general-support-discussion.3432382/. I'd stay away from any fix that uses Magisk Alpha, though. Alpha is very unstable.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ViperX85:
Ok, since we're taking about universal safety net fix I went again in the props settings and choose Pixel 3a this time as my current fingerprint and now it finally works.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wbgenetic:
Well the phone is not rooted. I actually thought I might play with magisk and some modules trying to make it work.... We are running LOS 18 with twrp (not installed). Gapps are loaded though.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
I have heard that the installation of any root tool may leave dirs/files in memory and some apps are checking for them. This might be a reason why they will not work. Additionally i have heard about some workarounds to rename those folders and tools to "hide" the root tools traces :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Greenmirage:
Hi, I followed your advice and changed the fingerprint to 3a. My safety net now passes allowing Google pay to work but now my banking app is detecting root. BEFORE I got magisk to try for Google pay, the app worked fine on lineage. Seems like every other app I've thrown at it works fine though. I'm using the safety net fix 2.1.1 & magiskhide modules. Any ideas?

Edit: I take it back Google Pay doesn't work, it just temporarily seemed to allow me to add my card but it's not working due to device not showing as certified in Google Play :/

Seems like my options are - go back to stock & stop receiving updates but have google Pay. Or go without google pay & continue w lineage & updates
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mosio:
Works for me, but I had to go for the XPrivacyLua pretty complex solution mentioned in the universal SafetyNet Fix thread. Now Gpay works as intented.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mosio:
Just updated to Sept 30th build using the built-in updater and I still pass SafetyNet check and GPay is still up and working.

Btw: Any idea why my Google Assistant won't react while the phone is locked with display off?

I have that functionality enabled and it works when I turn the screen on using power button.

Is that stock Pixel rom specific behaviour?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
i just updated to build 20211012 coming from 20210914. Config ist Walleye, just pure LOS including LOS recovery, no gapps, no magisk/etc. All good, No problems so far.

@Eamo5: Thx for keeping the Pixel 2 familiy alive!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Hawkeye77:
It's such a shame that other ROMs can be supplied and pass safety net (CTS) but this one needs Magix.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Greenmirage:
Is your device certified in Google play or is the XPrivacyLua solution some sort of solution to hide that? I may look into it but I feel the more I do to tamper, the more things usually end up horribly wrong and unstable LOL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mosio:
It is certified in Google Play. I recommend this solution, as I still pass the Safetynet after update, can use Google Pay and MS Intune to use MS Teams for work on the same device.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] runekock:
Well, it's LineageOS policy not to cheat Google's security. In this case, Google correctly detects that the phone has been modified. While I disagree with Google's position that modified phones are unsafe, I understand LOS's choice: as the most visible custom rom, they cannot allow themselves to get on Google's bad side.

BTW, it might be possible to pass Safety Net by relocking the bootloader. Not that I recommend that; I don' t feel certain that you'll be able to fix a bricked rom with a locked bootloader.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
After some days of usage i recognized significant less battery drain with build 20211012! Same like the 20211010 for the Galaxy S5(klte).
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] vatva69:
relocking bootloader only possible on stock rom, with custom rom you will brick your phone
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zpunout:
Relocking bootloader on Pixel devices is possible for some custom OSs. I've personally relocked the bootloader using GrapheneOS and CalyxOS. I also heard that ProtonOS supports that feature. I don't know about LineageOS if locking the bootloader will brick the phone. I would be interested to know despite reading somewhere that official builds of LOS and LOS recovery are user_debug mode builds.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
i never relocked the bootloader since i unlocked it on my P2. Normally i do a socalled "clean install" once a year when a new LOS version goes into "official" state. i dont like any additional work during that process. I am wondering if there is a similar process of upgrading a LOS recovery version to a newer one as this is possible in TWRP to flash from a lower version to a higher.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zpunout:
I thought OTA LOS recovery version updates would be possible by setting the checkmark in the initial setup after a clean install. I can't say specifically for the Pixel 2 build though as I've never installed LOS on mine, but other devices I've installed LOS onto have this option. Since Pixel 2 is designed with an A/B partition setup, I would assume the recovery updates to be part of the seamless update process.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
Yes of course, you are right. i set this checkbox too, forgot to mention that. But if there is a new LOS version lets say 19.1 we need to update the recovery first and the flash the ROM. With TWRP you can use the old/existing TWRP to flash the new ROM. And you can use TWRP to update itself. So using TWRP there is one step less to install a new ROM.

That leads me to the old question which recovery is "better" :) if you need the backup function take TWRP. if not i think LOS recovery is the best solution because it "fits" better to the LOS ROM ??? Is this true - or possible? TWRP is a "Third party" product, is it as good as the LOS recovery is?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zpunout:
Oh I see. Yeah the pros and cons of choosing a custom recovery. For me, I'd probably stick to LOS recovery only for the OTA updates to work. Then when it's time to change to LOS19, I'd do a clean install. If OTA isn't a big factor in deciding, I could see why TWRP would be good to use with its extra features.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zimral.xda:
On my development Galaxy S5 i use TWRP since several years now and the OTA updater runs fine. As far as i know the only prerequisite for using the OTA is "...a working recovery environment". And with a standard TWRP this is the case. We will see it next spring when LOS19 goes into official, i can do at least 4 clean upgrades on my devices.... 🤡 💪🛠️⚙️
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zpunout:
I didn't know that. Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ralfbergs:
This ROM abandoned support for the Pixel 2. :-(