yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
This is how open source should work. Thank you very much for your contribution. This is much appreciated. I did some minor fixes and changed the FAQ!

THANK YOU VERY MUCH!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Sradgads:
I'm already at G970FXXU7CTF1, should I just wait for RC1?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gonzo202828:
Does the installed official device firmware have any influence on how the rom works?

Or is it just a neccessary step to install lineageos?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] exxxtreme:
SD card encryption

First of all, thank you for your work on this, and especially for the great instructions for installing the ROM (I've been struggling with installation of other ROMs on the S10e, with instructions spread over a number of threads :( ).

I just finished installing your ROM, and after doing a bit of discovery, I realized I don't know how to encrypt the sd card. Is this supported? I am happy to either use the SD card as internal storage, or portable, either way would be fine if I can get it to be encrypted.

Thank you in advance
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
Using it as internal storage should encrypt it, but I'm not 100% sure. I've never tried it.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
RC1 is out

New Kernel and performance improvements through new power HAL!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
You're welcome, and indeed this is how open source should work :D

I'll probably add some more details once I've set up my phone completely (I still need magisk) and later after the update, if I think it would be helpful. You'll still have the option to only merge the parts you like.

Will add that to the FAQ by the end of the week, thanks for the info :)

Its out now :)

It's hard to deliver (nearly) bug-free software for anything, but it becomes ridiculous if you have to test multiple versions. There might be some low-level hardware drivers that are not included in the ROM and thus some hardware might not work. (Based on experience of the redmi4x, if you didn't update the firmware before flashing, the sensors wouldn't work).

I planned to use veracrypt to create an encrypted container on my microSD and use EDS lite to access it. With this setup you could access data on a PC as well, if you have the password.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
My S10 arrived today, so after much unlocking rigmarole, just flashed RC1 onto it. Installed OpenCamera v1.48.1 from F-Droid. Set the Camera2 API. Four cameras are detected according to the version page, two for back (wide and normal), two for front (zoomed in and normal). I'm not seeing the telephoto lens at all.

Am I missing something? I thought maybe if I adjust the zoom for the normal, maybe it switches camera used? I tried sticking my finger over each back camera. Definitely the middle one is always being used for normal, no matter the zoom chosen. I'm probably being stupid, do I need to change a setting in OpenCamera or something?

Edit: Just to be clear, if in OpenCamera you open the drop down settings and choose Aperture F/2.4, it does NOT change the camera used. You can test this using your finger. Some online sources say this can happen due to insufficient light, I tried this outdoors in a sunny day with direct sunshine.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] okloloi:
First of all, thanks for all the work on this rom! Been running since beta 2 with no real issues.

Just some info that might help others when updating to CTF1 firmware, I had to add the vbmeta_disabler.img into the tar with the dt.img to boot.

I was using odin so no idea if heimdall has any issues with updating.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] nten2:
Hello! how to run gpay on this firmware
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
Welp, I do only have the S10e and because all 4 cameras worked and I knew open camera supports all 5 on stock, I thought all 5 should work. Sorry for the confusion, totally my fault. So thank you for reporting this issue. One question: If you go to opencamera/settings/about, does it report 4 or 5 cameras to you? [MENTION=4297219]modpunk[/MENTION] can you please change the FAQ and take a look at the issue?

Both aperatures (1.5 and 2.4) are done with the main camera. At 2.4 you will hear a small click and see that the physical aperature is smaller. Unlike the telephoto I've tested this on my S10e and it works as intended (on beta3).

Thank you for this feedback, I'll add this to the next revision of the FAQ.

I'm not sure if it's possible. If you try methods intended for other ROM (at your own risk) and find one that's working please report back.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
No need to apologise. It's very hard to accomodate hardware that you don't have access to.

I trawled through the OpenCamera issue tracker, and from there it seems that OpenCamera uses whatever the OS tells it. So I suspect that the cause is that for the S10 build, a single line in some props file somewhere has the S10e setting, not the S10 setting.

In the About screen which is a big long wall of text, it says "No. of cameras: 4"

If you cycle through the back cameras, camera id 0 is the normal (middle) lens; camera id 2 is the wide (closest to volume button) lens. That suggests to me that camera id 1 ought to be the telephoto lens. I don't know if that helps figure out what .prop file to fix.

Aha! Yes, if I look at the back of the phone and toggle the setting, the camera's apeture visibly changes size. The reason I didn't see this before is because of that sunny day, I assumed surely a darker image would result. Thanks for the tip.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fishnetfancy:
Thank you for your amazing work on this ROM. I have just updated from Beta 3 to RC1 and can confirm that removing pin/password/pattern prior to flashing works and does not trigger the one day delay

FYI: When removing the lock feature all store fingerprints are erased as well.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
The IDs 1 and 3 are associated with the front camera and it's crop mode - so I'd guess the telephoto should be ID 5. Because only 4 cameras are detected, it is likely that the issue lies somewhere within this ROM - the question was just ensure that it's not an opencamera bug.

The camera hardware changes ISO and shutter speed to get a correct exposure. A larger aperture (f1.5) will let in more light (which is great in dark environment), while the smaller aperture (f2.4) will let in less light, but give a larger depth of field (ie. more stuff is in focus). F2.4 will also only use the center part of the lens where production tolerances are better and thus the image should be slightly sharper, especially in the corners. For general purpose f2.4 is better imho, but unfortunately opencamera selects f1.5 as default after starting and does not automatically switch based on light conditions...

The difference is not huge though, only about 1 f-stop, meaning that the smaller aperture will let in half as much light. The rule is: double f-number (eg. f4.0 -> f8.0) lets in a quarter of the light. If needed, one can look up tables eg .on wikipedia.

It's worth noting that the background-out-of-focus depends not only on the f-number, but also the chip size. This is the reason why phones have to cheat in software to get portrait-like shot with out-of-focus backgrounds. If you're curios you can try out the difference between the cameras and the f-numbers in this online DOF simulator. I've added the 4 different settings (ultrawide, wide f1.5, wide f2.4, tele) and a bunch of possible settings based on a low end Canon DLSR as a comparison.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fishnetfancy:
Same with S10+ using OpenCamera with API2. S10 Plus supposedly has three rear and two front-facing cameras.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
That's great news, thanks! I can't edit modpunks post, so we'll have to wait for him to update it.

Yeah, it's a side effect because afaik the pin/password/pattern is used as a master key and the fingerprint just as a weaker alternative key. It's still faster to set up the fingerprints then to wait that day. Which resets btw when you turn off the phone. Guess how I found that out. :silly:

---------- Post added at 09:10 PM ---------- Previous post was at 09:03 PM ----------

The second front camera is an 8MP depth sensor and can't produce an image on it's own. Samsung merges the extra data in their camera app to get the out-of-focus background. I doubt that lineage/opencamera has a feature like this in the near future. (detaild device comparison, including cameras)

Like the S10e and S10 the front camera is a "wide" 26mm lens. In software it gets cropped to offer a "second" camera option with a narrower field of view, but all it does it throw the extra pixels away.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
There is an AOSP camera API for getting the ID and a Samsung one. If I add a shim to use the samsung one we get more IDs but they report errors when switching to them. Help is welcome to reverse engineer this, just contact me :)

Code:

https://github.com/cryptomilk/andro...mmit/23be7ab0ab5ab9aa758e7f25cc49a11265663634
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
Testing it there now:

Id 0: Back normal lens (centre)

Id 1: Front lens cropped

Id 2: Back wide lens (closest to volume buttons)

Id 3: Front lens full

So I'd suggest it would be Id 4, not Id 5, which ought to be the telephoto lens.

:( ... though, in the end, now I know I must do it manually, that's okay with me.

You're getting me interested in photography once again! Back before children, when I had the time, I had a lot of fun with that stuff. Since, well if I'm not sleeping or working, I'm on childcare.

Thanks for all the info, it's useful. To be honest, this new phone is because my current HTC 10's battery is nearing end of life. I chose the S10 purely based on not being wider than the HTC 10, lineageos availability and cost (less than 500 euro, new, just recently) rather than any other factors. These cameras look like they'll be a large step upwards from the HTC 10's, which was pretty good in its day for a smartphone. I'm feeling excited.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] angela5246:
[MENTION=4297219]modpunk[/MENTION], thanks for the new release. It seems the update brings two regressions (tested on S10e):

1) DT2W doesnt work after reboot

2) Rebooting into recovery doesnt work. Phone goes straight back to Android instead of TWRP

3) Reboot or shutdown takes an exceptionally long time. Like 30 seconds.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] florek_18:
Probably somebody answered already but I have a problem. I have proper twrp of course, checked verify zip. During installation I have no problems but when I reboot system it keeps rebooting back to twrp.

Anyone ? Please help
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fishnetfancy:
procedure to get Magisk back after ROM update

Apologies if this has been explained before but I couldn't find the answer.

Upon upgrading to RC1 and rebooting I realised that Magisk was not installed anymore. I tried to boot into recovery but the phone will now always boot into the system. I also can't turn off the phone - again it will just reboot into the system. When I launch Magisk manager I can download the Zip but the installation fails.

I did follow the upgrade guide on the first page but am now stuck and don't know how to proceed - any pointers in the right direction are much appreciated!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] chiragcqc:
Hi i installed your version of lineage but im facing an issue when i turn the device off and try to charge the device it keeps restarting can someone please help me i cant even power off the device and it when i left it for 10 minutes it just froze do you think installing magisk could be the reason for this issue
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] chiragcqc:
hi can you please tell me how to fix phone off charging issue i am using the latest version thanks
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] :
You have two problems.

1. You did not flash the the magisk boot image for rc1. You always have to flash the magisk boot image if you update the phone.

2. LineageOS comes with an own "su". After updating you have to mount /system with twrp and rename/remove the "/xbin/su". Otherwise Magisk is useless for much banking apps.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
1) Fixed, see https://review.lineageos.org/c/LineageOS/android_hardware_samsung/+/280570

2) The strange thing is that it works with `adb reboot recovery`

3) Likely the same problem as 2, I first thought it is the kernel, but it could have to do with the power hal or a bug upstream.

2 and 3 are caused by the new power HAL. Now we need to track down what is causing this.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fishnetfancy:
[/COLOR]

I did not realise I had to flash Magisk after an update. Could you please put a line into instructions on p.1 to remind people to (optionally) update Magisk as well?

As has been mentioned due to power HAL bug the only way to boot into recovery at the monent is via adb. After that it's simply a matter of pushing the correct Magisk image to the phone and installing to BOOT via TWRP.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
Bug in RC1 when registering fingerprint unlock

When first registering your fingerprint in the settings, if you press and hold your finger on the reader for "too long", some weird error box pops up, the settings page crashes, and then the fingerprint circle overlay won't go away and prevents any pressing of keys on the keyboard underneath it until the device is rebooted.

If you don't hold your finger for "too long", everything works fine. Otherwise the fingerprint reader seems to work very well, I haven't noticed the lag some said is a problem with the S10.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] florek_18:
No help with that I guess :rolleyes:

From my side it looks like there is no os installed after installation but twrp doesn't say it.

Also, not that I'm complaining but why every other rom installs normally like that: download, go to recovery, install, reboot. That's it. No different twrp needed, no zip verification, nothing else... Here it's not the case.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Ivo_Todorov:
I'm on the verge to upgrade my firmware S10 to the supported one G973FXXU7CTF1_G973FOXM7CTF1_XEF.zip (due to sounds issue during phone calls) with Odin3.

Just for me to be aware, will that flush all my data on my mobile? I there anything specific tasks that I shall not do at all? I cannot find any information about data loss in the FAQ.

And a last comment, I have downloaded the firmware on "sammobile" is that a safe place from your point of view?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Keule-Tm:
If you flash the ct_HOME zip, your data will stay with your.

Sammobile is good to go.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] :
Was it the first installation? If yes....did you wipe /data?

1. Other ROM's do not really care about security.....

2. No different twrp needed >>> Other ROM's do not suppport FBE and other TWRP's for the S10(e|+) do not support FBE...thats why you need a custom TWRP

3. If you don't like a the work you get for free from modpunk....why do you use it? You can use the other LOS if you don't care about Encryption or SELinux
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] florek_18:
I'm coming from evoX 4.4

I would say it differently: because I care that much about stuff you mentioned that's why I asked and kinda pushed you guys for help.

I had the other LoS.

And now I know :) thanks

If I insulted Modpunk I'm sorry but it wasn't my intention. I'm just frustrated that I can't install something that I never had problems with. I was flashing custom ROMs since Galaxy S1....
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] :
Did it work with wiping /data?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Ivo_Todorov:
Thanks for the heads-up, so it is telling me in the FAQ I'm requested to update BL / CP / AP. How to update ct_HOME?

To update the firmware on your phone you either need to use Odin or Heimdall and flash the following partitions:

Odin

With Odin you have to flash:

BL_G97?FXX*.tar.md5

CP_G97?FXX*.tar.md5

From AP_G97?FXX*.tar.md5 take the dt.img and create a new AP.tar with only the dt.img
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] florek_18:
No, I wiped everything and like I said it installs normally without anything unusual and when I want to restart it restarts and then it restarts again but straight to twrp
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Keule-Tm:
Ah, sorry, typo.

It was meant to be CP_HOME_*.tar.md5
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Ivo_Todorov:
Thanks for your fast answer, so a single update of the CP file will update the full firmware of the device then? That sounds cool.

BL: the bootloader file.

AP: “Android partition,” the main operating system file.

CP: the modem firmware.

CSC: “Consumer software customization,” an extra partition for regional and carrier data.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] nugeganteng:
Hello, so i want to switch from Ivan's LOS to this and after flashing twrp in odin, instead of booting to recovery mode after pressing the combo keys, my phone went back to download mode with the following text on the screen:

XXX(cant see cause obstructed by round edge) MODE (DT Load Fail)

[OTH] dt table header check Fail: <unknown error>

load_kernel: Could not do Normal boot (DT LOAD Fail)

vbmeta: Error verifying vbmeta image OK_NOT_SIGNED (3)

CUSTOM VBMETA

VBMETA : No Sign info

VBMETA .

Any help is appreciated :)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Keule-Tm:
Damnit, I should really look it up before answering.

In the big zip file you downloaded, there will be a file called 'HOME_CSC_*.tar.md5". That's the one to go (instead of just 'CSC', of course).

I have no clue whatsoever which of that files (ap, cp, home_csc) will carry the firmware.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Eidluci:
I guess it has something to do with your recovery.img and vbmeta.img archived into a tar file. Kinda got same problem but got it working now. Maybe you'll need a vbmeta disabler of some sort. Just go through the comments I just cant locate it
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
Did you download the vbmeta_disable.img, renamed it to vbmeta.img and incuded that in the .tar file you flashed? The process is in the FAQ.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] florek_18:
Ok I got it.

Stupid me, I was wiping data from advanced wipe instead that separate button format data...

So I lost absolutely everything but everything is working now.

Thanks ;)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
Jesse is working on that problem. The same happens on S20.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
If it boots back to TWRP get /proc/last_kmsg and share it e.g. via https://cpaste.org/
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] nugeganteng:
yeah i did, i renamed vbmeta-disabled.img to vbmeta.img and twrp-3.4.0-0-android-10.0-beyond0lte-2.img to recovery.img then archive both vbmeta.img and recovery.img into a .tar file.

how did you get it working?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Eidluci:
Try running Odin as admin
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gonzo202828:
with beta3 or rc1 i got some weird restarts and screen off crashes.

when screen off, the fingerpring leads to a vibration, but no screen wakeup. if i do this several times, it freezes and a restart has to be forced by holding down volume down + power.

ideas?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
Which phone are you using? Usually it only vibrates and doesn't unlock when the finger is not registered. Try removing the finerprint and settings up again.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] nugeganteng:
nevermind i got it working after going back to stock then flashing from beginning :p
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gonzo202828:
s10+.

no it works, when i enable the screen with the power button, before.

i just had a poweroff while charging, without doing anything.

something is weird since beta3 or rc1.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] trancinguy:
Double tap to wake works if you disable then re-enable.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fishnetfancy:
I had one weird restart with hang yesterday on my S10+ where the phone was stuck on the LOS boot animation with screen off.

I managed to force a restart by holding Power+Bixby+Volume DOWN

Has been fine since.

---------- Post added at 09:48 AM ---------- Previous post was at 09:42 AM ----------

I had a similar problem initially but then came across TopJohnWu's instructions for properly unlocking the bootloader.

---------- Post added at 09:53 AM ---------- Previous post was at 09:48 AM ----------

Wow, amazing - very much appreciated from an S10+ user. Whilst I can't contribute in reverse engineering I would like to express my gratitude that this has made it onto the roadmap. :good:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
I had a similar incident. I was running the AnTuTu HTML5 benchmark when the phone restarted on it's own, but coun't reproduce the issue. My screen wan't actually off, but the lowest brightness setting. The animation wasn't correct either, the dot in the moving circle was shifted somewhat to the left. Very odd. Power+Volume Down solved it for me.

Unknowingly I've done the same with my installation, I just wanted to confirm that the OEM unlock is still set. Will update this in the next FAQ revision, thanks.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fishnetfancy:
That is a more precise description of what happened on my phone!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] funiewski:
Maybe this is clearly answered, but I can't find it. Is Bluetooth in call working with all devices?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gingew:
phone

for now I buy s20+ and screen is huge and as I write early I like more than just like I very very like all photos which make this phone
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
Bluetooth in generall seems to work just fine. The range is amazing as long as the top left part of the phone is not covered. I've tested it with

file transfer to PC or other phone

soundbar/ speakers

keyboard inkl. special keys

I don't have wireless headphones, so I can't test if it works during a call but the chances are pretty good, I think. If ou try it out, please confirm if it works or not :)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] :
Bluetooth calls work perfectly. I have the Sennheiser 4.50 as my main music headphones, and I haven't noticed any delays in the call audio or my microphone audio.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] funiewski:
On the other los some BT headphones works in call and some not. My jaybirds doesn't work but Jabra works
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Sradgads:
Is there a way to tell an app to use the full screen without caring about the camera hole?

Currently if I play a game (Black Desert Mobile) a black bar appear on the left (landscape, where the camera would be).

Screenshot attached.

This didn't happened with the original os, am I missing something? (maybe there is a setting somewhere I do not know about)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] :
At least for me, I only have this bug on RC1. I had to go back to BETA3 and in this version the phone turns off normally.

Great review by the way. :highfive: