yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
I noticed the same in the AnTuTu Benchmark and it's pretty annoying in full screen applications. You can try to force full screen: settings->display->fullscreen apps. It does not show AnTuTu there on my device so YMMV.

Alternatively you can try a "hide status bar" app, chances are that it solves the black bar thing as well. To get these apps to work you need either root or send a special command over adb. It's just an idea, I haven't tried it myself.

---------- Post added at 07:58 PM ---------- Previous post was at 07:55 PM ----------

I've added a remark "only on RC1" to that line, thanks.

Glad you like it :highfive:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
Thanks for your review!!!

So first, the sensor HAL has several samsung specific sensors and not what AOSP expects. We needed to hack e.g. the proximity sensor to get it working. So to get sensors working we need to have support in Android for it and check if we can relabel it so AOSP detects it.

The proximity sensor has only two states, NEAR and FAR. This is why you only see 0 and 8cm.

https://review.lineageos.org/c/LineageOS/android_hardware_samsung/+/275677

https://review.lineageos.org/c/LineageOS/android_hardware_samsung/+/275262

https://review.lineageos.org/c/LineageOS/android_hardware_samsung/+/275767
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
I can confirm this sensor is working well in RC1 on the S10. Its SpO2 results vary a lot by how hard you press your finger, but that's identical to stock. The heart rate though is very accurate, and captures even the second shock wave after the heart beat very nicely.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
That makes sense. It just seemd odd to me that the value was off by so much.

I've no clue about any android code, so this may be a dumb question, but do we have access to the I2C interface that is connected to all the sensors? Usually I work on low level embedded systems and direct control over the sensor would certainly be interesting to me :D

Great, Thanks! I'll add it to the post.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] exxxtreme:
I have something that might be considered an exotic scenario, I'm trying to add a 'work profile' ( https://support.google.com/work/android/answer/6191949?hl=en ) to my S10e running the beta 3 version of this ROM, and while most of the process seems to work, when it tries to register the account, it gives an error that my device does not pass the security checks. On the google G suite admin side, the device gets registered, but it appears marked as 'Compromised' under the the 'compromised status'. In documentation, google says this can mean among other things that the device is rooted.

I would understand this to be an issue with the custom ROM / unlocked bootloader, however I have also an Xiaomi Mi Mix 2S running lineage OS 17.1, with the same 'work profile' registered and this one does not appear as 'compromised', which lead me to think that maybe something in this ROM makes it look like rooted when it's not actually rooted (I did not use `Magisk`).

Any advise on what can I do?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
I'd guess it doesn't work because the ROM doesn't pass "safetynet" by default. If I remember correctly there are workarounds, but I haven't done any research on it yet. Currently I'm waitung for the RC2 update, after that I'll look into it. If I manage to get it working, which can take a while, I'll update the FAQ.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
Yes, MagiskHide isn't working anymore on very latest Play Services, thanks to Google now using the secure enclave to do the checking: https://www.androidpolice.com/2020/03/11/safetynet-improvements-kill-magisk-hide/

My current phone, the HTC 10, has been on microg its entire life. That works well on Android 9, which it's on, and SafetyNet and all the other jazz just works, so anything root-disabled works just fine.

It's pretty amazing that you have to dispose of Google Play Services entirely to combine root with banking apps, but there you go.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] exxxtreme:
Sounds great, thank you.

I think it's somehow normal to consider that a custom ROM may fail some security checks, but as I was saying, I have my other Mix 2s with Lineage OS 17.1 ( https://xdaforums.com/xiaomi-mi-mix-2s/development/rom-lineageos-17-0-xiaomi-mi-mix-2s-t3974661 ) that seems to work just fine
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] lakkimsetty.baba:
Hi, does the new HAL improve battery life (Screen-on time)? or would it improve performance while maintaining the same SOT?

Thanks.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
The benchmarking in one of my last posts was done on RC1 and the results are slightly above average stock values (about +5%). I can't think of a reason why beta3 would be any slower.

The new HAL most likely turns off more stuff inside the phone when not needed (sensors etc) and permits lower sleep modes, so I'd guess the display-off idle battery drain will be lower. If the display is on, it contributes most to the power consumption, so small savings won't be as noticeable. It's very hard to do an accurate run time measurement, especially because the phone is not yet my daily driver.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] nten2:
Hello! my screen doesn’t turn on during a phone call
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] trancinguy:
Fingerprints work if you hold for two seconds.

---------- Post added at 08:48 AM ---------- Previous post was at 08:42 AM ----------

wake the device and unlock, also avoid obstructing the proximity sensor.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
I've followed this guide almost to the letter with BETA3, but the signature spoofing patch won't take hold. The only variation I did is that installing microg using magisk seems to have no effect, so instead I installed microg before I installed magisk to have it install into the system.

The fact that installing via magisk for either of the two modules isn't working for me on BETA3 I personally find suspicious. Can I check if I'm doing it right:

1. After factory wipe and clean install of BETA3, installed the matching Magisk img into boot in TWRP.

2. Boot into system and install the Magisk Manager app.

3. Open Magisk Manager app, it downloads something from the internet and reboots.

4. After reboot I install the magisk module either from TWRP or from within the Magisk Manager app (I've tried both), and do another reboot. Neither approach for either of the two modules I tried seems to "take effect".
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gonzo202828:
i had about 8 crashes on screen off, today.

so this is completely unstable to me since beta3 or rc1.

not sure which rev exactly, because i switched to beta3 on one day and to rc1 the day after.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
So, I worked around this problem as follows:

1. Run the SmaliPatcher, it'll pull files from your phone and generate a Magisk patcher module called "SmaliPatcherModule-0.0.6.8-fOmey@XDA.zip". As Magisk is having no effect for me, this is useless on its own, but ...

2. Open that zip file with your favourite ZIP archive reader.

3. Extract the file system/framework/services.jar from the ZIP archive and place it onto the sd card of your phone.

4. In TWRP, mount system partition. Go into /system_root/system/framework. Rename the existing services.jar to services.jar.old. Copy the services.jar from your sdcard into that directory.

5. Reboot, and check the microg app, you should find signature spoofing is now working. Carry on with the rest of the microg guide above to complete your microg installation.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] MrNumber6:
The only issues I have with this version is :

Sometimes after a reboot the lockscreen crashes after the corect password so I have to delete it in twrp. No clue maybe trebuchet crashes idk.

Also I'm actually trying to fix safetynet rn because it fails both tests even with magiskhide activated. Ofc exposed isn't insalled.

Safetynet shows evaltype:BASIC,HARDWARE_BACKED in logcat, if I remember correctly it's because it detects that the bootloader is opened hardware wise. Nobody found a work around yet right?

EDIT: The trebuchet crash is triggered after the s10+ I use doesn't boot on the recovery mode, disabling the root and apparently ****in up trebuchet.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Sradgads:
That setting is different from stock os, it handles only "legacy" apps ? (do not know that that means in this context)

I tried, with no luck:

https://play.google.com/store/apps/details?id=com.rascarlo.granular.immersive.mode&hl=en

https://play.google.com/store/apps/details?id=com.ivianuu.immersivemodemanager

https://play.google.com/store/apps/details?id=com.zacharee1.systemuituner

And I think that the camera cut out was is handled differently than status/navigation bars. IIRC there was a package installed in the original OS dedicated to camera cutout (or at least is what the name/description lead to belive), is there a list of packages installed by default on the original OS? (or a way to obtain it withouth having to reinstall the original OS xD)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] lakkimsetty.baba:
(Not sure if this is the right place to ask this question, if not please point me to the right thread)

I am on S10e RC1 (working great! thanks modpunk) with Magisk and acc. I used the AccA app to set my phone change to 80% instead of default 70%.

I noticed that the battery stats would not reset when letting the phone charge just to 80%. Is anyone else experiencing similar to this?

I am looking for an automatic way to reset the stats when charged to 80%. I installed RC1 image on top of beta3 image, didn't do a clean install (if this helps)

Thanks!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Keule-Tm:
The acc thread would be your go-to thread about questions regarding acc(a).

Nevertheless there's a switch on the first screen of AccA to reset battery statistics when plugging off the charger. Did you try that?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Mischu1989:
Anyone has also problems to register fingerprints? Defintetly nothing happens, even after reflashing the rom. Any solution for this?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] trancinguy:
Read 8 posts before you.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] iamthekings5:
The blinking dot in the status bar seems to be there all the time I'm on the phone, I'm not sure what I'm using that requires the proximity sensor to be active. Is this intended?

Also, the always on display is way too dim and I can barely make out the info on it, defeating the purpose of the AoD.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gonzo202828:
[MENTION=231896]dev[/MENTION] any idea when rc2 might appear?

i know, when it's done, i am a dev myself ;).

But I will fly on vacation on thursday and i need a stable phone there. Wednesday is my last chance to update my phone. If rc2 will not come out until then, i have to flash an older version instead. ;).
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
I've let my S10e (running RC1) sit idle for the last 3 days (wifi & nfc on, no sime, everything else off) and the avarage power consumption is about 0.35% per hour, the estimated max. idle time is about 12 days(!). With it's small 3000mAh battery this equals a power draw of ~40mW or so and should be very close to the minimum power consumption of the hardware. (For comparison, my redmi 4x running an older version of LineageOS take about 0.75% per hour, despite its larger 4000mAh battery.)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fishnetfancy:
Has RC2 been pulled?

Forgive me if I am missing the obvious but the latest files on Android File Host are RC1 for the ROM and Magisk .img

Edit: sorry, misread the announcement. Now that it's here I will flash it asap.

Thank you!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
I've just released RC2
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gonzo202828:
s10+

flash worked fine

but magisk is not working anymore.

i flashed the rc2 boot image two times to boot, no success.

---------- Post added at 06:45 AM ---------- Previous post was at 06:43 AM ----------

magisk with boot image of rc1 works in rc2. strange.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
Please redownload
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] :
Does RC2 works in CTF3 firmware? Or only in CTF1?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] modpunk:
Works with both!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Gonzo202828:
Fixed!

Tyvm!

Stable so far, no crashes yet.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
I've tried a bunch of other sensor apps and found "Hardware Info" which reports a bit more detailed sensor values then the app I've used before. Notably it supports more than three values per sensor, so I can actually confirm the front light sensor works as it should! Out of curiosity I've experimented a bit and think I figured out what all the values mean. It's a bit offtopic for a ROM thread, but I thought you might be interested in the results.

Description for the highted values in the screenshot:

red/ green/ blue: brightness of individual colors (raw ADC values)

pink: likely brightness of a "clear" channel, sensitive to all colors including infra-red (raw ADC values)

(no color, value "392"): most likely also a channel with raw ADC data, maybe clear without infra-red?

yellow: brightness in lux, likely calculated from the raw ADC values of different channels

white: color teperature in Kelvin, likely calculated from the raw ADC values of different channels. The shown value seems to be off by a factor of two, the screenshot was made in sunlight and thus should be 5000K

cyan: real-time brightness of screen. Possible values are 19 to 486 (shown value is 8bit and will overflow at 255).

This new app also shows that the SX9330 grip sensor, which detects if a hand touches the left and right side of the phone, is working just fine. Maybe it's a little slow, I don't have a stock phone on hand to compare. Supposedly this sensor is used to optimize antenna performance, so I'm glad that it's working.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Brembo109:
I have a completely stock S10+ and could do a comparison. What's the beste way? Just download the app, take a screenshot and upload it here?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Noble35:
I wanna ask can this system be used on S10 5G? G977X etc.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Lav64:
Big thanks to the hard work out in by the Devs. RC2 is really solid. WiFi is better, power handling well, touch to wake was missed, overall a really solid experience compared to RC1.

Still some minor issue with setting up fingerprint but got there with patience in the end.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
A general comparison between the "known good" values of your stock device and one with this ROM would be very useful! Just download the app, go to sensors, lay the phone flat on a table and take screenshots of all values. I'd like one extra screenshot of the "Rear ALS sensor" while you're holding the phone (so that light can actually reach the rear sensor).

For the SX9330 grip sensor in particular a screenshot isn't that helpful. On my phone the first reported value changes between 0 (no hold) and 5 (hold) with a delay of 2-3 seconds; just check if your stock device behaves similiar.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Brembo109:
Here are the screenshots of all values. Grip sensor is the same behavior as yours. "Rear ALS Sensor" is blank and has no values. Maybe it helps to tune some things. I can test more "stock" things if needed :)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
Thanks, that's very interesting. First, the shown values roughly match the values get on my device, so I confident that the sensor drivers work perfectly. And second, I expected that on stock all sensors output data and thus any missing values on the ROM must be bugs. This assumption is now proven wrong, missing values are expected and not a flaw in this ROM. I'll update the FAQ accordingly.

You have an extra entry "Auto Brighness (Rear Lux)" which might contain the brighness value from the rear sensor. Can you please try out if that's the case? Just disable the auto brightness of the screen, cover the front light sensor (left beside the camera cutout) and point the back of the phone to a light source and see if that value changes significantly.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
I've made further progress with getting LineageOS (installed RC2 last night!) working well with MicroG. I'm probably unusual, but the literally only thing from google services that I like is the swipe keyboard, so my ideal setup is Microg instead of Google, but with the Google swipe keyboard.

I tried installing its libraries into BETA2, RC1 and RC2 the usual way, and I could never get it to take. Last night after work I spent some time plouging through the github PR adding Android 10 support to OpenGApps to figure out what I was doing wrong. Turns out that paths have changed in this very new Android 10, and specifically on the S10, so here is what you must do:

1. Go download the Android 10 edition of OpenGApps for ARM64 (Nano sized package is sufficient). Open the ZIP file, inside that open Optional/swypelibs-lib-arm64.tar.lz, extract out the libjni_latinimegoogle.so file. Copy that to your phone's sdcard.

2. Reboot into TWRP. Mount the system partition. Copy libjni_latinimegoogle.so from your sdcard into /system_root/system/product/lib64/. You may also wish to chmod it to 0644. You'll note that this path is quite different to the path used in any Android until now.

3. Reboot, and swiping on the keyboard should now be working.

RC2 looks fine, so far at least. I've been trying to find a non-fussy gcam for exynos which supports the variable aperture, and ideally the multiple cameras. So far no luck, the zgcam for exygnos everyone recommends is very unstable on this LineageOS build, at least with the standard S10 config files. I'd actually take a very old gcam if it supported the aperture and multiple cameras, I mainly want it for panoramas, which which OpenCamera does NOT do well at all. So I'm actually not wedded at all to gcam, I just want a camera which takes not shockingly bad panoramas.

I was curious if this LineageOS build must absolutely always remain stock and clean, or is there scope to bundle the unholey notification led app from https://xdaforums.com/galaxy-s10/themes/app-holey-light-t3917675? I can't see how anyone wouldn't want that functionality, but maybe some people really hate notification leds.

As another bundle suggestion, there is a patched libexynoscamera3.so which enables RAW capture from the front camera. As all the (more recent) gcams workaround the exynos chipset by effectively capturing everything in RAW and postprocessing those, if this LO bundled that patched libexynoscamera3.so, then the front camera would "just work" with those gcams.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
I've found a workaround to enable full immersive mode in all apps or on an app-by-app basis. This workaround has two downsides: The camera hole covers the normal status bar as well (the battery value in percent is hidden) and it requires a magisk module which can be a security risk. Here's how to do it:

Open Magisk, select "Downloads" in the side menu, search for "None Display Cutout" and install it

go to Settings>System>Developer Options>Display Cutout and select the new option "No display cutout - MlgmXyysd"

install any app which can control immersive mode (I like "System UI Tuner") to enable immersive mode or enable it only for some apps

To partially fix the statusbar go to Settings>System>Statusbar and enable "battery level in percent" next to the symbol

With root alignment can be further improved by cpadjsutor. For me the ideal offset is 16

It's a bit cumbersome, but chances are this feature will be integrated into a future version of the ROM :fingers-crossed:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Brembo109:
Rear Lux seems to be the sensor on the front. I faced my phone to a well lit window and covered the front with my hand, the values decreased. Then I turnt away from the window while covering the front and they stayed the same. Then I removed the cover and the values rise. It is the sensor in the front.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ned14:
If correct, this might explain why RC2's screen brightness appears to work opposite to what's behind the phone, which I find very annoying.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ibuza:
Just to be sure: Before I flash a custom firmware on a S10(+,e) like lineage, there is nothing to back up like DRM keys or certificates? (I had SONY phones before. If you reverted to stock on those some SONY apps would not work anymore if you did not backup the DRM keys).
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Lav64:
Question surrounding Gapps.

When I initially flashed LOS, I used Gapps Nano. However, I'd like to reduce to Pico.

Can I do this at anytime? Or, should I wait until the next update? Or, have I missed the boat entirely and will need to format and wipe before trying?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] exxxtreme:
I also don't seem to be able to get Android Auto to work. When connecting the phone in the car, it is not recognized by the car even tho the android auto app is started on the phone and doesn't give any error.

I am running RC1
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ctrej:
That's exactly why I'm searching for a solution to the rear brightness sensor - it's a useful hardware feature and it'd be nice if this ROM could support it. [MENTION=4860184]Brembo109[/MENTION] was talking about the Stock OS and it doesn't work for him either, so I'm not sure how to proceed.

I can not give you a definitive answer, but the term "drm" did not bring up a single complaint in this tread nor in Ivan's ROM's thread, so I guess it sould be ok? Personally I don't intend to go back, so I can't offer any first-hand experience.

According to this german forum thread (https://www.lineage-os-forum.de/Thread-Downgrade-GAPPS-nano-auf-pico) wiping everything should not be required. I don't have personal experience with this, but I'd try to install the current ROM and directly after the pico GAPPS package in TWRP, just like you'd do for an update. If the extra Google apps (ie those that are not included in pico) disappear it did work, otherwise the linked thread was wrong and you have to do a fresh install.

How could I not include this info :p ? The camera is the one area where there are noticible differences to stock and any improvement including app recomendations is welcome. So thanks for this in depth test :D

I'll try your suggestion myself first and then add a brief summary + a link to your post with the next FAQ update.

Edit: Just to make it clear, modpunk & a few other developers (mentioned in the first post) wrote all the code, I'm just helping out a bit with testing and maintaining the FAQ :)