yashsingh1/xdaforums huggingface dataset:
[Xposed General] pndwal:
References:

https://xdaforums.com/xposed/android-9-0-xposed-solutions-t3889513/post79434397

https://xdaforums.com/xposed/android-9-0-xposed-solutions-t3889513/post79434517 PW
[Xposed General] names:
Well, this problem has returned.

I'm on the latest canary build of Magisk and trying both SandHook and YAHFA versions of EdXposed canary builds. I will get it to where it shows the framework as active or installed but not active, where the modules work but Brave crashes. I have tried switching back and forth between builds, which seemed to correct the issue previously, and have Brave, Chrome, Google Play Services, and the Google Play Store all blacklisted. I have also cleared Play Services and Play Store data.

Thoughts? Any help is appreciated.
[Xposed General] Brandroid28:
idk. mine will stop crashing so long after it's been booted. i think the installed but not active status is a bug: https://github.com/ElderDrivers/EdXposedManager/issues/110
[Xposed General] names:
So, shortly after seeing your message I seem to have finally gotten things working again by doing the following:

Installed riru core, and then placed phone into airplane mode and restarted. After reboot I cleared data from both Google Play Services and Google Play Store, and then I installed the canary build of YAHFA through Magisk. For safe measure, I cleared data again from Google Play Services. Restarted and saw EdXposed enabled, and then rebooted a few times until the SIM was recognized. After, I opened Brave which loaded my last tab I had opened and then I rebooted my phone a few times until my SIM was recognized. I then launched Brave, the page loaded, took phone off airplane mode and confirmed Brave is still loading without crash.

Very drawn out process, and I'm sure some of it was not needed, but happy to report EdXposed is working correctly for me again without Brave crashing.

Hopefully this will help others if they run into the issues I encountered.
[Xposed General] useformildaccess:
I faced a similar issue when I installed both SandHook and YAHFA and though I could just disable either one in Magisk and have the other become the active framework. It was resolved when I removed both and installed either one. In addition, this clever observation can be helpful. Apparently, there are multiple residual SandHook directories and files that remain after uninstallation which could also be the source of your issue.
[Xposed General] ianmacd:
I just wanted to give an update on this.

I have since compiled SELinux permissive test kernels for both devices and can now state with certainty that the failure to boot on a stock kernel is definitely SELinux-related, because both devices boot fine with the kernel in permissive mode. EdXposed now works like a charm.

Unfortunately, the boot issue occurs so early that it happens before logging is enabled. The AVC denials that subsequently appear in the logs have no effect on the device's ability to boot. I have verified this by injecting them via supolicy.

So, clearly these 2020 Samsung Snapdragon-based devices need some custom SELinux policy rules, but I don't know what those would be or currently how to figure that out. Does anyone have an idea? I really don't want to have to maintain a custom kernel just to be able to boot with EdXposed.
[Xposed General] pndwal:
I won't pretend to know which rules need modifying either, but wonder if you've tried using very latest MagiskSU (Canary build) as ChangeLog includes this:

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post83882861

Some Background:

Clearly new dynamic/logical partitions required to support devices that launch with Android 10+ have presented a real challenge recently as this architecture has meant that sepolicy rule files must now be stored on different partitions apparently depending on device / soc, and the problem is that very few are available now.

John Wu

I imagine he will be doing more work on this aspect too.

Also on the plus side, John has gone from being highly critical of Samsung devices and a strong Pixel advocate, to a happy rooted Samsung Z Fold2 5G owner, and has done a lot recently to fix root issues for Samsung devices in general.

I don't know if he's a current EdXposed user, but, of course, he cut his teeth on Xposed, and personally created systemless Xposed in 2016 ( https://xdaforums.com/xposed/unofficial-systemless-xposed-t3388268/post67074423 ), so I'm sure he's very aware of needed sepolicy.

Hope it helps. PW
[Xposed General] FahadQ8:
Hi ,

Edxposed not suuport s20+ SD865 Version ?

Because when I install Edxposed and restart my device not able to bootable
[Xposed General] kevinwu128:
I had the same issue, I had to downgrade Magisk to 21005 and edxposed worked again.

As for the intermittent failure of safetynet on my Samsung S10, it's been happening since the beginning. When I need to use apps that detect safetynet, I open up edxposed, let it run for a while, then safetynet will pass 100% of the time. Battery optimisation is turned off for edxposed but I still believe the app is hibernating which causes safety net to fail after not using the phone for awhile.

Edit: i tried magisk 21101 and it also doesn't work with edxposed. (Android 10, s10 galaxy)
[Xposed General] ianmacd:
The permissiveness of the kernel turns out to be a red herring. After more testing, the same custom kernel will allow the machine to boot with EdXposed enabled even when the kernel is in enforcing mode and the ability to switch to permissive mode has been completely disabled.

So, SELinux has very little to do with the issue.

The real cause of the problem turns out to be CONFIG_KDP_CRED. With that feature enabled in the kernel, the device cannot boot with the EdXposed Magisk module enabled, if CONFIG_SECURITY_SELINUX_DEVELOP is also enabled. In the stock Samsung kernel, this is the case: Both features are enabled. One or the other must be disabled for the device to boot with EdXposed.

I hope this information will provide the EdXposed developers with the information required to work around the issue in the module files, thereby allowing the device to use a stock kernel to boot with EdXposed.
[Xposed General] pndwal:
Interesting.

Again, I don't understand much about sepolicy, but it seems CONFIG_KDP_CRED is part of a security protocol aimed at preventing SELinux being disabled, and has been used in patching some Samsung devices. https://duasynt.com/blog/samsung-s20-rkp-selinux-disable

CONFIG_SECURITY_SELINUX_DEVELOP seems to equal global permissive mode. Seems if it's defined (=y) it can be invoked generally for early development / engineering etc (by adding androidboot.selinux=permissive to BOARD_KERNEL_CMDLINE, etc).

https://wiki.gentoo.org/wiki/SELinux/Tutorials/Permissive_versus_enforcing

https://seandroid-list.tycho.nsa.na...led-in-most-of-the-aosp-based-releases-can-we

I'm not sure about unflagging these kernel features (disabling ability), but wouldn't such changes be considered 'custom SEPolicy? PW
[Xposed General] pndwal:
Well, you got John's attention! Well done, n thanks!

https://github.com/topjohnwu/Magisk/issues/3485

...And he has Z Fold2 5g to boot! PW

Related issues extant:

https://github.com/topjohnwu/Magisk/issues/3490

https://github.com/topjohnwu/Magisk/issues/3486
[Xposed General] ianmacd:
No, an SELinux policy is a separate entity, compiled from policy files. When people refer to a custom SELinux policy, they are usually referring to adding rules to this set.

CONFIG_SECURITY_SELINUX_DEVELOP is a bit odd on Samsung devices. It's actually set in the stock kernel, and if you download Samsung kernel source for any device you'll see this reflected in the defconfig. However, this doesn't mean that Samsung's kernels can be switched to permissive mode. Samsung render the feature inert in the stock kernel, probably in a post-compilation stage that is missing from their source drops.

If you run:

su -c setenforce 0

on a stock kernel, the command will silently fail, rather than issuing an error as it would if CONFIG_SECURITY_SELINUX_DEVELOP were disabled.

I have since updated my Magisk issue with the disassembled code of the kernel section that must be patched to fix the bug of EdXposed not booting on 2020 Samsung Snapdragon devices. Now John just needs to condense this into a magiskboot hexpatch command.
[Xposed General] pndwal:
Many thanks for your valuable insights... and it's looking highly likely that he will! :good: PW
[Xposed General] textbook:
I am posting this just in case it might help someone else...

I have a Oneplus 7 Pro.

I am on the latest Open Beta Oxygen OS (Open Beta 19).

I am using Magisk Canary.

For months I was on Oxygen OS Open Beta 16 with Magisk Canary and EdXposed Canary 0.5.0.6 (4565) with 0 issues and I was passing Safetynet, then I started to fail Safetynet in Magisk even though I didn't make any changes.

So I decided to update to Oxygen OS Open Beta 19... When I finished upgrading I was passing Safetynet, but EdXposed was broken and my phone was VERY unstable (laggy) with EdXposed enabled. So I uninstalled Edxposed 0.5.0.6 (4565), rebooted, then I installed 0.4.6.4 (4563)... But EdXposed was broken (framework not working), so I uninstalled EdXposed framework and EdXposed manager... Then I installed EdXposed framework from Magisk (YAHFA), rebooted, then installed EdXposed manager, then enabled all my modules and rebooted... Now EdXposed was working and I was passing Safetynet, but my phone was still VERY unstable with EdXposed enabled.

I think the key steps for me was uninstalling everything and then installing the framework first and the manager second.

Lucky Patcher EdXposed module was the cause of the really bad system stability issues. After disabling Lucky Patcher module, I am on OxygenOS Open Beta 19, Magisk Canary, and EdXposed 0.4.6.4 (4563) passing Safetynet and perfect system stability.

I will try to go back to 0.5.0.6 (4565) and report back.
[Xposed General] ianmacd:
I've now traced and fixed the bug of Samsung's 2020 Snapdragon devices panicking on boot when EdXposed is enabled.

I ended up making the fix to the EdXposed code, and it does fix a real bug there, but the much bigger bug is Samsung's stock kernel panicking when an attempt is made to switch it to permissive mode. That should never happen, but I don't know how to report it to Samsung.

Fixing the EdXposed bug merely avoids triggering the much more serious Samsung bug.
[Xposed General] dortok:
FYI, the latest Camera update from November 17 on Android 11 does not work with Edxposed running. It just crashes immediately.

I'm on a Pixel 4 XL using Edxposed 5.0.6 (4565).

After uninstalling the Camera update it works again.
[Xposed General] LNS:
Guys someone help? I can't seem to get EdXposed to work. I installed magisk 21.1, latest Riru v22, EdXposed Canary and EdXposed manager 4.5.7.

With Riru v22 edxposed will not work at all (framework not installed). With Riru v21.3 framework is installed but the modules don't work. I've tried variations like edxposed alpha and stable builds, ended up just staying on latest since nothing works. Any insight? Cheers!

edit: I'm on android 10.
[Xposed General] JudgeDread11:
Exposed is not yet updates for Riru 22.

Which modules do you use?
[Xposed General] LNS:
Ehm, YouTube background playback was the one I wanted but I installed a couple more just for testing, YouTube adaway, xinsta. Is it possible all these are outdated?
[Xposed General] Hirs_E_Fruit:
yes they are outdated, try youtube vanced, which only need root, and instaprefs
[Xposed General] Uluru25:
I am running A10 under MSM Xtended Version 13 and have no general problems with EdXPosed (but I admit to use only very few modules) as you can see:
[Xposed General] JudgeDread11:
I'm not using them, but xinsta and YouTube at haven't been updated since 2018 in the xposed repo.

For the YouTube related stuff just use Vanced YouTube.
[Xposed General] LNS:
Ok I also tried Instaprefs, this is not working either, am I missing sth?

Vance is awesome! I didn't know about! I wouldn't have bothered with edxposed if I did. Now I'm invested though lol.

edit:

I have small update, I'm on riru 21.3, edxposed alpha yahfa and I'm getting message

"Please grant Instagram/VirtualXposed Storage permission otherwise Instaprefs won't work"

Although I think it's not very related, cause my Instagram is not changed at all. I'm using Instaprefs as test module right now.
[Xposed General] TheKerevas:
Guys I did not understand, so Riru v22.0 how to use? What is needed?
[Xposed General] JudgeDread11:
An update to exposed which is not there yet. Use 21
[Xposed General] Lord Sithek:
Isn't Canary EdXposed compatible with Riru 22?
[Xposed General] njtony:
Edxposed 0.5.0.6_4568+Riru 22 works fine
[Xposed General] tramp20:
Thank you, but could you add a link for edxposed 0.5.0.6?
[Xposed General] textbook:
The problem is that even if you can get riru v22 + EdXposed 0.5.0.6 (4568) to work... Rikka specifically says in the riru v22 update that all xposed modules need to be updated to work with riru v22.

I won't be updating until xprivacy lua gets an update to work with riru v22.
[Xposed General] adriansticoid0312:
I think he meant to say Magisk module. Not Xposed module.
[Xposed General] njtony:
XprivacyLua works very well for me, I am P3aXL, A11, it should be Edxposed to support riru22 to work normally, so Edxposed modules should work normally after Edxposed works normally
[Xposed General] JudgeDread11:
I think that the modules that are talked about are not the xposed modules but the riru modules, like exposed and storage isolation are riru modules.
[Xposed General] njtony:
https://ci.appveyor.com/project/ElderDrivers/edxposed/history
[Xposed General] Uluru25:
... having seen this promising post that you run XPrivacy Lua under A11, I am very interested in the details.

Could you spent some minutes and describe what versions of magisk.zip, magisk manager, riru, etc. you are using? If necessary also the sequence of steps you made for installing etc.

Thanks in advance!
[Xposed General] TheKerevas:
But I don't understand, does custoMIUIzer also need to be updated or will it work?

---------- Post added at 05:35 PM ---------- Previous post was at 05:34 PM ----------

That's right, we still don't understand what we're talking about...
[Xposed General] tramp20:
Thanks I know this site but I don't find a downloadable zip file there.
[Xposed General] njtony:
magisk V21.1,magisk manager v8.0.3,riru-core v22.0,riru-edxposed v0.5.0.6_4568,edxposed manager v4.5.7,xprivacylua v1.27

After installing magisk, install the module and edxposed manager, there is no specific order.

riru-location report enabler and riru-edxposed edxposed needs to support riru-core v22.0 in order to work normally, so xprivacylua can also work normally after edxposed works normally.

The only regret is that safetynet cannot be passed unless riru-core is disabled

After entering the corresponding version, find "Artifacts" and you can download it

Such as https://ci.appveyor.com/project/ElderDrivers/edxposed/builds/36448754/artifacts
[Xposed General] bush911:
Could you please possible help check whether the lataclysm module work or not on latest Exposed?

I have been using Lataclysm for fake location on my Pixel 3 with Android 10 and hesitate to upgrade to Android 11 as Lataclysm is a must for me.

I would be most grateful for your help with this, thank you.
[Xposed General] tramp20:
Thank you. So simple and I searched and searched...
[Xposed General] textbook:
Thank you for the clarification. My bad on the mistake. I updated to 0.5.0.6 (4569) right now and everything is working perfectly, I am also passing Safetynet.
[Xposed General] labello29:
Hello after update no longer works someone has solved?thanks
[Xposed General] JudgeDread11:
If you use riru 22 you need to use the canary version of exposed. I also needed to reboot twice after updating riru.
[Xposed General] eliezerjk90:
Could someone pass safetynet with the latest canary? Somehow safetynet always failed on that version. Reverting to older version for now
[Xposed General] labello29:
thank you i already instaled (canary version) after reboot stoped logo samsung bootloop:(
[Xposed General] Lord Sithek:
Actually I can't pass it with any versions, and I tried probably all of them. Currently I'm using riru 22 + EdXposed Canary yahfa. For some time it's passing, but then it fails. I've tried many different tricks, with the same results...

Xiaomi Mi Note 10, Xiaomi.eu Android 10 20.9.17
[Xposed General] USHERROB:
I'm on Magisk Canary build 21101

Riru 22.4 (does not require double reboot)

EdExposed Canary 0.5.0.6 (build 4576 YAHFA)

Passes CTS

I have Magisk Hide Props (v5.3.6 build 109) module and renamed Magisk.
[Xposed General] textbook:
Everything is working and passes.... But I am having an issue where my screen is going black (sometimes) when I am on a call and using my phone at the same time (like browsing reddit).
[Xposed General] pndwal:
Can't wait for Magisk 22.2... but think you might mean Riru... PW
[Xposed General] BrikHaus:
Hi, Anyone with a Pixel 2XL confirm that edxposed / riru is working on Android 11? I have Magisk working fine, and last time I tried getting edxposed working I spent a day getting my phone

working again (which I don't have the time to do atm). THANKS!
[Xposed General] uradryct:
I cant install EdExposed coz "no riru-core installed" when it is.

Riru apk recognize the riru-core

I'm using Galaxy A71
[Xposed General] Lord Sithek:
After the update to Riru 22 u need EdXposed Canary until the stable version be released
[Xposed General] uradryct:
"Please install riru-core 19+"

And im using 22.4

:(
[Xposed General] willybarca:
For these having issue with getting xposed to work. I used this setup and everything is working now.

edxposed canary sandhook 4586(anything before this didn't work for me)

Riru 22.4

Latest magisk canary
[Xposed General] Soumy1234:
Are all of your modules loading and being applied properly? Is you selinux permissive or enforcing?
[Xposed General] Matce:
Can someone assist please:

I can't get it to work...

Samsung S20 5G Korea version (Snapdragon).

I got magisk running (tried both 20.4 and 21.1) - so far so good.

I also get Riru 22.4 on there (at least it shows OK), but as soon as I install any edxposed (the latest canary) the phone goes into boot-loop, eventually starts after I press a bunch of buttons, but EdXposed Manager says its got no framework installed...
[Xposed General] flame360:
+1 for this! For the first time I'm able to have root & xposed while having Google pay snapchat and everything else working. Thanks a lot!
[Xposed General] Matce:
where did you find magisk 22.2 ?

I cant find anything over 21.1 :(
[Xposed General] USHERROB:
Sorry, I meant Riru 22.2 (now it's 22.4)

For Magisk, you need to use the Canary builds and the latest one is 21101 and latest manager is 315.14
[Xposed General] coconutxyz:
after installed 22.4 riru core then canary yahfa 0.5.0.6 4586 and restarted, the edxposed manager 4.5.7 45700 crashes..

any advice? thanks
[Xposed General] enetec:
[bug] 0.5.x.x. versions break compatibility with old Xposed modules

I've open this on official GitHub but developers continue to close it without any reply... so...

I've done some extensive tests...

Ambient: Moto Z2 Force on Android P stock

Riru - EdXposed - Behaviour

---------------------------------------------

v.21.x - 0.4.6.x (4563) - All fine

v.22.x - 0.4.6.x (4563) - Xposed not loaded (Riru not found)

v.22.x - 0.5.0.x (4569) - Old Xposed modules don't work well

v.21.x - 0.5.0.x (4569) - Xposed not loaded (Riru not found)

v.21.x - 0.5.0.x (4562) - Old Xposed modules don't work well (!!)

v.22.x - 0.5.0.x (>4570) - Bootloops (known bug... mainly with Android P devices)

I've asked for a new v.0.4.x.x compatible with Riru v.22 and they replied that it won't be done.

Then they try to find the "culprit" in new Riru v.22.x changes while it is *clear* that the issue is in EdXposed v.0.5.x.x, since Riru v.21 with EdXposed v.0.5.x.x (4562) already have this issue...

So I reported this again to ask a check on v.0.5.x.x and they closed this again with no reply... so beware.

I'm very disappointed with developers behaviour. :rolleyes:
[Xposed General] Lord Sithek:
Good check. I wonder then what's the point of Canary updates if we won't be able to use Xposed modules
[Xposed General] enetec:
I wonder what is the point to have a github to report bugs when you close (trying to hidden...) reports that you don't like too...

It's not hiddening dust under carpets that the house would be clean...

Since it seems to be *evident* that v.0.5.x.x has some things to be still fixed (old modules compatibility, bootloops on Android P since 4572, etc...) I asked for a (last?) stable v.04.6.x able to work with Riru v.22 (it should be very simple since what Rikka reported...) but they simply say NO.

Well OK... so fix v.0.5.x.x if you are able... (and LOT of US want their old modules continuing to work fine. I think!).

Up to date my hint is to remain with Riru v.21.3 and EdXposed 4563 for better compatibility and stability... ;)
[Xposed General] Lord Sithek:
Exactly what I've done ?

And yes, weird approach...
[Xposed General] enetec:
Update!

I've just been BANNED on their GitHub since of this... :laugh:

https://github.com/ElderDrivers/EdXposed/issues/693

Beware of them... ?
[Xposed General] enetec:
Somebody to develop "unofficial" v.0.4.6.5?

Well anyway I'm a professional IT and not a "permalous" chinese boy, so my mind is solving oriented...

They just merged "bugged" (low backcompatible and prone to bootloop... ) "android_r" v.0.5.x.x develop branch into master branch, so it's clear what their intentions are...

(and ban whoever try to report *legit* bugs is another clear sign of this... :rolleyes: ).

So... we have a stable and good working v.0.4.6.4 (4563) which has the only evident issue of not recognizing Riru v.22.x....

Sources are available on GitHub.

Changes needed to support Riru v.22.x, since of what Rikka itself declares, should be trivial (like change some paths or something similar...), SO, if somebody is interested in develop an UNOFFICIAL v.0.4.6.5 (45630) I would be happy to test it for him on my devices. ;)

I would develop myself but my workours are totally not compatible with any develop project... :rolleyes:

Interested can eventually PM me for any help... ;)
[Xposed General] shah22:
That's really weird. I think no dev would like to hide bugs ..

I think they just marked it no fix because it can't be fixed ?

We often think that its really easy or trivial to change paths/renames or easy fixes, while in reality devs know better. But this issue should be urgently fixed as it makes latest stable versions of riru and edexposed incompatible to each other.. and not all of us want to flash a canary build on our daily driver phones, not especially with a big red warning written on it "This build is highly unstable and only users themselves are responsible for the consequences of flashing this"

And I would've liked their reply instead of just closing bug reports with won't fix tags. Its really looking bad for ed exposed users :(

But all said in the end, they really did a great job with giving us ed exposed in first place ! Would love if they keep it going :)
[Xposed General] the00guy:
It kind of sounds to me like they are simply stating that they won't release another 0.4.6 version to fix the compatibility with riru 22.4, so hopefully this means that they'll fix it in a canary edition and push that as a stable build soon...
[Xposed General] shah22:
Yes but as stated above, if the old xposed modules won't work 'well' with the new builds that fixed the issue of not 'recognizing riru - core' then I guess it will effect that group of people who use ed exposed with old xposed modules (including me)

And I don't think we're that less in numbers :D