yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S9 & S9+ Cross Device Development] geronimoge:
Thanks!

Just did a dirty flash from Xawex v0.3 to v0.4.

And the device booted up quickly after that so I assume that's a good sign.
[Samsung Galaxy S9 & S9+ Cross Device Development] crhylove:
Yep, also dirty flashed over v.3. Will update in a day or two to see how we're doing. :)
[Samsung Galaxy S9 & S9+ Cross Device Development] xo.en:
Yess, thank you 4 nfo.
[Samsung Galaxy S9 & S9+ Cross Device Development] geronimoge:
Update: Still no problems besides the issue with charging.
[Samsung Galaxy S9 & S9+ Cross Device Development] trance432:
flashed v0.4, camera in instagram, whatsapp, snapchat is not working, in both instagram and snapchat camera shows blackscreen and in whatsapp it says camera is not working, please restart you phone.

Any fix please ?

I like the rom, very smooth like butter

Note: Camera app is working
[Samsung Galaxy S9 & S9+ Cross Device Development] crewpuk13th:
delete the HAL1 line on build.prop, that'ss fix it in my case
[Samsung Galaxy S9 & S9+ Cross Device Development] trance432:
Worked!

Thank you so much
[Samsung Galaxy S9 & S9+ Cross Device Development] gedw:
Cast Issue

Great ROM. Works fast and smooth on my S9. Thanks. :D

The only issue I have is Cast not working - spends a long time searching then reports No Nearby Devices Found.

Anybody else had this? (I've searched forum but no luck so apologies in advance if this has been posted and I've missed it.)
[Samsung Galaxy S9 & S9+ Cross Device Development] trance432:
I found a bug, when I want to put an app on home screen, I long press on the app but it doesn't show anything i cant drag it, I have to restart my phone and then it works and after like 30 mins to 1h I try again and it doesn't work.

Edit: Found another bug, Camera is lagging when zooming in instagram
[Samsung Galaxy S9 & S9+ Cross Device Development] crhylove:
Maybe try a different launcher? I like Lawn Chair on the F Droid market.
[Samsung Galaxy S9 & S9+ Cross Device Development] trance432:
After letting the phone settle it worked don't ask me how but it is no longer there ?.

Few bugs left
[Samsung Galaxy S9 & S9+ Cross Device Development] aptalherif1:
where is CSF2 vendor img file link ????????? its giving ERROR 7

EDIT: found it , just type its name on the link to stop people from asking same thing over over again.
[Samsung Galaxy S9 & S9+ Cross Device Development] aptalherif1:
Guys, screen recorder not recording internal sound ? is there a solution ? recme and plugin is not working too ??
[Samsung Galaxy S9 & S9+ Cross Device Development] crhylove:
I don't have that issue.... Hmmm Just did a screen cap tonight:

https://youtu.be/5ZiP5ccnPSU
[Samsung Galaxy S9 & S9+ Cross Device Development] aptalherif1:
wtf is this sht to do with my question ? :laugh:

go open a game , record a video with internal sound and come later please, after that we can discuss its only me or everyone.
[Samsung Galaxy S9 & S9+ Cross Device Development] Syntax_1:
It's only you.......

Great ROM - Everything is working well. Thanks !

(No Gapps installed)
[Samsung Galaxy S9 & S9+ Cross Device Development] rupert3k:
In case anyone hasn't noticed there's a promising S9/+ Lineage 17 rom by abtekk & Synt4x.93 out:

https://xdaforums.com/galaxy-s9/samsung-galaxy-s9--s9-cross-device-development/rom-t4020939
[Samsung Galaxy S9 & S9+ Cross Device Development] alpherb:
Even with deactivated AGPS: Strange SUPL connections to amazonaws

- deleted -
[Samsung Galaxy S9 & S9+ Cross Device Development] Bullixflieger:
Solution for problem 2.): Install Micro C Services Core via Fdroid manually:

https://www.celsoazevedo.com/files/android/google-camera/troubleshooting/#help12http://

# How to use GCam without GApps »
[Samsung Galaxy S9 & S9+ Cross Device Development] KiralyCraft:
DS4 Controller (V1 / V2) - Can't connect wirelessly

I have been using this as my daily driver and I can say with fair confidence it's working perfectly. The only issue that stresses me the most is the fact that despite having keylayouts for Sony's DualShock 4 controller, I can't connect it wirelessly whatever I do. I have tried both V1 and V2 controllers, and they both get stuck at pairing. I have tried pairing them manually with the help of a Windows machine, and they connect (and pair!) but there is no input. I tried installing the 1Controller module despite having keylayouts already, but to no avail. I do not have an OTG cable to test it wired. Bluetooth mice work.

Another inconvenience (but I can't complain) is that Google Pay does not seem to work, I am passing SafetyNet and I can add cards to the app. Everything works until it's time to pay. The device does not even seem to react to the POS.

Signal bars also don't work with Android Auto (signal strength does not change, it stays the same as when the device was connected). Also signal bars don't seem to work while roaming at all.
[Samsung Galaxy S9 & S9+ Cross Device Development] testerS4:
No sources are shown under "Stream".

Tried LOS 15.1 / 16.0 / 17.0 beta ... always the same problem.

Galaxy S4 and J5 with 16.0 no problems.

Anyone have an idea?
[Samsung Galaxy S9 & S9+ Cross Device Development] SilentStorm21:
Where to obtain vendor.img

Hi, I'm new to rom flashing. May I know where I can obtain the CSF2 vendor.img? Much thanks.
[Samsung Galaxy S9 & S9+ Cross Device Development] testerS4:
You can find the vendor in the download link
[Samsung Galaxy S9 & S9+ Cross Device Development] AgeOfMarcus:
QuickSwitch doesn't work

Do you know why the Magisk module "QuickSwitch" might not work on this build? On my device, whenever I set the recents provider, after reboot it simply resets. I want to get pixel-like recents menu with OCR but only on your ROM I can't. Is there anything I can do?
[Samsung Galaxy S9 & S9+ Cross Device Development] D4ND310:
Where can he find the download link? Then he might tell everyone.

Thanks in advance.
[Samsung Galaxy S9 & S9+ Cross Device Development] ÉNITSED?:
Hi , do you know how to fix headset bluetooth on los16
[Samsung Galaxy S9 & S9+ Cross Device Development] rolferikalfheim@gmail.com:
Hey

What is CSF2 and where to download it? :)

Regards

Rolf
[Samsung Galaxy S9 & S9+ Cross Device Development] xo.en:
Here..

https://drive.google.com/drive/folders/1yRcKpYHt-aLfUqaxFLC-Xx3kX6BOEKbW

It's needed to make this working.

But afer you flash vendor, flash this:

https://github.com/xawex465/LineageOS-16.0/releases

0.4, but...before this, flash latest twrp.
[Samsung Galaxy S9 & S9+ Cross Device Development] SorcioSecco:
Great ROM

Great ROM, good battery life, everything seems to be working fine. :good:
[Samsung Galaxy S9 & S9+ Cross Device Development] xax88:
wifi problem

Hi

i have installed lineage os 16.0 with CSF2 vendor.img and open_gapps-arm64-9.0-aroma-20200205 (custom aroma installer), twrp 3.3.1-0 and magisk 20.3 but after installation wifi stops working after a short time...

What may be causing this problem? thanks for help.
[Samsung Galaxy S9 & S9+ Cross Device Development] Syntax_Error_:
It would be so nice if the developer of this Rom could continue this project. It would make me realy happy ! This Rom works like a charme !
[Samsung Galaxy S9 & S9+ Cross Device Development] Synt4x.93:
My los17.1 builds are far better than this now

Have been doing them on telegram for a month or so to get the bugs worked out, but feel it is finally stable enough and bug free for everyday use.

Will make a new thread on here sometime for it.
[Samsung Galaxy S9 & S9+ Cross Device Development] Syntax_Error_:
Great ! I'm happy to hear this great news ! Thanks !
[Samsung Galaxy S9 & S9+ Cross Device Development] xo.en:
DO it!
[Samsung Galaxy S9 & S9+ Cross Device Development] Eye_of_Osiris:
Can't find CSF2 vendor image. Most vendor images suggested by s9plus devs, can not be found anywhere in the internet. What a nerve-twisting nightmare! Somebody do something about it. Devs please save us!
[Samsung Galaxy S9 & S9+ Cross Device Development] [Acme]:
ERROR: 7
[Samsung Galaxy S9 & S9+ Cross Device Development] [Acme]:
Flashed successfully!

Great work, thank you very much about it.
[Samsung Galaxy S9 & S9+ Cross Device Development] Synt4x.93:
Whoever is using this rom still, i suggest you stop and flash los17.1 instead.
[Samsung Galaxy S9 & S9+ Cross Device Development] [Acme]:
Is los17.1 as stable as los16?
[Samsung Galaxy S9 & S9+ Cross Device Development] Synt4x.93:
Much more stable, Ive moved to it myself.
[Samsung Galaxy S9 & S9+ Cross Device Development] [Acme]:
Ok, I'll try.

Thank you very much for your recommendation.
[Samsung Galaxy S9 & S9+ Cross Device Development] Synt4x.93:
better in every way imo, 4.9.218 kernel, SELinux enforcing.
[Samsung Galaxy S9 & S9+ Cross Device Development] rbeuker:
Indeed! I have been able to successfully upgrade directly from the 17-07-19/16.0 version to the newest 10-04-20/17.1 version on my Galaxy S9 (960F), keeping all my apps and settings and without any issues. :cool:

Maybe this will help someone:

1. Make sure your TWRP version is 3.2.3.0--if it's older/newer then upgrade/downgrade to 3.2.3.0 by going to https://eu.dl.twrp.me/starlte/ and grab the twrp-3.3.0-0-starlte.img file. Use your current TWRP version to flash this image file. Read more about TWRP here: https://xdaforums.com/galaxy-s9/samsung-galaxy-s9--s9-cross-device-development/twrp-exynos-t3763464

2. Flash the new Q BL (Bootloader). I've grabbed the BL_G960FXXS7DTB5.zip file from https://mega.nz/folder/oFJ1nK5Z#eWD2AU4CQxWSdA_kxxRkHA/folder/QFZhxKqI. After installing the new bootloader my phone wanted to reboot. This wasn't a problem: the bootloader booted the 17-07-19/16.0 version without problems.

Note: there's also a vendor.img file in the same folder, but you do not need that one!

3. After booting into in Recovery (TWRP) again I've used the Advanced Wipe option to *only* wipe the Dalvik/Art Cache and Cache partitions.

4. Still in Recovery (TWRP) I've flashed the file G960FXXU8DTC5_vendor.img file that I've grabbed from https://mega.nz/folder/0McClQKJ#ic8c0LEYF3zGSo_Ivv1nSw/folder/MdNGlACQ (source: https://xdaforums.com/galaxy-s9/samsung-galaxy-s9--s9-cross-device-development/rom-t4075725)

5. Still in Recovery (TWRP) I've flashed the latest 17.1 ROM version that I had downloaded from https://mega.nz/folder/0McClQKJ#ic8c0LEYF3zGSo_Ivv1nSw/folder/gcMkHK4T. Read more about this new ROM here: https://xdaforums.com/galaxy-s9/samsung-galaxy-s9--s9-cross-device-development/rom-t4075725

6. Finally, still in Recovery (TWRP) I've flashed the Open GApps that I had downloaded from https://opengapps.org/. I had selected: Platform ARM64, Android 10.0, Variant Nano

Rebooting the first time took some minutes to complete. The next time the phone boots fast as always. And everything works great! :D
[Samsung Galaxy S9 & S9+ Cross Device Development] [Acme]:
:good:
[Samsung Galaxy S9 & S9+ Cross Device Development] Synt4x.93:
Glad to hear it worked out well for you, enjoy :)
[Samsung Galaxy S9 & S9+ Cross Device Development] [Acme]:
Updated to LineageOS 17.1 !!!

Thank you very much for your recommendation.
[Samsung Galaxy S9 & S9+ Cross Device Development] rbeuker:
Welcome to Android 10! [emoji3]

Verstuurd vanaf mijn SM-G960F met Tapatalk
[Samsung Galaxy S9 & S9+ Cross Device Development] volcanogreen09:
The speaker on my S9 sounds really bad on this ROM. Anyone else having this issue? It IS stereo, but sounds really bad, like an old radio lol.
[Samsung Galaxy S9 & S9+ Cross Device Development] eossam:
Hello Synt4x.93,

please, where can I find the device and vendor tree, manifest.xml, etc. you've used for the LOS 16. ROM?’

Thank you!
[Samsung Galaxy S9 & S9+ Cross Device Development] darklime:
Can anyone confirm if this won't work for the US snapdragon variants? (T-Mobile).
[Samsung Galaxy S9 & S9+ Cross Device Development] itsmevinu:
Sir, from where do we get the vendor.img for SM-G965F? And is it necessary to flash it before installing the ROM?
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
Just flashed now. The "Migrate" app is setting things up. Might give this baby a spin for a week and see how it goes. Seems okay for now (5mins into the ROM). Will keep all posted about how I find the it.

Cheers!!
[Samsung Galaxy S9 & S9+ Cross Device Development] bdwilk:
I don't know about app lock but you can get a clear all FAB using the app Recently from the playstore.
[Samsung Galaxy S9 & S9+ Cross Device Development] intervigil:
Question: Is there a specific version of the firmware required to run this? I've got CSF2 firmware from flashing via ODIN, following the instructions here results in a failure to boot (hang at the bootloader splash)
[Samsung Galaxy S9 & S9+ Cross Device Development] geronimoge:
Check OP and there instructions: CSF2 is required.

Sometimes formatting data before starting is helpful.

I'd try that and use TWRP for flashing purposes.
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
I too was on CSF2 official firmware. I did not have any issue. Here is what I followed.

Reboot to recovery

Factory reset

Clear/wipe Cache

Clear/wipe Dalvik cache

Clear/wipe Data

Flash ROM

Flash Gapps

Flash Magisk v19.x

Reboot

This worked without a cry!

Try again and post if it worked for you.
[Samsung Galaxy S9 & S9+ Cross Device Development] phamtieugiao:
Any chance for this to be official?
[Samsung Galaxy S9 & S9+ Cross Device Development] geronimoge:
My installation process

Reboot to recovery (TWRP)

Format data

Delete system, data, dalvik, internal storage

Reboot to recovery (TWRP)

Flash vendor

Clear/wipe Cache

Clear/wipe Dalvik cache

Reboot to recovery (TWRP)

Flash ROM and Magisk v19.3

Clear/wipe Cache

Clear/wipe Dalvik cache

Reboot

Works like a charm...
[Samsung Galaxy S9 & S9+ Cross Device Development] Akhayev:
So we don't need to wipe system ?
[Samsung Galaxy S9 & S9+ Cross Device Development] geronimoge:
My bad, i corrected my post. Sorry for that...
[Samsung Galaxy S9 & S9+ Cross Device Development] Akhayev:
Its okay , but is it necessary to delete storage
[Samsung Galaxy S9 & S9+ Cross Device Development] geronimoge:
According to OP data and cache is enough.
[Samsung Galaxy S9 & S9+ Cross Device Development] Yjtvdw:
Amazing rom! Its very fluent and fast. The only minor bug i am having is the malfunctioning flash in the Lineage stock camera. The funny thing is that i can record video's in full hd with 180fps.
[Samsung Galaxy S9 & S9+ Cross Device Development] Akhayev:
Im asking because the rom is very laggy , I wiped system cache and data but the rom is very laggy
[Samsung Galaxy S9 & S9+ Cross Device Development] bobandar:
Make sure to clean flash again by wiping cache, data , dalvik and system. Wiping internal storage is not required. And also the steps which were mentioned just a few posts earlier.

Trust me this rom is perfectly smooth, alot smoother then how lineage was on s9 and s9+ earlier.
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
Cannot agree more. Was able to squeeze out 5.5 hrs of SOT compared to 4.5hrs on stock. Works well for me.. i am also using GCam and camera port from Asus Rog phone (no issues) and I have got the gallery app changed to Asus Gallery for better UI and keep track of deleted photos.
[Samsung Galaxy S9 & S9+ Cross Device Development] crewpuk13th:
Which gcam are you using? Can you share it with me?
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
Download the 2nd file from here. Its version 3.5

https://www.celsoazevedo.com/files/android/google-camera/dev-idan/

---------- Post added at 05:34 PM ---------- Previous post was at 05:31 PM ----------

I ran into a crazy situation early today. The phone just started flickering and started having random reboot to TWRP. I tried wiping cache and dalvik/ART runtime; however, that did not resolve the issue. I had to reflash the ROM to get my phone working. Can anyone tel if you faced similar issues. By the way, this was post 24hrs of successful use.
[Samsung Galaxy S9 & S9+ Cross Device Development] okias:
Hello :)

Do you plan mainline your work into Official LineageOS tree?

Also please release source code.

Thank you
[Samsung Galaxy S9 & S9+ Cross Device Development] crewpuk13th:
Thanks for the camera cheers, [emoji482]

For your problem, I suggest you to provide a logcat, so the dev can find out what is the problem.
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
I am okay with it as it was just a one time issue. If the issue persists, I will report with Logcat.

Btw battery have been amazing, may be HWC is the issue.
[Samsung Galaxy S9 & S9+ Cross Device Development] Benphire:
Finally! It's So Nice To Have Some Kind Of Active Development On Custom Roms Again And This One Works Great! Just A Couple Of Issues I'm Having And Hoping Somebody Has A Solution To The Problem's I'm Having

Issue #1 SELinux Isn't Enforcing But I Don't Think There's Anything I Can Do About That But Maybe I Can I'm Not Sure

Issue #2 Some Google Apps Crash And Don't Start Up At All Like Google Photos Regardless Of Having A Google Account Logged In Or Not

OS Build Date: 7/01/2019

Phone Model: S9+ SM-G965F

Hopefully Someone Here Can Help Me Out But If You Can't Or Don't Want To Then Thanks For Reading Anyway And Have A Great Day Or Night!
[Samsung Galaxy S9 & S9+ Cross Device Development] bdwilk:
Photos works fine here. Maybe it's your gapps package causing the issue. I'm using bitgapps. It's even lower than opengapps pico.

https://www.mediafire.com/file/28jqzs1zshpdw8l/BiTGApps-arm64-9.0.0-v0.9.zip

https://xdaforums.com/android/software/arm64-bitgapps-pie-9-0-0-t3828515/post77315552
[Samsung Galaxy S9 & S9+ Cross Device Development] intervigil:
Had a go at doing exactly these steps, I'm still hung at the boot splash screen (The one showing "Samsung Galaxy S9 Secured by Knox Powered by android").

The Samsung download mode identifies this unit as G960F running CSF2.
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
Somtimes it does get stuck on splash screen. Try just a normal restart. If the issue persists than I would suggest first flash any other room and then follow through the stated process. Not really sure why you facing things issue, you shouldn't be facing if you have followed through the process.:confused:
[Samsung Galaxy S9 & S9+ Cross Device Development] Muntasir Mahmud Saif:
any gcam that works?
[Samsung Galaxy S9 & S9+ Cross Device Development] andreMusers:
try ini bro https://www.celsoazevedo.com/files/android/google-camera/dev-idan/
[Samsung Galaxy S9 & S9+ Cross Device Development] parrenin:
Great work!

Very nice to see LOS 16 coming to the s9/S9+!

Congratulations to the developers!

I will install it and make a donation when it becomes official.

Thanks.
[Samsung Galaxy S9 & S9+ Cross Device Development] bdwilk:
Omg. Official? Why? My mouth dropped to the floor when I read that. Bwahahahaha
[Samsung Galaxy S9 & S9+ Cross Device Development] Crazy_Fox:
+1 from me.

Official state is a sign of ROM maturity, following LOS standards and definitely worth of donation and appreciation :)
[Samsung Galaxy S9 & S9+ Cross Device Development] Dr.Fr4nk3n5731n:
Thank you very much for the LineageOS 16 port for the S9 that actually works reliable, I really appreciate that? Is there some way I can help/support you? Maybe providing a OTA server for OTA updates or an alternate download mirror for the ROM?
[Samsung Galaxy S9 & S9+ Cross Device Development] murtzsch:
looking at users' reactions, it looks promising.

Will try it when full source gets released, that's the whole concept of using Lineageos : using something that can be trusted not to contain spyware/malware/whatever, something that can be fully rebuilt.

Keep up the good work, looking forward to use it !
[Samsung Galaxy S9 & S9+ Cross Device Development] Zwulf:
[MENTION=7381301]Synt4x[/MENTION]93

Thanks a lot for this ROM! Only way to use my S9 without any proprietary stuff. Working great, no problems so far.

Will donate soon. :)
[Samsung Galaxy S9 & S9+ Cross Device Development] omniaholic:
hi, i will donate too when it becomes official

omniaholic (davrek)

:good::good::good:
[Samsung Galaxy S9 & S9+ Cross Device Development] nicomari29:
where i find the CSF2 vendor.img?

sorry, i find it
[Samsung Galaxy S9 & S9+ Cross Device Development] Akhayev:
What is the changelog for the latest build?
[Samsung Galaxy S9 & S9+ Cross Device Development] bdwilk:
He's already explained many times why it's not released yet. They have to manually add things to get it to work correctly right now. The device tree isn't ready for buildbots and would cause havoc if released right now.

I was always told the Samsung community was cancer. Now it shows it's true colors. If you're going to donate then donate. Trying to persuade/blackmail someone who is working on something and providing it for free to others is outrageous.

I personally hope it never goes official. I don't want any of you to enjoy it.
[Samsung Galaxy S9 & S9+ Cross Device Development] Zwulf:
In principle I agree. But I saw this kind of posts starting many flamewars in S3 community back then, many threads were closed. That was awful. I think it makes more sense to tell people in a calm way where they go wrong. Understand your feelings though and this "will donate when it's ready" stuff makes me very angry as well.
[Samsung Galaxy S9 & S9+ Cross Device Development] bdwilk:
I feel ya. To be honest, I was being calm. Haha. I've seen more threads close because of the other posts and devs being frustrated with the type of users who voice their fake supportive opinions. I was a little saddened to see it released here as this is inevitable nowadays on XDA. At least on other platforms those users will be banned or at least warned before it gets out of control.

:good:
[Samsung Galaxy S9 & S9+ Cross Device Development] MidnightDevil:
I've been using this rom since it's been in testing., it was always smooth, battery life sure beats OneUI in my experience, it was the only the only rom it kept me out of stock for a few weeks now!

Thanks so much!
[Samsung Galaxy S9 & S9+ Cross Device Development] andermartinezl:
Hi, how is the camera compared to the stock one? Im really interested to unlock the BL for installing this ROM but i don't know how is the camera quality. Thanks!
[Samsung Galaxy S9 & S9+ Cross Device Development] bobandar:
Camera quality is good and with gcam it can be said the quality gets better than stock. Also opencamera is available which is also pretty good not like before how it used to be.
[Samsung Galaxy S9 & S9+ Cross Device Development] Akhayev:
Endurance kernel works but when u enter your pattern the screen goes black and doesn't unlock

And on the latest build dual speakers not working too
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
GCam Works well, if that is enough for you to consider.

Camera is good; however, it will again be totally on what app you have been using. For me i have got some great shots while i was using GCam and Asus Rog phone camera. Contrary to this, the stock cam does a OKAY job.

Use either of the apps. BTW, super slow motion will not work, just in case you were interested to keep that feature :p

---------- Post added at 07:09 PM ---------- Previous post was at 07:06 PM ----------

Can anyone else point to the direction of the changelog for the latest build, i am not able to see any :(
[Samsung Galaxy S9 & S9+ Cross Device Development] LavaSnake54:
According to the "what's working" list and [MENTION=5537575]Akhayev[/MENTION], the changelog is:

HWC now doesn't work

Dual speakers now don't work
[Samsung Galaxy S9 & S9+ Cross Device Development] andermartinezl:
Thanks both of you for the answer, tonight i will install this ROM and try it. To be honest the super slow motion is not a feature that i use so is not important for me. :) thanks the developers for making this possible. :good:
[Samsung Galaxy S9 & S9+ Cross Device Development] Vabby:
how do i disable sim card? there is no option present :(, both sims are working at all times
[Samsung Galaxy S9 & S9+ Cross Device Development] zeyaan:
then i would prefer to stick to the original build. Cannot afford to loss HWC working as this my lead to loss in battery life (my understanding, please correct me if i am wrong).