[OnePlus 3T Guides, News, & Discussion] Deleted member 4405529:
After a night with less than enough sleep, I belive I'm going crazy. I'm pretty sure something's wrong in my brain after looking too long at the same lines and I really need some help to unlock my brain again.

We agree that (for los16/oneplus3) that the block from line 768 to 788 needs to be deleted: https://github.com/nvertigo/android...blob/nlos-16.0/configs/manifest.xml#L768-L788

This should be easy with sed:

ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $ sed -e '768,788d' /tmp/manifest.xml >/tmp/t2

I assume that the block (marked above in git) is deleted now, but look at this:

ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $ colordiff -u /tmp/manifest.xml /tmp/t2
--- /tmp/manifest.xml 2019-07-18 09:27:39.296058200 +0200
+++ /tmp/t2 2019-07-18 09:49:34.846269326 +0200
@@ -766,27 +766,6 @@
</interface>
</hal>
<hal format="hidl">
- <name>vendor.lineage.livedisplay</name>
- <transport>hwbinder</transport>
- <version>2.0</version>
- <interface>
- <name>IAdaptiveBacklight</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IDisplayModes</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IPictureAdjustment</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>ISunlightEnhancement</name>
- <instance>default</instance>
- </interface>
- </hal>
- <hal format="hidl">
<name>vendor.lineage.power</name>
<transport>hwbinder</transport>
<version>1.0</version>
ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $

Ok, I thought, let's decrease start line and end line by one:

ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $ sed -e '767,787d' /tmp/manifest.xml >/tmp/t2
ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $ colordiff -u /tmp/manifest.xml /tmp/t2
--- /tmp/manifest.xml 2019-07-18 09:27:39.296058200 +0200
+++ /tmp/t2 2019-07-18 09:51:25.986269375 +0200
@@ -766,27 +766,6 @@
</interface>
</hal>
<hal format="hidl">
- <name>vendor.lineage.livedisplay</name>
- <transport>hwbinder</transport>
- <version>2.0</version>
- <interface>
- <name>IAdaptiveBacklight</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IDisplayModes</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IPictureAdjustment</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>ISunlightEnhancement</name>
- <instance>default</instance>
- </interface>
- </hal>
- <hal format="hidl">
<name>vendor.lineage.power</name>
<transport>hwbinder</transport>
<version>1.0</version>
ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $

Strange, isn't it? But I can make it even mote strange. Let's cut from line 768 to 787:

ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $ colordiff -u /tmp/manifest.xml /tmp/t2
--- /tmp/manifest.xml 2019-07-18 09:27:39.296058200 +0200
+++ /tmp/t2 2019-07-18 09:54:39.826271669 +0200
@@ -765,26 +765,6 @@
<instance>default</instance>
</interface>
</hal>
- <hal format="hidl">
- <name>vendor.lineage.livedisplay</name>
- <transport>hwbinder</transport>
- <version>2.0</version>
- <interface>
- <name>IAdaptiveBacklight</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IDisplayModes</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IPictureAdjustment</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>ISunlightEnhancement</name>
- <instance>default</instance>
- </interface>
</hal>
<hal format="hidl">
<name>vendor.lineage.power</name>
ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $

ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $ sed -e '768,789d' /tmp/manifest.xml >/tmp/t2
ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $ colordiff -u /tmp/manifest.xml /tmp/t2
--- /tmp/manifest.xml 2019-07-18 09:27:39.296058200 +0200
+++ /tmp/t2 2019-07-18 10:08:08.535812187 +0200
@@ -765,28 +765,6 @@
<instance>default</instance>
</interface>
</hal>
- <hal format="hidl">
- <name>vendor.lineage.livedisplay</name>
- <transport>hwbinder</transport>
- <version>2.0</version>
- <interface>
- <name>IAdaptiveBacklight</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IDisplayModes</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>IPictureAdjustment</name>
- <instance>default</instance>
- </interface>
- <interface>
- <name>ISunlightEnhancement</name>
- <instance>default</instance>
- </interface>
- </hal>
- <hal format="hidl">
<name>vendor.lineage.power</name>
<transport>hwbinder</transport>
<version>1.0</version>
ingo@adler /usr/local/src/los16/device/oneplus/oneplus3 $

As you can see, cutting from 768 to 787 works as well as 768 to 789, but as soon as I try to cut from 768 to 788 it gets strange.

I've compiled two different sed versions (4.5 and 4.7) and compiled a busybox with sed: all three seds show the same behaviour.

Please help me unwinding this.

EDIT: some hours of sleep helps: I should finally learn to read diffs. It's as expected and working, of course...