yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S 5 Unified Development] haoyangw:
Screenshots​

Coming soon
[Samsung Galaxy S 5 Unified Development] durukanx:
Where is download link ?
[Samsung Galaxy S 5 Unified Development] vlad3647:
No link
[Samsung Galaxy S 5 Unified Development] haoyangw:
Sorry about that! Was finding the link so I created the thread first
[Samsung Galaxy S 5 Unified Development] guest4711:
In first post: https://androidfilehost.com/?w=files&flid=295838

---------- Post added at 06:26 PM ---------- Previous post was at 06:25 PM ----------

See first post: https://androidfilehost.com/?w=files&flid=295838
[Samsung Galaxy S 5 Unified Development] durukanx:
Ok,thanks :good:
[Samsung Galaxy S 5 Unified Development] DevilEyes212:
More variants

If you made it supported for other klte variants it would be awesome :).
[Samsung Galaxy S 5 Unified Development] fbs:
llvm 8?
[Samsung Galaxy S 5 Unified Development] pascua28:
Thanks for the build. Just asking, but if you don't mind, can you also build an optimized pie rom? Cause there are no other roms with compiler optimizations. Here's another tool chain to play with https://developer.qualcomm.com/software/snapdragon-llvm-compiler-android
[Samsung Galaxy S 5 Unified Development] cbr69er:
Couldnt get this baby going. Froze during install on twrp 3.3.0. Tried twice with gapps, didnt try without. Came from pie on first install so cleaned house, next one followed instructions to the letter and same result. Anyone else? Can someone try without gapps?
[Samsung Galaxy S 5 Unified Development] flyingsaucer75:
Following your hard work and thanks a lots for your effort
[Samsung Galaxy S 5 Unified Development] haoyangw:
Oh sure, I'll work on it when I find time! But I'll prioritise this nougat ROM cos this is my daily driver haha xD And interesting suggestion about the compiler, I was trying to figure out how to use it(enable it) in the android build system lol but I got carried away. On my to-do list! Both of them! Thanks :) Especially for your wonderful kernel, was looking through your commit history for some cherry-picking but there were so so many good ones! XD
[Samsung Galaxy S 5 Unified Development] haoyangw:
Hmm I can't seem to find arm binaries for it lol, but I'll try to compile using snapdragon llvm 6 next build! Thanks :)

EDIT: Also on my todo list is building using gcc 7/8! I'm still deciding between using (slightly) outdated uber toolchain builds or the latest linaro android toolchain xP and whether to use gcc 8, I'll compile and try if I face too many (unfixable) compilation errors I'll use gcc 7 instead! Heard there are many optimizations compared to (really old) 4.9, especially with -o3 and graphite :)
[Samsung Galaxy S 5 Unified Development] haoyangw:
Heads up! Successfully incorporated random driver from linux 4.12 mainline(yay) and vnswap! Compiled successfully and after some preliminary testing all is well :D will commit the changes neatly and push to my github then upload a kernel zip :) not sure if it's the new driver + vnswap or the -O3 flags, but ROM feels noticeably smoother hmm(or maybe because I tested on a clean flash 2ith no apps installed lol, vs my personal 80+ apps D: )
[Samsung Galaxy S 5 Unified Development] haoyangw:
What device do you have? I only built for the klte for now sorry, so if you have kltekor or klteduos etc, you might face issues :( hmm also I think I'm still on twrp 3.2.0(oops), I'll update my twrp and test out myself too
[Samsung Galaxy S 5 Unified Development] cbr69er:
Hi, my device is a klte g900w8. It must be the twrp version not playing nice. Thanks for doing all this for us and breathing new life into 7.1 and our gs5's! Btw, Im using twrp 3.3.1 not 3.3.0
[Samsung Galaxy S 5 Unified Development] haoyangw:
Ok I'll test out twrp 3.3.1! Haha honestly I just started this cos oreo and pie ROMs' battery life wasn't good enough for my daily usage and I missed the crazy optimized ROMs from previous popular devices like my late Galaxy S4 xD so nougat ftw it is :D fast stable and long-lasting battery
[Samsung Galaxy S 5 Unified Development] fbs:
for the kernel I'm using gcc 9.1
[Samsung Galaxy S 5 Unified Development] pascua28:
I use latest linaro GCC. I'll try to fix some warnings first. Those maybe used uninitialized warnings seems harmless but they might caused panics
[Samsung Galaxy S 5 Unified Development] cbr69er:
Couldn't agree more about battery life on o and p. Im currently on haggertk's latest los 14.1 update and surprisingly the battery is not so great either but I think I need a new one anyways. I hear ya, I wish slim roms was updated. :( Im happy to help out with testing and report any bugs as that is all Im really good at lol
[Samsung Galaxy S 5 Unified Development] haoyangw:
Oh you're using linaro 7.4? I tried to use it the whole of last night but it's missing ld.gold and also cloog and isl :/ then I tried compiling linaro 8 but that failed too D: Gonna try again later using crosstool-ng, hopefully I can finally get a optimization+friendly linaro toolchain with ld.gold :)

Aside, SDClang only compiles with gcc 4.9 and below for idk what reason >:( Something to do with the linker but I don't understand lol. Pretty pissed but will investigate further, I think I found a potential fix. Fingers crossed
[Samsung Galaxy S 5 Unified Development] pascua28:
Linaro doesn't support graphite optimizations, but you can compile linaro with cloog in order to use graphite. Ubertc is compiled with cloog by default so it supports graphite, but ubertc is more of a bleeding edge toolchain. Sdclang doesn't have a linker by default that's why it depends on gcc; gcc is only use for linking when you use sdclang so you don't have to use the latest gcc
[Samsung Galaxy S 5 Unified Development] flyingsaucer75:
Please if you can build for klteduos. Thanks in advance!
[Samsung Galaxy S 5 Unified Development] haoyangw:
Yeah I realised that the last time I used linaro, it gave many internal compiler errors xD but no worries I successfully compiled (Linaro?) GCC 8.3 from source with cloog, isl and osl support so graphite works now haha. Not sure whether it's actually Linaro though, when I clicked on the link on Linaro's downloads and releases for GCC 8 I got redirected to ARM's GCC 8 download page lol. Ah about the sdclang part, was wondering why I kept getting segfaults with newer gcc versions, sdclang must have been compiled against GCC 4.9's linker. Thanks :) I think I figured out a workaround to use new GCC versions

Aside, some updates! Couldn't release a build these past days because there were so many compilation errors lol. So what I'm trying to do for the next release is compile using SDClang and GCC 8.3. I managed to fix the compilation errors with SDClang (yay), so it's just kernel compilation errors caused by new GCC warnings that trigger -Werror problems. Trying to fix the warnings properly rather than just disable the new warnings, so it's taking a while. But I think it's worth it! Wait for it :) When I'm done committing the changes into a nice linear history on github, I'll publish a new build! I'll try to provide a proper local_manifest too with proper documentation on my own changes if anyone is interested in what happens behind-the-scenes, but that'll take a while as I'm working part-time now, limited time xP
[Samsung Galaxy S 5 Unified Development] pascua28:
Nice. Thanks for your work. I also experience clang segfaulting when compiling a 3.18 kernel. I just leave it as it is, it segfaults throughout the build, but still the output is fine
[Samsung Galaxy S 5 Unified Development] haoyangw:
Oh weird when it segfaults my make/ninja build fails instantly lol xP haha but nvm I worked around it
[Samsung Galaxy S 5 Unified Development] pascua28:
Did you specify clang triple? I'm interested in clang'ing the kernel too. Don't know if I have time to do that, along with LTO build
[Samsung Galaxy S 5 Unified Development] haoyangw:
Oh how do you specifiy clang triple? What I did was modify some soong files to hardcode the gcc 4.9 libraries, and also build/core/combo/clang/TARGET_arm.mk to hardcode the '-B' clang option to the gcc 4.9 bin directory, plus build/core/combo/TARGET_linux_arm.mk to hardcode the gcc 4.9 libraries as well. That fixed the segfualts in clang for me, I'll try and upload my detailed changes soon if you need
[Samsung Galaxy S 5 Unified Development] pascua28:
Specify the environment variable with CLANG_TRIPLE=arm-linux-androideabi and adding -fno-short-enums and -fPIC flags. Although this guide is simpler: https://developer.qualcomm.com/forum/qdn-forums/software/snapdragon-llvm-compiler-android/33437
[Samsung Galaxy S 5 Unified Development] haoyangw:
I don't understand what that does lol sorry. Are these the steps to enable clang on kernel compilation? Or is that supposed to fix the segfaults?
[Samsung Galaxy S 5 Unified Development] fbs:
Saw a huge smoothness going back from LOS16 to this rom. I don't know if most of it is just because 14 is lighter or if o3 had an impact on it
[Samsung Galaxy S 5 Unified Development] pascua28:
It enables clang for compiling C sources, I think. The instructions seem straightforward

Disregard my instructions about clang triple and compiler flags.
[Samsung Galaxy S 5 Unified Development] haoyangw:
Before I begin I do apologise for the lack of updates from me the past few weeks :( I realised I didn't really think things through properly before I switched toolchains lol because aosp enables Werror for many libraries and newer clang and gcc produced so many new warnings, which got tuned into errors by Werror xP Yeah and I don't how to code so I took very long to fix the errors. But rest assured I am working hard on fixing the compilation errors and currently the build is about halfway through! Hopefully the rest of the libraries left produce easy-to-fix errors so I can release a build soon :) I have already fixed all kernel compilation errors! Just ROM-side(gosh which is so much worse than I thought) But I'll definitely take a day or two to test the new build when it's done before I upload to make sure I didn't make any silly mistakes. Aiming for a release next week! But I won't be including July patches in the build as my source tree is really messy now and won't survive a repo sync lol. By end of July I will strive to release patched July build! Thanks everyone for your interest and suggestions :)

PS: Thinking about supporting other variants too. I'm thinking klteduos and kltekor, any other suggestions? Will try to release for them for August :)
[Samsung Galaxy S 5 Unified Development] vlad3647:
Wonderful news ,thanks haoyangw
[Samsung Galaxy S 5 Unified Development] pmduper:
Hi mate.

Thanks for you hard work for our device.

Can I suggest kltedv variant?

Thank you ?
[Samsung Galaxy S 5 Unified Development] haoyangw:
Ok :)

Btw are people using the sswap test kernel?? Saw a few downloads lol xD Just fyi it's patched using DualbootPatcher sorry so can't use directly. If anyone is interested I'll upload a 'normal' zip to install for a primary ROM. If yall see any bugs do tell!! Thanks :)
[Samsung Galaxy S 5 Unified Development] vlad3647:
thanks

it will be great
[Samsung Galaxy S 5 Unified Development] Adzkii:
looking to switch back to los 14.1
[Samsung Galaxy S 5 Unified Development] haoyangw:
Build succeeded!!! But I'm deleting the build and rebuilding because I faced too many errors along the way, a clean compile would be a better idea. Will upload a new build tmr morning if testing goes well, yay :) finally got all the errors
[Samsung Galaxy S 5 Unified Development] vlad3647:
yuppiiiiii
[Samsung Galaxy S 5 Unified Development] Tony-kingston:
Plz helps how fix offline charging? Bootloop after connect charger when phone is off.
[Samsung Galaxy S 5 Unified Development] temoxperia:
Offline charging

Offline charging not working
[Samsung Galaxy S 5 Unified Development] vlad3647:
no data or wifi,i went back to the 1
[Samsung Galaxy S 5 Unified Development] haoyangw:
Yes I have uploaded a new build but heads up the kernel is broken so no data or wifi. There are also random reboots. To fix, flash the sswap kernel, or the boot.img from the precious release. Next time, just be wary before you flash a build I have not notified of in this thread as it is likely untested, or contain issues that I am still currently fixing, so don't use it as daily driver. Thanks for the report though :)
[Samsung Galaxy S 5 Unified Development] haoyangw:
Sorry guys I don't know how to fix that :(
[Samsung Galaxy S 5 Unified Development] BlueCyclone:
Pretty sure this was an issue for a while when Oreo was coming out. Workaround was to only charge online, or else charge in TWRP if you want your rom offline
[Samsung Galaxy S 5 Unified Development] haoyangw:
Ok sorry for the SIM card issues in the latest build, there's something funny with the kernel, I get RLOG-RIL-QMI unable to connect and permission denied errors, plus random reboots from Unbalanced irq in enable_irq function call. Anyone knows what's the problem or how to fix? Can't figure this out :(

For users, make sure you flash either the sswap kernel or the boot.img from the previous release
[Samsung Galaxy S 5 Unified Development] vlad3647:
Walaaaa is working fine for me ,thanks
[Samsung Galaxy S 5 Unified Development] fbs:
for kernel I think you should recommend mine :P

no more versions btw?
[Samsung Galaxy S 5 Unified Development] StayedUp:
Great Rom
[Samsung Galaxy S 5 Unified Development] CStadler:
Thanks for the rom, really appreciate it and love that someone is putting effort into a nougat rom, battery is great!

Just curious about the optimisation...

The O3 GCC optimisation, is that rom or kernel sided? (Since i use a different kernel)

And how is it different from using a better optimised toolchain?
[Samsung Galaxy S 5 Unified Development] haoyangw:
Oh sorry about that, let me explain. So recently I got a new Single-Board Computer that I was really excited to setup but took me a long time, so I had to take 2 weeks off the project :( And then I'm currently preparing some gifts for my friends who will be travelling overseas soon, which is again taking a lot of time off the project. But do be reassured that I'm still committed to this project, and I am determined to fix the kernel issues that have arised recently from using a newer GCC version. I hope you all may have patience! It may take some time as I'm new to ROM stuff and need a lot of Googling to learn things xP Thanks for all your support and interest though!
[Samsung Galaxy S 5 Unified Development] haoyangw:
Ah good question, it's applied on both the ROM and the kernel, so if you change the kernel the O3 optimizations there will be gone, unless you use another -O3 kernel.

As for your second question, the -O3 optimization refers to usage of a GCC/Clang flag. There are a total of 5 such flags, namely -Os, -O1, -O2, -O3 and -Ofast. -Os is the default used by Android, which tells GCC/Clang to prioritise code size optimizations, resulting in smaller code. -O1, -O2 and -O3 refer to the level of optimizations GCC/Clang will apply to code, with -O1 have the least optimizations, while -O3 having the most optimizations, as complex optimizations are also enabled. -Ofast produces the fastest code of all, as it enables all optimizations there are, but is also the least stable as it is known to break the sqlite implementation on Android, plus other issues with enabling excessive optimizations. All 5 flags are supported by all GCC/Clang compilers.

Now, what about optimized compilers, like say Linaro or SaberMod? Optimized compilers are designed to use better algorithms in producing code such that some basic optimizations are already applied without the use of the above 5 flags. The difference is, the above 5 flags enable more advanced optimizations that are on a opt-in basis, while those applied by optimized compilers are standard-issue(and proven stable), and will be applied no matter what flags you pass to the compiler. So basically, -O3 enables more optimizations than using an optimized compiler, resulting in even faster code.
[Samsung Galaxy S 5 Unified Development] CStadler:
Thanks for the in depth explanation! When you mentioned GCC/Clang compilers, are they the same thing or do they compile different parts? Or is it like optimisations stacked on each other?
[Samsung Galaxy S 5 Unified Development] fbs:
I'm compiling my kernel with gcc 9.1 already.. I'm interested in the optimized ROM itself.. :P
[Samsung Galaxy S 5 Unified Development] LightC:
is there any way to get the notifications themed to black in LineageOMS? I'm using the substratum Swift Black substratum theme but cannot get the notifications to change from white. I think this might be a Nougat limitation but I'm not sure.

I came from the RR klte pie rom.
[Samsung Galaxy S 5 Unified Development] haoyangw:
GCC and Clang are two different compilers that can do the same thing. GCC is older and more widely used, while Clang is quite new but is becoming more popular recently because it's better(produces better code). They support the standard optimizations
[Samsung Galaxy S 5 Unified Development] haoyangw:
Yeah I saw your kernel, it's really very impressive indeed :) I'm gonna try and squeeze some time out one of these days to fix the remaining problems
[Samsung Galaxy S 5 Unified Development] haoyangw:
I'll have to dig around Github a bit, I'll let you know if I find something :)
[Samsung Galaxy S 5 Unified Development] Steam.:
Thank you for this ROM, everything seems smooth and fast. I'm staying on the 1st build until everything is fixed. But can you answer on why the phone is charging so slowly? I left it on 20ish percent at 10pm, at 1 am it was barely 90%. It says charging slowly on the bottom of the lock screen, and this didn't happen on stock. I tried 3 different chargers with 3 different cables, it's not a charger issue. They're all 2A and above.
[Samsung Galaxy S 5 Unified Development] CStadler:
Before Lineage 14 with OMS i used this substratum theme which worked for making notifications black even without OMS (aospUI Black)

https://play.google.com/store/apps/details?id=substratum.piereligio.bst
[Samsung Galaxy S 5 Unified Development] LightC:
I've used PitchBlack and Swift Black substratum themes previously with other ROMs and the notification are themed to black. It seems like Nougat has this limitation. Have you tried aospUI Black with a Nougat rom?
[Samsung Galaxy S 5 Unified Development] CStadler:
Yes, not on s5 tho but on my previous device with Los14.1, and aospui black was the only way i managed to theme the notifications black using substratum
[Samsung Galaxy S 5 Unified Development] pascua28:
I tried gcc 9.1 and it catches more errors and warnings which is good for stability. But I haven't noticed any difference in performance. Plus gcc 8 is the latest stable version for gcc. Might have to wait for linaro tool chain update. I'll just use gcc 9 for reading some warnings, although some of them looks false positives
[Samsung Galaxy S 5 Unified Development] LightC:
AOSPUI Black did indeed work to get black notifications. Thank you for the tip, [MENTION=8187951]CStadler[/MENTION]!
[Samsung Galaxy S 5 Unified Development] Gbrl95:
I tried installing the ROM as per instruction, but my simcard is not detected. I tried without gapps but still the same. Please help, thank you!
[Samsung Galaxy S 5 Unified Development] haoyangw:
I don't know actually, it might be a hardcoded value in the LineageOS kernel, I'll have to check. I'll let you know if I find anything
[Samsung Galaxy S 5 Unified Development] haoyangw:
Flash another kernel, like my sswap kernel, or either the awesome Tuned kernel or the amazing Intelli Kernel.
[Samsung Galaxy S 5 Unified Development] haoyangw:
Good news btw! I have successfully figured out the cause of the sim card and random reboot issues in the latest release, expect a new build today or tomorrow with everything working! Will not be incorporating July security update though, haven't found time to clean up my source tree, if I do a repo sync now I'm gonna lose all my changes which took hours D: I'm working on it though, I promise!
[Samsung Galaxy S 5 Unified Development] Gbrl95:
Thank you for replying to my inquiry. I'll give it a shot probably this weekend, because I'm using this phone as my daily driver.
[Samsung Galaxy S 5 Unified Development] LightC:
Looking forward to the next build.

Is there any way to show the charging rate in amps on the lock screen similar to how it is done in Pie resurrection remix?

Also what are the benefits of flashing those other kernels if they are not compiled with all the optimization tweaks?
[Samsung Galaxy S 5 Unified Development] haoyangw:
Hmm I'm not a LineageOS dev and I don't intend to add any features apart from optimizations to this ROM, so i can't do that :( Perhaps you can find an app that can display the charging rate as a notification. As for your second question, -O3 and graphite flags applied on the kernel actually brings very minor performance improvements compared to doing that on the ROM, so no matter what kernel you change to, the performance loss(if any at all) will not be noticeable. Besides, Intelli Kernel is already compiled with -O3, plus it already has numerous more performance improvements than stock LineageOS kermel has, and Tuned kernel is already heavily optimised(it has its own cpu governor and hotpluging mechanism yo!) even without the -O3 and graphite optimizations, so if you choose these two kernels, I would say performance would be similar, if not better than with my ROM's default kernel. So don't worry about changing the kernel :)
[Samsung Galaxy S 5 Unified Development] haoyangw:
Finally got a successful build! I've tested it, sim card works and so does everything else! Download it here. Changes since 240619 build(0807 build is ignored because it is problematic):

-Compiled using latest Linaro GCC 7.4 snapshot(compared to Uber GCC 4.9 in 240619)

-SDClang 6.0.2 enabled

-Kernel compiled using -O2 instead of -O3 for stability(fixes sim card issue, not sure why). Based on my testing and benchmark results online, the difference is negligible

Note that the security patch is still 5 June 2019 as I have not found time to do a repo sync sorry. Will intend to update to August security patch the next build!
[Samsung Galaxy S 5 Unified Development] biship:
Looking forward to a kltedv build!
[Samsung Galaxy S 5 Unified Development] flyingsaucer75:
Looking forward to a klteduos build! Thanks
[Samsung Galaxy S 5 Unified Development] mhraqeeb:
I can't flash any custom kernel with 30/7 build it turns me to download mode. What is the reason
[Samsung Galaxy S 5 Unified Development] haoyangw:
By download mode you mean twrp/recovery, correct? If that's the case, I believe I know what you're talking about
[Samsung Galaxy S 5 Unified Development] vlad3647:
So far so good,excellent job thanks
[Samsung Galaxy S 5 Unified Development] fbs:
I dirty flashed 3007 and got "Can't do normal boot. Odin Mode" right after rebooting. I had to flash back the june version again to use my phone :P

Are you sure this 3007 .zip package has a valid "boot.img" (kernel) ?
[Samsung Galaxy S 5 Unified Development] haoyangw:
Hmm, I dual-booted this kernel and it works, but maybe primary booting is a different matter
[Samsung Galaxy S 5 Unified Development] mhraqeeb:
No the ODIN mode
[Samsung Galaxy S 5 Unified Development] DevilEyes212:
Tuned kernel for SGS5 on telegram

May you join tuned kernel telegram channel? ˘:)
[Samsung Galaxy S 5 Unified Development] godofsalt:
I second that......

Edit....

Wait a second. I do see all the "Settings"

( through "wireless and netork"... Then "Cellular Networks".... Then "Access Point Names"...)

I see all the info for KTLEDV. That said, on 30Jul build-it seems to stick to Sprint. Settings for Virgin Mobile do not stick (meaning - "Clicking" on "Virgin Mobile", it will actually switch back to Sprint Networks "

Now, atleast for me, (Virgin) am able to make a call, use Firefox and XDA Labs App. However, " Messages" do not work! (Still trying to finger that out)

If this info can help.....

Tanx