yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
Yes, that's definitely the case.

My strategy at this point is to build two custom kernels, one just disabling the Knox security features and the other adding the MTP fix. My TWRP tarball includes a recovery image using the kernel with the MTP fix, but the boot image doesn't. This allows MTP to continue working on the OEM stock system image.

For my custom ROM (based on AOSP 9.0), both the TWRP recovery and boot images get the custom kernel with the MTP fix.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Aren't you rooted in and booting from recovery, though, like with the S10, N10 and Tab S6? I thought the Tab S5e was a system-as-root device and thus the same in that regard.

That's my issue here. One kernel boots both TWRP and rooted Android, so if I fix MTP for TWRP, I break it when the user boots stock Android. And if I leave everything alone, MTP works in Android, but is broken in TWRP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
I can't speak for the Tab S5e, but the Tab A 10.1 definitely is system-as-root. The difference is that I'm not pushing Magisk on the OEM stock system, which has to dual-boot through the recovery partition. Frankly, that solution seemed inelegant to me, and so I really haven't designed my TWRP distribution with that scenario in mind. If users aren't satisfied using TWRP to make changes to the system partition, they can just use the rooted version of the AOSP 9.0 GSI (ab-gapps-su) that [MENTION=1915408]phhusson[/MENTION] distributes.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
OK, thanks. Now it all makes sense. You're rooting in system. I'm so used to dealing with Magisk that I tend to forget that rooting in system is still an option, but the loss of modules is a deal-breaker for me and many others. Of course, if you're on a custom ROM, you can include much of the functionality that modules add in the ROM itself.

My latest headache is getting a custom kernel to run on the Tab S6. I'm having a hell of a time with that. No matter what I do, I can't get a custom kernel to boot on this device. Something is obviously fundamentally wrong, but I can't figure out what.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] t20190702:
TWRP on SM-G9750

Hello ianmacd,

In your very detailed post you never mention the SM-G9750.

Does it mean that there is no way to install TWRP on thoses devices ?

thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
Hang charging after shutdown?

On the Galaxy Tab A 10.1 (2019) [SM-T510], we're seeing a hang when plugging in the charging cable after a full shutdown. The circular battery charging indicator appears, but then it hangs before it can display the usual animation to the current battery level.

I assume this is related to the kernel modifications or Multidisabler, both of which were adapted from [MENTION=7187684]ianmacd[/MENTION]'s work on the Galaxy S10 (Exynos). Are you seeing anything like this on the S10?

Note: It's definitely not related to the MTP fix, since we can reproduce the bug on earlier builds.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
[MENTION=7187684]ianmacd[/MENTION]

Are you happy with this :

https://xdaforums.com/galaxy-s10/de...3-1-7-magisk-prepatched-t3966521#post80227254
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
If you mean Magisk, no, but it's John's code in the end.

I know he doesn't like this form of distribution of his work, but I wouldn't be surprised if time constraints prevent him from acting.

If you mean TWRP, it's GPL'ed code. Anyone is free to issue their own builds in accordance with the licence.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I just tested this on my Note10+ and I don't see the hang there. I haven't tested the S10 yet.

Incidentally, I have just released v1.5 of the multi-disabler, which now includes support for the Tab A 10.1 as standard. Support has also been added for the A10 - A50 range of devices, and I will continue to support new devices in an effort to provide a one-size-fits-all solution.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
Thanks for checking that, [MENTION=7187684]ianmacd[/MENTION]! Must be something specific to the Tab A.

This is fantastic!! I'll update my post on the Tab A forum ASAP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Version 3.3.1-9_ianmacd for G97[035]F released.

Changelog

v3.3.1-9_ianmacd for G97[035]F [inc. ASH6 kernel (which also works with ASH1 firmware)] (2019-09-17)

Restore working MTP functionality to TWRP. With thanks to bigbiff for the reference and to Geiti for his commit embodying the same fix.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Zonge:
Thanks for all your continued work on this project Ian. One question, when updating what option do I choose in twrp to flash the img? Sorry, I did a search on the thread but could not find the instructions.

Thanks. again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Choose Install, tick the box that you want to install an image, and then select the TWRP image file and flash it to the recovery partition.

Note that you will first need to root the image with Magisk if you also want to be able to boot Android from the same kernel.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Zonge:
Thank you very much, greatly appreciated.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] emariu:
[MENTION=7187684]ianmacd[/MENTION]

Hello,

I would very much like to be able to boot in( Android with magisk root) without having to press combination keys, just by presing normal Reboot in Power menu.

I understood that you can implement a script to automatically do that..Can you please share this?

The phone is a gift for my wife,but she is not technical at all,she will just press Reboot and the applications will not have root anymore :)

Thank you
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
If you have Xposed installed there's a brilliant module called Firefds Kit. With this you can customise the power button. You can even rename and remove some buttons. Screenshots below.

If you haven't yet got Xposed, go HERE for instructions how to install.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] emariu:
It's working... but the phone becomes unresponsive at times..

If I open Google search ,the phone hangs

When restarting I wait a long time to can use the phone..

Is there any other xposed module ,just for customising Power button menu? Maybe I'll have more lack not to slow down my phone
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] redjamesg:
Is there a way to remove magisk once TWRP is installed, I have a situation where it's impossible to hide root from an app, and previously the fix has been to remove magisk and use TWRP to debloat the rom and add a proper hosts file to avoid all irrelevant ads.

But since it's more or less impossible to add TWRP without magisk, I was wondering if it would be possible to remove magisk after TWRP is installed and still keep TWRP as recovery while having the rom status as non-rooted?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Norup58:
Yeah, you can try this Magisk module:

https://xdaforums.com/apps/magisk/module-smali-patcher-0-7-t3680053

I only use the Magisk Reboot (Galaxy S10) option
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NZnewbie:
Hi,

Any better avbtool instructions??. Cant find any googling and each time I try and install TWRP i get the red binary error in download mode.

Thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
Hi guys, I have never used TWRP before for making backups. I normally use it for flashing and titanium for backing up apps and data.

However I want to make a full nandroid back up so that I can experiment with different roms.

When I go into the backup menu in twrp there are so many options: boot, data, product image, system, vendor etc.

My question is do I need to tick them all to make a full backup of my phone? Any advice appreciated thanks!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] redjamesg:
Yes, for a full backup you need to tick every box, usually you can leave out data, dalvic and cache and probably recovery too, but to be on the safe side, select all.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
[MENTION=7187684]ianmacd[/MENTION] I have a rather odd problem with TWRP. Using stock TWRP 3.3.1-8 and LineageOS. When booting from LineageOS into recovery, recovery gets loaded but the screen stays black/dark. Usually I have to press some buttons for several times (or press the screen after some time, it's always different and I couldn't find a pattern so far) and then TWRP shows up. Rarely (1 out of 5 times I would say) TWRP shows up instantly. What could be the problem here?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
I'm on a custom ROM. What the proper procedure to update twrp? I did it the simple way: went to twrp and flashed the updated image. I lost root. the 3 keys combination didn't work any more, so I had to recover my previous installation.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
are we back to TWRP on demand until the new source is out???
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
See the FAQ in the OP for instructions on how to upgrade to the new ASIG firmware, but the answer is basically yes, and with an extra complication caused by incompatibility of the ASIG firmware.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
You should both contact the supplier of your individual ROM to find out whether there are special instructions for using TWRP in combination with it.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Just flash Geiti twrp and keep it FOREVER
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bigpotato107:
I have updated my s10 SM-G973F with latest firmware upate rooted with this twrp and magisk all works until I restore my back ups... I REBOOT AND PHONE JUST KEEPS RESTARTING!!! I can get into twrp and have tried wiping cache etc and still reboots over n over I have wiped it and formatted data still reboots over n over what have I done wrong?? PLZ Help :) I think I figured it out all ok until I uninstalled the 2 Vodaphone apps and restarted my phone it goes into bootloop. can someone recommend a good system app remover plz
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
Tried LOS16 in combination with latest TWRP and FBE enabled.

These are the steps I did:

Until there it works fine. LOS boots up and the stettings menu tells me that files are encrypted. BUT, after reboot TWRP shows up and stucks at the TWRP splash screen. Nothing else works. I can only boot into download mode or stuck with TWRP splash. Only way out seems to be to flash stock again then.

Is this a problem with LOS or TWRP or a combination of both?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I think it's because TWRP can no longer read its own config file, due to the encryption on /data, which is where the file is stored.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] thevmax:
I noticed that Soldier9312s has closed his MOD for discussion and updates (08-10-2019) and his last update was for the ASG8 firmware. So there isn't any way to run the mod with ASIG and your TWRP 3.3.1.9....
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Can someone please point me towards a quick step by step guide for replacing vbmeta in that bl file (if there is indeed one).

What program is able to delete and replace the file? 7zip won't delete it, seems to be those lz4/md5 issues

I'm stuck on step 3 of updating to ASIG at the moment
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] redjamesg:
Unzip the BL package, replace the vbmeta by over writing and re zip the package, if it doesn't end in .md5 Odin won't look for a md5 sum check when flashing
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
i rezipped with 7zip and odin just force closes when i'm flashing the BL and Recovery

edit:nvm it seems odin cant flash zips within a zip hahahaha all good it seems now
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
how do we make a vbmeta.img? or will simply removing that file from bl work??

to say i have had a right time with this is an understatement. all day i have been trying to get my phone on ASIG rooted, i understand we need a lil knowledge for messing about with our phones but there's a steep learning curve every other bloody firmware!:laugh:

quick step by step for making these VBmeta files? i have succeeded in making tars for odin

id rather learn useful stuff than flash a one in all fix but im seriously considering preventing days like today happening again
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Odin can't flash ZIP files at all.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
In the case of upgrading to ASIG, you can simply remove the vbmeta.img from the BL file.

To make a benign vbmeta.img is simple, though. There's a snippet of shell code in the OP that will create one on your device. Just open a terminal on your device, either via adb shell or a terminal app, and run that snippet of code.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
i said zip but meant tar lol :cyclops:

cool thx ill try that :good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
deleted finally seems sorted
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cameronkelley28:
For one thing I noticed that you have two single quotes in d='' on line 6 instead of one double quote.

Regardless of that though, it would be much cleaner and easier to copy and paste the snippet exactly into a shell script and just run the script.

So create something like vb_gen.sh, paste the code into it, then just run "bash vb_gen.sh" (assuming bash anyways)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
ok ill try that,

i flashed TWRP, then rebooted to download, flashed patched stock recovery and bootloader without vbmeta in then rebooted and got the "only official released binaries are allowed to be flashed"

[MENTION=7187684]ianmacd[/MENTION], looks like there's a typo in that code

im going to try making bl with the dummy vbmeta

otherwise im pretty much done here now lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
copying the code exactly into an sh file (that part works) and calling it in terminal emulator

keep getting a syntax error so something's up.

time for plan b as my balls are aching like they're cancerous lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NetSkipper:
Please help!

I've flashed TWRP (magisk patched) 3.3.1-7 (Galaxy S10e ASG8, Magisk root) with Flashify.

After entering TWRP, I've flashed Multidisabler.

My internal storage is probably encrypted, because all that I can see is folders with just letters and numbers. Is my data gone? How?!

Tried to reboot - bootlop, but I was able to get back to TWRP

I've flashed back the stock recovery image, and now I'm in bootlop, and no TWRP.. :(

Edit

: Phew, I dodged a bullet.

Rebooted the phone in download mode, and via Odin re-flashed the same firmware with home_csc.

Booted successfully, all my data intact.

So, how can I use TWRP, temporary, for backing up my data?

I tried to use the switch-recovery script in the OP, and got errors. So I've figured that I'll try the suggested by [MENTION=2539760]Jmakhdoom[/MENTION] "Flash TWRP with Flashify, use it for whatever, then within TWRP, flash back the stock recovery". Also read [MENTION=499148]robbo1947[/MENTION]'s advice not to turn off the phone.

So what went wrong? I wasn't supposed to flash Multidisabler?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Chuytl:
hi, first thanks for your hard work... what are the problems to keep twrp (don't restore stock recovery) when rebooting... i al this because you know there could be something going wrong and face a bootloop if this is the case

Q1: flashing twrp in odin could let me boot it and restore a backup?

Q2: if forgot reflash stock one may i fla**** trough odin too?

Q3: is there a way to make a temp twrpbuild which make te re-stock process automate? or add an option on reboot menu?

---------- Post added at 03:22 AM ---------- Previous post was at 03:17 AM ----------

did you customized the script to your own needs? i mean change paths and file names as the one you have?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
[MENTION=903232]Magendanz[/MENTION] Did you find a solution for that problem? I have a S10e and face the same problem. Enabling FBE, first boot into LOS16 after flashing works, rebooting LOS16 puts me into TWRP splash and there the phone hangs. I wonder if TWRP can be made that way that it ignores the problem of not being able to read its own config. Its bad that it hangs and I also wonder why this works on S10 (like Ian mentioned) but not on S10e.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
I fixed the MTP problem, but not the hang with FBE. I've had many other devices with file-based encryption and my TWRP builds would boot fine, even if the files on those partitions showed as gibberish. It's not clear to me what's going wrong with these specific devices to cause the hang, and I haven't had a day to kill tracking it down.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
I see. I thought I could have a look at TWRP's log but that's impossible too. TWRP hangs at the splash screen and booting the phone into LOS also doesn't work. It always tries to boot into TWRP. Then only download mode works to reflash stock. I wonder how to get a TWRP log in that situation...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Just use Geiti TWRP
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
I'm on that now. No issues :D
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
The code, as given, needed a shell that supports for (( expr1 ; expr2 ; expr3 )) syntax, which unfortunately doesn't include mksh, the Android default. Other shells would work.

I've now rewritten the code to be mksh-compatible.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Wicked thanks man.

I will return to stock probably during the week and reattempt this as I see it as a personal victory should I get this to work (i have been learning r.e code a bit too thanks to the awkwardness of samsung :laugh::good:)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Sorry that I told you to paste the code into a shell on the device itself.

When I wrote that code, I wrote it for Linux. I obviously intended for people to create the vbmeta.img on a computer and then copy it over to the device. By the time you asked your question, I'd forgotten that little detail and thought that the file could be created on the device itself. Unfortunately, I used shell syntax that mksh doesn't support.

That's now remedied, however, and the modified script snippet will run without error on the device itself.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
There's certainly no issue that should affect only the S10e, not not the S10 or S10+. Any set of circumstances that gives you trouble on the S10e should be equally problematic on the other devices.

All my devices have encryption turned off, so I can't non-destructively test your issue. I was guessing that the issue is one of TWRP being unable to read its own config, so take that with a pinch of salt until it's verified as the cause.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
All good man, I was a little stressed by 12am but all good after some of Shiva's tincture and a good night sleep.

A good learning curve for me to so now everything's corrected, and remotivated :D

For my part I should not attempt such stuff whilst enduring the headf%%% of gabapentin withdrawal :laugh::good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
I had a version of init.recovery.usb.rc that managed to bring ADB online before the hang so that I could adb shell into the device and pull the TWRP log. However, I was unable to get adb logcat to dump all log data in the boot process, which would have been more helpful. I've also set TARGET_USES_LOGD, TWRP_INCLUDE_LOGCAT and TWRP_EVENT_LOGGING in my BoardConfig.mk.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
I see. Feels like a big pinch of salt. Do you think you could implement/deactivate some checks so that TWRP wouldn't stuck any longer if FBE is enabled for /data? I would be happy to help testing.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Abaddon:
this should work on G973N right? since it has exynos too?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Narkozzz:
Hello, I have stock S10 ASDA firmware. Rooted it fine and decided to install TWRP. Downloaded and patched it with Magisk 19.3. But now I have only 2 boot options: non-rooted Android and TWRP. If I try to boot rooted OS with 3 buttons - I got restart right on the first SAMSUNG letters appearing and boot into unrooted environment. In FAQ such problem described as custom rom problem, but I have full stock. Multidisabler applied on first TWRP run.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cameronkelley28:
You need to use the version of TWRP that was built on the same kernel as the firmware you're running or it won't boot. I'm not sure what version ASDA is since I only know of ASCA and ASD5 (both quite old now), but you won't be able to boot with just any version of TWRP.

Check the second post in the thread for Ian's changelog and you'll see that it gets rebased on newer kernels as the sources are released. You may be able to use the TWRP based on either ASCA or ASD5, but I would suggest updating to the latest supported firmware (ASH6) and use the latest TWRP from Ian.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Narkozzz:
Thank you very much, I will equalize versions of my firmware and TWRP and try again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
ASDA is a supermarket mate :laugh::good::good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DJBhardwaj:
So, the old instructions that required patching both the AP firmware and TWRP image with Magisk, and then replacing the stock "recovery.img" in "magisk_patched.tar" with the Magisk Patched TWRP image are not applicable anymore?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DJBhardwaj:
[Bump] Anyone?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] OsoAlgo:
See here.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DJBhardwaj:
Okay. So, the method is still the same? Instead of deleting the existing stock "recovery.img", adding the patched TWRP "recovery.img" first and then deleting the prior.

Or, do you think the below would be a better (probably current) method?

1) Patch the AP firmware file using Magisk Manager

2) Boot into Download Mode and flash the Patched AP firmware (patched_magisk.tar) along with CP, HOME_CSC, and BL.

3) Along with following the rest of the steps mention here by John Wu.

4) And then, download the TWRP image, patch it with Magisk

5) Rename the resultant "magisk_patched.img" to "magisk_patched.img.tar" and flash it using Odin (In the AP Slot).

But then it got me thinking, that we already flashed the Patched AP firmware (During Step 1, 2, and 3 above) and then during step #5 will be flashing the patched TWRP image, wouldn't that overwrite Magisk and simply leave the device with TWRP installed?

Sorry, but this is confusing for me right now. New to the S10e that I have and also knew to the new method.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] OsoAlgo:
If I understand correctly, the tar file created for step 5 only contains the recovery image, so it would leave the other partitions untouched; I'm not sure though. Do note that creating that tar can't be done my simply renaming the file and changing extension, you'd actually have to pack the image in a tar file.