yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DJBhardwaj:
I understand now that by simply renaming the file wouldn't do the job. The image has to be properly packed into .tar using the commands mentioned in the OP.

As for the patched TWRP recovery image, it will be flashed to the /recovery partition, right? Isn't that where Magisk exists now on the Galaxy S10 devices? So, that would be replaced, correct?

My S10e is already rooted with Magisk. And now I want to install TWRP as well. But this slight confusion is still there.

.....

Okay, so while writing this comment, I can understand even more. The Patched TWRP is already injected with Magisk. So the recovery image not only contains TWRP, but Magisk too. Am I getting this right, now?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
If your S10e is rooted and you will

only

flash twrp, you can flash the image hishelf by using the app "flashify".

After that boot into twrp

format data =yes(all you stuff will be deleted)

boot again into twrp and flash the multidisabler zip
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
haveTWRP but I can't copy System. I can copy Boot and Data but System not. When I want to copy a System image, TWRP copies but at the end I get the message Failed. What can I do?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Can't make it work, i patched the twrp file using magisk, added .tar to it's name "magisk_patched.img.tar"

flashed using odin putting the file in "AP" and it says pass but when i try to boot it it's the stock recovery.

Also tried with that adb command but still no luck :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
Did you renamed it recovery.img before you tar it? Otherwise it wont work with odin.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
You don't add the .tar on the end. Just patch twrp with magisk then rename it 'recovery' and place it inside the patched AP file. Remember to also delete the original 'recovery' file.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Ok i almost did it, i finally installed the recovery but now the problem is that it bootloops as soon as the "S" of "Samsung" appears.It worked at first but after the button combo vol up-bixby- power button it gives me this.

I've also installed the multidisabler.

Maybe i can fix by flashing a custom rom?Downloading the BeyondROM V5.3 now.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
If this is your first time rooting the phone then you will need to go into twrp and format data aswell. This should fix bootloop.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Yeah i did that as well to remove the encryption. Btw now i have that official binary error again damn, have to flash official fw with odin again :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
Just make sure you follow the instructions carefully by topjohnwoo in the first post of this thread. Don't let the phone boot until you have formatted data and flashed multidisabler.

Good luck! :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Ok guys i finally did it.In the end i flashed the Beyond rom and now root and twrp are finally working fine.

Damn it shouldn't be this tricky to mod a phone, i'm not really sure i'm going to buy Samsung phones in the future.

Btw is it normal that those app from the playstore to reboot directly on twrp doesn't work right?

Also i've noticed the Beyond rom seems not updated anymore, do you know another good up to date stock rom?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
Kernel source is out. ASIG, hope to get new update very soon and than Ian
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Version 3.3.1-10_ianmacd for G97[035] released.

Changelog

v3.3.1-10_ianmacd for G97[035]F [inc. ASIG kernel] (2019-10-07)

Rebase kernel on Samsung's ASIG source code.

Merge latest upstream TWRP commits.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
[MENTION=8000280]GearCEO[/MENTION] your prayers have bene answered lol!

[MENTION=7187684]ianmacd[/MENTION] - im on the Geiti's TWRP at the moment. will I need to return to stock and reroot to have your TWRP working without lock screen issues?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
Love you ianmacd
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
That's possible, because I believe that other version bumps the security patch level date of the boot and recovery images far into the future.

If you want to flash this version, flash it with a stock boot.img at the same time. If you still can't log in after that, you will have to apply the minimum force necessary to reset the device's record of the latest patch level date used to boot the device. I'm not actually sure what the minimum force necessary is, though. Certainly, restoring stock firmware will do the trick, but there might be a less heavy-handed way.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
and now we have a lovely matching TWRP to our ASIG firmware, this should be a standard firmware upgrade apart from the above?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Yes. Users who are not yet on ASIG firmware, however, should update their firmware before installing this version of TWRP. The ASIG kernel will not work with older firmware.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Flash geiti twrp again
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
[MENTION=7187684]ianmacd[/MENTION] Thanks for putting out another version.

I hope you don't mind me asking about this encryption problem once more. Situation is like this: If I keep FBE enabled, format /data and flash LOS16 I have encryption. I can boot into LOS16, set up all the things, save files, access them, etc. But once I reboot (even if I choose to reboot into system) TWRP pops up and hangs at the splash screen. So I assume this is a problem with TWRP. Maybe it hangs because it cannot read it's own config, maybe something else. I don't need to have access to an encrypted /data partition via TWRP. I just need it not to block the reboot process. Could you take a look into that? I would be happy to help with testing.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Does ver 10 work with asii?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] sfofu:
Hello, I flash in TWRP 3.3.1-10 MTP is normal, but the flash in ROM system partition mount fails. May I ask how to solve it
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Hello, I flash in TWRP 3.3.1-10 MTP is normal, but the flash in ROM system partition mount fails. May I ask how to solve it[/QUOTE]

I had the same problem but solved it. It turned out that the SD card was to blame. It had the FAT32 format. It's an old system that blocks larger files. I formatted the card to exFat and it's ok.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinwu128:
Can i get twrp without wiping my phone? Using topjohnwu root on S10. Thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] trancinguy:
Yes you can, use the official twrp app and grant it root and then flash to recovery from storage.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Version 3.3.1-11_ianmacd for the G97[035]F released.

When I merged Samsung's kernel source code for the ASIG firmware revision into my own kernel repository, I somehow neglected to update my kernel configuration with USB gadget support, which is required by Samsung DeX for PC, a new feature on the S10 series. This release rectifies that omission.

Changelog

v3.3.1-11_ianmacd for G97[035]F [inc. ASIG kernel] (2019-10-11)

Add support for Samsung DeX for PC.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
But you may have to format your data to enable it to be readable by TWRP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Would anyone be kind enough to share this if they have tested it:

If I flash asii FW and provided that I'm going to be using the swap recovery script I will be booting to sysytem on the stock asii recovery. That would work of course.

But if I flash TWRP 3.3.1-11 would it be possible to boot to it while on asii FW and would it work (flash a zip or make TWRP backups)? Then of course, flash again stock asii recovery and boot to asii system.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
[MENTION=7187684]ianmacd[/MENTION], have you noticed that the Geiti fix for MTP over FunctionFS requires adb?

For TWRP we can probably assume that's always on, but it's a problem for custom ROMs. Even after tweaking /vendor/etc/init/init.<platform>.usb.rc as we've done for TWRP, MTP won't work unless the user has enabled Developer Options->Android Debugging. (sys.usb.config and sys.usb.state are set correctly, but sys.usb.ffs.ready=0)

Any ideas on how we might fix that?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] To0wnn:
Is it possible that i can not flash Smali patcher file anymore with G973F (S10): twrp-beyond1lte-3.3.1-11_ianmacd.img?

I get ERROR: 1 any fix for this? Tried already the format data but no luck with that.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Android can just use the standard Samsung MTP, can't it? I understood from the TWRP folks that the FunctionFS MTP fix was just for TWRP. Samsung's Android uses a variant of the AOSP implementation of MTP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
No, I had to do the kernel mod to get MTP running on AOSP, which disables USB_ANDROID_SAMSUNG_MTP. Just tweaking tweaking /vendor/etc/init/init.<platform>.usb.rc for FunctionFS would be a much more elegant solution, but I can't get it to work without ADB enabled.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
Flashing v3.3.1-9 from the official TWRP site (I guess this is equivalent to your 3.3.1-11, right?) puts my S10e into bootloop with LOS16 installed. 3.3.1-8 works without any problem.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Yes, official release 9 is the same as unofficial release 11. I wish I could keep the numbering in sync, but circumstances surrounding the official release process can cause two consecutive updates to become consolidated in a single release. The only reliable way to prevent this would be to delay unofficial releases until the official one has ground its way through the mill, but most people prefer the unofficial releases, precisely because they appear sooner rather than later.

The 9 official/11 unofficial release is based on ASIG firmware. I suspect that LOS16 is not. Pre-ASIG bootloaders and post-ASIG kernels don't mix, and vice versa.

Flashing an ASIG or later bootloader may fix your problem, but I have no experience with LOS16, so I couldn't say for sure.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I just can't keep in my head that you're using AOSP. I'm so used to stock firmware.

What is the actual scope of the problem? By that, I mean: Is there really anyone who runs a custom ROM without leaving USB Debugging enabled?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
For anyone to be able to help, you would need to provide all of the flash output, not just the error number.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Freakyd9984@gmail.com:
Is their a- way to root snapdragon s10 5G or install twrp... I don't have the OEM option
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
I don't think you can root the snapdragon model, they don't have the option to unlock bootloader. Sorry mate.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] itachiccc:
:crying::crying::crying::crying:

G977N(G977NKSU2ASIA) need new TWRP:crying::crying::crying:PLS!!!!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cameronkelley28:
Has anyone tested TWRP 3.1.1-11 with ASII yet? I'm usually happy to guinea pig for others but just been too busy to risk hours of tinkering if it blows up in my face. Still have ASIG PTSD ?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
I'd like to know that as well.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Magendanz:
Well, USB Debugging is off by default, so most probably do. I looked at turning it on by default, but couldn't find the setting in SettingsProvider.

Seems like there ought to be a simple way to initialize FunctionFS without relying on ADB to do it.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
I for one have it off when I am not home.

For a bit more added security I use a Tasker profile that turns it off when I'm not on my home wifi. But when I'm home it's always on.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
That applies to only some Snapdragon models. Outside of North America, many Snapdragon models have an unlockable bootloader.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Most mainstream users, yes, but users of custom ROMs?

Anyway, I agree with you that the ability to use MTP ought to be independent of adb, but I don't have a solution for you, other than to revert to the original implementation of MTP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Zonge:
Running ASII with 3.1.1.11, patched myself and all is running well. Have made twrp backup from this and that went smoothly as well!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Chulain:
Hello guys, recently decided to root & get twrp on my S10e.

Having rooted every smartphone I owned so far but I can't seem to figure this one out.

I have successfully installed magisk, I downloaded the correct twrp img and patched it with magisk.

I tried flashing it with the TWRP app on my phone and also with odin (made it a recovery.tar file with 7zip)

I end up getting a boot loop with both methods.

Edit: solved! I used version ASIG instead of ASE7
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
Post removed
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cameronkelley28:
Just updated to latest ASJG with TWRP 3.1.1-11 and everything is working fine so far.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
It's nice when someone shares this here. Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
Was going to post this also. I updated to the ASJD fw(was fine, ni hiccup) and was going to try the ASJG fw too.

So l hope mine goes well too!!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Please, give information here how did it go.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
Updated to ASJG fw using Magisk to patch both the AP and TWRP 3.3.1-11 and everything seems to have gone fine. No app fcs or anything problem. So l'm crusing with it..

cheers
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Just updated to ASJD with TWRP 3.1.1-11 and everything is working fine
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
[MENTION=7187684]ianmacd[/MENTION], Mentalmuso was able to get encryption working on his TWRP builds. Do you think it might be possible to use his work to integrate encryption support into your builds too?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Dr.][No_WaY:
Sorry,

I know it mentioned in OP , but now i need prepatched twrp for s10+ with G975FXXU3ASIG and magisk 20.1 , that what i have on my device , and now im in boot loop after trying to install youtube vanced and no way to patch twrp my self and i need it to disable all magisk modules.

Any body can help , even on pm.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Dr.][No_WaY:
Ok i fix the boot loop with flashing the patched fw and it working now , I patched twrp v11 with magisk 20.1 , do i need to flash multidisabler after flash twrp?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cameronkelley28:
Yes, always flash multidisabler after flashing FW. Even if it wasn't needed depending on what you did, better safe than sorry.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] nvthd94:
G975n Support or no ??
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Dr.][No_WaY:
Thank you, i will wipe my data? Or it wil be preserved?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
You should only need to wipe data/format if installing magisk for the first time. If just updating firmware there is no need.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Dr.][No_WaY:
Thank you , but when flash twrp and try to flash multidisabler form within , I cannot no zip appers even it there and all folder are encrepted! so I think I need to do data wipe first , I found this from OP

FBE (file-based encryption): Until this is disabled, most versions of TWRP — all for Exynos devices and many for Qualcomm — cannot read files on /data (the userdata partition). You must format /data after disabling FBE. Back up your data first!

so I need to do full backup and all data will be deleted!!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cameronkelley28:
Yes, in that case your data must still be encrypted so you will need to format. Since your data is encrypted, you will not be able to backup with TWRP either since it can't read your data.

If you can still boot into Android (not rooted) you can use SmartSwitch to backup. The PC/Mac application works well and also the phone app can do a backup to an SD card.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Dr.][No_WaY:
thanks ,

So i hope OP can add encryption handling like SD version by Mentalmuso
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Sadly, no. The encryption support that exists within TWRP is for Qualcomm-based devices only.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] WaningGibbous:
I ****ed up somehow and soft bricked my device....I tried flashing back to stock, and now when I boot it hangs on the s10 screen for a while, then flashes to a blue screen with the android logo with two arrows circling in his chest with "deleting" underneath for a second and then I get thrown to download mode. I can still access stock recovery though

maybe this isn't the right place, but I would like to ask here first as it is the first thing I tried that went wrong.

any ideas? factory reset in stock recovery doesn't work
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
I don't think there is much you can do besides booting into download mode and flashing FW through odin.

What firmware were you running and what version did you try flashing? Samsung has changed the bootloader of different firmware versions so if you were trying to 'downgrade' that might be why.

Go to sammobile of use frija to download the latest firmware and flash that.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wora92:
I see. A pity that exynos owners are excluded from encryption.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
I hope someone knows the answer. If for any reason I install a firmware using odin, root it and then I install twrp. I prefer to avoid additional steps by using a recovery file from my sd card, but I get an error. I wont finish the recovery and I have to reinstall the firmware with odin. Is it a firmware or kernell incompatibility? When the recovery file was saved, the phone was in an updated ROM different than the firmware just installed with odin.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
It happened again. I tried to flash android beta 10. When I went to the previous ROM, hades rom, I encountered an error in recovery. This time I have a screenshot. It says "unable to wipe efs". I have galaxy s10 (g973f). Any one knows why this keep happening to me?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NexxusDE:
Anyone got LineAge 16 to work on S10 with Magisk?

Anyone got LineAge 16 to work on S10 with Magisk? Cant boot after flashing Magisk!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
Perhaps Ianmacd or any other developer can help me. I cant use twrp to recover an image (wich was done without error) . It gives me error 1 and stops at the end of the process. It cant recover EFS. So I thought I could spare this part if I was sure my imei was ok, then the same error happens during "product" recovery. Any Idea? Im not a developper and essay and error didnt help me. Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I see from your screenshot that you have already successfully restored a Product image, so just skip the file-based restore of Product. It's superfluous.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] superlutin:
Dobbelpost. My fault - sorry
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] superlutin:
Hi ianmacd, Thank your for a very very well written guide! Though, being a bit noob I have doubts.

My overall understanding:

The initial process is divided in different operations, to be done in strictly this order:

1 - Root

2 - Unofficial TWRP

3 - Multidisabler

Positive part:

The goal is root and Magisk

Worrying part:

I have found that sometime app's can't be removed, even with root. After successful install, can I remove bloatware?

The process of eventually upgrading phone with new firmware is more obscure to me:

Installing future upgrade from Samsung involves my own hacking of firmware & install with Odin?

Installing future upgrades from Samsung will wipe my device and by that force a reinstall of all apps and settings?

I find no information about CSC or other way to activate regional features (eg call recording)

I might be "stuck" with your unofficial TWRP because it might be incompatible with future official TWRP (?)

High risk for bricking my device? - or will it be piece of cake to restore to factory with Odin (ok if Knox tripped)

Will your procedure work on firmware released after your date of release (multidisabler)?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
I am in no way an expert on this topic as the s10+ was basically the first real phone that I have rooted, but ive been learning over the past year and hope i can help.

After rooting you can pretty much delete any file, program or app on your phone you just need to find the right app for what you want to do. (E.g. use a good file explorer or app like titanium)

-Upgrading firmware is quite simple, you just download the new version of firmware and then patch the firmware and twrp with magisk and flash through odin. Firmware comes with a csc and home_csc file. If you flash home csc through odin you keep all your data if you use normal csc its like doing a factory reset. As for regional features, it depends on what firmware you download. If you want to be safe just make sure you only use firmware for your specific region/country and then you will have all your features like normal.

-sometimes newer versions of firmware are released that will be incompatible with the current twrp, your choices are to use a script to switch between stock recoverys and twrp. Wait for twrp to be updated before you upgrade firmware, or find a different twrp that is compatible with the firmware you want to update to e.g. one not by ianmcd.

-soft bricks are definately a risk but these can be easily fixed by re-flashing firmware through odin (so Always make sure you have a backup that you can restore). Hard bricks which are permanent and will make your phone a paperweight are extremely rare.

- The procedure stays the same with different versions of firmware as does the multidisabler, only twrp needs to be updated with newer firmware versions
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] superlutin:
Thanx for answer! I'm on s10e. Strange behavior. I start as advised by unlocking bootloader. No Google-user attached to the phone. From topjohnwu:

Allow bootloader unlocking in Developer options → OEM unlocking YES

Reboot your device to download mode. YES

Long press volume up to unlock the bootloader. NO action - nothing happens!!!!!

Any suggestions?