yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
First Format Data (yes) in TWRP then the multi disabler zip, then boot first.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
I think he meant the twrp file. With patched AP only you shrink your data without flashing the other files.

You have to extract it with 7zip again and you get the raw image file which you can flash via twrp, twrp app or flashify app.

Never worked for me. But some guys said it works. Didnt found out yet why it doesnt work on my device.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Switch off boot during recovery - works without problems.

I have done so many times.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tripdastati0n:
I have done this and this is when it all turns to crap i NEVER get to the twrp screen so i cant get to do the other steps
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Did you take the right image?

My file is finally >recovery.tar< , otherwise I get problems.

First Format Data (yes) in TWRP then the multi disabler zip, then boot first.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Flashing just a recovery image in the AP slot is fine, but flashing an actual AP file (i.e. one whose name starts or started before renaming with AP_ is not.

Switching TWRP in and out on demand is, all things considered, the better solution in my opinion. It's simple and bypasses the need to boot Android with a custom kernel that is often trailing the firmware release that it is booting.

The patched AP file will have an uncompressed recovery.img, so there's no need to lz4 -d it.

Yes. I have restored /data a few times without any issue at all. Back-ups are all I use TWRP for.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] horeizo:
what do you mean by

? I'd like to come prepared n case of emergency..
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I will not restore the boot partition.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] horeizo:
got it, thanks!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
The instructions are better than any video:good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] doggydog2:
the root steps are twrp steps are ok, not so bad, the only thing neither video or text will teach you is how to always enter download mode by keypress:) just like i never got the LG keypresses right.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Bixby + Volume Down (hold down) and then connect the phone via USB to the PC.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tripdastati0n:
no its not and thats an annoying answer. a video would be wonderful if someone could make one on adding twrp and not give an annoying answer like this one
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Everything is described very well. "10,000" people can handle it, why do not you?;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
A video is useful if you're doing something inherently visual, like learning to tie a knot.

If the written instructions aren't clear enough for you, please indicate where you get confused and where installing TWRP goes wrong for you. If you haven't yet even attempted to follow the written instructions, please do so and then provide feedback on the process.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
If the video or instructions doesnt work, i can draw out the picture out for you
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Well, I wasn't smart enough when I tried first, so that's kind of trial and error for me but in the end it worked out great ... there are a few things which I ignored and tried to "improve"

1. the su variable is intentionally declared within the "if" block because there is no su in TWRP -> I put the declaration to the twrp/stock vars block which made the file not executable in TWRP, had to correct that back

2. the shell script has to be executed being the superuser in android terminal otherwise one is not allowed to reboot to recovery (permission denied)

3. the paths to the external sd are different in android itself (ie. /storage/[number]/) and TWRP (/external_sd/) which I also brainlessly aligned :D

Perhaps you could just add a bit of information to the shell script instructions so that others may have a calmer switch :)

There is one thing left which I don't know and you probably do: since we have system-as-root and are rooted thru recovery, is it still necessary to allow modifications in TWRP to be able to flash multidisabler or mods?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tripdastati0n:
i finally did it. the way i got it to work. flash magisk_oatched tar reboot to recovery master reset then boot to download then flash recover.tar (formally patched magisk image). Only thing i was missing is a master rest in reg recovery before flashing twrp
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
Does anyone know what will happen if I accidently boot my phone normally and not to recovery using the button combinations? Im not game to try but it would be nice to know if it will stuff my phone or anything to a point where I would need to re flash stock firmware!! Thanks in advance.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Bluetooth pairings would be gone and you would have to 'Forget' wifi connections and re-enter passwords.

No, your phone won't explode. :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
Thanks, it's good to know that I can just turn it off and re boot to recovery partition like normal without losing anything. And im most glad that my phone won't explode :laugh:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Any brave soul flash the new firmware yet? Any problems wirh twrp?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] |||||:
Damn, isnt there an easier way?

At least I have an rooted S10 now, but this is a really lame way compared to older methods...

But well, we all need TWRP to go forward!

Found it: https://www.getdroidtips.com/twrp-recovery-galaxy-s10-s10-plus-root/

Why the OP did not just post the patched twrp .tar file?

Edit: I tried it, but always got the error something like "only official roms can be installed"

It would be nice if you could link all the tools needed. Also add a 1-7 steps list for windows users.

I can't even find a usable version of avbtool for the start?

https://www.startpage.com/do/dsearch?query=avbtool (where is the compiled file here for straight use?)

Actually no one has it ready, who reads this thread. Every such steps is important...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
Hello Senior, I just updated with the latest security patch July-2019 but unfortunately camera app won't work and its auto restart my cell phone. Any idea ? or wait for the open source of ASG8 to fix this issue.

Regards
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
I agree, I was scrolling through the Whole OP quote thinking this must be something good...only for a thank you. So dissapointed :(:(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
I think you answered this to yourself. An always working solution is to switch the recovery partition to twrp on demand only, then the twrp kernel is independent from the newer magisk kernel. See OP
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] |||||:
Damn, this is how you go / the missing link:

Basically you just need to move the twrp... .img file into a .tar by 7zip

rename the prepatched twrp to recovery.img and put it into a tar

Here you go, I did it with the latest version.

Instead of this stupid instruction, this would be the way to go.

Basic Instruction for everyone:

https://www.getdroidtips.com/twrp-recovery-galaxy-s10-s10-plus-root/

But use this newer prepatched .tar file, that I uploaded here for you, because this old one doesn't work anymore.

https://www.xup.in/dl,11328230/TWRP_S10_Magisk_Prepatched.tar

0. Click the Links above

0.1 Read it all

1. Unlock OEM Steps

2. Do the Magisk Rooting

3 Flash the TWRP from the link

4. done

Now you can install everything you want.

edit: I had this Error

Failed to mount '/data' (Invalid argument)

And here is a Solution that works!

How to fix Failed to mount '/data' (Invalid argument) (100% working method)

https://www.youtube.com/watch?v=Rs4zcryNt5Y

Have Fun!

ps: Installing Beyond Rom now ;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Basically u need to wipe and format again?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] gabrielgon:
Did you find a way around this? Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
You mean this:

https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tripdastati0n:
so can i install xposed now? i want to add the instagram thingry to disable the swype and download pix and a center clock would be nice
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Yes, I have found EDXposed to be very reliable, installable by adding to Magisk Modules.

https://magiskroot.net/download-xposed-for-android-pie/
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tripdastati0n:
thank! hope this isnt hard let me give this a go
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
I was told that the twrp version prior to the asf3 base actually worked with the asf3 base so we were able to update firmware etc before the asf3 source code was released (using tarp from the previous base etc)

Is this the case with asf3 to asg8? Are the bases almost identical apart from the July patch?

Cheers!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Camera will not work because its improved in ASG8
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Ok thanks and thanks for confirming my understanding of this weird new way of working! :D
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
As mentioned in OP, You're free to swap recovery partitions content anytime by using the script, so you're totally independent from firmware, ie twrp can contain the asf3 kernel but you switch back to stock recovery which then contains the asg8 kernel. You'll never have to update twrp again (only when twrp itself gets an update of course)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] drago122:
Sorry for a clarification but the file containing the to be put on the script device must be a .txt file?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Yes, you copy the shell script to your device, for example switch_recovery.sh, you use a terminal app to execute it, for example juicessh, as the superuser (#) which you'll become by entering su - first (the terminal app then asks for root access). (sh ./switch_recovery.sh)

The recovery partition then gets swapped and the device reboots to recovery (I don't even root twrp because there's no root used in twrp and I don't have "this" recovery used for magisk then). Then you can do whatever you want in twrp and go to advanced/terminal in the end and execute the script again which will again swap the recovery to stock rooted and reboot to recovery which then boots to system rooted.

That's way more easy than patching twrp. In case of firmware updates it's only necessary to patch the AP file and flash the firmware with patched AP and home_csc (and bl,cp). It's still possible to use your latest twrp though because the kernel is not shared but swapped.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] drago122:
There is a guide to use the juicessh app? I dont know this app.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Nice little project for someone, a kwik-switch TWRP on/off app.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Cool I'll look into that! :good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
[MENTION=7187684]ianmacd[/MENTION] ASG8 soon?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Better ask here ...

https://opensource.samsung.com and search for sm-g973

Short : no kernel source no new TWRP
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Answered in the OP itself.

What part of the guide is unclear to you?

You said you were already rooted. If so, you don't need avbtool. avbtool is only needed to create a custom vbmeta.img. Magisk will have created one for you when you patched your AP file. And even if you did still need one, the OP contains a shell script to create one as an alternative to avbtool.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
You quoted a post more than a month old. That link was fixed long ago.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
There already exist Android apps to flash a new recovery partition. A shell script will work just as well, as will a Tasker task.

Once in TWRP, you can use TWRP to replace itself with stock recovery; or a shell script again.

The OP contains a script that can be used to flip from stock recovery to TWRP and back again. All you have to do is run it.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Sorry Ian but link still 404
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I beg your pardon. Mea culpa.

It's linked to twice in the OP and only one of the links had been updated. It's fixed now.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
If you switch between recovery.imgages, wouldn't you need to wipe/format data?. I can appreciate you'll need to reinstall multidisabler when you go back to TWRP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
https://en.lmgtfy.com/?q=topjohnwu+magisk+samsung

Just in case [emoji1]

---------- Post added at 09:45 PM ---------- Previous post was at 09:42 PM ----------

No, multidisabler does not disable anything in relation with recovery. Formatting data is only needed once to remove encryption to make twrp cope with the contents (backups!)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jfm91:
Current setup:

Stock Rom ASF3

Magisk Root

Twrp

CarHD Mod

Is it possible to have TWRP installed without Magisk Root?

What I want is:

Stock non-rooted rom

TWRP and CarHD mod?

How can I do that?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
You need root privileges for the CarHD mod - it's the same.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Magisk and twrp only exist in recovery, so you're free to boot not to recovery but to system, then you will be non rooted (but lose your wifi connections, you'll have to set them up again)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jfm91:
But the mods from CarHD mod was still enabled when I was using my phone whit normal boot (non recovery/combination-key boot)

My real problem is snapchat...

https://xdaforums.com/galaxy-s10/how-to/snapchat-account-locked-rooted-s10-t3952267
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
[MENTION=7187684]ianmacd[/MENTION] Can you include permissive kernel instead of enforcing?

---------- Post added at 12:03 PM ---------- Previous post was at 12:02 PM ----------

[/COLOR [MENTION=7187684]ianmacd[/MENTION] Can you include permissive kernel instead of enforcing?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
The included kernel is switchable. TWRP switches it to permissive in order to run.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
In first version in changelog it says "Replaces SELinux permessive kernel with enforcing kernel."
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
The initial release of TWRP for the S10 series contained a kernel that booted Android on the device in SELinux permissive mode. Permissive moce is needed only for TWRP, not Android, so I switched to a kernel that is SELinux enforcing by default (in Android), but switchable to permissive (which is what TWRP does).
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] |||||:
Ian, can you explain this please?

https://xdaforums.com/galaxy-s10/help/bootloader-relock-bootloader-unlocked-t3952480
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
That Download screen showing is waiting for you to connect to your computer, fire up Odin and flash stock firmware.

See my post here:

https://xdaforums.com/galaxy-s10/help/how-to-lock-bootloader-t3927663/post79698366#post79698366
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
So you can switch it to permissive on rooted android?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] |||||:
Why the OP did not just post the patched twrp .tar file?

Because of this?

Then why not just ask him for permission for the S10?

Oh I found it..

Can you please edit this, to be more clear for others.

If you have a Bootloader unlocked and rooted device and want to flash TWRP via ODIN:

The twrp-beyond[xxx]lte.img File must be renamed to recovery.img packed into a .tar Archieve to flash it via Odin

You may use 7zip or this code to do this under windows:

$ mv twrp-beyond[012]lte.img recovery.img

$ tar cf twrp-beyond[012]lte.img.tar recovery.img

This would make it much clearer. I clearly oversaw this line of code at first, because you don't see it must be actually renamed. Only when you inspect the code and know the code, you know what to do.

And maybe add an simpler step by step explanation. Step 1-7 for Quickstart & with linked files.

That would help many people to come, alot.

Basically just attach the .tar files by default, would save this little steps for most, because they all will flash it via odin, as a start.

So basically just use magisk manager for that.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
anyone got a quick step by step to swap recoveries on the fly?

these terminal commands are doing my nut in

"Copy the following (not as the superuser) into a file, for example /storage/emulated/0/switch-recovery:"

can i ask which type of file we need to copy this into and what command is used to execute?

cheers

---------- Post added at 10:20 PM ---------- Previous post was at 10:04 PM ----------

arrgghhh how do we make an sh file and get the bloody thing to work lol

---------- Post added at 10:37 PM ---------- Previous post was at 10:20 PM ----------

or how do we do this dual booting? this may be simpler for me as i haven't got a clue about command scripts, unfortunatley without further context (i.e what file names code needs copying into or how these fles are created) i'm buggered up the arse til we get the source code lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
A shell script is just a simple text file. Adapt the paths in the OP shell script with your files' paths (ie extract the stock recovery from the magisk patched AP and take the patched or unpatched twrp). Push the script to your device, open a terminal, become superuser by typing "su -" and execute the shell file with "sh [path to the file]/[filename]" for example sh ./switch_recovery.sh if you cd to the script directory. Then the code switches the recovery partition content and reboots your device, that's all. Twrp has its own terminal which you then use to switch back to stock after doing your stuff. That's pretty easy, but pay attention that the path to your external sd is /storage/[xxxx-xxxx] in system but /externalsd in twrp. So don't change these absolute paths in your shell file, otherwise you'll not be able to execute the script again, because the recovery image may not be found. So make sure these paths are correct. Once it works you will not have to change that again. Pretty easy.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Ok thanks

I'll check the paths etc

Do I need to do anything to the text file like rename it from .txt to.sh

Or make it executable?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
You can rename it but it doesn't need an extension either. I'll usually name them .sh to know what I'm looking at [emoji3] making it executable shouldn't be necessary, but you can with chmod u+x [filename].sh if it ain't executable for root anyway.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
That's much clearer for my ADD ridden brain lol

Cheers!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Is "allow modifications" in twrp necessary to install mods and multidisabler?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Because:

patching a TWRP image is trivial;

people learn something from patching their own image;

different people have different preferences for Magisk stability, i.e. stable, beta, canary (debug/standard), unofficial;

a pre-patched TWRP image ages badly, because some channels of Magisk are frequently updated;

I understand and agree with John's reasons wanting to keep Magisk binaries within the Magisk distribution.

I have now edited the OP to explicitly mention the fact that the TWRP image must be renamed for Odin to recognise it.

I am willing to create detailed, precise documentation and continually improve it, but I am not willing to spoon-feed users by doing the work for them. That approach typically results in users who don't understand the actions they are executing or why. When it all goes wrong, they often have no idea what to do, so they panic, make rash decisions and frequently make things worse for themselves. This not only increases their stress, but also the support burden on others. It's just a bad outcome all around.

I'm a firm believer in the adage Give a man a fish, and you feed him for a day. Teach a man to fish, and you feed him for a lifetime.

Users who understand the steps they are following and why are not only able to help themselves when there's a problem, but also better able to help other users who are just starting out and have less knowledge than they do.

And let's not forget that we are only discussing the simple act of tarring a file here. That's trivial. The OP isn't intended for anyone incapable of that, nor is rooting and running TWRP on an S10 series device a process suited to anyone incapable of that. Rooting and maintaining these devices after rooting them is actually quite a tricky process, certainly when combined with installation of TWRP. Users should possess basic computer skills and a healthy interest in the subject matter.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
I'm a very firm believer in teaching man to fish but in almost 10 years if rooting devices,

I have seen nothing like this.

In this context it's meaning there's a lot of new stuff to learn (especially when you're late in the day in learning about the quirks of running batch files like me, I.e what kinda file to paste code into and wondering why after the 20th time of executing that code, it has not executed lol).

---------- Post added at 09:50 AM ---------- Previous post was at 09:19 AM ----------

This is my next q lol

On the switching v recoveries side, I got over to TWRP using the sh file but got stuck as twrp is weird with file paths.

Had to lose root by flashing stock recovery but I know what I'm doing now so thanks for your help bro!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Noooo :eek:, I was on the verge of doing the same, but it was sufficient to edit the shell file on my pc and pushing it back onto the microsd. That was my kind of trial and error. Phone remained in its erroneous state while I fixed my bugs on my computer.

If twrp does not recognise changes on the sd (ie. changed file names etc.) it would have been possible to reboot recovery from recovery to refresh. So did I with 2-3 iterations until I got anything up and running.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
final question in that case,

soldiers mod zip has all the disabler stuff in, are we able to keep system read only and install this?

otherwise we have to deal with having to format every time we boot into twrp?