yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Tech 4 9:
Just received my 973f today. Still totally stock. Is there any reason not to take the ASF3 ota update?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
No reason at all. All ok with Magisk and the latest TWRP, 3.3.1-4_ianmacd.img includes compatibility with ASF3.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Your script seems to be valid, just to make sure, in notepad++ the line ending setting is in the lower right corner of the app, this has to be Unix (LF). The filetype doesn't matter, that's just for syntax highlighting...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I will make sure once I get home, but as of now, Termux is saying it can't find su

I guess that's progress, but just as confusing for me as the unmatched if

Is there a better terminal app that I should be using?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
:confused:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
I'm using juicessh but termux should work too. Just write "sh [path to your script]/switch.sh" or become superuser first by writing "su -" and then shell command
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Material terminal is my weapon of choice lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
It's mine now too... But I'm stuck in twrp currently... Can't execute the script... I thought the command was the same as it was in Android?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Are you "CD-ing" to /external_sd/ when in twrp as the file system is named differently in twrp

Eg

twrp_img=/storage/17E4-1C13/twrprecovery.img

# Path to ext. SD is different in TWRP.

stock_img=/external_sd/recovery.img
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Jmakhdoom:
I have used flashify to install TWRP and then in TWRP flashed recovery. img to swap back to stock recovery. Working fine without hassle of complicated scripts.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
I wouldn't have a clue how to write or execute scripts:laugh: so am looking for a simple way to switch between twrp and stock recovery so I don't have to wait to update software. This seems like a good idea, do you have a link for any instructions that you used?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
Going to try this method
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Jmakhdoom:
No instructions. Just used my mind.

Just install flashify. Click flash recovery image. Then choose Magisk patched TWRP.img. It will install TWRP.

Then reboot and by using key combo enter into TWRP. Install any mods/zip u want and in the end install Stock recovery.img. Then reboot back to Magisk OS by using key combo.

It is the simplest method I could find.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Philnicolls89:
I already have twrp installed by replacing the stock recovery image in the AP file when I was rooting my phone. Will I need to start again to use this method?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Jmakhdoom:
As u already have TWRP, just flash the stock recovery. img that u can extract from patched magisk.tar, in TWRP. Then u have stock recovery. Now whenever u want TWRP flash TWRP patched recovery.img in flashify.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
Many thanks to everyone who participated in this thread, extra for answering my questions.

I will attempt to explain my steps to get rooted AND modded(not a guide, by any means)

1 follow John Wu's amazing Magisk installation guide and find your CSC with Phone Info SAM

2 use Peazip/7zip to extract the recovery from patched AP and download Ian's 3.3.1-4, copy to sd card

3 use Flashify(reboot + button combo) or Script(auto reboot) to install Ian's STOCK(unpatched) recovery

4 format data in TWRP and reboot recovery(I used button combo, but not sure if it's necessary)

5 flash disabler

6 flash Soldier's mod(use correct CSC)

7 flash(or script~script reboots automatically~)the recovery extracted from AP into recovery

8 reboot system(use button combo)

8a // EXPERIMENTAL/ / reboot recovery might boot into a rooted system unaided... MIGHT(could someone confirm?)

9 profit... rooted ASG8, Modded, camera working

Scripting is the best option(now that I've figured it out), no button presses need

For noobs like me, copy Ian's script into some text editor ON YOUR S10(I kept using windows). It should paste as one long string. Now separate that string according to how it appears in the OP(ENTER key between lines, the hints between the # # can be deleted altogether). The command in the OP just has to be changed to---[sh /sdcard/switch.sh]--- for TWRP terminal(I kept my filename short to preserve key presses)

If this small contribution somehow helps someone, I would be honored

Thanks again everyone(please inform me of any errors in my methods if you encounter any)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Thank you [MENTION=2539760]Jmakhdoom[/MENTION] this works well.

Just would like to add a warning to other users using this method, NEVER EVER select Power off from either of the Recovery screens. If you do, when you power on you'll go into a boot loop even if you use key combo, and have to wipe/factory reset.

From TWRP after flashing the image, select TWRP home button, then Reboot, then Recovery and phone will automatically reboot to Magisk rooted system without using key combo.

From Stock recovery after flashing the image, select Reboot system now, when screen goes off very quickly press the 3 key combo.

Also every time you install TWRP always flash the multidisabler. I didn't once and my internal memory was encrypted and unreadable. Had to re-partition.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
Well I just flashed patch stock recovery.img through flashify. Here is my simple steps.

1- Install Stock Firmware

2- Install Magisk, patch AP and TWRP in Magisk

3- Replace recovery.img file in patch AP with patched TWRP and flash it

4- Do the setup and restart into TWRP recovery

5- Flash Soldier's zip MOD v4 and reboot phone

6- Download and install flashify and flash recovery.img from Patched AP file

Now TWRP is no more and camera is working. hope that helps.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Should point 3 mean Ian's TWRP recovery? & not stock?

otherwise excellent step By step

I'm guessing I don't need to do that thread this evening lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
You have Windows line-endings in your script. Use UNIX line-endings.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I'll update the post to be more clear... I say STOCK because it's Ian's TWRP as downloaded, unmodified... I've read to use a Magisk Patched TWRP, but that's unnecessary, Ian's download is sufficient

Thanks for the compliment

If I was REALLY any good, it would be a guide with links to all the aforementioned threads & downloads... I'm just trying to contribute in some small way since I've learned so much in here

I don't even know what that means (but I'll be doing some research now)

Thanks for the tip and your STUPENDOUS contributions
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
[ianmacd@lagom ~]$ cat iffi
if true; then
echo true
else
echo false
fi
[ianmacd@lagom ~]$ . iffi
true
[ianmacd@lagom ~]$ unix2dos iffi
unix2dos: converting file iffi to DOS format...
[ianmacd@lagom ~]$ . iffi
iffi:2: command not found: ^M
iffi:8: parse error near `\n'

DOS (thus also Windows) terminates the lines of text files differently. You must terminate the lines of shell scripts with UNIX line-endings (i.e. a single \n, a.k.a. new line or line-feed, rather than a \r\n pair, a.k.a. a carriage return followed by a line-feed).
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
That really shouldn't be happening. You should be able to power off from any situation without causing a problem when you turn the device on again.

The very first Geiti release of TWRP for these devices had this issue, because of a problem with the kernel supplied in that version.

Are you using your own custom kernel or have you made some other low-level modification? This should not happen under normal circumstances.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Do you mind if I use this as a basis then mate? ill use what you've got, also list Ian's method (script) as a stand alone one and ill do links etc (credit to sources of course :) )
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I'd be honored if you used it
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Hi Ian

No custom kernel or mods. In fact I have totally reset my S10+, reflashed the stock ASF3 firmware, rooted with your Magisk and setup without accounts for now.

Installed Flashify, flashed newly created patched Unnoffial TWRP (3.3.1-4). Went into TWRP, flashed multidisabler, powered off phone from TWRP.

Powered on with combo keys and ....... bootloop. SAMSUNG pulsates 7/8 seconds then blanks and starts booting again.

Also then managed to boot back into TWRP, selected Reboot to recovery, same loop.

Doesn't over bother me, as long I select from the outset boot to Recovery from TWRP, or Restart system from stock recovery and press combo keys.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Fascinating. I really have no explanation for this.

If you can capture any logs, I would like to look at the problem. Does adbd start or does the device loop before it can be started?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] TheUndertaker21:
Camera still rebooted after I flashed twrp on July

Why is that?

Thanks.

I'm rooted with twrp but camera is not fixed (
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
No asg8 kernel sources up yet, so flash temporaly patched stock asg8 recovery to have a working camera again. Was posted so many times here in the forum. Use the search.;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
From what I've encountered, ROM shouldn't be booted with twrp installed, only the recovery.img extracted from Patched AP should be booted up.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
I have a g973f/ds. I followed post number 9 from PiCkLeS, step by step, that includes Ianmacd advise and john's instructions. I could install root and recovery without a problem. I had to remember Ianmacd advise of the 3 keys to restart my phone, otherwise I ended to the other road where the phone is without root. Thanks a lot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Hi Ian

Attached zip of Kernal and Recovery logs, hopefully of use to you.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
I made a back up on twrp. Every thing went without an issue. When I tried to recovery I couldnt. it says systemy read only. Any Idea what the problem is? Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
Updating, in case somebody else need it. I found out what was wrong. After I finish installing twrp during the flash, before leaving twrp, I have to tick "allow modification". If I "keep read only", I'll be able to back up, but not to restore.:D
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Thanks for the logs. Sadly, I see nothing unusual in them.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
I decided to report this. May be it's of some importance.

I did advanced wipe in recovery to system, data and cache.

Then restored TWRP backup, which I successfully restored previous times, so I know it was working.

But then the phone couldn't boot. It hung on the small Samsung logo.

I re-flashed TWRP and I repeated the process a couple of times and the result was the same.

Then I flashed the patched AP I was already on, along with the rest of the FW package with Odin. Then flashed the multi-disabler. And just in case restored data from that same TWRP backup and it worked.

I suspect that the system wipe in TWRP messed something up. And TWRP restore of system wasn't able to restore correct.

Someone could try this to see if it was only me.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PillowCake:
I followed these steps thoroughly, with the only difference being that after flashing Soldier's mod (making sure that I chose the correct CSC) I ALSO flashed Soldier's Splash Screen mod.

However, after step 8 (reboot to recovery AFTER having flashed the "recovery.img" extracted from the Magisks patched AP file), the phone turned on, but it stuck at Soldier's splash screen and never managed to fully boot.

I tried factory resetting but to no avail. Eventually I had to flash the whole stock firmware again and start from scratch.

Just as a reference, I'm trying this with ASG8 firmware.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I don't know if it's the extra mod or the rebooting process, but I've never used the reboot recovery option, I just restarted with the button combo

I would redo the process and reboot system after step 7, just use the button combo

Is the splash screen mod confirmed to be working?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PillowCake:
Then you should have been more clear in your instructions, as you wrote "8 reboot recovery(boots into rooted system, no buttons required ~untested by me~)", which I assumed meant that I had to reboot to recovery by using the proper option provided in TWRP. After I confirmed to reboot, I did not press any key and the phone stuck at the splash screen.

To be fair I have spent quite a lot of time on this already, and (possibly) wasting more hours is not something that I look forward to, especially because I have no guarantees that it will work :S

Considering that I saw no posts by users who reported to have some problems with it, I think it is safe to assume that it is fully functional.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] AlexesZ:
Good day. Tell me how to install twrp on s10 + if there is root obtained not using magisk? Thank.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] thevmax:
* PLEASE READ BEFORE POSTING *

at the top of this listing, Ian tells you how to do this.

TWRP without Magisk

If your device is currently still unrooted and running stock firmware, you are strongly advised not to proceed with installing TWRP. First root your device with Magisk, using John Wu's excellent Samsung system-as-root-instructions for patching the firmware's AP file. Only when you have completed that procedure should you return here and continue from the Image Preparation section.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
Sorry to hear that that process didn't work for you, but I wouldn't say it would take hours to complete the process by rebooting with the button combo. If I didn't update my post already, I will do so. Hope you get things up & running
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Firstly I don't think you need to format data when you install TWRP on already rooted phone. You only need to format data when you root and install TWRP at the same time, I.e. replacing recovery.img in magisk_patched.tar with the patched Ianmacd's TWRP.

Secondly your question of rebooting from TWRP. As Magisk rooted system resides in the Recovery partition on the S10, you select Reboot Recovery to boot into rooted system, no combo keys required. If you actually want to reboot back into TWRP recovery, you can select either System or Recovery, but using combo keys and holding Vol-up until TWRP appears.

Do not power off from TWRP, should be ok but for me causes bootloop.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
Thanks for informing me of my errors. I updated the post again to be as clear as possible and include instructions for scripting, which is the easiest method to get in and out of TWRP. Hope this helps

---------- Post added at 03:09 AM ---------- Previous post was at 03:04 AM ----------

My 1st boot into TWRP always has my internal storage in a bunch of jumbled letter filenames. I guess the format is to unencrypt the system because the format makes filenames readable on internal storage. Just rebooting TWRP would leave the filenames jumbled

---------- Post added at 03:13 AM ---------- Previous post was at 03:09 AM ----------

I actually updated my post once again, added all the reboot options I know and TRIED to explain the scripting installs, which are the simplest solution
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] AlexesZ:
On my phone, root rights are received. But, not using magisk. Ruth received using the EFT Dongle. Is it possible to install twrp in this option?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
[MENTION=7187684]ianmacd[/MENTION] hi sir, hope you are fine. Just wanted to let you know samsung just released ASG8 source. Can you please please update TWRP. We will really appreciate your hardwork as always.

Source: http://opensource.samsung.com/reception/receptionSub.do?method=sub&sub=F&searchValue=asg8

Thank you
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Jumbled file-names mean that /data is encrypted. After removing the encryption by running the multi-disabler and formatting the file-system, you should never have to do this again. If you do, it means that /data has become re-encrypted, but that scenario is entirely avoidable by never rebooting to Android after a firmware update before the multi-disabler has been re-run.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Unfortunately, Samsung have botched the release. The source code for the G970F is correct, but in the case of the G973F and G975F, Samsung have accidentally re-released the ASF3 sources.

This means I'm missing a few crucial files, so there will not be an updated release of TWRP until Samsung fix this error by issuing fixed ASG8 source archives.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] planck0815:
Hi [MENTION=7187684]ianmacd[/MENTION],

will you update TWRP for the G973F anyway?

Thanks and best regards!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I think you need to reread what I wrote.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] planck0815:
You're right, sorry. It's early in the morning here :)

Thank you anyway!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
You are correct, I failed to mention that I had to repeatedly do fresh installs after losing root by booting into ROM with TWRP installed. I feel like some kind of expert after figuring out how to run the script [emoji1787][emoji1787][emoji1787](you did all the work tho)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] AlexesZ:
Dear ianmacd.

Tell me, can I install twrp on a phone with root access not obtained by magisk?

Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Look at first two posts
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vegetaleb:
Thanks for your hard work

Personally I think I will pass the asg8 roms even if the source is released this week, in 2 weeks they would release a newer fw.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I agree.

Personally, I load TWRP on demand and replace it with stock recovery when no longer needed. I'm not in the habit of rendering my device unable to boot Android, so having TWRP available when I don't need it is rather like packing a winter coat when I'm going on a tropical holiday: useless. Whenever I need TWRP, its just one simple 5 second flash operation away.

The ASG8 release for the G973F and G975F has now actually been withdrawn, presumably indicating the imminent release of revised archives. But as you say, ASH* firmware can't be far away now, with a good chance of breaking dual-booting with the TWRP kernel for the umpteenth time.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
[MENTION=7187684]ianmacd[/MENTION]:

Can you please outline how to load twrp on demand and then replace with stock recovery when not needed (i know l read somewhere here but can't find it again). Thx

By the way, the source code for ASG8 has now been released by sammy!!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I have a post on page 63 that might be useful
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
If in doubt, check the OP. You'll find it there.

This had already been reported here. What hasn't yet been reported, however, is that Samsung have now issued new archives for the G973F and G975F, so we do finally the ASG8 source now.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
G970F too?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Tech 4 9:
Could I get the post number? In tapatalk we don't have page numbers.

Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Will put up a lil guide soon for swapping recoveries (both methods)

It's no trouble at all to swap recoveries when is all set up and one methods ridiculously easy
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PillowCake:
To be frank, I've yet to understand (due to my "n00b"-ness) why the procedure you describe works (assuming it does) by using Ian's stock recovery.img (that is, without patching it through Magisk).

I mean, if by using the stock version we are able to boot into TWRP and leverage all its functionalities, what's the point of patching it through Magisk?
[MENTION=7187684]ianmacd[/MENTION] can you please explain this to me? I'm genuinely curious.

Also, since my device IS rooted, I believe it is not necessary to format data when I'll decide to flash TWRP, am I wrong? I'd simply like to know if I will lose any data when I'll attempt to install TWRP.

Anyway, as others have said, I'll skip trying to have TWRP on ASG8 for now. My phone arrived three days ago and today is the first day that I am actually using it, as I've spent the past 2 days messing around with flashing/stocking and whatsoever. Now I'm currently sitting on a regular rooted S10e and I'm content (though it could be better, of course).
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
You only have to patch it to allow it to stay on your device and to use the recovery kernel to double boot either twrp or system with magisk. If you don't patch twrp, you'll have to replace it with the patched stock version again to be able to boot your system.

It's only necessary to format data to enable twrp to cope with the partition, if it's encrypted you cannot backup/restore it or make modifications fromn twrp (ie. install anything into the data partition), but that's all. So this means, nothing will be destroyed if you don't format it but twrp is rather useless then.

---------- Post added at 04:39 PM ---------- Previous post was at 04:22 PM ----------

[MENTION=7187684]ianmacd[/MENTION] : I have two questions on this: After doing a firmware update (and with switching to twrp on demand), how can I NOT reboot into android to run the recovery switch script and flash the multidisabler? Should I then rather do a firmware update, flash twrp through odin right after this, and boot directly into twrp, flash multidisabler and then push the new patched stock recovery of the new firmware to my device and run the switch script pointing to the new patched stock recovery to boot the new firmware for the first time? or what would be your strategy to do so?

Furthermore: the switch script demands the system to be working to use it. But imagine if you'd be stuck in a bootloop and cannot boot system anymore but you made a data backup before which you want to restore. What would you recommend? Flash twrp with AP in odin?

Thanx for any advice :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Theres 3 methods

Flashify

Script

Odin