yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
That's what I'm asking myself, see a few posts above. Since I have my S9+ still productive, I did not change the setting to allow modifications yet as I have not installed multidisabler or mods until I get an answer :) Then, after successfully restoring a data partition backup, I'll be finally using the S10 everyday , I hope :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
i can answer this, got into twrp, flashed soldiers zip

i then managed to reflash the patched stock recovery via the sh file

on rebooting i got a bootloop.

am i missing anything else?

do i need to format internal storage when i boot TWRP for the 1st time then flash the disabler?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
I don't think it has anything to do with internal storage, that ain't encrypted. The data partition is encrypted and has to be formatted once to remove encryption to enable TWRP to backup and restore.

But I guess the mod changes stuff in the system partition which would lead to the fact that TWRP also has to allow modifications but I'm not sure. Magisk itself - I think - doesn't change anything in the system partition.

Did you allow modifications before flashing the mod? I think multidisabler does also change system, as there are lines like "chmod 0 /system/system/bin/vaultkeeperd" to disable the vaultkeeper daemon... (multidisabler is somehow included in soldier's mod)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
I can't really remember I'll try both ways. Easily sorted bootloop with flashing patched ap and the rest.

I'll keep you posted
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
allowing modifications borked it.............

2nd try read only.........
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
One question in between, you flashed the 4.0 mod onto asg8? just to make sure ...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
yep defo mate

so, some success

i scripted over to TWRP and whilst in TWRP, i;

1 formatted internal storage in twrp

2 rebooted twrp (without going to system 1st) flashed multidisabler (for completeness)

3 flashed soldiers modpack

i have now booted normally successfully to set up.........more to come :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Sounds good :) Go the extra mile! :D So this was now variant B "no modifications"?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
[MENTION=4984667]daphun[/MENTION]

sorted!!

i now have a rooted device with soldier's mod before the asg8 source code is released.

on initial TWRP boot (after running switchy script) .....

i can confirm we must format data - reboot twrp - flash multidisabler (or rom zip with it included)

hopefully now i can truly Boot into TWRP on a whim without any more problems hehehehe

[MENTION=7187684]ianmacd[/MENTION]

this is the initiative you're after right ;):D

---------- Post added at 01:45 PM ---------- Previous post was at 01:41 PM ----------

[/COLOR [MENTION=4984667]daphun[/MENTION]

oh yeah before my ADD makes me forget, it is swipe to allow modifications :cool:

---------- Post added at 01:55 PM ---------- Previous post was at 01:45 PM ----------

and finally.....

i realised i used the wrong CSC in soldiers zip so had to reflash.

all good on rebooting to twrp without any issues!!!:)

---------- Post added at 02:21 PM ---------- Previous post was at 01:55 PM ----------

is it wrong to have a beer on a Monday afternoon when you're off work ill? cos i need one after that hahaha
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
Go for it! Sounds like that was much more work than work :D But in the end we will prevail ;) Cheers!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
YEAH NICE TRY SAMMY!!! :laugh:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
So on TWRP startup, tick nothing & swipe to allow modifications. Is that correct?.

Format data? Y/N
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Yessir

Then (if 1st twrp boot) format internal storage (the usual wsy)

Reboot recovery using the function in twrp (don't reboot any other way)

Then flash multidisabler

You can then run that script that allows twrp on the latest base (just be sure to rerun the script in twrp terminal under advanced options)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
[MENTION=7187684]ianmacd[/MENTION],

can you look into the magisk thread - I just can not root the S10 anymore.

Have already tried everything possible.:(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
But I just got rooted yesterday with july patch. Not installed TWRP because camera issue. It works fine.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Have you ever looked at my posts in the Magisk thread?;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
I'm on latest base, rooted, with soldiers mod and able to boot to twrp when required
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
I am curious if you tell me about your camera is working with rooted device. First open magisk and see if its rooted then open camera. Tell me if it works or not. Thank you

Sorry I have never face such issue. Will you try to restart your PC and run Odin as administration. Might this will help. My suggestion is lock your bootloader, flash stock firmware, then unlock bootloader then do magisk.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Tech 4 9:
Hello all.

Hopefully tomorrow I'll be trading my sm-g975u for a 973f to get the unlocked bl along with root.

I just wanted to confirm what I think I've already read..that there's no or not many issues running the F model on Verizon. All I really care about is volte and mms messages. Don't care about video calling or wifi calling. Hoping there might be a Resurrection Remix for the s10 someday.

Thanks all.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Waleedaligomaa:
Failed again after following every tiny little step .. i wont boot to recovery no matter how long i press the combo keys am stuch at s10+ screen :( started to hate that twrp thing :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Pm me. I want you to test another set of instructions and see if that solves your problem.

/P

---------- Post added at 01:26 PM ---------- Previous post was at 01:16 PM ----------

Anyone of you that have problems right now - any one of you _not_ rename the output file from Magisk, magisk_patched.img, to recovery.img before you use it? Especially if you use Odin? Because if you dont, that might be the problem for some of you..

It must be renamed recovery.img before its tar:ed and then flashed.

//P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] killprocess:
Thanks to do this, But how to build the "recovery_dtbo" file?

When I was build this with DTBTool, I got some error messages, just like this:

dtbTool: model_info-chip of ***exynos9820-beyond1lte_eur_open_24.dtb is of invalid size, skipping
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] TheUndertaker21:
Is there a way to update without wiping data.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Where are you coming from systemwise? Do you mean updating from another twrp-version or upgrading firmware when you have this solution installed?

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] TheUndertaker21:
Coming from your twrp or your instructions
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Thanks. And what exactly do you want to update?

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] TheUndertaker21:
To this newest twrp.

But I already one the old version installed and working though.

Just don't want to lose my data lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Just download the new twrp image. In MM choose install, patch file and choose that image.

Copy that resulting magisk_patched.img and rename it recovery.img. Tar it. Flash it in Odin and disable autoreboot and boot into twrp directly from there. Flash the latest disabler zip from Ian. Just to be surez its not necessary but what the hell.

And no, data won't be lost.

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Question. Did any of you having problem flash Soldiers modpack when in TWRP?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] raphael.e:
Yes! did it the same way and worked perfectly fine. The disabler zip I flashed already after the initial twrp installation and skipped it this time. No issues for me.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] uvitor:
I think its a TWRP issue(or ROM?), but if you guys could help me, i appreciate. When i try to flash GAPPS it returns me an error code 64 saying that's the wrong architecture for my device (Its not the case, S10+ Exynos) i tryed all the instances of gapps (nano, stock, full, micro) always using the arm64 android 9.0 versions with no lucky.

I flashed Ian's patched TWRP+Magisk file to get the custom recovery.

I could be wrong but i think TWRP is reading somewhere that my device is ARM.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
The packed image files might appear different, but that's due to your flags being set differently from another user's. I deconstructed both images — mine and your allegedly broken one — into their constituent kernel and ramdisk components and recursively diffed the trees. They were identical. Everything was properly patched in your image. Only the two checkbox flags were different, but that's not significant.

Again, this is almost certainly a red herring. Two users with different MM settings will produce two different binary images with almost identical content, the minor differences between which are insignificant in terms of whether or not Magisk has been properly embedded.

Your 'bad' image was fine. If I had flashed it on my device, it would have worked; no doubt about it whatsoever.

That leads me to question how you flashed it, because there's nothing left to analyse. We don't have a log of that, unfortunately.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Thanks.

I hope you are right.

However I still have my doubts.

I pointed out that for the AP I used one MM which settings were unchanged and still there was difference in the recovery.img.

On the image I posted and you analized: Thanks for doing this. I flashed this image with the dd command and with Odin. A few times with each method. No logs here, just Odin said that the flash was successful. This image didn't work for me. It's still posted and if anybody wants he can try it and confirm or deny if it worlks.

I still think it may have been some mistake of mine. Some setting or some action somewhere may be. I see others had the same problem. So if it's a mistake, others do it too. Therefore if we find what I may have done wrong we will be able to point it out so it's avoided.

I will see what happens when I am next updating and I will report here.

Thanks again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] derekclee:
Afterglow

I would like to extend a most heartfelt and relieved thanks to both Ian and John for finally helping me get this thing working on my S10e with AUT ASD5 firmware. It was a bit of a charly foxtrot but then again I have never been involved at this level of root rom development on such a new device. It has been a stressful two days but it finally works and I have spent the last four hours configuring my ROM. I had issues with systemless in magisk interfering (which makes sense now that I think about where the recovery actually exists). I also had several issues where I could not get TWRP working with multiple attempts at a tared image.

I have only rebooted after flashing something in Magisk and am a little hesitant to reboot using power off or reboot on the power menu. I was hoping someone could verify the proper sequences to reboot back to Rom using the power menu, how to properly get into TWRP (think I have that one), how to reboot back to the correct system after doing something in TWRP? I think a lot of people just want to get the ROM working and I am unsure if I will always have to briefly use vol up, bixby and power briefly or not. Also, in TWRP, there are two partitions with IMG, both system and vendor. Are these necessary and can I remove them or are they needed? It's an extra 6 gigs or so that is not necessary? Thanks again for any comments on reboot instructions and any other pointers in preserving this rooted solution. I'm finally feeling like I am not going to fall through the ice. I even have Edexposed working and I am very relieved. Thanks again guys! Great work! Yaaaaaay!!!!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Norup58:
I would like to upgrade from ASCA rooted to ASD5 TWRP-rooted all in one go as mentioned in the OP.

After patching the ASD5 AP I opened the archive using 7Z, deleted the Recovery.img, then dragged/ dropped the patched TWRP (renamed to Recovery.img) I noticed the permission mode is changed from ( -rw- r- - r - - ) to ( -rwxrwxrwx )

Is this supposed to happen and I’m good to go or am I doing something wrong?

Also, about 24 hrs ago this thread disappeared from the S10 forum?? Any particular reason??
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Waleedaligomaa:
well i didnt rename tbh .. gonna try if it failed i will pm you
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Please write here in the thread. I'm hoping that will make it work, as Odin uses the specific name of the image in the tar to figure out where to flash the image.

Crossing my fingers.

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exidler:
I have used this version with G973F and in recovery have a problem.

With mounted /system on every ls command in shell (adb shell) (and others toybox applets too i think) got the error:

linker: Warning: couldn't read "/system/etc/ld.config.txt" for "/sbin/toybox" (using default configuration instead): error reading file "/system/etc/ld.config.txt": Too many symbolic links encountered
WARNING: linker: Warning: couldn't read "/system/etc/ld.config.txt" for "/sbin/toybox" (using default configuration instead): error reading file "/system/etc/ld.config.txt": Too many symbolic links encountered

When /system mounted, loop symlink appears (/system/etc -> /system/etc, because of system as root image i think)

Could you fix this problem?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Yes, I saw that. It's because /system/etc is a symlink to itself when /system is mounted, so infinite recursion occurs.

Note that your commands will still succeed; they are just very noisy.

I will try to devise a fix.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
He said when its needed. Not he has twrp all the time running.;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
My camera stopped working after I booted into twrp then returned but I checked the stock recovery I patched and it turned out i reinstalled twrp (not stock) in error. I'd named the twrp "stock" like the twat I am lol.

I have redone the entire rooting process, making sure all files and links are correct but not booted twrp through the batch file yet

Edit: my camera was defo borked by the old twrp.

I just need to use it tomorrow so not risking anything tonight
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
ASG8 with soldier's mod and twrp unpatched asf3 with shell script switched on demand: camera is working like a charm [emoji3]
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Lmao, twrp shouldn't be patched?

Double **** up on my part as twrp was patched.

Learning loads this week! I'll give it a go ???
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I cannot get the script to execute. I'm using Termux and it keeps saying "syntax error: unmatched 'if'.

I have a 970F, I've already rooted and installed twrp, but the camera not working with root is really devastating

How should I proceed in order to have things setup like you? I'm not adverse to re-rooting the device
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
No, why should it? [emoji2] You don't need the kernel to double boot, magisk has not to be included. Twrp doesn't know root, so it's enough to take it as it is and replace it with the patched recovery if you're done with your recovery work...

---------- Post added at 07:27 AM ---------- Previous post was at 07:23 AM ----------

Sounds like a typo... Check your shell file to match the proposal in the OP and only replace the paths to the recovery files mentioned in there. Don't forget to save the file with Unix line endings of you're in Windows for example!

You don't have to reroot, you just have to replace the recovery as it contains the asf3 kernel now for you. If you get the shell script working, just use it to replace the twrp recovery which you have now with the stock patched asg8 recovery. Afterwards you can just switch recoveries on demand having the asg8 stock patched recovery being used for magisk/root.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
How did you extract your stock recovery from the lz4 format? I'm wondering if my img is corrupt or not properly converted

When rebooting from twrp to the stock img I have using the script I keep getting stuck on the splash screen with the red text, is this something to do with the recovery.img? Or am I missing a button combo on reboot?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
The stock (patched) recovery can be extracted from the magisk_patched.tar in which it ain't stored compressed but as a pure image. Just use "tar -xvf magisk_patched.tar recovery.img" or 7zip on windows. It shouldn't get stuck on boot, only if you used the unpatched stock recovery (?) No button combo necessary as the script reboots to recovery directly.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
i got my recovery img from

stock ap file

then by converting the lz4 file to img

now its plain to see I was not doing that correct lol

thanks again mate you are a legend!!

---------- Post added at 09:44 AM ---------- Previous post was at 08:46 AM ----------

Thought I may try my luck lol, I don't suppose you have a copy of the recovery you can upload? at work at the moment.

Unless the recovery is a CSC dependant file>?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
At work too :) With my S9+ Workhorse, the S10e is still waiting to be given the finishing touch :D So no S10 stuff round me here ...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
No worries mate, at least you've given me the kit to catch Ian's fish :D:laugh::cool:

---------- Post added at 11:03 AM ---------- Previous post was at 10:58 AM ----------

one have cracked this, i'm going to write a guide as the whole rooting process is a bit of a headf#ck lol

will include specifics like where the stock recovery is in img form and other specifics I have learned :good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
batch from stock to twrp to stock worked finally!!

the only issue i had was a bootloop when i rebooted after flashing soldiers mod and then stock recovery but phone has booted

if the camera works ill consider this worthy of a guide lol

do you know why i may have bootlooped??
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
I had the same, no bootloop but booted twice with no system. When I debloated in second install, there was no double boot, so maybe that was some feature related stuff? ;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
ok cool lol at least my phones how i want it now which will more than suffice til the next source code is out

now for that twrp swapping guide lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Grovyle:
Please do, really want to use Soldier's ROM for battery saving and TWRP in case I softbrick , haha.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
I'll start drafting it asap. My schedule is busy but gimme some free time and a bit of sativa and I'll be flying lol
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
Been tinkering, currently just rooted, no twrp. Can the script be used to install twrp? I've read that twrp can be installed thru the official app. What's the best way to get a recovery installed at this point?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Through a terminal such as Termux. Example as provided by Ianmacd on P1 of this thread:

# f=/storage/emulated/0/Download/magisk_patched.img; dd if=$f of=/dev/block/sda15 bs=$(stat -c%s $f)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
So once(if) I get the script to work I can just use twrp as needed?

Just for clarification:

Extracted recovery from patched ap is for twrp terminal

Ian 3.3.1-4 TWRP is for Termux

I copied the script(everything in the box) directly from the OP, but keep getting the 'if' error, would your example work, it seems much shorter than what I've been using?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
I may repeat myself, but why installing twrp when it can be switched easily? You'd have to rely on kernel source updates for every firmware iteration which is totally unnecessary. The asf3 twrp can literally be used forever on the S10 if you just swap it on demand. And how often do you really need twrp on your device up and running? I do backups at least once a month, and I just would not want to wait for a working twrp version but rather use it regularly and upgrade to a newer version just when available. I think there is really no advantage when twrp has to share the kernel with magisk...

---------- Post added at 09:25 PM ---------- Previous post was at 09:21 PM ----------

His example is not the shell script but the shell command to install twrp in the recovery partition. No switch logic in there.

Just figure out the line endings after copying Ian's code into your script...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Flashify
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
What do you mean by figure out the line endings?

Also, what does the OP mean about not copying as the superuser?

I missed be getting lost in translation somewhere
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Grovyle:
Doesn't work with Magisk for some reason.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] luisnica98:
I have sm-g973f/ds. can I use magisk and custom recovery for sm-g973f? Isearched and I couldnt find the answer. Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
No, you can't and you shouldn't [emoji1]

---------- Post added at 11:44 PM ---------- Previous post was at 11:38 PM ----------

Make sure you save the file in Unix format as Windows has CR LF and Unix has LF only, so carriage return is an additional letter which can apply badly to Unix code. Use notepad++ to check (if on Windows), Mac has CR only.

I guess creating the file not as the superuser could prevent a normal shell from executing the script. I execute it with superuser anyway so I guess that doesn't matter for me...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I've been using notepad++ and the listed language is Unix

I've been changing the directory to match my own in the script, but I can't figure out what the 'if' error is for

I would love to see the code for a functioning script, so I can figure out what I'm doing wrong
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] daphun:
The code in the OP IS a working script. I hope you copied all the code, ie the closing fi of the if clause and the dd command in the end?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I copied everything, verbatim, pasted into notepad++, saved as .sh, copied onto card & phone, ran the command from OP and I keep getting the unmatched 'if' error
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SumDum YunGuy:
I have also tried it with the explanations between the # # pasted from the OP