yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Thank you my friend Work!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MobAndro:
Hello,

I would like to root + twrp on the galaxy s10.

I have Windows 8.1 and I don't know how to use a Root Shell or Terminal Emulator for Android because I've never done that before. So, I don't want to make mistakes.

Before on my previous phones, I first flash the twrp in odin then flash the root in twrp ; but everything has changed with these new phones and I don't want to make mistakes.

In my situation, how to convert rooted twrp.image to rooted twrp.tar simply and in safety please ?

Thank you very much in advance for any help :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
I can not install Edxposed. Before I installed TWRP, I had Edxposed. Now you can not. Whether it's a well-known crop or just me, it's happening. Has anyone met with this problem? Is there a way?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GearCEO:
Anyone tried TWRP latest version with ASF3? If I install ASF3 on my S10+, will the latest TWRP works?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] TheUndertaker21:
im guessing we won't ever get mtp working ?

i have to restore my whole rom if i forgot to add anything
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Does anyone who has TWRP also have a working Edxposed? I'm asking because I can not deal with it. When I had only root, I installed Edxposed without any problems. Then I installed TWRP as well and from now on I can not install Edxposed. In Magisk is message "Unknown image format / installation failed"
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] faheemch13:
Yes I have latest twrp with ase7 firmware and working edxposed with magisk... I'm using a custom rom
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Great message! And what is the custom rom?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] faheemch13:
https://xdaforums.com/galaxy-s10/development/rom-beyondrom-v3-1-t3942112
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Just tell me if you installed TWRP, did you install the multidisabler or did you just install custom rom?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
It doesn't make any sense. I rooted the same file myself and flashed it to my own device.

Did you rename the file after downloading it? I'm curious how it changed from being twrp-beyond2lte-3.3.0-1_ianmacd.img to boot.img.

Which version of Magisk and MM are you running?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rafalubo:
Hello, good afternoon, I already updated my cell phone, I installed Root again but I have not placed the recovery yet, I can start from here or I have to reinstall the ROM and do the whole process thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] miguel.ocon@gmail.com:
Same problem

- Device platform: arm64-v8a

- Existing zip found

- Copying image to cache

1014+1 records in

1014+1 records out

1039176 bytes (1014.8KB) copied, 0.005080 seconds, 195.1MB/s

- Unpacking boot image

Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]

HEADER_VER [1]

KERNEL_SZ [44781580]

RAMDISK_SZ [15037449]

SECOND_SZ [0]

EXTRA_SZ [0]

RECOV_DTBO_SZ [1680812]

DTB [0]

OS_VERSION [9.0.0]

OS_PATCH_LEVEL [2019-04]

PAGESIZE [2048]

NAME [SRPRI17C001RU]

CMDLINE [buildvariant=eng]

CHECKSUM [8e66b6a2e238ae3fdae94021f429aa8517c987bc]

KERNEL_FMT [raw]

RAMDISK_FMT [gzip]

- Checking ramdisk status

Loading cpio: [ramdisk.cpio]

- Stock boot image detected

- Backing up stock boot image

- Patching ramdisk

Loading cpio: [ramdisk.cpio]

Add entry [init] (0750)

Patch with flag KEEPVERITY=[true] KEEPFORCEENCRYPT=[true]

Loading cpio: [ramdisk.cpio.orig]

Backup mismatch entry: [init] -> [.backup/init]

Create directory [.backup] (0000)

Add entry [.backup/.magisk] (0000)

Dump cpio: [ramdisk.cpio]

Patch @ 01EFCCBC [736B69705F696E697472616D667300]->[77616E745F696E697472616D667300]

- Repacking boot image

Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]

HEADER_VER [1]

KERNEL_SZ [44781580]

RAMDISK_SZ [15037449]

SECOND_SZ [0]

EXTRA_SZ [0]

RECOV_DTBO_SZ [1680812]

DTB [0]

OS_VERSION [9.0.0]

OS_PATCH_LEVEL [2019-04]

PAGESIZE [2048]

NAME [SRPRI17C001RU]

CMDLINE [buildvariant=eng]

CHECKSUM [8e66b6a2e238ae3fdae94021f429aa8517c987bc]

KERNEL_FMT [raw]

RAMDISK_FMT [gzip]

Repack to boot image: [new-boot.img]

HEADER_VER [1]

KERNEL_SZ [44781580]

RAMDISK_SZ [15203636]

SECOND_SZ [0]

EXTRA_SZ [0]

RECOV_DTBO_SZ [1680812]

DTB [0]

OS_VERSION [9.0.0]

OS_PATCH_LEVEL [2019-04]

PAGESIZE [2048]

NAME [SRPRI17C001RU]

CMDLINE [buildvariant=eng]

CHECKSUM [48beff8babc10895ec3035079731fb47081cc821]

****************************

Output file is placed in

/storage/emulated/0/Download/magisk_patched.img

****************************

- All done!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
What happens if you manually delete /data/user_de/0/com.topjohnwu.magisk/install/boot.img before you attempt to flash the recovery image?

I suspect the presence of this file is causing Magisk to default to using this file every time. It has nothing to do with the recovery image you are trying to root.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] miguel.ocon@gmail.com:
I did the thing to delete the folder, and I made an error when trying to patch, then I installed magisk manager again and the same as usual, I added the logs.

- Device platform: arm64-v8a

- Existing zip found

- Copying image to cache

1014+1 records in

1014+1 records out

1039176 bytes (1014.8KB) copied, 0.004718 seconds, 210.1MB/s

- Unpacking boot image

Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]

HEADER_VER [1]

KERNEL_SZ [44781580]

RAMDISK_SZ [15037449]

SECOND_SZ [0]

EXTRA_SZ [0]

RECOV_DTBO_SZ [1680812]

DTB [0]

OS_VERSION [9.0.0]

OS_PATCH_LEVEL [2019-04]

PAGESIZE [2048]

NAME [SRPRI17C001RU]

CMDLINE [buildvariant=eng]

CHECKSUM [8e66b6a2e238ae3fdae94021f429aa8517c987bc]

KERNEL_FMT [raw]

RAMDISK_FMT [gzip]

- Checking ramdisk status

Loading cpio: [ramdisk.cpio]

- Stock boot image detected

- Backing up stock boot image

- Patching ramdisk

Loading cpio: [ramdisk.cpio]

Add entry [init] (0750)

Patch with flag KEEPVERITY=[true] KEEPFORCEENCRYPT=[true]

Loading cpio: [ramdisk.cpio.orig]

Backup mismatch entry: [init] -> [.backup/init]

Create directory [.backup] (0000)

Add entry [.backup/.magisk] (0000)

Dump cpio: [ramdisk.cpio]

Patch @ 01EFCCBC [736B69705F696E697472616D667300]->[77616E745F696E697472616D667300]

- Repacking boot image

Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]

HEADER_VER [1]

KERNEL_SZ [44781580]

RAMDISK_SZ [15037449]

SECOND_SZ [0]

EXTRA_SZ [0]

RECOV_DTBO_SZ [1680812]

DTB [0]

OS_VERSION [9.0.0]

OS_PATCH_LEVEL [2019-04]

PAGESIZE [2048]

NAME [SRPRI17C001RU]

CMDLINE [buildvariant=eng]

CHECKSUM [8e66b6a2e238ae3fdae94021f429aa8517c987bc]

KERNEL_FMT [raw]

RAMDISK_FMT [gzip]

Repack to boot image: [new-boot.img]

HEADER_VER [1]

KERNEL_SZ [44781580]

RAMDISK_SZ [15203636]

SECOND_SZ [0]

EXTRA_SZ [0]

RECOV_DTBO_SZ [1680812]

DTB [0]

OS_VERSION [9.0.0]

OS_PATCH_LEVEL [2019-04]

PAGESIZE [2048]

NAME [SRPRI17C001RU]

CMDLINE [buildvariant=eng]

CHECKSUM [48beff8babc10895ec3035079731fb47081cc821]

****************************

Output file is placed in

/storage/emulated/0/Download/magisk_patched.img

****************************

- All done!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Here's my versions.

We have to figure out the reason.

Thanks for looking into this
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Hm.. you seem to be on John's Magisk core but Ian's MM.

Look at mine, both from Ian. Have you changed Magisk repo to Ian's?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] oggi21:
Exynos only
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Did that now. Thanks for trying to help. But it's the same result.

I need someone to send me link to patched TWRP 3.3.0-1

I want to uphold the rules, and it's not like I didn't try to, but it's out of my hands.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] lupin57:
Ian ;)

Even if the file is deleted, it is created again when the patching is starting ! :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Fznwolf:
This looks awesome, any way you could do a patch for SM-G97x0 using the ASD4 source? For us unlocked BL snapdragon users?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
I've decided to post one of my badly patched TWRP img files here.

May be someone could get an idea of what goes wrong by inspecting the file of that's possible.

Link: https://www.dropbox.com/s/o32wtd8q27cp23d/do_not_flash_bad_magisk_patched.img?dl=0

Do not flash or use this file. It's bad.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] lupin57:
Got the same as you ... more than ten times I tried !

I'm gone further, I deleted the file from John in /data/user and got the same error as you "No zip present •► failed to patch !

Even that, as nomore boot.img present (deleted all files called boot_xxx), I renamed Ian's img in "boot.img" to see what MM should do ... it downloaded (from John gihub) the same boot.img necessary for its script I think (...)

Thats really weird as behavior ! Seems like a hidden script wanting at any price to patch an original boot.img !
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I'm looking into it, but you will have to be patient. This small setback does not entitle someone else to violate the Magisk developer's wishes on your behalf. Magisk + TWRP is not a human right.

The only difference in your log file and one produced on my device is this line, bolded for emphasis:

Dump cpio: [ramdisk.cpio]
[b]Loading dtbs from [recovery_dtbo][/b]
Patch @ 01EFCCBC [736B69705F696E697472616D667300]->[77616E745F696E697472616D667300]

For some reason, your Magisk installation is ignoring the fact that this is a recovery image and failing to register recovery mode. I've escalated this to John and forwarded your installation log to him for analysis.

EDIT:

[MENTION=2676284]tiho5[/MENTION]

You are subsequently flashing /storage/emulated/0/Download/magisk_patched.img, right? Not the original input file, twrp-beyond2lte-3.3.0-1_ianmacd.img?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Geekser:
I had issues earlier today trying to patch the new TWRP image that Ian offered in the OP - it just would not flash in odin for some reason. So this afternoon, I started over from Scratchh - and patched the AP file from the stock Rom - then I also patched the new TWRP file from the op - renamed the patched twrp file as 'recovery" and replaced the recovery in the Patched AP file with the one I just renamed to recovery.

THEN I flashed that Patched AP in Odin and everything flashed perfectly. My point is - if you are having issues - stop what you are doing - go back to the OP - and start from the Beggining - you should have success if you follow all of the steps.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Mr.HiddenBug:
Great job! but my device is G977N, I really expect you to add support for it, much thx!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] lupin57:
OK and thanx for the advice ... but not the topic I think ! :(

I got root 15 days ago and all is perfect since this time !

I would like to "benefit" of wonderful Ian's work about "new" TWRP and try his process without wiping anything, its normally available (see OP) !

...

All I get is a patched img that I dont know if its the good one or not !

So, I think u understand me that Im lightly suspicious before trying to pushing it by root shell or flashing it by ODIN ^^

I just would like understand why Magisk wanting, at any price, to patch a boot img (all logs are telling that) when I would just patch a "lambda" file (...)

Thanx, in anyway, for the advice to start again from scratch :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Don't focus on boot.img. That's a red herring. Magisk is evidently renaming the input file, and the log messages always refer to a boot image, never to a recovery image. This does not mean that patching has failed.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
I checked your image. It's virtually identical to mine. The only difference is in the setting of your flags in MM:

diff -uNr --no-dereference ramdisk/.backup/.magisk ../../img_broken/AIK-Linux/ramdisk/.backup/.magisk
--- ramdisk/.backup/.magisk 2019-04-27 09:50:33.305457499 +0200
+++ ../../img_broken/AIK-Linux/ramdisk/.backup/.magisk 2019-04-27 09:53:33.324499519 +0200
@@ -1,4 +1,4 @@
-KEEPVERITY=false
-KEEPFORCEENCRYPT=false
+KEEPVERITY=true
+KEEPFORCEENCRYPT=true
SHA1=ccc34b593e4a46d821be8cc6f35bcd9bae09d7a6
RECOVERYMODE=true

You have the Preserve force encryption and Preserve AVB 2.0/dm-verity boxes checked when patching, but that's the only difference and should have no effect on patching.

Magisk itself is properly installed in your image.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
I'm of course not doing that, mate.

You see other people have the same issue. It's not that.

I also binary compared the 2 patched images (because I got a proper patched TWRP 3.3.0-1 by a good fellow on PM in the meantime).

They were different. I can't open the img file and see where and how they differ, but I know that my Magisk didn't produce the same image.

As for the 2 check boxes in MM, I am not sure I've even touched those. Probably they have remained in such a state since the MM installation. I just looked at them right now and they are unticked. Since I flashed the patched TWRP from someone else yesterday I have a different Magisk version now too. But as you say this is not the problem.

One other thing:

I've had (and also reported that here in some of the relevant threads) such a badly patched image also with a whole AP. I remember checking it later against a proper patched AP and again found binary comparing the images in the AP that only the recovery.img was different. The other two that Magisk touches (boot and vbmeta of coarse which is just emptied) were the same.

The interesting thing here was that my own (unchanged) Magisk manager was able to produce both patches - one good and working and one bad, not working. So I think this can happen to anyone. And may be an indication as a kind of warning could be posted somewhere on this for the people.

That's why I kept on trying many times to patch the TWRP the last time. I was hoping that finally magisk manager will make it right. Changed the placeholder folders, names of the files, etc, but the outcome was the same.

Thank you for helping, Ian. I'm sure we'll know what's the culprit pretty soon.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] idealz:
I have a galaxy s10e running on ASD5. Is it safe to flash the TWRP in the OP which seems like it's meant for ASE7? TIA.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Nobody will help me?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] thebob6:
Sorry I can't assist with the error your are getting but I can say I have TWRP/MAGSIK/ROOT + Edxposed on the stock ROM. Where are you trying to install Edxposed from? Did you install the required Magsik modules first? I believe that RIRU - CORE, RIRU - Edxposed (YAHFA) / RIRU - Edxposed - SANDHOOK. I have both YAHFA and SANDHOOK installed.. although I dont think both are needed? I'd recommend installed RIRU then Edxposed Yahfa and that should get Edxposed working for you.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Thanks! Work!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MobAndro:
Someone can help me PLEASE ? :crying:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
Was posted over and over again. Rename the patched twrp.img to recovery.img and use 7zip to build a .tar. If you have root(1st thing you must do), you can also use the "twrp app" or "flashify" to flash the pure .img files to your recovery. So no need of odin or how to build a .tar.;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vegetaleb:
You have to update your fw first or you will end up with bugs
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Carotix:
yes , it works ...... but i have problem with updating root

edit: maybe i have done something wrong
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vegetaleb:
Better wait for asf3 version then
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] TheUndertaker21:
so now twrp will have to be updated for everytime there's a new monthly security ?

jesus fking Christ Samsung
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
Not every time, only if you get bugs. But ASF3 works fine for me with ASE7 TWRP. Seems nothing was changed with camera by samsung. And root works on my side.;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MobAndro:
Thank you very much hanspampel for helping me. It's really easy and simple to understand :laugh: :good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vegetaleb:
Any ways to keep a custom rom from being wiped when updating or you will have to format anyway after multidisabler again?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] trancinguy:
There is a specific rom that has that option in the aroma.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
MTP is complicated, due to the shared kernel with Android.

Just use adb for now.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Potatothief:
Hi I am having problems with boot loops. I tried to install 2 different custom roms but I had issues with boot looping.

I just came from stock rom patched with magisk for root. I then used flashify to flash the magisk patched twrp (v3.3.1-3.1). I had no issues booting to twrp but when i tried to flash a custom rom and reboot afterwards I get boot loops. I can luckily reboot to twrp though once the boot loops starts.

No idea what to do any advice please. SM-G975F (australia)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Did you flashed multi disabler?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] OsoAlgo:
I can confirm that firmware update on my S10e succeeded without major hiccups. What I did was basically:

- Flash with Odin

- Reboot to TWRP recovery with button combo

- TWRP rebooted automatically, so I had to press the button combo again to enter TWRP a second time

- Flash multi-disabler

- Wipe Cache and Dalvik

- Reboot to "recovery" to get system with magisk

I think all wifi networks were forgotten after my phone booted, but I restored them with Titanium Backup. All my apps and data still seem to be there.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Potatothief:
I flashed the multi-disabler and I had issues with boot looping. I will add though that I flash a rom first and only after it had started to boot loop did i go back into twrp and reflash the rom as well as the multi disabler
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Did you also format data after flashing multidisabler zip?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] TheUndertaker21:
just updated to magisk 19.4 and got bootlop

anyone else ?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Under discussion here:

https://xdaforums.com/galaxy-s10/development/magisk-root-galaxy-s10-series-t3918699/page107
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] exocetdj:
Ready for the twrp part as soon as the updated version follows the source code release.

Can the patched TWRP file be installed with flashify? T.I.A
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinjmoore:
Quick questions. Can someone help me?

1) Since I am already rooted with Magisk and have the latest Magisk Manager, can I just flash the latest file (twrp-3.3.1-2-beyond2lte.img) from the official app repository straight to recovery? Or do I have to patch it using Magisk Manager, and then find the file from TWRP off my SD card and flash to recovery?

2) Will I have to reformat or run the multi-disabler immediately after flashing from the official TWRP app?

3) Will I lose all my data?

4) Will the app try to force reboot right away after flashing? Do I have to be prepared to quickly do some key combinations to stop it from trying to reboot?

5) Will there be key combinations required each time I boot and if so is it the recovery key combo and release ALL buttons as soon as I see the bootloader warning?

Thanks so much. I spent so much time getting this rooted that I don't want to FUBAR it.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] OsoAlgo:
1. You'd need to patch, but you shouldn't because of kernel incompatibilities, see the section on firmware updates in the first post, and the second post too.

2-3. See this.

4. In twrp: no. In odin: you have to turn off auto reboot as mentioned in magisk's instructions.

5. See this.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinjmoore:
Thank you so much for the reply. So, I'm not sure what to do with your reply on #1. You'd need to patch, but shouldn't. Not sure if that is a yes or no. I have the correct one downloaded, 3.1.3.1-3 for my baseband. Can I patch and flash from TWRP if I have already patched it using MM?

I don't think I was very clear, but I already have Magisk installed and am rooted. I now want to install the correct version of TWRP so I can back up my data and restore if necessary. After that I may want to install a custom Rom. It seems like #5 is telling me how to install Magisk, but I've already done that. I just need to flash TWRP the right way and then know how to install the custom ROM from TWRP.

Sorry if that is too much to ask, but I'd appreciate any help that you could offer on that. Thank you for everything so far.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
There is a guide here, but in German. This is the translation of the orig.manual.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinjmoore:
Thank you very much. I hope I don't lose anything in the translation. I will review it later tonight to try it out! Great help.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] OsoAlgo:
It means you should only patch and flash if you know the TWRP version you use is compatible with your current firmware's kernel. Only the versions provided in the first post are compiled with Samsung's kernels, and post 2 specifies which versions are compatible with which firmware versions.