yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Suggestions to avoid S10 bootlooping or boot lockup when first trying to root with Magisk:

You will inevitably loose your data during rooting, so backup all important information and data!.

Go to to the first page of this discussion, read, then follow the Link to Instructions https://topjohnwu.github.io/Magisk/samsung

Watch this video tutorial https://www.youtube.com/watch?v=o3a8YnWT3yk at least a couple of times. Pause, rewind whatever until you feel more confident with the many various stages. When I first rooted my S10 Plus, I paused and sometimes rewound the video as I was actually rooting the S10. Be careful not to miss a step.

IMPORTANT. Do not forget to untick the Reboot option in Odin before flashing the magisk_patched file.

It cannot be over-stated just how critical and important the button pressing (Vol. Up or Down, Bixby button and Power button) sequence and

timing

is. REMOVE ANY PHONE CASE YOU HAVE ON THE PHONE as the case can numb the button presses.

If you get into a bootloop or a non-progressing boot screen near the end of the rooting process, follow this:

If you want Download mode, connect the USB cable from the phone to your PC. press and hold the Bixby button, Volume-down button and power button and hold the 3 buttons until the Download screen appears.

If you want to try and reboot the S10, press and hold the Bixby button, Volume-down button and power button and hold the 3 buttons until the screen goes off, then IMMEDIATELY release only the Volume-down button and IMMEDIATELY press the Volume-up button, as soon you see the S10 logo screen VERY quickly release all buttons.

Remember, sequence and timing of button presses is critical.

If your first attempt at rooting fails, it is not the end of the world. Just go into Download mode and reflash all 4 of the original firmware files in Odin to return to stock firmware. For a complete reflash in Odin you can leave the Reboot option in Odin ticked.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] royhanks3:
I've successfully rooted my S10 Plus and I absolutely love this phone, but I was just wondering, is it possible to actually hard brick this device given the amount of tools we have to pretty much fix it? Coming from a Huawei Mate 10, a device that could be bricked EASILY, I just wanted to know if it were actually possible to hard brick this phone like it is with a lot of other Oem's?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
I have not heard of anyone yet of having bricked their S10. I've had a couple of moments of thinking oh hell now what - but have always overcome. The Bixby + Volume-down + Power button + USB connected to PC has always got me going again.

As long as users know this sort of info I think (obviously not impossible) the chances of bricking the phone are pretty remote :highfive:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ChrisChristian:
Camera sound mute don t work?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] c3k:
Is there a way to disable encryption ("encryptable" in fstab) while patching the stock image?

For a local install a did this using /data/.magisk but it's not working with "select and patch a file".

I did modifying CSC feature.xml, but it's not easy as install a module, you have do extract your CSC XML, decrypt it (omc-decoder), add the camera button code, encrypt and send it back to the device.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
That requires patching /vendor, which John doesn't want to do. Magisk works systemlessly and, by logical extension, vendorlessly.

[/quote]

It's actually not necessary to re-encrypt the file before returning it to the device.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Garock:
I've only read the last 3 pages but couldn't seem to find the answer

I noticed that there is magisk update when I open magisk manager. so what's the procedure to update? is it as simple as tap update then pick direct install (recommended) or I need to patch the AP again?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
You can just do direct install and let it reboot itself after its done.

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DSX2:
Unfortunately stuck on flashing recovery.img in Odin while trying to update my firmware (was already patched with Magisk). Any advice on where to go from here?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
You cant flash an .img-file in Odin. You must tar it first. So if what you wrote is exactly right, that is your problem.

Use any suitable app on your computer, if Windows use 7-zip or PeaZip, and add the recovery.img to a tar and flash that tar.

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DSX2:
Not flashing an img file, flashing the magisk patch tar, but the recovery.img is where it holds on the odin log
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
So you opened the magisk_patched.tar you made from the firmware AP-file, then removed the recovery.img that was in there and then added your patched recovery.img?

And the recovery.img that you are inserting, was an twrp-image that your patched in Magisk Manager before renaming it recovery.img, right?

If all of that is exactly what you did, please send me a PM with a screenshot of how Odin looks when its trying to flash the magisk_patched.tar file and ill take a look.

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DSX2:
No no no,

I flashed the patched magisk tar in Odin under AP, as directed by the instructions.

The Odin log lists each file in that tar as it flashes, however, it is unable to flash the recovery.img portion of the magisk_patched.tar

[IMG="https://i.imgur.com/ojPnubO.png"]https://i.imgur.com/ojPnubO.png[/IMG]
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DaReDeViL:
Don't worry, I had such an issue. It's only a bad patched file. Use another phone to patch the AP again and flash it. Done
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Garock:
I'm currently having an issue, and although it might not be magisk issue but I wonder if anyone can help me fix it

I'm not sure what I did, but the latest changes I did with the phone was to update magisk manager to v7.1.2 (not the magisk itself, it still on v19.0), update riru-core to v19 and edxposed to v0.4.1.2 from the module menu and all works good

until a few restarts later, suddenly each time I boot with magisk, the phone seems to boot fine but whenever I run any app, it'll stop responding. so basically after the phone booted, I can still swipe the home menu and open the app drawer, but not running any app

I can still boot without magisk though

I was thinking to boot without magisk then disable those modules using magisk manager, but unfortunately the module menu was gone if magisk was not installed

any other suggestions?

edit

solved it (well partially)

it looks like when booting with magisk, although I cannot run any app but root is still working

so I run adb then follow the steps here https://www.didgeridoohan.com/magis..._Uninstalldeletedisable_modules_from_recovery to disable riru and edxposed modules, reboot and now it works

I guess I need to downgrade those 2 modules to earlier versions then. just wondering if it's safe to uninstall these modules from magisk manager or do I need to flash the edxposed uninstaller?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Sly123:
Hi all.

I have a question.

I have a Snapdragon S10 and as a result I rarely can get reboots.

I've had a cetrain Magisk version (ianmacd's from the 03.05.19) which ran very stable but I've did an update.

Is it possible to restore the previous version? I've downloaded the .zip file but I don't know how to apply.

I would appreciate any help. Thank you.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Wishhful:
Can anyone confirm if this will work on S10 5G
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DSX2:
Had my original patched AP hanging around, so flashed that and wiped the phone. Not ideal as I didn't want to wipe but hey beats a bricked phone.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xXMenaXx:
Mine is working fine using this method.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] patrickneil:
Has anyone update to today's Magisk 19.2 version yet? Any issues?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
No issues on the custom version from [MENTION=7187684]ianmacd[/MENTION]
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cboar:
Has anyone been able to do this with Heimdall? I extracted the AP tarball and flashed the .img files to their respective partitions. Unfortunately, many attempts only bring me to either a bootloop or directly into download mode with an error message. I can't even get the stock firmware running with it.

I wonder if this has to do with the meta-data/fota.zip file that also gets extracted. I'm not sure if using Heimdall to install this properly is even possible, assuming the file is important in the first place.

If anyone has insights, I would love to hear them.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ru_dimka:
Who can tell me what benefits I will get if I will do a root(Magisk) over stock FW?

---------- Post added at 11:29 AM ---------- Previous post was at 11:29 AM ----------

How do you use a Magisk on S5e? I also have it.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xXMenaXx:
I just did the steps found here on the original post.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ChrisChristian:
How to update the firmware if root?:confused:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Sly123:
I have a question.

I have uninstalled Magisk inside of Magisk Manager and chose Complete uninstall due to anoying reboots.

Now I can't install Magisk anymore and reboot to MAsik ends up in booting stock recovery.

Wth can I do now to get Magisk work again?

Edit: Fixed it by using Odin with patched AP + Home CSC, but still same reboots.

Edit 2: After installing newest ianmacd Magisc 0520 phone runs pretty stable.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] c3k:
Magisk patched + home_csc should be fine, but I have to do a real test
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] trancinguy:
If stock recovery, download new firmware, take AP from it and Magisk patch it, reboot to Down load mode, flash the patched image tar file along home csc in Odin, then reboot recovery.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SirUnreal:
I rooted my S10e and here are some hints that might hopefully prevent you from wasting time:

- In my case after the unlocking prozess OEM unlocking is not visible anymore in the developer menu. Don't worry. If you get a warning message while booting, everything went right.

- Don't use the mounted Samsung device in Windows, just prefer a microSD card to copy the AP file to the phone and back. In my case one of the magisk_patched.tar files Magisk created had a different size - although I used exactly the same origin files. The following error was that Odin hung up while flashing file dt.img.lz4. You can close Odin and restart the phone - in my case nothing was damaged.

- Use Odin 3.13.1 and use it as an administrator. Using Odin 3.12.s/th the flashing hung up. You can close Odin and restart the phone - in my case nothing was damaged.

- You can set AutoReboot=0 in Odin3.ini. Then you don't need to check Auto Reboot anymore.

- After the two factory wipes Android updates its Google libraries automatically. Wait for that and start the Magisk steps afterwards - otherwise Magisk will be killed. (What in my case had no effect, but just to make sure.)

- When I start my S10e in the recommended way into the Magisk recovery, I have no wifi networks available. Even the libsecure_storage module does not help. What helps is a recovery reboot from inside Magisk. Is there a possibility to create a shortcut? And: is there a final solution?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xstatik:
i got an aussie s10+ for the time being :D:D
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Sly123:
libsecure works just fine on my S10.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] zaidbaby:
Is there a way to avoid phone switching itself on when plugged on power switched off?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Saibot.XI:
I have downloaded the latest XSG firmware and the current one that my phone came with, i have tried patching both through magisk but everytime i flash through odin i'm stuck. The further i can go to is and .img.lz4 file as you can see in the photo. Most of the times it just stops to SetupConnection.....

Could anyone help me out?

P.S. I have tried patching the file multiple times to see if it was a bad patch but same problem everytime......
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SirUnreal:
Would you mind to scroll just 4 posts higher than yours?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
I think its odin 3.13.3 problem. I never had that problem when i was using odin 3.13.1
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MajikUF:
Can this be used as a "temporary root"? On previous phones, there were ways to temporary root that would disappear after a reboot. (probably an exploit that was corrected during a reboot) I'm interested in restoring some apps with full data from a previous phone but not mess up any of the samsung functionality.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Dave_247:
Jesus I should of known things were going to get a hell of a lot more complicated. Still it's nice to see the amazingly dedicated work of topjohnwu refusing to be defeated.

I'm gonna do the smart thing and wait until Magisk support for the S10 reaches at least the Beta stage as it's sure to be pretty unstable for now.

also hopefully in the future there will be mthords to help negate the inconvenience of having to use the correct button combination when wanting to boot the phone in root.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kloosgj:
You pretty much asked what I was wondering too.. would be very nice if it was the case.

---------- Post added at 02:41 PM ---------- Previous post was at 02:38 PM ----------

You pretty much asked what I was wondering too.. would be very nice if it was the case.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] askim40:
Welldone John Wu. I just rooted my S10+ and now restoring all data from Titanium. Thanks for your hardwork.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] the_scotsman:
For those discussing the issue of not being able to get into download mode. I noticed this too while flashing firmware a few days ago. It's an S10 "issue". Nothing to do with anything the OP has done.

I found the ONLY way to get into download mode on the S10 is to power off the device. Hold down Bixby and VOL Down > then connect the USB cable. This instantly opens the phone to download mode.

All previous modes that worked on S9 etc don't seem to work. It doesn't work from a reboot, it doesn;t work holding down buttons only. It only works using this one specific combination. And my phone is completely stock.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
I can't seem to get the full magisk. I got an s10 plus and OEM gray out. I redid the steps instructions line 14. please assist
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Done it!

Noticed that if you do a reboot it will reboot without Magisk, but if you power off and power on it will keep Magisk installed. Don't know if it's supposed to be like this or it's a bug.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] memocatcher:
I don't know if substratum is worth doing all of this... I kind of miss my OnePlus 6. :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Found a bug, it seems to happen after some reboots. The Wi-Fi your are connected stops working and you have to delete the connection and set it again
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DaReDeViL:
Glad to see my tip being confirmed.

Another tip for S-Health users: it won't work until you modify your build.prop by changing ro.config.tima=1 to ro.config.tima=0
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DaReDeViL:
This happens only if you reboot once without magisk...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mansonstein:
My fingerprint doesn't work, it keeps saying "make sure the fingerprint sensor is clean and dry, then try again." Safetynet check success, and tried reboot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] degsyh:
Having problems here. It started to boot up and got to reset but i restarted it because i didnt think I was in magisk mode. I don't see the bootloader warning.. Just a message with an exclamation saying the phone doesn;t have official software on. When I switch it on it comes up with a red message at the top saying "only official binaries can be flashed". I've flashed the patched magisk tar file again and now its stopped at userdata.img and the message has come up on the phone download screen saying "only offical binaries can be flashed". Any ides?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tensux:
this works for me too thank you. without twrp, wondering if it would be safe to try to flash zips with an app? (i have one TBO app that i would hate to live without) if so do you have an app you would recommend?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] equlizer:
Does this work with the snapdragon version?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] FPSkillerPC:
Sadly google pay doesn't work. I've tried Magisk Hide, and hiding magisk manager. Google pay detects root as soon as you add a card :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kendzlic:
From what I read it seems so as long as your bootloader can be unlocked. I am curious if the bootloader unlock process posted by John Wu works on the G975U. All new to me so may be wrong...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] atieh99:
can somebody please answer

I'm stuck at odin when flashing patched tar file it doesn't even start what should i do
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] degsyh:
Is yours stuck at the userdata.img part? If you look at the phone it will have a red line with a error msg. Its not liking flashing the patched file for some reason. I flashed stock back and it was ok. Do we have to recreate the patched file each time (some kind of signature) as it went through ok first time.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] atieh99:
it wont even start to flash

i uses samfrim to download my ap i checked the csc and pda they are matching but i don't know what is the problem
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ferizzi726:
Is it normal that I don't have to do the button combo to boot into Magisk? If I power off and power on, I have root without touching any buttons. Does Magisk now boot automatically?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rpsweb:
I almost bricked my phone had to reflash stock is this going to get more easy? :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
Download new firmware with frija then patch it with magisk then when updating in Odin use csc_home so it doesn't factory wipe your data
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] lyndon.onin:
I downloaded this canary version of Magisk but I wasn't able to see the button to patch AP firmware of my Samsung Galaxy A6
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ChrisChristian:
and do not lose anything on the phone?do I make a backup copy and then restore?and the AP file does not patch it anymore
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] c3k:
Happen to me and other pepole too.

It's not a magisk feature, it's like the stock firmware force to boot in recovery in some cases.

Have you made any mod to system partition? Which one?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Providing you use the csc_home file

not

the other csc file your phone will automatically restore

---------- Post added at 11:11 AM ---------- Previous post was at 10:40 AM ----------

Yes it is normal for Magisk to survive power-off then power-on, but if you select restart when you press the power button the phone boots into non Magisk mode.

By the same token, if you power off and then connect to a charger the phone automatically boots into Magisk mode.

Some people prefer the phone to stay off when being charged. The only way I've found of achieving this is press power button, choose Restart. When restarted it will be in non Magisk (non-rooted) mode, then press power button and select Power Off. Connect to charger and the phone will stay off and charge as normal.

Obviously when you turn the phone on you will have to use the button combo to get back Magisk rooted. Unfortunately you loose your wifi settings when booting unrooted, you have to forget the network(s) and re-enter the password(s). I don't know a way around this as yet.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ru_dimka:
omg, so many users and no one can tell why they do a root :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SirUnreal:
Wrong thread for that question.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Garock:
but you'll lose your wifi settings each time you booted back from non-magisk to magisk right?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Unfortunately yes you do. You have to forget the network(s) and re-enter the password(s). I don't know a way around this as yet.

(Edited post to reflect you useful comment).

Now sorted, see my post #800
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] [Lemmy]:
proper backups that can be stored locally and restored without a network connection

a proper firewall that can control outbound connections for each app separately and for each connection type separately

the ability to remove system packages (bloatware)

an ad blocker on OS level that works for (almost) every ad in (almost) every app

a ssh daemon so you can transfer files with rsync

...and that's just why I root my devices. Your mileage might be even better.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
And a biggy from me is themeing, I.e changing background colours on many apps.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
Anyone update to AES5 yet may security patch. Without twrp just normal magisk. I just want to know if the procedure changed at all . Because I know it did for people that are using twrp.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] c3k:
you can prevent this problem installing libsecure_storage to /system/lib(64) instead of using the module
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
Just updated to aes5 with the may security update. Everything is running smooth
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Snake.s9:
Did you put home csc in odin ?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] patrickneil:
Any chance you can elaborate on that method or is there another thread that discusses this?

For what it's worth, I've been using Titanium Backup to get my wifi networks back. First I restore an empty wifi networks XML, then one where I've backed up all my work networks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
To patrickneil and to others who are fed up with losing Wifi and/or Bluetooth connection settings/password after returning to rooted after booting in standard non rooted mode.

I've had libsecure_storage installed for a while but couldn't find any benefit with the module, until now.

After you download and install libsecure_storage and have rebooted your phone just go into Magisk Downloads, select libsecure_storage and read the description of the module (screenshots attached), the 5th paragraph is particularly relevant, yes, you definitely need to edit a file.

I used ES Explorer to locate the file secure_storage_daemon.rc and opened it as a Text file selecting RB Text Editor, edited the last line to: stop secure_storage then saved.

Job done, no more lost wifi or bluetooth credentials after booting non-rooted.