yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Themes, Apps, and Mods] bidav1:
Can I use the new version with camera ring and with regular aod on?
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
So you'll do it?

;)

Nah I get it. But being an optimist is in my view an essential tool to go about this world. So.. here's to hoping anyway ;)

/P
[Samsung Galaxy S10 Themes, Apps, and Mods] nhariamine:
[MENTION=631273]Chainfire[/MENTION] I'd like to send my deepest gratitude for your amazing work that u put into this great app.

i just wanted to know if it will be possible to have a stable release of Holey light with the basic most necessary features, alongside another holey light beta release to test the new features that will be implemented in the future.
[Samsung Galaxy S10 Themes, Apps, and Mods] Tweety78:
Yes screen off, that's why I asked if I can have AOD set to low brightness but have the notification light independently stronger in order to save battery. oh well, I guess thats the norm.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Once the basic functionality is finished, yes. It will leave beta as soon as I think it is good enough for basic users.

I haven't found a way to influence AOD brightness as of yet.

But if you use the feature to hide AOD, it wouldn't matter, because black pixels on an AMOLED screen use the same amount of power with brightness set to high as set to low.
[Samsung Galaxy S10 Themes, Apps, and Mods] Tweety78:
Oh I see, thank you for clarifying!
[Samsung Galaxy S10 Themes, Apps, and Mods] 20degrees:
[MENTION=631273]Chainfire[/MENTION] - I've asked a question twice and neither have been responded to. Is there a reason for that? Am I asking something that's already been covered and I've failed to see it on my part? My apologies if so.
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
If you asked about the cutout swirl then yes.
[Samsung Galaxy S10 Themes, Apps, and Mods] 20degrees:
For the camera? If so, could you point me to the actual info? I never saw it. Sorry.
[Samsung Galaxy S10 Themes, Apps, and Mods] kezzuki:
I am learning so much about android and android programming just reading your thread! Thats so awesome. It really helps a lot. Thanks again! for the app and your patience for writing replies to all our dumb and/or silly questions.

One thing about how samsung counts the battery consumption for its AOD though. I have looked at the battery consumption list before and the situation counted for AOD is about the same as how long the AOD screen is lit. And this is displayed in a different item in the battery consumption list beside the "Screen" item, which does not count in how long the AOD is on. So i think the item for AOD is cery likely to be the sum of the CPU cycle + the battery used for actually lighting up the screen.

But no matter what, thats samsung's android component, our holey light is just tagging along lol
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
How about going back one single page, last answer in CFs multi reply ....
[Samsung Galaxy S10 Themes, Apps, and Mods] 20degrees:
Thanks man. I appreciate the help. ?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
So this may be outdated knowledge (or wrong in the first place), but I recall the per-component battery draw is a fixed estimate set for each component by the OEM, that Android then uses to calculate total draw by multiplying it by time. That is not the same as a real measurement. On the other hand, if AOD is the only thing running, then it could just take it from the delta of the before/after battery level, but I'm not sure that it does.
[Samsung Galaxy S10 Themes, Apps, and Mods] kezzuki:
wow...i had no idea the per-component battery drain is just multiplication :eek: LOL ...

Battery brain calculation is indeed much trickier than I expected...
[Samsung Galaxy S10 Themes, Apps, and Mods] Chibul:
Unfortunately the post you're referring to states that there will be a large black circle in the center, rather than the camera cutout. Thanks though!
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
v0.60 is here!

This new version will go on Google Play, and brings together all the last few updates that didn't.

This version allows you to use any of the animation styles with or without AOD hiding, your preference, with the exception of Unholy Light which always hides AOD.

The other big changes in this version are UI related. The colors screen has received some minor updates that should make it better usable, one of them being splitting the display into currently active and inactive channels. Several options in the main configuration screen that used multiple entries are now collapsed into single entries, which should unclutter the UI and make it less imposing to new users.

But perhaps the biggest change in the UI is the addition of a Setup wizard, and notices about needed configuration changes if you change options. I hope this will help the noob users. Unfortunately for existing users, the first time you run it, the wizard will overwrite your settings. I always appreciate feedback on this. If you really want to help, completely uninstall Holey Light and install/configure it from scratch.

This update strongly outdates the included translations.

Scheduling

This is still not in there (neither are the often requested animation intervals), but the schedule you set in AOD is respected (it should be, please report back).

AOD Helper

You can find it attached to this post.

The AOD helper is only useful if you want to hide AOD. The current version can indeed hide AOD without the helper, but using it is slightly more efficient. It does however also have some drawbacks.

The following assumes you are explicitly hiding AOD through the option, or using the Unholey Light display (which implies the option):

Without AOD helper, if there is no active notification, battery draw remains at 1% per hour the same as if there is a notification. With AOD helper, AOD is fully disabled and battery draw drops to 0%.

Without AOD helper, AOD's schedule is respected. With AOD helper, the schedule is ignored.

Without AOD helper, AOD/HoleyLight can be used in tap mode. With AOD helper, it's full on or off only.

Changes

- Added setup wizards and assistants

- Collapsed several options into single options (less cluttered UI)

- Colors: add notification tickertext to display if available

- Colors: split into currently active and inactive notifications

- Split "Screen On" setting into battery and charging variants

- Added link to GitHub in app

- Show (user)name of translators in app

- Added (Brazilian) Portuguese

- Adjusted AOD position size and follow logic

- Various crash fixes
[Samsung Galaxy S10 Themes, Apps, and Mods] andee39:
I installed v55 earlier today. Working really well!! With this new version if I stick with unholey and uninstall previous version as recommended, do I need to uninstall/reinstall AOD helper and follow the precise instructions noted with the v55 version?
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Well, you've done it again! More fun stuff to mess with!

Uninstalled .50 and testing this new version now .. I installed the AOD helper app and testing Unholey Light at the moment. Wizard seemed to work to configure without using AOD helper. I installed it manually after the wizard was done.

Tried that new 'Pie' (camera) option, not sure the meaning, but looks like "Stable" - "Steady" - "Always On/No Blink" to me. Maybe a different name then Pie unless someone can explain the meaning of Pie to me, maybe it's just late :) (no Pi jokes) Not sure of anyone who may want to use this all the time (I'd worry about burn in) but to each his own.

Unholey Light seems to be working so far. Watching it slightly rotating the colors ever so often and changing its position.

I see one drawback of AOD helper -- Tap to Show AOD doesn't want to work, just pops up the dummy fingerprint image.

For future version:

-Checkbox option to "Automatically set new notifications to Black (disabled)" in the 'Animation' section.

Why? Some (myself included) only enable small number of notifications (4 or 5 main apps) that I may want to see the Holey notification for, but some apps keep surprising with BS notifications as time goes on. Uninstalled and reinstalled, now you need to wait until <insert app here> decides to send a useless notification so I can fade it to black. I think it would be very useful, especially when testing and losing all prior color settings :)

-Checkbox option for battery charging. Blink red constantly while battery is charging, blink green constantly once battery hits 100%. Not mandatory, but I saw people asking for it.

-AOD Helper add-on check. Some indicator or message that "AOD Helper" is currently installed and is being used (if not installed, provide a means to install it) -- unless the goal is to eventually incorporate the helper into the app, then ignore.

Anyway... amazing job! Will report back if any weirdness.
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
I uninstalled both the helper app and version .51, went through the new setup process and it was laid out pretty clear. Everything is working correctly, I have tried to reproduce the force close I was receiving with DND/AOD Schedule and have not received any.

Last thing to make it perfect is the option for it to respect the phones DND, but using AOD schedule is not the end of the world for now.

Awesome work as always.
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
No. Read again.

/P
[Samsung Galaxy S10 Themes, Apps, and Mods] Tweety78:
I uninstalled previous version and installed 0.60, setup wizard was easy to understand and all went smoothly. I thought I will have to configure all the colors to the different apps again but it remembered what I already set up in previous version.
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
Would it impact the battery more if I were to keep the AOD on auto brightness, than if i kept it at low?
[Samsung Galaxy S10 Themes, Apps, and Mods] bigmann77:
Just installed the latest apk and AOD helper as well. I have AOD set to tap to show. Unfortunately when notifications come it doesn't show the led notifications and trigger AOD to turn on with it. Is this normal and if so is there a way to bypass this? I have read all the posts and can't really seem to find the answer. I've followed all the setup instructions as well. Thanks and wicked job with this app been following since the start!
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
I have this "bug/feature" - don't think it happened before...

But I am having to set colors for each notification within an app.. for e.g. on WhatsApp, i receive a notif and set the color.. another person sends a message and i have to set the color again for this one.. i thought if i set color for WhatsApp it would mean for every notif.. here it seems individual colors are being assigned to each message/contact.
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
This may help

[MENTION=631273]Chainfire[/MENTION] do you plan to add in backup/restore setting feature?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
No, just follow the instructions in v0.60. It'll adjust the recommendations and popups accordingly to having the helper installed.

The Pie option shows all notifications in a single light. So if you get three notifications, it's a third for each color. It's really a small version of the "Unholey Light".

I've added some of your suggestions to the issue tracker.

Battery stuff is future, there's other things to implement/fix first.

You are right about AOD helper, it doesn't play nice with tap-to-show. I'll add that to the drawback list.

I cannot add AOD helper suggestions to the app, it is not allowed by Google to have apps suggest to install other components that themselves are not on Google Play.

I don't really know. The brightness sensor may be on that would otherwise be off? I'm not sure how much power that uses (if noticeable at all), or maybe it's always on regardless.

AOD helper and tap to show do not play nice together. But even if they did, it would not work the way you think it would. Tap to show only works when you tap it, regardless of notifications.

What, how do you even get WhatsApp to use different channels for different users? I get the same channel for all users :(

But yeah fixing this better is on the to-do list. Telegram has the same issue. There will be a default color for each app, applied to non-legacy notifications.

That is not planned, no.
[Samsung Galaxy S10 Themes, Apps, and Mods] xPr0metheus:
So there is a lot of changes, I am a bit lost.

Is or will it be possible to use AOD w/o image, w clock, tap only + black screen notifications from this app?

Gesendet von meinem SM-G973F mit Tapatalk
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
No, right now it's either:

- Black screen with notifications

- AOD with notifications (always or on tap)

There's currently no way to show notifications and only show AOD when you tap it. It's an interesting idea, though.
[Samsung Galaxy S10 Themes, Apps, and Mods] RequeLine:
del
[Samsung Galaxy S10 Themes, Apps, and Mods] inferno2:
Hello, i put update 0.50 from playstore and i configure with setup, i don't want AOD and i download any theme AOD free and put as image. I just want black screen with notiffication ? is it possible? what i missing?

I don't want AOD but i must active it just tap to see but i just see notification when i tap to see AOD...
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
Download 0.60 and you shall recieve all you want. Just follow the instructions, especially when it concerns AOD-helper (separat install) and configuring AOD in the system.

/P
[Samsung Galaxy S10 Themes, Apps, and Mods] xPr0metheus:
I mean its basically how it works on my S8+ with the normal led :D

Gesendet von meinem SM-G973F mit Tapatalk
[Samsung Galaxy S10 Themes, Apps, and Mods] RequeLine:
Updated Russian, to version 60.

I checked - works.
[Samsung Galaxy S10 Themes, Apps, and Mods] izephyr:
[MENTION=631273]Chainfire[/MENTION] Is it possible to make the unholy light around the camera cutout instead of the large bubble in the middle?

I have some other thoughts but I will share those after a bit groundwork.
[Samsung Galaxy S10 Themes, Apps, and Mods] 20degrees:
It works in the newest .60 he uploaded. Install it and the tutorial should pop up. ?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chibul:
This just randomly started happening with me as well. For whatever reason, when a notification comes through that should trigger the camera cutout, it's instead turning ON the AOD (I have AOD off with the AOD helper as instructed in the 0.55 instructions). I'll try installing 0.60 to see if it works, but I have no idea why it suddenly began doing this.
[Samsung Galaxy S10 Themes, Apps, and Mods] RobLives4Love:
I'm just unsure how to apply a theme as "image only" lol
[Samsung Galaxy S10 Themes, Apps, and Mods] Hen-3:
After download and during install of aod it will ask you with or without clock.

Verstuurd vanaf mijn SM-G973F met Tapatalk
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
Show AOD with icons notifications by tap for a few seconds it's a great idea. And then switch to black screen with ring notifications.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chibul:
Just upgraded to 0.60 and it's happening here too. It just randomly started this morning, and was working fine before that. I have AOD turned off, AOD Helper installed and Holey set to hide AOD - but whenever I see a notification, instead of popping said notification via the camera light, it's turning ON the AOD, so that the AOD ITSELF is what's essentially serving as a "notification".

Any suggestions? I've tried toggling every setting I can possibly think of to no avail.

[MENTION=631273]Chainfire[/MENTION]
[Samsung Galaxy S10 Themes, Apps, and Mods] vojopd:
Samsung pushed out an update for edgelightning, now it works like a charm, camera cut out works!
[Samsung Galaxy S10 Themes, Apps, and Mods] AllAboutTech:
Edge Lighting+ cutout support

https://www.sammobile.com/2019/04/15/good-lock-galaxy-s10-notification-led-alternative

"this is not a complete alternative to a notification LED.

While it works for all apps when the screen is on, the

Eclipse effect doesn’t seem to work for notifications from third-party apps

like WhatsApp when the screen is off, only for incoming calls and preloaded apps such as the stock messaging app. We’re assuming that’s for battery-saving purposes, or perhaps it’s an underlying limitation that stops third-party apps from using the cutout area for notifications when the device is locked and the screen is off"

[MENTION=631273]Chainfire[/MENTION] seems that Samsung is inspiring from your work :))))))))))))
[Samsung Galaxy S10 Themes, Apps, and Mods] Chibul:
Looks like I'll be sticking with Holey (once my issue is resolved)....as if it won't notify for third party apps when the screen is off, it's useless to me lol
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Stupid Samsung stealing my thunder, lmao
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
LOL. They got a ways to catch up still.

Updates: Overnight drain was approximately 3%. But there was no notification that came through to trigger Unholey Light (I really thought there would be, will test again tonight)

Makes sense with the Pie option -- at first I thought it was just a solid color in the UI -- now I see it's Unholey Light Jr.

Weird bug Unholey Light:

Uninstall, reinstall fresh.

Sent 4 notifications to phone..

Not sure if order matters, but don't think so.. anyway, sent one default Messages, one Signal, one Gmail, and then a Missed call / quick hang up.

Pie shows correctly at first, 4 quadrants of colors (slow spin/relocation)

Leave Unholey Light on screen for at least 5+ minutes without clearing (keep an eye on it), when it gets to a certain point of the screen 2/3 of the notification pie will become invisible. So only 1/3 of Unholey Light is visible, and it starts flashing the other 2/3. It will complete the circle for a second, then 2/3's vanish for a second. I'm sure I did AOD with Image only (no clock) maybe its just an invisible area where the clock might have been? After about and additional 5+ minutes of doing this (after it starts), the Pie corrects itself and works as intended, then after a period of time, back to 2/3 being invisible. And after a longer period (after that) it just disappears until I lifted the phone for it to return and start the cycle again. Weird.

Future version:

-"Colors" section. Alternative text entry box for currently selected notification's hex color code (located below color selection slider window)

Ex. Hex: [ #FF0000 ]

<manually editable - and updates hex code automatically as you are sliding around in color window>

Why? Just to make it easier to assign like colors. Want to assign same color for gmail and another app -- just very difficult to slide the target to the exact same color for a second apps notification color (If you miss by 1 hex, Pie shows two (doubles line) even if it's just a slightly different color. Would be easy to just copy gmails default hex into <insert app here> hex text box. Or clone custom colors between like apps.

As always, great job, even if Samsung stole it :)
[Samsung Galaxy S10 Themes, Apps, and Mods] Chibul:
To follow up on this, I just uninstalled AOD Helper and Holey completely. I installed AOD Helper, installed 0.60, and went through allowing every permission as the walkthrough states.

It's still happening - every single time I receive a notification with my phone screen off (charging or not charging), instead of showing a notification light, the AOD is what's being started, serving as the "notification". This is despite my having AOD turned off and Holey set to control AOD (although any combination of those features being enabled/disabled results in the exact same thing).
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
[MENTION=9861251]Chibul[/MENTION]

Before install Restart device bro!
[Samsung Galaxy S10 Themes, Apps, and Mods] Chibul:
I did that as well.
[Samsung Galaxy S10 Themes, Apps, and Mods] -=AsteriX=-:
New EdgeLighting+ works as I would like, even in AOD on tap, it displays a notification on the screen completely turned off, AOD shows after tap, and this is great, but not without a fly in the ointment

Indication occurs only when receiving a message and no longer repeats.

You may be able to base this and combine the best features of Holey and EdgeLighting+
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Just tested Samsung's version, yes -- Duration set to long, comes on for about 5 seconds with screen off .. no option for Repeat every 5 seconds or Repeat every X seconds - useless in this state (no better then not having it unless you are directly looking at the phone when notification comes) also, does not inherit notifications default color
[Samsung Galaxy S10 Themes, Apps, and Mods] izephyr:
The Edge Light feature, also as in Goodlock's EdgeLight+ (I just checked) is really funny.
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
I just did some testing with this (well the normal edge lighting in the phone settings) and Holey Light and the helper app.

I have edge lighting on while the screen is off, basic effect, duration set to short. Holey light set to hide AOD.

With edge lighting turned on (also Holey Light on) when I receive a notification for anything edge lighting can handle the screen does not turn on and go to the lock screen for a few seconds like it does normally. Edge lighting and Holey Light comes on, and edge lighting goes off within a second or so leaving just Holey Light running.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I've seen this happening, I'm not sure what causes it. Sometimes it works for me correctly, sometimes it doesn't. That makes it hell in testing :)

The internal states of Holey Light adjust to the new TSP location, but the drawn circle isn't moved. This is going to take some debugging, but I'm confident it'll be fixed.

Just so I understand you correctly, the only thing you want changed in Holey Light is that AOD shows when you tap the screen?

I'm not sure I'm following. Is this right or wrong? If wrong, what did you expect to happen vs what happened?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
That is strange. Do you see the white swirl in Holey Light settings when you open it?
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Not sure if it's right or wrong...but I like the behavior.

Normally with just Holey Light enabled and edge lighting off when a notification comes in it shows the lock screen for like 5 seconds. I like that with edge lighting on now the lock screen does not come on at all. Even though I have a mainly black AOD background with no clock set, without edge lighting on I would get a brief flash of the background once the lock screen timed out. That no longer happens.

Edit: with edge lighting on double tap to wake does not work and will only light up the fingerprint.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chibul:
I do. And oddly enough it works just fine when the screen is ON - but when it's off, nope. It pulls in AOD instead.

EDIT: I just toggled the orientation for AOD from Portait to Landscape and back to Portrait, and now it's working. No clue why...but that seems to have fixed it for now.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Interesting!
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
I think it will do what you want if you just uninstall the AOD Helper app, and set AOD to On Always .. or Tap to Show (in AOD settings), and Untick 'Hide AOD' in Holey Light (it will use a little more battery power)

When AOD Helper is installed and being used by Holey Light, you can't do this, it hides AOD no matter what, and AOD set to On Always, or Tap to Show will not do anything as it's being controlled by AOD Helper which overrides AOD settings, and hides it always (will use less battery power, more efficient)
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
No. I mean show AOD only then notifications are exist. If not - screen automatically is off. It could be like option (enable/disable).