yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] anndrenaline:
no prenormal. now im hoping to find some who can patch a new G970FOXM3ASG8 AP for me.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Did you transfer the gep.AP with ADB to the PC?

Without should often occur errors.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] anndrenaline:
No but i did try to unzip it and it works.

Anyway thanks for your time and help. My phone decides to start properly now for some weird reason. After many restarts the phone decides to finish updating.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] eprst:
This works on my S10, but after a while Magisk (19.4-e8581b4a) gets uninstalled. Tried multiple times and every time Magisk Manager shows "Magisk is not installed" after a while, root stops working. How can I fix it?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Did you reboot with the combo keys ( bixby, volume up and power buttons)? Make sure you hold it till u see the bootloader screen for couple more secs then let go. You will boot into the rooted mode
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 3c:
I did that a dozen times, and each time I saw an Android logo with blue background and a quick message saying 'erased', then the phone booted and device was not rooted.

Then decided to try flashing TWRP, but I just flashed (again) magisks_patched and all tar.md5 as per instructions and was still in download mode. So I pressed vol- and power to get out of download mode, and as I wanted to get back to it, kept pressing vol- and power. Instead of going back to download mode it just booted normally and device was rooted ! Magisk didn't even ask to configure anything, it was ready to go.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] thesin2:
Is there any way to automotise this reboot. I mean I have to press 3 buttons on every reboot now. Is there any other way like writing a batch file or something for automatically boot into rooted mode with regular reboot option
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
There are some tools that can do that. But you have to select > Recovery <. Then the phone boots with root rights.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Norup58:
Alternatively to an app you can use this Magisk module:

https://xdaforums.com/app...r-0-7-t3680053

I only use the Magisk Reboot (Galaxy S10) option
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] sixtyfootmalcolm:
I use FireFDS to solve this. I remove Restart button, leave Reboot to Recovery intact but change the text for it (using the option further down) to "Reboot".

--

Aside: thanks to everyone for their help in this thread, got me out of a sticky situation over the weekend. :)

---------- Post added at 12:19 PM ---------- Previous post was at 12:17 PM ----------

Thank you so much for this. Had no idea this was the case & first two attempts were made using an older firmware (because it made sense to me to use the same one when first rooting). Saw your comment in the thread and that sorted it. Much obliged! :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
If you have Xposed installed there's the brilliant module called Firefds Kit. With this you can customise the power button. You can even rename and remove some buttons. Screenshots below.

If you haven't yet got Xposed, go HERE for instructions how to install.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
CarHDMod,BeyondROM,modded services.jar,FireFDS
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] heahmad:
quick question,

from a technical perspective, is there a chance will be there another method root!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bomfa84:
Magisk is not installed after an update

So I followed all the steps and was able to install Magisk and had everything working for more then a month... but Samsung had an update these days that enhances the camera using the same functionalities from Note 10 and I wanted to install this update on my working magisk phone.

I followed the instructions here on this link ( https://xdaforums.com/galaxy-s10/de...s10-series-t3918699/post80076303#post80076303 )

Basically I used Frija to successfully download the latest update for my mobile (used the correct model and CSC, etc).

Then I did exactly those steps:

- extracted the downloaded file

- copied the AP to my phone

- opened Magisk Manager

- disabled all modules (lib secure and smally patcher) and reboot the phone

- back at Magisk Manager hit Install, select patch a file and chose the AP I just downloaded

- Copied the "magisk_patched.tar" file to my computer using adb command

- power off and entered download mode

- opened Odin3_v3.13.3, deselect "reboot" under options

- chose the magisk_patched.tar as the AP

- BL, CP from the new firmware and HOME_CSC as the CSC

- hit start and waited until finish with success

- after flashed, I didn't wipe. Pressed and hold Vol-down and Power

- then I booted with the combo to start using magisk.

- after success updating all softwares I had EVERYTHING WORKING pefectly!

The issue was after I tried to re-enable the previously disabled magisk modules (as it was on the instructions).

My phone rebooted a lot of times and then it opened a screen saying that it was unable to open due to an error... that screen had the options to try again (what I did) or clear data.

Now I have my phone working again however magisk is showing as "magisk is not installed".

I already tried several times to boot using the combo with no lucky.

Also I tried to repeat all the steps again flashing the same file but this time with wipe data and formating the phone.. configured everything again but magisk is still not installed.

What did I do wrongly? I think that magisk corrupted after trying to enable the module... however now I cannot even have the magisk working again...

Please any help is appreciated.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Link to windows doesn't work for me. It connects and everything seems fine for a few seconds and then it disconnects.

I wonder if it's root that caused it.

Can anyone say if it works with root.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] chieco:
Can't update...

I'm currently on the version pictured below and can't update for the love of god...! can some one tell men how to fix this?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
I am currently on ASH6. The phone has an unlocked bootloader, rooted and has TWRP ianmacd.

Now I have a question. I want to upgrade to ASIG. I want to try TWRP from Geiti94 but I have not read anywhere how to root ASIG. Is it traditionally with the help of Magisk or something else?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
if u patch the AP file with ianmacd magisk manager you will get a failed patched AP(at least that was so with mine). what l did was:

- uninstalled ianmcd magisk manager (not magisk root)

- installed latest canary magisk manager

- rebooted (of course, with the key combos)

- patched ap as usual

- rebooted to download mod

- flashed patched ap and other firmware parts (bl, home csc etc) make sure auto reboot in odin is not ticked

- rebooted again to download mode, flash geiti94 twrp via AP slot in odin

- rebooted to twrp using the combo keys for it and let it do its process

- back in twrp, flashed muilt disabler

rebooted phone via recovery..

And my phone is working properly...

Good luck
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Links to windows works perfectly with my s10+. Maybe reinstall "your phone" from windows store.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Nextasy

You used the patched TWRP or no patched?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] stephen.brader:
I still get this error patching and tried magisk canary i thought of trying that myself before reading this post and it gets stuck on the recovery.img writing that causes it to fail. was previously using ianmacd magisk. I get the error with any magisk manager version
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] stephen.brader:
Screenshot:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] patrickneil:
Sorry I don't have an answer for you, but which Magisk modules were these? Riru? EdXposed? Substratum? Curious because I'm about to do the same.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
i used patched twrp.

since lm not sure if l will be violating any rules if l post the twrp here, if u send me your email l can send it to you..

cheers
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
I've already downloaded the patched twrp. Thanks. If it goes wrong, I will ask for help. Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] stephen.brader:
The fix that worked for me is to use the stable magisk not beta or canary or ianmacd non of them worked always failed the patching
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bomfa84:
The modules were:

- libsecure storage (the one to keep the wifi and Bluetooth data after reboot)

- smallypatcher (the one to use GPS spoofer without been detected)

I am sorry if I am not typing the correct name but you can search by this name and the description I gave so you can find the correct one...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
I've tried that.. No improvement unfortunately.

I have to find what app, or setting makes it disconnect every time. I suspect Cerberus, but still not sure.

I suppose you're rooted, right?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Yes, im rooted
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Chuytl:
i have not tried the asig firmware but did you parches the vbmeta in BL file? i don't know if vbmeta cause this problem but there is a reason to being patched while magisk ap patch
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Narkozzz:
Ok, so what we have now? TWRP with 3-key entry and Magisk with same 3-key entry. Also we have annoying startscreens "Warning! Your device modified!". Maybe somebody already figured out how to get rid of these screens and load to Magisk core as default?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
https://xdaforums.com/galaxy-s10/themes/twrp-flashable-bootsplash-zip-t3943552
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
Nextasy

Work!. I used ready-made patched TWRP from geiti94 and it went quickly and without problems. I have ASIG rooted and I have TWRP. And in addition I haven't lost my data.Thanks!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bomfa84:
Well... This is a strange thing that happended on my phone... I was receiving notification that magisk manager had an updated version everytime and I opened the app and it was saying it was updated... then I uninstalled magisk manager and downloaded the apk again. Then magisk said it was necessary to do some stuffs... it did and rebooted... and voila, I have magisk manager and root installed AGAIN WITH SUCCESS!!!

Not sure what happened here... it seems the magisk manager was somehow corrupted or something... now I have it working again but only because I did a uninstall and installed it again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
Good to hear its working for you. The process is actually pretty simple and straightforward..:laugh:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Chuytl:
that was your problem? it's not an error ? it is the process Jhon Wu explained it in the instructions Linked in the OP: "You shall see Magisk Manager in your app drawer; if not, manually install the APK you downloaded in step 3 and continue to the next step. The app would be a stub and it shall automatically upgrade to the full Magisk Manager when you open it.

Magisk Manager will ask to do additional setups. Let it do its job and the app will automatically reboot your device.

Voila! Enjoy Magisk :)"

edit: sorry i see, "only beca..."

great i will try it too, i have not made it because i'm on Beyond rom and i like to have securefolder working
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bomfa84:
The problem was not that the app was NOT SHOWING on the app drawer... it was there, but simply it was not working properly. Then it was fixed after uninstall and install again.

Sorry about the CAPS, but it was not to be unpolite, just to give emphasis of the point :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Chuytl:
no problem also i edited my reply... just wasn't very clear haha
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] x3meee:
I followed instructions from first post with latest Galaxy S10 firmware (from September). After flashing magisk_patched.tar Magisk Manager still shows "Magisk is not installed". Is this because of new firmware?

// Sorry, I forgot to boot phone with 3-key combo.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
In case it can be useful to someone else:

It is not root/Magisk related.

It was a setting in Windows. I had to allow Your Phone app to work in the background using these steps: Open Settings/Privacy/Background apps and turn on the switch for Your Phone app.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NetSkipper:
It was a clean phone, or did you have your data?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinwu128:
Sorry, still finding something.

Where do I get the magisk changelog? I'm on latest 19.5 (19405)

The previous, 19404, i kept getting random reboots...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinwu128:
I tried this exactly and now my phone is just in a boot loop............... Can someone please help me please. I am so annoyed :(((((((( it just keeps going
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
I assume you don't have TWRP installed do you, and you disabled Magisk modules.

Connect phone via USB to your computer then press and hold Vol-down together with Power button, the phone should eventually switch to Download screen, be careful to release buttons soon as Download appears. This can sometimes take a while so be patient.

Now back in Download mode, after checking your firmware files are correct, you can attempt flashing again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinwu128:
Yep i really wished i could have just unticked a module in magisk that caused the bootloop, i had to start from scratch and install everything again :( i was able to get to download mode, i just wonder if there was a way to fix it just in case it happens again. I wasted 7 hours of my day setting it up again.

Has anyone been able to install twrp after using it this root method? I am afraid I'll miss the key combo and my phone will encrypt itself again.

Also still getting random reboots. Anyone else?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
The problem of installing TWRP now in your rooted and final setup stage is that it would require another wipe, requiring restoring data and settings again. If I'd known you wanted to install TWRP, I could've given you step by step instructions on doing this at the same time as you did the rooting.

As far as the random reboots are concerned, I suggest disabling any Magisk modules and Xposed modules you might have, one by one to see if you can pin down the culprit.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
problem free without twrp.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bigpotato107:
I take it there is still no way to update and keep everything with phones Magisk rooted with TWRP ??
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
1. Does this mean that you rooted ASII?

2. Have you tried TWRP from geiti94?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] cameronkelley28:
For anyone curious, decided to be the guinea pig for magisk v20.0 and so far so good. Just did a direct install as usual.

ASIG firmware

Latest TWRP 3.3.1-11 from ianmacd (ASIG kernel)

Edxposed Sandhook
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Meaning i dont use TWRP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] eliaspizarro:
How can i root from a new device?, there is any guide for this phone, i didn't find it at least in google and XDA.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
HERE

and

HERE
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Chuytl:
Did you followed step by step as john said?

Wiped data, don't let it boot before wipe ? Everything ?

Cause is weird, if you already did it and flashed some modules just reboot normally so magisk will not be activated, if you flashed twrp you have to flash the multidisabler

Which magisk manager did you used to patch your AP file?

If you didn't wipe because don't want to losee your files use smartswitch it saves everything
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] zaidbaby:
I am having trouble. I changed the sim. Phone restart and now whenever I open magisk it is just stuck. Keeps loading indefinitely.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] henio1195:
I had same. Reinstall magisk manager and restart like always.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] zaidbaby:
How to reinstall?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rxk:
My Galaxy S10+ (android 9) is currently rooted.

If i wanted to upgrade to android 10 firmware, is the the step would be the same?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Freakyd9984@gmail.com:
Will this work on snapdragon s105G?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] FwvG:
Hello,

can i flash a new version of magisk with trwp, or do i always have to flash with patched trwp ?

Thx

FwvG
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] leviiis:
It doesn't work for me. Any idea how to get snartview work? :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Mr Anderson:
Edit build.prop adding the following line:

wlan.wfd.hdcp=disable
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] leviiis:
I try it with root Explorer, but I didn't save my changes in build.prop.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Mr Anderson:
Mount the root directory as R/W first.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] leviiis:
Thank you, now it works. :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J_Force:
Hi, I just bought the S10+ to replace my OP6T and first thing to do is rooting with Magisk. So I am using this guide by TopJohnWu AND I CAN'T GET IT TO WORK :(. I feel like a n00b! I've been doing this since the first Galaxy S, had some non-Samsung devices but mostly Samsung phones. Now I've been trying all night to get this new S10+ rooted and I just won't work.

Unlocking the bootloader worked. It is greyed out.

I had no trouble in patching the AP file and I pulled it to my PC with ADB.

When flashing the magisk_patched.tar I used the BL_..., CP_.... and HOME_CSC_... files from the firmware I downloaded with the Frija-v1.3.0 app. After flashing was done (I go to download mode with vol down, bixby and inserting the usb cable because with powerbutton nothing happens) it is where things don't go exactly like expected. I need to use the power+vol down for almost 10 seconds, the I switch to vol up+bixby+power and keep holding. But I end up in a normal boot. When turning the device off and go into recovery to factory reset and all there is no result.

please, PLEASE, pretty please can somebody help me?

EDIT...HELP NEEDED. After following all the steps. It did not work. I have no Magisk installed and when installing Magisk Manager it clearly stated that it did not succeed. Weird thing is that it had trouble to get into recovery and when I got in stock recovery (step 10) I had no reboot system option. Also I can't get into download mode with the button combo. I need to hold volume down + bixby and then put in the usb cable. That way it will go into download. With the cable inserted it will only boot normal when doing the 3 button combo.

EDIT2: I started again from point 7 in the instructions. Flashing using Odin3 v3.13.1 was done. But then I need to get out of download mode. I need to hold the power + vol down button very long, the switched to vol up + bixby + power and I do not get into recovery. I only see the Samsung splash screen, the bootloader warning, the splash and then it just boots normally.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J_Force:
HELP! after several tries going through the flashing steps with Odin and trying to get it to work it deed not restart anymore. It got stock on the splash screen for 2-3 seconds and then turned off. I tried flashing once again and then the flashing failed. I now have a device that has this blue-ish screen sayiung: an error occured while updating the device software. Use the emergency recovery function in the smart switch pc software.

What to do? Why won't this work?

EDIT: I can get into download mode. But I can't flash anything. Not even stock. Odin skips everything: succeeded 0/failed 0
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Is the phone definitely connected to the computer, should hear a beep if you disconnect from computer, then beep when reconnected?.

Have you watched this video:

https://youtu.be/o3a8YnWT3yk

It is important to wipe after flashing and before booting.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J_Force:
Yes it is connected. Yes I watched the video. Followed the written instructions where it was different (flashing not only AP). Used Frija to get official FW and ADB to get the patched image back to pc.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
It is important to wipe after flashing and before booting.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J_Force:
I know. But there was no way I could get into recovery after leaving download mode.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J_Force:
Still I have a brand new non-working S10+. Can somebody be a hero and tell me how I can revert it all? I prefer magisk version but for now I would be even happy with everything back to stock.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Flash the latest stock firmware, load bl, ap, cp, csc home.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J_Force:
will try that another time. last couple of tries it failed. Do I use CSC or HOME_CSC? And which version of Odin? 3.13 or 3.13 Patched?

edit/update: I used CSC and 3.13 Patched and Odin did his job. The phone is now flashed and rebooted. I still have OEM unlocking greyedout (bootloader already unlocked). I really want to try again. Is there something I can do to make sure that for example the patching was done right? Can I for example patch the file on another device?

Did a bit of reading on CSC vs HOME_CSC. In the above mentioned video only magisk_patched is flashed as AP. But the written tutorial states to flash complete with BL, CP and CSC. Can I use CSC instead of HOME_CSC? And do I use the patched Odin?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J_Force:
Update again: after flashing the BL, magisk_patched, CP and CSC I left the download mode by pressing vol down + power. When the screen went black, I switched to vol up, bixby and power. As soon as the splash screen showed up, I kept pressing vol up only. I then see the bootloader warning, then a blue screen with a white android and the message erasing, then the splash screen samsung logo, the bootloader warning, the it vibrates and then the normal boot screen. I just don't get into recovery. At what point should I release the bixby and power button? I feel like I keep messing it up.