yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
v0.51 TEST RELEASE - not going on Play in this state.

You will find attached a v0.51 build that has a basic implementation of AOD hiding ("Automatic AOD"). For it to work, you also need to install the AODHelper APK. It will take control of your AOD, enabling/disabling it as it sees fit.

MUST-READ NOTES

- You must set an image as AOD background (from Samsung themes) and apply it without the clock. Otherwise at some point the clock will become visible.

- Sometimes you get a little flash of AOD. Some image loading needs to be optimized to reduce it to the point where it's barely visible or not at all. Work in progress.

- This will take control of your AOD's settings, so they may change at random.

- For overnight use, it is still safer to have AOD on a schedule than using this, so your screen isn't blinking all night in case a notification comes in. The AOD schedule is not respected currently.

- The UI really isn't being intelligent with regards to the helper APK right now, it won't tell you if it's not installed, broken, disappeared, or whatnot.

- It really will not work without the second APK.

- This is not extensively tested, so report back when it doesn't work.

Tech

As I've mentioned before, Holey Light cannot directly manipulate AOD's settings. This is because it is built for Android 9.0 Pie, and Android will not let you touch them anymore unless you build for Lollipop 5.1. I cannot build the main app that way because (a) we'd lose notification LED color access and (b) all apps released on the Play Store must now target Android 8.0 Oreo.

The helper APK is built for 5.1, and can thus manipulate AOD settings. The main app just tells it to change the settings when needed.
[Samsung Galaxy S10 Themes, Apps, and Mods] cruzargel:
Yas! You can only check "battery: screen off"
[Samsung Galaxy S10 Themes, Apps, and Mods] hammertime18:
Joined just to say, thanks for all your hard work, much appreciated.
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
I love you :highfive:

---------- Post added at 11:45 PM ---------- Previous post was at 11:26 PM ----------

Bug report for v.0.51; weird behavior when double taping screen to wake with Aod helper enable. Sometimes nothing happens, Sometimes it takes 3 or 4 seconds till the screen wakes up. Otherwise its working like expected!!
[Samsung Galaxy S10 Themes, Apps, and Mods] cruzargel:
Somehow I managed to destroy my AOD settings. I'm on v.50.

When I turn on AOD in settings, whenever I turn off the screen or lock the phone, it switches off by itself!!!

Tried to uninstall this app and Tasker, rebooted and cleared data for AOD app in settings. Still same issue..

Is factory reset my only option? ?
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
[MENTION=3994204]cruzargel[/MENTION] Did you uninstall the helper app?
[Samsung Galaxy S10 Themes, Apps, and Mods] the_scotsman:
Awesome! The more granular tuning control is a great addition! :good:

I'm not sure if it's just the minute variation in manufacturing, or if it's just ne, but the standard animation just seems ever so slightly off, byt the tiniest of margins. Having this smaller control allows for better positioning of the swirl :)
[Samsung Galaxy S10 Themes, Apps, and Mods] Jalogos:
AOD Bright and holey light...

Hi, first of all, you are a genius!!

Second, I don't really know if that would have any solution, but I've noticed when AOD decrease the bright the "led" do it too, so any way to have less bright in AOD but make the "led" brighter?

Many thanks!! and waiting to have the donation button...
[Samsung Galaxy S10 Themes, Apps, and Mods] the_scotsman:
Yea, all you can really do is turn off auto brightness for the AOD.
[Samsung Galaxy S10 Themes, Apps, and Mods] Jalogos:
Even in manual, may be I said it wrong.

Any way to have the "led" at maximum brightness and AOD with minimum?

Thanks!
[Samsung Galaxy S10 Themes, Apps, and Mods] mixxxk:
Wow, every release gets better and better. The last release with the AOD helper is working great so far. Keep up the great work !
[Samsung Galaxy S10 Themes, Apps, and Mods] cruzargel:
V51 working great. It's working even if my AOD settings are broken.

Should not have messed with Tasker. I think that broke the AOD settings. ???
[Samsung Galaxy S10 Themes, Apps, and Mods] Kiran-Kumar:
Very happy with v50... at this rate Samsung might steal this feature in their next big update :D
[Samsung Galaxy S10 Themes, Apps, and Mods] jugih:
You can easily buy Him a beer. Just click the profile and choose donate :good:
[Samsung Galaxy S10 Themes, Apps, and Mods] xPr0metheus:
Getting closer to something I will use :) Hope you can figure out a way that lets me AOD clock - no image - tap to use plus holey light on black screen.

Gesendet von meinem SM-G973F mit Tapatalk
[Samsung Galaxy S10 Themes, Apps, and Mods] exeon:
Tried v0.51, working just great on my s10e!! Thanks for the brilliant app! Just that when unlock screen, it delays a little bit.

I have a suggestion! Could we make it blink 0.5 second for every 5 seconds, that would be more battery saving. I think doesn't need to keep blinking every second.

One question, for example if the light will be blinking for 1 hour before unlocking my phone, it's better to enable the "mark as seen: pickup - battery: screen off" option? Which is more battery draining?

Edit: also, is it possible to mark notifications that received during screen on as seen? :eek:
[Samsung Galaxy S10 Themes, Apps, and Mods] izephyr:
For me, 0.51 broke my notification for a few apps. And I had to reinstall those. However, I am currently using Tasker to turn on Aod for notification and turn off aod when notification cleared or display off. This working like a charm for me, yet. I need notification light as a daily driver. So, I will stay with what ia currently stable to me.
[Samsung Galaxy S10 Themes, Apps, and Mods] ziociccio:
There is an app on playstore that do this,without using tasker.
[Samsung Galaxy S10 Themes, Apps, and Mods] izephyr:
Yes, I am aware. I have read it somewhere on xda. But Tasker gives this without additional process, almost 0 battery drain. moreover, I can add more conditionsn like at this moment, aod will only turn on if it's not in my pocket (I am testing this)
[Samsung Galaxy S10 Themes, Apps, and Mods] ziociccio:
Great.

Can you share this aod tasker process? I would try it
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
What is the purpose of charging screen on and charging screen off? I have turned then both on and off and send myself a text and everything is the same no difference at all. Same with battery on and battery off. I feel the texts that are underneath the options dont do a good job explaining. Downloaded from the google store. Awesome job tho sweet app just confused on the options. What options should be on?? Any recommendations would be appreciated it.
[Samsung Galaxy S10 Themes, Apps, and Mods] Igor6661:
i don't know if i'm doing something wrong but light only works when i turn screen ON. using latest 0.51 and default settings.
[Samsung Galaxy S10 Themes, Apps, and Mods] Lagggi:
You said that notification works only when AOD is on.

Does it require "always on" option or it works anyway?
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
*Edit*

Nevermind found out by myself. :o
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
The new Android notification system (I think since 8.0 ?) uses the concept of channels. Where in the past an application would just throw notifications out there, now each notification must belong to a defined channel. The application can

create these itself. An application (package) can thus have multiple channels.

You can see this for example with WhatsApp. They use (from what I've seen so far) three different channels: individual chats, group chats, and other (like WhatsApp Web being active).

Each of these channels is listed under colors separately. All three show up as WhatsApp, but their descriptions are different. You can set the color for each of these channels individually.

This also allows you to for example set a light on battery 100% (System UI: FBT) but ignore other notifications that come from System UI.
[Samsung Galaxy S10 Themes, Apps, and Mods] exeon:
Have u enabled always on display? It requires aod to work.

It will only show when aod is showing. If u choose "tap to show", holey light will only show when u tap the screen to show aod.

I think holey light will auto detect new notification and add them into the list :rolleyes:
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Ohhh OK thanks that's a very good addition then because I have A LOAD of channels and groups in Telegram loaded and I like to be able to set custom colors depending on what Telegram notification is being displayed! :good:

PS: I will try to update the XML later today if I have some spare time left.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Pretty sure I've found a way to get this working without using any battery at all. Unfortunately that would mean the notification wouldn't be on the camera though, but somewhere on-screen.
[Samsung Galaxy S10 Themes, Apps, and Mods] -=AsteriX=-:
there is an idea for the future, maybe you will like it,

if there are two or more notifications, each notification is displayed with the next ring of a slightly larger diameter (ideally in the appropriate sequence) it is possible to draw them one by one or all at once, but it will not be so beautiful.

or a more difficult option - divide the circle into sectors

2 notices - two halves each in its own color

3 notices - three parts of a circle

if necessary I can draw for clarity
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
Well for me, I couldnt care less. I want to a have a reasonable way to know that I have missed something that has happened on my phone.

Not specifically that it must be by a specific location on the screen.

So I say run with it :)
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
+1

If you feel generous (@chainfire) you could add in the possibility of moving the notification as per user pref :D
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Sounds good to me !

However can you explain why it could not be around the camera ?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Showing multiple rings doesn't actually look good, I've tried that.

Sector base (pie slice) is actually implemented, it is used when you use AOD in tap mode and have battery saving animation turned on.

I will explain this when I get around to implementing it. I know other competing app guys are looking at the same thing, I don't want to give it all away before I've implemented it.

Still possible one of them will get it done before me though, but as I have other things to do right now, no sense in helping them along :)
[Samsung Galaxy S10 Themes, Apps, and Mods] matoneo:
It seems to me like a good option, I don't like big blinking circle very much. Swirl is fine but consumes more battery. It would be nice to have tiny notification LED somewhere on screen.
[Samsung Galaxy S10 Themes, Apps, and Mods] saxena1:
Now v.50 work with aod no problem .here is my settings:D
[Samsung Galaxy S10 Themes, Apps, and Mods] Gilg@mesh:
that reminds me of the NoLED app that was used for first generation Galaxy :D
[Samsung Galaxy S10 Themes, Apps, and Mods] Igor6661:
i just wan't notification around camera ring, the main purpose of app doesn't work with default settings, also I tried to change every other setting and still doesn't work.

it works only when i double tap the screen...
[Samsung Galaxy S10 Themes, Apps, and Mods] iteam:
THANK YOU [MENTION=631273]Chainfire[/MENTION] !!! AWESOME!
[Samsung Galaxy S10 Themes, Apps, and Mods] Ranger187:
What am I missing? Only shows notification ring when I turn the display on. Updated to the newest version, so I know I probably missed something.

TLDR: I want the ring to show with the screen off.
[Samsung Galaxy S10 Themes, Apps, and Mods] Gilg@mesh:
it only works with AOD on, or you can just use the app Automate to make AOD only visible when you get notifications, and it will also make the ring appear.

PM [MENTION=2022726]PiCkLeS[/MENTION] to get the files to import to Automate, works great!
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Or use this version here: https://xdaforums.com/showpost.php?p=79317643&postcount=481
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
me personally, love the camera style.. if you're moving towards Led Dot, I'll stay without updating.. but you're the boss, your app, you decide the direction to take. I'd leave it for camera hole (unless you can deliver both options, for some camera, for others LED dot).

???with these notifications, device got the charm it was missing with camera indicator.
[Samsung Galaxy S10 Themes, Apps, and Mods] iteam:
Need to enable AOD. Cool for me as I've always used it since it came out

Or try this version per [MENTION=631273]Chainfire[/MENTION] https://xdaforums.com/showpost.php?p=79317643&postcount=481

---------- Post added at 09:42 AM ---------- Previous post was at 09:32 AM ----------

I'm with you! Love the camera style, wish we could change animations on it too:fingers-crossed: Don't want a dot but would be awesome for people to choose their own prefernce
[Samsung Galaxy S10 Themes, Apps, and Mods] b3y0ndd34th:
Me too, it really doesn't use that much power, and it's only on when it is out of your pocket. I dont mind having this on for notifications to work.

I hear ya on the style, but I dont mind it so much. What I would really like to see is a way to make the indicator thicker.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Everything will be optional folks. I mean, the code for everything that's in there now, is already in there. So why remove the features eh?

Makes it more difficult for the noobs to configure, though.
[Samsung Galaxy S10 Themes, Apps, and Mods] Gilg@mesh:
unfortunately the AOD on S10 is always on, even in pocket or with screen face down.
[Samsung Galaxy S10 Themes, Apps, and Mods] RobLives4Love:
Yeah it ****ed with my settings, so i uninstalled and reinstalled. Funny enough, i ****ed with it yesterday and got it to work with screen off, but now no longer, especially now that i see AOD is a bit of a battery hog. Lol
[Samsung Galaxy S10 Themes, Apps, and Mods] Greskac:
[MENTION=1095939]iteam[/MENTION]

When the screen is turned off, the colors are not strong enough, can you add the option to enhance the color of the notifications?

Thanks
[Samsung Galaxy S10 Themes, Apps, and Mods] belumira:
[MENTION=631273]Chainfire[/MENTION]

Hi, I've been using and loving Holey Light. But I find myself switching it off during DND hours beacause it ignores it and lights up eitherway. Is there a way to make it work with DND? I had a OnePlus previously and had the option to switch off the LED duing DND hours.
[Samsung Galaxy S10 Themes, Apps, and Mods] iteam:
Set it to the lowest brightness.. Makes a huge difference, try that
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
@Chainfire here is the updated Italian translation based on v50.

This time I followed your advices: saved the raw XML (instead of copy&paste it into UltraEdit), edited it and saved it again into UNIX UTF-8 format. ;)

That said the per-channel update looks quite cryptic when we talk about Telegram.

I've got like 20 channels, 3 groups and 4-5 private chats right now.

The problem now is that looking at the list in Colors shows them in a very anonymous way and I can't figure out anymore what color belongs to a specific channel... :D
[Samsung Galaxy S10 Themes, Apps, and Mods] b3y0ndd34th:
Well, I didnt realize that. I thought it went off in my pocket! Thanks for that tid bit of information. Given the information you have given, I am more surprised by the lack of battery usage by the AOD.

I see why I thought the AOD shut off in my pocket. It dims, but you are right, it doesn't shut off.

Sorry for the misinformation.
[Samsung Galaxy S10 Themes, Apps, and Mods] faisalis10:
Deleted *
[Samsung Galaxy S10 Themes, Apps, and Mods] DunKzz:
[MENTION=631273]Chainfire[/MENTION] how can I provide you pt-pt translation? Do you need GitHub user? FilipeOS
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I was afraid of that happening, I haven't really thought of a good solution to this problem unfortunately. I don't have any more details about the notification to make a distinction between them.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
If you know how to GitHub:

- fork the app

- create a new branch

- add your translation in the new branch (values-pt)

- create a pull request
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Alright if there is no further solution to that I simply will reinstall Holey Light from scratch and try 'intercepting' per-channel notifications to set immediately the desired color.

I just hope to be quick enough to do that lol. :laugh:
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
In the future there may be an indicator whether the notification is currently active. This is in the issue tracker as todo item, at least.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
You could group like applications so it's just one item in the list, and inherit the led color choices from the applications, neater, but I know... UI work .. yuck

---------- Post added at 06:30 PM ---------- Previous post was at 06:09 PM ----------

ledARGB

Added in API level 1

Deprecated in API level 26

public int ledARGB

This field was deprecated in API level 26.

use NotificationChannel#shouldShowLights().

The color of the led. The hardware will do its best approximation.

See also:

FLAG_SHOW_LIGHTS

flags

ledOffMS

Added in API level 1

Deprecated in API level 26

public int ledOffMS

This field was deprecated in API level 26.

use NotificationChannel#shouldShowLights().

The number of milliseconds for the LED to be off while it's flashing. The hardware will do its best approximation.

See also:

FLAG_SHOW_LIGHTS

flags

ledOnMS

Added in API level 1

Deprecated in API level 26

public int ledOnMS

This field was deprecated in API level 26.

use NotificationChannel#shouldShowLights().

The number of milliseconds for the LED to be on while it's flashing. The hardware will do its best approximation.

See also:

FLAG_SHOW_LIGHTS

flags

newer channel apps?

setLightColor

Added in API level 26

public void setLightColor (int argb)

Sets the notification light color for notifications posted to this channel, if lights are enabled on this channel and the device supports that feature. Only modifiable before the channel is submitted to NotificationManager#createNotificationChannel(NotificationChannel).

Not sure if that can be tapped from the channel or the legacy and inherited after the fact

I know, easier said then done
[Samsung Galaxy S10 Themes, Apps, and Mods] zperetz:
Just uploaded my AOD Manager to Automate community. It enables AOD in case of notification or charging.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Grouping applications could be easily done with some UI work, the problem is with setting a default color for the app and how that works further on. Something to ponder. When I was looking at it last it required a lot more state to be tracked, and then I still wasn't sure if it'd work nice. Combine that with the legacy notification support, and it makes a mess of things. I'll undoubtedly revisit it at some point but it is not my highest priority right now.

Not sure why you're quoting the Android docs, but the modern shouldShowLights() and getLightColor() are already used in the app (which you can see in the sources). One of the problems is that all the information marked deprecated has just gone away in the newer Android versions. For example ledARGB will just return "no color" regardless of what the developer of the old app has set.

What does that improve over just using the plugin I made for Holey Light and having it handled by the app? And if nothing, why is it in my thread?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
You can just clear data :)
[Samsung Galaxy S10 Themes, Apps, and Mods] Gilg@mesh:
correct me if I'm wrong, but with this way we can use AOD as normal and not need to choose a image, so in this case we just turn off AOD in settings then automate turns it on and off, also there is a schedule flow that won't turn on AOD between given time, for exempel when going to sleep. :)
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
You choose an image to prevent the clock from overdrawing the black background if you want to hide AOD. If you don't want to hide AOD, then there's no need to choose an image.
[Samsung Galaxy S10 Themes, Apps, and Mods] kleinmischa:
doesnt work for me o_0 aod stays off if notification comes i
[Samsung Galaxy S10 Themes, Apps, and Mods] xPr0metheus:
So you suggest an un-holey light? :eek: Thats blasphemy!

Gesendet von meinem SM-G973F mit Tapatalk
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
What a marvelous idea to name the feature! This... this is mine now.

I really only have one more hurdle to cross, almost there.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Gotcha. no worries makes sense now.

---------- Post added at 09:13 PM ---------- Previous post was at 08:53 PM ----------

silly idea, but you said the un-holy feature can have hardly any impact if its anywhere else on the screen - besides the camera.. does it just have to be 1 dot blinking in the same place, or can it change positions after every blink -- without any extra cost?

I was thinking - what about a trail of blinking dots that walk from left to right and back - on the top screen. Start from left most side - to right before it encroaches on the camera and then blink/walk back.. this would draw your attention to a notification even more from a distance I think. The problem with the AOD concept (no blinking) is its just stationary with its icons and what has everyone upset .. its the movement that catches your eye from a distance. Thinking Knight Rider. Although now after I wrote this, that maybe CPU cost will indeed be needed to do this....
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Victory is mine

This works confirmed with CPU sleeping, hurrah. Sub-1% power drain per hour, here we come.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Even better :)
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
This could actually be turned into a proper replacement for edge lighting notifications. Since it works for all apps with individual colors, you could have a setting to only show the light when an notification comes, instead of having it keep blinking until you read it. That way you will please both audiences. Just add a toggle to show the light for a few seconds when a notification comes. It would be simply amazing if you could do that. It would also appeal to those who's scared to use this because of burn in. Win-Win situation IMO!
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
With the helper app it's working amazing. I really like how when you have more than one notification it cycles through the colors.
[Samsung Galaxy S10 Themes, Apps, and Mods] 20degrees:
Will there be options for location and size for that? Man I really like the camera cutout one. ?
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
Amazing! Will the new Un-holey notification be customizable? A giant ring in the middle off the screen is a liiitle bit to much for my own taste. (I guess it needs to be that big to cover up the picture from aod?) Would really love to just have a small blinking LED on top of the screen, like the old s8.

Will report bugs as soon as i find any! Cheers
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
While there may be customizations to the display itself (making it smaller is no problem, just draw more black, eh), it can absolutely not be animated, nor moved. We're stuck with the position AOD picks.