yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Italian translation

I would like to contribute by doing the Italian translation, but I could not figure out where to look at?

I went on the GitHub page of Holey Light and I couldn't see a translation folder or something... :eek:
[Samsung Galaxy S10 Themes, Apps, and Mods] inferno2:
Hello and thanks for this app, i'm french sorry for my english, i install the ver 0.40 and accept all the permissions the app is OK.

I just want to see the animation when screen is off but is not OK, i don't use AOD and use fingerprint, when i receive message, i don't see the animation, but if i press one time on screen the fingerprint mark appear and the animation too!
[Samsung Galaxy S10 Themes, Apps, and Mods] Mohamed Ibrahim1:
You're wonderful as usual!

Now your overlay is above all!! Even above Samsung overlays like "Task changer" .. above android black statusbar .. 1th overlay.. great step.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
https://github.com/Chainfire/HoleyLight/blob/master/app/src/main/res/values/strings.xml

This is expected behavior if you have AOD disabled, you need to enable AOD for it to always show.
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
OK thanks and then I attach it here in this topic or?
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
Wow.. you managed to preserve the Taj for so long :) I am impressed and touched.. Great.

About the screen shot.. if you take a screen shot of a page that is longer than what fits on the screen (like a web page on Chrome) then once you click the power and vol down for screeny, it will show you a down arrow (second icon from the left and the bottom) and you can keep scrolling and adding the image to the screenshot

And I will test your advice on the options later this evening.. so you mean, if i have AOD off, i should still see notification ring, screen off and unplugged? (And the app is exempted from optimisation)
[Samsung Galaxy S10 Themes, Apps, and Mods] chkdsk90:
Sorry for that dump question but i don't understand the options under mark as seen :)
[Samsung Galaxy S10 Themes, Apps, and Mods] inferno2:
If AOD must be On for display what is the advantage of this app ? if AOD is ON and always display i see notification on it!

I just want black screen with just animated circle
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
in regards to "p.s." part in my comment,- I mean I though when plugging in charger it could be optional to see charging indicator on AOD or Screen On separately, either I'm missing something or it's not there.. battery charging tied to System UI in Colors (if you set it to black then it obviously isn't showing, if you colorize it, obviously it does) but on both aod and screen On and no option to choose where you want it as for notifications for example, we choose where we see them without relying on 10 sec Mark AS Seen- Pickup option..

as for Tasker profile, it basically turns On aod when notification comes there for your app shows the notification around camera as well. I haven't tested it because not planning in using this particular profile (even though I'm a long time Tasker user)..

https://www.reddit.com/r/galaxys10/...p_you_can_use_tasker_to_only_show_the_always/
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Thanks for that info. No, you need AOD on for now.

If you use those options, notifications that have shown you the light will no longer show once you perform the action.

For example, say you enable the mark as seen "After unlock" option, and you received a WhatsApp notification in your pocket. Once you unlock your phone, Holey Light will stop showing you the light for that specific notification, without you have to dismiss the actual notification. It will light up again if you get *another* WhatsApp notification, though.
[Samsung Galaxy S10 Themes, Apps, and Mods] chkdsk90:
Thank you very much for that fast reply and of course for that great app
[Samsung Galaxy S10 Themes, Apps, and Mods] exeon:
And have to make sure the "Smart capture" under Settings > Advanced features is enabled. :good:

Anyway, will it be using proximity sensor to stop blinking when phone is inside pocket? But it sounds a bit battery consuming if yes lol.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Can you try the attached version to see if those other notifications show up now? (in black, under colors)
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
It's on the list to investigate (please people, check the issue tracker, it's #16). Reasons have been explained before in this thread.
[Samsung Galaxy S10 Themes, Apps, and Mods] exeon:
Oops sorry for overlooking.
[Samsung Galaxy S10 Themes, Apps, and Mods] Z953RR:
Any plans to support other devices? (ie p30 pro?)
[Samsung Galaxy S10 Themes, Apps, and Mods] exeon:
P30 pro do not have notification led too?
[Samsung Galaxy S10 Themes, Apps, and Mods] Z953RR:
unfortunately not...
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
nope .. not showing.. did it 3 times, waited a bit for it to show up in Color list, no Go.

UPDATE>>> oh sh*t, it just did .. Haha.. pure genius [MENTION=631273]Chainfire[/MENTION] .. it took few minutes. alllll apps are supported now!!!
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
I found a solution to my problem. Which was that i did not want to have ANYTHING on my aod BUT the notification ring. I downloaded an aod theme with a very dark image (link below) and set the aod brightness to the lowest setting. Even in pitch dark i cant see the image :cool::cool: Im soooo happy with the way Chainfire created this amazing app. Thank you!

http://apps.samsung.com/theme/Produ...lackPaperCutDesign_89783.aodonly&SITE_CODE=en

Opens in Galaxy Themes.
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
Yes, but isn't the notification ring as dim and hard to see at times?
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
Its dimmer, but to the point that its still Very easy to see it. Almost better with a dimmer light ;)
[Samsung Galaxy S10 Themes, Apps, and Mods] SAO:
[MENTION=631273]Chainfire[/MENTION]

As usual you deliver !

Great application that does what is meant to! I've added the AOD theme from post #364 by [MENTION=9837049]bytypez[/MENTION]. I didn't dim it as I like the effect to be "lit" .

Everything seems to work perfect with your last version 0.40 from your post #357.

Thanks again buddy!
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
If anyone finds an even darker Aod theme, please be kind and tell us here :highfive::cool:
[Samsung Galaxy S10 Themes, Apps, and Mods] SAO:
I think it shouldn't be hard to do. Just a full black amoled wallpaper with a dot lol. But I'm ni pro on these things....so don't know.=_=
[Samsung Galaxy S10 Themes, Apps, and Mods] matoneo:
I'm afraid that proximity sensor is unusable yet due to Samsung's limitations. It works just during calls.
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
Unfortunately you can no longer select your own wallpaper for aod. You can only download the themes on the theme-store. All those themes in the store has to be accepted by samsung.. meaning its hard to make them accept a fully black one, What i have read.
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
[MENTION=631273]Chainfire[/MENTION]

brother, I hope you didn't miss my edited comment where I said v0.40-legacy has ALL apps support... thx for not giving up on that, much appreciated. considering all the technical difficulties you've encountered it's a work of Art..

your influence and dedication in Android community has no limits and valuable to all of us.. hope you'll continue working on this app withing your time capabilities, you know better than anyone there are always places to improve.

for now it's a damn great job and I'm super glad you joined in on s10 development.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Thanks for reply.

1- got it, using 4,4,0,-1 was the closest to making it look right on S10+ for me, but its still weird on the bottom right side (off a little, .5 pixel maybe) like scotsman suggested

edit: I'm using FHD+ btw, i wonder if resolution effects it. Trying to save some juice in FHD+

2- it does not clear after 10-15 seconds, I'm using power saving blink animation, and showing while screen on -- repeatable for me .. all I did was send 2 notifications from 2 different apps with 2 different colors (messages and signal). Unlock the phone and immediately pull down the notification and swipe both away quickly from bottom up instead of top down. (top down works) bottom up leaves the phantom blinker .. I cleared it by just sending another notification to the phone and swiping away that single notification (it cleared the notification and the phantom) -- only when swiping away notifications bottom up to clear it occurs for me - nobody else can replicate this behavior?

edit: didn't try this in WQHD+ yet
[Samsung Galaxy S10 Themes, Apps, and Mods] kezzuki:
Here is another dark AOD, which is also FREE:svetius::svetius::svetius:

http://apps.samsung.com/theme/ProductDetail.as?appId=minuhome.Earth.aodonly&SITE_CODE=ca

It is much darker than Holey Light's ring so that you can still see easily the ring, and overall it looks great.
[Samsung Galaxy S10 Themes, Apps, and Mods] pippobauro:
Hello Chainfire, i'm following this thread with interest, your app works very well. i have installed today the v0.40 today and test it with battery power, yesterday i was looking at this app under battery charger and i seen it works very well, i'm one of most that missed the notification led, i tried one app found on play store but was draining a lot of battery. looking at the work of this app i'm sure you will do a great job, i never rooted any phone and i don't want root my s10+ (exinos core) now, maybe i will tell you what you can add (of course if it's possible). from march 8, when i received my s10+, this is the most interesting app i ever found on internet and if you will do a final release i will buy it, or donate if you prefer, because this app solves a very big problem of this phone. excuse me for my english, but i'm italiaan and i never write in english, my english comes directly from school
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Found another way to make a phantom appear. Received a text message notification and unlocked with fingerprint and very quickly opened the message app. The person who is the sender needs to be the focus prior so it opens right to the person who sent you the message.

How to replicate: Open Messsages, click on the thread of person who is going to send you a test notification and when the their thread is in focus, just lock the screen there. Now send the phone a test message to that person. Upon unlocking and immediately going to the Messages app that person will come right up (in focus) - notification is automatically cleared from notification pull down and icon badge, but phantom blinker persists. If Messages is opened to all threads initially it will clear the blinker notification - only happens when thread of notification recipient is already in focus prior to opening app. Do this rather quickly, as soon as notification is received, or very close to receiving it.
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
[MENTION=631273]Chainfire[/MENTION] I am translating into Italian the XML when I noticed that you use

\'

into the code when you want to display an apostrophe.

Therefore I was wondering if I have to use something similar when entering letters with accents (ie. à, ò, è, etc.)?
[Samsung Galaxy S10 Themes, Apps, and Mods] Sacher_Masoch:
Working great! Thanks for this app!

For me the only issu is that it keeps rigging when messenger is in floating mode (because it also creates a notification saying that it is floating). Don't believe there is much to do about that right?
[Samsung Galaxy S10 Themes, Apps, and Mods] -=AsteriX=-:
It seems totaly black free AOD

http://apps.samsung.com/theme/ProductDetail.as?appId=minuhome.Starlight.aodonly
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
[MENTION=631273]Chainfire[/MENTION]

You said that its possible to "paint" over an aod. But it was ineffective due to the clock? If we use an aod theme with only a picture should that problem be possibly solved?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Does it work if you use a USB cable rather than wireless charging? Shouldn't make a difference, but worth a shot to see if it matters.
[Samsung Galaxy S10 Themes, Apps, and Mods] DoobyDroid:
I can't get past 2/4 if click ok nothing happens nothing to select s10+ View attachment 4735927
[Samsung Galaxy S10 Themes, Apps, and Mods] pigmich:
Have you enable the bluetooth?
[Samsung Galaxy S10 Themes, Apps, and Mods] DoobyDroid:
Will try now [emoji106]

---------- Post added at 08:49 AM ---------- Previous post was at 08:47 AM ----------

That did it thanks [emoji106]
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I have the (in-rom, no additional apps) edge lighting still turned on on my device and it still works. A side effect of this app is that edge lighting actually works as expected if Holey Light is already showing a notification, rather than forgetting to actually turn the screen on.
[Samsung Galaxy S10 Themes, Apps, and Mods] the_scotsman:
That is really schmick! :good:

But of course the main use case is display off on battery. But it's a difficult one to come up with a solution, with battery usage, as you briefly discussed on Github. I'm not sure how you can best work around this. Hopefully you can come up with something because that notification is perfect!

Throw in some minor customisation once you've worked out the kinks of the guts of the app, and this will be the most popular app of S10 users by FAR!

Awesome work as alwasy mate! I was waiting for someone to come up with something practical. Thankfully we have one of the best working on it!:D
[Samsung Galaxy S10 Themes, Apps, and Mods] Mohamed Ibrahim1:
A professional work from an already pro dev, why I say that ? Because the animation just simulates the exact stock animation of Samsung! Not just created tiny animation/look ..

I hope you add more customization to it such as to be as a battery indicator.

Also it doesn't work with me while screen is off whether aod is active or not. "I hope you make it works while aod is active too cauz I use aod"

Thanks for the amazing work as usual Chainfire!
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Doesn't so anything for me sadly.

I passed step 1,2 and 3 and I never had step four.

When I get a notification it indeed say that Holey Light is displaying on top of apps, however nothing is happening.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
It is the stock animation of Samsung. I ripped it out of the ROM. Took some time finding it...
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Just to be sure, are you in portrait mode, and is there actually a notification that would light up the LED normally? Unread Whatsapp, Facebook Messenger, Telegram, Twitter DM, etc?
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
I received an Email, Snapchat, and I had nothing.

I tried sending myself text messages, and nothing either :/

And yep, I am using my phone in Portrait.

I have a bunch of frozen system apps, could that be the issue ?
[Samsung Galaxy S10 Themes, Apps, and Mods] tiho5:
Will try this for sure!

Big thanks and happy you're on board with this!

Question I've asked in the other thread:

Will this app have a priority setting?

I mean if I get a missed call and I have for instance blue color set for it. And in a while I get an email with green color set for it, I would still want to have the blue color for the missed call lighting, as this is higher priority for me than the email. Once I see my missed calls, that notification is cleared and then I would still have the green one now until I check my emails.

If one sets multiple different colors for different notifications, will they be able to set such priorities?
[Samsung Galaxy S10 Themes, Apps, and Mods] AllAboutTech:
working prefectly on S10+

now the awesome thing would be to work with the screen off. i would pay for this option and i am sure most of the ones from here would do the same.

thanks.
[Samsung Galaxy S10 Themes, Apps, and Mods] Gilg@mesh:
[MENTION=631273]Chainfire[/MENTION] is it possible to make it not to turn off AOD when charging and getting notifications? thanks :)
[Samsung Galaxy S10 Themes, Apps, and Mods] hanne1989:
Working with wireless charging & usb charging

- Screen Off

- AOD disabled

*Tested with Whatsapp*

/Request/

- Charging animation light

- Blink effect (Like the first Galaxy S had on the soft buttons)
[Samsung Galaxy S10 Themes, Apps, and Mods] 2Faat:
I second that, I get no selection popping up after the 2/4 message on wifi with bt on and connected, restarted reinstalled got all kinds of notifications but nothing seems to do the trick for me?

I did debloat my device after this guide https://www.google.de/amp/s/xdaforu...alaxy-s10-s10-debloat-bloatware-t3912073/amp/
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Anything could be the cause really, I just don't know. The next update will always show a notification when you're in the config UI, to help debugging.

You can try manually exempting Holey Light from battery optimizations, but that really shouldn't be necessary at this point.

Are you using any other apps that (ab)use the notification or accessibility APIs?

If you have multiple notifications, it currently shows them sequentially. For example, WhatsApp is green and Twitter is blue, if I have messages on both I get alternating green and blue animations.
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
Works flawless. Thanks for making this app :highfive: The only weird thing is that the ring is maybe 2-3 pixels too much to the right on the s10+. Would also wish for a timer to slow it down a bit ;) Well done
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Unfortunately it's either AOD or this (when notifications are present); we cannot draw on top of AOD. The README on GitHub touches on this.

Charging animation has absolutely zero priority for me. Not sure what you mean with blink effect? I could go dig up an original Galaxy S but only god knows where it is now....

You absolutely need to get that device selection popup. If no companion device is selected, the app cannot access the LED colors on the notifications (it is a silly restriction), and nothing will work.
[Samsung Galaxy S10 Themes, Apps, and Mods] tiho5:
Thank you. That's also a good way. Even better in some cases. But if one has more than 5 notifications is becoming too much. So it's also good to have the prioritiy stuff. I hope you consider.

However alternating is fantastic to have too.

Question again :

(I still haven't tried the app, sorry)

Can one set custom lights different for each app?
[Samsung Galaxy S10 Themes, Apps, and Mods] b3y0ndd34th:
I would REALLY like to see the ability to manually add an app so that I can adjust the color. There are some apps that have notifications that just refuse to show up under the Colors section that I have been able to get led notifications for in the past.

LOVE THIS APP! It's not bloated and it actually works!!! (Which I am not surprised Chainfire is awesome!)
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
@ everyone I played around a bit with these Samsung themes, and we could install our own ones. I have an APK ready. However I have no way to create the QMG images files (and actually have them work). Sad!

You can disable the notification that messenger is floating. Does that solve the issue, or do then new messages not actually show up?

You're right though, this needs some attention.

Possibly, but there's still the case where Holey Light isn't actually active. I'm looking into auto-disabling AOD when this is the case. Work in progress.

Try the version in this post: https://xdaforums.com/showpost.php?p=79306122&postcount=357

Manually adding an app would do nothing. The lists shows all the notifications that the app has seen. If it can't see it, it can't respond to it, whether I let you add it manually or not. That's just not how things work.
[Samsung Galaxy S10 Themes, Apps, and Mods] Covafett:
I have this same issue. S10+
[Samsung Galaxy S10 Themes, Apps, and Mods] b3y0ndd34th:
I will give it a shot, Thanks! I just don't understand why Textra doesn't show up! I could care less about my email and my hangouts. I get to those when I get to those. But missed calls and text messages are my big wants.

YAHTZEE Textra showed up! Meh, I could care less about manually adding an app now XD.
[Samsung Galaxy S10 Themes, Apps, and Mods] crabapples:
Really happy with the app so far. I didn't even bother with any of the others as the comments suggest myriad issues. I trust Chainfire to get it right and keep it right.

My only issue that doesn't seem to be in the issue tracker is where certain notifications trigger Holey Light to display a red ring but said application does not appear in the colors configurator inside Holey Light. That the color is red by default is interesting to me considering no notifications are currently set to be red. It's better than nothing, though. Ideally anything that can trigger the ring should be configurable for color within the app, though.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Not sure if it's in there, but don't forget to have a check in the code if the app updates its LED method -- example, let's say Textra puts out an updated version in a week and decides to use channel notifications instead of legacy, then it will default to black and you will have people complaining that it doesn't work again - just looking out for future situations and headaches :)
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
[MENTION=631273]Chainfire[/MENTION] I am almost done with it mate so let me know. :D
[Samsung Galaxy S10 Themes, Apps, and Mods] trp3383:
Nvm
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Do you also have it occur when dismissing multiple notifications in reverse (bottom up) order from the notification bar? (phantom)
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
That's weird. It's not the first time I've read this either (or maybe that was also you?), I don't know. The app itself doesn't do it. Does it remain if you turn the app off?

Yes, you need to escape apostrophes with \, not sure why that is, but otherwise Android Studio complains.
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
I need to know from you if the same has to be done with letters with accents (ie. à, é, etc.)! ?[emoji28]
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I don't think so.
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Alright thanks I will go on then.

Once I am done I will attach it here in this thread OK?
[Samsung Galaxy S10 Themes, Apps, and Mods] Covafett:
I haven't noticed that. I've only noticed when the messaging app is already open to the person, or in focus, as you mentioned. I'll try to see if it occurs for me also.
[Samsung Galaxy S10 Themes, Apps, and Mods] crabapples:
That was my first post in over 5 years, so it wasn't me before. The notifications do disappear when I turn off the app. I'm just now testing it (S10e) so it may be more things like it but this particular app is the default email client for both a POP3 account and an Exchange account. The Gmail account came in as a configurable app (com.google.android.gm).

---------- Post added at 12:21 PM ---------- Previous post was at 12:11 PM ----------

I just got my first Whatsapp message and the ring was colored green like I configured for the HoleyLight notifications themselves. Still, no whatsapp entry appeared in the list of apps to change the colors so I am stuck with that green for now.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Sure

Have you tried killing the app in multitasker?
[Samsung Galaxy S10 Themes, Apps, and Mods] johnnyutah22:
If there is anyone who has this app working correctly on an S10 US variant phone, could you be so kind as to post screenshots of your settings. For the life of me I can't seem to get this app to work. Thanks.