yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DHGE:
You have to DL the ROMs (Frija I use for that) and flash them with Odin.

Follow post #1974 here.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fil3s:
When I reboot to download mode (1st step) and hold volume up nothing happens. I held vol up for a good 5 minutes. Can someone help?

Edit: g973f

---------- Post added at 03:47 AM ---------- Previous post was at 03:11 AM ----------

Also my S10 is on android latest 10
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Phone must be powered off. Press and hold Vol-down and Bixby button, finally connect phone to computer with USB cable. Within seconds the download screen will appear.

Press and hold buttons before connecting USB.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fil3s:
It's ok I did it :good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] David8960:
Bit late reply, but i guess its to help others: Yes, the finger print sensor will still work. But your phone security is compromised anyway if security concerns you at all. Any person with a little knowledge can flash twrp on a rooted phone and disable the screen lock removing a few files from the /data partition. Most payment features will be disabled, and certain Samsung apps will refuse to work. But for me personally its not a big problem.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Dilrajkehra:
Hey, Could you please help me out as well. I have Samsung S10 Plus Latest update Android 10 CANADA. Thank you.

---------- Post added at 04:44 PM ---------- Previous post was at 03:58 PM ----------

Did you find anything for USA variants?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hhwong:
does anyone know if the stock rom can be deodexed? I need that to work in order to take some screen shots from bank apps right?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ultradj83:
Magisk on Galaxy S10+ with Android 10

Hello there.

I'm attempting to install Magisk on S10+ SM-G975F/DS, with Android 10, firmware AP_G975FXXU4BTA8_CL17806689_QB28787933_REV01_user_low_ship_meta_OS10 by following the official guide:

Straight through to point 8 then, on point 9, there's a problem.

I cannot reboot phone directly to recovery to factory reset as it automatically shows a blue Erasing... screen, then boots system:

[YOUTUBE]Bh28W5dCqyw[/YOUTUBE]

Well, I could complete the procedure, but at the end Manager reports Magisk is not installed.

Any suggestions?

Can I install directly on Adroid 10 or do I have to root on Android 9 and then to upgrade to Android 10?

Tks everybody!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fil3s:
I downloaded stock rom, grabbed the ap file , transfered to S10 (pie) patched it with magisk 20.3 used the following command in adb ;

adb pull /sdcard/Download/magisk_patched.tar

loaded the magiskpatched ap , csc, bl and cp, removed Samsung and Google account. Flashed successfully with odin:D

Zero idea :confused:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ultradj83:
Sorry what you mean?

Why did you remove accounts?

Did you succeed in obtaining root?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fil3s:
Yes.

Edit: I removed accounts because Odin told me to :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ultradj83:
Are you on S10 with Android 9 or 10?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fil3s:
Pie ?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Krissienn:
I have the same problem..

Any solution?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Neefemi:
I think there is an application that can help in booting S10e/Plus/10 after it has been rooted without having to do the combo stuff.

Quick Reboot

. It is on Play Store. I have tried it and it boots to root everytime but when I restart normally, I get stuck at the Unlock screen. I input the Pin/Pattern and then it will reboot that screen and request for unlock again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bamsbamx:
Hi,

Have been reading the OP documentation, as well as, the post of the official TWRP, and the both state that Magisk has to be installed into recovery partition since the boot partition does not contain the ramdisk anymore because the ramdisk is now inside the system partition.

Then, why not disable dm-verity by creating a script like multidisabler to disable AVB and directly install Magisk into the ramdisk inside the system partition?

This is the only point I have left to understand. I guess this could simplify the rooting process by only having to install Magisk zip installer through the original TWRP recovery, as in pre-N

EDIT: Or, instead, use a custom pre-rooted kernel directly built with magisk inside its source code maybe? This should remove the need of using hardware keys to boot?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] firefds:
If you are using Xposed, my module Firefds Kit jas that feature
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hiroo Onoda:
Or, you could just use Tasker to setup a 'reboot to recovery' task which is linked to a simple shortcut anywhere on your phone. Works like a charm for me.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] eprst:
magisk crashes when patching AP

Magisk 642788ab (277) crashes on me when patching latest Android Q ROM

c52e8901433929201eb26fce5900efae AP_G973FXXU4BTA8_CL17806689_QB28787932_REV01_user_low_ship_meta_OS10.tar.md5

2020-03-05 14:23:32.639 24299-24299/com.topjohnwu.magisk E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.topjohnwu.magisk, PID: 24299
java.lang.IllegalArgumentException
at com.topjohnwu.magisk.model.entity.internal.DownloadSubject$Magisk$Companion.invoke(DownloadSubject.kt:101)
at com.topjohnwu.magisk.ui.install.InstallViewModel.install(InstallViewModel.kt:64)
at com.topjohnwu.magisk.databinding.FragmentInstallMd2BindingImpl._internalCallbackOnClick(FragmentInstallMd2BindingImpl.java:649)
at com.topjohnwu.magisk.generated.callback.OnClickListener.onClick(OnClickListener.java:11)
at android.view.View.performClick(View.java:7352)
at android.widget.TextView.performClick(TextView.java:14177)
at com.google.android.material.button.MaterialButton.performClick(MaterialButton.java:967)
at android.view.View.performClickInternal(View.java:7318)
at android.view.View.access$3200(View.java:846)
at android.view.View$PerformClick.run(View.java:27807)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7037)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
2020-03-05 14:23:32.640 24299-24299/com.topjohnwu.magisk E/App: java.lang.IllegalArgumentException
at com.topjohnwu.magisk.model.entity.internal.DownloadSubject$Magisk$Companion.invoke(DownloadSubject.kt:101)
at com.topjohnwu.magisk.ui.install.InstallViewModel.install(InstallViewModel.kt:64)
at com.topjohnwu.magisk.databinding.FragmentInstallMd2BindingImpl._internalCallbackOnClick(FragmentInstallMd2BindingImpl.java:649)
at com.topjohnwu.magisk.generated.callback.OnClickListener.onClick(OnClickListener.java:11)
at android.view.View.performClick(View.java:7352)
at android.widget.TextView.performClick(TextView.java:14177)
at com.google.android.material.button.MaterialButton.performClick(MaterialButton.java:967)
at android.view.View.performClickInternal(View.java:7318)
at android.view.View.access$3200(View.java:846)
at android.view.View$PerformClick.run(View.java:27807)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:7037)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:965)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] pupochek:
FWIW, had no problem patching AP_G973FXXU4BTA8
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] eprst:
Tried with all the modules disabled - same thing..
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] pupochek:
That is irrelevant. Redownload the firmware and try, maybe the file is corrupted...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] eprst:
I did, same result. md5 was also the same
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bsam55:
I was having same issue with SM-G9730 and after several firmware downloads assumed no firmware problem so I reverted to MM 7.51 to patch AP file and update succeeded. I then reinstalled MM 277 and updated to 20306 Canary build Magisk and all is good.

I'm gonna mention for [MENTION=6011480]fil3s[/MENTION] and anyone else interested while I am writing that I have noticed lately that I can now boot with power button only into root mode. I did nothing to enable this and I'm guessing it is a welcome improvement to Magisk that allows this.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
This isn't an improvement, this has always been the case, Magisk survives when you power off with the power button and then power on with just the power button only.

You loose root if you select Restart. So if you select Restart you will need the 3 button combo as soon screen goes off.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bsam55:
Yep, I just checked it and you're right. I don't know how I got mixed up about it but, sorry for faulty info.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
When you choose reboot to recovery it will reboot to system with Magisk.

If you do the same, but hold the volume up in the first stage of the phone rebooting, it will take you to recovery.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bruram:
I was until yesterday in BSL4 with my smg970F (S10e).

Now I upgraded to march security patch G970FXXS4BTB3 using Odin 3.13.1 and Magisk Manager canary (7.5.2 ?) 642788ab, with a new reinstallation from scratch

I have a problem in ctsProfile which is on false.

Other test with stable 7.5.1 generate the same problem.

What can I do to resolve that imperfection?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Yiftach123:
Lost root after reboot

My root is lost after restarting the device,

What should I do? (the root worked for 24 hours, until I restarted the phone)

Tried uninstalling Magisk and reinstalling but that didn't help.

It says "Magisk is not installed", it was installed before I restarted the device.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bruram:
>I was until yesterday in BSL4 with my smg970F (S10e).

>

>Now I upgraded to march security patch G970FXXS4BTB3 using Odin 3.13.1 and Magisk Manager canary (7.5.2 ?) >642788ab, with a new reinstallation from scratch

>I have a problem in ctsProfile which is on false.

>

>Other test with stable 7.5.1 generate the same problem.

>

>What can I do to resolve that imperfection?

answering myself...

This a general question involving a lot of people

See

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post81913803

and following pages

---------- Post added at 08:59 PM ---------- Previous post was at 08:52 PM ----------

@ Yiftach123

Try restarting with the combo key for 6-7 seconds (Power+bixby+volume up)

A simple restart loose root, root needs a combo key restart
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Yiftach123:
Thank you,

Can you please explain a little more?

I'm trying the combo when the phone is running (home screen), it doesn't do anything.

I tried force reboot (Power+volume down) then the combo (Power+bixby+volume up), went to recovery then clicked reboot system now - also no root (Magisk is not installed).

SOLVED

Booted to recovery then chose "Shut down" - that worked.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Yawin_sh:
Magisk do not display modules

My SafetyNet status (ctsProfile: False) and (basiclntegrity: False). How can i Fix?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Abastasija05:
:silly
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] putti71:
I have a question, I don't have TWRP installed and if I update my firmware with latest Odin files, do I have to do a factory wipe again after I patched AP file with magisk or can I skip it?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
No you don't have to wipe again.

See my post HERE
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SirUnreal:
A little bit off topic:

I'm out of having my device (Samsung S10e) rooted. It was anoying. Google maps only found my position when it was stopped before and another app was tracking my position. And then I couldn't leave the Google maps app. Only Google maps had that position problem.

When having switched between Magisk and normal boot then saved wifi connections could not connect anymore (known problem).

With a low battery the last percent dropped a little bit too fast. At all too many wakelocks. And the problem with no OTA updates and the risk of having problems with manual updates by odin. My Android was version 9 from March or April 2019.

Now I'm back on stock. Some bloatware was removed by adb. Tracking and ads of apps are blocked by Blokada (VPN app with local connection through blacklists). I use Android itself to block as many rights as possible of apps - even Google apps if possible. Yes, backup is a problem. Titanium doesn't work anymore, so I have to backup my main apps by their own backup mechanism. Tested adb backup and restore, but only a few apps came back in full configuration.

Even Button Remapper works perfectly now, only some adb sh commands were necessary.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] biustech:
Hey guys, i had my phone rooted for about 3 weeks (s10 stock rom, stock recovery) i installed a module from magisk repository, rebooted (from magisk) and lost root. What should i do? Can i Just reinstall the patched AP file via Odin? Will I lose my data? FW ASJA

TIA
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MarioKempes:
Did you reboot to recovery from magisk?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
latest version magisk cant patch new firmware. its stuck on flashing. can someone confirm that?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rafalubo:
:good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Clear the cache in settings, app, magisk manager solved the problem and then reboot. Viola.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] putti71:
How can I update magisk without TWRP? I am rooted, but on stock recovery and magisk app shows me an update of magisk to v20.4
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DHGE:
"Install" and see ...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hidden_in_d_mist:
hello

I am new to this root/unroot , have done it before, i have a samsung galaxy s10 plus snapdragon varaint all update. Is this magisk root still sweet , still good legit at this time? , any problems/compromises with this ? i have all updated everything on my phone. i will be attaching a ss of my software . Thanks for helping[IMG="software information"]https://ibb.co/hfNF5PT[/IMG]
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Narkani:
I hate to break it to you, but only the Exynos versions can achieve root, and the 5G sprint version I believe.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Tel864:
LOL, have you been hidden in the mist? It was common knowledge years ago that the Snapdragon was locked down.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hidden_in_d_mist:
ok, sir. dont be rude for no reason.. dont be LOL and its common knowledge "Da". are you stupid ? its not common knowledge.. unlike you i have more important things to do than **** posting or rooting my phone all day. TEL864 what is this name so innovative .

---------- Post added at 04:14 AM ---------- Previous post was at 04:13 AM ----------

thankyou for telling me :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] putti71:
Most likely this leads to a bootloop or soft brick, but thank you for the tip
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DHGE:
you are welcome

do/did it with several devices - never had a problem
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] putti71:
You were right! It worked right within the manager app
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] c_j_k:
Magisk update

A few days ago I got a notification from Magisk Manager that I can update from 20.3 to 20.4

Will it work if I just click "Install" ?

Stock Rom, Android 10
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
Did you read the last posts above from yours?:confused:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] AlphaDream0:
I agree it's not 100% clear from the posts above,

but I just tried it myself, and yes you can just simply click 'install' in magisk manager and it works.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] billyx1:
Just bricked my phone doing this ...

I'm now in a bootloop and not able to get to recovery or download mode. Any Ideas how to solve this?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] AlphaDream0:
I don't know what you exactly did and what's on your phone,

you should always be able to get in recovery with the key combo, try it from a powered off phone.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] billyx1:
None of the key combinations work - perhaps because it is not abel to turn it off completely or because the reboot happens faster than it is possible to get into the recovery or download mode.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] AlphaDream0:
then just wait until your battery runs out
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] billyx1:
Already did that. Still no possibility to get into recovery or download mode.

EDIT: Was able to get to download mode. The trick was not to press all three buttons, instead only bixby + volume down and then plug in the USB-C connected to the PC..
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
When you're in a boot loop, connect your phone to your computer via USB, then press and hold Vol-down button and Power button at same time until screen goes off. The instant the screen goes off and still holding the Vol-down button and Power button press and hold the Bixby button. Be patient, might take a little while, release all buttons soon as Download screen appears.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 3c:
Losing root on reboot?

I've successfully flashed a few months ago my S10+ following the instructions while it was still running Android 9.

In case it helps others, I upgraded to Android 10 by downloading the latest firmware and patched the AP file with Magisk. Then flashed everything (BL, CP, AP, HOME-CSC to keep my data) with Odin and rebooted. It booted just fine and device was upgraded to Android 10, and rooted.

Now, I rebooted the other day and upon reboot, I lost root! Had to flash in Odin again to get back root.

Here is my question if anyone can shed some light on this: when we reboot our S10, do we have to press any buttons to make sure it boots with Magisk? Why first boot have root and subsequent boots do not? Is there a way to prevent this from happening?

As I'm testing Xposed features in my app, I don't want to have to re-flash every-time I reboot the device to test updated features! Ok, at worse I can create a .tar with only boot.img, recovery.img and vbmeta.img, so it won't be that long to flash, but still have to reboot twice and flash it, which is, to say the least, very inconvenient.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DHGE:
You should follow the link in post #1 of this thread and read the instructions.

You have to boot to recovery - a normal reboot first or later boots without Magisk being active.

In the Magisk modules screen there is a menu that lets you boot to recovery.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
If you power off with the power button then power on again, root survives. But if you select Reboot root will be gone when the phone reboots. Root is restored when you use the 3 button combo as the phone restarts.

This has always been the case with S10 root and not unique to Android 10.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 3c:
I've read it many times, and it was not clear until I read 'magisk in recovery' section. I have a Tab A with the same method of booting, so I knew about it but forgot about it since I rooted the device several months ago, only upgraded a few days ago.

Thanks for the tip, can't believe I didn't try it before.

Not unique to Samsung (and Huawei), having a Pixel 3 XL and a MI 9 both with Android 10, they boot with root automatically.

Are you sure about power button? Do you turn off with the software menu or keep pressing until it turns off instantly? I've added a shortcut to reboot to recovery, so that'll do fine too.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dirtydirtyharry:
I selected reboot earlier and realised after that I had lost root. Just wondering, does this mean it has been lost permanently or is it still there waiting for when the phone is started with the 3 button combo? Thank you.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 3c:
You will get back root if you use the 3 buttons combo. I failed to do that and re-flashed patched image for no reason, lol.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dirtydirtyharry:
Haha. That's exactly what I went and done this morning!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Software menu of Firefds which is activated by the hardware power button.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fil3s:
This is awesome. Can't use Snapchat but meh.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jediknight111:
Ok this is probably a stupid question, I have Magisk 20.3 installed at the moment, and update 20.4 available

Will me having modules and magisk hide cause any issues in updating? I've changed package name for Magisk hide so wanted to double check if I needed to revert to standard before updating

Thanks in advance

---------- Post added at 07:05 AM ---------- Previous post was at 07:05 AM ----------

Ok this is probably a stupid question, I have Magisk 20.3 installed at the moment, and update 20.4 available

Will me having modules and magisk hide cause any issues in updating? I've changed package name for Magisk hide so wanted to double check if I needed to revert to standard before updating

Thanks in advance
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DHGE:
No

To be on the safe side with the modules: uninstall them, update Magisk, reinstall

sometimes I forget... (no harm here - I have only the bluetooth patch installed, which may not be running all the time)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] letus.mors:
Hello...I need some help. I've just updated it to one UI 2.1 and if reboot (without root) it starts normally

but if i press the buttons to start with root, it just stay on samsung's logo and reboot again.