yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Ah ok, I get it, yeah so have a Blink and AOD on only when notification is not cleared , once cleared, it's a black screen again and AOD is sleeping

---------- Post added at 05:59 PM ---------- Previous post was at 05:57 PM ----------

-Option to "Unhide AOD only when notification is present" :)
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
[MENTION=9839677]S10Guest[/MENTION]. Exactly! :)
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Something like this?

https://xdaforums.com/galaxy-s10/themes/app-automate-display-to-notification-t3920902
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
So it seems like Samsung is catching up :

https://www.xda-developers.com/sams...e-lighting-effects-galaxy-s10-display-cutout/
[Samsung Galaxy S10 Themes, Apps, and Mods] jugih:
Are you NOT reading this thread at ALL ?
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
Good idea. But i would like to see also Holey light blinking when I got notifications. So I believe CF can do this feature simply and better! :)
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
XDA Article > Sammobile's Article.

I wonder if a mix between the two would be possible ?

Also from my testing it does not work nowhere near as good as Chainfire's implementation. When the screen is on AOD it wont show anything at all.
[Samsung Galaxy S10 Themes, Apps, and Mods] Hamza5682:
Do you think you would expand to other punch hole devices as well? Like the honor view 20? Because I would love to use this.
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
Garbage!
[Samsung Galaxy S10 Themes, Apps, and Mods] Mapantz:
Hi there. Thanks for your hard work regarding the app.

I'm getting the issue of a static circle in the middle of my screen while it is off. It works fine on the lock screen, though.

I take it we lose the AOD? The clock appears briefly when I lock it and then half of it disappears.

Scrap that! I have it working. I'm new to Samsung phones, so i'm still working things out.

I have it working now and as I said above, thanks for your work. :)

Just a quick question; When you say the battery usage is 5.5% per hour for swirling, does that mean 5.5% if a notification has been left for 1 hour? Or 5.5% per hour regardless of notifications?

An added extra I have found... I use an app called 'Rain Alarm Pro'. It has a built in LED notification system so you can choose colours for close/heavy rain. Obviously, it didn't work because there's no native LED supported as standard on the Samsung S10. However, it now works with holey light installed, and it doesn't need a colour to be set within holey light, which is great!
[Samsung Galaxy S10 Themes, Apps, and Mods] bighand01691:
Awesome work. Thanks. Only thing to make it perfection would be if it worked in landscape ??
[Samsung Galaxy S10 Themes, Apps, and Mods] m8980:
hello,

I am a little bit confused,

if a new notification arrives i see a big ring on display, not around the front cam.

attached a screenshot with my config.

always on display is enabled with a picture only like recommended in the wizard.

thanks for help
[Samsung Galaxy S10 Themes, Apps, and Mods] Mapantz:
See where it says Battery: Screen off?

Click it and choose an animation.
[Samsung Galaxy S10 Themes, Apps, and Mods] m8980:
big thanks. now i understand the different options there.
[Samsung Galaxy S10 Themes, Apps, and Mods] -=AsteriX=-:
No, i use AOD only by tap, it will be perfect if Holey can work all time, but AOD only by tap
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
Yes. And second point is add option to show AOD with Holey always when we got notifications. And automatically turn off AOD when notifications are absent. And at the same time to save possibility to show AOD by tap. So we could watch the clock. It would be like a charm :)

Thank you!
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
Any way you can have it work like edge lighting? Light the camera cutout only when a notification comes, and then shuts off, like Samsung just did. But you would have the advantage of having it run in every 3rd party app.
[Samsung Galaxy S10 Themes, Apps, and Mods] TorpedoGirl:
+1

Would be amazing! I miss my led so much :crying:
[Samsung Galaxy S10 Themes, Apps, and Mods] pug1:
That option is already there pal. That is the point of this app. Scamdung have just copied his idea ??
[Samsung Galaxy S10 Themes, Apps, and Mods] vojopd:
How did they copy the idea when they already implemented it when switching between front and rear camera ???
[Samsung Galaxy S10 Themes, Apps, and Mods] Ndaoud360:
AOD just got notification with hole punch BUT not with screen off which is disappointing. This app works great for screen off but changing a setting stops notifications from lighting up when screen off. Uninstalled and reinstalled but no dice. I just want notifications with screen off and barely any battery loss. Hard to come by I know but just wanted to mention. In pocket notifications would be annoying too and I heard proximity wont work well. I did download a proximity app specifically for not turning the phone on in my packet and it works quite well.
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
Where? Doesn't the light in holey light stays on until we dismiss the notification?
[Samsung Galaxy S10 Themes, Apps, and Mods] pug1:
In holey light at the bottom where is says mark as seen... pic attached
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
That's not what im talking about. I'm talking about the same functionality as edge lighting. Edge lightning only lights up for a few seconds when a notification comes.

The mark as seen feature will dismiss the light on holey light when we perform such actions, but thats not what i meant, since the light will stay on for as long as i do one of those actions..
[Samsung Galaxy S10 Themes, Apps, and Mods] pug1:
Oh ok
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Serious question, I'm not trolling by ask this.

What purpose does a notification light that only comes on for a few seconds serve? If you're able to see the light for those few seconds that means you're right by your phone.
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
Im not asking him to redo his app to have only this fucntionality.. im asking him to have it as an option for those who dont want the light on for as long as you dont deal with the notification..

im only asking him because he is very close to doing what samsung doesnt do.. which is allow 3rd party apps to work with the official edge lighting with the screen off without having to turn on pop up notifications.
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
So you mean like add a timeout option, say it flashes for a minute and then it stops?
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
yes, exactly. For seconds too if possible. Like 5s, 10s...
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Gotcha, I could see something like that being handy if you're not around your phone for hours at a time so it's just not consistently running. The seconds part I don't get it because that kind of kills the idea of a notification LED.

But everybody's entitled to their own opinion. Something I might not find handy somebody else will.
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
Yes, its just great to have options. Id rather have it alert me that a new notification came in, than having it be always on until i deal with it..
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
Hi all, I flagged this to [MENTION=631273]Chainfire[/MENTION] already but neither of us can figure out what might have changed... So I wanted to ask everyone else in this thread if they could confirm if their "Notification Swril" is showing with the screen off and whilst charging or if this has disappeared for you too?

Mine stopped working between 0.40 and 0.50 (can't really tell which one of them was the last time that worked, but I think it was 0.25).

Now I can only get the notification when the screen is on...
[Samsung Galaxy S10 Themes, Apps, and Mods] ramnkc:
Which app you are using? Can you share?
[Samsung Galaxy S10 Themes, Apps, and Mods] Mapantz:
Is AOD switched on?
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
Yes, I've always had it on with the "tap to show" option.

With the phone charging should show the swirl but it doesn't.
[Samsung Galaxy S10 Themes, Apps, and Mods] Mapantz:
Do you want it to show just the swirl on the black screen? Because mine doesn't, even with it set to 'tap to show' The swirl will show when you tap the screen once.

I plugged my charger in, and I get the swirl, but only when I tap the screen, or AOD is always on.

Apologies, it's all rather confusing.
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
The app is designed to show the swirl if the screen is off and the phone is charging (providing that you turn that setting on).
[Samsung Galaxy S10 Themes, Apps, and Mods] Mapantz:
Only if the AOD is showing.

I cannot get any notification light to show unless AOD is switched on.
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
Nope, with or without AOD... when charging you are supposed to see the swirl if you get a notification if you have the option enabled. You didn't have to have AOD on and hidden for it to work.

This kinda proves that the setting is not working for some reason...
[Samsung Galaxy S10 Themes, Apps, and Mods] Mapantz:
Well I have only used the latest version, and I get no LED swirl if my AOD is switched off. That's a problem for me, because I schedule my AOD to be on from midnight to 7am, so I can glance at the time if I wake up. After it switches off at 7am, I don't get any LED swirls unless I go to my lockscreen.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
If AOD is turned off, you get nothing, currently. I think some of the confusion with the "older users" is that initially, Holey Light used a window that showed independently of AOD. We changed to AOD because we use way less battery that way.

The "hide AOD" option just makes the AOD invisible, it is in reality still there.

If I'm understanding the comments correctly, what is asked for by several users are two different things:

(a) A tap-to-show mode. In reality, this would just hide AOD selectively until tapped, then show AOD for several seconds. Faking the original tap-to-show mode. I am in fact unsure if this is even possible, but I'm willing to find out. (We may not be able to detect taps)

(b) Hide AOD on a schedule. In the example case, AOD would be visible at night and hidden during the day. Notifications would show up in both modes. This is certainly possible technically.

These settings would both have you configure AOD to be Always On, and Holey Light would do the rest of the magic. These both require options inside Holey Light that are not currently available, and thus is cannot be setup that way right now. If it is something you envision you will still want in a couple of weeks, add it to the Issue Tracker on GitHub.
[Samsung Galaxy S10 Themes, Apps, and Mods] Mapantz:
That makes sense now. :)

That would be great! :highfive:
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
I have the S10 Plus and I spend more time reading this thread and keeping up on it then I do in that entire S10 Plus section...lol
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
(b).02: Hide AOD until a notification comes, when notification comes then show AOD (clock and all) with user choice blink/swirl/pie over camera, once notification is cleared, send AOD back into hiding/sleep.
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
Hide AOD until a notification comes, when notification comes then show AOD (clock and all) with user choice blink/swirl/pie over camera, once notification is cleared, send AOD back into hiding/sleep. Exactly would be perfect!
[Samsung Galaxy S10 Themes, Apps, and Mods] Covafett:
Yes! So much this!
[Samsung Galaxy S10 Themes, Apps, and Mods] Ndaoud360:
Pocket Screen Lock https://play.google.com/store/apps/details?id=com.goldenpie.psl
[Samsung Galaxy S10 Themes, Apps, and Mods] brenopapito:
[MENTION=631273]Chainfire[/MENTION]

Updated version of the PT-BR translation.

*the orange lines are now translated
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
Aaaah, got it!! That's why!

I've not been using the hide AOD setting so far because the image always blinks (briefly shows) and that makes my OCD sad. I will see if I can cind a darker AOD.

[Edit] If the problem of the old method was battery consumption, can we not have that other option implemented *only* whilst the phone is charging? Or is that too much trouble code-wise?

Thanks!
[Samsung Galaxy S10 Themes, Apps, and Mods] kleinmischa:
Feedback to version 6.0 on S10+:

My phone is set to Hide AOD and if i try to wake up the phone it happens frequently that in first 0.3sec. the lower 25% of the screen turn on and than the other 75%. This happens with any wallpaper/live wallpaper. Doesn't matter if lockscreen and normal screen have different wallpapers or same. Doesn't matter if its FHD+ or WQHD+.

But it doesn't happen always... thats whats strange to me and it happens only if "Hide AOD" mode is on.

Is there anything else I could try?
[Samsung Galaxy S10 Themes, Apps, and Mods] optimummind:
I'm on the latest Play Store version of Holey Light & AOD helper and the "Unholey Light" option isn't working as intended for me - no giant circle in the middle of the screen. I just see an ultra small speck of light in the top middle part of the screen. It's about as big as this symbol: *

All other options work fine - Blink, Swirl, Pie. I have the Unlocked 975U1 S10+ model.

Any one else with similar experiences?
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
That happens to me too, I think is the black image that is over AOD to make it black which does not disappear immediately or at the same speed as AOD itself when you tap. I am trying to overlook that minor "glitch" for now as I do like the Holey LED to be there even when the screen is off.
[Samsung Galaxy S10 Themes, Apps, and Mods] mixxxk:
Same for me. The screen glitch isnt every time, and it only started on .60. All previous versions didnt do that.
[Samsung Galaxy S10 Themes, Apps, and Mods] b3y0ndd34th:
Me too! There were like 3 or 4 posts in the S10 plus section for another App that did something similar to this. It didn't work well though, IMHO. I hated seeing it advertised so much when it wasn't reliable. Someone was nice enough to recommend I come over here and take a look. And guess what!? Holey Light JUST WORKS! I haven't been more happy since I came over to this thread!
[Samsung Galaxy S10 Themes, Apps, and Mods] Devhux:
This is really cool and seems to be working fairly well.

Would it be possible to have an option to disable the "Hide AOD" option when charging? I use my phone as a bedside clock and it would be handy to have AOD working normally when on my wireless charging dock.

Edit - might be trickier as I forgot you have to use an AOD with just an image to use that option
[Samsung Galaxy S10 Themes, Apps, and Mods] iteam:
[MENTION=631273]Chainfire[/MENTION] Does anybody know if the use of the camera hole LED causes any kind of "Burn In"?? Just not sure if its part of the main screen or a separate LED and if burn in is a consequence..
[Samsung Galaxy S10 Themes, Apps, and Mods] -=AsteriX=-:
this mode is very desirable because

"Holey + AOD on tap" saves energy better than

"Holey + AOD" until the notification is viewed also because as we know, the AOD does not turn off the screen in your pocket
[Samsung Galaxy S10 Themes, Apps, and Mods] inferno2:
hello i'm on ne last playstore version without any other app like aod helper or other and the soft is very good but two things:

-I don't find black AOD, i take the first free theme AOD and when my phone go to sleep i can see the theme for 0,5s and after is hide.

-sometime randomly my AOD move to landscape mode?? and the image of my aod theme is visible permanently, i must going into AOD settings and remove landscape mode.
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
[MENTION=631273]Chainfire[/MENTION] - Not a bug or anything that personally annoys me, but flagging it if you want to look at it.

-Current settings (0.60): AOD always on + AOD helper ON

-Expected behaviour: when touching the screen AOD is not visible

-Observed behaviour: when touching the screen AOD is covered by AOD helper *unless* the phone is charging. When charging the bottom part of the screen shows the information re charge (percentage and time until fully charged).

Again, not a problem.
[Samsung Galaxy S10 Themes, Apps, and Mods] Lagggi:
I was searching for an alternative of led light notification to install in my S10+.

Tried yesterday for the first time this app (v0.60) and no problems till now.

I prefered swirl light to the camera hole,costomized colours and yes I have reliable notification now!

AOD is in off position and screen wakes up only by the swirl hole light when notification comes.

Really there is no battery drain with this set up.

Congratulations to chainfire....:good::good::good:
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
Anyone else experience that a few apps loses vibration? Even though it's enabled for those apps in system?
[Samsung Galaxy S10 Themes, Apps, and Mods] Mad Queen:
Hello to all!!

First of all congratulations on your work!!

It is really amazing what you did.

I'm here reading all the threads almost from the beginning. I've installed the app and I check it from time to time to see your updates, what's changing and how the whole thing progresses.

Somewhere along the road among the questions and the updates I got lost.

So I have only one question without any suggestions or anything. Just a question to see where we are at and of I have configured everything Wright (for my preferences at least).

So the question. With AOD on in Tap to wake mode, without downloading any helper or theme as the instructions say, does the ring in the punch hole work when my screen is off? Can the notifications wake the screen (the ring actually) and keep it on? I don't have it on when the screen is on.

Just this question. Just to know if it does it or not.

Thank you in advance.
[Samsung Galaxy S10 Themes, Apps, and Mods] henklbr:
Could you share your settings of "Holey Light" & your "Always On Display"?
[Samsung Galaxy S10 Themes, Apps, and Mods] Lagggi:
Here are my settings:
[Samsung Galaxy S10 Themes, Apps, and Mods] andee39:
I've upgraded to v6.0 and have noticed when I get unholey light notification, half of circle is the color I assigned and the other is black. I do have some other apps marked as black but none are receiving notifications at the same time. Did not happen in v55. Am I missing something?

Am happy to hear charging/full battery colors are on the to do list (at least I hope I read that!). Didn't realize how much I would miss until it was gone!

Thanks again for all your efforts [MENTION=631273]Chainfire[/MENTION]!
[Samsung Galaxy S10 Themes, Apps, and Mods] lightmastertech:
Not sure if this has been asked before, but with the AoD helper app, is there a way to have it detecting if your phone is in your pocket (proximity sensor?) and not even turn on AoD unless your phone is out if your pocket?
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
How are you getting holy light to work while you have AOD off??
[Samsung Galaxy S10 Themes, Apps, and Mods] lightmastertech:
Do you have the AoD Helper app installed? https://xdaforums.com/showpost.php?p=79317643&postcount=481
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
No i did not but i have it now ? thank you!

Quick question now with AOD off any notification I get has the swirl effect but only on the lockscreen nothing when the screen is off. Is there anyway to have AOD off and have the light effect on the off screen? Because that the whole point of this app for me to know about notifications. The offscreen work with AOD on so that no issue but i would like AOD off thanks.
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Yes, set this as your AOD and when you do select no clock:

http://apps.samsung.com/theme/ProductDetail.as?appId=minuhome.Starlight.aodonly&SITE_CODE=us

And these are my settings for Holey Light and settings for AOD in the phone settings. With this combo I have a completely black display (fingerprint still works without waking the screen) and when a notification comes in my locks screen and hole punch comes on for a few seconds then my screen goes black and the hole punch is still running, letting me know I have a notification.

In Holey Light I have charging screen off that way I don't get a light in the middle of the night when my phone is always on a charger.

Hope this helps.
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
And here is a quick video of what it looks like on my S10 Plus with the helper app installed and my settings from the post right above this one.

https://youtu.be/kpifq-swRxo
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
Awesome thank you!! Working smooth with AOD off and getting light in the off screen.
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
[MENTION=631273]Chainfire[/MENTION] can you please add a timeout option for the notification light? so the light will go away after a few seconds
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
Why would you meed this feature? For that use edge lightning or the new camara cut out that samsung released them self. I would think the purpose of this is for notification alerts just like in previous samsung phones that light never when away untill you saw the notification.
[Samsung Galaxy S10 Themes, Apps, and Mods] filipe.dultra:
edge lighting doesnt work with all 3rd party apps.. thats why im asking him to do it because it would work flawlessly
[Samsung Galaxy S10 Themes, Apps, and Mods] lyndonjohnson:
This app is coming close perfection! One thing I noticed about double tap to wake just in case anyone is wondering. The AOD image will come on and go hidden after you lock the phone, as you can't see the image after it is hidden, if you happen to double tap on the image part, it will just show the fingerprint instead of waking the phone. I usually just double tap near the corners or above the fingerprint sensor to always successfully wake the phone. :D
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Do you happen to have edge lighting on? I found the same behavior when I had edge lighting on. Once I turned it off it doesn't matter where I tap.
[Samsung Galaxy S10 Themes, Apps, and Mods] Ndaoud360:
I have aod on tap I can't seem to get notifications to show on screen off. It used to but not anymore. I tried re-installing and wiping data too.
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
AOD has to be on Show always for it to show with the screen off and you need to install the helper app and check off hide AOD.
[Samsung Galaxy S10 Themes, Apps, and Mods] lyndonjohnson:
Just double checked, edge lighting appears to be off. The AOD image does randomly shift each time the screen turns off, maybe you are a lucky person and tapped at the right spot every time :laugh:
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Kind of weird.

I am far from Lucky...lol

But I just tried it again and turned on edge lighting. I can reproduce the exact same behavior that you stated is happening.
[Samsung Galaxy S10 Themes, Apps, and Mods] aygz:
Version 0.6 battery drain is much higher than version 0.5.
[Samsung Galaxy S10 Themes, Apps, and Mods] Lagggi:
I don't know...

I have set edge lightning also to on position. Does it have any influence?

I really don't know...

Chain fire maybe has the answer!
[Samsung Galaxy S10 Themes, Apps, and Mods] Tweety78:
You can set them now, they will appear under colors section as those:

System UI (GEN) >>> Charging

System UI (FBT) >>> Fully charged
[Samsung Galaxy S10 Themes, Apps, and Mods] koko115:
My aod always works, even if in pocket. Its normaly ?
[Samsung Galaxy S10 Themes, Apps, and Mods] Ndaoud360:
So I guess no way right now to have tap to show aod because I'm pretty sure it was working before without aod helper.