yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Themes, Apps, and Mods] DamirZg1:
I was very disappointed when I realized that my s10 + did not have a LED notification. Then I started exploring the Internet. I realized that many owners of the Samsung s10 were disappointed. I truly respect your efforts to solve their stupidity problem. BAT ... on my s10 + no applications did not help. I tried a lot of options, but nothing helped. I tried the options in my cell phone. Nothing! I tried 'Always On Edge' with all the options but it did not work right. I tried your apps too. I read many posts trying to solve the problem. Nothing helps to solve this problem on my s10 +. I'm sorry, because you have to work hard enough to fix their mistake. I will keep track of your application work and I hope you will succeed. If you solve this problem, I'll be glad to donate it. Finally sorry for my English, it is with the help of google translator.

Have a nice day!

Greetings from Croatia!
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
I would be so happy with just the blinking option + screen off. Can you implement it so people can choose between the battery heavy animation or blinking? :highfive:
[Samsung Galaxy S10 Themes, Apps, and Mods] -=AsteriX=-:
yes
[Samsung Galaxy S10 Themes, Apps, and Mods] aygz:
it is working only when is screen on , not working if screen is off with my Galaxy S10.!
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
Read the post before asking, its not implemented yet.. :angel:
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
Finally someone I can actually believe will deliver...

Thanx for joining in Chain.

My situation,-

Did everything recommended and demanded (permissions, aod, immediate lock, bla bla bla, everything), also as recommended earlier here re-installed, rebooted etc..

Works only when app is working (Galaxy S10+ Exynos), no signs of life when charging. or app Notifications.. not working, trying few ways around (off, on, aod).

update: got one Notification after which I understand you can go into Colors and it should appear in the list (read it in issue tracker link) but the app didn't get added there, still only Holey is the only one there. just curious if it's me, device or the app in really early phase (at least for s10+ Exynos).. maybe some sort of different connection should be used than Bluetooth to my LG TV ?! hm...
[Samsung Galaxy S10 Themes, Apps, and Mods] aygz:
Charging screen off is implemented and not working
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
If it's not working at all, check ADB logcat for any crashes; may need some live debugging with users too at some point, to figure out some of these issues.
[Samsung Galaxy S10 Themes, Apps, and Mods] Jawomo:
You could use an accessibility service to draw the notification ring over AOD (with limitations), lockscreen and unlocked. Theres a special window type for accessibility services. That could also help to reduce battery drain. If you need more info let me know. Regards
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I had tried that without success - couldn't get anything to draw at all. Maybe I did something wrong there? Also, aren't these banned from the Play Store by Google? :)

I did manage to draw on top of AOD *just now* with display in doze mode, but the setup is far from ideal - requires launch from PC (every reboot).

I'm going to try the accessibility route again, now I've at least made sure I can get the system running in doze mode in the first place. Not clear on doze+suspend yet, but we're definitely getting somewhere.
[Samsung Galaxy S10 Themes, Apps, and Mods] popophobia:
Arc light is able to draw on top of AOD. I'm not sure how they do it.
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
Works fine for me! And ive never had any bugs yet with this app :)
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I'm not familiar with Arc Light, and with no link nor further info that's not very helpful.

Either way, I'm close to getting it to work well and cheap (battery wise). Probably have to piggy-back off of AOD, instead of being able to manage the lower-power state ourselves. That is unfortunate, but it cannot be helped at this time it seems.
[Samsung Galaxy S10 Themes, Apps, and Mods] popophobia:
Sorry it's one thread below this one on the forum.

https://play.google.com/store/apps/details?id=com.symetium.holepunchcameraeffects
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Seems everybody wants to do this now eh. Well feel free to use that app instead :)

Serves me right for trying to get things *and* battery friendly *and* not violating any Play Store policies, should have just done that to begin with, would've been done last week :P

Not going to go bother competing with a dozen other apps.
[Samsung Galaxy S10 Themes, Apps, and Mods] rahulkheria:
I haave not tried any of those apps.. tried your app bcoz of you only.. and i know u will make things possible sooner or later
[Samsung Galaxy S10 Themes, Apps, and Mods] saxena1:
Not going to go bother competing with a dozen other apps.

Appreciate your workmanship ?
[Samsung Galaxy S10 Themes, Apps, and Mods] AllAboutTech:
hi [MENTION=631273]Chainfire[/MENTION],

As I said before, I am ready to pay for this app once or if you need to make it work with screen off while battery.

Thanks.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Well. Seing that this other app doesn't get the ring placement right, and probably much more people are already aware of your method, I would definitely stick with it.

Also I've been using yours since it was fixed for S10 and I don't see any reason to switch to anything else.
[Samsung Galaxy S10 Themes, Apps, and Mods] popophobia:
Sorry I didn't mean anything. Just thought you may want to know.

Nothing against you. I've been using your apps since forever.
[Samsung Galaxy S10 Themes, Apps, and Mods] 20degrees:
I'm totally cool with you taking the time to tweak it. I'll buy it or donate as soon as you post a link to enable me to do so. ?

I appreciate your time and effort in creating this. Thanks.
[Samsung Galaxy S10 Themes, Apps, and Mods] Jawomo:
Accessibility ban was revoked by google as impact was way too big. No problems with my bxActions app here...

Drawing over AOD has some disadvantages like animations and even viewlayout updates not working properly.. Maybe you find a workaround.

I thought about creating such an app months ago, but decided against it because keeping screen on will require a wakelock and will always drain battery way more than a manufacturer implementation.. im excited about your upcoming solution :)
[Samsung Galaxy S10 Themes, Apps, and Mods] dung014:
S10 Notification LED

Hi everyone, can I get the file for the Samsung A50 device?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I couldn't find any information on the ban other than their original announcement, and then later that the ban was paused. But that was 2017.

So on the side of caution I didn't investigate that much further. I was investigating another avenue that allows us to control doze power directly, but though it seems I now have the permissions I need, I still can't find a path to trigger the right calls inside system_server. As a side-effect of those permissions I also gained full system window access, so no accessibility rights needed. BUT as I noted earlier it's a hassle to set up, and not worth it unless I can fully control doze power. So back to accessibility it is.

I did run into the animation issue there as well, and I do have a fix. For now I will assume that fix will also work with accessibility, it will take me a couple more hours to find out.

I think the best way I have right now re: battery life is just piggy backing on AOD, letting AOD control the power saving mode, which trigger true doze.

BTW I didn't mean to imply idea stealing. It's just that lately I've decided not to bother with things a lot of other people are also doing. It just doesn't feel like it's worth my time to duplicate efforts.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
AOD experiences

What is you guys experience with Always-On Display (Samsung in-ROM) battery wise ?

I've seen people state to have it always-on and it taking 5% overnight. Any anecdotal (or meticulously tracked) experiences?

Test I ran today (this is just AOD, my app or anything else isn't running) came out at about 4% drain/hour (feels high).

I did a full CPU on (without doze, just Android force running) test yesterday which came down to about 5.5% drain/hour (expected for force-on CPU).

(my phone is pretty clean, barely any 3rd party apps)
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
On my testing, I do not see any difference between on and off. I drain between 1 to 3% per hour regardless of it being on and off. So I just keep it on.
[Samsung Galaxy S10 Themes, Apps, and Mods] cam30era:
Likewise, AOD on or off doesn't seem to matter here. 1%-3% battery use per hour.
[Samsung Galaxy S10 Themes, Apps, and Mods] larryk:
Another one with 1-3% overnight...
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
See the vast differences here!

[MENTION=4140769]larryk[/MENTION] what is your setup? Do you have AOD always on? Or only when you tap it? What does it display, a clock that constantly updates (so including seconds) or once every minute? DId you 'scrub' your phone? Pause/freeze all sorts of services, uninstalled bloat, or...?

As I said earlier, my phone is a pretty clean install, straight from initial setup, and a handful only of apps installed. BUT, I suspect for us people who drain 3% per hour rather than 3% per night, there is a reason the phone doesn't go into deep doze mode; it never reaches the deepest sleep state.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Good news everyone! I have it all running smoothly now. The code need some cleanup, dead code removal, fixing up some bad test code into "meh" production code, some installation helpers, etc, but I have the basics all working as I want them.

Going to run it overnight to see what the drain is... release hopefully tomorrow.
[Samsung Galaxy S10 Themes, Apps, and Mods] cam30era:
[MENTION=631273]Chainfire[/MENTION], let me clarify battery drain: 1%-3% per hour during the day when I'm using it.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Might as well give you some info from my side :

Always on AOD, Displays the stock clock without seconds. I froze some stuff, the list is in one of my previous post but I don't think it matters. I turned nearby device scanning off. Otherwise WiFi and data on, location and NFC too. Sync is disabled, and I sync emails manually from the Samsung email app whenever I need. I disabled trace debuggable application in system tracing in the developers settings.

WQHD+ stock launcher. No Bixby.

Sounds fantastic. Do we have option to choose between the fancy animation of something less fancy but more keen on the CPU now ?

---------- Post added at 11:54 PM ---------- Previous post was at 11:53 PM ----------

Same, at night I got AOD off cause it's too bright (don't mind me, I'm really sensible to light at night)
[Samsung Galaxy S10 Themes, Apps, and Mods] johnnyutah22:
In my setup under Advisory at the bottom, it says Lock Automatically. Under that heading it says "It is advised to lock the device immediately (0 seconds) after screen off. Current setting (5 seconds)." I have no idea where this setting is and have searched alll relevant terms to find it. I am not using a lock screen and the AOD is off. Any ideas?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Yes. The latter will be enabled by default on screenOff+battery.

The notification LED is now going to be dependent on AOD being on. But, I was thinking for this exact case to provide the option to just make the screen black and hide its contents.

Don't worry about it. The difference wasn't that big, and this advisory will be irrelevant (and gone) next update.

That being said, in English phones the setting is literally called "Lock Automatically" and you can find it through the Settings's search bar.
[Samsung Galaxy S10 Themes, Apps, and Mods] johnnyutah22:
I did a search for Lock Automatically and it had 0 results. I will ignore like you said. The only reason I was asking is because I can't get the app to work at all. I'm on the US Snapdragon with At&t and I just can't get it to work.
[Samsung Galaxy S10 Themes, Apps, and Mods] 20degrees:
Please do. I just want the notification light. I don't use AOD. Never really been a fan of it.
[Samsung Galaxy S10 Themes, Apps, and Mods] Brad.B:
hello, love the app! Not sure if this has been addressed but when using an app, I double tap to wake and the notification disappears. possible to fix?
[Samsung Galaxy S10 Themes, Apps, and Mods] cruzargel:
Apparently there's an RGB LED in the rear camera area, it lights up when you turn on PowerShare.

Hopefully we can use this as a notif LED as well. Although it's on the back.....
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
5% over 7h night time, so even if you can manage within an extra 1-2%, it won't be a big deal.. thanx for your work, super glad you joined in on the cutout app, somehow only now that you're "in" on it I feel comfortable it'll be done finally.

p.s. I appreciate any dev's work, I know how time demanding and exhausting it can be simply because I have my own many themes, mods, and a rom, but no one can seem to deliver, too many things to sacrifice. any app you install, its either this or that or this again. some need custom AOD in order to work, other something else, no one can deliver factory like experience.. hoping you can.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Tonight's test was pretty good really, 1% per hour. But it didn't look quite right.

This shows I need to revisit the on-battery animation yet again. The granularity of CPU on-time control is not enough for timings to be even every-few-seconds reliable (well it is, but only for code running as system, not for third party apps). So we need to force-keep the CPU awake (hard no, bad for battery) or change it up again.

Not a problem, just time consuming. And all this is very hard to test because I have to leave it on battery for half an hour before true deep sleep kicks in, and you can't debug on battery (because the act of debugging keeps the CPU awake).
[Samsung Galaxy S10 Themes, Apps, and Mods] vojopd:
For me AOD (tape to wake) takes 5, 6% overnight. Last night I turned it off, and lost 1% from 1:30 to 7:30.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Attached is a test for you few readers here, it will not be on Play until I finish some more things. Unfortunately I have a funeral service to attend.

This test includes the transition to AOD+Accessibility. Ignore the advice in the app, and enable AOD (it will work both in always-on and tap-to-wake modes, but obviously differently).

Things that are still missing or wrong:

- New battery+screenOff display isn't ready yet. As a result, depending on your config, you'll either see the swirl (which keeps the CPU awake) or the blinker (which timing is completely off when on battery).

- No option to hide AOD itself yet

- AOD advice is wrong

What I'm looking for is some feedback whether it works at all for you, and if the setup with permissions is clear and works right. This version is not fit to 'keep'.

This version has some debug stuff in it that causes it to use a lot more battery than it should, be sure to update to Play version as soon as I release it!
[Samsung Galaxy S10 Themes, Apps, and Mods] destz0r:
The annoying thing with AOD on the S10, is that the AOD stays on even when the phone is inside my pocket or when the phone is upside down on a table. On my previous samsung phones (S7, Note 9, etc) this was not the case, on those phones the AOD would be off while the phone was inside my pocket.

This brings me to this app Holey Light, is it possible to have the notification LED turn off when it detects that ur phone is inside my pocket? That would save some battery as well.
[Samsung Galaxy S10 Themes, Apps, and Mods] kezzuki:
Hey,

I installed this on my snapdragon S10E. Ring's position looks right, 4 permissions went through fine without hickups and the ring lights up on AOD screen as well (both swirls and blinkers). Awesome.

A little thing, when i set it to blinker and to only light up when screen is off(while AOD always on), the blinking of the ring is only stable and periodic (with 50% on/off duty cycle) for the first 15 seconds or so, but becomes sporadic and less frequent as time goes by. And then eventually the blinking would stop after like ~30+ seconds, either in "on" or "off" state...

If setting to "swirl", there is no such problem...

Not sure what is causing this. I do have the "Greenify" app installed but Holey Light is not greenified. And battery optimization is off for Holey LIght as well.

Also, if you could spare a minute or so, I would like to PM you about an app idea for implementing screen off notification on the S10 series and hopefully learn something from your knowledge and feedback.

Thanks!
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
as always.. 100 thumbs up.. jus tested the apk you dropped and all is great bro ...

Works fine with AOD On

Works fine on Lockscreen

Works fine with screen On

if you want feedback, here it is, -

Blinker effect looks better on AOD as to the regular swirl animation.. swirl animation doesn't look as crisp on AOD as it does on the lockscreen and screen on, if you set swirl animation on aod it looks kinda pixelish..

and another thing, - sometimes notification can run for as long as it wants and sometimes it only runs for few seconds.

outstanding work.. I see people been trying to do this in 5 different apps and it's all kinda unprofessional looking (with utmost respect to everyone who's trying), but you killed it.. I'm sure there is much work to be done but you got "there" real fast.

p.s. curious about the time duration for animation, will there be a timer settings for animation on notification as well as repeat notification time duration?! and another thing, - in order to change the color you need to receive notification from a certain app and its fine but I have received a Notifications from third party apps and first- no swirl appeared and second - the app didn't appear in the Color section of the settings. not all apps get recognized by Holey Light (great name by the way).

thanx again, you're a Beast !!!

update: at one point Notification light caught a bug.. wouldn't stop showing, had to enter and exit Holey Light.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Exactly the same here. I do not use any greenify or anything like that.

Slowly but surely the ring stops blinking and does not do much after a while. Sometimes it will just wake up and blink once from time to time, but very sporadically.

I am guessing the system is putting Holey Light to sleep quite aggressively.

EDIT : However using the swirl animation does not cause this issue and the animation is being shown constantly. And it looks freaking awesome.
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
you get all notifications ?! so far I only tested few, - sms, WhatsApp , Viber, GMail, VK are fine but many don't.
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Well done mate I knew you were the (only) one that could make it and now having it working on AoD too it's even better! :D
[Samsung Galaxy S10 Themes, Apps, and Mods] gabihorvath95:
S10 user here, the app only works for me when it's in the foreground, once I leave the app the ring animation just disappears.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
It seems people did not understand this from my earlier post, but the blinker not working right on battery I was already fully aware of. I'm working on figuring out the battery-cheapest way to do this right, and I will probably move away from blinking :)

I was actually looking at this earlier, and automatic screen off with proximity sensing doesn't work in AOD mode out-of-the-box. However, your assumption that it would actually save battery may not be correct. In AOD mode on the S10, the screen holds its image while the CPU (and GPU!) can be completely asleep. If you use the upcoming option in Holey Light to hide AOD, in reality there'll just be a black screen over it. The screen would still be just as "on". But as these are AMOLED panels, black pixels use way less energy.

So with that, the screen would be using only very little energy. Actually turning the screen proper on and off automatically by using the proximity sensor (or any other sensor really) would require both the CPU to be awake and sensors to be powered. It would not surprise me if this actually used more power than AOD.

As stated above and earlier, I am aware of the blinker behavior. It's the app itself, nothing to do with Greenify.

Re: your PM, I've been considering adding such functionality to Holey Light, but not until several weeks from now at the earliest.

Thanks for the feedback.

I don't understand your question about the animation/timer/repeat. You should explain better what you're looking for. I have been thinking about those things, but dev on this has been slower than expected and I'm running out of available time. Once I get the core on this working right, I will have to take a break from it for some weeks to catch up on other work. (Though of course it is open source and anyone could contribute features eh)

Regarding apps not getting recognized, are you sure these apps are set to light up a LED ? Holey Light takes the LED information from Android, app developers need to specifically request the LED, it doesn't just fire for any notification.

If you're certain they are trying to use the LED, let me know exactly which apps and which types of notification they should have given you.

Actually when it stops blinking the entire device is asleep, not just Holey Light. I can keep it from doing so, but I rather continue trying to figure out a better way to keep both notification and keep the CPU napping. Because that's best battery-wise.
[Samsung Galaxy S10 Themes, Apps, and Mods] RS050377:
Here is another app which works with AOD and screen off

https://r.srvtrck.com/v1/redirect?u...ow&ad_t=advertiser&ad_zi=YieldLink&ad_dt=link
[Samsung Galaxy S10 Themes, Apps, and Mods] 34FB1907:
Same here :(
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
1. what I mean by timer/duration is settings to choose for how long the swirl (or any other animation if you choose to add) will be visible (ex: 5 seconds, 10 seconds etc) and settings to let's say Repeat the light Notification every 2 minutes , 5, 10 etc... not having it continuously blinking and killing off the battery...

2. mostly apps that are not connected to your app I've realized are modded apps .. devs take third party apps (let's say Facebook for example) and modify them.. there is an app called VK (Russian Facebook) and of of it there is a mod called Kate Mobile (which is more customizable of course, that's the point of using modded apps) and it absolutely has all access and gets all possible notifications (edge, popup etc) but Holey Light doesn't see it as a source to work with..

those kind of apps I mean..
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
(a) That has no place in this thread. This is not a thread about all sorts of apps that do similar things - this is a thread about Holey Light

(b) If you're going to link to Play store, link to the Play store, not some weird ass redirect that could be anything
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Find me one that isn't suspicious, in English, and that can somehow trigger a notification, so I can test what is going on.