yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Themes, Apps, and Mods] RobLives4Love:
I literally just have the bare minimum of settings on and power saving animation and it works great. All I wish now is that it can not be on when the screen is on and it'll be like having a LED light lol
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
I'm sure it will come to that.

This guy have not nearly this refinement that HL has, but he has actually got a switch in settings that makes AOD completely black so only the ring shows up.

Anything you can use, Chainfire?

https://xdaforums.com/galaxy-s10/themes/galaxy-s10-led-notification-replacement-t3919278
[Samsung Galaxy S10 Themes, Apps, and Mods] arthur_dm:
Is it possible in next release to select only if screen is off?
[Samsung Galaxy S10 Themes, Apps, and Mods] vboyz103:
Thanks OP for addressing my question about permission requested to access what type on keyboard. I think it's best if you can reduce that to what is actually needed. I bought the donated version but will uninstall for now until future updates :).
[Samsung Galaxy S10 Themes, Apps, and Mods] iggdawg:
I'm getting a consistent snag on my S10+. Basically, if I dismiss notifications while it's plugged in, the ring keeps swirling. If I'm on battery, they go away. Similar behavior if I have "auto-dismiss upon unlock" enabled. Anyone else getting this? It didn't happen in 0.26.

EDIT: It's happening on battery too. I was probably just noticing more when it was plugged in because that's where I noticed it first and was looking for it.
[Samsung Galaxy S10 Themes, Apps, and Mods] .dan:
is it possible to have a completely black screen (whether it is off, or a pure black AOD) with camera ring notifications? as far as i can tell, if my AOD is on 'tap to show', the app doesn't work until i tap the screen.. at which point i no longer need this app since i will see my notifications..

the best i can do is use the always on AOD with the edge clock face.. but that is still too much going on for my taste.

---------- Post added at 04:17 PM ---------- Previous post was at 03:52 PM ----------

what are your AOD settings? what AOD do you use?
[Samsung Galaxy S10 Themes, Apps, and Mods] johnnyutah22:
My settings mirror yours but I do not get the notification if the screen is off. What are your power saving animation settings and what are your AOD settings?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
It'll take me more time to figure out what he's doing than to just do it myself. Time is always my limiting factor.

That's curious, as there is no donated version.
[Samsung Galaxy S10 Themes, Apps, and Mods] z576012568:
Wow, works so well. Love this excellent function! Thanks for development.
[Samsung Galaxy S10 Themes, Apps, and Mods] DamirZg1:
For now I'm happy with app 0.40 ... because it shows notifications much better now on my s10 + (my AOD is on). #Chainfire ... a good job. Thank you !
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
It does not show battery charging because there is no such function, and I don't understand why you think there is.
[Samsung Galaxy S10 Themes, Apps, and Mods] DamirZg1:
Ok ... obviously I figured it wrong, my mistake
[Samsung Galaxy S10 Themes, Apps, and Mods] mixxxk:
I had this problem after updating to .40 , for me, it assigned a color to the Google app. And that was the color that kept spinning. I turned it to black and it stopped. It happened on my s10+, but my s10e did not have the issue. Hope that helps.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Everything is fine here, beside the known bug about the notification dismissal, and the ring blinking despite having no notifications any more.
[Samsung Galaxy S10 Themes, Apps, and Mods] Sacher_Masoch:
It did the job! Thanks for the tip.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Well, I finally got the phantom notification myself, so let's see if I can find what's causing it!
[Samsung Galaxy S10 Themes, Apps, and Mods] RobLives4Love:
I use the stock Android.

---------- Post added at 12:49 AM ---------- Previous post was at 12:48 AM ----------

Oh, i don't either. But i have my AOD set to stay on
[Samsung Galaxy S10 Themes, Apps, and Mods] poczynek:
Tell me if this is a stupid idea, but is there a way for the AOD to come on, but the AOD colours are made transparent so no battery suckage? I saw a reddit thread where someone had edited the apk of the Good Lock Clock and had changed the pngs to transparent. Could that work? So AOD is technically on but transparent colours are used and all you see are notifications?
[Samsung Galaxy S10 Themes, Apps, and Mods] iggdawg:
Woohoo! I'm not crazy!

I noticed just a little bit ago that it doesn't just keep looping after dismissing notifications. It seems to keep looping in general once it starts. I had a bunch of Twitter notifications queued up. Then a Gmail notification came in, which I have set to red, and it never showed up in the swirl. Sure enough, after dismissing everything, it kept looping Twitter blue.
[Samsung Galaxy S10 Themes, Apps, and Mods] johnnyutah22:
That's why I asked if anyone who has it working to post settings. Are you saying that you don't get the notification when you have screen off and get a text message?
[Samsung Galaxy S10 Themes, Apps, and Mods] anjum877:
Not working while screen is off

Thanks for the great app. I'm having issue while screen is off. Nothing is showing for battery charging or any other notification. I've tried different settings but didn't work. Please suggest what I've to change in settings.
[Samsung Galaxy S10 Themes, Apps, and Mods] izephyr:
Did you disable battery optimization for the Holey Light?
[Samsung Galaxy S10 Themes, Apps, and Mods] anjum877:
Yes, it's already disabled
[Samsung Galaxy S10 Themes, Apps, and Mods] izephyr:
I think you may start over.

1. Clear Holey Light's cache and data.

2. Reconfigure

3. Disable Battery optimization for Holey Light

4. Enable Always on Display.

5. Optionally, check if Notification is enabled on lockscreen

I hope this helps

---------- Post added at 11:33 AM ---------- Previous post was at 10:50 AM ----------

@Chainfire. If we can make an AOD theme with everything transparent or black except the notification icons, that can make the notofication screen all black.
[Samsung Galaxy S10 Themes, Apps, and Mods] Brave.Maxton:
Thanks for your hard work and app. This is much better than AOE.
[Samsung Galaxy S10 Themes, Apps, and Mods] the_scotsman:
Couple of random battery life screenshots. I haven't found it to be that bad on battery at all.

Yesterday:

Today:

Ignore the battery charge on todays image. I had just driven home from work, so the phone had charged in the car dock before I took the screenshots. But the other stats are still relevant.
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
[MENTION=631273]Chainfire[/MENTION] here is the Italian translation (based on GitHub v40 of yesterday afternoon).
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
That is good, of course, but this is not the whole picture, as it shows only the CPU use of the Holey Light process itself.

It does not count the additional CPU cycles used by system_server (most of Android's internal code runs here, including window and notification management) or surfaceflinger (the renderer, which flings our pixels at the screen). While the cycles spent there for most apps in normal phone operation are relatively insignificant, when we're talking about Holey Light being pretty much the only thing running, low power modes, etc, their CPU usage is probably twice that of Holey Light itself (hence my statements about there being little left to optimize in Holey Light's own CPU usage), and becomes strongly relevant.

Nor does it count the additional power used by the screen because it cannot go into it's very lowest power mode as our display would disappear.

Additionally, it does not count the power required to have the CPU be awake. Even if all processes together wouldn't consume any CPU cycles, just the CPU being powered draws additional energy. Unfortunately for us, Samsung's stock CPU configuration keeps the CPU running at a rather high frequency even when it's near idle. While Pixels may reduce their active cores to one and its frequency into the low hundreds mhz, it seems the S10 keeps powering four cores at around one ghz. This is a monumental waste of power. (Note: CPU power use is fairly linear with frequency, and squared for voltage. "Fairly" and not exactly, because efficiency always goes down with higher energy use, but it's a good rule of thumb)

Of course, all these things are only relevant when a notification is actually being showed; if there isn't, the screen goes into ultra-low power mode, and the CPU goes asleep.

This is why I generally tend to ignore statements about CPU usage by non-devs, for any apps. It rarely tells a complete picture of what is going on, and even if it did, CPU usage % changes drastically between CPU frequencies. In an aggressively downclocking / powersaving device, the CPU may be downclocked significantly, that could cause running apps to use 40% CPU. Those same apps may run at 5% CPU if the CPU was running full-speed. But, and here comes the kicker: it is likely less power is used on a low clock with high %. Without information about all those factors, the only thing CPU % measurements are good for is noting if a process is actually using abnormally high CPU for sustained periods. Aside from that, they are pretty much useless used from Android's statistics found in the UI.

At the risk of sounding an arrogant know-it-all, when I test and state my numbers, I do take all those factors into account. The only real way to measure in this case is many hours running with notifications, and noting battery levels at intervals, subtracting the usage of the same tests without Holey Light running.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Can you update this to the latest strings.xml contents ?

Sorry this wasn't done in the current version, but for future updates I will clearly mark in the xml what has been changed.
[Samsung Galaxy S10 Themes, Apps, and Mods] the_scotsman:
Ahhh, thanks, that makes sense. Thanks for taking the time to explain it :good:

I've always been dubious of these battery stats, and don't normally rely on them or use them in any way to be honest. This explains why :D
[Samsung Galaxy S10 Themes, Apps, and Mods] RequeLine:
corrected for version HoleyLight-v0.40-legacy
[Samsung Galaxy S10 Themes, Apps, and Mods] Wacky2bakky:
What's the latest version available of Holey Light?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Please let me know if the attached version shows the translations correctly
[Samsung Galaxy S10 Themes, Apps, and Mods] sungdd2:
Not work on my galaxy s10 5g

Error code is beyondx

Please help me..
[Samsung Galaxy S10 Themes, Apps, and Mods] RequeLine:
One mistake, I updated the file

https://xdaforums.com/showpost.php?p=79313269&postcount=428
[Samsung Galaxy S10 Themes, Apps, and Mods] Eziooo:
Thank you Chainfire, it works perfectly, just need to read the instructions!

I have found only one bug: there is the possibility of centering the light horizontally but there is like 1 pixel difference between left and right and you can always see a space between cameras and light. It will never be perfectly centered.

And I suggest some features:

-Possibility to see the light only with screen off (will save power also)

-Possibility to insert the color manually in the the "Colors" section to have the same color for many apps.

Thanks for the job, if you release a donation variant, I will pay for it!

Bye!
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Yep it looks OK.

I got the Italian language as soon as I updated the APK and launched the app. [emoji1360]
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Do you know if this is based on the s10, s10e, or s10+ ?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
@ everyone and specifically [MENTION=9839677]S10Guest[/MENTION]

I think I fixed the phantom notification thing. Please test ASAP :)

PS: [MENTION=5143755]RequeLine[/MENTION] , this includes your latest translation update
[Samsung Galaxy S10 Themes, Apps, and Mods] sungdd2:
Maybe galaxy s10+..?

Except bigger Screen size (6.7inch) and 5g chip modem, everything is same as galaxy s10+
[Samsung Galaxy S10 Themes, Apps, and Mods] RequeLine:
No, I fixed and updated

it used to be:

<string name="settings_animation_powersave_title">Анимация (Минание),для энергосбережения</string>

but it will be correct like this:

<string name="settings_animation_powersave_title">Анимация (Мигание),для энергосбережения</string>
[Samsung Galaxy S10 Themes, Apps, and Mods] maderos:
Everything is fine except one ( bug ) problem? Sometime, ring stays on after notification. Any clue how to manage that?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
All three of you, try the version here: https://xdaforums.com/showpost.php?p=79313731&postcount=436

Please try the version in the linked post above. I fear the size/position of the animation is not correct though, use the "Tune" window to adjust (and let me know the values that work right for you)

I think the upload wasn't right earlier, those changes you mention are actually in my files. Please see the linked post.

Possibly fixed by linked version. Let me know.
[Samsung Galaxy S10 Themes, Apps, and Mods] RequeLine:
great now
[Samsung Galaxy S10 Themes, Apps, and Mods] b3y0ndd34th:
It needs the AOD to be on. Due to limitations, NO ONE has a working app with the screen off. Even that Always on Edge app sets an AOD.
[Samsung Galaxy S10 Themes, Apps, and Mods] Sylar82:
wow its work perfect in my s10 plus thank you man
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
For some reason with this update the translation at top went back to English.
[Samsung Galaxy S10 Themes, Apps, and Mods] RS050377:
Is the app safe of display burnin?

Does it use a lot of battery?
[Samsung Galaxy S10 Themes, Apps, and Mods] sungdd2:
Oh works well

Thank you for comment.

And I have another question.

I don't wanna see notification when screen is on so I turned the screen on menu to off. But everything is off when I tried it.
[Samsung Galaxy S10 Themes, Apps, and Mods] the_scotsman:
This is a limitation of the app for the time being. You need to have it enabled for the screen on for it to work.
[Samsung Galaxy S10 Themes, Apps, and Mods] the_scotsman:
There should be no risk of burn in, since the light is always moving or changing colour. And only on for notifications, not constant.

Battery usage is roughly 3.5% per hour, based on Chanfire's testing. (When there are notifications showing). Battery usage is less when no notifications are showing.

For me I've found it doesn't use too much, and I'm happy to keep it runing all the time with all settings turned on. I also have the more "fancy" animation turned on which uses more power.
[Samsung Galaxy S10 Themes, Apps, and Mods] kleinmischa:
any way to have AOD without clock and battery %

Just a black AOD...
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
[MENTION=631273]Chainfire[/MENTION] while you are checking please replace the Italian XML with the new attached one (found a typo).
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
safe, no drain.
[Samsung Galaxy S10 Themes, Apps, and Mods] BulldozZzerr:
[MENTION=631273]Chainfire[/MENTION], great job! Thanks a lot. I use almost black AOD skin

http://apps.samsung.com/theme/ProductDetail.as?appId=minuhome.Starlight.aodonly

So I wanna get filled small round by left of camera like LED. Could you add thickness option in Tune settings and overall scale should be regardless of thickness.

Appreciated.
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
Well it's gonna be awesome when you find the way to have aod disabled or completely black. Since apps like Tasker, or in this case, Automate, can tap into monitoring notifications (sleeping until something appears) and with that put "aod_mode" to 1 or 0 on the fly, which is what I have built since the S10 came out, I'm sure you will find the sweet spot as well.

For anyone interested until it's sorted out, pm me and I'll send you the flow to import into Automate.

It simply monitors notifications, when one arrives it turns aod on, and when it sees that no notifications are there, it turns aod off. Ie, at a glance I see if there is nothing on the screen (all black) I know I don't have any missed notifications.

And it works very well already now with Holey light as it gives some extra umph to the aod when it's automatically turned on due to notifications.

So for me at least, a good middle ground until I can dump that flow and Holey does all of the work for me.

//P
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
This will have to wait until next release and I've put the new strings on GitHub, then base your modifications on both values\strings.xml and values-it\strings.xml (the original and the translation). I had to modify your file quite a bit due to encoding and xml errors, I'd hate having to do that again.

(New strings will be added too for next release)
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Look I opened the raw page of the XML, copied&pasted into UltraEdit and saved into UNIX format to be double sure that it wouldn't then mess up everything.

If you can think about anything else that is gone wrong... ?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Probably the encoding settings, try forcing UTF-8 next round ? Not sure if that option exists in that editor. Might have been the copy/paste instead of copying the file and editing. I don't know.

No worries though, it's not a criticism, your work is definitely appreciated.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Bug squashed.

Works now with text message in focus and if dismissing notifications from notification bar bottom up .

Good job!
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
OK no problem mate I too wasn't complaining, but just asking. :laugh:

I will follow your suggestions next time (and yes it supports also UTF-8).
[Samsung Galaxy S10 Themes, Apps, and Mods] ventolino:
Hi, I have a question.

I Read "Screen off + battery functionality enabled", it means that the program works with screen off, without AOD? I'm going crazy because I can't find the way
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Bloody effin' Android... If I compile the app for API 28, I can't change AOD settings, and if I compile the app for API 22 (max that modifying these settings works) we can't get access to the current notificaiton LED colors. Hair pulling frustration.

I did sort-of find where it is decided which parts of the screen are saved in ultra-low-power though, not sure if I can influence it.
[Samsung Galaxy S10 Themes, Apps, and Mods] dmdelgado:
Thanks for this! It really is almost all black when you apply this AOD theme without the Clock :svetius:
[Samsung Galaxy S10 Themes, Apps, and Mods] steelersmb:
Is there ever going to be an option to ignore certain apps instead of making it black?
[Samsung Galaxy S10 Themes, Apps, and Mods] m8980:
hi. any plans to add a function to change notification color for apps, which not provide a option to change the color?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I await your pull request with anticipation
[Samsung Galaxy S10 Themes, Apps, and Mods] steelersmb:
Sorry, I don't understand what you mean, anyhow, thanks.
[Samsung Galaxy S10 Themes, Apps, and Mods] cruzargel:
lol. it's a git thing. :D
[Samsung Galaxy S10 Themes, Apps, and Mods] dannywi11iams:
Hi downloaded this app, like it a lot. I have it running on the S10+

Can I ask, what setting do I need to set in order for the light effect to work when the phone is in standby mode.

If not, is this a feature coming, as the LED did this on the older Damsung phones, to notify what notification had come through before activating the phone.

Be great to here that it does work when the phone is in standby mode.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
lol.

I think maybe he wants you to pull on his CHAINfire and he may do it for you.

I think the problem is some people just don't understand how the app flows without experimenting with it first - or a language thing.

Maybe change the name of "Colors" section to "Notifications" and once under Notifications, auto default to only list the ones that are Active, with 3 dots in the top right with options to show to "Show Active (default)", "Show Blocked", "Show All" or something like that. With a message on top of the list "Notification applications will populate this list as they are received - check back after a new notification arrives to block or make color changes to individual applications."

And when clicking on an app to make changes, have a toggle button to 'Allow' or 'Block' rather than sliding the slider to black.

And when displaying Blocked applications in the list, don't have a square with color black by the app that's blocked, just put a big red X in the square.

Unless someone can think of something better ... ?

The app is gonna get bigger..and bigger.. and bigger, LOL.
[Samsung Galaxy S10 Themes, Apps, and Mods] broncogr:
Great job on the app CF.

Invaluable !!
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
All of these are good suggestions, but I absolutely hate UI work, this will take some time to do, and I feel functionality comes first. Both for myself and other power users.

Noobs complaining about an app that's completely free and in beta/unreleased state, because they can't be bothered to read, I just can't bring myself to care.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
v0.50 attached, also on Play (whenever it updates), and also on GitHub.

Changes:

- Support for legacy notifications

- Fix 'phantom' notification

- Reduce Accessibility permissions to minimum

- Independent control of screen on/off modes

- Tuning now has 0.25dp granularity (all previous tuning is lost!), gained reset button

- Colors are now configured by channel rather than by package (all previous color config is lost!), gained refresh button

- Adjusted 'reverse portrait' rendering

- Added Italian and Russian languages

- Support resolution change

- Various efficiency, crash and deadlock fixes
[Samsung Galaxy S10 Themes, Apps, and Mods] pug1:
Seriously dude you dedication is unbelievable. Your app is bloody amazing and gets better with every update. Quality!!!
[Samsung Galaxy S10 Themes, Apps, and Mods] Gilg@mesh:
PM'd
[Samsung Galaxy S10 Themes, Apps, and Mods] Eziooo:
Amazing work. Thank you.
[Samsung Galaxy S10 Themes, Apps, and Mods] andee39:
Thanks [MENTION=631273]Chainfire[/MENTION] for this app. Very cool. I think the biggest thing you are missing is the contribute feature. Folks here want to buy you a beer to thank you for all your hard work!! [emoji482][emoji482]
[Samsung Galaxy S10 Themes, Apps, and Mods] Covafett:
The new update fixed my phantom notification! Thanks Chainfire! Completely happy! If you go paid version, I'm in!
[Samsung Galaxy S10 Themes, Apps, and Mods] cruzargel:
Tasker workaround, only show AOD when there's a notif:

https://www.reddit.com/r/galaxys10/...p_you_can_use_tasker_to_only_show_the_always/
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Amazing work, works better and better.

Do you think you would be able to implement a feature just like those Tasker scripts and similar implementation in order to just show AOD (and therefore HH) when there's a notification ?
[Samsung Galaxy S10 Themes, Apps, and Mods] freebee269:
Does VPN affect this app? I have adguard installed so in the notification area there are 2 things from adguard. One is Android system and the other is adguard info. I'm asking because I can't get the notification light to stop. Wondering if adguard could be keeping it going.

Edit: yep it is adguard. I had to change its color to Black to get it to stop. So Black is the same as no color for that app. Gotcha. This is a great app. Thank you for your time invested in this.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I don't think we'll ever get there, no.