yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] dr4go:
Last offtopic from myself... Sorry for that.

I've finally fixed the upgrade issues for good: I simply modify system.img.lz4 with both modified libsecure_storage.so files and then flash the tar via Odin. Works wonderfully. If anybody tries that, be aware of the pitfall, that you also need to modify vendor.img.lz4, because both libsecure files are also present in there. (Additionally I also debloat system a bit, Facebook or YouTube for example, and also already modify the secure storage daemon's file to be stopped on startup - thanks for those findings [MENTION=7187684]ianmacd[/MENTION]).

Is there any interest on sharing a howto for that in a new thread?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
The libsecure_storage.so libraries in /vendor should not be replaced. I can't remember the details now, but it's at least unnecessary on the S10 series, possibly disruptive. On other Samsung Pie devices, replacing those libraries definitely causes problems.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
Version 1.2 released.

Version 1.2, released today, adds support for the G977B (S10 5G).
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] shivalwolf:
Similar question.

Is there a way to keep encryption but fix the other issues that the disabler is used for.

Can you go back to full-disk encryption or if i dont mind not having access to /data in twrp can i just comment out the disable the file encryption line.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] shivalwolf:
I was able to answer my own question here. At least i think i was.

When the script is run and File encryption is disabled.

In the settings menu for encryption the option for full disk encryption returns.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] shivalwolf:
So while the option exists encryption seems to just crash out the OS and reboot the device (Australian s10e at least) when you try and turn it on. I am looking at the logs and hopefully i can find the cause and il post anything here if anyone else is still looking to use encryption.

Edit:

I grabbed the logs while it was encrypting.

It starts the process and then kills off a bunch of other processes on the device.

06-19 09:49:57.168 15369 17360 I StorageManagerService: encrypting storage...

06-19 09:49:57.170 5024 5031 D vold : !e4crypt_is_native, spawning fdeEnableInternal

06-19 09:49:57.171 5024 24607 E Cryptfs : Unexpected value for crypto key location

06-19 09:49:57.171 5024 24607 E Cryptfs : Cannot open block device

(bunch of process listing and killing )

06-19 09:50:48.615 5024 24607 E Cryptfs : Unexpected value for crypto key location

06-19 09:50:48.615 5024 24607 E Cryptfs : Cannot open block device

(reboot)

I am guessing it's just not compatible to do full disk encryption even though the option is there.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] shivalwolf:
So i was looking though the script and saw that it replaces "fileencryption=aes-256-xts" with "encryptable"

From what i was able to dig up encryptable requires a parameter to tell it where the encryption data goes.

On some devices this is a block device where the encryption key data can be stored.

On other options apparently encryptable=footer will get it to write the encryption data to the end of the current block device which in this case is the userdata block device.

I tested this with a slight modification but then when attempting to encrypt logcat showed that it could not encrypt due to "Orig filesystem overlaps crypto footer region. Cannot encrypt in place."

Another thread suggested shrinking the userdata block device to make sure there was 16KB free at the end of the device.

I did this as well and encryption started with the progress bar. but then it failed out and corrupted all of /data needing a reset.

I would really appreciate if anyone can advise how or even if its possible to get encryption while still using magisk+twrp+multidisabler.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] dynospectrum:
FBE is disabled by multidisabler, so probably not.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
I can understand wanting to keep encryption, but why do you prefer FDE over FBE? New devices come with FBE for very good reasons. You're sacrificing flexibility and functionality for no obvious reason, and performing a procedure that is actually more invasive than simply removing encryption. I'm very interested in your reasons for preferring this method.

That's 110 Gb for a single back-up on an S10e. On a busy 1 Tb S10+, that's going to be a lot more, more than will fit on a 512 Gb SD card, making even a single back-up impossible. Clearly, this method is going to be impractical for a lot of people.

Incidentally, anyone who wants to install TWRP, but retain the factory-installed FBE of a new device can actually run the multidisabler in an untested, undocumented interactive mode (by renaming the zip file to include the string _interactive somewhere in the name, and simply skip the step that flags the file-system as unencrypted.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] shivalwolf:
I tried this as i saw it in the code. What i ran into is if i didn't do the disable FBE then the device would never boot. it would just get stuck in a reboot loop trying to go into either recovery or system boot. If i then went in and applied the disable of FBE it would boot fine. I'm not sure what caused it not to boot if i left FBE turned on as i could not get logs during this stage. This only seemed to be a problem when using twrp and not just the modified normal recovery.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] MobAndro:
Hello,

I just want to know :

The correct way to proceed is : FOR THE FIRST TIME

- Wipe data and flash the multi-disabler.zip then wipe data again ?

OR

- Flash the multi-disabler.zip then wipe data only ?

AND

The correct way to proceed is : AFTER FIRMWARE UPDATES AND/OR TWRP UPDATES

- Wipe data and flash the multi-disabler.zip then wipe data again ?

OR

- Flash the multi-disabler.zip then wipe data only ?

Because I don't want to make mistakes Please and thank you very much in advance for any answer.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] FlatOutRU:
Will this work on a G9750?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] yokala:
I guess I ****edup my device. Here's my story :

I had a S10e rooted with TWRP and It was working fine.

I flashed multi disabler in TWRP from SD card because of course, data was inaccessible. After flashing, I got a bootloop (because I didn't wiped data after flashing ?). So I wiped data from TWRP and I was able to boot the phone with or without magisk. I thought I fixed all the issues but I noticed the phone complained about not enough free space on internal storage while it was empty and showing 12gb out of 128. I could not do anything in the storage : impossible to create a folder, paste a file, nothing. I guess the partition was corrupt.

So I tried to fix that by reflashing the whole firmware with Odin. Big mistake ! The process get struck on installing the userdata.img.

So now, when I turn on the phone, I have the error ''something went wrong during a software update, use the emergency Samsung software blablabla....''

I tried differents cables / usb ports with odin, it get stuck everytime on the userdata.img.

Any advices ?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] trancinguy:
Reboot to actual recovery, then in twrp reboot to Download Mode, then Odin to Stock. Samfirm is slow but guaranteed.

Or, Format in actual recovery, then look for an Aroma install Rom/theme for your device, usually around 3 gigs, usb it or otg, then install it in twrp, when it's done, reboot back to actual recovery twrp, then in twrp reboot to recovery and be patient, sometimes it takes little longer than usual.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] yokala:
Well, I don't have access to recovery anymore, only download mode.

And Odin is always stuck when flashing userdata.img.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] shivalwolf:
I error happened afew times to me.

1. You will need to download your full firmware for your carrier from a place like https://www.sammobile.com

2. Extract the zip you download and it will contain 5 files (there are 2 versions of the CSC file you only need the HOME version).

3. in odin set each file in their matching section. (when it comes to the CSC section use the HOME_CSC file from the archive)

4. flash with odin. Restoring everything like this should restore your device back to a normal state.

As for the shrunk data partition. This is in some of the documentation.

It happens randomly if you flash just the modified AP file and dont flash the other 3 files along with it.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] yokala:
Thanks, this time it worked !

I was using the CSC file instead of the HOME_CSC.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] MobAndro:
Someone can help me PLEASE ? :crying:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] vegetaleb:
If we want to upgrade fw, we flash the new patched twrp from twrp, then multidisabler?

Should we format data again after multidisabler?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] MobAndro:
Thank you very much vegetaleb for answering me. But do you think it's very safe to not do a format data before to flash the multi-disabler.zip ?

Very sorry, but I don't want to make mistakes :eek:
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] vegetaleb:
Put multidisabler on your external SD card as it won't be wiped or encrypted, after flashing magiskified twrp, boot to twrp using the 3 buttons method (long) select your sd card as memory instead of internal, flash multidisabler, format data.

If you want to flash a custom rom, put it too on the sd card and flash it right after the format. Never reboot from recovery, turn off the s10 instead and use the 3 buttons boot
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] MobAndro:
Thank you very much vegetaleb for helping me. Everything is clear and easy to understand and it's great ;):good:

And very sorry, because finally I understood that you, in fact, were actually asking your question :o
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fastzombies:
After flashing Multi-disabler, lost OEM unlocking option, cannot flash patched firmwa

So I was on the brink of success, had TWRP up, flashed mutlidiabler, and something went wrong and I lost OEM unlocking from developer options. Now I can only flash stock images. Any advice? Thanks.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
At some point, you flashed an AP firmware file without also flashing something in the CSC slot. That's how this shrinking of /data occurs. You may have been able to recover something and could have at least resized /data back to its original size if you had followed the instructions in the OP of the TWRP thread for these devices.

You may need to flash stock firmware at this point, or a Magisk-patched AP + CSC combo at least.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] an-_-dro:
so far my device still not available for custom kernel for pie. i just want to ask about proca. when my device got rooted, samsung account can not login and lockscreen always fail to authenticated. is that proca? what exactly this "proca" does?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] fastzombies:
Thank you, but I was very careful to fill in each slot with the correct file as I read this warning before I started.

I re-enabled bootlock and essentially started over with stock firmware and after another factory reset I somehow got the OEM unlock back. When I have time I will try the routine again. Thanks for your help.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] vegetaleb:
After a week with rooted ase7 carHD s10+, I tried to update magisk but ended up reflashing the stock ase7 because I only had magisk patched ase7 with old twrp. So now I have a stock rom ase7 with unlocked bootloader but no magisk, I will follow the usual root process this time using latest fw files, though in the end after flashing multidisabler should I format data again or it's not needed if done in previous root?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
So long as installing the stock firmware hasn't reencrypted the device, there's no need to format data when you reroot. However, if you truly flashed stock, then it's hard to see how the device could still be unencrypted.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] doggydog2:
it's nice to be on rooted stock and TWRP is a must.

(1) I got into a situation where installations don't work (from file / vending / aurora). "Installing" never finishes. I saw lot of "proca" log messages, so I installed multidisabler_interactive, but it didn't help. They're gone but still seeing "audit" errors but nothing telling. Have no clue why it is still not working, but I was experimenting with disabling Device Security, which is a bogus antivirus, however it's linked to all installations. Something is still broken. Maybe some knows? #Pending

(2) Additionally i softbricked device when downgrading from problematic edxposed .4 to .3, and kept both versions by accident (or in other words, the versions don't overwrite each other). Might have been also QuickStep magisk plugin related. So I was reflashing TWRP, cleaning up, reflashing magisk via Odin etc and nothing helped to boot root version. So i moved /data/adb directory and it worked. This is a nice way to fix Magisk situations even when phone is encrypted. You can then either reapply all plugins or delete the problematic one and rename adb folder back. Without TWRP i'd have to format data! #Fixed
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] doggydog2:
would appreciate any thoughts on this, still can't install via anything (incl. titaniumbackup), notifications very late, and messaging crashing on each SMS, and each SMS is received twice. I know, good to format data, but it can reoccur then.

-> formatted and went through 2 day setting up process. hope it won't come back
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Vuska:
Is multidisabler will work on G9750 too ?

i think i wanna try twrp for g9750 magisk version.. but i think i need multidisabler
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ExtremeGrief:
Try maybe it could work.

If it doesnt work flash No verity opt encrypt and rmm bypass v3.Get them on the internet

They are doing almost the same thing.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
Version 1.3 released.

Change log

This version adds support for F and N models of the Note 10 and Note 10+, which are released next week.

It also adds support for the upcoming 3.3.1-6_ianmacd release of TWRP for the S10 range, which will contain a change that makes it incompatible with previous versions.

v1.3 (2019-08-18)

Updated to work with TWRP 3.3.1-6_ianmacd and later for the S10 range.

Added support for Note 10 and Note 10+ F and N model devices.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] thevmax:
Samsung Galaxy S10e won't stay OFF when charging

S10e on ASH1 with TWRP 3.3.1-6, further modified to use SOLDIER9312.

My phone will not stay in an OFF STATE when I try to charge the battery.

The phone turns on and boots successfully whether I try USB or Fast Wireless Charging? And if I turn off the phone it comes right back on.

Both options tried with Samsung USB Cable/Samsung Fast Charger ...

Additionally, when selecting MAGISK 19.4 download options, the phone reboot while selecting options and then becomes unresponsive. So I go into TWRP and do a standard WIPE and send the phone into recovery, which ends up rebooting to home...

but, of course, I have to then go through the initial screens all over again and acquire my apps...I believe the app selected in MAGISK is ACTIVE CHARGING CONTROLLER (last updated 07/21/2019)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Magendanz:
[MENTION=7187684]ianmacd[/MENTION], I think there's a bug in this line of the script:

sed -i -e 's/^[^#].*vaultkeeper.*$/# &/' \

-e '/\/system\/bin\/vaultkeeperd/,/^#\?$/s/^[^#]*$/#&/' $ANDROID_ROOT/init.rc

It's causing *every* line after the "service vaultkeeper /system/bin/vaultkeeperd" line in init.rc to be commented out...including all the service declarations that follow.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
That's interesting.

The code above operates on every line from the first instance of the string /system/bin/vaultkeeperd up to and including the line that is either blank or starts and ends with a single #. This ensures that the multi-disabler stops in the same place each time, even if it is run multiple times. While within the operable portion of the file, all lines that do not already start with a # are commented out.

If this goes wrong for you, it means that your copy of the file somehow fails to match the closing pattern. Have you hand-edited the file before at any point in time? Even adding a space to the line containing the single # would be enough to make the code keep replacing lines until the end of the file was reached.

A less likely possibility is that you have replaced your copy of sed with one that doesn't support all of the syntax that I used, and that the code fails for this reason.

Can you send me a copy of the original file? Then I can get to the bottom of this.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Magendanz:
This was run on an unmodified OEM init.rc file (attached), but it was from the Galaxy Tab A 10.1 (2019) [XAR-T510XXU1ASEF-20190605151710]. I've adapted your script to run on the SM-T510/T515, but it looks like there's an assumption in this regex script that isn't true on this particular device. Everything else has been working nicely, though.

I'm not really much of a regex guru, so I'd appreciate any tweaks you could offer that will get the desired result.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
If I copy your file to my laptop and run the (GNU) sed command on it here, it behaves as expected. If I inspect the pristine input file, there's also no difference from the relevant section of the S10's file, either.

So, either the sed on that device is different from the one that runs on the S10, or something else is being run on the device prior to the multi-disabler, and whatever that is leaves the file in a state that no longer matches the closing regular expression.

Can you figure out which version of sed is being used? Try typing in TWRP's terminal:

$ ls -l `which sed`
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Magendanz:
Yeah, that threw me too, because the relevant sections of the file on the Tab A are identical. You can even see from the first file that I attached that there was a blank line after the vaultkeeper service declaration.

I don't know how that ls command would return the version, but calling "sed --version" returns "This is not GNU sed version 9.0"...which also seems odd. As far as I know this is just coming from the latest minimal OMNI sources we both use to build TWRP.

I've also attached my modified version of your Multidisabler script.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
Long options (those with -- are a GNUism), so this binary is just recognising that you thought you were calling GNU sed and reporting that you are not.

I wanted the ls output, because it would show me the path to the sed that you're using. I want to know if you're using a stand-alone binary, a Toybox applet, a BusyBox applet, etc. There has to be something different in your runtime environment. I think the output that you got is from Toybox.

Assuming your sed is a Toybox applet, what's the output of toybox --version?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Magendanz:
Yes, I have TW_USE_TOYBOX set, and so that's probably true. Calling toybox --version returns "toybox 0.7.6TOYBOX_VENDOR".
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] warp2:
[MENTION=7187684]ianmacd[/MENTION]

Would it be possible to include the libsecure_storage-patch in the disabler?

Because if S10e should be started without Magisk (or without root), the libsecure_storage-modul does not help, and all parings are gone! And a restore with Titanium Backup will not work.

I'm a bit baffled, what I can do, so that the Bluetooh-Parings will be preserved even if the S10e starts without magisk / without root.

I would be very happy about a positive feedback.

Thank you very much!
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] dr4go:
Same opinion here, but I'm using a different approach since I'm not using twrp and the multi-disabler... For details: Check post #80 (and #81) in this thread. At least that's how I'm managing it.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
Version 1.4 released.

Change log

v1.4 (2019-08-28)

Changed regex that caused too much of $ANDROID_ROOT/init.rc to be commented out by some versions of sed(1).
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
I've changed the problematic regex and verified that this works on the S10+ and Note 10+.

Would you please try the new v1.4 and report back? Thanks.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
Version 1.41 released.

This one is a minor update, unless you happen to own the device it adds support for.

Change log

v1.41 (2019-08-28)

Added support for N976B (Note 10+ 5G).
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] Magendanz:
Yes, that seems to have done the trick for the SM-T510/T515 too. (Result attached.) Thanks, [MENTION=7187684]ianmacd[/MENTION]!!

BTW, do you mind if I post the version that I've modified for the 2019 Galaxy Tab A 10.1? (I'll be sure to give you full credit.)
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
Glad to hear it's fixed.

No, I don't mind. The more code we reuse, the more people are helped. You'll also notice that I don't bother putting a software licence on any of my little Android hacks.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] FlatOutRU:
[MENTION=7187684]ianmacd[/MENTION] What information do you need to include Snapdragon variants aswell?
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] tiho5:
A bit OT as it is also for the Note 10

Will this work if flashed with the recovery, which geiti94 (and now also dr ketan) made for the N975F in the note 10 forums?

He also shared a version of multidisabler. And I am wondering which one to use
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
I couldn't tell you. I haven't used those versions of TWRP, but I would expect the multi-disabler to work with them unless radical changes have been made. The multi-disabler works with my own build of TWRP for the Note 10.

As for which multi-disabler to use, you can inspect the code, see what they both do, and make an informed choice. Obviously, mine is what I use on my S10+ and Note 10+ and it does everything that's needed to protect those devices against Samsung's anti-tampering mechanisms.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] thevmax:
Just a note... I was rooted with Magisk and using your TWRP. I successfully installed Soldier9312.Then I tried Lineage 16 and it worked... But could not go back to Soldier9312 without installing stock rom first.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] ianmacd:
Solder's mod isn't a full ROM, so it assumes installation on top of a stock firmware base.
[Samsung Galaxy S10/S10+/S10 5G/E Cross Device Deve] tiho5:
Thanks Ian.

However, I've not been able to find yuur TWRP for the Note. I just learned that there was one. Could you please give me a link where to get it.

Another question is if the recovery is still in /dev/block/sda15 for the N975F. I'd like to use the dd commands and the script as well, but I am not sure if if the partition table differs between these devices. Please, advise.