yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
I was just going to say something about that - esp.

-Dark Mode "Cancel" "OK" is fixed for me now.

-Tested 'Unholey Light' w/4 notification quadrants for a while now, seems to be working and I have to admit starting to get a vibe for it. No longer does its blinky thing bug.

-For S10+ camera cut-out 'Tune' settings - The closest I can get it to look right around camera: Scale 4.00dp, Scale horizontal 4.00dp, Shift vertical: 0.00dp, Shift horizontal: -1.25dp .. anyone else get it closer on S10+? it's still off just a hair, but I can't put my finger on exactly what it is that's off.

New Bug (low priority):

-Changing Display modes with Holey Light - Holey light force closes itself. Have to re-open for it to reorient itself to the new res. Ex. Open Holey Light, Go to system settings/Display: Change res from FHD+ to WQHD+ (or vice versa) then switch back to Holey Light and see him run away.

Suggestion:

Pie (camera) - Fully understand Pie option and dig it does the quadrant snake move - but burn-in possible? let's say your a lonely dude and you only get one notification - overnight it's one solid color around the camera -- even multiple snake colors are still static in that one zone around the camera hole.. For Screen on modes (Maybe) - assuming the person isn't going to leave their screen on forever and dismiss the notifications in a timely manner -but- Charging: Screen off (dangerous*), Battery: Screen off (dangerous*)

* Maybe a Pie/Blink hybrid version instead? - not sure if this will impact battery more than 3.5% - or if blinking may reduce the chance of burn-in any more than just being static/solid on? but it feels safer anyway, lol.

[MENTION=9854485]Covafett[/MENTION] I can't replicate the AOD flicker - are you using the AOD helper .51 app along with Holey Light? Maybe it's the AOD background choice? - I just picked the free black and white planet earth looking one from the theme store and applied as 'Image only', have yet to see it flicker in any version. Maybe when first rebooting the phone, starting up phone, and then dropping it immediately on wireless charger I saw some partial AOD image for a second, but then it cached up and do not see it again when fingerprint unlocking. I even tried in AOD Full and Partial and couldn't get it to do it. Even let the notifications sit for 20 minutes before unlocking .. maybe the type of notifications your getting? or some other app waking up on unlock causing some lag to Holey Light? Is your AOD image color? try b/w.

As always, amazing work! It's really coming along .. just a few more bugs to squash to almost perfect.
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
[MENTION=631273]Chainfire[/MENTION] latest 0.65 still doesn't work for me skype, WhatsApp is not activating unholy light. And ik is not my phone or any bad setting on my phone because when ever i try 0.61 everything works 100%. I have downloaded 0.61 a few times and i delete it every time i see a 0.65 update but at this point am just going to stick with 0.61 it works the best and does all i need from it Just a quick update.
[Samsung Galaxy S10 Themes, Apps, and Mods] xlr8me:
Just curious but has Samsung contacted you at all Chainfire to use your app in upcoming software updates?
[Samsung Galaxy S10 Themes, Apps, and Mods] daigoro64:
I think they really should.
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
This is what i have.
[Samsung Galaxy S10 Themes, Apps, and Mods] fran_96:
Configuration APP.

The application is perfect, it works correctly, but it could be further improved by configuring a brightness option, so that the light that illuminates the contour of the front camera is brighter and more intense.

The brightness is not very intense, and it would be great if this theme were improved.

And finally, the thickness of the contour, creating another configuration to be able to edit the type of thickness that we want, big or small.

Thank you!!
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
You can make it brighter by going into your AOD settings and turning off auto brightness and turning it all the way up.
[Samsung Galaxy S10 Themes, Apps, and Mods] fran_96:
I did it that way, but having the maximum brightness, it is not intense, different colors can not be seen clearly.
[Samsung Galaxy S10 Themes, Apps, and Mods] RMSfan:
Holey Light doesn't work for me at all on my S10e. Any tips? I gave it all the permissions it asked for during setup.
[Samsung Galaxy S10 Themes, Apps, and Mods] tiziman:
Can anyone please give me a completely black background for AOD? thank you

Inviato dal mio SM-G973F utilizzando Tapatalk
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
@Chainfire I finally had some time to translate v0.65.

I ignored parts as per request in the XML.
[Samsung Galaxy S10 Themes, Apps, and Mods] kezzuki:
Thanks for the prompt reply.

So i have all 3 steps done, and grant "battery not optimised", but still nothing showing from holey light ...weird.

And also ,i couldnt install the apk from this thread either. Same screen shown as previous post. This is on S10E

Thanks.

---------- Post added at 02:15 PM ---------- Previous post was at 02:12 PM ----------

Darn...why does mine not work :silly:

Quick question, do you have any apps disabled?

Thanks
[Samsung Galaxy S10 Themes, Apps, and Mods] swagie:
No all standard here.
[Samsung Galaxy S10 Themes, Apps, and Mods] AllAboutTech:
hi [MENTION=631273]Chainfire[/MENTION],

what is the difference in configuration of app between working on screen off while charging and working with screen off on battery?

can this be the main focus of development of the app?

thank you in advane.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I think the APK thing is mainly it not working on mobile either with the Download manager or the browser. Desktop chrome + adb install works like a charm.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Yep could not install it either, even after un-installing the one from the playstore.

EDIT : installation works from ADB.

I should be able to see a while LED, but nothing.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Screenshot for reference
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
I had the same issue with some other APK and I was able to install it by temporary enabling 'OEM Unlock' from the Developer Options in the S10 Settings.

Maybe that will do the trick for you?
[Samsung Galaxy S10 Themes, Apps, and Mods] tosunkaya:
thanks chainfire, nice app, i was looking for exact this feature on my phone due to there is no notification led, i hope they will add your app's feature later..
[Samsung Galaxy S10 Themes, Apps, and Mods] iDreamliner:
Chainfire again you made a very great app, this is way better then that crappy Always on Edge app

The only thing that doesnt' seems right is when asking the 2th permission it shows local wifi and bluetooth networks, whats the use of this?
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I have no idea what's going on with your device. Feel like we're stabbing in the dark here. Can you paste the output of "getprop" ?

Are you using a non-standard resolution or dpi?

It's to work around a bug in the Android notification system. We need at least one association to be able to read the LED color the app's notifications trigger. It doesn't matter what we associate with, so tapping anything is fine.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
getprop is attached

I use WQHD+ (3040x1440) and my minimum width in dev settings is 411dp so I am pretty sure it's standard.
[Samsung Galaxy S10 Themes, Apps, and Mods] gfro9191:
The APK will install fine when you disable Play Protect in the Play Store.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Try the attached version
[Samsung Galaxy S10 Themes, Apps, and Mods] Cr4z33:
Oh yes indeed!

Got the same crap while trying to install Lucky Patcher and disabling that solved the issue.
[Samsung Galaxy S10 Themes, Apps, and Mods] Paradoxxx:
Bingo. Issue is fixed on my side. Thanks for being so fast in fixing it.

Just out of curiosity, what was the issue ?
[Samsung Galaxy S10 Themes, Apps, and Mods] iggdawg:
My S10+ didn't work with the play store or test1 apk, but test2 works like a charm.
[Samsung Galaxy S10 Themes, Apps, and Mods] rahulkheria:
This install good.. but still unable to pass the 2nd step.. i dnt knw how can i pass it.. my bluetooth is on
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
I think it didn't detect the Qualcomm variants correctly and only worked on Exynos until test2
[Samsung Galaxy S10 Themes, Apps, and Mods] Saleem360:
Thanks for this app, it works well compare to the last app that was posted b4.

The google play version didn't work for me, i took the Test2 APK works really good so far. :D

Is there an option to stop the animation and just make the light blink (on and off) or a way to use less cpu?

Just a thought

Thanks Chainfire :D
[Samsung Galaxy S10 Themes, Apps, and Mods] kezzuki:
This one is working on my Snapdragon S10E, with a bunch of system apps diabled (which i thought was the cause of it not workong)

Thanks!
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
[MENTION=7844457]Zirox[/MENTION], [MENTION=5590786]RMSfan[/MENTION]

You have 6GB,8GB memory version s10e? Processor EXYNOS? Snapdragon?

I looked up some more differences:

Capacitive v Ultrasonic Fingerprint sensor S10/S10+

Infinity-O Display (2280x1080) v s10/s10+ (3040x1440)

438 ppi v 550ppi/s10 v 522ppi/s10+

Maybe something there has to do with the app falling asleep and not waking on taps? Strange

I installed Skype and tested it.. works with Unholy Light on S10+ .. I did not try Whatsapp I will not install it, too many privacy invasions for me from that app - skype is weird tho on phone, if you have the desktop version open and using it, most of the time it won't notify on the phone at all if new notifications (default behavior) but if your desktop falls asleep and your using phone, then the notifications come to phone your using it on.. or maybe someone else is intercepting your skypes somewhere else (other instance) preventing it to notify to phone first? something to investigate

Whats funny is [MENTION=9854485]Covafett[/MENTION] after I initially set Skype to a color, and then told Holey Light to apply that color to all new Skype notifications, when I unlocked w. fingerprint after 2nd test, I saw the AOD screen flash for half a second, LOL. Maybe it's tied to occurring right after initially setting a new color for a previous blacked app? Or the apply to all notifications from this app choice. That's why it doesn't happen all the time. That may be a clue. Holey Light has to look up the new color and the lag time in between doing that and turning off AOD is just enough for it to break thru for a split second.

[MENTION=1141664]PG101[/MENTION]

I tried those settings but it seems to cut off the left corner of the light - I'm using pretty vanilla S10+ no themes, maybe just upped the font size a little cause my eyes suck, but I tried set it back to default and it did not change (still chopped corner) -- I wonder why yours requires different Tune settings then mine.. what is influencing it.. processor type? I'm on snapdragon fyi..
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
I have S10+ snapdragon with 8GB of ram and 128GB memory.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
skype works for me, you tried uninstall both holey light & helper .51, reboot, reinstall with latest altaodshed version ? first seen skype comes thru as black, i just changed it to whatever color and then long press it to apply same color to all future skypes , assuming a skype does come at least the first time, if it doesn't might be because skype open somewhere else intercepting the notification? also assuming you do not have On timeout set (disabled) with that on, it probably won't come thru as it is one of those apps that doesn't wake the lockscreen when received

---------- Post added at 07:06 PM ---------- Previous post was at 07:00 PM ----------

also, check your edge lighting, manage notifications , I have Skype active there, everything else is default (did not enable All Apps option) maybe check WhatsApp too..
[Samsung Galaxy S10 Themes, Apps, and Mods] BuckyRocks:
That is what AOD Helper achieves.

At the moment I am using this one as I believe is the one with the smallest image:

http://apps.samsung.com/theme/ProductDetail.as?appId=zhangniannian.da3f.aodonly&SITE_CODE=uk
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
Here's the settings I'm using. S10 Plus, T-Mobile Snapdragon version.
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
This one seems to help with the double tap to wake, thanks.
[Samsung Galaxy S10 Themes, Apps, and Mods] GeminiSpark:
Can you add support to use the heart rate sensor led on the back for notification? (the led seems to have support for multiple colors according to reverse wireless charging)
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Thanks! This seems to be spot on for the S10+/snapdragon - CF should make this the default. Testing with Edge Lighting (eclipse) at the same time as Holey Light. Edge Lighting swirl follows the same light path as Holey Light with those Tune settings. So far Edge Lighting does not seem to conflict with Holey Light .. comes up for a few seconds and adds a little pre-swirl to the Unholey Light to boot (as long as edge lighting supports the app sending the notification)

also thanks [MENTION=5338421]BuckyRocks[/MENTION] for the minimal AOD - I looked into becoming theme developer so I could just make an all black one, and it seems like a big pain in the ass processes. Probably easier to buy a gun, lol.
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
Yup.. used the settings.. they look quite thick.

I don't think its processor dependent.. probably screen protector positioning and type/eye sight :p

I was using .65 but it was very wonky.. would not show up on screen off many a times etc.. went back to .61.. but now it seems it is over-riding the AOD schedule.. i am pretty sure it worked before..

So yeah.. which version of .65 are you using?
[Samsung Galaxy S10 Themes, Apps, and Mods] xlr8me:
Works fine for me.

Did you go through the wizard and do what it asks ?
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
CF post https://xdaforums.com/galaxy-s10/themes/app-holey-light-t3917675/page97

>> Latest test from CF (altaodsched) + aod helper .51 from https://xdaforums.com/showpost.php?p=79317643&postcount=481 + 'image only' AOD background http://apps.samsung.com/theme/ProductDetail.as?appId=zhangniannian.da3f.aodonly&SITE_CODE=uk

>> Don't use anything from 'On timeout' option.. that's when the crazy wonky starts for me with it
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
I'll give it a try.. i think i had this one before.. it was draining noticeable battery..

Maybe I will stick with .61 for now and wait for an update from CF.
[Samsung Galaxy S10 Themes, Apps, and Mods] Zirox:
That what i did i tried ALL 0.65 version and for me they all had issues. When back to 0.61 since the app works perfectly fine and does everything i need from it and that is get a notification light lol. The rest is just addon in my opinion but personally not looking for other stuff unless it get to a version with 0 battery drain lol.
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
v0.66

Maintenance release, also on Play.

This just rolls up some of the fixes of the past week into a full release.

Aside from changes to the translations, this is the same as v0.65-4-altaodsched, so if you have that one already, there's no functional update.

Changes

- Adjust screen-off rendering (should fix animation disappearing for some users)

- Adjust AOD schedule handling

- Adjust default tune for S10+/X

- Fix color picker in night mode

- Translations: updated ru, pt, it; addes es; removed fr (outdated)
[Samsung Galaxy S10 Themes, Apps, and Mods] Chainfire:
Man I really wish I could replicate your problems and figure out where they come from. It seems nobody else has issues quite as extensively as you do.

If it's on maximum brightness already, there's nothing Holey Light can do to light them up even more. You can go into colors settings and pick a brighter color for your notifications, and that's it, really.

65-altaodsched and 66 should use less battery than 61, especially if you use AOD schedules. But if not, please let me know your observations (in %, screen on vs screen off, which animation used, etc. I need to know when the drain is occurring to be able to investigate)

Thanks, but it seems someone on GitHub beat you to it :(
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
So. I just tested the 0.66 version:

* Always on schedule -> Works beautifully

* DO or do NOT adhere to DND-mode -> Works perfect

* Long hold for example one Telegram-entrie, choose to set all to the same and then set as standard for further chans from TG -> Works insanely good

* The different modes of hiding stuff, partial full etc -> Works like a charm

* Using the color picker in night mode -> Works unsettlingly well

All in all? A home run, at least for me.

Where do I find the line to stand in to kiss som feet?

;)

/P
[Samsung Galaxy S10 Themes, Apps, and Mods] bytypez:
V 0.66 works flawless. Thanks again cf!

Will report if i find any bugs.
[Samsung Galaxy S10 Themes, Apps, and Mods] Covafett:
[MENTION=9839677]S10Guest[/MENTION] [MENTION=631273]Chainfire[/MENTION]

So using altaodschedule, everything works flawlessly. I still get a very brief showing of the aod screen when unlocking the phone. It happens very rarely and I'm not able to pinpoint what's causing it. Also S10guest, I have all the timeout settings set to 1 hour and they seem to be working exactly as they should with no issues being caused by them.
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Agree - it may work with 1 hour yes, haven't tested that long of a timeout -- This version is very solid. I'm testing on a very short timeout period - Only using one On timeout setting: Battery: Screen on <5 seconds-1 minute>. If you lower your time out I think you will see the behavior.

You may ask why you would use such a short timeout for Screen on .. maybe if I gave you a scenario.. I always use the default persistent notification behavior with screen off for all modes (never dismiss until I dismiss -- works perfect) - just in case phone not going to be used for a while (sitting on desk) and notifications come in over time .. but if actively using the phone, the notification not need be persistent (hence the On timeout options) but I still like to see it pop up and show for a short period of time when actively using phone .. with that said, if the option is on for Screen on '5 seconds' and screen is off that's when it messes with persistent notifications.. I believe apps that wake the lockscreen for a brief period are the culprits, as it's considering the lockscreen flash as a 'screen on' moment ..

so here's the scenario where you would miss persistent notifications with short duration On timeout setting: Phone on desk, you leave to do something else not looking at phone .. 4 notifications come in.. but then a missed call.. when you return an hour+ later, the screen is blank as if you received no notifications because the Screen On timeout was triggered and it cleared them (even though all the other On timeout options are set to No timeout), so no need to even look at the phone at that time (but there are notifications there) <may not be a scenario for most who are constantly on the phone, lol>

The 1 hour setting gives it plenty of time for you not to notice that it's doing this..

So I was giving it some thought as I was writing this - not sure if there's a way to not consider the glance/lockscreen part of 'screen on' and if two additional 'On timeout' options may solve this: Add 'Charging: Lockscreen on' and 'Battery: Lockscreen on' to On timeout settings (default 'No timeout') This may do the trick if possible? It may just bring it out again if someone sets a short Lockscreen timeout - catch .22 lol. Maybe just simply ignore the Lockscreen as a "Screen on" moment if possible. Just brainstorming, if anyone else has any ideas ..
[Samsung Galaxy S10 Themes, Apps, and Mods] bp328i:
I'm seeing the same behavior with with "On timeout". I would also like to see a brief light while actively using the phone, say 5 to 10 seconds and then turn off. But with the Samsung messages app, and some others (missed call) it wakes the lock screen for a few seconds and then the light turns off. If I step outside or far enough away from the phone to not be able to hear it once I get back I don't know to check it.
[Samsung Galaxy S10 Themes, Apps, and Mods] methoddon1:
[MENTION=631273]Chainfire[/MENTION]

brother, any progress on Notification Reminder as a great addition to Timeout settings ?!

as always great work, installed 0.66, all is good.
[Samsung Galaxy S10 Themes, Apps, and Mods] Jeshter2000:
Is it possible to show 30 sec that 10 min nothing than again 30 sec..

I do not know if this is already the case? if so disregard this message.....

Otherwise Im liking this app very much!

Thanks [MENTION=631273]Chainfire[/MENTION]!
[Samsung Galaxy S10 Themes, Apps, and Mods] Eziooo:
Perfect app!

Would be nice to have the cake animation only for the battery on charge/charged not to be confused with the other notifications (like the original led on s9).

Thanks for your job!

I would donate if I had the possibility ;)
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
Ok.. so now I'm on .66 as above.

The battery seems to be stable.

I've AOD schedule on.. what I can remember from the previous ones is that if I receive a notification during the AOD scheduled off hours, it won't blink on screen off, but if I single tap on the off screen it will blink along with showing the FP area for those few seconds.. doesn't any more..

Here are my settings..
[Samsung Galaxy S10 Themes, Apps, and Mods] S10Guest:
Just tested this .. turned my AOD schedule on and sent a few notifications ... vibrations came through but no blinks (Holey Light is respecting AOD schedule). If I quickly lift the phone the lockscreen comes on and I see the blinking sequence+the info (although I have details hidden/content hidden) . Also tried to tap screen (it's a double tap) and it woke the lockscreen and I saw the blink sequence.. when the screen turned off no blinks again (respecting AOD schedule)

working for me as intended .. but not sure why you don't see any blinking? are you using aod helper also? Do you allow the notification content/details to show through on the lockscreen or do you restrict/secure it?
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
It used to be so with .61 that, on AOD schedule if a notif came, on a single tap when it shows the FP area, holey light would blink as well for the duration that the FP area is visible and then turn off, respecting the AOD schedule.

The way AOD schedule works is that when it's on, it will not show on the screen off until you single tap. (I think)
[Samsung Galaxy S10 Themes, Apps, and Mods] henklbr:
Could you post (screenshot) your "settings" of "Holey Light" & "Always On Display"?
[Samsung Galaxy S10 Themes, Apps, and Mods] PiCkLeS:
Sure:
[Samsung Galaxy S10 Themes, Apps, and Mods] mixxxk:
Change HIDE AOD to Partial. From my understanding, partial hides 75% of the screen, leaving the fp scanner image, and charging info while charging.
[Samsung Galaxy S10 Themes, Apps, and Mods] PG101:
Yes.. but I can see the FP scanner image on full AOD hide.
[Samsung Galaxy S10 Themes, Apps, and Mods] rohithathie:
Hi Chainfire, could you add a option to display only the clock + light. I am now missing the time, i setup to only see the light because with aod on you already see the notifications and the clock + light, i only want to see the clock + lights and not the notifications again.