yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rainbowxxl:
there is no direct install with "recovery mode" checked and i have no root anymore. (rooted only with magisk, no twrp)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
Coming from unrooted stock I think I followed the instruction (used Magisk 22.0) . But after loading firmware with Odin (patched AP and others) - I am in a bootloop. See this part of instruction:

After Odin is done, your device should reboot. You may continue with standard initial setup.

If you are stuck in a bootloop, agree to do a factory reset if promted.

But while in bootloop there is no question about wipe data! How to get out of this hell?

The only I get is back to download mode but there is question "Lock bootloader + factory reset" or "Don't lock and restart". Finally I go to "Recovery Mode" and did factory reset there to get out of bootloop. After a while Android starts. Magisk is away (because of factory reset). But after installing Magisk again it reports to have no RD installed. ?!?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
Looking at the result of the magisk_patched...tar I see that only boot.img is changed. Isn't it just enough to flash this with heimdall? (In fact Odin is for me a bigger thing - don't have Windows. Does Odin works with Wine?)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
Mh, after reading instructions again and again I found the problem. You can either call me stupid or one can think that instructions can have a slight improvement.

So what was problem: At beginning of manual there is mentioned that AFTER installing Magisk with Odin you might boot in a special way, via Recovery.

@topjohnwu: Wouldn't it be better to mentioned that in the line - after odin is done?

Additional it confuses me that nowaday USB cable has to be plugged in addition to the known pushing the Vol+ / Bixby / Power keys.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
Finally I flashed a Magisk patched TWRP 3.5. Wow. Difficult for me, but how difficult is it for the dev. Great work!

Is this a known issue that Magisk doesn't boot recovery if requested? Is it something that can be solved in future? It would be much more comfortable than standard way of shutdown and Vol+/Bixby/Power.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
One more thing: If I see this right - without a PC connected I don't have a chance to boot into Magisk enabled system?

That I think is a really bad thing. Just imaging you have a firewall running and your Phone does a reboot! You phone is not protected anymore.

Is there a chance to modify that logig?

Any way to reboot into Magisk-enabled mode?

I understand that the hack combining Magisk/recovery is required, but could it be solved another way around?

Any chance to revert the need of USB plugged for Recovery?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
ANd with new firmware is worse and worse
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
A USB-C stick on a keychain is what I use when I can't boot in Magisk mode without USB. But I have near 100% success rate of getting Magisk mode with just the button combo and no USB.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] FossaFX:
Need some help, guys.

I've bought S10+ (Exynos) yesterday, unlocked bootloader, patched stock AP image, flashed it and so on. Everything is working OK (except I need to insert Type-C adapter to be able to boot into rooted mode).

Now I want to install Lineage OS and here comes the trouble.

I've downloaded latest TWRP, patched it, flashed it, booted into it and installed Lineage, again no problems. BUT, if I try to boot into rooted mode, phone freezes on the screen with two warnings (about bootloader and custom software).

What's this? Incompatibility between TWRP and newest Magisk? If so - how could I flash Lineage without TWRP?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
D

What is newest Magisk and TWRP? More details please. DId you format data? So before you try to flash LOS, do you have a working combination of Stock/Root/TWRP? I found to get that already tricky ;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
Did someone of you have been able to spoof a Android 11?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] FossaFX:
Magisk 22.0, TWRP 3.5.0_9-3. Yes, of course I've formatted data.

I didn't had working combination, I had Stock + Root working.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
If you have fastboot, you can "fastboot boot TWRP" just to install Lineage.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
The same thing happened to me last night (plus additional mysteries; see below). I followed @topjohnwu 's instructions, ran into bootloop, got out of it somehow, have Magisk 22 app installed, but seem not to have Magisk itself installed (which I don't understand), have no root access (per Root Checker), and Magisk app fails SafetyNet check (ctsProfile circled "minus" sign). Here is the entire process I went through:

Received a gently used S10e SM-G970F. Did not put my T-Mo SIM in it, as I need my old phone to work while I liberate the new one. Installed and used the app Phone Check to run diagnostics to make sure phone is in good working order; all tests passed. Phone arrived with:

Android 10 (stock, no root)

Security Patch Level : 2020-02-01

Bootloader : G970FXXU4BTA8

Build Number : QP1A.190711.020.G970FXXU4BTA8

Baseband : G970FXXU4BTAA,G970FXXU4BTAA

Kernel : 4.14.113-17806689

Locked bootloader

Followed @topjohnwu 's instructions for SAR to the letter (used SamLoader [EDIT: SamLoader found and downloaded: G970FXXS9EUB1/G970FOXM9EUA4/G970FXXU9EUA4/G970FXXS9EUB1], and adb for file txfr), and landed in bootloop upon Odin's automatic reboot. Tried many times to catch the black screen between loops and boot into Recovery. Was finally able to interrupt the bootloop by pouncing on the black screen in between loops, and booting into Download mode; then from there was able to reboot into Recovery. Now in Recovery Mode, I selected Factory Wipe Data. Phone rebooted.

Now my memory becomes a little muddled, 'cause things started not working, and I don't know my way around these kinds of operations (I can intelligently follow instructions). I think the first thing I did was use the Files app to navigate to my external SD card, where I stored the Magisk 22 apk (downloaded from official GitHub repo), and installed it by tapping it in the Files app (gave permission). When I opened Magisk (the install routine offered to open it for me), I expected that it would ask me to let it continuing to do things, as @topjohnwu stated in his instructions: "It should show a dialog asking for additional setups. Let it do its job and the app will automatically reboot your device." But it did no such thing. I tried setting update channel to Canary, and tapped Install in the "App" card, and now the latest version is installed "(22001) (18)".

Note that I have done

nothing

with TWRP so far.

Magisk app's top row shows "Home" and the settings gear, and nothing else. There are no icons on the bottom row (besides social media icons). The "Magisk" card shows: Installed N/A, Ramdisk No, A/B No, SAR Yes.

Like I said, I don't know how any of this works, and don't know how to do anything in the world of rooting except follow instructions.

Can anyone help?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
Some things I learned:

For peace: untick the Auto Reboot in Odin.

Use adb push and adb pull instead of MTP to send and receive the AP file that you patch with the Magisk App. With MTP, corruption can occur.

On our SAR devices, tick 'Recovery Mode' when patching the AP file. The files it patches are boot.img, recovery.img and vbmeta.img. Don't worry about the .lz4 compressed files; Odin flashes the patched .img files just fine.

You can put a Magisk patched TWRP image as recovery.img in the AP file, overwriting the patched stock recovery.img. This gives peace, because in order to flash TWRP separately, you need to reboot to Download Mode again and flash it.

You could choose to run without TWRP, which will work fine, but there won't be multidisabler benefits (see later).

From rooted Android, you can easily swap between TWRP and stock recovery, if you with to. I recommend the official TWRP app.

Never flash just an AP file, always flash together a HOME_CSC file. I ended up with a 16GB data partition, which I had to fix in TWRP. Better to avoid this all together by integrating patched TWRP into your AP file.

First time entering TWRP it will probably do something (protecting itself from firmware overwriting TWRP with stock recovery) and reboot your phone. Be ready for this and force TWRP boot with Bixby+Volume Up+Power, keeping Volume Up until in TWRP. USB data connection may be required.

I always flash multidisabler. I think it's not needed for a functioning rooted stock system, but better safe than sorry. Check the instructions.

Flashing firmwares from different CSC regions is fine as long as it has OXM in the filename.

TWRP must be compatible with the stock kernel. Use corsicanu's official builds.

When you are done with the flashing and recovery things, boot into Magisk Mode with Bixby+Volume Up+Power, keeping Volume Up for a bit. USB data connection may be required. After installing the Magisk App, it should tell it's installed. The extra steps it does are a thing of the past, I believe.

/edit: I had a look at the official instructions and this section is confusing:

This is an if if. The first bullet does not apply, the second one does. You can do that, but I recommend booting TWRP first in order for it to at least safeguard itself. I also recommend flashing multidisabler, as I said.

/edit2: one last word of advice: be very careful with custom kernels (some of which do wayyyy more to your system than just being a custom kernel) and Magisk modules that mess with your Android keystore, like the Universal SafetyNet Fix. They can mess it up with the only solution being a factory reset. Not even TWRP restores can fix that ****.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
Thank you for the detailed advice. I'm unsure of what order to go in, and also how many things I can flash in Odin while the phone is in Download Mode before rebooting. (I assume only one file at a time per slot can be loaded into AP and the other slots, right?) Do I need to reflash back to stock and redo the entire root-by-Magisk procedure, or just reflash the Magisk-patched .tar file (with its companions, per John Wu's warnings) without returning to stock first? [EDIT: Additional question: Do I need to uninstall and reinstall Magisk?]

A related question: would the Magisk rooting method work better with older firmware? I'm not picky: I'd be perfectly happy with any rooted, stock-like OS from Marshmallow to the newest version. My priority is simple: have a fully functional rooted device, so I can install root-only apps.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I am uncomfortable with all the numbers you spit at us. Is the ROM you downloaded the same as the ROM currently installed on your device?

There are "protections" in play, such that if you "update" to a "higher" level, you will not be able to go back. This may only apply to the bootloader, which I think is the BL.tar file. But since it is the bootloader that is supposedly "unlocked" to allow any of our fiddling, I worry that an "improved" bootloader will suddenly block us, even while pretending to be "unlocked".

So, you said your bootloader was "XXU4". I would avoid using any bootloader that doesn't end in a "4". And I wouldn't fool with the phone until I had a copy of the current ROM, in case I had to restore the phone.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
That is strange. I guess 100% for me that it won't work without USB. What Stock Android is your base? Maybe it is because of I am already on 11?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
What is FUBD? I am on S10e anyhow.

But that behaviour has to be controlled via the very first part of software. The Odin Part of BL consists of quite a view parts - no idea what they are all for. Only "sboot" sounds somewhat familiar ;)

But in AP there is again a "boot" part? Very confusing.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
With FUBD I referred to the firmware version; it's the last 4 characters. The full version string of this for S10 is G973FXXU9FUBD.

BL: BootLoader

AP: Android Partition

CP: Modem Firmware

CSC: Consumer Software Customization

The .tar file you flash in the AP slot contains different .img files. These 3 are special: boot.img (containing the kernel), recovery.img (can be stock or TWRP), vbmeta.img (used to protect something I believe). Those 3 files are the files the Magisk App patches on our S10's, and repacks into the Magisk patched .tar file.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
Ok, but I think I would like to change the behaviour of a part of BL section. That one that is responsible to require an USB-C pluuged device for booting into recovery/Magisk-enabled mode.

Even better would be to have the "Magisk-enabled" mode as default boot mode, but that might be not possible.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
A custom kernel can do that. I have had a good experience with CruelKernel, but I have become so afraid of strange things messing up my system that I'm running stock kernel. v4.0 is compatible with FUBD and works with Magisk patched TWRP as well. No key combo needed to boot Magisk mode. Be aware that, like with TWRP, kernel needs to be compatible to the rest of the firmware.

In my opinion still, custom kernels are risky. They can do things you don't want. There's os_patch_level's that need to be minded. Going back to stock kernel is not always possible (it is with CruelKernel). They can keep you from updating firmware, unless they are updated as well.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] starbright_:
I am on FUBD too.

Surprise that this is key-combination is already handle by kernel. It is in very, very early boot. Isn't there some kind of uboot?

Yes I have seen this "beware of custom kernel". Also you will get in mess after the next OTA. No other way?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
And here I thought FUBD was "Up By Design".
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
Key combo is handled by the bootloader I think, to boot to recovery. Normal, stock behavior. Magisk patched recovery then handles what recovery does;

Keep Volume Up pressed for a bit: skip recovery and boot Magisk patched Android

Keep Volume Up pressed long: boot recovery

A custom kernel has Magisk integrated in the kernel, a totally different way. So it doesn't need a key combo. Also, it doesn't need Magisk patched recovery.

This is gold, thanks for the laugh 😄
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
My apologies for spitting specs! I did so b/c I wasn't sure which specs were relevant, so poured them all out.

@jelbo -- Thank you so much for the idiot-proof instructions; really needed them! -- Yet somehow I still managed to "FUBD" it up, if you take my meaning.

I followed the procedure, but when flashing the patched files, Odin (3.14) threw: "Complete (write) operation failed". When I tried rebooting, I found my S10e stuck on the Emergency Recovery ("An error has occurred while updating the device software..."). I successfully reflashed the un-patched firmware files, so now back to latest stock Android 11 (G970FXXS9EUB1). I'm thinking that my version of Odin and the cable are both working fine, because they have successfully flashed this S10e a few times now.

The only thing I can think of that I did outside of your instructions was rename the Magisk-patched AP .tar file after I created it with 7Zip (not 7Zip ZS).

Any thoughts?

[EDIT] P.S. Sorry for my delayed response; had to work overtime Sunday thru Tuesday this week.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
That error ca have different causes.. drivers, USB port, USB cable, maybe more. The name of the .tar file doesn't matter. It has everything from the original inside, the Magisk patched .img's and the Magisk patched TWRP, renamed to recovery.img?

Also, I linked to files for the S10, not the S10e.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
@HerrPoetry I didn't mean to object to the amount of information. I was trying to say that it was not clear to me that you were patching the same version as was already on the tablet. Since you've reflashed the unpatched version, from now on that is what is already on the tablet.

I do not have this tablet. I do not know if TWRP is a vital part of the process. I would try just patching with Magisk and see how Odin/tablet react.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
Could the recent installation of Smart Switch have affected Odin? (I installed Smart Switch in multiple futile attempts to get Frija working on my Win7 box. Nothing worked. Had to use Samloader.)

I did download the correct TWRP for S10e (beyond0lte).

If I just install Magisk without TWRP, how could I add TWRP recovery afterward?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I wanted to know if the Magisk patching / flashing is working for you.

After that, you can go back to @jelbo's instructions.

Other experiments: copy AP.tar, replace recovery.img with TWRP, try to burn modified AP.tar. Whether it works (meaning Odin doesn't complain, and you end up with TWRP installed) or not, use Magisk to patch the modified AP.tar -- maybe Magisk does something different when it sees the whole AP.tar than it does when it just sees a recovery.img.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
Tried again with TWRP version of the Magisk-patched AP.tar. Odin hung again, I think in the same place: when it got to userdata.img the progress bar stopped moving forward.

Is it against the rules of this forum to ask for technical help with putting myself out of my misery? 😵😢

[EDIT]

I tried @J.Michael 's experiment of taking the Magisk-patched-with-TWRP-recovery.img AP.tar file, and running it through Magisk 22's patch process again, and got the same result from Odin: hangs on userdata.img for a while, and "Complete(Write) operation failed." Tomorrow night I can try flashing the Magisk-patched AP.tar without the TWRP recovery.img in it. But I would prefer to have TWRP. Odin is flashing the device back to stock Android 11 successfully every time, so I don't think Odin or drivers can be the problem. Any ideas? -- Including any reliable mail-order rooting services?

Perhaps I need to try patching a different version firmware? I would, however, have no idea how to choose another version. Can anyone confirm successfully rooting an S10-family on Android 11 with Magisk+TWRP-patched 11 firmware?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
Answering just this question: you can easily do it with the TWRP app or even using dd as root from a terminal in Android.

What happens if you flash the firmware files and the Magisk patched AP.tar without TWRP? Remember, TWRP is not necessary, unless you want to make backups and flash things from recovery.

If that works, you can flash Magisk patched TWRP as a second step, before booting Android. You'll need the vbmeta.img file from the TWRP topic in the CP slot and, I believe, the HOME_CSC file in the CSC slot. If it works, don't forget to flash multidisabler.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
Well, flashing Magisk-patched AP.tar without TWRP hung on userdata.img also, with same Complete(Write) operation failed result.

Am I the only member of the global SM-G97XX family who cannot root his device?

For the time being, I am going to try flashing back to stock with the FUBD firmware (UK CSC: EVR) instead of the EUB1 I've been using. But since at least one version of Android 11 (EUB1) isn't working, I'd love suggestions on how far back I can downgrade the firmware in order to make the Magisk root process work. (If I were a more senior member, I would suggest that the Magisk installation instructions be changed to: Do NOT download the latest firmware! Download the last firmware known to work.)

Is there anything that will make this process foolproof?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
@HerrPoetry I don't completely trust Odin to know when problem occurred, I think Odin can be sending a file when it gets a message from the tablet about an earlier file. But what else have we got?

Try making a small AP.tar file, containing just boot.img, recovery.img, and vbmeta.img. (If any of those are .img.lz4, don't expand, just copy the three files from the "original" AP.tar.) Then patch the small AP.tar with Magisk. (Or take the three image files from the Magisk-patched big AP.tar to make the small patched-AP.tar) Use the small

patched-AP file, along with the other three original .tar files, and see what Odin says.

I'm losing track: every time Odin fails on "userdata.img", do you try to boot to recovery to wipe data? Or do you give up? I think there were times when Odin said "error", but it worked. I know there were times when the tablet said "fail", but I went through the rest of the procedure and it worked.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
@J.Michael -- I will try the small AP file experiment, but just want to answer the above-quoted question. When Odin fails -- "(succeed 0 / failed 1)" -- my phone does not reboot automatically (b/c I've unticked Auto Reboot), but instead remains in download mode. To exit DL mode I hold Vol-Down + Power for 7 seconds, and the phone then reboots into Emergency Recovery mode (see attached image), because the software update failed. I found out that this is actually a version of download mode, so it is while on this Emergency screen that I then reset Odin, load up stock firmware, and flash back to stock.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
[EDIT: Deleted b/c this was a duplicate of my Mar 12, 2021 at 12:32 PM post]
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
From download mode, does Power+VolUp do anything?

Can you shut down from download mode by holding Power (maybe long time)?

I think on my tablet (SM-T290) Power+VolUp goes to Recovery.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] R1xON:
Need some Insight

im on Android 11, Oneui 3. Galaxy S10Plus with Code SM-G975F/DS.

1. what is the difference between SM-G975F and with /DS?

2.can i use the method provided in 1stpage Link To obtained root?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Dual SIM
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] HerrPoetry:
Hey, gang -- and particularly @J.Michael & @jelbo -- thank you for all your help. After a phone conversation with my wise, 2000 year-old father, who has been a programmer since the punch-card days, I've decided to try life without root. My root-or-die attitude was formed during the KitKat years, when you couldn't write to your own external SD Card without root. With recent OS versions, as dad pointed out to me, there's more scope for customizing the user environment; not nearly as much as with root, but I think enough for me.

Cheers! 🍻
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] R1xON:
Thx for the answer, so i can assume it is safe to view SM-G975F and SM-G975F/DS as a same type of phone, and download, flash magisk, and use customROM that is intended for SM-G975F ?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
He's right, much has changed. Rooting Samsung devices has become a headache, especially the SAR ones. Enjoy your S10e :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Yes
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] R1xON:
Cheers