yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
No, that's not what I said.

what I'm saying is this: the multi disabler in this link disables file-based encryption (and a few other things, like preventing it from reverting to stock recovery), and when you flash twrp, it probably does this automatically. and this is why the encryption screen in the screenshot below is gone.

[Pie/10/11] [System-as-root] Multidisabler: disables encryption, Vaultkeeper, auto-flash of stock recovery, proca, wsm, cass, etc.

The multi-disabler started life on the Exynos S10 range, the first Samsung devices to launch with Android 9 (Pie). Since then, it has grown to support a great many Samsung devices running either Android 9, 10 or 11, and with either an Exynos or a...

xdaforums.com

FBE (file-based encryption): Until this is disabled, most versions of TWRP — all for Exynos devices and many for Qualcomm — cannot read files on /data (the userdata partition). You must format /data to actually remove FBE after disabling it. Back up your data first!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
below are the commands I need in the multidisabler config file. but I couldn't find where these commands work.

disable_recovery_restoration() {

local r=recovery-from-boot.p

local found

local i

ui_print " - Disabling restoration of stock recovery..."

for i in $ANDROID_ROOT $ANDROID_ROOT/system; do

if [ -f $i/$r~ ]; then

ui_print " - ...already disabled."

found=true

break

fi

if [ -f $i/$r ]; then

ui_print " - Found $i/$r. Disabling..."

mv $i/$r $i/$r~

if [ -f $i/$r~ ]; then

ui_print " - ...succeeded."

else

ui_print " - ...failed."

fi

found=true

break

fi

done

[ -z "$found" ] && ui_print " - Found no stock recovery. Pfft."

}
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I don't know what I said that was not what you said. (I don't know what I said that was intended to be anything you said.)

I was thinking that you should not use the multi-disabler. I have not replaced my recovery, but I did install a magisk-patched copy, and it does not get replaced, so I'm thinking that just booting to recovery immediately after downloading the patched recovery resets something. Or maybe it's related to the factory reset / wipe data. I don't know.

It seems like you should have the option to encrypt the phone if it is not encrypted. Do you have a PIN? Do you have the option to set a PIN?

The code you posted looks like some shell command language. I do not know whether the tilde is a string matching operator or just a literal tilde, but the code seems to be searching two directories for a few specific, peculiar, names. Since at some point it renames a file, and the directories seem to be "/" and a subdirectory, this is not in the spirit of systemless modification. More to the point, on some device and firmware combinations, you just can't do it. So I repeat my advice that you should not use the multidisabler.

You should check with Lineage people to find whether the multi-disabler is part of their process.

If you still want to try a single disabler: in the vicinity of the code you posted there is probably a stack of calls to procedures, including the procedure you posted. Cut out all but the one procedure you want to try. You might be able to run the script in a terminal emulator window (if you have root privilege). You might have more luck making your own version of the disabler zip and running it from recovery.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
sorry i may not be able to express myself fully, i am using translation.

The only thing I want right now is to root without using twrp. and device encryption remains enabled.

(i.e. I don't want anyone to access my data until the device is unlocked)

(because all new twrp's automatically disable the encryption system, likely that multidisabler used to do)

this now includes the following in all new twrp

Spoiler content hidden.

and this twrp-free root thing is only possible with lineage recovery. but since lineage recovery does not contain a file to prevent it from restoring stock recovery (I think) samsung, deletes lineage recovery directly.

how can i use terminal emulator? Should I paste the code I gave above with my root right?

I've kept you a little too busy. sorry
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I think when you install Magisk, you must wipe data. Stop thinking "encryption remains enabled", try for "enable encryption after installing Magisk".

Maybe I missed something. Why replace recovery at all?

The code you posted seems to regard the existence of "recovery-from-boot.p", either in "/" or in "/system", as meaning recovery will be replaced/restored at some point.

The first post of this thread was written by @topjohnwu, and explains in some detail. He has a way to keep recovery from being "restored". It must work: I have a "/system/recovery-from-boot.p", but my recovery does not get overwritten when I boot.

Why not try installing Magisk without introducing a custom recovery? Do it by letting Magisk patch the full AP.tar so it can make necessary changes to boot and vbmeta while injecting itself into recovery.

After Magisk has been installed, and data has been wiped, I think you will have the option to set a PIN and then encrypt your filesystem.

I think this is a dangerous choice. According to Wu, the encryption key is derived from (among other things) the boot partition. If for some reason that changes, you will lose the key; you will lose your data. Maybe you will be safe as long as you do not update your system. Maybe the system update process deals with it. (But there must be all kinds of warnings against updating your system without uninstalling Magisk first.) I would not take the chance.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
Thank you so much for all your help.

I answered both my own question

(I exctract boot.img from lineage recovery and stock rom and patched it with magisk and I got what I wanted, but the method you wrote now is more logical)

and the method you told me is the most logical, what you said (patching ap with magisk)

I never thought alone, I always used patch AP with magisk+twrp as magisk patch. I never didn't just patch the ap and try to boot it, I wish I had, I wouldn't have bothered so much.

Again, thank you very much for answering my strange question. :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] sams10:
is there a software to put phone in download mode
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mat68046:
I'm getting nowhere rooting this SM-G973F, which I purchased specifically because the bootloader was unlockable.

Obviously I should not be doing this at all since it's apparently over my head....

I aquired the CSC info via Frija.

Running Android 12, OneUI 4.0

Original CSC was XTC I believe, on TPA now from the looks of Frija but it's the same download file afaik.

I got as far as patching the AP.tar with Magisk but I cannot get Odin to flash the phone with the HOME_CSC AP to keep current data, no matter which version I use.

Bootloader is unlocked as I get the unofficial Samsung software warning and I assume Knox is tripped.

I cannot boot the phone into Recovery mode, only Download, so I am stuck on this step.

I'm hoping to find help on this thread, I'm unsure where to turn at this stage.

Agreeably the one-click root options aren't trustworthy but I need to finish this process. I'm not yet looking for a custom ROM, only the stock software and the ability to do full backups including app data and the option to use call recording (for personal attorney-client calls) which was disabled in recent versions of Android (I believe). Unlocking the bootloader has already cost me the several sammy apps mentioned in other threads.

Again, any assistance appreciated. If I knew someone in New England that could walk me through this in person it'd be worth the trip.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Hello Matt68046, If you follow the installation as explained by John Wu normally no problem.

I put you a tutorial

1- The bootloader follow explanation Use vol down + vol up + USB cable plugged into a PC to boot the phone into download mode;

Long press vol up then confirm that you want to unlock the bootloader (this is only needed once);

* Please note that all your data will be erased, including internal memory, and the phone will restart!!

5- Let the phone start normally, go through the configuration and connect to the Internet (wireless or mobile data) in order to unlock

6- Make sure OEM Unlock is enabled in Developer Settings.

2- Once reboot install magisk 25.2 APK.

3- Download the official firmware on Samobile.com or frija you will find this on the forum.

4- Transfer the official firmware AP to the smartphone.

5- Open magisk recovery mode choose corrective mode choose the AP download press "let's go."

6- Once the modification is finished in the root directory, download a patched_magiskxxxx.img.tar file if found.

7- Transfer it with adb pull like this adb pull /sdcard/Download/patched_patched.magiskxxxx.img[.tar] you can rename it "patched_magisk.img.tar"

8- Put your smartphone in download mode Use vol down + vol up + usb cable connected to a PC to start the phone in download mode, briefly press vol up to

confirm that you want to enter download mode;

9- Open Odin latest version placed 4 files following BL-AP magisk patched.img.tar-CP-home CSC leaves auto start checked in odin option.

10- It will restart open magisk activated Zygisk restart install safetynet modules - shamiko-hidemagisk prop config-busybox nk-lposed see on this page https://xdaforums.com/t/discussion-magisk-the-age -of-zygisk.4393877/

En savoir plus sur ce texte sourceVous devez indiquer le texte source pour obtenir des informations supplémentaires

Envoyer des commentaires

Panneaux latéraux
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mat68046:
J.Michael,

Thank you for the tutorial.

I am not understanding your step #5:

"5- Open magisk recovery mode choose corrective mode choose the AP download press "let's go."'

Does this mean I need to reboot the phone into recovery mode?

If yes, then this is the problem I am aving as the phone will not let me boot into recovery mode using the appropriate method.

I CAN get into download mode, but NOT recovery.

The bootloader IS unlocked and the OEM unlock button is set to active, although it is grayed out somewhat.

Knox was tripped in the processing I've done so far to the phone, and upon reboot I do get the unofficial Samsung software warning.

Util I can get the phone to boot into recovery mode I am stuck at this step.

-Mark
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Those instructions were posted by @meric57.

I think step 5 means when you use Magisk Manager app to patch a file, sometimes there are checkboxes. One box is labelled "Recovery", and had something to do with telling Magisk Manager app that the patches for Magisk would be installed in the recovery partition.

When I installed Magisk on a T290, I patched an AP.tar file. I don't think the "Recovery" checkbox did anything -- Magisk Manager app recognized that it was patching a tar file and it fiddled with boot, recovery, and vbmeta.

Since then some people have found that some devices that would seem to need to install Magisk in recovery can in fact have Magisk installed in boot. There is no way to tell other than by trying it.

If you have not flashed anything yet, you should be able to boot to recovery. If you have flashed a modified recovery, that might interfere with booting to recovery. Re-read this thread and other instructions to make sure you know how to boot to recovery. Flash the stock ROM to make sure you haven't damaged recovery. Then try to boot to recovery. I don't think there is any point in doing anything else until you can boot to recovery.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mat68046:
I think I need to be sitting next to someone who knows what they are doing. Anyone available in the New England area?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Hello mat68046, I don't see where it's blocking you.

I just updated the October security on my S10 exynos 4 g, no worries on my side it must be your model which must be the cause. On the 5 you must have magisk on your S10 modify the AP of the rom Official with magisk choose patch which is the AP of the firmware, then you transfer the patch_magiskxxx.tar with adb you flash with odin.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Hello Sam10, yes install adb on your pc then use the following adb devices command to find out if it is authorized.

Then adb adb reboot download or recovery.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mat68046:
I tried Odin several times, several versions, etc. Odin will not complete the process. I did get as far as getting the Magisk patch created, which I referenced in Odin, but it will not work.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
What "will not work"?

If Odin says "success", but the download screen on the tablet says "SECURE CHECK FAIL: vbmeta", that was success for me. Next step reboot to recovery to wipe data.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Hello Mat68046, Your S10 is G973F exynos not a refurbished with a Korean or US chip.

If you flash the official Android 12 XEF rom or an operator with a version with a chip that does not support the European network, it will not work.

The trap of telephone market sellers who sell low-cost telephones with unlocked operator my chip inside Asia or the US.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Hello Mat68046, I don't know how you do to flash I don't see how you perform the manipulations. Your S10 is good exynos. A fair advice must first rot with magisk ok then TRWP which must be done either with TRWP APK or odin must follow the forum tutorial, me in your place I will just do with magisk unless you want to install a custom rom.

Your s10 is a non-refurbished unlocked all operator if these the case looks at your model SM-G973F / DS and not SM-973 with other letters behind 973 thank you
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] zogoibi:
Hello all.

I'm all confused by the many apparently contradictory posts on this topic that I've read all over this website. I hope someone can help me (and others like me) clarify a "simple" question.

As far as I understand, for rooting S10 and getting TWRP, the recommended steps are to first root the OS by flashing a magisk-patched AP file, and only then replace the stock recovery by flashing a (patched/not patched?) TWRP. So far, I have already achieved the fist step (successfully root the ROM with a magisk-patched AP file via odin). My system (stock ROM if you care to know) is now rooted, but no TWRP.

Now I want TWRP. So, my question is:

Do I need to magisk-patch TWRP before flashing it, or not?

What is the difference between a patched and a not-patched TWRP? What do I achieve by patching it? What do I miss if I don't?

Thanks in advance for any help.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] zogoibi:
About magisk modules install

How do I go about installing modules in Magisk? I am on Magisk 25.2 and there is no option for downloading modules. It only shows "Install from storage". I've tried changing channel stable/beta (just in case it did something) but no difference. Am I doing something wrong, or this new version of Magisk does not support downloading modules? (Which would be quite weird in my opinion.)

And yet another question: I do not see the "preserve encryption" option in Magisk. Previous versions had it. The thing is, I would like to disable encryption using Magisk, but I wonder if that is at all possible for this phone.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
hello, if you are looking on this forum for discussions on magisk

https://github.com/Fox2Code/FoxMagiskModuleManager#foxs-magisk-module-manager
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I think if you use Magisk manager app to patch AP.tar, it will install Magisk in recovery. If you replace recovery a second time, this time with an unpatched TWRP, at best you will lose Magisk.

I have read this thread, but I have not retained everything. You will have to go back and find someone who describes doing what you want to do, and see what steps got him there.

It is not really contradictory for there to be more than one procedure. Some people find it easier to install TWRP first, then use TWRP to install Magisk (by renaming magisk.apk to magisk.zip, then using TWRP to "flash" a ZIP). I think when they take this path, Magisk will be installed in boot.

Another possible path (just assembling steps, I do not remember if it has succeeded on this device):

take AP0.tar, the stock AP.tar; make a copy, AP1.tar, and replace recovery.img with TWRP.img (which means make a copy of TWRP.img, rename it recovery.img, then stuff that into AP1.tar; if the original AP.tar contains recovery.img.lz4, delete that and insert the TWRP-renamed-to-recovery.img -- I don't think all images need to be compressed, just get the extensions right); then have Magisk manager app patch AP1.tar, producing AP2.tar. Run Odin with AP2.tar and the other 3 .tar files of the stock ROM.

If you insist on knowing every possible choice, and its pros and cons, before trying anything, you will never do anything. Pick one success story and try to follow his instructions. Then wipe the tablet and try something else.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
John Wu no longer maintains an official module repository. Check the main Magisk thread for talk of places to look for modules, and how to install them.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] profeeder55:
Hi All, I'm in a bit of a tricky situation here. I was able to unlock bootloader for my S10e (SM-G970F) and have tried patching the AP stock file through magisk 25.2 in my phone and using Odin to flash it back (alongside the CSC, BL, modules) but it keeps throwing it into boot loop. I then try flashing it back using the AP stock file and it worked fine.

Any idea or help I can get on this as I've read through the threads and most people are able to get the "patch AP Through magisk then flash using Odin" method to work but unfortunately not for me as I'm constnatly getting boot loops

Thanks in advance
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Hello profeeder55, just to know the ap modify with magisk 25.2. the transfer you do it how S10 via pc or you used ADB pull as adviser by the instalation john Wu.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] profeeder55:
Hey I've tried both methods ADB and direct transfer MTP (though ADB is much slower) and it's still throwing the same error
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Strange that it does not work, you are sure that the firmware is the one to quote SM-G970F or SM -G970U or SM-G970N. If you use the EU firmware AP and you have a US or ASIA network chip you will have this problem, so the best to be sure to have the right firmware for your model.

Your S10 E buy or market -amazon or others if it tells you to unlock all operators ok for the sim card for the network not the same.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] profeeder55:
Thanks for the reply - I've managed to get it to work and boot into Android using some button tricks and following the below video

However, another issue is when I try to "Hide" the magisk app and restart the phone, it goes into boot loop and I have to re-flash everything again. Trying to use this phone to spoof my GPS with Smali Patcher but nothing seems to be working at all
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] profeeder55:
It looks like the boot loop issue occurs when I turn back on "Developer Options" after the root is successful. Is there anyone that has encountered the same issue who has a solution for it ? Thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
normally after the restart you have to activate Zygisk in the parameter then install the modules magiskhide prop config v 6.1.2- shamiko 0.5.2 -universel safynet fix v 2.3.1 use the fox manager apk that you will find on the forum.

Do not forget in the parameter to hide the apk bank and others

https://xdaforums.com/t/discussion-magisk-the-age-of-zygisk.4393877/
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] sperelli:
after following the video instruction, which is the safest way to install a custom recovery?

and after that, is there any simple way to simply reboot the device without having to do any combo?

thx,

regards
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] basile:
What happens if I do NOT wipe/factory reset the phone (s10+ andro12 nov2022 updated) in the whole Magisk root process ?

Thing is I do NOT want to loose my data & software (because there is loads on it and I do not want to reprogram everything again) ...

Just thinking, I patched the original AP, what happens if I just flash this into the phone via Odin ?

What can go wrong ?

Anybody tried this ?

Thanks in advance

Bas
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
The official instructions have you wiping twice. At least one of these is to remove encryption.

You might get away with not wiping. Is your bootloader unlocked? Samsung does not give you a choice -- you *must* wipe as part of unlocking.

If your bootloader is not already unlocked, and you do not want to have to set up your device again, then give up trying to install Magisk.

If you are already unlocked, there is a chance you would get away with flashing a patched AP without wiping. There is another chance that, after that fails, simply flashing the unpatched AP would put you back where you started. (Do some reading, one of CSC and CSC_HOME does not wipe data; the other does.)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] sperelli:
anybody?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I've lost track of what you've been told. You need to read a substantial amount of this and other threads. What I've seen was probably in the T290 and T295 threads, but I'm not sure.

I think some people said using adb to boot to recovery triggers Magisk.

It might be that having a USB cord plugged into the device (not necessarily connected to a PC) helped.

The most useful thing would be learning what signal to respond to by releasing the buttons. It's not random, and somebody described it well enough for me to do it.

What kind of reboot are you talking about? If from a running system with Magisk, there's an option in the Manager to reboot -- that ends with Magisk again. If Magisk is not active, maybe there's a "boot to recovery" option in the Power menu. (Maybe there's a Developer option that adds Recovery to the power menu.

Mostly, you have to read a lot and try a lot of things.

Do you expect to have to reboot a lot?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] IsocolXDA:
cool. Do i need to factory reset the device first before flashing uipdate in odin? Or can i just enter download mode straight away?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
Curious, Frija, Updato and SamFirm all give me different PDA, CSC and phone codes. How do I know which is right?

I can't even find the download button on Updato
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dames0701:
Updato download button is closer to the top. It's just underneath the region filter area.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
It links to a dead page for me
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dames0701:
Ahh yes, this has happened to me too. You do get a dead link every now and then. I recommend samfirm then. After you type in your region code, it will download the latest firmware they have. Then compare to updato and others to see if it is truly the latest.