yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
If you don't think Magisk was installed properly, do not install Magisk modules. Magisk should work without any modules. No module is going to fix a faulty Magisk.

What do you mean "when I installed lsposed it showed that the magisk is installed partially"? What "showed that the magisk is installed partially"? The Magisk manager app? Some LSposed interface?

I don't think I have ever heard of Magisk being partially installed.

If Magisk is installed, and you boot, and Magisk does not detect a Magisk manager app, then Magisk will inject a stub manager app into your system. When you run the manager app, it will ask for permission to fully install the manager app. There might be something that calls the stub a "partial" app. But that is the manager app, not the Magisk that is patched into some system partition.

There are instructions for installing Magisk. Some use TWRP. Some do not. There are probably instructions in this thread. There are definitely detailed instructions in John Wu's github area. Have you read any of these?

I know it seems like it shouldn't matter, or people should be able to guess, but you should really make a point of specifying what device you have, what version of Android is on it, and what version of Magisk you installed. You should also say something about whether you saw a "Recovery" option checkbox when you were patching your AP file, whether it was checked, whether you left it checked.

My first guess is that the ROM you patched is not the ROM you are running.

There is a slight chance that the ROM you downloaded was tampered with -- where did you get it?

There is a better chance that there was a problem during the download -- did you check the MD5 hashes?

If you used the Magisk manager to patch an AP file there is probably no chance that it patched the boot image using code intended for patching recovery, or vice versa.

There is the danger that you ran Odin but only gave it the patched AP file. I don't know why that is a problem, I only know that John Wu advises against doing that.

I think you should start over. Burn the unpatched ROM. Convince yourself that your device is running well. Then install the Magisk manager app and patch the AP.tar. Read this thread to see if there is a particularly good or particularly bad version of Magisk. Choose accordingly.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mange70k:
Awesome!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bruram:
I follow my previous post of Sept,21, 2023

In these last months all is now running well with Wallet (Google Pay) working

Actual environment:

HWC1 Stock security patch 1March23 (last fw), root with magisk 26.1, Twrp 3.7.0_9.2

Only Magisk Module PlayIntegrityfix 15.9.4 coming from

https://xdaforums.com/t/module-play-integrity-fix-safetynet-fix.4607985/

SafetyNetFix and MagiskHidePropsConfig are NO MORE necessary.

I cannot remember if I flashed Multidisabler to retain bluetooth.

Reset cache memory of ALL the following apps

Google PlayStore

Google Play Services

Google Wallet

Magisk

REBOOT!

Zygisk and DenyList enabled, insert in denylist:

Google PlayStore

Google Wallet

optionally Google Play Services

Magisk left visible (= not hidden)

Results:

In Play Store, settings, Play Protect Certification: device is certified

SafetyNet Check app: all green

RootBeerSample app : Only 4/12 are RED: SU binary, 2nd SU binary check, root via native check, Magisk specific checks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Thabo.:
Hey I'm very new too this stuff and I am wondering if there is a way to install root access on my phone without wiping anything, I've already installed a custom ROM(elite UI 6)and unlocked the OEM and stuff but in the tut I was following they flashed a one UI 6 twrp recovery over the installed twrp( I don't know if what I'm saying is correct I'm still learning) And now I honestly dont know what to do to install the root now

Sent from SM-G970F using ReLabs
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Have you found a thread for the elite UI 6 ROM? Any mention of rooting?

I would expect you to be forced to wipe data to unlock the bootloader, and to turn off encryption. You have already unlocked the bootloader. If you do not have encryption, I would guess that you would not need to wipe.

If you can't find anyone who talks about doing what you want to do, there is a chance that a reasonable attempt could result in you being forced to wipe. Of course, there might be a way to back off, restore the ROM, and not lose data, but I wouldn't bet on it.

When you installed the current ROM, were you forced to wipe?

Are you saying that you already flashed a TWRP over another TWRP? Or that the next step in the tutorial you are following would be to do so, and that that is the point at which you stopped?

Do you have *any* TWRP? (TWRP is not a synonym for "recovery". TWRP is a particular implementation of a recovery. A recovery is a system that provides some (usually limited) access to your device. It is meant as a last resort when the full system won't boot. Your device probably had a recovery before you made any changes.)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Thabo.:
I am sure that the encryption is turned off and the tut made me flash twrp-s10.img(exact file name) onto the recovery partion in the twrp menu. And please may you tell me a way to check if it is encrypted just in case.

Sent from SM-G970F using ReLabs
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Thabo.:
soo basically I'm trying to do what you originally said in the instructions and try to get the custom recovery and magisk to co-exist but I'm not exactly sure how to do that

Sent from SM-G970F using ReLabs
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] lupin57:
"with android 13" ◄• ??? :unsure:

No official A13 for S10 series doesn't exist and never wont exist in anyway !
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bruram:
You are right, i made a typo.

Now I use the stock rom with Magisk 27 with Play Integrity and Twrp. Wallet runs perfectly.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I don't know what you think I "originally said in the instructions".

I was trying to find out whether you really had a TWRP before you installed another TWRP.

You need to read posts from people who have actually done this. I do not know whether you need to install Magisk in recovery.

If you are comfortable flashing, and then reflashing the stock ROM (OK, not stock, but the one you have chosen to use, with no patches), then you can try installing Magisk *not* in recovery. That is the simplest way to have Magisk and TWRP.

In principle (in my head, at least) it is straightforward to make a new APwithTWRP.tar in which "recovery.img" is a renamed copy of TWRP.img. Then have Magisk patch that tar, with Recovery option selected, to produce magisk-patched-APwithTWRP.tar. Then hand that to Odin, along with BL, CP, CSC (or CSC_HOME to maybe flash without being forced to wipe data). Then you should have Magisk injected into the TWRP which is your recovery.

You have to read what other people have done, or try things yourself, or both.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Thabo.:
Thanks, I just have one more question , Can I just patch the boot image and also the ROM dosent have an Ap, bl and others , it just has the system.img, vendor.img and the rest

Sent from SM-G970F using ReLabs
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Clearly I am confused. I thought you had a Samsung device, and I thought you used Odin to flash. And I thought Samsung ROMs were always a set of four tar files.

You can't say "and the rest". Just how many files did you download when you downloaded this ROM? How do you flash them?

I can't tell you whether you can "just patch the boot image". I tried to make it clear that I don't know, and that you need to read, or experiment, or both.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] pndwal:
I'm NOT a Samsung user, but:

If you mean boot.img, then NO... The point of this thread and OP is that you need to patch/flash recovery.img (although that is actually a boot image too) to achieve root in S10 series (and many other Sammy and other A-only legacy SAR) devices (all being devices launched with Android 9)... You'll also need to boot via special key combination...

Regarding your original question about whether you can root without "wiping anything", generally the answer is No also, but having already installed a custom ROM you may be possibly able to do so... Nb. that you need to understand the risks, especially that vaultkeeper may re-lock your device thus bricking it (possibly 'hard' bricking) if it isn't properly disabled/removed by custom ROM installation or you fail to observe cautious in instructions...

Read the OP here and official instructions linked and don't do anything if you don't properly understand the process (or risks) first. 👀 PW
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dan.dior:
Hello, I and others have the same experience, that after the Root descriptions with actual magisk patched TWRP and AP it is unrooted after custom (beyond f.e.) Rom install.

May it be, that there was an backdoor update in the last half year? Is some Magisk or TWRP, or FW version now problematic?

Even my one year ago rooted G973F is now not rooted anymore...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] pndwal:
What's 'f.e.'?... I don't think S10 series had 'Fan Edition'! 🤔

Doubt 'backdoor', but there are always regressions, especially in Magisk with the amount of refactoring going on in the last few years. Also, addon.d has needed a few fixes (for preserving root thru custom LOS etc updates)...

Some Magisk regressions include issues with updating images patched with old methods and have left devices unrooted after taking Direct Install to update (due to patched boot images becoming incompatible with later updates)... Usually performing initial installation again (patching unpatched/stock boot image and Flashing or, if using .zip package, taking Uninstall Magisk, Restore images, first) allows Magisk to update properly...

Sometimes Magisk configuration files can become corrupted or incompatible too... These issues are fixed simply by deleting /data/adb/magisk.db file and /data/adb/magisk directory contents and rebooting... Magisk configuration files will be rebuilt (modules will persist, but need to set up superuser apps, denylist etc fresh; alternatively, deleting everything in /data/adb will remove all configuration data incl. modules...

Hope info helps... 🤠 PW
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dan.dior:
The problem is to solve on the new phone, with complete new flash/root procedure.

Magisk 25xx seems to be as well unable.

If a complete earase with new partitioning is possible can be one helpful thing, even it does not solve the problem, what goes wrong. (I hope an optional anti root patch of the last FW update can be deleted through this)

But just G973F + Magisk (canary...+) insider facts please.

f.e. = for example
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
What did you do?

What did you then see?

Which Magisk was working?

Did you hide that Magisk?

Did your device get updated? (From what to what?)

I couldn't understand "that after the Root descriptions with actual magisk patched TWRP and AP it is unrooted after custom (beyond f.e.) Rom install."

Did you use Magisk to patch both TWRP and AP? Did you have Recovery option checked for both? Did you install TWRP first? Did you use Odin to install AP?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] pndwal:
Are you taking about standard (official method) flash to /recovery, or patching TWRP and/or Magisk injection in/with a custom kernel??

... Again, are you using a custom ROM/kernel??...

If not up to date, kernel is likely the issue due to 2SI magiskinit injection refactoring in Magisk 25+ as custom Kernels often used to opportunistically rely on Magisk stripping AVB flags and keys from vbmeta... That's no longer done as fstab is no longer patched and kernel Devs have had to start fixing verity/verification issues properly.

S10 series custom kernel users are able to use Magisk 27.0 if kernel is up to date... 27.0 and 26.x still contains some regressions (some are fixed in 27002) so some have mentioned needing to flash a 25.x version (suggest 25.1) before updating to 27.0.

Oh...

English convention uses Latin abbreviations... For example is actually E.g., "exempli gratia"...

Mind you, I was encouraged not to use such abbreviations here after correctly using N.B. ("nota bene"), note well, because many don't understand the convention, however, I persist. 🙃

🤠 PW
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dan.dior:
To the last two answers AIO:

I used the old standard way... I patched with installed magisk(v27) canary the TWRP (3.7..) and the AP and put the Twrp as recovery image in the AP. Once I tried to flash just the patched AP.

But all leads to no root anymore. I do not know the reason, but I did believe something blocked it.

Now I erased everything in TWRP and flashed with pit and new partition table to get it clean.

But I found a new description with maybe own kernel, that seems to be functional with every StockROM. The custom is as well rooted after.

It builds as well on TWRP and Magisk(v26)

There are the data in the subsciption.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] pndwal:
So stock ROM, Stock kernel?... Always patching with Recovery mode selected?... And booting via recovery key combo?...

Does the method work with clean AP (no TWRP injected)?... (Really need TWRP anyway?)

Have you tried with latest Canary 27002 (in case something got fixed already)?... 🙃 PW
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
This is so pissing me off. Everything went smooth until my final boot but the 3 button combo into recovery wouldn't do anything. Is there another combo for the final boot for the S10+?

Edit: this is where I am now :(

What button combo powers off the phone so I can try getting back into download mode?

Should I just flash back to stock in odin to start over? Using all the usual fields?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rameshkotibani:
When i revert back to stock or unroot,the bootloader splash screen appears or not bro :confused::confused::confused:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jimbo77:
Just connect to odin it will work from that screen. Flash just the AP boot, setup and you can start over.

---------- Post added at 06:16 PM ---------- Previous post was at 06:14 PM ----------

Because the Bootloader unlock status does not change based on the system installed. You'll need to relock the Bootloader for that message to dissappear
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
Thanks, You mean the AP I extracted from the beginning, not the magisk patched one?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jimbo77:
Correct. Stock AP, let it boot. Setup quickly check for EOM unlock available and then start over with Magisk or twrp
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
Thanks, God I hope that works. Untick auto reboot or leave it?

Edit: You saved me. Thanks so much. It just ruins my day when these things happen.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DamonSH:
10 Plus

I have a 10 Plus from T-Mobile .. and I have the JUMP plan which allows me to get a new phone every year. My question/concern is .. When I return the phone or need to do a warranty exchange with them. will they see that my phone has been unlocked and Ill have issues? Has anyone been in the scenario? or have any information on how the carriers deal with unlocked phones that they receive back and what impact that may have.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
Ok, I'm at the final boot again and my 3 button combo (power + bixby + volume up) does nothing. The Reboot system now just highlights in green but wont reboot.

Any ideas?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Do you mean with final boot the reboot that magisk manager initiate?

That reboot it handles itself,.don't touch any keys on that one.

All other reboots you need to hold the keys, but not the one magisk manager wants to do the first time you let it make it's changes.

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
The last boot after you odin the magisk_patched.tar then reboot to recovery, then Wipe data/factory reset to wipe the data of the device, then this part wont work "Select Reboot system now, and immediately press Power + Bixby + Volume Up. After seeing the bootloader warning screen, release all buttons so it can boot to the system."
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
That usually happens if you after stock flash didn't go thru the setup and activated development options. Did you do that?

It's important so vaultkeeperd knows it's suppose to allow the tar to be accepted in the next step.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
I did.

So my question next would be, if I was successful until that last boot into recovery (from recovery) and was only able to boot normally, could I restart again this way per the op:

All words in summary, after installing Magisk:

(Powering up normally) → (System with no Magisk)

(Power + Bixby + Volume Up) → (Bootloader warning) → (Release all buttons) → (System with Magisk) to have root?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
The update just hit me. Anyone on this thread know if it's gonna screw the setup if allowing this update to install? Or if one needs to flash all stock again, let it update, make a new magisk tar, and do the whole process again?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
So I figured out my issue in case it helps anyone else with a S10+

After you flash the magisk_patched.tar in odin, then boot into recovery where you do a factory wipe, then reboot system using the 3 button combo (nothing was happening),

I tried the steps used to go from download to recovery, i.e., Press Power + Volume Down to exit download mode, and as soon as the screen turns off, immediately press Power + Bixby + Volume Up to boot to recovery partition

That allowed me to boot to the system with Magisk.

4th x's a charm!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] chronzz:
i got the same update? is it safe to update?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vonDubenshire:
Sadly no but I am hoping someone figures something out.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] chronzz:
i updated it and its working fine.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
Is it safe to update Magisk through the app (see attachment)?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rafalubo:
Yes

View attachment 4741031
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] the_dealer:
I have a g970u, any chance I'd get root?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
Didn't the instructions say to do this already ? Because I am getting also an s10+ So I am curious why the button combination would be different.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] chronzz:
no
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jam51dill:
I don't get it, I know people say it doesn't work for any Snapdragon but on the instruction page, it says "Your device must also have an unlockable bootloader, which means in practice that all Exynos devices are supported, whilst those manufactured for the Northern American market (with Snapdragon SOCs), are not."

Meaning that all you need is an unlocked bootloader. Also North American markets is a no. The HK Snapdragon is unlocked bootloader and not in the North America, so it should work right? I tried and I couldn't boot to recovery after flashing file in Odin.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ChrisChristian:
For this work root i am unloked
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
It was made for Exynos processor phones that are unlocked. In theory if you rewrote the program to work with the snapdragon kernel then it would work but the files that johnwu wrote are for Exynos processors since in Taiwan they use Exynos.

---------- Post added at 05:32 AM ---------- Previous post was at 05:30 AM ----------

Because the the patching software only works with Exynos processors.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mcn1970:
any idea how to make Samsung Apps working? tried to magisk hide but i cannot find it in the list.

heard that a fingerprint update is available thru Galaxy Apps
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
This is not correct. John has personally confirmed to me that this rooting process works for any device with an unlocked bootloader, including Snapdragon models.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ChrisChristian:
is true goes. and for my model? Sm-g9700?:silly:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tsoureki:
Great news but we need instructions! Rooted unlocked S10 Snapdragon will be perfect! I am ready to donate John for his hard work.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
You have instructions. As I said, this rooting process also works for Snapdragon models with an unlocked bootloader, so simply follow the same process.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] wheelswisk:
keeping root. after reboot?

why Is magisk root lost after reboot? tnx
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Did you hold the key combo when you rebooted?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dr4go:
May I ask which version(s) regarding riru and edxposed you're using?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NisseGurra:
Looking at the instruction page:

"Samsung

Note: This guide is ONLY for Samsung devices launched with Android Pie (9.0) pre-installed, which currently includes the S10 series and A50. If you have an older device, please follow the general installation guide. Your device must also have an unlockable bootloader, which means in practice that all Exynos devices are supported, whilst those manufactured for the Northern American market (with Snapdragon SOCs), are not."

So anyone with snapdragon actually managed to get root?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
[/COLOR]

that is great so the SM-9750 from china and Hong Kong that is unlocked bootloader should work fine even though it is on snapdragon.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ChrisChristian:
tomorrow I try lool;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mcn1970:
how should I make galaxy store working? is magisk hidden and i also hide magisk manager. s10+ rooted
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] manojl76:
Galaxy store works without any problem at least for me s10+ rooted
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ndaoud360:
That's what I'm saying, root should work on HK but I can't boot to recovery after flashing and just tried yesterday.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
When you are at one of the last steps in recovery, after factory reset, instructions are to press power + bixby + volume up to reboot into system. That combo wouldn't boot my phone, so I tried Press Power + Volume Down first, and as soon as the screen turns off, immediately press Power + Bixby + Volume Up. That's what worked for me.

You'll see if you look closely at the instructions (or watch the video).
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] darksimo:
topjohnwu, : HI, thks for your great work, everything go on for me, root: ok, magisk: ok, and no bugs !
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
Cool are you making a video?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
I was referring to this one: https://www.youtube.com/watch?v=o3a8YnWT3yk&feature=youtu.be