yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
I did all the steps correct, I am sure.

After the successful flash, I held power+bixby+volup to reboot rooted. The first time the phone rebooted twice which is normal.

When booted it was booted without root. I said to myself that may be I didn't manage to keep the button combo well enough and rebooted again.

But what I have now is that even if i hold the combo for a split second, the phone boots to recovery.

If I reboot to system from recovery or if I boot from a powered off state without holding the button combo, the phone boots to system and all my data and setting are there and everything is normal.

But if I press the button combo even for a moment at any time during the start of the boot it will only go to recovery

Does anyone have an idea?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Pharraon:
They need to stop putting exynos devices we need snapdragons not the exynos everyone knows exynos is easy to root
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PingPawan:
I have this problem. Additionally, if rebooted normally, root is missing!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Garock:
just noticed that after being rooted you can no longer charge the phone while powered off

every time you plug power the phone will automatically turn on

will I be in trouble if somehow got the battery completely drained, or the phone will charge just fine?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mercifool:
It will charge fine. My battery was at complete 0.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Garock:
awesome thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
When I first rooted my S10, I was so excited I couldn't put it down consequently the battery went down and the phone powered off. As soon as I put it on to a charger it powered up automatically and the root was still there with no buttons pressed. Even if you manually power off with the power button while it is rooted, it will automatically reboot on its own into root mode as soon as it connected to a charger. Very useful.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Edit

It was a badly patched AP. I repeated the patch and it was OK. Then I binary compared the files in the 2 patched Ap sets. Exactly the recovery image was the one that showed difference in the 2 patched ones. It felt like there was no Magisk in that recovery partition.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] WookieLance:
I think I need to say this..

From my readings around the place, doing anything to any partition triggers Knox.

Knox cannot be reversed the damage is permanent to your device no service which relies on explicitly of the Knox signatures and or services will continue to function, this means no more Samsung pay, Samsung Vault app thingy and any other Knox API reliant application. It is one of the first questions I asked before proceeding if I should care about Root/ Magisk on the S10

as I only wanted Root to install BusyBox and LuckyPatcher again and disable system apps.

Solved the issue of the last one, by using Adhell3 and thankfully via ADB we can remove system apps and bloat w/o root.

Also, be there a warning to Australian residents who lease their device like myself, without restoring to factory settings and clearing Magisk partitions data etc, you may be faced with upfront fees on device return, not saying that they are going to check software level tampering but you do have to hand the device back in working order and system modifications such as this are in breach of your lease contract terms if you do no buyout the device at the end of the lease period for its market value.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
I am glad I live in a country were Samsung doesn't care about software breaking rules ( breaking knox) and they only care about hardware tampering.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] WookieLance:
Unfortunately, form my findings, Knox has had this Root issue since S8/S9 Devices.

As for tampering... specifically, it is the phone company Telstra which is our only "actual" company in the nation they hold a monopoly over telcoms as they own the under ocean cables leading out of the country and most of the cable laid in the country.

Don't ask me why.. the gov was stupid enough to sell them exclusive rights to all this in exchange for doing all the national work.

Cough, don't ask me why they also sold land to China instead of rent it. Our Government is more about getting things done cheaply and fast less about the future it seems still not as ****ed some others but the stupidity is up there at times.

Bright side is, Knox is a low-level running service Adhell makes use of this as I can see when I built the APK for it, as Adhell3 can disable system apps without root when I figure out how it able to do this and my money is in the jar which reads "Knox can perform root access commands and access root partitions." I will prob use the Knox SDK and make a basic system debloat app whereby you just tick the **** you want disabled or removed, backed up and so it be done rootless. I am still sad I get no LuckyPatcher until a solution is found for Knox and bricking devices as I am not willing to risk it while Magisk is this early stage of device modification.

I loved my luckypatcher I guess I can still do it, I have a Sony Z5 rooted of course, modded up the wazzoo that I stripped down simply to use as a backup device.

So I am not completely ****ed, I can make my APK mods with that device then install the hacked APK onto my S10.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Anyone have problem with samsung cloud, "couldnt authenticate samsung account?" I got another message stating the phone is rooted and now i cant back up on samsung cloud

EDIT: Patched firmware corrupted. made a new one . now its all fine and dandy
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Just backed up and I am Magisk rooted.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] mcn1970:
i did those steps but I am stuck with Starting Android screen
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 93ae8074:
This exists already, mate. Check Package Disabler Pro+ (Samsung) for and example of these apps.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kp.nikhil:
how did you fix this??
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
Sounds like corrupted firmware.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] viridite:
Hi there. I've got a problem that there's once I booted without using the combo as the phone system crashed. Then next reboot with the combo will stuck at the SKTelecom logo and then reboot. I can only boot without root access and each time I boot to recovery for root will lead to restart.... How shall I fix it?

---------- Post added at 01:11 AM ---------- Previous post was at 01:05 AM ----------

Me too. I can only boot without root... I don't know how to deal with it.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kp.nikhil:
yeah probably a bad patch.. I repatched the firmware with another phone and tried it with Odin and it worked fine
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] IsocolXDA:
Unfortunately I didn't find a way to fix this. Had to flash asd5 stock firmware then root.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] viridite:
This doesn't work. I tried twice.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
I'm having some issues with google play store and swift installer. Can I reflash any files in Odin to clean up?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
Your patch file that you made is corrupted. Transfer over the original AP and patch again
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] WookieLance:
Oh nice. well currently I am using Adhell3 (yea I am the same guy who posted and compiled it for S10)

it can disable packages aswell, debloating tho does not need root or an app really ADB commands will get rid of it.

The app is a nice way to go about it, I was going to make one tho, depending on what the others offer, as I want a simple package which just lists of bunch of tick boxes for stuff you can do with ADB, like Bixby tick that and boom all of Bixby gone except for that one service which you will want to keep as it retains the barcode scanning function in the stock camera app.

Likewise oh you want to hide/rehide status icons no worries just tick them and they are gone. Very simple app really just runs ADB commands and re-applies ADB commands on boot.

I know I can just an automated ADB app but honestly I rather just make the app with the stuff I am going use.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Hi,

Is it theming you want to achieve ?

If so have you tried Substratum, works perfectly.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
I was fine for a while but also installed Wings fonts that is theme based and it may have caused conflicts. I've been using swift installer and the updates were failing. I went to uninstall swift to then reinstall it for troubleshooting, but my play store won't open (keeps stopping). Now I can't even reinstall swift installer.

I was thinking to reflash firmware with a patched AP that may clean things out.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Unless you've got a backup of your Play Store (Titanium or whatever), from which you could restore, I think reflashing your AP is your best option.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
Thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
@ianmacd i have confirmed today that Snapdragon SM-G9750 , 9730 , 9740 (Factory unlocked Hong Kong , China Factory Unlocked) can not work with Magisk main issue is Step #9 when attempting to go into stock Recovery after you have flashed Magisk patched .tar none of the button combinations work. so the person on Github who said they got it working was lying . we have made an issue on Github but haven't gotten a response and its been a few days.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ChrisChristian:
I think it will not solve the problem :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] vibrantliker:
Would it be recommended updating to this firmware([ASD5] OFFICIAL STOCK FW-update (Odin) thread (18 Apr 19) GALAXY S10+ SM-G975F/DS) ?

I would just need to patch the AP file and flash that with the others in the update, correct?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Patched the firmware first, then place patched ap into odin
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
And replace csc with csc_home so you don't loose your data
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Fznwolf:
Great news everyone. [MENTION=4470081]topjohnwu[/MENTION] has modified a file in the magisk source, specifically init.cpp.

See the proposed changes here: https://github.com/topjohnwu/Magisk/...c29ac78327c87c

He added the following note: "This should in theory should support more devices for detecting the

volume up press on boot."

This will have to be complied into an apk and tested again. I've tried compiling the new source, however my canary build (which it wants) is breaking when making the apk.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
Last night, I used Magisk Manager to patch the AP file from the ASD5 firmware. This is actually the first time I have upgraded in this way, and I must say that John has made life extremely easy for all of us.

I just wanted to give a tip for anyone who is already running TWRP on their device at the time they need to update their firmware.

Using John's procedure, you'll have to enter download mode a second time to re-install TWRP and re-disable encryption. Since I screw up getting into download mode once in a while, I find it a nerve-racking experience, since failing to boot into download mode at this juncture could initiate a system reboot that would re-encrypt /data.

So, before you flash the patched AP, you can make a copy of your existing Magisk-rooted TWRP recovery. For example, a quick way to do it is by typing this in a root shell:

# dd if=/dev/block/sda15 of=recovery.img

Next, replace the stock recovery image in the AP file that you patched using Magisk Manager. On Linux, that would look something like this. Adapt these commands for whichever platform you use.

$ tar f magisk_patched.tar --delete recovery.img
$ tar rf magisk_patched.tar recovery.img

Now, when you flash the resulting file in Odin and reboot, all you have to do is hold the recovery combo down until you reach TWRP. Then, simply disable encryption again (e.g. by flashing my own multidisabler zip) and reboot.

I followed the above procedure myself last night and it worked like a charm.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
That's what I did yesterday having the same thaughts. And thanks posting it.

I just want to add that if one has been with recovery before and already has a TWRP data backup, they can restore it. Provided that they have finished the whole process, have recovery again and have formatted data plus fkahsed the multi disabler they can restore the TWRP data backup that they had.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] psyafter:
restoring data in twrp will restore settings, system apps' data and user apps with all data/settings?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Yes

If you're using the same ROM you can restore the data TWRP backup made for it

And it will restore all your settings, user apps, apps data, system settings and system app data/settings. Basically everything
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] psyafter:
did you find the fix? same here, only unrooted or stuck on samsung logo when booting to magisk (and the only way to boot unrooted is vol.up+bixby+power and continue vol.up like for recovery option)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] viridite:
I flashed back to stock and patched the twrp to AP and use odin to flash again. Then everytime it boots to twrp instead of getting to system. Then I just rooted the phone without twrp.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Restart your phone, using power button and selecting Restart and the phone will boot into standard system non rooted mode. Some root reliant apps might run but will not be fully functional. Power off and connect to charger and you will have your charge percentage and green line back - the phone will not auto boot.

Ofcourse if and when you want to go back to Magisk rooted mode, you will need to boot with the 3 button combo.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] veso266:
Thanks

but why it will auto start if in Magisk mode and is it possible to disable that?

BTW: how can I check Knox status, I tried every app and everything reports 0x0? apps are probably broken (Phone Info and Samsung Knox Info)

[IMG="Phone Info"]http:shrani.si/f/38/dr/BpYfr2h/1/screenshot20190422-19382.jpg[/IMG]

[IMG="Samsung Knox Warrenty"]http:shrani.si/f/2j/kK/2oyYstCM/2/screenshot20190422-19412.jpg[/IMG]
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hiroo Onoda:
Let me start my first post with a huge thanks to the creator of Magisk and all those here posting helpful stuff. You guys are awesome!

Is there really no quicker way to do that? Came from a rooted S6 and never had this issue. Anyone know what is causing this?

On another note, I really don't get what is meant by non-rooted mode. Say I cold boot my phone without pressing power+bixby+vol up, I conceive no difference compared to booting into Magisk. For example, I'd expect from non rooted mode that I wouldn't be able to change firewall rules in AFWall+, but it works. So does any other root app. Bluetooth pairings do stick, too. What gives?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
I have edited my previous comment as I have discovered powering off completely then restarting by just pressing power button retained the rooted mode.

In non rooted mode some root reliant apps may run but not be fully functional.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] lupin57:
Till u dont flash a custom recovery ... knox remains to 0x0 :)

Ur screens are correct regarding this parameter ^^
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
After first rooting my S10 Plus I got same result as you, but after about a week I checked and got warranty void. What tripped this change I don't know, but it is now correct. In simple terms as soon as you unlock the bootloader and flash anything with Odin your warranty is void, 0x1 .
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
As soon as you unlock the bootloader and flash the Magisk_patched file (equivalent to a custom rom), your Knox status will be permanently changed to Warranty Void 0x1
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
The real question is do you live in a country were Samsung cares about software tampering or do they only care about the hardware warranty.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Certainly care in my country, UK. Refused warranty repair on my S8 Plus when had screen burn-in problem. :(
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
That does suck. I think only Asian countries have the hardware repair warranty seal and not care about software because I know here in china it is like that. Hehe the workers at Samsung help me root my first Samsung phone back in 2010
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 93ae8074:
Most Europe is like that, too.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Norup58:
No, this is not correct in regards to EU countries. Please read following link which explains the root issue in EU countries:

https://www.piana.eu/root/
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] leviiis:
I have checked also bei Knox Status and it shows me also 0x0 and my phone is rooted since beginning of Magisk for s10. I also have update to the newest firmware with Magisk. It is really nice, but I don't understand it. ?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Duncan1982:
It's fake Knox to make it look like it's official, however you Knox counter is actually 1x0 or 0x1 however it's written lol. Meaning yes it has been tripped and you will no longer be able to receive ota's.

It's an illusion.......:p
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 93ae8074:
Yes, exactly what I tried to say. My bad it was not clear. I was surprised after moving down under that here is not the case any more.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
l have magisk and my knox is still 0×0 and was kinda of surprised to see it that way. l rooted the second day johnwu released the rooting file..

---------- Post added at 01:03 PM ---------- Previous post was at 12:58 PM ----------

[MENTION=3926910]viridite[/MENTION]: do you still have twrp after you rooted this way?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] viridite:
No. I think I did something wrong so if I have twrp it will always boot to twrp instead of the system.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
What did you flash specifically?

/P
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] domi994:
I can't find OEM unclocked after getting Dev options on
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] veso266:
I think you have to wait a week before that option becomes uvailable

did anyone figure out how to get charge boot animation back?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NisseGurra:
Enable wifi/data

Reboot
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] corepda:
Anyone facing freeze or system ui force close? I am on asca and it keeps freezing randomly and also giving me close or wait dialogue. Very annoying.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] anonymous-_:
Use Samfirm tool or Updato site :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Nextasy:
Just a question: installing magisk will trip knox, right? Is it possible to install root without tripping knox, l mean for guys that just want to have root access and not necessarily want to install custom rom?

Cheers
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DaReDeViL:
Hehehe. Seems like even an idiot like me can still follow simple instructions :p

Seriously, I didn't have to do anything special. Just did it Wu's Way ... :good:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rp4k:
For everyone who says the button combination isn't working for them please remember johnwu is using and testing only on a s10+ . So the button combination might be different

---------- Post added at 12:56 PM ---------- Previous post was at 12:55 PM ----------

I am more worried about what we will will have to do every month when Samsung pushes updates
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SoLdieR9312:
The problem is, that every S10 user i talked with is not able to do the button combo.

And even adb reboot recovery, which should reboot to rooted system (which is working fine on s10+ and s10e) isn't working on our S10.

And i'm not too stupid to follow instructions, i would not even need them, because i run twrp with magisk already since 2 weeks.

(And yes, i also tried the patched AP file stock recovery with magisk, same issue there. So its not the twrp build that got not patched correctly)

---------- Post added at 02:02 PM ---------- Previous post was at 02:01 PM ----------

I also checked the Generic.kl file for my bixby remap, Buttons are the same.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DaReDeViL:
You still have to wait for the master's instructions to fix it but I will give a tip for all not stupid instructions followers : the combo works for me when initiated with powered off device but fails when done upon reboot ...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] SoLdieR9312:
Thats what i never tested, i always rebooted. God damn. Thanks for the tip, i will check that later when anyone else can confirm ;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Samfirm it says is deprecated, and on updato the speed is 15kb :rolleyes:

Can someone please post a good link, i have the Italian version.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] DaReDeViL:
Fingers crossed...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] degsyh:
Yes Samfirm is deprecated but it still works
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PiCkLeS:
Download the samfirm app anyway, works fine. I just downloaded the firmware.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Ok i'm using samfirm, i have updated it with the visual thing he needed. I inserted manually these informations here but it doesn't work https://updato.com/firmware-archive-select-model?record=90778D6E472411E99F15FA163EE8F90B it says it could not send the Binaryinform.

I've tried the Spain version but same error :/
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Norup58:
You could try Frija if your are on Windows:

https://xdaforums.com/s10-plus/how-to/tool-frija-samsung-firmware-downloader-t3910594
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] xRedDroidx:
Thanks man it works, it's also super fast.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kloosgj:
So after checking XDA for an update every 30 minutes, it finally happened.. Amazing work, John!!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
All modification on boot.- and recovery.img are triggers knox. There is no way to of nontriggering. Maybe with an engineering bootloader. But ive never saw one after a galaxy s6 with android. 5.1.1