yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
This worked great for me. I patched TWRP anyway, because I needed to boot into Android to flash stock recovery. Also, I didn't do steps 1-5, but instead put the recovery.img in the magisk_patched.tar. I didn't want to use Odin and only the recovery, fearing it might shrink my data partition. I also flashed corsicanu's bootlogo patcher.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 1jkan:
I installed A11, did root and TWRP. However, I have a problem. Tap 2 to wake screen does not work for me. The latter option works, i.e. Tap 2 to lock. To unlock I have to press the Power button or unlock with a fingerprint. It's inconvenient. After all, it worked on the A10
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ireas:
I'm currently trying to install TWRP so I can install the Pixel Experience ROM.

Seemed ok at first and got into TWRP but all folder on the SD seemed to be encrypted? How are you supped to bypass that?

I installed TWRP through the official app after getting root via Magisk
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Did you patch the TWRP with Magisk beforehand?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ireas:
Yesn't.

This was my 2nd attempt, I patched it, tried flashed it via Odin but it Odin got stuck :D - had to cancel, got to Emergency Recovery Mode, so I completely wiped the phone via Odin and currently am trying to flash it via root

su
dd if=/sdcard/twrp.img of=/dev/block/platform/13d60000.ufs/by-name/recovery

EDIT: that method seems to work. just adb pushed multidisabler inside recovery and flashed it afterwards
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I patch the * .img with Magisk and copy it to the SD card. (twrp-3.5.0_9-1-beyond1lte_magisk_patched) Then I flash it with Flashify from the playstore. Then the whole process in TWRP> Format Data etc. Your firmware must have root rights beforehand.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ireas:
Cheers, that seems to be basically the same as the shell approach that worked without flashify and patching magisk on it (well no magisk now but seems to work nonetheless, the devices that was flashed doesn't need root)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Did you stop having encrypted files on the SD when you installed the second time?

When you said "SD", did you mean the fake SD internal storage, or the real SD external storage?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ireas:
Yes and yes - the internal storage :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ireas:
Wrong thread
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jbigs69:
I have a Verizon United States Galaxy S10. If I root my device, is it possible to enable the call and text on other devices feature?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fseuz:
Hello, my Galaxy S10 suddenly stopped booting properly - it gets stuck on the animated Samsung logo.

I can:

1. press "Power + volume down" to restart, then

2. "Power + volume up" to enter recovery mode and then

3. select "Reboot manually" - this way I can sucesfully boot, but only without root!

Pressing "Power + volume up + bixby" after restarting get me stuck on the Samsung logo. Same if I don't press anything after restart.

Any advice how to fix this (and boot as root)? I can get to the recovery menu but not sure which option to try so I don't mess up my system..
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Did you do something on your cell phone that suddenly doesn't boot anymore? Magisk updated with no new kernel, new kernel, etc.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fseuz:
Actually I have installed new Magisk Manager (have 8.0.7 now) and also some other apps, but nothing with kernel..
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Try to flash the TWRP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fseuz:
You mean I should do steps 4-10 from this guide? https://www.thecustomdroid.com/samsung-galaxy-s10-root-guide/ (see Table of Contents)

Download latest Firmware Package, patch it with magisk manager, flash in with odin?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MarioKempes:
It worked for me that way. Take care to use Magisk 21.4
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] fseuz:
You had the same problem (stuck on Samsung logo on boot) and fixed it?

BTW, there's also an option in the Magisk manager to install Magisk (latest 21.4), should I try that?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MarioKempes:
Nope, I didn't got stuck.

Go for Magisk 21.4 - it supports Android 11
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
i can't patch AP file by EUA4 firmware.

It show me: Process failed
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Who Says the Process Failed?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MarioKempes:
Did you patch the AP-file with Magisk 21.4?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] asustitan:
Anyone got root working with the AP Patch method on Android 11 without TWRP?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MarioKempes:
Yes, worked like a charm
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
No all ok... just did it

my fault
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] asustitan:
What device you got? I have G973F.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I had it (before a suitable kernel came) and it worked perfectly.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] MarioKempes:
G970F
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
I noted that when i reboot phone with combination keys... i lose root
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] eksa78:
I have the same issue, root is enabled after flashing with Odin and completing the steps in Magisk for initial start of the phone. But once i restart the phone, root is lost. Tried to boot both with bixby+vol up+power and without any keys pressed, still no root. This is the first time i'm trying to root, so maybe i do something wrong... Running S10 with Android 11 and latest Magisk. Any ideas how to return root?

If i restart the phone from Magisk (reboot to recovery option), then phone starts rooted
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dr4go:
Please read a bit guys... If you are on Android 11 you have to attach the usb cable and press the combination keys, otherwise it won't work. That is something Samsung has changed on their end in sboot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Even when not Android 11, what you describe is plausible. (Except I'm not sure what it is to "reboot phone with combination keys".)

The original instructions warned that, when installing Magisk into recovery, if you reboot, you are not running Magisk. You have to boot towards recovery to activate Magisk.

In practice, I found that once I had Magisk working, I could shut down the tablet and reboot, and I would still have Magisk running. There are two options when you hold the power button: Shut down, and Reboot. If you use Reboot, the tablet comes up without Magisk. Then you have to repeat the dance to get just close enough to recovery mode to activate Magisk.

I never read whether Wu improved his code, or Google or Samsung changed something, making Magisk survive a shutdown followed by boot.

And finally, I have a SM-T290. Maybe nothing I know applies to you.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
Maybe i found a solution... try to boot phone with usb-c cable inserted and vol up+bixby+power button pressed togheter
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Rubbydubby:
Dear all,

before I ask my question(s) I apologize if these were already discussed here. I screened the last week for a solution but have not been successfull.... Maybe you could help me?

1. I successfully rooted my S10+ 1TB with Magisk. After I reinstalled a lot of my apps I got a message that the memory is nearly full and discovered, that the phone was "restricted to" (or showed) 32GB only. I restored it with factory reset and started from scratch. Before flashing the patched AP-File: 1TB, after flashing and booting: (even before updating Magisk) 32 GB....

Is that a known problem and is there a work around or solution?

I used the latest Magisk from github and set the "beta" option. Also I tried several ways to copy the files - SD-Card and also via adb.

2. The patched file is never named magisk_patched.tar, but always magisk_patched_*****.tar with changing letter combinations if created new. Is that a problem (or pointing at one)?

3. Is my way an old and no longer working way to root the SM-G975F/DS 1TB? I read that some of you were successfull with TWRP, but I have not checked this way till now. As I first wanted to find out where my problem is. Also currently I can reset the phone to use an unrooted 1TB version. Not sure if this also works with an alternative way.

Thanks for any helpful information! And sorry for my beginner's questions...

Best,

Rubbydubby
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
You need to read much more than one week of posts.

The Magisk Install instructions talk about the data partition possibly being shrunk if you use the wrong combination of files when running Odin. Is /data where you start with 1TB?

The goofy suffix on magisk_patched.tar is a relatively recent innovation, but much older than one week.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
I confirm that method works.

The phone always boot in recovery (so it rooted) if turned on with keys combination but with something plugged in the usb. It can be cable, headset or simply a adaptor
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Rubbydubby:
Thanks for your answer!

Sorry, my english is not the best... I meant I tried to find a solution during the last week, not that I only had a look at the last week's posts.

In Odin I used all files everytime (BL, patched, CSC, CP) and only unchecked the reboot option. Also I updated the phone before flashing/rooting and downloaded the latest firmware to patch, the information on the phone confirms (if this can be taken as a confirmation).

The memory shrunk problem was discussed in some other posts, but in combination with TWRP, that's why I asked if the flashing with "only installing Magisk and using bixby+vol up+power everytime" might be outdated.

What do you mean with "is /data where you start with 1Tb"? If the 'clean' mobile has something stored in this folder?

Thanks a lot advance!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I don't patch anything anymore. An

unpatched

TWRP on the stock rom according to these instructions and a custom kernel afterwards - done.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I am so boggled at the idea of 1TB on a phone I wanted to make sure where it is: Is /data 1TB? Or do you have an extra disk attached to the phone?

The Magisk installation instructions do not address TWRP, and they do warn that some misuse of Odin can magically shrink the data partition. It never happened to me, and I don't understand why it would happen, I was just pointing it out as something for you to read.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Rubbydubby:
No, it's 1TB without my card. I used it one time (512GB) and thought, it might be the card. So I did the whole without card again.

I only used the magisk installation. No extra patch, no other file upload, no twrp. Just as explained. (Install magisk, patch original file (don't used mtp as it may corrupt files, so in the try after the replacement of the card I transferred via adb back and forth), upload via odin and boot with bixby-volup-power).

Internal storage afterwards: 32GB.

Before and after updating magisk in the final step.

Any idea would really be appreciated! Thanks a lot!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I'm still not following. You have 1TB with no external SD card? You have an external card that's 512GB?

The note I'm remembering about the data partition getting shrunk was a warning,

Magisk Install instructions

You should ask about this in the main Magisk thread. And maybe report it on Github (post logs).
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
Which custom kernel are you using? Is it working well for you?

Regarding the USB connection thing to boot to recovery: I mostly don't need it for some reason. Only sometimes I can't cold boot to patched Android using just the key combination, but mostly it works.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Rubbydubby:
Correct: 1 Tb internal storage (plus additional external SD-Card 512 Gb).

I started a request at Magisk on github. Let's see if they find some time to care for it. Thanks a lot! Concerning the installation process: I did exactly like described (at least I think so...). Also always uploaded all 4 needed files.

Still: if somebody has an ideas, feel free to share it with me!

Best regards,

Rubbydubby
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I take this ThunderStorms-Kernel-Q / R-v1.7: 02/01/2021

Downloads for : Samsung Galaxy S10 (SM-G973F) | AndroidFileHost.com | Download GApps, Roms, Kernels, Themes, Firmware and more. Free file hosting for all Android developers.

Download GApps, Roms, Kernels, Themes, Firmware, and more. Free file hosting for all Android developers.

androidfilehost.com
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Harvie Almighty:
Is it possible to root stock fw by flashing twrp thru odin
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
No, you need to patch and flash the AP file as well. Read the official instructions linked in the OP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Enddo:
so is the latest method the same as before?

working with android 11 as a base.

do i just need to patch the AP firmware file with magisk manager and flash it with odin?

or do I need to also flash a vbmeta file as well?

and then when i want to boot with magisk loaded, i just need the button combo with something plugged into the usb port?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
You can patch the AP with Magisk and then flash the four parts with Odin - then you have root rights. But you can also flash TWRP on the stock rom according to these instructions and take a custom kernel - then you also have root rights.

Do not patch TWRP and vbmeta! - the kernel is patched.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Enddo:
I figured I could tackle TWRP later. I'm just looking for simple root access. thanks for the link, though.

so no need to flash vbmeta?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
As I said, there are two options. I flash TWRP on the stick with custom kernel. TWRP can always be used when you want to install / flash something. You only need vbmeta if you want to flash the TWRP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rainbowxxl:
IT is possible to Upgrade from oneui 2.1 to 3.1? The method has not changed since android 9 and 10, or? I want to Upgrade my magisk 20.2, the only new is a checkbox with ^recovery mode^, the tick is ok and the update too? Thanks.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
The AP.tar of the firmware release contains a vbmeta.

When Magisk patches a AP.tar, it modifies boot, recovery, and vbmeta.

I don't think there is any case where you "flash a vbmeta". I'm not sure what kind of file you would be handling, but I'm pretty sure you should not be handling a vbmeta that is not part of a larger .tar file.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Enddo:
this video explains the recovery mode option in Magisk
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
So if I'm not mistaken there are these options:

Magisk patched [ stock firmware + stock recovery ]

Stock recovery resides in the AP_<blabla>.tar.md5 file

Magisk patched [ stock firmware + TWRP ]

Magisk patched TWRP can be flashed together with the Magisk output file AP_patched<blabla>.tar if put inside there, replacing recovery.img, or afterwards, flashing the Magisk patched TWRP .img file using Odin (in the AP slot)

Stock firmware + stock TWRP + custom kernel

Custom kernel needs Magisk baked in, and because of that..

.. this does not require button combination to boot rooted
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
That's the way it is. But you always need Magisk.apk
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
Yes, of course.

Is your experience with custom kernels still good? What reasons do you have for using it? I'm considering it to not have to press the button combination at boot, or the need to use USB that sometimes pops up for me. But I am fearing issues with custom kernels, like random reboots.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I take a custom kernel: ( ThunderStorms-Kernel-R-v1.8 : 08.02.2021)

- because of the boat

- the faster rooting

- the performance

- and the Accu.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Enddo:
nvm
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rainbowxxl:
is TWRP now with android 11 like it was for example with the galaxy s3 - s5, nearly impossible to brick so hard that twrp does not boot and when it does not boot, you only must flash twrp with odin new. since project treble i dont believe that twrp is so stable that i can flash roms or mods for fun and testing and can instal everytime my stable rom with twrp.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Get TWRP + instructions from here
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jelbo:
It's like that yeah. Though the S10 is a weird one as a 2019 SaR device that requires patching recovery to gain Magisk rooted Android. But if you understand that and you use multidisabler on stock firmware you can use TWRP's backup/restore functionality.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] asustitan:
I keep losing root for some reason S10, first boot root is enabled but I'm losing it after reboots. latest Canary
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
you have to turning on phone with something inserted in usb-c plug like only cable as well
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] asustitan:
Thanks, yeh keeping a USB plugged into the computer, lets me boot with root again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Ivymike52:
you don't need to be connected into pc, just connected a cable to your phone or just an adapter

maybe with new magisk update canary this issue has been resolved. This morning i reboot phone without problem only with keys combination
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
In your opinion, rooting S10e (with custom kernel) to use "proximity sensor reset" to recalibrate proximity sensor, will fix it?

S10e have the worst proximity sensor ever seen, but i don't know if is a bad physical sensor or a bad calibration never fixed from samung.

What do you think?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I can not tell you. There are some custom kernels. Just give it a try, maybe it will get better.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
yeah i'm trying but i can't go into download mode with android 11.. maybe it's a messagge from God to stop!

vol down+bixby+power on+cable goes in safe mode, not download mode
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
What do you want in download mode when you want to flash a kernel? It is flashed in the TWRP. Cell phone off> USB cable to cell phone > louder + Bixby + Power
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
I'm following this .. ok, i have unlocked bootloader, now i'll try to flash kernel
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
In TWRP: Format Data (confirm with yes)> Flash Multidisabler> Custom-Kernel> boot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
done, i'm testing proximity sensor with root..
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] azzadh:
I have 2 issues on EUA4 rom (Magisk patched) with Thunderstorm Kernel v1.8 (Arter97) on S10 SM-G973F. Firstly, my recovery just keeps vanishing after every restart, I have to re-flash it for every use, a minor issue for now. My bigger issue is that my phone keeps restarting when it connects to my QCY-T2C Bluetooth headsets. If I unpair it and then repair it, it works for 2 connections and the 3rd time the phone keeps restarting as long it can connect to the headset on boot. Anyone else experiencing anything similar?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Did you in TWRP> Format Data <(confirmed with yes) and flashed the

multidisabler

?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] azzadh:
Yes. Data formatted from twrp even though I was upgrading from rooted pie firmware. And then flashed multidisabler v3.1
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Have you patched TWRP? TWRP patched and a custom kernel (which is also patched) that can go wrong.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] azzadh:
No, my twrp vanishes after completing a boot. I install unpatched twrp from twrp app when I need it.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] azzadh:
It failed attempts from my end before I opted for a custom Kernel. I tried multiple clean(CSC flash)/TWRP format installations but my phone would either not have magisk after 1st boot completion or I would lose root after the 2nd boot and then no amount of key presses could get me to the recovery or Magisk mode boot. So I flashed Thunderstorm Kernel v1.8 just to have proper root on every boot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
I haven't patched anything. TWRP + vbmeta in Odin> the procedure in TWRP + Multidisaber, then the Arter kernel. After booting, Magisk appears immediately and needs to be set up.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] azzadh:
I didn't use any custom Kernel on Pie and had proper recovery plus magisk (with key sequence). But for some reason the latest firmware just wasn't playing well with magisk and twrp so I flash the Thunderstorm Kernel. I have proper root now, it's just the reboots with Bluetooth device connected that's a real bother now.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
@bininga59 any suggest for ota updates withour losing root?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Unfortunately it does not work. Odin is your friend. :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
So:

flash Odin -> closed bootloader -> open bootloader again -> flash twrp + kernel.. right?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
The bootloader normally remains open. Unless you closed it. Odin: TWRP + vbmeta > Multidisabler > Custom-Kernel
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
I don't wanna lose OTA Update, so:

(open bootloader) rom+recovery stock -> custom kernel via odin.. might work?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
Nope.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
There is always something patched at Root. TWRP, AP or the kernel. How should the update work? ;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hnktc:
@bininga59 @tiho5 thanks guys! So no chance, or OTA or custom Kernel..
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jediknight111:
Sorry for the stupid question, but I'm unable to update magisk in the new magisk update 22.0 , any help?

Update the manager fine by restoring manager to default, but magisk won't install, what options do I need to select?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Direct Install

See here: https://topjohnwu.github.io/Magisk/install.html
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] jediknight111:
Do I leave recovery mode unchecked or checked?

Thanks, that managed to work in the end,

Don't know why it didn't the first few times