yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
You are cutting corners. You are getting away with it.

I believe newer TWRPs include what used to be done by the multidisablers.

As for patching TWRP instead of the AP: If Magisk needs to be installed in recovery, and you want TWRP to be your recovery, then TWRP needs to be patched. It could have been done by building a new AP.tar file in which you replaced recovery.img with a renamed copy of TWRP.img. That is what I would have tried, because I do not know what other files in AP.tar get fiddled by Magisk patching. John Wu warns against having less than {boot.img, recovery.img, vbmeta.img} in what you use for an AP.tar. He also warns against not flashing all four files in each use of Odin. These warnings are not "it will fail if you do not heed my warnings", they are "it *might* fail...".

You got lucky. Yay you.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
Hello ZmisiS, I am rooted its works well or almost.

Why rooting jumps like on put 2 screenshot?

I did nothing else I updated shamiko redmarer as requested, then I look in magisk or setting as I hid magisk.

I see magisk not available and Zygisk not and application ok still install.

So each time I reflash with the 4 file don the patched _magisk -BL-CP-Home CSC, then once rooted restart I reflash up_param.tar and I'm rooted.

Also ramdisk these possible only with lineage 18.1 or we can find a module or do with adb for which works
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] :
I have not problem. I installed patched AP, CP, BL and CSC. It is the first installation. When I update new firmware, I use HOME CSC, not CSC. Before root, I install Magisk. After install firmware, if in system not have Magisk, I install Magisk again and follow the instructions. System restart and I have rooted system.

After, I install up_param for logo withaut notifications.

Magisk in my system is this:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] :
If I use Boot and Data, will the backup be worth anything?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I think so.

Data should be all installed apps, all settings. (Unless an app saves something on external SD-card, or in "internal memory".)

Boot is less useful: Before you install Magisk, boot partition is as in stock ROM AP.tar file. After you install Magisk, boot partition is the magisk-patched.img. Either way, you already have it.

What is correct spelling of "redmarer"?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] :
I don't know what is it "redmarer".
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] meric57:
to restart =redémarer ;)

Zmisis on your screenshot your zygisk on no, these wanted or it is activated me I see NE sa ve say no.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] :
On English language:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] :
I maked screenshot when Backup with TWRP.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
by the way, with my method, there is no need to connect to the computer to boot with root. Just go to phone settings and choose factory reset. it says the phone will be reset, but because I rooted the recovery mode, it opens with root :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hykosit:
Thanks again (with some time) !

In the end, none of these solutions worked with me, so I currently use an pre-magiskrooted boot image that I found (magisk 23)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] :
I used TWRP S10 - beyond1lte - G973F/G973N, avb disabled vbmeta .tar,

multidisabler-samsung-3.5 from this link to which you refer . I patched TWRP with Magisk 25.1 and all working good.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Since you are the one with the guts to click "factory reset" to see if it really will:

Is the phone not reset because you "rooted the recovery mode", or because you installed TWRP and TWRP does not honor the signal from Android settings?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
all i did was patch the twrp with magisk. that is, the first method for me to open with root normally: I have to press volume + / bixby / power keys until I see the bootloader open warning while connected to the computer. To reach twrp, I do the same process (volume+/bixby/power) until twrp is turned on.

The second method is: When it comes to the factory reset process, it starts again when you press that key and since there is no stock recovery, the reset command only forces the recovery mode and because there is root in the recovery partition, the rooted system is booted directly.

EDİT: actually I didn't try before patching it with root so I don't know the answer to your other question. If it comes to my mind before re-rooting the phone, I'll try that too.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hykosit:
Is there an order for the flashing of the images/ZIP ? for the vbmeta.**tar** (which I can't flash) is the idea just to extract the .img and flash it ? Or do you use Odin ?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] :
TWRP.img I patched with Magisk. Version of Magisk is 25.1. After I patched .img with Magisk, I copy it on PC with ADB. After copy on PC, I convert patched .img to .tar and it install with ODIN.

First of all, transfer the patched TWRP image (magisk_patched.img) file from your phone’s storage to the PC.

Open the folder where the file was transferred.

Hold the SHIFT key on the keyboard and right-click on any empty space inside the folder.

Then select the ‘Open PowerShell window here’ option.

Now, enter the following command to rename the ‘magisk_patched.img’ to ‘recovery.img’:

mv magisk_patched.img recovery.img

Instead of magisk_patched.img, type the name you got when you patched the .img with Magisk and then Enter.

For me it looks like this:

Next command for Galaxy S10 is: tar cf twrp-beyond1lte.img.tar recovery.img

Now you can install TWRP with ODIN.

I installed TWRP.tar and vbmet.tar with ODIN.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Charles_LV:
Yesterday I rooted my S10 with instructions from Magisk:

Everything was working great until I got a huge message "Please activate KNOX licence" or something similar. Which I did, because that thing did not go away. Afterwards the root is gone.

Any idea how to avoid that?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] casoaoshzo:
Hey folks!

I've just installed my first ever Custom ROM to a phone (S10+ Exynos) - Lineage 19.1 from here - and super stoked that I actually managed that without problems. :D Now I'm wanting to add Magisk, and feeling a bit confused by the installation instructions provided.

Specifically, my main question is whether I should follow the general section or the Samsung section , i.e. is that Samsung section hardware specific (so that I should use it) or software specific for phones running the Stock OneUI (so that I should not use it)?

What's causing me additional confusion is that when I was searching this thread and XDA overall for similar questions, among other things I found suggestions to install via recovery (e.g. here) which seems to be working for some people, yet also seems actively discouraged in the installation guide itself.

Would appreciate any pointers as to what the best practice would be, and apologies if that's a silly question and/or has been answered before - tried my best at searching this thread but couldn't locate an answer.

Cheers! :giggle:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
You still need to follow Samsung instructions, at least as far as using Odin -- you still won't have fastboot.

Whether to install in boot or recovery always depended on whether the bootloader and kernel would support an initrd in the boot image. That note on Magisk manager app front page "Ramdisk: yes/no" tells you whether the original boot image included a ramdisk. If there was a ramdisk, Magisk can patch it. If there was not, Magisk will add one, but it is not certain that it will be used.

It is possible that the stock boot image did not support a ramdisk, while the LineageOS boot image does.

I don't think patching recovery was actively discouraged, it just wasn't the first approach, and there is no reason to use it unless you have to.

Is LOS distributed as .tar files, suitable for Odin? If you hand AP.tar to Magisk, it will patch what it wants to. Why not try that?

Just don't waste time setting up the tablet every time it boots -- you will be wiping it a lot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] casoaoshzo:
Thank you J.Michael for the detailed response! Definitely helps my understanding along quite a bit.

Oh of course, that makes sense - I skimmed the instructions for the non-Samsung section and missed the reference to fastboot. 😅

That indeed does appear to be the case, I have downloaded the Magisk .apk and checked, I am seeing "Ramdisk: yes" for Lineage. (And believe from a tutorial I saw running through the installation on a stock S10+ that it's a "no" for that.)

That was certainly one of the sources for my confusion, had assumed Ramdisk is a hardware property, but turns out that I assumed wrongly.

Yes maybe I was exaggerating by that choice of words. :D It does say 'deprecated' on the installation guide. In any case I'm probably feeling better following the image patching approach.

So I downloaded LOS from here and it's provided as a .zip file with a recovery image as an .img file. My understanding is that is can be made suitable for installing with Odin by simply renaming the recovery image to recovery.img and packing it into a tar archive (many people in the relevant thread for the ROM and more so the previous version report so, and the maintainer specifically says so), however I used Heimdall (following these instructions).

The main reason I got confused which path to follow was that the Samsung section specifically talks about using Frija or similar to donwload a Samsung firmware and I assumed some of the following steps are specific to it - namely, looking into that Lineage .zip archive there don't appear to be AP, BL, CP, CSC files inside it, so I'm not sure how exactly that would work with Odin – will need to read up on that, but it's definitely a thing people successfully do - so I'll attempt to educate myself and try that. :giggle:

(I think a similar question was asked earlier in this thread but don't think that was answered.)

I'm not sure I follow this last sentence - what do you mean by the 'tablet'?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Maybe I should have asked if you used Odin. Odin is the Windows program to download to a device. The device is supposed to be in "download mode". This is the "flashing" step.

Odin expects four tar files. John Wu's instructions emphasize the importance of always providing four files to Odin. They also emphasize the importance of not having too little in the AP.tar file. I think at some point he says if you want to make a smaller AP file, at least have boot, recovery, and vbmeta in it. Other posts I've read describe people successfully ignoring this advice. I don't know if the problems only occur on certain hardware, or if the problems used to occur but the real reason for the problem has since been corrected. I did this once, with a new tablet, got it to work, and will not be experimenting with that tablet ever again.

I said tablet because I have a tablet and I get tired of typing "device" to avoid offending people with phones.

If you were able to install LineageOS following instructions and using Heimdall, then just stick with what works. When I was doing this, Magisk manager app had an option checkbox "patch Recovery". I think I found that it did not matter when I handed the manager a tar file to patch. I do not know if that checkbox is still available. As I understand it, the manager displays only those options it thinks relevant. It will cost you nothing to perform the patching step -- you can always choose to delete the patched file.

Shirley somebody in a LineageOS oriented thread mentions which piece they patch, but if you say Magisk manager app now says "Ramdisk: Yes", I say patch the boot image. And don't change any names. Or be careful. I think I remember Heimdall having much more explicit specification of what goes where, so do not change the part that says "flash this to the recovery partition", but you are probably free to change the actual file being flashed; then again, why bother. Stick with what worked the first time you installed LineageOS, just use a patched boot image.

And read those instructions another four times. They have to read in a spiral to get the steps in the right order. And the special instructions for Samsung, like "don't let it boot after Odin finishes, but instead force it to boot to recovery so you can wipe the data", may still apply. Again, Lineage-focused threads probably have more reliable advice.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] casoaoshzo:
No worries, I should have been more specific! Yep I'm slowly getting the hang of what I'm actually doing - Heimdall respectively Odin taking the role fastboot would have on a non-Samsung device here and those two Samsung tools (theoretically?) being able to do the same things. I'm a sticker to instructions I'm given, so I'm happy to familiarise myself with Odin if the instructions say Odin. ;)

Yes, the importance of always providing four files was one of the stumbling blocks for me - the instructions that describe flashing Lineage recovery with Odin all only ever speak of using the provided .img file (zipped into a .tar archive) in the AP slot and leaving the other 3 slots free. Seems like a potentially dangerous thing to do here.. I'm starting to understand that it matters more to ask advice specific to ROM than specific to device, so I'll seek help in the relevant forum!

Of course! I apologise, that was me being stupid, didn't think of tablet as a device type. :ROFLMAO: Thought that's some kind of software I am not familiar with.

Very good advice. :) I'll try the patching step to get a feel for it in any case and do some more reading up on what to do with the patched file (or discard otherwise). The only reason I really want to root is so I can get AFWall+ installed, but if the whole endeavour becomes to complex for me I may go with NetGuard for now while deciding whether to proceed reading up on stuff.

Thanks for that, yeah I'm gonna go into the relevant LineageOS thread and see what people there know about it!

Not to worry, if there's one thing I do it's following instructions to the letter. ;) Took me three reads through the Lineage setup instructions plus a couple of YouTube videos before I dared that.

Thanks again J.Michael, that was tremendeously helpful!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
@casoaoshzo Odin does not do everything fastboot does. I really envy the people who can try "fastboot boot crappola" to see if it works before committing to "fastboot flash boot crappola".
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] casoaoshzo:
@J.Michael that sounds neat indeed. Not equivalent then, but the best replacement for fastboot we have I guess. :LOL: I've posted in the relevant forum for my ROM (here if anybody comes here in the future with the same question). Cheers again!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Shumafuk:
I want IodéOS 3.1 on S10e with TWRP, root (Magisk) and encryption.

I was used to flash Magisk as zip file after flashing ROM, but it is not recommended now. So... I'm quite lost.

So I need...

Install Magisk apk

Pre-root TWRP in Magisk

Renaming modified img to tar via adb

Flash modified TWRP in Odin with avb disabled vbmeta .tar

Boot to TWRP and format data

Flash

multidisabler-samsung-3.*

zip

Flash custom ROM

Install Magisk apk again in fresh custom ROM (not flashing in TWRP)

... and that's it, system will be rooted? I'm not sure about last two steps. Also... Upgrading. For new Magisk version I need to repeat whole process? For upgrading OS with root I need to reinstall Magisk? I'm confused.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Read the last few pages. @ZmisiS described his procedure in detail.

Do not rename .img to .tar. tar is an archive format, and the name of the program that manipulates that archive.

You probably have a tar in your Android. From a command prompt (terminal window) in Android, Linux, UNIX, even Windows if you downloaded a Windows-version

tar cvf new-tar-file.tar recovery.img

If "Pre-root TWRP in Magisk" means "use Magisk manager app to patch TWRP.img", then yes, but.

I am still waiting for someone to tell me how TWRP is "delivered" for this device.

If you started with a tar file, just tell Magisk to patch the tar file. Then tell Odin to use the patched tar file.

And yes, upgrading OS may mean doing the whole, miserable, process again.

Does "IodéOS" mean "LineageOS"?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Shumafuk:
But Magisk wont accept tar files. It fails with finding recovery.img. Only img works.

Why, after years of development, we make basic things as rooting devices more and more difficult?

Yes, basically there is no difference except few features, that saves me quite a lot of time (MicroG, F-Droid repos, Aurora Store, built in adblocker).
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Magisk *does* accept a tar file.

If you are saying Magisk said "unable to find recovery.img", that means the file in the tar file was not named "recovery.img".

Did you get TWRP originally in a tar file? How many files are in the tar file? What are their names?

tar tvf tar-file

will list the contents of a tar archive.

Have you read @ZmisiS's posts? If what he said differs from what I advised, follow his instructions. He has actually done this.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Shumafuk:
Do I need to patch by Magisk any files from custom ROM pack to have root before flash it?

If I understand correctly, root is done by patched recovery, not by boot, right? So no need to patching any ROM files?

I understand that part of patching, I'm just not sure about the last two points that I wrote in my list.

I have TWRP in tar and img. tar version have recovery.img in it. Btw, what is problem with renaming img to tar? According to this guide it should work.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
I am not even going to look at that guide. You cannot change a file into an archive containing the original file by just renaming the file. You have to run a program that creates an archive, and tell it what files you want in the archive.

Have you read John Wu's installation instructions? In the section for Samsung, he advises that if you want to work with a smaller tar file than the GB AP file distributed by Samsung, that, at the very least, yoj always have boot, recovery, and vbmeta in the tar file. While Magisk is injected into the recovery, there is some patching of boot and vbmeta. It may not be code injection, it may just be modifying some signatures, but it is still necessary. Or it was at some point.

You should always start from a working system that does not have Magisk. If that working system is a custom ROM, then whenever someone says "pull this piece from the stock ROM", for you it means "from the custom ROM".

I do not know if you need to install Magisk in recovery if you are using LineageOS. Can you find anyone who is using your ROM on your device with Magisk?

If your ROM cannot be installed with Odin, but rather you need to install TWRP and then use TWRP to install the custom ROM, maybe you should never use Odin. Except to reinstall the stock ROM.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] knojap:
Where did you put param.tar in Odin? AP?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
It probably doesn't matter. I think Odin just downloads all the files of all the .tar files. Odin having four slots, each named after a file provided by Samsung, is probably just a convenience -- it helps you to keep track of what you're doing, and reminds you that Samsung ROMs usually come in four parts.

If you're feeling adventurous, give Odin both tar files (TWRP and up-param) and see what happens.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] megatron_lives:
Hi all. I'm curious, can we now have both TWRP and Magisk root with Android 11 or latest firmware for S10? I recall sometime before that your couldn't have both and also, you needed a USB device attached when booting??

Thanks
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
hello @J.Michael

I want to use stock firmware with encryption. my actions:

1. Install stock firmware with odin.

2. Patching the lineage recovery with magisk and flashing it with odin.

3. To boot the system by saying reboot recovery.

4. when it boots up it will boot as root, but after reboot it will delete samsung lineage recovery and restore stock recovery. How can I prevent this restore? I don't want to use multidisabler. because it also disables encryption. Now, when I look at the first boot, encryption is enabled in the settings. so my question is: how can i prevent restoring stock recovery in system?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
You plan to use stock firmware, but LineageOS recovery?

I do not know if encryption causes a problem, or which components need to be capable.

I do remember that the original instructions called for handing Odin a full set of files, so even if the only part that interests you is flashing a magisk-patched recovery, you should hand Odin a full set of AP, BL, CP, CSC tar files. The magisk-patched recovery would replace the recovery in AP.tar.

I don't know where you are saying "reboot recovery", but if that's a command that makes it easy to boot to Magisk in recovery, then that is wrong. After flashing magisk-patched firmware, the next boot is supposed to be to recovery, and the instructions call for factory reset / wipe data.

I never used the multi-disabler. I thought it was associated with installing TWRP. Maybe if you look inside it you will be able to distinguish the part that disables encryption.

It is possible that nowadays people get away with patching the boot image on an S10. That might avoid some of your problems. If it doesn't work you can reflash the stock firmware and start over.

I hope that someone who has actually dealt with this will respond.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kullanici32:
when I normally do it using twrp it simply:

1. flash stock firmware

2. flash magisk patched twrp

3. Format data and reboot to recovery.

4. "reboot to recovery" function means start as root because you already have magisk installed in recovery. and the phone opens, use it as you want, no further action is required.

but the encryption is disabled on the phone, and i want it to be on encryption on my phone. twrp doesn't support it, but lineage recovery does, this is why i want to use lineage recovery.

my request is to remove all processes in the multidisabler and keep only this function: I want it to prevent magisk patched lineage recovery from replacing it with stock recovery.

where in the system is this ''change to stock recovery'' command? How should I remove it manually?

Maybe this @Linux4 lineage recovery developer person can help.

If you know someone who understands these things, can you tag them here?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] J.Michael:
Have you looked in the Android settings for references to encryption?

I Googled "enable encryption android" and found a page describing how to encrypt a phone.

https://www.ferris.edu/it/howto/encrypt-android.htm

go to Settings > Security > Encryption > Screen lock. Select the PIN option and enter a PIN.

Settings > Security > Encryption > Encrypt tablet or Encrypt phone.

The Android device needs to be plugged in to a charger or it won't encrypt. Tap the encrypt button.