yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
a single video exists on youtube for s10 series

https://www.youtube.com/watch?v=o3a8YnWT3yk&t=509s
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
here I can not get I tried all the 5-day buttons but that's what they do lool...this picture not my phone.....and I told you when odin finish flash magisk_patched on my phone upstairs write something small failed I did not remember everything she wrote
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Perhaps try step 7 again:

Flash magisk_patched.tar as AP in ODIN

Important: Uncheck “Auto Reboot” in Options!!!!

Do you still have magisk_patched.tar? You're sure you've used the correct firmware? When performing step 7 try identify what the error message is (if you get one).
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
yes i have magisk_patched in my pc and auto reboot uncheck....
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
In Magisk there is in the settings "Patched Boot Output Format" Try switching it to img.tar if it's not already selected. Last time I tried it was defaulted to .img which I don't know if people know. So I think changing it might fix it, not sure. Don't have the time to try right now.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Just to confirm, this was the same step you were stuck at, correct?
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
I will try it once but I do not think it will have any effect:confused:
[Samsung Galaxy S10 Guides, News, & Discussion] pixiebob:
i trying too and after flashing magisk_patched.tar i can't boot to recovery. same issue like you, trying several key combinaison . phone cannot boot system or recovery.

only download mode working
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
Yes indeed
[Samsung Galaxy S10 Guides, News, & Discussion] SuperBrolySSJ:
You guys have the HOLD the buttons past the bootloader warning screen until you actually see the recovery. if you just press and stop at the bootloader warning screen, it'll just boot normally.

That's a possibility on why you can't get into recovery

---------- Post added at 07:18 PM ---------- Previous post was at 07:17 PM ----------

read my post explaining how to get into recovery
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
exactly what is happening and on my phone I throw them in the garbage loool:D
[Samsung Galaxy S10 Guides, News, & Discussion] pixiebob:
even if rooting was unsuccess , reflashing full firmware odin(and reinstalling all application, it take long time without root ...),the good thing is my fingerprint working largely now better than before.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Ok, so try this. I played around with it on mine (stock 9730, no magisk yet).

From download mode (step 9)-> Power+bixby+volume down

As soon as that download screen vanishes *quickly* press and hold power+bixby+volume up

When u see samsung s10 logo screen release bixby and power, only holding volume up.

Gets me into stock recovery every time. For you guys that didn't succeed with root, are you able to get into the stock recovery using this method now that you're up and going?
[Samsung Galaxy S10 Guides, News, & Discussion] pixiebob:
i can going into recovery mode with stock rom without problem with this key combination, but after flashing magisk patched and same key combination i can't going to recovery
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Thanks for the update and testing.

For now let's agree that the current Magisk patch and process is breaking something in the recovery partition for the SM-G97x0 SD variants.
[Samsung Galaxy S10 Guides, News, & Discussion] pixiebob:
this is what i'm thinking too, the patch generated by magisk is the problem.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
Did anyone take the time to provide logs to github so that [MENTION=7187684]ianmacd[/MENTION] or [MENTION=4470081]topjohnwu[/MENTION] can look at the problem and fix it.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I don't mind submitting something on behalf of people here, I'd only require the logs they generated. If anyone is willing to attempt root again, then generate logs feel free to contact me.

I suspect we are very close to a root.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
I think this is a great idea. Maybe you can write down the procedure on how they can get the logs. Because maybe they are not familiar with how to do it.
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
Not sure how to take logs when phone is not booted into system BUT I did tweet to him. Yet I feel he rarely responds to people there.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I've created an issue report for [MENTION=4470081]topjohnwu[/MENTION] on the magisk github here:

https://github.com/topjohnwu/Magisk/issues/1346

Note, I've indicated if we can get logs that i would also update the post with them.

Something interesting I've noticed when submitting the log (and some Chinese translation) is this: https://github.com/topjohnwu/Magisk/issues/1307

This user was indicating his SD HK variant was not working, but suddenly he did manage to get it working.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
For the user that said he got into recovery and successfully rooted the device. i asked for his wechat so maybe i can talk to him since i also live in china/hk area. so it might be easier to communicate with this person.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Great news.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
But maybe all the users with a HK or CN version of this phone can post on the github . Because the more post it has the more likely johnwu will see it and pay attention to it.
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
I will also write when I go home to account because I do not
[Samsung Galaxy S10 Guides, News, & Discussion] TheFirstAv3nger:
Guessing the SM-G973U isn't unlocked.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
USA version is not a true unlock.
[Samsung Galaxy S10 Guides, News, & Discussion] AloxeCorton:
Tried to root a couple days ago on a 10+ and +1 for experiencing this same issue where I can't get to recovery mode AFTER the new AP odin patched file is installled (worked well before though). I ran into a bootloop so ended up reinstaling full stock through Odin and now awaiting working Magisk like us alll.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Which model of s10 do you have? Is it the chinese or HK variant? Can you link where you specifically found the FW?
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
You can use the fajia firmware downloader or Samfirm software to download your official versions
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Samfirm is deprecated, linking us to http://fw.updato.com/ which has no downloads for SM-G97x0.

Feels like i'm missing something here.
[Samsung Galaxy S10 Guides, News, & Discussion] AloxeCorton:
I'm not sure how to differentiate HK from Chinese version - It just says SM-G9750 and both have unlocked snap 855 as far as I know. The firmware files that I picked up here: samfrew.com/model/SM-G9750/ is for HK and worked well when I reinstalled full stock. Could that be the issue( HK Vs. Chinese firmware)?
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I suspect it may be related, yes. You need to check your build number in software information and ensure its the correct one prior to doing anything. You can also check by dialing *#1234#

The PDA/AP Version for my HK variant is G9730ZHU1ASC8.

I'm wondering now that you've possibly changed everything to the HK variant if the magisk process would work. It may have been possible you were initially patching pieces of the HK variant with Magisk into your Original Chinese firmware then trying to boot from it.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
You need to download the firmware with https://xdaforums.com/s10-plus/how-to/tool-frija-samsung-firmware-downloader-t3910594

After your done downloading the firmware I recommend flashing that firmware first in Odin. Then after that . Patch it with magisk this will make sure you are patching the same firmware as the one you downloaded.

Btw if you are in HK or china and want to join a wechat group we started . Message me for the qr code.

---------- Post added at 04:58 PM ---------- Previous post was at 04:57 PM ----------

If you have a HK phone you should download the

SM-G9750

CSC: chc

This is the china variant maybe it would work.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I don't think so, that's where a possible issue is arriving.

For HK variant the CSC is: TGY

For the China variant the CSC is: CHC

The PDA/AP Versions between the two are also different. I believe the only similarities in the current version may the the modem.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
I understand but it won't matter what firmware your patching as long as that firmware you are patching is the firmware that is installed on the device. If they are switching to a different region they need to flash that one first before patching it then reapplying it.
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
Yea, I patched the right firmware. Mine is TGY, I patched TGY and still same issue as everyone else.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
What I want someone to do is switch there CSC.

So download the CSC: chc

Then flash the entire chc firmware then try and patch it. Because chc is for Chinese.

The phones are the exact same. Just different firmware
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
If it won't wipe data I'll do it now but it if does I don't have the time to restore everything.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
No for this process it will take a full wipe. But on the Exynos forum we have been able to do the updates without wipe . But for this project to see if snapdragon can get root we need a clean firmware install.
[Samsung Galaxy S10 Guides, News, & Discussion] AloxeCorton:
That's what I figured about the HW being the same but I may have switched only the AP file in ODIN and thus used a patch file that was out of sync witH the other firmware components (CSC CP BL).

I'll try doing a full CHC firmware flash followed by another Magisk patched install towards EOD and report back...
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
someone changed the font to snapdragon sm g970x0 hk?non-root:confused:
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
Sounds good . I recommend downloading the full firmware and flashing all parts. In Odin. Then after flashing let the phone boot and install magisk then after it installs. Patch the new AP. Then put the phone back into download mode and flash the patched.tar file.
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
You try it s work root?
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
I am trying to solve the snapdragon root to help friends out because I live in china but I have the Exynos s10+ from Singapore
[Samsung Galaxy S10 Guides, News, & Discussion] AloxeCorton:
Ok, I started off by doing a full firmware install (BL, AP, CSC, CP) to chinese. I got the files from the Frija app which makes sure the CRC32 is the same after download. Do keep in mind I used the S10+ (SM-G9570) firmware because I have the 10+ and not the 10.

I then patched the same file I used for the full install an this worked fine. When I installed it to the Galaxy S10+, everything installed fine but then I ran across the same problem as everyone else (I think) and that I already noticed with the Hong Kong firmware which means that the the Recovery Mode was simply not available anymore no matter

what key sequence I tried (Power-Bixby-Vol_UP). I again got into a kind of boot-loop and then gave it up and flashed back to the original.

So on my end, both HK and Chinese S10+ firmware (for G9570 snap 855) doesn't seem to work using the current Magisk iteration.
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
The 9730 kernel source is out and the guy I'm talking too says he can compile a modded 9730 kernel without root restrictions which may help with getting us root, hopefully.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
This is great news.
[Samsung Galaxy S10 Guides, News, & Discussion] pixiebob:
very hope that he would do that.

---------- Post added at 08:47 AM ---------- Previous post was at 07:53 AM ----------

thanks for the report.

do you notice any improvement with chinese firmware like for example compatibility with Volte?
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Great news everyone. [MENTION=4470081]topjohnwu[/MENTION] has modified a file in the magisk source, specifically init.cpp.

See the proposed changes here: https://github.com/topjohnwu/Magisk/commit/f2b52755d6694cb6708737bb6ac29ac78327c87c

He added the following note: "This should in theory should support more devices for detecting the

volume up press on boot."

This will have to be complied into an apk and tested again. If anyone complies it, feel free to post it with a link.

I might work on it a bit tonight if I have time.
[Samsung Galaxy S10 Guides, News, & Discussion] pixiebob:
i think we are close to root, please report and good luck
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I'm having issues compiling the code on the latest canary build of android studio. Unless someone else complies the source we will have to wait for a official release of the latest canary build of magisk.

If anyone else is willing to try it today that would be awesome.

Git here: https://github.com/topjohnwu/Magisk.git

Android Studio Canary (needs 3.5 to build for me): https://developer.android.com/studio/preview
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I have a buddy that manged to compile the updated source. If anyone wants to try rooting their SM-G97x0 devices, today may be the day. Changes should fix step 9, Link below:

The complied apk may be located here: https://drive.google.com/file/d/1v3ZCEZVjEpLk9KO49G1n11bvchhGNtPk/view?usp=sharing

Good luck everyone!
[Samsung Galaxy S10 Guides, News, & Discussion] Easiey:
Thank you for your info.
[Samsung Galaxy S10 Guides, News, & Discussion] dtowngs4g:
Are you referring to those with the US snapdragon versions? I've gotten kind of lost since it seems those who have root on other variant are posting here. It's kind of getting off topic for those of us waiting to hear about Snapdragon root. Sorry not trying to be a buzzkill.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
No not us variants only china and hong Kong and other snapdragon countries that have official unlocks. Now why do I say official unlock is because in china and hong Kong the unlock is decided by Samsung. The usa / Canada unlocked snapdragon is not the same because of the regulations and rules by the FCC. If it was the same then there model numbers would be the same and not have a U variant at the end.
[Samsung Galaxy S10 Guides, News, & Discussion] pixiebob:
thank you my friend, we will need some tester, i can't try today because working but will try next day
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
for china chc variants the new update arrived for tgy no :( asd4... now I think I regret that we did not stop the European variant sm-g970f
[Samsung Galaxy S10 Guides, News, & Discussion] Tel864:
Oops, wrong thread deleted.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
No problem, hopefully this gets us all rooted.

I've managed to patch the HK tar using this apk, seemed to work well.
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
Now work root:confused:
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
If you start fresh and use this apk to patch in magisk I think yes:

https://drive.google.com/file/d/1v3Z...ew?usp=sharing
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
[MENTION=7187684]ianmacd[/MENTION] can you please post the new compiled

.apk for magisk here so the people on snapdragon can have a try. [MENTION=2022726]PiCkLeS[/MENTION]
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
[MENTION=3567583]rp4k[/MENTION] [MENTION=2022726]PiCkLeS[/MENTION] it's compiled here.....

https://drive.google.com/file/d/1v3Z...ew?usp=sharing
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
you just think but nobody tried:confused:
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Correct, this is only a compiled version of what [MENTION=4470081]topjohnwu[/MENTION] created. He hasn't compiled the source yet, I had a friend compile it for us in the meantime.

This will help us provide feedback to [MENTION=4470081]topjohnwu[/MENTION].
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
Wrong link:confused:
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Correct, this is only a compiled version of what [MENTION=4470081]topjohnwu[/MENTION] created. He hasn't compiled the source yet, I had a friend compile it for us in the meantime.

This will help us provide feedback to [MENTION=4470081]topjohnwu[/MENTION].

---------- Post added at 02:30 PM ---------- Previous post was at 02:28 PM ----------

Updated here: https://drive.google.com/file/d/1v3Z...ew?usp=sharing
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
Sorry, the file you have requested does not exist.

Make sure that you have the correct URL and the file exists.

Bad url doesn't work
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
it's probably the one in the morning app :silly:
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
It doesn't work on snapdragon my friend just tried.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I'm not sure how your friend tried it in under 10 minutes...

Can your friend make a log? This will have to be submitted to [MENTION=4470081]topjohnwu[/MENTION] again, for further investigation.
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
we probably will not have root on the snapdragon:(
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
He asked me to tell you how to do a log when your turning the phone on and off. So if you know how please tell me the instructions so I can tell him
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Please see here: https://www.didgeridoohan.com/magisk/MagiskHelp
[Samsung Galaxy S10 Guides, News, & Discussion] Sly123:
Please keep this thread up. :)

I just ordered a S10 import from China.

In my opinion the superior Snapdragon S10 should get at least root.

Thanks to all who help with it.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Great choice, IMO its the best S10.
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
How did y'all try because the new apk wouldn't even install for me and I did uninstall the old
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I was able to install and patch my AP tar with it...

Try reboot after your uninstall then save the apk to your phone (dont run from downloaded or drive app) then run using your file manager (in my case solid explorer).
[Samsung Galaxy S10 Guides, News, & Discussion] ChrisChristian:
And you have root now:confused:
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
so my friend got TWRP installed but he said the new build of magisk and the old build . will not work
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
The guide below has no mention of TWRP, you dont just "install Magisk". You have to follow the steps, patching the AP and other various steps. I'm worried hes not following the proper steps.

Did he follow the guide here: https://topjohnwu.github.io/Magisk/samsung

Where is it getting hung up on? Which step?
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
i have no clue... but [MENTION=4726113]Fznwolf[/MENTION] you have an HK variant of the s10 ? did it work for you?
[Samsung Galaxy S10 Guides, News, & Discussion] ianmacd:
I compiled that 2 days ago, as soon as John committed the code.

Are you not running an ianmacd build of Magisk? If you are, updating to the latest Magisk code is as simple as updating through the Magisk Manager app.

Note that the ianmacd builds are often newer than even the canary builds, so if there are commits that you don't yet see in canary, the latest ianmacd build usually has them.
[Samsung Galaxy S10 Guides, News, & Discussion] SuperBrolySSJ:
He has TWRP? was the TWRP made compatible with China and Hong Kong snapdragon variants?
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Lol, I have no idea what that dude is upto or what variant he was using. I was only trying to help him test out the latest magisk.
[Samsung Galaxy S10 Guides, News, & Discussion] jam51dill:
So it's confirmed not to work on the latest ianmacd build?
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
Not a single person tried it.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
Then were is the .apk

They are not updating they are doing a new install and need to try to see if the button combination works for hk/CN snapdragon

---------- Post added at 01:00 AM ---------- Previous post was at 12:59 AM ----------

He is on cn/hk variant . Sm-g9750
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I have his APK, just check his GitHub.... I don't think your friend is following directions correctly. Within 10 minutes you said he failed with the apk I provided earlier. Just copying the apk and AP.tar to the phone takes 5 min, patching another few min then back to the PC another 5 min. That's just copying, before doing any of the other steps, something is super fishy.

I'll likely be trying a flash over the next couple weeks when I'm back from a work trip, I can't afford to be rebuilding my phone at the moment. However, I do ask that when trying these new apks they start from fresh, following each step closely. The fact i saw TWRP in the screenshot is concerning as well.
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
I'll try it again now and see if the new apk works. But people say that when flashing back, flashing the home Vs the csc part of the firmware will not wipe data, I did that last time and still had to wipe data.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
He tried to install the apk from inside system and it failed. That is what I mean. And in china someone built a version of twrp for the sm-g97x0 phones . So that is why I posted that picture. It's ok I am done they are all happy to have twrp.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
You will have to 100% wipe, follow the guide with Ian's APK (use it to patch the ap) and you'll have the highest chance for success.

Keep us updated, you're truly pioneering here.

---------- Post added at 01:48 AM ---------- Previous post was at 01:47 AM ----------

You should share the sm-g97x0 TWRP if that's truly a thing.
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
I have it on my computer. I will upload it now then share the link.

https://mega.nz/#!tUBBSCjA!EYL4EACO4BDtnaVyO6-hmt8DPQSFW-7X941RFX3snrY

Sm-G9750 CN/HK variant working twrp. But this build is vanilla so it doesn't contain magisk
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
Two pictures of it working
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
Does it work for 9730 or just 50? Also does the newest ianmacd magisk work or did no one try it yet? Im about to but want to know before I do.
[Samsung Galaxy S10 Guides, News, & Discussion] Fznwolf:
I don't know of anyone that's tried it, please keep us posted. That build does have fixes (in step 9) I reported to [MENTION=4470081]topjohnwu[/MENTION]
[Samsung Galaxy S10 Guides, News, & Discussion] Ndaoud360:
AND............ it doesn't work.
[Samsung Galaxy S10 Guides, News, & Discussion] ianmacd:
Install the latest version from here and then select the ianmacd channel to stay updated.

https://github.com/ianmacd/MagiskBuilds
[Samsung Galaxy S10 Guides, News, & Discussion] rp4k:
These are all uninstallers is there a .apk that has the latest builds instead of them having to add a repo.