yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PillowCake:
To have root it's only necessary to boot in recovery, which is done by powering up the phone with the Bixby+VolUp+Power button combination.

What I don't get is why exiting Download Mode by pressing Bixby ON TOP of VolDown+Power buttons... I mean, even in his guide (https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root), JohnWu states that you only need to press VolDown+Power to get out from Download Mode (see step#9). This is why I'd like a clarification from the above user.

My guess is that pressing Bixby is irrelevant at this point (that is, for exiting Download Mode).
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
After Odin (without Auto Reboot) you only come with emergency from the download mode. Power + Volume Up
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] PillowCake:
This post does not make any sense.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
He does not have to make sense to you either. But you have to turn off the phone after Odin and then start with the three buttons - very simple.;)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Norup58:
I agree with you. After I have flashed software updates I only press Power+Volume Down to leave Download mode and then immediately do the Power+Bixby+Volume Up combo to boot to Recovery/Root.

Maybe the Bixby button isnt recognised/ has no effect in Download mode when/while pressing the Power+Volume Down combo and if that is the case I can see the advantage of already pressing the Bixby button as you only have to shift your finger from Volume Down to Volume Up to get to Recovery/Root....
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
That's right, it's faster. But that is the only reason and maybe a bit confusing for some.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
OK guys, [MENTION=9793184]PillowCake[/MENTION] [MENTION=5902940]bininga59[/MENTION] [MENTION=6296692]Norup58[/MENTION]

In the interests of accuracy for everyone, afterall this what XDA is all about isn't it, I am scrubbing previous post and re-worded a new one.

---------- Post added at 06:24 PM ---------- Previous post was at 06:14 PM ----------

Firmware updates and keeping your data,

for phones Magisk rooted without TWRP.

Just download new firmware, copy the AP file of the new firmware to your phone.

Open Magisk Manager, ensure Magisk is up to date, if not, update it.

When Magisk is up to date, if you have any Magisk Modules running, go into Modules and disable them (no need to uninstall them). Then reboot and go back into Magisk Manager.

Hit the top INSTALL, select INSTALL again then select 'Select and Patch a File'

Locate the new AP file from your new firmware and patch it. Then copy the magisk_patched.tar back to your computer, preferably with ADB to minimize corruption during transfer.

Power off phone and reboot to Download mode.

Open Odin 3.13.1 on your computer, and

deselect Reboot under Options tab. Now use the new magisk_patched file in the AP slot, the BL and CP from your new firmware into their respective slots and importantly HOME_CSC into the CSC slot. Press start and let Odin do it's stuff.

When flashed, do not wipe. Press and hold Vol-down and Power, when screen goes off, quickly change to Vol-up, Bixby button and Power. As soon as screen appears, let go of all buttons.

Within moments without any further user intervention your phone will reboot into your updated Magisk rooted mode, data intact.

Just re-enable your previously disabled Magisk modules.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] rxk:
Hi [MENTION=499148]robbo1947[/MENTION],

With the steps you mentioned above for Firmware update without TWRP. Is the OEM unlocking option must be grayed out? If it is required how to do it? Mine currently enable and blue.

Thank you.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
The OEM switch only needs to be greyed out prior to the Magisk rooting. After rooting it should be Blue as yours is now.

You're in a position to update.

Good luck!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 93ae8074:
Anyway of doing it systemlessly with Magisk? I tried putting a copy of the folder structure at the same level than "system" in the module but without success.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
I put an unmodded cscfeature.xml and loaded into product/omc/XXX (BRI)/conf, reboot, then my phone lags and cant make calls. Luckily i saved the original cscfeatures.xml. It's a failure
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] 93ae8074:
I made it work. I have in my /product/omc/single/XSA/conf folder modded cscfeature.xml, cscfeature_network.xml and custom.xml to add some functionality and include specific configurations from TEL. Working fine, what did the trick to me was re-encode the files before adding them to my XSA folder.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Hiroo Onoda:
Yeah I got the same error message in Magisk last night trying to patch the new August AP. It said it was unable to save the output file, which yet appeared anyway. I still held off on flashing. This morning, patching went through with no error. Gonna trying to flash now.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Player04:
Can You send me yours cscfeature.xml and cscfeatures_network.xml and custom.xml? i want to see how you do yours. Im using AT&T on my S10+ exynos
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Previous Firmware

I'm sure when I was on ASF3 I could flash back to any previous firmware. Now on ASG8 no way back.

Am I missing something?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
The ASG8 has the Bootloader 3, because you can not go back. G973FXXU

3

ASG8, G973FXXU

2

ASF3
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Rshady:
Is it possible to root with out a computer I have another phone any ideas???
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Anton_84:
Hi, can't find instruction how to delete magisk and return to official rom.

Give me the link please.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Just flash a current stock-rom with Odin
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
If you wish to return to the original start screens and remove the bootloader unlocked warning, see my instructions HERE
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tiho5:
May be it is useful to report this:

There was a Magisk update today on the [MENTION=7187684]ianmacd[/MENTION] channel.

It solved some problem that I had with the previous version, which was strange. A Tasker profile meant to delete a group of files and folders was causing my phone to freeze and SystemUI to stop responding. Now it works again with this new version.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Termy5678:
For some reason, the recovery is not working at all. I installed the patched file along with the other files from odin

Held down bixby, down and power until the screen turns off, then pressed bixby with volume up and power. However, it never gets to recovery but goes on a blue screen saying erasing. Recovery works only after reboot. The issue is the same one experienced by a person few pages ago and even tried his solution but to no avail.

What I have done so far:

Patched original AP file and used ADB push/pull to prevent corruption multiple times

Flashed original AP, reset, booted up and then flashed patched file after entering download mode again
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
After flashed with Odin you should hold volume down and power button, when screen goes off release and then immediately press volume up, Bixby and power until screen reappears, then release Bixby and power and just hold volume up until recovery screen appears.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Termy5678:
So I went and decided to flash slightly older official firmware, skipped the setup, patched that firmare with magisk manager, pulled with adb then flashed through odin

Left download with bixby+down+power. Pressed bixby+up+power and as soon as the "powered by android" appeared the second time, I let go of the bixby and power. Only held up the volume up but unfortunately after few seconds, it showed the erasing screen and not the recovery. Phone bootlooped after until I did a reset.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
What do you mean with older official firmware?

You have to hold the buttons until you release in the recovery, not before.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
To quote [MENTION=2750493]johnwu[/MENTION] :

We now want to boot into the stock recovery to factory reset our device.

Full data wipe is mandatory! Do not skip this step.

Press Power + Volume Down to exit download mode. As soon as the screen turns off, immediately press Power + Bixby + Volume Up to boot to recovery partition. Just as mentioned in the previous section, since we want to boot into stock recovery, continue pressing the volume up button until you see the stock recovery screen.

It doesn't overly matter if you don't catch recovery screen on first attempt as long as you wipe the data before it finishes rebooting into the system. Do this by cancelling the rebooting with volume down and Bixby, then quickly changing to Power + Bixby + Volume Up when screen goes off, then Volume-up only.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Termy5678:
Just tried that few more times along with new patched file. Won't go past erasing even while holding all the buttons. KG state is on checking and download shows no error so can't seem to find the reason for recovery not working

I have watched the videos about the S10 root, in both of them the erasing screen is for a split second followed by recovery showing up.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Just a matter of button press and timing I'm sure.

Tip, remove any phone casing.

When you see the Blue 'Erasing' screen, you should be pressing the Volume up only. If your finger is still on The Power it will go to reboot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] powerful111:
I want to update Magisk to 19.4 from within the app but am scared of bootloop. Can anyone confirm if it's safe to get on the latest?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Quite safe and quite easy, just click install then click install again then select the last option Direct install then click on reboot when flashing is complete. No need to hold the buttons as it reboots straight back into magisk system
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] powerful111:
Thank you
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] aslomagic:
I'm having the exact same issue as [MENTION=9133048]Termy5678[/MENTION], and I can assure you it's *not* just a matter of button press and timing. I did this probably 10 times, tried with ASH1 and ASG8 (unfortunately I updated the bootloader to ASH1 and I don't think I can downgrade), no luck. Either you get the "erasing" blue screen, or a straight up bootloop.

Any help would be highly appreciated!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] aslomagic:
Screw it, I installed twrp and LineageOS instead, works like a charm :D Magisk on the other hand, just won't work (even with twrp). I'd still be interested in getting magisk to work, I'm going to miss VoLTE and a couple things found only on stock :/
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Guagno_:
Hi everyone.

I made everything correct. After I've installed the magisk_patched.tar image with the latest firmware, it reboot correctly the system but there is no magisk app.

If I try to install it and open it after the installation it remains stucked on the first image and the system seems to go on crash.

Any suggestion?

Thanks in advance
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Take this version
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Angarmax:
Flash only "AP patched" in Odin, works for me. And verify you've "KG state checking" in download mode
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
Normally it shrink your data size if you only flash the "patched AP file". You must afaik flash all files via odin.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
Original Instructions:

Flash magisk_patched.tar as AP in ODIN, together with the BL, CP and HOME_CSC files. Never flash only an AP file, as Odin can shrink your /data file-system if you do.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Guagno_:
Worked!

thanks :D
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tomas11:
Hi, I've a brand new Galaxy S10 and wanna root it.

Just to clarify, should I root it first and then install the firmware updates (one by one)?

Or can I install the updates first and then root the phone?

I'll follow this guide for rooting: https://www.youtube.com/watch?v=o3a8YnWT3yk

And this one for installing the updates: https://xdaforums.com/showpost.php?p=80076303
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
First update using OTA (download and install updates in the settings app )
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] tomas11:
So rooting the phone with Magisk will keep the updates? I thought you get back to the stock ROM when rooting...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
No.Before rooting update then root.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] GingaRanga:
Broken Link

Um, when I click installation instructions link it bring me to a 404 page not found...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinwu128:
Can I just confirm? the only way to have root is to boot into the recovery partition?

are there any complications when for example my phone reboots itself and goes into the normal mode?

I can see TWRP exists now, Can I root with TWRP these days?

Sorry, it's been awhile for me. Thanks in advanced.

Great work all!
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
If it does not start from the recovery or the 3 keys, then you have no root. But if it is not bad, then start again.

Gesendet von meinem SM-G973F mit Tapatalk
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinwu128:
Thank you sir, sounds good!

Would updating the software just be a matter of patching the latest firmware from magisk manager and using odin to do a dirty flash?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Link to Full instructions H E R E

DO NOT MISS A STEP.

In nutshell:

Unlock bootloader on phone.

Download latest firmware using Samfirm or Frija.

Unzip the firmware and copy AP section to phone.

Install magisk.apk, run and patch file, selecting the AP.

Patch, copy patched file back to PC.

Open Odin and use patched file in AP slot, then use from unzipped firmware BL, CP and CSV.

Flash then DATA WIPE, then reboot.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] hanspampel:
But youll lose all your BT connections and you have to pair your devices again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] kevinwu128:
Oh wow, that must be annoying. I was about to do it until I saw this.

I was just imagining I missed the buttons and it booted normally and I suddenly need to pair it with my car again. how annoying..

---------- Post added at 09:37 AM ---------- Previous post was at 09:36 AM ----------

I realise all this, but what i'm asking is if I want to update it after using this root method.. Will I need to wipe it just to get the latest security patches?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
No you won't have to wipe your phone when Samsung release firmware updates.

Just follow my instructions H E R E

You will keep all your data, apps &settings.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] dr4go:
Again... That depends on the setup. In the multidisabler thread I have asked several times if anybody needs a tutorial how to modify system to be able to boot without Magisk without losing wifi networks or Bluetooth pairings. Nobody cared. ;)

How I am doing it: after patching the AP with Magisk I mount the tar on Linux I replace the two libsecure libs (additional do a small debloat, but this has nothing to do with that) and also modify vendor so that the daemon remains stopped (credits: geiti, topjohnwu, ianmacd).

Yes, I love Magisk (i.e. the systemless modification per se) and am doing everything on top of that by using resetprop and such things... But when I can't boot unrooted without losing the pairings or loose some apps / settings, because I want them to reside on data instead, I'm pissed. :)

Additionally... I have to say, that my G973F is only stable since the first update with the 3rd bootloader (july patches) and it happened way more often before that this stupid brick in my pocket freezed and rebooted itself automatically (=unrooted) before july...
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] bininga59:
He may have thought with complications, when the phone starts by itself, that it has to flash again.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] polarbeerd:
stuck at userdata.img

I followed a guideline on youtube from a guy called max lee (its equal with the official one). First it was staying in the beginning of odin, then I pulled with adb as instruced before in the forum, it worked but now it stays stucks at userdata.img. Idk what is the problem. In youtube the guy only patches with the AP file, do I need to put everyfile in odin or something else is missing? Thanks :))
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
As well as the AP file you need to include the BL, CP and CSC files.

I would suggest starting again from the beginning and

carefully following these instructions : https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root

You might also check when you have the Download screen showing, does the wording KG State : Prenormal appear in the wording at top left of screen.

If yes, flash all stock firmware files including original AP file before trying to root again. After flashing with stock firmware check Download screen again, if Prenormal has changed to Checking you are good to root.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] sflekenec:
I have an issue with Odin.

When flashing stock firmware in Odin, everything's fine. When I try to flash the patched AP (along with the BL, CP and CSC or alone) Odin just crash immediately after pressing I press start.

I tried repatch the AP again and other computer as well. Nothing helped
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] polarbeerd:
thx

Thank you so much for your help, I managed to do it. And I changed my magisk to ianmacd version. Both magisk and the manager are in the last version now. I installed the xposed also and tried couple of tweaks, everything seems to be working fine now. But I have 2 questions.

1- I want everything to be stable now, I have my v4a, xposed, fonts.... Do I have to upgrade both the system and the magisk everytime when there's a new version or since it looks like its stable now, should I stay?

2- Do you know what is the difference between ianmacd version vs canary? Everywhere its written that for s10's, canary is the one. But I read in here that ianmacd works fine, and it works for me also.

Im asking these because I have been trying to make it work since yesterday for 10 hours maybe. I don't want to do all the steps and download all the programs again, takes lots of time. I just want it to be stable :) Thank you so much.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ianmacd:
The ianmacd builds are sometimes slightly ahead of the Canary releases. As such, they're riskier to run, but sometimes contain a fix or a feature not yet available elsewhere.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Never flash the AP file on its own for reasons explained HERE

If Odin stopped immediately it sounds like a firmware incompatibility. Check firstly firmware is for your model, secondly the firmware you are trying to flash is it older then version already installed? Odin just freezes if the bootloader your flashing is older than installed.

Copy Magisk_patched from phone to PC with ADB to avoid any corruption during transfer.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NetSkipper:
So.. Netflix..

I've spent 2 days searching for a solution and it seems that there is none. :(

I have rooted G970FXXU3ASG8, and according to DRM Info, my Security Level is L3. I cannot download Netflix, and even when side-loading an apk, it doesn't work.

My brother has the exact same G970FXXU3ASG8, but not rooted, and his Security Level is L1, and of course he can download and watch Netflix.

Did I miss any solution in the matter, or no Netflix for me? I have a paid HD subscription..

https://www.xda-developers.com/android-netflix-hd-amazon-prime-video-hd-drm/
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Magisk updates are very painless. You get update notifications automatically. Update Magisk Manager, run it, select Magisk update, Install and Direct Install. Then Reboot. All done.

For firmware updates see .....H E R E
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Sumedh_:
Thanks !
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Install via SAI
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Have you tried Magisk Hide?

See ....HERE
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NetSkipper:
Thank you very much!! :victory: It worked!!

https://xdaforums.com/android/apps-games/apk-bundle-netflix-v7-10-0-2019-05-24-t3934574

Yes, I've tried before, it didn't work. Seems that Magisk Hide is not 100% "hiding" the root. For example, Samsung Pass still knows the device is rooted, thus not working.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Aaazv:
Xposed

Guys.

Does xposed work after rooting? Has anyone tested it or not?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
Yep, not the original one by Rovo though, but EDXposed, works brilliantly.

For download and instructions to install EDXposed go here: https://magiskroot.net/download-xposed-for-android-pie/

Install the EDXposed apk file first then open Magisk then install the other 2 downloaded files per instructions

After the 2nd item installed in Magisk hit reboot at bottom of screen.

Open EDXposed, should be Active. Choose your modules. :)
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Firefly__:
Been a long time since I've rooted but I'm getting an s10 soon and was curious if it's possible to root without voiding warranty.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] sflekenec:
The firmware version is ok. I'm flashing the same version of TMZ CSC firmware. When flashing the stock BL, AP, CP and CSC, the Odin passes and everythings ok. When there is patched AP together with stock BL, CP and CSC, Odin's window disappears immediately after hitting Start and nothing happens. I followed the guide step by step from the beginning, also copied the magisk_patched using adb.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
No problem !

For S pay to work go to settings and select hide magisk manager
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] Aaazv:
Hey thx for the answer.

If I normally reboot or turn the device on which wont give me root access, do I still have xposed?
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NetSkipper:
Sorry, didn't quite understand what do you mean.

I used Magisk Hide for almost all Samsung services, including Pass, and it didn't help.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] ExtremeGrief:
Magisk Manager - Settings - Hide Manager
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] NetSkipper:
Unfortunately, it didn't help.
[Samsung Galaxy S10 ROMs, Kernels, Recoveries, & Ot] robbo1947:
No, Xposed would be only active when root is active.

You might consider Firefds Kit [Pie] (an Xposed module) - customization for the power button. You can even rename some of the buttons.