[Galaxy Note 4 Android Development (Snapdragon)] 73sydney:
[MENTION=6363151]mobspyguy[/MENTION] flashed last night. I still get sim death like on Oreo, but its easily revived using RIL control - just like Oreo, RIL in custom ROM just doesnt seem to recover from signal loss like stock does....

My last post to [MENTION=6005084]ripee[/MENTION] i shared that since ive moved house i can only use stock ROM - asmy sim death ramped up and looks like its due to low signal...this is just an fyi...i had been a regular flasher of his (and others) Oreo ROM's, testing for sim death causes....

As for specific feedback on this ROM, just bug feedback, not criticism, this is a first build!:

* Screen rotation - Auto switch does nothing

* Brightness - Auto switch does nothing

* "Phone is starting" - out of the blue while my phone was just sitting there, this happened after booting successfully - note after initial boot my provider "Boost" was showing in the status bar (i have provider turned on as it helps me track sim death), then when "Phone is tarting appeared, the provider had changed to Telstra Mobile (the provider who provides wholesale signal to Boost), then it changed back to Boost and "Phone is starting" again and now is "No Service" and "Phone is starting" again. First time ive seen this, but there it is....please note my earlier comments about low signal and sim death, it may be related. Note it was also after a previous cache and dalvik wipe....just out of the blue...any attempt to swipe to enter desktop met with "phone is starting". Just wiped cache again and rebooted and all is fine....go figure....

* GPS - theres no default NTP_SERVER= set in gps.conf (perhaps an oversight?) - uncommenting one NTP_SERVER= line (or adding it) and setting it to correct ntp pool gives a working GPS

For others, my usual gps.conf guide:

Go along to http://www.pool.ntp.org and find at least your region (on right hand side) if not country (drill down again on region page), and edit /system/etc/gps.conf to edit the necessary lines..

For instance, for me in australia i could use the following (multiple redundancy):

NTP_SERVER=0.au.pool.ntp.org
NTP_SERVER=1.au.pool.ntp.org
NTP_SERVER=2.au.pool.ntp.org
NTP_SERVER=3.au.pool.ntp.org
NTP_SERVER=au.pool.ntp.org
NTP_SERVER=0.oceania.pool.ntp.org
NTP_SERVER=1.oceania.pool.ntp.org
NTP_SERVER=2.oceania.pool.ntp.org
NTP_SERVER=3.oceania.pool.ntp.org
NTP_SERVER=oceania.pool.ntp.org

or to make it even easier, at very least i could use:

Region:

NTP_SERVER=oceania.pool.ntp.org

Or, even better, for Country

NTP_SERVER=au.pool.ntp.org

Its enough to use the simplified version folks, some like to go all out and do the multiple country and/or region lines, its never made a difference for me...

Next, reboot your ROM and test.

An optional step is to use a good gps app (i use GPS Status & Toolbox) and use the Reset function (Menu > Manage A-GPS State> Reset) to clear cached GPS data

GPS works for me on my 910G once the gps.conf is set..

As for Magisk...

18.1 Works just fine, Magisk Manager was present after flashing when i did. Please note i did have to boot it twice after installing some modules to get them to work - this not Pie/ROM specific it was sometimes needed on Oreo too. One module did not work that i usually use (Debloat), but the other regular ones i use worked fine:

* Busybox for Android NDK

* Swap Torpedo <- Everyone should be flashing this on devices with 3Gb+RAM

* Sysconfig Patcher <- to unexempt Google apps from battery optimization

* Youtube Vanced

* Nova Launcher (Pro) (my customised version of submitted Nova Launcher module - includes license - original doesnt)

I have others i normally flash, but i thought id start out with the absolute basics while testing....

Note: Magisk Manager doesnt seem to keep a record of installed modules properly on Pie, every time you go into the Downloads window, it rescans your modules, every time...