yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] sinedoke:
Yes I am. This is my roomservice.xml

<!-- 64-Bit -->
<project name="srgrusso/android_device_samsung_gtaxlwifi" path="device/samsung/gtaxlwifi" remote="github" revision="aicp-14.0_64-bsp" />
<project name="srgrusso/android_device_samsung_gtaxllte" path="device/samsung/gtaxllte" remote="github" revision="aicp-14.0_64-bsp" />
<project name="srgrusso/android_vendor" path="vendor/samsung/gtaxlwifi" remote="github" revision="gtaxlwifi-lineage-16.0_64-bsp" />
<project name="srgrusso/android_vendor" path="vendor/samsung/gtaxllte" remote="github" revision="gtaxllte-lineage-16.0_64-bsp" />
<project name="srgrusso/android_kernel_samsung_exynos7870" path="kernel/samsung/exynos7870" remote="github" revision="pie-m105" />
<project name="srgrusso/android_hardware_samsung" path="hardware/samsung" remote="github" revision="los-16.0" />
<project name="LineageOS/android_packages_resources_devicesettings" path="packages/resources/devicesettings" remote="github" revision="lineage-16.0" />
<remove-project name="AICP/hardware_interfaces" />
<project name="srgrusso/android_hardware_interfaces" path="hardware/interfaces" remote="github" revision="gtaxl-aicp-14.0" />
<remove-project name="AICP/frameworks_native" />
<project name="srgrusso/platform_frameworks_native" path="frameworks/native" remote="github" revision="gtaxl-aicp-14.0" />

I searched in Android.mk for a reference to touch but only found this:

frameworks/native/data/etc/android.hardware.touchscreen.multitouch.jazzhand.xml:$(TARGET_COPY_OUT_VENDOR)/etc/permissions/android.hardware.touchscreen.multitouch.jazzhand.xml \

But I was able to move forward with this changes

-cc_binary {
- name: "vendor.lineage.touch@1.0-service.samsung",
- init_rc: ["vendor.lineage.touch@1.0-service.samsung.rc"],
+cc_defaults {
+ name: "touch_samsung_defaults",
defaults: ["hidl_defaults"],
relative_install_path: "hw",
- // FIXME: this should be 'vendor: true' for modules that will eventually be
- // on AOSP.
proprietary: true,
srcs: [
"GloveMode.cpp",
@@ -36,3 +33,10 @@ cc_binary {
"vendor.lineage.touch@1.0",
],
}
+
+cc_binary {
+ name: "vendor.lineage.touch@1.0-service.samsung",
+ init_rc: ["vendor.lineage.touch@1.0-service.samsung.rc"],
+ defaults: ["hidl_defaults"],
+ vendor: true,
+}

Am I doing this right? It is the first time I'm trying to compile android sources.

Thank you for your help [MENTION=8017005]srgrusso[/MENTION]
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
I may need to update my repos to track AICP's changes and Lineage's Samsung Hardware changes. I would undo what you did. The easiest way for me is to delete the directory and sync. It's time for me to post a new build anyway. After I post the new builds try again.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
New builds

SM-T580 https://www.androidfilehost.com/?fid=1899786940962594395

SM-T585 https://www.androidfilehost.com/?fid=1899786940962594399
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] c1ph4:
Another small review

Hey guys,

in the meantime I was able to test the last build but when using the device I encountered weird issues again. Some of them were already mentioned, though.

Let me explain in detail here. :cool:

CPU weirdness: the issue that one CPU is not shown with its 4 cores is still there, as a user you can check this by installing "Geekbench" and reading the start page. I also tried installing the RR kernel which was recommended in previous posts. From performance side there was no difference (checked it with "Antutu" which gave me a ~85,000 with both, and "Geekbench" which gave me ~145 SC and ~800MC), only the start page of "Geekbench" show no info about the CPUs anymore. Thus, I don't know if the issue is gone after installing the RR kernel. As mentioned above, it makes no difference so IMHO we can stick to the ROM kernel

Widgets not working: some widgets weren't working anymore. Affected apps on my device were "Palabre" which doesn't update anymore at all. Plus, "TuneIn Pro" says as a widget "Faulty blahblah". If you don't use a lot of widgets when using this ROM, this is no big issue. As I read the news with RSS & "Palabre", for me it was

Magisk not running properly from start: I can't explain what when wrong on 1st install, but I couldn't get apps to work with SU at the beginning. The app, no matter which one, wasn't able to get access for SU from "Magisk". The popup to grant this was just missing. I could circumvent this by installing "Magisk" again via the installed app in the ROM. After another reboot I could get this essential popup to work

As these issues persisted I went on and tried another ROM. So far I didn't reach the end, so wish me luck! :good:

Happy flashing & testing, hope this post was helpful to you! ;)
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] jofjof:
Hello

thank you for this powerful, functional and smooth ROM.

However, I have a problem with my headset (normal, not bluetooth).

When I plug it in, the sound doesn't come out through the headset but through the tablet's speakers.

I tested on 2 different tablets (SMT-580) with this ROM. But same result.

Did you encounter this problem on your tablet? If yes, have you found a solution (maybe an option to check in the settings).

Another question:

is it possible to go back to an official ROM (android 7.1) ?

I tried with TWRP, flashed the official ROM but got a black screen and impossible to boot the tablet.

Thank you for your possible answers.

Jof
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] BADA 187:
how do i do that again? :p

EDIT: got the logs trough aicp's handy built-in log interface/zipper.

DATA: it shows signal, I can call and send SMS. But it shows an x in the corner. No internet connection.

GPS: Google Maps picked up my location pretty quick, While Waze showed "No GPS, showing approximate location" and 2 other GPS status app could not lock on.

ROM was overall bitt laggy until I turned off the aicp live wallpaper and it was butter smooth.

[MENTION=5480152]followmsi[/MENTION] I did use the zip file you posted with updated kernel.( result was identical on stock kernel that came with ROM)

Here is link to logs. https://drive.google.com/file/d/1ySa4y-hJb7kRI_iTpNKrFhxS5uW7dysu/view?usp=drivesdk
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
No i didn't, looks like I have some studying to do. Do I need to apply all the patches listed or just certain ones?
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
For my last ROMs I was using this patch only ..

https://github.com/phhusson/platfor...mmit/62d721e6c289d567871367dbfd1c7626c3edeac9

Valera did replace both repos completely .. and wanted to check which code is actually blocking/missing in lineage/aicp repos.

Just replace both repos completely.

Should still build fine for lte.

Cheers

---------- Post added at 21:51 ---------- Previous post was at 21:45 ----------

Thanks for testing.

Data is missing patch to make it working .. next build.

What means gps apps could not lock on ?

No 3d fix ?

Does it show "off" ?

Pls use "GPS test" app and do clean and update AGPS data via settings menu..

Logs are not able to download.

Cheers
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] BADA 187:
Ah crap! Gdrive went all bananas.

GPS turns "on" but The gps test app I used could not find any satellites.

Here is new link: https://mega.nz/#!0bAxXIZb!cMn0PMhoqFVCo_R5l4fkFrrvTa_ybATvc38NObB64d0

EDIT: I downloaded the app you mentioned and opened it it took a little bit but the 3D fix was successful.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
I'm sorry, I'm still learning. I never applied a patch before. Can you point me in the right direction.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] DILTON:
Does this rom have additional customization like that of crdroid and RR?
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Yes.

Here is a link to the AICP website features page. https://github.com/AICP/vendor_aicp/blob/p9.0/FEATURES.md
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] DILTON:
Ok then I'm downloading it
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
Good news !

Just to confirm .. You have 585 and you get 3d fix in GPS test app!

Perfect !

Are you able to post screenshot for the other 585 users ?

Topic GPS for 585 should be closed now.

Mobile data is on its way :)

Thanks for your help !

---------- Post added at 09:59 ---------- Previous post was at 09:48 ----------

You will need to use console ..

git clone your original repo

git checkout aicp14 branch

git remote add phhuson repo url

git fetch remote (phhuson)

git cherry-pick commit number.

git push origin aicp14branch

You may have a look for some git doku.

Not too hard to learn ..

Cheers
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] BADA 187:
[MENTION=8017005]srgrusso[/MENTION] [MENTION=5480152]followmsi[/MENTION],Here you go!

Working GPS on T585!

The pic is from testing indoors (in the house and tablet was @ the window)
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
Thanks a lot for your help !

Topic GPS is definitely closed !
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] mnd123:
Well, I'm still struggling.. The device always freezes when an app is trying to use location (when the location icon shows up in status bar), on almost all pie roms (didn't try the pixel experience yet).

Guess I messed something up. If I restore the stock rom backup, the gps works fine though.

Maybe I should try flashing the stock rom with odin and start from the beginning. Is there a difference between wiping everything with twrp and flashing stock rom with odin? And do I have to unlock the bootloader again this way, or it is enough to flash twrp with odin afterwards and then install a custom rom as usual?

Edit: after letting the tablet sit for a few hours, the gps seems to be working now. Hope this applies to all pie roms for our devices.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] BADA 187:
another 2 tiny bugs i found

home button does not wake device.

and download progress does nof always show when downloading files. (browser/nas/ google play/etc..)

the download progress issue is a aicp issue itself as this same bug is also on my htc m8 running aicp pie
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
This change below should fix "home button" :)

https://github.com/followmsi/androi...mmit/c181634d4cb120b64e5e7fcae6cc485e65302583

https://github.com/followmsi/androi...mmit/f9ee3003de010dcc38e5098d55ab856275d5026b

Other stuff, especially if it happens the same way on other devices, are very often general AICP problems .. to be solved by them !

Thanks for all your help !

[MENTION=8017005]srgrusso[/MENTION]

Please pull latest change for both devices.

Cheers
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] DILTON:
When it freezes, always press the power button for the screen to go off and then unlock the screen
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Thanks! I hope to work on this this weekend. I prefer using console for doing things anyway. I pulled your updates into my repository. But before I do any more building I would like to fix an error I'm getting when I issue the make mpropper command.

make mpropper | tee logs.txt
=============================================================
HOST_ARCH=x86_64
HOST_2ND_ARCH=x86
HOST_OS=linux
HOST_OS_EXTRA=Linux-4.20.2-arch1-1-ARCH-x86_64-Arch-Linux
HOST_CROSS_OS=windows
HOST_CROSS_ARCH=x86
HOST_CROSS_2ND_ARCH=x86_64
=============================================================
AICP_VERSION=
BUILD_ID=PQ1A.190105.004
OUT_DIR=/mnt/UserData/Projects/Android-Source/AICP-14/out
=============================================================
PLATFORM_VERSION_CODENAME=REL
PLATFORM_VERSION=9
TARGET_PRODUCT=aosp_arm
TARGET_BUILD_VARIANT=eng
TARGET_BUILD_TYPE=release
TARGET_GCC_VERSION=4.9
TARGET_ARCH=arm
TARGET_ARCH_VARIANT=armv7-a-neon
TARGET_CPU_VARIANT=generic
TARGET_2ND_ARCH=
TARGET_2ND_ARCH_VARIANT=
TARGET_2ND_CPU_VARIANT=
=============================================================

ninja: no work to do.
[1/1] /mnt/UserData/Projects/Android-Source/AICP-14/out/soong/.bootstrap/bin/soong_build /mnt/UserData/Projects/Android-Source/AICP-14/out/soong/build.ninja
FAILED: /mnt/UserData/Projects/Android-Source/AICP-14/out/soong/build.ninja
/mnt/UserData/Projects/Android-Source/AICP-14/out/soong/.bootstrap/bin/soong_build -t -l /mnt/UserData/Projects/Android-Source/AICP-14/out/.module_paths/Android.bp.list -b /mnt/UserData/Projects/Android-Source/AICP-14/out/soong -n /mnt/UserData/Projects/Android-Source/AICP-14/out -d /mnt/UserData/Projects/Android-Source/AICP-14/out/soong/build.ninja.d -o /mnt/UserData/Projects/Android-Source/AICP-14/out/soong/build.ninja Android.bp
error: vendor/aicp/build/soong/Android.bp:30:8: module "generated_kernel_includes": cmd: unknown variable '$(KERNEL_MAKE_FLAGS)'
ninja: build stopped: subcommand failed.
21:20:10 soong bootstrap failed with: exit status 1

#### make failed to build some targets (5 seconds) ####
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
https://github.com/phhusson/treble_experimentations/issues/303

But your problem is definition of mrproper at this point.

Its used inside kernel sources .. but not in android build tree.

For Android use in top level ..

make clean

and/or

make clobber

make clean && make clobber

Hope this solves your issues ..
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Now I feel stupid. I got confused. Thanks! :laugh:
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] mnd123:
Will do, if it continues to freeze on the new rom(s). Previously when it froze, after a few seconds the tablet didn't respond to the power button. But maybe it would work if the power button is pressed right away. Thanks.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] Greenchain:
Project Treble

Why not port project treble by repartitioning
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
This has been done, but hasn't seen any development for a while.

https://xdaforums.com/galaxy-tab-a/development/sm-t585-treble-project-t3834538
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Pulled the updates, synced, and rebuilt. Wiped system data dalvik and cache. Flashed the new build and the home button wake problem still persists. :(
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
https://gerrit.aicp-rom.com/c/AICP/frameworks_base/+/77954

AICP uses his own files .. Have changed accordignly now.

https://github.com/followmsi/androi...mmit/9f59fb65dd2e752c1f66665c637b61d0292d4717

https://github.com/followmsi/androi...mmit/6d4bfa826376843abb712cd10d97ad7ffa7a1559

You need to checkout my branch onto your console .. and force push to your branch.

No need to work via GitHub website pull requests.

Pls change maintainer on "your" sources and just push your changes from console into your gituhb.

If you find new stuff or other corrections I can pull / cherry-pick from you.

Yes .. you will learn it quickly :)

Cheers
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] DILTON:
How do i pass magisk safety net on this rom?
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Which build are you using? Safety net was fixed in build 20190117.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Thanks I really appreciate your confidence. I did git clone and force pushed to my remote repo. I rebuilt the T580 rom and still no wake with the home button. Not sure if I am missing something or if there is still a bug. Now I just need to learn "cherry pick" so I can patch and build the T585 rom.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] DILTON:
Can you please share me the link to that build I'm on T585
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] BADA 187:
ive only seed an build from 17 thatbwas for the 580.

im also on the older one and used the magisk module called (MagiskHide Props Config)

I just used the pixel fingerprint wich is also using pie. passes cts and safetynet (no issues nothing)
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
One more change ..

https://github.com/followmsi/androi...mmit/9e25d6ec63dbe78c7c0991e051d8e252c5a0b0d2

https://github.com/followmsi/androi...mmit/cbfcd35e8a0cf29ce926e2d456c869ee009aaf95

You can build "framework-res" only .. ( make framework-res ) and replace it in system to check this.

One other idea ... to remove this line for building.

https://github.com/followmsi/androi...ifi/blob/aicp-14.0_64-bsp/BoardConfig.mk#L102

Otherwise we do the same stuff as on all other devices and roms ..

Cheers
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] Greenchain:
But the cache parturition doesn't work and because of that yt won't load. I mean to literally repartition something else such as a SD card or Internal Storage. EDIT: You cannot repartition internal since it is probably mounted. Repartition SD card so about 1 GB is for cache.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
The latest changes you made to aicp_config.xml and config.xml fixed the home button wake. :)
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
New build for the T580.

https://www.androidfilehost.com/?fid=11410963190603905833

20190122

Home button wake fixed. Thanks [MENTION=5480152]followmsi[/MENTION]

:D
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] reddb7:
Great ROM! Disabling hardware keys option works on this one.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
New test build for the T585.

https://www.androidfilehost.com/?fid=11410963190603907132

20190124

Exfat, NFS and CIFS filesystem support added. Thanks [MENTION=5480152]followmsi[/MENTION]

Fixed Magisk SafteNet (new fingerprint). Thanks [MENTION=5480152]followmsi[/MENTION]

Home button wake fixed. Thanks [MENTION=5480152]followmsi[/MENTION]

Add route to gateway on null netmask patch

Please leave me feedback.

Thanks :fingers-crossed:

Edit: Added changelog
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] DILTON:
Any changelog?
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Sorry, I didn't have time. It's been added.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] Diabolus_Musica:
T580 here, my tablet crashed into a reboot loop when I formatted my sd card for internal storage then tried to move the files over to the card.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
This is a common problem that's been around since Nougat. When I tried to format any card over 32GB as adopted storage I had this problem. Unfortunately these Tablets only have 16GB. Using a sd card as adopted storage has some major drawbacks too. The sd card prematurely dies because it's not designed for so much read and writes. Also the sdcard can't transfer info as fast as your internal storage which will slow down your tablet. To get it out of boot loop just remove your sd card. Before you put it back in, format it on your computer.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] Diabolus_Musica:
Thanks for the info. My point was that it happened on this rom and not others on here that I've tried. I'm not saying it's a problem with this rom, I'm just reporting it. I've formatted my card as adopted storage many times before with these roms. I'll tell you a major drawback: having only 16GB internal storage and only being able to install like 1/10th of my apps lol. Thanks again for taking the time to explain some of these things.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
I agree.

I'll try it myself and see if I can't replicate the problem.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] Jamess27:
Try using apps2SD, works for me on lineage 16
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] reddb7:
I have a 128gb sdcard formatted as internal storage and my apps work fine.

What types of files did you move? What folder path did you move them to?
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] Diabolus_Musica:
When the card is set up as internal storage it just says "move" and when you press that button it shows a percentage until complete. You don't pick a folder path to move the files. Once that's done and you install apps, the apps get installed to the sd card. What I did was the initial setup, then I immediately formatted the card as internal storage. Once I clicked "format as internal" it rebooted. I've done this in two orders in the past successfully on other roms:

1. format as internal --> install all apps

or 2. install apps until there was no more space in the internal memory --> format as internal --> installed the remaining apps

No matter what I install or what method I used above I never had to choose any folder path to install to.

Thanks,

---------- Post added at 07:18 PM ---------- Previous post was at 07:16 PM ----------

I'm familiar with that app but once internal (adoptive) storage is enabled I don't see any need to use that app or other apps like it.

---------- Post added at 07:20 PM ---------- Previous post was at 07:18 PM ----------

Thanks srgrusso. It's possible it was just something I did incorrectly but I'm not sure so I figured I'd mention it. I'll try the install again and see if I can replicate it.

EDIT: OK I just replicated it again. I was wrong about when it happens though. It didn't crash into a reboot loop when I pressed the "move" button, it happened when I pressed "format as tablet storage". As soon as it tried to format the sd card as tablet storage it crashed.

Thanks,
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] reddb7:
The reason I asked for a folder path was because I'm using it as internal storage and moved a bunch on apps to SD.

I had clean flashed the rom and didn't see the crash. could it be related to Data partition not being wiped from the previous rom you were on?

Can you try to wipe clean if you haven't already?
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] Diabolus_Musica:
I did a data wipe before I installed the rom both times. It's the same method I used for several other custom roms and I haven't had that issue on those.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] followmsi:
Magisk installation has to be removed for formatting sdcard as internal storage .. do I remember correctly ?

Have a try without Magisk ..
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] TheArtfulPenguin:
This seems to be the best ROM I've put on my 580... with a couple of issues. If those were resolved then I'd say 10 out of 10 in rating.

The release notes say that the Home Button wake issue is resolved. For me it doesn't work. I have TWRP 3.2.3.4, did a full wipe, and then even did a advanced and wiped everything. Installed aicp_gtaxlwifi_p-14.0-UNOFFICIAL-20190122.

The camera doesn't work. It open, and doesn't lock up, however if I record a video and then go to in any player it says it can't play it. It the video have the single image with sound in the background but no change from the first image.

I'll try some different camera settings. Also I have a couple of apps that use the camera. KIK and WeChat. It does show the image but if I hit record it then locks up.

This rom on the SM-t580 is great with everything else I have tried.
[Samsung Galaxy Tab A series ROMs, Kernels, Recover] srgrusso:
Do you have on screen navigation bar with swipe gesture enabled? If you do you have to disable hardware keys and then the home button won't work.

Which camera app are you using? AS far as the video goes it might be a codec problem.