yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] :
I guess, you've related to my response. I really hate postings, which arn't a question nor a statement, but subtext. This always leads up to pointless conversations and ends up in writing some basics.

Other then e.g. zfs f2fs has a fixed design (https://www.kernel.org/doc/Documentation/filesystems/f2fs.txt ). This means the fs structure written on the physical memory cells will stay the same on f2fs if the kernel driver is updated. This means the bare fs on the "disk" is the same, no matter which f2fs-tools version or which kernel driver version is used. It just doesn't matter which which f2fs-tools (and kernel driver for this matter) are used to generate the fs. The same goes for fsck. Probably newer f2fs-tools and newer f2fs kernel driver backports are faster (IMHO it doesn't matter if mkfs or fsck is some percent faster or slower).

That doesn't mean it's not desired to use the newest backports (with regards to fixes, code cleanups and/or improobememts), it just means the fs itself is the very same. The operating performance may differ with f2fs kernel driver versions.

Though the write performance degredation on ~60% used f2fs is by design, we hope that especially the gc patches will help here. But the main reason to include the backported f2fs commits is just about fixes.

The above is true for working f2fs-tools and kernel drivers. E.g. a broken mkfs will not generate a working f2fs. Or if mkfs is used in a way that the encyption footer is not reserved. We've seen both in the evolution of op3/t twrp (broken mkfs dates back over 3 years, footer issue has been addressed round about a year ago).

There is no reason to reformat data. As already explained, the actual fs is the same. The reason why a freshly fprmated data partition "feels" faster, is a mixture of perception, wishing and the fact, that a 30% used fs is faster then a 70% used fs (sidenote: it's the same for all fses; the difference is larger on f2fs then on ext2/3/4; on fat32 it's even worth).
[OnePlus 3 & 3T Cross Device Development] votz11:
amazing rom

curent stats: f2fs test build + gapps + magisk ( data f2fs)

encrypted

drain 1%-3% over night

no lags and smooth until now

good work
[OnePlus 3 & 3T Cross Device Development] knpk13:
I'm not sure if the post if you just wrote about f2fs was basic (I doubt a non dev googling f2fs would be able to find a complete accessible description), but thank you for the informative explanation; always been a little confused by the backward compatibility of f2fs.
[OnePlus 3 & 3T Cross Device Development] SenseSei:
My response wasn't directed at you and I'll try to avoid posting subtext.

Thanks for the detailed explanation!

Edit (31.07.20):

Running the f2fs test build on ext4 for 3 days without issues. Will try f2fs when I have some spare time
[OnePlus 3 & 3T Cross Device Development] :
I havn't expirienced this. But since f2fs performance depends heavily on the usage of the partition, I just may not hitting this, so far (data usage <60%). That's why thorough testing by as many useres as possible is so important.

Any more feedback? Oppinions: should nlos use the f2fs backports and gc fixes?
[OnePlus 3 & 3T Cross Device Development] 64ashg:
Yes in my opinion it should, highly recommended. I was using my f2fs data partion with 37-45% usage only. So my observations comes from that.

Also, i used cache in both ext4 and f2fs for a few days each. Unoptimized apps opened faster, eg paytm app (real **** show even on sd855) in f2fs but with well made apps, apps whose developers use googles' material design and coding standards, googles own apps, lineage apps, Francisco francos apps, etc, no improvements whatsoever.
[OnePlus 3 & 3T Cross Device Development] a0879:
Have been using this rom for few weeks and found it amazing...

I just tried to change system fonts to my liking but was unable to do so as magisk font changer is down for maintenance, also magisk avfonts zip and twrp flashable font zips both are doing nothing..??

Am I missing something or is there any other way to change my system fonts..?? ?

My set up : op3t - nlos 2407 + open gapps + magisk 20.4
[OnePlus 3 & 3T Cross Device Development] :
Logs. (At least for the twrp flashable zip a recovery log - I've never debugged magisk mpdules, so I don't know if a recobery log is usefull.) And a link to the zips in question, of course. BTW: which version of twrp are you using?
[OnePlus 3 & 3T Cross Device Development] a0879:
Twrp : 3.4.0.0

Zips from here:https://xdaforums.com/android/themes/fonts-flashable-zips-t3219827/amp/

Twrp logs: attached

'since magisk avfont modules were also not working so I tried installing twrp font zips'
[OnePlus 3 & 3T Cross Device Development] :
That's a dmesg but not a recovery log from the flashing session. (TWRP-Main screen->Advanced->Copy log)

The zip is not fixed for android 9 or later recoveries: it uses busybox, which is no longer present in recent twrps. Replace busybox with toybox in updater-script. Always check the recovery log after flashing.
[OnePlus 3 & 3T Cross Device Development] a0879:
Thanks for your prompt help on these outdated font zips, your help saved me a lot of time and mess with these font zips..

Infact I found and installed some new magisk flashable fonts on telegram and they are working absolutely fine with Nlos...

(I don't know if it is okay to share outside links here on XDA...? )

Thanks again for the Nlos...
[OnePlus 3 & 3T Cross Device Development] :
UPDATE (August Security Patch; kernel: f2fs & upstream; Webview: 84.0.4147.121)

Build 20200808

Releasenotes:

This build relies on OxygenOS firmware. OxygenOS 9.0.6 firmware is required. At this point you have two options:

You don't care about loosing data on an unlocked bootloader and clean flash including format userdata according to the first time installation instructions in OP (recommended):

Oneplus 3T: OxygenOS 9.0.6 firmware without alipay and soter files

Oneplus 3: OxygenOS 9.0.6 firmware without alipay and soter files

You want to keep your current setup and like to dirty flash on top of beta builds:

I've created a firmware package from OxygenOS 9.0.6. To avoid issues due to an unlocked bootloader and/or encrypted userdata partition, I've kept the bootloader and and keymaster partition to OxygenOS 5.0.8. This allows to run the pie-blobs builds with native Oneplus OxygenOS 9.0.6 firmware, but you don't need to reformat the userdata partition (for details see: https://xdaforums.com/oneplus-3t/how-to/guide-cope-9-0-3-5-0-8-firmware-barrier-t3941164 ).

Oneplus 3T: OxygenOS 9.0.6 firmware with 5.0.8 bootloader and keymaster and without alipay and soter files

Oneplus 3: OxygenOS 9.0.6 firmware with 5.0.8 bootloader and keymaster and without alipay and soter files

If you need to pass safetynet api flash sec-patch-2019-08-01_v02.zip from https://xdaforums.com/oneplus-3/one...-nlos-16-0-t3879405/post78433987#post78433987 .

Before you ask: though I've updated the blobs used in the rom to OOS 9.0.6, I've decided to stick with OOS 9.0.5 build fimgerprint, because 9.0.5 is the only version with identical fingerprint strings for op3 and op3t.

If you want to use Alipay with fingerprint authentication, follow [MENTION=9998549]Galiis[/MENTION]' directions in posting #6.

For a complete list of additional cherry picks see: current.pick.sh.

Changelog (Last repo sync: 8 Aug 2020, 09:28:23 CEST / 8 Aug 2020, 07:28:23 UTC):

Patch up: P_asb_2020-08. — Nvertigo

Update webview to 84.0.4147.121. — Nvertigo

see https://bitbucket.org/nvertigo/android_external_chromium-webview/src/master/patches/ for a complete list of patches

kernel: upstreamed to https://android.googlesource.com/kernel/common/+/8490f56ce46a982b1e49910041621c33c80cc9dd including https://android.googlesource.com/kernel/common/+/refs/tags/ASB-2020-08-05_3.18 — [MENTION=7929484]MSe1969[/MENTION]

Updated f2fs kernel drivers — Nvertigo (for the complete list of f2fs patches see: https://xdaforums.com/showpost.php?p=83130149&postcount=1672 and https://xdaforums.com/showpost.php?p=83130149&postcount=1673 )

WireGuard v1.0.20200729 — Jason A. Donenfeld

NLOS-Bootlogo

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip(pre ob16 OxygenOS Bootlogo)

[SIZE="+2"]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3 & 3T Cross Device Development] :
I havn't forgotten the update - I'm hunting an ugly usb bug:

Would someone try this please:

attach an usb3 mass storage device (aka usb3 stick)

use the rom shipped file manager to browse the content of the usb3 stick

quit the file manager and umount the usb3 stick from pulled down notifications EDIT: and remove the usb3 stick from the op3/t

let the screen off timeout kick in and wait 2 minutes

wake up the device

Thanx in advance.
[OnePlus 3 & 3T Cross Device Development] phoberus:
worked fine for me with 15s display timeout and an NTFS formatted SSD (Sandisk Extreme Pro Portable SSD, 1.0TB, USB 3.1)

edit: hotspot was turned on and magisk installed, I don't know if that is crucial
[OnePlus 3 & 3T Cross Device Development] MSe1969:
OUCH !!! :(

Did it with an OTG adapter and USB stick (no clue whether it was an USB3 or not, but does not matter).

After unmount, I observed, that the USB stick itself still showed activity, but the file browser does not show the USB stick as mounted. After unplugging, the launcher freezes, then the phone gets dark and all you can do is a forced reboot by pressing on/off and vol-up. Have downgraded to the August build and tried the same (to see, whether it comes from the recent kernel patches): Same result!

Further observation: After unmount, a different file manager (Amaze) still shows the OTG device in its device list, but when trying to access, it calls the shipped file manager, which claims that the OTG is not reachable.

So seems, that the unmount is not properly performed.

Next try:

Did the same with my Huawei P9 (LineageOS 16.0 Treble build plus custom kernel) - all works fine.

Hence: The issue is not platform related, but specific to the OP3T device (kernel or device config or blobs or firmware)
[OnePlus 3 & 3T Cross Device Development] :
I'm low on time today. Just to avoid double work/testing:

It's the kernel. Proof: this one (based on my not upstreamed behind 3.18.140 kernel with qcacld 7800 update and f2fs patches) https://github.com/nvertigo/android_kernel_oneplus_msm8996/tree/tmp works.

I've tested with SanDisk Ultra USB 3.0 USB Device 128GB fat32.

The crash is extremely hard: the last line in pstrore/ramops-console is "Call Trace:" - the interesting part is missing. Even a "regular" panic isn't triggered; it's just hard crashing.

First I thought it's the xhci driver, but considering [MENTION=5499170]phoberus[/MENTION] feedback it may be fs related.

It's not toolchain related, nor f2fs patches related, nor frameworks related.

EDIT: [MENTION=5499170]phoberus[/MENTION]: Just saw your posting in the mad kernel thread - to avoid misunderstandings: which kernel did you use when testing unmounting?
[OnePlus 3 & 3T Cross Device Development] SenseSei:
I didn't see any weird behavior after I did everything on your list, only after the removal of the stick.

Everything went without problems until I removed the USB stick (3.0 attached with the original OnePlus OTG adapter) from the phone.

Screen froze immediately and faded away into a black brick.

Prior to that I couldn't see the unmounted USB device in the stock file manager nor in Solid Explorer. (as expected)

I use your latest Rom on ext4 completely stock, except magisk and a light underclock.

Basically what MSe1969 already reported but I couldn't observe activity of the stick (the LED wasn't active)

Edit: I took a syslog after the hard crash. If it helps I can send it to you via PM
[OnePlus 3 & 3T Cross Device Development] Galiis:
USB: PNY USB3.0 device (NTFS)

OS: NLOS-20200808

It's weird. It works great before unplugging the OTG adapter.

browse files of usb device -ok

eject the usb stick from notification - ok

wake up the phone - ok

unplug the USB stick - ok

unplug the OTG adapter - phone dead(need hard reboot)

The screen freezing and getting dark even if I plug the OTG adapter (no USB device) then unplug it. Then, I test the same with my Redmi Note 7 (MIUI 11, Android 10), it works great.
[OnePlus 3 & 3T Cross Device Development] :
Sorry, my bad! I would have sworn I've mentiined that... (Added in original posting.)

For me the op3/t freezes some seconds after the screen switches off (after removing the usb stick, of course). Anyway, we talk about the same expirience.
[OnePlus 3 & 3T Cross Device Development] :
[MENTION=7929484]MSe1969[/MENTION]:

I think I found the culprit:

The problem is that timer_pending and del_timer (defined in include/linux/timer.h to be called with "const struct timer_list *") is actually called with "struct delayed_work" (defined in drivers/usb/host/xhci.h) in drivers/usb/host/xhci.c.

Reverting

https://github.com/lin16-microg/and...mmit/1b946b121482289143456ada5327fdc15ee885e0

and

https://github.com/lin16-microg/and...mmit/2fd58669ee588aad1c649f97c4a7726f0409f79f

as done in

https://github.com/nvertigo/android_kernel_oneplus_msm8996/commits/nlos-16.0

fixes the issue for me.

I guess something is missing (backport failure, mismerge or incomplete merge) - until we find the reason reverting these two is absolutly fine for me.

[MENTION=9350973]All[/MENTION]:

Update will be shipped tomorrow or Sunday.
[OnePlus 3 & 3T Cross Device Development] MSe1969:
Thanks - that fixes it also for me/my build!
[OnePlus 3 & 3T Cross Device Development] :
Update uploaded to the usual location. Anouncement/Changlog: Tomorrow. ;)
[OnePlus 3 & 3T Cross Device Development] :
UPDATE (Sep. Security Patch; Kernel upstreamed; webview: 85.0.4183.110)

Build 20200912

Releasenotes:

This build relies on OxygenOS firmware. OxygenOS 9.0.6 firmware is required. At this point you have two options:

You don't care about loosing data on an unlocked bootloader and clean flash including format userdata according to the first time installation instructions in OP (recommended):

Oneplus 3T: OxygenOS 9.0.6 firmware without alipay and soter files

Oneplus 3: OxygenOS 9.0.6 firmware without alipay and soter files

You want to keep your current setup and like to dirty flash on top of beta builds:

I've created a firmware package from OxygenOS 9.0.6. To avoid issues due to an unlocked bootloader and/or encrypted userdata partition, I've kept the bootloader and and keymaster partition to OxygenOS 5.0.8. This allows to run the pie-blobs builds with native Oneplus OxygenOS 9.0.6 firmware, but you don't need to reformat the userdata partition (for details see: https://xdaforums.com/oneplus-3t/how-to/guide-cope-9-0-3-5-0-8-firmware-barrier-t3941164 ).

Oneplus 3T: OxygenOS 9.0.6 firmware with 5.0.8 bootloader and keymaster and without alipay and soter files

Oneplus 3: OxygenOS 9.0.6 firmware with 5.0.8 bootloader and keymaster and without alipay and soter files

If you need to pass safetynet api flash sec-patch-2019-08-01_v02.zip from https://xdaforums.com/oneplus-3/one...-nlos-16-0-t3879405/post78433987#post78433987 .

Before you ask: though I've updated the blobs used in the rom to OOS 9.0.6, I've decided to stick with OOS 9.0.5 build fimgerprint, because 9.0.5 is the only version with identical fingerprint strings for op3 and op3t.

If you want to use Alipay with fingerprint authentication, follow [MENTION=9998549]Galiis[/MENTION]' directions in posting #6.

For a complete list of additional cherry picks see: current.pick.sh.

Changelog (Last repo sync: 12 Sep 2020, 19:59:28 CEST / 12 Sep 2020, 17:59:28 UTC):

Patch up: P_asb_2020-09. — Nvertigo

Update webview to 85.0.4183.110.. — Nvertigo

see https://bitbucket.org/nvertigo/android_external_chromium-webview/src/master/patches/ for a complete list of patches

kernel: upstreamed to https://android.googlesource.com/kernel/common/+/refs/tags/ASB-2020-09-05_3.18 — [MENTION=7929484]MSe1969[/MENTION]

Revert "xhci: Use delayed_work instead of timer for command timeout" — Nvertigo (HEAD, nvertigo/nlos-16.0, m/nlos-16.0, m/lineage-16.0, github/nlos-16.0, nlos-16.0

Revert "xhci: Fix race related to abort operation" — Nvertigo

WG: squash WireGuard-linux-compat-1.0.20200908. — Nvertigo

NLOS-Bootlogo

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip(pre ob16 OxygenOS Bootlogo)

[SIZE="+2"]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3 & 3T Cross Device Development] phoberus:
For testing I was using the stock kernel and all partitions are ext4. I was just testing a little bit the battery and speed difference. I tried to proceed exactly as you explained, but had no freeze.

btw: I can also say that there isn't a need for custom kernels for this rom, only a small increase in speed and some minor bugs. Going now back to stock kernel with the new build
[OnePlus 3 & 3T Cross Device Development] :
Anyway, it's fixed.

BTW: [MENTION=7929484]MSe1969[/MENTION]: I've examind the original android-3.18 sources. I'm pretty sure it's an incomplete backport of the delayed_work stuff to android-3.18 and not your merge.

Did you try (per app) performance profiles?
[OnePlus 3 & 3T Cross Device Development] phoberus:
No, but good idea to try it. I tested the app "helix engine" in the past, which could change governor parameters per app.

Thanks for the fix:highfive:
[OnePlus 3 & 3T Cross Device Development] MSe1969:
Thanks for having an own look. I also could not see any obvious merge/pick faults in regards to those two commits. So let's keep them reverted for the time being and see, whether there will be further fixes in that area.
[OnePlus 3 & 3T Cross Device Development] :
UPDATE (Octoner Security Patch; Kernel upstreamed; webview: 86.0.4240.73)

Build 20201007

Releasenotes:

This build relies on OxygenOS firmware. OxygenOS 9.0.6 firmware is required. At this point you have two options:

You don't care about loosing data on an unlocked bootloader and clean flash including format userdata according to the first time installation instructions in OP (recommended):

Oneplus 3T: OxygenOS 9.0.6 firmware without alipay and soter files

Oneplus 3: OxygenOS 9.0.6 firmware without alipay and soter files

You want to keep your current setup and like to dirty flash on top of beta builds:

I've created a firmware package from OxygenOS 9.0.6. To avoid issues due to an unlocked bootloader and/or encrypted userdata partition, I've kept the bootloader and and keymaster partition to OxygenOS 5.0.8. This allows to run the pie-blobs builds with native Oneplus OxygenOS 9.0.6 firmware, but you don't need to reformat the userdata partition (for details see: https://xdaforums.com/oneplus-3t/how-to/guide-cope-9-0-3-5-0-8-firmware-barrier-t3941164 ).

Oneplus 3T: OxygenOS 9.0.6 firmware with 5.0.8 bootloader and keymaster and without alipay and soter files

Oneplus 3: OxygenOS 9.0.6 firmware with 5.0.8 bootloader and keymaster and without alipay and soter files

If you need to pass safetynet api flash sec-patch-2019-08-01_v02.zip from https://xdaforums.com/oneplus-3/one...-nlos-16-0-t3879405/post78433987#post78433987 .

Before you ask: though I've updated the blobs used in the rom to OOS 9.0.6, I've decided to stick with OOS 9.0.5 build fimgerprint, because 9.0.5 is the only version with identical fingerprint strings for op3 and op3t.

If you want to use Alipay with fingerprint authentication, follow [MENTION=9998549]Galiis[/MENTION]' directions in posting #6.

For a complete list of additional cherry picks see: current.pick.sh.

Changelog (Last repo sync: 7 Okt 2020, 17:42:15 CEST / 7 Okt 2020, 15:42:15 UTC):

Patch up: P_asb-2020-10. — Nvertigo

Update webview to 86.0.4240.73. — Nvertigo

see https://bitbucket.org/nvertigo/android_external_chromium-webview/src/master/patches/ for a complete list of patches

kernel: upstreamed to https://android.googlesource.com/kernel/common/+/5e150a725c1fda0e9c4981b33db3f7c216a7766c

which includes https://android.googlesource.com/kernel/common/+/refs/tags/ASB-2020-10-05_3.18 — [MENTION=7929484]MSe1969[/MENTION]

NLOS-Bootlogo

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip(pre ob16 OxygenOS Bootlogo)

[SIZE="+2"]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3 & 3T Cross Device Development] xdam57733:
Hello.

Looks like the three-finger screenshot is gone? Is that on purpose?

Thanks
[OnePlus 3 & 3T Cross Device Development] :
Thanx for the heads up. Rebuilding. Later tonight, or tomorrow.

EDIT: broken build deleted - fixed build uploaded. Thanx again. Sorry for the inconvenience to all, who downloaded the broken build!
[OnePlus 3 & 3T Cross Device Development] xdam57733:
Thanks for the quick fix.
[OnePlus 3 & 3T Cross Device Development] gamernabby:
Quite a informative read.

Can you please suggest a recommended version of Gapps.
[OnePlus 3 & 3T Cross Device Development] :
Most important: please help us keeping this thread readable by only quoting, what you are directly refering to. Quoting 4Kb of text for a ~50 byte question is not usefull. Pleasd edit your quoting accordingly.

For this rom the recommendation is in the OP. For other roms search and read the other roms thread and make an educated decision based on the threads information as well as on the general thoughts on gapps you've quoted.
[OnePlus 3 & 3T Cross Device Development] MSe1969:
Hi all,

in my thread, I got feedback, that the lastest kernel upstreaming for October ASB has a negative impact on native wireguard functionality:

See https://xdaforums.com/showpost.php?p=83692993&postcount=201 (and related)

As this build picks the kernel tags from "my" kernel, I would like to make you aware / would like to ask whether you experience the same?

Thanks, M.
[OnePlus 3 & 3T Cross Device Development] gamernabby:
Ok, please accept my sincere apologies, I am new to this forum thingy also mobile phone world, I just got my first ever mobile device, I am still learning and I'll try learning how to reply using proper quotations and other formatical and grammatical things.

I was looking for an educated and straightforward answer, like just a suggested version number rather than generic "search the thread" kind of reply. I consider such reply pretty unhelpful as searching a thread consisting hundreds of pages is practically an insurmountable task for an average joe. But thanks anyways.
[OnePlus 3 & 3T Cross Device Development] :
I've read the conversation. Since azire has droped the free vpn I've currently nothing to test but the wireguard demo endpoint:

adb shell cat /sdcard/Download/wireguard-demo.conf
[Interface]
Address = 192.168.4.219/32
PrivateKey = aBAwpWFNNAGQ7WDlagZWQ0oAaYi188jTQBjPmbNuuX8=
DNS = 8.8.8.8, 8.8.4.4

[Peer]
PublicKey = JRI8Xc0zKP9kXk8qP84NdUQA04h6DLfFbwJn4g+/PFs=
Endpoint = demo.wireguard.com:12912
AllowedIPs = 0.0.0.0/0

As far as I can test (no trafic is routed behind the endpoint) it's working. If you look at the announcement, I've picked some (15 or so) of the more current commits after asb-2020-10 tag. Though I've checked these commits and found nothing that may have fixed, may be...

BTW: the log entries the user has shared (the netlinkevent as well as the coreographer) arn't related to wireguard. The first one is related to the physical wifi interface (I've seen them since los14 without any drawbacks) the latter is graphical output (some frames are droped - e.g. during scrolling or rom's animations - if the coreographer process can't write fast enough to the graphics engine). Since the user stated to share logs if he can't fix it himself and I'm so tired of asking for logs, I havn't done so... Note: the wireguard application log (accessible from within the wireguard app) doesn't appear in logcat.
[OnePlus 3 & 3T Cross Device Development] knpk13:
The post you quoted answered everything you wanted to know. The "search the thread" response was for other ROMs, in case they have any special instructions that might differ from this ROM. I personally use opengapps nano. Those are automated builds. Pick the latest version, if there's an issue use a build with a different date.

If you're new you can always flash other gapps packages like bitgapps or nikgapps, which are built manually and released less frequently after being tested more, instead of automated nightly builds like opengapps.