yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] TheMystic:
Arch - no, I haven't read it and I have said several times I am not a techie.

As with Simplicity, here is a tip - Simplicity is the key to make the most out of anything. This applies to just about everything in life.

Now, coming back to you - I don't know what drives you to make this ROM and keep it alive. If users are not really your target, then what is (or who are)? XDA is not just a forum for developers, because, if that is the case, who will use the so many products linked in there? Just developers?

I know the difference between wiping and formatting, and I haven't used the terms interchangeably. I have only described the process I used to get back my data.

My data partition was formatted in f2fs (as it always has been) and also encrypted from the beginning. I have flashed several ROMs (on may be hundreds of occasions) and never faced this particular problem before. All I am saying is that the ROM should fail to flash if it finds that the data is not correctly formatted. In my case, I successfully flashed the ROM but was greeted with the decryption unsuccessful error. Had I got the error at the time of flashing, I would have simply restored my nandroid backup and my data partition wouldn't have been affected, like it did by flashing it. I have informed you about what happened, so if there is anything you can do about it so that it doesn't happen in future, it is up to you. Not many users seem to have tried this ROM as yet, so you probably haven't heard many complaints. But if you really want to take this ROM to the users, you would do well by making the necessary changes.

Again, if you don't intend to actively develop this ROM (except for security patches), that is also up to you. I'm not sure what drives you on this project, but what I can tell you is that the most popular product is one that addresses the requirements of it's user base.

As an example, I can tell you Tasker app would have been many times more popular if it wasn't for its steep learning curve. The learning curve is from the user standpoint. The product has been abandoned by the original maker, probably because it stopped growing. Other similar apps like Macrodroid are probably just as capable, and are super easy to use. The results are clearly visible and aren't surprising. The answer to that is simple - Simplicity of use.

From your comments and approach, it seems to me that GlassROM is a very closed ended project, kept alive for a very specific purpose, and not really for the custom ROM community of users. So all the best with that.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
2) already mentioned. Glassrom is simple it's just not your definition of simple and I can't fix that

3) it started because I was tired with how people treat custom ROMs

Ever heard these?

"Custom ROMs can never be secure"

"It's a custom ROM how can it be stable"

That's how glassrom started. This entire thing is essentially code I'd be comfortable with having on my device. It's also clean and "simple" and you can do whatever you want with it. Nothing useless, unnecessary or overkill

5) I've told you how to backup your crypto footer in a previous post

Bugs are a rarity on glassrom. This is code I would use on my own device and if it's not reliable it's pointless. Wondered why nobody else has a problem?

6) It's a "base" system. Customise it as you want

8) You are on a developer forum and are posting in a development community. "I'm a user" doesn't work here
[OnePlus 3 & 3T Cross Device Development] TheMystic:
Nowhere did I talk about simplicity (or complexity) of the ROM. You should just read patiently. All my comments were about how you presented the ROM, as well as the kind of things you post in comments. You assume a certain minimum level of knowledge and understanding on the part of the users, and unfortunately that bar is set too high. There is a mismatch w.r.t the target users, unless you are specifically targetting developers alone for this purpose.

I did check out GlassROM, and I liked the attention to detail you used in certain areas. Unfortunately, there were some features missing that I wanted, so reverted to Havoc. And yes, it is very simple - just to make sure you don't confuse.

Lineage has always been thought off as being very stable and well made custom ROM. There are some pretty good custom ROMs like RR, Havoc, and a few others with a very satisfied user base. Bugs are there, but they are there with stock ROMs too. There are quite a few bugs with Havoc too, yet I am satisfied because they are mostly related to "extras" which I may not be using, or at least not as often.

Custom ROMs can never be secure - this I heard only from you and as I told you before, XDA should impose certain guidelines on developers publishing their work on this platform.

Backing up the crypto folder - I didn't understand the process for obvious reasons, and you should remember one of the very first discussion we had on common sense. What you know too well could appear as common sense to you, but it is not necessarily one.

You have a limited base of users, so you probably haven't heard people complaining. But that is to be expected since you insist this is a developer's forum and you present your work accordingly.

Of what use/ point is a product if there isn't going to be a "user"?
[OnePlus 3 & 3T Cross Device Development] ΦDroid:
It might be common knowledge now, but the official TWRP results in a bootloop. The unofficial is required.

I just upgraded from a OP2 yesterday so I'm unfamiliar with the nuances of this phone. Please update the OP accordingly for anyone else who may be unaware.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
This is unexpected behaviour

Please boot to TWRP immediately after the first bootloop and run this on a PC

adb pull /sys/fs/pstore/

It will pull a few files. Put them all in a zip

Since memory corruption occurs during a bootloop you'll have to repeat this procedure thrice

Send all these files in pm. I'll need to see what's wrong
[OnePlus 3 & 3T Cross Device Development] ΦDroid:
Isn't it some problem with forced encryption? I think the issue is that I reformatted /data with the official TWRP. The encrypting device page never popped up until I switched recoveries and reformatted /data.

I'm busy the rest of the weekend but I'll try next weekend. It just takes hours to get my phone set up again after a clean flash.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
A fix was included in glassrom. If it's not working I would want to find out why
[OnePlus 3 & 3T Cross Device Development] ΦDroid:
Ok, just some more detail for now:

Never formatted to F2FS (everything correct for ext4 configuration)

128GB model Oneplus 3T
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Op3 uses F2FS by default
[OnePlus 3 & 3T Cross Device Development] ΦDroid:
Just shows you how new I am to the phone. Regardless, I reformatted /data to ext4 before flashing.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Updated:

Linux 3.18.137

Substratum support

Gestures are now enabled by default

Enabled yama

Bluetooth is disabled by default

You can now set a 64 character password instead of 16

Note: there are no April fools jokes in glassrom's build. We take our work very seriously
[OnePlus 3 & 3T Cross Device Development] MuzzamilIhsan:
I'm encrypted, FS is Ext4, Twrp 3.2.0 , so my question is if i flash ext4 version of Rom will i lose data?
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
If you're already encrypted, no

However you should still backup data before you change ROMs. This applies to all ROMs and not just glassrom
[OnePlus 3 & 3T Cross Device Development] MuzzamilIhsan:
What are the exact steps to flash this rom?

I'll be grateful for the help?

Edit: Successfully flashed, it's running smoothly,

One bug i found Ambient notifications with dark theme are invisible.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
I'll be releasing the 1st April 2019 security patch soon

April 5 security patch cannot be rolled out as CAF hasn't updated op3's WiFi driver. Once we get a new CAF tag I'll set the security patch date to April 5

Any ROMs that advertise a security patch level of 5 April 2019 are lying as they cannot do so unless CAF releases a WiFi driver update for the op3. Be careful of such ROMs. The highest security patch date a ROM can set is 1 April 2019
[OnePlus 3 & 3T Cross Device Development] MuzzamilIhsan:
To all those who want to flash GlassRom

Here are the instructions.

Unlocked Bootloader

Twrp 3.2.3.0

Wipe Data and System

Mount/ Mount System read only

Flash GlassRom

Reboot.

See if rom boots.

After first boot

Now go to fastboot, and Flash Twrp 3.2.3.0 as This rom will replace your recovery

After flashing twrp, flash gapps and Magisk

Enjoy GlassRom super Fast??

Note: You should be encrypted, if not then backup your data first.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
You need to wipe data (not format) after flashing gapps btw
[OnePlus 3 & 3T Cross Device Development] abhibnl:
You can do it this way to keep twrp and not have to fastboot it:

Flash ROM, flash recovery img, reboot to recovery, flash magisk, and you are good to go!

Honestly no other custom ROM keeps stock recovery so it's a good thing to add this in the OP. OOS shows this behaviour so I am used to use these steps on all ROMs when I flash and try something new.
[OnePlus 3 & 3T Cross Device Development] skymera:
I've moved to this from HavocOS and there's some nice options I miss

Data traffic indicator is centered on the status bar - is there an option to move to the right?

Could there be an option to move volume slider to the left side?

Ability for ambient display on new notification?
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Sorry I don't plan to add a lot of features. If it's not present on lineage and not already in the features list then it's probably not there at all
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Okay so I just updated the WiFi driver. I still need to test a few things and then I'll release the 5th April security patch
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Updated:

Merged LA.UM.7.5.r1-04500-8x96.0 from CAF

WiFi driver updated to LA.UM.7.5.r1-04500-8x96.0

Linux 3.18.138

Upstream changes from lineageos common kernel

New USB devices are now denied by default

Updated security patch string to 2018-04-05

Upstream lineageos changes

Known bugs: lineage recovery is still a little buggy. There are reports that it doesn't boot. This will be fixed in a future release.

Edit: this bug has been fixed upstream. The fix will be added in a future release

Verifying builds: https://github.com/GlassROM/glassrom-verification/commit/a2ea205956518fbfd7821149b2229b121888cdef
[OnePlus 3 & 3T Cross Device Development] karakanto:
How is the performance of ext4 vs f2fs variants? Do they offer similar optimisations or would you recommend using the ext4 version?
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
You can go around the internet and people will keep telling you everything they think to be true

In reality neither is "better" or "worse" than the other. They all have some good things and some bad things

F2fs is faster, it discards asynchronously, journalling is not present so sqlite is faster

On the other hand F2FS suffers from fragmentation, needs periodic garbage collection and while doing these activities will use 100% of your CPU which can lead to battery drain. Data recovery was very hard until very recently. TWRP support is poor. The on-disk format changes with every glassrom release

Ext4 is very reliable, does not suffer from fragmentation even on hard disks, recovering a bad ext4 partition takes a very long time but unlike F2FS at least it's possible, TWRP support is great, the on-disk format is constant throughout releases

On the other hand it uses journalling which wears down the storage (disabled on glassrom), it is also slower than F2FS. In fact F2FS showed performance improvements compared to ext4 even on hard disks. Ext4 is also a very old filesystem and it's age has started to show. The developer of ext4 considers btrfs to eventually replace ext4

While btrfs resolves some of the issues with ext4 it is slower due to it's copy-on-write nature. It also needs periodic defragmentation and something called "rebalancing" which is hard to explain unless you already know a little about newer filesystem formats
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Guys we have a CDN for downloads now

The glassrom server often has poor reach in certain areas of the world. This means that even if the server has a gigabit link you'll see bad downloads because your ISP doesn't have a proper link to us. This only happens in certain parts of the world

The CDN aims to resolve these issues. It reaches where the glassrom server cannot and gives faster download speeds. If downloading directly from the server is slow try the CDN

The CDN provider doesn't support ipv6. Unfortunately if you're on an ipv6-only endpoint you'll have to directly use the glassrom server for the download
[OnePlus 3 & 3T Cross Device Development] mnsiw:
I was on OOS Pie, rebooted to TWRP and wiped everything, formatted data and rebooted TWRP, mounted system read-only, flashed op3_ext4.zip, waited for an hour, it was still on boot animation, restoring OOS backup now :(
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Please download dianlujitao's TWRP from here https://androidfilehost.com/?fid=1395089523397907195 then format data with it and try again
[OnePlus 3 & 3T Cross Device Development] mnsiw:
Avoid this on OP3T 128Gig, got my device bricked, now trying to get it back to life.
[OnePlus 3 & 3T Cross Device Development] ΦDroid:
Same problem I had a couple weeks ago. Still haven't had time to do a clean flash and take logs unfortunately.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
I have 3 testers on the op3t using the 128gb version and not one has reported a brick

Please press and hold the power button until it restarts. It might just be stuck
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
I just keep finding more and more issues with encryption

Today I noticed that lineage sets the size of the data partition wrong in the device tree and doesn't even set the size for the 128 GB variant

This commit fixes that https://github.com/GlassROM-devices...mmit/c03d84e9358bf6b7e2265c4ae825d5fb2b842762

Maybe it also fixes the encryption issue. I can't tell for sure
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Updated:

Fixed the issues with lineage recovery

Updated GPS driver to LA.UM.7.5.r1-04500-8x96.0

Added some additional April security patches Google decided to push during the last moment

Fixed some issues with encryption

Reduced initial boot time

Removed aggressive task scheduling

Improved memory management

USB devices are no longer denied during boot

Additional hardening applied

Verifying builds: https://github.com/GlassROM/glassrom-verification/commit/f596520da647e93a5cbe6593348ca4d95e169e0b
[OnePlus 3 & 3T Cross Device Development] mnsiw:
Tried all that but it was completely dead, it was not low battery issue as it was full before flashing, flashed the ROM and no-verity as suggest by someone in the group and rebooted, no GAPPs, Magisk or any other zip. As I was on MacBook but luckily have Windows 7 running in Parallel Desktop, after spending 3 hours on different unbrick tools, drivers etc finally it's back to life, actually it need pressing volume up+power button few times when connected to MSM Download Tool (just pressing volume up while connecting to USB/PC detect and show it in Device Manager but show error when try to flash)
[OnePlus 3 & 3T Cross Device Development] vny10:
On latest build torch automatically start after some hours and have to turn off manually

One more when opening menu it open recent window

OP3
[OnePlus 3 & 3T Cross Device Development] l3lockbuster:
I just flashed the latest version twice (dirty flash first, clean flash afterwards), but instead of taking 50 minutes to boot for the first time, it only took about 3 minutes in both cases.

Does this mean the optimalization part failed?
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
See the changelog

The optimisation now happens a lot faster

Also 50 minutes was measured under the worst case scenario (opengapps super, device throttling, etc) so you'll never actually see 50 minutes of boot time
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
After how many hours?

Does it turn on by itself even if you disable the torch gesture in settings?

Menu will only open if you hold the recents button
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Please do not clean flash glassrom updates. This is hardly required, if ever
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
I have had success with booting twrp on a locked bootloader

In the future glassrom might replace the recovery with TWRP instead of the lineageos recovery
[OnePlus 3 & 3T Cross Device Development] vny10:
Yes turn on by itself even gesture off

About 3 to 4 hours

But after using pixel launcher everything is perfect even torch problem is gone
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Interesting

If it occurs again please let me know

Also while reporting the bug as per the first post make sure these are not installed: custom kernels, magisk, xposed modules

Wiping cache will not help so don't try it
[OnePlus 3 & 3T Cross Device Development] vny10:
Got it thanks for this solid build
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Okay I've added some advice because people are too reliant on aggressive battery optimisation

Android runs several maintenance tasks aside from just runtime optimisation when your phone is idle on a charger. Charging your phone overnight is necessary

Aggressive battery optimisation was never meant to stop battery drain overnight. I know it does but this was never it's intended usage. Do not use aggressive battery optimisation as a reason to not charge your phone overnight

Unlike OOS aggressive battery optimisation on glassrom does not kill apps. Remember that a bad app can always keep the system awake and aggressive battery optimisation will be useless against it. Also aggressive battery optimisation works with doze so it only activates once your device enters deep doze. The device needs to be idle for at least 2 hours before that happens
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
I was really surprised to see how broken twrp is on the op3 in general

I did a twrp build https://glassrom.pw/op3_recovery.img

Here's what I fixed:

Kernel 3.18.139 (upstream)

Upstreamed f2fs to 5.1-rc1 to fix the issue where twrp would get stuck at the logo for a long time if the userdata partition was using f2fs

Much better support for USB-OTG drives

A full selinux policy so that files get labelled correctly

Added all code to create the crypto footer correctly back

This build can validly detect if you have an op3 or an op3t

Ext4 is the default filesystem

Built against lineage 16 instead of omni

Much better decryption support

This is still a WIP. I couldn't find any bugs but if you do find any please let me know

Source: check the twrp branches on the GlassROM-devices organisation
[OnePlus 3 & 3T Cross Device Development] abhibnl:
[MENTION=5091734]dianlujitao[/MENTION] is our official maintainer of TWRP on OP3/T. If you think TWRP is really broken, you should get in touch with him and submit your patches to the official TWRP gerrit. That will benefit all of the OP3/T community as well as this thread might not get as many views as it deserves.
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Well I do not really care about that part. If you're interested you can submit these patches. I'll also wish you good luck for what you're about to do. In fact I initially did consider just releasing the kernel source and keeping my changes private

Here's a fact:

"I do not contribute to upstream"

Also note that nowhere in my post did I specifically mention official twrp. I've tried every single twrp that's out there and each had it's own share of problems. I just went ahead and fixed the ones I noticed
[OnePlus 3 & 3T Cross Device Development] :
NOT possible to download from your website with Via (Android) or IE (Windows) because of outdated SSL or invalid response from your server ?

Edit: cdn is working, changed link for firmware to cdn
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
The glassrom server will only reply to clients that support RFC TLS 1.3 with x25519 and a secp384r1 key for authentication

Please ask your browser to update it's TLS library. TLS 1.3 has been out since 9 months now and there is no excuse left for browser developers to not update

https://www.ssllabs.com/ssltest/analyze.html?d=glassrom.pw&latest
[OnePlus 3 & 3T Cross Device Development] :
Thanks for your reply [MENTION=5842226]anupritaisno1[/MENTION].

The link you added in your post is giving "Warning: Inconsistent server configuration " btw... ;)

It seems IPV6 and IPV6 are not configured the same way, IPV6 is missing certificate.

Good to see that you are keen on privacy, hardening the rom and using as secure and up-to-date stuff as possible, although probably not so easy for a lot of the users because as I find out myself now; although always trying to use safe software, latest versions and especially no bloat-ware, Google-stuff etc.... it still seems not enough... :silly:

Two questions about the rom itself.

I do like the idea of a hardened kernel, no backdoors etc..., but because a website and repository are missing; what is the normal frequency for new builds?

And it is possible to install your rom without encryption without loosing /data? I have read the first post, but still not completely sure how to install with keeping my /data.....
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
That ipv6 warning is a bug in the test itself. I have an ISP here that only gives me an ipv6 address with no ipv4 support and it loads just fine

It seems that the ipv6 security checks fail if TLS 1.2 is not supported

Dm-verity and forced encryption disablers should work

To be really sure

Mount the system partition in the mount options

Make sure "mount system partition read-only is not ticked"

Run this command

sed -i 's/forceencrypt=/encryptable=/g' /system/vendor/etc/fstab.qcom

Note: the next build will unify ext4 and f2fs. Do not remove the g from the command

There is no schedule for new builds. These are released when all known bugs at that time are fixed
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
Many custom kernels don't boot on glassrom

To solve this issue I've added a set of requirements for people porting kernels to glassrom

If a custom kernel does not boot point your kernel developer to the first post of this thread and ask them to satisfy the requirements for booting on glassrom
[OnePlus 3 & 3T Cross Device Development] knpk13:
May I ask why? And thanks for the TWRP build. You're right, the others are really broken.
[OnePlus 3 & 3T Cross Device Development] :
Strange though because browser seems to support TLS 1.3....

Could it be the Android downloader in Lineage 16 which is not supporting TLS 1.3? :confused:

Edit: I gave up, using your CDN links now. Tried privacy browser, Firefox lite, some other tastes, even a separate downloaded. Get I valid response messages and no downloaded files. Then it will be CDN ?
[OnePlus 3 & 3T Cross Device Development] vny10:
Usb otg not working
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
It took dianlujitao almost 2 years to get his crypto footer fixes merged into TWRP and it wasn't as of the patch itself had issues

I simply do not have that kind of time or patience
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
That's weird. Android's boringssl has supported TLS 1.3 for a very long time
[OnePlus 3 & 3T Cross Device Development] anupritaisno1:
What filesystem is your OTG drive formatted as?

Also check settings > security > trust and make sure deny new usb devices is not enabled. It is enabled by default on glassrom