yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] :
I guess you can use the webview.apk from a nlos build, because the prebuilts (from the git you mentioned) are used while building to create a multi-arch package:

ingo@adler /usr/local/src/los16 $ ls -la external/chromium-webview/prebuilt/arm*/webview.apk out/target/product/oneplus3/system/product/app/webview/webview.apk
-rw-r--r-- 1 ingo ingo 42275666 10. Jul 15:41 external/chromium-webview/prebuilt/arm/webview.apk
-rw-r--r-- 1 ingo ingo 74020006 10. Jul 15:41 external/chromium-webview/prebuilt/arm64/webview.apk
-rw-r--r-- 1 ingo ingo 143783705 10. Jul 18:05 out/target/product/oneplus3/system/product/app/webview/webview.apk
ingo@adler /usr/local/src/los16 $ unzip -l out/target/product/oneplus3/system/product/app/webview/webview.apk|grep lib 81234248 01-01-2009 00:00 lib/arm64-v8a/libwebviewchromium.so
51930964 01-01-2009 00:00 lib/armeabi-v7a/libwebviewchromium.so
ingo@adler /usr/local/src/los16 $

BTW: the bromite documentation states that all features of bromite webbrpwser are present in bromite webview, but I've found no way to use/configure them, nor do I het an answer on this - so I thought it's time to ask again...
[OnePlus 3 & 3T Cross Device Development] :
Hi [MENTION=3456089]nvertigo[/MENTION]; thanks again for your quick reply. Seems you are connected 24/7... ;)

Did some testing and seems I am doing wrong or stupid; either way I do not understand what I am actually doing....

First test;

Downloaded the apk from github, replaced it 1:1 in /system/product/app/webview.

After reboot did not work, also tried the same with removing the oat directory in /system/product/app/webview.

Second test;

Removed /system/product/app/webview completely and installed your webview after reboot, simply as installing every apk.

Though the apk is installed succesfully, in settings / developer options/ webview implementation, there is no webview available.

Third test;

Replaced the webview apk in /system/product/app/webview with yours from github and removed the oat directory.

Then installed your apk after reboot, simply as installing every apk.

This setup seems to work without any issues.

Probably misunderstood you or am messing up my system but why is the third setup working and the first not?
[OnePlus 3 & 3T Cross Device Development] :
See my previous posting. I've explained why that can't work.

As explained in my last posting priv-app/webview/webview.apk needs to be a multi arch apk (containing arm64 and arm) to be used as system webview. You need to ise the apk from a nlos build - you can't use the apks from the git. Extract nlos rom and grab the apk from there and follow the installation instructions from https://github.com/bromite/bromite/wiki/Installing-SystemWebView ,which is basically the same as the third test:

Never had this issue (have used 3.4.0-0 fpr about 10 dirty flashes so far. It seems that after formating caches the absence of /cache/recovery makes "mkdir /cache/recovery/2bdde8504898ccfcd2c59f20bb8c9c25f73bb524/" fail.

Recommended procedure for dirty flashing is

boot twrp

flash rom (always use signature verification with md5sum file)

flash sec patch date fix if you need to pass safetynet (always use signature verification with md5sum file)

flash IL cc for tethering if needed

wipe cashes and dalvik from the after flash page

reboo to system from the after cache wipe page

This way you don't hit tje above bug. Or you can reboot to twrp if you insist on wiping caches before rom flash.
[OnePlus 3 & 3T Cross Device Development] :
Noted
[OnePlus 3 & 3T Cross Device Development] Ihe87:
Hi [MENTION=4405529]nvertigo67[/MENTION],

did you remove the firewall from settings in latest build?

Can't find it anymore...

TIA
[OnePlus 3 & 3T Cross Device Development] :
It has been moved. Look at the last comment from Sam Mortimer at https://review.lineageos.org/c/LineageOS/android_packages_apps_LineageParts/+/265238 .

Look at Settings->Network & internet->Data-Usage->Manage data restrictions.

EDIT:

I completely agree to this design decission: IMHO a firewall should be able to do statefull inspection, but at least packet filtering with regards to the direction. Data restriction is the much better phrase and data usage is the better place for this feature.
[OnePlus 3 & 3T Cross Device Development] Ihe87:
Hello again [MENTION=4405529]nvertigo67[/MENTION] ,

i got another question today... :D

What are thinking about adding a backup-app that doesn't require root?

See: https://github.com/stevesoltys/seedvault

TIA
[OnePlus 3 & 3T Cross Device Development] :
No. See: https://github.com/stevesoltys/seedvault/commit/37ffacbafef83a0cdedc6347dcbd1049ff23f6a4

EDIT:

You can make a flashable zip from the prebuilt repo: https://github.com/stevesoltys/seedvault-prebuilt .
[OnePlus 3 & 3T Cross Device Development] knpk13:
Found this in the MicroG thread, FYI [MENTION=4405529]nvertigo67[/MENTION]

Edit: Removed fake link

Not sure if it affects your builds [MENTION=7929484]MSe1969[/MENTION]
[OnePlus 3 & 3T Cross Device Development] MSe1969:
Well, in the short term, I'd say "not really" - I have noticed that the microG development almost "stalled", but some forks exist and keep things up - I e.g. use now the GmsCore from the /e/ project.

With the announced development "in the pipeline" by Mar-v-in and several forks progressing, I feel slightly optimistic on a mid-term base, especially, as my main priority is not the latest Android release.

Long-term, I am afraid that the view on the Android ecosystem has some true points . . .

EDIT:

IMPORTANT - read this (the linked article seems a fake)! the linked article has now been removed
[OnePlus 3 & 3T Cross Device Development] knpk13:
Yeah I found it fishy myself when I checked Marvin's profile and there was only one post ever made by that account. Thanks for confirming it. Don't really get what the fake poster was trying to accomplish. :confused:
[OnePlus 3 & 3T Cross Device Development] :
[MENTION=7134312]knpk13[/MENTION] & [MENTION=7929484]MSe1969[/MENTION]:

Thanx for the heads up! Thanx for being open minded and aware! I highly appriciate the original note as well as the correction!

[bad irony]

Wow, there's fake news on the internet!?!?

[/bad irony]

I've started to read about the first ten posting of the mentioned sub. Though a few postings are substantiated, most of them show half baked knowledge and misconcepts.

Anyway:

Foss rulez! (Making all source code available for review by everyone and evolving the code publicly can be part of a chain of trust.)

MicroG rulez! (It takes time to reverse engineer all gservices apis - it's not loud, it's not colorfull, it's no headline, but it is done.)
[OnePlus 3 & 3T Cross Device Development] m3adow:
Wow, I didn't realize /e/ has their own GmsCore fork (LINK for the lazy). Do you know if they release flash ready zips somewhere? Or does one have to build it themselves?

BTW: /e/ is such a stupid name, searching for it is rather difficult.
[OnePlus 3 & 3T Cross Device Development] MSe1969:
I took their prebuilt, good thing here is that that spoof Google signature, otherwise it would be an issue replacing the Apk :)

I am not related with them in any way, but what I understood from any info or FAQ is, that they don't like the name either, but they had already experienced quite some legal challenge for a different name attempt - seems nowadays that for any random combination of letters, there is somewhere in the world somebody having the name rights already reserved ...
[OnePlus 3 & 3T Cross Device Development] :
I just realized this lol

The icon far to the right, what it means tho. No documentation in the link. What an ugly icon zz

The second from the right should be screen off, middle is vpn

cmiiw
[OnePlus 3 & 3T Cross Device Development] :
Icon meaning from left to right:

wlan, mobile data, vpn, background data, unrestricted data access.

You can access the same functionality with Settings->Apps & notifications->[App]->Data usage (no icons but human readable strings).
[OnePlus 3 & 3T Cross Device Development] meiser:
Might be fixed by this commit?!?
[OnePlus 3 & 3T Cross Device Development] pijas82:
I'm back always to the best rom, thanks
[OnePlus 3 & 3T Cross Device Development] 64ashg:
Slight ot

I searched the thread if there are any plans for nlos17.1 and i came across a reply from op on 5th april.

Are there any desire for going further with it? I think sdclang and the kernel fixes is what the official rom needs after already being somewhat stable (if one goes by the los thread) los17.1

PS for that one guy, a year or maybe more ago on this thread, who complained that the calibration does not apply after he got a new panel installed and went back to official los16, i got the same done today. It was cheap, a less than legitimate amoled panel and the dcip3 & srgb goes away as these panels' controllers don't understand it. Turning the saturation way down and the contrast down a little is the best bet for anyone doing so.
[OnePlus 3 & 3T Cross Device Development] pijas82:
I need help

How to put notification on black?

Thanks

And it's normal? Diskinf

Thanks
[OnePlus 3 & 3T Cross Device Development] :
Substratum.

What do you mean? I can't see the images.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
That's because XDA is having issues attaching images to posts. This happened a coupler of weeks ago as well.
[OnePlus 3 & 3T Cross Device Development] :
Do you know if a reupload is needed? Or is it "autofixed" after some time?
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Once the problem (issue with the image upload process) has been fixed you can then upload the image again. The problem has been mentioned a fair recently bit https://xdaforums.com/android/apps-games/labs-t3241866
[OnePlus 3 & 3T Cross Device Development] DroidFreak32:
Hey [MENTION=4405529]nvertigo67[/MENTION] just FYI, I've been using nlos for a while now with the F2FS improvements from arter97's kernel.

Ive merged the latest f2fs-stable for Linux 3.18.x on top of nlos kernel, and cherry picked the rest of the improvements in arter97's kernel.

You can have a look at :

https://github.com/DroidFreak32/android_kernel_oneplus_msm8996/commits/nlos-16.0-f2fs

I'm not asking you to add this to your kernel (mostly because I don't trust myself all that much XD) , but just letting you know there's a source which took care of merge conflicts and can save you some time in the future if you wish to add f2fs fixes.
[OnePlus 3 & 3T Cross Device Development] :
Thank you very much - at least you've umderstood how to motivate me to add something... ;)

I'll check out (literally as well as metaphoric) these commits.

[MENTION=9350973]All[/MENTION]: anybody interested in a test build with f2fs fixes and backports (only if you use f2fs on data)?

EDIT:

Will take some time. The merge is not easily pickable. The commits doesn't match the latest kernel - they are on top of the June version... :( Maybe you can do it again for 83cd20d790971aee686f13f88050c23758cd62a0. Since [MENTION=7929484]MSe1969[/MENTION] is forcing updates it's better to have all(!) commits picked on top (merge breaks if the base is forved updated.
[OnePlus 3 & 3T Cross Device Development] xdam57733:
Full disk encryption

Hello.

I tried finding an answer to the below question in this thread and elsewhere, but wasn't successful. If this is not related to this ROM at all, which does sound likely, I would appreciate a pointer / link.

On my OP3T running NLOS 16, I had FDE enabled, which made me enter my PIN on each boot, so that the data partition could be decrypted.

After I recently registered a few fingerprints, the phone does _not_ ask for my PIN on boot anmore. I am not booting every day, so there might not be a correlation to the fingerprint registration and it could be just a coincidence.

Also when searching the net for this, I found that Android was recently changed to prefer File encryption over FDE and I thought this could be related.

What is strange though, is that also TWRP is _not_ asking for the PIN to decrypt /data anymore. Instead I can see the files just fine in MTP provided by TWRP and they are not encrypted (e.g. photos).

Of course I double-checked that the phone is still showing "Encrypted" in the security options.

Thanks for any insight helping me understand.,

Mo
[OnePlus 3 & 3T Cross Device Development] :
I've explaimed fde/fbe in the official rom thread (references included).

Adding a fp does not remove secure boot, but changing the passphrase (pin, pattern, password) without checking the checkbox for secured boot does. Set it again and check that checkbox and your boot passphrase is back.
[OnePlus 3 & 3T Cross Device Development] xdam57733:
Thanks for your quick response.

I suppose you mean this thread? Or what else is the "official rom thread" (slightly confused)? Will check again.

What I still don't understand is why TWRP was able to decrypt /data without me entering my PIN if secure boot is not checked. Are the keys cached? Would a cold reboot have made a difference?
[OnePlus 3 & 3T Cross Device Development] BillGoss:
The same thing had happened to me on a few occasions but I've never been able to reproduce the problem. It's happened to me when making changes with Magisk and changing things in my password app.

Whatever it is that happens it resets the encryption key to a default value, which is why TWRP can decrypt /data. You'll notice that you're phone is still encrypted (TWRP decrypts /data, your phone shows it's encrypted in Settings>Security).

As [MENTION=4405529]nvertigo67[/MENTION] said, just set your password again and say Yes for on boot.
[OnePlus 3 & 3T Cross Device Development] DroidFreak32:
It is actually based on top of the July 10th commit. Here is the history ( 83cd20d790971aee686f13f88050c23758cd62a0 )
[OnePlus 3 & 3T Cross Device Development] stevenkyk:
Just my 2 cents, I noticed this problem recently as well, based on my own investigations, it is due to accessibility service being enabled (bitwarden password manager in my case). The default behaviour of android seems to be to disable secure boot whenever any accessibility service is activated, with the rationale that secure boot prevents accessibility features from working at boot. This is reproducible for me at least.
[OnePlus 3 & 3T Cross Device Development] :
I've meant tje official los 16.0 thread. I explained the default_password "Trick" a hundred times (feels like that). E.g. in the twrp thread:

https://xdaforums.com/showpost.php?p=79471558&postcount=665

Please understand that I don't like explaining the basics every 3 months. On questions always see official los-16.0 thread, official twrp thread the four help and how-to forums and this thread of course:

https://xdaforums.com/oneplus-3/one...eplus-3-3t-t3866517/post80836945#post80836945

https://xdaforums.com/showpost.php?p=79471558&postcount=665

https://xdaforums.com/oneplus-3t/ho...ndroid-8-0-t3728119/post80242330#post80242330

Also nlos threads 14 and 15 and official los threads 14, 15 and 17 have excelent and valuable information.

[MENTION=9350973]All[/MENTION]: this is a one time service because I typed "rom" instead of "los". I'm no search assistant, My name is nvertigo67, it's neither "ok google" nor alexa.

There's only one substitute for reading: reading more... ;)
[OnePlus 3 & 3T Cross Device Development] :
You are right. I was confused due to two empty commits, which made me think it's due to changes to the base.

My problem is the merge commit: https://drive.google.com/file/d/1LjnVDAIp7N0koQwad52pPnNPXWzbbgYy/view?usp=sharing

As you can see the merge in 41f72330cd52f expands to over 300 single commits. This is hard to maintain, if https://github.com/jaegeuk/f2fs-stable/tree/linux-3.18.y changes. If this is forced updated one single time, it will give serious problems if applied to [MENTION=7929484]MSe1969[/MENTION]'s sources after they have forced updated, too. I need to think about these implications and about how to maintain that...

EDIT: I'm running https://github.com/nvertigo/android_kernel_oneplus_msm8996/commits/tmp with encrypted f2fs on data. Any testers?
[OnePlus 3 & 3T Cross Device Development] xdam57733:
Thanks, that might be a hint why it changed for me with me thinking I hadn't changed anything related. For handling double-tap to sleep, I think I recently changed to allow Nova the accessibility feature.
[OnePlus 3 & 3T Cross Device Development] :
For how long?

What your tester need to do?

Upload it, i'll take a look
[OnePlus 3 & 3T Cross Device Development] knpk13:
https://xdaforums.com/android/apps-games/labs-t3241866/post83129221
[OnePlus 3 & 3T Cross Device Development] xdam57733:
I indeed had searched for a reason of this changed behavior before asking. I always do that. Potentially I hadn't used the right terms. Explicitly checking the LOS thread is something I will do next time.

Also, I am not sure I would have been able to find the relation between the secure boot flag, which only can be seen if you change the PIN (which I hadn't) and the resetting of that flag when allowing an app accessibility permissions.

Thanks, [MENTION=4405529]nvertigo67[/MENTION]
[OnePlus 3 & 3T Cross Device Development] 64ashg:
Yes i can test, running encrypted f2fs on data and cache formatted from arter97's recovery on nlos
[OnePlus 3 & 3T Cross Device Development] :
Which TWRP to use for the format?

Arter or Dian/official?
[OnePlus 3 & 3T Cross Device Development] 64ashg:
Anything in particular to look out for? It boots fine for now on encrypted data, with cache too on f2fs, and the webview implementation is also the chromium 84.xxx.95 that you updated.

I used pico gapps so there were no webview implementation that i know of from both the july builds..

PS thanks for merging f2fs fixes from f2fs-stable

I wouldn't, nor does the op recommend, but i used the r2 recovery built by arter..
[OnePlus 3 & 3T Cross Device Development] :
Stability, bat consumption, performance... The usual suspects...

Install https://play.google.com/store/apps/details?id=com.google.android.webview and check, if it's selectable in dev-opts.

A gapps package with webview included would just replace the shipped (updated) one.

[MENTION=5616867]150208[/MENTION]

For twrp: no matter if flashing or formating, always use the OP recommended twrp! (currently: 3.4.0-0) The new kernel should work with existing f2fs partitions. If not (you all tell me) this would be a real showstopper for the f2fs backports.
[OnePlus 3 & 3T Cross Device Development] 64ashg:
Installed the chrome webview and it is selectable in the webview selection list along with the chromium one with the rom.

PS thanks for the speedy update for chromium, chrome webview is on 84.xxx.89. Even the installer for chromium for windows hasn't been updated yet. Only microsoft edge has been updated with latest stable chromium before you..
[OnePlus 3 & 3T Cross Device Development] :
Everybody should be excited to try f2fs, I'll dirty flash with ext4 partition to see any side effect then ;)
[OnePlus 3 & 3T Cross Device Development] :
f2fs commits

For homebuilders, devs and all interested people:

I've reorganized the f2fs commits:

First I applied all commits as cherry-picks on top of the branch merge-16.0, including the merge of https://github.com/jaegeuk/f2fs-stable branch linux-3.18.y. The result is branch merge-16.0-f2fs. On top of merge-16.0-f2fs I cherry-picked the commits to build in my buiöd environment resulting in nlos-16.0-f2fs

If you want to try the f2fs commits on an other kernel, you only need to pick everything from merge-16.0 to merge-16.0-f2fs. iIf you've added my kernel git as remote and fetched it completely, you can pick the f2fs part:

git cherry-pick merge-16.0..merge-16.0-f2fs

If you want to pick the f2fs part without completely adding my kernel git, you can do this:

git fetch https://github.com/nvertigo/android_kernel_oneplus_msm8996 merge-16.0-f2fs
git cherry-pick 0ce043cd7e9b4..FETCH_HEAD
[OnePlus 3 & 3T Cross Device Development] knpk13:
The exact opposite ended up happening lol, not a fake link this time :P

https://e.foundation/e-foundation-announces-official-support-of-microg-development/
[OnePlus 3 & 3T Cross Device Development] SenseSei:
According to Post #157 from Arters Kernel Thread, only the

Mkfs tools are different.

DroidFreak32

64ashg
[OnePlus 3 & 3T Cross Device Development] :
So what? Use the third party recovery? It has been proofed that the new kernel drivers work on older official twrp generates fses!?!
[OnePlus 3 & 3T Cross Device Development] SenseSei:
I just wanted to give some information, not direct the Users to use third party. Maybe I was hoping that you or some other user would explain the difference.

For myself I must say that I don't have enough knowledge to decide for myself, so I tend to follow people who are more knowledgeable. Especially because twrp has a history to be very confusing for our device ;)
[OnePlus 3 & 3T Cross Device Development] :
You quoted my recommendation. So I've guessed you disagree. If I got that wrong and you still agree with my recommendation, I would like you to write what you mean directly and precisely instead of spreading some subtext and leave it to the reader...

I stick with my recommendation. I'm not inzerested in supporting more then one recovery.
[OnePlus 3 & 3T Cross Device Development] :
Sp far it's good, i don't feel any differences when using ext4 with the new f2fs commits
[OnePlus 3 & 3T Cross Device Development] SenseSei:
I agree with you and your reasoning to support official twrp only.

I was just kinda curious because Arter must have his reasons to make his Mkfs different. (also to point out that Arters twrp should work according to the quoted user)

Like I mentioned earlier, there was a brief time when an unofficial twrp version was the recommended one. (From Dian but still)

I'm sorry if I pushed the discussion in a wrong way, we can end it here if you wish.
[OnePlus 3 & 3T Cross Device Development] 64ashg:
No problems here too running encrypted f2fs, just a little slower/laggier, very little, than without the garbage collection fixes. But I'd take these fixes with 90% of the previous build's perceived performance than without in the long run..

If you are that curious, try it at your own risk and see for yourself. Arter97 has built the recovery over older twrp version (3.3 instead of latest 3.4 recommended in the op) just to facilitate the f2fs build tools he chooses to support across oneplus 3 to 5t and maybe even higher I didn't check. He has done the same to more devices which had eol development all the way back to the galaxy s3 with his cwm recovery with which my gt-i9300 running f2fs with touch wiz still running.

Here, be more confused now without trying and learning when things go wrong. Have a backup made over a weekend and try it out, nvertigo gave up on supporting nlos beyond 16 to avoid precisely this conversation, and no one giving any damn logs for bugs..
[OnePlus 3 & 3T Cross Device Development] SenseSei:
I'm only confused about your angry reply. Thanks nonetheless
[OnePlus 3 & 3T Cross Device Development] 64ashg:
Apologizes if I came across angry, I meant to come across annoyed, nothing more, nothing less.

PS you were meant to be confused too, confusion that you can only clear by trying and experimenting for yourself or drop the whole idea and follow op as he is, by far, one of the most knowledgeable regarding this device..