yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] :
ACK

You can test yourself: edit /system/build.prop (if not rooted, via twrp) and add either ",com.your.apps.cannonical.name" or " com.your.apps.cannonical.name" (can't remember exactly if it's a comma seperated or a space seperated list) and reboot.

Sic. Changing android's default behaviour in a commit will never ever meeged in los, but...

Let me sleep a night over this, but I think using the f/a patch is ok for op3/t only builds. (personal note: the patch is so small and therefor elegant - I love those one or two liners... ;) )
[OnePlus 3 & 3T Cross Device Development] pedritopl:
Coma. It's coma separated. I read the patch and then tested it already (my previous post) :)

---------- Post added at 07:46 PM ---------- Previous post was at 07:21 PM ----------

The "generic" patch comment* says it was found in "OSS" sources. Isn't it a typo and what was meant was "OOS" (OxygenOS)? If so - if OxygenOS includes such workaround - I see no reason not to include it in LOS & NLOS.

* "Found in the OSS sources by Kevin Mckee <kxzxxx@gmail.com>."
[OnePlus 3 & 3T Cross Device Development] knpk13:
I tried reading all the commits I could find related to the issue but I still don't understand why we need to force HAL1 camera for certain apps (like WhatsApp) to prevent lag/blurry pics on OP3/T. Can someone link me to an explanation if it has been explained before?
[OnePlus 3 & 3T Cross Device Development] :
OSS: OnePlus OpenSource Software: https://github.com/OnePlusOSS

It can't be found in OOS (OxygenOS) sources, because we don't have access to OOS sources.

It's due to some issues with the Oneplus blobs: android's default behavior is falling back to HAL3 if api1 is requested without assigning a HAL level. api1 with HAL3 creates the issues you are describing with our OnePlus camera blobs. So we need to force HAL1 in such cases: either via f/b patch with a prop, or with tne generic f/a patch.

Since other devices may have blobs that support api1 with HAL3, the generic patch can't make it to los upstream.
[OnePlus 3 & 3T Cross Device Development] pedritopl:
Good point about OxygenOS :)

OK, so if such behaviour is in OnePlus provided sources anyway - why not use it :)

OnePlus knows their camera blobs are misbehaving in default configuration so they "fix" it by forcing HAL1. I believe we should too.

If it ever changes (with Android P based OxygenOS for example) then we can go back to default Android behaviour.
[OnePlus 3 & 3T Cross Device Development] knpk13:
Ohhh ok. That makes so much more sense now. Thanks. I'm assuming there's no way to apply the generic fix to upstream LOS in a way that won't affect other devices, and that's why we're using the hard coded solution. Btw do f/a and f/b mean something? (I know you're using them to refer to the 2 different patches)
[OnePlus 3 & 3T Cross Device Development] CodesCodger:
Then why don't just adapt oss camera hal instead of prebuilt one. Might solve a lotta headache just like it solved for xiaomi and zuk devices. Just a thought ;)
[OnePlus 3 & 3T Cross Device Development] Itachi_Uchiha:
Great New Build! I just wanted to know is there any way (manual prop file changes also) I can decrease the always on display brightness?

I love the new animation it brings and I'm getting great battery life. So is there any way to link the brightness of the always on display to the phone's display brightness?
[OnePlus 3 & 3T Cross Device Development] knpk13:
I already asked if AOD brightness can be changed. Apparently the answer for now is there's no way.
[OnePlus 3 & 3T Cross Device Development] :
Yes they mean something: frameworks/av, frameworks/base ;)

This has already been thought/tried: https://github.com/OnePlusOSS/android_hardware_qcom_camera/issues/1
[OnePlus 3 & 3T Cross Device Development] CodesCodger:
but they removed image processing algorithm only.

This : https://github.com/dianlujitao/android_device_oneplus_oneplus3/tree/cm-14.1-oss-camera/camera

I don't know why dian never continued this.

and This: https://github.com/ThankYouMario/pr...mmit/e6ed10cbae927911f516f0beff6d728955797975 looks like there are more things needed.
[OnePlus 3 & 3T Cross Device Development] :
Please see https://review.lineageos.org/q/proj...eplus3+branch:%5E.*cm-14.1.*+status:abandoned all cam commits and all relation chains: [MENTION=5091734]dianlujitao[/MENTION] has not just stoped. We have done extensive testing and trying...

I've also tried porting the oneplus proprietary callbacks (see my nlos-14.1 thread for details) without success.
[OnePlus 3 & 3T Cross Device Development] CodesCodger:
I only found shim related commits. Looks like compiling camera hal from caf sources is a side project. Did you guys able to get viewfinder on camera using caf camera hal?
[OnePlus 3 & 3T Cross Device Development] :
I've spended more then hundred hours on this cam sh!t. Not only on the abandoned commits and [MENTION=5091734]dianlujitao[/MENTION]'s oss port, but also on some tries of [MENTION=4800121]Sultanxda[/MENTION] and the port of the callbacks. I can't remember each and every try. You really need to read through lineage-14.1 thread, nlos-14.1 thread and [MENTION=4800121]Sultanxda[/MENTION]'s los thread.

The oss cam hal doesn't play nice with the los codebase. With the oss hal you get even more problems.

Please understand, that I don't like to go through all this again. Why don't you try yourself? I will not spend more time on it.

The time I've spended on this conversation is now missing to prepare an updated build with the f/a patch for today...

[MENTION=7134312]knpk13[/MENTION], [MENTION=6561751]pedritopl[/MENTION]: I've decided to go with generic f/a patch for nlos.
[OnePlus 3 & 3T Cross Device Development] CodesCodger:
Already tried on CAF. There's nothing wrong on lineage base.
[OnePlus 3 & 3T Cross Device Development] :
If you use the oss hal, you also need to use the oss changes to the rest of the rom sources (see the f/a vs. f/b patch convesations in this thread as example, there is much more in the oss sources), which will not happen on los.

Of course it's working if you build from modified caf sources (like oss - in deed oss was my first build for op3t).
[OnePlus 3 & 3T Cross Device Development] CodesCodger:
Probably that's why struggled with viewfinder because i didn't include camera changes. I used necessary changes in camera hal to work with proprietary blobs ( given on oneplus oss). The camera in logs could detect sensors but was unable to get a feed out of them.
[OnePlus 3 & 3T Cross Device Development] :
That's the root of the "funny" conversation in the git's issue tracker: [MENTION=5091734]dianlujitao[/MENTION] ask how to use the oss hal on custom builds, and the staff member answeres that pulling all the oss code is required... The next problem you run into is identifying the cam related parts of the commits from oneplus - these are squashed and not well documented...
[OnePlus 3 & 3T Cross Device Development] CodesCodger:
That's true. It's hard to track which parts are actually needed
[OnePlus 3 & 3T Cross Device Development] pedritopl:
In my opinion - that's a good decision. Thanks :)
[OnePlus 3 & 3T Cross Device Development] :
The design is nearly perfect now. The jump has now moved from part0->par1 to bootlogo (back in black). (We should start with version numbers on your animations... )

But the initial slowlyness has increased compared to the newlogo/oldlogo previous renderings. Don't pay too much attention to the size of the zip asl long as it's not far more then 10 MB.

Though I like the old boot logo, I'd suggest for the ease of setting it up (saves us from flashing back in black) to go for the new one. The one I've shipped with the last build (newlogo) is perfect.

BTW: I've noticed that the initial slowlyness is quite short, if rebooting without wiping caches.

One idea (I hope you like it): when transitioning from the oneplus logo to nlos logo, don't fade out the plus sign and fade in at the bottom, but let it (while still turning) go in a large right turn from the logo to the bottom like a spinning boomerang. On the transition to the characters the sign moves up again to the N of NLOS.
[OnePlus 3 & 3T Cross Device Development] :
UPDATE (adreno blobs: LA.UM.7.6.r1-03900-89xx.0; camera: default to HAL1 for api1)

Build 20190121

Releasenotes:

NLOS-16.0 relays on OxygenOS firmware. OxygenOS 5.0.8 firmware or later is required:

Oneplus 3T: OxygenOS 5.0.8 firmware

Oneplus 3: OxygenOS 5.0.8 firmware

For a complete list of additional cherry picks see: current.pick.sh.

Changelog (Last repo sync: 21 Jan 2019, 10:27:36 CET / 21 Jan 2019, 09:27:36 UTC):

NLOS: track our own frameworks/av. — Nvertigo to use this:

CameraService: default to HAL1 for unassigned HAL with API 1. — nvertigo

Revert "current.pick.sh: Camera: Force HAL1 for predefined package list; op3: Force HAL1 for WhatsApp." — Nvertigo

Revert "Revert "Revert "current.pick.sh: LA.UM.7.6.r1-03900-89xx.0.""" — Nvertigo

op3: doze: Fix AoD default pref — Henrique Silva

op3: Update adreno blobs from LA.UM.7.5.r1-03700-8x96.0 — dianlujitao

op3/t: sepolicy: remove ssr nodes. — Nvertigo

fs: sdfat: Fix frag_ratio formula — Noctis Ackerman

fs: sdfat: Update to version 2.1.8 — derfelot

NLOS-Bootlogo

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip(pre ob16 OxygenOS Bootlogo)

[SIZE="+2"]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3 & 3T Cross Device Development] hattorihansou:
Sorry [MENTION=4405529]nvertigo67[/MENTION] for the delayed feedback.

With the build from 19.01.19 my problem with sRGB was fixed. Thank you!
[OnePlus 3 & 3T Cross Device Development] pedritopl:
Thanks!

And for all the poor souls on LOS-16.0 ;) - will You propose a patch to the LOS code adding the CamScanner app to the same list as WhatsApp or should I ask dianlujitao in the LOS thread?
[OnePlus 3 & 3T Cross Device Development] :
Tell him. Perhaps in reply to https://xdaforums.com/showpost.php?p=78675665&postcount=503
[OnePlus 3 & 3T Cross Device Development] pedritopl:
Okie dokie. Done: https://xdaforums.com/oneplus-3/one...ageos-16-0-oneplus-3-3t-t3866517/post78728423
[OnePlus 3 & 3T Cross Device Development] simthadim:
In your download link all files are named as ***beta-oneplus3T.zip

To avoid future confusion, it may be an idea to change it to ***beta-oneplus3AND3T.zip or something alike. Spend some time looking for a OP3 specific build because of this ;)

After flashing (latest build) TWRP warned me when I pressed reboot that no OS was installed (even though I just flashed NLOS). First boot (having flashed microG as well), booted with the blue LED on. After a few minutes of the bootscreen it rebooted in the recovery. Second boot did not have the blue LED and also rebooted to the recovery (but after a much longer time >5 min)
[OnePlus 3 & 3T Cross Device Development] hattorihansou:
Updated firmware to OxygenOS 5.0.8?
[OnePlus 3 & 3T Cross Device Development] :
No OS no boot. That's a matter of fact.

Follow the instructions in OP. If twrp states "no OS", abort the reboot and get the recovery log, a step by step description of your all your actions and your setup (fw version, twrp version, other initial flashed software's versions, output of flashing).
[OnePlus 3 & 3T Cross Device Development] simthadim:
(tried it again, new download. checked MD5checksum)

Phone: Oneplus 3 (European version: that is the A3003, if I'm not mistaken)

Initial ROM: Official LOS 16 beta without GAPPS.

TWRP version: 3.2.3-1

FIrmware: 5.0.8 (flashed prior to LOS16)

wipe -> advanced wipe -> select all -> wipe

format data -> yes

adb sideload "nlos-16.0-20190121_094215-beta-oneplus3t.zip"

laptop (Ubuntu) terminal output: "Total xfer: 1.00x", phone output

Phone output: script succeeded: result was [1.00000]

recovery.log, see attached file.
[OnePlus 3 & 3T Cross Device Development] :
Don't use twrp-3.2.3-1 - IT'S BROKEN!!! - follow OP. Please try the recommended procedure from OP (adb push to transfer the zip; and then flash from within twrp). If you have formated system or data, reboot before flashing.

BTW: if you have used twrp-3.2.3-1 for formating data, youmwon't be able to use encryption again, until you format data again with reservation for encryption footer. See twrp thread for details.
[OnePlus 3 & 3T Cross Device Development] simthadim:
Switching to TWRP-3.2.0-fix3 did it for me. I was unaware that 3.2.3-1 was broken. Sideloading the zip did not work (checked it for the heck of it). However a push and 'manual' install worked. Thank you very much for your itme.

Next step is to enable signature spoofing for the playstore (i.e. fakestore from the microG package, microG itself has signature spoofing). It is the only checkmark missing, and presumably the thing why Whatsapp refuses to install. Weird though.

Thanks again.
[OnePlus 3 & 3T Cross Device Development] :
That's really strange. Just to be sure, I've checked if the spoofing and lp outside system patches may got lost, but both are in:

https://github.com/nvertigo/android_frameworks_base/commit/7072cca0048b26941952e8b5d505e9ee6cf7b580

https://github.com/nvertigo/android_frameworks_base/commit/4033f627269043bb0666e0c165689ed5f04e0cc0

I know of two users successfully using microg, perhaps one of you can help here, please?
[OnePlus 3 & 3T Cross Device Development] simthadim:
I solved it using: https://shadow53.com/android/no-gapps/faq/playstore-incorrect-signature/

I flashed both microG and fakestore as systemapps. I had to get root access (Magisk) in order to 'assign' signature spoofing to 'fakestore' via:

su
pm grant com.android.vending android.permission.FAKE_PACKAGE_SIGNATURE

Works perfectly, now. Though with MicroG GMScore I had the option to give it signature spoofing without root (the app requests it when tapping the option within the app. Tapping on faskestore permission did noting). Could be a microG feature, rather then something on your end.
[OnePlus 3 & 3T Cross Device Development] :
Great finding!

I'll try to include that by default.

Sidenote: Since pie I suspect some apps (oandbackup in the first place) to doesn't migrate permission handling to pie properly. The permission(s) (for oandbackup some more then just one as for microg in this case) should be requested by the app and a user dialog to grant or deny that requested permission should pop up. If including android.permission.FAKE_PACKAGE_SIGNATURE for com.android.vending works, I can try the same workaround for oandbackup.
[OnePlus 3 & 3T Cross Device Development] ArchGalileu:
Hello [MENTION=4405529]nvertigo67[/MENTION]

I'm having trouble with camera on the 21 release... can't record 4k or 1080... also the quality was really bad from video... of course ;)

I downgraded and working perfectly....

Best regards

ArchGalileu
[OnePlus 3 & 3T Cross Device Development] :
The video, you can't record has bad quality? This is an oxymoron.

Which app? Snap?

Installation type? (Does it happen with a clean flash, too?)

Mods?

Gapps package?

Test scenario?

Error message?

I can record 1080p and UHD with Snap and pixel2mod V8. Snap's video and picture quality is not so good as p2m's.
[OnePlus 3 & 3T Cross Device Development] knpk13:
Lol [MENTION=5152592]ArchGalileu[/MENTION] (and everyone really) , try not to make this poor guy ask for the same basic information every time and include a log xD

I'm surprised he hasn't given up in frustration yet. What a noble soul lol. Most other devs aren't as engaging as nvertigo in the threads and that's really nice to see. It's courteous/respectful to the dev to read the OP and provide a detailed report of the issues.
[OnePlus 3 & 3T Cross Device Development] :
UPDATE (kernel: LA.UM.7.5.r1-04000-8x96.0 & WG 20190123; blobs: display postproc)

Build 20190124

Releasenotes:

NLOS-16.0 relays on OxygenOS firmware. OxygenOS 5.0.8 firmware or later is required:

Oneplus 3T: OxygenOS 5.0.8 firmware

Oneplus 3: OxygenOS 5.0.8 firmware

For a complete list of additional cherry picks see: current.pick.sh.

Changelog (Last repo sync: 24 Jan 2019, 16:10:46 CET / 24 Jan 2019, 15:10:46 UTC):

current.pick.sh: force picking "Revert "AOSP/Messaging: bump targetSDK to 28"". — Nvertigo

op3: Update display postproc blobs from LA.UM.7.5.r1-03700-8x96.0 — dianlujitao

op3: Remove unused jars — dianlujitao

WG: squash WireGuard-0.0.20190123. — Nvertigo

Merge tag 'LA.UM.7.5.r1-04000-8x96.0' of https://source.codeaurora.org/quic/la/kernel/msm-3.18 into HEAD — dianlujitao

op3: Disable IPC Router MHI transport — dianlujitao

oneplus: make sure some wakelock references are destroyed — Francisco Franco

sched/core: Fix a race between try_to_wake_up() and a woken up task — Balbir Singh

tty: check before stopping kthread — Philip Cuadra

NLOS-Bootlogo

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip(pre ob16 OxygenOS Bootlogo)

[SIZE="+2"]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3 & 3T Cross Device Development] darthchicken:
Notifications for messenger are acting strange again. Sometimes the notification light stays on, sometimes I get a few blinks, sometimes no light at all... I haven't been able to figure out what the pattern is... Anybody else?
[OnePlus 3 & 3T Cross Device Development] ArchGalileu:
Only this night i made a clean flash...

I will teste pixel2mod v8 and comment...

Best regards

ArchGalileu
[OnePlus 3 & 3T Cross Device Development] simthadim:
Just now I experienced a screen/overlay freeze. While installing an app (Fitnotes, trough the Aurora play store[1]) the overlay that shows an overview of the app permissions and the options 'cancel' and 'install' froze.

I used the right hardware button to get an overview of active apps, selected the installation window and managed to install the app. However, the homescreen was still stuck on the initial overlay.

When tapping on locaitons where I know there are app shortcuts my phone launched that specific app (e.g. Antennapod), though the homecreen remained the frozen overlay. I rebooted my phone, tried to extract the logcat and that's it. The logcat is attached. (I presume the issue was caused at 14:22, because I read an overlay related error message. Hope it is the right log).

Hope this helps with the NLOS development. :) Many thanks for your effort for making this.

[1] Aurora app store is a fork of the yalp store. For both, see F-droid. They allow for a more anonymous way of using official play-store signed apk packages. And are my go to option with Micro G.

EDIT: Thank you [MENTION=7134312]knpk13[/MENTION]. Can't seem to upload it. A wetransfer instead: https://we.tl/t-Pp5K0JiRcQ

Additional info:

Oneplus3 A3003

Running the 21-01-2019 build,

No Gapps but MicroG instead.

Firmware version 5.0.8
[OnePlus 3 & 3T Cross Device Development] knpk13:
I don't see any logs attached to the post.
[OnePlus 3 & 3T Cross Device Development] :
Too late to get a usefull logcat: the logcat ringbuffer is in ram, and therefor is vanished after a reboot. Also: mentioning "an error message" without the exact content of this message does not really help.

If it's overlay related a SystemUI restart should help - no need to reboot.
[OnePlus 3 & 3T Cross Device Development] Siddk007:
i'm not getting always on display (AOD) notifications for whatsapp when phone is locked. however, AOD works for SMS . i'm using latest build dated 24th
[OnePlus 3 & 3T Cross Device Development] simthadim:
I did not know the logcat is boot specific. Learned something new. Will see if the situation turns up again.

Referring to 'the error message', I scanned the logcat and found some lines that states that involved an overlay. However, some more detailed reading:

"01-26 14:22:32.198 1027 1940 W ActivityManager: Unable to start service Intent { act=com.android.launcher3.WINDOW_OVERLAY dat=app://com.android.launcher3:10030?v=7&cv=9 pkg=com.google.android.googlequicksearchbox } U=0: not found"

This has nothing to do with my problem, though is something the OS appearently wants GAPPS for while booting. I jumped to a conclusion too quickly. Again, will see if I can reproduce the UI freeze I mentioned earlier.
[OnePlus 3 & 3T Cross Device Development] :
Works for me. I can even tap answer directly in AOD like in ambient.
[OnePlus 3 & 3T Cross Device Development] :
I got overlay wrong. I thought you were refering to a theme and got an error message... ;) The logcat line is a warning (W) and is ok if google apk isn't installed. This is because quite some launchers have the feature for the g quick search box. Disable quick search box (for trebuchet disable show google app) in the launchers settings.
[OnePlus 3 & 3T Cross Device Development] immi803:
[MENTION=4405529]nvertigo67[/MENTION]

First of all, thank you for your great work, loved your Rom

Can you elaborate microg , my requirement is Google Play Store, location services fully functional, all apps working problemless...

I appreciate your patience, please elaborate how to get this working, step by step guide is appreciated
[OnePlus 3 & 3T Cross Device Development] simthadim:
All apps working problemless, that might be a problem with alpha-phase software. Please check the microG website and thread, there is a very clear statement (what it is, how to install, the issues,...) . it works for me, but may not suit you (even after tweaking)
[OnePlus 3 & 3T Cross Device Development] Maynard100:
Hi, I really want to try this ROM. Is there an option to swap left & right hardware buttons? This is because I'm used to the left as the recents menu and the right as the back button.
[OnePlus 3 & 3T Cross Device Development] :
That's a mental long term issue. One gets infected by using sammy too much... ;)

NLOS has a switch for.
[OnePlus 3 & 3T Cross Device Development] deejaycarras:
Anybody have white led and freeze phone issue?
[OnePlus 3 & 3T Cross Device Development] qasimtb:
Hi everyone does location services get properly registered in this ROM with Micro-G or we need some workaround for it.
[OnePlus 3 & 3T Cross Device Development] :
Try getting the content of /sys/fs/pstore/ on the very next boot (best practice: if device freezes switch it of and boot to recovery; in recovery copy /sys/fs/pstore/ to /sdcard/Download/pstore/; boot to system and zip /sdcard/Download/pstore/*).

Signature spoofing and Location Service outside system is in. In one of the last builds I've added an additional needed permission. So I think it should work. Sadly I can't test myself, since my banking app refuses to work without certified play store.
[OnePlus 3 & 3T Cross Device Development] :
UPDATE (kernel: 3.18.133; WireGuard 20190123; fix manual carrier selection)

Build 20190127

Releasenotes:

NLOS-16.0 relays on OxygenOS firmware. OxygenOS 5.0.8 firmware or later is required:

Oneplus 3T: OxygenOS 5.0.8 firmware

Oneplus 3: OxygenOS 5.0.8 firmware

For a complete list of additional cherry picks see: current.pick.sh.

Changelog (Last repo sync: 27 Jan 2019, 15:24:17 CET / 27 Jan 2019, 14:24:17 UTC):

current.pick.sh: libril: Fix manual network selection with old modem & op3: Enable workaround for old MCC/MNC format. — Nvertigo

Merge tag 'v3.18.133' of git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable into linux-stable/merge-16.0 — Nvertigo

WG: squash WireGuard-0.0.20190123. — Nvertigo

NLOS-Bootlogo

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip(pre ob16 OxygenOS Bootlogo)

[SIZE="+2"]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3 & 3T Cross Device Development] pedritopl:
You fixed it? :)))

Downloading :)

Edit: confirmed to be working just as in NLOS-15.1 :)
[OnePlus 3 & 3T Cross Device Development] simthadim:
Could you specify your question? I think it is more microG specific, than ROM specific. Nontheless, unifiedNLP (what you are referring to) works IF, and only IF, you follow microG instructions.
[OnePlus 3 & 3T Cross Device Development] :
To honor the facts: Han Wang fixed it and Dianlujitao found it (it was abandoned). I've just tested it.
[OnePlus 3 & 3T Cross Device Development] deejaycarras:
[MENTION=4405529]nvertigo67[/MENTION], i have another white light led freeze. I attach you zip file with pstore files copied from recovery. I hope this help to discover the problem!

I think this can related with bluetooth connexion (two freezes after park the car at job)

Regards!