yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] :
Ok.

I don't know the app, I've searched and found the xda posting as well as the https://apkpure.com/. It seemed to me, that apkpure allows to circumvent restrictions including payment. If that is not the case, or only the case for the modded app, I apologize.
[OnePlus 3 & 3T Cross Device Development] :
On build fingerprints

Using the 9.0.6 fp instaed of 9.0.5 fp has no benefit.

Staying with 9.0.5 fp instead of using 9.0.6 has no drawback.

Since we set the build fp two times (once by init, once by buiöd.prop; and the build.prop fp is fpr op3, even if the device is op3t), I prefer having the two different fps as similar as possible, as long as this doesn't result in any drawbacks. It's not necessary, nor does the difference in 9.0.6 fps prevent their usage, but using 9.0.5's fp won't hurt.

As always: stick to OP and announcement (it's the same! ;) ).
[OnePlus 3 & 3T Cross Device Development] hellcat50:
I am getting "E AndroidRuntime: java.lang.ArrayIndexOutOfBoundsException" app crashes when trying to open apps with the newest release. And the strange thing is: if i use matlog (or catlog) and scroll up and want to see the crash log, the app crashes. I had to use my computer to capture these logs.

if you need the full log let me know.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
No such problem for me on 191205. Your error doesn't show up in my logcat.
[OnePlus 3 & 3T Cross Device Development] knpk13:
All the apps I usually use have been working without any problems, but since you mentioned Matlog, I tried it, and huh, it does crash. I even tried reinstalling it, weird. What other apps don't work for you?

To be fair, I don't think I've used Matlog in a while, so I don't know if the problem was introduced in this build.
[OnePlus 3 & 3T Cross Device Development] :
Well i just have a system ui crash after i woke up, need a force reboot. Before media storage fail to register any ringtones, clean it's data and reboot and wait for a while does the fix for media storage

Something is wrong with dirty flash it seems. This is the first i got quite problems with dirty flash on nlos..

I'll try clean next since it might be my setup...

==============

Seems like this is the culprit for system ui crash on my end

https://whatsaero.com/

can anyone with clean flashed system check? use it for a while, it doesn't make the system ui crash immediately. In my expereince, just for the night.
[OnePlus 3 & 3T Cross Device Development] hellcat50:
yes it's probably dirty flash issue. but i don't want to clean flash again. i simply want to update :/
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Well, I dirty flashed 191205 over my previous install (191107) 24 hours ago and I've had no problems.
[OnePlus 3 & 3T Cross Device Development] :
I've never used matlog (sic!). I've installed it, granted root permissions (magisk 20109) and after some scrolling back matlog crashes with:

12-07 09:37:06.930 16894 16894 W StaticLayout: maxLineHeight should not be -1. maxLines:1 lineCount:1
12-07 09:37:06.932 16894 16894 I chatty : uid=10075(com.pluscubed.matlog) identical 2 lines
12-07 09:37:06.932 16894 16894 W StaticLayout: maxLineHeight should not be -1. maxLines:1 lineCount:1
12-07 09:37:06.934 16894 16894 D AndroidRuntime: Shutting down VM
12-07 09:37:06.935 16894 16894 E AndroidRuntime: FATAL EXCEPTION: main
12-07 09:37:06.935 16894 16894 E AndroidRuntime: Process: com.pluscubed.matlog, PID: 16894
12-07 09:37:06.935 16894 16894 E AndroidRuntime: java.lang.ArrayIndexOutOfBoundsException: length=86; index=86
[...]

I'm pretty sure the out of bounds is a follow up error of the static layout error. Out of bounds of an array means here: the array has 86 elements, indexed from 0 to 85. If the app tries to access index 86 this doesn't exist. This needs to be fixed in the app.

Considering matlog has been updated the last time over a year ago (11/07/18), I guess it's just some missing adjustment in the app, which leads to a line height request of -1.

[MENTION=655117]hellcat[/MENTION]:

I've dirty flashing since 8 months or so - since I often flash builds between releases, I've flashed about ~200 times. The only system ui crashes after a dirty flash I've expirienced were when playing with substratum themes and forgot to disable the overlays before dirty flashing. I've never expirienced issues with media storage or media scanner.

The same gpes for some magisk modules: always uninstall modules before a dirty flash.

General note on updating/dirty flashing: always wipe caches and dalvik after flashing a new rom. If an system app or a system service is updated without increasing it's version number the caches arn't automatically rebuild, this can lead to strange side effects.

Did you get a (adb) logcat when systemui crashes? Did you save /sys/fs/pstore on the bery next reboot?
[OnePlus 3 & 3T Cross Device Development] knpk13:
we're supposed to disable substratum overlays before dirty flashing? is that necessary? ive never done that before, and i have not had a systemui crash either.
[OnePlus 3 & 3T Cross Device Development] :
That isn't happen on previous build though, i remember used it once

Let me check later with previous build

I don't use substratum themes...
[OnePlus 3 & 3T Cross Device Development] :
It's not necessary until it's necessary... ;) I think it depends on the resources themed and on the installer used. If systemui is themed and a themable resource in systemui is changed, then crash, boom, bang...

It's like wiping caches: it works 50 times, but one time...

Even if the December asb patches introduced something, which triggers this error, what do you expect me to do? Rolling back to make an app running, which hasn't been updated for a year?

I guess it's this: https://review.lineageos.org/c/LineageOS/android_frameworks_base/+/265144

I'm checking that.
[OnePlus 3 & 3T Cross Device Development] :
Depends on if the new patch introduce little benefit but more problems or greater benefit with little problem :laugh:

I don't use matlog often though
[OnePlus 3 & 3T Cross Device Development] :
Still not answered - would be interesting to know... See below... *lol*

*lol* I've never used it, and never will: it's not possible to examine a log with this funny toy... *lol* It only motivates users to send crippled logs... So breaking log apps is the benefit of this commit!!! *lol* In deed, I LOVE this commit! *lol*

Back to business:

https://review.lineageos.org/c/LineageOS/android_frameworks_base/+/265144

https://review.lineageos.org/c/LineageOS/android_build/+/265279

Let's see if/what Kevin comments.
[OnePlus 3 & 3T Cross Device Development] hellcat50:
Sorry for answering that late, I got app crashes with several apps: FairEmail, CPU-Z, (ProtonVPN only once) and some apps behave weirdly (long load times, sluggish performance, but at random): ING Banking, Slide, (Tor Browser is slow in general but even slower than usual with latest update)

i should add that i reinstalled every app to see if it's better after that

I uninstalled every module and every theme i had applied, still got these app crashes

FINAL EDIT: My systemui didn't crash, i just got these weird app crashes. That's all. Other than that the new version worked fine.
[OnePlus 3 & 3T Cross Device Development] :
Hotfix for java.lang.ArrayIndexOutOfBoundsException

This is the very same build (no "make clean") as the last update, but with

Revert "RESTRICT AUTOMERGE Do not compute outside given range in TextLine" — Nvertigo

ROM: https://drive.google.com/open?id=1Da9pK3AyeEKstO1WZHfQovuSsgv-4_1M

MD5: https://drive.google.com/open?id=1Cph44-7E-bhdDh4FGvQwHl87znk9dtZI
[OnePlus 3 & 3T Cross Device Development] hellcat50:
no more crashes with this release :svetius:
[OnePlus 3 & 3T Cross Device Development] knpk13:
I followed the conversation, looks like it's going to be fixed, but I have no idea what they're talking about rip. How did you figure out that that commit was the problem?

As a side note, how do you usually take logs? I tend to use Matlog since that way I can do it on my phone. The other way I know is getting a logcat over adb, but I have to connect to my laptop to do that. Is there a difference? Since you said you don't like Matlog because it cripples logs or something.
[OnePlus 3 & 3T Cross Device Development] :
Brain driven pattern and line number matching... ;) (the latter is a bit sketchy, because of nlos' additions)

Log:

12-07 09:13:41.712 9800 9800 E AndroidRuntime: at android.text.TextLine.draw(TextLine.java:267)

This logline leads to https://github.com/LineageOS/androi...f3d/core/java/android/text/TextLine.java#L260

Really? I feel like writing the following code at least twice a week:

adb logcat -d >/some/funny/path/logcat.txt

Reason: when dubugging something I try to exclude as much sources of errors as possible. It doesn't cut the ppids. Since it's not possible to examine a log in that toy, I need my tab or laptop anyway (less, vi -R and grep are my best friends). adb over network doesn't even need a wired connection.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
I understand why [MENTION=4405529]nvertigo67[/MENTION] uses ADB - he wants to look at the files on his tablet or PC.

I, on the other hand, rarely hook my phone to a PC so I always collect my logs on my phone by running the logcat command in a terminal session. Note that you have to run it as su or it's useless.
[OnePlus 3 & 3T Cross Device Development] Kewjoe:
Does anyone know why Disney+ shows as incompatible in the play store? I'm on latest version and firmware. No mods, no root. I tried flashing safetynet patch, didn't help.
[OnePlus 3 & 3T Cross Device Development] knpk13:
No idea, works for me. I use magisk and the security patch zip posted in the OP to pass safetynet. I don't think NLOS includes the kernel patch for safetynet, as written here.

You can flash magisk for the kernel patch in addition to flashing the security patch zip that nvertigo posted.

Also not sure if safetynet restricts downloads of apps in the play store. My battles with safetynet have been with the app actually working, not downloading it.

Edit: Could also be incompatible because of your location perhaps?
[OnePlus 3 & 3T Cross Device Development] :
I think the main difference is between "taking logs" and "examine logs". If I imagine I would have examined the home button stoped working logs on 5" screen with it's onscreen keyboard for some hours...

It's about using the right tool for a given task: you can't tear down a wall build from bricks with a tooth brush... I mean, you can, but... ;)

Does it work on OOS?

If you look at https://forums.oneplus.com/threads/disney-app-not-compatible-with-op7pro.1138637/ disney+ does not only require L1 drm (nlos/los offers L3 only), but even a op7 with L1 is not compatible.

More information on disney+ compatibillity, installing split apks and possible workarounds:

https://xdaforums.com/oneplus-7-pro/help/disney-compatible-t4001975

https://www.androidcentral.com/havi...-disney-your-android-phone-disney-working-fix
[OnePlus 3 & 3T Cross Device Development] Kewjoe:
Thank you both. Since it's working for [MENTION=7134312]knpk13[/MENTION] , I'll try a clean install over the Christmas break. I'm due for one.
[OnePlus 3 & 3T Cross Device Development] :
What? Where is that? This is nonsense. NLOS complies to safetynet api out of the box with the sec-patch-2019-08-01 zip.

https://github.com/nvertigo/android...mmit/0e17d9aaf4b665349ef9125cd51d2219ad2728a9

https://github.com/nvertigo/android...mmit/e4e0bd274eee201611ec6156b08f8f59f67e1d62

My device is passing safetynet tests, but disney+ is shown as incompatible. In my case, because I'm in Germamy.
[OnePlus 3 & 3T Cross Device Development] :
Please read, what I've searched for you - it's most probably NOT a dirty flash issue (99.9 %). Check if you pass safetynet and if playstore is certified (I understood your initial posting, that your device passes safetynet tests), that's all you can do.

The claim on missing kernel patches is nonsens.
[OnePlus 3 & 3T Cross Device Development] Kewjoe:
My safetynet is failing due to CTS profile match. Playstore is also not certified. Not sure what caused that.
[OnePlus 3 & 3T Cross Device Development] knpk13:
Sorry but maybe I'm misinterpreting something. You wrote in post #3 that you need a kernel patch in addition to the security patch zip, so I thought it meant NLOS didn't have the patch. I'm guessing that was a posting in general, for all (other) ROMs.
[OnePlus 3 & 3T Cross Device Development] Kewjoe:
Ah I see I also need to lock bootloader or use magisk module to pass the test.

Edit: misread. It should work without these things. Not sure why it is not.
[OnePlus 3 & 3T Cross Device Development] :
Posting number #3 reads:

I don't say nlos doesn't have these kernel patches. It reads clearly "a kernel patched to throw away the tripped verity flag". nlos comes with such a patched kernel, since three years! Each announcment clearly states you only need to flash sec-patch-2019-08-01_v02.zip in order to pass safetynet api.

To avoid future misunderstandings, I'll add "(like the shipped nlos kernel)".

I've just unimstalled magisk and made a new screen shot. nlos is passing safetynet api out of the box with sec-patch-2019-08-01_v02.zip applied. (5.0.8 bl, unlocked)

Which zip did you use?

What's the output of "getprop ro.build.version.security_patch"?

adb shell getprop ro.build.version.security_patch
2019-08-01

Do you use a custom kernel?

Anything special about your setup?

EDIT:

To avoid future misunderstandings I've added

"The shipped kernel is prepared to comply to googles safetynet api. Since google has started to check if the sec patch level matches the build fingerprint, it's necessary to adjust the aosp based shipped ro.build.version.security_patch to the currently used OxygenOS build fingerprint. For details see posting #3 and the announcment of each build."

to OP.

EDIT2:
[MENTION=2912675]Kewjoe[/MENTION]:

Which bootloader are you using?

What's the status of selinux? permissive or enforcing?
[OnePlus 3 & 3T Cross Device Development] Kewjoe:
I used the 3rd one "sec-patch-2019-10-01_v02.zip"

2019-10-01

No, just yours. I would never cheat on you :) For clarity, i'm using your latest Dec 5th ROM and using firmware 9.0.6 with the 5.0.8 bootloader and keymaster

Absolutely nothing special

I'm using 5.0.8 bootloader.

We used to be able to see this in the settings didn't we? can't find it anymore. anyway, ran the following and got '1' which means enforced

adb shell getprop ro.build.selinux
[OnePlus 3 & 3T Cross Device Development] SenseSei:
And here's the user error. Read post #3 and the announcements of each new version again.
[OnePlus 3 & 3T Cross Device Development] Kewjoe:
I'll concede that i was doing this at 4am because i woke up and couldn't go back to sleep. But it's 8:37am now and I'm seeing things more clearly. Why did i make a mistake? Of the 3 options, i still see the 3rd one being the correct one as I'm using 9.0.6 firmware. My Android and Vendor patch level are matching. Which one am I to use?

Edit: ah, i see. need the 2019-08-01_v02 version. my bad. thanks for catching! :) flashing now.

---------- Post added at 08:46 AM ---------- Previous post was at 08:38 AM ----------

Ok, seems like I made some progress. After flashing 2019-08-01_v02, i pass safetynet now. Even though my Android and Vendor patchs are different (Android Aug 1, 2019, Vendor Oct 1, 2019). However, playstore stills says not certified and Disney+ still doesn't show up.
[OnePlus 3 & 3T Cross Device Development] :
Force stop playstore, delete it's data, restart it and wait for about five minutes.

Though passing sfetynet api and a play protect vertified device is the necessary condition - it doesn't mean that disney+ shows up. Being in the wrong country (like me, see previois posting) or any of what's mentioned in the oneplus thread I've linked can prevent you from receiving disney+ from playstore...

It has moved from "Settinhs->About phone" to "Settings->Security & location->Trust".
[OnePlus 3 & 3T Cross Device Development] Kewjoe:
OK trying the force stop and data clear. I'll report back after trying. As for Disney+, yes of course. I have it on my nvidia shield TV. Definitely available in my country (Canada).

Edit: Woohoo it works! Thanks [MENTION=4405529]nvertigo67[/MENTION] and others for the help!
[OnePlus 3 & 3T Cross Device Development] :
Is it possible to add a shortcut to advanced setting privacy guard in app info? Finding the new installed app takes time if do it manually

Also why it can't regulate the system app.. such a waste for a cool feature. But that's another subject for official los though.

============

I'm going clean now, this is newpipe freeze logs (and some other)

============

Clean have a same problem. Fuk those dec patch then, i'm choosing my own setup.

Back to rc1.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
You need too know that your firmware has nothing to do with SafetyNet. And neither do the blobs used by the rom.

What matters are the fingerprint and security patch date reported by the rom.

Fortunately [MENTION=4405529]nvertigo67[/MENTION] is kind enough to tell us which zip to use.

Otherwise you would have to install the rom and then look at the fingerprint to select the correct security patch zip.
[OnePlus 3 & 3T Cross Device Development] :
No. I don't see any necessarity. In deed, I like the seperation of "normal" (aka aosp api based) permissions and the addotional app-ops in trust. I can't see the time taking point, neither: you have not only a alphabetic sorted list, but also a search field at the top; and you can enable privacy for all freshly installed apps by default.

I don't know what "the system app" means. There are many system apps, which are controlable, of course - if enabled.

If an app is not only an system app, but also an previleged app, you can only control those permissions, which arn't granted as part of /system/etc/permissions/privapp-permissions-*.xml. That's the base concept of previleged apps.

The log isn't complete. Booting (especially package parsing) is missing as well as any hint which build you are using (did you try the hotfix build?). The log contains no traces of a crash or a stacktrace. It doesn't contain any hints that the ArrayOutOfBounds error is triggered. Since the log is incomplete, I don't know if it's really not triggered. Can I assume you followed the hint in the log for SimpleExoPlayer?

I understand, that you are frustated. Please understand, that I don't intentionally try to break things - though it's okay you poke your frustration on me; beside that, to track this down remember that a complete log and a description how to reproduce this can be helpfull. I'm watching clips with newpipe for over 15 minutes without any hassle (Hotfix build).
[OnePlus 3 & 3T Cross Device Development] knpk13:
Everything works well with the hotfix build for me. No Matlog scrolling crashes anymore, and I've never had problems with Newpipe.
[OnePlus 3 & 3T Cross Device Development] :
[MENTION=4405529]nvertigo67[/MENTION]

Don't get my post wrong, i'm not mad to you though.. I'm mad to myself for carelessly update without taking precaution.

First i forget to take backups on recent whatsapp chat, it has a recent important info.. and second, for tinkering when i'm ready to sleep, you know i listened to musics with newpipe, and it really makes me mad when it's broken right before i was ready to sleep, so yeah i'm a little mad when typing previous post lol

Now i'm a little sober, but i'm still pissed about the whatsapp chat. Maybe later, with rc1 everything back to normal even on dirty flash.

For privacy guard advanced setting, what i mean is on the attchement.

To get into that, you must to go into settings>security>trust>privacy guard>click on 3dot up right corner>advanced - and the worst part is after that, finding the app.

I don't understand what "enable privacy for all freshly installed apps by default" do, it'll just ask again later for the permission.

With advanced setting, for example i can grant an app for reading my sdcard, but not writing to it.

About the system apps, my mistake, you can do it through "show built in apps"

About the logs, yes i filtered it right from when i open newpipe. I don't want you to get mad when you see some lines with "...........sandhook sandhook".....

The logs is from hotfix build. Yes i followed the hint in the log for SimpleExoPlayer, but i don't understand it :p

Please, keep using it, it was working normal at first with hotfix build. That bastard just choose to freeze when i really need it.

(What i mean with freeze is when:

24944 25121 W SimpleExoPlayer: Player is accessed on the wrong thread. See https://exoplayer.dev/issues/player-accessed-on-wrong-thread

occur, it's not crashing)

====edit 1====

It was freeze when i use "background" feature, not watching a video
[OnePlus 3 & 3T Cross Device Development] :
Ah, ok. Tjat's a painfull way. I use settings>security>trust>privacy guard->find app in alphabetic list or search field->long press tjat app, and never had problems finding it.

That's the reason why I like the different places for different things: the app can only request permissions in the aosp api (here: access to sdcard), but can't know of what los has added. These are controled via app settings. The app doesn't know of the fine grained permissions in privacy guard - fot that it can't request them.

Putting these different catrgories of permissions in the same (gui)place increases the possibillity to mix them up.

If you check "enable by default" i.e. access to contacts is disabled by default, and the app needs to request it - that way you can check "remember choice" to avoid further questions. That's the way it's designed - and it's very usefull that way.

I understand that. The problem is: if one knows, what's important to look for, he can look at the logs himself; if one don't know what's important, he cuts off important information (like you with skipping the package parsing). To protect myself from wasting my time, I don't work for more then 10 minutes with filtered/crippled/shortened logs.

Please explain endetail how to reproduce.
[OnePlus 3 & 3T Cross Device Development] :
See the attachment

After i press it, the song won't played and the app freeze

I'm guessing it's my setup since nobody doesn't have it. Well it's sucks and i accept the burden on nov builds for a while though

If you don't have it, just ignore my complaint though. I don't want to waste your time either with my setup problem, that's the other reason i filtered the logs.

Lol, i have wasted so much time in my life
[OnePlus 3 & 3T Cross Device Development] :
Played 37 minutes of Ella and Louis (pressed background, changed to homescreen and locked the device). Then I tried the same with "Ella Fitzgerald - Bewitched, Bothered, and Bewildered (Lyrics)" till the end.

It's not artist dependend... ;)
[OnePlus 3 & 3T Cross Device Development] meiser:
[MENTION=4405529]nvertigo67[/MENTION] may I ask you to update WireGuard in an upcoming release? Thanks in advance.
[OnePlus 3 & 3T Cross Device Development] SenseSei:
I know that some devs don't want to add it because it's not properly audited yet.

I'm not nvertigo and this isn't my Rom but I just wanted to add that to the discussion.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
[MENTION=4405529]nvertigo67[/MENTION]

There's a bug (at least I think it's a bug) in the processing of on boot passwords. If you enter an incorrect password and then try again with the correct password you'll still be told that the password is wrong.

The work around is to reboot the phone and enter the correct password on the first attempt.

And in case you wondering, I tested this on the stock boot image without Magisk.
[OnePlus 3 & 3T Cross Device Development] moscic:
[MENTION=4405529]nvertigo67[/MENTION]

Can you add DTS AndroPort Project to kernel?

Commits: https://gitlab.com/dts_project/intro