yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Thanks for clarifying the problem and providing the solution.

I didn't want to wait for LineageOS to fix the issue or use a Magisk module. So I've created a shell script which you can use with Magisk to set the fingerprint and security patch date. Rename the extension from .txt to .sh and follow the install instructions in the script itself.

It's using the 9.0.5 values and there's a file for both 3 and 3T.

Note, it sets both build and vendor.build fingerprints otherwise you get an Android warning when the phone finishes booting.
[OnePlus 3 & 3T Cross Device Development] knpk13:
Thanks, it works. Was just wondering how using a Magisk module is different from a magisk boot script and why you don't want to use a module. I went through Didgeridoohan's thread and documentation for the MagiskPropHide module, but I'm not sure I understood the difference.

Edit: Uh, ctsProfile stopped passing after the next reboot. Not sure if I messed up anything, getprop shows the correct fingerprint and security patch like it did in nvertigo67's post. I put the script (.sh) into /data/adb/service.d and changed permissions to 755 using Solid Explorer as written in the instructions.
[OnePlus 3 & 3T Cross Device Development] :
Yeah, the second one is a bad idea (after a night of sleep it looks even worse...). The first one is just fair enough: updating the build fingerprint to the most current one doesn't violate any los rule.

For the second one we have some options (each one a better idea then exchanging sec level and vendor sec level. One option are the scripts from [MENTION=2911853]BillGoss[/MENTION]:

As soon as https://review.lineageos.org/c/LineageOS/android_device_oneplus_oneplus3/+/259997 is merged, you just need to set the sec level date.

BTW: great idea to make a small script for magisk instead of a configurable module. Really nice and smart. I like straight forward solutions without any unneccessary bells and whistles.

The configurable module is option number two.

As a third option (i.e. for people with locked bootloader and no magisk installed) is a flashable zip, that just sets the matching sec level date. I'll provide such later today.

---------- Post added at 09:18 ---------- Previous post was at 09:10 ----------

You need to update the fw. If you are upgrading from 5.x fw to 9.x fw some ugly things can happen. For upgrading fw from 5.x to 9.x I'd recommend start reading these:

https://xdaforums.com/oneplus-3t/how-to/firmware-beta-10-t3631166

https://xdaforums.com/oneplus-3t/how-to/guide-cope-9-0-3-5-0-8-firmware-barrier-t3941164

And - of course! - this very thread.
[OnePlus 3 & 3T Cross Device Development] Naudiz:
Tried the script by [MENTION=2911853]BillGoss[/MENTION]

CTS check passed, but PlayStore lost its "Certified" status in settings. Not sure why this happened.

What even are the downsides of not having "certified" in PlayStore? I don't even know.
[OnePlus 3 & 3T Cross Device Development] :
After the sec level date is fixed, delete data from playstore app, force stop playstore app, wait 5 minutes and check again.
[OnePlus 3 & 3T Cross Device Development] Naudiz:
Nice one! That worked, thanks.
[OnePlus 3 & 3T Cross Device Development] PiereMallao:
I have LineageOS installed i cant upgrade to Firmware 9.x. With Firmware you mean the oxygenos stock Rom from oneplus? So i have to go back to the stock Rom? Will this delete also twrp and root?
[OnePlus 3 & 3T Cross Device Development] BillGoss:
A module is more complicated to set up, but you can get a lot more creative with it.

I installed the script the same way you did. I have no idea why it doesn't work for you.

Edit: you can change the script to only set the security patch and use 2019-04-01. This should work with the current (9.0.2) fingerprint.
[OnePlus 3 & 3T Cross Device Development] pedritopl:
I just tried it (your script) and it fixed my Google Pay on NLOS:)

Thanks.
[OnePlus 3 & 3T Cross Device Development] :
That would be great! Thx for your great, ongoing support!
[OnePlus 3 & 3T Cross Device Development] Johannes1098:
The same for me.

But a second reboot fixed it and passed the ctsProfile.

I don't know when and how often the Playservices does the safetynet check but I assume it doesn't happen every reboot and only time to time (1 time a day maybe?).

Because the cTsprofile passed for me yesterday (but my sec patch and device string was on LOS default) and actually it had to fail.

But it failed only since this morning.

Installed the script from [MENTION=2911853]BillGoss[/MENTION], twice reboot. ctsProfile passed. Very fine solution, thanks.
[MENTION=4405529]nvertigo67[/MENTION] I also like clean and simple solutions :o
[OnePlus 3 & 3T Cross Device Development] :
Yes, you can.

No. Only the firmware files.

No.

No and yes.

Read the threads I've linked, please.

Also read the twrp thread. Guessing from your questions I see a fair chance you end up with the unbrick tool...
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
Well, right now we don't have better solution, so...push it and I'll merge.

btw we don't really need VENDOR_SECURITY_PATCH so drop it while you're at it
[OnePlus 3 & 3T Cross Device Development] :
As stated earlier, I dislike this myself. For two reasons:

It fakes two variables, though only faking one is necessary.

It's ugly, uninspired and - did I mention it's ugly?

I'm going to make zip to replace the sec date and a nice explanation posting.

Yesterday I wanted to make a build that passes sf api out of the box, and in a hurry I've thought it's a good idea the exchange sec patch level and vendor sec patch level, after sleeping a night (highly recommended - not only here ;) ) over it, I think just changing the sec level by a zip, magisk script or magisk module is the leaner solution.

I'll push it, but before merging, sleep another nicht over it, I'll happily abandon it.
[OnePlus 3 & 3T Cross Device Development] :
Here you go: https://xdaforums.com/oneplus-3/one...-nlos-16-0-t3879405/post78433987#post78433987

Note:

For all los builds until and including 20191004 you need sec-patch-2019-04-01.zip.

For all los builds from 20191005 and later you need sec-patch-2019-08-01.zip.
[OnePlus 3 & 3T Cross Device Development] :
Great, thanks!!

Just flashed the April sec-patch - both, sec-update and vendor sec-patch are now on April - still getting uncertified in Google play store. I've deleted Google play store data, no change. Am I doing something wrong?

I'm on Los 03-10, no magisk.
[OnePlus 3 & 3T Cross Device Development] :
Is safetynet api (including CTS profile match) passing? What do you get for

adb getprop ro.build.version.security_patch

?
[OnePlus 3 & 3T Cross Device Development] :
Unfortunately I have no access to any pc for the next 2 weeks (I'm on holiday :) ). Means no adb access

For the other points I've attached 2 screenshot. Hope it helps.
[OnePlus 3 & 3T Cross Device Development] :
If basic intergrity is failing, this is another issue apart from the fingerprint security patch level date mismatch. Do you jave atleast one of this: locked bl, magisk installed, or a patched kernel? addonsu will break safetynet, too.

EDIT:

Is Settings->Security & location->Trust all green? Do you use gapps or microg?
[OnePlus 3 & 3T Cross Device Development] :
Stock Los, opengapps nano, addonsu, fw 9.0.5 - unlocked bl, no magisk, no mods.
[OnePlus 3 & 3T Cross Device Development] :
Yes I know, addonsu will break safety net. That's clear.

I thought certified/uncertified label in Google play store is not driven by safety net. Am I'm wrong?
[OnePlus 3 & 3T Cross Device Development] pedritopl:
I believe it is. Not 100% sure though.
[OnePlus 3 & 3T Cross Device Development] Dirk:
I don't know if it's relevant now, but i still wonder how the ROM was passing Safetynet at the beginning of this development cycle. (Everyone will remember the discussions we had when it began failing again). What changed? The subject was commented on by the OP in December '18:

https://xdaforums.com/showpost.php?p=78490660&postcount=321
[OnePlus 3 & 3T Cross Device Development] :
I've done the same flash but without having addonsu flashed -> new screenshots
[OnePlus 3 & 3T Cross Device Development] :
The last attachment was missing:
[OnePlus 3 & 3T Cross Device Development] :
Sorry for the attachment mess ... Xda app and attachments is challenging ...

That's the right one:
[OnePlus 3 & 3T Cross Device Development] :
Reflash addonsu, go to dev ops and set root to disabled, boot to recovery again and uninstall addonsu again (if you can disable root in dev ops without reflashing addsu, do that and just reboot to system, I don't remember if addonsu is needed to change the root settings). I hope the outdated patchlevel is no show stopper. If it is a show stopper wait for tomorrows builf and use sec-patch-2019-08-01.zip.

EDIT: remember the at least one out of three rule. If you bl is unlocked, you need eitjer a patched kernel or magisk installed.

[MENTION=1763460]Dirk[/MENTION]: the los kernel never had the verity patches. I still don't know exactly, why sf was passing on the first builds, but I'm ptetty sure it was on g's server side (the test request), because nothing verity related has been changed on los' side, when it stoped passing. Bottom line: g suckz! ;):p
[OnePlus 3 & 3T Cross Device Development] :
Done the first of your tasks ;) -> result, have a look to the two screenshots.

Unlocked/locked bootloader I'm unsure about the impact to my system: can I lock bl without losing data? How can I flash new Los, opengapps, ... with lock bl?

Do I miss something? Thx for clarifying!
[OnePlus 3 & 3T Cross Device Development] :
No, data partition is lost. Just flash as usual with bl locked - only boot partition altering packages may cause issues (use VerifiedBootSigner-v8.01-aosp-key.zip from this thread on top of such packages). Yes. ;)

Or use a patched kernel, or flash magisk.
[OnePlus 3 & 3T Cross Device Development] Johannes1098:
I would also advice you to use Magisk. Very easy way:

And as you had the AddonSU it seems that you also used root (otherwise it would be unnecessary).

So just flash Magisk.zip after LOS and in the Magisk Manager in LOS, tick Magisk Hide in settings and hide Google Play Store, Play Services and Play-Services-Framework in the Hide tab.

The security and build fingerprint hack is of course also needed with Magisk for passing CTS..
[OnePlus 3 & 3T Cross Device Development] bschmidy10:
Do we have to manually update the firmware to 9.0.5 before we flash 10/4/19 with the updated fingerprint? Or is that not necessary?

Thank you.
[OnePlus 3 & 3T Cross Device Development] lokeshjt:
Do these need to be flashed after every rom update(till your solution is merged by [MENTION=5091734]dianlujitao[/MENTION])?
[OnePlus 3 & 3T Cross Device Development] :
I'd recommend so, but it's not enforced on los.

Yes.

If you use magisk go for [MENTION=2911853]BillGoss[/MENTION]' script - they persist through updates. If you don't use magisk, you can add a script to /system/addon.d. You can use the sed command in the flashable sec-patch-2019-*.zip as a starting point (you don't need to care about mounting system if /system/addon.d/* are executed, of course).
[OnePlus 3 & 3T Cross Device Development] :
Some questions I hope people here know the answer...

First, is there a Telegram test group or something for coming LOS17?

I am on NOS10 at the moment, but when possible I am willing to help as 'test user' for LOS17.

On misc forums I see people noting that we need a new twrp with system-as-root for Android-10.

Probably not enough background available here, but can someone explain me why this would be?

Also asking because every 10 install I did until now was with one of the latest official or unofficial twrp's but definitely without system-as-root....
[OnePlus 3 & 3T Cross Device Development] :
Can someone with shipped los kernel give me the output of

adb shell su -c "cat /sys/module/diagchar/version"

, please?
[OnePlus 3 & 3T Cross Device Development] :
I'm a bit puzzled: you have the vendor security patch level Sep. 5th - I've with latest Los and fw 9.0.5, magisk, only outdated April 1st vendor sec patch. What's the reason for? What I'm missing?

Thx in advance
[OnePlus 3 & 3T Cross Device Development] BillGoss:
root:~ # cat /sys/module/diagchar/version

1.0
[OnePlus 3 & 3T Cross Device Development] :
To unpuzzle: look closely to the second link in what you've quoted and compare to https://github.com/LineageOS/androi...mmit/246ff3ff0e42e2e3fedc318e7ced7db4dc8dd4f7 . If you are still puzzled look at my sig.

BTW: I'm sure there is a los based rom with verity pathches in the kernel out there... ;)
[OnePlus 3 & 3T Cross Device Development] :
OK, thx for unpuzzling ;)
[OnePlus 3 & 3T Cross Device Development] Dirk:
Almost certainly you refer to crDroid?

or maybe NLOS. :p
[OnePlus 3 & 3T Cross Device Development] :
https://review.lineageos.org/c/LineageOS/android_device_oneplus_oneplus3/+/260093

EDIT: [MENTION=5091734]dianlujitao[/MENTION]: if you update the blobs to 9.0.5 (differences with 9.0.4 are marginal) we would be on the same level for blobs and build fingerprint, and we would be able to set vendor sec patch level to 2019-08-01. Though this all would be basically cosmetics, it's just nice and clean to have them all on the same status.

Feel fred to use: https://github.com/nvertigo/proprie...mmit/3866893bc7b69ec08bb240c33e8457281f67caed (freshly rebased)

If you want to update the blobs these days, drop me a note and I'll adjust https://review.lineageos.org/c/LineageOS/android_device_oneplus_oneplus3/+/260093 for 9.0.5.
[OnePlus 3 & 3T Cross Device Development] :
Super, thx, you're the best ;)

Is there any special reason why do you link in your commit to fw9.0.4 (and not to latest fw9.0.5)?
[OnePlus 3 & 3T Cross Device Development] :
Yes. The reason is explained in the comment of the commit you've qouted: Because los is currently build with 9.0.4 blobs. See also my EDIT in my last posting.
[OnePlus 3 & 3T Cross Device Development] Ihe87:
Hi [MENTION=5091734]dianlujitao[/MENTION],

is it possible to add options to hide quick settings and power menu on lockscreen like in Skydragon or HavocOS?

For me it is essential for security and privacy.

Thank you for your work and help in all matters.

Greets

Ihe
[OnePlus 3 & 3T Cross Device Development] :
Perhaps this is a good idea (I prefer the requirement to unlock the device for changing settings via QS over disabling them all together): https://github.com/nvertigo/android_frameworks_base/commit/39e859c581f5920a5abc64c3d63e20569053f102

[MENTION=5091734]dianlujitao[/MENTION]: Push?

If we are in the wishing mode: I'd like to have off screen gestures not only on AOD but also on Ambient Display - no idea were to start.
[OnePlus 3 & 3T Cross Device Development] Ihe87:
OK, that's a good option, too.

Could you add GPS tile if you stick with this option?
[OnePlus 3 & 3T Cross Device Development] :
This option is easy to get around through the emergency screen, if I'm not mistaken.
[OnePlus 3 & 3T Cross Device Development] Ihe87:
I just tested it and it's true...

I didn't know that.

The quicksettings can be operated in the emergency screen.

But you have to unlock the device to change any settings.

The deactivated power menu does not appear.
[OnePlus 3 & 3T Cross Device Development] chotaire:
Hello all. The weeks have passed and to date I am still unable to dirty-flash any newer release over 20190823. There is no new TWRP release yet (if that is even related) and any attempt to update LineageOS will result in an endless boot, requiring me to restore from nandroid backups. What is the actual issue here and how can I fix this? I am running the latest version of Magisk, I have flashed the latest version of OpenGapps Nano and cleared cache/art prior to reboot.

---------- Post added at 04:10 PM ---------- Previous post was at 03:42 PM ----------

So the actual issue is indeed Magisk. I managed to finally break the endless boot by doing the following:

a) Reboot to recovery

b) adb push the latest version of Magisk Uninstaller

c) run Magisk Uninstaller

d) wipe cache, reboot (and it works!)

e) Reboot to recovery

f) Re-flash Magisk 19.3

g) wipe cache, reboot (and problem solved)

Let's see if this survives the next dirty flash.
[OnePlus 3 & 3T Cross Device Development] :
What is your dirty flashing routine? What have you tried so far? Did you search the thread? What about Magisk - some users have reported issues with updates when Magisk/Magisk modules are installed in this thread.

Nothing to address - something's broken with your setup not with the rom. A detailed description of your setup would be helpful.

Have you tried updating without Magisk?

Uninstall (delete) all modules from the MagiskManager. Boot to twrp and flash the magisk uninstaller zip. Reboot to system and see, if it still boots. If so, reboot to twrp and flash just the current rom zip. Wipe caches and dalvik before rebooting to system.

If that doesn't work: clean flash.
[OnePlus 3 & 3T Cross Device Development] dmukhin:
Not very informative at least in my case and logcat shows nothing suspicious like screen was on and off for usual (hope could grab it later). It's like some DSI commands silently fail here but not on stock or some commands interfere, gonna play with device tree, compare with stock etc if have time this week

pu_en=0

xstart=0

walign=0

ystart=0

halign=0

min_w=0

min_h=0

roi_merge=0

dyn_fps_en=0

min_fps=0

max_fps=0

panel_name=samsung s6e3fa5 1080p cmd mode dsi panel

primary_panel=1

is_pluggable=0

display_id=

is_cec_supported=0

is_pingpong_split=0

is_hdr_enabled=0

peak_brightness=0

blackness_level=0

white_chromaticity_x=0

white_chromaticity_y=0

red_chromaticity_x=0

red_chromaticity_y=0

green_chromaticity_x=0

green_chromaticity_y=0

blue_chromaticity_x=0

blue_chromaticity_y=0
[OnePlus 3 & 3T Cross Device Development] :
Though I'd like to see logcat and dmesg. This issue is around for quite some time in many roms, but nobody is willing to share logcat and dmesg - funny or sad, I havn't decoded yet.

I've thought the same, and have updated mdss-dsi-on-command and added mdss-dsi-post-panel-on-command (the only dtsi differenves from oss and los kernel - sadly we don't have sources for the stock oos kernel, but only the oss sources) for s6e3fa5 and s6e3fa3 (I just wated to be sure the relacement panels use the same name string, that's why I've asked for the panel info): https://github.com/nvertigo/android...mmit/4a44c616b431f64dcade50522d34c329de775981

I just want to get this comfirmed with at test kernel, before pushing. I also don't want to waste my time: so I've decided to upload a test kernel only if users with basic debug skills (like providing a logcat and dmesg) and the issue present are willing to participate in testing and debugging. As you can see, nobody is interested in fixing this, since I've asked for a logcat.
[OnePlus 3 & 3T Cross Device Development] Mata99:
Hi,

how can I fix this issue?
[OnePlus 3 & 3T Cross Device Development] serj.borgore:
Have you read past post in this thread about this issue?

Do it, there are two solutions.

Just use search button
[OnePlus 3 & 3T Cross Device Development] Allan_Hun:
Yesterday morning I woke up at 06.14 had a quck bath and checked the time on my phone. Clock widget displayed 06.14 but the system clock showed the correct time 06.28. After a moment clock synced with correct time.

This a fresh clean install, so no naptime or anything like that installed.

Am I the only user facing this issue?
[OnePlus 3 & 3T Cross Device Development] :
No, you arn't. As a quick thread search shows: https://xdaforums.com/search/thread/3866517?query=clock widget
[OnePlus 3 & 3T Cross Device Development] dmukhin:
I compiled kernel (based on commit 682d3393adad8db58b348e7122c00ab724f23286) with your changes for s6e3fa5 display. Unfortunately it's still failing to switch on quite often, once it was just right after PIN requested after boot and next one around 11:41 I believe
[OnePlus 3 & 3T Cross Device Development] Allan_Hun:
I actually did search. Only found one user with a similar problem, but he wrote that his system clock displays wrong time while the clock widget displayed the correct time. On my phone the sys. is correct while the widget is behind.

Makes med fear that my morning alarm might get delayed, but I guess upcomming alarms should prevent the phone from entering deep sleep.

Maybee removing clock from the battery optimized list would prevent this issue but I dont want to increase my standby battery drain...
[OnePlus 3 & 3T Cross Device Development] :
In the dmesg are some errors on dsi panel commands (I think while initialization), but before spending more time in comparing the dtsis of oss and los, it would be mandatory to know if it's fixed in the oss sources at all (there's at least the probability that it's fixed on oos but not on oss, or that something is trighered within the los rom, which isn't an issue on oos).

Does anybody now if there's a oss based pie rom around?

Ups, sorry, my bad, I havn't even realized that your device is vice versa effected.

To tell if it's the widget, the launcher or none of them, you could try different launchers and widgets. I.e.: I'm using nova and chronos and have never expirienced that.

I've never lost an alarm in the morning. I'm sure the issue is not a "standing" system clock, but a not properly updated view.

Check if excluding from bat optimisation helps. In a second step you can deal with bat usage.
[OnePlus 3 & 3T Cross Device Development] vitorgatti:
Hi [MENTION=5091734]dianlujitao[/MENTION] could you please take a look at this bug? Maybe it's easy for you to fix :cyclops:

Screen gestures loses assigned action

https://gitlab.com/LineageOS/issues/android/issues/531

This is happening on OnePlus 3 and other devices.
[OnePlus 3 & 3T Cross Device Development] :
I'm using v for torch and o for camera (the opposite of the the default/shipped config) since the bery first builds (when most of the other gestures wasn't even in) and never lost the assignments). Perhaps because I've set this so early, but I doubt that.

Do you use any mods (I use Magisk)? Do you have dirty upgraded through major version updates? Is this happenning after a factory reset, too? Have you tried a clean flash?

Can anybody confirm it's working (aka changed gestute settings are persistent)?
[OnePlus 3 & 3T Cross Device Development] Johannes1098:
I've also V for flashlight and O for camera.

For me its persistant - but I also think I set this very early (directly after a dirty update from LOS 15.1 - so in march or april)

So I assigned a new gesture: ^ for Browser. Persists here also after reboot.. (build 04/10)
[OnePlus 3 & 3T Cross Device Development] L_e_x_t_e_r:
Here, clean flash, works perfect, too.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
I also don't have the bug. What I did notice is that after a reboot the off-screen gesture doesn't work until about 20s after the lock screen is displayed (wait for lock screen to display, turn the display off, test the gesture every 5 seconds)

I've set "O" to camera and all others to "do nothing".

I'm on 191005. Tested with and without Magisk.
[OnePlus 3 & 3T Cross Device Development] vitorgatti:
The issue is that if you set all to "Do Nothing", reboot and wait a few minutes, the default gestures will be set (try single swipe up and the torch should light). If you go to the gesture settings, it's all set to "Do Nothing", but not behaving as intended.