yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] rg_gapa:
Today I've upgraded my phone from 5.0.8 firmware, so I'm posting steps I've made with some notes. Perhaps it might be helpful for someone.

Starting point:

Unlocked bootloader

TWRP 3.3.1.0

Firmware 5.0.8

LineageOS 16.0 (2019-06-15)

OpenGapps (Aroma variant)

FrancoKernel r45 (9-custom variant)

Magisk 19.3 with EdXposed

Steps:

Remove fingerprints (1)

Change Lock Screen from PIN to None

Reboot, check, reboot to TWRP

Uninstall Magisk

Reboot, check, reboot to TWRP

Make backup

Copy Internal Storage to computer via MTP

Reformat /data as ext4 (which removes encryption) (2)

Copy Internal Storage back to the phone via MTP (3)

Install Firmware 9.0.3

Reinstall TWRP 3.3.1.0

Reboot TWRP

Install LineageOS 16.0 (2019-07-01)

Restore /data backup

Install OpenGApps

Reboot, check (4)

Reboot to TWRP (5)

Install custom kernel

Install Magisk

Notes:

(1) Removing PIN should also remove all fingerprints, as the warning says, but it removes only 1 out of 5.

(2) Disable 'Use rm -rf instead of formatting' before wiping /data partition if you checked that option before.

(3) I couldn't restore whole internal storage data back to the phone via TWRP's MTP - it always stucks after copying some smaller files and the only solution is to disable and re-enable MTP in the TWRP's options. I've just copied backup and zip files via MTP and had to use FTP after full system upgrade to copy the rest of the files.

(4a) Encrypting was triggered automatically at the first system run.

(4b) Before the upgrade 'OEM Unlocking' in 'Developer options' somehow was shown as disabled (turned off but clickable). After the upgrade checkbox was properly disabled (turned off and unclickable) with 'Bootloader is already unlocked' information.

(4c) Even if I removed all 5 fingerprints and PIN before the procedure after the upgrade LineageOS showed 4 added fingerprints. They couldn't be deleted as entering into the fingerprints menu was redirecting me to the missing PIN setup. However, adding PIN didn't change the menu, screen lock method was still set as 'None' and 4 undeletable fingerprints were still present. At the reboot of the device encryption PIN was correctly asked for and accepted (so my attempt to setup PIN was successful, for the system startup part at least) but there still wasn't a lock screen and the settings in LineageOS still showed 'None' as the lock screen unlock method.

Removing /data/system/locksettings.db in TWRP solved setting up the PIN also for the lock screen.

Removing /data/system/users/0/fpdata folder and /data/system/users/0/settings_fingerprint.xml file solved re-adding fingerprints.

All thanks to the [MENTION=2911853]BillGoss[/MENTION] for posting that helpful information before.

(5) At this point I discovered that restoring internal storage from computer to phone via TWRP's MTP copied all files to /data/media instead of /data/media/0. I just removed all data in /data/media (it wasn't complete anyway, thanks to the MTP problems mentioned before) except '0' and 'obb' folders and transfered back my internal storage to the phone via FTP.
[OnePlus 3 & 3T Cross Device Development] bumbum.droid:
Anyone's touchscreen stopped working after flashing the 3rd or 4th July release? It works immediately after reboot but once the phone goes to sleep the touchscreen stops working - buttons and finger print reader keep working.
[OnePlus 3 & 3T Cross Device Development] :
Why is this necesarry? As far as I remembder the recovery is replaced on oos on first boot if oem unlocking is disabled - and therefor reflashing twrp is necesarry. twrp is still installed at this point.

Since there are different fw packages around, it would be helpful to give a link to the specific fw package used.

This is true for oos,

grep encrypt $(find ./oxygenos/* -name fstab\*)
./oxygenos/system/vendor/etc/fstab.qcom:/dev/block/bootdevice/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,nodiratime wait,forceencrypt=footer,check
./oxygenos/system/vendor/etc/fstab.qcom:/dev/block/bootdevice/by-name/userdata /data ext4 noatime,nosuid,nodev,barrier=1,noauto_da_alloc,discard wait,forceencrypt=footer,check
./oxygenos/system/vendor/etc/fstab.qcom:#/devices/soc/74a4900.sdhci/mmc_host* /storage/sdcard1 vfat nosuid,nodev wait,voldmanaged=sdcard1:auto,encryptable=footer

but los isn't shipped with forced encryption:

https://github.com/LineageOS/androi...ob/lineage-16.0/rootdir/etc/fstab.qcom#L9-L10

"encryptable=footer" clearly states the encryption isn't forced, otherwise this needs to be "forceencrypt=footer". You are mixing oos and los. On los you need to manually initiate the encryption, if userdata is unencrypted.
[OnePlus 3 & 3T Cross Device Development] Dirk:
Does anyone have a theory what's going on with the OEM Unlock setting in DevOps? It's been pointed out a few times that it defaults to Disabled now, even with the BL unlocked. It's the same on my LOS Based ROM too. (5.0.8). Previously it would stay Enabled after the initial unlocking of the Bootloader.

As pointed out before, when you Enable the toggle again, there's a warning about 'Device Protection features being turned off'. If you then toggle it off again the message reads something like. 'Device Protection will be enabled after a restart.

A previous poster didn't even know about this setting and locked his BL with no trouble. Assuming his OEM Unlock setting was also disabled at the time, does it even matter if it's enabled or disabled?
[OnePlus 3 & 3T Cross Device Development] rg_gapa:
1. This was steps I've made, not minimal steps required - I wasn't sure if TWRP will still be there after FW upgrade, so I did it just to be sure :)

2. Used FW zip:

Stable9.0.3_Firmware_Modem_OnePlus3.zip (by MarcoLK)

https://www.celsoazevedo.com/files/android/oneplus3-modem-firmware/

3. About automatically triggered encryption - I'm using LineageOS since the first days of my OnePlus 3, I don't know why encryption was triggered, but it did!
[OnePlus 3 & 3T Cross Device Development] :
This is impossible: https://github.com/LineageOS/androi...3/commits/lineage-16.0/rootdir/etc/fstab.qcom Look at the commits forceencrypt has never been used. Even if you had some unofficial build, that had forceencrypt, it doesn't make sense to mention this in a guide. For all official builds that's impossible and you are spreading false information in a guide for official builds...

That also means, you havn't tested your guide - you just assumed that los is forcing encryption, though you can't reproduce it or show in the sources? But you insist on that?
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
On my side, before and after locking my BL ... (No time to say more... Sorry [MENTION=1763460]Dirk[/MENTION])

BL unlocked (left) ----------> BL locked (right)
[OnePlus 3 & 3T Cross Device Development] Dirk:
In your case it's exactly how i would expect it to be. And it makes logical sense. My own is not greyed out, but 'Disabled' with "Allow the Bootloader to be unlocked". It is, of course, already unlocked so the setting should be 'Enabled' right now. Perhaps it will change when crDroid gets the 9.0.3 update.

Thanks.
[OnePlus 3 & 3T Cross Device Development] Galiis:
It's true for Lineageos after restoring system and data, I did that before.

Before restoring config: Los16-0702/twrp 3.3.1-0/fw 9.0.4/BL unlocked/encrypted data.

I think his userdata was encrypted.

Sorry for the missing url in quote, new user prevented from posting outside links.
[OnePlus 3 & 3T Cross Device Development] jakito:
Hello, I just updated to 20190704 version and my alarm information stopped appearing on the lock screen. I was on 20190701 before. I checked the changelog and didn't find anything relevant.

Is there a way to enable this again?

Thanks
[OnePlus 3 & 3T Cross Device Development] :
You're right, it's the same for me with July 4th release. But to be honest, I don't know if it's the same for previous releases ...
[OnePlus 3 & 3T Cross Device Development] generalprobe:
[MENTION=4405529]nvertigo67[/MENTION] Do I need root access on OOS to access these files? Since a friend of mine has this phone and uses it with the stock rom.
[OnePlus 3 & 3T Cross Device Development] :
It should be possible to sdb pull them. If I'm wrong, drop mema note and I provide the oos files.
[OnePlus 3 & 3T Cross Device Development] generalprobe:
[MENTION=4405529]nvertigo67[/MENTION]

I had the time to compare all four files. the libnfc-nxp_RF.conf are identical in stock and lineage.

libnfc-nxp.conf has some differences

# HAL library path for selftest
NXP_HAL_PATH="/system/lib64/hw/nfc_nci.pn54x.so"

this part is missing in lineageos

and this part is missing in stock:

# Choose the presence-check algorithm for type-4 tag. If not defined, the default value is 1.
# 0 NFA_RW_PRES_CHK_DEFAULT; Let stack selects an algorithm
# 1 NFA_RW_PRES_CHK_I_BLOCK; ISO-DEP protocol's empty I-block
# 2 NFA_RW_PRES_CHK_ISO_DEP_NAK; Type - 4 tag protocol iso-dep nak presence check
PRESENCE_CHECK_ALGORITHM=1

###############################################################################
# Configure the single default SE to use. The default is to use the first
# SE that is detected by the stack. This value might be used when the phone
# supports multiple SE (e.g. 0xC0 and 0x80) but you want to force it to use
# one of them (e.g. 0xC0).
# host 0x00
# eSE 0x01
# UICC 0x02
DEFAULT_OFFHOST_ROUTE=0x02

###############################################################################
# Vendor Specific Proprietary Protocol & Discovery Configuration
# Set to 0xFF if unsupported
# byte[0] NCI_PROTOCOL_18092_ACTIVE
# byte[1] NCI_PROTOCOL_B_PRIME
# byte[2] NCI_PROTOCOL_DUAL
# byte[3] NCI_PROTOCOL_15693
# byte[4] NCI_PROTOCOL_KOVIO
# byte[5] NCI_PROTOCOL_MIFARE
# byte[6] NCI_DISCOVERY_TYPE_POLL_KOVIO
# byte[7] NCI_DISCOVERY_TYPE_POLL_B_PRIME
# byte[8] NCI_DISCOVERY_TYPE_LISTEN_B_PRIME
NFA_PROPRIETARY_CFG={05, FF, FF, 06, 81, 80, 70, FF, FF}

###############################################################################
# Bail out mode
# If set to 1, NFCC is using bail out mode for either Type A or Type B poll.
NFA_POLL_BAIL_OUT_MODE=0x01

#################################################################################
# Set max transceive length for IsoDep frames
# Standard 0x105 (261)
# Extended 0xFEFF (65279)
ISO_DEP_MAX_TRANSCEIVE=0xFEFF

###############################################################################
#White list of Hosts
#This values will be the Hosts(NFCEEs) in the HCI Network.
DEVICE_HOST_WHITE_LIST={80 : 81 : C0}

also the loglevels are different 0x03 in lineageos and 0x00 in stock.

Does that help?

btw, I got the stock files from a friends phone. unfortunately it is not here with me, so I cant test it, if it works with stock.
[OnePlus 3 & 3T Cross Device Development] moso11:
Is there any way to get automatic brightness for ambient display?
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
On latest build: Settings > Display > Adaptative brightness ... Enabled

Edit : FYI, "Phone is starting" issue (PIS) is still alive.
[OnePlus 3 & 3T Cross Device Development] :
After switching to Lawnchair 2 and deleting TrebuchetQuickStep, I haven't seen the issue anymore on my phone.

Could it be related?
[OnePlus 3 & 3T Cross Device Development] :
You've got me wrong: comparing the files only makes sense if it's working on oos!

I have never used nfc myself and I have nearly no knowledge on nfc other then that I knew from 15.1 that the extended frame length needs to be set. I hoped that something in the differences would have caught our eyes regarding signal strength.

I don't know if not being able to change the pin, is related to signal strebgth, I've relied on your knowledge that this is the case. I don't know if it's working on oos. I don't know the nfc specs in general, nor the specific specs of op3/t's chip.
[OnePlus 3 & 3T Cross Device Development] moso11:
That's for when screen is turned on.

I'm looking for ambient display or AOD.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Unless I'm mistaken, no adaptative brightness for ambiant display.
[OnePlus 3 & 3T Cross Device Development] generalprobe:
oh okay, thank you for your clarification.

The problem is, that my friends phone is in the Netherlands and I can't drive there just to test it ;) I will be there in September, so maybe I delay it till then.

I just don't want to mess up with my device right now.
[OnePlus 3 & 3T Cross Device Development] Dirk:
Crops up when you least expect it. I've not seen it once since i posted the Logs, although i'm certain i will see it again.

Could be related. Or could be coincidence. You'd have to poll everyone who has done the same as you to see what they say.

So, 'anyone who was suffering the PIS bug, who subsequently deleted Quickstep and later found the bug had gone'. Report your findings.

Results may still not be conclusive but it's as good a theory as any.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Also surprised... on my son's device... not on mine.
[OnePlus 3 & 3T Cross Device Development] Dirk:
I have a feeling that whatever the cause, it will eventually get fixed 'accidentally' and disappear. :fingers-crossed:

How are you doing Eric? Is your weekend expected to be filled with rest & relaxation, or do you have plans?
[OnePlus 3 & 3T Cross Device Development] :
Before verifying that it's working on oos, it doesn't make sense to play with the conf files.

BTW: oos has much more libnfc-*conf files:

find oxygenos/ -name libnfc\*\\.conf
oxygenos/system/vendor/etc/libnfc-nxp_RF.conf
oxygenos/system/vendor/etc/libnfc-nxp_productline.conf
oxygenos/system/vendor/etc/libnfc-nxp_RF_yangchengtong.conf
oxygenos/system/vendor/etc/libnfc-nxp_yangchengtong.conf
oxygenos/system/vendor/etc/libnfc-nxp_RF_productline.conf
oxygenos/system/vendor/etc/libnfc-nxp_beijingbus.conf
oxygenos/system/vendor/etc/libnfc-nci.conf
oxygenos/system/vendor/etc/libnfc-nci_shenzhentong.conf
oxygenos/system/vendor/etc/libnfc-nci_beijingbus.conf
oxygenos/system/vendor/etc/libnfc-nci_productline.conf
oxygenos/system/vendor/etc/libnfc-nxp_shenzhentong.conf
oxygenos/system/vendor/etc/libnfc-nxp_RF_shenzhentong.conf
oxygenos/system/vendor/etc/libnfc-nxp.conf
oxygenos/system/vendor/etc/libnfc-nci_yangchengtong.conf
oxygenos/system/vendor/etc/libnfc-nxp_RF_beijingbus.conf

I have no clue what the additional files are used for, nor does it make sense before checking with oos. But since it's the most eye catching difference, I'd start there. You can use the time till checking for enppwering yourself in nfc-debugging.

I'm too lazy to search, but I'm pretty sure we have discussed quickstep/trebuchet as cause already with nova. Shortly after someone claimed using nova and still expiriencig pis...

The logs I've seen suggesting some hals aren't ready, if pis shows up. I still think it's something with the boot order/boot timing. Meanwhile I've found, that boot order differs depending how you reboot: after an update with wiped caches it's different from system to system reboot is different from power off and power on... You can easily check yourself, if you take the lineage logo as fixed point in the different logs. It seems that minimal changes in the boot process trigger or avoid pis. Changing the default browser, removing a hal (i.e. livedisppay), bootanimation and quite some more we don't even think about, slightly changes the startup process. So that it seems a specfic change has fixed it... Really ugly. "Crops up when you least expect it." describes this pretty good...

I wonder if something like these, could be helpful:

https://review.lineageos.org/c/LineageOS/android_device_cyanogen_msm8916-common/+/225783

https://review.lineageos.org/c/LineageOS/android_device_cyanogen_msm8916-common/+/225785
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Another surprise, changing the color of SIM slot 1 always results in bypassing "Enter sim PIN" screen and disabling the Mobile network !

This issue occurs only if you use only one SIM card, not two ... (and only on LOS not on NLOS ... if I'm not mistaken)

And you did not move from 15.1 to 16.0 with a dirty flash.

Procedure:

Settings > Network & Internet > SIM cards > SIM slot 1 (SIM slot 2 is shaded)

Select SIM Slot 1, change the color and click on OK

Reboot System

"Enter SIM PIN" screen is bypassed and Mobile network is disabled.

As reminder (logs and so on): https://xdaforums.com/showpost.php?p=79176344&postcount=1404

Be careful, perform a Nandroid backup before testing !

My weekend ... I'm giving a lecture next week in Paris and I haven't done anything yet... I'm lazy to start!

What about yours? Wimbledon ?

Edit: "changing the color of SIM slot 1" issue ... Fixed since 20190802 !
[OnePlus 3 & 3T Cross Device Development] Dirk:
You're still having that issue with the SIM? I always change the colour of SIM 1, (but i don't use SIM Lock). Perhaps these things will be resolved in Android Q (AOSP).

Wimbledon, work and slaving over a keyboard on some animations. You better start prepping for your Lecture! :eek:

---------- Post added at 15:57 ---------- Previous post was at 15:02 ----------

PIS Update:

"The error is due to LOS livedisplay. Proper fix unknown.

Someone has posted a workaround in our telegram group - this workaround fixes PIS issue at cost of livedisplay."

https://xdaforums.com/showpost.php?p=79854602&postcount=1568
[OnePlus 3 & 3T Cross Device Development] :
Not using telegram, what is the workaround?
[OnePlus 3 & 3T Cross Device Development] Dirk:
I don't use it either, but i assume the fix removes/disables Livedisplay. There's a ROM for the OP5T that i mentioned before where the Dev had swapped out Livedisplay for another implementation. He was sure it fixed the PIS bug. Turns out he was right.

Then there's this clever chap who called it way back on the 17th March:

https://xdaforums.com/showpost.php?p=79134549&postcount=1341

:cool:
[OnePlus 3 & 3T Cross Device Development] :
The root fs is a loop device populated by an cpio archive in the boot image. You can't put stuff there, it's reset on each reboot - it can't contain leftovers from other installations. In other words: all files are from los and uswd by los.
[OnePlus 3 & 3T Cross Device Development] multiwirth:
Does anbody have issues with google assistant with build 20190704 ?

It couldn´t be enabled and wasn´t enabled by default.

Since i had to do a full wipe, the assistant has gone aswell for some reason.

I had to modify build.prop to get it back.

Something seems to be broken.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
I am on 20190706 + gapps pico (See my signature for more information)

I don't use Google Assistant but I just installed Google app and Google Assistant app via Play Store for testing your issue.

Note that Assist app is disabled by default in LOS 16.0.

Go into Settings > Apps & notifications > Default Apps > Assist & voice input & set Google app as default.

Now, Google assistant works fine on my side.

As reminder: Even if not specified in OP (inter alia), Open Gapp pico or nano is strongly recommended to avoid modifying system files.
[OnePlus 3 & 3T Cross Device Development] realtos:
hello again, been rackin my brain around this for some time and couldnt see posts about it beyond my own months ago regarding the vol rockers on our 3t, as of now my settings are top ( silence ), middle ( vibrate and buttom is normal but on each boot it goes directly to vibrate no matter how my rockers are set and in order to get normal the fastest way is to push the rocker up and down, is there some setting im unware of? i cant be the only one thinkin its weird it goes to vibrate on default(reboot), i read some posts about about it was still WIP, so was just wonderin if its still the case and yes nvertigo67 will prolly kill me for askin this for not searching but i actully did and found nothing so just curious why i dont see any posts about it being an bug or ofc its just suppose to be like that
[OnePlus 3 & 3T Cross Device Development] Doggie52:
Hi nvertigo,

I agree with both of your statements - neither the Play Store issue nor the Maps issue turned out to be LOS-related. It just so happened that they appeared when I did a clean flash onto LOS16, so it was my first assumption (as the phone otherwise is fully functional and a clean flash should have things working out-of-the-box).

It was never my intention to "mock about" LOS, my apologies if this is how it came across.

I have posted a solution to the Maps issue both here and on the Google forums, so hopefully I've contributed my part on this issue.
[OnePlus 3 & 3T Cross Device Development] :
I don't kill people - I ask them to stick to xda rules, which are the rules everybody agrees to on sign up.

If you've searched and havn't found anything the reason might be there is nothing to find:

I've set up my buttons like this:

top: Total silence

middle: Vibration

bottom: None

I've done the following three tests:

set slider to bottom; reboot; still None - no icon in status bar

set slider to middle; reboot; still Vibration - Vibration icon is shown in status bar

set slider to top; reboot; still Total silence - circle with minus sign inside is shown in status bar

I'd suggest you clean flash with only gapps (pico or nano) and no additional apps and no restores and try to reproduce.
[OnePlus 3 & 3T Cross Device Development] psc-m3:
the current build seems incompatible with older firmware.

at least this is claimed when I try to flash a current build via twrp.

So I just installed "Stable9.0.3 Firmware+Modem_OnePlus3." on my op3.

Storage was not readable after that (was encrypted), but thats okay, this is why we do backups.

So I wiped everything, inclusive internal storage, media, system, data and stuff.

I noticed the dm-verity notice changed a bit. It was a red warning before and now it says something about "dm-verity is not enforced"

Then I tried to flash a current LOS16 build but it fails with "e1001: failed to update system image" - somebody heard about this or have an idea?

(now I'm just running an twrp restore of the los16, 08.06.2019, nightly - which seems to work somehow on the newer firmware)
[OnePlus 3 & 3T Cross Device Development] :
Would you share the recovery log of the twrp session the "e1001: failed to update system image" appears in, please?

(FYI: all the other stuff you've expirienced is the expected behaviour.)

EDIT: I gues you havn't wiped internal data, but formated the data partition. If not: fprmat data in twrp when twrp is booted with the 9.0.x fw.

EDIT2: I assume you are using twrp-3.3.1-0. If not, update before getting the recovery log.
[OnePlus 3 & 3T Cross Device Development] jianwen03:
Faced this once. Restart phone fixed it. If it doesn't try removing the phone's back cover & putting it back on. Cause of issue may be due to loose contacts from the slider's flex cable to the motherboard. Dropping, sliding phone across surfaces or any other events that shakes the internals may cause this.

fyi i had to replace screen of phone & faced this after reassembling whole phone. searched internet for issue but no one seems to face it. finally fixed it when the bright idea to restart phone occurred 1 day later.
[OnePlus 3 & 3T Cross Device Development] Johannes1098:
I'm back - one week holiday and everything is escalating here :eek:

PIS bug, NFC bug, new OOS version with new firmware, bootloader problem - magisk, addonsu Safetynet problem etc.

I have to be honest - I've read the 20 last sites but I don't think I understand at least 50% of the written things here :)

So I have a question for updating my system

I just don't want to reformat /data again ^^

My config:

LOS 20190629 / FW 9.0.3 / encrypted F2FS with unlocked BL / Magisk / OpenGapps

So I would like to upgrade to the build of today (new security patches) and I also want the new firmware

But: Can I flash the 9.0.4 FW over the 9.0.3 without any issues (like the old upgrades from 5.x to 5.y..)

I've the unmodified firmware 9.0.3 of course - I've did the real way for upgrading from 5 to 9 FW (with format /data) and not only fw with patched BL and keymaster.