yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] Johannes1098:
Hmm - okay, I know what you mean with the oxymoron. I think it's about having the newest :)

So I should correct my sentence: "You're right, changing the less to have the newest things is the best way." :D :D

Ok, didn't seen anything unexpected yet - but if I'll - I'll not whining on xda (and revert the changes)... That's already a problem here: people change/mod/edit the LOS - something isn't working then - but the problem is of course already the ROM itself. Too bad :rolleyes:

Oh okay, didn't know that. Interesting. So maybe [MENTION=5091734]dianlujitao[/MENTION] will include the blobs from 9.0.6 as it's the last version for the OP3 (probably) - and then it would also be nice to use the fingerprints from there.

Did you also check the 9.0.6 version?

Then [MENTION=2911853]BillGoss[/MENTION] would be right with the wrong fp from my script (deleted it for the OP3 anyway)
[OnePlus 3 & 3T Cross Device Development] :
No. The problem is g not exepting the aosp generated build fingerprint(s). Or short: gservices suckz.

Or we stick with the 9.0.5 fp, no matter what blobs are used: it's equal between op3 and op3t, it's not one or more major releases behind and will not be obsoleted by a new major oos release. We would not expirience any downside by doing so.

Yes, he is. See my previous posting.

(I put these in code tags, because you can better compare with a fixed width font.)

For 9.0.6 the difference is (2019-10-01):
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3:9/PKQ1.181203.001/1911042107:user/release-keys
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3T:9/PKQ1.181203.001/1911042108:user/release-keys

For 9.0.5 (2019-08-01):
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3:9/PKQ1.181203.001/1907311932:user/release-keys
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3T:9/PKQ1.181203.001/1907311932:user/release-keys

For 9.0.4 (2019-06-01):
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3:9/PKQ1.181203.001/1906252002:user/release-keys
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3T:9/PKQ1.181203.001/1906252001:user/release-keys

For 9.0.3 (2019-04-01):
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3:9/PKQ1.181203.001/1905251415:user/release-keys
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3T:9/PKQ1.181203.001/1905250152:user/release-keys

For 9.0.2 (2019-04-01, too!):
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3:9/PKQ1.181203.001/1905102347:user/release-keys
ro.bootimage.build.fingerprint=OnePlus/OnePlus3/OnePlus3T:9/PKQ1.181203.001/1905102346:user/release-keys

I have no 9.0.1 for op3 on my disk.

The longer I look at these funny strings, the dizzier I get... ;) And the dizzier I get, the more I like the idea to stick with 9.0.5 fp.

EDIT: this is my 5000th posting - do I get a 7t pro for free, now? *lol*
[OnePlus 3 & 3T Cross Device Development] BillGoss:
:laugh: Wouldn't that be nice!
[OnePlus 3 & 3T Cross Device Development] BillGoss:
For what it's worth, I took a logcat after one of the instances of the home button becoming unresponsive (see discussion around this post https://xdaforums.com/oneplus-3/one...geos-16-0-oneplus-3-3t-t3866517/post80916535)

It's from nlos, but since that's so similar to Los I thought I'd post it here since all the discussion about this issue has been in this thread.

I hope it helps identify the source of the problem.
[OnePlus 3 & 3T Cross Device Development] lulu14150:
Hi guys,

I've installed the latest nightly 20191126 with nano gapps + addonsu (from stock 9.0.6 firmware and after a full wiping from the latest TWRP).

DT2W doesn't work and i've a black screen when i press the power button to wake up the phone (capacitive buttons backlight on), i've to try many time to unlock the phone.

Any solutions ?

Otherwise great Rom :)

Thanks
[OnePlus 3 & 3T Cross Device Development] :
After looking for an hour in this log, I feel lost, I can't even find when the home key is pressed. This looks like "one of these"... :(

As soon as I can get a couple of hours timeframe, I'll take logs from a successfull home key press, and check line by line again.

Currently, I would guess, the event is never seen by the system. :(
[OnePlus 3 & 3T Cross Device Development] Simone98RC:
Sadly, I noticed that the fourth CPU core is powered off causing lags with Asphalt 9 and scroll activity in some contests (e.g. Nova Launcher).

There's no way to enable it with EX Kernel Manager, the only solution is the installation of custom kernel (I've chosen MCD).

Can you provide other solution, without changing the stock kernel? Maybe there's some specific parameter to be edited?

Thanks in advance.
[OnePlus 3 & 3T Cross Device Development] knpk13:
Not sure if it's relevant since I'm on NLOS, but Kernel Adiutor shows all 4 cores online for me.
[OnePlus 3 & 3T Cross Device Development] :
Please describe give a detailed description of your setup and exact version information on all zips used.

Does this third party app show valid values? Have you checked the sysfs nodes to verify?

Is the third party app a root app?

Can you reproduce that on a clean flash without any mods (maybe some so called battery maximize tweak applied)?

Do you use so called bat savers?

Try as clean as possible (only rom, nano or pico gapps and asphalt 9) and check sysfs node: "adb shell cat /sys/devices/system/cpu/online"

BTW: power save profile disables one big core.
[OnePlus 3 & 3T Cross Device Development] :
This is the log snippet of a hardware home button press:

11-28 10:37:56.772 2118 2369 E fpc_fingerprint_hal: fpc_wait_finger_down_for_home_12_zone after irq 0
11-28 10:37:56.772 2118 2369 D fpc_tac : fpc_tac_wakeup_qualification begin
11-28 10:37:56.772 2118 2369 D fpc_tac : fpc_tac_send_cmd begin
11-28 10:37:56.788 2118 2369 D fpc_tac : fpc_tac_send_cmd end
11-28 10:37:56.790 2118 2369 D fpc_tac : fpc_tac_wakeup_qualification end
11-28 10:37:56.790 2118 2369 I fpc_fingerprint_hal: do_home status 0
11-28 10:37:56.792 2118 2369 D fpc_fingerprint_hal: do_home HOME DOWN
11-28 10:37:56.792 2118 2369 D fpc_fingerprint_hal: fpc_wait_finger_up
11-28 10:37:56.937 2118 2369 E fpc_fingerprint_hal: fpc_wait_finger_up FPC_LIB_FINGER_LOST
11-28 10:37:56.938 2118 2369 D fpc_fingerprint_hal: do_home HOME UP
11-28 10:37:56.938 2118 2369 D fpc_fingerprint_hal: fpc_wait_finger_down_for_home_12_zone enter
11-28 10:37:56.938 2118 2369 D fpc_tac : fpc_tac_12zones_wakeup_setup begin
11-28 10:37:56.938 2118 2369 D fpc_tac : fpc_tac_send_cmd begin
11-28 10:37:56.946 2118 2369 D fpc_tac : fpc_tac_send_cmd end
11-28 10:37:56.946 2118 2369 D fpc_tac : fpc_tac_12zones_wakeup_setup end

This rins through the fingerprint hal - not too surprising, because tne fingerprint hal has to decide to scan a fp, handle a home button short single press, long press or double press to pass one of these four up to the frameworks.

If I look at your log:

ingo@adler /usr/local/src/oxygenos $ grep -e "fpc_fingerprint_hal: fpc_wait_finger_down_for_home_12_zone" /mnt/export/data/Downloads/incoming/Android/191127-172946.logcat
ingo@adler /usr/local/src/oxygenos $

But if I grep just for fpc_fingerprint_hal:

11-27 17:29:29.777 E/fpc_fingerprint_hal( 2155): fpc_wait_finger_down_for_home_12_zone after irq 0
11-27 17:29:29.793 I/fpc_fingerprint_hal( 2155): do_home status 0
11-27 17:29:29.801 D/fpc_fingerprint_hal( 2155): do_home HOME DOWN
11-27 17:29:29.801 D/fpc_fingerprint_hal( 2155): fpc_wait_finger_up
11-27 17:29:29.894 E/fpc_fingerprint_hal( 2155): fpc_wait_finger_up FPC_LIB_FINGER_LOST
11-27 17:29:29.894 D/fpc_fingerprint_hal( 2155): do_home HOME UP
11-27 17:29:29.894 D/fpc_fingerprint_hal( 2155): fpc_wait_finger_down_for_home_12_zone enter

We can see, that the send_cmd stuff is missing.

I don't know, if this is just because of the changed format of the log or if that's a symptom of the non working home button. If I should guess, I'd go for an app (like com.oneplus.sensor.pocket), which is suspressing the handling of the button press. But I'm guessing here, perhaps it's just the log. (I'm always paranoid on logs with changed format: when the format is changed, perhaps lines are droped, too.)

[MENTION=5091734]dianlujitao[/MENTION]: Maybe you van cjeck [MENTION=2911853]BillGoss[/MENTION]' log - I can't see the real reason, why tje button press isn't processed.
[OnePlus 3 & 3T Cross Device Development] Simone98RC:
The only mod I'm using is Magisk v20.1 with modules that are not related to system tweaks.

As performance profle I've the balanced (default) one from battery menu.

I'm not using battery savers and I dislike them.

The EX Kernel Manager app works only with root permissions, so it should be accurate.

I've no time to do a clean installation on my daily driver phone, actually I've not upgraded LOS neither OpenGapps, so consider the device almost clean.

For logcat and other details I'll update you asap (I've to restore stock kernel and remove init.d additions).
[OnePlus 3 & 3T Cross Device Development] :
Take your time. As no other users expirience this, the probability is high that it's setup dependent - and if you are happy with your current setup, go ahead. Just honor OP.

If you are interested you can check the ramdisk and init.d changes for cpuset, I remember vagualy an old bug with 0-2 instead of 0-3, maybe that got somehow back in your setup.

BTW: never ever trust an app, if you can check sysfs nodes. I don't now your third party app, but for adiutor I recommend checking the git. It's always surprising how much devices differ and how easy one can be misled or confused.... sysfs nodes just eliminate an unnecessary soirce of errors.
[OnePlus 3 & 3T Cross Device Development] knpk13:
It's from flar2, long time dev of the ElementalX kernel. From what I know, he's supposed to be a very reputable dev who updates his app/kernels regularly, just like Franco and eng.stk (I heard Lord Boeffla retired ;-; , I used his kernel for my OP2 for a long time)

I'm sure the point about relying on system stuff like sysfs nodes stands, but just a bit of background since you asked and triggered my nostalgia haha.
[OnePlus 3 & 3T Cross Device Development] :
You didn't get my point. It's not about trusting/mostrusting one or another dev or doubting anybody's reputation. It's just about the old dev saying (I think it's originates from W. Ricjard Stevens): "Debug your debugger, first." If I can exclude a source of error, I do so - no matter how probable or not: one source of error less, is one source of error less.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Lol! It helps if you search for fpc_tac then you'll see the send_cmd lines.

As to the format of the logs, this is how I produce them:

logcat -d -v time

I really appreciate your taking time to look into this.
[OnePlus 3 & 3T Cross Device Development] :
Sorry, mixed that up, you are right, of course. After over 4 h of log looking, I was confused this morning. I've no clue, why the home button stops working for you. Perhaps the launcher. I use the payed version of nova, just guessing because I've never expirienced this issue. In the end the launcher has to react on the send_cmd.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
I, too, use the paid version of Nova.
[OnePlus 3 & 3T Cross Device Development] knpk13:
I got it, that's why I said this :)

"I'm sure the point about relying on system stuff like sysfs nodes stands..."

I should have probably worded it better. I kinda miss them, they've all moved on to newer devices rip. Anyway sorry about the OT lol. The funniest part is I'm not knowledgeable enough to judge their competence/reputation :P

---------- Post added at 09:35 PM ---------- Previous post was at 09:34 PM ----------

I'm in good company then. I use paid Nova too, and I've experienced the issue, but its not too much of a bother.
[OnePlus 3 & 3T Cross Device Development] Peachh:
[MENTION=5091734]dianlujitao[/MENTION] Does this rom support VoLET of China-Unicom?
[OnePlus 3 & 3T Cross Device Development] Johannes1098:
Nova Launcher Premium too, experienced the stopping fingerprint sensor just one time.
[OnePlus 3 & 3T Cross Device Development] :
[MENTION=2911853]BillGoss[/MENTION]:

I've recreated the working home button logs with -v time (I like the logs w/o -v time more, because sometimes the ppid is really helpfull). It looks exactly like the blocks in your log. This can mean that the failure is after the fp hal but isn't logged, or it can mean that the failing button press isn't logged at all. For both cases this means no hints what's exactly going wrong in the log. :(

I'd be really happy, if someome else would take a look at [MENTION=2911853]BillGoss[/MENTION]' original log - I've looked at this log for the last two days, and sometimes the most obvious things get invisible if you look long enough at...
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Thanks for taking so much time trying to find the cause.

I've decided to remove the '-v time' from my logcat script because it doesn't add anything but takes away the ppid info, as you mentioned.

In the "got old days" the logcat command didn't display the timestamp without the time option, but now it does.
[OnePlus 3 & 3T Cross Device Development] thesplitter:
The issue of the home button not getting recognized happens to me too, when trying to unlock with the fingerprint sometimes it does not react, also sometimes also as home button, since I turned on the software navbar I've had no issues with the navbar home button but the unresponsive fingerprint sensor while unlocked still happens randomly

I guess it's something that's not right with the hardware button getting ignored in certain instances
[OnePlus 3 & 3T Cross Device Development] BillGoss:
[MENTION=8423339]Johannes1098[/MENTION] [MENTION=7134312]knpk13[/MENTION] [MENTION=4405529]nvertigo67[/MENTION]

Ok, my [possibly] final post on the SafetyNet fingerprint issue.

Thanks to Dirk's post https://xdaforums.com/oneplus-3/one...ageos-16-0-oneplus-3-3t-t3866517/post80988263 I'm now changing the build and vendor.build fingerprint rather than the security patch date in my script.

As Dirk pointed out, NOS roms pass SafetyNet without needing to have the security patch date changed because they use an older (pre 16th March 2018) fingerprint.

There are two reasons I like this approach:

1. This solution is independent of the fingerprint used in the rom (which may change depending on the blobs used) and is, therefore, sorry of a "universal" solution for our phones (until Google changes the rules again). I've also tested the script in Los 17 and it works though I had to run it in post-fs-data.d.

2. It leaves the build date and security patch dates unchanged so that you can see what they are for a rom in Settings>about phone.

I've also come to realise that, because ROMs for our phones (3 and 3T) are unified, there's no need for separate scripts for the two models.

The minor, in my mind, downside is that the solution changes two properties. If you use an installable zip file you'd need to modify both /system/build.prop and /system/vendor/build.prop [MENTION=4405529]nvertigo67[/MENTION] would you like me to change your script?)

The script is attached. Change the extension to .sh and follow the installation instructions in the script itself.
[OnePlus 3 & 3T Cross Device Development] :
Thanx for the offer, but no:

I like the date changing approach. Sadly, we've discussed this in too many places, so I sum it up one last time, though it has been allready said:

Mismatch between files and props will lead to unwanted side effects. (See below for init setted props.)

If one canges the fp in the prop files, you need additionally to overwrite the props set by init.

If one uses the oreo fp, playstore will not present apps with a minimum sdk of 28.

Only changing the sec patch date in /system/(system/)build.prop with a flashable zip works without magisk (i.e. relocked bl, patched kernel).

Perhaps it would make sense, to make your script a real magisk module that not only resets some props, but overlay the files to show the same as the resetted props, but changing the fp in the files without resetting the props set by init will not work, because if you just change the files, getprop will report what init has set:

https://github.com/LineageOS/androi...b/lineage-16.0/init/init_oneplus3.cpp#L62-L63 &

https://github.com/LineageOS/androi...b/lineage-16.0/init/init_oneplus3.cpp#L70-L71

That the "wrong" secpatch date is shown, doesn't matter to me, because I know what is originally in build/make/core/version_defaults.mk. ;)

I think, it's good to have more then one approach, who knows what g is going to restrict next... For now I'm more then happy with changing the sec patch date.
[OnePlus 3 & 3T Cross Device Development] Viper The Ripper:
I agree with [MENTION=4405529]nvertigo67[/MENTION]. Not being dependent on third-party applications and avoiding the modification of several files, make the flashable zips from Ingo very useful especially for inexperienced people. Not all the people use Magisk and the consequences that can lead to inexperienced :good: ... How many times have we already posted about encryption, data formatting...? and all we have left!
[OnePlus 3 & 3T Cross Device Development] Johannes1098:
I thought that not using Magisk (with Magisk Hide of the Google Play components) would lead to failing Safety Net, isn't that true anymore? (I thought that everyone who wants a 'certified device' has to use it - and thus can use also the script directly from [MENTION=2911853]BillGoss[/MENTION])

But I also like the approach of a Magisk module, that [MENTION=4405529]nvertigo67[/MENTION] mentioned above.

So that also means, that in LOS 17 - with the 9.0.x fp - the Playstore also doesn't show apps with minimum sdk of 29?
[OnePlus 3 & 3T Cross Device Development] Dirk:
You don't need Magisk to pass Safetynet. Just the regular requirements/fixes and now a way to pass CTS:

Selinux Enforcing.

Kernel with Verified Boot Patches, (or alternatively relocked Bootloader).

Matching Build Fingerprint and Security Patch date, (or alternatively an Oreo era Fingerprint alone).

Edit: (Added BL Relock which applies to LOS when using latest TWRP)
[OnePlus 3 & 3T Cross Device Development] :
For safetynet api to pass, the triped verifiedbootstate kernel command lime parameter is not allowed to be tripped. There are several methods to accomblish this:

most obvious: don't trip the ****ing verifiedbootstate kernel command line parameter in the first place: use a locked bl.

If the bl is unlocked:

just throw away the triped verifiedbootstate kernel command parameter:

https://github.com/nvertigo/android...67e1d62#diff-bc7b36fe4d2924e49800d9b3dc4a325c

https://github.com/nvertigo/android...d2728a9#diff-bc7b36fe4d2924e49800d9b3dc4a325c

use Magisk to hide the triped verifiedbootstate kernel command line parameter (default on magisk).

Yes. (Or - if you use the web playstore - you will be informed such an app is not compatible with your device. I know currently of no app with min sdk >26, but that's just a matter of time, especially for games and system near apps. Also note this is only in playstore - installed (i.e. apkmirror) apps that check the api version and not the fp while running on the device will work flawlessly.)
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Do you know for sure that the Play Store uses the ro.build.fingerprint rather than ro.build.version.sdk to determine the SDK version ?
[OnePlus 3 & 3T Cross Device Development] :
I'm not 100% sure - we can be 100% sute only when the first apks with min sdk 28 or 29 show up.

I'm about 90% sure, because I've expirienced this with my nougat builds for chagallwifi (which had a kitkat fp from picasso, because I had no clue of fp and safetynet api hasn't been introduced and I thought it's working, because I've used that fp since the very first marshmallow builds, I've based on the picasso device tree...). When safetynet came up (never switched to oreo or pie), I've switched to the latest available native chagallwifi marshmallow fp. After dirty flashing that build I've got an playstore update-list of over 30 apps, including netflix, gmaps, gcamera (both installed from playstore, not from zip or modded apks) and gps toolbox.

Since I've seen g making the gservices more restrictive (sic!), but never seen g taking back restrictions, I'm 90% sure it's still in place.
[OnePlus 3 & 3T Cross Device Development] OTAx1:
FYI - Zero problems updating playstore apps with AuroraOSS 3.1.4 & Magisk 20.1. No other issues either.
[OnePlus 3 & 3T Cross Device Development] knpk13:
https://www.apkmirror.com/apk/adobe...photoshop-camera-1-0-41-android-apk-download/

Min sdk 28, should be on play store (edit: soon) if anyone wants to try
[OnePlus 3 & 3T Cross Device Development] :
I can't find adobe photoshop camera on playstore (with 9.0.5 build fingerprint). Therefore no test possible.
[OnePlus 3 & 3T Cross Device Development] Naudiz:
I'm starting to get really confused by this SafetyNet-Fingerprint situation. I still use the original version of [MENTION=2911853]BillGoss[/MENTION] 's script, which sets SecPatch date to 2019-08-01 and Fingerprint date to 1907311932. I never had any reason to try something new, as it works for me to this day.

Yesterday I updated LOS to latest nightly, and now my "About phone" section shows me 05 November as patch date, even though Bill's script is still executed at boot (checked in Magisk log). Also SafetyNet still works fine, which is nice.

But why doesn't the "About" section show the faked date of August? Until yesterday I thought I understand how the script works, but now I'm not so sure anymore :/

EDIT: Just had another reboot due to some other Magisk modules updating and now the Sec date is back to 01 August, also in "About phone". Weird.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
I think you'll find that it's not[/] available from the Play Store. You can get it from Adobe or by copies of the APK from APK Mirror or AFH. See https://www.xda-developers.com/download-adobe-photoshop-camera-preview-android/

---------- Post added at 12:08 PM ---------- Previous post was at 11:48 AM ----------

There was a long discussion around this in the NLos thread. It comes down to timings of activities in the boot up process. And I definitely do NOT want to restart the conversation here.

The way things stand is: use what works (passes SafetyNet) for you and ignore the info in About Phone.
[OnePlus 3 & 3T Cross Device Development] :
That's why it's not possible to test if the playstore selection of presented apps is based on the buildfingerprint or the prop regarding api level... An installed app requests the minimal api level in it's manifest file, package parser and art rely on the prop - that has been out of question.

To check, if an oss 5 (android 8) fp allows to install min api level 28 (android 9) apks, we need a min api 28 apk on playstore.
[OnePlus 3 & 3T Cross Device Development] knpk13:
Oops, I forgot to add "soon". Edited my earlier post.
[OnePlus 3 & 3T Cross Device Development] RKS96:
I just recently migrated to LOS16. Today I found out that OP3T build is user debug which means USB debugging gets reenabled every time phone reboots. Is there option to permanently disable this feature? From my research I understand that building eng/user builds might be impossible because of old hardware.
[OnePlus 3 & 3T Cross Device Development] :
Is this guessing, or did you try rebooting with Android debugging disabled? For me the Android debugging setting is reboot persistant.
[OnePlus 3 & 3T Cross Device Development] RKS96:
Yes, I did try it!
[OnePlus 3 & 3T Cross Device Development] CortexFriend:
I can confirm this state: I disabled "Android Debugging" in the developer options. After a reboot it is active again. I have seen this as a "feature", not a "bug"...