yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] BillGoss:
[MENTION=5091734]dianlujitao[/MENTION]

I previously mentioned an issue with portal connections and you replied here https://xdaforums.com/oneplus-3/one...ageos-16-0-oneplus-3-3t-t3866517/post78939252

I'm now on stable 190328 after a clean install of stable earlier this month. And I'm still having the issue with some public wifi points and I think I know why.

Here's what I did:

- reset my network settings

- connected to the public wifi successfully but I'm not prompted for a login and, therefore, can't connect to the internet.

- so I type in the portal gateway address into the browser and if I use https it fails

- I type in the gateway address into the browser using http and, hurray!, it works.

Conclusion: for some portals using https doesn't work for the gateway connection.

Screenshots and logcat attached.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
It depends on mobile network (quality and coverage).

Try to test stock messaging notifications with wifi disabled.

You can also ckeck your Wi-Fi preferences (e.g. Turn on Wi-Fi automatically).
[OnePlus 3 & 3T Cross Device Development] Calum 2:
Text messaging doesn't use wifi. Which one of us is confused?
[OnePlus 3 & 3T Cross Device Development] b.roid:
for sim 1 is HD capable in status bar issue.

Settings -> Apps & notifications -> See all xxx apps -> Hit the three dots in the upper right and select "Show System"

Scroll down to find "org.codeaurora.ims" and select it.

Select "Notifications"

Select "ims"

Select "Behavior", and set it to "Show silently and minimize".

still stays in notifications but a lot less annoying.
[OnePlus 3 & 3T Cross Device Development] Dirk:
I don't even know why this is still a thing. Some people had figured this out months ago and were editing their own ims apk to eliminate the message.

Can we just get it done on LOS already?
[OnePlus 3 & 3T Cross Device Development] OTAx1:
Thanks. I can't support SU over Magisk just for the convenience of OTA updates. The discussion was made for 15.1 about whether leaving SU after installing Magisk was an issue & it wasn't. Open source vs closed source. Closed case IMO. ;)
[OnePlus 3 & 3T Cross Device Development] DarkSJ1998:
Or perhaps replace it with a good looking VoLTE logo that just sits aside the network bars [emoji14]
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Of course, messaging notification only depends on the quality/coverage of 3G/4G/LTE mobile network.

On the problem at hand, I noticed if mobile network coverage is poor, disabling Wifi improves messaging notification (i.e. messaging notifications are getting right away, not after a "lag" time).

But this solution is not ideal.
[OnePlus 3 & 3T Cross Device Development] deepblue_gr:
i installed recently the lineage os 16 on my a3003 but i cant be root. i enabled root options from developer options . i flashed the supersu binary and the addon su. but still nothing.... what i did wrong?
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Try to flash official LOS su (i.e. addonsu-16.0-arm64-signed.zip):

==> https://download.lineageos.org/extras
[OnePlus 3 & 3T Cross Device Development] deepblue_gr:
i did it .but still nothing
[OnePlus 3 & 3T Cross Device Development] Dirk:
Yeah, i think we have two SU installed again. :laugh:

Eric was suggesting you install ONLY the addon SU.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Do you have the same display as below in Developer options?
[OnePlus 3 & 3T Cross Device Development] deepblue_gr:
And how I remove the supersu. To flash only addon?

---------- Post added at 03:30 PM ---------- Previous post was at 03:29 PM ----------

Yes
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Boot in recovery

Wipe cache/dalvik/system ... not data !

Install build+Gapp+official su

Reboot system

Enjoy ... hope so
[OnePlus 3 & 3T Cross Device Development] Dirk:
Wherever you got the supersu from, should have the uninstaller. Or do what Eric suggested.

Supersu is no longer in active development. It's Magisk or addon SU. Either, not both.
[OnePlus 3 & 3T Cross Device Development] deepblue_gr:
the lineage os 16 i installed with my stock kernel is it possible to make that a problem?

---------- Post added at 07:01 PM ---------- Previous post was at 06:43 PM ----------

i tried exactly what you say.and im not root.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Firmware: FW 5.0.8 ?

TWRP: 3.2.3-10 ?

From a clean or dirty install ?
[OnePlus 3 & 3T Cross Device Development] Dirk:
Did you enable Root in Developer options as Eric mentioned before? (Take a look at his screenshot).
[OnePlus 3 & 3T Cross Device Development] deepblue_gr:
Yes I enabled root in Developer option.

---------- Post added at 04:40 PM ---------- Previous post was at 04:38 PM ----------

Twrp 3.2.3.1

Where I can find firmware
[OnePlus 3 & 3T Cross Device Development] vinoxflame:
how do you know you dont have root?

did you tried with root checker apps?
[OnePlus 3 & 3T Cross Device Development] ciarpame:
Does Addon su for LOS 16 passes safetynet check so I don't have issues with Netflix or financial apps or Magisk is still the only way to go to have better compatibility?
[OnePlus 3 & 3T Cross Device Development] deepblue_gr:
I checked with an app. Root checker. Not rooted

I install supersu and.... Not rooted

I tried the twrp app not rooted

---------- Post added at 05:27 PM ---------- Previous post was at 05:23 PM ----------

Yes, one app says no and the other say yes.

But other apps like twrp and supersu say not rooted
[OnePlus 3 & 3T Cross Device Development] Dirk:
Addon SU will break Safetynet for sure. The ROM passes Safetynet out of the box, but if you must Root, use Magisk.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
The easiest way is to install the highly recommended recovery (3.2.3-10 TWRP) and perform a clean installation (full wipe and flash build+gapp+official los su)

@ dianlujitao's TWRP (see OP)

==> https://androidfilehost.com/?fid=1395089523397907195

If you wish to use OTA updater

see this post: https://xdaforums.com/showpost.php?p=79172768&postcount=1383

---------- Post added at 17:43 ---------- Previous post was at 17:38 ----------

I confirm official LOS su breaks Safetynet.
[OnePlus 3 & 3T Cross Device Development] deepblue_gr:
Yes
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
[MENTION=3986617]ciarpame[/MENTION]

Did/will you have time to check the "symbol color SIM card" issue? But no rush, of course.

Previous posts:

https://xdaforums.com/showpost.php?p=79215056&postcount=1496

https://xdaforums.com/showpost.php?p=79215385&postcount=1498
[OnePlus 3 & 3T Cross Device Development] unimke:
Guys, anyone using the pie pixel launcher with LOS 16?
[OnePlus 3 & 3T Cross Device Development] meiser:
This is only partially true. You can use iSu to pass SafetyNet.
[OnePlus 3 & 3T Cross Device Development] Dirk:
So i created a flashable zip to remove the 'SIM is HD Capable' message.

Some things to note:

1) I am certifiably insane and ususally have no idea what i'm doing.

2) The ims.apk that has been modified comes from the crDroid ROM. (The ROM is LOS based so should be using the same ims.apk)

3) The modified ims.apk come from the Magisk Module kindly created by [MENTION=8956135]C-3OP[/MENTION] and available here: https://androidfilehost.com/?fid=11410963190603903635

4) The module was created some time ago so any ims.apk changes that have been made since then won't be included.

5) If you want to edit your own ims to remove the message:

1) Find ims.apk file in your phone and extract it to PC
Try looking for it in /system/priv-app/ims

2) Use apktool and do these edits in ims.apk

Decompile ims.apk

In ims.apk>res>values>bools.xml
Change value of config_update_service_status to True

In ims.apk>res>values>strings.xml
Delete value of device_is_hd_capable

In ims.apk>res>values-mcc** (inside dozen or so folders) > bools.xml
Change all values of config_update_service_status to False

Re-compile ims.apk and give necessary signs. Apply it manually or use a flashable zip

That Guide is from here: https://xdaforums.com/yureka/development/mod-device-hd-capable-notification-t3551145

6) If you do edit your own ims you can modify my flashable zip by extracting it, replacing the ims.apk with your edited version, zipping and signing the zip again.

7) I have tested my zip on my 3T and everything is working. I haven't seen the SIM is HD Capable message yet, but i can confirm that later once i've spent more time with it.

8) Before doing anything, make a copy of your ims.apk for safe keeping.

9) Nandroid!

10) Did i mention that i'm certifiably insane?

11) .zip below:
[OnePlus 3 & 3T Cross Device Development] Shreeram02:
U can use notifications off app from playstore it needs root u can turn it off from there
[OnePlus 3 & 3T Cross Device Development] Dirk:
As you said, it requires root, and there's nothing to be learned from installing apps that do everything for you. There's the easy way, and there's the XDA way! ;)
[OnePlus 3 & 3T Cross Device Development] GTRanushka:
Substratum

Is anyone using substratum with this rom?

I had battery drain issues with AOSP and substratum. Wonder it's the same with LOS.

Reason for substratum is dark notification.
[OnePlus 3 & 3T Cross Device Development] ciarpame:
Steps trying to reproduce the issue, with 20190323 build, SIM in slot 1 and slot2 empty:

- enabled PIN sim lock

- boot

- PIN is requested and radio works after inserting it

- changed sim color from red (my previous color) to purple

- boot

- PIN is still requested and radio works after inserting it

So, on my side, it works as expected.
[OnePlus 3 & 3T Cross Device Development] Eric_Lev:
Many thanks for your feedback !

From memory, you moved from 15.1 to 16.0 with a dirty flash ... That's right, isn't it?
[OnePlus 3 & 3T Cross Device Development] Shreeram02:
But that way doesn't get rid of it completely ?

Thats why...

If it did it completely why would I waste my time writing here
[OnePlus 3 & 3T Cross Device Development] ciarpame:
Yes, that's right.
[OnePlus 3 & 3T Cross Device Development] punio4:
So, safetynet suddenly isn't working as of today. No new LOS updates installed, no changes.

Yesterday evening Google Pay was working, this morning it didn't.

My phone wasn't rooted. Installing Magisk Manager and running safetynet check returns a CTS mismatch.
[OnePlus 3 & 3T Cross Device Development] ciarpame:
Safetynet ok for me according to Magisk manager 7.1.1 (Magisk version 18.1)
[OnePlus 3 & 3T Cross Device Development] Dirk:
Just a reminder for anyone not into April Fools pranks in their ROM:

In Terminal:

setprop persist.lineage.nofool true

Hopefully that will prevent some of the "OMG my OP3/T says that it's an iPhone now..." or "I flashed the latest build and now my font is Comic Sans" complaints tomorrow.
[OnePlus 3 & 3T Cross Device Development] matulko:
Can confirm, after installing 20190328 Google pay is not working (no magisk, no su installed, only clean LOS). After installed 20190327 back, Google pay is working again.
[OnePlus 3 & 3T Cross Device Development] berliozz:
[MENTION=5091734]dianlujitao[/MENTION] — does any chance to add support tri state button, like on OnePlus 5 for our device? This allow use tasker for handle Alert slider.
[OnePlus 3 & 3T Cross Device Development] punio4:
Weird. I haven't done any updates since 0329 which worked fine.

---------- Post added at 18:22 ---------- Previous post was at 18:21 ----------

Weird. I haven't done any updates since 0329, which worked fine yesterday.
[OnePlus 3 & 3T Cross Device Development] npeersab:
Even while charging or after charging the phone "Battery may run out soon" notification is still there
[OnePlus 3 & 3T Cross Device Development] Calum 2:
I think I figured out what was wrong. The messaging service app was being optimized for battery usage. I had checked on the messaging app but not the messaging service app. I hope that does it.
[OnePlus 3 & 3T Cross Device Development] dimon2242:
Sometimes I faced with mistake with fingerprint. Device not respond on fingerprint (no any reactions), but if turn on -> turn off display once and again, it's works again.

I installed latest firmware.
[OnePlus 3 & 3T Cross Device Development] realtos:
try add it and see if it works?

---------- Post added at 06:25 AM ---------- Previous post was at 06:23 AM ----------

so?
[OnePlus 3 & 3T Cross Device Development] matulko:
tested once again with 20190331 build and Google Pay is not working with this build (error message says, that phone is rooted or modified, but only clean LOS is installed, no Magisk or su). Installed back build 20190327 and Google Pay is working again.

Can be this https://review.lineageos.org/245235 responsible for this?
[OnePlus 3 & 3T Cross Device Development] Pablo.x:
I've used Google Pay with no problems on 20190330 build and Magisk v19.

With Google pay and GMS (by default enabled) on Magisk Hide.
[OnePlus 3 & 3T Cross Device Development] Flounderist:
A lot of GPay users are being blocked due to a new unlocked bootloader detection system. I don't think it is ROM related. You will find a thread on the magisk section in XDA about it.

By my side, I can't use GPay since mid-march. It looks like that Play Services app being updated to 15.090 version or higher is the deal breaker.
[OnePlus 3 & 3T Cross Device Development] lokeshjt:
Finally installed LOS 16.0 last week. Everything else is working fine but I'm having issues with Bluetooth connection to my car audio. Music plays for say ~10-30 seconds and then it abruptly goes silent. Audio fx bug is already fixed so not sure what else could be the issue.. Still tried disabling audio fx but it made no difference.

One point to note is that when I go to connection settings and uncheck Phone calls, then the media audio works fine without any interruption. The issue occurs only if both Media and Phone calls are enabled for my car's audio connection.

I had faced the same issue with OOS ( back in 2016 when it was on Marshmallow) but it got resolved by itself and since then never faced it on OOS or any custom ROM (Sultan ROM, AOSPA, Omni etc).

I will try to collect logs if that might help. If anyone knows about any solution/workaround for this, please advise.

P.S: I did a clean flash coming from OOS 5.0.8. No magisk module or any enhancement, just stock LOS 16 and open gapps nano.
[OnePlus 3 & 3T Cross Device Development] felagund:
Earlier somebody mentioned disabling aptX but I don't remember if it was in relation to the audio fx bug. Might be worth fiddling with the BT codec settings just to make sure it's not due to a codec. I don't have aptX capable devices to check though and it works fine with bothy rn52 based diy car BT adapter and my mpow BT adapter which had both phone and media turned on a couple of weeks ago when I last used it.
[OnePlus 3 & 3T Cross Device Development] kryzeK:
[MENTION=5091734]dianlujitao[/MENTION] would you be able to redo the for the alert slider settings to be appropriate with Android Pie? Please.

Because DND is now a single mode, and also there is a real silent mode. Then it would make more sense to remove DND types (alarms only, priority and total silence) that actually bind the same unique functionality.

So the new triggers should be these: Silent, Do Not Disturb, Vibrate and Ring/None.

Or a better example: from what I remember OxygenOS Pie already works this way.
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
Will do, definitely, but it's too early to do so, I care more about basic hardware support and stability at this stage.
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
Experimental build trying to preserve crypto footer on format: https://xdaforums.com/showpost.php?p=78332159&postcount=374

For anyone cannot re-encrypt after format data in TWRP, have a try
[OnePlus 3 & 3T Cross Device Development] bumbum.droid:
Using Tolyan's release and just had to reinstall the apk...

---------- Post added at 07:20 AM ---------- Previous post was at 07:17 AM ----------

I can confirm other's experiences. Dirty flashing works. Before flashing I installed latest stable firmware and latest twrp. Only issues I had was downloading from Gapps page as it was 20kbyte/s... You'll get some FCs from google apps but after re-installing those they disappear.
[OnePlus 3 & 3T Cross Device Development] CodesCodger:
I had a weird issue today. If i try to connect laptop via usb tethering or wifi hotspot causes rom to hot reboot
[OnePlus 3 & 3T Cross Device Development] dimon2242:
Anyone has high lags in viewfinder on any version of gcam?
[OnePlus 3 & 3T Cross Device Development] caryle:
What's the best 6.x gcam for now?
[OnePlus 3 & 3T Cross Device Development] legendavey:
These questions belong in the GCam thread on XDA, as they are not related to LOS 16. :)

P.S. The lags you experience are because the camera is for the Pixel 3 with a Snapdragon 845 processor while we are on the Snapdragon 820/821.
[OnePlus 3 & 3T Cross Device Development] caryle:
Your reply is very useful to me! Thanks!
[OnePlus 3 & 3T Cross Device Development] realtos:
[MENTION=5091734]dianlujitao[/MENTION] would just like to say thanks to you dianlujitao for movin the device forward to Pie, without you it wouldnt happen at all officially. so I appreciate your work on it :)

---------- Post added at 04:53 PM ---------- Previous post was at 04:47 PM ----------

i enabled mine in settings, but is there any way to have the nfo on screen there until unlocked the phone? it disappeared very quiclkly
[OnePlus 3 & 3T Cross Device Development] dimon2242:
Of course, but on LOS15.1 and other ROMs I haven't this problem:fingers-crossed:
[OnePlus 3 & 3T Cross Device Development] Dirk:
You can't reasonably expect Camera Apps that were worked on for months to be compatible with Oreo, to also work just as well on Pie. If they do, it's a miracle... but there's probably a lot of work ahead for GCam devs to get the ports working well for Pie. More so now as there is new Camera software from Google, with new features that everyone wants, so it's even harder. New Camera software, new Android software..somehow got to be made to work together. It's a big job. Have a look at this article to get some idea of what's involved:

https://www.xda-developers.com/came...opers-make-hardware-work-without-source-code/
[OnePlus 3 & 3T Cross Device Development] MrKartupelis:
You're right. Just enabled pocket setting in ambient display settings and it did work (on removal of pocket) but disappeared almost immediately.

[MENTION=5091734]dianlujitao[/MENTION] I know you're very busy with basic functions of ROM but maybe you can have a look in the future :cowboy:
[OnePlus 3 & 3T Cross Device Development] realtos:
i just enabled it in quicktoggles and then remove the toggle again after enabled and it activated but would be cool to have settings on it to change the timer :)

but afiak its not a target oneplus3 change so other devs will probably take care of it :)
[OnePlus 3 & 3T Cross Device Development] bumbum.droid:
I'd recommend Tolyan's builds as he has an Oneplus 3 himself.

https://www.celsoazevedo.com/files/android/google-camera/dev-tolyan009/

I don't have issues with GCAM. In fact it's working better than on Oreo...
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
"disappeared almost immediately"? It lasts for few seconds here
[OnePlus 3 & 3T Cross Device Development] MrKartupelis:
Sorry for confusion. Yes it lasts for few seconds. I wrote almost immediately, because ambient display was always on for me - on other ROMs - (before proximity sensor gets triggered)
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
That's probably AOD, will be enabled.
[OnePlus 3 & 3T Cross Device Development] caryle:
Thx, I will try.
[OnePlus 3 & 3T Cross Device Development] ufokomar:
support magisk manager ?
[OnePlus 3 & 3T Cross Device Development] matulko:
Anyone knows how to sign TWRP?
[OnePlus 3 & 3T Cross Device Development] DarkSJ1998:
I have Magisk installed & just upgraded to the 20190331 build & SafetyNet fails for me too now :/

Was previously on 20190329 build & everything was fine there. Google Pay was working & my device was passing SafetyNet check.

EDIT:-

I don't know how but now I'm again able to pass SafetyNet. Didn't do anything & didn't even do a reboot. IDK what was causing it to fail earlier... :/
[OnePlus 3 & 3T Cross Device Development] punio4:
Updated to GPS v16. Still failing.

Installed Magisk.

...

It works now. What the hell.
[OnePlus 3 & 3T Cross Device Development] OTAx1:
I removed G PlayStore & PlayServices, installed YalpStore OTA. Even though doesn't pass SafetyNet Check due to GPS not installed everything else works fine. Uninstalled any apps that require GPS long time ago with zero issues.

https://github.com/yeriomin/YalpStore/releases
[OnePlus 3 & 3T Cross Device Development] Dirk:
I have a theory. As theories go it's not going to make the Washington Post, but TMZ might be interested.

The ROM was passing Safetynet out of the box. The only way this could happen is if the Kernel had the Verified Boot patches, hiding the Bootloader Unlocked state. The OP stated months ago that this was not intentional. Don't ask me how the Kernel could have been patched accidentally, but we know that officially LOS aren't interested in circumventing Safetynet. They stated before they wouldn't do this. (It might even be in the Charter)

So, with the Bootloader unlocked state already being hidden, all Magisk had to do previously was to hide Root (itself basically), from Google Pay etc.

Now imagine if the ROM stopped hiding the Bootloader Unlock, making itself compliant with the LOS protocol. Perhaps the patches were removed? Now the ROM would not pass Safetynet out of the box. Magisk would now have to hide the Bootloader state and Root state. There seems to be evidence that Pay has gotten better at detecting the Bootloader Unlock, OR that for a version or two Magisk got worse at hiding it.

Another way to look at that. With Kernel Patches in place, Pay could never know that the Bootloader was unlocked because the Kernel was reporting 'everything fine here, Bootloader secure'. If the Kernel Patches went away then it's up to Magisk to 'convince' Pay that everything is secure. As above, if Pay were getting better at spotting the deception, or Magisk were getting worse at deceiving, it could lead to the current condition.

Easy way to test the theory. Does the ROM still pass Safetynet out of the box? I've had no issues using Pay at all, regardless of GPS or Pay builds. That's because the ROM i use has the Kernel Patches. If not passing Safetynet out of the box any more, try Caesium or other Kernel. (They are all patched) Now you will certainly pass Safetynet without Magisk again, and Magisk can go back to just hiding itself, something it appears to be better at.

If i'm correct then the people still having trouble using Pay, should find the situation improved by using any of the popular 3rd party Kernels.

Hopefully someone will do a clean install soon, without Root, and check Safetynet status.
[OnePlus 3 & 3T Cross Device Development] pedritopl:
There's a long discussion about this in the Magisk Canary thread and even a separate Google Pay Magisk thread. In short - Google Play Services started doing additional checks for root with v15 and that's why in latest Canary and Beta Magisk builds com.google.android.gms.unstable is added to Magisk Hide by default. For most - that should do the trick (it does for me on NLOS), but there are some guys in the GPay Magisk thread complaining that GPay is still not working (mostly Pixel users).
[OnePlus 3 & 3T Cross Device Development] matulko:
Clean installation without root or magisk and safety net check fails on build 0331. Safety net check on build 0327 passed.

BTW. Caesium kernel is not anymore in active development as far as I know
[OnePlus 3 & 3T Cross Device Development] pedritopl:
Well, there are not many commits between those two builds, and as was mentioned already - this commit seems to be tho one causing the change. Look at the code it introduces:

https://review.lineageos.org/c/LineageOS/android_device_oneplus_oneplus3/+/245235