yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Thanks for your efforts..still nothing i have to disappoint you sadly
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ashyx:
Don't your T830 kernel sources boot on the T835?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Samsung's kernel source code release for the T835 features the same source code as for the T830, but with a slightly different kernel config.

The differences are highlighted below:

$ diff -u arch/arm64/configs/gts4l[wl]*
--- arch/arm64/configs/gts4llte_eur_open_defconfig	2018-10-21 09:53:36.290780301 +0200
+++ arch/arm64/configs/gts4lwifi_eur_open_defconfig	2018-10-21 09:53:48.890756627 +0200
@@ -569,24 +569,12 @@
# CONFIG_SEC_GREATQLTE_PROJECT is not set
# CONFIG_SEC_CRUISERLTE_PROJECT is not set
# CONFIG_SEC_KELLYLTE_PROJECT is not set
-CONFIG_SEC_GTS4LLTE_PROJECT=y
-# CONFIG_MACH_GTS4LLTE_USA is not set
-# CONFIG_MACH_GTS4LLTE_CHN is not set
-# CONFIG_MACH_GTS4LLTE_CHNHK is not set
-# CONFIG_MACH_GTS4LLTE_DX is not set
-# CONFIG_MACH_GTS4LLTE_KX is not set
-# CONFIG_MACH_GTS4LLTE_JX is not set
-# CONFIG_MACH_GTS4LLTE_SER is not set
-# CONFIG_MACH_GTS4LLTE_SPR is not set
-# CONFIG_MACH_GTS4LLTE_TUR is not set
-# CONFIG_MACH_GTS4LLTE_UB is not set
-# CONFIG_MACH_GTS4LLTE_UC is not set
-# CONFIG_MACH_GTS4LLTE_USC is not set
-# CONFIG_MACH_GTS4LLTE_VZW is not set
-CONFIG_MACH_GTS4LLTE_XX=y
-# CONFIG_MACH_GTS4LLTE_DD is not set
-# CONFIG_MACH_GTS4LLTE_XX_LDU is not set
-# CONFIG_SEC_GTS4LWIFI_PROJECT is not set
+# CONFIG_SEC_GTS4LLTE_PROJECT is not set
+CONFIG_SEC_GTS4LWIFI_PROJECT=y
+# CONFIG_MACH_GTS4LWIFI_SER is not set
+# CONFIG_MACH_GTS4LWIFI_ZC is not set
+CONFIG_MACH_GTS4LWIFI_XX=y
+# CONFIG_MACH_GTS4LWIFI_XX_LDU is not set
CONFIG_DRV_SAMSUNG=y
# CONFIG_RELOCATABLE_KERNEL is not set
CONFIG_LOD_SEC=y
@@ -1449,7 +1437,7 @@
# CONFIG_HV_MUIC_S2MU004_AFC is not set
# CONFIG_MUIC_S2MU004_ENABLE_AUTOSW is not set
# CONFIG_MUIC_S2MU004_NON_USB_C_TYPE is not set
-CONFIG_HICCUP_CHARGER=y
+# CONFIG_HICCUP_CHARGER is not set
# CONFIG_GPIO_UART_SEL is not set

#
@@ -4926,7 +4914,7 @@
CONFIG_SENSORS=y
# CONFIG_SENSORS_SYSFS is not set
# CONFIG_SENSORS_CM36672P_IRIS is not set
-CONFIG_SENSORS_SX9320=y
+# CONFIG_SENSORS_SX9320 is not set
# CONFIG_SENSORS_SX9320_WIFI is not set
# CONFIG_SENSORS_SX9320_WIFI_SUB is not set
# CONFIG_SENSORS_SX9310 is not set

As you can see, the main difference is CONFIG_SEC_GTS4LLTE_PROJECT vs. CONFIG_SEC_GTS4LWIFI_PROJECT. I haven't yet looked into the different compilation paths depending on these defines.

I haven't tried having someone boot the T830 kernel on the T835. It may well boot, but I suspect it would be crippled. Presumably, LTE would not work, and there may be other issues.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
OK.

For the sake of clarity, I have (hopefully only temporarily) removed the T835 from the title of this thread and upgraded the T830 kernel to beta status again.

The T835 is unsupported until further notice. I shall continue to work in the background on producing a working kernel for this device, but it will probably take updated sources from Samsung to fix the problem.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ashyx:
Yep I'm aware the sources are the same and of the differences in the defconfig.

I used the T830 sources which are booting and running fine on the T835.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
I've just trawled through the code to determine the net effect of defining CONFIG_SEC_GTS4LLTE_PROJECT vs. CONFIG_SEC_GTS4LWIFI_PROJECT.

It turns out that the only difference is in the compilation of the device-specific DTBs, which is pretty strong evidence that the DTBs supplied by Samsung for the T835 are defective. I already suspected them, given the T835's failure to even attempt to boot its kernel. Something has to be fundamentally wrong for the kernel to not even get out of the starting blocks.

[MENTION=5592698]dr460nf1r3[/MENTION], please try this boot image. The kernel is built for the T830, but it's packaged inside a modified boot image for the T835. This means the kernel has the T830's DTB (hardware spec) appended to it, and may therefore not be fully compatible with your device. It will, however, probably boot. Please put it through its paces and report back.

If you run into hardware issues using this version, I'll look into detaching a working DTB from the T835's stock kernel (which we know works) and appending it to my kernel. Hopefully, it won't come to that, though.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Check the link again pls its faulty
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ashyx:
URL is just malformed.

https://androidfilehost.com/?fid=11410932744536986028
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Still no visible change

Does a clean nandroid backup change anything?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Ugh. That is the exact same kernel that my T830 is running right now.

Let me look into appending the DTB from the T835's working stock kernel onto this kernel. Someone has produced a tool for splitting them, so I just have to figure out the exact mechanism for gluing one back on. The answer must be in Samsung's source code somewhere, as this is the process that happens when you build a kernel from scratch.

What a pain the T835 is so hard to get working. The T830 was trivial and literally worked on the first attempt.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Well it would be too easy i guess ? looking forward to test the next build
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Well, that turned out to be remarkably easy.

Here is a boot image consisting of a kernel image compiled from Samsung's source code, with T835 DTBs appended from Samsung's own stock kernel, rather than built from their source, which I suspect is faulty.

The DTBs are Samsung's and known to work. The boot image is modified from Samsung's own stock and known to work. The only custom element here is the kernel itself, and that is known to boot on the T830. There are no conditional code paths when compiling for the T835, so all 3 of these elements are known to separately work. They should therefore also work together.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
So with this one, its different again, like 10 sec static screen then reboot without showing the moving samsung logo. Looping

I'll try to restore stock Backup and see what happens

Edit: nope
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Look! After restoring the backup the system partition got ****ed up somehow which is why it didnt boot when i restored first, after getting everything right however the kernel booted! Going to try the others you uploaded earlier!

The one before also works now

Tried your modesty zip and it works just fine now.. really funny i have no idea what changes caused your kernel to not boot
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ashyx:
Do you still have twrp installed?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Yes. I restored the nandroid of all partitions which i created right setting up twrp
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ashyx:
/Data is still mountable?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Yeah all just working! Even flashed the updated 21/10 kernel from the download post, 0 issues. Then rooted via ians latest magisk build and setting up now

---------- Post added at 03:55 PM ---------- Previous post was at 03:26 PM ----------

Yeah all just working! Even flashed the updated 21/10 kernel from the download post, 0 issues. Then rooted via ians latest magisk build and setting up now

Welp something is fundamentally wrong after installing apps and gapps modules.. for example apps dont uninstall and there are no root requests anymore, apps freezing frequently etc

After wiping cache we got the same problem as before, bootlooping

I guess i can try to pull logs somehow if you tell me how to do this without computer
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Appearently the problem about all the freezing stuff has Something to do with the magisk modules i installed. System was freezing Samsung Files didnt open and system hot rebooted by itself.. i removed the modules and voila no more freezing. Really weird tho because with Stock kernel everything works
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Let's pause for a moment to take stock of the situation, because some good progress has been made today, and I don't want the key findings to get lost in the noise.

If I understand you correctly, most if not all of the test kernels I built for you, as well as the T835 kernel from at least one official Modesty release, are now booting on your machine after some kind of data restore operation that you carried out. Is that correct?

If the official Modesty release is now working for you as expected, that's the most important thing I need to know. If that's not the case, I need to know which of the test builds are functioning as designed. Please also detail exactly what you restored today to bring about the change in booting behaviour.

I can't tell at this point if there was ever a problem with the Modesty kernel for the T835, or whether this whole tangent has been caused by some issue local to your machine.

I also want to be careful not to confuse any Magisk module issues you have with kernel issues, so please detail which modules you have installed, and which of them you had to disable to cause the machine to boot properly.

I need to digest all of the data here and make sense of everything that has been said today, so that I know exactly how to proceed. I'm left with the impression this has been one long wild goose chase, but if not, I need to understand what work still needs to be done at my end.

Let me conclude by appealing to other T835 users to please try this kernel out and report your findings. The more data points I have, the less likely I am to waste valuable time chasing non-issues caused by configuration issues local to a single device.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
You are right about what you said. Much confusion going on here..

Sooo. Completely stock nandroid backup of all partitions. Twrp app only backup of my apps. Installed magisk modules one by one. Screen attached.

And yes, this is performed using your latest official Release!
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Here
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
So, is it now your view that there never was an issue with the kernel itself, and that your difficulties all stemmed from some unrelated, local problem on the device?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Probably, yes. If so im sorry for all the work you had done because of this. But yeah, it works flawlessly with this configuration.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
No worries. I'm not looking to apportion blame here. I just want to establish the facts and move on to more constructive work on the kernel.

Given your statement, I'll reinstate the T835 as officially supported by this kernel.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
More testers needed.

Now it has been verified that Modesty works on both the T830 and T835, it would be nice to get a few more users up and running on the kernel. Is anyone willing to take the plunge? A single user on each model of device is woefully inadequate as a testbed, especially when one of those users happens to be me.

If there's no interest in a custom kernel for these devices, that's fine: I would have done the work anyway to satisfy my own needs. But if there is interest, then it would be helpful if a handful of users could actually give the kernel a spin.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] 1eStar:
I'm interested in your kernel development, I've only just purchased my Tab S4, have not yet rooted it or put custom recovery on it. Eventually my devices go that way, I do not own a computer so it's something that will happen in its own good time when I get an opportunity. So please keep up the good work with development.

What interests me in any kernel is battery life, and fast charging.

I know kernel work is important, but what I'm more interested in is custom Rom development. I'm hoping someone will adapt the stock Rom and add theme store support.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] Cirno5:
T835 user here.

Because of work I can only help out starting mid November.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Tbh i think i found the culprit. I flashed updated adreno drivers back then which i just flashed again... System not booting with your kernel. Restored vendor Image, all just fine. Sorry for the confusion caused.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Where did you find these Adreno drivers?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
https://xdaforums.com/mi-mix/development/driver-adreno-530-540-gpu-driver-t3815853

These ones. Was sceptical but they indeed worked on the stock rom, just not with your kernel. Was hoping for better Performance in pubg ?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
According to the poster of that thread, the lineage of these files is:

Not much of a pedigree, in my opinion.

Be careful what you flash onto your device. You basically have no idea what's in those files, or what side-effects you are setting yourself up for when you flash them into the very core of your device.

Please definitely do mention in the future when you have deviated from the stock configuration in such a fundamental way. The first thing I would have had you do is roll back to a stock config when you hit a kernel issue. It's all water under the bridge now, but please do bear this in mind in the future.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Yeah thanks for pointing this out definitly will do.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] buzzfuzz1:
Can this be flashed on a stock non rooted tab?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] Reuben_skelz92:
You will need unlocked bootloader and TWRP
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] N1NJATH3ORY:
SM-T835 Unlocked bootloader TWRP & Rooted, can test. i hope it's just flash and play ? Just let me know when i can proceed dude [MENTION=7187684]ianmacd[/MENTION].. Oh i got some majsik modules installed see pic i hope they don’t interfere with the Kernel! Other thing logs I’m not sure how to do that if you need them ? I’m not a pro, I’m letting you know up front, as i don’t want to waste your time. If you get what i mean dude. Thanks.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ashyx:
You know that you can natively take screen shots on your device? Usually power + vol down.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
So after using for a bit i found that while using your kernel netflix does not work for me. I flashed countless times with different approaches like not installing magisk modules xposed etc trying to resolve that issue. In the end it was your kernel making the difference. So i gotta stop using for now since Netflix was one of the reasons to buy a tablet sadly
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Netflix plays fine, just not in HD, and only after installing the liboemcrypto disabler Magisk module. TV station apps like My5 need it, too.

This is a known issue with any rooted kernel, not just this one. You will also run into it with a rooted stock kernel.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Well i installed liboemcrypto module ALWAYS! It works without your Kernel.. with yours i get Netflix Error 5.8 when trying to play an episode
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
I don't know what to tell you. I'm using the module myself on my own Tab S4.

Please tell me the path of liboemcrypto.so on your device.

Have you made any other unofficial modifications to the device?

Are you sure you are using the module called liboemcrypto disabler, not some other module with a similar purpose?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
Have a look at the magisk modules. its definitly the right one.. without the Module Netflix doesnt even get to the Login Screen.. No other Changes Made apart from xposed but i have the same issue without it so..

I found the File in /system/vendor/lib.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] usadream:
Using your kernel on an SM-T835 for a few days now, no issue during use at all. Only issue I had was at the first reboot after installing ur kernel and magisk (ur last version), the tablet froze. After a soft-reset everything is now working flawlessly. Thank you
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Thank you very much for the positive report. It's particularly good to receive it from a T835 owner, since I can't test that device myself.

I'm pleased the installation went smoothly for you, except for the initial freeze, which I can't explain. Hopefully, that was a one-off.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] usadream:
Sure thing, me too. I will keep u posted should I encounter any issue. Thank you for ur efforts in building the kernel, very much appreciated
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Issue confirmed.

Something significant changed between Linux 4.4.115 and 4.4.116. I guess I hadn't tried it for a few weeks.

I'll hunt the issue down.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Version 0.99.6 released.

This release fixes the problem of media apps that depend on liboemcrypto.so failing to play, even when the appropriate Magisk module is loaded. This will allow Netflix, My5, etc. to play video again.

Change log

v4l2 fixes to restore liboemcrypto-dependent apps to working state.

Thank you to [MENTION=5592698]dr460nf1r3[/MENTION] for reporting this issue.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] dr460nf1r3:
This one working pretty good so far, thanks! ?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] vick1982:
stock ?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Aitken? Waterman?

In other words, can you please elucidate the question?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] N1NJATH3ORY:
HI i flashed this one v0.99.5 (2018-10-21) as the web page hadn’t refreshed, I didn’t know there was a update.. Anyway it booted fine, then i inputted my Android pattern it froze for a few seconds then screen went blank..

i left it, waited about 30 seconds, i then double tap to wake it up. It didn’t respond. Then i pressed power button only once, now I’ve got a dim SAMSUNG logo just flashing away.. I held in power button nothing, then volume down and power button it rebooted.. Now it's booted up fine, can I just flash new version is that how I up date ? if I experience any other issue I’ll let you know, other than that it all seems fine. Thanks

UPDATE!! I've just noticed that i have lost Magisk and all the mods, i had made...Sorry i didn't read all the post so flashing it breaks root
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Which device do you have? Everyone who reports an issue needs to state this as a matter of course.

Flashing a new kernel necessarily removes the currently installed one. If the old kernel was rooted, but you neglect to root the new one before booting, then you will obviously lose root when you boot.

Just reboot to TWRP, reinstall Magisk, and everything will be back as it was.

If you don't want to be able to forget to root a newly installed version of the Modesty kernel before rebooting, set up your system to make use of the Magisk-chaining feature,
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] N1NJATH3ORY:
Hi i have the SM-T835 after first boot, it automatically rebooted to the Samsung logo (real dim) slowly flashing away. I think its first boot it don’t like it for some reason other than that it working fine now

Yes thank you, i have root now :) Also i flashed the new version of Modesty, so i am on v0.99.6 (2018-10-28) it all seems fine. Will have a play next few days, to see if i get any issue.

But I doubt ill have any issue as it’s been fine since last night.. Thanks
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] N1NJATH3ORY:
Hi i can’t get the Xposed Framework (SDK 27) 90.2-beta3 to install? it installs fine via Magisk but when i reboot it boots up then i input my Android pattern it locks up then it don’t respond.

30 seconds later it reboots with the dim flashing SAMSUNG logo, the only way i can get out of that is volume down and power button. Once it boots I’m back to square one, Magisk shows it installed but it does not show up in apps ?

And just know as i was about to search for Xposed it froze and rebooted I’m back at the dim SAMSUNG logo? This is the 3rd time it’s done this? Thanks
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
I'm using systemless Xposed via Magisk myself without any problems. Note that installing the framework won't put the Xposed module installer itself on your system; you have to install that app separately.

Do me a favour and try changing your authentication mechanism to a PIN instead of a pattern. Let me know if that makes any difference.

Are you running any other kind of mods, such as SystemUI hacks or anything like that?
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] ianmacd:
Version 0.99.7 released.

Well, what do you know? Samsung have finally granted my request to release the source code to their ARH5 kernel, and they even did it simultaneously for the T830 and T835.

So, this release of Modesty updates the kernel to match the firmware that most of us are actually running on our devices. Samsung's new source code includes device tree (DTB) updates, so all ARH* firmware users are recommended to upgrade to 0.99.7.

Anyone running on ARH8 firmware should note that the kernel source code is unchanged for that version, so this release of Modesty is equally well-suited to that firmware.

Modesty's boot images were already based on ARH5 stock images from the beginning.

Change log

v0.99.7 (2018-10-30)

Rebased on Samsung's ARH5 kernel source code.

Reworked the v4l2 fix that restores liboemcrypto-dependent apps to working state.
[Samsung Galaxy Tab S4 ROMs, Kernels, Recoveries, &] N1NJATH3ORY:
HI I manage to get Xposed installed, i did change to pin as you asked but im still having issues. For example today 3 times i put my pin in, it would lock up and reboot to Samsung (dim logo) So I would have to push volume down and power button to get out of that mode.

No i am not running any SystemUI hacks I think? See below what i got installed

AdguardDNS AdBlocker

Enable Doze for GMS Magisk Module

Libsecure_Storage Companion for rooted Samsung devices

Magic Charge Switch

Ram Management fixes bt crok

Sysconfig Patcher

Viper4Android FX

Xposed Framework

YouTube Vanced - Magisk Repo

YouTube Vanced black theme - Magisk Repo

In Xposed, all i got installed is AllowLongSMS..

Other issue I’m facing, as i got Magic Charge Switch installed. i cannot get any command's to work via terminal? Something is seriously wrong as no command will work, i SU first to get Root then let’s say i run this command -i --> i get not found. It doesn’t matter what i try, it simply does not work? When i was on stock kernel all the terminal commands worked fine.. Thanks