yashsingh1/xdaforums huggingface dataset:
[X Style (Pure) Android Development] Hashbang173:
Like a better version of audit2allow?

It does? It seems to work fine with whatever version I'm running. (but I have done very little testing, my hacky way of skipping the first 19MB of the modem partition to avoid the old version string might need to be adjusted)
[X Style (Pure) Android Development] randomblame:
Been a minute since I looked at it I tested it once and it failed I assumed TWRP needed rebuilt probably didn't look at it hard enough could just need to be adjusted.

https://developer.android.com/training/safetynet/

It's a set of apis designed to take all the fun out of everything we do luckily only about 1% of apps are using it. I only started ranting about it because my kid wanted to play Pokemon go on it and it didn't work so it was on my mind. Imagine a scenario where Google implemented it in their apps and they each checked to see if your device has been tampered with before running - it would be an xda apocolypse
[X Style (Pure) Android Development] PythonNut:
I ran into this too. Try wiping data for the Play Store? That fixed it for me.

---------- Post added at 02:58 AM ---------- Previous post was at 02:00 AM ----------

If I format the sdcard on the phone, the filesystem is FAT 32. I'll try formatting it as exFAT on my laptop, I guess?
[X Style (Pure) Android Development] camcho1:
:crying:

How can I have the sound of the old builds again? my mp3 files are at 320 kbps and with the latest updates, they sound like 128 kbps
[X Style (Pure) Android Development] moviefirst:
I am missing the navigation bar in landscape mode, bug?

Edit: Mistake, their working?
[X Style (Pure) Android Development] randomblame:
I remember in the olden days there was a difference between pure and style audio files but im having trouble finding info. I'll look into the audio issue I'm sure it's acdb related
[X Style (Pure) Android Development] moviefirst:
No problems with audio for me ( x style )
[X Style (Pure) Android Development] randomblame:
I may have borked it months ago when libinit wasn't working I don't remember if I fixed it but I think I hardcoded some stuffs in there ill have to take a look again

*Edit looks like I did fix that
[X Style (Pure) Android Development] camcho1:
lineage-16.0-20190209-UNOFFICIAL-clark_video_recording_functional.zip

Whit this build the sound is cool

My model is xt1572
[X Style (Pure) Android Development] randomblame:
I moved the acdb files so they are getting called and used now you may just prefer the uncalibrated sound or it may be still a little broken I can disable acdbloader next build to compare
[X Style (Pure) Android Development] randomblame:
Lol I think the audio difference between variants I was thinking of was actually desirehd vs inspire and I'm getting old *suppresses urge to try building pie for 10 year old device
[X Style (Pure) Android Development] aybarrap1:
LoL...I still have my Inspire running ICS.

Edit: if for some reason your urge takes over, I'll test Pie for you.
[X Style (Pure) Android Development] camcho1:
:D:D
[X Style (Pure) Android Development] randomblame:
It would be slowwwww but nerdy fun... I think I have some of my inspire somewhere
[X Style (Pure) Android Development] aybarrap1:
LoL... I'm game, but I think I can safely speak for most of us following your work that we would prefer you keep your focus working on this ROM atm. With so few devs left supporting this device, it is nice to see you so active. Your current work for the MXPE is greatly appreciated.

Perhaps later.
[X Style (Pure) Android Development] Kasha05:
Hey , i flashed this rom on my moto x pure a month ago and it was constantly crashing after i unlocked my screen, it wasn't stable and in working condition so i downgraded to android 6, i am very eagerly waiting for a stable version because i want to have android pie, can anyone tell me if it is stable or in working condition now??? Please help me !!

Thanks!
[X Style (Pure) Android Development] randomblame:
It's been stable wipe cache and data
[X Style (Pure) Android Development] Kasha05:
Will it work if i flash it directly from official android 6??
[X Style (Pure) Android Development] xabr3:
No. You need 7 nougat firmware. (Modem)
[X Style (Pure) Android Development] big_marcolino:
Can I take photos with apps like Whatsapp, Instagram, etc or only with Snapchat?
[X Style (Pure) Android Development] Kasha05:
what do firmware and modem mean??? Is it that i need to have an android nougat based rom to be able to successfully run this android 9 rom??

currently i flashed this rom directly from android 6 and it dosen't show my sim card, and keeps on powering off in every 40-60 seconds everytime i turn my device on,

please help!!! ASAP, guide me how to properly flash it, i wish to use this as my daily driver! and im up for a donation aswell
[X Style (Pure) Android Development] randomblame:
There are instructions to flash the nougat firmware including the modem on here, two different guides exist one for pure and one for style search them out

I think this is the link for pure

https://xdaforums.com/moto-x-style/general/xt1575-moto-x-pure-edition-factory-t3704142
[X Style (Pure) Android Development] Positron543:
Hi, the word Thank you is not enough to thank your hard work. But I'd like to say that image capture through camera doesn't work as you said. And there is no Google assistant? Is this a bug?
[X Style (Pure) Android Development] randomblame:
Did you install Google apps? That has nothing to do with the rom itself :)
[X Style (Pure) Android Development] randomblame:
Panorama works in snap you can take a single frame image that way, Snapchat was confirmed working for image capture as well but I don't know if anything else has been tested. Another method is to screenshot the preview in an app like open camera with GUI off
[X Style (Pure) Android Development] moviefirst:
Yes, I can can capture and save image and video on Snapchat. The quality isn't perfect but.......oke for now.

I am using the latest ROM as my daily driver. Internet,Whatsapp, Viber, calling, YouTube, snap, audio, all is fine for me. Only a little bit lag and keeping apps in memory issues. I am happy with it for now, I am sure in the long run it will probably only get better thanks to randomblame,???
[X Style (Pure) Android Development] randomblame:
I might throw together a camera app that bypasses our issue
[X Style (Pure) Android Development] moviefirst:
It's strange that Snapchat can capture and save image and video. Yes, maybe a camera app would be the solution for our issue.

*** cannot take picture with Whatsapp and Viber, video calling is working on Whatsapp.
[X Style (Pure) Android Development] randomblame:
I was thinking something basic and hacky full screen preview swipe to switch front vs back tap for screenshot copied and renamed to the right folder and long press for record but then the resolution of photos would be limited to the screen resolution

I'll research maybe there is a better way
[X Style (Pure) Android Development] randomblame:
I had image capture sort of working through front camera months ago ugh I need to double check paths in these blobs I'll be really ticked off if it's broken because I vendorized another hardcoded path

For instance it Looks like the camera firmware files like cpp_firmware_v1_1_1.fw were all moved to /system/vendor by hash in Oreo but they were originally in /system/etc and whatever is calling them is likely hardcoded in a blob. Treble=trouble
[X Style (Pure) Android Development] Itz_GoodPlayer:
Telegram X also work.
[X Style (Pure) Android Development] kerdiaz:
Hello,

I'm impress with your work and I must say Thanks. The camera and the flashlight is stable?

Another thing, it's I'm in the original ROM and I wan't backup how i do that? Sorry It's my first time making a ROM Backup.
[X Style (Pure) Android Development] Itz_GoodPlayer:
Please! Can someone make a Kernel for the ROM with Overclocking Capabilities?
[X Style (Pure) Android Development] randomblame:
It's low on my list of priorities but maybe
[X Style (Pure) Android Development] Itz_GoodPlayer:
Thanks anyway :D
[X Style (Pure) Android Development] randomblame:
Save your personal files and go for it there are numerous copies of the stock firmware online that can be flashed via fastboot. Be sure you upgrade from nougat or flash the nougat modem first. Flashlight works camera has issues described in the op
[X Style (Pure) Android Development] :
I cant wait to try it out!
[X Style (Pure) Android Development] Kasha05:
okay so i flashed the official stock nougat7.0 rom on my xt1572, and even after doing that, when i flashed your android pie rom it shows the same problem!, it doesn't detect my sim cards and keeps on powering off ,the pie launcher keeps crashing but that's no big deal.

i don't understand what the problem is, now that i flashed the nougat stock firmware it means that i have the nougat modem and firmware right? so what should i do now to achieve a stable state for this rom?

i have an asain_clark_xt1572. and everything worked fine on android 7! please guide me how to do this properly, what am i missing??

baseband: M8992_1255331.29.01.08.09R CLARK_EMEA_DSDS_CUST

[IMG="about phone"]file:///C:/Users/Akash/Pictures/Screenshot_20190216-110647_Settings.png[/IMG]
[X Style (Pure) Android Development] randomblame:
Go through the steps to flash the factory nougat firmware again via fastboot make sure you flash the modem twice as instructed it seems to always fail the first time check the text output of the commands make sure it is succeeding. After that boot into stock nougat check that radio is working then wipe and flash
[X Style (Pure) Android Development] Kasha05:
Yes i did flash the firmware correctly through fastboot, i did flash the modem twice and yes i did check all the files successfully flashed! even the radio was working yet still it isn't stable! i wiped the cache and dalvik after and before i flashed pie, can it be that it is because i have an Asian retail??i really dont know what to do please help
[X Style (Pure) Android Development] randomblame:
Did you only wipe cache or did you wipe everything including data? Is this a dual SIM variant?
[X Style (Pure) Android Development] Kasha05:
i wiped cache ,dalvik and data after i flashed it this time! but i'v previously wiped just cache and dalvik even then its the same result! yes it is a dual sim variant. it's been 2 days now i cannot figure out the proper way! i really want to make this work, help me people as soon as possible
[X Style (Pure) Android Development] Marco275:
Hello, I have an eu Style 1572 from which I wrecked the ability to make calls in the *#*#4636#*#* menu.:silly: I only have data connection. Will flashing this rom solve that problem or will it keep the old modem fimware alone? Assuming the modem firmware is to blame.
[X Style (Pure) Android Development] moviefirst:
Try it.

* I also have a EU Style XT 1572, no problems for me*
[X Style (Pure) Android Development] randomblame:
I have a 1572 and a 1575 but I don't have the dual sim version. Could you pull a bug report if possible and describe the actual problem as well as you can. Are you flashing from TWRP? Which version of TWRP? Can you try wiping everything including system, remove the sd card and then flash the rom only no Google apps and tell me how that works. Try booting without any sim cards then with one at a time also please
[X Style (Pure) Android Development] kb8no:
[MENTION=1776875]randomblame[/MENTION] WiFi tether works and you can set both AP name and password but reboots when you try to shut it off so it is still a little schizo. Barcode scanner doesn't focus. 2/13 build seems to recognize purchased apps now. Neflix installs and opens but then does nothing. I'm starting to use 2/13 build as a regular.
[X Style (Pure) Android Development] randomblame:
hadn't tested netflix yet thanks for the info, I didn't have a problem with wifi tether I'll retest
[X Style (Pure) Android Development] randomblame:
libsepol.check_assertions: 541 neverallow failures occurred

this is frustrating at least none of them are coming from *our* sepolicy just inherited policies. Trying to get selinux into enforcing mode, user builds are gonna be a while though
[X Style (Pure) Android Development] kb8no:
[MENTION=1776875]randomblame[/MENTION] You are a good teacher. "Just for giggles" as you say, in a few words and for educational purposes, could you explain how you got what's functional in the camera to work and what battles you are fighting to get the camera working and preventing a photo from being saved and the app crashing? This is all so mysterious and would be a lot more fun if you have a better idea what's going on. I'm sure it is a good read and I hope you don't mind.
[X Style (Pure) Android Development] randomblame:
You can review the commit history on GitHub it's linked in the op it's a great way to see with your own eyes changes that have been made but it's incomplete in that I only push changes that work 99.9% of what I have tried has been experiments that didn't make the cut. What fixed the camera was a combination of changes. I'll list camera specific things I can Remember off the top of my head

Binder in pie no longer allows binaries to close already destroyed mutexes and our camera bins did that so needed whitelisted

Pie limits permissions of vendor provided scripts and binaries to certain locations and requires paths are changed to /data/vendor and they need to operate from system/vendor at least in theory so I moved them renamed them and hexedited them to behave appropriately - this is best practice but not 100% nessecary

Rather than use the old camera wrapper I am using the oss camera Hal that hash began work on. I made several changes here because the camera service starts earlier than in nougat and the kernel did not have time to initialize and read the sensor eeprom data for calibration. I also experimentally included the old rear sensor lib that hash had missed in his attempts to bring the camera up which turned out to be nessecary and was being called and silently failing.

I attempted a zillion other fixes from new kernel camera drivers to the 3.18 kernel I started work on and trying to get the old camera wrapper to work but these were what ultimately lead to the fix. Last night I worked on our selinux policy and did some device tree cleanup and currently I am working in Android studio playing with the idea of an app to cheatily capture images. If I stare at a problem from one direction for too long I get discouraged and bored so I tend to circle issues and keep busy. I'm also uploading a new build that I'll link in op shortly - edit 2/18 build is up now

I'm think that in apps like Snapchat where the camera is able to take photos they do so by capturing an image through the preview stream I have found an old example of code to capture raw images directly but haven't managed to get it to compile yet to test.
[X Style (Pure) Android Development] kb8no:
2/18 build fails error 7.
[X Style (Pure) Android Development] randomblame:
Are you failing the bootloader assert?
[X Style (Pure) Android Development] kb8no:
"patching system image unconditionally" Then:

E1001: Failed to update system image.

Then red: updater process ended with Error 7

Error installingt zip file ...

tried it twice, came error same place
[X Style (Pure) Android Development] randomblame:
Weird maybe it's a bad upload I tested it here
[X Style (Pure) Android Development] kb8no:
corrupted download. Booting now.

Edit. This build boots but does not recognize SIM card. Anybody get it to successfully install?
[X Style (Pure) Android Development] randomblame:
that's what I get for not testing with a sim card in. I'll fix it and push another build

OK new build up now tested and working
[X Style (Pure) Android Development] kb8no:
Anything specific you want us to look for or comment on?
[X Style (Pure) Android Development] randomblame:
not really just let me know if there are regressions
[X Style (Pure) Android Development] randomblame:
https://github.com/jeremymcrhat/Nexus_5X_kernel

super interesting I still haven't completely given up hope of a new kernel at least 3.18 is debugable and theoretically fixable

I got slightly inspired and compiled 3.18 again tonight on the notebook here's the output https://pastebin.com/SEpXpssy
[X Style (Pure) Android Development] randomblame:
I'm going to be setting up a new build system this week, the notebook is convenient but not enough oomph. I'll move the desktop and stripe some ssds so I don't have to deal with running out of storage. Running into weirdness without clean builds
[X Style (Pure) Android Development] ResistanceIsFutile:
If your interested-

Amazon has a daily deal today, SanDisk 480GB SSD Plus 2.5" Serial ATA 6Gb/s Internal SSD for $69.99 with free shipping. (SDSSDA-480G-G26)

B&H Photo Video charges the same price.

Anorther Amazon deal for today only is-

SanDisk Ultra II Solid State Drive 1TB (SDSSDHII-1T00-G25) for $149.99 & free shipping.

Desktops up to $400 Off!

This weekend only, take an additional 14% off any Inspiron or XPS desktop at the Dell Outlet, including the Inspiron 5680 Gaming desktop! Limit 1 per customer, while supplies last. Free shipping & same as new warranty included.

Coupon code: 14INXPScw115
[X Style (Pure) Android Development] randomblame:
Yeah I've got a haswell i7 system the kids stole but today I steal it back lol don't have the scratch for another drive this month but the magic of raid should get me a big enough fast enough partition for now.
[X Style (Pure) Android Development] ResistanceIsFutile:
Will we be red rockers ?

Bout a month away is Black Friday - Cyber Monday for deals too.

Possibly way before then you'll have something out for us to use ???

Good luck, karma and success...as always !

PS: I can't drive 55...
[X Style (Pure) Android Development] randomblame:
got the desktop set up and I'm pulling down repos now. I found a 500gb ssd I wasn't using too lol so now I'm set. really like this 27in qhd monitor in portrait mode bedside. so much better than the 15in 720p notebook
[X Style (Pure) Android Development] ResistanceIsFutile:
Just have to keep the kids occupied with something elsewhere then where your working.

Great sounds like your set to dig in deep waters. Hope it's smooooth sailing.
[X Style (Pure) Android Development] randomblame:
[IMG="fresh build of oreo running well"]https://pbs.twimg.com/media/DqejPq9WoAEfcc0.jpg:large[/IMG]
[X Style (Pure) Android Development] Aluminium X:
Wow, you made LineageOS 15.1 run on the Moto X Style in just 11 days? That's amazing!

Turns out you didn't need to update the kernel to 3.18. That's good.

What modem is the ROM using, Marshmallow or Nougat?
[X Style (Pure) Android Development] randomblame:
it was already running with hashbangs work, device tree needed some fixes from a few months worth of upstream changes tho and it's running the kernel with fixes for pie. Was trying to figure out a few things so I built oreo to test some theories.
[X Style (Pure) Android Development] randomblame:
my phones on bootloader 0xA0048 currently I'll worry about other stuff when I get to it kernel is unnecessary just something I thought might be fun in the future

lineage 15.1 10/26 test only if anyone really wants it. kernel uses source linked in op branch 16.0 of my github for gpl camera does not function marshmallow firmware based.

https://filehost.net/ec586286b3fe2867
[X Style (Pure) Android Development] randomblame:
sort of got hung up on playing with 3.18 kernel today. I made a lot of progress. Not only does it build but it runs (panics) and I have logs to work with :D logs here if anyone is interested https://pastebin.com/anvAceiT

[ 0.000000,0] Initializing cgroup subsys cpuset

[ 0.000000,0] Initializing cgroup subsys cpu

[ 0.000000,0] Initializing cgroup subsys cpuacct

[ 0.000000,0] Linux version 3.18.71-LineageOS-g4d1dbeaf6b28-dirty (kelsi@Portrait) (gcc version 4.9.x 20150123 (prerelease) (GCC) ) #4 SMP PREEMPT Sat Oct 27 19:24:39 PDT 2018

[ 0.000000,0] Boot CPU: AArch64 Processor [410fd033]

[ 0.000000,0] Machine: clark

nothing like a shiny new kernel to debug to steal my attention. I went from zero to logs on it in less than a day gotta be a new record
[X Style (Pure) Android Development] randomblame:
I'll switch to nougat firmware and build for it later I'd rather get past the current issues with a known and stable setup
[X Style (Pure) Android Development] randomblame:
Anyhoo 3.18 is being problematic. Memory and a single core are online but the method of hot plugging CPUs and managing them needs to be fixed otherwise it's single core only. Spmi interface to lcd is broken but fixable as well. The CPU hotplugging feature is the biggest issue, I had hoped it would still be mostly intact in this code even mainline 4.19 supports this SOC in the same single core configuration
[X Style (Pure) Android Development] xabr3:
Keep up the good work. Would be nice to see Android Pie on our devices. :)
[X Style (Pure) Android Development] Az Biker:
* * * Thread Cleaned * * *

Let's knock off the back and forth, insults, and off-topic.

If your comment isn't helpful, respectful, or directly related to the DEVELOPMENT of this work, please don't post anything at all.

This is a courtesy warning to get the comments back on track and only about development.

If you advice isn't being taken here, move along. If you don't want to deal with a certain member, utilize the ignore function. Either way, please do not take it out in the development thread, not only is it a violation of Forum Rules, its a bad look for all involved.

Thank you for your cooperation.
[X Style (Pure) Android Development] randomblame:
back on los16 - cleaned up device tree a lot getting further, msm_rng is not working correctly, this is causing gatekeeper service to stop basically it's calling the kernel to generate a random number for security and the process is failing

[ 124.798087,3] init: starting service 'gatekeeperd'...

[ 124.800819,1] msm_rng:Data not available!

[ 124.949789,3] init: Untracked pid 15347 exited with status 0

[ 124.951038,3] init: Untracked pid 15354 exited with status 0

[ 124.951516,3] init: Service 'gatekeeperd' (pid 15212) received signal 6
[X Style (Pure) Android Development] randomblame:
Last thing preventing boot is now the broken gatekeeperd /keystore. It completes the rest of the process

More progress

Made it to the setup screen for a second crashed and rebooted after I skipped through it.

I flashed nougat modem and bootloader my 15.1 builds run on it
[X Style (Pure) Android Development] randomblame:
Its aliiiiveeeee!

so far it loads to a useable interface

wifi + bt +ril + nfc broken as expected

sound works

usb and sdcard functional

camera just as broken as before, sensor works for a moment flashes and attempts to capture an image and crashes
[X Style (Pure) Android Development] frank0312:
YES!!! Some good progress!!! Keep up the good work!:good:
[X Style (Pure) Android Development] xabr3:
I hope you get the camera fixed with image capture a full resolution 21mp. Good luck. :)
[X Style (Pure) Android Development] collinschen02:
Is privacy guard in the build ?
[X Style (Pure) Android Development] randomblame:
yes