yashsingh1/xdaforums huggingface dataset:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
1. This is a bit strange since I did this rom withouth SIM and never seen that toast (just the icon in status bar as you say)... could you send a screenshot?

2. About inmersive mode, what is really? You can hide navigation bar for some apps. If I remember well LG hasn't inbuilt inmersive mode tile for quicksettings

Well this toast maybe is harder to remove because I think it could be located in a google app instead of lg. And althoug is annoying, I find most of the times accepting high precision mode for location (and giving to google all my movements :rolleyes: ) Anyway I will take a look and if easy to locate and remove I will do :good:

Good finding!

I left NOTCH because with NORMAL you disable the notch setting system-wide, including the new second screen setting. And I think with it is somewhat different and more like a "real" G7 haha :cool:

About Lcom/lge/internal/R$bool I suggest not modifying as you did. These variables (Lcom/lge/internal) are located in lge-res.apk/res/values. I suggest to mod them there (easiar and will take less time). This one specifically at least with NOTCH option do nothing putting it to false ;)
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Ok here we go again, try flashing this again and check if finally is solved :good:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Yes it is. Great work Astrako !!

No more warmstarts on earplug in/out, HiFi DAC simply works as intended.

Thank you for this immediate update !!
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
I'm glad to read that ;) I will add this bug with its fix in OP and will be included in the next update.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
perfect, thanks a lot !
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Thanks to you for reporting. So all settings are working properly? DTS? equalizer option?
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Equalizer in LG Music App and Foobar2000 (DSP Manager) is working flawless. Cannot find the DTS setting., where is it located ? Did i have to install the DTS feature during Installation (i didn't select anything during H-ROM installation)
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
Thank you for the explaination, I'm generally too lazy to do something "clean": once it works, it's ok:laugh: Your solution seems to be much better:good:. There was an user asking for a notch simulation, maybe if we find where is that mask that is enabled in lge-res.apk, it would be possible to create a fake aesthetic notch.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
No, is not an installation procedure.

Add this line to your build.prop and reboot and this will enable the Hi-Fi mode in quicksettings (useful only having the external DAC)

persist.audio.hifi_dac=OFF

Then you can go to advanced audio settings there. Check if can and tell us the result.:good:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
I'll try. Please, give me some time, as i'm not used in modifying system internals ...

---------- Post added at 12:09 PM ---------- Previous post was at 11:58 AM ----------

Cannot store the modification. How can i remove the write protection from build.prop ?
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] askermk2000:
You need to mount system partition in R/W mode, right now it's in read-only mode. The file manager app you use must be able to do that.

I recommend MiXplorer, though there are many, root explorer etc...
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
You shoud use an editor that supports root acces, like Root Explorer. If you're already using an editor that can access in root mode, try to open Magisk Manager and see (in Superuser tab) if the root acces has been granted for that application.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Psdragon:
if it´s possible to achieve that notch simulation it would be great!

I know it's just a detail but it would be more like the lg g7.

this rom is already perfect but...
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Thank you ! Modification worked with Total Commander with Superuser Rights and system re-mount, however i restarted the phone (DAC still connected) and it doesn't start properly (just LED is blinking blue). i have to investigate further ...
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] ezzony:
Screenshot attached. I wonder if this has something to do with my sim problem, i'm still hoping its software before I open it up to see if I see problem with contacts.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Don't get it to run :( tried with and without ext. DAC, same behaviour. After startup (first i can see the LG Logo, then screen stays dark and blue LED is flashing). So i restored my H-ROM backup i made before with TWRP and now it boots properly, however I'm stuck in the unlock screen, because my PIN is not accepted anymore ? Any help would be much appreciated.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
It's a common issue if you restore a backup with a different pin/pattern set. Reboot in TWRP, go to Advanced>File Manager, reach the folder /data/system and delete these files:

password.key

pattern.key

locksettings.db

locksettings.db-shm

locksettings.db-wal

You can now reboot and set the pin again.

The full guide is here: remove-lockscreen-recovery
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Yeah, it's back to life:laugh: Thank you, [MENTION=9336951]tremalnaik[/MENTION] !
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] ezzony:
Well done Astrako - soft reboots are gone!

So after fix there is some software changes. No more can you see G7 settings for dac which were accessible through LG Music app. On stock G5 these were accessible in the Settings>Sound menu.

By inserting build.prob edit to persist.hifi_dac = OFF or ON then this will make visible the hifi icon in the LG Music app and also in the quick settings panel. However clicking on either of those does nothing except a toast notification saying to connect headphones even when headphones are connected. So basically adding this is currently pointless.

This is not a big deal imo. The g5 only had balance control for the dac anyway which can be done in most music apps. So as far as I can see from small time usage what you get is same as stock G5 just without balance control so as it is it's perfectly usable. If Astrako wishes to spend time brining back balance control would be nice but not particularly vital, for me anyway. I don't think the G7 equalizer controls and DTX:3 (whatever that is, some sound effect I suppose) would work anyway even if you could see them in the settings because as I said before the G5 dac doesn't not have this capability because it's not built into the G5 dac chip.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
I gave the "persist.hifi_dac = OFF" modification in build.prop a second shot. This time all went well :)

I can confirm what [MENTION=4721914]ezzony[/MENTION] is saying: "hifi icon" in the LG Music app is visible, but doing nothing except asking for connecting a headphone.

However, i concur to ezzony, that this no big deal at all. I don't need it and [MENTION=6917540]Astrako[/MENTION] may want to spend his valuable time with other topics.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Ok guys, I don't understand well the behaviour there with DAC.

Here

without

DAC, with that build.prop line I can go to this screen

keep pushing quicksetting hi-fi

tile with a jack connected to audio jack output. Also, I can even enable DAC option, but this disable any music. The rest of settings don't work except volume slider. My question is, can you get this settings screen aswell with DAC?

EDIT: btw you can also add any or all these build.prop lines and check if something change for you:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
I can confirm that when I remove SIM card I also get that notification. Sorry but I understood bad. You really don't get a toast or popup but a notification like me. I would say that is a slot problem there :(
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
I stand corrected:

Yes , i can get this setting screen. With and without DAC attached, i'm getting the screen while keep pushing quicksetting hi-fi tile with a jack connected to audio jack output. And Sound goes off once Setting Hifi Quad Dac is activated.

Will test your proposed additional setting in a couple of minutes ...

Added all

persist.audio.dmb_hifidac=false

persist.audio.hifi_adv_support=1

persist.audio.dual_audio=ON

persist.audio.hifi_dac=OFF

ro.config.hifi_enhance_support=1

persist.lge.hifiquaddac=true

to build.prop and rebootet, but the behaviour is the still unchanged.

Btw. i'm on the Mk2000 Kernel (for sd card compatibility), what about you [MENTION=6917540]Astrako[/MENTION] and [MENTION=4721914]ezzony[/MENTION] ?

---------- Post added at 05:29 PM ---------- Previous post was at 04:42 PM ----------
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
I made a first try to emulate the notch, but it seems to be working just in LG's applications in portrait mode. Give it a look and see if you like the shape of the notch (should be almost the same of the original G7).

To enable it, unpack the zip, reboot in TWRP and copy the files to their respective folders, then reboot and go to New Second Screen setting. Choose "Custom" and select the fourth colour combination (purple/red).

Be sure to set the same background for home and lockscreen. If you don't like it, set "Standard" instead of "Custom" to revert to full screen.

The files are here: MEGA
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
But you get to the HiFi Setting screen only, if the earplug is put into the standard phone plug on the top. If you connect it to the HiFi DAC Module you cannot activate the setting screen.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] ezzony:
After your latest fix this screen will not appear. It did appear before the fix but it did not work for example enable 32bit to on would turn off all music even with when using the DAC, I don't know about normal jack output, shouldn't do anything anyway.

The perfect situation would be to have the G5 stock audio settings appear as it does on Nougat or Oreo stock G5 rom, and not the G7 audio settings screen. G5 does not have the options you can see in the screenshot you attacted, they are for G7 only. Hope that explains clearly.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
At least i can get to this screen if the earphone is plugged into the standard jack on the phone top and not into the DAC jack.

However, this does not make much difference in the end, as the settings do not work. :cyclops:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] ezzony:
Exactly, so this settings screen is redundant. Android never had a system wide equalizer that works across all music apps. That is why you have things like Viper4android etc that one can simply install through Magisk easily, and is in fact very good. V4A does not work with the G5 DAC as it's 32bit but it does with with built in headfone out. JamesDSP which is similar does work with the G5 dac. Dolby4Atoms did work on Nought but don't work on Oreo but prolly will in the future when developers get round to it porting it.

---------- Post added at 05:27 PM ---------- Previous post was at 05:23 PM ----------

I am going to totally re flash using stock KDZ in case something went wrong or I did something wrong to cause this problem. Better to be certain it's not software first before I take out the screwdriver!
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Psdragon:
lot of thanks dude its a big step forward but its not perfect yet.but as you said it was your first try.i like the shape and size of the notch, perfect is the word, but it would be cool if we could use it in all apps.i think notch can be hide only in lg´s apps on g7 and ...here we can only use it in lg´s apps.but it´s a great great effort.i´m glad you took the challenge....
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Wow, very good mate :good::good::good::good: I thought to do it with a new layout in statusbar, but you did easier ;)

See the G5 with a notch and that huge bezel is a bit strange :p

I will add it to OP with your permission! ;)
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
It works only on LG app because it works by replacing one of the notch masks used to hide the notch on thw G7, but here it creates the notch instead of hiding it.

Of course you have my permission:laugh:

In fact creating a new layout would be the right way to do it, but I don't have any idea of how to do it:confused:

I just replaced one of the masks that now simulates both the notch and the round corners.

If I am right, the LG interface "moves around" the notch masking the upper part of the phone with both geometrical objects and raster overlays, it's really complex.

Adapting the notch to the G5 is quite an hard job:eek:

I don't like it too, the bezel and notch together make no sense, especially without an OLED screen, but it would be nice to give the chanche to choose to have it or not.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Psdragon:
ohhh come on!am i the only one here that likes the notch thing?i told once that you can do it and you did it.so..... why not trying to port the most as possible?and the notch is there... accept the chalenge as [MENTION=9336951]tremalnaik[/MENTION] did.this rom is the best so... be proud don,t stop!thanks
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] ezzony:
I should have posted this earlier since I know you don't have G5 dac. The attached screenshot is what the audio settings look like on G5 STOCK , as you can see it's different and more limited as what we see on G7 port.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] comesefosseantani:
After one day I can already say this rom is fantastic!! :) super fast and battery life is really really good! I just had to use mk2000 kernel because of the sd card corrupted problem.

Thank you again for the great work!

Ps. Maybe a silly question. I disabled the option to show the apps icons with the border, but google apps still have it. While other apps don't. Not a problem but I don't understand why.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] grzanek94:
Well... i've just installed this rom and it's seems to be very responsive and fast. But... for me the icon on the status bar are bit to large ? i've change dpi but icon still stays little bit too large
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
I have a couple of questions that I hope will be easy to answer:

1) Is the HiFi external module needed for HiFi recording in the HiFi recorder app and in the camera?

2) I saw that this screen recorder (com.kymcy929.screenrecorder) can record the screen at full resolution in HEVC without lags. The codec used to encode, as far as I can see, is not in the app, so it should already be on the phone. Is it possible to enable HEVC in the LG camera or in other camera apps?
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
1. No idea. I don't know the reason but thinking that HiFi recorder app alone works fine and controls also seems to work, I guess this could work too in camera app, but sincerely I don't know now. This requires a lot of time to studiying code from camera. I think is not related with HiFi module.

2. Yes, I think is supported (I saw a reference to it in libOmxVenc.so) but I don't know if could work for example with camera app. I leave attached here media_profiles and media_codecs files from G7. Now I haven't time to compare them and test in our phone but if you want you can try. I suggest to compare with G5 using winmerge or similar. :good: If need some help tell me.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
Thank you, I already tried enabling HEVC by adding the codec in the list of codecs available for recording in FullHD and higher resolutions, but without effect. Probably because I only edited the files in /system/etc/ and not those in /vendor/etc (do they have some priority over their /system/ versions?). I'll try to find if I can enable the HEVC!

Do the HiFi recorder controls work on your phone? On mine it records just from the microfone on the bottom and the controls do not work, just like a standard recorder. The only thing that I deleted from the system before flashing your ROM was the /cust folder (to remove bloatware and nterror, I don't care about loosing VoLTE), may this be tha cause?
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
1. I briefly checked the HiFi Recorder App with and without DAC and it makes no difference. Either way recording appears to be mono only. Recording format selection e.g. flac works fine. Manual controls appear to have no effect.

2. I activated the H265 code in my google cam app. The App accepted the setting and recording works fine. However looking at the codec info in MX Mediaplayer shows h264.

Don't know if this info is of any help for you?
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
They are different really since G5 hasn't vendor partition and in G7 LG moved a lot of files to there. Try also changing there to see if has some effect. I dont know really which has priority (I guess vendor files in vendor partition).

About hifi recorder well didnt test much.... Just recorded some audio files and to me seemed that work but now I tried again and well... Really controls dont work. Just record as is, isn't it? Maybe G7 (and V30, V20, etc) has some kind of dedicated microphone for this. Sorry but is not something where I have spent much time researching for improving. :confused:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] askermk2000:
I know V20 has a special/good microphone for this.

The mention of hifi-recording in conjunction with G5 made me search for this, and can't say I found

any mention of G5 having so called "hifi-recording". And to be sure I checked my phone and... nothing.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
Don't worry, you already did a lot of work!

The G5 has a second microphone too, used mainy for noise reduction during calls.

Thank you, this is very helpful! So it means that probably is just something missing from the phone, hopefully from the software and not from the hardware.

For the H265 I had similar problems with other camera softwares, the codec seemed to be active and could be selected, but MediaInfo shows that is just a regular H264 file. I'll try to fix the problem (it shouldn't be too hard, as the Qualcomm encoder works in other apps).
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Yep, the 2nd Micro is also used in the original LG camera app and the resulting videos provide good stereo sound.

I also would be interrested in using the H265 codec. Please let us know, when you managed to get it work.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
I forgot to answer to this. During rom installation /cust content is deleted to avoid problems, so everybody that install this rom has /cust empty :p
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] tremalnaik:
Ok, so that was not the cause. Meanwhile I tried to look at the media_files you sent, and I tried to edit the ones in H-ROM adding HEVC codec, but without success, like if the camera doesn't care if I set the file to use only HEVC for 4K movies.

I tried then to install a Magisk module to enable HEVC on OnePlus phones and I got one step further: LG Camera crashes, but OpenCamera now uses HEVC.
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Is one good step. Check and share log of camera crash to see what happen. Maybe is easy to fix :good:

EDIT: what is that Magisk module?

EDITED2: this module modifys media_profiles, but according with OnePlus camera. I suggest to extract it and compare with G5. I have seen it and notice how is in this file:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] kimaro:
Hi guys.

I have a little problem installing this rom.

Short history (long is at the bottom): Stuck in twrp bootloop. Installed with no error aparently but when I reboot I get the trwp screen again... I´ve reinstalled several times with no luck...

Long history:

In my first try I installed succesfully, boot the first time into android with no problem but I wanted to format internal memory... Too many garbage, uninstalled apps folders... etc so I did a factory reset in settings menu.

It rebooted in twrp recovery mode and all the issues started... I could not boot into android again.

Next time I tried whole process I had to format data in twrp because I couldnt wipe anything (unable to find crypto footer). After formatting data I could wipe again but still in twrp bootloop.

I started all over again, wipes, flash bootloader, flash rom, reboot system and got to twrp again...

Now I have a "Keep System Read only? twrp screen.

I have tried both options: Keep read Only or Swipe to Allow modifications but no luck

Any ideas? :crying:

Thanks in advance guys!
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Yes, update TWRP: https://dl.twrp.me/h850/
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Ok guys, I have modded finally the UI for disabling those annoying dialog when clicking in data, airplane and sync. I will include in next update, but until now you can flash the attached zip to use it now :) GPS button behaviour is different since dialog comes from Google Services I think, but sure not from LGSystemUI so, as said this is harder to remove and for now I don't know how to do it (and I have tested some things but no result) :good:

Also I changed some code for Hi-Fi button.... could those with external DAC check it too? [MENTION=4191060]speedyburnzales[/MENTION] [MENTION=4721914]ezzony[/MENTION]
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] kimaro:
Te quiero tío! [emoji28] Estaba a punto de tirarlo por la ventana!! [emoji23][emoji23][emoji23]

It worked! Thank you so much!

Is there any reason it worked the first time but failed the rest? DRM or some security related?

Anyway, it seems to be working now. Thanks again

Enviado desde mi SM-T580 mediante Tapatalk
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Did a quick check.

Pop-Ups are removed :svetius::good::good:

HiFi Button works like before w/wo DAC, cannot see any difference in behaviour. What did you intend to change ?
​
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] Astrako:
Well I tried that you were able to enable Hi-Fi mode pushing quicksettings button, but with DAC connected for you still is disabled.

Anyway I am thinking on buying the Hi-Fi module.... only have to find it cheap as second hand :laugh: then I could support it better. How is battery with Hi-Fi module? does it drain much? :good:
[LG G5 ROMs, Kernels, Recoveries, & Other Developme] speedyburnzales:
Yes it does. Thats the price you have to pay for the better sound, however i'm still very pleased with the DAC. :):)

B.t.w you don't have the DAC permanentely connected to the device. It's also working flawlessly when connected via USB-C cable, e.g. on demand. That way i enjoy music at home with my headphones.