[Samsung Galaxy S 5 Unified Development] curiousrom:
Magisk 18.0 & Magisk Manager 6.1.0 - No Update Button w/ Display Large

Edit 2: Thanks to the posts by [MENTION=6928202]KazuDante[/MENTION] and [MENTION=3626968]cOOk!e[/MENTION] in the next page I've concluded that the problem described below was related to my setting: > Display > Advanced > Display size set to Large.

I don't know yet if it's the app or LineageOS 16.0 build 2018-12-03 that is not doing the scaling properly but anyway the workaround is to set Display size to Default before using Magisk Manager 6.1.0 to update Magisk.

***

[MENTION=4470081]topjohnwu[/MENTION] - I noticed that the Magisk v17.3 thread was renamed to [2018.12.8] Magisk v18.0 - Root & Universal Systemless Interface [Android 5.0+] so fired up Magisk Manager 6.0.1 which offered & successfully updated to Magisk Manager v6.1.0 then it offered to update Magisk v17.3 to Magisk v18.0 but the popup only offers either No Thanks or Release Notes.

Tapping Release Notes shows the notes but after closing it returns to No Thanks or Release Notes without any option to install.

Tapping randomly on different areas in the popup found out that in the bottom right it opened the install options popup & I finally updated to Magisk v18.0.

Attaching screenshots of Magisk Manager 6.1.0 > Update > No Thanks or Release Notes > tap bottom right & successful update.

View attachment 4660899

Edit: [MENTION=2218776]stiltzkin[/MENTION] - Maybe you would have better luck with that new Magisk 18.0 version?

***

Brightness Scale

Thanks :good: for the report.

It's good practice to read the last 2-3 pages to get up to speed before posting IMO as [MENTION=8031265]kurtn[/MENTION] & I discussed this 2 pages back. He thinks it's a feature & I a bug. ;)

Added a link to your post in Report: Bugs & Semi Clean Install S5 klte 16.0 Unofficial Build 2018-12-03 where you can find other small bugs & stuff not working @ the present in haggertk's excellent build 2018-12-03.

***

Google Pay Not Working

Thanks :good: for the report. Added to the Bug post linked above: 12. Google Pay NFC point-of-sale is not working with link to your post.

I cannot test Google Pay NFC point-of-sale payment as it is not available yet in Costa Rica. List of countries w/ Google Pay here.

Could you edit your post & include your S5's model number please? :cool:

I tested file transfers both ways with NFC enabled via > Share > Android Beam between S5 G900M 16.0 & S3 i9300 LineageOS 14.1 & it works. Can you test your NFC also to rule out that possible reason why Google Pay does not work for you?

You could also look in logcat for errors after trying to make a payment.

*****

Charging & Boot?

I'm not sure I understand. Are you saying with the battery discharged, phone turned off & connected to a charger if you press the power button it re-starts the charging process & does not boot to System? If so that's exactly what my S3 i9300 running official LineageOS 14.1 does. I thought is was normal.

Edit: - I turned off a S5 Mini G800H running stock Samsung 6.0.1, plugged into charger & pressing the Power button it does boot to System so maybe it's a LineageOS quirk.

While in TWRP & connected to a charger my S5 G900M 16.0 klte Unofficial Build 2018-12-03 boots to system without problems. [MENTION=4828250]Ibuprophen[/MENTION] and [MENTION=7978913]fitittome[/MENTION] can you confirm the same on your different S5 models?

***