yashsingh1/xdaforums huggingface dataset:
[Sony Xperia XA Ultra Questions & Answers] Araxielfenix:
Nop, it´s the same thing, Xperia companion didn´t recognize it.
[Sony Xperia XA Ultra Questions & Answers] cqloveqc:
Have you tried this ? " https://support.sonymobile.com/global-en/xperiaxaultra/kb/0231018805656b91c0145c620eeaf004cb9/#gref "
[Sony Xperia XA Ultra Questions & Answers] Araxielfenix:
I tried that but I had the same problema, there´s no pc or laptop that recognize the phone.
[Nexus 6 Q&A, Help & Troubleshooting] thegrim11:
Mod Edit:

Warez, mods, apps, code, links, or discussion on how to by-pass a paid feature on Xda are a violation of Forum Rules, specifically:

6. Do not post or request warez.

If a piece of software requires you to pay to use it, then pay for it. We do not accept warez nor do we permit members to request, post, promote or describe ways in which warez, cracks, serial codes or other means of avoiding payment, can be obtained or used. This is a site of developers, i.e. the sort of people who create such software. When you cheat a software developer, you cheat us as a community.

As in the title, I'm looking for a way to xxxxxxxxxxxxxxxxxxxx. I've seen it before but every Google search leads to a outdated post (2011) or to one that isn't coherent. I found one mentioning a Magisk Module but I don't see that module in my downloads. I'm running the NitrogenOS Pie ROM (Android 9.0). If anyone knows of a method, that would be great.
[Android Q&A, Help & Troubleshooting] elieber16:
LG k10 m320

Android 7.0

I tried everything, but can't root it
[Android Q&A, Help & Troubleshooting] KIBS2173:
TRY THIS

Hi there,

Have you tried kingoroot

www.kingoapp.com
[Android Q&A, Help & Troubleshooting] elieber16:
I tried with it too and other apps but none worked.
[Magisk] Skittles9823:
Hey everyone, i'm Skittles. You may have seen me around here on a few other threads. I've been apart of the development community as more of a support member for certain projects like ARISE (now deceased) and Lawnchair Launcher, over the past year I've switched sides to development. since then, I've been learning the ins and outs of shell scripting and am teaching myself Python, i'm still not too experienced, but for basic development it works well and especially for Magisk modules.

So. with an influx of way too simple (or just flat out broken and untested) modules flooding the Magisk repo, I decided to make this thread as a call to action and a place for more experienced developers to help out the less experienced guys trying to make modules.

In the second post you'll see my little list of useful resources and tools to get started with making your own Magisk mods.

So I encourage all you new module creators to take note of the resources and use this thread if you get stuck or have any questions regarding module development.
[Magisk] Skittles9823:
Templates:

Magisk Template

The default template provided by Topjohnwu

GitHub

Unity Template

A custom template provided by zackptg5 and ahrion, allows one zip to work for multiple devices and root solutions, aswell as ramdisk patching and more

GitHub | XDA

Magisk Module Template - Extented

A template with all the goodies from Unity, but it only supports magisk installations.

GitHub | XDA

Terminal Binary Template

A template for creating binaries to be used in the Android terminal by veez21

GitHub

Tutorials:

Volume Keys

A tutorial by zackptg5 to use the volume keys in your install script to make choices

XDA Tutorial

Resources:

Shellcheck

Shellcheck is a wonderful resource recommended to me by zackptg5, it allows you to verify your code and check for any mistakes or unused variables, etc

Shellcheck | Shellcheck Wiki
[Magisk] deletescape:
Nice bruh
[Magisk] Skittles9823:
Reserved (Dammit Till)
[Magisk] Jaymin.0.1910:
Hey bro,

I am the developer of 'Battery Life Extender' in the Magisk Repo, and I strongly wish for a single place for highly skilled experienced Magisk module developers and new-comers, and I completely support your efforts, count me in, and let me know if you need any kind of help.

Best regards.
[Magisk] Jaymin.0.1910:
Discussion regarding modules' moderation

Hello to [MENTION=4470081]topjohnwu[/MENTION] and every Magisk module developer,

[MENTION=4470081]topjohnwu[/MENTION] [MENTION=6315410]Skittles9823[/MENTION] [MENTION=4476591]Deic[/MENTION] [MENTION=4667597]Didgeridoohan[/MENTION] [MENTION=5228676]VR25[/MENTION] [MENTION=8918441]OldMid[/MENTION] [MENTION=7296895]veez21[/MENTION] [MENTION=6037748]Zackptg5[/MENTION] [MENTION=4936496]joeyhuab[/MENTION] [MENTION=5357345]ahrion[/MENTION] [MENTION=5124760]yochananmarqos[/MENTION] [MENTION=7187684]ianmacd[/MENTION] [MENTION=4187311]Setialpha[/MENTION] [MENTION=1620550]fOmey[/MENTION] [MENTION=5765352]TechnoSparks[/MENTION]

I would like to invite every Magisk module developer to discuss about moderation of Magisk modules in the Official Repo (inclusion and maintenance) and come to a solution on how to prevent those idiots from entering the Repo who just read through the template instructions and sell any kind of **** in the name of a Magisk module.

If you are a developer and agree to have a discussion here, please quote me back with a link to your module or a list of links to them, so that I know my attempts for user-safety and a better standardized Android modding environment aren't getting wasted away, and once [MENTION=4470081]topjohnwu[/MENTION] is here, I will be sharing my ideas and so should be y'all.

Best regards and cheers,

Jaymin Suthar.
[Magisk] Didgeridoohan:
The repo does need some moderation, and [MENTION=4470081]topjohnwu[/MENTION] have been maintaining that thought as well...

https://twitter.com/topjohnwu/status/1046835383475032064

I'll try to contribute to any discussion that arises...

https://github.com/Magisk-Modules-Repo/MagiskHidePropsConf
[Magisk] joeyhuab:
I'm down to contribute with any discussion regarding moderation! :)

Pixify github
[Magisk] OldMid:
Definitely, I've seen increased interest in some sort of moderation, I'll be looking forward to helping integrate some sort of system.

MidnightCore
[Magisk] yochananmarqos:
Count me in. As the author of the Collection of Magisk Modules v2 thread, it makes it quite tiresome to keep track of all the modules being released with all the garbage and numerous fonts. It's a lot more work to have to examine every module to decide whether it's worth listing or not.

Move Certificates
[Magisk] rowe39401:
I do not know how but I need to add a line to a file in the system.

The file is "system/csc/others.xml" the added line is:

<CscFeature_VoiceCall_ConfigRecording>RecordingAll owed</CscFeature_VoiceCall_ConfigRecording>

the folders have 755 as the permissions and the file is 644

the error I am getting is "- Copying zip to temp directory! This zip is not a Magisk Module!"

Here is my zip

https://drive.google.com/file/d/0B9-J29l3cx94T0szbDVNNEZXcmp5QW5mazhEanc1Tlc5YTE0/view?usp=sharing

can someone help please!!!
[Magisk] yochananmarqos:
Your folder structure is wrong. Remove what's in red. Otherwise it looks like it should work. You can also remove the placeholder file in /system as it's not needed after you place something there.

.
[COLOR="Red"]└── magisk-module-template-17000
└── magisk-module-template-17000[/COLOR]
├── common
│** ├── post-fs-data.sh
│** ├── service.sh
│** └── system.prop
├── config.sh
├── META-INF
│** └── com
│** └── google
│** └── android
│** ├── update-binary
│** └── updater-script
├── module.prop
├── README.md
└── system
├── csc
│** └── others.xml
└── placeholder
[Magisk] topjohnwu:
Moderation would require quite some changes to the current server I've written, and also I need to figure out a way that plays well with GitHub.

Unfortunately I'm currently stuck with tons of schoolwork and couldn't find time to sit down and think through all the details how I'd implement the moderation.

I'll keep you guys informed once I have any updates to share with you!
[Magisk] veez21:
I want in ?

I run a channel in Telegram which detects the module updates and the modules added. And so much stuff were added there, duplicates, practically useless, etc.

Debloater: https://github.com/Magisk-Modules-Repo/terminal_debloater

Systemizer: https://github.com/Magisk-Modules-Repo/terminal_systemizer

Module uninstaller: https://xdaforums.com/showpost.php?p=76140961&postcount=733
[Magisk] Skittles9823:
Glad to see you here John. Yea it would a lot of changes to the server, but if possible I'm sure we all agree it's needed.

Well, you know I'm in already lol.

Terminal Modifications
[Magisk] rowe39401:
It worked thanks!:D:D:D:D :highfive:	the other thing that was wrong "RecordingA ll owed" should have been no spaces "RecordingAllowed"

If anyone wants to make their stock rom note 4 enable call recording in the stock native call app... this works

https://drive.google.com/open?id=1uVhT7iZyuUDRNTRFQGKfZ1vq3KToHyZC

tell me what your paypal.me url is and I'll tip you as soon as I can... you saved my butt... I had spent so long figuratively banging my head against the wall... wasting time

---------- Post added at 11:25 PM ---------- Previous post was at 11:16 PM ----------

Never mind found the link and tipped you! You rock have great night
[Magisk] TechnoSparks:
Greetings! This thread has came to my attention due to my username being mentioned.

However, I am actually out of the loop. Could anyone explain to me what happened? A link in the OP is also dead (I assume the repo has been taken down by the owner.) I am really interested to know this.

Of course, I am also in support of some moderation. Unfortunately, since I do not know the story that sparked this movement, I don't know what to suggest. One thing that I did long for is that, modules that are basically too simple in nature (i.e. font modules) should be separated from main functional modules in the repo. But I am not really confident in my own opinion though, because a simple counter argument could be made about simple modules that override prop entries which on the other hand, I think is fine... ?

Looking forward for anyone to do some story telling
[Magisk] Jaymin.0.1910:
I'm really not a good story-teller, but this movement began because of many modules that are rather pointless or full of bugs (one module recently, that even didn't have an installation script, Oogh……..), I have shared my ideas regarding this in this telegram group, please check that and I'm sure, you would be involved in this. ;)
[Magisk] TechnoSparks:
Thanks. I have joined the Telegram group, and will scroll to the part where it was a discussion in said chat. But first had to go through the countless bot's messages :silly: haha!

Yes, count me in. GitHub link: https://github.com/Magisk-Modules-Repo/ts-binds
[Magisk] Jaymin.0.1910:
Just found busybox-ndk-nolinks, peeking through its update-binary.....

1) Where is file_getprop() defined ??

2) Why did the dev not use $ARCH directly and yet cluttered update-binary with some unmeaningful code ??

3) Where is $root defined ??

I bet now we've gotten one more example as to why moderation is required, that guy didn't even read the template documentations thoroughly to find out there was a $ARCH already defined in the template. Whoever disagrees, raise your hands.

With kind regards.
[Magisk] Didgeridoohan:
That user has simply copied [MENTION=4544860]osm0sis[/MENTION]' code for the architecture detection straight into the Magisk module template. With little to no understanding of what he's actually doing...

I particularly like this part of the readme:

Very little of that script was "created" by the user...
[Magisk] Jaymin.0.1910:
Haha..... Such fraudulent claims! He could have rather removed the symlinking part of osm0sis' script rather than copying from that directly. I think the module should be in the Repo or not (if osm0sis adds no symlinking feature), what would you suggest, should it be taken off ??
[Magisk] Didgeridoohan:
Personally I don't get the point of the module. And claiming that you created something when all you've really done is copy-pasta, is morally questionable... If I'd been a "gate keeper" for the module repo, it would not have passed...
[Magisk] osm0sis:
If anyone had ever once asked me for that feature I would have added it. :rolleyes:

Yeah, please remove it. I'll add a config file for more options via repo installs. The guy would have to wait each time for me to update my module first and then kang my new binaries. It's ridiculous.
[Magisk] Jaymin.0.1910:
The point of the mod might be to allow developers who ship their own copy of BusyBox binary to detect this BusyBox and install it to their target locations, so as to save on maximum space needed by the module, many devs ship a BusyBox binary in their modules, right ?? But of course, I might never know what the dev actually intended it for :eek:

What the dev did, aah that's not just morally questionable, but rather a bad aspect of the developer community, I completely agree with what you said, this module shouldn't have entered the Repo, the first reason being the developers morals, and the other, why would we have a one more module that relies on another to just provide a feature that can be easily adapted into the original with some lines of code ?? He could've rather created a pull request for that to [MENTION=4544860]osm0sis[/MENTION]' Repo and I'm sure he wouldn't ignore that.

Well, that's a real nice of you :laugh:

With all due respect, I wish to humbly know your opinions as to how such gate-keeping strategies should be implemented ??
[Magisk] osm0sis:
I don't know.. I suppose primary fork etiquette basically. i.e. If there's an actively maintained module and the new one hasn't made at least an attempt to contribute their proposed changes back to the original then common sense it should be frowned upon.
[Magisk] VR25:
A rather huge set of issues, all "ejaculated" by dark human ego.

Some people just think they can do anything without even taking a minute to think about implications (especially negative aspects).

Below is a glimpse of what spins around in their minds.

"I think I can and SHOULD do that. :D Feel lik'a developer already. So, let's flood Magisk repo with some good stuff! :D The bot won't even care. :fingers-crossed: I'll be *$&% famous! :laugh: W-wait... what's a bot anyway? :confused: ...Uh, never mind! I'll eventually catch up on that. :) Packing osm0sis' stuff into a masterpiece module should be enough to get started. How about a busybox module to control flashlight? :o I'm a genius! :cool: Guess I can already see the light of success shining on my scalp! :rolleyes:"

Looking at a couple of modules in the repo, I can say the above quote is pretty accurate.

A few queries/suggestions to get started...

- Could MagiskBot perform basic shell syntax checking (sh -n <file>) on all module files containing a sha-bang?

- Extremely simple modules (i.e., bootanimation and font replacers) should be removed from the repo and blocked. A template in the form of a module, with a suggestive name, such as <universal font/bootanimation replacer/installer> would be much better. Font/bootanimation people and aliens alike would use that to install whichever fonts/bootanimations they wanted. Eventually, conscious folks would stop flooding the repo with parasitic modules

- A team of repo moderators to hunt down the bad stuff would be great. The group would work in conjunction with MagiskBot. Not sure how manageable this is as far as granting permissions to edit/remove repos is concerned. If that's feasible, count me as a candidate!

- The mod team would also rate modules which are very similar in functionality, then decide which should be gotten rid of in favor of the top rated. An example of such is Viper4Android and other audio modules. There are too may of these targeting the exact same end results (well, some have a few "extras", but you get the point).

In sum,

- It'd be great if MagiskBot could perform basic syntax checks on shell script files. Perhaps filter out parasitic modules as well.

- Template modules (not module templates) should replace modules which accomplish the same tasks.

- A human/alien + MagiskBot repo moderation team would take things to the next level. Maybe even SkyNet could be a great ally in hunting down folks who publish bad modules. Given that its paycheck doesn't state, "Destroy everybody and everything, but MagiskBot. Love that bot."

---

EDIT

topjohnwu, here's another suggestion (unrelated, but important):

Add ability to change a module's description by opening an issue on GitHub.

Case scenario: a developer changes their module's ID and would like Magisk Manager not to go crazy about it.

Or even better... have MagiskBot auto-update module description based on $id in module.prop.
[Magisk] Jaymin.0.1910:
Hey fella, first of all, see this part in lib/RepoModerator.js source file, the MagiskBot does auto-update repo description and name with the id from module.prop if they don't match :p.

if (repo.description !== prop.id || repo.name !== prop.id) {
console.log(`${repo.name}: Name/ID missmatch`);
gh.getRepo(ORGANIZATION, repo.name).updateRepository({
name: prop.id,
description: prop.id
});
}

Thanks for your suggestions, I support the shell syntax checking thought, while I also suggest the thought of template modules, like put a font in /cache/template_mods/fonts/ and flash the zip to have that font applied systemlessly, I think we should discuss about the moderation via telegram, kindly join the telegram group linked in the OP.
[Magisk] Harlock1978:
I want to change the bootanimation of my P10lite with a Watchdog one modyfing a little bit the work of MasterTech, but I always have the original boot animation.

In P10lite the boot animation is not in /system/media, but in /product/etc/media.

Here is how I build the structure of the module:

│ config.sh
│ module.prop
│ README.md
│
├───common
│ post─fs─data.sh
│ service.sh
│ system.prop
│
├───META─INF
│ │ CERT.RSA
│ │ CERT.SF
│ │ MANIFEST.MF
│ │
│ └───com
│ └───google
│ └───android
│ update─binary
│ updater─script
│
└───product
└───etc
└───media
│ bootanimation.zip
│
└───audio
PowerOn.ogg

Do I have to write some particular script in post-fs-data.sh to let it boot?

Is there I way I can find where is stored bootanimation.zip so that my files can be mounted either in product/etc/media or in system/media or wherever they are?

TIA
[Magisk] Didgeridoohan:
[MENTION=5301439]Harlock1978[/MENTION] A normal module is likely not mounting the file early enough to replace the animation. You'll have to use simple mount:

https://topjohnwu.github.io/Magisk/details.html#simple-mount

Be aware that simple mount might also happen to late on some devices.
[Magisk] Harlock1978:
So I have to change under config. sh $MODPATH with $SIMPLEMOUNT or I have to modify also update-binary?

TIA
[Magisk] Didgeridoohan:
Simple mount is not included in the module template. If you wan't to use a module to install the animation to that location you'd have to write some custom code, yes. Or just use [MENTION=8918441]OldMid[/MENTION]'s module to change to whatever bootanimation you want:

https://xdaforums.com/apps/magisk/module-midnightcore-one-midnight-modules-t3762758
[Magisk] Harlock1978:
Ok, thank you
[Magisk] OldMid:
My module does not support the P10's bootanimation path as I had not been made aware of it, I'll be able to push an update to accommodate it in a couple of hours if necessary.
[Magisk] Harlock1978:
Don't worry I have no hurry.

I thought it was easier to build a module for boot animation
[Magisk] Didgeridoohan:
The easiest thing is just to drop the boot animation in the simple mount directory (with the proper paths, of course). Currently that is /data/adb/magisk_simple (the value of $SIMPLEMOUNT).
[Magisk] Harlock1978:
Thanks I'll try

Edit.

I created the directory magisk_simple and than I copied inside with the right attribute

─product
└───etc
└───media
│ bootanimation.zip
│
└───audio
PowerOn.ogg

but I still have the original bootanimation from P10lite
[Magisk] OldMid:
Is the path /product/etc/media or /system/product/etc/media?
[Magisk] Skittles9823:
As far as I'm aware (idk I might just be dumb here) but magisk doesn't mount /product at all. That's why in my Lawnstep module I push the overlay to /product/overlay with cp instead of keeping it in /sbin/.core/img/lawnstep/product/overlay.
[Magisk] Harlock1978:
The path is /product/etc/media
[Magisk] Didgeridoohan:
That's a perfectly valid point. For some reason I didn't catch the path mentioned... Blind as a bat.
[Magisk] OldMid:
Ignore
[Magisk] ponces:
I was updating the "System Accent Color" Magisk module to comply with the new template rules.

However, with the 19.1 update, Magisk no longer allows the creation of new files and folders in the root of the vendor partition and this makes it impossible to use this module in my vendor as I do not have an "overlay" folder inside "/system/vendor".

Even after creating the "overlay" folder manually, I can't make it to work.

Am I missing something here?

Edit:

Solve it!

Forgot to run the following command:

chcon u:object_r:vendor_overlay_file:s0 /vendor/overlay

Is there any way to circumvent the need to manually create this folder?
[Magisk] Skittles9823:
Just gonna give this thread a bump for new module devs and I've also gone and updated the 2nd post with the link to the current module template docs and the new MMT-Ex template.
[Magisk] DiamondJohn:
I cant get the Remove APK using the folder replacement working

I am obviously doing something wrong, but I cant work out what it is, when trying to get the Remove APK, using the folder replacement working as described at https://topjohnwu.github.io/Magisk/guides.html. And before I go any further, yes I know there is a simpler way with the "Easy Replace", but I have more plans in the future that will only be available using the whole folder replace. In case it makes a difference. I am using Magisk 20.3

Anyway, the apps appear to be physically removed from the file system when I browse to the corresponding locations, but the apps are still in the app drawer, but when I I click on them, they crash,:confused:

Attached are some screenshots of one example (the Jelly web browser in LOS)

1. Showing the module is active in Magisk

2. The physical file has been replaced in the running ROM. NB: Tye file is not empty, but it only contains ascii text

3. The app is visible in the app drawer ("Browser")

4. The settings menu, for an app that I am attempting to remove

4. The error message when I click on the apps icon to start it

I also have some listing of the files (and what files are not present), locations and contents in the attached log file.

Can anyone see what I am doing wrong?

Again, I am purposefully avoiding using the "Easy Replace"
[Magisk] Didgeridoohan:
[MENTION=5417899]DiamondJohn[/MENTION] That behaviour usually comes from not having uninstalled any updates for the app on question. Updates go to /data, so they'll still be there even if the system part has been replaced. Worth checking...
[Magisk] DiamondJohn:
Sounded good, but I just checked the browser ("Jelly"), and as i was checking, I realised I don't remember ever seeing it in the playstore, and when I checked the path, it was

cmd package list packages -f | grep -i "Jelly";

package:/system/app/Jelly/Jelly.apk=org.lineageos.jelly

I also checked /data/app/ for any path with "jelly"in the name, and nothing there either

ls /data/app | grep -i jelly;

So I checked the data, and it did find something, but I kind of expected that since it wasn't truly removed.

ls /data/data | grep -i jelly;
org.lineageos.jelly

I then tried clearing the cache and data for Jelly, and then went into recovery, and also wiped the dalvik (which I tried before) and cache. And still Jelly is "half visible". ie it did not work.
[Magisk] Didgeridoohan:
[MENTION=5417899]DiamondJohn[/MENTION] I would try to disable the module, so that the app returns in /system, clear it's data and everything else possible and then try again.

From the looks of it the module is working exactly as it should, but whatever leftovers you have in there are causing issues. Trying to remove those with the app not even properly present anymore might be too much for Android to handle... Systemless modifications can cause some really weird stuff to happen sometimes.