yashsingh1/xdaforums huggingface dataset:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Well, well, well :)

I just installed the latest enforcing build and Snap camera no longer crashes when changing flash options.

GCam also works fine after changing flash options and takes pictures without snap button being non-functioning.

I don't think this is a fluke because I took more than 10 photos on both cameras.

EDIT: Damn I spoke too soon.

Snap camera doesn't crash when changing flash options but the snapshot button is inactive.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
I also attach the last logs, just in case. I did not check everything, but so far it’s smooth:good:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Can you test GCam and Snap camera and see if you have the same conclusions as I?

EDIT: great news guys. Casting now works fine!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Latest enforcing ROM log files.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, this whole pie perf service on msm8976 is a pain in my butt... More random minor denials! And they only showed up on enforcing lol... Ok, fixed those.

I also noticed in logcat that I made a mistake with the /proc/touchpanel chown script, so I fixed that too. This script is to properly handle setting permissions for the on screen NAV bar toggle to enable/disable the capacitive keys... So this will need to be tested to ensure it works and no selinux denials.

[MENTION=5236670]gohaz0331[/MENTION] sent me pstore from offline charging animation as that unfortunately wasn't working with enforcing, so I fixed the new denials on that.

So build lineage-16.0-20191015-UNOFFICIAL-s2 will be permissive to confirm that both the on screen NAV bar toggle and offline charging animation denials are fixed and that no newer denials show up hopefully.

This build I guess is optional, since it's mainly to just test the things mentioned above and submit logs to ensure those are indeed fixed.

It will be here in about 30 minutes of this post once it is done uploading

https://osdn.net/projects/lineageos-for-s2/releases/71768
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

Logs attached.

I tried on-screen navbar and it worked.

I switched off the phone and plugged it in to charge and there was a charging animation.

I noticed there is no LED notification for SMS messages in the default app.

When I installed Google Messages, the LED worked.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, woot! No denials for /proc/touchpanel... Nice! I also didn't see any denials for offline charging animation too... Sweet!

I did see another new silly pie perfservice minor denial lol... It is taunting me at this point. :silly:

lineage-16.0-20191016-UNOFFICIAL-s2-selinux-enforcing is going up within 30 minutes of this post! As the title says, it's another selinux enforcing build. Please test to ensure on-screen NAV bar properly enables/disables the capacitive keys and that offline charging animation works too.

Another request I have is to loop a demanding app like AnTuTu or 3dmark three times at least, so we can try and flush out any potential remaining perfservice denials if any come up when enforcing... Otherwise? I'm confident that selinux enforcing is done. :good:

https://osdn.net/projects/lineageos-for-s2/releases/71773

[MENTION=8738749]kalehrl[/MENTION] , Yeah the messages app no led notification is some odd LineageOS bug, as our notification LED device tree entries are general for all notifications and not specific to any app.... So that one is very odd indeed...
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

On-screen navbar works fine.

There is also offline charging animation.

Antutu benchmark wouldn't run.

It crashed after starting the app.

I ran Passmark 3 times but the second time it wouldn't complete.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
[MENTION=6235294]ThE_MarD[/MENTION] Actions: turned on the on-screen buttons, checked - they work correctly, turned off the on-screen buttons - all the icons on the desktop disappeared, the curtain could open.

This was the first attempt (the next attempt to repeat this situation did not work - the icons always appeared), I made a log of this first situation, but then I accidentally erased it with other commands (
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=8738749]kalehrl[/MENTION] , hmm, does AnTuTu work on the selinux permissive build? Can you check please?

That is indeed good news that on-screen NAV bar toggle works and offline charging animation. :)

[MENTION=10121505]tImI breakdown[/MENTION] , I checked your logs and for some reason the launcher is crashing. You can always try to force stop it and clear data on it and try again
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
I ran a 15 minute antutu stress test (at today's build) and it ended successfully. Is that what you needed?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

Here is the log with 3DMark and Antutu Stress Test.

These ones worked fine.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, heh odd... Well? I'll chalk up those AnTuTu issues up to AnTuTu's recent update to version 8 acting up as logcat wasn't showing anything selinux related, only package install and update errors. :silly:

I'm finally happy with selinux enforcing on s2! So it is ready for LineageOS 16.0 official! It's up to [MENTION=7985055]Rk585[/MENTION] to push to LineageOS Gerrit for code review and so on.

I also nagged him to get official TWRP for s2 properly updated to match the DRM blobs since s2 official TWRP is very out of date and his builds of TWRP for s2 look good and code review by me looks clean enough for official builds. :good:

Thanks again to everyone who provided me with a constant flow of logs! I wouldn't have bothered with this if I didn't have a way to fix the errors coming up.

Meow that selinux enforcing is done? Time for me to move onto my x2 and work on LineageOS 17.0 for that, and also start helping out more with nash (Motorola Z2 Force) that I am grateful that the LineageOS team members sent me as they received it as a donor device. :)

Take care my fellow LeEco community friends!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Are you sure Rk585 is still around?

I haven't heard from him for some time.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=8738749]kalehrl[/MENTION] , hehe yes he is around. I nag him a lot on Telegram hahaha ;)

Sometimes? It works too!

https://gerrit.twrp.me/q/project:android_device_leeco_s2

That's the first step! Next is to get TWRP official updated and then push everything we worked on to LineageOS Gerrit for code review and then merge it all for official LineageOS 16.0 builds for s2. :)

I told him that I won't be handling selinux enforcing on his new Asus Zenfone Max Pro M2 so he better learn sepolicy writing for that device hehe. :silly:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Great work Marc.

It seems we'll have both the updated TWRP and LineageOS 16.0 official soon ?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
Heyyo:) Mark, frankly - even a little sad that you are leaving us, but in any case cheers and WOW, thanks again for your huge work and help. I wish you good health (and your family) and success in all matters.
[MENTION=8738749]kalehrl[/MENTION] thank you too:good:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Yeah. It's been hell of a ride with Marc's ROMs and constant flashing and wiping and wearing my NAND flash very thin haha ?

Fun times these were. I'm already feeling bored not having to posts any logs. ?

Thanks again Marc and all the best mate.

Cheers!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
If OSDN is accurate? 17 builds lol, plus the two broken builds... So 19 builds total haha. I am glad that s2 will be in great shape though! LineageOS 17.0 will run pretty darn good on s2 once all the larger bugs are ironed out! :good:

I just made my first build of LOS 17.0 for x2! Gonna download it and see if it boots haha :)
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] satyam0987:
However its a nice custom pie ui for S2 but as i am using it since it has been uploaded and i have noticed that many times, i have to switch on and off mobile data to carry on in googlecrome and every time when i open paytm i used to switch on n off mobile data to use it ......

And while charging it gets extremely hot .....

..

..

Can any one suggest some solution for this.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

I remembered you mentioned perfservice and its many denials before.

I had a look and my last log and saw many entries with perfservice like this:

type=1400 audit(0.0:51): avc: denied { read } for comm="Binder:539_1" name="hw" dev="mmcblk0p27" ino=2206 scontext=u:r:perfservice:s0 tcontext=u:object_r:system_file:s0 tclass=dir permissive=0

Is it something to be worried about?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
[MENTION=8738749]kalehrl[/MENTION] , derp! Another random minor perfservice denial I guess lol... Can you please check what it is trying to access?

adb root
adb shell
cd sys
find -inum 2206

I'll need the result of that. If it's important? We will give perfservice read permissions to system files.

update: [MENTION=5236670]gohaz0331[/MENTION] did the commands, and it seems to be an msm8976 specific thing.

# find /sys -inum 2206
/sys/devices/soc.0/b1dc000.qcom,msmcci-ccimon/subsystem

I'll have to find a good way to solve this without creating a lot of newer denials hahaha :silly:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, ok, another enforcing build going up! lineage-16.0-20191018-UNOFFICIAL-s2-selinux-enforcing has that random selinux denial for perfservice on it... This denial seems to be exclusive to msm8976 as I saw that node only in msm8976.dtsi files in the kernel heh.

The build should be up within 30 minutes of this post.

https://osdn.net/projects/lineageos-for-s2/releases/71786
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
[MENTION=6235294]ThE_MarD[/MENTION]

le_s2_ww:/sys # find -inum 2206
./devices/soc.0/b1dc000.qcom,msmcci-ccimon/subsystem
find: ./kernel/slab/L2TP/IPv6: No such file or directory
find: ./kernel/slab/L2TP/IP: No such file or directory
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Yes, I get the same output:

le_s2_ww:/sys # find -inum 2206
./devices/soc.0/b1dc000.qcom,msmcci-ccimon/subsystem
find: ./kernel/slab/L2TP/IPv6: No such file or directory
find: ./kernel/slab/L2TP/IP: No such file or directory
1|le_s2_ww:/sys #
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Hmm [MENTION=8738749]kalehrl[/MENTION] you still got the denial... I guess we will need to genfs it... Can one of you please give me the result of this?

ls /sys/devices/soc.0/b1dc000.qcom,msmcci-ccimon/

We probably need to genfs the whole thing in there as file_context didn't work :silly:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] 545himanshu:
Amazing work

---------- Post added at 07:07 AM ---------- Previous post was at 07:05 AM ----------

Plz anyone can help me , i have device LYF F1s

Have sd652 similar to le 2 , and almost same specifications have.. can anyone tell me is that possible to port this rom for my device
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
le_s2_ww:/ # ls /sys/devices/soc.0/b1dc000.qcom,msmcci-ccimon/

driver modalias power subsystem uevent
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Let's try it again! Lol... lineage-16.0-20191019-UNOFFICIAL-s2-selinux-enforcing is going up and hopefully that darn pie perfservice denial for msmcci-ccimon is resolved. :silly:

Everything that [MENTION=8738749]kalehrl[/MENTION] showed on his ls of that directory is genfs'ed so it will take care of it.

https://osdn.net/projects/lineageos-for-s2/releases/71795

[MENTION=4488776]545himanshu[/MENTION] , that would require kernel source code to be released and an unlockable bootloader for that to even be possible to the same extent that s2 has custom ROMs. Next, it would require someone to maintain the device and port s2's trees to that LYF F1s. Usually device maintainers will only work on a device they own, as doing it remotely via testers does make it take a lot longer to test and diagnose. I did sepolicy for s2 only because it's not as difficult as device bringup.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
No perfservice denials but a lot more others :D

dmesg also looks strange :(
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
[MENTION=8738749]kalehrl[/MENTION] , tbh no one bothers with those logd denials since we just use logcat anyways, which is why I'm also just leaving them be. Those denials aren't important. :silly:

Anywho? The rest looks great to me! Ok, for real meow she's done hahaha. I'll let [MENTION=7985055]Rk585[/MENTION] know what I pushed to GitHub is ready meow. :good:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=7985055]Rk585[/MENTION]

Have you started the process of getting LineageOS 16.0 official for x52x devices?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] alban7314:
hello camera on messenger not working. New rom lineage-16.0-20191019-UNOFFICIAL-s2-selinux-enforcing. im full wipe cache, dalvik cache, system and data.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
It works just fine:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] alban7314:
I install rom	lineage-15.1-20191022-nightly-s2-signed now is ok.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Linuxkek:
Last build, last TWRP and clean install - somebody got problems with mic?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
Heyyo [MENTION=6235294]ThE_MarD[/MENTION], I managed to build lineageos 17 and the lineage boot screen saver is spinning endlessly (it does not freeze and does not reboot into recovery). Tell me, please, if possible, what to do? where to look? and yet, please, maybe there are instructions somewhere how to fix this, on which lines to pay attention, so that I can learn how to do it myself
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=10121505]tImI breakdown[/MENTION] , I'd recommend checking LineageOS gerrit of LeEco msm8996-common for LineageOS 17.0 branch to see what kind of changes we have to get it up and running. I'm unsure how much different it will be on s2 though as it is msm8976 legacy. https://review.lineageos.org/q/project:LineageOS/android_device_leeco_msm8996-common

Other good spots to look is other s2 Android 10 ROM repos to see what other s2 device maintainers have done to get it working for them as well.

Good luck bud! :)
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] anermika:
same problems with mic for 1019 build for me unfortunately- after clean flash

never had any probs like this before with lineageos 16
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] htcandroid:
Hi

I would like to know if there is any setting for turning off the light below the screen? i.e. the light of the 3 buttons. Thank you !

---------- Post added at 08:22 AM ---------- Previous post was at 08:17 AM ----------

Another issue.

I am running TVClient and stream the TV signal to my phone, however, the phone kept on prompting me there is no video apps installed., which is not the case, and I used to stream it flawlessly using VLC on another phone.

I've granted all the rights to TVclient and the video app, VLC. What's wrong ???

Thank you !
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Settings, System, Buttons, Backlight.

Try moving the sliders all the way to the left.

No idea about the second question.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shatheone:
is there a gcam for this rom or a better camera app? the default has been giving me problems freezing up , taking a long time to take a pic and using the flash gives me an unusable picture
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
Try these cameras for our device from a reputable nullbytepl: https://www.celsoazevedo.com/files/android/google-camera/dev-nullbytepl/

I am using GCam-6.2.030-Le2-V3.2-build75.apk. 7 version is not so relatively stable
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shatheone:
thanks for the info and fast response. i wanted to try out resurrection remix 8 as i heard pie doesnt work too good on this phone, but that rom is giving problems even starting. so until i figure that out im stuck on this one
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shatheone:
i tried that cam version youre using and it is definitely better and seems like it wont freeze but it still takes a while to take a pic with the flash on. i really should try out a good oreo rom
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Rk585 has started the process of getting it official: :D

https://review.lineageos.org/q/project:LineageOS%2Fandroid_device_leeco_s2+status:open
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] anermika:
sorry to post again, but using newest build i call anybody- my mic doesnt work and i dont hear the other side. that is in my opinion a critical bug
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=9517267]anermika[/MENTION] , can you please explain to us what procedure you are using? Is it the default dialer app? Something else? Another voice app like Facebook Messenger or WhatsApp?

[MENTION=8738749]kalehrl[/MENTION] , [MENTION=10121505]tImI breakdown[/MENTION] have you guys had any issues with the mic? Or any form of voice calls? I didn't touch the audio blobs for the latest releases as they use the same ones from LOS 15.1

And he better have started Gerrit stuff after all the work we put in :silly:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi Marc

No, no audio problems for me.

I've been using your latest build for more than 2 weeks now and haven't experienced anything similar.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
Hi Marс, the problem was with the microphone once on one of the builds during the test (they did not hear me). There was no longer such a problem. Also, all this time I have been at the latest build (20191019) and there are no problems.

Here, I found a comment about the microphone and Marc’s answer about Oreo audio blobs. On the 20191010 build, the microphone did not work (or maybe I did something wrong, but I always do with all the wipe):

https://xdaforums.com/showpost.php?p=80489703&postcount=284

https://xdaforums.com/showpost.php?p=80499131&postcount=285
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] anermika:
Hey, using the normal google telephone app.

with the builds before i did not have any problem.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Clean flash this one:

https://osdn.net/projects/lineageos...20191019-UNOFFICIAL-s2-selinux-enforcing.zip/

If you still have the problem, post a logcat log.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Jatin Verma x821:
Heyyo Marc

Really happy to see you here too.

Your lineage os 16 for x2 was the best rom i had ever used on my that phone. Now that my x2's screen is broken and it's bended too much, i am using s2.

Right now i am sick of random reboots in the aex pie I am using in this phone but I guess that problem is going to get away.

Is there any bugs in this rom btw?

I like stability and unable to find any stable rom here that's why I am thinking to finally go back to stock..
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
There are some camera instabilities but nothing too serious. I'd say it works fine 9/10. I've never experienced any reboot while using LineageOS 16.0.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] anermika:
Hey, sorry if that was not clear, this is the build i used.

I also did a clean flash.

I have no idea how to do a logcat log, is there a tutorial. sorry.

Thank you guys
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
This is how you make a log:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] josemarkos:
Hello, how is the progress of the officialization process?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
It seems nobody is interested in reviewing the code submitted by Rk585. The code needs to be approved for it to become official. ?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Vikas360:
Some bugs

Preview:

Video recorder is not working even with any app not only gcam on le 2 x526 i can click the pics but when i switch to recoder it crashes
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tommie39:
I am thinking of moving from AOSPExtended to LineageOS. Should I install the unofficial version or should I better wait for the official version? Will it be possible to easily upgrade later?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
There is a migration zip from unofficial to official but I'm not sure if it will work. We may be in for a long wait since nobody cares about reviewing the code ?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
I updated LineageOS 16 while we wait the official version

Changes:

• LineageOS code synchronization [11/18/2019].

• November security patch.

lineage-16.0-20191118-UNOFFICIAL-s2.zip
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
I just noticed that front camera produces mirror photos.

There is a setting regarding mirroring but it doesn't make any difference if I turn it on/off.

How can I get "normal" photos?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
[MENTION=8738749]kalehrl[/MENTION], exactly, never paid attention to it, I don’t know how to fix it, need to look or Marc will prompt:)
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Also, in GCam I haven't been able to find a solution.

However, I installed Open Camera and, voila, there is a 'front camera mirror' option which actually works.

Selfies, which I actually never take :D, are normal now .
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=8738749]kalehrl[/MENTION] , sighs so [MENTION=7985055]Rk585[/MENTION] never fixed the commit messages so I did on gerrit for him... I'm fixing everything these days I guess hahaha... :silly:

Also, gcam purposely horizontally flips the picture compared to the mirrored preview... the reason is for text. Otherwise? text in your seflies will look backwards like you see in the preview, so that is no bug. ;)

Attached shows you what I mean if you check my T-Shirt (free t-shirts with a case of beer purchase ftw)... also, face reveal with my Movember partially grown mustache haha. :good:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
I guess 'it's a feature, not a bug' ?

QC camera has a front camera mirror option but it has no effect. In the Open Camera, on the other hand, this option works and the picture isn't flipped horizontally.

And thanks again for fixing the commit messages because Rk585 went AWOL again ?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] mamamia888:
If we have to use EdXposed module， is the potential official release（Selinux enforcing mode）still critical？
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
[MENTION=8738749]kalehrl[/MENTION], woot! Great news! Rk585 is starting to merge stuff on LineageOS Gerrit! :good:

Update: so s2 device tree is fully merged after fixing some commit messages as RK forgot to put a new line after the commit header for the body of the commit message. :silly:

I'm checking with RK if there is any kernel commits that need to be pushed and merged, then we also need to do a pull request for the vendor blobs .

update 2: someone gifted me XDA ad-free for a month from this post, so thank you anonymous s2 community member! :good: