[Samsung Galaxy S 5 Unified Development] curiousrom:
Report: Bugs & Semi Clean Install S5 klte 16.0 Unofficial Build 2018-12-03 over 11-21

Edit 2: See this post about the new build: New S5 LineageOS 16.0 haggertk 2019-01-09 Build! - Report & Bugs

Edit: Everything below still applies to the most recent @ the present haggertk's S5 klte + variants unofficial 16.0 Beta Build 2018-12-10 (bug report 2018-12-10) except for 10. Status bar Bugs as several were fixed except for the Bluetooth icon when active & a few icon combinations.

***

As with the previous build, in haggertk's S5 klte unofficial 16.0 Beta Build 2018-12-03 there are very few minor bugs, some stuff is not abled yet, it's very stable & perfectly usable for my S5 SM-G900M daily driver.

Some of the issues below are copy/pasted from Updating TWRP, S5 Flashing 16.0 on Official 15.1 & Camera Quality because they are still unresolved.

Not working yet in the current haggertk's 16.0 beta build 2018-12-03:

You can open Privacy Guard (my favorite LineageOS feature) but it does not do anything. 3-dots > Advanced crashes back to Trust. As a workaround using rooted apps like App Ops - Permission manager several permissions are accessible like run in background but not Run at startup. For that I use SD Maid > AppControl > offending app > Receive Manager > & disable the BOOT_COMPLETED entries. More about it in a future post.

The LineageOS AudioFX equalizer is present, you can open it, turn on/off, move the sliders but does not have any effect. The small org.lineageos.audiofx process is running all the time & AudioFX cannot be disabled in System > Apps but can be frozen (disabled) with a third-part app like App Freezer for example.

Meanwhile if rooted with Magisk > Manager > Downloads > Search for viper4 & download the VIPER4Android module. I have been testing it while listening to a high quality recording using the FIREqualizer in Viper4 with bass pushed to the max & treble to the min & good earbuds & it's working fine & really obvious when toggling off/on the equalizer as seen in the screenshots.

View attachment 4658307

There is no weather provider for the LineageOS stock Clock widget included in the 16.0 build 2018-12-03 & could not find a 16.0 compatible plugin or apk. Obviously there are several alternative weather apps in Play Store & elsewhere.

The Expanded Desktop is usable but it's semi working. As you can see in the screenshots when tested with the stock Browser & other apps the view is expanded but the Status bar icons are visible & overlaid & when tapping in the Search box they can be triggered.

View attachment 4658308

Settings > Battery > the data is incomplete & 3-dots > Battery usage sometimes says "Battery usage data isn't available". More about it & workarounds in a future post.

In the Stock Camera > hamburger > Storage > if you select SD Card the photos will be saved to /external sdcard I.D./Android/data/org.lineageos.snap/files/ & not in DCIM as usual. If Phone is selected it goes in the standard /storage/emulated/0/DCIM/Camera/.

Edit: [MENTION=7500155]tomm1e[/MENTION] posted here: "Seems like that is the new way of saving files to sdcard on Pie..." & included a link to a LineageOS 16.0 commit.

I did not try with other camera apps yet but with the nice Open Camera > Settings > More camera controls > Save location > default is /storage/emulated/0/DCIM/Camera and cannot be changed to the external sdcard as it gives a "cannot write to this folder" error. This is maybe the fix in the review stage @ the present: msm8974-common: sepolicy: Resolve mediaserver denials. [MENTION=7500155]tomm1e[/MENTION] posted here a workaround: "...there's a way to write to sdcard using Storage Access Framework. Open Camera has this option, goto Options -> More Camera Controls and turn on "Use Storage Access Framework" then choose the original sdcard folder (e.g. /storage/<id>/DCIM/Camera) for Save Location". Tested by me & it works.

Dark Style & Gboard: I switch several times a day between 3 different virtual stock AOSP keyboard languages & > Notification > Change keyboard (or by long pressing the Space bar) works fine. As seen in the screenshots when > Settings > Display > Style > Style > Dark and back to Settings > Display > Style > Dark mode > Dark is selected & using Gboard > long press the Space bar > keyboard switcher it's impossible to see the language options. That bug is also present in the official LineageOS 15.1.

If you click on > Notification > keyboard switcher it offers the stock AOSP keyboard options + only Gboard without any of it's language choices.

The workaround shown in the screenshots: Settings > Display > Style > Dark mode > Default. It's no pure black :crying: but solves the problem until it's fixed. Or don't use Gboard w/ multiple languages.

View attachment 4658309

Desktop folders created by stacking apps icons are not responsive sometimes when the phone is woken up. After several taps on the folder with no response sometimes one of the app inside that folder opens. After closing the unwanted app the folder opens as it should.

In my Home settings > Change icon shape is set to Square but the folder's shape keeps being a circle which is a "feature" probably. In Display > Advanced > Display size is set to Large. Screen rotation is set to disabled 90% of the time.

View attachment 4659418

Hotspot panel: if I select AP Band 2.4 GHz Band it works fine & can connect other devices to it but if I select 5.0 GHz Band it does not work as also reported by [MENTION=5655966]hightension[/MENTION] on his G900F. My S5 G900M maybe does not support 5 GHz as a hotspot host but does as a client. I don't have access to a 5 GHz Band access point to test that so can somebody confirm please?

View attachment 4659476

Status bar Bugs: The Bluetooth icon is not showing up on the Status bar when it's activated. Edit: haggertk explained the Bluetooth Status bar icon Pie behavior in this post: "...It will become visible when something is actively connected.".

Settings > System > Advanced > Status bar > System icons > Bluetooth is on & toggling it on/off/on has no effect. This can have an impact on battery if you forget to turn Bluetooth off when you don't need it like I did for a day.

View attachment 4659485

Edit: haggertk says here that a dot on the Status bar instead of icons is a characteristic of Pie so the following are not bugs: Settings > System > Advanced > Status bar > Network traffic monitor > Display mode: if you enable either Download only, Upload only or Upload and download the icon & info overlaps & hides the Wifi & network signal strength on the Status bar + the last digit of the Clock. Confirmed by [MENTION=6098030]Struppi0815[/MENTION] in his post here.

View attachment 4659938

With > Status bar > Clock position > Right > if both Do not disturb & an Alarm are active then the 2 icons are just a dot on the Status bar but shows up correctly in the mini icons of the Curtain on the right side.

If you disable one of those 2 in > Settings > System > Advanced > Status bar > System icons then the one left will show up correctly. Or if you select Clock position > Left or Center.

View attachment 4659509

[MENTION=8318852]Gbrl95[/MENTION] also reported some Status bar dots instead of icons with screenshots here and [MENTION=7978913]fitittome[/MENTION] also here.

The Brightness adjustments seems to be exponential rather than linear. Settings > Display with Adaptive brightness off > Brightness level which shows % in 16.1 needs to be set to 50% to get the same brightness level as 10% in LineageOS 15.1. To get 50% it needs to be set @ 85%. It's the same for the curtain's Brightness slider if enabled in > Settings > System > Advanced > Status bar > Brightness slider. [MENTION=4422232]eurohunter[/MENTION] first reported it in this page and [MENTION=7403250]FedoraMaster420[/MENTION] on his G900S here.

Google Pay NFC point-of-sale contactless payment is not working. [MENTION=7043628]Rocthrower[/MENTION] reported it here on his S5 SM-G900R4 & wrote "I have restored a 15.1 backup and payments were working at the terminal as expected". I cannot test this as it is not available yet in Costa Rica. List of countries w/ Google Pay here.

Desktop > Home settings > if you toggle on/off > Show icon labels on desktop and/or Show icon labels in drawer the change(s) sometimes are not reflected immediately.

View attachment 4662289

Workaround: reboot or in the same > Home settings panel > Change icon shape to a different one than you current choice to force a redraw of the Desktop & the Apps drawer. Afterwards you can change back to your original > Change icon shape > choice.

As seen in the screenshots if you manually labeled some Desktop folders created by stacking apps icons, the label will not be turned off with > Show icon labels on desktop > Off. You must edit them out manually.

***

If you or I find more stuff I will update this post!

Everything else is working including the important SELinux Enforcing security feature.

It's stable & awesome enough to be used as my daily driver. :)

The most important changes compared to the previous build I think are under the hood which can bee seen in logcat when searching for errors (E/) and SELinux Enforcing - sepolicy- denials (avc: denied) as there a lot less than before & further tests I am running will probably show a better battery life because of that.

[MENTION=2693412]haggertk[/MENTION] worked hard on this as you can see with this LineageOS code review search: owner:haggertk@lineageos.org (status open OR status:merged)

I am attaching a logcat made after the first boot without Magisk or root.

Semi Clean Install S5 klte 16.0 Beta Build 2018-12-03 over 11-21

It may seem overboard to some but I prefer to be safe than sorry so here is what I did, everything is peachy and all my apps & settings were intacts including the icons on the desktop:

Using the Magisk Manager > Full uninstall & automatic reboot to System as I have seen some S5 users reporting update problems w/ Magisk installed. Edit: uninstall your custom kernel if you installed one.

Enabled all apps that I had frozen, update apps using Play Store, synced all my accounts one by one, forced a fresh > Settings > System > Advanced > Backup + a Chat backup in WhatsApp.

Because that feature is not available @ the present in 16.0 I used SD Maid > AppCleaner to clear 400MB of cache to make the TWRP full backup smaller.

Copied haggertk's build & a fresh copy of Open GApps Pico to external sdcard, rebooted to TWRP and made a full backup: Modem, Boot, System, Data to external sdcard including the important EFS partition which can come handy in case of no IMEI and/or no network problem. So everything except Cache. When restoring using TWRP you can select any part of the backup you want.

In TWRP > Wipe > Advanced Wipe > wiped both caches, System and nothing else.

Flashed the most recent haggertk's unofficial LineageOS 16.0 for S5 klte + variants + a fresh Open GApps Pico ARM 9.0 one after the other then > TWRP > Home > Advanced > Copy Log to external SD card then reboot to System. The TWRP Recovery log can be very useful for troubleshooting an installation problem & it takes about 10 seconds to back it up.

After testing the S5 for 1-2 hours, for root I downloaded & copied to external sdcard Magisk v17.3 (edit: now updated to 18.0 & it's working fine) and on that page: Latest Beta (or Stable), Latest Uninstaller & Latest Magisk Manager.

Back into TWRP wiped both caches, then flashed Magisk-v17.3.zip & rebooted to System. Magisk Manager was not showing up so installed manually the MagiskManager-v6.0.1.apk downloaded previously & everything is working fine.

In Magisk Manager > Settings my preferences are: Update Channel: Beta (or Stable), Automatic Response: Grant Prompt (thanks to [MENTION=8069426]jmichael2497[/MENTION] for his security tip here), Superuser Notification: None (otherwise it's gets annoying fast). And kept the default settings for all the rest.

So instead of getting all those notifications & grant questions I just check once in a while > hamburger > Superuser and > Log.

Magisk Manager > Downloads > Search for viper4 & download the VIPER4Android module. Original XDA thread by the same dev as the module for the somewhat older app alternative.

Tested more, screenshots & wrote this huge post! :rolleyes:

For installing 16.0 Unofficial over 15.1 see: Updating TWRP, S5 Flashing 16.0 on Official 15.1.

Tested on Galaxy S5 SM-G900M (klteub), Bootloader (aboot) G900MUBS1CQD5 & Modem (baseband or radio) G900MUUB1CQA3 (from haggertk's collection of S5 Odin bootloader/modem combo flashable files) & TWRP 3.2.3-0 without a custom kernel or any other system modifications.

***

No. :) I can see some icons of stuff running on the status bar of your attachment... Without a description of your setup & impossible to do some troubleshooting & since it was on the previous build you have to test again with the new one & install the minimum apps to test the build itself.

***

[MENTION=2218776]stiltzkin[/MENTION] could you edit your post please & include the model #?