[Samsung Galaxy S 5 Unified Development] curiousrom:
Brightness Bug or Feature? LineageOS Contributors & Magisk Problem

View attachment 4659611

:) We can discuss all day about if it's a bug or a feature as it is relative to our different point of views but for the "logarithmic" part if have to disagree: "...the logarithm is the inverse function to exponentiation" & if you compare the two curves I would say that the Brightness slider's progression in haggertk's build 2018-12-03 is indeed exponential.

Your comment is the only feedback I got so far :crying: besides some Thanks :good: (which are always appreciated) to the Report: Bugs & Semi Clean Install S5 klte 16.0 Unofficial Build 2018-12-03 over 11-21 post I just updated with some more minor bugs (Status bar) & screenshots.

Hoping it can be useful to [MENTION=2693412]haggertk[/MENTION] & that some users of that build confirm, contradict or add some bugs or observations to make it better.

***

S5 Searchable LineageOS Contributors Database

I just spent a few seconds in that panel in the past year of using LineageOS but today paid attention to it & tried a search that surprised me: About Phone > Contributors > Search with haggert. Then 3-dots > Contributor info shows 755 commits (!) as of February 1, 2018 as seen in the screenshots.

View attachment 4659612

To that you need to add about 1,150 more commits (!!!) since that date as I found out by changing the last numbers in this search to go back to February (currently page 47): https://review.lineageos.org/q/owner:haggertk%40lineageos.org,1150

Contributors > 3-dots > Contributions info shows 2,033 contributors & 103,377 Total commits! That's just amazing & gives a little idea of the time & energy those unpaid volunteers put in the LineageOS project. Hats off :cowboy: and thanks for all the fish!

View attachment 4659613

There is also this LineageOS contributors page in the LOS wiki with the current top guys but it's not searchable & for some unknown reason the 9 project directors are not listed @ the present. BTW haggertk is one of them so we S5 users are very lucky. That's besides the other hats :cowboy::cowboy::cowboy: he is wearing.

***

Magisk Problem

In the post linked above I described how Magisk v17.3 was installed successfully on S5 G900M klte. That's a stopgap for me until a working LineageOS addonsu for 16.0 becomes available.

In Magisk Manager > hamburger > Log > Magisk > there is a save button on the top. That could be useful for troubleshooting besides capturing a logcat. Because you are not rooted check "setup ADB and then capture a log" in the LineageOS wiki.

But maybe Magisk is hiding to the system what it is doing.

Since the phone is not rooted you can grant this permission to enable SysLog using ADB (15 seconds ADB Installer) & a computer:

adb shell pm grant com.tortel.syslog android.permission.READ_LOGS

You can also install an app like MatLog to analyse the logcat, filter it, search in it, export files etc but Syslog is fast & easy. If not rooted grant permission for MatLog:

adb shell pm grant com.pluscubed.matlog android.permission.READ_LOGS

For some unexplained reason the Magisk v17.3 - Root & Universal Systemless Interface thread was locked but it's still searchable with lots of info in post #1.

The best place to ask for help would be in the Magisk Forum IMO.

And because all those install trials + SuperSU you mentioned that you tried also there is probably lots of garbage left behind. :eek:

Besides running the flashable Magisk removal tool you could check unSU Script zip -- Unroot with ease! by [MENTION=4544860]osm0sis[/MENTION] or do a clean install.

***

MindTheGApps Bad for 16.0 on S5 klte Variants?

Thanks :good: for reporting back. :cool:

Could you please post links or quotes of these "3 of the Lineage Team Maintainers" comments about MindTheGApps?

***