yashsingh1/xdaforums huggingface dataset:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

Clean flashed the latest ROM without gapps.

Screen casting still doesn't work.

Google camera won't start.

Even the default camera takes a long time to start.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
[MENTION=8738749]kalehrl[/MENTION] thanks... Hmm, it did clear up my selinux denials... But darn, there's a bunch of things broken on s2 that we will have to figure out why... There's all kinds of issues that there shouldn't be. There's definitely something wrong or missing in the device tree or vendor blobs since ether (Nextbit Robin) is msm8992 and doesn't have hwc2 like s2 and the msm8976... But they have no hwbinder issues and no camera issues with it enabled...
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Screen casting was fixed by Rk585 in his recent builds. I complained it didn't work and he obviously corrected it. The camera both Google and factory worked fine in your penultimate build.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] elbiatcho1:
Maybe set battery/device performance to quick or performance.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] lambha48:
I have bro,but no use I'm on cr droid 7.1.2 with illusion kernel,I tried pie,oreo also the same with grapheme kernel,
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] satyam0987:
Is it better in stability then lineage OS 15.1
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Rohit Salian:
Well used this ROM till today (bought new phone) and was quiet stable, sometimes during call couldn't receive incoming voice and camera won't start but after a restart everything was back to Normal

Also not all banking apps could be used.

Thanks for your Support and ROM's <3
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
EDIT: Link taken down. Built with wrong device tree branch sorry.... will do another build later.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Welcome back [MENTION=6235294]ThE_MarD[/MENTION] :)

Google camera doesn't work.

Casting also no go.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, so special thanks to [MENTION=9260323]Akash98Sky[/MENTION] for pointing me in the direction of a commit that fixes hwbinder for both graphics allocator and camera? This should fix all those qdisplay service selinux denials we have had on s2, plus of course having proper hwbinder on those two like we should have always had. ;)

This is still an selinux permissive build to ensure we don't get any new selinux denials. I'll need logcat as always to check to make sure this all works.

File upload should be done in about 30 minutes from this post.

https://osdn.net/projects/lineageos-for-s2/releases/71722

[MENTION=8738749]kalehrl[/MENTION] , sorry about that previous build... I used the wrong device tree so we were getting those silly cpuset denial errors... this one will be proper.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
As before.

Google camera crashes.

Casting doesn't work.

Ambient display seems OK.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=8738749]kalehrl[/MENTION] , by chance can you force stop that gcam mod, clear storage, then uninstall it and try a different gcam mod? The error is odd as it shows...

--------- beginning of crash
10-05 19:52:17.077 6228 6228 E AndroidRuntime: FATAL EXCEPTION: main
10-05 19:52:17.077 6228 6228 E AndroidRuntime: Process: com.google.android.GoogleCamera, PID: 6228
10-05 19:52:17.077 6228 6228 E AndroidRuntime: java.lang.RuntimeException: Unable to create application com.google.android.apps.camera.legacy.app.app.CameraApp: java.lang.SecurityException: Failed to find provider com.google.android.gsf.gservices for user 0; expected to find a valid ContentProvider for this authority

It could be a gapps related error as it mentions Google framework services for that gcam mod...

Also, do all functions of the built in LineageOS snap camera app work ok or no?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
I reflashed the ROM together with gapps pico and now the Google camera works fine :)

This is the Google camera mod I'm using which is modded especially for x52x models:

https://www.celsoazevedo.com/files/android/google-camera/f/changelog563/

https://xdaforums.com/le-2/themes/v1-1-google-camera-6-1-013-port-le2-t3880934

I believe no others come close to its stability although it's not perfect.

The default snap camera also works great.

Casting doesn't so I guess it isn't dependent on gapps.

The logs below are with gapps installed and they seem to be quite "clean" :D

I hope you get some additional logs from other people who focus on some other aspects of the ROM.

Unfortunately, I've only got one phone which is my daily driver so I can't spend a lot of time testing.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
[MENTION=6235294]ThE_MarD[/MENTION], I sent clean logs in PM. Then successfully installed GApps pico. GCam also works successfully. This is all that I managed to see, if I notice something - will inform.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, wahoo!!!! thanks again [MENTION=8738749]kalehrl[/MENTION] and [MENTION=10121505]tImI breakdown[/MENTION] , it looks like we are ready to finally test selinux enforcing again! :good:

lineage-16.0-20191007-UNOFFICIAL-s2 is selinux enforcing, including that sepolicy fix for gcam mod for s2 so it will work just as good with selinux enforcing. ;)

The build will be up in about 30 minutes from this post.

https://osdn.net/projects/lineageos-for-s2/releases/71726

Test EVERYTHING you can! ROM + Gapps! I've heard from other s2 devs that casting is indeed buggered on s2 so I'll leave that one up to [MENTION=7985055]Rk585[/MENTION] to fix, along with reverting audio blobs back to Oreo as I don't have EUI ROM for s2 on my PC or those Oreo blobs he was using before.

I don't own an s2 as I've mentioned before, so I'll also be leaving the official s2 for LineageOS 16.0 up to [MENTION=7985055]Rk585[/MENTION] as well.

As before, everything is up here on GitHub for our sources under the lineage-16.0 branch.

https://github.com/leecodevs/

We did it!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
ooo, cheers, a button appeared with the attachment of files:

first screenshot before installing GApps: the camera breaks when switching flash modes.

second screenshot after dirty installation of GApps: attempt to complete the setup. (maybe with a clean installation of GApps this would not be. in the previous assembly with a dirty installation of GApps this was not).

upd.: with installing the firmware and immediately GApps, the standard camera does not crash when switching the flash and there are no problems with completing the setup
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

It seems we're getting very close but not just yet :D

I clean installed the latest ROM and gapps pico from today.

I also installed all my apps except for Magisk.

They all work fine but Google camera, Facebook and Messenger crash.

Google camera doesn't pop up at all.

Messenger pops up but when you click on a conversation, it freezes and you eventually get a pop-up saying:

'Messenger isn't responding'

Facebook also throws the same error after some time.

The default camera, however, works fine.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
I confirm for Gcam - it does not even start.

Where there is sound (video on YouTube, video on Instagram, viewing ads in the game, etc.), the sound clicks and occurs:

6134 6669 E ACDB-LOADER: ACDB -> Not correctly initialized!
6134 6669 W audio_hw_utils: audio_extn_utils_send_audio_calibration: No audio calibration for usecase type = 0
6134 6669 E audio_hw_primary: start_output_stream: cannot set hw params: Out of memory
525 525 E /system/vendor/bin/adsprpcd: vendor/qcom/proprietary/commonsys-intf/adsprpc/src/adsprpcd.c:43:adsp daemon will restart after 25ms...
525 525 E /system/vendor/bin/adsprpcd: vendor/qcom/proprietary/commonsys-intf/adsprpc/src/adsprpcd.c:43:adsp daemon will restart after 25ms...
6133 6156 W AudioFlinger: write blocked for 393 msecs, 1412 delayed writes, thread 0xf3503240
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, DOH! Darn, that gcam mod fix didn't work... ok, I'll have to create an seapp_contexts entry specifically for it and then grant it extra permissions I guess. :silly:

lineage-16.0-20191009-UNOFFICIAL-s2 will be permissive, so please in your developer options increase your log size to 4MB or 16MB and use your s2's as much as possible so we can capture the biggest logcats we can. Please also add gapps and test gcam mod and test all gcam mod functions too.

I saw a few other selinux denial fixes we needed too for graphics hardware composer that I fixed as well.

the adsprcd stuff is a noted bug. That is something I've asked [MENTION=7985055]Rk585[/MENTION] to fix as we will need to drop the pie audio blobs and revert to oreo stuff and use adsp modules from s2 EUI ROM.

The build is going up in 30 minutes from this post.

https://osdn.net/projects/lineageos-for-s2/releases/71734

Just a heads up... my days off end today as I'll be on night shift for the next 15 days... so updates will slow down again. Eventually once I'm on days off again I'll try to finish this off I guess heh
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
I clean flashed the ROM and open gapps from today but LineageOS didn't boot. After a couple of minutes, it rebooted into recovery. From there I copied recovery and dmesg logs to sdcard and I attached them here.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
[MENTION=8738749]kalehrl[/MENTION] hmm it didn't boot? Darn, I'll have to check my device trees sorry about that I might be on a bad branch somewhere...

Please note if it falls to boot, we would need pstore logs to show what the kernel saw recently for logs.

Once a boot fails, immediately reboot to TWRP via button combo and then via PC do this

adb shell cat /sys/fs/pstore/console* > pstore.txt

Or via local terminal like this

cat /sys/fs/pstore/console* > /sdcard/pstore.txt
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Unfortunately, I will only be able to get this log next week because I won't be home ?

Maybe somebody else will try the ROM and, if it fails to boot, get the log.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
No worries bud. To be safe, I did a new clean build as that last one was a dirtybuil which may have caused issues.

lineage-16.0-20191010-UNOFFICIAL-s2 Will be up in 30 minutes from this post

https://osdn.net/projects/lineageos-for-s2/releases/71737
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
[MENTION=6235294]ThE_MarD[/MENTION]

Clean logs in the corresponding archive without GApps. Log size = 16MB

It repeated:

This command worked from the local terminal: cat /sys/fs/pstore/console* > /sdcard/pstore.txt

upd.:

1. On version 20191007 GApps worked, but now does not work. On 20191009 also does not work (also goes into recovery). Maybe the problem is in today's GApps?

2. Damn, and on the old assembly the same thing with gapps pico 20191010... Apparently a problem with them. We must try the version below. With the open_gapps-arm64-9.0-pico-20191006.zip version, the old build was installed.

3. lineage-16.0-20191010-UNOFFICIAL-s2.zip loaded with open_gapps-arm64-9.0-pico-20191006.zip.

4. Added logs with the latest version.

5. On the last version, the microphone and sound do not work when making a call.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
[MENTION=10121505]tImI breakdown[/MENTION] thanks for the info. Tbh I always recommend MindTheGapps since it never gives me issues. OpenGapps with their daily updates have given me grief sometimes.

Apparently I need better understanding of seapp_contexts as it didn't work again hmm. I've tried this time to follow what other devices have used to see if it works for us.

New test build is going up! lineage-16.0-20191011-UNOFFICIAL-s2 will contain another attempt to properly address gcam mod for s2 denials and also fix offline charging denials that [MENTION=5236670]gohaz0331[/MENTION] has brought to my attention. I've also restored the adsp modules from s2 EUI ROM 30s to see if that fixes the audio issues... If not? We will indeed need to revert to Oreo audio blobs.

The build will be done upload within 30 minutes of this post.

https://osdn.net/projects/lineageos-for-s2/releases/71741
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
LineageOS 16.0 20191011 LOGS +GApps(20191011).zip: contains pstore.txt (through the local terminal), recovery.log (via the TWRP function), dmesg.log (via the TWRP function).

On the clean version without GApps, the standard camera stops taking pictures when switching the flash mode.

The sound on the video works.

The speaker and microphone are working.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=10121505]tImI breakdown[/MENTION] , it seems that snap not taking pictures after changing flash modes is a snap camera app bug as my x2 seems to be doing the same thing :( if you could please do a bug report on lineage gitlab issues.

Woo! I'm taking full advantage of the guest WiFi on the location I'm doing night shift out of town on a coiled tubing frac job heh, so I got lucky this time. ;)

Build lineage-16.0-20191012-UNOFFICIAL-s2 will be going up in 30 minutes from this post. Gcam mod sepolicy should be good now as the logcats I've seen had the one same denial. There's also a few small cnd, qti init shell and qseecomd denials. I'm also curious if we can get rid of some nasty dac_override permissions as we have the proper permissions in our init scrips for CND, dpmd, rfs_storage and maybe for the goodix fingerprint reader, so let's see if those come back or not. I have also reverted the audio blobs back to oreo to see if that helps get rid of the dmesg adsp related spam.

UPDATE: I just realized on audio blob revert that i forgot to revert the audio blob mkdir locations in init... sorry folks. I made a new clean build with that fix and redid the upload.

UPDATE 2: the build was taken down, will post a new build once I find a fix
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] reysers:
the build does not start!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] karabassssss:
this build stuck in boot loop. even clean install aftr wipe of everything. my TWRP is 3.3.1

---------- Post added at 09:29 AM ---------- Previous post was at 08:41 AM ----------

build : 20191010 is bootable in same environment

---------- Post added at 09:34 AM ---------- Previous post was at 09:29 AM ----------

but even 20191010 went into boot loop when installed with latest opengapps
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, I've taken the build down. I haven't seen much for logs so I'll try to check over why it failed and guess a fix. Probably still something with audio...

Please avoid latest OpenGapps. As mentioned earlier in this thread any build newer than 1006 is broken, so either use an earlier version of OpenGapps or switch to MindTheGapps which I recommend over OpenGapps.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] karabassssss:
I was able to install and use the same opengapps build with no issues with build : lineage-16.0-20190817-UNOFFICIAL-s2.zip

So I unsure if issue is in specific opengapps build. Anyway, your latest build isn't starting even as pure LOS installation.

Thanks for your work!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, sorry again about that bad build. [MENTION=5236670]gohaz0331[/MENTION] confirmed this one boots meow! :good:

lineage-16.0-20191013-UNOFFICIAL-s2 is up!

Gcam mod sepolicy should be good now as the logcats I've seen had the one same denial. There's also a few small cnd, qti init shell and qseecomd denials. I'm also curious if we can get rid of some nasty dac_override permissions as we have the proper permissions in our init scrips for CND, dpmd, rfs_storage and maybe for the goodix fingerprint reader, so let's see if those come back or not. I have also reverted the audio blobs back to oreo to see if that helps get rid of the dmesg adsp related spam.

https://osdn.net/projects/lineageos-for-s2/releases/71757
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] karabassssss:
I confirm, this one is booting :). Thanks
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] karabassssss:
after installing latest gapps (nano), system is automatically rebooting into recovery mode. unable to boot into system

attaching logs from twrp, hope this helps
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] karabassssss:
tried with opengapps 1005, it indeed booting into system.

but again, with older los builds I able to boot normally with opengapps 1012 as well
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

I'm back so here are the log files after a clean flash with your latest ROM and mindthegapps.

Everything seems to be working fine.

There are no Facebook and Messenger freezes.

Gcam works fine. Snap camera crashes after clicking flash icon.

Casting doesn't work.

I will be using this build for some time so if you want me to test something specific, just tell me.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=8074991]karabassssss[/MENTION] , not sure what to tell you bud, but even non-LineageOS ROMs on x2 are failing to boot with newer OpenGapps, and nothing I'm doing on the device tree is affecting OpenGapps. I'd recommend getting an OpenGapps install log and post it on OpenGapps GitHub issues page.

[MENTION=8738749]kalehrl[/MENTION] , sorry but I do need to do one more build to ensure the dac_override denial for fingerprint is resolved. If you are unable to switch to this build? No worries bud. :good:

We are so darn close! Looks like msm8976 should stick with Oreo audio blobs as the dmesg errors with adsp are gone.

Build lineage-16.0-20191014-UNOFFICIAL-s2 is up! This has a dac_override WIP fix for the goodix fp so that s2 sepolicy will be even more secure on pie than ever before on a custom ROM. ;)

Everyone please go into your developer options and increase log buffer size to 4MB or 16MB and run this build for a day before submitting logs to me.

I also mainly need the fp sensor tested

As always, I recommend a PC via USB ADB (with root for ADB permissions enabled in developer options) for the logs

adb root
adb pull /sys/fs/selinux/policy
adb logcat -b all -d > logcat.log
adb shell dmesg > dmesg.log
adb shell lshal --init-vintf > manifest.xml

https://osdn.net/projects/lineageos-for-s2/releases/71761

If this build comes back without any new denials? We shall try another enforcing and hope that once again no new denials pop up lol :silly:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] tImI breakdown:
1. The fingerprint is working.

2. In GCam: take a picture, switch the flash, take a picture, wait a bit - the snapshot button becomes inactive.

I don’t know yet how to send a report :(. In the assembly 20191014 snap camera behaves better when you change the flash mode, but still occasionally falls, so I propose to leave it for last.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
I'm afraid that snapshot button becoming inactive is the bug in GCam. You can't expect it to be 100% stable because it was never intended for our phones. It seems to me that notifications aren't delayed now like before with old LineageOS 16.0. Sometimes I wouldn't get them at all unless I opened the app. Now they are instantaneous. Could it be because of these fixes or because I'm not using Magisk?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo [MENTION=10121505]tImI breakdown[/MENTION] and [MENTION=8738749]kalehrl[/MENTION] , unfortunately it seems the camera issues could be due to the camera HAL, or the blobs are mismatched from the camera HAL version or something else? I've asked the other s2 devs to try and revert the camera blobs and maintain the hex edits and see how that reacts.

Was camera in general this buggy on Oreo? Or was it just in pie?

It looks like the dac_override fix worked! Selinux isn't asking for that permission and I don't see any new denials I'm that log! :)

Notification delays could be caused by power management, low memory killer or even Google services framework acting up... Not sure if Magisk could negatively affect it, unless it messes up and hogs a bunch of memory I guess?

gohaz0331 was telling me that cpusets aren't working correctly on s2, so that is probably something else s2 maintainers should look into, as I also did see some kernel debugging errors for it... Cpusets is a system in place on the kernel that can limit apps/processes to only using certain CPU cores, so it is super handy for optimizing performance vs battery.

I'm feeling confident in doing another enforcing build, so I'll whip one up for fun :cool:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
I updated the ROM this morning and I can post logs in the afternoon. This GCam mod doesn't work on Oreo. At least not the latest version. I think we should ask nullbytes because he is the author of the mod. I think he modified it to only use CPU, not GPU and it uses a lot of battery. Maybe another mod is needed after all these fixes and then it would work better.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
What about Oreo ROM with snap camera app or other camera apps like footej and opencamera? Do they work ok or no? To me it seems like the camera blobs might need the revert which was only done on pie ROMs and not Oreo ROMs
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Snap camera also had some bugs on Oreo if I remember correctly. Open camera works fine. I remember early Oreo builds had a lot of problems with camera inside apps like Facebook and Messenger but later on big bugs were ironed out.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ThE_MarD:
Heyyo, new Selinux enforcing build going up! :good: lineage-16.0-20191014-UNOFFICIAL-s2-selinux-enforcing is the same as the last build, but with selinux enforcing! Hopefully the last build we need to test.

As mentioned before, I'll be leaving the camera and Miracast bugs up to s2 maintainers, as trying to work on anything like that for a device I don't own wouldn't go well, and I'm not looking fora newer device as I own a nash (Moto Z2 Force) and my x2 (LeEco Le Max 2) so my spare time is still a bit lacking and I plan on helping those devices for LineageOS 17.0 next once s2 selinux enforcing is done... I did get lucky this set of night shifts with wifi though.

[MENTION=8738749]kalehrl[/MENTION] and [MENTION=10121505]tImI breakdown[/MENTION] and [MENTION=9686869]CptFlash[/MENTION] (cptflush from Telegram), please create accounts on GitHub and pm me your GitHub username and email addresses and I will change authorship of an sepolicy commit to you guys, one each so you will be part of s2's commit history. ;) I've already done one for gohaz0331, so your guy's turn! The constant logs I've received from you guys have been very instrumental in achieving what we have.

Any major issues? Please submit logs and you can always switch back to the permissive build and check if things are ok there too or not.

I'm uploading the build meow, so it should be up within 30 minutes of this post.

https://osdn.net/projects/lineageos-for-s2/releases/71763
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] kalehrl:
Hi [MENTION=6235294]ThE_MarD[/MENTION]

Here are the logs from the penultimate, permissive build.

Installed this morning and with increased size of 14MB from the developer options.

And thanks for the offer to immortalize our nicknames :D