yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S 5 Unified Development] cali.s:
[MENTION=4122877]curiousrom[/MENTION]

i have installed dirty over the latest official 15.1 build

i had remove addonsu before

wipe dalvil, cache system

install the rom, gapps and my micgain

i had to setup the launcher homescrean again
[Samsung Galaxy S 5 Unified Development] haggertk:
Regarding things hitting 15.1 getting to 16.0. In general, if something is submitted ("merged", even though it's not a git merge) to lineage-15.1 and it is either a fix that also impacts lineage-16.0 or is an enhancement that is wanted in lineage-16.0 it will get cherry-picked over. That said, the kernel source for lineage-15.1 and lineage-16.0 is currently still identical. Because it makes sense to see when things actually diverge, until such a time that there are lineage-16.0 kernel changes that are actually unique, I make a practice of pushing the HEAD of the lineage-15.1 branch to lineage-16.0 whenever anything is submitted on lineage-15.1.

Regarding the BT HID change. I don't like the actual implementation of the change (the research is certainly invaluable), because in general we prefer to backport/pick changes that went into actual upstream kernel source. Given that hid-generic support landed in 3.5, the picks from the original branch are straight-forward and trivial, but they are slightly more intrusive, so wider testing (I bought a BT KB and mouse and verified BT KB/mouse, USB KB/mouse, and digitizer multitouch myself) is prudent.

Which brings us to now -- lineage-16.0 is a perfect testing community. The 20181121 builds that I just uploaded contain the https://review.lineageos.org/#/q/topic:hid-generic-3.4-backport topic. If I don't hear any negative responses in about a week it will get submitted to lineage-15.1.
[Samsung Galaxy S 5 Unified Development] Couchy:
I found a minor and somewhat obscure bug:

- Start split screen with a dark themed app on top (Firefox private)

- Choose a light themed app for the bottom (Settings)

- Rotate the screen so icons are in the light themed app and turn black

- Rotate back and icons turn back to white except for the signal/LTE/wifi, which stays black

Obviously, I can't open a Jira report on 16.0. Can someone check if this happens on 15.1? Video is attached.
[Samsung Galaxy S 5 Unified Development] kurtn:
How did you detect root? If I type su in local terminal, I get "not found".
[Samsung Galaxy S 5 Unified Development] Rocthrower:
Has anyone been able to use Google Pay on 16.0? On the latest haggertk builds, 20181118 and 20181121, I have been able to write and read NFC tags, but the phone doesn't do anything at the terminal. I just restored a 15.1 backup, and it google pay works just fine. I will try to see if I can get a log when I'm somewhere that isn't too busy and the clerk doesn't mind me nerding out. :o
[Samsung Galaxy S 5 Unified Development] warism100:
HI every one , is the offline charging work in last build from haggertk ????
[Samsung Galaxy S 5 Unified Development] pmduper:
Appears to be working :good:
[Samsung Galaxy S 5 Unified Development] pmduper:
SM-G900I kltedv

Thank you [MENTION=2693412]haggertk[/MENTION] for your work. Much appreciated sir.

Very happy with LOS 20181121 build!!

Device operates very smooth and responds well to commands.

So far no fault found for how I use my device. Perfect!

I have no idea of SOT as I don't really care. I'm just grateful to have a 4 yo device with Pie :good:
[Samsung Galaxy S 5 Unified Development] curiousrom:
Re: Ibuprophen's Unofficial AddonSU for LineageOS 16.0

I guess [MENTION=2693412]haggertk[/MENTION] is too busy to reply to my questions in Installing Over Official LineageOS 15.1 w/ Only Wipe System? so I went ahead anyway & will post about if after some testing.

To reply to one of the questions in unofficial LineageOS 16.0 beta build 2018-11-21 the only options in > Developer Options > Root access are Disabled or ADB only. Not possible to enable for apps.

So yes please, I would like to try your Unofficial addonsu for LineageOS 16.0 on my SM-G900M klte as I would like to avoid Magisk if possible.

Edit: [MENTION=4828250]Ibuprophen[/MENTION] - Does it include a update survival script in /system/addon.d like LineageOS 15.1 su's 51-addonsu.sh or does it need to be reflashed after every update? It's not a big deal, just asking.

BTW LineageOS 15.1 ARM addonsu & SuperSU are not working on 16.0 @ the present according to some users' reports in this thread.

Could you post a link in this thread or PM me if you prefer?

Any tests you would like me to run?

***
[Samsung Galaxy S 5 Unified Development] haggertk:
That's an official -> unofficial, which involves a signing key change. There are ways that may or may not work, but I'm not going to recommend those. Official -> unofficial, and likewise unofficial -> official, "officially" require a data wipe.

Official 15.1 -> Official 16.0 will not require a data wipe. That is an upgrade path required by our charter.
[Samsung Galaxy S 5 Unified Development] cali.s:
[MENTION=8031265]kurtn[/MENTION]

Phone INFO -> Android ->Root-Exist: Yes

also Swyx Mobile app detecting Root
[Samsung Galaxy S 5 Unified Development] SNiPe08:
Your problem is very easy to fix. Yes, after you flashed the custom rom, root is detected that is where Magisk will save us from everything. Just flash the latest version (search the forums). For me everything works great even I can play Pokemon Go in my rooted S5! :D
[Samsung Galaxy S 5 Unified Development] Minas90:
Hi there,

Amazing work, almost everything works perfectly for me.

The only issue I noticed so far is that Performance profile in Battery saver and performance is not persisted after restart.

Eg I pick Quick and restart phone, it's still showing Quick, but core clock goes down to 300 MHz as if it's balanced.

Any idea about how to fix that?
[Samsung Galaxy S 5 Unified Development] 12h01:
Do you play Pokémon Go in custom rom?!

Mine stay just loading forever, then show a error and a exit button.

In any Custom Rom that I tried, it never worked.

* I don't use GApps. May this be a problem?
[Samsung Galaxy S 5 Unified Development] kurtn:
[MENTION=4187311]Setialpha[/MENTION] plays Pokémon go without GApps.
[Samsung Galaxy S 5 Unified Development] mhraqeeb:
Does anyone have a problem with turning hotspot on in transferring apps like Zapya?
[Samsung Galaxy S 5 Unified Development] eurohunter:
Wow, it looks like with all the major bugs fixed recently (selinux enforcing/hotspot/offline charging), S5 will be ready to receive official builds from day 1 :) I wonder if there is still anything major that is not working yet with lineageOS 16. On the other hand, if the devs fix everything, they may get bored waiting for their next challenge (android Q) :D
[Samsung Galaxy S 5 Unified Development] kurtn:
AudioFX and addonsu is not working. Major issue for me.
[Samsung Galaxy S 5 Unified Development] curiousrom:
Almost Done?

While the progress is amazing there is till plenty of stuff the devs are working on including sepolicy (SELinux), su, camera, kernel, Privacy Guard (not working @ the present), etc. Check https://review.lineageos.org/q/branch:lineage-16.0

"...ready to receive official builds from day 1" - When is day 1? ;)

"...waiting for their next challenge (android Q)" - That's a bit mean to put on their plate while the LineageOS team is working so hard on the current firmwares. :eek:

Grateful for 16.0 build 2018-11-21 which is perfectly usable as a daily driver.

***
[Samsung Galaxy S 5 Unified Development] DatzMrPig1862:
I couldn't agree more.Thanks to all the devs.
[Samsung Galaxy S 5 Unified Development] eurohunter:
haha, I didn't mean anything bad by it. I just think the devs look at the lineageos project as a hobby. and I was jokingly saying that if they fix everything so soon, they will get bored :p . Day 1 i meant whenever they decide to switch from 15.1 to 16.0 with official builds. I don't know when that is going to happen. But I was referring more to the overall completeness of the rom seeing that the latest build is definitely a daily driver.

Of course, I am very grateful for the devs sharing the newest builds with us.

p.s. selinux can now be set to enforcing in the recent build. Yet, I saw more commits about it that have not been merged yet. How can this be interpreted?
[Samsung Galaxy S 5 Unified Development] fbs:
sliding from "chat" tab to "status" tab on whatsapp is so much slower on 16 than it was on 15...

the rest is so smooth

have anyone noticed it too?
[Samsung Galaxy S 5 Unified Development] eurohunter:
I tested LOS 16 build 11/21. I have a G900P (kltedv) virgin mobile, a sprint mvno. I can't seem to be able to get LTE. I did a clean flash from nougat rom. I flashed the rom, and flashed the VMU apn fix R2 zip file as i usually do to get data in los 14.1 based roms. All i get in Los 16 is 3G. and the carrier shows as sprint, not virgin mobile as it should. does anybody with a similar device have this issue, or found a way to get LTE? If logs are needed, i can provide them.

Other than that, everything seems to work correctly. phone calls, sms, 3g data, wifi, camera, hotspot, NFC.

I also noticed that in general the brightness is lower on los 16 than on los 14.1. I have to slide the brightness almost to the maximum to acquire the same brightness that i could achieve on 14.1 by going to half or 2/3 of the way.
[Samsung Galaxy S 5 Unified Development] eurohunter:
Thanks a lot for your comprehensive response. I just realized this issue was present even on 15.1. I checked the Bugbash 1986, and it seems like that's the same thing I encountered on 16.0 as well. I will try a few things, but i don't think i'll be successful. :(
[Samsung Galaxy S 5 Unified Development] portsample:
I'm running lineage-16.0-20181019-UNOFFICIAL-klteactivexx.zip on my S5 Active G870F and have been very pleased with it. However, I have tried installing all of the other ROMs released since with no luck. No problem with the install using TWRP 3.2.3, however when I go to boot the updated OS, I get the Android "Downloading" screen rather than Lineage. Rebooting with volume up + Home gets me back into TWRP where I can reinstall the 20181019 zip again. This installs with no problem. I've been doing clean installs with cache and data partition wipes beforehand. Suggestions? TIA...
[Samsung Galaxy S 5 Unified Development] haoyangw:
Haha selinux is currently usable, but it's not perfect. Selinux policies are usually constantly updated as they can be too harsh(causing apps to fail) or too lax(so your phone is not secure enough). This is especially since our device is old and isn't exactly complying with the highest security standards(like separate camera and media processes. But no choice because our vendor libs are old), so we need to implement additional policies that newer devices don't, which takes more testing and time. So yeah, no need to worry about the selinux updates, there already is very decent security in place with current selinux policies, just that sometimes more specific issues need to be addressed(for specific apps/vulnerabilities).
[Samsung Galaxy S 5 Unified Development] curiousrom:
Re: Update Fail S5 G870F klteactivexx - TWRP Log

You did not describe your setup which makes it very difficult to troubleshoot. :eek:

Did you install any GApps, custom kernel, Magisk + modules, Xposed or any other system modifications? :confused:

Magisk may cause update problems. If you have it try uninstalling it using the Magisk Manager app, reboot to system, reboot to TWRP & try installing the update again.

See also "Latest Uninstaller" in the Magisk v17.3 thread which always should be in the external storage in case of emergency anyway.

"No problem with the install using TWRP 3.2.3..." _ That's not obvious. After flashing the update but before booting to System in TWRP > Backup > Select storage > select Micro SD card (the external storage) > OK. Back to Home > Advanced > Copy Log. TWRP will show: Copied recovery log to /external_sd/recovery.log.

You can open /external_sd/recovery.log with Wordpad or Notepad++ for example & check for errors and/or rename it recovery_log.txt & attach it to a reply.

Note that TWRP has MTP enabled by default so you can connect to computer & copy that log & because you are having problems make sure you have a fresh full backup made with TWRP before attempting to update again.

***
[Samsung Galaxy S 5 Unified Development] Ibuprophen:
My deepest apologies for the delay in responding...

The Unofficial AddonSU (ARM) for the LineageOS 16.0 that I had created was a rough first attempt at this.

I had originally created it in hopes of testing it on my G900V (Primary Device) after I accomplish the replacement of the USB Daughterboard. I just received the adhesive yesterday and am about done with the assembly.

I'm currently using my G900T (backup device)...

One other member tested it out and, though it had flashed fine in TWRP, he had stated that he was not able to locate any Superuser settings within the Developer Options.

So I can't figure out what, where, how, etc... until I can begin testing it to figure out what needs to be done (or undone so to speak).

~~~~~~~~~~~~~~~

UNLESS asked to do so, PLEASE don't PM me regarding support. Sent using The ClaRetoX Forum App on my SM-G900T device.
[Samsung Galaxy S 5 Unified Development] curiousrom:
Re: Ibuprophen's Unofficial AddonSU for LineageOS 16.0

Thanks :good: for the reply.

No apologies needed for the response delay. Seeing the American flag under your avatar I presumed you were doing some Thanksgiving stuff or whatever pleases you.

"One other member tested it out and, though it had flashed fine in TWRP, he had stated that he was not able to locate any Superuser settings within the Developer Options." - After installing on S5 G900M haggertk's 16.0 beta klte build 2018-11-21 > Developer Options > Root access > the only options are None or ADB @ the present as seen in the attachment. So it's not possible to enable root for both ADB & Apps unless some hacks I presume.

The third screenshot in that group is Settings > Security & privacy > Trust > showing Root access: ADB only. Note the SELinux Enforcing enabled with the build 2018-11-21.

View attachment 4650357

The explanation may be in this patch: 226142: Settings: Add developer setting for root access: "It is possible to be running a user build with a debuggable boot image. In this case, "su" will not be available. So only show none/adb.". Only [MENTION=2693412]haggertk[/MENTION] could confirm this.

After installing Magisk v17.3 a couple of hours ago because I need root > Magisk Manager > Settings > Superuser Access > enabled both ADB & Apps, Root access disappeared from Developer Options (screenshots) & Trust still says Root access: ADB only for some reasons.

View attachment 4650358

This said I'm still interested in testing your unofficial AddonSU for 16.0 if you decide to pursue that project.

You may want to check those:

https://review.lineageos.org/q/SU

project:LineageOS/android_system_extras_su branch:lineage-16.0

topic:"pie-su" (status open OR status:merged)

Interesting: 232442: Settings: Root appops access in developer settings
[Samsung Galaxy S 5 Unified Development] haoyangw:
Hmm if you're thrown into the 'Downloading' screen(this is called the 'Download mode', only found on Samsung phones) you likely have no ROM or kernel installed, i.e. /system is empty or your boot partition is empty(or both). Like curiousrom suggested, check the TWRP log(either use the copy log option, or under TWRP terminal, run 'cat /tmp/recovery.log'), and see if any errors occurred. Can't really help much without knowing what exactly caused your ROM install to fail :(

---------- Post added at 03:51 AM ---------- Previous post was at 03:35 AM ----------

I believe this is intentional, root may not be fully working yet due to (I presume) new security updates in Android Pie, and so I think the root for both ADB & Apps option doesn't even exist yet(and hence you can't select it). Root over ADB is much easier to implement so it's already available. The LOS team is definitely working on it though!

Actually what that line meant is this. LOS can be built in 3 variants, user, userdebug and eng. 'user' LOS builds will not have su installed at all and so the LOS team disables root(for apps) for 'user' builds(because without the 'su' binary there can't be root for apps. Adb root is different I guess). Problem is that I think having a debuggable boot.img(i.e. kernel) can cause LOS to think 'su' is available, even on a 'user' build, so the team disabled root in that case. But that doesn't affect us, as all these builds we have now are 'userdebug' builds that are supposed to have 'su' binary installed by default

That's normal. The 'root access' option under developer options likely checks for a 'su' binary under /system(probably under /system/bin?), as LOS still uses the 'old' way of having 'su' under /system for root. Magisk is different, it hides 'su' under a completely different filename and under /data or /cache so LOS will not find 'su' under /system, and hence that option is hidden. Trust still says 'Adb only' because you chose 'Adb only' before, which saved your selection in the system settings and remained there even after you switched to Magisk. So Trust simply checked the system settings and thought you still selected the option 'Adb only'. Magisk saves its 'Root access:' option under its own app settings, which is separate from system settings so Trust doesn't detect your Magisk settings.

Hope this clarifies! :) I believe addonsu is intentionally blocked atm because the team has tested and verified that it doesn't work so they decided not to allow anyone to use it, even if you flash the right zip in TWRP
[Samsung Galaxy S 5 Unified Development] curiousrom:
Re: Ibuprophen's Unofficial AddonSU Beta 1.0 for LineageOS 16.0

"Hope this clarifies!" - Yes it does & Thanks :good: for the detailed reply. :cool:

[MENTION=4828250]Ibuprophen[/MENTION] shared his Unofficial AddonSU beta v1.0 for LineageOS 16.0 w/ me & after flashing on S5 SM-G900M (klteub) running haggertk's beta LineageOS 16.0 klte build 2018-11-21 + Open GApps Pico w/ Magisk v17.3 totally uninstalled, system rebooted, rebooted again in TWRP for flashing I do get adb & apps option in Developer options > Root access but no luck granting root to apps.

Trust panel confirms Root adb & apps & DevCheck confirms root as seen in the screenshots but even after rebooting & dirty reflashing 16.0 w/ wiping the caches still no luck in granting root to apps.

Tried clearing Data for those apps & still no luck. Installed a new app requiring root & no luck.

I can see in the logcats:

E/su ( 8122): Apps root access is disabled by system setting - enable it under settings -> developer options

D/su ( 8122): access_disabled

W/su ( 8122): request rejected (10164->0 /system/bin/sh)

It could be related to what [MENTION=2693412]haggertk[/MENTION] enabled or not in his build 2018-11-21 because w/ Magisk v17.3 & root enabled for some apps like App Ops - Permission manager by Xingchen & Rikka I could not modify some app permissions.

In App Ops on S3 i9300 w/ LineageOS 14.1 I can see Run at startup permission & toggle the apps listed under it while it's not listed in App Ops on beta 16.0 build 2018-11-21.

Privacy Guard is also disabled @ the present in this build so it can be related to that. I also did not find a way to disable startup for some apps & if you have some suggestions for that it would be appreciated.

If you are interested in the logcats & recovery logs captured during the testing of Ibuprophen's Unofficial AddonSU beta v1.0 for 16.0 just PM me.

***

Edit: Nobody replied to my question: :crying:

Expanded Desktop Crashing? :confused:

Can you guys with haggertk's 16.0 build 2018-11-21 check if Settings > Display > Advanced > Expanded Desktop is working for you? It's crashing Settings for me & never opens.

***
[Samsung Galaxy S 5 Unified Development] eurohunter:
Yep, I tried it and it doesn't work. it never opens. it just goes back to the previous settings menu.
[Samsung Galaxy S 5 Unified Development] eurohunter:
A couple of more things i noticed while using this rom (11/21) with my kltedv G900P Virgin Mobile.

-I activated the "Do Not Disturb" option, and I muted sounds except for alarms and media. Also, I specified "No sound from notifications", however, I keep hearing the sound whenever a notification pops up. Does anyone else have this issue?

-Also, it seems like there is no weather provider pre-installed (like yahoo) as it was in previous versions.

-This is probably the case with sprint mvno versions. but I flashed the rom after having it on stock rom and somehow got lte working right away after trying so many times. the only thing is that it shows the carrier name Sprint, not Virgin Mobile. it sends sms, it just doesnt send mms.
[Samsung Galaxy S 5 Unified Development] curiousrom:
Re: SM-G900P kltedv LTE Problem

I'm a bit confused.

In a reply to suggestions made in SM-G900P kltedv LTE Problem in which I asked you the baseband of your SM-G900P kltedv you replied:

Now you say "...I flashed the rom after having it on stock rom and somehow got lte working right away...".

So did you try any of the suggestions?

Did you flash a stock Samsung rom then flashed the build 2018-11-21 again & it fixed your LTE problem? Did it change your modem/baseband?

It's possible that having stock Samsung it activated SIM provisioning.

What is you current modem?

"...it just doesnt send mms" - Did you double check the APN settings?

Anyway MMS is not a biggy. My network provider eliminated that service because most of it's customers are using WhatsApp.

***
[Samsung Galaxy S 5 Unified Development] Puncan:
I have the same issue with do not disturb but it begins to behave after some time g900f device
[Samsung Galaxy S 5 Unified Development] eurohunter:
haha yes, i tried a number of roms to see how the LTE issue behaves. LineageOS 15.1, a couple of Resurrection Remix Oreo, LineageOS 16. The problem was that, after tinkering with apn config and carrier settings in these roms, sometimes I would lose data entirely, and the data wouldn't come back even after clean flashing LOS 14.1. So, after every try, i found that the safest bet would be to odin back to stock (latest baseband) to get LTE back, then odin twrp, and then flash the custom rom. i must have odin-ed like 4-5 times these 2 days haha. The LTE issue is so odd. in oreo roms, i get LTE, but it shows up as sprint, and sms doesn't work. When force 3G, it switches to Virgin Mobile and sms works. With LOS 16, it stays on Sprint both under LTE and 3G, and mms doesn't work on either. so whenever carrier shows as sprint, something wrong is present. Last time when i wrote the first post, i only picked 3G in LOS16. maybe that happened because i clean flashed from LOS14.1 and not from stock. I dont know. oh well. :rolleyes:
[Samsung Galaxy S 5 Unified Development] curiousrom:
"Latest" & "most recent"

"Latest" & "most recent" is for people too lazy to write a date or version. :rolleyes:

It's my pet peeve. :silly:

***
[Samsung Galaxy S 5 Unified Development] eurohunter:
lol QD1. Our baseband has been like that for a year and a half :) I also added some logs to my previous post. Just in case

ah, i shouldn't report problems so quickly. now mms and sms are both working with LTE, i don't know why. will test some more
[Samsung Galaxy S 5 Unified Development] saikyom:
is there an option to disable programs at startup, like windows msconfig?
[Samsung Galaxy S 5 Unified Development] Aragona83:
Battery consumption

Do you think my battery life is normal? https://is.gd/TbVOQn
[Samsung Galaxy S 5 Unified Development] hightension:
i confirm that it crashes. smg900f.
[Samsung Galaxy S 5 Unified Development] Scorpionea:
Almost 2 and half hour SOT with battery left at 47% I would say it's pretty awesome .