yashsingh1/xdaforums huggingface dataset:
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
No idea, I did using magisk prop so that's it. Try manually edit it using text editor or other app?

Mine charge normally. Either its battery fault, cable fault, or.. Something else.. like my laptop which battery broken, it won't charge past 92%.

Tough, it's normal for any "quick charge" supported devices to slow down after hitting 80% mark, but it should charge fully.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
I think I should change the battery then. The phone is only usable between 84% and 29%. (about six hours of medium usage). It never goes above 84, and never goes below 29. As soon as it drops below 29, it shuts down.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] its tannu:
Masterawesome sir this is not lineage related but pls help me.

Actually my device volte not working in any custom ROM.

But it's working perfectly in stock rom(8.1). I take efs and persisit backup of stock rom and restored in custom rom by twrp. But volte is not working. I also flashed bholte fix zip. But volte is not working

Pls help me to use volte in every single custom rom.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] Chromag9:
Anyone have any ideas why I would be having any problems with wifi? I have a US-based G5S Plus purchased unlocked. I went from stock to installing TWRP and formatting/wiping everything and installing this ROM. Installing from TWRP went fine and everything seems fine except for wifi. When I try and connect to my local wifi network (that I used when on stock and is being used by other devices) all I get is "Obtaining IP address..." and it never connects. Any ideas?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
Can you please share what you did? Finding the optimised set of permissions for AFWall+ is a real pain.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
Encryption is pointless on an unlocked device because TWRP can decrypt it without requiring any password.

Encryption works only in combination with locked bootloader. Even if a thief unlocks the bootloader, the unlock process deletes the encryption keys.

It is possible to use some devices with custom ROM and root while the bootloader is locked. I used to do that with my Xperia Z2. But TWRP could still read storage and you can't do it on a Moto G5s plus anyway.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
You got wrong info here..

TWRP can't decrypt partition without its original password. Most likely you got it from here :

"decrypt your device by formatting data"

most people used that word NOT to decrypt data partition but to format your data partition, so that you don't have encrypted data partition.

No need to decrypt if you don't have encrypted storage in the first place. *insert meme here*

Also, people rant about unable to enter TWRP because they don't understand how to input their password, thus someone will say that decrypt thing again.

Encryption did work on old build (don't ask me which, I'm not ready to redo backup-restore everything). So, encryption is not pointless. Thief can choose between formatting data or trying their best to decrypt it, I'd go with former and just sell it.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
Files get decrypted every time you access it. TWRP lets you browse the contents of internal storage. It also lets you connect the phone to PC in file transfer mode.

If you can flash Magisk from TWRP then TWRP can decrypt the storage. How else is it gonna write to the data partition? Maybe if Android had partial encryption like Windows.

---------- Post added at 11:52 PM ---------- Previous post was at 11:36 PM ----------

If you can somehow manage to hide the encryption keys from TWRP then it will be unable to do most of its functions, including the ability to flash zips and take backups. Also, if the device goes into bootloop due to a faulty Magisk or Xposed module, there will be no way to recover the OS. You will have to start from scratch.

---------- Post added at 11:58 PM ---------- Previous post was at 11:52 PM ----------

Encryption on a rooted device serves three purposes: it slows down the load time of TWRP, it makes switching ROMs a pain, and if for some reason if you need to sell your device, you wouldn't need to run secure eraser.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
>TWRP lets you browse the contents of internal

Only after you're inputting your password. Like, did you ever actually set pins and encrypt your device? it SHOULD ask pins even if you want to boot to system.

>partial encryption

I don't know what partial encryption is, all I know is either full disk or file based encryption.

Full disk encryption, to put it simply, work similar way, whether it's andorid, window, linux, etc.. Heck, any encryption work similar way, there are keys, salts, etc etc..

Andorid (full disk encryption) only encrypt data partition, not system. Thus, even without magisk (magisk only inject boot, won't affect anything if data partition is empty), system still intact, simply format data and viola, you're booting up your device.

"twrp can decrypt your partition" means "twrp ABLE to open your door (with required keys)" It doesn't mean "twrp WILL open your door", mind the word able and will.

>If you can flash Magisk

Magisk is preventing dm-verity or forcing encryption so that your not encrypted device able to boot. Magisk don't/won't decrypt your data.

Bootloop caused by magisk? Restore boot. caused by xposed? There are uninstaller, or reflash whole rom. You don't even need to wipe data.

>Encryption on a rooted device serves three purposes

It serve its purposes, it's just not for you.

Is it slow? Yes, even it will slow down booting to system, somewhere out there people are using multilayered encryption (serpent, twofish, the hell with alien words) for their computer devices, it took considerable time to boot. I myself encrypt my data even it's file based. They found my encrusted files? No problem, they need to decrypt them anyway. I don't even remember my password and salts. I'm more than happy if device encryption can work again..
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
TWRP doesn't have any password protection. So what's the difference between "can" and "will"?

And I just checked the Magisk installer script. It definitely does mount the /data partition. There were total 25 hits for /data in all three of its scripts. Here is one example:

initialize() {
# This path should work in any cases
TMPDIR=/dev/tmp

mount /data 2>/dev/null

MAGISKBIN=/data/adb/magisk
if [ ! -d $MAGISKBIN ]; then
echo "! Cannot find Magisk binaries!"
exit 1
fi

# Load utility functions
. $MAGISKBIN/util_functions.sh
}
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
You can boot to TWRP, but TWRP won't open your door. I just wrote it with door instead of encryption. If you have time to spare and a will, encrypt your device. Warning tough, encryption broken, you won't be able to boot to system. It'll ask password even if you enter correct one. Then boot to TWRP, you'll know what I mean.

Magisk mount, yes, they just make sure that it's required files is there. If not (broken data or not decrypted data), it's still bootable. Try it yourself.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
That doesn't make any sense. What is the point of an encryption that doesn't allow the device to boot even if I give it the right password?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
This whole conversation initially is about your comment about "this rom encryption is broken", did you just forget that?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] baruch31:
hum I allowed root application, so it's not really optimized, i'm afraid...
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] 19Patrick:
Hello,i flashed the last version of the rom. My fingerprint sensor dose not work. Before i used havoc Os but there was an other issue. After deep sleep the phone dose not connect to the lte network.

How can i make the FP sensor work?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] QkiZMR:
Did you really try encryption or just talking?

I have encrypted data partition and phone is asking for PIN code during boot. TWRP can't mount encrypted data partition without that PIN or password. Without providing PIN to TWRP I only have access to system partition but not to my settings or files because ma sdcard is also encrypted.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] Chromag9:
Has anyone gotten MicroG + UnifiedNLP working with this ROM? I installed MicroG and the self check looks all good except for UnifiedNLP. It's showing up as not working. I tried installed a couple different NLP backends (Mozilla, Apple) but still no luck. Just curious if this was working for anyone else that didn't install the full GApps and went the MicroG route instead.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
I had TWRP on stock ROM for a long time. I never saw any situation where TWRP asked for password to flash zips or perform backups or anything like that.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] QkiZMR:
because you didnt set PIN code/password on lockscreen and enable prompt for password during boot. here you have password prompt in TWRP when you have encrypted data partition and enabled password on boot time:

[IMG="twrp asks for password"]https://www.wykop.pl/cdn/c3201142/comment_Z3P98sQ5DSF1tRmcONffFRyoE6n2qDgN.jpg[/IMG]
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] 19Patrick:
Any idea to get FP sensor work.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] 19Patrick:
I ve got it, thanks to all
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] XDFefo:
Hi. Is there dual boot support for this ROM (phone even)? Couldn't find any info searching the thread. I wanna try the options before commiting. Last I've dealt with dual booting was with MultiROM, about the time Dual Boot Patcher appeared.

If not, how's support for the 4GB RAM XT1805 version? There's so little info about this variant that I'm not sure if it's the same as vanilla XT1805.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] sbcontt:
What? I always had password.

OK here is the thing: These days Android comes with Encryption enabled by default and on many stock ROMs there is no way to turn it off. It looks like this: [IMG="android_encrypt"]https://static.makeuseof.com/wp-content/uploads/2018/06/android-encrypt-2.png[/IMG]

It has always been enabled as long as I had stock ROM. I had to run dm-verity- forceencrypt disabler zip when I switched to custom. But TWRP always used to work. Don't ask me how. On devices where TWRP does throw that password screen, like my older phone, it always fails to decrypt, even if I provide the correct password.

That's why I always saw that password screen as a bug and auto decryption as the standard behaviour. If it is supposed to be any other way... then I have never seen it. Since this LinageOS ROM doesn't support encryption anyway, I can't try it this time either.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
Well, you can read about whatever encryption on Android here, do read both link. It's not a bug, it's just how full disk encryption works. For your last sentence, your older phone's TWRP has problem with encryption.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] QkiZMR:
it works like this:

- phone is unencrypted - TWRP has access to data partition and it will works

- phone is encrypted and has unofficial broken TWRP (especially old versions), phone has password/PIN code on lock screen and system asks for it during the boot time - TWRP has broken decryption support. TWRP can't mount encrypted data partition even if you enter good password/PIN.

- phone is encrypted and has proper prepared TWRP, phone has password/PIN code on lock screen and system asks for it during the boot time - TWRP can mount encrypted data partition and adopted storage on sd card if it's enabled. Of course start of TWRP is longer than without encryption but it works. I can backup and restore encrypted data partition. Even after data formatting and removing encryption but this it's tricky and requires knowledge about Linux encrypted volumes.

Of course using encryption without enabling asking for password/PIN code during boot is useless. Data partition is encrypted but with standard key which is generally known. Then TWRP will not ask you for password because it will first try standard key. Some one can easily access your files via TWRP. So enabling asking password/PIN code during boot is important on custom ROMs. I enabled it even on stock ROMs.

Maybe you used broken version of TWRP. Now I'm on last official version of AEX which support encryption and TWRP which working fine with encrypted data partition and adopted storage on sd card. Adopted storage on SD card is also encrypted. But with Linux and knowledge how it works you can mount it on Linux PC and access files on it. It requires encryption key to adopted storage which is on data partition.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] MasterAwesome:
Update

Since i've been PC-less for a while I haven't been able to contribute much to the development of this ROM. In around 2 weeks or less I should have a desktop to run all my builds. That being said, there will be one more build for lineageOS 16 and will be marked final AFTER a few tests and bug reports(?). The development will focus on LineageOS 17 from the date of the Final build

Thanks for sticking on,

MA.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] andre.h:
Sounds good!

Would you consider integrating the wireguard kernel module (hxxp://git.zx2c4.com/android_kernel_wireguard/tree/README.md)? That'd be swell, thx ;)
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] Jagx:
wow thats good news... thanks a lot man :highfive:
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
Bumping, after that conversation about FDE, decided to go few pages, twrp site and then lineageos Gerrit, found this cryptfs thing. And few search show that this erfan abdi did PR mostly on moto devices with metadata flag.. Are we the same? I can't test/get the log for it tough
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] YurekaYuser8142:
Ps4 controller support..

My dualshock 4 controller gets detected by Bluetooth and gets connected also but sadly there is no input by the controller but it is still connected...

Even tried with USB OTG but no luck there also...the controller starts

This controller worked like a charm in the stock ROM...

I just wanted to know if there is any fix
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] XDFefo:
My phone was going kaput after fiddling too much with the base rom so I took the oportunity to try both LOS and Pixel XP, and the former was more fit for my tastes. So far so good on the last build. A few questions:

- What's the prefered method of rooting, Magisk or LOS extra pack?

- While I was testing both roms I made a TWRP backup to save my settings, but wasn't sucessful in restoring it. What do I need to backup and restore in this case?

- Can I flash a new logo to remove the bootloader warning without changing the bootanimation? Seems like the stockish motorola ones will overwrite it.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
1. Depend on you, both give root access, Magisk have this so called module which if you don't need them, nothing matter.

2. Should be done by backing up /data but I won't do it since it's way too big and even some app settings not saved. Just forget it, redo all the way to make sure no app data corrupted which make system unstable/crash

3. Yes
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] XDFefo:
Tested my 1st gen DS4 and it worked, finally with proper inputs. Felt a little laggy at times, so maybe you still need Bluetooth Auto Connect to deal with it.

Thanks, Magisk worked nicely and it seems that SafetyNet is still on. So far no need for backups, but I'll note that and use them as a last resort. Boy I miss MultiROM.

Yes, it'll replace LOS bootanimation or yes, it'll only change the warning? The image zip doesn't have a flashable logo available and I rather deal with a silly warning instead of a color blast midnight. Much appreciated by the way.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
Bootlogo is not bootanimation, bootlogo show few seconds after you press power, then bootanimation come with.. well.. animation.. that line and circle thing..

If you change bootlogo, only bootlogo will be changed.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] XDFefo:
For some reason I thought they where linked, my mistake. Thanks!
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] MasterAwesome:
Build will be up this Saturday, no user facing changes just security patches for this one.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] MasterAwesome:
New build - September patch

Build: https://github.com/MasterAwesome/android_device_motorola_sanders/releases/download/lineage-v15/lineage-16.0-20191004-UNOFFICIAL-sanders.zip
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] tomcat-:
Hi all,

I have a g5s plus dual sim (xt1805) which is running stock Rom.

I'm thinking of upgrading to lineage 16, as currently i'm experiencing some slow downs with stock

Is everything operationally in this rom and how is dual sim functionality in lineage 16?

Thanks
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] nooope:
Good evening, All,

after I've flashed the latest build it seems my phone's screen is not turning off during suspension anymore, (it keeps showing some sort of clock screensaver) and battery life got sensibly shorter.

Am I the only one noticing this behavior?

I've dirty flashed over a build from April, could this be the cause?

Any suggestion would be much appreciated,

thanks in advance.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] testeraphy:
Always try searching this thread first, start with "always".. So yeah, use search feature next time..

Now for that answer, search "always on" on settings, disable that.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] nooope:
Yep, you're definitely right, my bad, sorry.

In my defense I've spent like half an hour looking at settings without noticing that one...

Thanks for the answer and I promise I'll look better next time before asking.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] andre.h:
I get that too, but that also started happening with the build before that. I think it started happening with a play store self update. Letting the phone just sit there and watching logcat, I get various play log update crap and some crypto errors over and over again. Dunno if its related to that though...
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] icecoldsipra:
Hello Friends!! I am trying to install the latest LOS 16.0 build but unable to get Gapps and Magisk working. I have a stock Oreo 8.1 unrooted rom. Below are the steps I followed.

Step 1 - Booted into bootloader and installed twrp 3.3.0 from fastboot

Step 2 - booted into twrp and formatted data to remove encryption on internal data. Without this i am asked for a password which i have never set.

Step 3 - installed the latest LOS build and immediately flashed gapps which is opengapps pico arm64 version and then immediately flashed magisk too

Step 4 - wiped casche and rebooted phone. It takes a really long time to boot, showing the los boot screen and then boots back into twrp again.

If i try flashing only los zip file at step 3, i am able to boot properly but i am having no sim error. I have trying to get things working for last few hours. Now switched back to stock oreo rom.

Kindly guide me on how I can get Los, gapps, magisk and mobile network to work on my phone.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] pradeeppk:
Format data, wipe system, cache and install LOS, gapps
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] nooope:
Hi Andre,

have you tried this?

(it's the "always on" option of Ambient Display), disabling it worked for me.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] icecoldsipra:
I have tried this too. After flashing all the zip files, i get the Los boot screen for a very long time (~10-15 min) and once it boots successfully, the sim card is not detected.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] andre.h:
I meant the battery life, hence me quoting that part ;)

On that topic, if i disable LTE the battery life gets better. Maybe it's really those play logs that make the device toggle LTE all over again...
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] PingoBingo:
I've just created my account on XDA to thank you for providing this rom, Thank you so much :). Just found an Issue about battery backup It's draining quite fast Device: xt1804 sanders
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] icecoldsipra:
Hey, just curious. Did you install this rom from Stock Android 8.1? If yes, what steps did you follow? And which twrp did you use too? I'm still facing problems getting this rom to work. Any inputs would be greatly appreciated.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] PingoBingo:
Yes I did flashed from Stock 8.1(july security patch).

• First I unlocked my bootloader using moto's official process.

• Then I flashed an unofficial TWRP recovery V[3.2.1]_r22 via Adb/fastboot.

• Cleared /dalvik, /system, /data, /internal, /cache.

• Flashed this ROM via TWRP. :)

• Flashed MicroG and Magisk v20 after that.

• Rebooted.

----And VOILA ! It's done---

[Bonus]Also flashed a Custom Logo.bin file via Adb. That's edited by me specially for Lineage OS ;)
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] andre.h:
Oh, so you observe the battery drain even with microg?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] PingoBingo:
Yes, I even Flashed MAYHEM Kernel V4 Non-treble and also disabled 2 cores but no luck :(
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] andre.h:
Hm, the other thing I noticed via `adb logcat` is that the sensors wake up the device quite often. Like everytime it's moved, even just a little bit. I guess just walking around with the device will result in many wakeups, maybe it's related to that?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] RossiniBr:
I installed this rom but it does not unlock with sensor biometro, nor appears to do a biometry, how to do that?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] EmiAndroid:
Come from stock Oreo?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] puneet800123:
Volte not working for me :/ shows only LTE
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] RossiniBr:
Yes, I came from Oreo and then I installed this one by twrp
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] maliceomalice:
im sorry, but which gapps should i choose? is it 7.1, 8.1 or 9.0?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] vinod meel:
Definitely 9.0
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] suyash09:
yes wifi and pixel launcher are not working..every other thing seems to be fine
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] Jnitrofish:
Everything is working well, except VoLTE. LTE shuts off as soon as I make or receive calls. Any recommendations?
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] blitz5:
SafetyNet fail

How did you pass SafetyNet test? I get a "Basic Integrity: Fail" and "CTS Profile Match: fail" when I check for SafetyNet

I have neither installed Magisk nor rooted.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] KrackerJak13:
Seems all 9.0 do not support encryption so I'll wait till encryption is supported.
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] marshmello_61:
Yes, ofc
[Moto G5S Plus ROMs, Kernels, Recoveries, & Other D] XotusBlack:
Flashed on XT1805 with Internal Data Wipe, otherwise it will not boot, as KrackerJack mentioned.

So far everything works, except > Theme select (Dark) crashes the App and it doesnt apply.

Does anybody know how to remove the google bar ? Cant find the settings.....