yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] red5pade:
Is it just me or does the auto brightness minimum dim setting default to 10% instead of the brightness slider at 0%. It's really annoying
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Y1NY4NG:
wishes :)

Is it possible to add the googel camera?

What would also be interesting: smart Charge.

Oh yes and if possible you can deactivate the provider clock etc. in the locksceen so that only the clock, weather and or alarm clock is active.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] @dirpatgaonkar:
How do I update to the latest build? I have to clean flash or dirty flash the zip? I know this is a noob query, however I couldn't find any answers to this in the forum.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] burakcank:
I also wonder how this process is done since I am a beginner with roms. Do I need to download the latest zip and dirty flash it via TWRP or what kind of process should I follow ?

Edit: I am especially curious about this because firmware version has changed, right ? Should I download the latest firmware too ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
First time installation:

- Do necessary backups

- Remove PIN if coming from OOS

- Reboot to TWRP

- Wipe system / data / cache / vendor and format data

e, crDroid and Gapps (also no-verity if you want to run decrypted) then reboot and do setup

- Install Magisk / Root add-on for root

Update installation:

- Do necessary backups

- Flash new firmware (if there is one), updated ROM base and Gapps (and Magisk if you had this as root method, followed by no-verity if you want to run decrypted)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sc4r3Crow:
[MENTION=3795148]neobuddy89[/MENTION]: After flashing latest build Magisk shows ctsProfile: false.

Is that a known issue and is there a solution for that?

Edit: Can be solved with using MagiskHide Props, but should work out of the box. Can you fix it in next build?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] rapdes:
I have the same issue
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sc4r3Crow:
Solved: Use MagiskHide Props and edit device's fingerprint...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dd0s:
Any chance to use weeb kernel?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Adromir:
Make a backup and try then you will know
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dd0s:
Okay, not a good answer but an answer. Its the custom Version that works.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jay0r:
Could you do me a favor and explain this a bit better?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sc4r3Crow:
Install the mentioned module in Magisk. Then install an Terminal Emulator, there you enter the word props and just follow the shown steps to select and install a fingerprint for OP5...after that ctsProfile will be set to true :good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sc4r3Crow:
Did it work?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jay0r:
Yepp thanks a lot for the information about the Magisk Props. It's a cool module where you can even do more tweaks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sc4r3Crow:
:good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
Update

29th July, 2019

Build type: Nightly

Device: Oneplus 5 (cheeseburger)

Device maintainer: neobuddy89

Required firmware: 9.0.7

Short changelog:

* More accent colors from familiar brands

* Improved location detection

* Improved localization / translation for Q Clock

Download:

https://sourceforge.net/projects/cr...d-9.0-20190729-cheeseburger-v5.6.zip/download

Firmware:

https://sourceforge.net/projects/cr...firmware/firmware_9.0.7_oneplus5.zip/download

Cheers.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] fandroid7:
Can you add the recent app lock toggle on recent app list? Just like the oneplus recents providing it...?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
Is it just a display issue that the date of security and hardware patches is displayed wrong? See attached screenshot. Thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] rapdes:
Are you using magisk prop hide? If so it also spoofs the security and hardware patch of the fingerprint used, but in reality you are up to date.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
Exactly that. Thanks for the reminder!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sc4r3Crow:
I have problems with the hotspot function...

When I connect my car radio to my phone speed of mobile data seems to be very slow. I didn't have that problem with other roms.

Is that a known issue?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Hastaloego:
can all 3 hardware keys be used with long tap and double-tap ? can "menu" be set to back or last app key with long tap or double-tap?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
See my screenshot, that are the settings which are possible.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Hastaloego:
thank you but wow that is disappointing. they still have not expanded that over the last year.

this is from the custom rom im actual using
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wizardknight:
I am using the latest rom, and firmware. When I place a call using google voice, the other party has been reporting that they have a hard time hearing me.

I like to make IP based calls as the cell reception at my location is poor. This is why I usualy use google voice for my calling needs.

I am wondering if google voice might be using the wrong mic, or if the default mic gain is too low.

Does anyone know if there is a way to boost the volume?

Is anyone else getting this kind of feedback during calls?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jay0r:
No problems with Google Voice here in Germany. Is your wifi connection stable and fast enough? I made the experience that G-Voice react horrible to high or vary latency.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wizardknight:
Wifi connection is not the issue here. The other party can hear me. The volume is just very low to them. I have to speak loudly for them to hear me clearly.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jay0r:
Okay. Try the recorder app, maybe your microphone is dirty/broken. I'm on the latest crDroid with latest firmware like you and asked today my girlfriend about the quality while a call. Everything was fine. I tried it with G-Voice and regular GSM call.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
Update

11th August, 2019

Build type: Nightly

Device: Oneplus 5 (cheeseburger)

Device maintainer: neobuddy89

Required firmware: 9.0.8

Short changelog:

* Android August Security update (9.0.0_r46)

* cheeseburger: Updated blobs from OOS 9.0.8

* cheeseburger: Upstreamed kernel to v4.4.188

Download:

https://sourceforge.net/projects/cr...d-9.0-20190811-cheeseburger-v5.7.zip/download

Firmware:

https://sourceforge.net/projects/cr...firmware/firmware_9.0.8_oneplus5.zip/download
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] burakcank:
The reason I keep coming back to stock rom is, I don't want to deal with the hassle of flashing roms whenever a new version is out. While I am on stock rom, there is no such need. Is this really the case with every rom ? Because I genuinely want to continue with lineage os or maybe crdroid, so much faster and fluid than the OOS.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
You can dirty flash or not flash at all.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Napoleon_First:
Gapps are broken for me. Right after I installed the latest ROM wit the latest OpenGapps stock archive, some of the gapps like Gmail, photos, keep, won't open, or just send an error message. Not sure if it's a ROM's problems or OpenGapps', but if someone knows how to fix it, let me know please
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] MZGSZM:
I had issues with Gmail not liking the Chromium based System WebView that is bundled with LineageOS/crDroid. I downloaded the Android System WebView app (https://play.google.com/store/apps/details?id=com.google.android.webview) from the Play Store and set it as the default under 'Webview implementation" in Developer options. Google Chrome should also work for this purpose if you already have it installed or plan on using it. Hopefully this is a fix for you as well! :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Napoleon_First:
No, that's not the case. I managed to make Gmail and maps working simply by installing APK on top of existing ones, but it didn't work with Photos, it doesn't install, even if I force delete Photos from the system and try to reinstall it
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] randman2011:
Google Photos hasn't worked for me on this ROM with latest gapps in many months. It took me a long time to figure it out, but I'm using a gapps package from the middle of April and that has gotten everything working again. I haven't yet flashed the latest update, but on all of the previous versions since May I have been able to get Google Photos back by flashing this old gapps zip.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Napoleon_First:
Previous build with 1 of August Gapps worked fine, I tried to dirty flash that package on top of the new one, but that didn't help:(
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
Try to wipe only system and cache partitions, reinstall ROM and flash the working gapps package after that. Hopefully that works...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Napoleon_First:
Thanks for the advice, but it still doesn't work, unfortunately... even with previously working gapps. May it be the problem of the ROM?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
Or install just pico gapps and install photos from Play Store. Works at least for me.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Napoleon_First:
Just wanted to edit my previous post, but you answered faster :) Right after I posted it, Photos app got an update via GP and now it works! Thanks a lot for your help!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sc4r3Crow:
Hey guys. No matter what I try, I can't get NFC to work. Either I perform a clean flash or dirty flash...it just can't be activated.

Any ideas? Thanks in advance...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Once you find a ROM build you like, just stay with it. You are never forced to flash newer builds. If it ain't broke, don't fix it. :svetius:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] android_dan:
I've dirty flashed this rom since I first installed it months ago. I've not had any problems. That said I've not installed a bunch of third party add-ons either. Rooted it with SU and gcam basically. It's been a great rom.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Havana4life:
Snapchat not working spotify widget gone

Hey has someone similar problems - snapchat crashes while startup - and spotify widget is no more available - first wasnt just working then uanble to replace widget
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] @dirpatgaonkar:
Spotify removed it's widget support.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
Update

25th August, 2019

Build type: Weekly

Device: Oneplus 5 (cheeseburger)

Device maintainer: neobuddy89

Required firmware: 9.0.8

Short changelog:

* Allow configuring battery percentage position with respect to icon

* Fix showing battery percentage text on homescreen when charging

* Custom header support - display image at top of the notification panel

* Added layout files to support Xbox controllers

* Added crDroid welcome screen for new users

* Improvements for live display support

* cheeseburger: Upstreamed kernel to v4.4.189

* cheeseburger: CAF updates for kernel (LA.UM.7.4.r1-05500-8x98.0)

* cheeseburger: Update kernel clang to 9.0.6

Download:

https://sourceforge.net/projects/cr...d-9.0-20190825-cheeseburger-v5.7.zip/download

Cheers!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] 1edenec:
hello everybody. I m trying to install crDroid.

My Device 1+5, firmware 9.0.8, twrp-3.3.0-0-20190423-codeworkx-cheeseburger.

I installed crDroid and magisk (full wipe install) with no errors and boot into system. After that i set password and reboot to recovery. And my recovery secured with password, but my password isn't correct. I tried it few time with pincode, pattern and simple password. What was wrong?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] jackpollard:
Try the latest TWRP from codeworkx here --> https://sourceforge.net/projects/cheeseburgerdumplings/files/16.0/cheeseburger/recovery/
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
On your previous ROM - OOS maybe? - you need to remove PIN before rebooting to recovery and installing ROM.

While coming from other ROM (non-LOS), you need to follow this practice.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] 1edenec:
ty for cooperation) isuue was a result old twrp using. iinstalled the latest twrp and now everything fine)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
Update

30th August, 2019

Build type: Weekly

Device: Oneplus 5 (cheeseburger)

Required firmware: 9.0.8

Short changelog:

* Port longshot (long screenshot) support from OOS

* Add more fonts

* Improved system fonts and theming

* cheeseburger: Upstreamed kernel to v4.4.190

* cheeseburger: Improved stability

Download:

https://sourceforge.net/projects/cr...d-9.0-20190830-cheeseburger-v5.7.zip/download

Cheers!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hadaug:
Anybody having issues with the latest August 30 build? My phone's been stuck loading it up for the past 25 minutes. I'm going to revert back to the previous release.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kadutt:
Hey [MENTION=3795148]neobuddy89[/MENTION]

Thanks for the longshot implementation! Any chance to port OOS Face Unlock to crDroid? auto unlock + google face smart unlock still feel kinda sluggish.

Cheers :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] DannyY:
Yes, I'm having the same problem, stuck on the crDroid loading screen. Unfortunately, flashing the build from the 28th has not fixed it for me yet.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] DannyY:
I think it may be the latest GApps or the combination of GApps and the 30th Build. I have gone back to earlier versions of both and I am up and running, although getting multiple app FC's.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hadaug:
Yeah it was definitely the Gapps that was causing issues it turns out
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
Update

3rd September, 2019

Build type: Weekly

Device: Oneplus 5 (cheeseburger)

Device maintainer: neobuddy89

Required firmware: 9.0.8

Short changelog:

* Fix crash with some 3rd party apps

* Improve font theming support and fix crash when applying new font

* Add font tile

* Improve Pocket detection

Download:

OP5: https://sourceforge.net/projects/cr...d-9.0-20190903-cheeseburger-v5.7.zip/download

Cheers!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mashnoon731:
Nfc hasn't been working for me for the last 3 releases. Any thoughts?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
Some logs would be helpful.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Bomsek:
Just installed this rom and it's great so far! Very snappy.

Just have issues with the alert slider, it seems like it doesn't work, regardless of the options I choose it to do.

Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
NFC is working here without problems.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] irdev:
What about noise cancellation with dedicated mic?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] amar1548:
Hey can anyone help me please

My company uses this native root checker app to check root status

I've already hide this app via magisk manager ,but I keep getting this error "permissive selinux"

Can I get the unrooted status smh

Thanks in advance
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] irdev:
I have this problem too
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Adromir:
Selinux doesn't have anything to do with root access. It's a security feature on kernel level and Selinux permissive means you are using a Rom/ Kernel that allows a bit more but is probably less secure. You can have root with both a permissive and a restrictive Selinux
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Necatro:
Hello guys.

Can't enable NFC in settings, it's grayed out.

Tried reflashing full Oxygen OTA and 9.0.8 firmware zips.

Logcat is a few weeks old but it haven't changed since then.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] amar1548:
All right man ,but how can I change that ,if a flash a another kernel ,will it solve this ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] morfances:
See the apk

https://xdaforums.com/devdb/project/?id=1561#downloads
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
I've got a problem with camera during video ident started from third party apps, but I'm quite sure that it is a bug in this ROM causing it (or maybe in the Oneplus Camera mod of yours). A logcat is attached.

The problem is, that camera freezes during the first minute of video ident waiting queue, so I never actually get to start it. Would be nice if you can take a look at it! Thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Adromir:
If you don't encounter any problems, then just ignore it
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
We have selinux enforcing by default. If you have flashed any mod or kernel, it might have changed selinux mode.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jay0r:
[MENTION=3795148]neobuddy89[/MENTION]

I have a tiny and simple question.

Will crDroid on the OP5 see Android 10 in the future or are you going to quit this Project for the OP5 on Android 9?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] b1ackbeat:
Friends, is there any chance to get crDroid launcher apk to install it on another ROM?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] morfances:
See quickstep mod on xda

Inviato dal mio ONEPLUS A5000 utilizzando Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] neobuddy89:
Update

15th September, 2019

Build type: Weekly

Device: Oneplus 5 (cheeseburger)

Device maintainer: neobuddy89

Required firmware: 9.0.8

Short changelog:

* Android September Security update

* Improved stability

* New revamped Launcher

* New revamped Recorder app for screen and sound (with QS tile)

* Updated longshot app with Markup support

* cheeseburger: Upstreamed kernel to v4.4.192

Download:

OP5: https://sourceforge.net/projects/cr...d-9.0-20190915-cheeseburger-v5.8.zip/download

Cheers!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
Hi, just installed your update and still getting the camera freeze during video ident. New logcat is attached. There are different errors though this time... Thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] jahidinbedod:
try again and not using custom kernel and modul magisk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dansou901:
I used neither a custom kernel nor Magisk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] machotom:
I have an issue with my phone. After each reboot the phone is in silent mode and the slider isn't working at all. But sometimes I found that the sound mode is automatically changed to silent. I assume my phone is doing a soft-reset or something. What can be the issue here?

Thanks for any idea!

I'm facing the same issue with LoS, LoS for microg, crDroid. The slider works fine on stock oxygenos!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] pinto83:
Try Lawnchair here https://lawnchair.app/

CrDroid Launcher is based on Lawnchair. the new one is better in many ways in CRdroid.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] funkyirishman:
Do I need latest version of twrp to install this? I'm on 3.2.1-0 as this is the latest version that works with oreo. Can I do install and once installed then I can update it?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
You need the latest TWRP, as well as the latest firmware as of now, 9.0.8.

You can flash codeworkx or blu.spark recovery.

Find the firmware by codeworkx on sourceforge here.

Note

You will have to perfom a data format if you migrate from Oreo to Pie, so make sure you backup your files before.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] funkyirishman:
Thanks

I have everything backed up.

However however I can't update twrp on oreo. So do I wipe except internal, install rom, gapps and reboot and then install twrp. Or once I have these installed flash codeworx before booting.

Then i install magisk

What's the correct steps?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
You need 9.0.8 firmware for latest TWRP to work correctly, or your device will show a black screen with blue LED.

Keep the firmware zip and recovery img on the internal storage, flash 9.0.8 firmware, then select "install image" and select the recovery img. Set it to "recovery" image and flash.

Reboot recovery

Then you format internal storage
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] funkyirishman:
Cheers

I'm on oreo and tried to update twrp to the latest version but obviously didn't have latest firmware thus I got black screen and blue led.

So i go into recovery flash the firmware then img. Then I format, can I format everything except internal?

Once this is done then I can flash rom etc.

Been a while since I updated rom so I am a bit rusty

Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
you NEED to format internal storage when migrating to pie
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] shantam3108:
Same here every gcam I try doesn't work or is Laggy that you cant even take a pic. The same gcam is working fine on rest of the roms.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] red5pade:
Flash this in magisk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] irdev:
Hi

Can any one confirm Screen Cast working on wireless display?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] irdev:
What about dark mode?

Sorry, found that and I can't delete this junk post.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] android_dan:
Took this this morning. Crdroid, gcam, nightsight, HDR enhanced.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] faboz84:
Which GCam? stock or modded?

I'm using/testing Arnova8G2's latest and seems to be good

https://www.celsoazevedo.com/files/android/google-camera/dev-arnova8G2/
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] android_dan:
It's 6.2.030 advanced
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ElHechicero:
Yes. Work.

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] funkyirishman:
Hi

I want to update to this and I have everything backed up and just wondering about wiping internal storage

I have the below on internal storage

Latest Twrp

Latest Firmware

Rom

Gapps

Magisk

So I boot into recovery and flash the latest firmware and then Twrp. Then once done I reboot into recovery again and flash the rom, gapps and Magisk

What I want to know is do I have to clear internal storage? My fear is that I go into bootloop and can’t get phone back to normal. I have everything backed up but if I save my back up to internal storage at least then I can restore it this way rather than having to go via adb as I have back up also saved on the laptop

So can I save the back up to internal storage and not wipe this when I go from Oreo to Pie as reading conflicting reports some saying yes I have to wipe others not
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] access9:
Try this: Before flashing Magisk, boot into the ROM and go through the setup process first. Once complete, boot into recovery and flash Magisk.