yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S9+ Questions & Answers] androabuse:
hi people,

due to an emergency i had to factory reset my s9+, i forgot to backup the files in the secure folder, some pictures, videos and documents. these are personal files, that are very important for me.

is there any way to recover them? unfortunately i didnt back them up earlierer....

i have nearly 0 hope to do so and xda developers site is most likely my last chance, i hope you guys can help me to get some files back. :rolleyes:

btw: theres no backup in clouds or whatsoever

EDIT:

i know the files are encrypted, but in case a recovery is possible, i am the owner and know the pin/passcode
[Off-topic] d.butters:
For some reason, I can't access the threads for any of Dutty's roms. About 4/5 tries, I get either a blank screen or an HTTP: 500 error. Does anyone have any ideas? I posted a question in one of them and would like to get the answer!

Thanks!
[Off-topic] d.butters:
Still not working for me. Here is the link I just tried : http://xdaforums.com/showthread.php?t=379327

but every time I try to access a Dutty thread, and *only* when I try to access those threads, I get a blank screen, with the occasional '500' error thrown in for flavor.

Thanks!

db
[Off-topic] d.butters:
Will do, thanks a lot!
[Off-topic] d.butters:
I've found something strange - I can't see the threads when I'm signed in, but I can view them fine if I'm not. Have I been blocked from this thread somehow?
[Off-topic] blkdrgn:
What browser are you using? Maybe you can try Firefox or something else.
[Off-topic] d.butters:
Firefox, IE, Firefox with the IE plugin.

I've been having the problem on other threads now, not just the Dutty threads. Fun times!
[Off-topic] CurtisJ:
Internal 500's on threads with a lot of replies

Hi Folks,

I see that this thread is a bit aged now, but I have been having this challenge increasingly more often now - to the point where the thread on Dutty's 4/29 release will never render for me, and it does not seem to be related to my browser (it is a typical Service Unavailable error). Here is the thread:

http://xdaforums.com/showthread.php?t=388947

If someone that can get it to render could reply with the link to posting two or page 1 I guess then it might be interesting to see if that renders.

I doubt that this has anything to do with a browser since it is a 500 error.

Thanks
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
Moved all of my development efforts from XDA.
[OnePlus 6 Themes, Apps, and Mods] vtec303:
Thanks for the hard work, I don't get this instal and reinstall? but please confirm the following:

Flash the op6_v5_stereomod in twrp,

Install AML from magisk,

Reboot.

Thanks for your help.
[OnePlus 6 Themes, Apps, and Mods] fantomrik:
Thanks for your work!

There are applications that output sound depending on the proximity sensor (for example, watsapp, telegram). You turn on the voice message, bring the phone to your ear and the sound from the external speaker switches to conversational (that could be heard in public places).

Is it possible to implement it in your fashion or is it technically impossible?
[OnePlus 6 Themes, Apps, and Mods] pankspoo:
Is it any difference between this

https://xdaforums.com/oneplus-6/themes/magisk-stereo-speaker-mod-oneplus-6-t3814512

And u r mod
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
It literally says EXACTLY what the differences are in the main post dude!

- AML support

- Unity support

This basically means:

- This can work flawlessly with other audio mods.

- This can work with or without Magisk.
[OnePlus 6 Themes, Apps, and Mods] pankspoo:
Try to create app like op5t stereo mod which helps to control sound parameters like mono, true stereo etc
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
Sorry to say this but providing any form of GUI or additions to the mod isn't really in the scope of what I set out to achieve here.

The code, however, is freely available on GitHub using the link from the main post - I'm more than happy for anyone to fork the code and add any additional functionality they wish to.

My aim here is simply to provide AML support so things like Atmos, ViPER, etc. can be used seamlessly alongside the mod. I also converted the mod to use "patch" instead of just overwriting the file and switched to Unity so that it could support being flashed directly for those not wishing to run Magisk.
[OnePlus 6 Themes, Apps, and Mods] bartjeh1991:
Confirm this is working flawlessly together with ainur sauron & viper4android. Awesome mod for our device! Thank you very much!
[OnePlus 6 Themes, Apps, and Mods] Ferdav.lp:
And with Dolby Atmos ??
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
Yes it works with Atmos - I ran that for a while myself - worked great.

If you're wondering - I ran the latest build from: https://androidfilehost.com/?w=files&flid=247761

Not my work - just linking to it since the main post for Atmos links to a 5 month older version by the same dev - very odd.
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
No - if you're using Magisk - just download the ZIP, flash in Magisk. Then install AML from Magisk and you're golden! :)
[OnePlus 6 Themes, Apps, and Mods] xxBrun0xx:
Do any of these audio mods actually improve speaker quality? The speaker crackles at high volumes right out of the box. Would love to improve it, but wiping to unlock bootloader only seems worth it if there's a noticeable difference
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
Some of the mods can have a considerable amount of effect on the audio quality but things like Atmos are not going to resolve any audio "popping" or distortion. ViPER may be able to help mitigate the issue.

The purpose of this mod, however, is actually just to enable the earpeace speaker as a secondary speaker so instead of just the one mono speaker at the button - you have a kind of stereo effect (i.e. 2 audio sources.)

I'm sure others can guide better on which specific ViPER settings may help with the issue you're facing but it may be worth tinkering if you're passionate about resolving the issue. That having been said - unlocking the bootloader and rooting does lose you OTA functionality so it's something to keep in mind.
[OnePlus 6 Themes, Apps, and Mods] CetiiN:
How can permanent increase earpiece volume? If I increase it with ex kernel manager I turns back to normal after switching to standby
[OnePlus 6 Themes, Apps, and Mods] Sh0X31:
What is "AML" and there I get the aml module? ?
[OnePlus 6 Themes, Apps, and Mods] Vevee:
I have installed the v5 of stereo mod along with AML and Vioer4Amdroid. How do i control the volume and gain levels of earpiece? I am not able to find the control settings anywhere.
[OnePlus 6 Themes, Apps, and Mods] bartjeh1991:
You can change these values in a kernel manager. Also i think you'll need a custom kernel.
[OnePlus 6 Themes, Apps, and Mods] Vevee:
Ohh thanks. Can you please let me know which kernel works the best for it?

---------- Post added at 12:15 PM ---------- Previous post was at 12:09 PM ----------

Which kernel manager to use to control the sound settings of earpiece?
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
A kernel manager can do this for you - Kernel Aduitor is probably a good option.

Any kernel though mate - they all have that option as far as I'm aware.
[OnePlus 6 Themes, Apps, and Mods] Vevee:
Can you post a screenshot i have installed kernel auditor but still see no option to control earpiece volume or gain
[OnePlus 6 Themes, Apps, and Mods] CetiiN:
Ex kernel manager
[OnePlus 6 Themes, Apps, and Mods] Vevee:
I am not getting this option in Exkernel manager. I have User settings, cpu times, battery monitor, kernel backup, gpu governor, flash kernel,script manager.

This options. Nothing about audio
[OnePlus 6 Themes, Apps, and Mods] Ferdav.lp:
Your version is gain reduced or not ? Thanks
[OnePlus 6 Themes, Apps, and Mods] Vevee:
I am not getting this option in Exkernel manager. I have User settings, cpu times, battery monitor, kernel backup, gpu governor, flash kernel,script manager.

This options. Nothing about audio

---------- Post added at 07:12 PM ---------- Previous post was at 07:09 PM ----------

Which kernel are you using?
[OnePlus 6 Themes, Apps, and Mods] silvercat:
Use this

https://xdaforums.com/oneplus-6/development/kernel-elementalx-op6-1-00-t3799054
[OnePlus 6 Themes, Apps, and Mods] CetiiN:
Radioactive V1.0.5
[OnePlus 6 Themes, Apps, and Mods] bartjeh1991:
If your gain is too high, install a custom kernel and change the output gains in a kernel manager.
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
Yes it's the gain reduced version. Same results as V3 of the other mod..
[OnePlus 6 Themes, Apps, and Mods] Kevinkuensken:
What is AML?
[OnePlus 6 Themes, Apps, and Mods] yldlj:
Audio Modification Library. Found in magisk download section.
[OnePlus 6 Themes, Apps, and Mods] jonny30bass:
Is there any way to get the earpiece gain level to stick? It always reverts back to 0 after turning the screen off.
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
I'm not touching the earpiece gain level mate so I can only assume this is an issue with either your kernel or the kernel manager app you're using. This module just enables the earpiece to be used as an audio output and provides the default earpiece gain level. It does this once at boot time each time you boot your phone - doesn't change anything to do with kernel-specific parameters, etc.

I would recommend talking to your kernel dev and/or kernel manager app dev to ask if this is something they can resolve.

Hope this helps!
[OnePlus 6 Themes, Apps, and Mods] jonny30bass:
I've tried both Franco kernel manager and EX Kernel manager, and it happens on both. Not unless something from Renovate Ice 4.4 is causing it.
[OnePlus 6 Themes, Apps, and Mods] Overclock96:
I still experience problems with the error when they call me. I do not hear the caller until I remove the phone from my ear and I'll carry it back up again.
[OnePlus 6 Themes, Apps, and Mods] azreen91:
Still got issue? Wanted to try this v5 though
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
What Magisk modules do you have installed?

What kernel are you using?

What ROM are using?

I have not experienced this issue at all and have been using v5 of this mod for weeks.
[OnePlus 6 Themes, Apps, and Mods] Salamender:
Hi !

I've installed this Mod on Renovate ICE 4.5 + CleanSlate Kernel 1.7.23.

The earpiece is not really audible til i set the gain to 10, if i let the gain to 0, i almost hear nothing.

So, i can set the gain from 0 to 20 and i want to know whats the maximum gain i can set for avoiding any damage on my earpiece, anyone know ?

By the way, thanks for this mod :)
[OnePlus 6 Themes, Apps, and Mods] azreen91:
You dont have any issues with earpiece sound crackling and distort only when notification/ringtone plays? Playing music is ok though.
[OnePlus 6 Themes, Apps, and Mods] Salamender:
No crackling or distortion when i play music, i suppose it's the same when i receive a call or a notifications, i've installed the mod 2h ago and doesn't receive a call, i can't really know.

So, i think it's good for my earpiece with the gain set to 10.
[OnePlus 6 Themes, Apps, and Mods] azreen91:
i'm gonna have to try revert back to zero and flash the mods again. so you are using v5 stereo mod + AML, on cleanslate kernel. no v4a profile set on speakers, correct? on cleanslate config app, what's your speaker gain?

EDIT:

So I went back to stock kernel, flashed v5 stereo mod + dolby + AML. earpiece does not distort/crackle upon notification. However, after flashing cleanslate kernel, earpiece distort/crackle is back. Also, the main speaker becomes loud & noisy as well
[OnePlus 6 Themes, Apps, and Mods] Salamender:
I'm using this mod + AML + Viper4Android + Ainur Sauron with [MENTION=9205009]black_file[/MENTION] audiophile profiles.

The audiophile profiles are really amazing, lot more bass on the main speaker and tons of tweaking for your headset with them, it's cool.

For the stereo mod, i don't think i'm gonna use it, i've tried whit music, it doens't bring much higher or better quality and on youtube video, it sounds weird.

For me, the earpiece have to remain an earpiece and not a secondary speaker.
[OnePlus 6 Themes, Apps, and Mods] azreen91:
For viper and ainur both using [MENTION=9205009]black_file[/MENTION]'s profile? mind to tell the order of the installation? Also need to reboot each mod install? Thanks
[OnePlus 6 Themes, Apps, and Mods] awaisuk:
To uninstall, can we just remove the module from Magisk? or need to install it again using Magisk? I have installed it using Magisk Module.
[OnePlus 6 Themes, Apps, and Mods] williamcll:
Whats the difference between this and v3?
[OnePlus 6 Themes, Apps, and Mods] rienux:
this module work smoothly on custom ROM?
[OnePlus 6 Themes, Apps, and Mods] Roger.T:
Read the opening post...[emoji849]
[OnePlus 6 Themes, Apps, and Mods] xpdragon:
v8 stereo mod works perfectly with my setup (EX kernel + Ainur Suaron + Dolby Atmos + AML).
[OnePlus 6 Themes, Apps, and Mods] HatRiGt:
Does anyone tried this in Hydrogen OS beta 2?
[OnePlus 6 Themes, Apps, and Mods] gismoboss13:
Hi where you have Dolby Atmos ? How install ? Thanks
[OnePlus 6 Themes, Apps, and Mods] xpdragon:
Download the module and install it from magisk manager.

https://androidfilehost.com/?w=files&flid=247761
[OnePlus 6 Themes, Apps, and Mods] gismoboss13:
Thanks I have flash on magisk but magisk say I delete on next reboot why ?
[OnePlus 6 Themes, Apps, and Mods] chrisaw:
Sounds like an issue with CleanSlate rather than this mod mate. Probably bumping your earpiece volume up by default. Probably possible to fix by reducing that back to the standard amount.

You should also try v8 of this mod to see if the changes help at all.
[OnePlus 6 Themes, Apps, and Mods] xpdragon:
Look like the module was already installed and you tried to install it again. Flashing the 2nd time will uninstall the module.

1. Uninstall the stereo mod, Dolby, and AML if you have them installed previously and reboot. You don't need to uninstall Aniur Sauron.

2. Install stereo mod v8, then Dolby, and AML.
[OnePlus 6 Themes, Apps, and Mods] yandreev3:
What's the changelog from v5 to v8?
[OnePlus 6 Themes, Apps, and Mods] KnifeFed:
https://github.com/cawilliamson/op6-stereo-magisk/blob/master/README.md
[OnePlus 6 Themes, Apps, and Mods] Toni Moon:
why the performance drops drastically when i install this mod?
[OnePlus 6 Themes, Apps, and Mods] Mike.YT:
Could you compile a boosted edition of this mod that uses the same values for the earpiece as the v1 mod? The newer reduced versions aren't loud (obv since they're reduced lol) and personally I've not been able to get a kernel to set the earpiece gain to where I want and have it stay that way- after a pause, the earpiece volume would reset, which I find weird. Thanks for the work dude :)
[OnePlus 6 Themes, Apps, and Mods] SzymonL:
It works, but its so quiet, that I can't hear the difference.
[OnePlus 6 Themes, Apps, and Mods] radoslaw79:
+1

op6 oos 8gb 256gb
[OnePlus 6 Themes, Apps, and Mods] azreen91:
I tried earpiece gain to -10 it does reduce the volume but it still crackles. Tried V8 and the outcome is the same. I was wondering if theres anyone here using this mod on stock OOS + cleanslate kernel and havent had this issue im facing. Probably my earpiece speaker is broken?

But its weird that if i dont use cleanslate kernel, the earpiece doesnt crackle.
[OnePlus 6 Themes, Apps, and Mods] quimbexa:
I'm trying this out now. What are the chances of this mod wrecking my earpiece?
[OnePlus 6 Themes, Apps, and Mods] HatRiGt:
I have tried v8 on Hydrogen beta 2 based on pie. but im getting some speaker breaking out sound from earpiece. but on v6 it wrks fine,.
[OnePlus 6 Themes, Apps, and Mods] Zokinet:
Works on OmniRom?

Enviado desde mi ONEPLUS A6000 mediante Tapatalk
[OnePlus 6 Themes, Apps, and Mods] sameer1049:
Thank you so much sir ?

Works fantastic on oxgyen os open beta 1/2 (Android 9.0)
[OnePlus 6 Themes, Apps, and Mods] MrPhilo:
I got same issue, so gonna try other version

Did you fix it?

EDIT: same with all version. Crackling only happens after the volume slider goes past the notch on the right (where the camera is), regardless if it's on minus gain or plus gain. Anything under the right side notch works fine regardless of the gain. Weird.

EDIT 2: Seems that crackling happens to my brother OP6 as well, when the volume slider is past the right side notch (front camera), it crackles, I tested this by putting the speaker to 0 and just listening to the earpiece, the gain doesn't matter it will crackle after going past the notch. Can someone else confirm this as well?

Me and my brother are using 5.1.11 Oxygen.
[OnePlus 6 Themes, Apps, and Mods] windo34:
And btw on OB3:o
[OnePlus 6 Themes, Apps, and Mods] tonisl78:
On OB 2 and OB 3 in games the ear piece crackle and have distortion but only in games.
[OnePlus 6 Themes, Apps, and Mods] tonisl78:
O tried from TWRP and Magisk but still the same problem in games....crackling sound and distortion and sometimes i have only sound from the bottom speaker on Oxygen Open Beta 1 , 2 and 3 :(
[OnePlus 6 Themes, Apps, and Mods] quimbexa:
Better disable the mod and wait for some fix before we blow up our earpiece
[OnePlus 6 Themes, Apps, and Mods] Faye Reagan:
If i'm not misunderstand, this means i will have 2 mono speakers instead of 1 mono speaker on the bottom?

Hence if this is truly stereo, wouldn't it disable one of the speakers if i set only left or right audio source?
[OnePlus 6 Themes, Apps, and Mods] i6rb:
Anyone try this on Oxygen 9 final android Pie ?
[OnePlus 6 Themes, Apps, and Mods] dgunn:
We need a build for Android Pie please
[OnePlus 6 Themes, Apps, and Mods] BaRTaSs88:
Generally it works for me on stable pie however I hear echo - it isn't synchronized with main speaker... :rolleyes:
[OnePlus 6 Themes, Apps, and Mods] Bigs1985:
It works fine but Bluetooth audio doesn't work with it enabled.
[OnePlus 6 Themes, Apps, and Mods] xpdragon:
Bluetooth audio works fine for me.
[OnePlus 6 Themes, Apps, and Mods] Bigs1985:
How did you update to the official? Were you on the beta or stable? Dirty or clean flash?
[OnePlus 6 Themes, Apps, and Mods] xpdragon:
Updated to the official stable pie 9.0 with dirty flash. I uninstalled magisk 17.1 and installed 17.2 plus v8 + V4A + AML. All work fine so far.
[OnePlus 6 Themes, Apps, and Mods] Bigs1985:
I got it sorted, just had to delete the module and reinstall. Cheers.
[OnePlus 6 Themes, Apps, and Mods] baxtex:
So this mod is working fine on Pie then? :)
[OnePlus 6 Themes, Apps, and Mods] quimbexa:
It is. Beware of the volume while playing games tho
[OnePlus 6 Themes, Apps, and Mods] baxtex:
Great. I barely play games, but couldn't we limit the gain with V4A?
[OnePlus 6 Themes, Apps, and Mods] quimbexa:
Sure, you can do that
[OnePlus 6 Themes, Apps, and Mods] awaisuk:
is this confirmed to be working on official android pie release with no issues?
[OnePlus 6 Themes, Apps, and Mods] Faye Reagan:
I can confirm it works on OOS Pie Stable :highfive:
[OnePlus 6 Themes, Apps, and Mods] tonisl78:
Well....even after installing oficial pie from fastboot and magisk 17.2 and v4a and aml clean have the same situation.....no stereo or crackling sound on games...so i make a try to the V3 reduced version and all working OK...

In V6 and on V8 they have something breaking on games.

I Stay on V3 for the momento and wait for an update.
[OnePlus 6 Themes, Apps, and Mods] marriusf81:
Tried it with magisk 17.2, not working for me.
[OnePlus 6 Themes, Apps, and Mods] tonisl78:
What version have you tried with magisk 17.2?
[OnePlus 6 Themes, Apps, and Mods] marriusf81:
V8
[OnePlus 6 Themes, Apps, and Mods] tonisl78:
Remove AML and try the V3 reduced version on other post

For me its working OK even on games without crackling ir loose of stereo.

Oh i use V4A included on xxxnolimits 2.9.5 module.
[OnePlus 6 Themes, Apps, and Mods] marriusf81:
thanks!

Thanks for helping mate but tried and it's not working.
[OnePlus 6 Themes, Apps, and Mods] Lazaroth:
Anyone have a good way of delaying the sound from one of the speakers? They are off by a few milliseconds, making it sound like a chorus effect.
[OnePlus 6 Themes, Apps, and Mods] javad79:
Yes flash weta dual speaker
[OnePlus 6 Themes, Apps, and Mods] awaisuk:
Hi,

Is it possible to update this module for Android Pie? Users are reporting there are some issues with volume not being in sync between 2 speakers.
[OnePlus 6 Themes, Apps, and Mods] Taebom:
This
[OnePlus 6 Themes, Apps, and Mods] quimbexa:
Sounds about the same. Which file did you install? Just the dual mod or the whole deal?
[OnePlus 6 Themes, Apps, and Mods] kahntran:
Hi Bigs1985,

Please, tell me exactly how did you delete the module ? Flash it again or click on Garbage Bin in Magisk Module ?

And is your bluetooth still working ?
[OnePlus 6 Themes, Apps, and Mods] Bigs1985:
Yeah tap the bin, reboot & flash again via magisk, all now works.
[OnePlus 6 Themes, Apps, and Mods] kahntran:
Thanks for your reply. But after many times trying and failed, I finally give up :(
[OnePlus 6 Themes, Apps, and Mods] Bigs1985:
Try weta mod https://xdaforums.com/oneplus-6/themes/mod-wetamod-magisk-modules-t3827628/page16
[OnePlus 6 Themes, Apps, and Mods] kahntran:
Yay, I found out the problem thanks to your suggestion. I was using this "package" Magisk Module: V4A, Ainur Sauron, AML and Stereo Speaker Mod.

After trying WETAmod (Audio), the Stereo Speaker Mod did not work, so I think the mistake must be on my side.

I was following this order: Flash V4A -> Flash AML -> Reboot -> Flash Ainur Sauron -> Reboot -> Flash Stereo Speaker Mod -> Reboot ===> Stereo Speaker Mod wont work this way

Turn out, the issue was the Ainur Sauron blocking Stereo Speaker Mod from AML.

The correct order is: Flash V4A -> Reboot -> Flash Stereo -> Flash AML -> Reboot -> Flash Ainur Sauron -> Reboot ===> Now, I got bluetooth & Stereo Speaker Mod working

Thanks for your kind support, Bigs1985 :D:D:D
[OnePlus 6 Themes, Apps, and Mods] awaisuk:
can someone update the mod to fix this issue of speakers not being in sync? Using it on OOS Official Pie 9
[OnePlus 6 Themes, Apps, and Mods] ajsmsg78:
How did you get this version to work on Pie? Every time I've installed it nothing happens. It shows up in Magisk Manager as Enabled but no sound comes out of the earpiece. Only v3 works for me.
[OnePlus 6 Themes, Apps, and Mods] SHAY820:
Yes not working on p
[OnePlus 6 Themes, Apps, and Mods] vrda08:
Just flash "audio modification library" after mod from magisk.restart.done.
[OnePlus 6 Themes, Apps, and Mods] SHAY820:
Hi thanks

Whare can I find "audio modification library"
[OnePlus 6 Themes, Apps, and Mods] spevil07:
In Magisk

Gesendet von meinem ONEPLUS A6003 mit Tapatalk
[OnePlus 6 Themes, Apps, and Mods] R3VX:
Need a fix for the delay between the speakers, its annoying
[OnePlus 6 Themes, Apps, and Mods] Dmitriy9119:
hello. Thanks for mod. Tested it on oos 9 beta 5 and android 8.1 (5.1.11)

There is one problem.

Problem is spontaneous switching phone to vibrate mode.

Evev when stock sound mode is enable, by hardware button.

Fix it, please.

Thanks
[OnePlus 6 Themes, Apps, and Mods] FraRu:
Hey there, can you update your module with acervenky V4 that supports Pie?
[OnePlus 6 Themes, Apps, and Mods] pb82000:
Perfect

It works perfectly for me with Magisk.

I installed the v8 on Android Pie

It improve a lot the audio quality.

Great job !
[OnePlus 6 Themes, Apps, and Mods] mv0hra:
Deleted
[OnePlus 6 Themes, Apps, and Mods] brmbjn:
Audio modification libray work for oneplus 6
[OnePlus 6 Themes, Apps, and Mods] mv0hra:
This has stopped working for the latest OP6 update 9.0.2. It was fine on 9.0.1.
[OnePlus 6 Themes, Apps, and Mods] mv0hra:
Thought I try the module for the OP6t, as the latest update (9.0.2) for OP6 has meant that the stereo speaker module is not working.

The OP6t module did not work, in fact it messed up the pattern lock which meant I could not get into the phone.

So if you are going to try that module (https://xdaforums.com/oneplus-6t/themes/magisk-stereo-speaker-mod-oneplus-6t-t3860041) then ensure you wipe any security lock.

I had to use magisk uninstaller, in TWRP, to disable the module and get back into the phone.