yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy J5 PRIME ROMs, Kernels, Recoveries,] Brhue.hel:
Can you install via odin ?? or twrp?
[Samsung Galaxy J5 PRIME ROMs, Kernels, Recoveries,] fullerhkz:
Hi, you can download The Oreo firmware From sammobile. Country Trinidad Tobago and odin Flash. My device is G570M., Brasil zto
[Samsung Galaxy J5 PRIME ROMs, Kernels, Recoveries,] DIEALEX182:
Buenos días, tengo el siguiente problema con un samsung SM-G570M

-An error has ocurred while updating the device software. use the emergency recovery funtion in the Smart Switch PC software.

he intentodo en odin con diferentes rooms pero ninguna me funciona.

alguien de buen corazón que me pueda ayudar gracias.
[Palm Treo 750] alfredtv:
Hello I am thinking about getting one of these soon, but need to know if it will run bbconnect and work with the AT&T rom or if I get the Vodafone rom if that will work. Please respond back with any info.

Thank you
[General Topics] KHARISHK:
Hi,

:fingers-crossed::fingers-crossed:

here is my design for a smart phone without notch or motorized cameras. Its a simple design and i hope some manufacturers may try it.

[youtube]hVKjKjSpGtU[/youtube]
[General Topics] KHARISHK:
[youtube]NxHHZQYZOpY[/youtube]
[General Topics] KHARISHK:
[youtube]_mQnJTzYWak[/youtube]
[General Topics] KHARISHK:
Hi,

For more info, the design is having the upper portion which circles around the main display screen. And is of AMOLED the outer screen has permenent black background where the signal notification and time is shown along with battery indicator as a line which shortens and changes colours as per battery percentage. The camera and flash are there with shaped spaces. Thus we get a border which can lit up on standby to show all notification and even light up the whole corners when notification arrives. The inner main display remains there for all the utilities. The notification and indicators all accommodate the outer screen also giving a thin separation we get to only replace the outer display in time of drop break which will only effect the outer screen.
[General Topics] KHARISHK:
Full layout and dimension uploading tomorrow
[General Topics] KHARISHK:
[youtube]_BnQFMPcT24[/youtube]
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
Delete
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
Huge thx to rocker00 and Cirra92. We worked on this for weeks, it was an adventure starting from scratch trying to reverse engineer this what Xiaomi did. A lot of frustration, hours of testing and comparing and finally getting to this point that for me, us, we have the sound that we want.

I am a huge fan of 'what you hear is what you get ' recordings. This has been done with the changes... BUT ... read below for further technical information and limitations.

Also to be precise, Xiaomi messed up the left and right microphone. Easily tested in recordings and a headphones, so that was changed in the config files.

As I already wrote in the other (original) topic, AGC can be a good thing. AGC stands for automatic gain control which makes all the sounds sound at the same level.

Most people will like that you hear birds in the background really well and that conversations will always be at the 'good' level. Now our human ear can hear the slightest noise and still cope with loud things. Our brain adjusts the volume in a sort of way. If you technically translate the difference in sound levels this means an unbelievable dynamic range. Now some of us remember a VU-meter and that ideally peaks will go to 0dB to avoid distortion and get the best signal to noise ratio. AGC normally regulates this ... but due to the huge levels in our environments it is almost technically impossible to always do this. There is always a technical limit. You can look at it like HDR, it can be fantastic but useless in a complete dark environment were the sensor doesn't get light or gets way to much light.

AGC is switched off in the modded files so what you hear in dynamics is what your ears hear . BUT!!!! there is the technical limit of 0dB and the opposite side of the scale which is almost silence. The goal is to keep within these two and to aim at the 0dB. That setting can easily be controlled by DEC1 and DEC2 levels in the files which are easily modifiable.

There is another technical thing which you cannot control and which are the microphones themselves. They might have a hardware limitation to how loud they might record without distortion. Even in a professional environment microphones have limits.

The microphones that we have in our devices are really excellent and the difference between original and modded is day and night, no magnifying glasses or angel dust needed to hear it with headphones.

To bad Android hasn't got a recording mixer to set the level like the playback mixer. For the moment I found 1 application which can change the level and which is called Footej camera. It also has a VU meter which is a must, especially in loud environments.

So people give it a go and please provide feedback. Without positive or negative feedback there is no progress.

Now let me get back to my coffee.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] unisol107:
Thanks for this module. But I wonder, why no one has noticed the rubbish quality xiaomi has implemented in the camcorder video recording. Don't know if it's only with the Indian variant or others too.

The issue is that the quality is very bad even at 20mbps bit rate. The video has artefacts all over. I also own a Samsung galaxy note 3. Quite old device but with a great camera. Although note 5 Pro still camera beats it's old sensor, but videos come out great on my oldy Galaxy note 3.

Another biggest bug is that the continuous auto focus in camcorder works like in photo mode. Quick auto focus ruining all the video. I am talking about the lack of smooth continuous auto focus. The lens focuses back and forth quickly instead of slow smooth focusing. This ruins the whole quality and is quite irritating. I have tried many camera apps but the same bug. That means it's in the libs and nobody seems to notice it. The dynamic range is also very poor.

Such a great sensor, crippled by xiaomi's bad software. Can you guys fix it? It will make this already great camera greater. Thanks.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Half Alive:
All the videos I took with this phone were ruined because of this issue .. I'm surprised to know there were minds working on it in the background.

I've never edited the build.prop on the vendor folder so I was digging through the lines in the /system version at first before double checking your note.

I've tested before and after the mod and I can confirm this is working with Pie pr1..

Huge thanks.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] fed_xD:
Thanks bro i installed miui version, all excelent good audio quiality but with earphones for test the module, i hear more loud in right ear, and the left ear the sound is low, it's only perceptible with earphones, it's normal?
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
Normally the volume should be the same. One way to easily tell is to export the file to your pc (if it is a windows one) and use this meter during playback.(VLC player or so) http://www.vuplayer.com/other.php

If you play the file it shows the left and right output from the file to the amplifier (end stage) of the pc. Should show about the same values at once.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] fed_xD:
i made a test with both mics the inferior and superior (superior is beside IR)

1.-without the module the inferior mic sound is the left ear, and superior mic is the right

2.- with the module installed, ocurs a inversion of mic, the inferior mic is the right ear, and the superior is the left ear :o

i'm going to faculty, and don't have time to test with vumeter right now bro, sorry

when i back from the faculty i will check with vu meter

edit: the module works fine bro, the quality is better than stock audio
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
The mod changes left and right modules since they are wrong in the roms. Might be that a case is messing up the levels in recordings. Try without I would say.

If not fixed it might be your phone itself. We tried on 3 phones here (mine, rocker00 and Cirra92) and all were good. Quality of left and right mic should be the same ... so if volumes are not equal then you might need to change the DEC1 or DEC2 value, we'll say the correct location where they are if it doesn't work for you.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
[MENTION=1743042]lukesan[/MENTION] I really wished to have half of your patience! Great explanation man!

[MENTION=4510354]unisol107[/MENTION] I don't think we've that kind of bug on the global version, or maybe i didn't notice it! and if it's really about libs then unfortunately i can't do anything about it, you need a programmer (C++), Thanks for your kind words :)

[MENTION=4692134]Half Alive[/MENTION] It's good to hear that buddy.Enjoy it

[MENTION=8635280]fed_xD[/MENTION] NOOOOOOWAAAAAAAY :D, this part exactly you can ask luksan how much time i spent on fixing it! the top microphone was the main one from Xiaomi's genius engineers..lol!! but i think those bugs are intended..this is how to run the business! i tested this module on MIUI 9.5.19.0 and Masik 2.3 and it's bug free, so again noway especially in this part :D
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Subhashis:
Thanks for these fixes.I tried it on miui 9.5.14 and the difference is huge.The video's background noise has significantly reduced which I think Xiaomi should do from the start though.Anyways excellent writeup [MENTION=1743042]lukesan[/MENTION] and thanks for the awesome work [MENTION=4702982]rocker00[/MENTION]
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
Not really audio related and haven't really played with video yet. I was about to ask to put a small clip on Youtube but they compress video so I would not see the issue.

The global version also has different cam modules.

Thinking as I type:

EIS : crops picture and uses sensors to define shakiness. Could cause less sharp images. Try without anti-shake to determine that issue.

Default video bitrate : 20mbit/s. Could be too little for a real time simple encoder. Check with green grass, like a football (soccer) field, and pan the video. If low bitrate grass will be like blocks and not sharp. Solution would be simple and even trying H.265 in Aranova's gcam (developer settings and activate) might fix that. 13.3mbit/s but H.265

Dynamic range. I have a S7 which is worse I think. Taking pictures sometimes clouds not visible in the sky while my whyred (lets call it that way) shows everything. Might be because of the Sony sensor in your devices. Use of Masik rom. which has HDR recording might mask this issue.

The fast AF, yes it can be an issue but I guess it is a compromise for taking pictures fast. People love a fast camera ... mm Masik rom also has object tracking.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] scricccettoni:
[MENTION=4702982]rocker00[/MENTION] I've found how to change the prop from magisk... Just add:

resetprop ro.vendor.audio.sdk.fluencetype none

in common/post-fs-data.sh and enable it in module.prop with

POSTFSDATA=true

Attached my modified version of yours module.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] fed_xD:
This module affects mic for calls? I talked and I have to talk in the top mic hahahaha the other person don't heard when I talk in the inferior mic maybe is my phone? Haha
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] scricccettoni:
Just disable module and check if still same happen
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Subhashis:
I noticed the same too.I'm in miui ROM and the other person has difficulty in hearing my voice.So ,even though this fixes video problem,but it creates another problem
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
[MENTION=8635280]fed_xD[/MENTION] [MENTION=6404303]Subhashis[/MENTION] Now I am confused! i don't have that bug!

Please try this one, now mics are the same like before, please report back!

Edit: You are right guys, looks like i didn't test the call in a proper way since i was focus on the camera but i've found a quick fix for this issue :p, now the mics adjustments are on the path which is being used by camcorder only without touching the calls, tested with 2 calls and camcorder audio quality is the same :)

Sorry guys but it was really a tough job.

Thread updated.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
[MENTION=7580575]scricccettoni[/MENTION] Thanks, i will add to the OP and the credit is for you of course but first lets see this weird issue!
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
[MENTION=8635280]fed_xD[/MENTION] [MENTION=6404303]Subhashis[/MENTION] [MENTION=6404303]Subhashis[/MENTION]

Fixed, give rocker00 new files in the openingpost a try.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] scricccettoni:
I have my own miui camera v2 port and I've added your fix in it. It's working good on LineageOS. The background noise has a really big difference. In few days I'll back home and so will share the module with also your fix if you are OK with that. I've already put link to this thread in the module and will add also in the post.

Thanks for the share, I'll just suggest you to use a unique name for the module in module.prop (see the one I've posted previously) to avoid problems with other modules.

In your new one you changed only mixer_paths.xml right?
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Subhashis:
Thanks for the fixes.Now everything is working perfectly.:good:
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Zanr Zij:
Tks for the mod. Just tested and Cam audio bitrate increased to 156Kbps on full hd mode. Very good job folk
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
[MENTION=6404303]Subhashis[/MENTION] Glad to hear that mate and thanks for your feed back :)

[MENTION=3241487]Zanr Zij[/MENTION] Thanks mate, enjoy it.

[MENTION=7580575]scricccettoni[/MENTION] Sure, feel free to use the module, proper credit is more than enough, and yeah only mixer_paths.xml has been changed.

It's not just about noise, now we have a bass like it should, before the camcorder audio was horrible in general!!! now you can depend on it!

Ok i will change the name, it was the first module i create and to be honest i didn't even care about that.

Regarding your zip, i have a couple of questions before i add to OP:

- Can't find this "POSTFSDATA=true" in module.prop as you said, do you mean i

should add it?

- How is the script differentiate between the build.prop on system and vendor and ignoring the one on system? i know that i am always curious :p
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] scricccettoni:
[MENTION=4702982]rocker00[/MENTION]

From what I understood magisk don't change the built.prop it rewrites the property so doesn't matter where it is set if vendor or system.

With setprop I was getting error but resetprop worked (it's a magisk command only).

For POSTFSDATA I were wrong it is inside config.sh not module.prop file (I'm new to making magisk modules too)
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] cutay:
anyone try this mod on 9.5.19?
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] mrps2:
Very nice, sound is much better now, received a call and no problem with the mic... Loud and clear on the other side! Great work!
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Gingernut78:
[MENTION=4702982]rocker00[/MENTION]

Thxs for all the time you've spent on this.

If you don't mind I'm interested in jhenrique09, from the Pixel Experience team, including your audio fix in his builds, I've contacted him but he would like to know which exact files have been modified to take a look as you include in the zip so many libs for some reason.

Edit: The only mods are to these three xml files?

audio_platform_info.xml

media_profiles_vendor.xml

mixer_paths.xml
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
................
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] mxilil:
I'm flash aosp v2 on AEX 5.8 before flash cam audio bitrate is 96kbps after flash 96kbps no changes :(
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
Going to create 2 files, MIUI and AOSP, today or tomorrow. My aim is to create files which will record approx 20 to 30dB less loud than the one we have now. I will test this with a sine generator and speakers at a fixed distance.

My way of thinking is that the standard created one is excellent for all round use. But you probably know in advance if you go to a place where they use an amplified environment, concert, schoolplays etc etc. Afterwards you can amplify recordings if the level is low but if they were recorded over the top loud (clipping) then you can not get rid of that distortion. that is a fact.

Magisk is a fantastic tool to change stuff in a reboot so why not switch over if you know in advance? So stay tuned.

Edit done : The ones included are approx 20 to 25dB down. I didn't use a sine generator but punchy bass music. (saves my ears and gives an idea of what it would sound it produce). When listening the level was a lot lower, of course, but with the phone about 1 cm away from the speaker, lets call that concert level, sound will go up to normal listening level and I could not hear any clipping at all.

Try before you use in 'action'!
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] NovelliJack:
Nice, that works for me.

Thanks! :D
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] XZsuga:
The module won't work on havoc (los based)

Audio bitrate still on 96kbps
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] mackeev:
MSM-X: no effect whatsoever.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
View attachment 4573285

Please test this one it should works, looks like i messed module.prop! please report back.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] mackeev:
I flashed Test.zip. Now camera won't launch at all (I have v. 4.2 installed from here).
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
!!!

Try with this one, i removed media_profiles_vendor.xml, this is the only file which can causes that, for now acc bitrate won't change just ignore it and test the audio, please report back!!
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Okkejulian:
Hey, bro, can you fix this file link? because Yang Miui and Aosp cannot be downloaded

:cowboy:

---------- Post added at 02:13 PM ---------- Previous post was at 02:12 PM ----------

Hey, bro, can you fix this file link? because Yang Miui and Aosp cannot be downloaded, please correct it because it cannot be accessed by me for download. thank you
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] mackeev:
With Test2, camera launches alright. Sound is very low (and 96 kbps).
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
[MENTION=8837177]Okkejulian[/MENTION] Hi, please never quote the OP! :)

OK i will mirror the files.

[MENTION=5645843]mackeev[/MENTION] Well then, there's nothing i can do! some AOSP users reported they got it works and some not, we have many custom ROMs maybe every ROM has it's own files and setup and i am using MIUI and no intention to move to any of them, the same for MIUI camera ports, the stock modded media_profiles_vendor.xml caused the issues you had! that means they use modded media_profile_vendor.xml, I will leave AOSP module for the users who want to give a try but i will remove this file since it can causes issues, just ask your ROM developer or MIUI camera ports developers to increase the aac bitrate, Sorry buddy!
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] mackeev:
You predicted test2 wouldn't change bitrate (and it didn't), so I expected test3 to do the trick. No test3?
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
[MENTION=5645843]mackeev[/MENTION] I've updated the OP please have a look.

Thread updated.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] hm.huy.97:
Please release Module for increase quality sound for Voice Recorder.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] warlok9000:
Wow! It is so cool tht someone fix that! I knew xiaomi had good hw microphones and all thing was in software! Thank you so much! Will try it on my RN5 MIUI 9.5.17.0

---------- Post added at 09:29 PM ---------- Previous post was at 09:25 PM ----------

Oh, and big question: will it work on redmi 5 plus?
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
Thanks buddy.

I don't think it will work on Redmi 5 Plus due to the different files of course.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Cloud_Ac:
Great job, the audio sounds way better now.

With the stock settings is sounds way more tinny.

Even though the bitrate increased just by a few bits.(AOSP)
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
I think encoding bitrate is far above the 96kb/s than it was before in the standard MIUI roms. We experimented with different values. There is a limit where you will not hear any difference anymore if you go higher so that leaves you with waste of disk space. Relative if you have 20 or 30mb/s for video of course.

64kb/s aac on a expensive encoder will sound better than a 128kb/s mp3 but unfortunately we are stuck with a cpu that handles everything realtime, video encoding, the software and OS itself so processing has to go fast to obtain an OK quality. You can increase the bitrate in the XML files but I am on a MIUI rom and I think we are already on the limit of hearing artifacts. Microphones and amplifiers also have their limits. On my earbuds I cannot hear any aac encoding artifacts.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Cloud_Ac:
My comment wasn't meant to relate to the bitrate, that's was more a kind of an information for other people.

I know that's the mic's of phones are not able to obtain more details which would justify a higher bitrate.

Even the iphone isn't recording at a higher bitrate.(So far i know also around 90-100kb/s)
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] lukesan:
No worries. Might have misinterpreted but I've seen people bumping it up to 320kb/s which really is useless. If you do video recordings of fast action with detailed stuff like grass etc then I would rather bump up the video bitrate. It can make some serious difference I have seen.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] adaa1262:
I got into a concert with this mod flashed and

the audio is just awful and sounds very distorted.

Is there any fix for that?

I miss my Zenfone 2 amazing mic and captured great audio
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] tlf55:
I know it's maybe too much to ask but can someone make this work on Pixel Experience Pie rom ? :)
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Cirra92:
My guess is that you messed up somehow, or if you are using custom rom it may be incompatible with it, but I doubt that since this includes stock MIUI audio files, just edited and adjusted. What was distorted, bass only, or something else?
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] adaa1262:
No I'm using MIUI 10 on China AI version, beats sound very distorted and the rest of the sound is barely hearable
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] Cirra92:
Ok, my question was, what was distorted? Lows, mids, highs, everything?

For example, the pre set mic volumes in the module are too high for video recording in my car, as I have subwoofer installed and the bass is too heavy and is distorted, but even then, the mids and highs are ok. When I lowered that value to stock it was much better, but for every day recording in quite environment it is too low.
[Xiaomi Redmi Note 5 Pro Themes, Apps, and Mods] rocker00:
I can agree it might distort at a concert, but in normal noway! I'm using it on a daily basis and no any distortion.

I can't lower the volume because it will become too low and unusable except for the concerts which aren't the priority for the majority, my suggestion is using the following app (and the fix of course) if you're at a concert since it has an option to control the db so you can lower the volume:

https://play.google.com/store/apps/details?id=com.footej.camera&hl=en