yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S 5 Unified Development] Bosket:
Why to buy a new phone when we have a huge ,great support for our old S5 ,with Dev's like you ?

S5 Resurrected! :D
[Samsung Galaxy S 5 Unified Development] Mcha01:
This is great! Im gonna test it
[Samsung Galaxy S 5 Unified Development] razor17:
Does it works with Klte?
[Samsung Galaxy S 5 Unified Development] swiftbones74:
Duh.. Read the op.
[Samsung Galaxy S 5 Unified Development] tomm1e:
Ok, that error comes from a request to LineageOS 15.1 resources, I removed that request and recompiled it, try this version:

https://drive.google.com/file/d/1VVColk1q8D7_bM48QXo7hjDrB12pDolr/view?usp=sharing

Let me know if it works
[Samsung Galaxy S 5 Unified Development] Bosket:
G900F AEX v5.6 works like a charm ,test video record 720p/120fps slow motion ,perfect .

The Camera name changed to "enable" ,can you change to default name "Camera".

Thanks ! :good:

Edit :screenshot is set to 1080p ,just to show the active slow motion FPS .
[Samsung Galaxy S 5 Unified Development] tomm1e:
Awesome, does the High Speed work as well?

I'll look into that app name problem
[Samsung Galaxy S 5 Unified Development] rulex231:
Tested on lineage 15.1 klte build (SM-G900P model)

Everything works well, one bug i noticed was it doesn't work without flash, its not concerning but I'd like to point it out as a bug.

But I'd like to personally thank you so much for working on this mod as 60fps recording was one of the reasons I switched back and forth from AOSP to stock as I use this feature alot, I'm happy to know awesome devs like you are finally working on this, I wish you all the best with this project and I will keep testing and report back accordingly :)
[Samsung Galaxy S 5 Unified Development] tomm1e:
Thank you!

With flash or without? I noticed it turned the torch off once recording starts, for now I made it so torch turns back on if it was set. New links in the OP. More changes are needed to properly switch into 60FPS after selecting it from the menu, that way the torch won't turn off.
[Samsung Galaxy S 5 Unified Development] Bosket:
Yes ,high speed work as well.

Camera name is not a problem ,just a suggestion.
[Samsung Galaxy S 5 Unified Development] cinghio71:
Tested, works perfectly. Thanks.

Inviato dal mio SM-G900F utilizzando Tapatalk
[Samsung Galaxy S 5 Unified Development] hsnhasantr:
Thanks, big biproject.

Does the front camera work?

I have not worked in my klte.
[Samsung Galaxy S 5 Unified Development] FfsWally:
Using a KTLE S5. The front camera doesn't work instead the camera app crashes. Highspeed and Slow-mo both seemed to working great. Would love to see the front camera get fixed. Thanks
[Samsung Galaxy S 5 Unified Development] Bosket:
Delete
[Samsung Galaxy S 5 Unified Development] rulex231:
Installed it this morning, works great now thank you, even the front camera works regardless as well.
[Samsung Galaxy S 5 Unified Development] Ano01:
So, whats the difference between the LOS and Others?? What am asking is, which one should i install in example, Resurrection Remix?? Sorry if its a dumb question, i just thought since RR is based on LOS......

Also, what are the exact bugs?
[Samsung Galaxy S 5 Unified Development] tomm1e:
I'm not sure if RR uses lineageos resource names, if LOS doesn't work the Others one should work. Only difference in those LOS versions is that Snap requests a resource from LOS configuration during startup, specifically which hardware keys are present for the camera, like home/back/menu, those will crash if you are not on lineageos. Others just keep a default hardware key set so no crash should happen in any android. Future versions will just handle the error, it will go back to one release if it still works across all android builds.

Bugs? Nothing major, currently the flash/torch has to restart when switching into 60fps. Maybe there should be a preference to keep the camera displaying 60fps while recording or not, to save battery. Trying to rewrite the wrapper to do this currently. Some say their front camera isn't working but I think that is only for certain variants, I need their logs to see what's going on.
[Samsung Galaxy S 5 Unified Development] donaldtrump388:
On my S5 G9008W (kltechnduo), with LOS 15.1, this just makes snap crash.
[Samsung Galaxy S 5 Unified Development] renzofronte:
Hello!!! great work done with this mod congratulations !!

Is there a tool that I love about the stock camera, selective focus, can you add it in future compilations?

---------- Post added at 01:15 AM ---------- Previous post was at 01:15 AM ----------

Hello!!! great work done with this mod congratulations !!

Is there a tool that I love about the stock camera, selective focus, can you add it in future compilations?
[Samsung Galaxy S 5 Unified Development] ofirmz:
Hi., Afther install it., Appears 3 as a name of the app., How can i change that?
[Samsung Galaxy S 5 Unified Development] ajox:
Is this compatible with latest los16 nightly?

Aren't a few of these system files updated from time to time on Los for klte (example libstagefright)... Maybe flashing this will work but it looks like the system files are not modified but overwritten with other ones (that could not be the latest ones)

You know what I mean?
[Samsung Galaxy S 5 Unified Development] greenaspen:
It worked just fine before (I think a few months ago), however currently it doesn't seem to. I kinda wish it were included in the official lineage os rom. The features it unlocks work very very well.
[Samsung Galaxy S 5 Unified Development] g.k.h.n:
I'm using Lineage OS 17 nightly on S5 klte and i couldn't use any version of this mod. Isn't it compatible with my OS or did i do something wrong?
[Samsung Galaxy S 5 Unified Development] J-Lindo:
I don't think this was developed with LOS 17 in mind.
[Samsung Galaxy S 5 Unified Development] g.k.h.n:
That's sad, i badly wanted 60 fps video because without OIS, 60 fps gives much better results in video, and it's easier to stabilize them after on a stibilizing software. I downloaded bunch of camera app but none of them helped. I miss only this thing from original OS.
[Samsung Galaxy S 5 Unified Development] J-Lindo:
Here, let me do a little leg work for you.

Hey [MENTION=7500155]tomm1e[/MENTION], do you intend to make this work on LOS 17.1?
[Samsung Galaxy S 5 Unified Development] mkdante381:
Pls add stagefright lib for Resurrection Remix Pie with Disabled 4GB file size limit
[Samsung Galaxy S 5 Unified Development] ancelmohenrique:
don't work on G900M with LOS 16.1
[Samsung Galaxy S 5 Unified Development] FettyWap:
Hello,

I have used this camera under Lineage OS 14.

I recently flashed Lineage OS 16 April 12 Build

I flashed Version 1.1 in twrp after flashing the latest build wiped Data and Cache, then flashed again wiped Data and cache again. Booted up camera app crashed. Went into app settings cleared cache and data rebooted, wiped cache and dalvik and it still crashes. I'm not sure what I am doing wrong
[Samsung Galaxy S 5 Unified Development] Noob9496:
This mod don't work o LOS 16.

Try this mod. https://xdaforums.com/galaxy-s5/themes-apps/magisk-a2-camera-s5-v1-t3844452
[Samsung Galaxy S 5 Unified Development] mkdante381:
Force stop app

Replace all files from zip to system

Restart user space system (Fast reboot)

Clear data and cache Snap

Rebuild Dalvik and Cache of Snap app.

App crash on 1st run only
[Samsung Galaxy S 5 Unified Development] Llamas_are_Good:
Do not replace your stock LineageOS Camera app with the one included in the zip. Just replace the media_profiles.xml and you are good to go.

UPDATE: (I forgot to edit this) replace only files from "vendor" folder (camera.msm8974.so from vendor/lib/hw and the media_profiles_V1_0.xml from vendor/etc)

(P.S. I've tried this method with my Note 3 running LOS17.1 and this should also work with S5 since this mod was build primarily for S5)
[Samsung Galaxy S 5 Unified Development] mkdante381:
That's not good tip... This mod have modified app snap and lib. Replacing media_profiles.xml don't add more features.
[Samsung Galaxy S 5 Unified Development] Llamas_are_Good:
sorry lol I forgot to mention the other file. updated my comment. Btw it's working even if you don't replace the Snap.apk (see attachment)
[Samsung Galaxy S 5 Unified Development] mkdante381:
Stop writing dude nonsense! Nnnnoooo you must update all files from zip to system. If your rom is not based on AOSP, don't copy to system libstagefright.so.

Force stop app

Replace all files from zip to system

Restart user space system (Fast reboot)

Clear data and cache Snap

Rebuild Dalvik and Cache of Snap app.

App crash on 1st run only

Tested and all is work.
[Samsung Galaxy S 5 Unified Development] Llamas_are_Good:
Uhh it's not nonsense tho, I've already done my method a couple of times while switching from different types of AOSP-base ROMS (Since 9.0 Pie to 10). Oh yeah this mod only works on AOSP ofc (I don't really know about your case since I'm using Note 3, so there may be some discrepancy between the ROMS built for Note 3 and S5, so maybe replacing the Snap.apk is important for you S5 users).

The only difference that I found out now is that, this mod doesn't properly work on newest builds of LOS 17.1, I mean the camera still works, but the 60 FPS doesn't work anymore, tho it can still record. Maybe it was kernel drivers problem or something related to.
[Samsung Galaxy S 5 Unified Development] mkdante381:
Why you talk in S5 group when you have Note3? Mod is for S5 only, max Pie(LOS16)... When you replace apk you have more options. That's normal. Read what autor this mod write in description how properly install this mod
[Samsung Galaxy S 5 Unified Development] androiddude7899:
Work on RR android Q?
[Samsung Galaxy S 5 Unified Development] mkdante381:
Not work...Why you asking about them? In description you have writed max Pie Android.
[Samsung Galaxy S 5 Unified Development] Noob9496:
For android 10 Q find modded GCam on this site.

https://www.celsoazevedo.com/files/android/google-camera/
[Samsung Galaxy S 5 Unified Development] FiestaLake:
Most of them will not work properly.
[Samsung Galaxy S 5 Unified Development] tomm1e:
Looks like the modified stagefright has symbol errors after updates in AOSP/LOS. Not sure when that happened. This will give a black screen on a clean install due to the camera crashing. It's the only library in this mod that gets frequently updated on AOSP so it has the highest chance of breaking the install when LOS gets updated.

Edit: Removed 1.11, see 1.2 in the main post.
[Samsung Galaxy S 5 Unified Development] V3_:
holy [profanity] you're back. i thought this mod is dead lol. thanks for continuing the development
[Samsung Galaxy S 5 Unified Development] tomm1e:
Experimental build 1.3 available for testing. It may or may not work.

New preference: Album. This will store media into subdirectories: Default, Date, Custom, Hidden. Keeps the Gallery organized. See attached screenshots. You can even use Emoji for Custom album names. Emoji may not work on certain filesystems. In my testing the emoji did not work on 16.0 sdcards filesystem, works on 17.1 sdcard filesystem.

[P] LOS 16.0 (Android 9), TWRP 3.3.1 https://drive.google.com/file/d/1MPOfu7UXV-1RfWbW4EBJfSwmbVSnPXkC/view?usp=sharing

[Q] LOS 17.1 (Android 10), TWRP 3.3.1 https://drive.google.com/file/d/1T3d6tIj_aM_zcfS7Q-RNNrT2IkvMwwvf/view?usp=sharing

1.3, 16.0 Notes: The sdcard deletion bug for Gallery still exists on official LOS 16.0 builds. To recap, the media will delete from the gallery but the files will still exist on the sdcard, and will reappear after reboot. However if you do your own builds then with the 3 commits below you can get it working again. LOS has not merged the last change because it breaks secondary users storage (see 248662) but if you do not use secondary users then you will not have any issues.

- https://github.com/tomm1e/android_vendor_lineage/commit/6ad07dee60e26bdf88d9ac07face4d7a0fbe5610

- https://github.com/tomm1e/android_p...mmit/7cad0838a254f6422343d17d5a578d2e09382359

- https://github.com/LineageOS/android_frameworks_base/commit/c3f4b30d8e15228a12ca6bd1f4037d5c69dda6ea

1.3, 17.1 Notes: 1.3 stores files using the MediaStore, since this is a major change I expect some bugs. The ZIP will only install properly on TWRP 3.3.1. On TWRP 3.4 they have made major changes to the mounting code, so the standard install binary will not work. I need to update the installer to a shell script for future versions. You can downgrade TWRP 3.4 to 3.3.1 without issue to install this mod, but remember your TWRP backups are only visible to the version you are using. So if you are on 3.3.1 and have 3.4 backups you will not see your 3.4 backups but they are still there, just not visible until you upgrade back to 3.4.

Thanks again everyone. If you have any ideas let me know.

Have a great one!
[Samsung Galaxy S 5 Unified Development] saikyom:
how to uninstal in case it didn't work?
[Samsung Galaxy S 5 Unified Development] guest4711:
Restore the files you backed up as described in opening post.
[Samsung Galaxy S 5 Unified Development] Lordicus21:
Is it possible to install on Android 11?
[Samsung Galaxy S 5 Unified Development] Noob9496:
This mod doesn't work on Android 11
[Samsung Galaxy S 5 Unified Development] vancedance:
Really cool mod. Thank you!
[Samsung Galaxy S 5 Unified Development] avidichard:
Boot loop on Lineage OS 17.1 G920W8
[Samsung Galaxy S 5 Unified Development] furiousdroid:
what would it take to bring this over to 18.1?

were there any incompatibilities or did the dev just never try

willing to work on this if there's no hard incompatibilities that are known lol :P
[Samsung Galaxy S 5 Unified Development] furiousdroid:
i have gotten it to work on 18.1, will create a post about this soon (sooner if anyone's still interested, otherwise this project's on the backburner)
[Samsung Galaxy S 5 Unified Development] furiousdroid:
for anyone following this thread, ive published it.

if there's anyone available for testing it (ive installed it on my klte and it seems to work), id like to hear their reports too.
[Samsung Galaxy S 5 Unified Development] tomm1e:
Do you have the log of the crash?
[Samsung Galaxy S 5 Unified Development] HeAdShOtRgB:
I am using SM-G900I (kltedv) running latest AEX and both LOS and non-LOS versions of this crash upon opening.
[Samsung Galaxy S 5 Unified Development] Ano01:
OK, then I'll be testing soon and informing you.. I'm on RR 6.1.0(Oreo), g900p..
[Samsung Galaxy S 5 Unified Development] Bosket:
Page 1 post 7 ,only that version works for me .

I'm on last AEX v5.6 ,but klte (G900F).Make backups and give it a shot !
[Samsung Galaxy S 5 Unified Development] Ano01:
Amm, i found a problem with the 0.2 non Los, the Snap.apk in the zip is corrupt, or rather its the Snap.odex renamed to Snap.apk.. I downloaded the Los one and found the apk is ok there, so i extracted it and replaced it, rebooting to test now..
[Samsung Galaxy S 5 Unified Development] Bosket:
People waiting here ,hurry up... :D

Dam...that's a looong reboot !
[Samsung Galaxy S 5 Unified Development] tomm1e:
Oh thanks for finding that, I wrote a script to create these zips during 0.2 and I guess it screwed the second zip. I removed the link. Anyway, I am in the process of a full rebuild of my LOS so I will post another version later tonight that just handles the error on resources so Snap should work across different OS.
[Samsung Galaxy S 5 Unified Development] Ano01:
Hahahah, am sorry, I had some stuff to do first, well, after the reboot, the camera app crashes on opening.. But other apps seem to work, like Open Camera and Geak Camera, all work, front and back..

---------- Post added at 11:50 AM ---------- Previous post was at 11:48 AM ----------

Cool, anxiously waiting..
[Samsung Galaxy S 5 Unified Development] tomm1e:
Try 0.3 in the OP and let me know if it works. If it's still crashing post the log/stacktrace
[Samsung Galaxy S 5 Unified Development] Bosket:
G900F AEX Oreo ,v0.3 is the "wanted" mod for S5 ,close to stock ,close to perfection.

Good job [MENTION=7500155]tomm1e[/MENTION] ! TY ;)
[Samsung Galaxy S 5 Unified Development] Ranniel:
the mod works fine but what is the difference compared to the slow mode and the fast mode the 2 record at 60Fps but I do not notice any difference?

(Why change the name of the camera to enable?)
[Samsung Galaxy S 5 Unified Development] tomm1e:
Try to clear the app's data/cache for Camera, then reboot and see if the name changes back. Seems to fix it when I get that issue. The app name is actually Camera, but for some reason when replacing system apps it messes up the app name in android resources, assigning it to some other string.

Edit: Try this version

https://drive.google.com/open?id=1VLpDTCy0cH_qmorZ0v7b-b96hVPcf3tI
[Samsung Galaxy S 5 Unified Development] HeAdShOtRgB:
I have installed the v0.3 ZIP. Everything works fine and as expected, but the name has changed to disable now... Cleared data/cache and name stays as disable.
[Samsung Galaxy S 5 Unified Development] james_rokr:
Working on G900F under CrDroid and Resurrection Remix latest version
[Samsung Galaxy S 5 Unified Development] Ano01:
0.3 working like a charm.. Thanks bro..

Now the only thing left is if you could help change the name, as instead of Camera, it displays 'enable' in my app drawer..

See image..
[Samsung Galaxy S 5 Unified Development] Mcha01:
This mod wont work on nougat right? :confused:
[Samsung Galaxy S 5 Unified Development] j1gga84:
That would be great because a lot of users still remain on N for good reason :good:

regards
[Samsung Galaxy S 5 Unified Development] Mcha01:
Im still using nougat as my daily driver... I didn't liked oreo ? but the developers are making great stuff ?
[Samsung Galaxy S 5 Unified Development] mission712:
Hi, installed this on the latest unofficial 15.1, works great. One little thing: the app is named 'disable' on my screen, rather than 'Snap'. Is this expected?
[Samsung Galaxy S 5 Unified Development] tomm1e:
Strange resource issue. Try this one out, I modified the manifest and put actual strings instead, let me know if it works:

https://drive.google.com/open?id=1VLpDTCy0cH_qmorZ0v7b-b96hVPcf3tI
[Samsung Galaxy S 5 Unified Development] tomm1e:
I can try compiling it for nougat, but I need to download nougat sources again and rebuild, if it works I'll post a nougat version
[Samsung Galaxy S 5 Unified Development] tomm1e:
https://xdaforums.com/showpost.php?p=76968132&postcount=40
[Samsung Galaxy S 5 Unified Development] Ano01:
Ok, now the name changed, but its still not right, check this..
[Samsung Galaxy S 5 Unified Development] tomm1e:
Here is nougat/14.1 version, I did not test it though, only compiled it, rolling the dice here, nougat users go ahead and test it, if it crashes attach the log :good:

Backup before install:

/system/etc/media_profiles.xml

/system/lib/hw/camera.msm8974.so

/system/priv-app/Snap/Snap.apk

https://drive.google.com/open?id=1bGzjcX0Ew-g1Ge_JJPYj5n0-IzzI0tsp
[Samsung Galaxy S 5 Unified Development] Ranniel:
it works perfectly thanks:laugh:
[Samsung Galaxy S 5 Unified Development] mission712:
Hi, I tried this mod for a day, and it breaks the Camera after the first launch. If you take photos/whatever then swipe it off from recents, when you re-launch Snap you won't get any picture on the screen, and pressing capture hangs the app. I reflashed Lineage to be able to use camera for now, so no logcat (sorry), if you cannot reproduce I can try getting a logcat for you.
[Samsung Galaxy S 5 Unified Development] Mcha01:
Hey, i tried your mod the nougat version it works on rear camera but when i try to open front camera it carshes
[Samsung Galaxy S 5 Unified Development] tomm1e:
Need more info

- Camera mod version

- OS

- Device model

- Log (attach as file or upload to paste site)

You don't have to do a full reflash of Lineage, if you made a backup just push those files back to the device while in recovery, it's only a few files.
[Samsung Galaxy S 5 Unified Development] Ranniel:
Camera version - nougat 0.1

OS - AOKP 7.1.2

Device Model - G900V
[Samsung Galaxy S 5 Unified Development] Mcha01:
Camera version 2.0

Slim rom 7.1.2 unofficial

G900v

I dont know how to make log sorry ?
[Samsung Galaxy S 5 Unified Development] tomm1e:
Ok, seems like one of the focus modes is unsupported, try this version:

https://drive.google.com/open?id=1FwIknL9QTmX5dBlonFwdrP6zYKtmjqqn

If there more errors attach the log
[Samsung Galaxy S 5 Unified Development] Ranniel:
install it but still giving error

Clean cache, open the application and switch to the front camera (So ​​you have a clearer vision) I think the log came out big
[Samsung Galaxy S 5 Unified Development] mission712:
- 0.3

- lineage-15.1-20180614-UNOFFICIAL-klte

- SM-G900FQ

- As I said, I already removed it, so no logcat. If you cannot reproduce tell me and I'll reinstall.

I didn't wipe+flash, I simply reinstalled the same lineage version I had.
[Samsung Galaxy S 5 Unified Development] tomm1e:
Test 2

https://drive.google.com/open?id=1vmorFbAfUwFPFsV08kisUZ6M6bpiWiLP
[Samsung Galaxy S 5 Unified Development] tomm1e:
The more logs the better :good:

I am only able to test for SM-G900P and I can not reproduce that issue on it
[Samsung Galaxy S 5 Unified Development] mission712:
Okay. I'll try adding your mod again and getting a logcat.
[Samsung Galaxy S 5 Unified Development] 10goto10:
Works on G900F, LOS 14.1, 20180623. Records at about 59fps. Taking a picture with the front camera makes it hang and not save the picture though. I don't use the front camera much, so I don't mind.
[Samsung Galaxy S 5 Unified Development] Ranniel:
it works, thanks for the fast tracking:svetius:
[Samsung Galaxy S 5 Unified Development] taylorhmatos:
Tested on Ressurection Remix and it worked perfectly. Now on MOKEE it gives camera error. Any solution? Excellent modification, I was able to use something I only had in the rom stock.
[Samsung Galaxy S 5 Unified Development] swiftbones74:
[MENTION=7500155]tomm1e[/MENTION] thanks for getting this together for us brother. This is looking like the best camera mod we have ever had for aosp/cm on the gs5! @ the moment its fc for me. I can grab a log if you like although I'm on v1. I did not follow your advice and make a backup. I am wondering if I can flash this over the other mod or if that will just make more problems? Please advice and let me know if you want a log first. Thanks again for your awesome contributions!

Camera_mod_v1

RR_7.1.2

Sm-g900v
[Samsung Galaxy S 5 Unified Development] tomm1e:
Thanks! It's ok to flash over the old versions. Try out the nougat v2:

https://drive.google.com/open?id=1vmorFbAfUwFPFsV08kisUZ6M6bpiWiLP

If still crashing on v2 attach a log
[Samsung Galaxy S 5 Unified Development] tomm1e:
For MOKEE solution I need more info about the error. Please post Device, OS/Rom version, camera mod version, and attach log file of the crash
[Samsung Galaxy S 5 Unified Development] iPAQ 6515a User:
Working on 900M. Nougat
[Samsung Galaxy S 5 Unified Development] mission712:
I just tried to get a logcat, but couldn't get the bug to happen using 0.3. I'll see if it happens again.
[Samsung Galaxy S 5 Unified Development] SrZambie:
Anyone able to record slow-mo while outdoors? It's a laggy preview with final recording in normal motion for me. Indoor recordings are perfectly fine.

LOS 14.1

SM-G900T

Latest Mod for Nougat
[Samsung Galaxy S 5 Unified Development] dm96:
works

Tested on LOS 14.1 2018/6/15 build. The first flashable resulted in front facing camera not working. The second flashable zip works perfect. Tested 1080@60fps, 720@120fps.

A smal bug: sometimes it does not record in slow motion, it just makes normal video with low bitrate, happens when you open the app and immediately start recording.

Outdoor recording work even better. I have attached a video to see.
[Samsung Galaxy S 5 Unified Development] systemcrash:
All good for me. G900F. LOS 15.1 lineage-15.1-20180704-UNOFFICIAL-kltedv.zip

back camera

slow-mo OK

hi FPS OK

selfie camera cannot do any slow-mo or hi-FPS.

Edit: when changing apps, camera is called "enabled" with v0.3 zip, cannot switch to selfie camera from within apps like FB messenger when using this zip. original snap works on this point, however.
[Samsung Galaxy S 5 Unified Development] Bosket:
Haha... dude you like to shake it ! :D