yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S 5 Unified Development] :
0.3 works great:D

But it is also named "enable" on my G900F, I have tried clearing cache etc.

LineageOS 15.1 KLTE (haggertk's build 04-07-2018)

Screenshot: ufile.io/ty8dy

Sorry about the link, I'm too new to post images;)

Edit: It appears that the issue was resolved when LineageOS became official for KLTE:)
[Samsung Galaxy S 5 Unified Development] systemcrash:
For video, is something like AGC possible on audio? Whenever I try and film in high SPL environments, the audio gets distorted. Using the camera in Samsung firmware, video recordings have undistorted audio; the device/camera 'ducks' the audio level to avoid crunch and distortion.
[Samsung Galaxy S 5 Unified Development] donaldtrump388:
Actually, it got fixed when I reinstalled snap. And high fps recording was working afterwards. But, on another unofficial lineageos build, it was working with no problems. And how do I get a log?
[Samsung Galaxy S 5 Unified Development] rcmaehl:
*snip* Ignore this
[Samsung Galaxy S 5 Unified Development] tomm1e:
Looks like all of the AGC stuff is completely commented out in klte's audio_effects.conf and android_hardware_qcom_audio, guess it's not working.

Preprocessor only has AEC and NS. If I knew more about that stuff I would try to fix it. Maybe one day :p

I could add a new menu to change audio sources though, like from Camcorder/Mic/Voice Communication/Voice Recognition/Unprocessed, etc
[Samsung Galaxy S 5 Unified Development] tomm1e:
0.4 has been posted in OP, just has some code cleanup and made it restart the flash when changing resolution/settings in the menus. No more re-enabling flash.

Oreo users there's a way to regenerate Snaps dalvik cache after installing, without rebooting or clearing the whole cache:

adb shell cmd package compile -m speed -f org.lineageos.snap

Or without "adb shell" from a root terminal app. Snap will not launch if its dalvik cache is from a different version.
[Samsung Galaxy S 5 Unified Development] hsnhasantr:
Thanks tomm1E
[Samsung Galaxy S 5 Unified Development] Mcha01:
I get instant crash when i take a selfie

Im on v0.4 camera mod

My device is g900v

My os : lineage os 14.1 nougat latest version
[Samsung Galaxy S 5 Unified Development] tomm1e:
Try this version:

https://drive.google.com/open?id=15vXaxit6N-ZvOUyqpx1smgY3Ju-tKNcS
[Samsung Galaxy S 5 Unified Development] Mcha01:
Thank you for your fast response, now it works but it hangs for a second then takes the picture, i dont have a problem with that as longs it works ❤️
[Samsung Galaxy S 5 Unified Development] tomm1e:
Try 0.5 now, that hang was pretty bad, didn't test front camera in 0.4

https://drive.google.com/open?id=1Na-XCy3P25kTroG2RDU6MoPp4-9_-TT7
[Samsung Galaxy S 5 Unified Development] Mcha01:
Now its working flawlessly no crash no lag, thank you so much ❤️
[Samsung Galaxy S 5 Unified Development] hsnhasantr:
All this custom rom should have this camera. a Wonderful working friend. Thanks.
[Samsung Galaxy S 5 Unified Development] systemcrash:
Give it a whirl. I'll test it. If AGC wasn't working, it wouldn't be in the original sammy ROM. AGC is the polish that any aftermarket ROM camera needs. Everything hitherto is nicely done, however!
[Samsung Galaxy S 5 Unified Development] SrZambie:
In 0.5 I'm unable to turn on the flashlight via quick settings or holding down power with screen off. Logcat spits out this error:

07-18 00:11:43.936 E/FlashlightController( 901): Couldn't set torch mode

0.4 doesn't have this issue but 0.4-2 has the same issue and error.

Running LOS 14.1
[Samsung Galaxy S 5 Unified Development] systemcrash:
Bugs in 0.5

Video camera, using flash, disables flashlight via quick settings. Disabling flash in video cam doesn't help.

Switching to camera for photos, and enabling flash, turns the torch on continuously, instead of momentary 'flash' for photos. Flashlight from quick settings still inaccessible.
[Samsung Galaxy S 5 Unified Development] tomm1e:
Nice find, here is Nougat 0.5-3, also posted Oreo in OP

https://drive.google.com/open?id=1_tHPtO56pDA3S7ZeCry7V4g6DTN2yyUv
[Samsung Galaxy S 5 Unified Development] tomm1e:
0.5-3 posted in OP, "On" shouldn't stay on now
[Samsung Galaxy S 5 Unified Development] cheaterel:
Hello and thanx for this mod , i have a bug on Facebook Messenger if i want to use the camera i get "sorry,the camera is not working right now . you mightneed to close any other camera apps you have running " but only on messenger on facebook works can u test guys and tell me thanx

RR Oreo rom G900F

PS : tested the last version and now it works don't no if it was from messenger or from the camera mod but without the mod it was working .

Thanx it works great
[Samsung Galaxy S 5 Unified Development] systemcrash:
Earlier problems fixed. Other apps can use the cam. Unless further testing reveals problems, this camera is now on par with Snap, minus the intended additions.

---------- Post added at 07:49 PM ---------- Previous post was at 07:48 PM ----------

Did you recompile?

adb shell cmd package compile -m speed -f org.lineageos.snap
[Samsung Galaxy S 5 Unified Development] rcmaehl:
Thanks! Should I do this after each upgrade to be safe or only if I encounter issues?
[Samsung Galaxy S 5 Unified Development] clockstoper:
Thanks for your great work ,will this work on my g900fd klteduos ?
[Samsung Galaxy S 5 Unified Development] vlad3647:
15.1 g9008 ,thanks
[Samsung Galaxy S 5 Unified Development] Vini69:
Just installed it on my g900fd klteduos and I can confirm this is working ! Great job, thanks !

[MENTION=7500155]tomm1e[/MENTION] I think the install script should do the backup, and there should be an uninstaller script too.

Otherwise, just reflashing the current lineageOS build does the trick.
[Samsung Galaxy S 5 Unified Development] Ranniel:
A script would be great
[Samsung Galaxy S 5 Unified Development] Win98and95:
I formatted my SD card with exFAT but the files aren't any bigger than 4GB.

It stops the recording when the file size reaches 4GB.

any help? [MENTION=7500155]tomm1e[/MENTION]
[Samsung Galaxy S 5 Unified Development] tomm1e:
Try 0.6 in OP.

I tested this on Oreo and sdcard with F2FS. Although Snap sets a 4GB limit, an extra mod had to be done on stagefright as well.

Note: Use VLC when playing the 4GB+ files, the default android video player seems to freeze up playing 4GB+.

Also added video and audio bitrate preferences to advanced camera options.
[Samsung Galaxy S 5 Unified Development] FettyWap:
Hello using Oreo on a 900p, it used to work and then just stopped, error is Could not start media recorder. Could not start video recorder. On 20180813 Lineage OS nightly with a custom kernel based on Boefla. I flashed .6 and wipe cache and dalvik footej camera records but stock camera does nothing. Any suggestions?
[Samsung Galaxy S 5 Unified Development] tomm1e:
Attach the log file from adb logcat
[Samsung Galaxy S 5 Unified Development] flyingsaucer75:
Thanks for your work.
[Samsung Galaxy S 5 Unified Development] FettyWap:
Hello,

Went back to 14.1 and started fresh 15.1 doesn't seem 100% road ready thank you for your help!
[Samsung Galaxy S 5 Unified Development] unzipped:
Installation

Hey,

I run LOS 15.1 on a G900F. I installed the zip in TWRP and get the "Installation successful" message. Cache was wiped before the system reboot. The name of the Camera app has also changed to Hardware ZSL, but I don't see the supplementary settings in the app.

Could anybody explain to me what I did wrong? I would love to use this mod..

Thanks!
[Samsung Galaxy S 5 Unified Development] Win98and95:
Maybe try flashing it again?

Did you download the correct version for your rom?
[Samsung Galaxy S 5 Unified Development] unzipped:
After an update of the system and another flash it works now. Thanks :good:
[Samsung Galaxy S 5 Unified Development] rcmaehl:
-snip- nvm finally found it as "hardware zsl"
[Samsung Galaxy S 5 Unified Development] Carlo Borbor:
thank you for this patch. I hope soon it will support on Pie rom. thanks
[Samsung Galaxy S 5 Unified Development] tomm1e:
Thank you. It works fine on Pie, tested it on my kltedv build couple days ago. :good:

Waiting on a framework change to get merged before I release it
[Samsung Galaxy S 5 Unified Development] Carlo Borbor:
did you mean It will work on Pie or need some modification? I tried the Oreo patch on Pie rom but it gives an error like infinite bootloop.
[Samsung Galaxy S 5 Unified Development] tomm1e:
It works, but use the 0.7 version for Pie and only install on 16.0 builds on or after 20180916, it will crash on older builds like 20180909.

The Oreo releases are incompatible with Pie so those will crash too.

Pie 0.7

https://drive.google.com/open?id=1n3kN2ZjWVD3MeGovZPRlYI85YkVij4Uc
[Samsung Galaxy S 5 Unified Development] rusherrrx:
Worked well on my SM900S (kltekor). Running Resurrection Remix Nougat v5.8.5.
[Samsung Galaxy S 5 Unified Development] flyingsaucer75:
Perfectly working on klteduos with resurrection remix 5.8.5, 7.1.2 nougat. Thanks for your modding. Best regards

Tony
[Samsung Galaxy S 5 Unified Development] Be4st187:
Am I being blind or are there no settings to decide where I store photo's? My S5 has an SD card, but it's formatted as internal memory and when using the camera, I get constant 'Could not find SD card' spam.

RR-O-v6.2.0, 8.1, G900F
[Samsung Galaxy S 5 Unified Development] fubo73:
If "formatted as internal memory" means adoptable storage, then you should see a single huge disk. It will be the OS that decides where to put data, either on internal or external card.
[Samsung Galaxy S 5 Unified Development] 12h01:
Working fine on SM-G900M with HavocOS 8.1.0. Thank you!
[Samsung Galaxy S 5 Unified Development] jerfsonpaiva:
Hi. I use the google Camera. This mod don't work for me. A new camera app icon appears but when open this camera app they crash.

When i open the google camera they works. But, no slow motion 60 fps or 120 fps.

I only download the Oreo v0.6: https://drive.google.com/open?id=1fM...WCRegu918PqRFp and flash? I have TWRP 3.2.3-0.

I'm using a LOS 15.1 (8.1) on SM-G900m.
[Samsung Galaxy S 5 Unified Development] ildorn:
Hey,

I run Resurrection Remix-OS 6.2.0 on a G900F.

I tried the following steps with version v0.6 and v0.5-3 for Oreo:

1) Install the zip in latest TWRP and get the "Installation successful" message

2) Wipe cache/dalvik.

3) Reboot to system.

The name of the Camera app has changed to Hardware ZSL. but won't start. and a crush message appears.

Unfortunately I don't know how to get the adb log.

Any help would be much appreciated.

Thanks.
[Samsung Galaxy S 5 Unified Development] Be4st187:
Had this issue with mine when I first used it. I just cleared it's data and cache and all was fine. I had also installed RR fresh too, so maybe that was a contributor.
[Samsung Galaxy S 5 Unified Development] ildorn:
I disabled the camera2Api module in magisk, then is started working. Still crashes do happen in some scenarios. Will update later.
[Samsung Galaxy S 5 Unified Development] j1gga84:
also checkout this mod, seems also amazing :) :good:

https://xdaforums.com/galaxy-s5/themes-apps/magisk-a2-camera-s5-v1-t3844452

regards
[Samsung Galaxy S 5 Unified Development] tomm1e:
Removed the pie build for now.. the camera on recent pie builds has some kind of fps/vsync issue
[Samsung Galaxy S 5 Unified Development] Coaxs94:
Does it work on Pie on sm-g900F? Thank you.
[Samsung Galaxy S 5 Unified Development] Tech0308:
Read the post by the OP just before yours:)
[Samsung Galaxy S 5 Unified Development] jackson_c:
Hi, I'm having a problem with constant sound noises when I record videos. I'm not relating to this mod, but I think it's a good place to ask. I read that this may be being issued by the camera itself as it does not occur in the audio recorder app. Does anyone know about this? Anything I can do to get around it? It happens in Stock and Lineage, with any app.
[Samsung Galaxy S 5 Unified Development] 7bangho7:
Hi, I have the S5 klte with DOTOS 2.5, Which one should I install?

th-cameramod-klte-6.zip or th-cameramod-klte-nonlos-1.zip?
[Samsung Galaxy S 5 Unified Development] Be4st187:
Need a bit of help with this mod. I was recording a video and my phone crashed. Not sure why, but the video cannot be viewed. Is there anything I can do to recover it?
[Samsung Galaxy S 5 Unified Development] flozge:
Try to clean your mics with a needle
[Samsung Galaxy S 5 Unified Development] jackson_c:
In audio-only recording apps this does not occur. In fact, I've heard a buzz coming from the camera, and that must be it. But I'll try your suggestion. Thank you.
[Samsung Galaxy S 5 Unified Development] flyingsaucer75:
It seems a kind of interference between screen and mic if used togheter. Maybe it depends by screen resolution, try recording video and audio with differs res.
[Samsung Galaxy S 5 Unified Development] jackson_c:
I tried all the different resolution options and did not notice any significant difference. Here's a sample of the problem. Note: the TV was on, but it can barely be heard.

Again, in an audio recording app this does not happen.

Thank you in advance.

https://drive.google.com/file/d/1tX1Ma3T89vPQAmSbvTdLxrCVcpRqh48UjA/view
[Samsung Galaxy S 5 Unified Development] 7bangho7:
In instagram the camera does not work. And you have a backup for those who have dotos 2.5?

tested on a g900f
[Samsung Galaxy S 5 Unified Development] james_rokr:
Just reflash DotOS and you're done
[Samsung Galaxy S 5 Unified Development] saikyom:
I have kltekor, the only problem i have is that when i record videos the sound is mono,not stereo.

but when i use just voice recorder it's in stereo :)
[Samsung Galaxy S 5 Unified Development] 7bangho7:
Does the camera go on instagram? because I do not
[Samsung Galaxy S 5 Unified Development] DanielAedo:
What about SM-G900M?

It seems to be interesting
[Samsung Galaxy S 5 Unified Development] iPAQ 6515a User:
Working 100%
[Samsung Galaxy S 5 Unified Development] leonardcoutinho:
any chance to merge camera tweaks in Lineage or AOSP main code?
[Samsung Galaxy S 5 Unified Development] tomm1e:
I have not made any new changes to this mod but I have tested the previous Pie release on a recent LOS Pie build 20181203 and the camera stability seems to match 15.1 again.

It's best to install the camera zip right after the LOS zip during a clean install. If you boot into LOS and then install this it will mess up the app name since Snap was already processed. If the app name is different, try to wipe dalvik/art & cache in TWRP and reboot.

Happy Holidays
[Samsung Galaxy S 5 Unified Development] tomm1e:
It's up to LOS' klte maintainers, I submitted the camera wrapper to LOS' Gerrit back in July/August:

https://review.lineageos.org/c/LineageOS/android_device_samsung_klte-common/+/220435

Along with some other Snap changes (which has another maintainer) but still no response from either

I just posted links to my Github repos for this in the main post.

It has no place in AOSP main code since it's mostly device specific, maybe only the 4GB+ recording fix change but I noticed a better version to fix that stuff in frameworks:

https://android-review.googlesource.com/q/topic:"sony_rec_limit"+(status:open OR status:merged)

which reads the filesystem type of the sdcard to see if it supports writing over 4GB or not, mine simply allows it regardless of filesystem type
[Samsung Galaxy S 5 Unified Development] tomm1e:
Pie 0.8 added, fixed the SD card issue. See main post for full info
[Samsung Galaxy S 5 Unified Development] Vortell:
You think there might be a way to port this to note 4?
[Samsung Galaxy S 5 Unified Development] tomm1e:
Just the Snap app? It should work on Note 4, I can't test it myself though I don't have a Note 4. But if you just want the camera app, you can try to flash the zip, it won't hurt to have the S5 camera wrapper file in there because Note 4 doesn't even use that one. According to the sources the Note 4 should already have a working wrapper with HFR/HSR support, unless it's broken.
[Samsung Galaxy S 5 Unified Development] Vortell:
No 4k or 120fps. Are most the changes in the wrapper?
[Samsung Galaxy S 5 Unified Development] tomm1e:
Ah I see, after skimming through Note 4 wrapper source again I think it just needs a couple parameters added so Snap can recognize 120fps support. As for 4k, does the resolution not appear in the video menu or does it just fail to save at 4k? Anyway I'd have to disassemble the Note 4 stock camera app if it's any different than the S5 stock camera, to know for sure what parameters to set in that wrapper. The 60fps works though?
[Samsung Galaxy S 5 Unified Development] Vortell:
It's been a while since I tried it. If I tender right it didnt show the option and have never seen 120fps on any note 4 non-stock camera. I was just curious did't think you would be so kind as to jump right in and try to fix it! Your awesome! Not even sure where to get snap anymore. It used to come with emotion os though on the note 4. That's Android 7.1.2 based though and was my favorite rom in nougat days.
[Samsung Galaxy S 5 Unified Development] mkdante381:
Probably this is only for AOSP "org.lineageos.snap"
[Samsung Galaxy S 5 Unified Development] mkdante381:
I have ADB & Fastboot for Android NDK Magisk module. How force rebuild dalvik with ADB on smartphone?
[Samsung Galaxy S 5 Unified Development] Plut0nio:
I'm wondering about this as well. I have an SM-G900P (US, Sprint) with Magisk v18.1 and I installed the Pie v0.8 .zip with TWRP and hit "Wipe cache/dalvik" afterwards. However, although I got the "Fast motion 60FPS" option, the videos I took were only 60 FPS for the first second with the rest of each video being 30 FPS. I also don't have a media_profiles.xml file. Instead, I have a file called media_profiles_V1_0.dtd in /system/etc. Help? I might fool around with this later since I just upgraded to the newest LineageOS 16.0 build (20190411-NIGHTLY-kltedv). Thanks.
[Samsung Galaxy S 5 Unified Development] tomm1e:
The XML path for media profiles appears to have changed. I think this caused invalid frame rates to be set during initialization of recording, which appeared in the earlier Pie versions.

Either flash the 0.8-2 zip or move the mods XML to the new location:

I haven't been able to work on this lately but next thing to do is change the saving method to SAF and add folder selection for saving to sdcard.
[Samsung Galaxy S 5 Unified Development] Plut0nio:
This seemed to do the trick. Thank you so much! I had to use Ghost Commander to move the media_profiles.xml file and then rename it to media_profiles_V1_0.xml, though. I'm having issues with adb and manipulating system files. "adb root" doesn't do anything and it says that Root Access is Disabled in settings, even though I have Magisk 18.1 installed (I tried flashing that su add-on zip, but it didn't do anything). Doing the mv command in adb shell doesn't work because it'll say that system is read-only, even when it's mounted as writable using Ghost Commander. Oh well.

Also, does this site not allow quotes within quotes?
[Samsung Galaxy S 5 Unified Development] fbs:
you know your media_profiles are making all video recordings with extreeeeeeeeeeeeeemely high bitrate for sound, and MONO instead of STEREO?
[Samsung Galaxy S 5 Unified Development] tomm1e:
Of course, only mono is supported, I've tried to force 2 channels in the past, it fell back to 1 channel, at least on AAC. There are comments in the original XML that audio settings are "ignored" in certain areas.

As for bitrate, the original values were all 96, which is real low for 720p/1080p video IMO. Considering the total size of the file produced the audio portion is relatively small compared to the video, even at 256.

In Snap you can change audio and video bitrates in the mods advanced video preferences, tap the Bright Screen preference until its enabled.
[Samsung Galaxy S 5 Unified Development] fbs:
The default IS stereo for 720p onwards. I even made stereo for 480p on my MICGAIN mod.

Thanks for the tip about advanced video preferences, I didn't know that. And it shouldnt need something like that. Oh my
[Samsung Galaxy S 5 Unified Development] tomm1e:
Set everything to 2 channels and now I can finally see 2 channels in the media info, I guess I had not replaced all channel values before and it kept giving me 1 channel.

Thanks for pointing this out
[Samsung Galaxy S 5 Unified Development] tomm1e:
Released 0.9 for Pie, includes latest upstream changes on Snap and stagefright, and stereo audio
[Samsung Galaxy S 5 Unified Development] fbs:
for the record, with AAC and 2 channels, 128kbit = DVD-Quality.. More than 128kbit for our simple MICs is a huge waste
[Samsung Galaxy S 5 Unified Development] Plut0nio:
Not working anymore (SM-G900P)

This isn't working for me anymore (SM-G900P). I updated LineageOS to the newest version (16.0-20190513-NIGHTLY-kltedv) as well as doing the same to TWRP (3.3.0-0). I installed th-cameramod-klte-pie-9.zip using TWRP multiple times, wiping the cache/dalvik afterwards sometimes and beforehand on others. I also did the "adb shell cmd package compile -m speed -f org.lineageos.snap" adb command. Now all of my 60 FPS recording options are gone except for the "Slow motion 60 FPS" and "Slow motion 90 FPS" ones. Help? Thanks.
[Samsung Galaxy S 5 Unified Development] sauth:
Looks very complicated. Please take a video tutorial.
[Samsung Galaxy S 5 Unified Development] V3_:
The mod sadly doesn't work on Resurrection Remix 7 Pie klte ROM but it was working on Dot OS 3 Pie klte

i didn't get a logcat because i forgot

(p.s i had to modify your flash file because the method of fixing the "broken" files by replacing them with a backed up one using a file explorer simply doesn't work. I hope you're okay with that)
[Samsung Galaxy S 5 Unified Development] uVSthem:
Does anyone know if this works with Pixel Experience rom?

https://xdaforums.com/galaxy-s5/unified-development/rom-pixel-experience-t3850592