yashsingh1/xdaforums huggingface dataset:
[Google Camera Mods] osm0sis:
[MENTION=4860033]Arnova8G2[/MENTION] using GoogleCamera-Pixel2Mod-Arnova8G2-V8.1.apk on my OP5T and the only image issue I can see (once I turned on the pink hue fix for Portrait mode shots and use HDR+ Enhanced) is that the front facing camera creates a garbled pink non-image when HDR+ Enhanced is enabled, but works fine with normal HDR+.

If there were some way to have it keep HDR+ on front facing and remember HDR+ Enhanced enabled on the back camera while switching between them then it's nearly perfect!

Edit: And the latest dot Magisk module for the Open Betas fixes HDR+ Enhanced on front facing also. Awesome! :D
[Google Camera Mods] Eric214:
Yeah this Gcam isn't a daily driver. Not that much better if at all in the pics and the focusing issue is a killer. How you don't have the focus issue ironed out first before release is crazy. I'm only using this mod for work expense pics I need to take to upload to fieldglass for submission. It allows me to select the MP to keep files sizes below 5mb which is the limit per file.

If the focus hunting issue is sorted out this would not be bad, though it will never replace the stock app as the video capture is still superior to the Gcam port by a long shot.
[Google Camera Mods] cstark27:
I have edited the first post Known Issues to make it more clear since people can't be bothered to read a sentence before downloading the app and hurrying to the forums to write down the same freaking thing that's been posted 10 times on the previous page. If one more person posts about Portrait Mode I'm going to lose my mind.

Also, please appreciate that someone is willing to waste their own free time to bring OP6 owners a port of Google Camera that works, even if it's not perfect.
[Google Camera Mods] aneesh12:
also add that slow-mo isn't working as there are so many noobs out here who doesn't know that slow-mo doesn't work in oneplus devices
[Google Camera Mods] Will008:
I got the OP6 since release and was about to return it and get a pixel 2XL because of the camera. The only thing that made me stick with it is this ported GCam.

I'm using the 1.2.2 release as a daily driver and yes autofocus takes some time but if you tap to focus it works great. Definitely worth using more than the stock camera app with the ****y detail level of faces. As for the front facing Cam its unusable for me on the stock app with it's processing, even with the 4MP GCam it is 100 times better IMO. Most of my pics are of people so the difference for me is huge.

The developers have worked very hard to get this port to where it is now and are still working very hard to get it to be as stable as possible, so please do not undermine the hard work that was put in getting this app to where it is now. If you can contribute by posting results, logs, or thoughts that fine, but calling their work bad or not up to par with the stock app is just disrespectful and would only discourage the developers to invest their time working on it.

I am very greatful for the time and effort Arnova8G2 and Cstark have put into making this happen.

Please note that I'm just giving my honest opinion on some recent comments I'm seeing, with no disrespect intended.
[Google Camera Mods] mf117:
Don't you have the problem with the front facing camera? Sometimes it appears the loading logo when I'm using it.

By the way, thank you so much to the developers, they are trying so hard to give us the best app.
[Google Camera Mods] Subhojit:
Anyone?
[Google Camera Mods] robotzki:
The amount of people who think they are entitled to a fully functional gcam port for free, without thinking about how much time and effort you developers are putting into this, is unheard of!

How dare you guys release something that doesn't improve my phone camera by 5000% with the snap of a finger ?

---------- Post added at 07:09 PM ---------- Previous post was at 07:08 PM ----------

Can't say I have noticed any issues, but I don't take that many selfies...
[Google Camera Mods] mf117:
These are some examples, even with the front camera
[Google Camera Mods] yashpatel99:
Videos is complete trash at night. It produces weird blur in the whole video. https://photos.app.goo.gl/BvqntLyyNB7zkuz48
[Google Camera Mods] Born2rein@gmail.com:
Share ur current settings that u have made
[Google Camera Mods] mf117:
I'm using the OP6_test_1.2.2_GCam_5.3.015_..._version

The one that is posted at the begining.
[Google Camera Mods] alexferdean:
You need more light. Not even Galaxy S9 would give you a better video in that light.
[Google Camera Mods] tibcsi0407:
The problem is that they are write-only. They won't even read the first post.
[Google Camera Mods] Blu3_Flam3s:
Must be a way to contribute or donate

I find it unfair that [MENTION=4860033]Arnova8G2[/MENTION] and [MENTION=2712580]cstark27[/MENTION] have to put in so much time for nothing. I will gladly donate if there a patreon or a crowdfunding campaign to support the great work they do. Im sure I speak for a few of the others here too.

Thanks guys for the phenomenal efforts
[Google Camera Mods] feeliumz:
Yes, you do! :)

There's a "Donate to me"-button below Arnova8G2:s name in all his posts. Not sure where cstark27:s button has gone? There used to be one. Otherwise we can contribute with logs, bug reports and whatever they ask for when they ask for it.
[Google Camera Mods] Blu3_Flam3s:
Thanks a bunch, appreciate the headsup ! I was able to find a link for [MENTION=4860033]Arnova8G2[/MENTION] , hopefully one will be available soon for [MENTION=2712580]cstark27[/MENTION] too
[Google Camera Mods] Arnova8G2:
I will add to what was said and explain why it takes time to fix the bugs.

1) We're working on Smali codes

ex: You have to understand these codes

# direct methods
.method public constructor <init>(Ldpl;Lfof;Lfor;Lfpn;Lfnu;Ldul;)V
.locals 23

move-object/from16 v0, p1

move-object/from16 v1, p0

iput-object v0, v1, Lkxa;->eK:Ldpl;

invoke-direct/range {p0 .. p0}, Ljava/lang/Object;-><init>()V

move-object/from16 v0, p0

iget-object v2, v0, Lkxa;->eK:Ldpl;

iget-object v2, v2, Ldpl;->p:Lcgn;

iget-object v3, v2, Lcgn;->i:Lkwk;

iget-object v4, v2, Lcgn;->aQ:Lkwk;

iget-object v5, v2, Lcgn;->bO:Lkwk;

iget-object v2, v2, Lcgn;->bP:Lkwk;

invoke-static {v3, v4, v5, v2}, Lbqy;->a(Lkwk;Lkwk;Lkwk;Lkwk;)Lbqy;

move-result-object v2

move-object/from16 v0, p0

iput-object v2, v0, Lkxa;->f:Lbqy;

sget-object v2, Lexg;->a:Lexg;

invoke-static {v2}, Lkwc;->b(Lkwk;)Lkwk;

move-result-object v2

move-object/from16 v0, p0

iput-object v2, v0, Lkxa;->g:Lkwk;

move-object/from16 v0, p0

iget-object v2, v0, Lkxa;->eK:Ldpl;

iget-object v2, v2, Ldpl;->b:Lfza;

invoke-static {v2}, Lexp;->a(Lkwk;)Lexp;

move-result-object v2

invoke-static {v2}, Lkwc;->b(Lkwk;)Lkwk;

move-result-object v2

move-object/from16 v0, p0

iput-object v2, v0, Lkxa;->h:Lkwk;

move-object/from16 v0, p0

iget-object v2, v0, Lkxa;->eK:Ldpl;

iget-object v3, v2, Ldpl;->p:Lcgn;

iget-object v4, v3, Lcgn;->bE:Livi;

move-object/from16 v0, p0

iget-object v5, v0, Lkxa;->h:Lkwk;

iget-object v3, v3, Lcgn;->u:Lbmc;

iget-object v2, v2, Ldpl;->n:Ldom;

invoke-static {v4, v5, v3, v2}, Lexr;->a(Lkwk;Lkwk;Lkwk;Lkwk;)Lexr;

move-result-object v2

invoke-static {v2}, Lkwc;->b(Lkwk;)Lkwk;

move-result-object v2

With original source code the app will work perfectly .

2) Portrait mode makes no error in a log, so you need to read more than 9000 smali files to find or that bug.

I understand there are impatients, That's why as soon as there's even a small patch, I share it.

For the moment you have the choice with the Stock version ( OnePlus made an effort to improve this app - disabling HDR doesn't work) Or use GCam with these bugs.

Thank you to all.
[Google Camera Mods] hassan987:
Is there a known reason for RAW photos overexposure on OP6?

Secondly is the reason known for EXIF data showing double the ISO and half the shutter speed (=4X more light) compared to Pixel 2 on all OP6 images ?
[Google Camera Mods] AcmE85:
The Pixel 2 has a better sensor with bigger pixel size, therefore it can catch more light.

Although the Pixel camera performance is mostly thanks to HDR+, they don't pack any mediocre sensors like OnePlus does.

The OP6 sensor is to the competition now what the OP3 sensor was to the competition in 2016, mediocre.

Not bad, but not that good either.
[Google Camera Mods] hassan987:
Im not 100% convinced by this observation. I have a lenovo ZUK Z2 pro with an even worse sensor than OP6, yet it doesn't have these problems of overexposed RAW and double the ISO.

Basically my suspicion is that due to some firmware bug, OP6 is continuously overexposing RAW files which contributes to loss of detail for all camera apps.

I do not fully understand the engineering part but my understanding is that camera firmware cant be optimized by users without root. Unless the firmware bug is not resolved by Oneplus, the full potential of the sensor cant be utilized by apps. Just my suspicion.
[Google Camera Mods] phate223:
Hello guys and girls,

This is my first time writing in the forums, so first of all I'd like to say thanks to the developers for all their effort.

My question would be what version can you recommend to someone who only uses the back cam to shoot normal photos.

i.e. no portrait, no selfie, no video, no portrait-selfie etc.

Is the pixel2mod in this case better than the 3mod?

What is the best current version in that case?

Thanks
[Google Camera Mods] Cell_7:
The sensor is not the issue, if you do a research you'll see that OP6 uses the latest IMX sensor which I wouldn't call mediocre, the software is the issue.
[Google Camera Mods] AcmE85:
Age and specs are two different things.

Simply by comparing the Pixel 2 sensor specs to the OP6, it should be obvious that the OP6 won't reach the same ISO / shutterspeed performance:

Bigger pixelsize = more light intake = lower ISO and/or faster shutterspeed can be used in comparison to a smaller sensor to get "comparable" results in terms of exposure.

But I'm out, sorry for off-topic to the devs.
[Google Camera Mods] Cell_7:
What does "Shutterspeed performance" even mean??

Pixel 2 has a pixel size of 1.4μm and OP6 has 1.2μm, same as the newest iPhones, so yet again, sensor is not the issue here.
[Google Camera Mods] hassan987:
We make a humble request to devs for spending a short time to deep dive into this high ISO and RAW overexposure anomaly experienced only on Oneplus phones!

---------- Post added at 07:08 PM ---------- Previous post was at 07:04 PM ----------

If it can be ascertained that there is a genuine RAW overexposure taking place, then a simple workaround would be to offer a "RAW correction" option which uses an exposure compensation of -1 EV for the image, however maintaining the post processing at 0 compensation for a normal result!
[Google Camera Mods] Dark Crow:
[MENTION=4860033]Arnova8G2[/MENTION]

I personally and likely a good chunk of the people here dont really care much for portrait mode or video for that matter. Should the auto focused be improved/fixed it will already be a finished app in ny book.

I really dont understand the thought processes of these self entitled people who are demanding stuff all the time. This is a free app its not like they paid for it of a part of the phone itself.

Ill take any improvements that come out and thanks for all the work!
[Google Camera Mods] Adala_:
I agree with that , the tint was fixed and if focus gets fixed then it's done in my book
[Google Camera Mods] alexferdean:
I get what you're saying, but the sensor is actually quite good. The dynamic range is very good and the ISO performance seems good. Yes, the pixels are not the biggest around, but the camera can do some magic with the right software. OP3 also had a great camera, better IMO than 5/5T.
[Google Camera Mods] hassan987:
Hi, I wish to share two observations about OP6_test_1.2.2_GCam_5.3.015-Pixel3Mod-Arnova8G2.apk

1) The tint issue is solved however, the white balance is still slightly on the warmer/magenta side compared to actual Pixel 2 phone as well as OnePlus6 stock camera. I did the comparison by transferring all images to a computer, and it happens 100% of the time that the white balance is still a little magenta/warm, compared to stock app or original google pixel 2 phone.

2) When using flash on stock camera, OP6 somehow uses a very bright LED setting, which is higher than e.g. torch mode. However the GCam app a)cannot focus in the dark using flash, and b) the flash is dimmer than stock camera app.

If the flash can be fired at maximum brightness then it may be possible for the app to focus in dark as well, aided by the higher light output.

Thanks,

Hassan.
[Google Camera Mods] ravidevani:
+1 for the flash issue
[Google Camera Mods] exaflare:
I don't think the sensor in OP6 is mediocre, it all boils down to the software (processing algorithm)

Most iphones used smaller sensors 1/3" which is

Much worst than OP6 , the latest IPX sensor has 1.22um pixels size same as in OP6 main sensor.
[Google Camera Mods] yashpatel99:
I don't understand why oneplus is doing this with flashlight. We can't even that as torch when needed due to its low brightness. I was thinking that it was just a poor flashlight while using it as torch. But now realised that OnePlus is reducing its brightness.
[Google Camera Mods] Dark Crow:
One quick thing. After trying out the flash and turning it on because of the talk here the message "5 second burst" has been stuck on my screen. I forced closed it, cleared cache, and reatarted my device. Still nothing, going to delete data now if that somehow doesnt work ill be re installing.

Some other thing too since i actually use 2 ver simultaneously once i turned on the flash on one the same message showed up on the other and it wont go away too.

Edit: Ooookay, i cleared data, turned off and on my phone and uninstalled it.... But its stilll there how the heck is that possible?!?
[Google Camera Mods] Subhojit:
How are the photosphere stitching for you on latest apk on OP and the test build you shared?

It seems pretty bad on mine for both builds. Kindly advise.
[Google Camera Mods] Gibsonflyingv:
To be fair, I've never seen a good picture taken with a mobile device that uses flash.
[Google Camera Mods] voolandis:
Flash is there not to make great pics, but to make text, lines, shapes, signs etc. readable, comprehensible and distinguishable at night.
[Google Camera Mods] Paz9:
which gcam? arnova?
[Google Camera Mods] Vuska:
after reading some comments here.... so none of the Gcam version at page one will work for Potrait mode at the moment ?

if any that work, can tell me which one please ?

Thank you.
[Google Camera Mods] CommanderROR:
What exactly does cstark27 change to make his builds work? They might not be stable, but HDR+ works...

Oh and btw...did Qualcomm ever offer an updated version of their Snapdragon Camera app? It used to be a "thing" a while back, utilizing all those specual image processing skill the Snapdragon SoC has built in. Went prrtty quiet though...
[Google Camera Mods] RazorBlade123:
Deleted
[Google Camera Mods] cstark27:
I tried a Snapdragon Camera APK posted around XDA but it crashed on my OP6. The thread seemed newer but not sure about the camera app version. Maybe it was old.

Dhz.smali and ihk.smali are where the main changes are to get it working. It has to have the support override code from Arnova and then it runs best if the "config" is forced to Nexus 6. But there's 2 places to do this and I haven't really figured out what ihk.smali override is for, because if you set the model in ihk to anything else and Force the config in Dil.smali, it will crash.
[Google Camera Mods] lutyjj:
So here's logs of camera crashing with Nexus 2015 + ZSL + ZSL config and blue tint with ZSL REPROCESSING + ZSL + ZSL:
[Google Camera Mods] Dendis:
I mean the amount of work you and your team does to make it happen is amazing. Keep up the good work!
[Google Camera Mods] @Peterrrrr:
Is the right picture from gcam?

The right picture is a lot more natural if you look at the background, less processed than the left picture.
[Google Camera Mods] CommanderROR:
You mean the sample of the Strawberries? In that case, GCAM Iis in the right.
[Google Camera Mods] eteles:
For scenes with a lot of light, camera is fast to take picture, but if there's not a lot of light (inside a room, for example) it takes a lot of time to take the picture...

(This is on Xiaomi Mi Mix 2S)
[Google Camera Mods] @Peterrrrr:
Is it possible to film in 4K 60fps with gcam? If not is it possible to fix?
[Google Camera Mods] Arnova8G2:
I can add you but need your device can record in 4k60fps
[Google Camera Mods] xterminater07:
So I tested all the version on the front page for my snapdragon 845 s9+, and none of them work. The cstark v3.7 showed live preview for front and rear camera, front camera took pic fine but not hdr+, and rear camera live preview lags horrendously and cannot take pics. Arnova 7.9.7 oneplus6 one force closes no matter what I do. The earlier arnova one froze my phone and it auto restarted.
[Google Camera Mods] @Peterrrrr:
OP6 can record in 60fps 4K :)
[Google Camera Mods] aneesh12:
is it possible to have the stabilization in videos recorded by gcam??i mean, the option is there...but I don't see any difference...
[Google Camera Mods] Arnova8G2:
You can do a test with this version

https://xdaforums.com/showpost.php?p=76720986&postcount=112
[Google Camera Mods] xterminater07:
Thanks... What settings should I have them set to?
[Google Camera Mods] cstark27:
[MENTION=4860033]Arnova8G2[/MENTION] I am attaching some info here in an effort to get some more minds looking at this. I have attached 4 photos, the first is a screenshot of the viewfinder with correct colors, followed by the captured picture (green), then I adjusted the exposure +2.0 and took another picture (pink). Maybe these photos, descriptions, and log will give us a clue.

There's also this in the log: 06-06 15:49:26.555 19766 20308 W libgcam : [shot_helper.cc:383]: WarnIfMapsDiffer: Contents of spatial gain map for subseq. payload frame don't match!

Is this our clue?

Log: https://drive.google.com/file/d/1A_7BMJBsZ38vZILF5myluypP3tsAIzFA/view?usp=drivesdk

Besides that note, I am uploading another version with minimal tweaks. I have set the default frame count to 3 (change to Low if you want the same as before), and I can correct the colors in the viewfinder but the resulting picture will still be wrong.

OnePlus6v0.2_GoogleCamera-Pixel2Mod-Arnova8G2-V7.9.7.apk
[Google Camera Mods] Arnova8G2:
For the green color I can fix it using blackLevelPattern to 16 instead of 64

for spatial gain map Op5t has the same bug when i fix libs for dots.

I will send this version with the fix or if you want to do it

cok.smali

Add oneplus 6 for spatial gain map

.method public static i()Z
.locals 2

sget-object v1, Landroid/os/Build;->DEVICE:Ljava/lang/String;

const-string v0, "OnePlus5T"

invoke-virtual {v1, v0}, Ljava/lang/String;->equals(Ljava/lang/Object;)Z

move-result v1

Add Oneplus 6 for blackLevelPattern to 0

.method public static g()Z
.locals 2

sget-object v1, Landroid/os/Build;->DEVICE:Ljava/lang/String;

const-string v0, "OnePlus5T"

invoke-virtual {v1, v0}, Ljava/lang/String;->equals(Ljava/lang/Object;)Z

move-result v1

if-nez v1, :cond_0

Or Add Oneplus 6 for blackLevelPattern to 16

.method public static e()Z
.locals 2

sget-object v1, Landroid/os/Build;->DEVICE:Ljava/lang/String;

const-string v0, "le_x2"

invoke-virtual {v1, v0}, Ljava/lang/String;->equals(Ljava/lang/Object;)Z

move-result v1

if-nez v1, :cond_0

And remove for blackLevelPattern to 16

[B] sget v9, Lcok;->h:I

if-nez v9, :cond_13[/B]

invoke-static {}, Lcok;->e()Z

move-result v9

if-eqz v9, :cond_13

Edit : [MENTION=2712580]cstark27[/MENTION]
[Google Camera Mods] xterminater07:
Just tried the latest versions and all gave fc. How can I show log without root?
[Google Camera Mods] cstark27:
Thanks [MENTION=4860033]Arnova8G2[/MENTION]. That fixed the spatial map error. I will play around more with the blacklevel settings and the CORRECTION_MODE. The viewfinder colors are having an effect on the color of the final image. So if I use the "fix" from v0.2 then that's when the image is green or pink depending on exposure setting. If I revert that "fix" then the tint is more consistent shot to shot, but still wrong. But maybe that means it can be corrected. I will dig into it more and let you know.

[MENTION=3266378]xterminater07[/MENTION] this thread is mainly for OnePlus 6 but you can use adb to make a logcat on a computer.
[Google Camera Mods] xterminater07:
Thanks cstark. I want to help since I have a snap 845 as well. If it helps, arthur's version worked ony s9+ but it has tinting issue. S9+ is level 3 hardware. I will post log soon
[Google Camera Mods] Dark Crow:
Welp, since there wasnt any feedback here. I had to reset my phone and remove everything before that stupid pop up message disappeared.
[Google Camera Mods] Pat123:
After asking multiple times and receiving no response, you still don't get the hint. Photosphere is not a priority for now and there are much important things to improve / fix first before getting to it.
[Google Camera Mods] itsmohsink:
None at the moment, its in works everyone is waiting for Portrait Mode to work on OP6, fingers crossed!
[Google Camera Mods] :
Could we ever replicate the performance of the Pixel 2 if we don't have the Pixel Visual Core in the OnePlus 6 phones? Because most of the performance relies on that, or am I wrong?
[Google Camera Mods] AcmE85:
The Pixel 2 does not use the Visual Core in Google Camera, it still uses only the SOC's DSP.

The visual core is only used by third-party camera apps (which support it).

As for performance/speed, HDR+ processing FLIES on the OP6.

You won't even see the processing circle if you don't tap on the preview quick enough.

It is too early to compare the mod to the Pixel 2 quality-wise.
[Google Camera Mods] :
Ohhh, my bad then. Thanks for the clarification! :good:
[Google Camera Mods] techthenoob:
Vignette

I had a pixel at one point and this is what made me come over to this. Have to say this is getting closer! It appears you have come along way than even a few months ago when I had first downloaded!

I'm using the oneplus 6, and I have to say this is almost to the point I could see it as my replacement cam! There is just one big thing that happens and I do not know if you have it happen on your end, there is a blue-ish, purple vignette that happens now in every image. It's more noticeable in low light. I've hit the toggles hoping that's what they were for, and it's not addressing it.

Other than that, the process for addressing farther away objects and the sharpening, is something that is 100% on par! So close!
[Google Camera Mods] AcmE85:
Are you using Pixel2Mod or the latest 1.2.2 Test Version?

I never tried Pixel2Mod, but on 1.2.2 I don't see any vignetting.

In terms of Whitebalance and color it is quite close to the stock cam.

Only in lower lighting the photos appear colder compared to stock.
[Google Camera Mods] techthenoob:
Thank you, the vignetting is gone in this version:

" Newest

July 21, 2018

GCam_5.3.015-Pixel3Mod-Arnova8G2-v4Beta4-op6-test-fix-hue.apk

Highlight Saturation : 0.7

Shadow Saturation : 1.7

To remove the light blue tint use exposure 1 or 2 "

UPDATE: I have now felt comfortable enough with those settings to set this as my primary camera. You're right AcmE85, it does run cold in images, however the only thing I do is add warmth to the midtones of an image and boom it's good to go!
[Google Camera Mods] xiplinter:
Try setting Highlight Saturation to 1.0, nice collors here this way
[Google Camera Mods] rienux:
what Gcam works for potrait mode?

i use OP6-1.2.1-GCam_5.3.015-Pixel3Mod-Arnova8G2.apk freeze in potrait mode..

thank you.
[Google Camera Mods] aneesh12:
use latest version. switch to front camera, set the viewfinder because when you switch to portrait mode, viewfinder freezes. after switching to portrait mode, press the shutter button. it will capture what is there on stucked viewfinder.
[Google Camera Mods] dvz91:
I tried this but the picture will fail to load..
[Google Camera Mods] Blue305:
Can someone point me to the latest version? I find it hard to pick the right one from the OP. I'm using the OnePlus 6. Thanks in advance.