yashsingh1/xdaforums huggingface dataset:
[Google Camera Mods] Arnova8G2:
On the Nokia before the update everything works, there is a lot of bug now
[Google Camera Mods] Dendis:
What is your opinion on shooting in complete dark with flashlight? Is everything OK? Are you still gonna do minor adjustments for corrections?

In my case, photos in dark lighting seems to have pinkish tint(like mentioned before) . Selfie photos are rotated.
[Google Camera Mods] defcomg:
Black in shadows is black level being too low .

The camera libs return 63 but in the raw tuning for imx519 the bin file 12bit pedastal correction black value is at 256 meaning it's 64 when HDR+ stacks and upcast data to 14bit 64 becomes 1008 instead of 1024

TL;DR op6 black level needs to be hardcoded to 64
[Google Camera Mods] CommanderROR:
Sorry, question was already answered!
[Google Camera Mods] :
On latest pixel2mod version, focusing is really weird. It really struggles to focus, especially while zoomed in. It will keep going back and forth trying to lock on to focus but can't.

https://drive.google.com/file/d/13dgYzfBabYY0fz9XF7tLBkhtDvFajxaQ/view?usp=drivesdk

[MENTION=4860033]Arnova8G2[/MENTION]
[Google Camera Mods] Arnova8G2:
The version by [MENTION=2712580]cstark27[/MENTION] uses 64,64,2,64.1,64 or SENSOR_BLACK_LEVEL_PATTERN of the device, the version I have posted uses SENSOR_DYNAMIC_BLACK_LEVEL, But make that hue in the shade.

---------- Post added at 09:55 PM ---------- Previous post was at 09:43 PM ----------

It's a bug with Phase Detection
[Google Camera Mods] JesusOmarMJ23:
please activate the 16 MPX in the camera
[Google Camera Mods] cstark27:
[MENTION=4860033]Arnova8G2[/MENTION] please see post #568, that test version you made then, fixed purple tint on 5.1.018 for me. Maybe something got accidentally changed during development.

https://xdaforums.com/showpost.php?p=76946633&postcount=568
[Google Camera Mods] Arnova8G2:
Yes I restore SENSOR_DYNAMIC_BLACK_LEVEL, I will prepare 5.18 and 5.3 by removing SENSOR_DYNAMIC_BLACK_LEVEL
[Google Camera Mods] defcomg:
Kill that dynamic black don't think that has ever worked correctly on any device it has to be exactly 64 if you go higher image starts turning green the only time black level starts to shift is when analog iso value is reached and digital iso is used
[Google Camera Mods] JimRockford:
I can confirm that on both versions (5.1 and 5.3) dark colours / shadows are too black. Significant brighter (and more realistic) on stock at the moment.
[Google Camera Mods] Dendis:
As I am reading this thread, I more and more realize the cooperation and the understanding of things between you guys [MENTION=4860033]Arnova8G2[/MENTION] [MENTION=377973]defcomg[/MENTION] [MENTION=2712580]cstark27[/MENTION] and others. I can't thank you enough for everything you have already done and for things you are doing now.

In you we trust!
[Google Camera Mods] JimRockford:
Can this be solved?

(To all of you developers: great work so far!!)
[Google Camera Mods] v4uluv2004:
Yes me too facing this issue.

It just struggles to focus when there is a light source. For example if I tap on street light it will keep on looking for focus.

Rest everything is working great.
[Google Camera Mods] cstark27:
[MENTION=4860033]Arnova8G2[/MENTION] or [MENTION=377973]defcomg[/MENTION]

Here's some info regarding the hunting focus issue on v5.1.018 Google Camera (GoogleCamera-Pixel2Mod-Arnova8G2-V8.1.apk)

* By default, the focus has to hunt and goes from in and out of focus before finding focus on the subject; ~1-2 seconds

* Disabling camera.enable_micro fixes the focus hunting; focuses roughly in under half a second and doesn't go "past" the subject usually. But the viewfinder freezes shortly after.

* Disabling enable_micro and camera.diet_burst introduces the focus hunt again but the viewfinder no longer freezes but becomes slightly jerky

* Enabling enable_micro and disabling diet_burst doesn't have freezing/jerky viewfinder but focus hunts

* The Nexus 6 config has better focus, but obviously no ZSL

The MGC version posted on the first page has good focus but viewfinder freezes when you set it to HDR+ ZSL (HDR+ Enhanced is forced by default). Hope that info helps.
[Google Camera Mods] Arnova8G2:
[MENTION=2712580]cstark27[/MENTION] , Version with the removal of dynamic black level, replace black level pattern by 64, 64, 64, 64 like [MENTION=377973]defcomg[/MENTION] advisor and some fix for stability.

https://drive.google.com/open?id=1yV3zI2gGxjQs_JYTnES0CyPkEjLSrXo6
[Google Camera Mods] cstark27:
Looks good so far. Matches the output of that old test version. :good:
[Google Camera Mods] DavidDev:
Amazing image quality. Judt wish the autofocus was more reliable. This is beyond alpha version imo. It should be beta.

Really appreciate your hard works. Couldnt ask for more?
[Google Camera Mods] Mord0rr:
thanks to this, maybe today or tomorrow i buy this phone!

Thank you guys in name of the community!!
[Google Camera Mods] v4uluv2004:
Disabling camera.enable_micro indeed giving better focus.

Focus issue still popping up occasionally but it is way better. I am going to keep it disabled for time being. Thanks a lot. :svetius:

And thanks for all the hard work guys I am now starting to love my oneplus 6 even more. No more tint issue and photos coming really natural and vibrant. Low light photos now are way better on gcam compared to stock.
[Google Camera Mods] slasherzx:
Latest version crashes when switching to front cam after 2-3 seconds. Turning back cam feature becomes too grainy when setting to 0. Going back to previous build.
[Google Camera Mods] cstark27:
Your viewfinder doesn't freeze with it disabled?
[Google Camera Mods] :
Not the person you were replying to, but I just disabled camera.enable_micro, and it did seem to improve the focusing a bit, and the viewfinder didn't freeze at all.

Although there's a weird bug with it on or off doesn't matter where a part of the image appears black and white for a moment in the viewfinder. Not fully black and white but kinda, it's very fast and only when moving the phone around quickly.
[Google Camera Mods] kagwind:
With Pixel3Mod (tint removal version), disabling camera.enable_micro does NOT lead to viewfinder freezing, and the focus seems to be better (hope it's not placebo).

Edit: forgot to mention that Pixel2Mod will have freezing viewfinder if camera.enable_micro is disabled.
[Google Camera Mods] -fluffy-:
dont u think they will enable it in new update
[Google Camera Mods] feeliumz:
Not sure if this is really helpful at this stage and please take this with a grain of salt as the results has been varying somewhat. I’ve been jumping between the different ports and this is some tendencies that I’ve noticed:

OnePlus6_cstark27_GCam_5.1.018_24_v3.7 takes a bit brighter images and vignette is less visible. The capture ring is often shown for a longer duration more and often as well. OnePlus6_cstark27_GCam_5.1.018_24_v3.7 generally shoots two images in a row before slowing down. OnePlus6_GoogleCamera-Pixel2Mod-Arnova8G2-V7.9.5 generally takes three and sometimes only stagger in a otherwise fast capture.

When opening the images immediately after taking it, you can see “Processing HDR+” for a while. OnePlus6_GoogleCamera-Pixel2Mod-Arnova8G2-V7.9.5 does not show that.

Both builds won’t take images when the camera is constantly moving or when shooting in bright daylight. However, OnePlus6_cstark27_GCam_5.1.018_24_v3.7 seems to “hold on” to the camera longer after getting stuck. If you try to open the OP6 stock camera app it’ll just show a black image until it finally "let go" of it.

(THANK YOU for your work! I was really disappointed in the OP6 camera but these two builds give me hope.)
[Google Camera Mods] cstark27:
Thanks [MENTION=4860033]Arnova8G2[/MENTION]. Here is a log when set to Nexus_2015. When opening the camera app, it displays like 1 frame then the viewfinder freezes. Same for any other support level besides LIMITED_JPEG. https://drive.google.com/open?id=1GpEjxvezqibZXGbOKgFcTjiaE9H_9piU

I am uploading an updated version of the one you posted above with the fixed Settings, that has HDR+. OnePlus6v0.1_GoogleCamera-Pixel2Mod-Arnova8G2-V7.9.7.
[Google Camera Mods] CommanderROR:
Thanks cstark27

The new version appears to work with HDR+ and the whitebalance seems improved, but not quite fixed. It took several photos without giving ip completely, but after 3 shots it slows down to a crawl and the colours were suddenly off...

Still, any progress is good!

There are two things I wonder about:

1) Is the Camera API and HAL actually OK this time, or did OnePlus mess it up again

2) Why did they step away from Level3 support thwt was there in the 5T...
[Google Camera Mods] Arnova8G2:
I just sent a test version to [MENTION=4487956]S4turno[/MENTION]

With the detection of oneplus 6 before the detection of supported hardware level, but I use Nexus_2015

https://drive.google.com/open?id=1lmOUKffeq9mnr2B4_Z1BnJZze2crtP84

Mod by B.S.G based on Google Camera v4.4.20

Version with selection

- Support level override

- Supported hardware level, back camera

- Supported hardware level, front camera

https://drive.google.com/open?id=0BzS5yycs3wsRb0xwN3JjTFV4TTQ
[Google Camera Mods] CommanderROR:
The first test version doesn't do HDR for me. Haven't tried the BSG one yet...
[Google Camera Mods] Arnova8G2:
The selection the BSG; that works on mi5 is

Support level override - Nexus_2015

Supported hardware level, back camera - Limited

Supported hardware level, front camera - Level_3
[Google Camera Mods] CommanderROR:
No sorry... doesn't work at all. Either no HDR, or the app crashes completely...
[Google Camera Mods] cstark27:
Log attached, set up the same as "working" 5.1.018. Couldn't find a combo that have HDR+. I've wanted to try 4.4 or 3.2 but am not familiar with the code.

Maybe the issues are related to SD845.. I guess LG G7 also has issues. And LG was pretty simple to get GCam working, relative to past OnePlus devices.
[Google Camera Mods] cstark27:
No HDR+. Log attached.
[Google Camera Mods] Arnova8G2:
I will make you a Pixel2Mod version with the selection

- Support level override

- Supported hardware level, back camera

- Supported hardware level, front camera
[Google Camera Mods] Arnova8G2:
So here is the version with the selection

https://drive.google.com/open?id=1ViFNNtvXydYcGNPDzGQAAD1sDKnNaXLG
[Google Camera Mods] cstark27:
Should HW level be Full,Limited,Level 3, Legacy? I'm seeing the same options as support level override (zsl,legacy,limited,zsl reproc,nexus 2015).
[Google Camera Mods] Arnova8G2:
Yes, but I named the use of the function.

OnePlus 6 does not use normal functions

What is normal

Full >zsl or zsl reprocessing

Limited >limited jpeg

Level 3 >zsl or nexus 2015

Legacy >Legacy jpeg
[Google Camera Mods] cstark27:
Thank you for the effort. Unfortunately nothing really changed. Either no HDR+ or a frozen viewfinder when set to the same settings you had a screenshot of.

I'm going to pursue the colors for now. I can get the viewfinder to not change colors after a capture by setting COLOR_CORRECTION_MODE to FAST or HIGH_QUALITY but it doesn't effect the actual picture but hopefully that gives us a hint...
[Google Camera Mods] eteles:
I know this is OP6 thread, but I just wanted to report that Xiaomi Mi Mix 2S has practically the same results with [MENTION=2712580]cstark27[/MENTION] build...

Thanks [MENTION=2712580]cstark27[/MENTION] and [MENTION=4860033]Arnova8G2[/MENTION]! Please keep up the great work!! Gcam rules! Please see if you can develop to mix 2s too...

Thanks in advance!
[Google Camera Mods] cstark27:
Hey thanks for the heads up. That's mildly reassuring that our OP6 issues aren't specific to us.
[Google Camera Mods] satishenl:
Hi Guys,

There is a thread for OP5T that has GCam Working fully. Here is the link to the thread. Can someone with OP6 try this...

https://xdaforums.com/oneplus-5t/themes/tasker-root-fixed-gcam-facing-portrait-t3750867
[Google Camera Mods] EmDoubleyou:
OnePlus 6 camera support full hardware level not level 3. Kindly ignore if already know this.
[Google Camera Mods] lutyjj:
I've tested all combinations of "Support level override" with "Supported hardware level, back camera". All of them doesn't seem to produce HDR+ images, except I've noticed that ZSL Reprocessing + ZSL = blue tinted image (not HDR+ though) and Nexus 2015 + ZSL = Crash, can't connect to the camera. I'll test combinations with front camera a bit later.
[Google Camera Mods] cstark27:
I don't think changing developer settings works in Pixel3Mod (v5.3.015). If you turn on af debug you'll see that the info won't show up. Also if you turn off the enable micro it still shows the toggle on the action bar. At least for me. Let me know.
[Google Camera Mods] kagwind:
You are right. Sorry for the misinformation.
[Google Camera Mods] mf117:
Do I need to root my phone or not?
[Google Camera Mods] :
No
[Google Camera Mods] xgunax:
Getting better than stock! Tested
[Google Camera Mods] gnam:
I'm littel bit confused, for OP6 which is the latest and best version?
[Google Camera Mods] Zurhal:
In my opinion 5.3.0.15 with denoise parameters and boost exposure [emoji14]

Wysłane z mojego 1+6 przy użyciu Tapatalka
[Google Camera Mods] Dark Crow:
After tweaking it the saturation a bit the colors look exactly like tye stock camera.

Amazing! Excellent work everyone Wow. This is really making me feel better getting the OP6 instead of an S9+
[Google Camera Mods] SpectraFun:
Which settings?
[Google Camera Mods] Dark Crow:
Oh just the H saturation and S saturation values nothing special. Though now i changed it a vit more to punch up the colours while keeping it relatively realistic.
[Google Camera Mods] Murdomeek:
would it be possible to not have the "IMG_" in the file name?

Also, bug: after 5-6 quick taps in 'auto camera mode', you cant take any more pics for ~5-6 seconds
[Google Camera Mods] Dendis:
First stock, second gcam.

The stock one is way more realistic with colors.

View attachment 4556135
[Google Camera Mods] cbendan:
I've tested this versión in my OP5T Oreo 8.1 (I'm not sure if it is intended to work in OP5T or only in OP6).

I've found that after taking 2 or 3 pictures with HDR+ on (not enhanced), the viewfinder becomes very laggy. The same with "portrait" mode. Then, if I disable HDR+, the lagginess dissapears.

Thanks.
[Google Camera Mods] kiranbly88:
best Gcam version with settings

[MENTION=2712580]cstark27[/MENTION]

could you please help me know the best GCAM version & also the best settings?

---------- Post added at 10:32 AM ---------- Previous post was at 10:20 AM ----------

[MENTION=4683167]v4uluv2004[/MENTION], bit confused, can you help me to find the best GCAM version & configuration settings ?
[Google Camera Mods] v4uluv2004:
No it doesn't working all great.

---------- Post added at 11:45 AM ---------- Previous post was at 11:33 AM ----------

I am using the last version updated by Arnova8G2 as of now. You can find it on the page 118.

With default settings and have enabled blacklevel fix also enabling nexus 6p model toggle produces overall great picture.

Try that see how it works for you.
[Google Camera Mods] JimRockford:
Even with "Fix blacklevel", shadows remain too black compared to stock camera. Raising exposure to 4 or 5 is no real solution, because then bright areas are too bright (compared to stock). Dynamic range on stock cam seems to be better. Is there any way to fix this??

Tuning highlight saturation to 0.7 and shadow saturation to 1.7 fixes my "too blue sky problem". Colours now seem more realistic and better than stock.
[Google Camera Mods] kiranbly88:
In GoogleCamera-Pixel2Mod-Arnova8G2-V8.1.apk, blacklevel fix is not available & also if we enable nexus 6p model toggle GCAM app will get freezed when we try to capture an image.

I hope you are using the different version.... Can you re-confirm.
[Google Camera Mods] panthimanshu:
Hello everyone. I am really surprised and glad that all are working so hard to bring this awesome application to our device. I installed the 'fixed_purple_tint_GCam_5.3.015-Pixel3Mod-Arnova8G2.apk' on my OnePlus 6 and unfortunately I encountered issues like most of the time the shutter button is disabled and greyed out and sometimes randomly I found it enabled but I noticed camera couldn't manage to focus on the subject at all.

Switching to portrait mode causing app to crash.
[Google Camera Mods] Arnova8G2:
[MENTION=2712580]cstark27[/MENTION], this version, I replace focus distance calibration which is set on APPROXIMATE by Hyperfocal distance, the focus is better, yet to improve.

I name them 1.2.1

1.1 [MENTION=377973]defcomg[/MENTION] fix

1.2 black level fix

1.2.1 Test focus

OP6-1.2.1-GCam_5.3.015-Pixel3Mod-Arnova8G2.apk

Code I wanted to add, but does not work ( FC )

// Infinity Hyperfocal Minimum Camera
// <----------|-----------------------------| |
// [0.0] [0.31] [14.29]
Float minimumfocus = characteristics.get(CameraCharacteristics.LENS_INFO_MINIMUM_FOCUS_DISTANCE);
Float hyperfocal = characteristics.get(CameraCharacteristics.LENS_INFO_HYPERFOCAL_DISTANCE);

if (minimumfocus == null && hyperfocal == null) {
return null;
}

minimumfocus = (minimumfocus == null) ? 0.0f : minimumfocus;
hyperfocal = (hyperfocal == null) ? 0.0f : hyperfocal;

if (minimumfocus > hyperfocal) {
return hyperfocal;
}

return minimumfocus;
[Google Camera Mods] kiranbly88:
[MENTION=3266378]xterminater07[/MENTION], i'm new here in the forum... Could you please guide me the best version of GCAM for 5.1.9 OTA updated OP6 with the best configuration.
[Google Camera Mods] cstark27:
Thank you. It is hard to tell a difference for me - but sometimes Pixel2Mod seems a little better than this test. Will wait for others feedback. :highfive:
[Google Camera Mods] bauwoo:
[MENTION=4860033]Arnova8G2[/MENTION] I'm finding the focus faster. Step in the right direction imo.
[Google Camera Mods] Will008:
Thanks for the great time and effort being put into this.

I have a question, I know the OP6 stock camera colors and true to life and all that which is good except that I've always thought skin colors look very pale in comparison to the Nexus 6P and the pixel. Is there a was we can have a setting that adjusts just that, cause when I increase highlight saturation all colors saturate plus I start to get a slight tint.

It would be like the skin tone settings Google photos has in the colors settings menu.
[Google Camera Mods] x111:
GoogleCamera-Pixel2Mod-Arnova8G2-V8.1.apk

and

fixed_purple_tint_GCam_5.3.015-Pixel3Mod-Arnova8G2.apk

both have very slow autofocus compare to stock oneplus camera.
[Google Camera Mods] txx1219:
[MENTION=4860033]Arnova8G2[/MENTION] Do have try to remove the red part below ?

// Infinity Hyperfocal Minimum Camera
// <----------|-----------------------------| |
// [0.0] [0.31] [14.29]
Float minimumfocus = characteristics.get(CameraCharacteristics.LENS_INFO_MINIMUM_FOCUS_DISTANCE);
Float hyperfocal = characteristics.get(CameraCharacteristics.LENS_INFO_HYPERFOCAL_DISTANCE);

[COLOR="Red"]if (minimumfocus == null && hyperfocal == null) {
return null;
}[/COLOR]

minimumfocus =[COLOR="SeaGreen"] (minimumfocus == null)[/COLOR] ? 0.0f : minimumfocus;
hyperfocal = [COLOR="SeaGreen"](hyperfocal == null)[/COLOR] ? 0.0f : hyperfocal;

if (minimumfocus > hyperfocal) {
return hyperfocal;
}

return minimumfocus;

Because you check after (the green part) if minimumfocus and hyperfocal are null to set a value by default (in this case 0.0f), it should be fine without the red part (which could cause a FC because of the return null and not a number like it could be if it's hyperfocal or minimumfocus.
[Google Camera Mods] Arnova8G2:
Thank's, I had prepared to do this

[COLOR="Red"]if (minimumfocus == null && hyperfocal == null) {
Int calibration = characteristics.get(CameraCharacteristics.LENS_INFO_FOCUS_DISTANCE_CALIBRATION);
}[/COLOR]

to return the original code, but I put null to do the test.

I will redo the test by deleting the code in red
[Google Camera Mods] robertusIT:
which last version you suggest for my OP6?

In first post there are 3 version, so i don't know which must install
[Google Camera Mods] v4uluv2004:
One thing I noticed that stock camera adds quiet a lot noise to the photos after updating to OOS 5.1.9 which makes photos look little washed out once you zoom.

1st stock. 2nd gcam
[Google Camera Mods] Critical Detox:
Good evening everybody,

I must once again address this thread in the short time frame of only 1 week, This is the third time now, And numerous other unseen cleanups, This cannot continue any further.

I strongly urge everybody to remain on topic, Do not continue to derail this thread, Follow the rules, And the wishes to remain on topic via the OP to this very thread.

If you've forgotten the Rules here they are once more.

The constant offtopic leaves this development thread in a mess and dismay and that isn't what XDA is about, With XDA being a development driven forum these threads should be pertaining to said developments and not offtopic nonsense.

There are areas designated for off-topic discussions, please utilize them.

If you see something posted that's against the rules it's better to report it rather then engage it, We will handle it instead.

This will be my Final Notice on the matter as failure to comply from here on out will result in matters being handled on a member to member basis..

Thank you,

Critical Detox
[Google Camera Mods] chakfung2:
Version 5.1.018.177624777.V8

Have been trying out the new version in different environments,

experiencing blue/purple tint at my workplace :(

(I first took a pic with gcam and then took one with the stock camera for comparison.)

Logcat: https://drive.google.com/file/d/1ylaEmPyJBwU4uDJDcEbgMA4boCdvl9tq/view?usp=sharing

Hope this helps:)
[Google Camera Mods] TheAdala:
The photo quality is nice on it but there is an auto focus issue still present, low light shot
[Google Camera Mods] lutyjj:
Is there a chance we could see custom aspect ratios such as 18:9 and 19:9? :)
[Google Camera Mods] Fade2:
I love latest update. The tint is gone but sometimes shutter is not working so I have to switch to video mode and back to make it work again. Am I doing something wrong?
[Google Camera Mods] Born2rein@gmail.com:
Try this as well maybe it would solve ur issue

https://drive.google.com/file/d/1fM_sXJck3bM6iQUdF4SfeYinPGzpWceI/view
[Google Camera Mods] aneesh12:
clear the app cache and data.
[Google Camera Mods] Arnova8G2:
OP6_test_1.2.2_GCam_5.3.015-Pixel3Mod-Arnova8G2.apk [MENTION=2712580]cstark27[/MENTION], test focus

- I restore SENSOR_DYNAMIC_BLACK_LEVEL, Works well for night shots or in the dark if fix blacklevel is enabled.

- Fix shutter button greys out and locks.

- Improvement the focus is faster now, so I restore the original code for zoom. I am looking for a better one, because the code mentioned above does not work.

OP6_test_1.2.2_GCam_5.3.015-Pixel3Mod-Arnova8G2.apk
[Google Camera Mods] tibcsi0407:
Works like charm! :)

Can you please include the setting of HDR+ quality? It would be nice to set it to super high manually if possible. :)
[Google Camera Mods] v4uluv2004:
Take one example if you have a ceiling fan and its running then simply open the gcam n tap on the fan and see if its able to focus. In my case it doesn't and keep on looking for focus. Occasionally it does work but most of the time it doesn't.

---------- Post added at 11:39 AM ---------- Previous post was at 11:25 AM ----------

HDR+ Enhanced already present.
[Google Camera Mods] tibcsi0407:
Yes, but in the old versions, and the version from [MENTION=2712580]cstark27[/MENTION] you are able to set the quality of HDR+ Enhanced.

In lower light situations it can help a lot compared to the lowest settings.
[Google Camera Mods] genevalpha:
issue:

60fps video still not smooth
[Google Camera Mods] lgalkis:
I compared this camera app with the stock oneplus6 ,and with stock app I get better HDR than HDR enhanced mode.
[Google Camera Mods] v4uluv2004:
I mean in arnova's version too HDR+ working.

The one he uploaded a while ago 1.2.2
[Google Camera Mods] tibcsi0407:
I know, I tested all versions actually, but I miss the scaling of the HDR+ enhanced.

When you set it to super high, shooting of the pic takes longer, but you get more details in low light conditions. It is called HDR+ parameters, as you can see it on this picture: