yashsingh1/xdaforums huggingface dataset:
[Huawei P10 Lite Questions & Answers] mrleja:
You can take a look at this:https://xdaforums.com/honor-9/development/tool-flash-official-firmware-recovery-t3769279
[Huawei P10 Lite Questions & Answers] elchino!!!:
Thanks, but I mean install the upgrades via Settings > System Update, that would brick my phone? Thanks again
[Huawei P10 Lite Questions & Answers] pity02:
I know that if you install twrp in recovery1 then you will not get an update.

If you have a root phone, you will not even get it.

If you install twrp in recovery2 and do not root, you will receive the update and the update will overwrite the twrp.
[Huawei P10 Lite Questions & Answers] elchino!!!:
Hello. I downloaded the upgrade and when I tried to install it the TWRP sent an error message (I don't remember which one). Yesterday I was able to install the stock recovery, but I don't know what I did wrong that I had to drain the battery out just to get out from the logo screen before the boot animation, and now I can enter into eRecovery.
[OnePlus 6 Questions & Answers] gtchs:
Anyone getting more missed calls (meaning phone not ringing at all) with the OP6? It's happened to me 5 times that I know of over the last week. It doesn't happen all the time but it even happened once when I was testing from my home phone. Locations are all areas with no problems before. I'm using AT&T through Consumer Cellular.

Thanks!
[OnePlus 6 Questions & Answers] TechOut:
You don't have the alert slider on silent or do not disturb on do you?
[OnePlus 6 Questions & Answers] gtchs:
Thanks. Nope, it's on ring. I'm not even seeing any evidence of phone calls at all. Maybe it's a provider problem but the timing of when I started getting reports and when it did it to me while testing coincides with getting the OP6.
[OnePlus 6 Questions & Answers] TechOut:
If the call isn't even coming in at all I don't think it's a OnePlus setting I would check and see if they need to do anything with the phone on consumer Cellulars side
[OnePlus 6 Questions & Answers] hhhanxf:
I am having same issue. On T-Mobile.
[OnePlus 6 Questions & Answers] mikex8593:
I had that issue just 30 minutes ago on T-Mobile. Alert slider was on vibrate but no missed call. Just a notification for voicemail.
[OnePlus 6 Questions & Answers] ram4ufriends:
I know this is 6 months old thread, but is there any fix. I am facing issue on OnePlus 6T as well...

Did you find any fix?

Did you find any fix?
[OnePlus 6 Questions & Answers] Cimmmi:
I have the same problem. I have 2 SIM from T-Mobile. Bouth are new. One is ok, second one have this problem. Doesn't matter on how or with slot I use...
[OnePlus 6 Questions & Answers] Anilkumarsingh:
I am also facing the same kind of issues, but I think this is happening because of poor network connectivity.
[OnePlus 6 Questions & Answers] mikex8593:
Not since then, and can't remember how it was resolved.
[Lenovo P2 Questions & Answers] legiontao:
Please help me, facebook crashes on stock rom randomly... I've even flashed stock rom again with all wipes, but same, 251 version nougat, I don't wanna customs, tried few, I want working 1 key too
[OnePlus 6 Questions & Answers] TechOut:
What setting do you guys prefer? Notch or notch hidden? I have mine full screen with notch it doesn't bother me and I think it looks pretty nice
[OnePlus 6 Questions & Answers] :
Full screen with notch shown. Hidden just looks ugly imo
[OnePlus 6 Questions & Answers] TechOut:
Ya I think it looks better with the notch as well I don't mind it without tho it still looks clean
[OnePlus 6 Questions & Answers] iElvis:
Hiding the notch borks some things like Android Auto. I got used to it very quickly and prefer the full screen.
[OnePlus 6 Questions & Answers] Eric214:
I have it full screen as well. Also I use Nova launcher and I use the gesture swipe up to toggle/hide the status bar. That also hides the notch on the fly but also hide all the status bar info unless you pull down. Just thought that was an interesting way to hide show the notch on the fly.
[OnePlus 6 Questions & Answers] jimmydee62:
I also have full screen with notch. I thought it would bother me but it doesn't.
[OnePlus 6 Questions & Answers] rickysidhu_:
With notch, like most others, it didn't bother me as much as I thought it would and actually looks nicer than the entire top blacked out.
[OnePlus 6 Questions & Answers] Messinger:
Some of us OnePlus 6 users, who connect to infotainment systems, for Android Auto, have discovered we don't have a choice. If the notch is hidden, the car's touch screen doesn't respond. The image displayed might not even fit.

It's great to have a choice. But, without an update from OnePlus, some of us are finding there's no option.

Before my own hand was forced, I hadn't made up my mind as to which I preferred.

And Nova Launcher provides some extraordinarily useful settings, for making the most of a navigation-button-free landscape, on this device's screen.
[OnePlus 6 Questions & Answers] Vinegar Joe:
Can't believe I'm the only one so far hiding the notch! Not that I hate it or anything, I just think it looks better hidden. It helps balance it with the chin.
[OnePlus 6 Questions & Answers] gino79:
I've been switching back and forth...kinda like them both actually...but I mostly leave the notch
[OnePlus 6 Questions & Answers] vigilante7373:
Hello, guys!

What does everyone mean by hiding the notch? Just making it black or disabling the notch area completely? Is there any ROM with the ability to turn off the notch area and move notifications beneath the notch so that I could have just a normal status bar with a long row of icons?
[OnePlus 6 Questions & Answers] Sepero:
By default, "hiding" the notch, simply turns it to black background. That never made sense to me, so I just left it as is. I'm also interested in an option the move the status bar below the notch, so I can see more notifications.
[OnePlus 6 Questions & Answers] hinix:
Black status bar in my op6 - so ntoch hidden. Not bother me at all and there is enough space for icons, and more space on display itself.

OnePlus 6 @ Tapatalk
[OnePlus 6 Questions & Answers] paumlhp:
I'd also like this option.
[OnePlus 6 Questions & Answers] crixley:
I really don't mind the notch at all. If anything I wish most apps would allow me to fill it totally when in immersive mode instead of blacking it out. Many apps don't use the space.
[Nexus 5 Developer Discussion [Developers Only]] ThePiGuy:
Hi Guys,

As you may notice from my signature, I'm actually an LG G4 owner (attempting :)) to assist with the development of Oreo roms for the G4. [MENTION=5461026]kessaras[/MENTION] and [MENTION=5545101]steadfasterX[/MENTION] have done a magnificent job so far and we have two bugs left - the torch tile in quick settings doesn't work (not a big deal right now, we just recommend an app as a workaround) and also we have robotic bt calling with a hands free set.

I have been browsing the hammerhead forums and noticed that this exact problem is also plaguing the Nexus 5 (and we share the same broadcom 4339 bt/wifi chipset, so I would imagine this is why we suffer from the same issue), and I was wondering whether it would be a good idea to share any ideas here as to how we could fix it - we have tweaked a lot of bluetooth settings so far but it has either made no difference or killed the bluetooth entirely.

[MENTION=4473900]amaces[/MENTION] I noticed you mentioned in your Unlegacy Android thread that you got it to work in a hardcoded and messy way - would it be possible for you to share it? I know you said it wasn't good for a production build, but if we could see how you got it working then it would definitely help us to find a proper fix.

Thanks for any help
[Nexus 5 Developer Discussion [Developers Only]] oguz6578:
I have that same problem. (android 8.1 or 9.0)

Nexus 5 D820
[Nexus 5 Developer Discussion [Developers Only]] Sashko98:
The issue is probably caused by the HIDLization and the introduction of eSCO command set. Prior to Oreo vendor specific commands(VSCs) were sent to the controller which would trigger I2S/PCM sco configuration.

When the HIDLization started the VSC for the sco configuration was removed 796523d and later on with the introduction of eSCO command setup these calls to the broadcom's libbt-vendor(pre-SCO setup) were completely removed a9152a2.

I tried retrieving retrieving these calls removed by eSCO(3/5), yet I cant get it working.

Here's what I've done so far:

system/bt stack

fb1d404

47f50f8-a2df04b

hardware/interfaces

dd21c98

The issue is either the way I attempt to send the VSC via send_command method, or in some of the methods which are supposed to notify the AG that the pre-sco is done.

So far I noticed that the code of bta_ag_ci_sco_open_continue method is never reached, but things could've went south even before this method, I dunno.

Looking at the snoop log nothing is even sent to the controller about this.

[MENTION=5545101]steadfasterX[/MENTION] [MENTION=8699949]ThePiGuy[/MENTION] if you guys are still interested in fixing this issue, you should really focus on retrieving these calls imho.
[Nexus 5 Developer Discussion [Developers Only]] Sashko98:
Would be good if anyone tries this c0d86fb. What I am trying is basically to avoid the need of hw_set_audio_state() call from bt stack to configurare SCO over PCM.

Should be accompanied by this commit in order to work.
[MENTION=4473900]amaces[/MENTION] [MENTION=614507]razorloves[/MENTION]
[Nexus 5 Developer Discussion [Developers Only]] Sashko98:
If i understand correctly this is just a warning that the hci module doesn't recognize the command, which I believe is normal since the call is not made from the bt stack( which is not quite needed at this point anyway).

What is curious to me is why are the VSCs even required. I mean I tried to replicate the exact clock/codec etc.. configuration as it would've been configured if the VSCs were send, in the vnd config and there was no change at all. Probably there is something in the hcd patch about this, which would explain why my attempt in the post above works for Galaxy Note 3 and doesn't work for us.(if i am right than your hack could be considered just as extended of the hcd patch.)

Broadcom's libbt-vendor is pretty much obsolete, thus it will be easier to maintain this hack in further OS versions. Changes to bt-stack to get this work would be just too much time consuming to maintain considering that the guys from Google working on the AOSP want as less VSCs as possible.

Read this https://source.android.com/devices/bluetooth just to see how the Bluetooth works,if you plan to retrieve the VSCs to bt stack.
[Nexus 5 Developer Discussion [Developers Only]] z3DD3r:
This is partly true. This warning means that HCI received event for command which was not sent from bt stack. Some commands are send directly from the VendorInterface class and should be handle only here.

It is not enough to just setup the vnd config. U still need to call hw_sco_i2spcm_config or hw_set_SCO_codec. But as i described above these methods fails.

You are right! This issue can be fixed new firmware or additional firmware prepatch. But we will never receive such update) I did one experiment. Your fixes + custom firmware for our chip downloaded from here = working bt calls :D But this way is more crazy that my current hack)))

Looks like we don't need to change anything in bt stack. Seems i have found the real issue. Look at VendorInterface::HandleEvent method. Seems that this is an entry point for all events sent from controller. This method uses the internal_command to determine how the received event should be handled. internal_command is populated inside of transmit_cb which is called from the libbt-vendor. So, what happens if someone will send 2 commands one after another? First command will be recorded into the internal_command var and the second command will be recorded to internal_command var. Second command will overwrite the infrormation about first. And since the communication is made via UART, controller will sent us response for first command (which is already gone) and then response for second command. Thats why nothing works! Thats why i saw that strange lines in logcat!!!

All that means that your fix should work. U just need to improve it a bit:

1. android_hardware_interfaces. Move lib_interface_->op(BT_VND_OP_SCO_CFG, nullptr); right after the lib_interface_->op(BT_VND_OP_LPM_SET_MODE, &mode);

2. c0d86f. Call the hw_set_SCO_codec for PCM instead of hw_sco_i2spcm_config

I have not tried it myself yet. But logs and logic seems correct. Bt calls issue may be not fixed cos of initialization sequence, but all callbacks should be called correctly.

---------- Post added at 08:47 AM ---------- Previous post was at 08:37 AM ----------

Hmm, seems that based on my finding i can improve my initial solution. At least i can made controllable configuration of the SCO with all required callbacks! Will try it today...
[Nexus 5 Developer Discussion [Developers Only]] Sashko98:
The VendorInterface still comunicates with the bt stack via the hci_layer.

In ideal case the hcd patch wouldn't need VSCs for such configuration, because It would've already been configured(what you tried with the custom patch just proves it). Appereantly Xperia Z3(shinano) is using its own solution by configuring the controller using bt drivers link. Perhaps this is why it is the only device I know of with BCM4339 Wifi/bt chip which didn't have any issues with bt-sco. Their code compiles perfectly with our kernel, but there are many init changes needed to happen to make it work.

If there is any race happening I think it should be handled by the VendorInterface, thought looking at the VendorInterface::HandleIncomingEvent method in vendor_interface.cc it is already handling such cases.

On Nougat the I2S/PCM interface was configured only when sco connection was established, if you look at the first eSCO commit you'll see that the initial idea was to keep the pre-SCO vendor setup link, thus I I used to be focused pretty much on bringing this back, till I understood there is no point, as it would require changes not only to the bt stack, but to Bluetooth app aswell.

As I said its just consumes too much time, not only to do it successfully, but to maintain it.

hw_set_SCO_codec is useless at this point, as everything goes back to hw_sco_i2spcm_config to configure sample rate for the required codec. The clock rate is the same regardless of the codec.

On my local builds I moved lib_interface_->op(BT_VND_OP_SCO_CFG, nullptr); to the end of the method. Just for the tests once I put it even in VendorInterface;;Open, doesn't really matter where it is as long as it is called. The problem is that the callback methods arent reached. I tried sending BT_VND_OP_SET_AUDIO_STATE opcode command to start the whole sequene, but it doesnt get past the first send VSC(HCI_VSC_ENABLE_WBS) I believe it was, exactly due to the cbacks.
[Nexus 5 Developer Discussion [Developers Only]] Sashko98:
Its probably because you sent the VSCs directly from libbt-vendor, rather than sending an opcode command from VendorInterface, which then sends VSCs, and thus the VendorInterface considers the last internal opcode(BT_VND_OP_LPM_SET_MODE in this case) saved, as the next opcode commands which are being received.

If these logs bug you so much, just edit small part of the bt_vendor_brcm.c and include named by you opcode command which points to the hw_config_continue method, then call it from the VendorInterface.

If you do this then you should partially revert your commit, and set the firmware configuration as it was before, but then again it doesn't matter where the I2S/PCM interface is configured, what matters most is that it is configured.
[Nexus 5 Developer Discussion [Developers Only]] z3DD3r:
Seems that we a talking about different things. It really doesn't matter where the I2S/PCM interface is configured. It matters when!

Good news!

I've managed to improve initial solution!

Commit:

78d62ad58da101371822cee107f7759841d2744b

Changes:

No more memory leaks.

No more uncontrolled commands to bt chip. Each sent command receives callback and handles it appropriately.

Ability to configure codec configuration through the vnd config. We can use only i2spcm or wbs+i2spcm.

[MENTION=614507]razorloves[/MENTION], what do you think about it?

I can share a test build if anyone is interested.
[Nexus 5 Developer Discussion [Developers Only]] M Asad Khilji:
Thank you very much Man [MENTION=7268092]z3DD3r[/MENTION]

You Rock :fingers-crossed: :highfive: :D
[Nexus 5 Developer Discussion [Developers Only]] steadfasterX:
I will try to adapt this to the LG g4 and if that works I will kiss your feet , really .. It tried since months to get that working (we have the same chipset) and tested almost everything I could think of .. But you're way ahead of me.. Thanks for taking the time to explain everything and ofc for the fix ;)
[Nexus 5 Developer Discussion [Developers Only]] z3DD3r:
Hi [MENTION=5545101]steadfasterX[/MENTION],

This should work for all devices with broadcom bluetooth chip. At least i don't see any reasons not to work... Just get the latest code of the libbt and configure your vnd config.

I think i should rebase libbt to have only one commit with actual description...

---------- Post added at 08:17 PM ---------- Previous post was at 08:17 PM ----------

Hi [MENTION=5545101]steadfasterX[/MENTION],

This should work for all devices with broadcom bluetooth chip. At least i don't see any reasons not to work... Just get the latest code of the libbt and configure your vnd config.

I think i should rebase libbt to have only one commit with actual description...
[Nexus 5 Developer Discussion [Developers Only]] steadfasterX:
Yea I strongly believe it will work especially as we have the exact same chip model.

Would be nice if you rebase but if not then not .. I can test it tomorrow first so .. ;)

Thanks again you have no idea how long the ppl are waiting for such a fix..
[Nexus 5 Developer Discussion [Developers Only]] z3DD3r:
[MENTION=5545101]steadfasterX[/MENTION], [MENTION=614507]razorloves[/MENTION]

Rebased:

broadcom libbt

hammerhead device tree
[Nexus 5 Developer Discussion [Developers Only]] steadfasterX:
you are incredible [MENTION=7268092]z3DD3r[/MENTION] , [MENTION=7412373]Sashko98[/MENTION] .. it really works.. I mean.. over 1 year no one was able to solve that f*** ! You're the saviour .. :highfive:

where the hell is your f*** donation addr [MENTION=7268092]z3DD3r[/MENTION] ??? :laugh: I am serious about that q :cool:

I recognized one little thing: one letter is not coming through in both directions: Z (german spoken like "zwei") or the C like in "niCe" or "intelligenCe". Its like it gets lost. I have tested with WBS active atm and will do some further tests with maybe clock rate etc. Just wanted to let you know. its still an awesome thing and when you speak out the character very loud it comes through btw.

UPDATE:

ok with or without preferred WBS makes no diff on that lost char issue

UPDATE2:

Log with WBS pref to FALSE (issue still there): https://paste.omnirom.org/view/28af9d55

(stopping audio server, starting it, incoming call, accept call, while talking log is silent)

.. and to clarify its hard to track that "lost char" issue. I am testing with 2 headsets, 1 connected to my main phone (OP6T) and the other to my G4. I mute always one of the both and then talking :) the little delay in transmitting the voice allows to hear that issue when you know it. so the impact of that here is not big I think but if you have any idea what to try let me know.

.-
[Nexus 5 Developer Discussion [Developers Only]] Sashko98:
This is unnecessary if you want to send HCI_VSC_ENABLE_WBS just route through it. We set the codecs manually anyway.

#if (BTHW_FW_EXTENDED_CONFIGURATION_ONLY_I2SPCM_CONFIG == FALSE)
hw_config_extended_set_SCO_codec(BTHW_FW_EXTENDED_CONFIGURATION_SCO_CODEC);
#else
hw_config_extended_sco_i2spcm_config(BTHW_FW_EXTENDED_CONFIGURATION_SCO_CODEC);
#endif // (BTHW_FW_EXTENDED_CONFIGURATION_ONLY_I2SPCM_CONFIG)

This could be re-worked

#if (BTHW_FW_EXTENDED_CONFIGURATION == FALSE)
static void hw_config_extended_start(void)
{
if (bt_vendor_cbacks)
{
bt_vendor_cbacks->fwcfg_cb(BT_VND_OP_RESULT_SUCCESS);
}
}
#else
static void hw_config_extended_finish(uint8_t result)
..........................

into

case HW_CFG_SET_BD_ADDR:
ALOGI("vendor lib fwcfg completed");
bt_vendor_cbacks->dealloc(p_buf);
#if (BTHW_FW_EXTENDED_CONFIGURATION == TRUE)
hw_config_extended_start();
#else
bt_vendor_cbacks->fwcfg_cb(BT_VND_OP_RESULT_SUCCESS);
#endif

Also since you figured out the callbacks, consider using your idea on the existing methods. No need for all this re-definitions.

The changes in the device tree are unnecessary

BTM_WBS_INCLUDED was removed since Oreo

BTIF_HF_WBS_PREFERRED was removed later on on Pie

Try setting the BTHW_FW_EXTENDED_CONFIGURATION_SCO_CODEC as SCO_CODEC_MSBC, if that doesn't work maybe try this 540b42c
[Nexus 5 Developer Discussion [Developers Only]] steadfasterX:
thx dude..

already tried that - no change

I also tried setting the SCO rate to force 8K - no change

I will test that commit asap

[MENTION=7412373]Sashko98[/MENTION] ok I tried that commit and this resulted in outgoing = distorted sound, incoming = silence

log: https://paste.omnirom.org/view/c7134f75

.-
[Nexus 5 Developer Discussion [Developers Only]] Sashko98:
Send your local vnd config just in case, perhaps there is something in there which effects everything. Other possibility is the mixer_paths or the audio_platform_info.

I see that you get good logs from the ACDB loader. if Nougat or stock rom didn't have such issue establish sco connection and look for line similar to this

D ACDB-LOADER: ACDB -> send_voice_cal, acdb_rx = 22, acdb_tx = 21,

acdb_rx = SND_DEVICE_OUT_BT_SCO <acdb_id>

acdb_tx = SND_DEVICE_IN_BT_SCO_MIC <acdb_id>

Perhaps something in the acdb mapping has changed. Check if on Nougat/stock rom different acdbs are being used for receiving and transmitting, and if by any change different acdbs are used, map them via the audio_platform_info
[Nexus 5 Developer Discussion [Developers Only]] z3DD3r:
Awesome news! Thanks for testing!!!

Thanks, but i will not accept donations. The main goal was to fix that damn issue and get official LOS support. I'm very excited that this solution works on hammerhead and other devices. That's all what i need :)

Unfortunately i don't have any ideas right now. Maybe the reason is in your device firmware, maybe in codecs, maybe in changes in bluetooth stack in 8.1/9.0 and eSCO/WBS or maybe it even not related to bt stack...

Did not quite understand you.

Agree. It will be more clear.

Thanks! Completely forgot about it. These changes are left after my tests :)

BTIF_HF_WBS_PREFERRED

is still used in Pie by in btif_hf.cc. But it FALSE by default.

Will remove this change cos it not required for hammerhead.

I'm already thinking about it. But in my opinion redefinitions have some advantages:

Does not depend on the original code. We can easily add any required changes to this solution without fear of breaking anything in the original code. Also lll possible future changes for original code could be also easily merged without conflicts.

Almost no changes in the original code. If we will decide to move forward with changes for existing methods then we should to take into many other things. We should handle

SCO_CFG_INCLUDED

cos it disables required methods. We should change the

hw_sco_config

cos we only need to configure all SCO related structs without calling the

hw_sco_i2spcm_config & bt_vendor_cbacks->scocfg_cb(BT_VND_OP_RESULT_SUCCESS)

. We should #ifdef a lot of places where original code calls callbacks or rewrite methods to accept callbacks as arguments. Quite a lot of changes...

Easy to read and understand without a ton of #ifdefs and code branching