yashsingh1/xdaforums huggingface dataset:
[Magisk] Estebanium:
Hi Didgeridoohan, since you updated the module in device simulation and the kick in stage at boot, I am experiencing soft reboots at my device. It lools like the UI reboots, not the phone itself. I have to enter my security pin like I rebooted my phone. I know that a log would be much better, but does a log survive a reboot or a soft reboot? I use Matlog by the way, maybe I can help?

So my general experience on this is the following: I used device simulation on LOS 15.1 and 16 with no problems until now. The fingerprint and the simulation acts like a 8.0.0 Samsung device. On 15.1 this was never be a problem on 16 not a problem, too. For now.

If I can move any files around, activate/disable some triggers feel free to write me. I have a very consistent error environment,but for now I needed to disable the module.
[Magisk] allrockedout:
04-05-2019
[Magisk] allrockedout:
I got it to pass by changing the boot stage to post. Under script settings.
[Magisk] paktepu:
My Redmi Note 4x Mido, not working with Magisk v19 & Busybox v1.30.1 and Magisk Hide Props Config v3.50

its says busybox not installed.

Now im back to magisk v18.1 and Busybox v1.29.3 to pass cts
[Magisk] hyborian:
My two note 4x nikel are fine with same BusyBox, magisk canary 19, latest props.
[Magisk] Kapiljhajhria:
[MENTION=4667597]Didgeridoohan[/MENTION] #redminote7 #lavender fingerprints. my mother owns it and its bl is locked but i can still give fingeprint and other details which should be able to help others. its android pie and miui 10

https://del.dog/unipecisum
[Magisk] AGBOHOU:
Hello; please detail me step by step the maneuver to do; I am a beginner and forgive my ignorance. Thanks in advance.

---------- Post added at 09:33 PM ---------- Previous post was at 08:55 PM ----------

I found it alone; Thanks anyway.
[Magisk] hyborian:
Thanks for that, I am waiting for Note 7/Pro to hit our shores so I can replace my Note 4x mtk.
[Magisk] Didgeridoohan:
Probably related to an issue with setting props in the module default boot stage that I introduced with my "optimisations" in v3.5.0. I finally found the flaw in my logic a few minutes ago and just need a bit of further testing before a (hopefully) fixed release is out.

But... Do you actually need device simulation? It's not needed for passing SafetyNet.

Without logs there's absolutely nothing I can do...

That's the true community spirit! Thank you!
[Magisk] paktepu:
Without logs there's absolutely nothing I can do...

Here my logs..

In terminal everything work normally, i can choose my fingerprint for mido. But when i check safetynet, cts failed.

Thanks for new module, but still didnt work here.

Edit :

Im back to 3.0.3 its work again
[Magisk] bitye:
I face the same many times... Miui is a nightmare. Magisk 19 not working if any module active in 9.4.1. now I was able to fix everything with 18.1 but my FP always switch back to original not the applied stable. 303_48 works fine
[Magisk] Angyone1:
Can you add mi note 3 fix for MIUI beta ? It's possible ? I tried to fix but nothing happened... I installed also BusyBox and then I installed emulated terminal and add superuser permission with magisk and then I write su>props>1>f>18 (Xiaomi devices) and mi note 3 was not present... So I chose Mi 6 model but not working because in magisk when I check, results again false (red).... Sorry my bad English, I hope you understand and help me. Thanks.

P.s.

I used 3.0.1 version with same method and now working ! Ctsprofile is true green ! Thanks again!
[Magisk] martyfender:
I don't think you should be hiding all of these, especially the snet one?
[Magisk] bitye:
I just tested a lot and it seems 3.0.3 v48 works perfectly with any magisk on my POCO also with MIUI 9.4.1. Problem starts when I am on MIUI 9.4.1 with magisk 19 and v3.5.0 v49. additional information I am on FrancoKernel r22.

V3.5 worked on earlier MIUI with magisk 19

V3.5 works with Magisk18.1 on Miui 9.4.1 but not set the FP (or set back to original?)

V3.0.3 works fine with Magisk 19 on MIUI 9.4.1

I don't know where is the problem 3/4 of this bundle boots when all the 4 on latest bootloop comes.
[Magisk] Didgeridoohan:
There are a couple of bugs introduced in v3.5.0 that I believe I have fixed, especially the part about fingerprint not setting properly (easily fixed by changing the boot stage setting to post-fs-data). Before release I have to find time to do a few more tests though, but it should be done this week.

Bootloops are harder to know if I've fixed or not, since so far no-one have provided any logs that show why the loop occurs (and I cannot replicate on any of my devices). A logcat boot script toghether with the latest Canary debug build (currently 19001) Magisk log would be optimal.
[Magisk] carlos974:
For me too the fingerprint does not apply with v3.5.0 :(

With v3.0.3 works very well ! ;)

(I use Magisk Manager 7.1.1 and Magisk 19.0)

Device samsung SM-J500FN (j5nlte)

Thanks to [MENTION=4667597]Didgeridoohan[/MENTION] for your great job :good:
[Magisk] Didgeridoohan:
Yes, that's been mentioned a few times now... Temporary solution in the post before yours.
[Magisk] carlos974:
This value (red):

# Edits prop values if set for post-fs-data

echo -e "\n--------------------" >> $LOGFILE 2>&1

log_handler "Editing prop values in post-fs-data mode."

if [ "$OPTIONBOOT" == 1 ]; then
[Magisk] Didgeridoohan:
Are you asking if you need to edit the code? No...

There are two easy solutions to get the props to set properly:

Stay on v3.0.3.

Use v3.5.0, but run the props command, go to "Script settings" and change the boot stage to post-fs-data (or late_start service).
[Magisk] paktepu:
Thanks for your reply

Magisk 19 make my mido reboot sometimes, im back to magisk 18.1. Everything work normally.
[Magisk] carlos974:
Sorry ! Please excuse me...:angel:

Thanks again
[Magisk] Didgeridoohan:
Update to v3.5.1-v50

I managed to replicate and fix the issue where props wouldn't set in certain circumstances. My logic was, let's say, flawed... :laugh: If you've changed the boot stage to post-fs-data, it might be a good idea to move it back to system.prop. But, generally there shouldn't be any issues...

A while ago [MENTION=6948826]Nebrassy[/MENTION] contacted me with some info regarding an issue where setting the security patch date too early would lead to a bootloop on devices with Keymaster 4. The patch date is now set in late_start service mode, so that should not be an issue any longer for those affected. Thank's again [MENTION=6948826]Nebrassy[/MENTION], and thank you for the reminder.

Also a couple of fingerprints added/updated. Thank you to [MENTION=4048340]Kapiljhajhria[/MENTION] and [MENTION=7713764]IkerST[/MENTION].

Let's hope I didn't break something else this time around. But, even if I did, it would have to wait for the next release. I'm gonna start on the update for the new module template ASAP (which, with my current IRL status, likely means sometime next fall :D).

Changelog

v3.5.1

Fix a few bugs causing props not setting properly at boot in some cases when using the system.prop boot stage.

Moved ro.build.version.security_patch to late_start service by default, so as not to cause issues for devices with Keymaster 4 (possible source of bootloops). Thank you [MENTION=6948826]Nebrassy[/MENTION].

Added an option to change security patch date boot stage under "Edit device fingerprint" boot stages.

Added a new fingerprint for the Xiaomi Redmi Note7 and an updated one for Motorola Moto G6 Play. Fingerprints list updated to v50.
[Magisk] hyborian:
Thanks. Tried 3.5.1 on one phone, both safety net fail, and props not found when typed in terminal. Reverted back to 3.5 and all good.

Will try to get logs later, maybe others have the same problem.

.
[Magisk] Nebrassy:
Thanks, this reminds me, forgot to update fingerprint for Mi A2

xiaomi/jasmine/jasmine_sprout:9/PKQ1.180904.001/V10.0.7.0.PDIMIXM:user/release-keys

2019-03-05
[Magisk] ipdev:
For the next round of fingerprint updates. :silly:

- Attached

April Pixel(s) and Essential PH-1 Fingerprints.

OnePlus 5T Beta 27 (March)

Samsung Tab S3 (LTE SM-T825)(8.0.0)

Xiaomi Mi Note 3 (8.1.0)

I did not have time to check PlayStore Certification but, all pass SafetyNet.

Cheers. :D

PS.

I haven't had time to update and test much this past week.

If it helps at all, two days ago, I updated my OP 5T to v3.5.

Using the new propsconf_conf file seemed to work fine for me.

So far, everything seems to be working running v3.5.1 and magisk canary-debug. :fingers-crossed:
[Magisk] hyborian:
Ok, tried to update to 3.5.1 on 3 phones, 1 was ok, 2 were not where both safety net fails, and props cannot run in terminal. Toggling Magisk Hide doesn't fix it. Reverting back to 3.5 fixes it.

The good phone had no custom props, while the other 2 have. Good phone is on pie, others are marshmallow. Hope the logs help.
[Magisk] hyborian:
Ok, updated to 3.5.1 on 3 phones, 1 was good, 2 not good. The other 2 falls both safety nets, and props does not work in terminal. Toggling Magisk hide does not work. Reverting back to 3 5 fixes it.

Good phone is on pie and has no custom props, other 2 are on marshmallow and have custom props. Hope the logs help.
[Magisk] Didgeridoohan:
Things look pretty good in those logs, meaning installation worked and the boot scripts are running as they should. The issue seems to be that Magisk isn't mounting the module (or possibly any module) properly, meaning the system.prop file won't load and the props script isn't mounted... So, I would have to see the Magisk log as well for any clues as to what's going on.

Edit: Wait a minute... Scratch that. All those logs are from v3.5.0, not v3.5.1. I would have to see the v3.5.1 logs to say anything.
[Magisk] hyborian:
Ok, but I got those logs right after installing 3.5.1. Maybe it didn't install at all ? (I installed from Magisk Download). I will try again and get the Magisk log (Canary release).

Other modules mount well.

p.s. I just tried it again, it did install, it says 3.5.1 under Modules. Now getting the logs.
[Magisk] Didgeridoohan:
Save the installation log from the Manager as well, please.
[Magisk] hyborian:
Here they are attached, after reinstalling 3.5.1. those propsconf still show 3.5 in the header. On the good phone, header shows 3.5.1

Magiskhide is shown in Modules as 3.5.1
[Magisk] hyborian:
See screenshots. When I install 3.5.1 through magisk on the other 2, it doesn't do any magisk stuff. The other screenshot is when I install 3.5, it shows more lines.

Tried flashing through TWRP, didn't help.

.
[Magisk] Didgeridoohan:
Yes that's what I was suspecting, that the installation isn't working properly. I need to see that module installation log (the "Save log" button seen in your screenshot).
[Magisk] hyborian:
Well, let's say I erase the Manager Magisk log first. Then I install 3.5.1 in Manager. Log is empty.

The Magisk logs (saved from Manager and the one in /cache) after I reboot (after updating to 3.5.1) are the ones I attached in my earlier post.

---------- Post added at 10:39 AM ---------- Previous post was at 10:29 AM ----------

Darn, after several installing,reinstalling, erasing Magisk log, it suddenly went through the last install attempt. Crazy.

Now going to the other phone to try. The only thing I did was clearing Magisk logs.

---------- Post added at 10:51 AM ---------- Previous post was at 10:39 AM ----------

Ok, went to other phone, currently reverted back to 3.5

Now I remember what I did earlier. I cleared Magisk log, updated through Download module of Magisk, failed (few lines shown). I went back and updated it again a 2nd time out of frustration, and it went through with more lines shown as expected.

Rebooted, went to Magisk and terminal to test, all ok.

Thanks anyway, must be one of those quirks hard to debug. Anyway, learned something in case it happens again.
[Magisk] zynonimoux:
Good job sir ..:good:
[Magisk] Didgeridoohan:
[MENTION=8671532]hyborian[/MENTION] I think you misunderstood me about the log I wanted... Right after you have installed a module you can save a log (just press the "Save log" button and it will end up in /Downloads) with further details about what happened during installation. It's got nothing to do with the ordinary Magisk log.

If you wouldn't mind, it would be very good if you could try to reproduce this again. Install v3.5.0, set eveerything up and then try to update to v3.5.1. If things go wrong like they did previously, the module installation log might show the debugging info we need. It's good you got things working, but there is a possibility that this issue you experienced is a symptom of a Magisk bug, and since you're running the Canary builds it would be very helpful if we could figure that out.
[Magisk] hyborian:
Ok, will try

---------- Post added at 02:12 PM ---------- Previous post was at 01:57 PM ----------

I am sorry, [MENTION=4667597]Didgeridoohan[/MENTION], I cannot replicate it anymore on both phones. It goes through now without any problem. Missed the opportunity to catch it, I didn't realize SAVE button is a save for a log as I never used it before.

If it happens next time, will know what to do, thanks.
[Magisk] Dante Enoshima:
[MENTION=4667597]Didgeridoohan[/MENTION] Here's the Samsung Galaxy A6+ fingerprint ( Pie, Security Patch date : 1 March 2019 )

samsung/a6pltedx/a6plte:9/PPR1.180610.011/A605GDXU3BSC6:user/release-keys
[Magisk] Estebanium:
I read a lot of MicroG and i would like to try it out as an alternative to OpenGApps. There is always written, that my ROM needs signature spoofing. I don't think that my LineageOS build has it. So is this done by MagiskHide?
[Magisk] Didgeridoohan:
It's not...

But, you've ended up in quite the wrong thread. This has nothing to do with MicroG or signature spoofing. The closest you would get here in the Magisk forums is [MENTION=4187311]Setialpha[/MENTION]'s NanoDroid, I guess...
[Magisk] Estebanium:
I know that this thread has nothing to do with MicroG, maybe my post was a bit misleading. Thank you for the link. That helps!
[Magisk] finoa:
This modules does do anything

i just added it to latest magisk and still have cts false.

i want like universal fix module - install without bloatware and reading docs which is a lot blah blah without straightforward solution

Reading docs I felt like talking to Google support useless, pointless waste of time
[Magisk] bitye:
[MENTION=4667597]Didgeridoohan[/MENTION]

Poco F1 (9)=Xiaomi/beryllium/beryllium:9/PKQ1.180729.001/V10.3.4.0.PEJMIXM:user/release-keys__2019-03-01 # # Xiaomi Poco F1 - v10.3.4.0 ro.bootimage.build.fingerprint=Xiaomi/beryllium/beryllium:9/PKQ1.180729.001/V10.3.4.0.PEJMIXM:user/release-keys ro.build.version.security_patch=2019-03-01 ro.product.model=POCO F1 ro.product.brand=Xiaomi ro.product.name=beryllium ro.product.device=beryllium

Thanks to [MENTION=7280276]ipdev[/MENTION]
[Magisk] jenslody:
Universal safetynet messed with Magisk internals and partly broke it.

And about MagiskHidePropsConfig: where do you get bloatware in this (extremly flexible) module ?

If you don't want to read docs, you should not root your device, but stay on stock-rom.
[Magisk] Didgeridoohan:
Update to v3.5.2/v4.0.0-v51

Got the module updated to the new template, and thought that it would be fitting to do a major version bump at the same time. Also releasing v3.5.2 at the same time, with one last fix for Magisk releases prior to v19.0.

Also got the fingerprints list updated with all those new and updated prints. Thank you [MENTION=6948826]Nebrassy[/MENTION], [MENTION=7280276]ipdev[/MENTION], [MENTION=7390731]Dante Enoshima[/MENTION] and [MENTION=3157580]bitye[/MENTION] for helping keeping the module alive.

List will update when running the props command, by using the -f option (run props with option -h for details) if you've disabled automatic updates, or from the "Edit device fingerprint" menu.

Changelog

v4.0.0

Updated to the new module template. Otherwise the same as v3.5.2, apart from some code cleanup.

Due to some of the code cleanup and the new template, this release is only compatible with Magisk v19+. Users not updating to Magisk v19+ can use module v3.5.2.

New (Samsung Galaxy A6 Plus and Tab S3, Xiaomi Mi Note 3) and updated (Essential PH-1, Google Pixel and Pixel XL 1-3 and Pixel C, OnePlus 5T and Xiaomi Mi A2 and Pocophone F1) fingerprints added. List at v51.

v3.5.2

Fixed a bug where automatic update of the applied fingerprint during installation would cause the installation to fail.
[Magisk] nicegamer7:
Just updated to v4.0.0, and for some reason it breaks the QuickSwitch module for me? Are there any logs I can provide to help you out? I'm on Magisk 19 and have osm0sis' busybox.

Edit: To clarify what breaks means, the QuickSwitch app no longer appears and the launcher's (Lawnchair v2 in this case) recents no longer work. If I go to recents the launcher crashes, but with your module disabled everything begins working.
[Magisk] TheAngryGuitarist:
A weird bug happens for me right now. I'm using Bootleggers Rom Pie on my Galaxy J5nlte. I've got an annoying bootloop after I've set the fingerprint for my device and activated device simulation. It worked on the previous version when I was using Magisk 18.1, but now, the module updated and I can't using it anymore on Magisk 18. In Magisk 19, device is continuosly bootlooping. Any fix?

Logs:

Magisk: https://drive.google.com/open?id=1986gz9CLpoXUyGnNZmKRj7V9ylohbx1S

Propsconf_install: https://drive.google.com/open?id=1jAHtnkoheU2NBJPz6BLpK1AcR-7Fn2KA

Propsconf: https://drive.google.com/open?id=1GJNC_qhFI2gh5TsAdqtlEZWCJ0NOs5B5
[Magisk] Didgeridoohan:
There's a crash in the Magisk log, but no info about why... Everything about the module looks like it has loaded just as it should and there shouldn't be any difference between how v4.0.0 handle the boot scripts compared to v3.5.1.

Things to try:

Install the v19 Canary debug build and save the Magisk log again. It might show more detailed info about what's happening.

Disable device simulation. It's not necessary for passing SafetyNet and could potentially cause issues (although it sounds like it worked previously, meaning it shouldn't matter now).
[Magisk] kimux:
Great work!

In fact, I had never successfully passed SafetyNet on havoc before version 4.0.0.

Now it's finally passed.

Thank you very much, dear friend!

My ROM is Havoc-OS-v2.4-20190404-dumpling-Office

Magisk 19
[Magisk] ipdev:
So far the only oddity I've noticed, is a discrepancy in the security date.

Not exactly sure when it started, Magisk 19 or MagiskHide Props Config v3.5.0? First noticed it a few nights ago when I was testing new/updated fingerprints.

After you set a new fingerprint and corresponding security date. SafetyNet will pass and PlayStore is certified.

No Device simulation. I did not have the time to try testing using device simulation yet. Should have time this weekend. ;)

If you check Android version under setting, it will show the security patch date of the system build. Not the corresponding date to the fingerprint used.

Settings -> About phone -> Android version

Apps like DevCheck PlayStore-Link and Device Info HW PlayStore-Link also show the security patch date of the build.

An older app, CPU-Z PlayStore-Link , shows the security date set by MagiskHide Props Config.

Odd quirk, or something that might become a problem ? :confused:

Note:

Tested using multiple fingerprints/security dates on:

- Pocophone F1 (LineageOS 16 Nightly)

- OnePlus 5T (March AOSP GSI)

:cowboy:
[Magisk] Didgeridoohan:
I've noted the same some time ago, but haven't really had the time (or bothered to) look into it further. The security patch date prop is only used to pass SafetyNet, and as long as Google is only using that it's no worries. I have wondered where they check for the actual date though...
[Magisk] ipdev:
Sorry I missed your post about it.

I did a quick search last night.

Swing and a Miss.

Confused me also. I debated about posting my comment/question here or in xda-Link

That's when I noticed it showed the same under Settings. :confused:

Tomorrow is a new day. :)

Five minutes and a few hours for some sleep. ;)
[Magisk] Didgeridoohan:
No worries. I don't think I've ever posted about it actually...

If you do get an opportunity to look into it, please report back with any findings.
[Magisk] TheAngryGuitarist:
Deactivating device simulation did the trick! Thank you!
[Magisk] dimon222:
Fails to update to latest version. Says "need magisk 19+". I'm already on magisk 19.0 right now. Mate 20 Pro / emui 9

Is it anything to do with my Huawei's installation of magisk to recovery_ramdisk partition?
[Magisk] Didgeridoohan:
Interesting... What happens if you run this command in terminal (that's a capital V):

magisk -V
[Magisk] dimon222:
I guess it's not available through alias. Says next:

:/data/data/com.termux/files/home # magisk -V
/system/bin/sh: magisk: not found

Magisk manager shows installed 19.0, even if I refresh status
[Magisk] Didgeridoohan:
Don't use Termux... Try a regular terminal emulator instead.

Edit: with Termux you could try just calling the binary though the absolute path:

/data/adb/magisk/magisk
[Magisk] dimon222:
Regular terminal emulator works, gave this:

:/ $ magisk -V
19000
[Magisk] Didgeridoohan:
In that case I'm stumped at the moment. I'll investigate more when I get an opportunity.
[Magisk] Didgeridoohan:
Actually, you could help with one more thing. If you could post the propsconf_install.log file that you'll find in /cache, that would be great.
[Magisk] dimon222:
Reports older version somehow

:/cache # cat propsconf_install.log ***************************************************
********* MagiskHide Props Config v4.0.0 ******** ***************** By Didgeridoohan ***************
***************************************************
2019-04-06 09:09:33:685393729 - Starting module installation script
2019-04-06 09:09:33:687741645 - ! Magisk version not supported!
2019-04-06 09:09:33:690223416 - Magisk build 18100.

Where does it get version from? :eek:

Is it cached from previous version of props module somehow? I'm for sure doing upgrade, not fresh install right now.
[Magisk] Didgeridoohan:
Interesting. It's grabbing the version code from Magisk's internal variables. That is supposed to show the currently installed version... I'll check with [MENTION=4470081]topjohnwu[/MENTION] what's up.
[Magisk] bitye:
I just updated 3.0.3 to 4.0 with new Fingerprint on Poco and it works as a charm. No problems everything perfect. Of course as it was update phone show March as security date as the fingerprint's not the real April. It still unclear for me that after a clean flash it show the real security date after module update show fingerprint's but don't care it working on latest MIUI 9.4.1 and also tested on latest LOS
[Magisk] Didgeridoohan:
Ok, so this is caused by a broken installation. How did you update from v18.1 to v19?

Try reinstalling Magisk from within the Manager.
[Magisk] dimon222:
You're right. I just tried direct reinstall of magisk from magisk manager and upgrade worked without issues then.

My previous upgrade from 18.1 to 19.0 I did through manual patching original recovery_ramdisk with new version of magisk and then dirty flashing it in fastboot same as 18.1.

I guess my main mistake was doing dirty flash, prolly fastboot flash is behaving different from built-in upgrade
[Magisk] Didgeridoohan:
Yup, that was the issue. Whenever possible, it's always best to let the Manager do the update. That way everything will be taken care of as it should.

Glad we got things sorted out. :highfive:
[Magisk] bitye:
Yes yes I knows about what not clear why it always OK after clean install of module but show the Fingerprint's after a disable / enable. Of course I don't care at all :)
[Magisk] iPusak Gaoq™:
not sure why but i notice something odds regarding devices fingerprints after updating this module..my phone is bacon and i'm using Google Pixel (9) as my devices fingerprints and after updating the module, the fingerprints changes automatically to Google Pixel (8.1.0)...i have to set the fingerprints again afterwards...this happen twice now on latest module and previous version...