yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
Interesting. That's the first time I've heard of that... I wonder if it would be true for other device/system combinations as well. Thanks for reporting.

Would you mind pulling the module logs (option 7 in the main menu) and posting them? It'd be interesting to see if the files included give any hint.
[Magisk] starcms:
With matching months (CTSprofile passing) or mismatching months (CTSprofile failing)?

---------- Post added at 10:23 ---------- Previous post was at 10:13 ----------

Also, just curious if you know why, I noticed that after changing the fingerprint and rebooting, I get a notification that says something to the effect of Finishing upgrading Pie that lasts for about 15 seconds with a progress bar (it's the exact same notification as when you upgrade from one month to the next and boot the very first time). Any idea what the system is actually doing during that time?
[Magisk] Didgeridoohan:
With passing CTS would be fine.

I don't actually know, but that's likely just Android registering your new fingerprint. It happens whenever you change it.
[Magisk] arealcoolhand:
Using the module for the same reason as starcms and can confirm same issue of CTS fail using September Pixel 2 XL key on October security update. Glad he realized what was causing it as I hadn't even considered it was the module since it was working fine before the October update.
[Magisk] bunklung:
Running 17.1 Magisk on Pixel 2 Oct Patch and Google Pay failed me this morning.

Would this mod work around this?

Anyone had luck with the October Update? Do I need 17.2 beta?

Thanks.
[Magisk] Didgeridoohan:
Do you mean that before the October update it didn't matter what fingerprint you where using, but now you need to use one with the October build id/version?

Does your device fail the CTS profile check? If so, the module might help.

If you can't pass by using the Pixel 2 fingerprint that is included in the module, could you give this one a go and see if it makes a difference:

google/walleye/walleye:9/PPR2.181005.003/4984323:user/release-keys
[Magisk] starcms:
I'm 99.9999% sure he meant before October, the September update worked with the September fingerprint in the module.

Because when I first installed September, and b4 the fingerprints in the module were updated to September, I had the same issue with September build. It's nothing new in the October build.

I'll get those logs for you in just a lil bit.

---------- Post added at 06:43 ---------- Previous post was at 06:38 ----------

You shouldn't even need this module. If you have a Pixel 2 running the official October ROM, you already have the newest, official fingerprint from Google. And with Magisk you should be passing SafetyNet just fine. I forgot what was changed in Magisk 17.2, but I would try that. Because this module isn't going to help you at all. With Magisk hide enabled in Magisk, you should pass SafetyNet and Google pay should work. Plus you have the official fingerprint already. Do you have Magisk hide enabled?

Using this module with the included Pixel 2 fingerprint is guaranteed to break SafetyNet and Google pay on the Pixel 2.

This module is made for those running custom ROMs (and in my case to trick Google into thinking my Essential is a Pixel 2 so that the newest version of ARCore will work).
[Magisk] starcms:
[MENTION=4667597]Didgeridoohan[/MENTION]

The issue (fingerprint having to be from the same month of the system to pass CTSprofile) MAY be something new in Pie. Because I just started using the module a little over a month ago when ARCore 1.5 came out (previous versions just dumped a bunch of config files in /data/data for each supported device and you simply had to rename one to match your device to get it to work.

I say this because in the first official, non-beta build of Pie for the Essential which came out in August, they accidentally forgot to update build.prop to show the Security Patch date as August 5, 2018 and accidental left it saying July 5 like the last beta release of Pie. I thought I would just go into build.prop and correct it myself and even that TINY change (changing the date of the Security Patch) made me fail CTSprofile which I couldn't believe.

Therefore, possibly if you were running October, but changed build.prop to have a security patch date of September 5, then the September fingerprint would pass CTSprofile. Just a thought. And if true, maybe a feature to add to the module -- change security patch date to match month of fingerprint when changing fingerprint.
[Magisk] Didgeridoohan:
[MENTION=2557531]starcms[/MENTION] Yes, that's something I've been planning to ask you to test (and a few other props, but I'll wait with those until you have an opportunity to upload the module logs). If you get an opportunity to test, it would be interesting to know if it has any impact. You can use the custom props function of the module to set the patch date.

Edit: Never mind... I managed to test it myself on my old Nexus 6 and a Pie ROM. It's all about the patch date...
[Magisk] awl14:
Hello [MENTION=4667597]Didgeridoohan[/MENTION],

no worries, no software bugs can ever be as important as a babies' sleep - and as getting enough of your own sleep as well once the baby is sleeping... ;)

Good news: I can now confirm that the "su detection" issue is fully fixed! Thanks a million! :good:

No need to hurry at all, but indeed, unfortunately, while moving forward configuring "my" Magisk properties as needed, I ran into another small issue with an endless loop:

Here is the "sh -x" log of entering the endless loop after choosing "4" (Add/edit custom props) from main menu, then "n" (create new prop), then enter a property name (here: "testprop") and then try to go back to the menu by entering "b" instead of entering a property value:

(...)
+ echo 'MagiskHide Props Config v2.4.3'
MagiskHide Props Config v2.4.3
+ echo 'by Didgeridoohan @ XDA Developers'
by Didgeridoohan @ XDA Developers
+ echo

+ echo '====================================='
=====================================
+ echo -e ' testprop'
testprop
+ echo '====================================='
=====================================
+ echo

+ echo 'Enter the value to set'
Enter the value to set
+ echo 'testprop to,'
testprop to,
+ echo 'or select from the options below.'
or select from the options below.
+ echo

+ '[' ']'
+ echo 'This prop currently doesn'\''t exist on your system.'
This prop currently doesn't exist on your system.
+ echo

+ echo 'b - Go back.'
b - Go back.
+ echo

+ echo -n 'Enter '\''e'\'' to exit: '
Enter 'e' to exit: + read -r INPUT4
+ INPUT3=
+ break
+ break
+ true
+ '[' -z n ']'
+ true
+ '[' -z n ']'
+ true
+ '[' -z n ']'
+ true
+ '[' -z n ']'
+ true
+ '[' -z n ']'
(...)

I think the issue is that in between line 1152 and 1153 of the "props" script (line numbers of v2.4.3) you need to add

INPUT2=""

to avoid the endless loop, because otherwise TEST2 still seems to equal "n" (from selecting to add a new custom property and things end up in an endless loop...

Many thanks anyway for your great Magisk module - it enables me to execute any apps requiring Safety.Net on my China phone very easily which would have been impossible or at least a real pain otherwise... :) :good:

Hope this helps & best regards

awl14

---------- Post added at 12:40 AM ---------- Previous post was at 12:25 AM ----------

... and, while at it, another - completely cosmetical - improvement that could be done at line 11 (otherwise the error message is written to stderr when the current user has no root privileges):

# Check for access to the Magisk internals. No access = no root
ls /data/adb >/dev/null 2>&1

Thanks for listening!

awl14
[Magisk] jenslody:
I pass safetynet on pie with september or october security patch (don't know at the moment, because I only use it for testing, ril still not working) on my J5FN with the latest official fingerprint from MarshMallow.
[Magisk] Didgeridoohan:
[MENTION=6823720]awl14[/MENTION] Thank you. Both of those are on the to do list. Have another couple of bugs I want to squash as well, so I'll probably try to get some time to fix 'em all in the next couple of weeks (if school and the little one are kind to me).

It seems like this is only valid for Pie fingerprints (don't know if it also matters if it's done on a Pie ROM or not).

I tested a couple of the Pixel fingerprints and the Oneplus 6 fingerprint I have in the module (all Android 9). Whenever ro.build.version.security_patch doesn't match the fingerprint, cts fails.

Using an Oreo or Marshmallow (or other versions, I assume) fingerprint the security patch doesn't matter.
[Magisk] jenslody:
I tested it on Oreo with pie fingerprint and sn passes.

I also tried it with definitely wrong sec-patch date of november and it passes.

But after changing all back to normal (MM fingerprint and original sec-patch date of october) my lockscreen pin was broken.

Not incorrect, but a null-pointer exception in system-ui. I had to delete my locksettings.db from TWRP to reset it. Users on devices without custom-recovery might need to do a factory-reset.

I will test on pie soon and see if the lockscreen stuff is reproducible (on Oreo and Pie).
[Magisk] jenslody:
With Bootleggers Pie (october sec-patcgh) and Pixel 2 XL Pie fingerprint from september I still pass safetynet (even with november sec-patch date).

But I have the same issue when changing the props back: lockscreen is broken.

Some users had issues with the lockscreen when updating Magisk (or at least related to Magisk) if I remember correctly, if they are similar, this might be a way to reproduce it and (if possible) find a workaround for that issue.
[Magisk] Didgeridoohan:
Interesting... So it's not consistent across devices. This merits some more investigation, and it might definitely be worth to keep looking at that lockscreen issue.
[Magisk] kryshnakishore:
Loosing root after a while & I have to reboot to gain root again

On,

V17.2,Stock Android Pie+OP6

Haven't Greenified

Not Optimised for battery

No BusyBox installed

Anyone who have solved this out? even facing the same issue on my OnePlus One, android 8.1
[Magisk] Soumy1234:
Hello!

I'm trying to change "ro.config.calibration_cad" in build prop to "system/etc/calibration_cad.xml". I put it in the customs props section of the module, but in order to use it, it says that I need to reboot, even if I rebooted. Can anyone help please?
[Magisk] Didgeridoohan:
That could be a bug I have on my to-do list. Could you provide the module logs so I can check? Option 7 in the main menu.
[Magisk] Soumy1234:
Sure. Does it automatically send it to you?
[Magisk] NOS_bzone:
Hi, maybe you can create Mi 8 Explorer Edition in the list... Thank you
[Magisk] Didgeridoohan:
Nope, you'll have to upload the resulting file yourself, but that's all explained when using the log collecting option...

https://github.com/Magisk-Modules-R...ter/README.md#please-add-support-for-device-x
[Magisk] Soumy1234:
Oh, I misunderstood. Here it is
[Magisk] NOS_bzone:
Hi dev, sorry i want to ask how to revert back to original fingerprint value? (Because no option on terminal), thank youu
[Magisk] Didgeridoohan:
When running the props script, under the Fingerprint option (1 in the main menu) there should be an option to reset the fingerprint.
[Magisk] hmathur:
Hats off to Didgeridoohan & MagiskHide Props Config.

Redmi 3s Prime Rooted

OS stock rom miui 10 global 8.10.11. beta.

Magisk 17.1 MagiskHide Props Config v2.4.3

by Didgeridoohan @ XDA Developers

Certified Fingerprint :-:good::good: Xiaomi/land/land:6.0.1/MMB29M/V9.5.1.0.MALMIFA:user/release-keys

Passed Safety Net.

Basic Integrity :"True"

Cts profile: "True"

Google Play Protection : "Device is Certified"
[Magisk] Xplorer4x4:
I installed this on a Moto G6 plus through Magisk Manager and rebooted. WiFi would no longer work.I'd toggle it on only to see it toggle itself off after a few seconds. It broke the fingerprint scanner as well,at least for navigation. Shortly after boot the phone suddenly said shutting down and rebooted. On rebooting I was greeted with stock recovery. I choose to try again,and it seems like it tried to boot slot-b instead of a giving me the generic black android boot animation. Phone reboots itself after a minute or so and then boots los16 on slot a. WiFi still broken and phone reboots again after a minute or so.
[Magisk] jenslody:
Did you already set the module up ?

Did you try to disable the moduke in the Manager ?
[Magisk] Didgeridoohan:
The only thing that I can think of that the module does that could possibly have anything to do with this, is the mounting of the props script to /system/bin or /system/xbin (determined during installation). In which case it's not a module specific thing but rather a Magisk-device thing.

You could try mounting the Magisk image in TWRP (@osm0sis SUmount script is good for this) and change the folder name to the one it isn't set to at the moment (change to bin if it's xbin and vice verca). You'll find it under /magisk/MagiskHidePropsConf/system/.

And if you haven't already, try disabling the module and see if that fixes things (as has been mentioned already).
[Magisk] Xplorer4x4:
Hey guys I jumped to conclusions on this. It was late and I was tired. I had tried to troubleshoot the issue and was certain I narrowed it down to this module. I need to investigate further but it might be the new Viper 2.6 module. Either way I guess I didn't trouble shoot it enough so my apologies!
[Magisk] Tr4sHCr4fT:
will this help for Zenfone2 users, by spoofing other deivice? ZF2 lost CTS
[Magisk] Didgeridoohan:
Possibly... Give it a try and let us know.
[Magisk] Didgeridoohan:
Hi there.

I finally had a moment over to take a quick look at this. It looks like that prop simply is set later during the boot process, so setting it in post-fs-data might be too early. Looking at the log you see that it doesn't even exist yet in post-fs-data:

02-14-1970 02:27:50 - Changing/writing ro.config.calibration_cad.
resetprop: prop [ro.config.calibration_cad] does not exist
resetprop: New prop [ro.config.calibration_cad]
resetprop: setprop [ro.config.calibration_cad]: [system/etc/calibration_cad.xml] by modifing prop data structure

Try changing either the global script setting for the boot stage, or for the specific prop to late_start service.
[Magisk] anishmworld:
The issue I'm having is this:

Just after boot, SafetyNet passes. But after a while, it starts to fail. I am attaching magisk logs from when it was passing and after it started failing. I didn't notice anything different in the logs. If you can point out if there's something wrong, it will be a lot of help.

I am using LineageOS 15.1 on Redmi Note 4 (mido). Magisk 17.2. I had the same problem on 17.1, too.
[Magisk] Didgeridoohan:
That is unlikely to have anything to do with this module, but rather sounds like something is killing of the daemon, something loads that Magisk can't hide, or something similar.

In other words you're a bit off topic... Head on over to the general support thread instead.

I have not checked your logs (doesn't seem like xda has indexed them yet), so I can't say much about that. Just make sure you're on the Canary build when reporting about issues, or the log will likely be useless.
[Magisk] fink.nottle:
I can confirm that the fingerprint needs to be consistent with the patch date. The module doesn't have the most recent fingerprint. For an AOSP build for pixel, this is what I had to change for the October patch level:

Orig fingerprint: Android/aosp_sailfish/sailfish:9/PPR2.181005.003/2018.10.12.23:user/release-keys

Modified: google/sailfish/sailfish:9/PPR2.181005.003/4984323:user/release-keys
[Magisk] Didgeridoohan:
Once I get a window of time, I'll work on the next release that will work around the need for the ROM to have a matching patch date to the fingerprint.
[Magisk] .\\D-ZFR:
Looking for Pixel 3 fingerprint, if there any. I can wait ?
[Magisk] Didgeridoohan:
Update to v2.5.0-v31

The major update point for this release is the fix for Android Pie fingerprints. It turns out that they often have to match the device's Android security patch date, meaning you can't use any fingerprint on any device. The workaround for this is to let the module also change the security patch date to one that matches the fingerprint when an Android Pie fingerprint is used. Shouldn't have any side effects since it's just the prop with the date that is changed, nothing else, but please report if you experience any issues.

As a nice bonus this meant I could also go back and re-test a couple of Android Pie fingerprints that had previously been submitted but I did not include since they did not pass (because of a mismatch with the patch date).

Edit 2018-10-22: After some investigation it might be that the need to match security patch date comes from Google's restriction of using Gapps on uncertified ROMs. I'm currently investigating, but it's definitely not a Pie only occurance.

Changelog

v2.5.0

Improved/fixed the SafetyNet fix when using Android Pie fingerprints.

Updated/changed Busybox logic.

It is sometimes an appropriate response to reality to go insane.

Added and updated fingerprints for Essential PH-1, Google Pixel and Pixel XL (all three variants) and Nokia 7 Plus. Fingerprints list v31.

Various bugfixes and improvements.
[Magisk] fabiodifa:
I am trying to use Havoc Pie Rom on my LeecoLePro3 (X720) but I have ctsProfile issue. So I tried to make my own file (with another X720 with a PIE Rom, without ctsProfile issue): I used Termux and the command getprop ro.build.fingerprint, but I can't undertsand where is located the file generated...Can someone help me?
[Magisk] jcmm11:
Hmm if the command you're using is

getprop ro.build.fingerprint

and that's it then there is no file generated. It simply displays the result to the terminal. If you want to place the result into a file you need

getprop ro.build.fingerprint > {full path to file you want generated}

or, alternately,

getprop ro.build.fingerprint | tee {full path to file you want generated}

The second version (with tee) will generate the file and also show the output to the terminal.
[Magisk] fabiodifa:
So I have simply to modify the ro.build.fingerprint value with the result of the terminal?
[Magisk] jcmm11:
If I understand you correctly then yes. Modify the "bad" fingerprint with the one that works. Only caveat, apparently, is to make sure both devices are on the same security date update.
[Magisk] fabiodifa:
Now it works: you are great!!!!!
[Magisk] Didgeridoohan:
From what I can tell (haven't done much testing), the security patch date only matters if you're using an Android Pie fingerprint. Using an Oreo or a Nougat fingerprint on a Pie ROM shouldn't be an issue.

Hi there. Saw that you got things working with the help of the ever helpful [MENTION=4487388]jcmm11[/MENTION].

If you got things working, would you mind sharing that fingerprint? I could add it to the module list of certified fingerprints for others to use.
[Magisk] fabiodifa:
This is the fingerprint for LeecoLePro3 (X720):

LeEco/ZL1_NA/le_zl1:6.0.1/WEXNAOP5802101261S/letv01261206:user/release-keys

Thanks again!
[Magisk] Didgeridoohan:
Fingerprints list updated to v32

A quick update to the fingerprints list before it's time for bed.

Added LeEco Le Pro3 to the list, thank you [MENTION=8233174]fabiodifa[/MENTION].

The fingerprints list will update when you run the props script. Or you can do it manually with the -f option (use -h for details) or from the Fingerprints menu in the props script if you've disabled automatic updates.
[Magisk] xpdragon:
fingerprint for Huawei Mate 10 (8.0.0)

HUAWEI/ALP-L29/HWALP:8.0.0/HUAWEIALP-L29S/143(C636):user/release-keys
[Magisk] paolocorpo:
I can confirm that the fingerprint present into the list for Xiaomi Mi A1 8.0.0 is running well with 8.1.0 too

xiaomi/tissot/tissot_sprout:8.0.0/OPR1.170623.026/V.9.5.10.0.ODHMIFA:user/release-keys

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] gfaf:
Fingerprint for LeEco Le Max 2 (X820) please....

Android 6.0.1 28s

Thanks a lot!
[Magisk] gfaf:
I cannot understand what can I do with this link. There is no fingerprint for my device LeEco Le Max 2 (X820).

Please advice.

Thank you very much.
[Magisk] Didgeridoohan:
That is the link to the instructions for how you can provide the fingerprint. I do not have time to go hunting for fingerprints...
[Magisk] runekock:
You need to find it yourself from a stock rom. Alternatively use a fingerprint from another phone.
[Magisk] gfaf:
I hope someone else is more helpful. I am looking for a fingerprint for LeEco Le Max 2 (X820)
[Magisk] Didgeridoohan:
We know you are... And the documentation I linked you is fairly detailed on how you can go about finding one.

Is it such a bad thing having to do some work for yourself?
[Magisk] gfaf:
Why are you buying a mobile phone that somone else constructed it? It would be better construct it yourself....

Are you using a custom rom that someone else developed?

I am asking for help in a support forum...

I have already tried one from a stock rom and most of what is described as a solution in this link...
[Magisk] TeutonJon78:
Axon 7 A2017U B20 Oreo official release (pulled from build.prop and matches the updater-script)

ZTE/P996A01_O/ailsa_ii:8.0.0/OPR1.170623.032/20180815.171922:user/release-keys

ro.build.version.security_patch=2018-07-01
[Magisk] Didgeridoohan:
Oops! You had better duck after that comment... :laugh: It's xda-

developers

, not xda-

tech-support

. :p

I've actually given you quite a lot of help and support by writing and providing the instructions for how you can learn how to do something for yourself. It's not hard, just a bit time consuming.

I help whenever I can, but I do prefer to help you help yourself. Remember that you are not entiteled to anything here... We are all volunteers, doing this because we think it's fun. If you happen to get something useful out of that, be happy. If you don't, just accept it.

Good luck.
[Magisk] jenslody:
You don't understand how open-source and community projects work, nor do you read instructions and you are offending without need.
[Magisk] gfaf:
I have seen a lot of replies to a same question like mine that the answer is a valid fingerprint.

I cannot understand why this does not happen in this case !

I did not want to offend anyone. I was aking for help !!! I have already tried most of the solutions described in the link..

Big mistake for me ....
[Magisk] Didgeridoohan:
If you've been trying different things and still can't get things working, you should have started with that. Describe what you've tried and what the results have been, include logs if possible. If you do that, instead of coming in here demanding stuff you might get some help.
[Magisk] gfaf:
I was persuaded to stop asking for help...

I let you work.

Thanks a lot again !!!
[Magisk] JoroBo:
From the perspective of a user and not a developer, I admire what developers have to put up with here on XDA and understand why some just give up...Big thank you for this module [MENTION=4667597]Didgeridoohan[/MENTION]
[Magisk] martyfender:
I don't know if this is useful to you or anyone with an x86 device, but here is the fingerprint for my Nextbook Ares 8A, x86, Android 6.0.1 tablets:

NextBook/NX16A8116K/NX16A8116K:6.0.1/MMB29M/V4.0.3:user/release-keys

Please let me know if this passes, or not.

Thanks