yashsingh1/xdaforums huggingface dataset:
[Magisk] martyfender:
I may try that but I just bought it Sunday, temp rooted with mtk-su a pulled the boot. Img with dd. I then patched that with Magisk Canary. I would have thought that would be pretty clean.

I do however know things can go wrong. I didn't use the stable because this fixed the additional setup fail error I was experiencing. That may have been a manager only fix.
[Magisk] FluffyDiscord:
Can this module help restore widevine l1 after bootloader unlocking l1 certified device?
[Magisk] martyfender:
I finally reinstalled Magisk by opening MM, click the uninstall completely button. I reflashed the Magisk patched boot.img again. Wow! what a journey! I installed MM and did the additional setup required and it rebooted. On reboot the screen would not rotate to my default landscape mode. I had the auto rotate setting on. I installed the busybox NDK module and rebooted and the screen rotated as usual. The device repeatedly froze, trying to give root prompts for my apply on boot apps, Kernel Aduitor, Lspeed and Apps2SD. Some were denied and I had to go in to the superuser section and toggle them.

After all of this things seemed normal again until I installed your module. It was then that I rebooted to the Apps2SD dialog that the 2nd partition could not be mounted. I will attach both magisk.logs when I go from this Linux desktop back to my tablet, as I hate typing on it.

It looks like I get the same result in the logs:
[Magisk] jhonmarkgomez:
Version 20 will this work? [emoji848]
[Magisk] martyfender:
The only way to know is for to try it. This is especially true without specifics.
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] I don't know... It doesn't seem to be module specific, since it's manifested without this module, with it, with the logcat boot script, etc.

And talking about the logcat script, did you happen to save the output of that? That's the log that might actually show what's going on.
[Magisk] Didgeridoohan:
No.

There's nothing specifically about Magisk v20 that's incompatible with this module, apart from that I now don't recommend using the "Improved hiding" feature at all. On SAR devices it'll mount your system rw.... I'm removing it in the next update.
[Magisk] martyfender:
Yes I attached the bootscript log last night, but I have not reinstalled it since I reinstalled Magisk today. Did you overlook it? I assumed you had seen it.

I uninstalled your module again, so the only module I have installed is busybox ndk and of course, the systemless hosts module.

I assume that the Magisk uninstall removed all of the files in /data/adb, but I never checked it out. I had to regrant all of my root apps access again, etc.

I've thought about installing and an older version of Magisk to see if it helps, but quite a few on both the Canary and general threads have appeared to have trouble when reverting to older versions that previously worked. Maybe that is because they did not uninstall first and or restore stock boot.imgs, first. I did restore my stock and rebooted with it before I flashed the patched image.

I have dd imaged some of my partitions, such as boot, recovery and system, but the device has ~28 partitions according to the author of the device thread. I am not even sure if they can be restored properly in fastboot mode. Many are using various mtk compatible tools to do this. I won't do this with spflashtool, if possibe because I used it in the past and had trouble with it so I hate it.

Thanks for your continued support
[Magisk] aseferfan:
Thanks for all the help, I created the printslist file using npp+ and put it inside the root of my sd, I still can't see the option "custome fingerprints" in props menu in termux, am I doing something wrong?
[Magisk] ipdev:
Not sure about Termux.

(I've only used it once/twice before.)

I normally use the built in terminal app or Terminal Emulator.

(aka jackpal.androidterm)

Unless Windows added something to the file name, NotePad ++ should work.

printslist file should have no extensions (. .txt .sh .WhatEverElse)

I use Android, Linux and MacOS. Windows only when I have to.

- Intermission -

So I just tried with Termux.

Like I remember, it's a little different than I'm used to but still worked.

Make sure you have root. (run su and make sure Magisk grants root.)

Then run props

Select 1 (Edit device fingerprint)

Select f (Pick a certified fingerprint)

Select 3 - Custom

To Recap:

Make, copy or move your Custom FingerPrint list to root of storage and name it printslist

/sdcard/printslist

Open a Terminal app (or adb shell)

Make sure you have file and root (su) privileges granted for terminal app (or adb shell).

Run props

Select 1, f and (currently) 3 for Custom.

- This should display your custom printslist file.

Please add the security patch date to your post. ;)

Please double check but, it should be the same as 5T.

(ro.build.version.security_patch=2019-10-01)

[MENTION=4667597]Didgeridoohan[/MENTION]

So I dragged my feet a little this month waiting for updates.

Of course OnePlus finally released 5/5T updates the day after.

Attached is an updated version.

Cheers all. :cowboy:
[Magisk] saintxseiya:
Seems as if there is an issue in the last havoc beta with the latest magisk.

Maybe you could have a look?
[Magisk] martyfender:
It looks like you may be having a similar issue as mine. See my recent posts.

From your log:

I hope that [MENTION=4667597]Didgeridoohan[/MENTION] will have more time to look at it after his up coming exams are completed and maybe fix this, if it is caused by his module. My new device has the latest Canary on it. It looks like you are on the latest Canary as well. Is it blocking the running of post-fs-data.d and service.d scripts, as well? So that is is Android 10?

I could not seem to find the havoc beta on the sourceforge site, or I overlooked it. Apparently it boots on my new device, but that may be the Android 9 version.
[Magisk] saintxseiya:
Yeah well was on canary, tried stable etc. nothing worked.

So using safetypatch v3 for now, that fixed the CTS issue at least for now.

---------- Post added at 09:58 AM ---------- Previous post was at 09:55 AM ----------

Yeah well was on canary, tried stable etc. nothing worked.

It had run on the first Android 10 release, so might not be an issue with A10, but who knows? :)

So using safetypatch v3 for now, that fixed the CTS issue at least for now.
[Magisk] damnation333:
Hi,

Could need some help to get my banking app to work on my OnePlus 3, Android 9, rooted with Magisk.

I pass ctsProfile and basicIntegrity. All green here.

However, the CaixaBank Pay (payments) or Sign (pins) apps still cannot connect to the server.

I have tried the "Fingerprint" option . Still not working.

The "Improved Hiding" feature is disabled.

What else can I try? Much appreciate your help. :)
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] and [MENTION=1060692]saintxseiya[/MENTION]

I have a few things I'm improving in the next update. One of them being making the post-fs-data.sh script much more efficient. That's something I've been a bit troubled about for some time actually (the script putting to much strain on the boot process). I'll give a holler once I've had time to implement it, since hopefully that should fix the issue you're seeing.
[Magisk] Didgeridoohan:
This module isn't going to help... Take a look at my Magisk guide and try a few things in there:

https://didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps

If you need further assistance after that, a more suited place to post would be the Magisk general support thread or one of the many "my bank app doesn't like Magisk" threads in the Magisk Forum.
[Magisk] Arindam430:
Please add Redmi Note 7 pro device in the certified fingerprint list, code:-

xiaomi/violet/violet:9/PKQ1.181203.001/V10.3.13.0.PFHINXM:user/release-keys
[Magisk] garylawwd:
He needs security patch date also
[Magisk] martyfender:
Onn 8 tablet Android 9

ro.bootimage.build.fingerprint=onn/ONA19TB002/ONA19TB002:9/PPR1.180610.011/1551232410:user/release-keys

Security patch level 2019-01-05

Please let me know if this is wrong somehow.

Thanks
[Magisk] ipdev:
Looks good to me.

Only question is What do we call it ?

Onn -> Ona :confused:

Are you able to check if there is a ro.product or ro.vendor

brand, device, manufacturer, model, or name

I just checked and it passes SafetyNet on my Nexus 7.

Cheers. :highfive:

Edit:

Mostly just the ro.product / ro.vendor model

Since brand, name and device are part of the fingerprint.
[Magisk] vgironov:
Always getting device boot loop when i change my device fingerprint... I'm tired of this T_T

I'm using Galaxy S6 GM-G920F with LineageOS 16.
[Magisk] martyfender:
The brand name is a Walmart brand called ONN.

ro.build.product=ONA19TB002

ro.brand=onn

ro.product.model=ONA19TB002

ro.product.vendor.manufacturer=JOYAR

ro.product.vendor.model=ONA19TB002

ro.product.vendor.brand=onn

ro.product.vendor.device=ONA19TB002

Thank You for testing this.
[Magisk] Ice-Cable:
I have a pixel 3 XL. I updated to android 10 lost wifi tether, re-rooted and what not still won't work. I tried the ol edit build.prop and it won't stick. I read and read and read and got pointed to the MagiskHIde Prop Config, downloaded all the modules needed and went to town except it isn't working wither. can anyone look at the pic Ive attached and tell what I am doing wrong?

so sorry for the ginormous pic
[Magisk] Didgeridoohan:
I see nothing wrong (apart from the horrible ui bug that will be fixed in the next release)... At that last stage you just need to enter the value you want to set the prop to and you should be done.
[Magisk] Ice-Cable:
So where it says enter E to exit I type "true" and then it should work. I wasn't sure with it saying the module doesn't exist. I knew i was trying to add it but was still confused.
[Magisk] Didgeridoohan:
That's correct.

That message is another thing I'm fixing in the next release... It's been causing more confusion than necessary. :laugh:
[Magisk] Ice-Cable:
Well thank you for clearing that up and it works. I have rebooted several times and my tether is working great. Thank you so much for your help.
[Magisk] kojak1989:
Any module for better hide root ? Something like anrc from xposed? I have problem with pay with my phone in banking app because of it , no better results with magisk hide.
[Magisk] Didgeridoohan:
Wrong thread... Take a look at this guide:

https://didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps
[Magisk] sliding_billy:
If you haven't already, give this a read? it uses this module, and it works even on 10.

https://xdaforums.com/pixel-3-xl/how-to/how-to-native-tethering-rooted-pixel-3-t3858662
[Magisk] pritamdutt:
Banking app detecting root

Tried magisk hide and ur module with official fingerprint and IMprove hiding feature too, but the app still detects root. Rom passes cts and basic integrity check by default. Any suggestions? logs attached,
[Magisk] Didgeridoohan:
Passing SafetyNet only helps with those apps that actually use SafetyNet (not that many) and make the Play store certified, and changing the device fingerprint doesn't really do anything if you already pass CTS (unless you want to make your device seem to be another). The "Improved hiding" feature of this module is in reality pretty useless... It's gone in the next release.

You want this:

https://didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps
[Magisk] chrcol:
can I use this module to read props set by other modules (to confirm they set properly)?

if so how?

thanks
[Magisk] Didgeridoohan:
You can, but I won't describe that process since it's much easier to just run this command in a terminal emulator:

getprop <prop you want to check>
[Magisk] chrcol:
Have used this now to fix tethering, add volume control steps and adjust and adjust one other prop, thanks, works as expected.
[Magisk] Doggie52:
Hey,

Recently (in the last month) my device stopped passing CTS although Basic Integrity still passes.

I'm on a Oneplus 3T running latest official LineageOS 16 nightlies. My prop value is the same as what this module wants to switch me to, so clearly it's correct.

I've tried turning MagiskHide on and off, turning Developer Options on and off, running Magisk in Core mode, lots of rebooting, turning off USB debug, etc. but nothing seems to work.

Any ideas on what I can do, save from reflashing my phone?

Thanks in advance and let me know if I can provide any more info!
[Magisk] Didgeridoohan:
Does the security patch date of the ROM match the one for the fingerprint (2019-08-01)? If it doesn't match CTS will fail...
[Magisk] Doggie52:
Oh, great, I wasn't aware setting the prop would automatically set the correct security patch date! Thank you, this fixed it for me!
[Magisk] StormySky16:
I think the LG G6 H872 fingerprint has stopped working, as it used to work a month or so ago but now it's not working. Nothing has changed device side, so I assume the fingerprint is just no longer functional.
[Magisk] martyfender:
Do you actually mean the build fingerprint, or do you actually mean a fingerprint reader? I don't believe a build fingerprint just stops working, there is some other cause, I think. I could be wrong?
[Magisk] StormySky16:
Build fingerprint, I have 2 G6s using magiskhide props config and the h872 fingerprint enabled, both are failing cts.
[Magisk] martyfender:
Have you looked for possible solutions in this guide?

https://github.com/Magisk-Modules-Repo/MagiskHidePropsConf/blob/master/README.md
[Magisk] Didgeridoohan:
Those LG prints where a bit finicky when I first tested them. A couple would only actually pass CTS on one of my devices, but failed on others. It's possible that it is broken somehow... I'll take another look at them.
[Magisk] Bi0haZarD:
You have to change security patch date to any, prior june 2019. CTS will pass with no other modification.

i.e. 2019-06-01

Edit: Only drawback is that in device info will show modified security patch date while the one included in rom, will still be in effect. So don't worry, it will not downgrade the security patch in any way.
[Magisk] Didgeridoohan:
I know about changing security patch dates (most of the prints included in the module do it automatically). But, that was a new one... What's LG up to?

Thanks for the heads-up.
[Magisk] Bi0haZarD:
You're welcome bro and thanks for all your efforts in this module!

The thing is that It's not related with LG, it's some recent changes in play store, thus why the same fingerprint was working before and suddenly device cannot pass CTS and playstore shows "not certified" ;)

Edit: Mostly it's this new implementation of play store and Q, focusing on security and updating security patch without changing the OS
[Magisk] Didgeridoohan:
Not the Play store. Play services, possibly.

It's not a general issue though... I've got plenty of prints I've tested recently, with later security patch dates that work fine (of course, I'm going to have to retest the entire list now to see if any other prints are affected).

My best guess is that Google has tightened something down as a result of the Huawei/LZPlay debacle a few weeks back. I'll try to look into it.
[Magisk] Bi0haZarD:
Yes you're right, most recent prints will work with their Sec. Patch date. Probably it's the whole GMS thing, google has some new bugs to sort out! Btw I have edited my post above but you replied so fast bro!
[Magisk] ValeV008:
Hi, I installed the module in Magisk and ran props command in Termux, chose option 1 (pick fingerprint) and pressed 'f' (certified one). Here, no list is loaded, the module kind doesn't do anything from here on. Check attached screenshot.

Was this bug (or "bug") reported yet and is there a solution?

Magisk 20

stock rom

xperia z3 compact
[Magisk] Sid220:
Hi all, I have tested successfully the latest fingerprint for PocoPhone F1 with MIUI 11. How can i submit it to be added to fingerprint list?
[Magisk] Didgeridoohan:
Just post it here together with the security patch date and I'll take a look at it.
[Magisk] Didgeridoohan:
Not something I've seen before... Nor can I replicate. Have you tried a different terminal emulator? How about the module log file?
[Magisk] Didgeridoohan:
I would like a few more details on this. The fingerprint that was being talked about had a security patch date of 2019-01-01, so well before 2019-06-01... Doesn't seem to apply here.

How did you find this info? What prints have you tested? Etc, etc...
[Magisk] Bi0haZarD:
Redmi 5 plus with oreo print

Edit: taken from here

https://github.com/Magisk-Modules-Repo/MagiskHidePropsConf/pull/26/files
[Magisk] Sid220:
Fingerprint: Xiaomi/beryllium/beryllium:9/PKQ1.180729.001/V11.0.5.0.PEJMIXM:user/release-keys

Security patch date: 2019-10-01
[Magisk] Didgeridoohan:
Fun fact: I test all the fingerprints found in this module, and when I tested that one it only passed CTS with the included patch date of 2019-03-01. Nothing else...

So, I'm still not quite sure what it is that you say you've found. Looks to me like things are working as expected.
[Magisk] jahidinbedod:
Thanks [MENTION=4667597]Didgeridoohan[/MENTION]
[Magisk] Kris Chen:
Please include of Pixel4 & Pixel4XL, thanks !
[Magisk] GTMoraes:
Aww.. good update, but I got slightly excited expecting for the Mi 9 Android 10 fingerprint there.

Thanks for all updates, though!

------

Of course, how rude. Any way to contribute with that fingerprint I want? How do I "extract" a working fingerprint for it to be added to the module?
[Magisk] garylawwd:
Everything you need is in the op
[Magisk] Bi0haZarD:
Build.prop from /system and /vendor. Fingerprint and Security patch date.
[Magisk] L0RD_SkyWalK3R:
Moto G5S Plus sanders fingerprint (8.1)[OREO]

Hey [MENTION=4667597]Didgeridoohan[/MENTION] you're doing noble work there. Can you please verify this fingerprint and hopefully include it in the list ?

FINGERPRINT : motorola/sanders/sanders:8.1.0/OPSS28.65-36-6/05c0:user/release-keys

Android Version : 8.1.0

Build Id: OPSS28.65-36-6

Security Patch : Wed Dec 5 11:17:24 CST 2018

Full Treble Enabled : False
[Magisk] CleaveGodz:
Hey, I'm having issues for setting custom props. I tried to change lcd density and the terminal is stuck after typing y. Both in default (1) and both boot stages (4). Android 6 using termux in custom rom, osm0sis busybox installed and magisk 20.1

EDIT: I tried to change default boot stage and now it shows in blank, and can't change it, going to reinstall module because it's now broken. Gonna try it again afterwards
[Magisk] Didgeridoohan:
I can't replicate, so I'll need more details and logs.
[Magisk] Bi0haZarD:
Quoting an earlier post of mine to give some info.

Source: https://www.android.com/android-10/
[Magisk] CleaveGodz:
Okay, I'll send a compressed zip with all the logs and two screenshots of the terminal. Note that the terminal literally does nothing else, and any input is added as a line but does nothing, just as if something is still working in there. Thanks in advance both for helping and for being so fast to reply :o
[Magisk] GTMoraes:
I've tried creating the propslist on my sd root folder, and option 26 Custom even shows up in props, but it's completely empty. I've followed the instructions on GitHub, and even used the example listed there, to no avail.

Weird. I have the Android 10 fingerprint, but I can't find a way to make it use it
[Magisk] ipdev:
[MENTION=3261130]GTMoraes[/MENTION] it's not just you.

There seems to be a problem displaying the custom list.

The custom.sh file is generated but not displayed.

Enter your desired option: 26

MagiskHide Props Config v5.0.0
by Didgeridoohan @ XDA Developers

=====================================
Edit device fingerprint
List version - v64
Select an option below.
=====================================

b - Go back
e - Exit

Enter your desired option:

[MENTION=4667597]Didgeridoohan[/MENTION]

Please take a look when you have some time.

Tried on a few devices (Android 9 and 10) and the last two versions of busybox and canary-debug.

Missed this until I ran it using adb shell.

/system/bin/props[2872]: [: ]: unexpected operator/operand

Shows up a few times.

Attached propslogs.tar.gz

Attached extra.zip has custom.sh, printslist and adbshell.sh

Cheers. :)

Edit:

New Note:

If you change the name of custom.sh to Custom.sh

It is displayed as the third option in the list (Asus, BLU, Custom) and seems to work from there.
[Magisk] Didgeridoohan:
[MENTION=3261130]GTMoraes[/MENTION] and [MENTION=7280276]ipdev[/MENTION] Confirmed. And I know exactly what happened...

The other night, while cleaning up the code for the release I thought to myself "why on earth did I name that file Custom.sh with a capital C? Let's change that..."

Let me introduce my palm and face to each other for a moment and then I'll take care of that once they're properly acquainted with one another.

What was that I wrote about typos in the release notes? :D
[Magisk] ipdev:
My head and palm are old acquaintances :D
[Magisk] Didgeridoohan:
The reason things aren't working is that the module settings aren't loaded, for some reason. So I know what is happening, but not why... Dammit. Do you experience the same if you use a different terminal emulator or ADB shell? Actually, if you could try from ADB shell that would most likely pop up some error messages that aren't visible on-device and could prove useful in tracking this down...
[Magisk] Didgeridoohan:
I'm sorry but I still don't see the relevance to what you said about some fingerprints needing a security patch date prior to June 2019...
[Magisk] Didgeridoohan:
Update to v5.0.1-v65

A quick-fix to take care of a couple of bugs introduced in yesterdays release.

Main bug was one that cleared out all the module settings when installing v5.0.0. Anyone that updated to v5.0.0 will have to redo their setup. Sorry about that...

Also realised I had forgotten about one submitted fingerprint, so that got included as well. Thank you to [MENTION=6301872]nri_tech1183[/MENTION] for submitting it.

Changelog

v5.0.1

Fixed issue with settings being cleared when updating from earlier module versions. Sorry if anyone got all their custom props removed...

Fixed issue with creating a custom prints list.

Fixed issue with saving Magisk log.

Added fingerprint for Xiaomi Note 7 Pro. Fingerprints list updated to v65.
[Magisk] CleaveGodz:
Okay, I'm gonna try it tomorrow in my sister's pc. I tried this in termux and terminal emulator, where I tend to use other kinds of modules so it's not the terminal. One more thing, I seem to be unable to use echo commands for both /sys and /system, idk if it's related or not. Catch you up later :)

---------- Post added at 10:35 PM ---------- Previous post was at 10:20 PM ----------

EDIT:

Idk if the logs I sent before said this so I copypaste these thingies. What brings my attention are those "curr" and "not found"

/system/xbin/props: CURRRO.DEBUGGABLE=0: not found

/system/xbin/props: CURRRO.SECURE=1: not found

/system/xbin/props: CURRRO.BUILD.TYPE=user: not found

/system/xbin/props: CURRRO.BUILD.TAGS=release-keys: not found

/system/xbin/props: CURRRO.BUILD.SELINUX=0: not found

/system/xbin/props: CURRRO.PRODUCT.BRAND=samsung
[Magisk] martyfender:
[MENTION=4667597]Didgeridoohan[/MENTION] do you recall my troubleshooting related to this module blocking service.d scripts such as Apps2SD?

Well it is still happening with this new version on my new Onn 8, Android 9 tablet.

Attached are the logs from your module and Apps2SD boot scripts. 3 of these scripts are in /data/adb and one: 00000000aps2sd.sh is in /data/adb/service.d.

I have thought about creating that script instead in /data/adb/post-fs-data.d to see if that makes a difference.

Congratulation on getting through those tough exams, etc. 1982 was the last time I took college exams for my BA, if you don't count some electrical certifications at a vocational college.

Thanks Again

Regards
[Magisk] martyfender:
While creating the script: 00000000apps2sd.sh in /data/adb/post-fs-data.d appears to solve the 2nd partition mount problem at boot, your module still shows with errors and log creation in the root terminal. Here I attach the log from that change.

Thanks