yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] Thank you.

I've whipped together a quick test version of v5.0.1, if you could try that. It's exactly the same as the current release, with just the post-fs-data.sh script being slightly altered. Hopefully that should clear some things up...
[Magisk] Ryano89:
I'm on a OnePlus 6t T-Mobile converted device running Android 10. It appears that our device signature doesn't match or something, as many of us are failing cts profile. Is there likely to be any negative effect if I select a device signature for something like the OnePlus 7pro in order to try and get playstore certified?
[Magisk] Didgeridoohan:
I'm assuming you want the 7 Pro print because of being Android 10.

It's usually no worries to mix and match either device or Android version when it comes to the device fingerprint. In your case though I would personally go for the included 6T print, even though it's Android Pie. Better to match the device than the version, IMO.
[Magisk] Ryano89:
Thanks. It's not a problem that the security patch is different? Nevermind.. I learned to read. Thank you
[Magisk] martyfender:
I wish I could.

I just may have found a potential bug in the Latest Canary debug build. I do not yet have a custom recovery for my new device so I attempted to flash your test in the + modules section. It does nothing and MM appears to close without errors. I then tried to flash your released version through the +modules option and it failed also. Installing through the downloads tab works normally, though. What is the best way to log this and post on github for [MENTION=4470081]topjohnwu[/MENTION] ?

I will reboot and do a LogcatX per app filtered logcat, or would a full device logcat be better? The full ones can be very long.

Thanks
[Magisk] Didgeridoohan:
The app just force closes? Strange... A logcat would be the best for that.

In that case could you simply replace the current post-fs-data.sh script (/data/adb/modules/MagiskHidePropsConf/post-fs-data.sh) with this and see if it fixes things (rename it from .txt to .sh)?
[Magisk] martyfender:
Attached is per app logcat for a hidden mm. Note the crash listed there. Should I post on github?

Thanks
[Magisk] Didgeridoohan:
If it's a reproducable bug and it's not fixed by the normal old clearing app data, etc, then I would say that's a good idea.

Is there any difference if the Manager is hidden or not?
[Magisk] martyfender:
I just did and checked permissions and am rebooting now.

Wow! When I rebooted that folder: /data/adb/modules/MagiskHidePropsConf/system/ It only had system in it. Not sure what happened?

I am now trying to put it in the module_update folder after installing your released version and before rebooting.

It is installed now, but after rebooting and running props in a root terminal, I get the same old:

As was before, no edxposed is installed.
[Magisk] martyfender:
Log attached.
[Magisk] martyfender:
That thought crossed my mind, also, especially considering all of the issues recently related to the hidden manager, which for me have been rather minor. will try.

Yes, you were correct, it installs properly from the +modules section when I restored the Manager. However, module still does not run properly.

I don't have time to report on github tonight, as I have to get up early.

Thanks for your help. I am glad to test when I have time.
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] Thanks for reporting and testing. I'll do some more tweaking later.
[Magisk] ValeV008:
I get the same errors (not found). Did you solve it yet?
[Magisk] Didgeridoohan:
I'm investigating...
[Magisk] Humaxxx:
[MENTION=4667597]Didgeridoohan[/MENTION]

I have a Samsung S3Neo and i managed to successfully pass SafetyNet with CM12.1, LOS14.1 by editing fingerprint in system/build.prop. But in LOS16.0 changes to build.prop seems to take no effect, so SafetyNet (ctsProfile) fails. Now i have tried your tool and setting a fingerprint (from galaxy S4 - same as i always used) and it works.

Now I have a question about how your tool works. It seems, that build.prop ist still untouched, so my question is, in which file or whereever does your tool makes the changes?
[Magisk] Didgeridoohan:
No files are edited, that's the basis of how Magisk works. Files are replaced systemlessly (Magic mounting), without touching any of the system partitions, and when it comes to prop values, the Magisk resetprop tool simply loads the new values to memory rather than the ones you find in build.prop.

You can find more details about resetprop here, and Magic mount in the same document right here.
[Magisk] Humaxxx:
Ok, thanks for the links, i will read it. But i have another question, maybe you can answer it...

I Guess in Android Pie, the informations about the phone are "stored" somewhere else than build.prop, because in LOS16 (Android Pie) most of the changes i make in build.prop take no effect. Here an example. In originally (untouched) build.prop the model of the phone is "s3ve3gjv", but in settings / about phone it shows "GT-I9301" also if i use a terminal with the commands "su" and "getprop ro.product.model" it shows "GT-I9301". So my question is, from where (which file ) does the phone and your tool gets the info about the Model and other properties like fingerprint, when its not using system/build.prop and not using /system/vendor/build.prop.
[Magisk] Didgeridoohan:
There are several prop files available on a device (system build.prop, vendor build.prop, default.prop, etc, etc). I don't know them all, since I simply use the resetprop tool (or getprop) to check and change information and props on the device. Much easier than to try to keep track of what file to edit and where...

Using the Magisk systemless way also means that the change survives a system update (as long as you don't clear /data). Yay.
[Magisk] Humaxxx:
Thank you.
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] [MENTION=9427212]CleaveGodz[/MENTION] [MENTION=7517292]ValeV008[/MENTION]

I've got a work-in-progress zip right here that have possible solutions for the issues you have been seeing. If you could test it and report back, that would be great.

Disclaimer: I have not yet fully tested this zip, but installation and basic functionality is there.

Edit: attachment removed so as not to have people using untested zips.
[Magisk] ValeV008:
My findings:

1. Sometimes I get "checking internet connection; no connection", but othertimes I don't.

2. Correctly sees my device fingerprint when I choose option 1.

3. I picked "pick certified fingerprint", it shows list now (official version gets stuck here).

4. I picked certified fingerprint for my device, when prompted "do you want to continue?", i put "y" and enter, then module went to new line and stopped working. I clicked ctrl+c, ran props again, and now i see "1. Edit device fingerprint (active)", so I suppose it worked, OR it just says it works.

I came this far, now have to go to sleep. Let me know what else you need. I am no expert but am willing to help.
[Magisk] CleaveGodz:
There's no change at all in functionality. But now it doesn't load the proplist (those "not found" don't even show) before opening the interface. Typing Y still hangs the module. Now my custom dpi correctly shows before typing Y. In a few minutes probably I could use the pc, how do I do this via adb? The same but typing adb before the command?
[Magisk] Didgeridoohan:
Thanks for testing. Do you still see the "not found" errors?

It's way past my bedtime as well, so: G'night.
[Magisk] Didgeridoohan:
Oh, hello there. Can't go to bed yet, it seems.

So, the "not found" errors are no more? That's a good sign and probably means I'm on the right track.

If you wanna give ADB a go that would be great (might show more errors that could give me more hints). Just hook the device up to the PC, open an ADB shell and run the props command.

As stated above, I'm heading to bed now and will get back to you guys tomorrow.

Edit: Yes run the command "adb shell props" and you should be good. Shell will ask for superuser access and you can just grant that on the device.
[Magisk] martyfender:
Sounds like your bed time is my dinner time here inthe Midwest USA.

I flashed this new test and I am still getting an error when I run in the terminal. I have attached new logs.

Thanks

Your release version continues to work fine on my Older, Nextbook, Android 6.0.1 tablets, so I haven't run this test version on any of them.

Thanks
[Magisk] ValeV008:
No sir, no errors now. It still hangs when selecting "y" after "pick certified fingerprint" or "reset fingerprint". But after choosing "collect logs" it works ok (on official version, here it hanged as well). I will pick a certrified fingerprint, collect logs and upload them, so maybe you will see why the module hangs after typing "y".

EDIT: Added propslogs.tar.gz file, hopefully you will find something useful there, because I don't: :D Is there supposed to be any additional logs between these 2 lines? (like "fingerprint successfully changed" or something)
[Magisk] Didgeridoohan:
[MENTION=9427212]CleaveGodz[/MENTION] and [MENTION=7517292]ValeV008[/MENTION], thanks for the help. From the info and logs you've provided so far (yes [MENTION=7517292]ValeV008[/MENTION], those logs actually told me a lot) I'm fairly sure that the issue is your device's toybox. I'm heading to school at the moment, but later I'll put together a new test version for you that enforces the use of Busybox's commands rather than allow the use of toybox where available. Hopefully that should fix things.

[MENTION=8126387]martyfender[/MENTION] I still have no idea what's up with your device. Comparing the logs from you and [MENTION=7517292]ValeV008[/MENTION], there are huge differences in the execution of the post-fs-data script. Yours takes over a second and a half, while his (and on my devices as well) executes in less than a tenth of that time. Weird.

Edit: [MENTION=8126387]martyfender[/MENTION] I just got an idea for something that we can test later. I'll let you know.
[Magisk] Ryano89:
So I used this mod to perfection to allow my TMobile converted OnePlus 6t running stable Android 10 to pass CTS profile and be playstore certified by changing the fingerprint to the Android 9 version of the 6t. However now all of the sudden a day later, it's failing again and I don't know why. Does anyone know of another way to fix this? I've tried reinstalling magisk, stock kernel, custom kernel, dirty flashed A10 again, reapplied the edited fingerprint, but it seems nothing will get it to pass now even though it was working yesterday.
[Magisk] Didgeridoohan:
Have you made sure that MagiskHide is actually running and working? Try toggling it off and on.
[Magisk] martyfender:
You didn't by chance, install xposed, did you? If not, take a look here if you have not already:

https://www.didgeridoohan.com/magisk/MagiskHideSafetyNet

and here is the link to the guides first page:

https://www.didgeridoohan.com/magisk/HomePage
[Magisk] Ryano89:
I toggled off and on, and rebooted. It's so weird

---------- Post added at 06:15 PM ---------- Previous post was at 06:14 PM ----------

Thanks for the heads up, but no I do not use exposed at all.
[Magisk] Didgeridoohan:
Logs then? Details:

https://github.com/Magisk-Modules-Repo/MagiskHide-Props-Config/blob/master/README.md#logs
[Magisk] Ryano89:
I think this is what you need. It may be some sort of problem related to being a T-Mobile converted device?
[Magisk] Didgeridoohan:
Reinstall the module... Somehow your settings file has been cleared out of contents. A reinstall and setting up the fingerprint again should fix things.
[Magisk] Ryano89:
Worked like a charm. Sorry for not trying that 1st. That was dumb on my part. Thank you so much.
[Magisk] MCR31:
I tried latest version and didn't work for me.

I have a samsung s9 snapdragon with Android 10 (PHH) with phh-magisk but i cannot pass CTS. I've try all the ways and no luck.
[Magisk] Didgeridoohan:
Logs?

Edit: and have you asked in the ROM thread (usually a good place to start)? And what's phh-Magisk? Haven't heard of that one before...
[Magisk] Didgeridoohan:
[MENTION=9427212]CleaveGodz[/MENTION] and [MENTION=7517292]ValeV008[/MENTION], here we go again. Got another test zip where I've made sure that a bunch of important commands are forced to use the Busybox variant rather than Toybox. Hopefully that should fix things (unless I'm completely wrong about what the issue actually is).

[MENTION=8126387]martyfender[/MENTION] If you also could try the ToyBoxTest zip that would be great. If you don't see any kind of improvement, try the MartyTest zip.

Thanks guys for helping out.

Edit: attachments removed so as not to have people using untested zips.
[Magisk] MCR31:
GSI Android Q, phh created a magisk version: https://github.com/phhusson/treble_experimentations/releases/tag/v200 you will find the magisk-phh.zip

I asked in the telegram group, but phh said he doesnt care too much about passing CTS

Attached are the logs, thanks
[Magisk] CleaveGodz:
There's an improvement! I still cannot put a custom config. The hang is still there. However, this time it didn't hang to collect logs, so I didn't have to manually get them. Also, I changed the default boot stage to post-fs-data, in the previous build it hanged for a while then said "current boot stage is" without anything else, like a null value. I know you are going the right way, I'll cheer you up from my bed xd. Going to try marty's build just in case, I'll only update if it does something new.
[Magisk] ValeV008:
Quick testing. for me it works exactly the same as last version, except now when I create logs through it, no file is created in root folder of internal storage. Will upload logs tommorrow.
[Magisk] Didgeridoohan:
But you're not running that phh-Magisk build now (according to the logs)?

Anyway... Logs look ok and things are working as they should. Have you tried picking one of the fingerprints from the included list instead of using the vendor fingerprint function? Other than that I don't think there's much more I can help with at the moment.
[Magisk] MCR31:
This is the magisk I'm using, but I can't even pass basicintegrity.

If I choose an other fingerprint, doesn't matter that the s9 says Android 8?

Thanks
[Magisk] Didgeridoohan:
No, it generally doesn't matter what Android version you pick the print from.

But, if you're not even passing basic integrity it's very likely that there's something about your setup or the ROM that causes it to fail rather than an uncertified fingerprint.
[Magisk] martyfender:
I just got home from the hospital so I will check it out. By the way, what time zone are you in, if you don't mind me asking?
[Magisk] Didgeridoohan:
Central European Time. Which means I should have been asleep a while ago. But, both me and my wife have a horrible cough keeping us awake...
[Magisk] martyfender:
I'm so sorry to hear that.

Attached is logs of another failure, the toybox test. I will nos. Try the other one and post on it. Is there anh other logs or system info that would be useful.

There are some very knowledgeable people in the Onn 8 xda thread that may be able to shed some light. There are severa that are testing various other GSI roms, etc on this device.

Thanks.
[Magisk] martyfender:
Here is the latest failure from martytest.

As always, thanks. Take care of that cough.
[Magisk] martyfender:
Guess what, marty test is working now after I rebooted a second time. I applied a certified Google Pixel, Android 9 fingerprint and am rebooting now and will check safetynet and playstore certification.

This makes me wonder if the others would have worked with a second reboot? Wow!

UPDATE: Changing the fingerprint and rebooting and it stuck and passes both safetynet and playstore certification.

I won't switch back to the previous tests and do two reboots, until I hear from you as to what to test next, so I don't go though anything that is a waste of time. I do know this with this device, that the release version didn't work after 2 reboots, I don't believe?

Regards
[Magisk] martyfender:
Now that you are thoroughly logged out, (My very poor attempt at humor), attached are the logs with martytest working tbrough several reboots.
[Magisk] martyfender:
Sorry, I couldn't resist testing toyboxtest again with 2 reboots, to confirm that it is still not working. I hope this gives you the info that you need. If you feel like it, considering that you are sick, let me know what you did in somewhat laymans terms to fix this. Could this create new bugs for other devices/Android version.?

I don't know why, but I enjoy testing early release versions of software, knowing that bugs are to be expected.

I have been testing Unofficial and Canary versions of Magisk, since I installed the first, working for me, version 15.0.

Regards
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] Thanks for testing, and thanks for the well-wishes.

In the MartyTest version I simply let the post-fs-data.d script run in the background so that the rest of the boot process isn't interrupted. This unfortunately has some drawbacks so I'm going to have to think about how to implement that...
[Magisk] martyfender:
Yes. I noted in that log that service.d scripts were not running. I did not have any because if you remember, I had moved them to post-fs-data.d.

Thanks
[Magisk] kusakhan:
any possibilty resolve this issue?
[Magisk] Didgeridoohan:
Using Xposed and "No device check"? Nothing this module can help you with there.
[Magisk] kusakhan:
what i do remove no device check module then ?
[Magisk] Didgeridoohan:
If you're using Xposed there's nothing to be done... EdXposed might help, since up until now it has not been detected by Google. That seems to have changed today though, but there are workarounds available if you take a look on the EdXposed Github.

All this module will do for you, regarding SafetyNet, is to help you pass the CTS check by using a Google certified device fingerprint.
[Magisk] cortomalese:
Will you please add support for Fairphone 2 : I find it on firmware.mobi "https://desktop.firmware.mobi/device:1732/firmware:13197"

Thanks !
[Magisk] Dr.][No_WaY:
How to add wlan.wfd.hdcp = disable to build prop through this module?
[Magisk] Didgeridoohan:
https://github.com/Magisk-Modules-Repo/MagiskHidePropsConf/blob/master/README.md#usage

and

https://github.com/Magisk-Modules-R...master/README.md#changeset-custom-prop-values
[Magisk] Dr.][No_WaY:
Ok thank you , but after installing this Module, the safety net work around stopped and got false again , any idea to fix it?
[Magisk] Didgeridoohan:
What SafetyNet workaround? You need to be more specific and detailed when posting, or it'll be really difficult to help. Depending on your problem logs might also be a good idea.
[Magisk] Dr.][No_WaY:
sorry , I mean this work around

https://github.com/ElderDrivers/EdXposed/issues/386

stooped
[Magisk] Didgeridoohan:
Sorry, I don't really know anything about that... Best I could do would be to look at the logs I mentioned earlier (if you post them).
[Magisk] Dr.][No_WaY:
thanks for fast response,

How to get this logs? can you let me know and i will send it to you
[Magisk] Didgeridoohan:
Check the link.
[Magisk] martyfender:
Please read the documentation.
[Magisk] MCR31:
Hi Didgeridoohan,

I had some issues with magisk 20.1, so I revert back to 19.3 and now I can pass basicIntegrity but Profile CTS is false.

I tried to run the module but no luck. Attached my logs.
[Magisk] Didgeridoohan:
Why are you using a largely untested test version from the thread rather than installing the module from the repo? Try again with a proper release.
[Magisk] MCR31:
Attached the logs with the latest version from magisk.
[Magisk] Didgeridoohan:
Where did you get that Magisk version? From the logs it seems like it's using an ancient version of resetprop (not the one included in Magisk v19.3, but from v13.4), and thus the commands using it are failing miserably.

Was Magisk by any chance included in the ROM you're using, or something like that?
[Magisk] MCR31:
I'm using magisk 19.3 from pph (GSI) is the only way to boot Android Q :S

So it's more phh-magisk fault?
[Magisk] Didgeridoohan:
Doesn't look like it. I checked the zip for phh-Magisk v19.3 and it looks fine. You might have some other mod that's replacing resetprop though...

What's the output from these two commands in a terminal emulator:

which resetprop
resetprop --help
[Magisk] MrHomebrew:
Galaxt Tab A (Wifi SM-T590) (9)=samsung/gta2xlwifixx/gta2xlwifi:9/PPR1.180610.011/T590XXU3BSJ1:user/release-keys__2019-10-01
[Magisk] MCR31:
Which resetprop -> /sbin/resetprop

resetprop v13.4(1340) (by topjohnwu & nkk71) - System Props Modification Tool

Usage: resetprop [options] [args...]
resetprop <name> <value>: Set property entry <name> with <value>
resetprop --file <prop file>: Load props from <prop file>
resetprop --delete <name>: Remove prop entry <name>

Options:
-v verbose output
-n don't trigger events when changing props
if used with deleteprop determines whether remove persist prop file

Can I update resetprop?
[Magisk] Didgeridoohan:
We're gonna need some more info... Run this command as well and post the output:

su -c stat /sbin/resetprop
[Magisk] MCR31:
File: /sbin/resetprop -> `/root/resetprop'
Size: 15 Blocks: 0 IO Blocks: 512 symbolic link
Device: 12h/18d Inode: 16830 Links: 1
Access: (0777/lrwxrwxrwx) Uid: ( 0/ root) Gid: ( 0/ root)
Access: 2019-11-07 10:16:51.611000000 -0600
Modify: 2018-08-24 18:30:19.839999999 -0600
Change: 2018-08-24 18:30:19.839999999 -0600
[Magisk] Didgeridoohan:
Well, you've got something on your system making sure that a severely outdated resetprop is used instead of the one included in Magisk. Could be the ROM, kernel, or whatever. I would start by asking for advice in your ROM thread or wherever you can get support for it.
[Magisk] DesireC:
The Oneplus 6 just received a stable Android 10 update. Its fingerprint is

OnePlus/OnePlus6/OnePlus6:10/QKQ1.190716.003/1910270526:user/release-keys
[Magisk] Didgeridoohan:
Security patch date?
[Magisk] OhioYJ:
So I've been updating all my devices to 5.0.1. All had been good until I got to my Tab S5E, which is running LOS 16, had Magisk 20.1, and was using version 4.0.3. With 5.0.1 all my menus look like this for some reason:

If you enter the correct numbers any letters the menu options change and seem to respond. Flashing 4.0.3 back to this tablet makes everything look normal again.
[Magisk] Didgeridoohan:
Those are the colour codes for the script. For some reason your terminal emulator can't interpret them properly. Not sure why it shows up all of a sudden for you, but I'll take a look later.

It's purely cosmetical and meanwhile you can get rid of the weird stuff by using the -nc (No Colour) option when running the props command.

props -nc

Edit: does v4.0.3 show colours, or are the menu's just plain, boring text?
[Magisk] OhioYJ:
4.03 is all white text, no color. This got me to wondering. So I grabbed a couple other devices I had handy at my desk.

Tab S2 - LOS 16 - Same Terminal - Magisk 20.1 - 4.0.3 has no Color - 5.0.1 has Color (and working fine, no weird characters)

Honor 5X - LOS 16 - Same Terminal - Magisk 20.1 - 4.0.3 has no Color - 5.0.1 has Color (and working fine, no weird characters)

OP 6T - LOS 16 - Same Terminal - Magisk 20.1 - 4.0.3 has no Color - 5.0.1 has Color (and working fine, no weird characters)

This is the terminal emulator I'm using, strictly because it's what I've always used and it's seemed to work:

Terminal Emulator for Android by Jack Palevich

I'm open to suggestions though.

I've got a couple more devices I could try but it seems they are all responding the same way. However it definitely seems to be isolated to that one device (Tab S5e). I know that device is still new and being developed for, there isn't an official LOS version, so it just maybe what it is.