yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
[MENTION=1844729]Mr_Bartek[/MENTION] Like you say, the prop does look like it gets set correctly. Might be that the encryption is messing with the boot timing, or something like that. I have had a report like this previously, where encryption seems to break the resetprop tool, but I have no idea why. It does not seem to be a common occurrence. I have no issues while keeping my device encrypted, as an example...

[MENTION=5056724]paolocorpo[/MENTION] Are you talking about the device certification status in the Play Store? If so it's connected to SafetyNet, yes. If you pass the CTS part of SafetyNet (this module can help with that), all you need to do is clear data for the Play Store (and possibly reboot) and the status should change to certified.
[Magisk] paolocorpo:
It works !!!

You are right ... As usual ;)

View attachment 4687298

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] jcmm11:
The camera 2 API is a "persist" prop. That means it's actually stored in the data partition, specifically in /data/property/ It used to be stored as each prop being a separate file, but that's changed in Pie and all the persist props are now stored in 1 file.

If you run, in a terminal emulator, as root:

setprop persist.camera.HAL3.enabled 1

that should set the property and (as the name implies) allow it to persist through reboots (meaning you don't have to reapply it every time you boot).
[Magisk] paolocorpo:
I applied recently this procedure on My Mi A1 with Pie with success

The root can be temporary !

I mean ... You can only boot using a patched_boot.img

Apply the above procedure

Reboot

You will loose the root (of course) but the Api2 will remain available ;)

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] :
[MENTION=4487388]jcmm11[/MENTION], setprop persist.camera.HAL3.enabled 1 works if device is unencrypted. Once I encrypted the phone it stopped working. The property will show 1 but GCam will not work. Only way to force it to work is by editing build.prop. The phone is a Redmi Note 5 and this issue happened on both ResurrectionRemix (Android 8.1) and Pixel Experience (Android 9.0) but only once encryption was enabled.
[Magisk] jcmm11:
Does it happen with stock? In any case, since you're running custom ROMs leaving system unmodified isn't really critical so I'd just edit build.prop in this situation.
[Magisk] :
[MENTION=4487388]jcmm11[/MENTION], I haven't tried with stock. It's not a big problem, sure. However the updates for PE are plentiful and the updater within the ROM is decent. It would be a lot easier to not have to flash additional zips after every ROM update and since I'm not the main user it would save me some headaches also hence why I'm looking for a solution. :)
[Magisk] madbat99:
Post-fs-data.d script?
[Magisk] Didgeridoohan:
Might be too late... If the ROM has addon.d support, that would be a better option.

Edit: Unless they don't mind doing an extra reboot. That would work with post-fs-data.
[Magisk] madbat99:
You're probably right. Addon.d is likely better idea.
[Magisk] :
Thanks guys. I will try addon.d when I get home. Having a second thought about it, it looks to be some kind of incompatibility between my device, encryption and Magisk. I also have a Redmi 5 Plus with Pixel Experience and that phone has no issues with Camera2API when encrypted.
[Magisk] morfikov:
My phone passes safetynet check without problem when the stock ROM is installed. But when I install Magisk, the safetynet check fails no matter what I try to do. Basically both ctsProfile and basicIntegrity fail.

I accidentally found out that setting log.tag=I using this module fixes the issue. I just had to use the following in its config file:

CONFPROPS="
log.tag=I
"
CONFPROPSPOST="
log.tag=I
"
CONFPROPSLATE="
log.tag=I
"

And now my phone passes the safetynet check.

View attachment 4689887
[Magisk] Didgeridoohan:
First of all, that's really interesting. Do you have any info on what the log.tag prop is and why it works? Where did you find info that this would work?

Edit: the main reason I'm asking is that the only prop I can find (after a quick search) that had to do with log.tag is log.tag.launcher_force_rotate, and that shouldn't have anything to do with MagiskHide and SafetyNet. Is it possible that MagiskHide simply wasn't working and then started working after a reboot? What happens if you clear out the settings for the module (to reset the prop)?

Second. You only need to pick one of those three settings... CONFPROPS should be enough.
[Magisk] morfikov:
When you turn on the adb debug and you type "adb logcat", you get all the messages, including the debug ones, right? For some reason my system plays with the logs. When I do "adb logcat", I can only see messages with E tag (errors). That was driving me crazy because I couldn't see what actually was happening when my phone stalled during boot -- I saw only some error messages, but I couldn't tell if the devices does something or should I turn it off because it probably died. So I started to look for some solution to fix the adb debug messages.

I found out that some vendors disable extensive logging for performance reasons and because of the battery life. So I wanted to turn it on because I wanted to have the debug messages, and then I found the log.tag prop, which solved my problems but only during runtime -- setting this prop to "D" enabled debug messages. But still I wanted to apply this setting early at boot time, and I found this Magisk module.

The module was saying something about passing SafetyNet -- I didn't know WTF it is, but I wanted to check whether my device passes it, and it failed. So I started to play with the SafeNet checks. I tried to spoof the fingerprint, set it early/late, or generally do whatever was in the HowTo/wiki, and all of that failed. But I really wanted that my device pass the checks, so I dug deeper and I've read somewhere that those debug messages can make SafetyNet fail.

So I used the Magisk module once more, setting it to defaults except the log.tag prop. Since they said that debug can make SafetyNet fail, I started to play with the values, and ultimately I've set it to Info and rebooted the phone for the last time. And I was really surprised that the checks passed.

I don't know what sets the log.tag prop when my phone boots. I have two other phones, and they don't have this prop.

OK, I see that in a free time.
[Magisk] Didgeridoohan:
Yes, the whole thing about logging being disabled or crippled causing issues for MagiskHide is known (that's how MagiskHide works). And log tags are part of logcat. But, what I'd like to know is where you found info that made you set that particular prop. I would love to read up on that some (I have yet to find a single mention of a prop like that)...
[Magisk] morfikov:
I think it was here:

https://stackoverflow.com/questions/2018263/how-do-i-enable-disable-log-levels-in-android

They said about log.tag.MyAppTag=WARN so I just grep'ed the getprop, and I got this:

X1_Max:/ $ getprop | grep -i log
[debug.mdlogger.Running]: [0]
[debug.mdlogger.log2sd.path]: [internal_sd]
[debug.mtklog.netlog.Running]: [0]
[init.svc.bootlogoupdater]: [stopped]
[init.svc.emdlogger1]: [running]
[init.svc.logd]: [running]
[init.svc.logd-reinit]: [stopped]
[init.svc.mobile_log_d]: [running]
[log.tag]: [I]
[persist.log.tag.AT]: [I]
[persist.log.tag.RIL-DATA]: [D]
[persist.log.tag.RILC]: [I]
[persist.log.tag.RILC-MTK]: [I]
[persist.log.tag.RILC-RP]: [I]
[persist.log.tag.RILMUXD]: [I]
[persist.log.tag.RfxController]: [I]
[persist.log.tag.RfxMainThread]: [I]
[persist.log.tag.RfxRilAdapter]: [I]
[persist.log.tag.RfxRoot]: [I]
[persist.logd.size]: [4194304]
[persist.sys.log.uploader]: [0]
[persist.sys.pq.log.en]: [0]
[ro.mtk_matv_analog_support]: [1]

And the [log.tag] was there. And I wanted to check what happens when I set this to other value.

Also, using CONFPROPS doesn't help. My system overwrites the log.tag after the module sets it.
[Magisk] Didgeridoohan:
Interesting... Thank you. Just change the boot stage for that prop to late_start service then.
[Magisk] morfikov:
I made some vid as s proof (I don't know why it's rotated) -- any media player can fix that on the fly.

https://www.youtube.com/watch?v=1Gps3P5RGkw

Basically the phone is booted with the default props, it doesn't pass the check. Then I applied the config file via ADB, and rebooted the phone. And as you can see it now passes the check. All what changed was the log.tag prop.

Also setting the log prop only in the late_start makes magisk logs disappear since till that point my phone logs only Errors, and Magisk use Info and hence they aren't shown. I think it's best to set the log prop in all the three stages.
[Magisk] Didgeridoohan:
That's even more interesting.... In that case you only need CONFPROPSPOST and CONFPROPSLATE. CONFPROPS is just gonna be the same as one of the others depending on how the module otherwise is set up (default is post-fs-data).

I'll think about implementing that in the module for the next update.
[Magisk] morfikov:
I see, yes it works too when set only the two options.
[Magisk] fredl99:
Hi,

Could you kindly give me a brief explanation how to apply that fix?

Which file has to be edited and how?

My Moto G5 also doesn't pass both checks, whatever I've tried from the docs.

Many thanks in advance!
[Magisk] Didgeridoohan:
By the way, what device is this we're talking about?

Do you mean the log.tag prop discussed above? First it's best if you check if you're having the same issue (Android logging isn't working as it should). Check if the Magisk log is looking normal and if it is you've got something else going on.
[Magisk] fredl99:
Thanks for your reply, Didgeridoohan

I was referring to morfikov's report to have found a workaround for the security checks by accident. Since I'm through all hints from the docs without success I'm willing to grab any straw I can find.

My Magisk log is full of messages, but I'm not aware what is considered as 'normal'.

At least I could revert morfikov's fix, if it still doesn't help me, no?
[Magisk] morfikov:
It's Neffos X1 Max.

[MENTION=3402860]fredl99[/MENTION] -- I think you have different issue. But maybe this will work for you too. Basically download this file:

https://raw.githubusercontent.com/M...iskHidePropsConf/master/common/propsconf_conf

And place it under the /cache/ dir .

Change:

CONFPROPSPOST="
log.tag=I
"
CONFPROPSLATE="
log.tag=I
"

And reboot the device.
[Magisk] fredl99:
Thankyou morfikov!

You were right, it didn't help me. Another straw gone :(
[Magisk] Didgeridoohan:
Thank you. Never even heard of it before... Manufacturers and ROM makers crippling logging is not that uncommon, but this was a new one. Somehow I doubt this particular case will be a common occurrence. :D Good to keep for the books though.

Yes, I would have been very surprised if that had worked for you.

When you say you've tested all the hints from the docs, do you mean my Magisk troubleshooting guide? If so, take a look at the "Asking for help" and make sure to provide as much details as possible, if you want further assistance that is.
[Magisk] z1rqdym:
My magisk updated today and then the ctsProfile goes to flase and cant pass. Theb i go to the props and reset the hide props, after restert the phone i got this.

Device i use is Huawei PRA-LX1

MagiskHide Props Config v2.7.2

by Didgeridoohan @ XDA Developers

=====================================

The original prop values are not loaded,

possibly due to a full reset of the module,

or something has gone wrong.

Please reboot your device to reset.

If the issue persists after a reboot,

please report the issue, with logs!

Logs have automatically been saved

to your internal storage

(propslogs.tar.gz).

If the automatic collection failed,

please collect the logs manually.

See the documentation for details.

=====================================

Do you want to reboot now (y/n)?

Enter y(es) or n(o):

Logs are in the attachment.
[Magisk] Didgeridoohan:
[MENTION=7156250]z1rqdym[/MENTION] There's a bug with the reset option... I've already fixed it for the next release, but I have very little time to test the new features so it'll be a while yet before it's released. For now you can delete /data/adb/service.d/propsconf_late and reinstall the module to fix.
[Magisk] fredl99:
Me too. :)

But how could I know without trying?

It's always a good day for a surprise, isn't it? :D

Yes. Also I crawled Moto forums and it seems to be a common issue.

Since you stated that your module couldn't do much when BasicIntegrity fails, I didn't even think to bother you with logs and questions. That's why this discussion caught my attention.

I think I'll give it up with this device by now. All I need root hiding for is a banking app, which shall work from Android 4.4 on. [Great safety measures...] I will flash 4.4 on my older phone and use that solely for this.

Thank you anyway for your efforts! Maybe I'll try it again sometime in the future.
[Magisk] andrizmitnick:
when i try to change my device fingerprint to oneplus 5t 9.0, somehow it won't changed. already try multiple times, also disabling module-reboot-enabling-reboot and apply again, still doesn't change. need help. thanks

crdroid 9.0, oneplus 5t

update:

recently i just remove the module and install again, but when opening, it asks to reboot because "the original prop calues are not loaded", after reboot, somehow it asks for that again, showing same message endlessly even after 3 times
[Magisk] Didgeridoohan:
Impossible to know. Check out the documentation on how to get logs and we might give it a go to see if there's anything to do.
[Magisk] Didgeridoohan:
You can also try reinstalling the module (that particular problem can be fixed by that), but logs would be good....
[Magisk] andrizmitnick:
here's the log.

i've been reinstalling for 3 times but same result, stuck with "the original prop values are not loaded", rebooting doesn't work, been tried over than 5 times now, using different terminal doesn't affect anything. thanks before btw
[Magisk] paolocorpo:
Dear [MENTION=4667597]Didgeridoohan[/MENTION]

As I said I have applied with success your module on N5x with GZSoP pie ROM

I have discovered with certainty that your module causes that torch and camera apps didn't run: the apps are not able to be launched :(

If I disable your module .... all is OK

Do you have any idea why ?

Thanks

Paolo

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] Didgeridoohan:
The Magisk image is mounted after the post-fs-data boot script is executed, so the script doesn't run since it can't detect if the module is installed. And, the workaround for that, which I introduced in the last update doesn't seem to have kicked in either... I'll look into it, but at the moment it looks like you're out of luck (until I have an opportunity to work on the next release).

The only thing this module does is to run some boot scripts, magic mount a script to /system/xbin (or bin) and then changes prop values according to how you edit the settings. If all you've done is change the device fingerprint I don't see how that could cause such an issue...

If you can provide a logcat when the apps in question refuse to launch that might show something. The module logs might be interesting as well.
[Magisk] paolocorpo:
here the log of module

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] jenslody:
It might have a totally different cause, but:

some (many?,all?) (Pie?) roms have issues with camera and torch, when "do-not-disturb" is active and has touch-sounds disabled in its settings for sound and vibration.

Allowing touch sounds there or disabling dnd make it work.

Camera crashes with a crash-log like this one: https://del.dog/vawuhirobe

I did not (yet) find the root cause (or a workaround) for it, I will dig deeper into it, when I have more time.
[Magisk] andrizmitnick:
btw thanks before for your attention and help. but i finally managed to fix it, i think it was because my magisk installation was dirty or maybe because i'm using ianmacd magisk custom build. reflashing the official v18.0 works now.
[Magisk] Didgeridoohan:
And the logcat (which happens to be the one that's important)?
[Magisk] paolocorpo:
I have checked and this is not my root cause and I repeat: if I disable the module camera and torch come back to a correct functionality

Inviato dal mio Mi A1 utilizzando Tapatalk

---------- Post added at 06:41 AM ---------- Previous post was at 06:40 AM ----------

Dear developer,

You are right but I have before understand how to collect it ;)

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] Didgeridoohan:
I posted a link to you earlier that should help explain it.
[Magisk] paolocorpo:
Here is the log of tha app CAMERA when it refuses to start (if you need I can provide that one related to the torch as well)
[Magisk] skdubg:
after updating to latest canary magisk 18.1-d73127b1 the module doesn't work anymore
[Magisk] paolocorpo:
Firstable many thanks for your support

I am facing this issue (with camera and torch) immediately after I install the module (it is not necessary to use it editing the fingerprint file ...)

I have already asked into related ROM thread but there are not other users on the same page ... :(

So ... I am obliged for a while to disable your module ... (Sigh) Because as you can imagine the camera and torch are two apps extremely relevant for my wife ;)

Ciao

Paolo

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] Didgeridoohan:
Hard to say, but it looks like the boot stages are messed up on your device. I'm actually seeing the same thing on my device with the latest Canary (18006), so it might be a Magisk thing. I have zero opportunities to look closer into that for the next few days though, so I'll just mention that to [MENTION=4470081]topjohnwu[/MENTION] and see if there's anything going on.
[Magisk] skdubg:
thanks for replying.

after downgrade to magisk 18.0 it works again :eek:
[Magisk] Didgeridoohan:
Yes, there might be an issue with Canary 18006 so it should be enough to revert to Canary 18005.
[Magisk] martyfender:
I'm glad to see that I am not the only one having issues with the latest Canary (18006). I reported and posted logs in that thread.

[MENTION=4667597]Didgeridoohan[/MENTION] Today's Canary build appears to fix all of the issues I had with the previous build. I am just curious what results you have with it?

Thanks
[Magisk] astrit1:
Could you add the Galaxy A5(A500FU) from 2015 to the list

Here ist the fingerprint which works if used as custom

Samsung Galaxy A5=samsung/a5ultexx/a5ulte:6.0.1/MMB29M/A500FUXXU1CPH3:user/release-keys
[Magisk] zacshawn:
[MENTION=4667597]Didgeridoohan[/MENTION],

After long time not update module (use 2.3.5-v23), yesterday update to last version, but unfortunately it didn't passed for safetynet. Ctsprofile false, when basic integrity still true.

Try to reset to default status and rebooted.

Applying fingerprint with my custom fingerprint and reboot.

After boot screen and phone is up shows warning like in screenshot

I don't know what happen cause in your old version it works well. When I deactivate fingerprint everything is ok.

I'm using custom room miui 9 with Android 5.1.1.

I attached proplogs when you need it.

Thank you
[Magisk] martyfender:
There may be something wrong with the archive you posted. when I download it on my linux mint system and try to open it, it is empty.
[Magisk] jenslody:
Latest canary build partially break this module, it's known and will surely be worked as soon as possible.

See:

https://xdaforums.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337/post78739301
[Magisk] zacshawn:
I collect it from module, i don't know if it empty. I try again and archive still empty. How can i collect it manually?
[Magisk] martyfender:
I responded here with my experiences with it on the latest Canary on 2 devices, one working and one not:

https://xdaforums.com/showpost.php?p=78739445&postcount=568
[Magisk] joluke:
On version 2.7.2 in Oreo 8.0.0 on Note 8 N950F with Magisk 18.1 r17 and from r13 I'm getting errors on Terminal that the default values could not be loaded.

Already tried doing a clean install on Magisk and the same happens for some reason.

Here are the logs: https://www.dropbox.com/s/lkjmtzl57ove1mz/propslogs.tar.gz?dl=0

Enviado do meu SM-N950F através do Tapatalk
[Magisk] Didgeridoohan:
With r13 and r17 I'm assuming you're talking about the unofficial builds. There's been a change in Magisk in the last few days that break the module. If you're on a build made after January 20 it'll be broken. In a way it's a good thing, because it's gonna force me to do some cleaning up I've been putting off. But, with my current IRL situation it's gonna be a while yet before I can get a new release out...
[Magisk] hyborian:
Thanks, at least the banking and other payment apps still work even with cts failing, Magisk is hiding well.
[Magisk] joluke:
Real life comes first! Hope everything goes well. The module and the xda community can wait :)

Enviado do meu SM-N950F através do Tapatalk
[Magisk] Nebrassy:
Mi A2 Pie January patch

xiaomi/jasmine/jasmine_sprout:9/PKQ1.180904.001/V10.0.3.0.PDIMIXM:user/release-keys

2019-01-05
[Magisk] Mehdih34:
[MENTION=4667597]Didgeridoohan[/MENTION] how to enable improve hiding.

Currently runing miui 10, China stable on xiaomi mi 8.
[Magisk] Didgeridoohan:
I'm going to assume that you're talking about this:

https://github.com/Magisk-Modules-R...ter/README.md#an-option-is-marked-as-disabled
[Magisk] Mehdih34:
Yes, my improve hiding option is disabled in Red colour. [MENTION=4667597]Didgeridoohan[/MENTION]
[Magisk] Didgeridoohan:
Did you check the link I posted? That simply means your device has no need for that particular option.
[Magisk] Mehdih34:
I still have cts false. What should I do?
[Magisk] Didgeridoohan:
That option has nothing to do with CTS. If you have set a certified fingerprint with the module and you still can't pass, there's (obviously) something wrong. Might be a number of reasons... There's some stuff covered in the documentation: https://github.com/Magisk-Modules-Repo/MagiskHidePropsConf/blob/master/README.md#issues-support-etc

But, number one reason at the moment would be this: https://xdaforums.com/showpost.php?p=78742107&postcount=1306
[Magisk] martyfender:
As you may recall I have 5 Nextbook Ares 8A's, x86, Android 6.0.1.

On 2 devices I have the latest Canary debug builds, on 2 I have [MENTION=3306843]kantjer[/MENTION] latest r17 and 1 on [MENTION=7187684]ianmacd[/MENTION] latest unofficial build.

On 4 of them I already had your module installed and it appears to function properly on them after updating to the latest builds.

On one of the Canary devices, which had the rom reinstalled last week, I didn't have your module installed. I installed it and there are no errors in the install log but there is the error when I run props in the root teminal. It is the standard one about props not loaded, wanting one to reboot. I will later attach the log it created. Maybe this will help you fix it when you have time? I don't know if it is of any use, but I have attached a logcat, as well.

Thanks
[Magisk] Mehdih34:
I will have to wait then.
[Magisk] jenslody:
That's exactly the issue due to the changes in latest canary Magisk.
[Magisk] martyfender:
On that one device where Magisk Hide Props Config was not installed, I uninstalled the module, rebooted, then rebooted to twrp, installed an older Canary build, rebooted again, then reinstalled the module and confirmed that it worked. I then once again rebooted to twrp, installed the latest Canary 18007, then again rebooted and the module now works on that device, like the others and I can change the fingerprint to the one x86 device in the list, other than mine and it passes safety net, also.

Logs attached after I did all of this.