yashsingh1/xdaforums huggingface dataset:
[Magisk] lepicane1:
There is a thread about the Santander app not working and a solution using AdAway to block outgoing calls to certain domains, which also works for the Halifax app. Unfortunately doesn't work for me...Give it a try.
[Magisk] L22EEW:
Thanks for the info, bit of a needle in a haystack. Not sure what to search for on XDA ... any hints on where the XDA thread may be?

:D
[Magisk] lepicane1:
Just Google Makisk Santander. Should be the first result.

https://xdaforums.com/apps/magisk/santander-app-custom-rom-root-device-t3794753
[Magisk] L22EEW:
Found it, thank you.

So I have followed the suggestions here https://xdaforums.com/showpost.php?p=77350020&postcount=110, adding those addresses to AdAway. Saved, and rebooted phone. Cleared Cache and Data in Halifax app. Logged in to the Halifax app, and it's taken me to the next stage, it then completed the log-in (Phew)

For now, I seem to have figured it out (with your help!). Let's hope this sticks.
[Magisk] Didgeridoohan:
If you can provide the module logs I might be able to take a look at it. Check the module documentation on how to get them.

https://xdaforums.com/showpost.php?p=77705848&postcount=768
[Magisk] martyfender:
Did you hide the Magisk Manager itself, disable USB debugging and developer options?
[Magisk] L22EEW:
Did you hide the Magisk Manager itself - Yes,

Disable USB debugging and developer options - not needed.

As I managed to fix the issue by taking the info from this post -> https://xdaforums.com/showpost.php?p=77707342&postcount=776

I'm not sure if I stumbled upon luck. However when I did add those domains/addresses into my AdGaurd app (black list) from this post->https://xdaforums.com/showpost.php?p=77350020&postcount=110 - I was finally able to log into the banking app (avoiding that dreaded "Your device have been jailbroken/rooted...") Example image below:

[IMG="Example"]http://i.imgur.com/5CAHuCR.jpg[/IMG]
[Magisk] Seagold:
Go to your magisk manager to enable hide root for the app
[Magisk] L22EEW:
Hello.

I think you've misread my reply.

The issue has be resolved ?
[Magisk] prabhatpatel93:
Unable to pass the safety net as well as basic integrity.

Unable to pass the safety net, cts profile as well as basic integrity. Please help
[Magisk] prabhatpatel93:
Unable to my solution in this link.

Unable to find the solution in the above link as I am unaware of such coding stuff.
[Magisk] Didgeridoohan:
Interesting... I'll add an option for that in the module. Thank you so much!
[Magisk] Jvirg:
I confirm that this method passes safetynet and playstore shows device as certified. Unfortunately I still can get the latest version of Netflix. Always says not compatible with my device.
[Magisk] whiplash1:
That means your ROM probably needs the widevine DRM patch.
[Magisk] Jvirg:
Where would i get that from?
[Magisk] whiplash1:
Reach out to the ROM devs
[Magisk] Jvirg:
He said "The ROM has always had widevine DRM support."
[Magisk] Didgeridoohan:
You guys are getting a bit off topic here... This module has done it's thing and you're now passing SafetyNet.

There are a number of things that can mess up Netflix, so I would ask around in your device forum or your ROM thread. But please keep it on topic in here... :good:
[Magisk] Fahrilubis:
Where is /magisk? How can i find it
[Magisk] Didgeridoohan:
There's no /magisk symlink to the mount point anymore (from Magisk v16.3). The proper location is /sbin/.core/img.

Or, wait a few hours until I've tested the new option to change when props are applied.
[Magisk] Fahrilubis:
Im used magisk 16.4 its recommended for pass safety net to used 16.3? Then i dont know in configuration section...
[Magisk] russel5:
I don't used 16.4 because I can't pass CTS profile, use stable version 16.0
[Magisk] skullkid383:
Really cause 16.4 passes fine on my moto e4 with correct fingerprint
[Magisk] Jvirg:
Deleted
[Magisk] russel5:
One more request - add resetprop for ro.vendor.build.fingerprint

If this value is not reset some module like Sony app enable not work, because Google play market check this value too. Thanks
[Magisk] Didgeridoohan:
I already change that prop. Is it not applying for you?
[Magisk] russel5:
Nope, this value is not changed
[Magisk] Didgeridoohan:
Probably has to do with the timing thing of post-fs-data vs late_start service. I'm working on improving that and currently finishing up some tests. Meanwhile, could you post your propsconf.log and propsconf_last.log, just to check?
[Magisk] NE0HP:
Thank you [MENTION=4667597]Didgeridoohan[/MENTION] for this module. After flashing Pixel Experience GSI on my device Mido, ctsProfile was showing false and play store showing device uncertified. But after flashing the module and after following usage guide, it just works and now both Play Store is certified and ctsProfile is showing true. Thanks also to [MENTION=6343462]whiplash1[/MENTION] for sharing this thread link to me at this thread here. https://xdaforums.com/project-trebl.../8-1-0-pixel-experience-t3796011/post76652322
[Magisk] Didgeridoohan:
Update to 2.2.0-v17

Module's been updated with some improvements that should help with props (fingerprint and custom props) not being set properly for some users (mainly on LOS 15.1). It is now possible to move this part of the module to an earlier stage in the boot process (post-fs-data rather than late_start service) and this should hopefully fix any timing issues with setting the props (resulting in ctsProfile staying false). Just go to the script settings (see the documentation for more details) and change the boot stage to "post-fs-data" if you can't get the ctsProfile to pass after using the module. Thank you to [MENTION=4688377]russel5[/MENTION] for figuring this out.

[MENTION=8524512]Semela[/MENTION] I've also included a new fingerprint for the Mi Max 2 in the fingerprints list. You might want to try it out.

Changelog:

v2.2.0

Added an option to set prop values earlier in the boot process.

Moved module setup from post-fs-data.sh to post-fs-data.d.

Fixed installing module on a fresh Magisk install.

Fixed restoring the boot scripts during post-fs-data boot stage.

Updated and added some new fingerprints (Google Pixel 2 XL, Huawei Honor 9, Samsung Galaxy J5 and Note 8, Xiaomi Mi A1, Mi Max 2 and Redmi Note 5 Pro), list v17. Thank you to [MENTION=8854405]CGA_d3[/MENTION], [MENTION=7530018]oslo83[/MENTION], [MENTION=5984889]Past2Present[/MENTION], [MENTION=4048340]Kapiljhajhria[/MENTION], [MENTION=7166349]turbolukex5[/MENTION] for providing fingerprints.

As usual, a bunch of improvements. They'll likely not harm any kittens, but might break the module.
[Magisk] moneyrain:
It tried to install but it failed to mount magisk-mergr.img
[Magisk] Didgeridoohan:
What do you mean "coding stuff"? That's the link to the documentation and troubleshooting tips to possibly solve your issue. No coding involved...
[Magisk] prabhatpatel93:
Sorry I didn't mean that,, But I have tried according to the documentation but the safety net test fails as well as the playstore isn't certified.
[Magisk] Didgeridoohan:
If you've gone through everything in the troubleshooting guide (that's linked in there), made sure you've got the basics covered, read though the SafetyNet part, etc, then there's probably not much to do...

Except, you can always try to ask for help in the General support thread (this is not the place and I don't really have the time), but make sure to provide lots of details and logs.
[Magisk] Felix Siahaan:
Hi [MENTION=4667597]Didgeridoohan[/MENTION],

Please help to update Redmi Note 5 Pro (8.1.0) fingerprint to:

xiaomi/whyred/whyred:8.1.0/OPM1.171019.011/V10.0.1.0.OEIMIFH:user/release-keys

Already tested on my device, both ctsProfile & basicIntegrity passed.

Thanks...
[Magisk] VincentJoshuaET:
What ROM did you test? Because on Global Betas/China ROMs/AOSP-based ROMs, the 9.5.11.0 is the latest one guaranteed to work.
[Magisk] Didgeridoohan:
Fingerprints list updated to v30

Finally had a bit of time to update the fingerprints list with the new prints you guys have provided. I've gone through and tested them all and the ones that could pass CTS on my test device have been added to the list.

Fingerprints list v30

The list will update when you run the props script, unless you've turned off automatic updates in which case you can use the -f flag or update in the Fingerprints menu.

Added prints:

LG G2

Motorola Moto E4 Plus

Sony Xperia Z5 Premium and Premium Dual

Updated prints:

Google Pixel, Pixel XL, Pixel 2 and Pixel 2 XL

OnePlus 6

Xiaomi Redmi Note 5 Pro

About the Xiaomi Redmi Note 5 Pro, I'm using V9.5.11.0 since it's been reported to work on most devices and it was the one that passed on my device (V10.0.1.0 did not).

Huge thanks to those that provide prints. Keep 'em coming! :good:
[Magisk] Sebacestmoi:
Hi,

I'm a long time user of Android and Magisk and I've got a problem with a banking app called Twint BCV which is a swiss bank app that detect root and refuse to be used.

Here is the link to the Play Store if it can help : https://play.google.com/store/apps/details?id=ch.bcv.twint

I've got a Nexus 6P with the latest official ROM 8.1 September security. My phone pass the SafetyNet without any problem and my device is certified in the Play Store. I use Masgik Hide for a lot of apps including this one and they all work except this one.

So I'v seen this Magisk Module and I'm trying to understand how I can use it without causing any mess to my device to try to use my app again.

Basically I've installed the module, downloaded the propsconf_conf, changed nothing inside except CONFPROPFILES to true.

If I put it in /cache and reboot my phone I should be good to make a try with app again ? Is there anything more I need to do ?

I would gladly pay a beer for anyone that can help me use my app again.

Kind regards
[Magisk] Didgeridoohan:
[MENTION=261480]Sebacestmoi[/MENTION] There's very little chance of messing up your device with the module, so don't worry. It won't do you any good either though. You're passing SafetyNet and since you're using the stock N6P ROM you won't have any use of the improved hiding either, so don't bother.

Best I can do is to link you to my Magisk troubleshooting guide. Some good tips on hiding root there:

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot
[Magisk] puturaya20:
Still issue ctsprofile Xiaomi devices (MIUI)
[Magisk] Didgeridoohan:
Yes, that's one of the known issues listed in the OP... :good:
[Magisk] Sebacestmoi:
Hi,

Thank you for answering me !

I've followed your guide and found that it looks for the root that can be hided by the standard Magisk Hide feature and for the Magisk Manager app even if I rename it with APK Editor. So for now I've resolved my problem by uninstalling the Managisk Manager but keeping the root and the Magisk hide settings and it works. Would love to find a way to keep it in the future.

Thank you for the help
[Magisk] Didgeridoohan:
Just out of curiosity: you've hidden (repackaged) the Magisk Manager and also tried changing the app name, but the app still detects the Manager? If so it's probably looking for some of the classes that are partly obfuscated in Manager v6.0.0. Obfuscation will be 100% in a later release...
[Magisk] Vuska:
Hiks.. its really hard to understand what to do.

already installed it..

but dont know what to do next.

Op6 Pie stable... with magisk 17.3

any easy step by step to do please?
[Magisk] Sebacestmoi:
Exactly, I've even tried name that have noting in common with Magisk like ABC but it didn't work. But even when I used the ABC name Substratum theme engine was detecting that Magisk Manager have been installed so is there another way for them to recognize the app ? I don't know, it's beyond my Android knowledge.
[Magisk] Didgeridoohan:
The documentation is pretty extensive, found here:

https://github.com/Magisk-Modules-Repo/MagiskHide-Props-Config/blob/master/README.md

But, I've tried you make the ui as user friendly as possible. Just install a terminal emulator, run the command "props" and explore the options.
[Magisk] Vuska:
Thank you...

already try...

it work... but my bank and internet provider app still detect it rooted..

Already check it in magisk hide, 3 days ago it still work.
[Magisk] robbayani:
buy another cheap phone specially for banking apps :D

dont unlock bootloader, dont root, dont using any root apps(like LP etc), dont have folder or file with name "Magisk" and etc..

because very confusing and need time for practicing & trying any method for hiding apps bank..
[Magisk] russel5:
Bro, why you are not update fingerprint for XZ1 Compact?
[Magisk] Didgeridoohan:
From the same post you quoted:

And from the OP:
[Magisk] russel5:
This is strange because my old fingerprint for this device and XZ1 you added.

Stock rom and only magisk without modules
[Magisk] Didgeridoohan:
I double checked. The fingerprint I already have works, the updated one you provided doesn't...
[Magisk] raystef66:
[MENTION=4667597]Didgeridoohan[/MENTION]

Just to confirm again that this is working flawless on Axon7. Using Termux

su props
props
choose...

I did use it multiple times by now on multiple Pie (s)GSI roms with latest magisk version/manager.

Nice work ! And again thnx for all the help in the past :good:
[Magisk] kkolokol:
Just a question: doing custom prop values change for ro.vendor.audio.sdk.fluencetype to fluence from none - I do not see changes in the build.prop file, it is still none after reboot. Why? Thanks.
[Magisk] VincentJoshuaET:
It will not modify build.prop, it will just override the values that are included there.

The proper way to check if the prop was set properly is to execute getprop ro.vendor.audio.sdk.fluencetype
[Magisk] kkolokol:
Got it. Checked - it is with getprop. Thanks.
[Magisk] jouid33:
Dears my device is blocked from using gapps and i want to use this method to but I am concerned that just as Google blocked my device they will block my email account, what do you guys think?
[Magisk] Didgeridoohan:
That's unlikely...
[Magisk] ShidqyRR:
Why when i put props command, the list not show Up

Sorry for bad English
[Magisk] awl14:
Issue with /system/bin/id in some ROMs not supporting "-u"

Hello [MENTION=4667597]Didgeridoohan[/MENTION],

first of all, thanks a million for your great Magisk module! :good:

I am using it on an Elephone P6000 Pro running my self-compiled Lineage 12.1 build (https://xdaforums.com/showpost.php?p=75295581&postcount=145 or https://bbs.elephone.hk/forum.php?mod=viewthread&tid=14156&fromuid=97621) and have run into an issue with more recent versions of your module that causes the "props" UI to be completely hung:

Either Lineage 12.1 or possibly even the "proprietary/vendor" binaries from the original stock ROM do contain a statically linked "/system/bin/uid" command that does not accept the option "-u" to return only the uid of the current user. It rather reacts in the following way:

shell@p6000_pro:/ $ id -u
uid=2000(shell) gid=2000(shell) groups=1004(input),1007(log),1011(adb),1015(sdcard_rw),1028(sdcard_r),3001(net_bt_admin),3002(net_bt),3003(inet),3006(net_bw_stats) context=u:r:shell:s0

root@p6000_pro:/ # id -u
uid=0(root) gid=0(root) context=u:r:magisk:s0

which unfortunately takes precedence over the busybox "id" command and makes both the props and the util_functions.sh scripts break when testing

if [ "$(id -u)" != 0 ] ; then

whether the current user has root privileges.

Can you please change this to either always only use the "id" command that comes with busybox (rather than the one that comes with the phone/ROM) - probably the best fix for the issue -, or otherwise not use an "id" binary at all and rather look at one of the shell environment variables that contain the current user name or user id ($USER, $USER_ID, $KSHUID, ...)?

Many thanks for fixing this minor issue & best regards :)

awl14
[Magisk] Didgeridoohan:
No idea... You'll have to be a bit more specific. And if possible provide the module logs: https://github.com/Magisk-Modules-Repo/MagiskHidePropsConf#logs

Look at that... I'll certainly look at finding a better way. Thanks for reporting.
[Magisk] jcmm11:
You should be able to register your device with Google to unblock it. You'll have to search to find the registration page, I don't know it off the top of my head.
[Magisk] ShidqyRR:
Blank
[Magisk] jcmm11:
Just a note:

$USER won't work, it seems to keep the parent value even if you're root.

$USER_ID and $KSHUID work as long as you're using the default Android shell, but if you reference them in TWRP (for example) they'll be undefined.

What should work in all cases is something like:

userid=$(id -u)
echo $userid|grep -q uid
if [ $? = 0 ]
then
userid=$(echo $userid|cut -f1 -d' '|cut -f2 -d'='|cut -f1 -d'(')
fi
[Magisk] jenslody:
If the internal busybox of this module and the internal busybox of Magisk work consistently, it would be most secure to use them. One of them should always be there, no matter if we are in TWRP on a fresh install or in a running android.
[Magisk] Jaymin.0.1910:
I think

if id | grep '^uid=0' >/dev/null; then
echo "I am root"
fi

will do the job well.
[Magisk] harshal2234:
So can it be used in Moto g4 plus too even though it's not mentioned here
[Magisk] jouid33:
thats a negative I followed the steps and contacted them but they refused to help on the very on issue that they made !

https://productforums.google.com/forum/?noredirect=true#!topic/play/VuWWw977Qmo
[Magisk] Didgeridoohan:
Dude... Don't ask Google for advice on how to use a method that circumvents their security measures... :eek: I'm pretty sure they know about this stuff already, but that's a proper facepalm moment.
[Magisk] jouid33:
damn it I bet thats what the google employee did when he read my question,,,

sorry for this mistake but I'm really in a messed up situation and shooting everywhere,,, again sorry and if there is anything I can do to fix this I'm totally ready
[Magisk] awl14:
Looks like you are running into the exact same issue that I reported yesterday: stock ROMs or Lineage ROMs built-in "id -u" not returning a number as expected, but rather a string, which causes exactly the type of hang that you have.

HTH,

awl14
[Magisk] Didgeridoohan:
Don't sweat it... Like I said, I'm pretty sure Google keeps track of what's going on here at XDA. Not much to do about it.

It very likely is the same. It's a quick fix, so I'll try to push a small update in a few hours (hopefully I'll get an opportunity).
[Magisk] Didgeridoohan:
Update to v2.4.2

A quick and simple update to fix an issue with root detection. Hopefully it should work better now.

[MENTION=6823720]awl14[/MENTION] and [MENTION=8735693]ShidqyRR[/MENTION] please update and test.

Changelog

v2.4.2

Small update to the root detection logic. Should fix issues on devices with a broken id command.
[Magisk] awl14:
Many thanks, [MENTION=4667597]Didgeridoohan[/MENTION], for the quick update. Much appreciated! :)

Small good news: The complete hang no longer occurs. But also bad news: At least for me, v2.4.2-v30 does still cause issues :(

/system/xbin/props: /sbin/.core/img/MagiskHidePropsConf/util_functions.sh[1130]: [: gid=0(root): unexpected operator/operand
/system/xbin/props: /sbin/.core/img/MagiskHidePropsConf/util_functions.sh[1132]: [: gid=0(root): unexpected operator/operand
/system/xbin/props[80]: [: gid=0(root): unexpected operator/operand
/system/xbin/props[2026]: [: gid=0(root): unexpected operator/operand
/system/xbin/props[2198]: [: gid=0(root): unexpected operator/operand

Please note that in util_functions.sh, in log_handler, the code for me even after the update still reads

log_handler() {
if [ $(id -u) == 0 ] ; then
echo "" >> $LOGFILE 2>&1
echo -e "$(date +"%m-%d-%Y %H:%M:%S") - $1" >> $LOGFILE 2>&1
fi
}

As stated before, on affected devices, "id -u" does NOT return an integer, but the same string that "id" (without parameters) returns, so if you want to stay with the numeric comparison, I think you need to explicitly call the busybox "id" command by its absolute file name/path rather than the one from the stock ROM from the search path/PATH variable (which unfortunately comes first in the PATH variable).

Sorry that I don't have better news & many thanks in advance for your help

awl14
[Magisk] Didgeridoohan:
D'oh! Completely forgot that I was using id -u there as well. That's easier to fix though and I'll take care of that soon. Thanks for testing and reporting.
[Magisk] DidierMoulin:
Hello,

thanks for your work!

Before flashing another rom I stumbled upon your request to read the key... Heres what the LG G5 h850 on newest Stock Oreo 8.0 returned:

lge/h1_global_com/h1:8.0.0/OPR1.170623.032/182532053d3a3:user/release-keys

Magisk is installed, I hope that's fine.

Didier
[Magisk] Didgeridoohan:
Udate to v2.4.3-v30

Ok... Note to self: don't push out releases at midnight, working from your phone while trying to entertain/put to sleep a 3 week old baby. You will forget stuff... :D

This release should hopefully make the module work for my good friend [MENTION=6823720]awl14[/MENTION]. Thank you for great bug reports and please let me know if you find more issues. If they're as easy to fix as the su detection I'll probably be able to take care of them quite quickly.

Changelog

v2.4.3

Another small update, fixing my bad memory (I wish).
[Magisk] starcms:
Does anyone have the fingerprint for the latest (October) version of the Pixel 2 or Pixel 2 XL? Much thanks!!
[Magisk] Didgeridoohan:
Why do you need that specific fingerprint? As long as it's certified you can use whatever fingerprint, it doesn't have to be the latest... The September fingerprint is included in the module and should work absolutely fine.

If it's absolutely imperative that you have the October fingerprint, take a look here:

https://desktop.firmware.mobi/

That's sometimes a pretty good source for fingerprints, especially for the Pixel devices...
[Magisk] starcms:
You obviously understand this alot more than me, so I'll tell you the situation and you tell me what you think.

I have an Essential phone. It literally has the same system.img as a Pixel 2 XL (I could flash system.img from the Pixel 2 XL Google image download and it would work perfectly). This is obviously partly because of Project Treble, but also because the phones run the same (or basically the same) system.img. You can't do this with any other Project Treble phone....and have it work perfectly that is, if at all :)

I'm using your Magisk module to trick ARCore 1.5 that I have a Pixel 2 XL so that it will work (the Essential isn't supposed by ARCore for whatever reason). So by changing my fingerprint to the P2XL, ARCore 1.5 (which checks only the fingerprint to determine device, not model, manuf, etc) along with ARStickers work perfectly. The AR Measure app that depends on ARCore also works perfectly.

This is where things get odd. If I'm using for example the latest October Pie update from Essential with the Pixel 2 XL fingerprint that is included in the module from September (or any other month but matching, in this case October), I pass basic integrity but fail CTSprofile in SafetyNet. So if the Essential build and the Pixel 2 fingerprint aren't both from the same month, I fail CTSprofile.

Before I saw your reply with the link to find fingerprints, I pulled the one from the October Pie image from Google for the Pixel 2 XL, made the file in my main storage so it would appear in the module, applied the October Pixel 2 XL fingerprint, rebooted, and now I'm passing both basic integrity and CTSprofile (I had to do the same last month when I upgraded my Essential to September, but at that time, the fingerprint in the module for the P2XL was from August).

I've read all the documentation and it seems there is no reason why the months would have to match (I'm running the Essential Stock Pie ROM, rooted with Magisk) and that any fingerprint should work. Luckily it's easy to get them to match the same month, but do you have any idea why that is required to pass CTSprofile?

Thanks and tyvm for the module!

Edit: And that link is fantastic! Thanks again!