yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
This module will only help you pass SafetyNet, which it has done. The rest is a topic for this thread: https://xdaforums.com/apps/magisk/discussion-google-pay-magisk-discussion-t3906703
[Magisk] esi2121:
i had same problem with hide props , but i change props from s6 to pixel3 and after reboot got boot loop
[Magisk] Didgeridoohan:
Could you provide logs? And device details...

Edit: logs from the current Canary debug build, that is.
[Magisk] Didgeridoohan:
I finally got around to testing a bunch of submitted fingerprints and this one does not pass CTS. Probably because I don't have the corresponding security patch date that goes with it. If you could also provide that I can add it to the list.
[Magisk] Didgeridoohan:
Update to v3.5.0-v49

It's about time for an update... There was a few bugs laying around since the last release that I finally got around to fixing. I also made some optimisations to how props are set during boot and a bunch of other stuff. One cool new feature is that there can now be several versions of a device's fingerprint, one for each Android version (thanks to [MENTION=7927349].:B:.[/MENTION] for the idea).

There are also a few new and updated fingerprints. Thanks to [MENTION=7530018]oslo83[/MENTION], [MENTION=5790692]timjosten[/MENTION], [MENTION=8939500]Saison2018[/MENTION], [MENTION=5685876]pekkle_hksar[/MENTION] and [MENTION=9637474]michaelmaverick[/MENTION] for providing them.

This is hopefully (unless I have messed something up, which is very likely) the last release before the next Magisk version which will also bring a new module template.

Changelog:

v3.5.0

Added ro.build.version.sdk to the device simulation props (see the documentation for details).

Updated editing the device fingerprint feature so that fingerprints for different Android versions can be added to the fingerprints list and the user can pick the desired one when applying a new fingerprint (see the documentation for details). Several fingerprints have been updated with dual fingerprints.

Updated and optimised when props are set during boot. Uses Magisk's system.prop function by default, rather than post-fs-data, to avoid putting a strain on the system during boot. At what boot stage props are set can of course be completely configured by the user (see the documentation for details).

Updated the configuration file to match current settings (see the documentation for details). Update your personal files to match.

Fixed a bug where the props file wouldn't get the proper permissions when using the configuration file on a clean install.

Fixed a bug where saving the simulation value for ro.build.version.incremental would give a wrong vaule.

Fixed an infinite loop bug if making an invalid choice when asked to reboot.

Optimised and cleaned up some code here and there.

Updated the fingerprints list. Added Asus Zenfone Max Pro M1 and Huawei Honor 8X to the list, and updated Huawei Honor 9, P20 Pro and Xiaomi Mi 8 and Mi Mix 2S. List updated to v49.
[Magisk] arddy1:
Redmi Note 5 pro cts profile gets false in v 3.5. Revert back to v 3.0.3, gets true again. Using listed fingerprint.
[Magisk] Didgeridoohan:
If you could provide the logs from v3.5.0 I would have a chance to fix any possible issues...

Edit: I have of course tested updating from v3.0.3 to v3.5.0 on my devices and there were no issues so unless I get some further input there's nothing I can do.
[Magisk] JarlPenguin:
February 1st 2019 patch.
[Magisk] bitye:
Used module for a longer time without any issues. Now I had no problems with V48 and I just updated it in magisk manager and my phone turned into bootloop.

Tried to flash back V48 in TWRP but it still bootloop. Any way "not remove magisk" to solve it fast?

This:

Place a file named reset_mhpc in /cache (or /data/cache on A/B devices) and reboot.

Never worked on Pocophone F1

Update: I try to boot for 10+ minutes now after flashed magisk uninstaller and still nothing just Loading...

Update: Magisk removal also not worked anymore, wiped system and reinstalling it now.
[Magisk] Didgeridoohan:
I've never had a single report about the reset file not working... But, since you found that information you should also have seen this link for info on how to manually remove a module:

https://www.didgeridoohan.com/magis...agisk_functionality_bootloop_loss_of_root_etc

But, that seems to be too late...

If you've removed Magisk and you're still having issues it is unlikely that the issue is (directly) Magisk related. Was your device encrypted or not? If not, the "bootloop" you're experiencing is likely the device encrypting itself since you restored the stock boot image when uninstalling Magisk.

The only way for me to know for sure what's going on is of you can provide logs, but sadly that will also be limited now.

https://github.com/Magisk-Modules-R...lob/master/README.md#collecting-logs-manually
[Magisk] bitye:
I am using DFE 18.1, I have no idea what happened at all, I accidentally updated the module in magisk, I usually just update automatically when run props. Now waiting for boot no idea what happened, I will check everything for next time. But I have no idea what happened as it seems it killed my data partition as I can't boot after a wipe / clean flash with keep data and all I did is to update V48 to V49 in magisk between the 2 boots.
[Magisk] hyborian:
After reading Bitye's post, I made a Nandroid backup first just in case. No problems on my Poco f1 after updating though, smooth as silk. I never set up phone to be encrypted though, and never ever run DFE.
[Magisk] bitye:
I am sure it's related to magisk+dfe18.1 as I had to format data to boot. New version works as charm after clean install.
[Magisk] dijeypee:
I need help :( i uploaded my log

I think i have a problem with service.sh
[Magisk] Didgeridoohan:
Hm... The Magisk log wasn't included there. Could you please upload that as well.
[Magisk] dijeypee:
Oh sorry here you goo
[Magisk] Didgeridoohan:
Don't worry... That wasn't your fault. The module script should have bundled it up with the rest of the logs, but didn't.

Unfortunately I see absolutely no reason in the logs for why the service.sh script wouldn't run. It is actually executed by Magisk, but for some reason does not do what it's supposed to. Only way for me to know more about what is going on is if you can install the Canary debug build and provide the Magisk log from that. First you could try reinstalling the module though (just install again over the existing installation). I don't think it will make any difference, but it's worth a shot and at the same time you can save the installation log and upload that as well.
[Magisk] Saison2018:
On my P20 Pro with Magisk 18122, I got bootloop this morning after updating to 3.5.0 v49.

I got my phone back but not sure how (tried too many buttons scenarios) but I landed in eRecovery and my phone reboot without Magisk installed.

I will try to install Magisk again and install latest module version and see if OK or not. (I do not have access to my pc right now)

Will keep you inform
[Magisk] Didgeridoohan:
Hm....

Can't be a coincidence that there's so many reports of issues. I'm going to need logs though, because I cannot reproduce any issues on my side.

I'll scan through the update to see if I can spot anything, but that might take some time.
[Magisk] Nebrassy:
Check if there's anything to do with keymaster, it might be the issue I PMed you about earlier

Actually nevermind, it can't be that if it was working earlier
[Magisk] Saison2018:
I need to find a way to remove modules without root. I tried to root again (version 18122) and I started to bootloop immediately.

Will keep you inform
[Magisk] Saison2018:
So after many tests, I was able to be rooted again and boot my P20 Pro without modules by placing the file ".disable_magisk" in "/cache" folder.

After that, I was able to remove lastest version (3.5.0-v49) and install previous version of your modules (3.0.3-v48) and change my fingerprint. Seems OK so far.

I will wait few days before trying to upgrade again, I need my phone (will be on the road)

EDIT: Do not know where to start, Magisk says SafetyNet is OK (both ctsProfile and basicIntegrity) with my fingerprint, but Google Pay refuse to activate my card because my phone is rooted or modified.

I have already tried to reset application and add/remove Google Pay from Magisk hide list. Any advise/help will be appreciated.
[Magisk] Didgeridoohan:
I really wish that you had tried to save the logs in /cache before downgrading... Could have showed me what's actually going on. It might not be too late though. If you haven't rebooted more after getting everything set up again, the magisk.log.bak and propsconf_last.log files just might show what I need. Could you please provide those?

This module has done it's job by helping you pass SafetyNet. Gpay might require more... There's a dedicated thread for discussing that: https://xdaforums.com/apps/magisk/discussion-google-pay-magisk-discussion-t3906703
[Magisk] martyfender:
[MENTION=4667597]Didgeridoohan[/MENTION] I just wanted to report that on my Nextbook Ares 8A, x86, Android 6.0.1 tablets, I have not faced any issues that others have experienced with this module. I have not tried changing the fingerprint or other settings yet, but with the update and checking in the terminal, all seems normal.

Thanks
[Magisk] pekkle_hksar:
Mi 8 have 2 fingerprints available. However, whatever I choose, it sticks to the fingerprint of Oreo after reboot. Is it normal?
[Magisk] interestingkid:
https://play.google.com/store/apps/details?id=com.kakaobank.channel

This is a banking app that I use in Korea and since the latest update, magiskhide only works if I don't install a custom kernel on my n960n (note 9 Korean variant, CSC1 stock ROM)

Would this module be able to help with this problem?
[Magisk] Didgeridoohan:
Logs?

Probably not...
[Magisk] pekkle_hksar:
Please ignore my problem, seems setting messed up by previous version.

After reset setting and setup fingerprint again, it works like a charm.
[Magisk] DerSteppo:
I am using the newest FW on my Xperia XZ1 Compact, which is 47.2.A.10.28. In the list of supported devices is a lower version of the finger print for Pie. Is that a problem or should I be able to use it? I tried but then the phone did not boot up after restart. Maybe I am doing something wrong?
[Magisk] Didgeridoohan:
It should not be a problem, but since you can't boot up something's obviously going on.

Before you do anything else, please collect and post the logs found in /cache (details here: https://github.com/Magisk-Modules-R...lob/master/README.md#collecting-logs-manually). You can likely grab them from recovery.

After that you can try resetting the module, as described here: https://github.com/Magisk-Modules-R...README.md#device-issues-because-of-the-module
[Magisk] bitye:
Am I able to boot without option "d" (device simulation)? I used it on LOS before they added stable fingerprint and it was super fine. On MIUI system tells me everywhere that it's 10.2.3.0 stable with February patch (as official FP) while it's 9.3.25 with March
[Magisk] Didgeridoohan:
Device simulation is only necessary if you want to spoof a different device for whatever reason. If you don't need to do that, don't activate the option (SafetyNet will pass anyway).

Just run the props command, disable the option, reboot and you should be fine.
[Magisk] DerSteppo:
Hm sorry I wiped yesterday and reinstalled AEX. Oddly enough, changing finger print was not a problem this time, however cts is now false.

Steps: changed finger print, rebooted, enabled improved hiding, rebooted.
[Magisk] Didgeridoohan:
Well, if CTS still doesn't pass after you have applied a fingerprint from the module there's still something going on. Your logs might still be interesting...
[Magisk] FaserF:
Seems not to work for a Galaxy S6 International Variant with Android 9 LineageOS

Used S6 Android 7 Fingerprint
[Magisk] Didgeridoohan:
I suspect there's an issue with the new optimisation I did for how the props are set at boot. It would be very helpful if you could try this by running the props command, going to the "Script settings" menu and changing the boot stage to post-fs-data or late_start service and reboot. If that works then I know I need to work on that...
[Magisk] Didgeridoohan:
I have confirmation from one user (thank you for the help [MENTION=8471321]DerSteppo[/MENTION]) that the issues with CTS not passing on v3.5.0 is related to my new optimisation update (d'oh!).

Until I have an update out, this can be fixed by going to the script settings and changing the boot stage to post-fs-data.
[Magisk] shloim1:
I'm back... Installed yesterday the new version, it worked for one time, but after the next reboot, CTS was false, but for some odd reason, the module is saying that it's active and is showing the real fingerprint as the one set by the module. And when I changed the boot stage to late, when rebooting it got into a boot loop

(I attached a screenshot and the logs)

https://drive.google.com/file/d/1ytDyUcKk3K5fq3sTJHNM8ipju4q2sB5v/view?usp=drivesdk

https://drive.google.com/file/d/1MrVvmmaeAcH87ueuRe-phpmU8zn6e9c8/view?usp=drivesdk
[Magisk] DerSteppo:
Thank you once again for your personal assistance. :good: Keep up the great work.
[Magisk] bitye:
Thanks everything works fine. I updated 9.3.25 to 9.3.28 with disabled module. I also updated Magisk to 19. After boot just enabled your module and everything went fine. After this I disabled the device simulation and now it shows me the correct MIUI version with working ctsProfile.
[Magisk] Didgeridoohan:
It does, but as far as I understand we're talking about a case of ctsProfile=false and basicIntegrity=true. That would not happen on a system with Xposed installed, hence I did not bring it up as a possible culprit in this particular case...
[Magisk] skullkid383:
Oh sry I thought it failed all together
[Magisk] gustiirwansyah:
not working

i have xiaomi note 3 mtk with magisk the latest version,but i have problen when type "props" in terminal emulator said "sh:props: not found"

please how to fix this,thanks

sorry for my bad english because i'm indonesia
[Magisk] Didgeridoohan:
That likely means that the module hasn't installed properly, or there's something (another module or a script) that is preventing the script from mounting.

Take a look under "Issues" in the OP for details on what you'll need to provide for troubleshooting.
[Magisk] gustiirwansyah:
thanks for answear... i will post the log soon
[Magisk] waylo:
Just for fun, I decided to try what you described above. This does allow for an accepted CTS profile, but of course the integrity check does not.

One interesting thing I found, was that right after I applied and first rebooted to a new fingerprint, the appstore does not list the device as uncertified, but rather, it doesn't make any statement at all. (This was before I installed xposed). After a while, though (unsure how long, maybe several hours), the playstore does list it as uncertified.

Do we know what the playstore uses to certify a device? It looks like it must be both CTS profile + integrity passing.
[Magisk] Didgeridoohan:
It does look like it, doesn't it?

I haven't personally played around with your particular setup. I know that you'll get an uncertified status in the Play Store if you have both ctsProfile and basicIntegrity reporting false, or ctsProfile false and basicIntegrity true.

You could test further by keeping your setup (with ctsProfile true and basicIntegrity false), and clear data for the Play Store. You'll initially see the same thing again, that there's no certification status at all, but after a while it'll show up. I would guess it'll be uncertified, but it'd be nice with a definitive answer...
[Magisk] Duden17:
Hi Didgeridoohan, can you help me. I like to manually edit ro.selinux from 0 to 1 for samsung devices or form 1 to 0. What should i do to edit samsung ro.selinux using terminal emulator. Thanks before and your module very help many people ;);). Thanks man. :good::good::good:
[Magisk] Didgeridoohan:
You have a few options...

The prop can be set by using Magisk resetprop tool. Just run this in a terminal emulator:

resetprop ro.selinux 0

The drawback is that this doesn't persist across a reboot.

You can use a boot script. Place the above resetprop command in a file, place it in /sbin/.core/img/.core/service.d and give it permission 755. Now it'll run that command at each boot. If it doesn't seem to work, move the script to /sbin/.core/img/.core/post-fs-data.d instead.

And lastly, you could use this module and the custom props function. Just run the script, go to menu 4 (Add/edit custom props), and type in the prop you want to change and then the value. This is pretty much the same as using the boot script method above, but you let this module do it for you.
[Magisk] steven360:
Hi, I've read through this: Readme file

and I still don't understand what to do. I have the build.props file and also the updater-script file (but it has only one line of code in it that doesn't mean anything to me)

Thanks for the help guys
[Magisk] Didgeridoohan:
In the build.prop, there's this line:

ro.build.fingerprint=Huawei/generic_a15/generic_a15:8.0.0/OPR6.170623.010/jslave04151845:user/test-keys

Did a quick test and it doesn't seem to be certified.

Which device? [MENTION=4385440]theCroh[/MENTION] provided a similar Huawei fingerprint recently, for the Mediapad M5 LTE. Seems like Huawei have a bunch of generic fingerprints they use for devices they don't want to bother with certifying. :silly:
[Magisk] steven360:
My device is an Honor 7x, I got that from a update.app file and extracted it from the system.img. :cowboy:
[Magisk] waylo:
Ahh, I'm happy to contribute some interesting info! An interesting revelation.

I hadn't ever cleared the Playstore data. So after clearing it, the Playstore actually showed the device as CERTIFIED. It's been like that for a day now. So it appears that CTSProfile pass = sufficient (at least for now) to show a certified device.

I do believe my situation (CTS pass, basicintegrity fail) is far less common, but I hope this can help anyone else in a similar situation.
[Magisk] Duden17:
Oke thank you so much man, i ll try it :):)
[Magisk] spawnlives:
I can confirm this on my device too

CTS pass. Basic integrity fail

Device certified.

Xposed is on (using No Device Check module)

Also changes values in finsky.xml file as well.
[Magisk] Didgeridoohan:
And when you think about it, it kind of makes sense that it's the CTS profile check that's the important one for Play Store Device certification. It's with that check that they see if you're using a certified device/ROM combo. The Basic Integrity check is more for rooting and other kinds of system tampering.
[Magisk] waylo:
Can you comment on how certain apps, like Netflix, won't show up in the appstore for certain devices? My tablet is set to mimic the Nvidia tablet, and Netflix doesn't appear. (I don't actually have Netflix so it's more a question of how devs can limit their apps from showing in general).
[Magisk] Didgeridoohan:
Play Store certification is used, of course. And some prop values are checked as well. I believe ro.debuggable is one, but MagiskHide should take care of that. With Netflix it could also be a Widevine thing...

Time is also a factor. I've seen reports of users not having Netflix appear for up to a day after clearing Play Store data and getting their device to report as certified.

I'm just guessing though, from what I've tested myself and seen reported on XDA... :laugh:
[Magisk] TerrorToetje:
Hi Hi,

Once I enable this module I lose basicIntegrity True, once i disable the module and restarts it's true again, I checked that the right fingerprint worked using "getprop ro.build.fingerprint".

Magisk 16.4 Beta, Android 6.0.1.

Best Regards,
[Magisk] Didgeridoohan:
Now that sounds interesting... But, how about providing the logs mentioned under "Issues" in the OP. Can't help without them...
[Magisk] JarlPenguin:
When turning "Improved hiding" on, the storage section of Settings starts crashing. Also, the Files by Google app says my device isn't supported. After disabling that it worked again.
[Magisk] beastobadness:
Bingo! I thought I was going loopy... I tried everything to get CTS profile to set true with the latest version as everything pointed to something up with this module. Google now thinks my Axon 7 is a Pixel but it is all working now after changing the script setting to post-fs-data. Nice one [MENTION=3230564]Digeridoohan[/MENTION] great module[emoji106]
[Magisk] Didgeridoohan:
Probably related to the prop issue some are experiencing from my "optimisation". You can try resetting the module, change boot stage to post-fs-data and reapply the fingerprint.

That weird... I would need to see some more logs though. The ones posted seem to be from after you have restored everything and I would also like to see a logcat of the crashes.
[Magisk] fjuniper:
Using the latest v19 beta Magisk and app, I just used the MagiskHide Props Config to try and pass Safetynet. I changed to the fingerprint for my S9+ then rebooted - and now I have a bootloop and can't do anything... Being a bit out of practise, I forgot to take a TWRP or Ti backup first too. Any suggestions please?
[Magisk] Didgeridoohan:
First of all, please save the logs. Nobody that has been reporting about this has so far been able to produce any... They'll be in /cache and more details here:

https://github.com/Magisk-Modules-R...lob/master/README.md#collecting-logs-manually

After that, you can follow this:

https://github.com/Magisk-Modules-R...README.md#device-issues-because-of-the-module
[Magisk] Mikes:
I had a bootloop with the 3.5 version as well. This is the workaround that worked for me:

1. Flash Magisk Uninstaller zip.

2. Flash Magisk.

3. Reboot

4. Flash MagiskHide Props Config and BusyBox modules.

5. Reboot.

6. Configure MagiskHide Props Config as you usually do.

7. Change the boot stage to post-fs-data in the MagiskHide Props Config.
[Magisk] fjuniper:
Thanks - Files should be attached.

I have placed a file named reset_mhpc in /cache and rebooted, but I am still stuck on the big white SAMSUNG.
[Magisk] Didgeridoohan:
Thank you. I'll take a look at those logs shortly.

Try navigating to /data/adb/modules and simply delete the MagiskHidePropsConf directory.

If that doesn't work, try the method mentioned above your post.
[Magisk] Saison2018:
Sorry for the delay, was on the road with no way to get the files.

Here there are, hope this could help.
[Magisk] fjuniper:
Thanks - I managed to get that done 2 minutes before leaving the house - I thought I was going to be without a working phone:eek:

Please let me know if you find anything helpful in the logs.
[Magisk] Didgeridoohan:
Glad you got things working again.

Unfortunately the logs didn't more than hint at what could be going on, so I'm none the wiser. If you're up to it you could try again, but this time also use a logcat boot script as described here:

https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] Donavonn:
[MENTION=4667597]Didgeridoohan[/MENTION]

I'm using phh treble 8.1 and my Snapchat is detected and I can't login even prior to rooting. Will this tool fix that?
[Magisk] Didgeridoohan:
That depends entirely on what the app is complaining about and how your setup works in general. In other words: I have no idea, please try.
[Magisk] allrockedout:
Trying to get redmi note 5 on pie to pass safetynet I tried changing the boot stage like I've done before but won't pass on Oreo props. How can we add the pie ones . Thank you

Nevermind I changed the bootstage to post and it's passing now. Thanks
[Magisk] allrockedout:
Ok here is Xiaomi Redmi Note 5 for pie...

xiaomi/whyred/whyred:9/PKQ1.180904.001/9.3.28:user/release-keys
[Magisk] VincentJoshuaET:
Beta firmware do not pass SafetyNet.