yashsingh1/xdaforums huggingface dataset:
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
New build up with January 2019 Security patches

Credits: Built from kyasu's sources. No modifications.

January 2019 security patches

Synced with LineageOS Sources 12. January 2019

Signed with my release keys

Note: Dirty flashing from my previous signed builds will work. Other than that, then you'll have to do a clean flash!

Sources: See the first post

Download link: https://androidfilehost.com/?fid=11410963190603896823
[Galaxy S 4 i9506 Android Development] Poelbast:
phone app crashes

Dear Sub_Zero2,

thank you for keeping our device alive.

using your build and the previous one, the phone app crashes always when I start a call. The call is still working but I can´t stop it.

Using kyasu's build - no problems. I did a full wipe befor install the rom. I tried also without gapps the same behaviour.

Kind regards

poelbast
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
Hi. I'm not experiencing this problem on my device. I will try to do some more tests though.

Is anyone else having this problem?
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
I've done some more testing, and I couldn't reproduce this problem.

Be sure when you do a clean install, and flash the latest opengapps right after lineageos, before booting the rom, or you might end up with force closes on gapps dependant apps like the dialer and contacts, etc.

By the way, kyasu is the one keeping this device alive, i just make some builds now and then based on his source code until lineage-16 gets linux kernel enforced mode.
[Galaxy S 4 i9506 Android Development] DiamondJohn:
Yes I understand [MENTION=4861355]kyasu[/MENTION] is the source / reason this device lives on, however, to everyone else and you, I'd like to say that "imply" doing a build (especially with the multi-day last build) should be applauded :good:

Anyway, in regards to

I noticed that [MENTION=6459107]darkness[/MENTION] published a build of Pie SELinux enforcing, for RR. Have you tried an Enforcing build?

Back in the day of early Oreo, I think I was one of the first to release an Enforcing build (may of been Nougat on a different device :silly:), even though LineageOS was still permissive. I was pleasantly surprised that it booted and only had a few SElinux deny's, which I simply coded and added; using tools such as my TeMeFI
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
TeMeFI is a genious app if i may say so. It will give you much more information than just a logcat. Have a look at: https://xdaforums.com/android/apps-games/app-temefi-comprehensive-documentation-t3806260 for you devs, modders or others out there who like a lot of info.

By the way, i didn't actually feel good about posting builds here in this thread, but i asked kyasu, and he said ok. It doesn't mean i will go ahead making lineage-16 builds at the moment, as i wouldn't feel well about posting builds in that thread where he is currently working. RR builds is a different case, and would require a entirely different thread, but i haven't done any RR builds so far, so i guess that's up to you [MENTION=5417899]DiamondJohn[/MENTION] :)
[Galaxy S 4 i9506 Android Development] DiamondJohn:
I think you may of missed my point, I was just saying that [MENTION=6459107]darkness[/MENTION] has an Enforcing Pie build off of [MENTION=4861355]kyasu[/MENTION] sources (which happened to be RR), so I was thinking a plain LineageOS build would possibly also work enforcing. Anyway, I am all about Havoc-OS right now, and the Oreo build actually has a LOT of visual queues from Pie; my pie build of Havoc-OS fails to build:mad: I think they switched from LineageOS to AOSP.

PS: I was also unclear (my bad) but I was thinking more from the point of view that you were waiting for enforcing before you personally moved to Pie.

PPS: If you can think of ANY extra shell commands to add to TeMeFI, please let me know in that thread. I'm tapped out of ideas.
[Galaxy S 4 i9506 Android Development] noob403:
lockscreen crash into yellow screen half

I have a reoccurring problem, when I press homescreen/powerbutton to open the phone. But is crashes to a yellow screen(half a page) and I cant do anything. Beside taking out the battery.

Since I a newbie grateful for tips and tricks. I all ready tried to reinstall and wipe . Nope still the same problem.
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
That's the smart cover info screen. It is supposed to display info like time in a small transparent window in the cover covering your screen. It might be you have dirt on your sensors on the top of your screen or similar. You can turn off smart cover in Settings -> Connected devices -> Smart Cover (See the attached screenshots)

(Actually the yellow color indicates that your device is charging, it will turn blue when you're not charging, or red when your battery is low)
[Galaxy S 4 i9506 Android Development] Poelbast:
Dear Sub_Zero2

I tested it with an other device with the same behaviour. I did a full cleenup in TWRP, wiping System, Data, Cache, SD-Card, I only flashed your .zip file. No Gapps. After reboot I choose language (German if it matters) and did no data connection. I switched off Wifi and switched also off mobile data. If I make a call the phone app crashed wile the call starts and there is a well working connection. But there is no red telephone to switch off the call. Restart of the phone app is not possible (always crashing again). After a reboot the same behaviour. With the rom from the first post everything is fine.

It would be nice If you could reproduce the problem.

Kind regards

poelbast
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
You should immediately flash gapps after my zip. If not, you might experience force closes (i did before when not flashing gapps, i use the pico gapps package).

Edit: I've done some more testing and I've just experienced a crash in the telephone app as you described. I'll try to do some debugging when I have time.
[Galaxy S 4 i9506 Android Development] DiamondJohn:
Out of interest, was that error with or with-out GApps?
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
With
[Galaxy S 4 i9506 Android Development] Poelbast:
For me it does not matter. I get the error with and without gapps. But I would like to use the rom without gapps. I tried also different bootmodems I9506XXSDPL2_I9506XXUDOJ2_bootmodem.tar and I9506XXUDRB1_I9506XXUDRA1_bootmodem.tar but there was also no difference. The builds of kyasu work without troubles.

Thank you for debugging

poelbast
[Galaxy S 4 i9506 Android Development] DiamondJohn:
That does not look promising from what [MENTION=2696268]Sub_Zero2[/MENTION] wrote.

Although one specific error may be hidden (gone) using the wrong modem/bootloader, you will inherit many other issues. i.e. only use the correct modem/bootloader, as within the ROM, there are specific firmware blobs which align/integrate to a specific modem/bootloader. However, I don't see why if you replaced the correct firmware files (see github) that align to the other modem/bootloader, why it wouldn't work.:silly:

And just to be clear, its a little confusing as in your post, you quoted me, but your thanks are directed to [MENTION=2696268]Sub_Zero2[/MENTION] ;)
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
Hi

I haven't been able to reproduce the error yet since my last reboot. Incoming calls are so far working and outgoing too so far.

If you would be so kind to provide me with logcat and last_kmesg until the problem occurs again on my device, i'd appreciate it.

It does not seem to be happening all the time, atleast not on my phone.
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
New build up with quick fix preventing dialer app from crashing.

lineage-15.1-20190128-UNOFFICIAL-ks01ltexx.zip

Credits: Built from kyasu's sources. Only modification is a quick fix to prevent a crash in the dialer app.

Synced with LineageOS Sources 27. January 2019

Signed with my release keys

Note: Dirty flashing from my previous signed builds will work. Other than that, then you'll have to do a clean flash!

Sources: See the first post

Thanks to [MENTION=9122505]Poelbast[/MENTION] for the logcat

Download link:

https://androidfilehost.com/?fid=11410963190603910118
[Galaxy S 4 i9506 Android Development] k3mot:
Can somebody ensble volte on this ROM?thanks for answer
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
New build is up!

lineage-15.1-20190210-UNOFFICIAL-ks01ltexx.zip

February 2019 Security patches

Credits:

Built from kyasu's sources.

Lineageos team.

Only modification is a quick fix to prevent a crash in the dialer app.

Synced with LineageOS Sources 10th of February 2019

Signed with my release keys

Note: Dirty flashing from my previous signed builds will work. Other than that, then you'll have to do a clean flash!

Sources: See the first post

Source of quick fix for Dialer app (diff): PhoneNumberHelper.java
[Galaxy S 4 i9506 Android Development] :
Just out of interest: Does this crash only occur on ks01lte? Otherwise it would probably make sense to merge it to the upstream.
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
I don't know if it happens only on ks01lte. Anyway it's just a quick fix until i have time to investigate it further, because if a crash is going to happen, then the geolocation string won't be shown with this quick fix (but preventing the crash ofcourse).

Edit: Geolocation string actually works as supposed to in the call log, so something seems to be broken somewhere.

For anyone wondering: geolocation text with the name of the county or state in a country, it is supposed to show below the phonenumber on outgoing/incoming calls (typically on landline numbers).
[Galaxy S 4 i9506 Android Development] Telone:
Hey [MENTION=2696268]Sub_Zero2[/MENTION] could you make a custom battery animation on phone switched off that show %?
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
Not for this rom, no. I won't build it with any customizations.
[Galaxy S 4 i9506 Android Development] Telone:
Oh... do you know if is it possible?
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
Yes, i think maybe los 14 had percentage display, if not then i'm 100% sure cyanogenmod 13 had.

Try to google a bit around, maybe you'll get lucky to find a patch or something.
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
New build is up!

lineage-15.1-20190227-UNOFFICIAL-ks01ltexx.zip

Credits:

Built from kyasu's sources

Lineageos team

Thanks to kyasu for keeping his lineage-15.1 repositories alive

No modifications to the sources

Dialer app is now working as expected with offline geo description

Synced with LineageOS Sources 27th of February 2019

Signed with my release keys

Note: Dirty flashing from my previous signed builds will work. Other than that, then you'll have to do a clean flash!

Sources: See the first post
[Galaxy S 4 i9506 Android Development] henryakeley:
Hello

I'm having problem with my Phone app. Made a general thread about it: https://xdaforums.com/galaxy-s4/help/weird-phone-app-behaviour-trying-to-t3905141

In short: when I try to make a phone call, the screen goes black and I'm unable to access any funtions - there is no keypad and hardware buttons stop working either. The call is underway and you can hear/speak. After some time (when the call ends I think) or after a reboot the phone/rom goes back to normal operational status.

Apart from that everything works: my mobile Internet and other functions of the ROM (camera, games, music etc).

Device: S4 LTE GT-I9506 according to IMEI. It was bought in Europe (Poland) but now I use it in Taiwan

ROM - the latest LOS 15.1 from this thread (20190227)

modem - I9506XXUDOJ2 from this thread

I'm not very experienced in flashing so perhaps I made some simple mistake but I did try and follow the instructions.

Here's the logcat...the phone call was made around 13:36 (or 13:37 perhaps) https://www.hastebin.com/cexopetaxu.pl

Any help and suggestions would be most appreciated.
[Galaxy S 4 i9506 Android Development] Sub_Zero2:
New build is up!

lineage-15.1-20190305-UNOFFICIAL-ks01ltexx.zip

March 2019 Security patches

Credits:

Built from kyasu's sources

Lineageos team

No modifications to the sources

March 2019 Security patches repopicked

Synced with LineageOS Sources 5th of March 2019

Signed with my release keys

Note: Dirty flashing from my previous signed builds will work. Other than that, then you'll have to do a clean flash!

Sources: See the first post
[Galaxy S 4 i9506 Android Development] DiamondJohn:
Proximity sensor?

I just had a crazy thought. It sounds as if your proximity sensor is telling the phone that it has been brought up to your head, and is thereby turning the screen off during the call. I just did a test and its what my phone acted like when I made a call and put my finger over the proximity sensor. Try downloading one of the many sensor test apps on the play store and check that your proximity sensor is working correctly.

If that's not it, then maybe someone else can see something in your catlog.
[Galaxy S 4 i9506 Android Development] DiamondJohn:
Investigate WHAT is consuming your battery.
[Galaxy S 4 i9506 Android Development] wkwk:
Check that ur battery isnt on its way out, the other thing to try is a battery recal. It happens sometimes when u switch roms, look for battery calibration on playstore.

Also use better battery stats and see if anything is triggering wakelocks. See if there is any deep sleep at all.

If you identify any culprit apps, use greenify via magisk to force hibernation.
[Galaxy S 4 i9506 Android Development] jegogo99:
with DOL1, the battery lasts longer, but data and GPS do not work as well as DPL2. for this reason I am going to use the most recent modem

Enviado desde mi GT-I9506 mediante Tapatalk
[Galaxy S 4 i9506 Android Development] corvus.corax:
Which version of magisk to use? 15.3 or 16?

Will Snap Camera video work? I really don't like Footej. It's very basic.
[Galaxy S 4 i9506 Android Development] jegogo99:
GPS doesn't work fine for me

Enviado desde mi GT-I9506 mediante Tapatalk
[Galaxy S 4 i9506 Android Development] DSMNCIHAGT:
I managed to improve the battery life by uninstalling Google messages as it was draining the battery in the background for some reason.

Battery's still not as good as it was with nougat but at least i can use the rom now, thx everyone for the help.
[Galaxy S 4 i9506 Android Development] :
Since v16 ist latest version why would one not use it? And of course I don't know more than you about the camera, but I guess it will be fixed someday (I am actually really happy with footej camera and I would probably use it anyway, since I have bought the pro version already a while ago. So the camera is no issue for me).
[Galaxy S 4 i9506 Android Development] jegogo99:
Someone have problems with Gps accuracy?

Enviado desde mi GT-I9506 mediante Tapatalk
[Galaxy S 4 i9506 Android Development] DiamondJohn:
Help with build

[MENTION=4861355]kyasu[/MENTION] I built the ROM using your sources, and it got stuck in a bootloop. I understand its a little off topic here, but could you see where I am going wrong? or have there been some recent breaking changes somewhere in LineageOS or your sources?

I used LineageOS Sources:

repo init -u git://github.com/LineageOS/android.git -b lineage-15.1

And your device/kernel & vendor. Below is my roomservice.xml file

<?xml version="1.0" encoding="UTF-8"?>
<manifest>

<project name="LineageOS/android_hardware_samsung" path="hardware/samsung" remote="github" />
<project name="LineageOS/android_packages_resources_devicesettings" path="packages/resources/devicesettings" remote="github" />
<project name="LineageOS/android_packages_apps_FlipFlap" path="packages/apps/FlipFlap" remote="github" />

<project name="LineageOS/android_device_qcom_common" path="device/qcom/common" remote="github" />
<project name="LineageOS/android_device_samsung_qcom-common" path="device/samsung/qcom-common" remote="github" />
<project name="LineageOS/android_device_samsung_msm8974-common" path="device/samsung/msm8974-common" remote="github" />

<project name="kyasu/android_kernel_samsung_msm8974" path="kernel/samsung/msm8974" remote="github" />
<project name="kyasu/android_device_samsung_ks01ltexx" path="device/samsung/ks01ltexx" remote="github" />
<project name="kyasu/android_vendor_samsung_ks01ltexx" path="vendor/samsung/ks01ltexx" remote="github" />

</manifest>

The build all happily churns along and produces a zip file within the expected file size range, but when I flash the zip, it bootloops before it even gets to the bootanimation.

Here is also the last_kmsg file from the boot. https://www.hastebin.com/hexaditeyu.vbs

I can build Nougat ROMs using your tree's, but this Oreo build fails to boot:mad: any guidance would be VERY appreciated, but I understand it is beyond this thread topic :o

EDIT: I also added a line to the BoardConfig to make it permissive

EDIT: If I flash your zip, it boots and runs fine. Thanks :good:
[Galaxy S 4 i9506 Android Development] wkwk:
GPS hasnt worked for me since cm12, tried many things and have given up. I reckon its a hardware fault. The phone tends to get a lock then immediately lose it, over and over again.

Tried going back to stock firmware to get a lock and then return to aosp, opened the back and lifted antenna pins for better contact, flashed many radios etc.
[Galaxy S 4 i9506 Android Development] jegogo99:
On 15.1, GPS doesn't work but I Turned to L.O.S 13 official and GPS accuracy works fine for me. I'm using OJ2 modem

Enviado desde mi GT-I9506 mediante Tapatalk
[Galaxy S 4 i9506 Android Development] corvus.corax:
A question for those using magisk. The magisk OP seems to indicate one should revert back to stock android, then put on magisk, then the custom ROM? Is that necessary? I am on LOS 14.1, so can I just unroot (addon-su), install Magisk, wipe/clear, then install 15.1?
[Galaxy S 4 i9506 Android Development] rojartem:
E330s sgs4 korean gps works fine
[Galaxy S 4 i9506 Android Development] :
I don't think you need to unroot and install Magisk before flashing los15.1. If you wipe everything before flashing los15.1 it will be deleted anyway. So clean flash of the rom.zip and the magisk.zip afterwards should work just fine.
[Galaxy S 4 i9506 Android Development] karbon1992:
I confirm that it works. Clean flash of the rom.zip and then flashing magisk.zip, and magisk works fine for me.
[Galaxy S 4 i9506 Android Development] kyasu:
lineage-15.1-20180226-UNOFFICIAL-ks01ltexx.zip

New build is available (See the first post).

Sync with the latest LineageOS source.

Downgrade radio service to 1.0 (battery friendly?)

Changes:

https://github.com/kyasu/android_device_samsung_ks01ltexx/commits/lineage-15.1

https://github.com/kyasu/android_kernel_samsung_msm8974/commits/lineage-15.1
[Galaxy S 4 i9506 Android Development] kyasu:
This thread is a development thread. No problem.

The followings are required:

You need vendor/samsung/msm8974-common. Copy it from TheMuppets, or Add the following line to roomservice.xml.

<project name="TheMuppets/proprietary_vendor_samsung" path="vendor/samsung" remote="github" />

You need my forked android_device_samsung_msm8974-common. Change the following line from LineageOS to kyasu in roomservice.xml.

<project name="kyasu/android_device_samsung_msm8974-common" path="device/samsung/msm8974-common" remote="github" />

Repopick some commits (See attached repopick-extra.sh.txt).
[Galaxy S 4 i9506 Android Development] marcinadd:
I am using DOF2 and GPS works, but fix takes long time. I tested navigation and it also works good. But i have another issue. WiFi sometimes don't show available networks :/.

(on screenshot indoor fix).
[Galaxy S 4 i9506 Android Development] bga224:
Big thanks for this delivery. Things improved since the last one from my experience :

- Log in on public wifi is now possible,

- More options, like performance adjustment in battery menu,

- No more "green accentuation" on dark background color.

Unfortunately, mobile network is still not functional at all with 15.1, although it was on 14.1, when LTE is selected on preferred network. I have to select 3G to have mobile data. My baseband is XXUDOJ2.

EDIT : 4G is back, with new APN setup
[Galaxy S 4 i9506 Android Development] supachris:
Thanks a lot for the build!

Everything seems to be working, except video recording.

Screen on battery consumption while wifi is on seems to be a bit higher than 14.1
[Galaxy S 4 i9506 Android Development] henryakeley:
Far from crazy, it's a BINGO :) I ran a heap of test apps and on all of them the sensor either showed no activity or wnt into the blackscreen mode. Then eventually found one app that blocks proximity and swaps it for light sensor when calling. And now the phone app (dialer?) works ok.

Thanks a million, this was really driving me crazy...question remains, if the sensor is damaged, why did it work on the stock rom? But, anyway, no matter. Now, onto some new ROM...
[Galaxy S 4 i9506 Android Development] DiamondJohn:
:highfive: :D

The only explanation I would have for that, is that you are running the incorrect modem/bootloader. I know it took numerous flashes to change my boot/modem. It would return that all is OK, but when I checked, it was still the wrong one.:mad: You can check with a look down a

getprop;

call in a shell, or if your lazy, my TeMeFI utility has a specific function for it under "Current State>Get Selected Properties"
[Galaxy S 4 i9506 Android Development] Hemuli:
This is just a guess, but maybe the stock rom has additional measures to check if the sensor is working. Or maybe it uses both proximity and light sensors to determine when to switch off the screen in the first place.
[Galaxy S 4 i9506 Android Development] cdrivex4:
its old hat now but its still relevant, this option exists on smg900f, and while going through the settings i also accidentally enabled it, i spent a panicked 30 minutes googling how to fix until i came across : https://www.reddit.com/r/LineageOS/comments/90d0ku/lineageos_151_solved_accidentally_setting_screen/

It was a damn nightmare trying to get things back to normal, we should have this option removed. Safe mode will not help you undo this as even in safe mode the screen will be black, even restarting into recovery i got a garbled screen like the graphics card had just packed in completely.

above link asks to edit through vi but you get a garbled mess because windows cmd prompt in windows doesnt know what to do with it.

from turning on the phone in the end i blindly entered twrp :

adb devices

adb shell

echo 0 data/data/org.lineageos.settings.device/shared_prefs/org.lineageos.settings.device_preferences.xml "mdnie_accessibility"

echo 0 "mdnie_accessibility"

This allowed me to see twrp and boot process after a restart but 16.0 would still boot to a blank screen even after showing the logo.

This at least gave me the ability to copy xml to sdcard, copy that to pc for editing, then copy back from sdcard to settings folder using twrp...

if there ever was something that could give you a really bad day "screen curtain" is it.

Please lets have this removed or at least some kind of warning or have this temporary and reset after a reboot...
[Galaxy S 4 i9506 Android Development] :
I went through this as well back on los15.1. I ended up clean flashing the ROM. It should really be removed (I can not imagine any use case). Anyway anybody who did not come across this yet take this warning and stay away from this setting :eek:

Edit: Just realized this is the los15.1 thread, my bad. Anyway the setting is still there on los16.0
[Galaxy S 4 i9506 Android Development] DualJoe:
This lines don't make any sense. But if you redirect 0 (>) into the file it probably would effectively overwrite the whole file though.

Better ways are to either take an editor like vi, rename/delete the file or use a text processor (like sed):

sed -i 's:"mdnie_accessibility">1<:"mdnie_accessibility">0<:' /data/data/org.lineageos.settings.device/shared_prefs/org.lineageos.settings.device_preferences.xml