yashsingh1/xdaforums huggingface dataset:
[Google Camera Mods] fu24:
1.

5.2 modify here. ilb.smali

:cond_0
:try_start_1
iget-object v0, p0, Lilb;->b:Landroid/hardware/camera2/CameraManager;

invoke-virtual {v0}, Landroid/hardware/camera2/CameraManager;->getCameraIdList()[Ljava/lang/String;

move-result-object v2

invoke-static {v2}, Ljik;->b(Ljava/lang/Object;)Ljava/lang/Object;

new-instance v3, Ljava/util/ArrayList;

array-length v0, v2

invoke-direct {v3, v0}, Ljava/util/ArrayList;-><init>(I)V

array-length v4, v2

[B] const/4 v4, 0x1[/B]

[B]const/4 v0, 0x2[/B]

:goto_0
[B]if-lt[/B] v0, v4, :cond_2

aget-object v5, v2, v0

invoke-static {v5}, Lild;->a(Ljava/lang/String;)Lild;

move-result-object v5

invoke-interface {v3, v5}, Ljava/util/List;->add(Ljava/lang/Object;)Z

[B]add-int/lit8 v0, v0, -0x1[/B]

goto :goto_0

This is a description from cstark27

To modify 5.3 versions (and above), you'll need to find the new smali files that have the same code. So search 'getCameraIdList' to find the new iga.smali and 'Starting HdrPlus#ZslShotCapture' to find the new ecu.smali.

2.

I don't know. Because when 5.2 appeared. I have updated to android 8.0.

3.

To use the second back camera, if the phone does not even report all cameras through the Camera2 API ( Includes second back camera ) (use Camera2Test app to verify your device info). You need to install the zoomfix module.

Limit the name of the package using the zoomfix module.
[Google Camera Mods] tnthd2:
Unless the mod works differently on your phone than mine, looks like you moved the phone before the first frame was completed. I tested this many times for quite a while, and also read how Google's HDR works, only the first frame is taken into account for sharpness, the rest are just for HDR.

Keep the phone steady for the first frame, after that the phone can be rotated or pointed away, the final image is still as sharp as the first frame. Only the HDR results will be affected.
[Google Camera Mods] RockStar2005:
Ok thx tnthd2!
[Google Camera Mods] fu24:
You are the second person to mention that the similar problem.

First of all, I must explain that I am just a beginner with limited ability.

Originally switching cameras requires restarting the app.

Now the camera automatically restarts because of the changed settings., it will feel more convenient.

However, if you change the button to the main screen, auto-restart will have no effect.

Is there still another way? Let the two back cameras coexist. I don't know.

Cstark27 may have tried. I found the standard rear version of cstark27, Some code may be related to this feature.

As for the detailed instructions. Maybe cstark27 can be more clearly stated.

I don't know which version you are referring to. It's just that I really don't have the ability to fix other problems. I can only say sorry.

For me, using a telephoto lens will be darker because the aperture is different. The sensor model is different.
[Google Camera Mods] cstark27:
Late last month I almost had it working, but I couldn't get past a couple bugs. So, as you mentioned, the only way that I know of this to work is the app basically has to restart, and we can do that now thanks to SerJo87/Namok functions of going into settings. Unfortunately I could not replicate this function for when a menu item was clicked on the main screen. So I ended up with a version that had a "Wide Angle" menu on the side but i made it open the settings and change a Boolean value, and the Boolean value was used in iga.smali. But there was still some bugs with this and I didn't want to release a version that was half baked like that. So I abandoned it as my drive to work on this diminished. I tried to find that test version but I must have overwrote it with newer tests because I can't find it to share with you. :(

Yes, fu24, the wa:I code was my tests from a long time ago. Which never worked. But I used it for the Restart function test. You can remove the if-eq before the L:Lfkf in the fhl.smali and see the new menu item if you want. I can't remember right now how I changed it to open the Settings menu.
[Google Camera Mods] M4ryn:
Hi,

currently I am running LOS 15.1 (LG G6). Installed latest version of your GCAM port and I am facing with strange problem. Mainly, pictures taken with enhanced HDR+ are saved properly but pictures made by HDR+ not. It looks like you are taking pictures (the sound of a shutter) but they are not available in the preview. When entering the gallery they are not present either. When you try to make a portrait, the same thing happens.

Only in one case it works correct, when you press long button to make a photo series then all pictures from series are saved correctly. A single press does not save, does not take a picture.

Is anyone else outside me having a problem with this?

Thx
[Google Camera Mods] okaiuz:
hi all,

i've seen more modded version in this thread. there's any aversion with standard and wide switch instead of standard/front or wide/front?i can survive without the front camera
[Google Camera Mods] Ocakypa:
I have one on lg v20 does not work nexus 6P(angler) model?
[Google Camera Mods] sagor1:
Just a suggestion if possible you can add normal selfie mode for normal cam & wide selfie for wide cam.

It will be great.
[Google Camera Mods] cstark27:
The stock camera app just crops the front sensor when it's on "normal". The only way to do it in the Google Camera would be to zoom/crop the sensor data. Though, Portrait Mode kind of mimics this already since it zooms to 1.5x by default.
[Google Camera Mods] JarkMackson:
Something weird I noticed was that when used portrait mode, I get a burst shot with just one pic. Is that normal or do I have a setting that I need to change?
[Google Camera Mods] mehra1:
Potrait mode only work with faces, if by any chanve it doesn't detect one then the outcome will be a normal burst pic.
[Google Camera Mods] fahmi182:
Buy pixel 2 xl then...
[Google Camera Mods] sagor1:
Is that mean lg upsampling the image?

Coz pic resolution is same...or it's higher than 5mp sensor?
[Google Camera Mods] cstark27:
If that's true (I haven't used the stock app a lot so I don't know), then yes most likely they are resampling it. The sensor on the V30 is SK Hynix HI553, advertised as 5mp from the manufacturer.
[Google Camera Mods] Aragami84:
Thanks A LOT for this...

AMAZING port/mod and it works great... on my LG G5

This is the best port/mod version I've seen.

I hated that every time I used ported/modded version of the latest google camera app, I had to choose between various phones and it crashed 40% of the time and the video mode wouldn't open at all....

But with this version EVERYTHING works great and every options works and never crash... ***** Stars

The only thing that is missing is filters like in the Samsung camera and it would be the best apps....

---------- Post added at 07:07 PM ---------- Previous post was at 07:01 PM ----------

The only thing I noticed with my LG G5 is that it only takes images from the 8MP camera not the 16 MP one... and there is no options to switch.

Could you make a version specific for the LG G5 or add an option for the dual cameras ?
[Google Camera Mods] cstark27:
There's 2 separate apps you have to download in the OP. One is for the standard rear camera + front camera, and the other app is the wide rear camera + front. Download and install them both - they will install as "Camera" and "Camera (Wide)". If that still doesn't solve your issue then send me a report from Camera2 Test: https://play.google.com/store/apps/details?id=com.camera2.test
[Google Camera Mods] Aragami84:
LG G5 Compatibility

Okay Thanks, actually I clicked without reading my bad.

I just now tested the versions available on this post.

My phone & Software : LG G5 (Android 7.0)

standard rear + front cam

cstark27_GCam_5.1.018_24_v3.3.apk

Doesn't want to install for some reason.

wide rear + front cam

cstark27_GCam_5.1.018_24_wide_v3.3.apk

That's the version I was talking about and everything works great but it only shows one of the dual cameras which is the 8MP

standard rear + front cam

cstark27_GCam_5.1.018_24_v3.4.1.apk

Doesn't want to install for some reason.

wide rear + front cam

cstark27_GCam_5.1.018_24_wide_v3.4.apk

Works great like the version 3.3, but like the other one is only showing one of the dual cameras which is the 8MP. I can't and don't see higher then 8MP but it should go up to 16MP or 15.9MP.

LG G6 Lineage Only Download wide rear + front cam

cstark27_GCam_5.1.018_24_wide_v3.4_G6Lineage.apk

This version now see the 16MP cameras and I can choose it in the options.

The rear camera doesn't work at all and it seems that all options of the rear camera are empty or simply just not showing up in the settings.

Also, it crash as soon as I click to switch to Rear camera it crashes. The rest works perfectly fine.

Screenshot of the setting section with the missing information's.

https://i.imgur.com/MHITkyg.png

Here the devices scan with the app you linked.

drive.google.com/open?id=1IUwsjX1q5tD8uDBj5HBG0o5g9KOj6BjS

(With this link you can download the HTML file with all the information's of the 3 devices)

If you just open the link all the text looks the same but if you check the file you'll see a ll the sections are separated and well displayed.

------------------------------------------------

Also, what would be great is to add all the filter of the app (Candy Camera), which there is a lot and they are pretty cool. I don't if it's possible to add them but I would be cool if so.
[Google Camera Mods] cstark27:
[MENTION=8949102]Aragami84[/MENTION] make sure you don't have any other Google Camera app already installed. They will have the same package name as my "standard lens" app so that may be the reason why it won't install. Just uninstall all other versions except your stock camera app.

Based on your report, you will not want the Lineage specific app. The regular, bolded, versions in OP are the right ones for you. LineageOS on the G6 has a different Camera ID layout so I had to accommodate that with a specific version.

On any of my current versions, you will only have access to (1) rear camera module at any time. There is not an app yet that currently supports (3) camera ID's at once.

Hope that helps. If you still have issues maybe someone in the G5 thread can help troubleshoot further as I don't have a G5 to test with.
[Google Camera Mods] Aragami84:
Oh, damn... I just checked in my settings and in the apps section I saw that I had a few apps installed and they were in disabled mode.

Because I had installed a few other apps but when I clicked on them and choose "Uninstall" for some reason it just disabled them.

I just removed a few apps that wasn't removed and now it installed fine.

Now I see the 16MP camera on the latest normal version and I installed the wide angle camera too and it works fine.

Everything works fine now thanks... a lot...

I had already post on LG G5 section but I will change my post and add your information and link towards this post of your app.
[Google Camera Mods] frasre:
Sorry if it's a stupid question but do I have to uninstall previous versions before installing the latest one?

Thanks!
[Google Camera Mods] cstark27:
Nah, though if you have issues just Clear Data of the app.
[Google Camera Mods] nic85:
Thanks for your work!

Anyone has done a comparison between the the original and this camera?
[Google Camera Mods] ardiansyahf:
im using G5 SE (LG-H845). when install this mod it say "This app isn't compatible with your phone" is there any solution for this?:(:(
[Google Camera Mods] scytalemk:
[MENTION=2712580]cstark27[/MENTION] You are the best. It just give a new meaning to my LG V20. About that error that I was talking few days ago "corrupted app" on install, that was because I was transfering apk from pc to phone befor install, but when I download it from google drive direct to my phone there is no such error. Thanks man.
[Google Camera Mods] frasre:
Thanks. Just had one issue (with the Wide app).

After updating to v3.4 it was using the normal lens and not the wide angle. Clearing the app data didn't fix it but after uninstalling & reinstalling the problem was solved. ?
[Google Camera Mods] MacLaughlin:
[MENTION=2712580]cstark27[/MENTION] is it possible to stop creating new folders when shooting a portrait?
[Google Camera Mods] cstark27:
Maybe in the future. From what I remember, there's some debug stuff that is written to those folders each time, so changing it may break some stuff.
[Google Camera Mods] koboltzz:
I have a possibly good idea which won't be too hard to accomplish:

Everytime Gcam is recognizing low light it shows 'flash', right?

What about if Gcam is automatically switching to nonZSL hdr+enhanced then?

Then we can take fast pictures on daylight with ZSL and at nighttime don't have to do anything for taking noiseless photos.
[Google Camera Mods] eigenjim:
[MENTION=8472543]fu24[/MENTION]

Thanks fu24, I will get 5.2 a try once I receive my used V30.

Another question, do you know how to increase the memory allocation of the gcam app? It seems my phone will lock up after 3-4 HDR enhanced pictures(while the phone still has 2GB of tam left itself), I don't know if increasing the memory allocation will help.
[Google Camera Mods] fu24:
I don't know.
[Google Camera Mods] viktor92:
I'm a little dizzy with all the versions of the camera, please somebody can tell me which is the best for the LG G5 ??
[Google Camera Mods] shamsul007:
Absolutely love this app, was at a wedding and took some great shots. Is there a tutorial that explains the advanced/experimental settings etc?

Thank you for all your hard work!
[Google Camera Mods] nkirk:
V3.8 from op
[Google Camera Mods] SHIVALP123:
Totally fed up with the constant hanging and rebooting of LGV30+ after oreo update. Can't take it anymore, tried everything. It's not rebooting while using gcam now but it does randomly now. Please someone tell how to go back to previous android version. Please help, almost fell like leaving the phone, but I'm still paying my EMI for this. ?
[Google Camera Mods] Mnementh666:
Not really the thread for this, but have you tried a factory reset?
[Google Camera Mods] ChazzMatt:
I have three V30+ on Oreo and have no such problems. Try Master Reset and/or try flashing full Oreo KDZ of your phone again, with dev patched LGUP with DL PARTITION method.

To go back to previous Nogat KDZ, same thing. Flash full image Nougat KDZ with dev patched LGUP with DL PARTITION method. Then Master Reset, just to make sure everything is cleaned out.

Master Reset (

post 101 of Frankenstein thread

)
[Google Camera Mods] SHIVALP123:
Sorry, but I started experiencing it first while using google cam mod, that's why I posted it here. After making the changes told by [MENTION=2712580]cstark27[/MENTION], it didn't reboot while using that, but phone started hanging 5-6 times everyday. I'm not understanding what's wrong.

---------- Post added at 02:46 AM ---------- Previous post was at 02:44 AM ----------

Thank you. I'll try that.
[Google Camera Mods] Vkboy:
https://xdaforums.com/galaxy-s9-plus/how-to/triple-bounty-thread-s9-exynos-version-t3822104 galaxy s9 exynos bounty thread. Please [MENTION=2712580]cstark27[/MENTION] take a look
[Google Camera Mods] viktor92:
Leaving such a great phone only because a camera app doesn't work ?, mate don't you think it's too much ??
[Google Camera Mods] SHIVALP123:
The camera app is working now, but the phone isn't. There has been a constant freezing and rebooting after the oreo update.
[Google Camera Mods] charliebigpot:
That is really weird, I'm also on Oreo on v30+ and haven't had a double reboot since I upgraded (1 month or so)
[Google Camera Mods] cstark27:
You followed these steps?

https://xdaforums.com/showpost.php?p=77133433&postcount=1069
[Google Camera Mods] cstark27:
Sounds like some possible issue with Gcam Tool to me. Try uninstalling it for a while and see.
[Google Camera Mods] SHIVALP123:
Yes. I guess it happened coz there was also a different google cam mod installed in my phone along with this. I uninstalled it and many other apps and now it never happened. Can you please confirm that having an other gcam mod can do this??
[Google Camera Mods] RockStar2005:
I don't think it is Gcam Tool though. Gcam Tool only prevents flipping on the front side "selfie" camera, but these pics were taken with the rear "main" camera.

Do you have any other ideas for what might be causing it or how to fix it?

Thanks!!
[Google Camera Mods] cstark27:
I'm fairly confident that the reboot issue on LG/V30's and Oreo is some kind of weird interaction with the Hexagon DSP. The ONLY reboot I got from GCam was right when I upgraded to Oreo but after I disabled the Hexagon DSP I couldn't make it reboot anymore. So yes, if other GCam versions on your phone exist, find the setting to disable the Hexagon DSP. Some versions don't have this so you'll have to uninstall it.

I'm pretty sure GCam Tool doesn't "prevent" it from flipping. Im pretty sure it detects through exif info of an already captured and processed photo if it's a FFC photo and then inverts it. So using that info I still believe it's a issue related to that app. Let me know what your experiment shows.
[Google Camera Mods] Vkboy:
Atleast please reply:confused:
[Google Camera Mods] RockStar2005:
Ok I'll try it. How long is a while though (before reinstalling it again)? lol
[Google Camera Mods] cstark27:
https://xdaforums.com/showpost.php?p=77158329&postcount=1097
[Google Camera Mods] stewie-droid:
This may be a silly question but is there Beauty mode in Gcam camera apk to soften up skin texture?

I absolutely love HDR enhanced and the only thing that's missing is beauty mode toggle to soften up skin texture in selfies. You know woman love this feature. lol

Alternatively does anyone know any phone apk that can really fast do this on the fly without screwing up rest of the picture details.
[Google Camera Mods] cstark27:
It's called "Face Retouching" in GCam. It's an icon on the selfie and while in Portrait Mode I believe. But not available on the rear lens, regular mode. The effect is pretty subtle so don't expect Samsung level of blurry face.
[Google Camera Mods] stewie-droid:
Oh yeah it is in there. Thank you. I'm not sure how i missed that. :)
[Google Camera Mods] hawkeyexp:
It seems i indentified a possible bug:

Used Version: cstark27_GCam_5.1.018_24_v3.8.apk (Standard lens)

ROM: Custom LineageOS 15.1 build from original sources. No mods only added some apk's builtin.

Taking a picture with enabled hdr+ and disabled flash does nothing. Click sound is present but no picture will be saved.

Enable flash or disable hdr fixes the problem.

Taking pics with hdr+ and flash works.

By the way: how about the possiblility to combine both apps? It would be much easier to use.
[Google Camera Mods] nevernding:
cstark27 was working on it a while ago. I remember that there was some issue with the fine tuning of each camera when toggling between them.

If I may: Wouldn't it be fairly simple to add a button to switch between the normal and wide angle camera app from the other app ? That would be very useful (to me at least!) and surely it is feasible. ?

Anyway thanks for the hard and wonderful work so far ! ?

(A happy LG G6 owner)
[Google Camera Mods] hawkeyexp:
The best solution would be same as in current lineage builds: The toggle cam button toggles this style: rear normal -> rear wide -> front -> start again at rear normal
[Google Camera Mods] cstark27:
Want to try this one? LG_Q7_GoogleCamera_4.2.035-armv7a.apk It's pretty basic, no additional settings - was just trying to get a working one going on the LG Q7+ I have at the moment.

[MENTION=8472543]fu24[/MENTION] I can't find where to change Camera ID on V4.2 - plus no device to test with anyway. Try:

OneCamera$Facing.smali

CameraDeviceVerifier.smali

Camera2OneCameraManagerImpl.smali

AndroidCamera2AgentImpl.smali

CameraActions.smali

Credit to [MENTION=377973]defcomg[/MENTION], used one of his versions to see how to edit 4.2.035.
[Google Camera Mods] andreisalvatorro:
The stock camera app just crops the front sensor when it's on "normal".

The only way to do it in the Google Camera would be to zoom/crop the sensor data. Though, Portrait Mode kind of mimics this already since it zooms to 1.5x by default.
[Google Camera Mods] bobstone:
Every time I open these links, it starts to open up a drive Link, hangs and crashes. Do you have other links?
[Google Camera Mods] cstark27:
There's alternative download link in the OP. Or download the Drive app and click a Drive link then press back once it shows the little loading dialog, open Drive, pull down to refresh. Should see what you just tried to download at the top. Long press it>Download.
[Google Camera Mods] koboltzz:
I am not [MENTION=4929684]Sergykm[/MENTION] you are referring to, but I tried both of them:

His suggestion:

MGC_3.2.045_FINAL_3.4

and your suggestion:

LG_Q7_GoogleCamera_4.2.035-armv7a

Result: On Oreo V30 StockROM, MGC_3.2.045 does not provide working ZSL which is essential for me. LG_Q7_4.2.035 does not even launch, error message 'process was repeatedly terminated'.
[Google Camera Mods] cstark27:
Dang, it worked on a G6. ?

I'm not sure v3.2 had Pixel ZSL HDR+ config yet. That may have been v4.0+.
[Google Camera Mods] fu24:
The syntax of this 4.2 version is similar to 3.2.

I have also tried to find where I can switch camera id.

But after I tried it a few times, I gave up.

When I have time, I will try again.
[Google Camera Mods] vnvman:
This is quite odd. I was on Oreo (stock) and the app worked no problem, but after the security update camera only works on burst mode, and when flash is toggled it just closes when trying to snap a pic. I cleared data and all but none seems to help. Any hint?
[Google Camera Mods] SHIVALP123:
Hey [MENTION=1921483]Cstark[/MENTION]. There is a nice working camera mod of huawei P20 pro for other huawei phones. Is it possible to get it working in V30 ?? The simulated bokeh mode which has variable aperture is something which is too good for a smartphone. Is it possible to get it atleast?
[Google Camera Mods] PhantomAndroid:
Hi cstark, I noticed another version of the GCAM app in this forum has the option to save all the "portrait mode" photos in the same folders instead of breaking them out into many different folders. Would it be possible to port this feature over to your app?

Also, would it difficult to change the naming scheme on normal HDR+ photos to the same numbering scheme as the BURST/Portrait photos? I noticed that Snapseed seems to group photos numbered this way after the edits which I think is a good thing. However, on normal photos it doesn't group things together, resulting in multiple copies of the same photo dispersed across the gallery.

Thanks for all your updates to the app so far! I really appreciate it.
[Google Camera Mods] stewie-droid:
Samsung beauty mode lol ...little humor
[Google Camera Mods] Disastrinho:
Im confused 😕

What is the best version for lg g6 h870ds?

Thanks.
[Google Camera Mods] Youms:
Great ports, kudos. Working great on my v20.
[Google Camera Mods] ChazzMatt:
What? No complaints, complicated questions or demands to make this work on some obscure phone?
[Google Camera Mods] Maverick-Legacy:
Soo about the issues some are having with the oreo update and the app even with all the "fixes" applied, try putting the HDR mode into HDR+ Enhanced this fixed the reboots/crashs issues i was having with the app :)
[Google Camera Mods] Youms:
That i will check with time, but up till niw i have tested the different modes without futher configuration. The only problem i face is the time to process the images ;) Front and Back cams work with no problems till now.
[Google Camera Mods] stewie-droid:
v 3.9 test apk normal and wide working great, no issues on my V20 H918. Just wanted to provide feedback.
[Google Camera Mods] RockStar2005:
Nice! Thanks stewie.

When v3.9 official for both standard and wide go live/get posted, I will definitely check them out!

I assume links to both will get posted here when they do?
[Google Camera Mods] stewie-droid:
Dev listed a link in his original post. 3.9 is posted as test thought but works without any issue on my v20

https://www.celsoazevedo.com/files/android/google-camera/dev-cstark27/
[Google Camera Mods] viktor92:
What are the improvements ??