yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] Doc Sniper:
The main changelog is:

What's new in 3.2.3-0:
* Fix automatic installing of OTA zips on encrypted devices
* Remove SuperSU from TWRP
* Support both md5 and md5sum file extensions when doing MD5 checking for zip files
[OnePlus 3 & 3T Cross Device Development] laupuy:
Thanks :good:

I don't have twrp's app but you can see full changelog on gerrit (see what is merged): https://gerrit.omnirom.org/#/q/project:android_bootable_recovery

:p

3.2.3	Merged

enable md5sum digest verification	Merged

Fix installing OTAs without decrypting	Merged

Fix ld.config.txt errors on Android 8.1 system root devices	Merged

language: italian: Fix SELinux support label	Merged

Remove SuperSU	Merged
[OnePlus 3 & 3T Cross Device Development] Doc Sniper:
FYI

For those who have read about the decryption problem on one of my two 3Ts and all of you with decryption problems in TWRP.

My decryption problem seems to be fixed now with TWRP 3.2.3-0, maybe yours too.

Thus I saved myself a reformat and I need neither the "old" TWRP nor RedWolf nor BlueSpark.
[OnePlus 3 & 3T Cross Device Development] SpasilliumNexus:
Nice. Can't wait to try out automatic OTA installs later this week. I was wondering why the previous release didn't do it on OmniROM, and never thought being encrypted could've been the issue.
[OnePlus 3 & 3T Cross Device Development] jc1266:
Hi all ..

I am new user op3 . My device is os 5.0.5 Oreo . I like to install twrp and magisk root . I am confused . Can someone help me . Which twrp shall I download. And the proper way . I came from Nexus family.

Thanks in advance .

Sorry for my poor English.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Install the latest TWRP from https://dl.twrp.me/oneplus3/

Use the latest stable Magisk from https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445/post68966662
[OnePlus 3 & 3T Cross Device Development] jc1266:
Which is the stable version for op3 twrp
[OnePlus 3 & 3T Cross Device Development] :
twrp-3.2.3-0-oneplus3: https://dl.twrp.me/oneplus3/twrp-3.2.3-0-oneplus3.img
[OnePlus 3 & 3T Cross Device Development] jc1266:
Can you please show me the step to flash the twrp ..abd and fastboot being install on computer ..I am worry it can't boot bcoz of the dm-verity
[OnePlus 3 & 3T Cross Device Development] denny666555:
steps are on website and dm-verity happens only if you boot trwp into stock rom so dont do what.
[OnePlus 3 & 3T Cross Device Development] Dirk:
Have a read of this guide. It's a little outdated but gets the job done. It assumes you know how to unlock your Bootloader and have already done so:

https://www.xda-developers.com/how-to-install-twrp/

Once installed use it as needed. For Custom ROMs you don't need to worry about NoVerity. Just be aware that Unified ROM builds require a seperate Firmware .Zip to be flashed before the ROM and Gapps. If you intend to use Official OxygenOS builds you need to either flash a matching NoVerity Firmware after the ROM, or install Magisk.
[OnePlus 3 & 3T Cross Device Development] :
Though evry single word from [MENTION=1763460]Dirk[/MENTION] and [MENTION=9389733]denny666555[/MENTION] are true and helpful, I guess you probably want to start with more basic reading: https://xdaforums.com/oneplus-3/how-to/oneplus-3-how-to-unlock-bootloader-t3398733
[OnePlus 3 & 3T Cross Device Development] Notor1ouS-:
hi there.

i recently full-wiped, because i wanted to switch to ext4.

i was coming from lineageOS15.1, no encryption and f2fs on /data.

after full-wipe, flashing lineageOS15.1 and root (magisk), i now get a password prompt on twrp boot (cant update my rom anymore now).

my android shows me "not encrypted", i also removed all my PINs and fingerprint. i also dont get a password prompt on android boot.

how can i remove the password on twrp /data? should i full-wipe again?

iam using twrp twrp-3.2.1-0-oneplus3.img on a oneplus 3T
[OnePlus 3 & 3T Cross Device Development] vivian&ondine:
Update to latest TWRP 3.2.3-0.
[OnePlus 3 & 3T Cross Device Development] Notor1ouS-:
[MENTION=7009345]vivian&ondine[/MENTION] thx! it worked.
[OnePlus 3 & 3T Cross Device Development] :
Someone who can tell when we can expect 3.2.3.1 with latest changes and full Pie support?

I know 3.2.3.0 is working, using it myself but get some strange ld.config warnings in twrp terminal when /system is mounted, which is giving me the idea some paths are not corresponding.

Could be wrong ofcourse, but have this with MSM and NOS pie
[OnePlus 3 & 3T Cross Device Development] henningsieh:
Can you provide a screenshot or copy/paste?
[OnePlus 3 & 3T Cross Device Development] :
[MENTION=8357285]henningsieh[/MENTION] ofcourse;

First screenshot is with /system mounted, second without; both terminal in twrp.

Any idea what the cause could be, is it twrp?

When I use the terminal from NOS (can be enabled in developer settings), no warnings are showing up...
[OnePlus 3 & 3T Cross Device Development] Randomsanity:
Sorry, wrong thread.
[OnePlus 3 & 3T Cross Device Development] vinoxflame:
firmware? yesterday's build? I think you posted on the wrong thread.
[OnePlus 3 & 3T Cross Device Development] █████:
Where can I download TWRP? You only linked the Git repository. No flashable zip, img,... ?
[OnePlus 3 & 3T Cross Device Development] casual_kikoo:
Really ?
[OnePlus 3 & 3T Cross Device Development] Dirk:
The link is in the OP.

https://dl.twrp.me/oneplus3/
[OnePlus 3 & 3T Cross Device Development] █████:
Yo Mr. Toxic just look at my picture and stop wasting our time. Thx.

No. It is actually not. Do you want a screenshot too? lol
[OnePlus 3 & 3T Cross Device Development] mk_1996:
Showing here perfectly. I clicked the first link and its downloading.
[OnePlus 3 & 3T Cross Device Development] Dirk:
It's right there in the screenshot that YOU posted:

lol?
[OnePlus 3 & 3T Cross Device Development] henningsieh:
The only thing, you did not commented in red color, is obviously the correct section... and is named "Download Links" therefore. :confused:

So, what are you looking for in detail?

---------- Post added at 08:09 PM ---------- Previous post was at 08:07 PM ----------

I have been too slow! ;)
[OnePlus 3 & 3T Cross Device Development] :
Folks, I really think we've got trolled.

If I would really belive someone is not able to find the download from OP, I don't think it's a good idea to empower that person to use twrp on her/his device. It's like giving a muscle car to someone who failed his driving licence exam three times - including the last one.
[OnePlus 3 & 3T Cross Device Development] Dirk:
Arthur C. Clarke said "Any sufficiently advanced technology is indistinguishable from magic". It also works if you replace two of those words with 'dementia' and 'trolling'.
[OnePlus 3 & 3T Cross Device Development] mk_1996:
Moral of the story:never make a fool outta yourself. Especially on a forum like xda where ppl are known as legendary flamers?
[OnePlus 3 & 3T Cross Device Development] Dirk:
As flaming is clearly in violation of the rules, we prefer 'sardonic wit'. After all, any sufficiently advanced sarcasm is indistinguishable from flaming! ;)
[OnePlus 3 & 3T Cross Device Development] gcross:
I'm trying to debrick my 3T after it fell down the toilet! I was able to boot to fastbootloader and recovery but the main system just gives a blank screen.

I tried MSM download tool - all appeared to complete successfully but still when I boot normally 2 lights flash at the bottom and the light top left stays on but nothing else.

I wantto try TWRP to try to fix the issue ? But I can't unlock the bootloader So I tried using MSM download tool by replacing recovery.img with a TWRP image but this gives me recovery failed due to MD5 checksum errors

Any suggestions ?
[OnePlus 3 & 3T Cross Device Development] :
You can't flash twrp without unlocking the boot loader. (BTW: if that would be possible, for what good? You can't use it for flashing at all as long as the bootoader is locked.)

The issue you need to fix in the very first place is:

If you can boot to fastboot mode, what's your problem? What does "fastboot oem unlock" retrun?
[OnePlus 3 & 3T Cross Device Development] gcross:
fastboot oem unlock returns

OEM unlock not allowed
[OnePlus 3 & 3T Cross Device Development] Dirk:
'OEM Unlocking' would need to be enabled on the device in Developer Options wouldn't it? Is there a way round this if he can't boot into a working OS?

Are you still able to boot into stock Recovery? Have you tried flashing an OOS ROM with it?

https://www.oneplus.com/uk/support/softwareupgrade/details?code=6
[OnePlus 3 & 3T Cross Device Development] :
If I remember correctly, you can boot to stock recovery, arn't you?

Put stock 5.0.6 for your device on an usb stick (you can skip that, if it's already on your data partition). Boot stock recovery and flash the rom's zip.
[OnePlus 3 & 3T Cross Device Development] gcross:
My suspicion is the filesystem is corrupted. I want to try to fix it with TWRP.

So I need some way to install TWRP without OEM unlock or some other way to unlock

But I'll try booting installing from a USB although I'm not hopeful as adb and msmdownloadtool failed to install it.
[OnePlus 3 & 3T Cross Device Development] :
If that fails, you can try unpacking the rom's zip and flash boot.img, system.img and userdata.img from fastboot.

If flashing the rom's zip fails and flashing *img via fastboot fails and unbricking with msmdownload fails: rma.

My suggestions arn't about probability, but about trying everything before rmaing... Crossing fingers!
[OnePlus 3 & 3T Cross Device Development] :
3.2.3-1

Does formating and reencrypting a 128 GB device work?

https://github.com/TeamWin/android_...mmit/92e9b432dd5b1c543b406d568820b8bf7d5b38cf
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
just to address the bug above
[OnePlus 3 & 3T Cross Device Development] :
Yep, and I'm pretty sure it will work for 64 GB devices - I'm just wondering, if it works on a 128 GB device. If the mkfs takes the size from the value in BoardConfig.mk, what does that mean for a 128 GB data partition? I would be more than happy if it works for both devices!
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
It'll work, but won't reverse crypto footer on both 64GB and 128GB devices. Check TWRP's mkfs command: https://github.com/omnirom/android_bootable_recovery/blob/android-8.1/partition.cpp#L2219 , partition size is calculated at runtime, the hardcoded value isn't actually in use. In short, TWRP's format function will format the whole partition for now, no crypto footer will be reversed.

I may submit a fix to TWRP when I have time.
[OnePlus 3 & 3T Cross Device Development] :
Oh, ok. The comment in this line: https://github.com/TeamWin/android_...543b406d568820b8bf7d5b38cf/BoardConfig.mk#L66 put me on the complete wrong track... It seems so clear to me that the reservation for the crypto footer is done here, that I've not checked anything else.

If one wants to encrypt the device againmafter formating the mkfs has to be issued manually (with size - 16384, of course), or use 3.2.3-0 (for ext4 only, obviously), isn't it?
[OnePlus 3 & 3T Cross Device Development] :
Fresh TWRP: https://dl.twrp.me/oneplus3/twrp-3.2.3-1-oneplus3.img.html

Changelog ?
[OnePlus 3 & 3T Cross Device Development] :
For op3/t: https://github.com/TeamWin/android_device_oneplus_oneplus3/commits/android-8.1 commits from Nov 29.

(BTW: that's what I'm talking about. ;) )

support dash charging in twrp

kernel update to los 16.0

fix broken mkf2fs
[OnePlus 3 & 3T Cross Device Development] laupuy:
thanks, and Changelog is also on twrp.me https://twrp.me/oneplus/oneplusthree.html

bottom page

Changelog:

dianlujitao

2018-11-29T10:28:52Z

op3: Update prebuilt kernel * HEAD: https://github.com/LineageOS/androi...mmit/231553dd7803ac9120aae9bdbda14645552c804a Change-Id: I6836f648a42fc8ab9dd3ef3f36756e6f52d16c73

dianlujitao

2018-11-29T09:55:26Z

op3: Ship dashd for fast charging in TWRP Change-Id: Idb0617f8107202cebb8901ce3f829fcd45d08495

dianlujitao

2018-11-29T09:44:38Z

op3: Remove crypto footer length from fstab * Explicitly setting crypto footer length breaks mkfs.f2fs * Set correct userdata size as well Change-Id: I19963da638c04ac48f0548bab534a62b5ec2217b

Edit

but Nvertigo has already said everything.

:)
[OnePlus 3 & 3T Cross Device Development] Dirk:
This would be so frustrating for someone flashing a custom ROM for the first time. Told to use latest TWRP and then wonder why device won't Encrypt. No wonder the forum gets filled with questions. Nobody knows what's happening and there's FUD all around.

If 3.2.3-1 won't Encrypt, shouldn't it be pulled and all links to it removed?
[OnePlus 3 & 3T Cross Device Development] :
twrp can't encrypt and never was able to.

If you format data with 3.2.3-1, you can't encrypt it with any rom.

This behavior IS INTENDED for now, because it fixes the issues with formating as f2fs. See: https://xdaforums.com/showpost.php?p=78324758&postcount=356

Because it is intended and explained in this thread, I see no reason to pull it. We all know it now. Atleast for n roms everybody can use 3.2.3-0 (though ext4 is strongly recommended you can use this https://xdaforums.com/showpost.php?p=75688089&postcount=4 workaround for f2fs), and for p roms you can use 3.2.3-1. If you want to use 3.2.3-1 for formatting and maintaining encryptablity you can easily manually mkfs with the appropriate size (full_userdata_size - 16384).
[OnePlus 3 & 3T Cross Device Development] Dirk:
Nobody should have to do that. Bottom line, Format Data as ext4 and keep using 3.2.3-0 for now.
[OnePlus 3 & 3T Cross Device Development] :
To make things a bit more challenging:

I think there is a medium probability, that this: https://xdaforums.com/oneplus-3/one...en-os-beta-t3737654/post78319640#post78319640 fff. relates to 3.2.3-1.

I'm not sure, but I can't say for sure it's not connected (or a side effect) to the removal of the encryption footer...
[OnePlus 3 & 3T Cross Device Development] Dirk:
There's nothing to suggest he used 3.2.3-1. In his original post he only said that his fs was ext4, but didn't state which TWRP build he was using. You suggested using 3.2.3-0 which is when he reported Error 7 errors. I can't imagine what's causing his issues but it's probably nothing that a step-by-step guide wouldn't fix.

I just updated my Recovery from 3.2.1-0 (Oreo) to 3.2.3-0. Formatted Data from f2fs to ext4. Moved files back to Storage and Restored Nandroid. Everything went fine. (TWRP warned that a Nandroid made in f2fs might not restore on ext4, but it worked out fine).

TWRP starts much faster on ext4 than on f2fs. (I'm sure this was mentioned before).

Edit: Phone was Encrypted before and remains so after.
[OnePlus 3 & 3T Cross Device Development] :
Should OOS do the force encryption? just to make things clear with nvertigo statement

So some of the users start getting hazard after formatting the data? God loves me for telling me to wipe-only when trying NOS yesterday and see the result
[OnePlus 3 & 3T Cross Device Development] :
Without reencrypting? Either you use a rom wich auto encrypts on first boot, or you have formated the md0 container (the encryptetd part of the partition).

If you format sda15 (the partition itself) the encryption is definetly removed.

You can check more easyily if you've set an encryption passphrase, because if you do the recommended reboot after formating and get not ask for a pasaphrase when twrp comes up, you know ncryption has been removed - if the passphrase is required you havn't formated sda15 but only the md container.

I've never expirienced only formating the md container, but from the reports of some people not beeing able to remove encryption from data, I guess this happens if you have enabled encryption, but with no passphrase set (aka default_passwordd) and using the Format Data button.

To be absolutly sure you format sda15 (and therefor remove the encryption from data) and not the md container (which leaves encryption in place):

twrp home screen->Wipe->Advanced Wipe->check Data->Repair or Change File System->Change File System:

If the screen shows that your device is already on ext4, change to any other fs and apply the new fs by swiping. Without a reboot change back to ext4, apply and reboot to recovery.

---------- Post added at 19:39 ---------- Previous post was at 19:29 ----------

Generally: yes. But there is an Magisk setting to disable it, but I've never used it and can't say how to enable/use this.

I'm not sure. But those hazards after formating data may relate to the missing encryption header. I've also no clue, what happens if you try to start OxagenOS without forced encryption disabled on an unencrytable data partition.
[OnePlus 3 & 3T Cross Device Development] Dirk:
I wasn't using on-boot security. After restoring nandroid everything is working as before. Data is now ext4 and device shows as Encrypted in Settings.
[OnePlus 3 & 3T Cross Device Development] knpk13:
This is all quite confusing. I am using NLOS, and I'm on ext4 unencrypted (formatted with TWRP 3.2.3-0). I saw a new TWRP version and upgraded to it (3.2.3-1) and I get this error whenever I use TWRP. I'm not sure what it means.

I didn't understand the technical explanation by [MENTION=4405529]nvertigo67[/MENTION] on the NLOS thread, but apparently there are different bugs with both TWRP versions according to him. I have not personally checked whether those bugs exist though since I lack the technical knowledge to understand what's going on. I'm just approaching this as a user trying to figure out what TWRP to use.

Claimed Bugs: Formatting to f2fs is broken on 3.2.3-0. The update fixed that bug but introduced a new bug which does not let you encrypted data if the partition was formatted with 3.2.3-1. I also get the error in the screenshot whenever I try to use TWRP 3.2.3-1.

I do agree with [MENTION=1763460]Dirk[/MENTION] and hope we can get one recommended version of TWRP instead of being confused as to which version to use depending on which bug is ok. I am going to revert to 3.2.3-0 for now as everything was working fine on that for me with ext4 unencrypted. The easiest solution for new users is to probably just stick to fastboot to format partitions (since it seems there are different bugs with formatting partitions on both recent versions on TWRP) and use the latest version of TWRP for other operations, from what I understand.

Edit: Link to [MENTION=4405529]nvertigo67[/MENTION] 's explanation for the technical details

https://xdaforums.com/oneplus-3/one.../rom-nlos-15-1-20180223-t3754855/post78326684
[OnePlus 3 & 3T Cross Device Development] Dirk:
I agree.

I'm wondering now if i should have just stuck with 3.2.1-0. I probably could have used that to format data to ext4. Is anything newer than 3.2.1-0 actually necessary? If so, why? Can Pie ROMs be flashed with 3.2.1-0?

So many questions. :)
[OnePlus 3 & 3T Cross Device Development] :
OOT

I'm a bit confused by the words of encrypted/decrypted/unencrypted and all the mess it brings.. someone with english as a primary languange should clear this up..

InMyStupidOpinion, as i am not a native english speaker/writer, there should be only 2 words. It's ENCRYPT and DECRYPT. There is an ENCRYPTION and DECRYPTION, ENCRYPTED and DECRYPTED. Unencrypted words should be removed from our dictionary :highfive:

LOL :laugh::laugh::laugh:
[OnePlus 3 & 3T Cross Device Development] :
I've tested formating ext4 (as well as f2fs with the workaround I've reffered to earlier) with 3.2.1-0 (oreo) and 3.2.3-0. All four cases produced a data partition, which were successfully encrypted with nlos. I don't know for pie roms, but for los and nlos 3.2.1-0 is as safe to use as 3.2.3-0.

Everybody, please keep in mind, that it's not my fault that the combination of filesystems, vold (volume manager and commander in chief of userdata partition container), recoveries and encryption is a bit technical - I really try my best to explain. I'm only the messenger... :(

---------- Post added at 20:50 ---------- Previous post was at 20:43 ----------

encrypting is the proces of making the data partition passphrase secured. (if data is encrypted, but no boot passphrase is set, the password defaults to "default_password")

decrypting is making the encrypted device readable again by providing the passphrase. (twrp and rom know about "default_password" and don't ask for it)

unencrypting is the proces of removing the encryption again from data: i.e. if you forget your passphrase - this requires to format the raw partition (sda15)

You need all three terms.
[OnePlus 3 & 3T Cross Device Development] Dirk:
Do we need a new version for Pie? People seem to be getting along alright with current versions.

Lastly, does my lack of on-boot security clear up your confusion with my recent changes? I guess if i did have on-boot security i might have run into problems. That would explain why some people remove all security before taking a Nandroid. A necessary step if you have on-boot, not necessary if you don't?

---------- Post added at 21:26 ---------- Previous post was at 21:11 ----------

One TWRP to rule them all, One TWRP to flash them; One TWRP to Root them all, and in the darkness blind them.

Paraphrasing there of course! :)
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
This is an experimental build trying to preserve crypto footer on format: https://androidfilehost.com/?fid=11410963190603865726

Note that I didn't test formatting /data, but in theory it should work. Please give feedback for both ext4 & f2fs formatting.

For devs: relative patch: https://gerrit.omnirom.org/#/c/android_bootable_recovery/+/33021/

-----update0

New experimental build which will wipe crypto footer after format https://androidfilehost.com/?fid=11410963190603865790 [MENTION=2911853]BillGoss[/MENTION] you may wanna try it

confirmed not working

-----update1

This one is tested working https://androidfilehost.com/?fid=11410963190603865871 encrypt works on both ext4 & f2fs

-----update2

This one fixes ext4 encryption on Pie: https://androidfilehost.com/?fid=11410963190603866112
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Results of my testing:

Starting point: 128 GB OnePlus 3T, OOS 5.0.7, Magisk 17.1, /data encrypted f2fs with on-boot password

Using TWRP 3.2.3-1:

- formatted /data to ext4 without errors

- formatted /data to f2fs without errors

- verified that /data was empty and that the size was correct

- rebooted to TWRP and was prompted for my on-boot password

- decrypted /data successfully

- restored OOS backup

- restored some files to my internal storage using ADB

- rebooted system successfully (prompted for my on-boot password)

- phone says that it's encrypted.

I'm pleased that it all worked and I ended up where I started from, but now I'm wondering how one would remove encryption.
[OnePlus 3 & 3T Cross Device Development] dianlujitao:
Thanks for your feedback, I may need to add logic to erase footer after format.

-----update0

I'm not sure if this is expected behavior, the "format data partition" button will does format+wipe crypto footer, while "advanced wipe" does not.
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Let me know if you need any more testing done.
[OnePlus 3 & 3T Cross Device Development] Dirk:
Thanks for working on this OP and BG for testing. Looks like you're on the right track. :good:
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Tested TWRP_3.2.1-format-fix-1_oneplus3.img by formatting /data from f2fs to ext4 then back to f2fs. Then rebooted to recovery and ...

I got prompted for my on-boot password. So it didn't remove the encryption.

Just wondering, based on your comment about wiping removing encryption, but not formatting, whether that is intended behaviour. This would allow you to change format whilst retaining encryption. And if you want unencryption then you need to wipe.

If that's the case, them 3.2.3-1 would be working as intended.

But users would need to know that formatting maintains encryption, and that wiping removes it.