yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] marcdw:
I thought I was quite polite, actually. Oh well. Sad.

Moto G5S Plus XT1806, Liquid Remix v9.1.4 ROM, MultiROM, XDA Legacy
[Xposed Framework Modules] beeshyams:
For those insisting on Pie update please see this post

https://xdaforums.com/showpost.php?p=79037482&postcount=428

And posts following

In short - module is ready but EdXposed isn't ( hasn't fixed all bugs) .

Blame no one and support all developers

And wait patiently for issues to be resolved
[Xposed Framework Modules] mrjuniork:
And this one :)

https://xdaforums.com/xposed/list-xposed-modules-android-pie-ed-t3892768/post79041913
[Xposed Framework Modules] beeshyams:
Yep. Thanks for making it explicit though I mentioned "and posts following" !
[Xposed Framework Modules] Fabian Rï¿½ling:
Screen recording time limit greyed out

Fairphone 2, LineageOS 15.1

The "time limit" option in the screen recording screen is greyed out and stuck at 3 minutes. Why is that the case? Or is it a bug? Can I somehow get around that without installing a separate screen recorder?
[Xposed Framework Modules] C3C076:
It's a limitation of Android's stock screen recording binary: https://android.googlesource.com/pl...1.0_r61/cmds/screenrecord/screenrecord.cpp#64

Currently I do not have a custom binary that would allow longer times or even audio recording.
[Xposed Framework Modules] C3C076:
Version 8.5.2-edxposed available

This version is compatible with EdXposed and is designed for those who don't mind sacrificing some functionality in favor of blacklist/whitelist support in EdXposed.

APK is available in the second post of this thread (Won't be incluced in Xposed Respoitory for now).

Features removed due to missing resource hooking support

- Enable H+ indicator

- Unlink ring and notification volumes

Features not working due to issues in EdXposed*

- Increasing ringtone

- Torch on power long-press

*There may be more I may have missed during my quick tests

Requirements

- Magisk v17 or later

- Riru v16 or later

- EdXposed v0.3.0.0-beta2 or later

- EdXposed Manager v2.2.1 or later

Required whitelisted packages

- Android System (android)

- System UI (com.android.systemui)

- Call Management (com.android.server.telecom)

- Download Manager (com.android.providers.downloads)

- Phone (com.android.dialer or com.google.android.dialer)

- Phone (com.android.incallui) (OxygenOS only)
[Xposed Framework Modules] DeathWishXIV:
There is a issue with the stock lockscreen on Sony XZ2, it looks like gravitybox is in a conflict with stock.

Issue: after lock and wait a few secs (5-10) then unlock with power button it looks like a lag!! Pressing power button and then it takes some time to unlock.

Now my question is it possible to build in a on/off switch for lockscreen tweaks?

Thanks
[Xposed Framework Modules] KaMyKaSii:
Tested and working well on my Zenfone 4. One comment I would like to make is that when opening GravityBox (before activating it in EdXposed and restarting) and minimizing it before the message that the framework could not be contacted, the app crash with the following stack trace:

java.lang.NullPointerException: Attempt to read from field 'int android.app.Fragment.mIndex' on a null object reference
at android.app.FragmentManagerImpl.putFragment(FragmentManager.java:905)
at com.ceco.oreo.gravitybox.GravityBoxSettings.onSaveInstanceState(GravityBoxSettings.java:1193)
at android.app.Activity.performSaveInstanceState(Activity.java:1516)
at android.app.Instrumentation.callActivityOnSaveInstanceState(Instrumentation.java:1386)
at android.app.ActivityThread.callCallActivityOnSaveInstanceState(ActivityThread.java:4799)
at android.app.ActivityThread.performStopActivityInner(ActivityThread.java:4104)
at android.app.ActivityThread.handleStopActivity(ActivityThread.java:4163)
at android.app.ActivityThread.-wrap24(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1630)
at android.os.Handler.dispatchMessage(Handler.java:105)
at android.os.Looper.loop(Looper.java:169)
at android.app.ActivityThread.main(ActivityThread.java:6585)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Not a real problem but anyway
[Xposed Framework Modules] okij:
Thanks a lot for so quickly providing an EdXposed version of GB for Oreo! :good: Very much appreciated! :)

Also

- Show brightness icon

- Brightness Settings in Display Tweaks

- Enable lockscreen rotation

aren't working here (Sony Z3c on AOSP based CarbonROM). They are working with the normal Xposed version of GB.

Can you probably make these features work again or is it a general issue of EdXposed?
[Xposed Framework Modules] Normas Interruptor:
Just wondering is this version compatible with Android P?

As i have just notice on Play Store 'Gravity Box Unlocker' updated with Android P support.

Or Gravity Box P having new thread?
[Xposed Framework Modules] KaMyKaSii:
Exactly

https://xdaforums.com/xposed/modules/app-gravitybox-v9-0-0-beta-1-android-9-t3908768/post79066435
[Xposed Framework Modules] C3C076:
For "enable lockscreen rotation" try using Advanced Tuning / Framework section to override parameter shown in attached screenshot.

Whether those feature will work or not in the future depends on EdXposed functionality.

Some methods cannot be hooked due to ART compiler optimizations and what's worse that experience can vary across systems

depending on how they were built. E.g. you can have 2 different builds of the exactly same Android system but features which work on one don't need to work on another one

because the systems might be built with a different set of optimizations.
[Xposed Framework Modules] okij:
Thanks a lot for your explanations! :)

Unfortunately this doesn't work for me either. Therefore I went back to a different method by adding lockscreen.rot_override=true to build.prop. Some months ago I made a small Magisk module for this purpose, before I saw the Enable lockscreen rotation option in GB.

So I'll keep my fingers crossed for further improvements. :fingers-crossed:
[Xposed Framework Modules] KaMyKaSii:
[MENTION=5008415]C3C076[/MENTION] now that I have been using it for longer I realized that Advanced Tuning correctly shows the Framework parameters but the SystemUI screen is blank. Attached are the EdXposed log and a boot log, I hope it is enough
[Xposed Framework Modules] C3C076:
Strange it works on my OP3T. Please, open issue at github so I can get back to it later. We will need to do some debug logging as I cannot see anything relevant in the log. Did it work with normal Xposed before?
[Xposed Framework Modules] KaMyKaSii:
I did not get to install the official Xposed so I can not tell if it works or not. I just upgraded Riru Core and EdXposed to v17 and v0.3.1.2, respectively and it seems that the log is more complete now. I'll open the issue with the new logs and the SystemUI apk but if it really is a problem specifically for being ZenUI, I will understand if you do not want to spend your time
[Xposed Framework Modules] C3C076:
Yes, it is possible that required "R" classes were not compiled into the system UI. I would probably need to implement similar workaround I had to do for Nougat
[Xposed Framework Modules] raven428:
afterboot loop

I got afterboot loop with Asus ZenFone M1 Pro stock firmware (link to video). Magisk version is 18.1 (18100), Riru version 17, EdXposed version 0.3.1.2_beta. Also tried Magisk version 18.2 canary builds, Riru version 16 and EdXposed version 0.3.0.0_beta2 - same result.

How to fix it?
[Xposed Framework Modules] C3C076:
Hard to tell without seeing logcat taken during boot.
[Xposed Framework Modules] raven428:
logcat

Sorry, first didn't figured out how to collect it while SystemUI crashes. There is it now.
[Xposed Framework Modules] C3C076:
Looks like EdXposed related.

03-16 13:39:45.338 9349 9349 F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
03-16 13:39:45.338 9349 9349 F DEBUG : Build fingerprint: 'asus/RU_X00TD/ASUS_X00T_6:8.1.0/OPM1/15.2016.1901.339-20190108:user/release-keys'
03-16 13:39:45.338 9349 9349 F DEBUG : Revision: '0'
03-16 13:39:45.338 9349 9349 F DEBUG : ABI: 'arm64'
03-16 13:39:45.338 9349 9349 F DEBUG : pid: 9270, tid: 9284, name: Profile Saver >>> com.android.systemui <<<
03-16 13:39:45.338 9349 9349 F DEBUG : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
03-16 13:39:45.340 9349 9349 F DEBUG : Abort message: 'profile_saver.cc:359] Check failed: method.GetCounter() == 0u (method.GetCounter()=535, 0u=0) java.lang.CharSequence com.android.systemui.statusbar.policy.Clock.getSmallTime!() access_flags=34078994'
03-16 13:39:45.340 9349 9349 F DEBUG : x0 0000000000000000 x1 0000000000002444 x2 0000000000000006 x3 0000000000000008
03-16 13:39:45.340 9349 9349 F DEBUG : x4 00000000005b5ca8 x5 00000000005b5ca8 x6 00000000005b5ca8 x7 00000000001fffff
03-16 13:39:45.340 9349 9349 F DEBUG : x8 0000000000000083 x9 0000000010000000 x10 0000007df5f4cff0 x11 30f7c70b6550914a
03-16 13:39:45.340 9349 9349 F DEBUG : x12 30f7c70b6550914a x13 0000000000000000 x14 ffffffffffffffdf x15 0000007e8ee7a8a8
03-16 13:39:45.340 9349 9349 F DEBUG : x16 000000041f781fa8 x17 0000007e8edfce6c x18 0000007e0e200080 x19 0000000000002436
03-16 13:39:45.340 9349 9349 F DEBUG : x20 0000000000002444 x21 0000000000000083 x22 0000007df2c56680 x23 0000007df5f4d089
03-16 13:39:45.340 9349 9349 F DEBUG : x24 0000000000000060 x25 00000000000000c1 x26 00000000000000b0 x27 0000007e0dbf4e9a
03-16 13:39:45.340 9349 9349 F DEBUG : x28 0000000000000217 x29 0000007df5f4d030 x30 0000007e8eda3630
03-16 13:39:45.340 9349 9349 F DEBUG : sp 0000007df5f4cff0 pc 0000007e8eda3658 pstate 0000000060000000
03-16 13:39:45.341 9349 9349 F DEBUG :
03-16 13:39:45.341 9349 9349 F DEBUG : backtrace:
03-16 13:39:45.341 9349 9349 F DEBUG : #00 pc 000000000001e658 /system/lib64/libc.so (abort+120)
03-16 13:39:45.341 9349 9349 F DEBUG : #01 pc 00000000000c7f60 /system/lib64/libart.so (offset 0x386000)

Try to report it here: https://github.com/ElderDrivers/EdXposed/issues
[Xposed Framework Modules] C3C076:
Version 8.5.3 and 8.5.3-edxposed available

Changelog 8.5.3 - 17/03/2019

- Improved Fingerprint Launcher compatibility

- GravityBox Actions: fixed SIM Settings actions compatibility

- Advanced Tuning: fixed missing SystemUI parameters on some devices (e.g. Asus)

- CircleBattery: adjusted outline color for visibility on white background

- Key Actions: redesigned Torch on Power Longpress for better compatibility

- Phone tweaks: optimized Increasing ring feature

- Other minor fixes and improvements backported from Pie branch

- Updated Russian translations (thanks to gaich)

Changelog 8.5.3-edxposed - 17/03/2019

- Key Actions: fixed torch on power-long press

- Phone tweaks: fixed Increasing ring feature

- Advanced Tuning: fixed missing SystemUI parameters on some devices (e.g. Asus)

- CircleBattery: adjusted outline color for visibility on white background

- Other minor fixes and improvements backported from Pie branch

- Updated Russian translations (thanks to gaich)
[Xposed Framework Modules] raven428:
CircleBattery

Something wrong with CircleBattery in 8.5.3-edxposed also as in 8.5.2-edxposed. After device boot it's working fine (screenshot 1) until I open GravityBox application. After this battery indicator fix its color on application launch time and never changing with other icons of statusbar until next boot.

Update: Battery indicator fix thei its color not only after launch GravityBox application. This happens also after some short time of device start,
[Xposed Framework Modules] C3C076:
Please, share Xposed error log made while having "Error logging" turned on in About menu of GravityBox.
[Xposed Framework Modules] raven428:
There is it. I collected it twice: second time with "force aosp" option enabled. Both times I collected logs only when battery indicator started to freeze.

Sorry, I didn't read first post with instructions like kind of bad user. I promise, usually I do this.
[Xposed Framework Modules] viktor92:
Installed v8.5.3 over v8.5.2, restarted, and the app does not respond, rolled back to v8.5.2 and still doesn't work,,,

---------- Post added at 12:54 PM ---------- Previous post was at 12:44 PM ----------

Don't know what is happening, uninstalled again, installled v8.5.0 and restarted, and GravityBox doesn't respond !!

---------- Post added at 01:35 PM ---------- Previous post was at 12:54 PM ----------

Tried EVERYTHING, nothing works, when v8.5.2 was working fine, but now neither version works...
[Xposed Framework Modules] firefds:
Try uninstalling, wipe dalvik cache and install again
[Xposed Framework Modules] C3C076:
Installer glitched which happens quite often especially for large modules. The solution is to disable and reenable module. Also another hint is to wait couple of seconds after updating module before rebooting to give installer a chance to do its job properly.
[Xposed Framework Modules] viktor92:
I've tried that too, but this time worked !! :D

Thank you all :good:
[Xposed Framework Modules] C3C076:
I don't see any error messages so everything should work fine.

Note that "Force AOSP" does not make any difference as GravityBox does not have any Asus specific adjustments.

The only way is to open issue at github where I will provide you with APK with some additional logging that could reveal what's going on.
[Xposed Framework Modules] C3C076:
Version 8.5.3.1-edxposed available

Changelog 8.5.3.1-edxposed - 18/03/2019

- CircleBattery: fixed dynamic color tinting not working on some systems
[Xposed Framework Modules] NAerop:
This means I can not now adjust the volume of notifications, regardless of the volume of the ringtone?
[Xposed Framework Modules] DeathWishXIV:
Could anyone help with post #1251 please?

Thanks
[Xposed Framework Modules] C3C076:
There is no reason for lag unless you are using "Proximity wake-up" feature in Power tweaks.

In this case, the lag is caused by waiting for data from proximity sensor to decide whether screen should be turned on or off.

Another features that could introduce a little lag in theory is Direct and Smart unlock.
[Xposed Framework Modules] DeathWishXIV:
Hi,

Thx for your answer. I tested both proximity off direct standard and smart also off.

Nothing has changed, lag is still there. By pushing power button it takes a long time til display goes on, by fingerprint it's a lil faster.

The worst thing is on incoming call then it takes so much time that the call is over.

For your information im on stock Rom 51.1.A.11.51 modded by MartinX3.

Regards
[Xposed Framework Modules] C3C076:
Definitely not a normal behavior. Even with features mentioned above enabled the lag would not be that noticeable.

I don't think disabling lockscreen tweaks would make any difference as there are no power-intensive tasks going on.

There may be other factors such as Xposed compatibility, number of xposed modules used, etc
[Xposed Framework Modules] DeathWishXIV:
Hi,

I have no other active modules than GB. My xposed installer says that framework version beta 90 is active!

So i dont know where i could find the problem.

I found also another thread on XDA that another guy have the same problem.

Thx

Update: now im on systemless magisk framework beta 3 everything tested but the issue is still there!
[Xposed Framework Modules] Ghisy:
Hi [MENTION=5008415]C3C076[/MENTION], I just realized that, if I set my navbar at less than 70%, the back and multi-tasking buttons are much smaller than the home button. Is this the intended behavior? I'm using the latest stable version of GB.

Thanks.
[Xposed Framework Modules] C3C076:
What version of Android? Scaling is different compared 8.0 to 8.1 and although I tried to cover

all the cases it is possible it might not be ideal across all devices/systems.
[Xposed Framework Modules] Ghisy:
Sorry, I'm still on Oreo 8.1 on a Pixel 2 XL.
[Xposed Framework Modules] Mikolaj612:
Hi [MENTION=5008415]C3C076[/MENTION]

I've got one question regarding your app.

At this moment my phone is LG G7 and I'm very familiar with Gravity Box due to long usage of this app with my previous phones (mostly Sony Xperia).

Right now my phone is running Oreo (8.0), which is running fine, I had original Xposed and Magisk (newest version 18.1 and Xposed as a Magisk module).

Then I switched to EdXposed due to safetynet and curiosity of testing something new.

Here's my issue, when I had original [MENTION=4419114]rovo89[/MENTION] Xposed then everything was working fine as far as I can tell (I just used few options that works well on my device).

After switching to EdXposed and reinstalling GravityBox to EdXposed version my phone behaves weird - I could boot properly, but whole UI is not rendered in any way.

I'm able to see AON (Always on Display) or reboot menu - but that's far I can go.

My fingerprint scanner is not responding, there is not haptic response also.

To get my phone working again I need to disable magisk module, then I'm able to disable/uninstall GravityBox.

Question is - does my issue had something to do with EdXposed (because it's still early beta) or GravityBox itself?

I could survive/wait for fix because LG provide many little things that I was always worried about when I was using Sony.

But after all it will be best to get this thing working again.
[Xposed Framework Modules] iva.f:
Hello [MENTION=5008415]C3C076[/MENTION]!

The increasing ring of the call does not work for me. Settings made. On similar smartphones function works. I think about the problem with my device. Could you help me find out what's wrong?

GB version: GravityBox_Oreo_8.5.3

View attachment 4734213
[Xposed Framework Modules] C3C076:
This looks like incompatibility with EdXposed to me. But I can only speculate if I don't see a logcat.

Ideally and if possible, use ADB to capture logcat while device is booting, let it output results to a file.

You have to enable "Error logging" in About section of GravityBox.

Next you have to get logs after testing that feature (after receiving a phone call while feature is enabled).

Please, direct your further info and discussion here: https://github.com/GravityBox/GravityBox/issues (open new issue for your case)
[Xposed Framework Modules] M@xFactor:
Ok, ok, I do know that EMUI 5 is not supported, but until 7.0.8 most of features work, but after that version nothing work, even previously working features... What happened so revolutionary?
[Xposed Framework Modules] dichandcheck:
Ultimate notification control - per app settings -download manager

With this version and previous I can never override the default notification sound for download manager using the ultimate notification control per app settings feature. I try to set it to none so it doesn't blow up my phone when downloading multiple files with the screen off. Has anyone else had this issue?:cowboy:
[Xposed Framework Modules] C3C076:
Depends on whether it is a normal or ongoing notification. If it's an ongoing one, you also have to check "Ongoing" checkbox.
[Xposed Framework Modules] dichandcheck:
I do have that checked but it still goes off. Wouldn't think it would be on going since it makes the notification sound when the download completes
[Xposed Framework Modules] dichandcheck:
I just turned it off in system settings, just won't have as granular control.
[Xposed Framework Modules] C3C076:
That could mean only one thing. That sound is not part of notification itself but is played directly using audio manager.
[Xposed Framework Modules] dope77:
been using the app for a long time ,used the kk mm ll versions and never experienced such problems with gravitybox

i'm using the oreo version on android 8.1.0 and this problem is really annoying,just by doing any change/tweak from gravitybox, lockscreen won't respond anymore,it'll just go black and the wallpaper would come and go each few seconds.

is there anything i can provide to fix this?
[Xposed Framework Modules] okij:
[MENTION=5008415]C3C076[/MENTION]: Now that EdXposed beta 4 supports resource hooking (Yay! :victory:), Show brightness icon and Enable lockscreen rotation are working again. :)

Only Brightness Settings in Display Tweaks still don't work here with EdXposed beta 4. I really miss them, since I prefer to have a lower minimum brightness setting and a flatter lux - brightness gradient than the ROM provides.

Are there any other prerequisites than resource hooking to make Brightness Settings work again? Or did you probably drop some of the code in GravityBox 8.5.x-edxposed which you could now add again? Or could I now switch to the normal (non edxposed) version of GravityBox again (I didn't try this yet), now that resource hooking is supported by EdXposed?

I'm still using Android 8.1 since there isn't a fully working Andoid 9 ROM for my phone yet. Otherwise I would of course use GravityBox v9.0.0, but I'm not sure if Brightness Settings is working on your current beta version for Pie!?

Thanks in advance for some feedback on my questions and keep up the great work! :cool:
[Xposed Framework Modules] C3C076:
These seems like symptoms of SystemUI crash. Logcat of crash would be needed to tell what's causing it.

If resource hooking support already works reliably in edxposed 4 it is suggested to use standard version of GravityBox instead of edxposed one.
[Xposed Framework Modules] okij:
Thanks for this info!

I'm happy to confirm that the standard 8.5.3 version of GravityBox works with the 90.0-0.4.0.1-beta-SNAPSHOT (Sandhook) version of EdXposed. :highfive:

It took a couple ot tries to get it to work. Just restoring the 8.5.2 version of GravityBox (which I had as a TitatiumBackup) including Data didn't work, also after deactivating GB, rebooting, activating GB and rebooting again.

So I uninstalled GravityBox completely, installed the standard 8.5.3 version from the Xposed repository, activated it and rebooted. Then I restored my GB settings which I had saved some weeks ago (still on the standard version) with the pro feature of GravitiyBox and rebooted. And voila, now it's working. :)

All resource hooking features that I use (like the Brightness Settings in Display Tweaks) are now working again! :cool:
[Xposed Framework Modules] dope77:
Things got worse, even restarting my phone didn't fix the not responding ui. Had to delete gravitybox from file manager in twrp to boot.

How can i post logs? Is it possible to pull logs from adb or twrp, cz phone will boot but system ui will hang with GB installed.
[Xposed Framework Modules] C3C076:
In case of such SystemUI crashes, not only xposed log is required, but also logcat of crash of SystemUI is required.

XPosed log can be exported from Xposed Installer / EdXposed Manager (whatever you use).

SystemUI crash can be captured by using ADB (or alternatively using some logcat app from play store).

Please, open issue at https://github.com/GravityBox/GravityBox/issues and continue there.
[Xposed Framework Modules] Dru79:
When I use GravityBox on Oreo (Oneplus 3T OOS or custom 8.1) and I use other phone app (True Phone) then I have double notification of missed call. Why?
[Xposed Framework Modules] C3C076:
One might be default system one while the other one is generated by app itself. You should try with GravityBox disabled to check if you get the same behavior or not.
[Xposed Framework Modules] Dru79:
When I disable GravityBox then notification of missed call is OK (one from Telecom.apk). When I enable GravityBox then I have double notification of missed call (two from Telecom.apk).
[Xposed Framework Modules] C3C076:
Might be related to a workaround in GravityBox for AOSP bug that prevents LED for missed call notifications.

The workaround reposts the same notification after screen is turned off which activates LED.

Not sure why you get double notification as I use the same ID of notification so original should get updated instead of new one created.

If you want me to help debug that, please open issue at https://github.com/GravityBox/GravityBox/issues
[Xposed Framework Modules] Dru79:
OK, I added new issue on Github.
[Xposed Framework Modules] C3C076:
Ok. Thanks. Can't give a time frame as all of my development devices are currently on Pie.