yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] :
That's what I mean by "religious": real life matters and facts arn't considered any longer, but theorthical benefits not present in reality at all are used as universal reason. This way the believer doesn't need to deal with dirty reality any more.

In real life usage there is no benefit of f2fs over ext4, but ext4 has less issues with twrp (that's a fact in the last two years). You don't even ignore these facts (a normal conversation on what to recommend would end here), but now the believes kick in: "I'm just saying that it's more modern in terms of flash memory." Yes it is. So what?

As long as a new design can't proof in real life any benefit, claiming again and again "I'm just saying that it's more modern in terms of flash memory." doesn't make it a benefit in real life.

We turn in circles here. You talk of "modern deign", I talk of real lifenexpirience. It doesn't make sense to continue.

Perhaps wemcan agree on this: theoretically f2fs is a much younger, more modern, emmc streamlined design - currently in real life for the average user (just interested in a reliable running device, without honoring the inner beauty of fs designs, nor willing to catch each and every issue a rom or a recovery has with f2fs) ext4 is the easier way to go, and therefor is recommended for quite some roms.
[OnePlus 3 & 3T Cross Device Development] Doc Sniper:
The same chain of arguments I heard years ago, namely in the discussion "avoid using btrfs, stick with ext4" :eek:

Discussion over (for me) ... never mind ;)

Edit: Forgot to write, your last paragraph describes it quite well. :good:
[OnePlus 3 & 3T Cross Device Development] Dirk:
On the OP5 we have codeworkx as Maintainer for LOS. He also has his own TWRP release and thread, seperate from the Official TWRP. For compatibility it's a no brainer. His TWRP works better, is updated faster to adapt to changing ROM demands and is the one that people use.

Any reason why we could have builds seperate from Official TWRP?
[OnePlus 3 & 3T Cross Device Development] :
We are in the comfortable position, that los op3/t and twrp op3/t are maintained by the same dev. The matter - I think - is not a seperate build, but people: If I remeber correctly, [MENTION=5091734]dianlujitao[/MENTION] has jumped in as twrp op3/t maintainer, because no one else was there.

As far as I remember there were/are other unofficial twrp builds around. Though every build has it's own pros, for me debugging other people's issues with flashing roms, encryption etc. has grown more complecated... That's why I recommend always to use the official twrp if using my rom.

All in all I belive [MENTION=5091734]dianlujitao[/MENTION] is doing a great job, and another twrp is not needed. Just my personal oppinion.
[OnePlus 3 & 3T Cross Device Development] :
Because nobody with it's knowledge haven't enough time and will?

dianlujitao seems to have more time lately
[OnePlus 3 & 3T Cross Device Development] Dirk:
You both completely misunderstood what i said. I wasn't talking about someone else making it. It's very clear in my post about the same person making it. OP is already doing all the work. Instead of waiting for the Official TWRP team to merge dianlujitaos patches and add the releases to the website, dianlujitao could release them in his own TWRP thread and host them on androidfilehost etc.

Exactly what codeworkx does for the OP5. There's a reason why codeworkx chose to go down that route.

Hopefully enough time to knock together a new thread, rename the test build to 3.2.3-1 and upload it to a filehost. Job done. Probably wouldn't have to touch TWRP again for the rest of the year.
[OnePlus 3 & 3T Cross Device Development] :
But we have a build with those fixes, already: https://xdaforums.com/showpost.php?p=78332159&postcount=374

Dianlujitao has edited that posting, and it contains what you are asking for.
[OnePlus 3 & 3T Cross Device Development] Dirk:
Do you deliberately miss the point or refuse to see it? That is not what i was asking for. I think i mentioned something about creating a thread...

Forget about it. I can't be bothered.
[OnePlus 3 & 3T Cross Device Development] knpk13:
Yes I don't get this error (in screenshot) with the latest test build anymore. Still not sure what the error means though. Forgot to grab a recovery log but guess we don't need it since the error is gone.

Everything else seems to work fine in the test build so far.

I'm pretty sure Dirk just wants a new thread dedicated to unofficial TWRP builds [MENTION=4405529]nvertigo67[/MENTION]. Unnecessary imo, just link the test build in the OP and I'm good. I see he's been getting kinda annoyed lately lol.

Thanks for the work on TWRP and LOS 16 [MENTION=5091734]dianlujitao[/MENTION].

I'm hoping I can start building Android stuff and contribute to LOS/TWRP in the winter break. Not really sure where to start though tbh.
[OnePlus 3 & 3T Cross Device Development] :
I'm completely confused now. Only thing I'm sure about: if I've bothered you, it wasn't by intend... :(
[OnePlus 3 & 3T Cross Device Development] laupuy:
Hi Dirk,

he chose to be the official maintainer of TWRP for this phone, as he is for LOS. His choice and I respect him.

Besides, he already had a subject for his UNOFFICIAL TWRP some time ago.

In any case, I am happy that such developers are working and sharing their work. Thanks again dianlujitao. :good:

And thank you Dirk for your interventions and the enthusiasm you bring to the forum ;)
[OnePlus 3 & 3T Cross Device Development] himsin:
Which theme is this?
[OnePlus 3 & 3T Cross Device Development] knpk13:
Attached

Edit: I tried looking for the original thread where this was posted, but I couldn't find it. I believe it was a thread for a blacked out TWRP image for another OnePlus device. It also included a zip so you could use the theme with any TWRP version/device. That is the zip file I've attached here.
[OnePlus 3 & 3T Cross Device Development] Ihe87:
I flashed 3.2.3-1 over 3.2.3-0 and rebooted to recovery.

Now I've got stock recovery - why?
[OnePlus 3 & 3T Cross Device Development] habylab:
Interesting, I didn't have that before. Try using fastboot, and flash again.
[OnePlus 3 & 3T Cross Device Development] Ihe87:
That worked. :good:

But it's strange to update that way...
[OnePlus 3 & 3T Cross Device Development] :
In the first place: don't use 3.2.3-1! Please read the last pages!!!! Use fix3.

The issue is strange. Did you flash 3.2.3-1 from twrp-3.2.3-0 or from within oos with an app?
[OnePlus 3 & 3T Cross Device Development] Ihe87:
So should i flash 3.2.3-0 again?

I flashed in the recovery not app.

Edit: I'm on Skydragon not oos
[OnePlus 3 & 3T Cross Device Development] :
Use 3.2.3-0 or fix3. Read the last pages, and you will find the correct answer for your demands.

Now it gets even stranger: if there's no oos on the device, where can the stock recovery come from? (Or is Skydragon oos based?)
[OnePlus 3 & 3T Cross Device Development] Ihe87:
It's my fault. It wasn't the recovery. It's booted to fastboot-mode after updating to 3.2.3-1

I'm sorry for that.

I'll try to flash 3.2.3-0 in twrp again.

So when updating recovery i can't boot into it again. Only fastboot-mode. So i have to flash again with adb to get it work.
[OnePlus 3 & 3T Cross Device Development] :
Uuh? My usual recovery update steps are flashing the new recovery (either dd method or twrp->flash image) and immediatly reboot to the just flashed recovery. I've never flashed 3.2.3-1 (@BillGoss and [MENTION=5091734]dianlujitao[/MENTION] were doing just a great job, I've just enjoyed reading them... ;) ), though I think that booting to recovery and ending up in fastboot is related to 3.2.3-1 (I'm not sure, if I've understood your problem, because you've lost me finally at "So i have to flash again with adb to get it work.".
[OnePlus 3 & 3T Cross Device Development] Ihe87:
I did it the same way but can't enter recovery after flashed the 3.2.3-1.img in twrp.

After that i have to flash it via fastboot again.

Now I'm fine with 3.2.3-0.
[OnePlus 3 & 3T Cross Device Development] mk_1996:
That's really weird never heard of something like that. Last time i checked. 3.2.3-1 had encryption issues only. Not this one.
[OnePlus 3 & 3T Cross Device Development] :
your "3.2.3-0" was the official, right? i ask because dragon rom dev has their own "modified" twrp (which didn't fix anything, more than possibly adding a new bug)

if it was, try with other roms and see if flashing an .img works.

since you are the only one yet experience it, it might worth checking since flashing is the essential feature of twrp.

is it another data corruption, or something else.
[OnePlus 3 & 3T Cross Device Development] Ihe87:
I'm on official twrp and never had a "custom twrp" in use.
[OnePlus 3 & 3T Cross Device Development] Leeo97one:
So, finally, which version should we use at this time?
[OnePlus 3 & 3T Cross Device Development] laupuy:
The last here: https://xdaforums.com/showpost.php?p=78332159&postcount=373

TWRP_3.2.1-format-fix-3_oneplus3.img https://androidfilehost.com/?fid=11410963190603866112
[OnePlus 3 & 3T Cross Device Development] Leeo97one:
3.2.1? What's the problem with the latest version? Because I'm currently using 3.2.3-0 and have no problem. In fact, I asked if I should keep using this version or if I could update to 3.2.3-1.
[OnePlus 3 & 3T Cross Device Development] :
The fix3's zip file is named 3.2.1-0, but contains a build versioned at 3.2.3-0, which is indeed 3.2.3-1-fix3... strange on the first glance... reading the thread (at least from the point of first issue reports on 3.2.3-1 ) helps to get not too comfused... ;)
[OnePlus 3 & 3T Cross Device Development] Yndi:
is there any way to make sure the update worked? I flashed(once through recovery and again with the app) it and the version still shows 3.2.3-0.
[OnePlus 3 & 3T Cross Device Development] :
You can check the logs. If you don't trust the logs, manually flash with dd. If you don't trust dd's output, you're lost.
[OnePlus 3 & 3T Cross Device Development] Paschfire:
Flashed what? Which update? Details would be helpful.
[OnePlus 3 & 3T Cross Device Development] Kimple:
Me too. Same problem, it still says 3.2.3-0 :(

Edit

I flashed image TWRP_3.2.1-format-fix-3_oneplus3.img. Phone is OnePlus 3T A3003.
[OnePlus 3 & 3T Cross Device Development] pedritopl:
It is messed up, but nvertigo67 already explained it a few posts back:

https://xdaforums.com/oneplus-3/one...ial-twrp-touch-recovery-t3742894/post78493618
[OnePlus 3 & 3T Cross Device Development] Doc Sniper:
I compared TWRP 3.2.3-1 and 3.2.1-format-fix3 and it seems to be like [MENTION=4405529]nvertigo67[/MENTION] wrote.

# sha256sum of twrp-3.2.3-1-oneplus3.img
02526ad3c90f5cbfaebda341a7cb535af0c39e5db9715fdfae1ac21a776e4311 devicetree.dtb
5b8bc4fa49868804cd87869310022e6535cde49171603885a5ef5bb24e4d9387 kernel
10ffb70d9ecc0d21f006a809524d96f729a0c9e4fd1d599c91448ff4ca3b58b7 kernelimage
b5cb81af3e94f3871001f061ed8b46dfc399c3c99a7d378b7e6bfa9dfcc85277 ramdisk

# sha256sum of TWRP_3.2.1-format-fix-3_oneplus3.img
02526ad3c90f5cbfaebda341a7cb535af0c39e5db9715fdfae1ac21a776e4311 devicetree.dtb
5b8bc4fa49868804cd87869310022e6535cde49171603885a5ef5bb24e4d9387 kernel
10ffb70d9ecc0d21f006a809524d96f729a0c9e4fd1d599c91448ff4ca3b58b7 kernelimage
8949599d88859ae43153756b744acc0930fc99767459fed60ae4c48bffac9cd7 ramdisk

As can be seen the files "kernel", "kernelimage" and "devicetree.dtb" are identical, only the "ramdisk" is different.

In the "ramdisk" file the string "3.2.3-0" can be seen, so it seems to be at least TWRP 3.2.3-0 or newer.

Also things like "service dashd /sbin/dashd" can be found in the "ramdisk" file.

But dashd was included after the release of 3.2.3-0 and before the release of 3.2.3-1.

So the fix-3 version should be named "TWRP_3.2.3-1-format-fix-3_oneplus3.img", the most recent recovery (not just a fix based on an old recovery).

Edit: Clarification that the version "TWRP_3.2.1-format-fix-3_oneplus3.img" has a confusing name and should better be called "TWRP_3.2.3-1-format-fix-3_oneplus3.img".
[OnePlus 3 & 3T Cross Device Development] theduke7:
Can't find TWRP_3.2.3-1-format-fix-3_oneplus3.img can only find TWRP_3.2.1-format-fix-3_oneplus3.img

Are they the same
[OnePlus 3 & 3T Cross Device Development] Dirk:
There is no TWRP_3.2.3-1-format-fix-3_oneplus3.img, only TWRP_3.2.1-format-fix-3_oneplus3.img.

This thread has become suitable for it's own subreddit, because of some terrible decisions regarding nomenclature, broken versions, and general FUD and confusion.

TWRP_3.2.1-format-fix-3_oneplus3.img is based on the very latest version but has all the fixes and is THE version to use if you want to carry out Format operations with both EXT4 and f2fs, whilst keeping Encryption. There is no point using any other version. Forget the naming mess. The 'fix' version will be the one that eventually hits the official website when they get around to updating it, (If ever).

What it will be called when it does get 'Official' status is anybody's guess at this point. They could call it 'Windows 10 1809' at this stage considering the fubar releases.
[OnePlus 3 & 3T Cross Device Development] theduke7:
Thanks for the clarification

The reply I quoted has that version number so I doubted what I read previously...I have the last fix 3 version...thanks again
[OnePlus 3 & 3T Cross Device Development] Doc Sniper:
Clarified my post, the file "TWRP_3.2.1-format-fix-3_oneplus3.img" should be named "TWRP_3.2.3-1-format-fix-3_oneplus3.img".

Install the file TWRP_3.2.1-format-fix-3_oneplus3.img, this is version 3.2.3-1 with the format fixes ...
[OnePlus 3 & 3T Cross Device Development] Dirk:
No problem.

All the issues stem from getting Format operations working properly with f2fs. If you never Format, or if you only Format using EXT4, you could use any version going back to the original Oreo 3.2.1-0. (Of course, in keeping with the general trend of keeping people as confused as possible, there were two versions of that Recovery of the same name. One for Nougat and one for Oreo).

I pity anybody who is new to this phone who is trying to flash a custom Recovery/ROM for the first time. I've already seen posts in ROM threads from people who have failed flashes from using the latest 'Official' TWRP because they were trying to Format in f2fs.

Bottom line, for anybody new to this device/Recovery. Use this:

https://androidfilehost.com/?fid=11410963190603866112
[OnePlus 3 & 3T Cross Device Development] ale.comi:
after 2 years i'm tryng to unlock bootloader and install twrp on my op3t.

could please someone tell me the link for download the last twrp recovery? because i find only for opt3 and not of 3t :)
[OnePlus 3 & 3T Cross Device Development] vinoxflame:
its "unified" which means it's for op3/3t
[OnePlus 3 & 3T Cross Device Development] slipstreamer88:
I am on OOS 5.0.8, TWRP 3.2.3-1, encrypted, f2fs data partition, Magisk 18.0.

1. Which TWRP version should I use to change data partition filesystem to ext4?

2. Do I have to format my data partition to flash 9.0 ROM (probably SkyDragon)?
[OnePlus 3 & 3T Cross Device Development] :
Don't use 3.2.3-1. It's broken.

Use fix3 build from https://xdaforums.com/oneplus-3/one...h-recovery-t3742894/post78332159#post78332159 (the link under update2 - don't let the versioning confuse, just read the last page )

Changing the fs type requires a new formating - no matter which rom is flashed or will be flashed.
[OnePlus 3 & 3T Cross Device Development] Anghirrim:
Thanks for your advice!

I have one question. I used to be on official 3.2.3-1 until I read you post. But is it normal that the fix3 build file is named 3.2.1 but is indeed a 3.2.3-0 once flashed? Or am I facing some weird issue?

This makes me doubt the flashing process went properly.

Thanks
[OnePlus 3 & 3T Cross Device Development] :
That's why I told you to get not confused by versioning and recomended to read the last page(s).
[OnePlus 3 & 3T Cross Device Development] Anghirrim:
Actually I have read the last 6 or 7 pages of test for all versions (fix 1, 2 and 3). ;)

But still, file name vs real TWRP version is misleading (I understood that the version 2 link was the fix 3).
[OnePlus 3 & 3T Cross Device Development] :
https://xdaforums.com/showpost.php?p=78493618&postcount=439 (two pages back)
[OnePlus 3 & 3T Cross Device Development] Anghirrim:
Crap... I've stopped here.

https://xdaforums.com/oneplus-3/one...ial-twrp-touch-recovery-t3742894/post78378004

:D
[OnePlus 3 & 3T Cross Device Development] Madridii:
Mates, I should flash fix3 version for first time I flash TWRP just to use franco kernel?

Anyone could help me steps for that?

Thanks in advance
[OnePlus 3 & 3T Cross Device Development] BillGoss:
Read OP
[OnePlus 3 & 3T Cross Device Development] Paschfire:
Your question isn't clear, what exactly are you trying to ask?
[OnePlus 3 & 3T Cross Device Development] abhaykelkar:
Thanks much. Fix really helps while switching between roms.
[OnePlus 3 & 3T Cross Device Development] pijen:
Hello,

i'm using the fix3 version to format /data to ext4, restore twrp backup (oos 5.0.5) and flash oos 5.0.8

It boot fine, but i can't delete file on /sdcard or download file using chrome and whatsapp

is there anything i have to do after restoring a twrp backup? Thanks
[OnePlus 3 & 3T Cross Device Development] BillGoss:
I've never had this problem. All I can suggest it that you check that the various apps have been granted storage permission).

Or try rebooting to see if it makes any difference.
[OnePlus 3 & 3T Cross Device Development] pijen:
storage permission have been granted, i did try revoke & grant storage permission again

fyi, my storage is decrypted and i use [MENTION=7030109]mcdachpappe[/MENTION]'s kernel

I think it looks like file permission problem, looks like I simply don't have write permission, but I checked the permission it's look okay (770)

--------------------------------------

it's solved by flashing stock OOS and another kernel then flash mcdachpappe's kernel again, don't know what's wrong..
[OnePlus 3 & 3T Cross Device Development] :
A log would be helpful, also a detailed description of your setup including mods and steps taken to run oos unencrypted (which steps have you taken to disable oos forced encryption?). We also need to know if you've formated with wiping encryption or maintaining the current encryption footer.

Please give the above requested information for both: the backuped setup as well as the restored setup.
[OnePlus 3 & 3T Cross Device Development] :
On some ROMs I have issues with date and time not set in twrp, resulting in 1970 year time stamps for installed system files and twrp backup names.

This seems to be an old issue in twrp which is still not solved.

Any ideas how to change this without setting time and date in twrp terminal every time I want to do an flash or backup?

Are there other twrp versions (HD, MSM, others) which solved this issue and are capable running pie?
[OnePlus 3 & 3T Cross Device Development] BillGoss:
I have no problems with date/time in TWRP with OOS and Los 16. Can you give me an example of a ROM that doesn't work for you?

I'm using the fix 3 version (listed under update 2 in https://xdaforums.com/oneplus-3/one...al-twrp-touch-recovery-t3742894/post78332159)
[OnePlus 3 & 3T Cross Device Development] Paschfire:
This is likely a ROM issue, not TWRP.

May I suggest you report/discuss this with the ROM devs for possible resolution.
[OnePlus 3 & 3T Cross Device Development] :
At this moment Stratix but had this issue before with some Oreo ROMs.... Did as Google search and found several same posts but did not find the reason and a solution except changing date in twrp terminal every time. ...

Using same twrp btw
[OnePlus 3 & 3T Cross Device Development] BillGoss:
I tried to run statix, but it won't start with an encrypted data partition. So, unfortunately, I couldn't test the TWRP date/time issue.
[OnePlus 3 & 3T Cross Device Development] :
Hmm, I think you're pointing your finger at the root of the problem: incompatibility between rom's and twrp's handling of encryption of the data partition. (OOS, los and twrp use hardware accelerated encryption)

[MENTION=8175708]Jan_L[/MENTION]: when on a rom you expirience the issue with, boot twrp and access the data partition (i.e. in twrp's terminal execute "ls -laZ /data/vendor/time"), then get a log.

It's also usefull to compare all roms generating this issue especially regarding implemented encryption method.
[OnePlus 3 & 3T Cross Device Development] :
I think I have found something in twrp log:

I:TWFunc::Fixup_Time: Pre-fix date and time: 1970-09-17--18-21-15
I:TWFunc::Fixup_Time: Setting time offset from file /sys/class/rtc/rtc0/since_epoch
I:TWFunc::Fixup_Time: will attempt to use the ats files now.
I:TWFunc::Fixup_Time: no ats files found, leaving untouched!
[OnePlus 3 & 3T Cross Device Development] :
You've found it!

The content of /data/vendor/time for los based roms:

adb shell su -c "ls -laZ /data/vendor/time/"
total 6
drwx------ 2 system system u:object_r:vendor_time_data_file:s0 3488 2019-01-03 12:08 .
drwxrwx--x 37 root root u:object_r:vendor_data_file:s0 3488 1971-12-27 06:37 ..
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-22 15:45 ats_1
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-01-03 12:08 ats_12
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-01-03 12:08 ats_13
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-01-03 12:08 ats_15
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-22 15:45 ats_16
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-22 15:45 ats_2

So the problem isn't access to userdata in general, but the ats files can't be accessed. Maybe a permission problem in the path to /data/vendor/time. You can check with "ls -laZd" on each directory in the paths.

This needs to be fixed in the roms. twrp can't do anything about.
[OnePlus 3 & 3T Cross Device Development] :
Thanks for your help [MENTION=4405529]nvertigo67[/MENTION], I will dig into it a little further to solve permission issue and direct it to the devs.

Hope you can help me a little further, as output of adb seems the same for recovery and running os, and same rights as you mentioned for los based roms:

C:\WINDOWS\system32>adb devices
List of devices attached
xxxxxxxx recovery

C:\WINDOWS\system32>adb shell
~ # [6nls -laZ /data/vendor/time/
drwx------ 2 4096 Feb 19 2019 u:object_r:vendor_time_data_file:s0 .
drwxrwx--x 38 4096 Sep 14 15:42 u:object_r:vendor_data_file:s0 ..
-rw------- 1 8 Feb 22 2019 u:object_r:vendor_time_data_file:s0 ats_1
-rw------- 1 8 Feb 21 2019 u:object_r:vendor_time_data_file:s0 ats_12
-rw------- 1 8 Feb 21 2019 u:object_r:vendor_time_data_file:s0 ats_13
-rw------- 1 8 Feb 21 2019 u:object_r:vendor_time_data_file:s0 ats_15
-rw------- 1 8 Feb 22 2019 u:object_r:vendor_time_data_file:s0 ats_16
-rw------- 1 8 Feb 22 2019 u:object_r:vendor_time_data_file:s0 ats_2
~ # [6n

C:\WINDOWS\system32>adb shell
OnePlus3T:/ $ su
OnePlus3T:/ # ls -laZ /data/vendor/time/
total 32
drwx------ 2 system system u:object_r:vendor_time_data_file:s0 4096 2019-02-19 18:48 .
drwxrwx--x 38 root root u:object_r:vendor_data_file:s0 4096 1970-09-14 16:42 ..
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-22 14:43 ats_1
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-21 18:20 ats_12
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-21 18:20 ats_13
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-21 18:20 ats_15
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-22 14:43 ats_16
-rw------- 1 system net_raw u:object_r:vendor_time_data_file:s0 8 2019-02-22 14:43 ats_2
OnePlus3T:/ #

Or is this the issue then??

drwx------ 2 system system u:object_r:vendor_time_data_file:s0 4096 2019-02-19 18:48 time

Set permissions to /vendor and /vendor/time as /vendor/time/* with chmod, but no diff in TWRP....