yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] C3C076:
This indicates you forgot to reboot after updating GravityBox.

Reboot is necessary after updating any xposed module so the part running in system context gets in sync with new APK.
[Xposed Framework Modules] me7tarfeek:
I found it :laugh:

Under Framework… set config_strongAuthRequiredOnBoot to false…

In Samsung Note9, now no need to enter password on startup… fingerprint is enough…

Thank you [MENTION=5008415]C3C076[/MENTION] for the great module…
[Xposed Framework Modules] AnonVendetta:
[MENTION=5008415]C3C076[/MENTION]: Can you consider an option to auto-hide the software navigation bar after a certain time has elapsed, like say 5 to 10 secs? I like having the bar but there are times when I wish it would temporarily go away, without having to enable immersive mode. To unhide it, a simple swipe up/tap gesture should be sufficient.

Thanks!
[Xposed Framework Modules] sjamie:
That's a great feature request! :good:
[Xposed Framework Modules] AnonVendetta:
[MENTION=5008415]C3C076[/MENTION]: If it isn't possible to add this feature because of limitations in Android, or if it would take too much effort, then I understand.

Thanks!
[Xposed Framework Modules] C3C076:
Sounds nice and seems easy but actually it is not. Navbar logic and behavior is strongly integrated into PhoneWindowManager which is responsible for laying out all the contents on the screen (depending on what kind of app is in the foreground, and million other things).

I can't imagine how such functionality could be done, especially when it comes to Xposed solution which is always more challenging than when working at the real source code level.
[Xposed Framework Modules] Eazii:
If I may make a suggestion to [MENTION=7441667]AnonVendetta[/MENTION]. You can achieve what you want with Tasker. Simply make a Profile that activates immersive mode (either status bar, nav bar or both) when the display turns on after "X" amount of time or in "X" apps. Then everytime you swipe the bottom of the screen the NaviBar will appear for a few seconds then disappear again until needed. You can control when and what time/apps this happens.

You can also run this shell command in Tasker to remove the NaviBar completely

settings put system buttons_show_on_screen_navkeys 0

This one to replace it

settings put system buttons_show_on_screen_navkeys 1
[Xposed Framework Modules] AnonVendetta:
[MENTION=5008415]C3C076[/MENTION]: Thanks for the explanation, I see that my feature request isn't so simple to implement. But with Android few things are simple, that is the nature of the beast, I guess.

[MENTION=5467825]Eazii[/MENTION]: Thanks, I'll look into your Tasker suggestion. I already use Tasker for a wide variety of tasks, so it shouldn't be very difficult.
[Xposed Framework Modules] Electrolite_XYZ:
I tried to keep the log as clean as I could, I cleared the log before going into the lock screen and playing the song (not sure if you wanted to see the entire log since restart).

The second log is bigger where I tried to do more stuff I changed songs in lock screen, pause, play etc.

The visualizer won't work either on lock screen nor in the navigation bar

Also in the log window what's that arrow button on the right of the save log icon? When I click it xposed crashes (yeah I think I really need to find a fix for my xposed)
[Xposed Framework Modules] FcukBloat:
dear [MENTION=5008415]C3C076[/MENTION] it seems to me that since I installed xposed and GB on my sony xz2c 8.0 I get sometimes some systemUI related FC when acquiring screenshots. when disabling GB and rebooting, FC messages seem to disappear completely.

do you think it could be really related to xposed and/or GB? if so, any logs that I could share for you to check if interested? (catlog, xposed logs etc)

tia and either way! :o
[Xposed Framework Modules] C3C076:
Looks like it's working but I am missing some logging messages that are logged during boot when visualizer is being initialized.

This is quite strange. Maybe check how you have set colors in Visualizer settings. E.g. if you use auto color, try using manual color instead.

Also note, that Visualizer won't be active when device is in power saving mode.

Logcat of such SystemUI crash should give us some hints.
[Xposed Framework Modules] FcukBloat:
thanks [MENTION=5008415]C3C076[/MENTION] I think I could replicate the error while recording catlog

https://drive.google.com/file/d/1-EAhD0r_qG39-dCIPhFzzx8o6Uz9G49i/view?usp=sharing

a friend of mine says it is probably due to GB:

"GB's ModQsTiles.java (at line 42) is replacing an integer resource (config_maxToolItems) in the SystemUI.apk, which can't be found"

02-01 22:59:24.711 E/Xposed (19456): android.content.res.[COLOR="red"]Resources$NotFoundException[/COLOR]: [COLOR="red"]com.android.systemui:integer/config_maxToolItems[/COLOR]
02-01 22:59:24.711 E/Xposed (19456):	at android.content.res.XResources.[COLOR="red"]setReplacement[/COLOR](XResources.java:500)
02-01 22:59:24.711 E/Xposed (19456):	at [COLOR="Red"]com.ceco.oreo.gravitybox[/COLOR].ModQsTiles.initResources(ModQsTiles.java:42)

.. of course i know your module is intended to be used with pure aosp roms only, so i can't complain about incompatibilities with Sony fw, but maybe if you confirm the problem is on GB, you can make a change that fixes that without breaking anything on aosp side?

:silly::fingers-crossed:
[Xposed Framework Modules] Electrolite_XYZ:
Oh I feel stupid I had power save on I'm sorry for wasting your time.

But I still have one issue, since day one the visualizer actually never worked in lock screen only the navigation bar, since the logs won't report errors I'm inclined to think this more related to a wrong setting of my part than an error?

"I am missing some logging messages that are logged during boot when visualizer is being initialized."

Sorry I cleaned the log, I'll restart the phone and play media from the lock screen and send the proper log for you in an edit

Edit: Added the log since the reboot.
[Xposed Framework Modules] carmeloamg:
Oreo version working on Xiaomi Mi A1 january patch with Magisk 15.3 and topjohnwu xposed beta 2. Tested fatures are battery icon, double tap to lock, more volume steps and problably one or two more. Not much tested yet.
[Xposed Framework Modules] eqagunn:
I'm on latest Unlegacy Android.

It's not there for me.
[Xposed Framework Modules] C3C076:
Call recording option is available only on OxygenOS as their Dialer comes with that feature natively. It is just disabled for different countries.
[Xposed Framework Modules] C3C076:
OxygenOS users: please test adding new fingerprint in the Settings.

It crashes for me as long as I have navigation bar tweaks enabled in GB.

Looks like a bug in the OS.
[Xposed Framework Modules] daddylonglegs:
Dumb question but why does this matter if Xposed trips safetynet anyway? The only thing I can think of is OTA updates but you can't take OTA updates with Magisk installed anyway?
[Xposed Framework Modules] cameljockey1:
HTC U11 PLUS everything is working very well on 8.0 sense.
[Xposed Framework Modules] sjamie:
Some banking apps don't work if safetynet is tripped.
[Xposed Framework Modules] ivicakc:
It's without navigation bar but it's working. (oneplus 3 running ExOs)
[Xposed Framework Modules] daddylonglegs:
I know, but he's worried about Gravitybox being systemless, when just having xposed alone causes safetynet to fail.
[Xposed Framework Modules] adibayer_:
Battery Percent Text won't show in lockscreen even though in keyguard mode I set it to "Always Show". Is this a bug or am I missing something?

Device: OnePlus One

ROM: Lineage OS 15.1 Android Oreo 8.1.0
[Xposed Framework Modules] madscribblerz:
Doesn't work for me either.
[Xposed Framework Modules] marbertshere:
I got it to work after toggling on and off after a reboot.
[Xposed Framework Modules] zefyx:
I finally installed Xposed on my 8.1 device after hearing GB support was here. Don't need the premium features, but I'm bought the Play Store unlocker. Thanks for the great work!

Edit: the bottom right action on the lock screen isn't working here. It's weird because, it doesn't hide or change the associated app from camera until the millisecond in-between unlock, and the lockscreen disappearing.
[Xposed Framework Modules] madscribblerz:
Worked for me too. Thanks :)
[Xposed Framework Modules] Knark83:
Sweet
[Xposed Framework Modules] troymz1:
I can't get LED lights to work in ultimate notification control. I get nothing. Pixel 2XL stock.
[Xposed Framework Modules] truelies1:
Works great on Le Pro 3 with AICP Rom, only problem is the bluetooth icon on status bar can't change color.
[Xposed Framework Modules] dgml14:
Dumb answer, because actually it is not an answer
[Xposed Framework Modules] bagarwa:
Pixel 2XL, stock Android 8.1 January patch, Magisk 15.3, Systemless Xposed 90.0-beta2, GravityBox [O] 8.0.0.-beta1.

GB is the only xposed module I have enabled. I've encountered two issues so far.

I placed the custom key in navbar and assigned "Take Screenshot" to it. But when I tap it to take screenshot, the "system ui has crashed" block pops up and the phone takes a second screenshot on its own. I tap to dismiss the popup, phone takes a third screenshot on its own. The screen goes off and on to relaunch system ui. I go to screenshots folder to see half captured / corrupted screenshots.

This happens 75% of the time while attempting to take screenshot. (Not crashes and looping screenshot if I take screenshot the traditional way (power+volume button))

At random times, I've found my media volume is almost near 0. I increase it to 70%, some random time later, I see it is back to near 0. My DND starts at 11 PM and ends at 7 AM. But this random media volume change is happening outside this. I'm not unknowingly pressing volume buttons. This has started happening after enabling GB module.

In GB, I had enabled "volume key controls media volume", "reorient volume keys" and "link ringtone & alarm volume".

I will try to capture some logcat and post that here, maybe sometime tomorrow.
[Xposed Framework Modules] C3C076:
Make sure you have "Blink lights" enabled in Android's notification settings.

Yes, logcat og SystemUI crash would be nice to have. I tested on my N5X and it seems to always work but it's on 8.0.

Will reflash to 8.1 later and check. Not sure about the second one (the media volume) - the only place where adjustments to media volume are made from module

is when you press volume button while: screen is off AND music is playing AND you have skip tracks using volume buttons enabled.
[Xposed Framework Modules] C3C076:
It's a Magisk log. It won't help here.

The reason why it doesn't work in lock screen is most likely due to different lock screen layout.
[Xposed Framework Modules] C3C076:
Funny thing is this resource replacement was added specifically for Xperia devices. See here: https://github.com/GravityBox/Gravi.../com/ceco/oreo/gravitybox/ModQsTiles.java#L41

I am not sure if this is the crash cause since crash stack trace contains many ART related errors which could indicate some kind of incompatibility in Xposed Framework (lower level than GravityBox).

But anyway, I compiled APK with additional error handling when replacing config_maxToolItems so please test to see if it makes any difference.
[Xposed Framework Modules] FcukBloat:
oh many thanks my friend for the prompt action! will happily test and report how it goes :o ;) :good:
[Xposed Framework Modules] FcukBloat:
unfortunately I got another crash with new APK installed, got a log also if interested.

https://drive.google.com/file/d/1mLbRYf-b8cEa6lNjphLTfq7thzcqPSAw/view?usp=sharing

btw if it is too hassle don't worry I can leave with it! ;):angel:

ps. I forgot to mention I manually debloated the install, so I removed some apks from system/app and system/priv-app, dunno if that could be also the reason of the crashes, but as far as I remember, they started after installing xposed and GB... but I may be wrong... anyway I have all the apks backed up, so I can restore (all of) them easily in case of need!
[Xposed Framework Modules] _Pano_:
can I install this module having an xperia z1 compact with lineage os 15 Oreo8.1?
[Xposed Framework Modules] Nergal di Cuthah:
You can but it's not supported and you'll probably be full of bugs
[Xposed Framework Modules] C3C076:
I could not find any relation between GravityBox and this crash. ART crashes in runtime.cc when screenshot is taken. This is most likely related to Xposed Framework itself.

You should be able to test by running with all xposed modules disabled. If crash happens with no modules enabled it will confirm my theory.
[Xposed Framework Modules] FcukBloat:
thanks for your time in this. I tried as you said before posting here, and I couldn't replicate the crashes with GB disabled. but it is not easy to replicate it, as it is pretty random, so maybe I just had to wait more and it would eventually pop out... will try now longer with all modules disabled and see and report. thanks again!
[Xposed Framework Modules] Lucifer_77:
Recently came across Gravity Box and loved it(Especially for the navigation bar tweaks). I come from Xiaomi Mi Max rocking an AOSP Extended Mix rom and I am planning to switch phone but without AEX because it is a battery black hole. One feature of AEX which is my personal favourite is the able to configure custom actions for the navigation buttons(actions on long-press, single-tap, double-tap of navigation buttons). Now I very well know that GB also does this with ease but I found one action missing(the only action I use on a daily basis in my current AEX) which kind of made me sad was the ability to "Clear Notifications". Basically the functionality which I personally and truly and deeply desire that GB should posess is the ability to long-press the home button(or the other two) to clear Notifications. Now expand notifications pre-exists in GB so I am guessing this should be a small and easy addition. :D
[Xposed Framework Modules] sjamie:
That would indeed be a cool feature to add.
[Xposed Framework Modules] C3C076:
Choose Custom action -> Switch to Shortcuts -> Choose GravityBox Actions -> Clear notifications
[Xposed Framework Modules] sjamie:
As you know, you're a Genius! :highfive:
[Xposed Framework Modules] li0nh3art3d:
is a gravitybox module in the works for edxposed? if so, I'm going to buy a new device on pie like the pixel 3 possibly. this module is the reason I haven't done so just yet..
[Xposed Framework Modules] AnonVendetta:
I would say that no GB should be released for Pie untl [MENTION=4419114]rovo89[/MENTION] officially releases Xposed for Pie.
[Xposed Framework Modules] arianat01:
And when rovo89 will be released Xposed for pie? Do you have any news about that?

rovo89 didn't say anything and last Xposed update is for 1 year ago.
[Xposed Framework Modules] AnonVendetta:
[MENTION=6424213]arianat01[/MENTION]: He'll release it when it's ready, that's when. Any unofficial release before then (like edxposed) will surely be riddled with bugs. Sure, official Xposed itself has bugs, but at least [MENTION=4419114]rovo89[/MENTION] takes care to work out as many bugs as possible.
[Xposed Framework Modules] arianat01:
Yes. I completely trust to rovo89 and his is very idealist. but unfortunately I think rovo89 is very busy and he can't update Xposed any more. I am very thankful of him. He is legend

But I want to use Android pie and Gravitybox together.
[Xposed Framework Modules] C3C076:
Regarding GB for Pie. I am planning to do some experiments as soon as I have more time.

The thing is resource hooking is currently not supported in EdExposed which means some functionality in GB would have to be sacrificed.

Moreover, I currently do not own a device running Pie. One option is to install some unofficial Pie build on my Nexus 5X but I haven't done a research on what's available, yet.

Anyway, I cannot guarantee anything at this moment.
[Xposed Framework Modules] bkkzak:
Just throwing this out there, I'd recommend Pixel Experience for the 5X. I had to use my 6P for some home automation and flashed Pixel Experience on it, and I couldn't tell the difference between that build and stock on my Pixel XL. Hope you get to try it out, Pie's a fun OS; plus my phone actually feels more stable running Edxposed on Pie than when I ran official xposed on Oreo.

Thanks for keeping us in the loop!
[Xposed Framework Modules] arianat01:
Yes. I agree with you. I installed pixel experience 2.9 magisk module and it makes your device like pixel. It add pixel overlay and Google call screen Google font and more.

I used EdXposed too. It doesn't slow your phone. I don't know why but I like it. It's pass SafetyNet too. most of the modules works good on EdXposed.
[Xposed Framework Modules] C3C076:
Yes, I am running it for some time already with EdXposed, although EdXposed is far from stable at this moment.

Getting random ART crashes here and there, plus there are some issues with reading module preferences with SELinux enforcing (solohsu already looking into it).

Not speaking about resource hooking/replacement not working.

But at least it allows me to work on GB migration to some extent ;)

Thanks for the hint, anyway.
[Xposed Framework Modules] Fabian Rï¿½ling:
LineageOS 18.1, Fairphone 2. "Screen record" appears in the reboot menu, as well as in the main power menu. Not an issue, but probably not intended.
[Xposed Framework Modules] sjamie:
This is excellent news. Thank you for the update!

Btw, would you consider adding screen on/off animations like CRT to GravityBox?
[Xposed Framework Modules] ajp_anton:
I have a feature request, but I'm not sure if it's in the scope of this module to do such a thing. I'd like to prevent apps from re-coloring the status bar of the phone, so that it always stays black. Or is there another way to do this?
[Xposed Framework Modules] reza_xdv:
[MENTION=5008415]C3C076[/MENTION]

I see many crashes and errors of GB module. Here's the log, I hope you can find the cause.

LG V20 (H990DS) running stock Oreo 8.0

Many thanks in advance.
[Xposed Framework Modules] me7tarfeek:
Great news… if you need a tester on Note 9 Pie, I will be happy to test. Specially for Advanced tuning.

Thank you soooo much
[Xposed Framework Modules] rickpub:
Ditto
[Xposed Framework Modules] C3C076:
Advanced tuning depends on resource hooking which is currently unsupported and is questionable whether it will be supported in the future.

Anyway, I already have some ideas how I could ditch dependence on resource hooking in GravityBox completely but it is in form of a concept only for now.
[Xposed Framework Modules] me7tarfeek:
Your effort is highly appreciated…

Thanks a million
[Xposed Framework Modules] me7tarfeek:
I am checking here like 4-5 times a day hoping for good news :o
[Xposed Framework Modules] reza_xdv:
[MENTION=5008415]C3C076[/MENTION]

Please have a look at this log, GB is crashing all the time.
[Xposed Framework Modules] KaMyKaSii:
Just to know, are your ideas similar to this?

https://xdaforums.com/xposed/modules/mod-exi-swiftkey-t3650598/post78959146
[Xposed Framework Modules] C3C076:
Yes, similar to that. There's currently no other way as far as I know. I still tried to design my solution with care in mind for it to be as optimized as possible. I am avoiding hooks of resources in zygote as it would make them active for all the processes/apps and could be an overhead. My hooks are only in processes where I need them. This means "Android" process and SystemUI process. Working quite fine, including advanced tuning.

I also managed to solve issue of SystemUI not being able to read module preferences from filesystem due to selinux restrictions. Just posted a pull request to EdExposed devs.

This means GravityBox (and other modules) can now run with selinux enforcing.
[Xposed Framework Modules] C3C076:
Version 8.5.1 available

Changelog 8.5.1 - 24/02/2019

- ExpandedDesktop: reworked and greatly simplified

--- now all modes on 8.1 are supported again

--- should be compatible with more different devices/systems

- AppLauncher and QuickAppTile dialogs: added support for dynamic theming

--- follow current SystemUI theme automatically

--- not applicable to OxygenOS nor other Android brands that have own theming

- NavigationBar: improved custom key/cursor control keys layout compatibility

--- OxygenOS: if navbar contains OOS specific "nav" key it will be replaced by GB custom key

in case GB custom key is enabled (thanks JerryGoyal for testing)

--- maintains complex layout on 8.1

- LocksreenAppBar: visual improvements

- Advanced tuning improvements

- Updated Turkish translations (thanks to Fatih Firinci)

- Updated Italian translations (thanks to ghost45)

- Updated Chinese (Simplified) translations (thanks to liveasx)

Full commit history for transition from 8.5.0 to 8.5.1
[Xposed Framework Modules] Ghisy:
Hi,

I have a weird bug since the latest update: my back and multi-tasking buttons are really small! (Pixel 2 XL, Oreo 8.1).

Is anyone facing the same problem?

Thanks.
[Xposed Framework Modules] C3C076:
Please, open new issue at https://github.com/GravityBox/GravityBox/issues

and direct your communication there from now on. I will probably have to create some test build which may require more iterations. Thanks.
[Xposed Framework Modules] dope77:
Why can't i find the update in xposed? It's still showing 8.5.0

Xposed sdk27
[Xposed Framework Modules] Ghisy:
Hi,

I just did! I hope you can fix the issue!

Thanks.
[Xposed Framework Modules] C3C076:
Thanks. Please, test APK I posted there.
[Xposed Framework Modules] me7tarfeek:
I jumped thinking this is the Pie version.. :D
[Xposed Framework Modules] C3C076:
:)

Pie version is still in the works but I'm getting there. All depends on EdXposed development and its quality. If I decide to release Pie for the public I will probably have to put an experimental sign on it. I will do reassessment next week after I get back from spring holiday.
[Xposed Framework Modules] beeshyams:
Thanks a lot... Waiting for it

Edit: Have a nice holiday. Sent you a beer
[Xposed Framework Modules] Ghisy:
I will. But it has the same version number, not sure I can overwrite the current version. Maybe you can bump the version number please?

I can't back up my settings since I have the regular version :(
[Xposed Framework Modules] C3C076:
You don't need to worry about version number nor the settings. Simply trust me :)
[Xposed Framework Modules] me7tarfeek:
Really appreciated… Can not thank you enough.. :good:
[Xposed Framework Modules] Airtioteclint:
Can you release a separate ed xposed module for staus bar tweak only? Clock, date, battery bar and data signals?

It's really the only thing i use gravity box for nowadays and find it to be most reliable. Also volume keys to skip media tracks if not too much trouble. :highfive:
[Xposed Framework Modules] Ghisy:
I installed your test apk and my nav buttons are back to normal! Thanks for the super quick fix! ?
[Xposed Framework Modules] C3C076:
Version 8.5.2 available

Changelog 8.5.2 - 25/02/2019

- Fixed scaling of navbar keys on 8.1

- Fixed bootloop on OxygenOS related to "hide navbar" vs. custom key button conflict
[Xposed Framework Modules] SaidJan:
I tested 8.5.2 today.

This issue has been around for a while:

The cursor control keys don't show.

I have LG G5, android 8.0 stock.

I also don't think clock second works when it's not in center.
[Xposed Framework Modules] Senliast:
Can you please add support for Android pie?
[Xposed Framework Modules] me7tarfeek:
Dear [MENTION=5008415]C3C076[/MENTION]

Any news on the Pie version?

Sorry for asking… can not wait*

I see new version of edxposed...

Thanks in advance..
[Xposed Framework Modules] marcdw:
[MENTION=6291448]Senliast[/MENTION] and [MENTION=7324057]me7tarfeek[/MENTION], see two pages back for the dev's post. If he has any news about anything it's safe to assume he'll post.

ETAs and impatience is not good. Part about not being able to wait is downright silly. You don't have a choice.

Moto G5S Plus XT1806, Liquid Remix v9.1.4 ROM, MultiROM, XDA Legacy
[Xposed Framework Modules] me7tarfeek:
Thank you for being the wise man. But I think you could've communicated the same exact message in polite way.