yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] VampireHeart:
Go in settings, Omni Gears and select the second line (characteristics of device) and into that you can find it, swap recent and back.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
Thanks but i dont have omni gears un settings?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] whymista:
Anyone else have issues with wifi after installing? I'm still reading through the pages on my phone but haven't seen anyone mention it yet
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Either install button manager or wait about 3 days until we merged the lineage buttons commits. We are currently trying to adapt them...

---------- Post added at 07:50 PM ---------- Previous post was at 07:48 PM ----------

No. WiFi is fine. The only thing on all devices is that wifi must be enabled "by hand" after a reboot.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] whymista:
Yea I've tried that and I've tried that and it still won't work. It shows the network as saved but won't connect. I've also gotten several FCs on inbox but I've no idea how to capture a log
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Then you either upgraded wrong, use the wrong firmware or wrong GApps.

Because I have none of these issues and I cannot tell what you did on installing the ROM.

And we have a "log that ****" feature in AICP Extras. It takes the log and can zip & upload it. It can also upload it to hastebin and give you a link to share... Pretty easy and can be done after the FC or crash... ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] VampireHeart:
Sorry I made confusion with other ROM :D

I don't remember if that option is present in AICP but you can download Button remapper from Flar2 in the PlayStore and enable the switch.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
...or just wait two days...haha
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jsilver73:
This is a lovely rom, after the last couple of months on OOS I'm coming back to AOSP FOR this ROM - my new daily driver :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dakotah2468:
Anything over 2 minutes for this rom isn't right, you probably installed it wrong and it's "bootlooping" also it could be that your device is encrypted in that case you need to reformat your device via twrp (YOU WILL LOSE ALL FILES) edit: sorry, just saw you had it fixed xD should read more before commenting
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
don't flash today's nightly please (20180115)!!!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dsg2003:
i think you mean 20180115, right?

Too late..... :)

in OTA it shows me Update (back) to weekly 20180106, is it save to downgrade? or do you preffer a clean install?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Right, thanks :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dsg2003:
how can i change butten remapping? want to change recent and back button. And i want to map recent button long press for menu. is this possible with this rom?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] VampireHeart:
Sometimes just read some posts before can help.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yep, that's why I posted this long answer a few posts back.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
Yeah, I had a major brain fart. On cheeseburger it's working for me encrypted with TWRP.

It's on flounder (N9) that TWRP isn't working. Sorry about that wartomato
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
I hope it gets fixed on all devices... hopefully...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I have a problem.

I have clean flashed my rom but the wlan speed drops to ~200kb/s.

The wlan connection have 866mbit and my internet connection has 200mbit. when i download a file, it starts with 200mbit=24mb/s, but it drops to 100-400kb/s.

which modem i must flash for the latest update?

and how to step by step flash the rom?

I have flash modem/firmware 5.1.3, the rom and the gapps, after a reboot then the magisk 16.

can anybody help me?

thx
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Actually you did everything right.

Currently not at home on a 100MBit line, but as you can see in the screenshot, the speed is okay, even after some time.

As I am on the same firmware, the modem or ROM do not seem to be the problem...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
It seems the problem is the rom.

I have checked out a few available roms and now iam on firehound rom, there is no problem with the speed.

The problem is definitly not the Router, my other devices have full speed over the 5ghz wlan (smartphone 866mbit, notebook 433mbit).

i had exchanged the router from my internet provider, to be able to rule out an error on the device.

The new rom works.

Dann shame, i like aicp, i will check it out later, maybe when its final.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] S2_fa_007:
I too have that problem, when downloading something over wlan, it drops to some 100kB/s..

No problem with transfers on LAN..

Sent by OnePlus 5 with Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It can obviously never be final...

And yes, as I said, my speeds, network (5 or 2.4 GHz) and connection speeds read the same speed settings like yours. And all I can say is that I don't "suffer" that as I already posted before.

Maybe I have some magic setting on or whatever, but afaik none of the other devs have that problem too.

So, sorry you left the ROM, but obviously some things are more important and thus it is understandable. :(
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
My wifi speed is ok too. Tested in two different WiFi networks with speedtest app from PlayStore.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Adromir:
Well I do have some Wifi Troubles as well. Sometimes Wifi gets so bad, that i need to go into Airplane Mode and reconnect. Until then barely a byte is coming to my phone
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] MarcoBobolo:
Same Wi-Fi problem, here…
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I can say that the update from 0626 or 29 was OK...

That was my last clean flash. After a update some days later i have the problem again.

This bug was the problem why Iam make a clean flash.

I did not notice the time before that. I still had an old wlan setup with the 200mbit line and 65mbit @, 2,4ghz.

I have 2 months use the internal updater.

---------- Post added at 07:26 AM ---------- Previous post was at 07:21 AM ----------

Speedtests are OK, take a large download like CSR racing2 from playstore or 5-10gb dummy files from various sites.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Tested... 1.5 GB on 250mbit fiber over 5Ghz Wifi... still working fine here...

But of course changed back to LOS buffer settings (as Firehound uses 100% LineageOS settings) and tested again... still working. :confused:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Iam back on aicp, and lost WLAN connection and have speed drops :(
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Good. I do not have them... And your possible fix is in tomorrow's nightly.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
Booo... LOS always gives me wifi problems, hope I don't have them now lol.

As of right now on current nightly and no wifi issues.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, sad to hear that.

As by demand, I changed our settings to LineageOS settings on wifi.

Here are the results on my companies network.

First is the "bad old" setting from Pixel 2 that we had before;

second is the result with LineageOS standard settings.

And please don't tell me "you need a bigger file", lol...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Mmmh crap. If this doesn't fix the wifi drops, might be a good idea to revert LOL ;)

BTW, anyone has sound issues when using headset? I made a build on the 12th and didn't have any sound through headset. Reverted back to an old old build and no issues :S I'll have to try to download the nightly and test it out.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
What can I say...

And no, no problems with my headsets... ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Same problem and worse.

But I did a video on a freshly installed system to demonstrate it.

https://www119.zippyshare.com/v/8nnrpWij/file.html

edit:

Sorry Guys, i find the problem.

it was the google apps 20180705 and some before.

I switched back to 2080626 and everthing is fine.

why 26.06?

because that was my last clean flash and everything worked.

Dont take gapps after 20180626, this works for me. :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, then reverting the super-duper lineage change, lol... I love this, haha

Und bitte lösche das Bild... Keine MAC Adresse nötig. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Delete it out of the quote please.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Of course ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Coming from xXx (decrypted), would formatting my data partition be required to get AICP running properly?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
I just woke up, and realized my alarm hadn't started.

When I checked the phone, there was a white AICP logo,, and all I could do was a restart.

Any idea what that's about?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I never seen before that issue. Have you instslled a substratum theme?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
No Substratum, no Xposed and no Magisk Modules.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
As xXx is based on oos i think you will need to format data partition.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] djsubterrain:
Devs wouldn't be able to help without the logs. There's a section in the AICP settings to dump out logs you can attach to your post to help them track down an issue.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
Yes, but aren't the logs cleared after a reboot?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Which clock app?

LineageOS one is a bit of a pain, but google clock works fine for me.

Plus never had a problem with a reboot... (Using stock kernel)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
Just the Google one.

But I'm pretty sure it's not the clock app. And I'm also just using stock kernel.

I would call this a reboot because it never rebooted. Just the AICP logo when I turned on the screen, and no option to do anything..

Had to reboot using the power button.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Strange thing is that it was stuck at the boot logo, which makes me wonder...

May I ask which Firmware version and Magisk version?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
I'm not rooted. And Firmware is OOS 5.1.3

This morning was almost the same, except there was no white AICP logo. Just a black screen and blue light in the LED.

I could only restart using power button.

I guess I will have to do a fresh install.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yep, because this is really unusual... The blue led indicates a kernel error...and that is really rare. Can you do me a favour and flash the Flash kernel 4.29... without wiping or flashing the ROM and see if that issue is still there tomorrow morning?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] arktay:
I read that lot of users are running the rom encrypted so I wiped cache, dalvik, system, data and flashed only the rom (without gapps and magisk) but i'm stuck on AICP bootanimation :/
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] KaszasM:
remove magisk and flash kernel again
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
Sure thing. Will do. ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
As the ROM is unencrypted...you need to format data and not wipe.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
The alarm started this morning. II'm hoping that the problem is solved.

Thanks for your help.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Announcement

Device builds changed for NIGHTLY devices.

Servers will start to build only WEEKLY builds from now on, until further notice.

Cheeseburger is scheduled for MONDAY.

Yes, this might change again, but we had to do this to sort some things on the servers out.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
How's your campaign to start FBE going?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
File Based Encryption? Y/N

Good, hehe. Only "problem" is that we would have to tell all of you that a CLEAN install (wiping + formatting /data) will be needed.

And I have the fear that the users would grill me alive, if I just do that.... :(

Team already said that it is okay for them. Actually made even a readme for that, haha... it is in the commit which is up on our Gerrit.

I wrote something like his, to prepare everyone:

"A full format on the data partition (to EXT4) is required before updating or you'll see "Error 7" in TWRP.

Since this build, flashing from/to LineageOS or OxygenOS no longer requires the need to format the data partition (just a wipe is needed).

Q: Why FBE (File-based Encryption)?

A: Google decided to use FBE from Nougat onwards and supports it on EXT4. OnePlus decided to do the same on this device. Full Disk Encryption (FDE) is still buggy in TWRP.

Q: So what are the advantages?

A: We follow Google and OnePlus on their way to a more secure device and the protection of your data. New users from other ROMs or stock OOS will no longer need to format their data partition.

Q: But what if I don't want FBE?

A: It's set to enforcing. You'll get an "Error 7" in TWRP, when you're trying to flash the new version without FBE enabled.

Q: How to enable FBE?

A: Just like how you disable FBE (unencrypt) before: backup all your data (including internal storage!!!) via TWRP and copy it to an external source, then format your data partition, then flash the ROM.

Q: What happens, if I don't follow the instructions, e.g. getting the "Error 7"?

A: Running a FBE-enabled ROM on a FBE-disabled phone will cause boot loops. So an assertion was implemented to check for FBE and prevent you from flashing "by accident" on an unencrypted device."

So, we could go for it... :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
I'll keep my eye on the change log. I have no issues wiping/format to make this happen. I read on one of the kernels the OB14 kernel source was released, any plans to incorporate it? I ask because I know you used flash kernel, which is now depreciated. Curious what kernel AICP will use stock.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
AICP stock kernel is Flash Kernel, so no need to flash it separately, lol.

And we will try to stick to it, as everything else did not give the "experience" we wanted.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
You know he dropped support for the OP5, right?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
You know he upstreamed our kernel? - And we are in contact with him? - Even after he sold his OP5? - And yes, we have kernel devs on the team too...

So, yeah, we know... ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
Okay okay, shade noted, my bad, i get how you guys are implementing the kernel now. Not trying to insult your intelligence, just confused how it will all work if there is no active support for kernel you were/are using.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Ah ok so I can already take this in my new builds? :) No need to repopick something else?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
No-no, I know noone gets my kind of humor when writing in English, haha.

Actually, Nathan stopped active building the kernel as he sold the device, thus he cannot test anymore.

He still supports different ROMs and keeps their kernels updated.

In our case it means updating his own "old" kernel, haha.

---------- Post added at 08:30 PM ---------- Previous post was at 08:27 PM ----------

Yes. It is only the one commit I made ?

If you try to install on an unencrypted device it will stop on TWRP and warn you to backup data and format it.

If that is done, you can flash and it will install and then encrypt on boot, just like OOS...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Ok thanks for your help, I saw your commit and the readme and the alert when flashing it ;)

I'll include this in my next build, I'll format, then flash xXx, then wipe again and flash this ROM (I saw changes when flashing OOS before this ROM in terms of GPS, even though I didn't see any impact when flashing firmware and modem).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
You do not need to flash a stock ROM before.

It just expects a "clean" phone, and a formatted and empty data partition.

Firmware is not touched and we are still based on latest stable 5.1.3.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Can I share the build with FBE enabled here and the op5-cleanup testing stuff? Got the link on AFH. If not, no problem ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, the "cleanup" topic got merged.

The FBE build can be shared on our G+ community, as it has a separate section for unofficial builds... ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
Could the no verity mod work, for keeping the phone unencrypted?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It should, as it alters the fstab as far as I know.

Haven't tested this actually in conjunction with the script checking the encryption.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Just formated the phone (everything including internal), flashed the ROM with gapps but doesn't boot... Quite strange... Only worked when flashed with no-verity script. Any guesses?

EDIT//// Forgot to format.. My bad. However keep getting framwork services FCs, can't seem to be able to install correctly. Made it work with no-verity, but strange that it is needed since encryption is forced.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Wartomato, I might need your help with the FBE patch :S I formated everything to EXT4 (100% clean), flashed the ROM + Micro Gapps. I'm getting android FCs and can't seem to install. Only way to work around is to flash no-verity (very strange...). Do you have any idea of what is happening? I'm using the latest version of TWRP from codeworkxx.

Thanks for your help!

EDIT/// WTF, now it works fine... Can't really guess what happened, reflashed latest version of codeworkxx TWRP (maybe I didn't have the correct version but everything seemed fine in terms of version number). Maybe the formatting of all the different partitions made the trick. Anyways, no issues here lol
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yup, had that too. Had to flash TWRP again and found that I had an encrypted leftover from before (OOS) that wasn't deleted or formatted. Seemed it was somewhere left out.

Lazy me just fully flashed back to OOS with stock recovery and started from there. That did the trick for me. Maybe overwriting the recovery with stock was my solution. Glad to hear reflashing TWRP did it for you.

Darn, would have saved me a few hours, haha.

But maybe the formatting two times (always forget to do this) is the solution. One format never did the trick for me...so I format data while having TWRP booted from PC to device without installing it first.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah before I always used ADB with format userdata to be sure that it was 100% perfect. Anyways, works now :) Gonna share the latest build on the G+ community ;) I'lll try to share some builds since it's weekly now (depending of the things to test out :) )
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yeah, if you want...

Hmmm.

GPS fix (hopefully) is up. A few open things and we are working on some things like "p" Volume Panel.... ;)

And I still wonder if it is easier to set "encryptable=ice" in the fstab, so that it encrypts fbe if the users wants, without forcing it... Hmm... Maybe something for next week, haha
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Just uploaded the new build ;) However without gps fix, I'll test it tomorrow, just finished the build but kinda late to test it out.

For the encryption, I guess the best would to keep it enforcing for security reasons, and let the user flash the no-verity script to stay decrypted. But since it's the same between LOS and OOS, don't see any reason why someone wants to stay decrypted (maybe to switch with other ROMs that don't support this?).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, we were always decrypted, but security seem to become more and more important, hmmm...

Yes, it is still faster unencrypted and was a good idea until the backup/restore problems in twrp weren't solved.

On the other hand it is easier for us on the building process or testing. We don't always push the whole ROM again and again to the phone. ?

But as all devs and maintainers for this device agreed that encryption is not a problem, it will happen.

I am trying to think of a good point to do it. Maybe when treble gets merged. Don't want to bother users by maybe having to clean install two times... But we will see.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
Dumb question, but why would you need to clean format for treble? I can edit my .prop and enable treble with 0 issues right now. I didn't think OP was incorporating A/B partition.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
If you can do that right now by a prop... fine, but I doubt it (btw, it needs more props).

And that prop copies all the vendor files to the partition?

You were on an Open beta, thus having the partition setup by OnePlus? - Well, not all users were/are using the Open betas, thus there is NO vendor partition for them.

You know that the vendor changes from OnePlus for the next Treble stable must be incorporated in the ROM's vendor?

Kernel needs "to know" that there is a verndor partition existing too.

etc...

And no, OnePlus did not incorporate A/B partitions, only one vendor partition of 1GB. Thus there will be no "seamless updates" for the OP5 or OP5T as it is not really a FULL Treble like on the OP6 or a Pixel device, where all partitions are "doubled".

...and there are no dumb questions. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z0mghii:
Hmm flashed latest build with magisk 16.7 and its failing safety net, any tips?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
I manually copied the vendor partition over via adb and recovery, to test it out. It originally had an old copy from april and gave me a vendor mismatch, so I formatted, mounted partitions as needed and copied the files over, and individually verified correct permissions. Took a while, but on boot it worked, no vendor mismatch or anything, and it was booting off the vendor partition, not system/vendor (I deleted the contents to make sure before booting and verified still empty after)

I didn't think the OB14 did a A/B partition. As for the kernel, not sure how to test that, as I had no issues when I did it, but I was using blu_spark at the time, maybe that's why? I did notice that the OS (kernel?) Binds /vendor to /system/vendor when I did it.

---------- Post added at 12:54 AM ---------- Previous post was at 12:53 AM ----------

Do more research. Remove all modules and reboot, try one at a time.