yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Javi22:
First of all thanks for the response!

Yes I'm aware about pros and cons of course. My only concern is stability, because other custom roms I tried had some random reboots, or sometimes camera not working, or any other inestability

But I can deal with no portrait mode in oos camera and no face unlock. Then maybe I should give a try :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Haha, well, we have face unlock through GApps...

Reboots? No, not as far as I know...

So, if you are "willing" to lose some feature from stock and gain others, feel free to try.

You can always go back to Stock...

Oh, just one thing I must add. We are running unencrypted unlike stock, LineageOS or OMNI Rom. So, read the OP carefully, as you will lose all data on a change (format of the data partition will be necessary)...

Firmware from 5.1.1 is necessary too and disabling any Lockscreen protection like pin, pattern etc. Before changing the ROM is always a good idea. (Even necessary before switching to TWRP and doing a backup before continuing...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Javi22:
So, first impression really good, everything working so far. Even some things which did not work with CNP rom :)

Battery drain and warming is a bit high though

I have to test all features but so far Im liking it, even the camera is not so bad. Thanks for all the work and the support!

PS_Magisk modules lasts like 6 minutes in the flash. Is it normal?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Dunno what you tried to flash...through Magisk. But currently we have only a reboot bug...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] nvidia70:
Reboot bug is only present with stock kernel. No prob with custom kernel. Just fyi.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Bug solved. Next nightly will be fine again...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Thanks [MENTION=6916498]wartomato[/MENTION] and aicp Team for your support.

The rom runs great :)

But there are some options to make it more perfectly.

Volume keys to move cursor

Reboot quick tile

Quick tile animation rotate/flip [emoji818] thanks :) [emoji818]

Opacity/dim for the lock screen

Quick unlock for pin

One Handed Mode for Buttons

Customize battery bar

Wakelock Manager

Alarrmlock Manager

Customize recent button/RAM bar

4G/4G+ icon

Can you add these options?

And there is another bug, the option to start the music app at headphone link is useless. Nothing happens when linked.

But overall it is perfect. And 100% stable, no reboots.

I use stock kernel with substratum swift black theme and type face font. The battery drain is good too.

Almost i come on around 1-2 days and 6-10h d.o.t..

In the most time the cpu is set to energy saving (no 3dgaming) and it runs very smooth.

Iam very glad to use this great rom. And say thanks again to the aicp dev's. :)

https://suckmypic.net/n37igouQ.png

https://suckmypic.net/5pGiak70.png

https://suckmypic.net/tvoKX60r.png

https://suckmypic.net/c2Sz09Kq.png
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Dunno about the volume keys on keyboard, but currently I doubt it...they have too much functionality right now.

QS animations are already in for weeks?

We saw no real improvement for dim on lockscreen. (Why?)

Quick unlock was ditched as it interferes with the other unlock options on clean installs on Google devices. As users just would not listen, we removed it.

Customized battery bar is in for months

Customized recents button and ram bar is in for months

We still see no sense in 4G icon switch (why?) And chose to put it at the bottom of the feature list...

#StayIceCold
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I mean customize colours for battery bar and recent menu.

And i want to dim the lock screen because i dont want to See the wallpaper (same as the powerdim).

I want it clear black :) with setting for font size of clock/date. And it is more space in statusbar. It looks more clear 2G,3G,4G.

The volume key not on the keyboard. I want to move the cursor, in portrait mode down/right and up/left.

I love the reboot quick tile, then i dont must use the power button.

And the 4g icon, it looks better and more consistent.

https://suckmypic.net/QftH3fb6.png

https://suckmypic.net/Re4cawZn.png
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Javi22:
So the rom is working better than I expected :)

It's only two things I would like to mention:

- Brightness is much lower than oos. This becomes a big problem. I did not have any problems with the sun, but today I notice a big maximum Brightness drop, for sunny situations

- Worse battery life and more heating. However I guess this is not a easy fixable thing. The other thing is more important in my opinion :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, just setup a black bg on lockscreen? Like me?

Actually my provider and SIM do not show 2G or 3G, lol...more H or H+...

Using a custom keyboard should do the job you want.

(I swipe the space bar for that...)

We will see about the reboot tile. Like I said, it is on the list and that's a long list....

---------- Post added at 07:33 PM ---------- Previous post was at 07:28 PM ----------

Interesting....

The brightness is from lineage, but I put up a commit for it.

Heating? Really, lol... 35 degrees on CPU is not really high...

Battery? - well I have usually 1day 15 hours with 7h to 8h SOT...

So, either it is you or you should consider changing back?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Javi22:
Yes please, thank you :)

Maybe one could not realize it, but if you compare, max brightness is much lower

Hmm yes I'm suffering high temperatures... wow that sot is not possible for me haha. With any rom

Anyone as I said this issue is no reason for switching rom :) it really works well!!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] pauljblo:
What firmware is recommended
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
5.1.1 firmware and modem.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] pauljblo:
Is it possible to add flashlight to the power menu options?

Where you can choose to add power menu content
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
AICP Extras - Hardware buttons

First two options... Torch on power button by long pressing it is already there. No need for the power menu...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
https://source.android.com/security/bulletin/2018-05-01

[MENTION=6916498]wartomato[/MENTION]

The move cursor function is standard at LOS.

Feature List

Buttons

Volume key cursor control when typing
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
...and we do not use lineage buttons....again & again, okay?

Long version:

1. Why did you link the security bulletin to me? - Anything you want to tell me? - I am a bit confused...

2. Months ago we decided to switch from LineageOS buttons implementation, because LOS wasn't ready by then and the "fast" development lead to no satisfying behaviour on hardware button devices and devices using their on screen navigation. Thus we had to remove almost all code related to Lineage button functions for On-screen and hardware buttons. We decided to leave AOSP on screen navigation and the Dirty Unicorn implementation for the on screen navigation which was much more flexible than LOS implementation.

We decided to mimic the Dirty Unicorn navigation features to the hardware buttons, thus making them more flexible too.

This was a "win & lose" situation. It means we lost a lot of (simple) implementations from LOS and gained some from DU.

All this meant that implementing now "standard" LineageOS features is not that easy anymore as the logic behind it is missing (the one that caused errors for months on our side). We can always try to bring back some good features back, BUT THIS NOT LINEAGEOS and our "Standards" are not the same.

Otherwise we could have stopped developent for another more months, waiting for LineageOS get get their sources right and up.

Always keep in mind: You can switch to other ROMs that include this "vital" features, if you cannot wait for someone in the team to try and port it to AICP...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Hey devs, I'm building on WSL and I would like to know if you plan on porting the commits that fixes the errors for those who use WSL (concerning BISON and IJAR). Thanks :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Commits not merged at LOS... so... :rolleyes:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
True, however +1 :) But yeah I know what you mean, you can still add the commits without merging them ;) In any case it works fine, even managed to put the WSL on my external SSD like a VMWare machine.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
...and you can still repopick or cherrypick them until they merge ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
True, I'll cherry-pick from LineageOS while it gets merged.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Todays update will force stopping the system ui.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Nope, it doesn't. Maybe something on your side like a theme?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Yes, Substratum + Swift black. But i deinstall before updating.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Then flash the rescue zip, because it is definitely not the ROM.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
[MENTION=6916498]wartomato[/MENTION] when making the build, it generates the changelog at the end and it takes a lot of time. I wanted to know if there was a way to not generate the changelog. I tried exporting USER_BUILD_NO_CHANGELOG=1 but doesn't work it seems. Maybe something when breakfast like breakfast cheeseburger-user?

Thanks for you help.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pho3nX:
[MENTION=2511007]csolanol[/MENTION] excellent ROM, i like really, AICP is always unique (like Camera, Audio FX, Music Player, new mix Trebuchet/Pixel Launcher, Smart pixel, Stock Icons). There some features missing for me:

1/ Advanced Restart (don't work?) when i click on the ON/OFF button i don't hacce options for Soft Reboot, Recovery, etx even after activate this parameter in Dev Settings

[EDIT: It's good after restart System UI or Reboot] :)

2/ There not the "Square" Clock, only Dotted, Portrait. (I know, it's a detail but i like so much Square Battery ^^)

3/ Always On Display is here, but there the Burst Protection ?

[i think yes because burst protection is always purposed with Smart pixels]

Using : ROM 05/20 Build, Aroma OpenGAPPS (Compatible!), noverity-v2 (keep decrypted, Magisk 16.0 (prefer Stable version), Singularity Custom Kernel 1.0.6
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a63548:
[MENTION=2511007]csolanol[/MENTION] [MENTION=6916498]wartomato[/MENTION]

I love AICP so much! Everything has been perfect. I hate to bother you both with the same question on how to get wifi calling for the Onplus5 working. I've notice that DU, as well as OmnirROM seems to be working correctly. Rather than just asking about it again, I checked DU gerritt in which I found some commits that may more may not help to get wifi calling working on ACIP:

Any help would be super appreciated, and I would help in any way needed to beta test any builds. Thank you both for all your time, and amazing work!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z0mghii:
Is there a setting to skip the lock screen for face unlock? Having a hard time finding it
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Seems a fault in the sh on our side, I look into it tomorrow...(hopefully).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
AICP Extras... Lockscreen.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well....

1. It is fine for me. The options you mention are default on any device by tapping the reboot button on the menu. Definitely no problem on our side.

2. The square clock is an Omnirom "invention" we just did not want... Not a very high priority. We would like to get our own battery icon in again.

3. I think you meant "Burnin protection". Yes, AOD has it (3 or 6 pixels, I think). Smart Pixels has a different algorithm, but has this feature too. Both are separate features.

Oh, you don't need noverity. Neither the fstab of the system not TWRP encrypt the device.

---------- Post added at 10:21 PM ---------- Previous post was at 10:14 PM ----------

Yup... Actually I have that on my list. Already looked into it, but saw that there is more needed. Seems carrier config changes, apn updates, and some changes in telephony service and fwb for the handover.

This is not easy and Lineage is way behind on these as of what I saw. I have it in some "half-baked" status by now, but ofc I will not be able to test as much as I need. Either time is precious (sorry, busy working) & testing that for e.g. Verizon or Sprint or Fi is a hassle for me, as these providers are not present here.

So, every input is welcome, as I tend to forget some things, when returning to the sources...

There are so many damn open ends to fix. :rolleyes:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Ah ok I'll try to have a look as well. Hope to find where the issues comes from but not sure, was hopping it was detected when breakfast like in 8.0 but seems it isn't the case anymore.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It should be, as it is the same code, but well, always worth a look to make it better ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Almost forgot... Which provider? (Oh Lord, please not VZW or Sprint...)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a63548:
Totally sorry for not mentioning that originally. I'm on T-Mobile. Thank you for all your help and information :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kipue:
Hi everybody, anyone calling over services like WhatsApp or Hangouts noticed lately a kind of static noise coming over the earpiece ?

It's fine if using a headset (wired/BT) or even loudspeaker, but makes the conversation impossible otherwise.

It happens on some other roms (like AospExtended), but not others (like DU or Omni), so I have a hard time to find out what's wrong. Kernel/Firmware does also nothing one way or the other.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
This ROM is very well done, nice work. Fysa, I had issues with wifi dropping on different custom roms (LOS, RR, etc). However the AICP seems to not be suffering the same fate. (22MAY18 nightly).

As for feature requests +1 on that square battery, however I'd rather have stability over a cosmetic feature. Also is it possible to add the scramble lockscreen pin?

Dumb question though, why did you chose to not encrypt? Not judging, just curious as to the reasoning. Are we able to encrypt after install?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, like I said, I like our battery more than mimic Omnirom.

The lockscreen scramble has not been ported on Los, but that is definitely something more interesting than the square battery.

I think I explained this a 100 times, lol... For devs and pushing changes encryption is a bad thing, apart from loosing performance.

And yes, you can encrypt after the install.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
Thanks. Man this rom is smooth. Wish you guys had a gaming mode to disable hardware keys like oos does. *HW keys quick tile is nice...

That being said I started getting random reboots with root lost/wifi dropping for no reason. Not sure why, if I can accociate it to the ROM I'll let you know, think it maybe greenify being stupid...

I was checking gerrit and GitHub to see if there was an official way to submit feature requests but I can't find it... Am I blind?

So a couple ideas I had, ignore if stupid.

Ambient display - on while charging only (currently off or always on for choices

Rotating lockscreen pin code (LOS style)

Add ability to disable wifi and NFC on suspend mode
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Thanks.

Well, we have the "gaming mode" under hardware buttons in AICP Extras. You can disable the hardware keys there, yeah, we did not link it to the profile to switch it to "high performance" (reason was that i use that qs tile for reading mode too)... ;)

Actually the HW Keys qs tile feature was implemented just for this option = disable the hardware keys for gaming, lol.

And yes, you get random reboots/wifi loss, if you use suspended actions. I know it, because it seems the system on 8.1.0 or more preciously the GApps do not like anymore, if we restrict the GPS or Mobile data access. Thus I don't use it anymore too. Sad, but we just can not work around GApps.

For the features:

1. Yes, I saw the commits on DU by Ezio for that. I think our [MENTION=460472]eyosen[/MENTION] pushed commits for that to test.

2. Hmmm, can you check in Settings -> Display (Advanced) -> Rotation settings -> Rotate Lockscreen? - Is that what you are looking for? Actually never tested it, haha.

3. Yeah, but like I already wrote above. If you restrict these, the GApps freak out and a random reboot might happen... And we do not have a solution for that right now, sorry.

And well, as we are a "small ROM" feature requests usually can be proposed on Google+ in the community. There's a subthread for that... ;)

(And no idea is stupid... we just need to check from where to get it or if it is suitable for all users.)

---------- Post added at 10:29 ---------- Previous post was at 10:27 ----------

Just as an "intermediate" heads-up. It seems T-Mobile US does not support Wifi Calling by default in the lineage APN / Carrier Config... so I try my best to implement what I can find. :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a63548:
You're the best! Thank you so much for all your work on this :D:):cool:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
I assume you mean prevent accidental touch? It is a nice feature, but design something to stop an idiot (like me) and we just get dumber.? I still press on accident, however it is alot less. Maybe you can use the DnD toggle switch to toggle the HW Keys Quick Tile?

Bad phrasing, For #2 i mean scramble lockscreen numbers, does that make more sense?

As for suspend actions, that sucks, the concept is awesome too bad the apps don't cause the phone to crash. I haven't had my phone random reboot since I uninstalled greenify, so I think that was the problem,. I'll keep monitoring.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
No, I did not mean "Accidental touch". In AICP Extras -> Hardware buttons -> 4th from top "Disable navigation buttons"? This is the setting the QS tile uses to disable the keys on cheeseburger. So, while gaming, you can accidently touch them, but nothing will happen. ;)

Hmmm, seems we missed it then. I use a pattern, so did not even notice.

Well, then let's say consider it a warning on Suspend actions, haha. Greenify, yeah... I personally use Naptime and Magisk Module "Sysconfig Patcher" (Get them GApps in battery optimization). But I thought Greenify should work (with the Magisk Module). Never tested it on Oreo, although I bought the App long ago, haha.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] willybarca:
it would be good if there could be a shortcut in quick settings to be able to enable/disable wifi scanning and Bluetooth scanning for improving location accuracy, most of the time indoor gps signal is so weak without these enabled, it such a pain going through all the settings, by the way thanx for the great rom, i have tried so many roms but none of them have so much features as aicp does, specially the quicksettings shortcuts.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
Ya, it's not greenify, it's the suspend engine.. I think specifically the 2G switch, I'm still testing. Here's my logcat and all.

https://drive.google.com/file/d/1xLhnXyQy27dDazsFkyW66M2QCuLpz7VC/view?usp=drivesdk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Not needed, but thanks. As I said before, I had this issue before. It is the code that doesn't "like" our device...

Actually I tested it too and came to the same conclusion.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Yeah nice, reading mode quick tile :)

Thanks.

But the option that start the music app when connect the headphones is still not working.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] eyosen:
Found the reason. On it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mekayzer:
Hi does anyone have working issue with headphne when plugged in jack. Working only on BT on my side.

Edit : found the reason, rolled back from openbeta 10 firmware to latest 5.1.1 one. All is OK now
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] eyosen:
See above post.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mekayzer:
Thank you, rolled back to latest 5.1.1 firmware and sound is working on wired headphone.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I dont understand.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] eyosen:
Found the reason why default music player app wasn't starting when wired headphones were plugged in.

And also fixed it. :fingers-crossed:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] picarito:
Does this rom support exfat USB storage?.i plug it via otg and it recognizes USB but doesn't read files inside it.tried it with other exfat usbs as well
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
If I found the mistake, I would not need to say it here.

The sound system is working fine, but only the app wont start.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] eyosen:
I don't know what you mean by that. I am one of the developers of AICP, found the mistake, fixed it, and now letting everybody know. Why did that bother you so much?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Ah OK, you mean you will fix it in the coming updates.

I'm sorry then I just misunderstood or misunderstood it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
Hello, i have a question for the developper. You think it’s possible to add a 4G logo in place of the lte logo in statues bar? Thanks a lot
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It is, of course. It is usually set by the provider info. We have it on the list, but not as a high priority...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] picarito:
Good rom btw but is there possible to add exfat mount support as I use otg USB with exfat and it only recognizes USB but doesn't read any files
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Actually it is enabled in the ROM and on the kernel.

Could you please log the process and link the log here? - Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ScrawlyG:
Beautiful ROM, polished In all ways.

Any chance you guys think of implementing DU's Lockscreen themes?

Maybe I am blind, can I change the battery led and notification led somewhere?

Keep up the great work please :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
It will be added probably but not the first feature in the list...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] S2_fa_007:
Type "LED" in the search bar and the setting should appear, not sure where it is :)

Sent by OnePlus 5 with Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Settings/Apps & Notifications/Notification LED

Settings/Apps & Notifications/Bettery LED
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Yay, start music app on connect headphones is now working.

THX for fixing this.

Gesendet von meinem ONEPLUS A5000 mit Tapatalk