yashsingh1/xdaforums huggingface dataset:
[Treble-Enabled Device Development A/AB ROMS] MrDanMak:
It does install and you can 'use' the app. For some reason however it doesn't technically save the images. I used it from here: https://xdaforums.com/p10/themes/huawei-p20-pro-camera-apk-t3778392

I think more needs to be done and I think it's still to do with the gallery. Unfortunately I have asked multiple times about it but I guess there's just no development in to this any more so I don't think we'll ever get to the bottom of the issues with using any EMUI camera port.
[Treble-Enabled Device Development A/AB ROMS] youtuber123:
It does save and works on my honor view 10! Emui 8.0
[Treble-Enabled Device Development A/AB ROMS] MrDanMak:
Yeah but you're on EMUI . This is in regards to any Treble based ROM.
[Treble-Enabled Device Development A/AB ROMS] Trism:
I used the guide on post #175 on my P Smart which is running AOSP 8.1 v18 and the camera is working perfectly.
[Treble-Enabled Device Development A/AB ROMS] AlmightyTritan:
Me and a few other folks have been noticing vertical artifacting on the front facing camera, have you been noticing that as well?
[Treble-Enabled Device Development A/AB ROMS] Trism:
On the front-facing camera, no. There's flickering scan-lines when using the back camera, though it only seems to be on the view-finder; nothing appears when an actual picture is taken.
[Treble-Enabled Device Development A/AB ROMS] MiniatureTheGod:
It doesn't save the pictures or videos you take though. Also running AOSP 8.1 v18 on Huawei P Smart

Also shows a black screen when trying to access the gallery from inside the Camera app
[Treble-Enabled Device Development A/AB ROMS] Trism:
I've got the black gallery issue, however mine is definitely saving pictures taken through the stock camera. Just took this picture (and a screenshot of the Huawei camera interface so no-one thinks I'm trolling ;) )

Photo:

https://imgur.com/a/B4tKo1u

Screenshot:

https://imgur.com/a/gZXjS3V

*EDIT* Also the video is working as well, though it's a bit twitchy. When I pressed the record button the app closed then re-opened, pressed record again and video was taken. However stopping the recording wasn't easy, had to hammer the stop button a few times before it registered.
[Treble-Enabled Device Development A/AB ROMS] optionalmgrr.la:
Can have flashable zip? Thx
[Treble-Enabled Device Development A/AB ROMS] madoxx77:
deleted
[Treble-Enabled Device Development A/AB ROMS] SCDMEV:
It doesn't works on mine :(
[Treble-Enabled Device Development A/AB ROMS] xHasKx:
Trying this camera on Huawei P10 Plus

Hi [MENTION=1915408]phhusson[/MENTION],

I have a Huawei P10 Plus device with unlocked bootloader and successfully installed your Lineage OS image for Project Treble (btw, great job, thanks!).

Now I'm trying to get back the stock Huawei camera app.

I've successfully built HwCamera2.signed.apk using your script on GitHub (huawei_camera_aosp repo, sorry I can't post links due to fresh account)

I was used extracted /system partition from official Huawei Oreo firmware (VKY-L29C10B362) and ROM keys from GitHub aosp-mirror/platform_build repo

Then I've installed the camera app to my phone using install.sh script in your repo.

Now I have the "com.huawei.camera" package in the system but it's crashing everytime I start it.

I'll be appreciated if you can suggest any help on it or can checkout logcat logs.
[Treble-Enabled Device Development A/AB ROMS] osk4rin:
[YOUTUBE]Q3W1xcwLd1M[/YOUTUBE]

huawei stock camera zip:

https://www.androidfilehost.com/?fid=746163614322262817
[Treble-Enabled Device Development A/AB ROMS] reeved:
[MENTION=1915408]phhusson[/MENTION] how were you able to build your apk without Java errors?

I've tried building it on two machines and I get the same error both times. I've used the P20 Pro system dump and the keys folder from here.

bash build.sh /mnt/c/users/USER/desktop/test/system /mnt/c/users/USER/desktop/test/tree
Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: 1887608904
at org.jf.dexlib2.dexbacked.BaseDexBuffer.readSmallUint(BaseDexBuffer.java:53)
at org.jf.dexlib2.dexbacked.OatFile$DexEntryIterator.next(OatFile.java:579)
at org.jf.dexlib2.dexbacked.OatFile$DexEntryIterator.next(OatFile.java:570)
at com.google.common.collect.TransformedIterator.next(TransformedIterator.java:48)
at org.jf.util.AbstractForwardSequentialList$1.next(AbstractForwardSequentialList.java:91)
at java.util.AbstractSequentialList.get(AbstractSequentialList.java:88)
at org.jf.dexlib2.DexFileFactory.loadDexFile(DexFileFactory.java:129)
at org.jf.baksmali.DexInputCommand.loadDexFile(DexInputCommand.java:144)
at org.jf.baksmali.DisassembleCommand.run(DisassembleCommand.java:161)
at org.jf.baksmali.Main.main(Main.java:102)
[Treble-Enabled Device Development A/AB ROMS] phhusson:
Try with a more recent baksmali?
[Treble-Enabled Device Development A/AB ROMS] reeved:
It's weird. I've tried it on two machines with small versions 2.2.2 (what the script automatically uses) and 2.2.3 (which I renamed to 2.2.2 to avoid confusing the script). I also tried using Java 8 and 10 and no matter what the issue persisted.

Would you mind building the APK for me? I could share with you the necessary files from the P20 Pro system dump (could also be useful if you wish to update the camera app :p ).
[Treble-Enabled Device Development A/AB ROMS] Boolable:
[MENTION=1915408]phhusson[/MENTION], in my opinion, this should be added to your first post of this thread.
[Treble-Enabled Device Development A/AB ROMS] madoxx77:
The app Is ok but when i try to switch cameras or change to video mode or portrait mode app crashes, does anyone know what to do ? My device Is Huawei p10
[Treble-Enabled Device Development A/AB ROMS] hex@dec:
Can someone help me out with the installation?

Whenever I put the HwCamera2.apk in priv-app, found in the opening post, or some others in the thread, it looks like something is messed up w/ the apk. Total Commander does not recognise it as an app, and neither do other file managers (no apk logo displayed). If I try to open it as zip, it fails.

What method do you guys use? Could dd work through terminal?
[Treble-Enabled Device Development A/AB ROMS] satwiknad:
Is slow motion camera is working in RR ROM. After installing stock camera in RR if no please anybody tell me how to install slow motion camera in

honor view 10 (RR rom)
[Treble-Enabled Device Development A/AB ROMS] velkeibalesz:
Slow Motion is not working on Mate 9. :(

Plus 1080p 60fps mode also not work. :(
[Treble-Enabled Device Development A/AB ROMS] ambitiousButRubbish:
Cant seem to get this working on an honor 9, running AOSP 8.1, how do I get the crash logs?
[Treble-Enabled Device Development A/AB ROMS] sknoman1:
will it work on Honor 9i (Kirin 659) ?

if not can you port it for me? badly need this because all treble rom has basic camera not extra features like huwaie camera.

i am using lineage treble (a-only)
[Treble-Enabled Device Development A/AB ROMS] shashank1320:
If thats treble then it may or may not work fine. Have backup in twrp and try.

Edit- sorry not sure if it will work as this is for 960/970 as per title.
[Treble-Enabled Device Development A/AB ROMS] TB2:
Thanks for this! The important parts are working.

Does someone know how to make this the default app to be launched when double-pressing the power button (in LineageOS GSI)?
[Treble-Enabled Device Development A/AB ROMS] ponces:
I successfully compiled for my Huawei P8 Lite 2017 (Kirin 655). However, video mode is not working...

If anyone wants to give a try, use the APK and the lib in the attachment.
[Treble-Enabled Device Development A/AB ROMS] sknoman1:
How did you set permission 655?
[Treble-Enabled Device Development A/AB ROMS] Fleckal:
When i try to install it it says app cant be installed

I use rescuration remix 8.1 on mate 10 pro blal09

Please help guys thanks
[Treble-Enabled Device Development A/AB ROMS] Asroe:
flash success on my huawei honor note 8

flashlight not work and phone no voice but voice search can work
[Treble-Enabled Device Development A/AB ROMS] hemant_jeengar:
[MENTION=1915408]phhusson[/MENTION] One plus 5/5T got official treble support. So is it possible to port the Oneplus stock camera app to other treble roms?
[Treble-Enabled Device Development A/AB ROMS] Boolable:
What is the procedure to extract Huawei Mate 10 Pro camera app from stock rom?

Will it works if I extract it from stock rom and install it to AOSP treble rom?
[Treble-Enabled Device Development A/AB ROMS] hemant_jeengar:
Check the OP . It has the build script.
[Treble-Enabled Device Development A/AB ROMS] 1003858449:
mi8(dipper) need a stock camera app for treble roms

help me please!
[Treble-Enabled Device Development A/AB ROMS] haggis23:
Got this working on my Mate 10 Pro (BLA-L09 8.0.0.131(C782)) - Thanks!

As with other posts some files need copied to /vendor/lib64 but for me I needed 3 files (using logcat to check).

libHwPostCamera_jni.so

libvislib_jni.so

android.hidl.base@1.0.so

I got them from a the stock ROM and I've uploaded them here incase anyone else needs: mega.nz/#!ZCYCQIBK!5W-MFXTQSAz-ivIQjRwHKHchjKkaYX7xGRd2rkp57PY

Unsure if it's related but my portrait mode works too :good:
[Treble-Enabled Device Development A/AB ROMS] FieryAura:
Possible to have this port for kirin 659?
[Treble-Enabled Device Development A/AB ROMS] Jelke997:
Kirin 950 support?
[Treble-Enabled Device Development A/AB ROMS] shashank1320:
Nope. Havent found anything related with that on this thread yet.
[Treble-Enabled Device Development A/AB ROMS] nachaxxla:
:svetius:
[Treble-Enabled Device Development A/AB ROMS] aureliomilitao:
i instal Havoc 8.1 GSI need install camera huawei

how install ? i put files in system priv app hwcamera2.....no appear apps
[Treble-Enabled Device Development A/AB ROMS] ∑(°Д°):
Have you set the file's permission to rw-r-r?

---------- Post added at 03:42 AM ---------- Previous post was at 03:39 AM ----------

I set this work in my Mate9 8.1,but it's not working,it's FC.
[Treble-Enabled Device Development A/AB ROMS] natanrosenfeld:
Thanks much, this worked for me! Honor 8 Lite, and i copied the libs from the Mega zip folder into Vendor.
[Treble-Enabled Device Development A/AB ROMS] srgrusso:
I'm using you build script and it's stopping at this error.

build.sh: line 49: signapk: command not found

I downloaded signapk from here https://code.google.com/archive/p/signapk/ and extracted it to your build script directory but I'm still getting an error.

Thanks

Edit: I just signed it with the zipsigner app.
[Treble-Enabled Device Development A/AB ROMS] srgrusso:
I'm trying to port HwCamera2 to the honor 8 and was hoping someone could give me some help. I started a new thread here.

https://xdaforums.com/honor-8/help/help-porting-hwcamera2-pie-treble-roms-t3850541

Thanks
[Treble-Enabled Device Development A/AB ROMS] Dixi1801:
Does this work on the P20 Pro?
[Treble-Enabled Device Development A/AB ROMS] yotic2:
I Have LineageOS running on P10 Plus and followed the instructions of Post #4 and also #50. Still the app crashes on start.

Here is the log:

02-24 19:29:42.589 924 3117 I ActivityManager: START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=com.huawei.camera/com.huawei.camera (has extras)} from uid 10036

02-24 19:29:42.689 924 1275 I ActivityManager: Start proc 4548:com.huawei.camera/u0a95 for activity com.huawei.camera/com.huawei.camera

02-24 19:29:42.890 4548 4548 E AndroidRuntime: Process: com.huawei.camera, PID: 4548

02-24 19:29:42.890 4548 4548 E AndroidRuntime: java.lang.RuntimeException: Unable to instantiate application com.huawei.camera2.controller.CameraApplication: java.lang.ClassNotFoundException: Didn't find class "com.huawei.camera2.controller.CameraApplication" on path: DexPathList[[zip file "/system/priv-app/HwCamera2/HwCamera2.apk"],nativeLibraryDirectories=[/system/priv-app/HwCamera2/lib/arm64, /system/lib64, /vendor/lib64, /system/lib64, /vendor/lib64]]

02-24 19:29:42.890 4548 4548 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: Didn't find class "com.huawei.camera2.controller.CameraApplication" on path: DexPathList[[zip file "/system/priv-app/HwCamera2/HwCamera2.apk"],nativeLibraryDirectories=[/system/priv-app/HwCamera2/lib/arm64, /system/lib64, /vendor/lib64, /system/lib64, /vendor/lib64]]

02-24 19:29:42.894 924 3209 W ActivityManager: Force finishing activity com.huawei.camera/com.huawei.camera

02-24 19:29:42.924 924 940 I ActivityManager: Showing crash dialog for package com.huawei.camera u0

02-24 19:29:43.406 924 939 W ActivityManager: Activity pause timeout for ActivityRecord{6341c07 u0 com.huawei.camera/com.huawei.camera t111 f}

02-24 19:29:45.156 924 3209 W ActivityManager: Force finishing activity com.huawei.camera/com.huawei.camera

02-24 19:29:45.159 924 3209 I ActivityManager: Killing 4548:com.huawei.camera/u0a95 (adj 900): crash

02-24 19:29:45.170 629 1061 E BufferQueueProducer: [Application Error: com.huawei.camera#0] disconnect: not connected (req=1)
[Treble-Enabled Device Development A/AB ROMS] theandroidguy:
Its better to wait a bit cz OP6 is launching around march, nd it will come with android Oreo i.e. Treble compatible, though the V10 is also a good one bt still the Treble based rom shows glitches mostly with huawei devices
[Treble-Enabled Device Development A/AB ROMS] Big-Blue:
After growing /system/ and installing the app in the appropriate location, modifying its permissions to 644 and rebooting, the camera crashes on opening for me.

45 seconds logcat here, the crash appears to happen around "01-19 20:34:29.175". I hope this is useful, if I can help I'd be happy to provide more information.
[Treble-Enabled Device Development A/AB ROMS] :
Have you added the lib file attached in post #4 of the thread? That did the job for me.
[Treble-Enabled Device Development A/AB ROMS] trive253:
Can i install this on honor 9 with RROS?
[Treble-Enabled Device Development A/AB ROMS] devanshu99:
Will this work on Honor 8 pro treble ROM ?
[Treble-Enabled Device Development A/AB ROMS] daniello8:
would appreciate a build that can be installed by adb install .. without root :)
[Treble-Enabled Device Development A/AB ROMS] devanshu99:
Thats sounds really good
[Treble-Enabled Device Development A/AB ROMS] ScardracS:
[MENTION=7354786]XePeleato[/MENTION] do you think It can work on our Honor 8?
[Treble-Enabled Device Development A/AB ROMS] XePeleato:
First the camera (as a system) needs to work lol. Then we'll see...
[Treble-Enabled Device Development A/AB ROMS] etern1ty:
Hey guys, Ive been running the script on the HwCamera2.apk from my mate 10 pro Oreo rom, as the app itself is different..

Now it runs fine until I need to sign it. Where would I find the stock keys to sign it with, or can I generate my own 1024 bit keys? I have the testkey.x509.pem but no idea about the private key, or pk8. Should I make a new pair of keys?
[Treble-Enabled Device Development A/AB ROMS] phhusson:
Well you can sign with any key, except for the platform certificate of your ROM.

I use AOSP's shared.{x509.pem,pk8}
[Treble-Enabled Device Development A/AB ROMS] phhusson:
Any key should work, except for platform keys (the app would get a wrong SELinux context). I personly sign with AOSP's "shared" key, but you're allowed to use a real key instead.
[Treble-Enabled Device Development A/AB ROMS] CertifiedBlyndGuy:
[MENTION=1915408]phhusson[/MENTION] This APK from the V10 help any? I can't legally use your script to Port it over ;). The camera app on the V10 has more features so I figured posting it might help some if you still have the system dump. If you need anything else then just ask.
[Treble-Enabled Device Development A/AB ROMS] Leechoonhwee:
Does this camera support camera2 api?
[Treble-Enabled Device Development A/AB ROMS] theandroidguy:
most probably it does
[Treble-Enabled Device Development A/AB ROMS] jalk44:
Using v9 aosp rom with a huawei mate 9 pro crash on open and installed in the correct directory
[Treble-Enabled Device Development A/AB ROMS] Nexus lover:
This does not work on my Honor View 10 with Treble-Phh.

This works on my Honor View 10 with Treble-Phh. Thanks.
[Treble-Enabled Device Development A/AB ROMS] CertifiedBlyndGuy:
Yeah. It has to be compiled with Phhussons script like I mentioned. It isn't legal to run it and I'm just trying to avoid legalities even though it's incredibly small. His script is on GitHub for you to use granted you're okay with legal caveats.
[Treble-Enabled Device Development A/AB ROMS] Nexus lover:
How to do that safely?

Anybody cares to share a link to a

safe

procedure? Of course Miss Google shows a lot possibilities, but not only good ones.
[Treble-Enabled Device Development A/AB ROMS] :
If you're unsure about resizing, you could uninstall some Google system apps to free up space, reboot then download them as user apps from the playstore.
[Treble-Enabled Device Development A/AB ROMS] Nexus lover:
That's how I fixed it for the moment, after reading this:

However, it's uncomfortable with such tight system space, to delete arbitrarily systems apps, and with 128GB there's more than enough space for data. It would be more convenient for future upgrades to have a bigger system partition.

In the meantime I read that apparently TWRP offers a possibility to resize, so I'll wait for TWRP for my Honor View 10.
[Treble-Enabled Device Development A/AB ROMS] 4RK4N:
not working on honor 9 lite with your treble rom. copied it to /system/priv-app/HwCamera2/ using mixplorer and on another attempts using termux.

maybe you can make smth out of the logs.

UPDATE: the lib from post #4 did the trick for me as well. there's gotta be smth about that lib :D
[Treble-Enabled Device Development A/AB ROMS] cooper2909:
copied the downloaded apk file to the folder using the mixplorer. but how to use it? still click the phh v11's default camera?

It's always crashing. Also used the post#4 method, still crashing. On mate 10 pro with v11.
[Treble-Enabled Device Development A/AB ROMS] vatsal_chandan:
Thanks in advance

is portrait mode working effectively ??
[Treble-Enabled Device Development A/AB ROMS] :
Couldn't get portrait mode to work (or HDR) and have since gone back to emui . Might just be a case of finding the correct lib file to copy from stock but am not sure.
[Treble-Enabled Device Development A/AB ROMS] woken:
No work for mi Mate 9 MHA-L09
[Treble-Enabled Device Development A/AB ROMS] mihaistefan88:
FATAL EXCEPTION: main
Process: com.huawei.camera, PID: 3206
java.lang.UnsatisfiedLinkError: dlopen failed: library "android.hidl.base@1.0.so" not found
at java.lang.Runtime.loadLibrary0(Runtime.java:1016)
at java.lang.System.loadLibrary(System.java:1657)
at com.huawei.hwpostcamera.HwPostCamera.<clinit>(HwPostCamera.java:15)
at java.lang.Class.classForName(Native Method)
at java.lang.Class.forName(Class.java:453)
at java.lang.Class.forName(Class.java:378)
at com.huawei.camera2.postprocess.PostCamera2.<clinit>(PostCamera2.java:83)
at com.huawei.camera2.postprocess.PostCamera2.isSupported(PostCamera2.java:234)
at com.huawei.camera2.controller.CameraApplication.onCreate(CameraApplication.java:81)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1119)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:5740)
at android.app.ActivityThread.-wrap1(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1656)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6494)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:440)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:807)

Maybe this will help with debugging. I'm using Lineage OS 15.1 on Huawei Mate 10 Pro. There is a file called libhidlbase.so in /vendor/lib64, and it has the right permissions (0644)

PS. i added the lib file in the 4th post with the appropriate permissions
[Treble-Enabled Device Development A/AB ROMS] abrahamjones:
Couldn't install neither: Mate 10 Pro (Lineage OS)
[Treble-Enabled Device Development A/AB ROMS] venreddy:
How is this camera performing compared to stock camera in view 10?

All taste features available? Same picture quality?
[Treble-Enabled Device Development A/AB ROMS] irony_delerium:
Took a bit of debugging (and the viewfinder is glitchy) but I managed to get this running on the LineageOS 15.1 Treble firmware.

For whatever the reason, LineageOS thinks the APK file is corrupt and won't run it ("inconsistent information" is what it had to say when it tried reading classes.dex; 'unzip' on the device had the same thing to say. Repacking it before installation seemed to work, though there are probably things broken as a result. Oh well.)

Needs android.hidl.base@1.0.so from an EMUI firmware (attached), put it into /vendor/lib64 alongside the libHwPostCamera_jni.so from post #4.

Edit: It's not the viewfinder that's glitchy. There are apparently some graphics glitches with Lineage on the Mate 9, or so it seems - lots of things are showing bad clipping and incomplete animations, not just the viewfinder.
[Treble-Enabled Device Development A/AB ROMS] abrahamjones:
Good job man, I will try it.

I noticed the glithcy issue too.
[Treble-Enabled Device Development A/AB ROMS] phhusson:
Thanks

What did you repack the APK with?

My script are using zip/unzip, I know that's not really clean, though it should work?!?

For the graphic glitches, I'd guess they are missing my hwcomposer fixes (Though my fixes are not perfect, so idk)

When you tell me how you fixed the "inconsistent information" I'll test it
[Treble-Enabled Device Development A/AB ROMS] irony_delerium:
It was convoluted because of the utilities I've got available on the machine, but;

- Renamed the downloaded HwCamera2.apk to HwCamera2.zip

- Unzipped it with Windows's built in ZIP reader

- Re-zipped it the same way

I tried renaming the output of this to HwCamera2.apk and pushing it into the correct location, but that just resulted in errors because it was compressed, so then:

> adb push NewZipFile.zip /sdcard

> adb shell

$ cd /sdcard

$ mkdir camera

$ cd camera

$ unzip ../NewZipFile.zip

$ zip -0 -r ../HwCamera2.apk *

And then I put that APK into /system/priv-app/HwCamera2/HwCamera2.apk, which resulted in success. Maybe there's something screwy with libzip in that LineageOS build?
[Treble-Enabled Device Development A/AB ROMS] phhusson:
Uh, ok thanks, I'll try that.

The problem is exactly the same on AOSP, so it's not Lineage's fault
[Treble-Enabled Device Development A/AB ROMS] mihaistefan88:
Well, after i copied that missing lib it worked, i didnt have to re zip the apk. (I copied it from the stock rom and signed it using the script posted in the OP). Some features like the slow mo didnt work and i had a weird bug: The viewfinder had very low fps only on one half of the display. Also, some photo resolutions were not available (the higher ones). Im on huawei mate 10 pro.
[Treble-Enabled Device Development A/AB ROMS] BadWolfYe:
Hello i have this error:

02-26 10:19:45.122 E/VendorTagDescriptor(13087): lookupTag: Tag name 'donotSupportHwCamera' does not exist.

02-26 10:19:45.122 E/SilentCameraCharacteristics(13087): can not get key <CameraCharacteristics.Key(com.huawei.device.capabilities.donotSupportHwCamera)>
[Treble-Enabled Device Development A/AB ROMS] phhusson:
Which ROM/version are you using?
[Treble-Enabled Device Development A/AB ROMS] mihaistefan88:
I was using the treble Lineage OS 15.1
[Treble-Enabled Device Development A/AB ROMS] phhusson:
Ok, that's most likely the reason why.

They didn't include my SurfaceFlinger fixes, looks like Huawei View 10 doesn't need it.

I'll check on my Mate 9 to confirm.
[Treble-Enabled Device Development A/AB ROMS] mihaistefan88:
Oh, ok. Ill try it with your rom tonight. :D
[Treble-Enabled Device Development A/AB ROMS] tr1cky1:
Is there an easy way to get this working on LineageOS 15.1 Treble Rom on the Mate 10 Pro?