yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Here's the logcat I took of the same bug when I was on DerpFest before jumping back to CNP. If it doesn't help, I'll reflash AICP and take it again.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Here are the steps to reproduce the above AOD bug almost consistently:

1. Set Ambient Display to "Always On".

2. Set the option to Display Alarms, Weather and Notifications beneath the clock.

3. Leave the default screen timeout set to 1 minute.

4. Go to your homescreen then let the display timeout.

5. AOD clock, weather and notifications appear as they should.

6. After a few seconds/minutes, AOD clock will automatically disappear and the status bar will suddenly appear.

BTW, the AOD bug is less likely to occur if you manually turn off the phone's display instead of letting the display timeout naturally. Weird!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
We try and reproduce it, as the log is kind of inconsistent and full of other errors.

As of now, I saw a permission denial for Google user presence, a sensor error for proximity and an error for adaptive brightness during AOD.

Thanks. Puh...might take some time though.

EDIT: I can reproduce it on op6 too, so narrowing it down and suspecting proximity sensor at the moment. Omni uses a different sensor readout on doze. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Why is that not possible?

Every version had this function.

The option is not good for me.

Iam using 2g at home.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Because it is a lineage thing?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I'm SO glad to hear you can reproduce this bug. All other devs seem to think I'm crazy! :laugh:

So far, I have been able to produce this bug on AICP, Derp, crDroid, and Validus. Only CNP and Omni have been able to escape it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
With Aicp 13.1 you said too that the rom ist not los based,

But it had system profiles settings.

This makes me confuse.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
13.1 is los based, 14 isn't.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Nope, it did not. As you can even read on our homepage.

---------- Post added at 07:08 PM ---------- Previous post was at 07:06 PM ----------

I know, you posted on Validus thread and we already discussed it. ;)

The others just do not post this often publicly, haha.

Getting no immediate answer does not mean nothing is happening "behind the scenes".
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
That's awesome! I know many ROMs share the same code base but some devs said they couldn't reproduce the bug so I was thrilled when you said you could. I love Android and the custom ROM community. You devs ROCK! ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Sry, i think so, its my fault.

But the option was really good, to set what the phone does when it connect to or disconnect from wlan.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
You can use apps like Tasker for that (and for much, much more), or something like LibreTasks or Easer (both open source, available on F-Droid)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Yeah thx. I have bought tasker but last using in 2014, lol.

Today i have a new problem.

I have used Blu Spark twrp 9100, i cant make nandroid backups.

Its abort with fork failure 255. After that i flashed the latest bluspark, same issue. The only thing what i can do, is that i can restore my backup from may.

Anybody knows what going wrong?

Edit:

OK, something was wrong with my running system.

After restoring my may-backup and flashing todays weekly all is fine.

I can make nandroid backups with bluspark twrp 9101.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I would like to know what happens after the last major update for the oneplus5. will there be more custom roms after that? or do we have to buy a new phone because then the drivers are missing or the firmware files?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sliqqq:
Are the nightlies stable yet? I'm on 160118, looking to update but kind of need a stable device right now. Having no problems on this build so far.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Believe me, I am older, but well helping people that ask is easy, helping on messages like "too bad" is not really a 'bummer'. :D

---------- Post added at 09:27 ---------- Previous post was at 09:24 ----------

I am using it a my daily driver since... 17/12/31, lol...

Whatever we add to it will not affect the user experience as it would break my phone. So, if it ever does not work, you can always flash the build from the day before...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] se7ensde:
Is there no option for disabling the backlight on the capacitive keys or am I just missing it?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Tiago A:
How is the photo quality of this with stock oos camera app? Too much difference from oos? Same quality? Its that possible to install oneplus camera service?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sliqqq:
It's ok. I personally installed the missed Google hdr camera as I think that's the best camera right now. You can install the one plus camera M, but it has no portrait mode. I'm actually quite interested in getting that to work though if anyone has had any success?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
Hello everyone you think it's possible soon to add in this rom the 4G logo instead the LTE logo in status bar? Good work and thanks for all.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] jaidev.s:
Does this Rom has Always on Display feature like Pixel devices? Clock is showing up on lock screen and it's not going dark even after 5 min.

edit : I had ambient display on.. After I turned it off, lock screen is going blank..
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dakotah2468:
It does have always on display, you can disable it in settings -> system -> system ui tuner -> ambient display
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Sliqqq:
Good point actually.. I have an 'R' next to one of my Sims (data roaming not on), can this be removed? Any ideas what it is?:confused:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] se7ensde:
so is there an option for this or not cause it's the only thing breaking the deal for me on this rom at the moment.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] se7ensde:
Is there an option for disabling backlight on hardware keys or not cause I don't see it anywhere in settings. And if not is it going to be added?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] willybarca:
Yeh I'm looking for backlight option too I dont think its implemented yet, but almost every other ROM has it
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Backlight option is being tested
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dd0s:
Is aptx working? When i connect to my aptx device there is no icon in the status bar.

Is weather on Lockscreen working? Cant get any weather information.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] whymista:
I'm trying to get to the latest version as I have last nights but I'm confused on how the OTA works. I've already downloaded the full zip but I don't see any built in OTA app.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Should we add it to patches, [MENTION=2511007]csolanol[/MENTION] ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Yup [emoji106]
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Did you set the OTA to check daily?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] whymista:
I don't see where there is an option for Ota
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Maybe my old post from our community can help? ;)

https://plus.google.com/115015009651694560786/posts/RXRZzSu8PMp
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Various developers are still creating ROMs for my super old Galaxy S4! Our beloved OP5 will continue to be supported by our awesome dev community for many years to come, I'm sure. :cool:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Yeah, i know that, but i know too that we need at every new android Version a firmware.

In September my 1P5 is 2 years old. For Sure i will use this phone for the next 2 years.

It is the best phone i ever had.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mzahs:
I want to try this rom but wanted to know if any issues with the latest version?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
No issues.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mzahs:
How is the gps? does OOS camera work with this rom?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
If you want to know if the ROM includes some specific patches for camera or gps, then the answer is: no.

GPS is fine afaik, but depending on your coverage in your location.

OOS camera is working, but no modifications included for things like portrait mode (which is not working) as most use gcam. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Unfortunately, every custom ROM I've tested so far (e.g. Xtended, DerpFest, CNP, AICP, Omni Treskmod, etc.) has the mic gain turned up way too high when recording video with the front camera. To experience this for yourself, go to a very quiet room, turn on the front camera and record the silence. When you playback the video, you will notice the noticeably louder white background noise. This behavior is present in most custom ROMs whenever using the OOS camera or a GCam variation. It seems only the OOS stock ROM can get around this issue. Have any thoughts or suggestions?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mzahs:
OOS camera works fine on CNP rom.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Yes, it works but the sound quality of the recorded video also contains much noise.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
You make Videos with the Front Camera?

Are you female?

Dont Care about the Front cam :D

[MENTION=6916498]wartomato[/MENTION] i found a bug.

After enabling gps via qs, you cant disable it, only via long Press to settings.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Yes, I make a lot of videos with the front camera.

No, I am not a female! :laugh:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Please wait for next build. If it happens again, please tell me what other settings (location-wise) you turned on and grab a logcat please.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Hi guys, latest build needs 9.0.6 firmware. You can download it from https://sourceforge.net/projects/ch...firmware/firmware_9.0.6_oneplus5.zip/download
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Here is a logcat from fresh flash today.

Same issue with GPS qs.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Flashed latest official build and it is working ok here.

https://www.dropbox.com/s/hasy16gk9vnmuda/ScreenRec_20190626_080309.mp4?dl=0
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Here not :D

Edit: now its working.

You must set Google location accuracy to enable.

Then i can switch between the Location modes.

That must be said yes :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Here.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
That's why I mentioned "what other settings (location-wise) you set", ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I die not understand it.

And in the last few years you did not have to do that.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
In the last few years you were not using pie, I guess.

We cannot change the way Google handles stuff in every new Android version. Sorry.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Yes, that was new for me.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Is that normal, that the option ist Grey?

It is since the new flash.

Today i have the problem that the screen brightness is on 0, after reboot.

Outside i cant do nothing.

And when iam listening music the tracks skipping or stopped.

Pocket detection is on and Screen gestures are disabled.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yes, we are aware of that but. Ofc we try and fix it as soon as possible.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] quicksilvr:
I can't get mobile data to work with this. Flashed the latest firmware + radio, tried old ones too. Still no luck.

Any one else face this issue?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Maybe you need to change your APN settings
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dd0s:
Yes, had to change my apn settings too. Many Roms got that Problem.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
No build this week?

Edit: Shows up now :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
It shows up for me.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Yeah I spoke too soon :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yup, misses some fixes as we were too slow, but they will be in the next build. :rolleyes:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] S2_fa_007:
Seems on last version user ca certificates aren't installed, they doesn't appear in the trusted user tab.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sam.balia1012:
screen-record

Any reason why screen-record launches on its own. Happened multiple times....???

Accidental pocket mode is enabled so i don't know what could've triggerd it ??
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Do you have a launcher gesture set for it?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sam.balia1012:
No, I don't.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Hm, can't think of any other reason for it to be enabled randomly... I have never experienced this
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sam.balia1012:
I had it on the power button, but why only screen-record get randomly started ???

I'm removing it from power button for now..

worth sharing tho !
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
The gps in this rom is very fast.

Awesome, thx.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] anjo88:
I do have oxygen os 9.0.6 android pie and is very slow since android pie :( im searching for a good rom to switch!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, don't expect the team to answer this question, haha. We think it is "okay" so far.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
The latest build seems really good in regards to battery usage.

Thank you!

Although I've been having a few issues lately. For the past few weeks, after selecting install through the updated, it doesn't reboot itself. I long press the power button, which turns it off, then when I turn it back on it boots straight into TWRP and installs fine.

Also just today I've been getting a lot of soft reboots.

Thanks guys

NaterTots
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Maybe you got a bad flash from the updater. I would flash latest build manually from twrp to be sure those issues aren't caused by a bad flash.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I have a fresh Install in 0625 and Update every Werk with Auto updater. No issues, no reboots. All is fine.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
Yeah I don't know what's going on. I've been updating weekly since April.

I can't get into the App info part of settings without settings closing on me.

I flashed the 7-21 build this morning, that I downloaded on my PC and checked the Md5, and it's still doing it.

Tonight I'll try to flash last week's build and see what that does. If it doesn't fix anything I'll format my phone.

Unless one of the Team wants to see a log.

Thanks for the help guys ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Hi guys, 9.0.7 firmware mandatory for next build (20190729). Download it from the op link or from https://sourceforge.net/projects/cheeseburgerdumplings/files/16.0/cheeseburger/firmware/ and flash it from twrp before the build.

Enjoy!.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
So over the weekend I ended up having to do a format of my device and now everything is good.

Not sure if it was something on my end or not.

Installed the latest firmware and today's build is going great!

Thanks again guys!

I'm really not sure why I haven't put this on my essential yet.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Because Essential has a mighty Dev which does magic to the kernel, haha?

Plus you are not alone, I had to do the same here... ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Ashish.akc:
Is it really Weeb? I was planning to flash this along with weeb kernel tomorrow:D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Ofc weeb is more updated, so feel free to flash it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Ashish.akc:
Found a few things that intrigued or caught my intention

1. QS tiles look a lot cleaner in the edit screen (when you tap the edit icon). Like battery percentage shown under battery saver tile, arrows adjacent to wifi and bluetooth, carrier name in place of mobile data.

2. Emergency button in power menu is visible even after you disable it in Power Button settings

3. Q style text clock on lock screen has issues with dark background wallpapers. "It's" always stays dark and hence not visible.

4. No icon pack support? Could we please have this.

5. Launcher settings keep reverting to default, upon restart maybe. Not much sure of this point/behaviour.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sleepwalking0593:
3. The colour of its depend upon background wallpaper that you use. Change the wallpaper to get different could of "it's"

4. And 5. Use lawnchair launcher
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
1. Hmm. Not the case here.

2. This is depending on your provider & location, e.g. like Indian providers are forced to let the phone show the button by law. Not our fault. It can be disabled, but we do not see the need for bypassing a countries law.

3. Yes. It is not perfect and was never meant to be be...

4. No.

5. Well, cannot reproduce this either.

---------- Post added at 07:39 AM ---------- Previous post was at 07:36 AM ----------

Can we stick to: Feel free to use ANY launcher you like that supports it, please?

That launcher is merely the pure AOSP one, so nothing much can be expected from it, haha, even google provides their own launcher...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Ashish.akc:
You know there are arrows next to WIFI, Mobile Data, Bluetooth names. When the QS portrait column is set to like 5/6 everything gets so close that those arrows take a considerable space and make things look more clumsy.

If those arrows could get auto disabled after like 5 or more column number, it would look more clean.

The included launcher had everything that i needed except icon pack support. But no issue with that. I'll happily switch to something else

Accent color. So many shades of blue which look almost similar and some colors like red have slightly less saturation (like red has more pinkish feel to it)

Definitely all nitpicks within ui, nothing major with the rom though. Was smooth, clean and fast. Performance wise excellent.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Disregard
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Okay. Now I got it.

Hmmm. I know the QS tile Infos are scrolled in the case of icons set to a higher number of columns. Well, so yeah, the little arrows can be a visual disturbance. I will set it on the list and see what the others think about it.

For icon packs... It is on the list already ;)

Yup, our maintainers like to add their favourite accents and even I was thinking about "cleaning" then up or trying another approach like a colour picker.

So, of course we don't disregard these things, haha. How else should we get ideas to make it "better"?

:good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Is there a way to enable the old wifi icon?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SpiritCroc:
Right now not, but I'll probably add it since I can't stand the new icons :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Yeah same :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SpiritCroc:
Next build should have it under Aicp Extras / Themes / System icons style
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Ashish.akc:
Anyword on how long will these be updated/added? What other's thought of it?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Nice, thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
QS tiles are in testing and discussion for latest change on the logic.

Colour picker in discussion.

Icon packs might take a little longer (holiday time here).

Patience is a gift that not many recieved, I know, haha.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] junliruyi:
NFC doesn't work on the latest and previous builds, it grayed out immediately when I turned it on. Should not be the hardware issue because it works well on OOS. Any idea on this?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
I's working ok here. Flash this build and test please:

https://www.androidfilehost.com/?fid=6006931924117931964

If it works for you, use it until next weekly.

Is someone else having this issue?.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] junliruyi:
I tried this one, NFC works good now. Thanks much!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] markeees:
I got a question.

I can't find the option to make ambient display always on through the menus. Can someone tell me where this menu is ?

Edit : Nevermind, found it by long-pressing the quicksettings tile
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
NFC is fine for me.

Turning it off helped me realize what the status bar icon looks like.

Past 2 days I've been wondering what that square icon was ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] qteqte:
Hi

Is there an option to change the alert slider configuration modes -

For example: top to "ring" and bottom to "silent"?

And where is it in the settings?

Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] danjamand:
Settings - System - Notification Slider :good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] markeees:
I updated using the updater in settings, but I cant seem to find the aicp_ota or aicp_updates folder where the zip gets saved. Can someone tell me where it is ?

Also, I dont know if it comes from the recovery or the rom, but when booting to the recovery it asks for password to encrypt. When I type the password, it decrypts the storage successfully like one would expect, but if I type a random password and click "Cancel" after it tells me that the password is wrong, I still can see decrypted files which isnt normal.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Ashish.akc:
Noticed the expandable QS function getting refreshed in the changelog :highfive: Will flash as soon as i get home.

Though one thing, is it recommended to format data partition in f2fs with this rom? (Weeb supports f2fs)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Noticed two things:

1. While flashing it says "target: 8.1.0", no big deal since it works of course, just a little funky

2. The new accent color picker is glitched. I remember it used to be a list with names, now it's a color palette, but it looks weird.