yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Ported, working, will be merged shortly.

---------- Post added at 10:35 ---------- Previous post was at 10:30 ----------

As we observed that on the dumpliing forum... yesterdays and todays nightly had many changes on the kernel, thus you might need to add Magisk 16.4 to the flash queue in the OTA app, when flashing one of these builds. Otherwise Magisk might not be able to adapt the boot.img changes.

Not doing might result in a bootloop on the logo screen.

The builds are fine, but need this "little" additional step.

(And yes, Magisk 16.0 might not "do the job", so please use 16.4.)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
Nice news. Thanks and have a good day
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
Good news, i flashed both and niether time did I need magisk to reflash.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeuRaul:
Hi, anyone can help me with some bug?

When I update OTA, with dirty flash [wipe system, cache & Dalvik; flash ROM, Gapps & magisk], my apps [whatsapp, instagram, etc...] kinda lost access to pictures. I only can see new pictures captured by camera or screenshot, but not others on the phone, edited, downloaded, etc... I simply can't see them.

On the QuickPic app I can access all pictures and manage then, including share then to other apps. But only on QuickPik.

On File Explorers I can access images too.

Last time That happened I had to full wipe, worked. But I wanted to update without loss data.

Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ostap999:
I am confused as to what you are doing.

This is how i understand the terms

OTA = Over the air update - gets done by ACIP manager using a script no user interaction required

Dirty Flash - Flash new rom over old rom (no wipe) no need to flash gaps or magisk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeuRaul:
Sorry.

I tryed both, the OTA with the AICP manager and the Dirty flash.

Get the same problem.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] alanjolly123:
Try to manually give storage permission to apps from their app info.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
This cannot be caused by the ROM. It doesn't touch permissions of the apps on a dirty flash. So must either be your GApps or something else you did or installed.

I am doing this daily for months now and never experienced that.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
I dropped 20 usd to show some love,. If you need machines to help build/etc I might be able to help, I got an 4 core i5 2.4ghz with 32gigs of DDR3 and a 1TB SSD.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Thanks very much. We appreciate it.

For the machines, well...

We already have 3 build servers and another one for test builds in between the nightlies... And the maintainers build on their machines as well, so, OP5 might be the best covered device here. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ScrawlyG:
Any chance you guys will implement the customizable Lockscreen time and date? ( I think it was in custom rr unofficial where you could already change the font and size)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
May I guess? You aren't using this ROM, right?

Otherwise...it is already in, lol...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ScrawlyG:
I meant it like in my attachment :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
That's in testing and might be merged in a few days, if we are satisfied with it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ScrawlyG:
Thanks for the info!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
4G icon is working now :)

3G too?

THX.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
You should not ask that much...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
FYSA that modem check update from a couple of days ago worked really well. I am not disconnecting from wifi randomly like I was before.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Notice:

Today's build includes full Flash Kernel from [MENTION=6842057]nathanchance[/MENTION] as some of our devs observed some battery drain on LineageOS kernel in conjunction with Bluetooth (it seems).

So, ther eis no need to flash it "again" with the ROM. Just to mention.... :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Hey just tested the Trust feature, and I was wondering if there would be a way to toggle it off. For example to make Viper4A, I need to be in selinux permissive. Also, root isn't working anymore.

Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] S2_fa_007:
Just install the magisk module from shadysquirrel, it includes the needed selinux contexts for V4A to work with enforced :).

Sent by OnePlus 5 with Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Thanks for the info. However this is the same issue as for root. Tasker doesn't want to do anything because it can't access root :S
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, V4A is only working on Oreo ROMs via a Magisk install (as already stated).

Toggling the SELinux state is still available and working via AICP Extras, if you really think you need it. ;)

And Root is working fine as Trust has nothing to do with that.

Perhaps I should say, that "Trust" is merely nothing more than a helper / information system for users to see what the system state on the phone is.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah I need to check if the selinux is correctly changed even though Trust says it's enforcing.

For the root stuff, some apps work, but seems Tasker isn't anymore. However I'm not sure if it's linked to an update of Tasker or directly to Trust. I made two builds, one without trust and one with all the commits in order to test this out.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Here is the message of Tasker.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yes? and? - You never wrote that Tasker cannot get a permission anymore. You wrote that root does not work anymore, if my memory serves me well... which is wrong.

And well, it might be a Tasker problem or the Tasker script you're using?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah sorry for that went to conclusions, I only tested another root item this morning lol... And seeing the message thought that root all together was KIA. Not sure if the script is the reason, it worked perfectly before without any modifications... Hmm need to test more into detail.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, lineage detects lineage root, haha
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah well tested without Trust and Tasker still doesn't work so yeah, Trust isn't the culprit here ^^

///Edit: Tasker updated and works now lol... Anyways thanks for the help!

Just little info, I'm using 5.1.2 firmware without issues, but I had to use 5.1.0 modem cause apparently it doesn't work well here in France, can't seem to get 4G, it doesn't get the correct network it seems...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
I made changes on the providers, so, if you can give me the provider info,... Maybe it was my fault....Maybe...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Oh, didn't see that commit, when did you merged it?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Maybe two weeks ago... Don't know right now, lol...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Mmmh thing is I changed provider last week, so not sure if your change has an impact. The APN is correct however, so not sure if there's something else that you changed.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Just changed a few flags for some providers, based on Google devices. Need to look into it, because i made a derp for US providers (which should not affect you, ofc).

There were changes to the signal strength too, but, actually yes, my device (after these changes) switches more often between 3G and 4G(+)...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z0mghii:
Anyone else not getting audio out of plugged in headset? Notification sounds work.

Edit: Might be the OB11 firmware/modem, clean flashed back to june 1st build and audio still not working. Remember audio was working before updating firmware/modem

Edit 2: I'm retarded and forgot OP notes to use OOS over OB firmware/modem, that fixed the issues
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah they don't use the blobs from OpenBeta builds, so the firmware will not work properly (since it will try to use the blobs from OB instead of stable).

BTW, why don't you guys use blobs from OB? Stability issues?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
You answered it yourself, lol...

And did you ever look what changed? Like from OB11 to 5.1.3 during the 4 days when the OB was "active". ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] KaszasM:
add "modversion" word in build prop and try ;) like new line

# modversion for tasker

done

Tapatalkkal küldve az én ONEPLUS A5000 eszközömről
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] myishika:
Since upgrade.... I cannot login to Google playstore. Playstore service is showing as missing.

Tried to reinstall Opengapps 19th June, 12th June but didn't work.

Even wiped system, data and cache but same result.

Google services just not working.

Gmail and playstore is reachable via browser though.

Tried Titanium restore of GPS but it failed.

Restored the TWRP backup but Google service were not working there too...

Any suggestions?

Thanks

DG
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
1. Wrong firmware?

2. Titanium will not help you.

3. What "upgrade"?

4. What GApps package were you trying to install?

5. What (the hell) did you do on install?

6. You are encrypted?

7. Anything installed we should know? Xposed, Magisk v16.x...with some modules?

8. Maybe a logcat would be nice...after answering the questions above.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] myishika:
Thanks for your reply.

I upgrading d from 12rh June nightly to 18th June. ai was installing Nano OpenGapps 18th June version.

During install, i wipws cache, system,. data, installed ROM, Gapps, Magisk. Without Magisk gave the same error. UnEncrypted.

Finally, reformat, reinstall with pico OpenGapps package did the trick.

Thanks though.

DG
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yep, I cannot understand why anyone always seem to try to install "Nano GApps" on a highend phone with plenty of storage and RAM...

That's why we advise to use at least Mini version of the package or higher...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] S2_fa_007:
I use pico gapps :D

Sent by OnePlus 5 with Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] djsubterrain:
I use Nano Gapps because the Play Store installs all my other apps anyway.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
I use pico gapps too. ^^
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
I run nano with no problems. Sounds like his permissions screwed up or something...

I'm dumb though, did a fresh install (full wipe of device) yesterday, didn't flash any gapps (had it in the folder with AICP) booted to find gapps installed already.

All this time I never knew AICP installed gapps if the file was in the folder (or does it not and I missed something?)

What other marvelous tricks am I missing?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] creeve4:
Are the official builds signed differently than unofficial? I.e. can I flash a home-built version over official?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
No, you can flash any build over official.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Hihi, a LineageOS user....
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] creeve4:
When pressing the back button quickly 4 times in a row it acts like pressing the Home button. Anyone else seeing this?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SpiritCroc:
That's expected behaviour, see https://www.xda-developers.com/andr...ode-that-detects-frantic-back-button-presses/
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] creeve4:
Is it just me or is DT2W sometimes slow to respond and/or it requires several tries to get the screen to wake?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yup, if the device was a long time in "deep sleep" state, I experience it too, so I usually use the powerbutton.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] theo72:
Hello wartomato has not been? implemented the Brightness slider..

Inviato dal mio ONEPLUS A5000 utilizzando Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
Hello, every one. I have a question can i use substratum and the custom color in the rom or if i use substratum the option disapear in the rom?

Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It will be greyed out and a message pops up. You cannot have it both.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] djsubterrain:
Anyone getting an issue with Magisk/Substratum with today's build?

I uninstalled my current theme (Edge), installed today's OTA, rebooted, installed the latest gapps nano package later when available.

When I go to substratum now it lists the themes but when I try to go into one it just freezes. Tried other themes and they do the same. Tried uninstall/reinstall of Substratum and the Edge theme. Tried flashing Magisk again too. It was all working fine on yesterday's build, that's why I'm asking. I did read something on G+ about an issue with the Play store version so flashed the gapps from 28th (everything was working previously with that) but the issue still remains.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Now, can you please tell me:

A. Why did you flash GApps.

B. Why did you reflash Magisk.

C. Why did you flash it at all and not install via the Manager?

D. Did you update subs to v997?

E. Was a your theme updated (at all)?

Right now your description is confusing as you did almost everything against what we advise...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] djsubterrain:
A. I flash the rom daily so I flash the gapps daily too.

B. I was trying to track down a cause and substratum wasn't being listed in the rooted apps.

C. Substratum requests root to work without the companion PC application

D. All apps are updated to latest and, as I said, I uninstalled and re-installed substratum from the play store.

E. As I said the theme was working yesterday.

F. What's with the attitude?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Attitude is that it works flawlessly here.

Magisk is persistent on OTA update.

GApps are persistent on OTA update (and updated via play store).

This is also described in the op here.

So, it is confusing... That not "attitude", but just question from the team...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
From today's build... "Dirty" flashed... Just saying.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] djsubterrain:
Welp, I just clean flashed (Fastboot -w and then wiped all partitions), flashed today's build, today's gapps nano and Magisk 16.4 and it's still happening when I go into substratum and try to apply a theme, the app blurs as if the theme details are going to come up and then nothing. Attached AICP logs.

From that log Magisk was supposed to have shown a prompt when I tried to access the theme, it didn't show any prompt. It seems to only be happening with some themes, possibly an overlay problem as the screen dims as if another layer is supposed to be on top which doesn't show up.

I've made a video of what's happening here.

https://www.youtube.com/watch?v=BN10yMu-rWw

Substratum did have an update yesterday I think so it's probably down to that. Hopefully they'll fix it soon.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yes, I can see the 100 themes and iconpacks.

In log the is only one instance if Magisk at the end.

And the FC of De Jan's Nineteen theme, because it could not connect to verify the purchase of it.

There is no fault in the ROM as far as I can see.

And as I use subs, Magisk 16.4 and today's build plus opengapps aroma without issues... Must be something else on your side.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
Hello, someone can tell me where can i found the wallpaper of aicp or someone can upload for me the wallpaper. Thanks everybody.

This one.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
That's not from us.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
OK I thought I saw this is the basic wallpaper of the ROM
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gouthamgoumi:
Even Im having the same issue on both aicp and treskmod omni..pitchblack works but Valerie,nineteen,desire,belo,dark infusion isn't working :crying:

Edit: just found out that it's a gapps issue...June 23 gapps works fine
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SpiritCroc:
https://github.com/AICP/vendor_aicp...es/res/drawable-xxxhdpi/default_wallpaper.png
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Like I said: not from us... from LineageOS.

Makes me wonder why we do not use our own? :/
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SpiritCroc:
Want to use moshe's wallpapers? :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It is, but it a LineageOS wallpaper, that we imported. ;)

---------- Post added at 07:59 AM ---------- Previous post was at 07:58 AM ----------

Hahahahaha...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] MarcoBobolo:
I just clean‐flashed 2018.07.02 version and it seems impressive — many thanks to developers! — but I encounter the exact same encryption problem with stock kernel. Is encryption functional in this ROM?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Denkai:
[MENTION=6916498]wartomato[/MENTION] Dumb question as it really changes nothing in the grand scheme of things... Are you planning on changing to treble support now that Open Beta 13 is bringing treble to OP5?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Of course? - Actually OnePlus was asked months ago about switching the devices to "half treble" (yes, it is not full treble with A/B partitions) as two well-known devs for the device managed to use a spare partition as vendor and build + boot successfully.

As these commits are still open on LineageOS, they just need updating and it should work out.

Maybe a few more new (or currently solved) issues will re-arise, but generally it makes our life easier too.

in short: It is next on the list after I convinced to others of File based encryption, haha...

I think i should share a comment from LineageOS devs for treble from their Gerrit (thus we just need a bit patience):

" DON'T do this, OnePlus added a new partition in open beta 6 and

it'll become /vendor in the future, what you guys are doing can

conflict with stock.

XiNGRZ is in contact with OP engineers, so we will of course do it aligned to stock :)"

The comment was about unlocking the "sdf6" partition for vendor on LineageOS. Actually OnePlus followed XiNGZ and codeworkx suggestions to unlock this spare partition now for treble support now.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z0mghii:
I have had this issue on multiple roms. It's easily fixed if you follow this guide https://android.stackexchange.com/q...device-running-cyanogenmod-12-1/131293#131293. See Frederick Nord's answer
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Sorry for a late (and maybe not satisfying responce):

From what I read on the TWRP threads, the issue is this:

"The good news is, I was able to build a TWRP that decrypts AOSP Oreo. The bad news is, whether or not decryption works is dependent on whether the build version and security patch level of the image match what system shows. Even if I dynamically update the props in recovery based on what's in system, it seems that the values from the cmdline supersede any props, so there's no real way to make them match before keymaster tries to start. I'm not sure what the best solution is for this, to be honest. This is an issue that exists on all Oreo devices that use FDE. I'm working with [MENTION=702506]dees[/MENTION]-Troy on this for another device, so if we can figure out a way around it there, then I can apply that same fix here. But I'm not currently hopeful ."

In short, if build version and sec level do not exactly match, it will not work as internal keymaster vows out.

This is partly our fault (and or LOS) at it seems the build version and vendor and security level and maybe some other properties are sometimes "behind the schedule".

That is my current understanding of the issue and I hope I explained it in an understandable way.

---------- Post added at 16:07 ---------- Previous post was at 15:38 ----------

actually we already do that and leave 16384 as an overlap for it...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
[MENTION=6916498]wartomato[/MENTION]

I'm not sure if it helps, but I am running these builds with encryption and I'm not having any issues updating each day. I do need to put in my pin in TWRP for them to auto flash.

The only issue I've had is that if I turn off my device and turn it on right away when I go to put in my pin for the device to start it says my data is corrupt and I need to reset/format the device. A long press on the power button turns it back off, I wait a minute before restarting and it's fine. This has happened twice so far. Not sure why.

Thanks for the continued support!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, I ran encrypted for a while too. I preserved my "old" OOS partition data (the "overlap") which is still encrypted and so Magisk has the "keep encryption" turned on here...

Dunno if that is an issue for the users. Apart from that, it was okay, yeah.

I already chacked, if we missed something, but no...

(And yes, I had this issue too 1-3 times during encryption. Don't know if it is a Magisk thing or not actually)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] MarcoBobolo:
Thank you for your detailed answer. File‐based encryption seems to be the way to go, then; right?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It is what google prefers, yes.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
So, I'm on the 13.1 build from June 30.

I downloaded the lastest build through the updater but when it rebooted to TWRP my pin for recovery wasn't accepted.

I'm pretty sure I'm on the lastest TWRP.

I'm basically just checking if this is a known issue.

Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
No? The Creator has no access to your phone... :eek:

Very ridiculous, as most phones were or are unencrypted, lol

It is just that I explained the reason a hundred times already.

In the end, it is up to you to encrypt or not. It is just unencrypted on the install. You can of course encrypt after that.

And why in the world would we want your passwords?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] cerealguy:
Looool!

Inviato dal mio ONEPLUS A5000 utilizzando Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] VampireHeart:
If you think that stop flashing every custom ROM. :rolleyes:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] c3drik 67:
Hello, it's possible to reverse the Hardware button?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] scoredance:
Hi. Anyone got this problem too? How to solve it?

Edit: solved with shutdown. Reboot just not working.