yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z0mghii:
I figured it out, I disabled Android Logging which is required for safetynet

"If you're here because MagiskHide, SafetyNet, Google Pay, etc, isn't working. This is why... Android logging need to be enabled for MagiskHide to work (also see "Requirements")."

https://www.didgeridoohan.com/magisk/MagiskHelp
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yes, blu_spark kernel already includes the vendor change for the open beta. That's why it worked, because it "sees" the partition.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] twcobra:
I noticed some 3minit battery java commits. Has 3minit battery been implemented into AICP 8.1. Or is this some old Nougat commits I am seeing..
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Old nougat commits I guess.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yup, those are from n7.1, so Nougat...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] twcobra:
Darn and I had hoped that someone actually got it to work with Oreo. LOL
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
We never thought anyone is interested anymore in it... I even doubt the app still works.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] twcobra:
The paid version is still available on the play store. The app runs but of course there is nothing for it to control. I thought it was an issue with getting it to work with Oreo. I used to recompile the SystemUI all the time on 7.1. But on 8.1 I get errors when I try to recompile. I forgot what it was now but when I tracked down the error. I removed the line it was conflicting with and then it would compile. But then I go systemUI crashes. I really have not had much time to dig further into it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
That's the same we experienced... and thought it was not worth a few users using it on Oreo...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] AleAndroid96:
There is anyone that flash the latest version of ROM and no Verity to stay decripted?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
The official builds are unencrypted, so there is no need for noverity.zip....

You cannot disable what is not even enabled, lol...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] AleAndroid96:
Sorry i have misunderstood what is FBE
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
No problem... File Based Encryption... ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gabriwinter:
This may not make sense so apologies if it doesn't.

Could the mokee treble upgrade script be cherry picked into this?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
There has previously been mentions of a GPS fix.

Has this been implemented yet?

I have been having serious GPS issues lately, and GPS signal almost never locks. And when it does, it doesn't last for long.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z0mghii:
It's happening on stock for me too
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yes, we merged a change. It was not a fix, but an update/cleanup.

And it is working fine here (18 seconds on initial start after flashing, 1 second to get 3D fix afterwards)

May I ask which firmware you are using?

Asking, because I know that 5.1.4 is not working well.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NinjaOne:
Thanks.

I'm on 5.1.4 now, but 5.1.3 was the same.

Which are you using? Maybe I should try that instead.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
5.1.3
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Already done weeks ago ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gabriwinter:
Pardon my ignorance,

Should I be able to see the vendor partition? I tried searching under /dev in TWRP for sdf6 but I didn't find anything.

Also I downloaded treble check app and it comes out as not supported.

Probably I'm just missing something really basic here.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
No, it is there but not merged into the ROM.

As I said on some more occasions, we will not more right now the change, as we are on stable and not beta.

If stable gets treble, we will merge.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Is the latest build with august security patch and can i use it encrypted?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
August sec update was merged yesterday by lineage. As next build is scheduled for Monday's... You could answer it yourself, I think. ;)

I have no idea how you encrypted, but we did not change anything on that, means it will not encrypt anything.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Why you are not encrypted the rom at default?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] DeadlyGhost088:
Quick Tiles Color

Is there a way to change the white accent of the Quick Tiles? I would love to change it to some other color but couldn't find an option to do so.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Because I already posted that I wanted to merge the change

A) together with official treble,

B) when we decided, if we provide a way without being force encrypted. The current commit won't let you flash a noverity zip...

---------- Post added at 06:28 PM ---------- Previous post was at 06:27 PM ----------

Not with "on board" theming. You would have to use a substratum theme to do that.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] DeadlyGhost088:
Yeah I thought so. Great ROM tho, would love to see a color changing option for Quick Tiles in the future.

I had one question tho, does this ROM use the stock kernel or it's modified somewhat? Cos I was thinking of flashing a custom kernel.

PS: Substratum Flux Theme, based on Android P, works good with this ROM. I'm really looking forward to future changes in the builds.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, I am using Flux too ;)

The ROM uses a custom kernel. We use Flash kernel from Nathan Chancellor. It is not available as a separate download from him anymore (as he sold his device), but he was so kind and updates it for us (still).

So, it is not LineageOS kernel, but feel free to flash another one.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] DeadlyGhost088:
Haha cool man!

Thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Next build includes the August security update and the updates for 5.1.4 OOS stable firmware.

I'd like to advice everyone to flash the firmware (firmware_5.1.4_oneplus5.zip) from the link in the OP, *before* trying to flash the build.

Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
I installed the lastest build with the 5.1.4 Firmware.

My GPS finally gets a lock again. And as a super bonus this week is my favorite AICP boot animation!

Thanks for all that you folks at AICP do!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Uggg I want to update but on vacation loool so can't do unofficial builds with FBE. I hope to be able to remote access my home PC and test this out :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wizardknight:
Me too. :)

Much faster GPS locks. So much better!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Yay, iam back on aicp.

Flash kernel <3.

All is running smoth and without any issue.

Only magisk-16 and the latest manager give me no response of safetynet check.

I have disabled the magisk hide and reboot but nothing happend.

Ans idea whats going wrong?

And another question can i encrypt the Rom through the android security settings, will the ota update working after this?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
As readable on Twitter and the Magisk thread for the beta:

Google changed the API for questioning safety net checks. TopJohnWu knows it. He needs to change his code for it, so ...

Magisk is working as expected, it just cannot query Google servers, as they reject the old API. That's all.

I still am not a friend of using the encryption right now, as the whole disk will be encrypted, which is an outdated version. Google changed to File_based encryption on Nougat for a reason...

The problem was always the TWRP in case of this encryption type.

As far as I know, one of our users builds with our non-merged the change to encrypt the ROM...but he's on vacation so, that build might take a week to appear.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
I have been using the encryption that's in the security settings. It does encrypt everything and you can take OTA's you just have to unlock TWRP with your pin. So you need to have a pin setup rather than a swipe based unlock.

I've been this way for months. So far no issues.

Edit: Obviously, not discrediting what wartomato says. Just letting you know it works.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
When i enctrypt the whole system with the Android onboard function, then twrp is also affected by this encryption?

Then that is what i want to use.!

But when the encryption method is outdated, how wartomato sad, it is useless.

But i am suprised that i do not notice a performance difference between a decrypt and a encryption file system.

I have used the unofficial resurrection remix for 1 and a ½ month.

And the battery runtime is really good, for an example 2 days and

6-10 hours screen on time.

The Rom is build with the flash kernel too and kam glad to know that the aicp crew decided to provide an official rom with a custom kernel, thats great.

depending on how much processor performance the application currently requires, 10 hours are almost normal, with energy-saving processor performance setting, that i am using when not running any 3d applications.

I have tried a lot of roms for out 8998 beast.

Most of them have a good approach, but it is lacking in fine tuning. I respect the work and time of course anyway.I am a user who does not skip any setting and therefore is harder to please, but that is probably also the fault of the developers.

:D

I say big thanks to the Android Icecold Project Team and specially to [MENTION=6916498]wartomato[/MENTION] as a speaker to the community.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Ah, seems really we should merge the file-based encryption... :/

But please, most of us are on holidays (like myself), so I will see if we merge it afterwards, as a format of the user partition would be needed. That's a bit difficult for me at the moment, haha

And yeah, the encryption does not have that much of an impact on performance on our device. It is just fast enough...

Oh, and thanks for the feedback of course, as we depend on it. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] willybarca:
Can you add eas rom side support so we can use it with eas kernels
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
No from my side. Looking at e.g. the essential ph-1 there are no real benefits for doing it.

But feel free to try DU, as they use it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] adefigo:
It seems there is no wireguard support at the moment. The wireguard app uses the userspace go backend.

EDIT: Sorry, forgot to root - everything is working fine. :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] abo0ood:
Flash latest build no sound in my headset any solutions?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] d1n0x:
Use 5.1.4 firmware
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
The 5.1.3 has a cool bootscreen in that i choose with volume keys the options to Start, fastboot or recovery.

In the 5.1.4 Firmware i cant do nothing.

Is there anyway to change that?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z0mghii:
https://xdaforums.com/oneplus-5/themes/mod-bootloader-changer-t3800862
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Anybody can help with magisk-16?

Gives no response with safetynet check.

Can not play fortnite.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post77329420

This should be known by now... ;)

So, here as a reference...

Again. TopJohnWu has moved to the USA for studying and said he will update Magisk, when he has settled there...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Oh, forgot latest post from him...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] MrCrc:
Hello,

I haven't audio on wired headphones too (AICP 18/08/13, firmware 5.1.4)...

Regards

Cr c

Gesendet von meinem ONEPLUS A5000 mit Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Well, although I have audio on wired and wireless headphones or headsets, tomorrow is "Update-day" and lineage merged some fixes for this issue (again).

If you still have issues after that update...there is something else going on.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] MrCrc:
Correction - I haven't headphone-audio on google play music (youtube and TuneIn radio works). Tested on firmware 5.1.2 - 5.1.4, headphone is Revonext QT2.

Crc

Gesendet von meinem ONEPLUS A5000 mit Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] MrCrc:
Hello,

headphone works now on weekly 18/08/20. Thanks goes out to Daniel...

regards

Crc

Gesendet von meinem ONEPLUS A5000 mit Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Yes, for fixing his mismerge, lol...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
[MENTION=2511007]csolanol[/MENTION] could you please try to add your different commits in topics? It would be easier for me to test them out, mostly in particular the treble support and updated blobs :)

Also, FYI, I'll add the WSL commits from LineageOS once I get home, they got merged and are working fine on my side :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Will do eventually, still on vacation mode :angel:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
WSL commits were merged by us on July 29th afaik...

The commits might get merged ALL on Sunday including FBE.

...you could just wait, I guess ;)

It is all working, just LineageOS has two commits open to make snap camera app work.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Haha no problem, I fully understand, same here ;)

Ah ok then I'll surely wait for it to be merged, and nice for FBE, already using it fine. For WSL, I'll take a look then and test it out :) might be some commits that's I didn't see passing, thanks a bunch! :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pipodi93:
I'm currently having an issue with GPS. I've never used Maps or other navigation apps since I've installed this ROM (a week or so), so I don't know if I was having this issue before. But today I've used Maps and the GPS won't lock.

I've attached a screenshot from GPS Status. As you can see, the signal was good, but no satellite was locked by the GPS. I've waited a minute outside, but no results.

I've updated the ROM this morning to the latest build.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
On a new install AGPS data is loaded in first usage. This might take up to a minute (most of the time less) and should lock then...

These are the original GPS settings from LineageOS at the moment, as I have been away and wanted to look into that this weekend...(and next build is scheduled for Monday)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Okay, little update...

1. Treble (Firmware 5.1.5) not yet merged. It works fine so far, but Snap camera fails due to some vendor copy-out change that we look into at the moment. (This is a Los issue, so we hope to hint them to the solution)

2. FBE not merged. We will do this together with the Treble change, as it requires a format of the data partition and a new setup.

...and I need a bit more time to write down the procedure and test a few more things out.

3. I haven't got time to look into GPS.conf changes, as holidays ended and I am working again. I try to look into it and change a bit the settings...

Sorry, if this caused some inconviences for now. :/
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gabriwinter:
Will these new merges (Treble, FBE) require a clean flash?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NaterTots:
Point 2 in the post above says that it'll require a clean flash. A format of all user data.

I'm very much looking forward to this. ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
The need of full wipe is due to fbe commit, not treble stuff.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Saw that you added topics, thanks :) However can't seem to get past the vendor partition to fstab commit, seems like there is a conflict, I think it may come from FBE (FBE may need to be merged before this commit). Am I wrong somewhere?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Yup, pick fbe patch first.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah thanks, just tested it out before, should have waited before posting LOL... Gonna clean build and test this s**** out
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It works okay, only issues so far are

A. No working Snap camera.

B. No wifi with the latest two or three commute from yesterday...

Damn lineage, hihi
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah don't care bout snap, however no wifi is a bit worse than expected ^^ I'll make a full build and see how it goes. However, takes a lot more time today on my home PC, should only take 2 hours or so with a clean build...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
When flashing the new treble stuff, nothing else to do other than 5.1.5 firmware + gapps? For the dm-verity, which version? v2 or V3 treble?

EDIT/// Forgot to update TWRP... Gonna test this out using blu-spark TWRP --> Still going back to fastboot, may need to flash FBE disabler, what do you guys think? Btw I wanna stay decrypted lool. Tried with no-verity v2 and v3, nothing helps and not sure if FBE disabler is really necessary.

Can't go further without any help :S
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Flashing treble just needs the firmware. I updated without flashing happy, it restored over wifi from the sync with Google services. Even some settings sticked.

For dm-verity, v3 is for treble.

I used no Magisk on first boot and TWRP from codeworkx. The latest one.

And we'll, if you want to stay unencrypted...did you disable Lockscreen Security? And please use the uninstaller of Magisk before doing anything. Then wipe the phone (without formatting data, ofc).

Building without the the change and changing the recovery fstab and the fstab in init should solve this. No dm-verity needed.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah I'm doing a clean flash in order to start fully fresh. So magisk and lockscreen stuff not needed. I'll try the TWRP from codeworkxx to see if it works better --> Tested and still doesn't work.

For the dm-verity, I'm gonna stay as is while using dm-verity stuff.

In anycase, what I'm doing is clean flash (data wipe), flash firmware + build + opengapps + firmware + no-verity v3. But doesn't boot, goes to fastboot.

EDIT/// Strange, even without dm-verity, it doesn't boot... Very strange indeed...

EDIT2/// Ok didn't make a full build, it didn't merge the commits after selinux fixes for ifaa... Gonn make a new build, don't understand what happenned since I repopicked all the topic...

EDIT3/// Ok so it is the dumpling commit that is breaking everything, it doesn't know where to put it ^^'
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Concerning the ant radio hidl commit, is there something else to add in the dependicies? I can't seem to build since libantradio is missing (http://gerrit.aicp-rom.com/c/AICP/device_oneplus_msm8998-common/+/72536). For info, i'm cherry-picking after repo sync. Not sure if I need to repo sync again afterwards since i'm using the command repo sync -f -c --force-sync --no-tags --no-clone-bundle -j$( nproc --all )
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] csolanol:
Vendor patch needed. Not pushed to Muppets yet.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Ah crap, is the commit already somewhere that I can repopick? Is this commit fully needed for treble? Other way would be for you to share with me the build with FBE and treble until it is fully testable.

I made a build without that commit and with the new config commit but still can't manage to make it boot using dm-verity, I'll try without later.

I can't seem to see why I can't make this work, first time I'm getting this type of boot issues.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Ant radio is not ready for testing, as it needs vendor changes from theMuppets. These are not merged, so you cannot build with that.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yeah saw the feedback from cslan ;) I'm gonna make a new build with clobber with all the commits except that one and see if I can manage to make it boot. In the meantime, flashing an old FBE build withotu Treble, really need my phone now ^^

Jujst to be sure, in order to update, only need to flash the ROM with the new firmware, right? With latest TWRP of course.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] fa_alatibi:
Why it's give me

(updater process ended with error 7)

Every time I try to install it
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] enskje:
because something is not that way it should be
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Tried to dirty flash the treble build with FBE, doesn't boot, goes to fastboot. How did you update on your side?

---------- Post added at 08:41 PM ---------- Previous post was at 08:41 PM ----------

What build are you flashing? Do you have the correct firmware? Are you flashing FBE build?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] fa_alatibi:
i was in NoLimits 12 rom

And i try to flashing (aicp_cheeseburger_o-13.1-WEEKLY-20180827.zip)

and i don't even know what is FBE build !
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
FBE is file based encryption, it's the way you encrypt the device. It's that type for Google and One plus

However it is still not included. It will be when it gets merged, it's not the case today.

Did you try to format data? What is your flashing process?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] fa_alatibi:
look
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Hmmm. I'll try to add a little bit of sarcasm, but try to read a little bit b-e-f-o-r-e the error. The issue is LITERALLY written there!...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
It clearly states that you are not on firmware 5.1.4 stable and thus refuses to flash over your current system.

If you want to, you need to flash the stable firmware. The Link to it is in the first post under "How to Flash"...

5.1.4 is the latest non-Treble firmware from OnePlus.

(but I would wait a few days for the next build...)

---------- Post added at 09:56 ---------- Previous post was at 09:52 ----------

Please wait a bit... we merged ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] matssa:
Yay thanks for the nice guide, I'll make a new home build and in // download the new build so that I'm sure it works fine :) Thanks again for your hard work!!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] wartomato:
Oh...we included the Ant+ commit now too, as lineage merged it.

And yes, it is working... :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Maria_gr:
It literally says that you have to flash 5.1.4 firmware first.

Have you done that?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zelect0r:
Is there a fix for the headphonebug with the latest Firmware 5.1.5?

As workaround switch mono sound on/off.

But i need a proper fix.

Thx