yashsingh1/xdaforums huggingface dataset:
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] adamsson6:
Finally switched to LineageOS 15.1

I flashed it before ! Even if it was theorically not necessary because I was running the last build of the previous maintainer of this rom si I already was running naugat.

Anyway, it's no more necessary. I didn't successfully installed this rom but I switched to android 8.1 oreo from here : https://xdaforums.com/moto-g5s/development/rom-lineageos-15-1-t3901872

It's maintained by [MENTION=9506129]JarlPenguin[/MENTION] and it's working for me (after flashing stock oreo firmware first from here : https://xdaforums.com/moto-g5s/development/rom-android-8-1-0-oreo-stock-firmware-t3845501 ).

A big thank to [MENTION=9506129]JarlPenguin[/MENTION] for his work because I really prefere un-googlized lineageOS clean rom over stock motorola firmware (which is almost clean but googlized). A big thank to all official and unofficial lineageOS developers.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] dau999:
build does not boot

Beeing on Nougat Firmware, your build does not boot... Could it be a 2/4GB Variant problem?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] XT1799:
Not working on xt1799 Green Pomelo

Even though I've downloaded the latest build (https://github.com/montanadevelopmen...ana-signed.zip ) and flashed it with different versions of twrp(3.1.1, 3.2.0, 3.2.3, 3.3.1) it still fails to boot and displays:(Error:failed to load keenel). I have also tested other Nougat-based from,but none of them could be booted. I can install Pie-based Roms, but I can't install nougat-based Roms.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] JarlPenguin:
Now that you've told me the error, I'll try to fix it.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] JarlPenguin:
Last build from me:

https://github.com/JarlPenguin/rele.../lineage-14.1-20190922-UNOFFICIAL-montana.zip

Includes September security patches.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] badro6:
Not booting

Hi i'm trying to boot this rom after flashing stock image here https://xdaforums.com/moto-g5s/development/rom-stock-montana-moto-g5s-7-1-1-lite-t3725293 (which boot)

But your rom isn't booting. It stuck on motorola logo and don't show lineage OS booting logo.

Any idea ? Thank you very much.

---------- Post added at 12:36 PM ---------- Previous post was at 11:38 AM ----------

I tested the last build of the previous maintainer of this rom, it's booting. But this one is not booting.

So I think the problem is coming from the rom... I cannot tell you what is the problem because I just have the logo and no other information..
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] badro6:
Rom abandoned ?

It looks like this rom is abandoned ?

I switched to Lineage OS 16. It's very cool but the battery life is really better with Lineage OS 14.1.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] adamsson6:
No more maintainer ?

Hi, is there any maintainer to update this rom ? At least to update security patch ?

I know there are lineage os 15 and 16 but the battery life is very better with this ROM.

If someone can show me how to build the rom I could continue to maintain it but I need a little formation on building custom ROM.

Thank you.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] newinnov:
That's the sad thing for this device mate. There is not a single stable ROM exists for this device.

Lineage Oreo is somewhat updated and closest to stable but new mtp and USB related patch has not been merged to that.

Pie is like having a niosy kid set beside you. And developers are non existant.

That Chinese lenovo abandoned this good device too soon.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Rush:
Are you ****ing kidding me? 4.9 kernel development is qualified as "no development"? Also, JarlPenguin currently doesnt have a proper Server, and Motorola only updated to Android Oreo, so obviously its the most stable...Android p is also mainly using oreo blobs, and if you can do it better, than go ahead
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] wiktorek140:
MTP things was merged in Oreo build long before in Pie, so last build support it for sure.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Dan Mornill:
There is not as much dev as for G5s Plus for sure, but Lineage Pie is a stable rom, and I've been using it as my daily device for almost a year now...
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] newinnov:
Your anger is pointed towards wrong direction mate, also you are defending a sand castle. You just rewrote, what I had written. You are talking about someday while I'm writing about today. Also I did not use the word ""no development". Better spend that hyper energy in something that's visible rather than being a keyboard warrior.

FYI, Criticism or Facts are not called: "****ing kidding"

In, Last Oreo build file copy via MTP does not work on both Linux and Windows. Copying only work in recovery. Those changes just fixed the detection of mass storage on windows.

I did not mean to discredit your amazing work on this device, I just talked about reality of not having enough developers on this project. There is a limit to one man effort. Perhaps right now you are the only one with enough understanding who is working on this device.

Last build with EVA kernel has random freeze followed by reboot.

Finally current status:

Lineage 14.1 : Stable (Lacks security updates)

Lineage 15.1 : Almost stable (Lacks security patch)

Lineage 16.0 : Regularly update, SELinux permissive + Currently built by: wiktorek140
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Rush:
There is a new build on telegram, idk how stable that is tho

T.me/montanalabtesters

Just track back a little
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Dan Mornill:
Last build doesn't include EVA kernel, and I do not experience problems with the 12 april EVA kernel build.

Which model are you using ?

Do you use G5s or are you just rephrasing what you read elsewhere ?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Rush:
He is probably using an older build as this has been fixed already

:|
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] GivFNZ:
Is there any way to fix IMEI and baseband version in this rom without downgrading to Nougat Firmware?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] someone_bla_bla:
Hi every one, im facing some problems to compile the kernel, like toolchain problems and environment problems. Would you guys send me a dockerfile with all the configuration ? Because I've tried everything that I can, but it seems not to work. I just wanna change some kernel configs and flesh it to my device.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
It is not a 3rd party. It is CMActions (alias MotoActions) code base imported from potter.

NFC - I haven't enabled it because my device doesn't support. Even in stock ROM, I couldn't find NFC option in Settings. I could enable NFC and make a build again. But if it is not working, someone who has device support for NFC would require to debug.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] catalin habdul:
Thanks again for your work, everything it's working great. I think finally we have a stable custom room for this device.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] GoldeneyeS2:
My device have NFC. Can you make that build? I will be thankful.

I can also try to debug if its not working.

Thanks.

I already see a NFC icon in the quick settings.(screenshot).

In the logfile:

1-11 15:40:14.658 1734 2247 E NFC : could not retrieve NFC service
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] GoldeneyeS2:
A fast response.

I think this is the problem.

https://github.com/kayesk/android_d...mmit/36c685e0571500d4f8c0df84c0e37d03b8a0098a

-lib/libnfc_nci_jni.so
-lib/libnfc-nci.so
-lib/libnfc_ndef.so

Tomorrow more time for this;)
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Looks like a kernel config issue. The call trace shows a I2C write. Let me try to tweak in kernel config tomorrow.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] GoldeneyeS2:
I see the following code:

https://github.com/kayesk/android_d...103c7a5be523d918cec91600d03040/BoardConfig.mk

# NFC
#BOARD_HAVE_NFC := true
#BOARD_NFC_CHIPSET := pn544

Is this OK:confused:
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] deejoy li:
My g5s is model XT-1799-2 for China, I flashed this ROM but Boot failed, tips: fastboot can't Boot in normal mode, can anyone help me ? Tks
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
That's fine. It is the boardconfig settings for a build with NO NFC. The build I posted for you in onedrive has these flags enabled. I haven't committed them to github.

FYI, I would not be available for next couple of days. I will take a look when I am back on Monday.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] tabletmen:
Maybe you and [MENTION=436307]squid[/MENTION] can work together on this build ?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] hillj284:
Do the fingerprint Moto Actions work in the latest build? I saw lots of people talking about Moto Actions on the thread but can't find an option for fingerprint gestures in the latest build
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] motafoca!:
I thought the same... There's no fingerprint gestures yet, even on 3rd apps...

But the rom are amazing! Im testing for a few hours.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] maciek_by:
Build.prop need cleaning. Theres a lot or duplicated entries.

ro.emmc_size 16GB?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Agreed. Lot of clean up required. Build.prop file is from stock.

G5s uses sensor.montana library and reference to that is present in stock build prop. When I started working on this project, I didn't know what other device specific entries are there in build prop. So I took the stock one. It requires lot of clean up. There are some unused property like the one you mentioned.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
New build is up. File name : lineage-14.1-20180114-UNOFFICIAL-montana.zip

Fixes:

MotoActions - with FPS gestures. Please check it out and let me know if you find any issues. This required kernel support. Took good amount of time to fix.

The kernel changes and device tree changes are not yet committed to github. I would do that tomorrow morning my time.

With that I believe except NFC, we are all set.

I cannot work on fixing NFC because my device (XT1795 India) doesn't have support. Without device support, I cannot test my build. I would update OP as non-NFC device only.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] catalin habdul:
Can we dirty flash over the previous build? Now that we have an stable nougat rom can we expect an Oreo room or for now it's hard to make 8.0 rom ? Thanks for your work for this device
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
I haven't tried dirty flashing. You can give it a try. But I would prefer a clean flash.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] igna.98:
Is it possible to add OMS support?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Cube8:
Just tried dirty flash over 20180111. Reflashed GApps and Magisk 15.3 also before rebooting and everything is perfect! :)

Btw, double-tap to wake doesn't work. It didn't work on the previous version, either.

Also, NFC doesn't work for XT1794.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Membrillo007:
Hi. i´ve got the XT1790 Moto G5S.

Will this rom be compatible with my device? also, video recording isn´t fixed yet right?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] deejoy li:
pls help to support xt1799
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Should work fine. Take a twrp backup in any case. Video recording works. Please let me know if otherwise.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
I would like to. But looks like xt1799 is a scaled down version. When I checked the specification, it has dual core processor instead of Octo core. I am not sure what else is different. If device specifications are different, it would be difficult to support.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] deejoy li:
my phone is called Moto 青柚，the model full name is xt1799-2, the processor snapdragon 430, it has octo core. And has NFC feature, the front camera is 1600Mp , it is different from Moto g5s.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] igna.98:
I tested and it works perfectly on XT1790 bought in Chile.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Please tell me the issues you face installing the ROM. I believe you already unlocked bootloader and installed TWRP. These are primary requirements. Take a TWRP backup of existing rom. Do all wipes and install lineage ROM. Steps are detailed in op. If you could attach logcat and/or dmesg output, it would be helpful.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] deejoy li:
Flashed this ROM then reboot device, display tips：fastboot can't boot in normal mode.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Looks like recovery is not coming out of fastboot mode. I don't this has something to do with ROM.

I request other developers in this forum to give their input. That would give me some clarity.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Couple of options I would suggest. There are ROMs by other developers like crDroid and AOSCP. You could give them a try. Also I use TWRP v 3.1.1-r3. I dont know what version you are using. I am also not sure if the TWRP version makes any difference. But it is worth a try. When we reboot from TWRP, it should automatically come out of recovery/fastboot mode and get into normal mode. If it is not happening, then there is something to do with recovery. That is my understanding.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Cube8:
I think we have an issue with audio volume (both speaker and in-call). It is a bit too loud, even in the lowest setting. It's like there is a sound booster.

I don't know if this happens on stock android, because I flashed LOS as soon as I bought it.

I had Nexus 5 with the same LOS version and the audio volume was "normal".

AudioFX is disabled.

Is there a way to adjust the volumes from inside the OS, besides the usual sliders?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] FAFAŁ:
I also have these symptoms. It's too loud to crack the phone. If you are talking to someone. Music sounds good and AudioFX is turned off.

model xt 1794
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] tabletmen:
[MENTION=1829889]vache[/MENTION], [MENTION=4480917]Alberto97[/MENTION], [MENTION=8124653]Faiyaz,[/MENTION] [MENTION=436307]squid[/MENTION] [MENTION=4493088]Shreps[/MENTION] maybe one of you can help?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Cube8:
I managed to fix the high speaker volume! :laugh:

I extracted libaudiopolicymanager.so and libaudiopolicymanagerdefault.so from stock /system/lib and copied them to current /system/lib (replacing the existing ones).

I made an update zip for easy fix until kalyansundhar releases an update.

Now I need to find which lib is for in-call audio.

Disclaimer: As usual, I assume no responsibility for any potential problem that might be caused by misusing the attached zip file. Use it at your own risk. It is recommended to keep a backup of the aforementioned files (or the whole system) before applying the fix.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] UryuuChangAmanno:
Link download fix?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Cube8:
Done! See post above.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
That is really great. Making something possible cannot be an individual effort. Only with team effort, it is possible. Thanks a ton.

Honestly I didn't realize the problem with audio, as I have some hearing inability. Louder noise is normal for me :).

Having said the reality, the audio policy libraries are from CM14.1 code base. I am not sure about replacing those because they are not vendor libraries. Also it may have some side effect with future CM/Lineage updates. Please correct me if I am wrong. But I noticed couple of things. The vendor blobs were missing couple of soundfx files 'libqcomvisualizer.so' and 'libqcomvoiceprocessing.so'. I added those to build.

Additionally audio_effects.conf file was always getting replaced by framework version. That is, I have audio_effects.conf pulled from stock. And device.mk has an entry for this file. But build process always ignores this entry and takes the file from 'frameworks/av/media/libeffects/data/audio_effects.conf'. I modified device specific makefiles to resolve this problem.

With these changes, I am making a build now. Once done I would upload and let you all know.

As usual I am making 2 builds. One with NFC and one without NFC. If you have NFC supported device, please use NFC build (and let me know if it works).

BTW, Do we have doubletap2wake in stock ROM? Can someone verify that? Because I made kernel updates to support double tap to wake. But still not working.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
New build up. Location same as in OP.

File name: lineage-14.1-20180117-UNOFFICIAL-montana.zip

Please find non-NFC build in root folder of shared location.

And NFC build in nfc_builds sub-folder.

Changes made:

1) Included qcomvoiceprocessing related libraries.

2) audio_effects.conf is from stock.

3) NFC chip type corrected in board config make file.

Things to verify:

1) Audio quality.

2) AudioFX

3) NFC (if device supports)

Regards,

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] ShattrdChain:
No doubletap2wake in stock rom.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Thank you. In that case, we can leave it as such. That's my take.

Display will wake up (1) when there is notification (2) when we lift the phone. Moreover we can configure fingerprint gesture double tap for screen on/off toggle. Given these options do we really need to struggle for DT2W. Is it worth the effort? Please let me know your thoughts.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] GoldeneyeS2:
Many thanks.:good:

It looks like NFC works. Tonight i will test it with a pin transaction.

Does it matter when someone without nfc installs the nfc build?

Can i have your local_manifest.xml (build environment)?

I want to build with your source code and maybe try to add daily updates to lineage updater!!

I have a little server at home.

Install linux with jenkins and automatically build every day a update. :laugh:
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] maciek_by:
Can we use well established codebase from cedric aka g5?

https://github.com/Wzedlare/android_device_motorola_cedric
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Yes. NFC build can be installed in a device without NFC chip. But If we look at the logcat, the NFC process tries to do an I2C write repeatedly. And this happens in an endless loop. Because of the resource usage, we might see a performance lag in device.

Yes. of course. Local manifest is already there in github. https://github.com/kayesk/local_manifests.git

I have committed all recent changes to device tree and kernel to github.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Current code base that I have for G5S is evolved from Wzedlare G5 only. For me it took a lot of time (couple of months together) to understand and start working on it. For a person with reasonable linux device development experience, it should be a piece of cake.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] Cube8:
My device supports NFC but I installed the one without.

I will check the new build (with NFC) later and see if the audio issues perist.

There are some files (including those 2) that can be replaced from stock without harm.

I have done some MTK ROM porting in the past and have learned a few things about which libs can be used from stock. Of course, I keep a copy before replacing. ;)

Btw, how can we make this an official release?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Seriously I don't know. Someone can guide in that regard. Before that I need to clean up vendor tree. It has lot of unused files. The files listed in proprietary-files.txt is final. I would remove other files.

Right now what I can do is (for the least) is remove BETA tag from title of this thread, if you all say NFC works :).

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
I noticed an approach in https://github.com/LineageOS/android_device_motorola_addison.git. There is a logic in releasetools.py to replace NFC conf file based on region. My thought is what if we have something like that to add NFC related files based on some device property. If it is possible then it would become a unified build. If device supports NFC, then related files should be copied, else it should not. All we need is to add/remove 2 APKs. NfcNci.apk and NfcSetup.apk. I don't know how to achieve this and what device property we could rely on.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] ShattrdChain:
I guess it's time. It's pretty stable and ready to leave beta.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] GoldeneyeS2:
I do not see all your committeds on github. Only from six days ago.

The local manifest doesn't have the device, kernel and vendor tree in it?

How much time does the build take?

It is possible, but when is this script running? after building or when you flash the rom on your phone?

Did you find a way of editing the lineage updater?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
It is my mistake. I committed locally; but forgot to push it to remote. I did that just now.

Local manifest only has external dependencies. I haven't included device, vendor and kernel. It is a good idea to keep them part of local manifest. I will do that now.

Clean build takes somewhere around 4+ hours depending on CPU, RAM, Disk read/write speed and CCACHE size.

I have my fedora linux in 1TB external USB drive. CPU is Intel i5 and RAM I have is 16G. I am using a CCACHE size of 80G.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Pushed changes to github. Also added device, vendor and kernel tree paths to local manifest.

Thanks

KS
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] GoldeneyeS2:
Or do we go straight to lineage 15.1? This lineage 14.1 is stable and usable.

Did you already try to build lineage 15.1? Just give it a try?

Did they changed a lot on Cedric to get it running? ARM64 is not the case, I mention only arm. Or do we wait official stock ROM?
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
I am not sure if someone else is already working on LOS15. If so then it would be a dual work and waste of time. Main changes would be HAL compatibility. Sometime back when I went through the code base of cedric, addison and potter, I could see HAL wrappers for camera, lights, fingerprint and so on. Also file config is dealt in a different way.

But your are right. If OREO stock update comes, then that would be the EOD for this project (14.1). Going official is lengthy process it seems. I just went through lineage wiki.

If we can add OMS support, then it would be more useful, I believe.
[Moto G5S  ROMs, Kernels, Recoveries, & Other Devel] kalyansundhar:
Adding OMS support seems to be straight forward from substratum documentation. But I haven't seen many LOS builds with OMS support. There are many custom ROMS like AEX, RR, Viper etc with OMS for many devices. But not many LOS with OMS. Not sure why? May be there could be some architectural incompatibilities. Or it is quite possible that official LOS doesn't support OMS.

Thanks

KS