yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
1. Upgrade your OP 5t to Oreo open beta 2 (which is awesome btw)

2. Unlock the bootloader using ADB and a PC.

3. Download and install TWRP recovery using ADB and PC.

4. Download and install Magisk Root v15.x. using your newly installed recovery.

5. When your phone is back up and you've got root, download and install a root file manager.

6. Download the latest Camera M magisk module and unzip just the camera APK and copy it to your phones sdcard.

7. Force close the Camera app and clear all data in settings/apps

8. Delete the camera apk in /System/priv-app/OnePlusCamera using your root file manager

9. Reboot and check the app has gone from your phone, check launcher and settings/apps

10. Install camera M apk on sdcard (by default it will now be a user app instead of a privileged system app)

11. One more reboot, you can clear system caches in TWRP if you so feel inclined.

12. Run camera app.

You know all is good if....

1. Camera is reported as version .21

2. Panorama works

3. A BIG improvement in picture quality.

Notes:

The modded camera app is a little buggy on the 5t and it will force close sometimes if you launch the camera from the lock screen or launcher, its seems pretty random and can be stable for long periods.

Always assume HDR is OFF in HDR auto mode (default when you first start the app).

You will see a noticeable increase in color noise (Chrominance noise) in lower light situations. This is normal as the dev. has made the compromise that some extra noise is a far better trade off to the OnePlus denoise filter which makes the images look terrible (watercolor like smudging) when you zoom in.

I would argue that reducing the effect of the denoise filter on images might in the long run produce a better result rather than turning it off altogether. But thats on the assumption it can be reduced. It may well be a one off, fire and forget bit of code which has little or no parameters available for manoeuvre.

As a final note, as i have root i've also installed...

YouTube adaway

Adaway

Google Contacts and Phone (with framework). I can confirm play store updates don't seem to break this.

Rootless Pixel XL2 launcher and Wallpapers app which works flawlessly.

Now if only I could make my quick settings look the same as a Pixel XL2!? :)
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Thanks for your review. I still try to tune in to get the best balance between noise/details/realness of the picture. The goal of the mod is to get the best quality in good light. Low light is impossible to get no noise and details. As someone shows few posts back, details are more kept with original Oneplus process than mine. I will add a switch in parameters for people decide what they prefer in low-light mode (low-light = ISO between 1600 and 3000) :

- Picture more natural, a bit of noise, less detail

- Picture more watercolored, no or less noise, better detail

FYI, Oneplus denoise is used upper ISO 3000, because without it, pictures are really bad.
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
Awesome you've done a gr8 job so far keep it up! Do you want some coding and testing help on a 5t? I'm primarily a C# dev, but I also know a little C++ and Java.
[OnePlus 5 Themes, Apps, and Mods] tcat007:
Development of compatibility with custom ROMs on 5t would be awesome. Some gcam mods work, but a good oos camera would be nice.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Thanks for your help ! I don't think I need help at this moment because it's quite more "taking pictures and evaluate them" now. So don't hesitate to do what you have tell before (about comparing with original application) and tell what do you prefer before and after, this would be a huge help because I rely only on my opinion for tune-in. If you post samples, post original pictures in https://imgbb.com so that I have access to EXIF infos (ISO, Shutter speed) of the picture.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
New update :

- Remove chroma noise and increase sharpness in bright light

- Overall tune-in depends on the current light situation

Magisk module

If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app. To remove the update, go to App Info of Oneplus Camera and disable it. A prompt will ask you if you want to revert back to the factory version. Press yes. Re-enable after that.

Concerning people with non-OOS ROM, you have to understand it that Oneplus have included some proprietaries things who post-process picture in Camera 1 API. Oneplus Camera relies on it. I don't think custom ROM included it. I can't do nothing about it because it's concerning the ROM itself and not the app.

If you are not satisfied with the current result of the mod, please post the ORIGINAL picture in https://imgbb.com and explain what you think it should be better.
[OnePlus 5 Themes, Apps, and Mods] :
Thanks for your work. Hearing great reviews from fellow users. But can you make it work without rooting? Maybe as a third-party app or something? The entire user community will be benefitted if you can also port this to non-rooted devices aswell
[OnePlus 5 Themes, Apps, and Mods] saccentekennedy:
For those of us with a 5t using the non-Magisk installation method... do we also have to install the OnePlusCameraService.apk from the Magisk zip, or just the camera apk?

By the way, dev... thank you so much for all your hard work!
[OnePlus 5 Themes, Apps, and Mods] TxxxxxKxxxxxxxx:
Does this mod also work if I have installed a custom room that does not support the official camera app?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
No, it's not possible. The original Oneplus Camera have special permissions who is needed to get the Oneplus post-process. It's not possible to have 2 differents app with the same special permissions. That's why I need to overwrite the original Oneplus camera, who is a system app. And for this, root is needed.
[OnePlus 5 Themes, Apps, and Mods] :
My bad then. Hope OnePlus could implement this in their future updates. Thanks a lot for you work on this
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
I have a couple of questions :) ...

Why did you decide to remove chroma noise in bright light? By definition, if the scene has a strong light source (day or night, inside or out) would chroma noise not be at it's very lowest? By applying a de-noiser there's the risk of re-introducing smushy images. Or have I misunderstood and you mean NO denoise filter is applied in bright light? Can you be more clear in the description?

Can you expand on what you mean by "Overall tune-in depends on the current light situation"?
[OnePlus 5 Themes, Apps, and Mods] Horwi:
Alright then, so is there any chance to install this mod without rooted phone?

I cannot root my phone, my bank apps will not work longer anymore.
[OnePlus 5 Themes, Apps, and Mods] genevois26:
I have the version of 22 January. Do I need to uninstall this version or I can update the version 24/01/2018 over the old? Thanks dev!
[OnePlus 5 Themes, Apps, and Mods] wasjapupkin:
Read the thread. DEV already tried it, but it didn't worked
[OnePlus 5 Themes, Apps, and Mods] quini2k:
Spanish caixabank's apps work fine after being hidden by Magisk (caixabank & caixabank pay). You could give it a try ;)

Enviat des del meu ONEPLUS A5000 usant Tapatalk
[OnePlus 5 Themes, Apps, and Mods] obol2:
No, Root is needed (magisk)

---------- Post added at 05:20 PM ---------- Previous post was at 05:19 PM ----------

You can update over the old
[OnePlus 5 Themes, Apps, and Mods] quini2k:
Hi! I'm giving the mod a try since 22nd January Magisk version. I'm not sure it has been applied, because it's showing version 2.5.2 instead of .21... Am I wrong?

Also, I haven't had a single FC.

Running stock 5.0.1 OOS plus Magisk 15.3

Thanks!

Joan Tur (Quini)
[OnePlus 5 Themes, Apps, and Mods] txx1219:
I don't know why but in scenes where it was extremely bright light, chroma noise appears more often than expected.

Oneplus camera used 2 noise reduction process. When you shoot a picture, the first one is directly applied. It's the noise reduction process I have disabled. After that, they process the picture to correct some minor things. What I have done is to trick this second process to apply more chroma noise reduction in extremely bright light. I have increased sharpness too in this situation thanks to that.

Concerning the overall tune-in, I increase/decrease sharpness depends on light situation, based on my tests.
[OnePlus 5 Themes, Apps, and Mods] Meepowski:
Do you plan on modding the 2.5.22 app version? Thanks!
[OnePlus 5 Themes, Apps, and Mods] minaz_in:
I m unable to delete the camera app through fx root what could be the problem ?
[OnePlus 5 Themes, Apps, and Mods] tcat007:
Just want to confirm this works on 5t with custom ROM (DU). Just flash it. Slow motion works much better than on gcam mod (1.4). No portrait. Haven't spent any time comparing pix, but looks good.
[OnePlus 5 Themes, Apps, and Mods] tcat007:
Just a quick shot, top this M mod, bottom gcam 1.4, both hdr. So I only issue this mod for slow mo.
[OnePlus 5 Themes, Apps, and Mods] Can。F:
The HDR+ is very good！But the Gcam can't work on 8.0，how to use it.

I think the camera mod is good than before .But also has the very big progress on algorithm and brightness space, I hope the author to HDR+ this direction development.That it very good.
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
Try root browser classic. Worked for me. Make sure you force close the app and clear data and caches too

---------- Post added at 09:24 PM ---------- Previous post was at 09:18 PM ----------

I've just been trying some outdoor shots under Street lighting at night this forces the camera to use the second lens and sensor. What do you apply in this scenario? It does look like a denoise filter is being applied in hdr off. In fact I don't think the images look all that different than on the original camera software. I totally accept that in such low light conditions you cannot expect miracles though and it still does a fair job.
[OnePlus 5 Themes, Apps, and Mods] jakobWango:
Literally read some posts before you.... What is wrong with people

Use the search function or at least your freaking eyes. 0_o
[OnePlus 5 Themes, Apps, and Mods] sohansonu:
+1.

I'm on 2.5.22, will it work if I just flash the module?
[OnePlus 5 Themes, Apps, and Mods] brmbjn:
Not work on 2.5.22. force close
[OnePlus 5 Themes, Apps, and Mods] qasimtb:
Will this work with oneplus3
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Where did you get this version? I took a look at apkmirror but theres nothing there

---------- Post added at 07:46 AM ---------- Previous post was at 07:46 AM ----------

Where did you get this version? I took a look at apkmirror but theres nothing there
[OnePlus 5 Themes, Apps, and Mods] jakobWango:
after you have installed the module and rebooted, uninstall updates for the camera. I think the new version will kick in then
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
After reviewing my night shots, I agree with what you say about denoise post 3000 iso. But I've taken the same shots in HQ mode and despite the noise I quite like the results.

I think adding options in the settings to choose when denoise kicks in. Would be great.

Can you confirm whether you have the ability to set the amount of denoise ? Are the soft to hard levels that can be applied?
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
Apologies on my phone i'm logged in as drummerboy99 and PC its 46! lol
[OnePlus 5 Themes, Apps, and Mods] jomaga:
Working here 2.5.22 without issues

My installation process:

-wipe camera data and caché

-flash from twrp

Btw, 2.5.22 camera is from Oos open beta 2 on my 5t
[OnePlus 5 Themes, Apps, and Mods] BFMSAND:
Not only from Open Beta 2 on 5t also Open Beta 4 on 5 uses the same new 2.5.22 camera, just to Keep that in mind to not confuse anyone ( would be good if everyone who has an issue Posts which phone, build and camera Version he uses )
[OnePlus 5 Themes, Apps, and Mods] brmbjn:
Watermark ? Panorama ?
[OnePlus 5 Themes, Apps, and Mods] jomaga:
I mean without issues in main app opening, photo, video etc

Panorama and watermark are known issues and wont' work
[OnePlus 5 Themes, Apps, and Mods] ShiShTuBaBu:
which gcam version are you using?
[OnePlus 5 Themes, Apps, and Mods] Mackie Messer:
Same here with OOS 4.7.6. Deleted Camera Date + Cache, installed Magisk Module, Restart. Still Camera 2.5.2. What's missing?
[OnePlus 5 Themes, Apps, and Mods] jomaga:
Goto Settings/applications/Camera and look there the version number. It should be 2.5.21 or 22.

If you look the same inside the Camera settings it will show 2.5.2
[OnePlus 5 Themes, Apps, and Mods] abhishek7791:
how to revert back to original camera. I flashed the zip using magisk module.
[OnePlus 5 Themes, Apps, and Mods] tcat007:
2.5.21 on 5t DU. But using gcam mostly. Going to look for 2.5.22 to see what he happens.

Edit: can't find 2.5.22, hopefully op will update to it when avail available. I'm on custom rom, so it won't update.
[OnePlus 5 Themes, Apps, and Mods] Dennis995:
How i know if the mod is installed or not? :rolleyes:
[OnePlus 5 Themes, Apps, and Mods] Mackie Messer:
It shows .21 in settings. Thank you!
[OnePlus 5 Themes, Apps, and Mods] Dan3ll1:
When u see the option for Sharpness.
[OnePlus 5 Themes, Apps, and Mods] Dennis995:
I can't find this screen, how to do that?

I've installed the mod via Magisk module, actually my camera version on "app" is 2.5.21!
[OnePlus 5 Themes, Apps, and Mods] tcat007:
What screen do you see when you touch the settings icon?
[OnePlus 5 Themes, Apps, and Mods] Dennis995:
Yes, i've the same screen that you have, thanks!
[OnePlus 5 Themes, Apps, and Mods] Dan3ll1:
Damn son u life in a fukcing cast Le or what? :svetius::D
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
I don't know if the problem it's only mine but when I take a selfie the dimension is very low (1728x2304) which is not 16MP of course, also the size is not much, around 2.5 MB. I tried last release of 24/01 and tried also with all the sharpness settings available for the front camera. Somebody else has this problem? How can I fix it? I want full resolution pics!
[OnePlus 5 Themes, Apps, and Mods] firoz3321:
Yes, i observed this too. If u enable HDR in front selfie though, the image size is back to normal.
[OnePlus 5 Themes, Apps, and Mods] mariotme:
Very weird mine says 2.5.20 i tried installing it using magisk multiple times
[OnePlus 5 Themes, Apps, and Mods] Mao3K:
Poor resolution selfie camera

Hi friends, this mod is cool but make low resolution for the selfie camera. Aprox work in 3MPx.

Please Fix it.:D
[OnePlus 5 Themes, Apps, and Mods] haitower:
unfortunately im having very bad results with the camera on my 5t custom 4.6.7 oos rom.

i took a single pictures with:

- stock cam (.17) HDR auto

- camera M (.21) HDR on

- camera M (.21) HDR off

in the following sceneries:

1. low light outdoors

2. low (artificial) light indoors

3. normal (artificial) light indoors

every time i was taking a photo of the exact same image section with a steady as possible hand and with the same manual focus.

first i took the three pictures with stock camera, then flashed camera M (drummerboy style) and took all three pictures again with HDR on and then again with HDR off. (camera fc 3 times during this testing btw)

i then copied the pictures on my PC and compared them on my screen. first i thought "OMG, NICE PICTURES" because i was only looking at the last 2 digits of the file names (and these are SECONDS of the time when the pic was taken, lol) when i was comparing the pics. long story short: in all 3 scenarios stock cam was WAY sharper on the whole picture (not just where i focused) while the pictures of the modded camera were really, really smudgy and full of noise. only the indoor normal light shot was not smudgy but still very noisy (really small green and red dots). from my limited understanding of photography/physics noise is the tradeoff of a less smudgy picture. so i dont understand how i can have a MORE noisy and MORE smudgy picture than on the stock cam!?

so when i read on the xda news about this new cam mod and saw the comparison pictures i was really exited but now i'm pretty disappointed. for me, the depicted comparison pics are only correct when you exchange the pictures' labels ;)

edit: when i was taking the pictures with the modded cam i could already see on my phone screen that the pictures look smudgy and lack sharpness. i then took another pic of the same motive because i thought maybe my hand was shaking too strong -> but no improvement..
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Really weird, I have the same issue too but haven't change something about it. I will see.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Uninstall it if you are disappointed.

I will not tell it one more time : if you want the thing to be changed, post the pictures in https://imgbb.com in order to keep original quality + EXIF infos (ISO, shutter speed).

You are yelling about it but you do nothing to change it. I will not responding to you now because of the lack of respect and the no-reading of the thread, because it's the 42942 times and tell to post original picture if you want to see some changes.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
That's the real issue : I can't set a amount of denoise. It will be really nice but the only think I know is depending the light situation, Oneplus process will apply a certain amount of denoise in picture. When is in bright light, the levels are 1 for Luminance noise reduction and 1 for Chroma noise reduction and it correspond to nearly nothing. Remember the issue I tell you about the chroma noise appearing in picture with ISO under 200 ? When you activate the HQ mode, the luminance noise reduction and chroma noise reduction will be at the level 2. This is the trick I do : I activate the HQ mode when ISO hits 200 to get a acceptable luminance noise reduction comparing to the original one. Only issue with HQ mode is that increase the shutter speed. In bright light, is not a issue because shutter speed will be always low. I want to activate in middle-light situation but the too big shutter speed is not acceptable.

To see this numbers, get "CatLog" from Play Store, take a picture, launch CatLog and search "dump_cfg". You will see what I'm talking about.
[OnePlus 5 Themes, Apps, and Mods] aoleg:
Phoenix ROM, last of the camera mod: flash is not working in No HDR, hq modes (didn't try it with Pro).
[OnePlus 5 Themes, Apps, and Mods] swstar:
jan 24 version seems to be force closing even more often than jan 22 version, oos 4.5.14, op5

p.s. I did force stop, disable, enable, clear data, before installing the module, and did the cycle for upgrading too,
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
Sure I'll give catlog a try.

Personally, I think the act of removing the denoiser for low iso high shutter speed shots is enough for me. I haven't had a chance to try your latest build which you say attempts some denoise in bright areas, but I've not seen any evidence of this in my daytime shots. Today I took some daytime shots with very good light, blue sky and they look fabulous. Zoomed right in I can see chroma noise in the details but you have to really zoom in.

Night shots are always going to be a tough ask, especially with far from optimal hardware. So I've never expected you to work on this much. You can switch between, photo, pro and HQ mode and each one gives very different results, as you would expect, so that's kinda cool really.

As said before, maybe Uber customisation of the photo mode in the apps settings would be the best way forward, put the power in the users hands and let them decide what they want in photo mode!

Thanks as always. :)

---------- Post added at 08:49 PM ---------- Previous post was at 08:23 PM ----------

Slightly different question, can you work out from the code what the autofocus system is? It's terrible and I'm touch focusing on almost every picture. I would hedge my bets that its no more than a centre weight single point.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
No I will not work on touch focusing because it sounds too difficult for me.
[OnePlus 5 Themes, Apps, and Mods] haitower:
Wtf is wrong with u? I was neither yelling/complaining nor being disrespectful, nor asking you or anybody else for help.

I was just giving feedback of my experience. When i check out new apps/tools i'm always happy about reading user feedback.

I rly dont get why u feel so offended by my post. Anyhow.. I'm still thankful that someone tries to improve the camera.

Cant upload pictures cause i am on limited data and have no wifi near me.
[OnePlus 5 Themes, Apps, and Mods] mdyer101:
Question about installing this

I'm rooted with TWRP and Super Su. Is there anyway for me to get this Camera mod? Can I just flash the Magisk over Super Su then flash the Camera M zip?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
You call me liar/cheater in your silly post :

So please don't tell me you are "just giving feedback". They are manners to tell things. If this mod was a fraud, it will not be where is he now.

And like I said, you read anything in this thread. The goal of this mod is not to improve the low light picture but removing the watercolor effect on pictures, specially in bright/good light.

Get out of this thread please by the way. Don't want to lose my time for reading some kind of s*it.
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
The thing that annoys me the most is people asking the same daaaaaaaaammmmnn questions over and over...read the threads! Soo lazy!

You've done great work and forces closes aside I'm happy with your improvements. Keep it up!
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Thank you for that. Really appreciate man ! Btw, don't hesitate to test the latest version in bright light like you have done with previous version before and tells me if it looks good.
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
Np I'll load it up tomorrow
[OnePlus 5 Themes, Apps, and Mods] mNiosu:
Can someone please help me with a copy of the original 2.5.22 app from the beta2 OOS?

I'm having problems restoring the default app for testing after I installed the mod with the TWRP flashable zip.

Even dirty flashing my ROM restores 2.5.21 for me.

Strange...
[OnePlus 5 Themes, Apps, and Mods] Mao3K:
I have the same problem!
[OnePlus 5 Themes, Apps, and Mods] denogun:
have you considered adding this to the magisk repo? :) definitely will help all of us in getting up to date patches!
[OnePlus 5 Themes, Apps, and Mods] Jorgeprdz:
How to enable portrait mode? Is there any way to make it work on custom ROMs? I'mi using AICP ROM
[OnePlus 5 Themes, Apps, and Mods] iRhyiku:
No
[OnePlus 5 Themes, Apps, and Mods] xocomaox:
I am running OmniRom and using the Magisk module. I can't get the camera flash to work. Everything else is really nice. Thanks a lot.
[OnePlus 5 Themes, Apps, and Mods] prajnay:
Hey I am getting error 1 when I try to flash it I am on oos open beta 4
[OnePlus 5 Themes, Apps, and Mods] Mao3K:
Poor resolution selfie camera

This mod only work in the selfie camera to 3MPx or less.....:(:(:(

Please fix it!!!
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
I hardly ever use the selfie camera but yep mines capturing at 4mp. Also the video modes look very zoomed in.
[OnePlus 5 Themes, Apps, and Mods] Pshemo__:
Also switching between the front and rear camera takes quite a lot of time, doesn't it? It affects also apps like FB messenger for example
[OnePlus 5 Themes, Apps, and Mods] Gruber008:
Video mode is "very zoomed in" in default camera as well, that's not mods fault.