yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] :
Ok. Last question: will you make your mod open source to reduce your work because you are very busy?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Yes but even if I modify all this values to 100, it doesn't change the final result.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
I have already explain this : I don't have more code that you have or anybody else. You just have to decompile my modded apk with Apktool and you will have the same codebase that I have.
[OnePlus 5 Themes, Apps, and Mods] :
Ok, thank you
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
but using stock camera, we can't record videos using the secondary camera, but video comes out so good with the secondary camera. it is possible from stock camera only if we use *#*#1597#*#* . please enable to switch between primary and secondary camera.
[OnePlus 5 Themes, Apps, and Mods] Dieppy:
Through magsik, I'm on latest beta version (14.5)
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
I'm in the same condition, but it return the error the other user pointed out... bah...
[OnePlus 5 Themes, Apps, and Mods] iGamesMaximus:
I tested this mod on a OnePlus3T (A3003) Android 8.0 with beta 19 and it works perfectly, thanks
[OnePlus 5 Themes, Apps, and Mods] Best008:
Jpeg quality

How can i increase jpeg quality to 100 ... I can't find any such option in my suck oos app !! I have op5 !! Please tell me!
[OnePlus 5 Themes, Apps, and Mods] wasjapupkin:
Try to read this thread. Spoon-feeding isn't the best way to learn something. There is no option, that's why we have this mod.
[OnePlus 5 Themes, Apps, and Mods] Hemilpatel3296:
Can you create the same thread for OnePlus 5T because most of the people won't know that this mod is there for 5T also.
[OnePlus 5 Themes, Apps, and Mods] 20mark:
Im using the magisk version on my OP5T, and it breaks panorama mode. Anyone confirm?
[OnePlus 5 Themes, Apps, and Mods] vagkoun83:
I didn't noticed before but you are right. I tried to take panorama picture but it takes a single pic just like auto mode

---------- Post added at 12:06 PM ---------- Previous post was at 12:05 PM ----------

I tried panorama on 5t and I have problem also..I didn't notice before.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
First of all thanks to OP for the mod.

I installed the magisk version and latest camera app.hiw can I confirm whether this mod is working or not??
[OnePlus 5 Themes, Apps, and Mods] MJawad:
How to install it?
[OnePlus 5 Themes, Apps, and Mods] shah_allstyle:
Before this I flash the first version of mod by magisk.. But when I flash the latest 2.5.12 mod by magisk it success but the camera still the old one.. Did I need to install the camera separately?
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Install from apkmirror.com
[OnePlus 5 Themes, Apps, and Mods] JonasSavimbi:
Hi,

First of all thanks for your work!

Is EIS working for 4k video?

Would you be able to provide a modded apk that can be installed by non rooted users like myself?

Thanks!!
[OnePlus 5 Themes, Apps, and Mods] fuarkgl3:
EIS is working yes. You can install via twrp, you don't need root to do so, but you need an unlocked bootloader
[OnePlus 5 Themes, Apps, and Mods] JonasSavimbi:
I don't have an unlocked bootloader :( Wouldn't it be possible to mod it to allow to install in parallel with the regular OP camera?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Update : now based on new version 2.5.15
[OnePlus 5 Themes, Apps, and Mods] txx1219:
There is soon (I hope) an unified section for OP5 and OP5T mods. We can only wait, I don't want to handle 2 threads.

Only 5T ? Because I have tried Panorama in OP5 and it works great.

No, not possible.
[OnePlus 5 Themes, Apps, and Mods] Dieppy:
Both zip and magisk zip are updated?
[OnePlus 5 Themes, Apps, and Mods] Hemilpatel3296:
So for now, will this work on OP5T ??
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
With this update I solved my issue on op5 ob2... Awesome!!!
[OnePlus 5 Themes, Apps, and Mods] jakobWango:
Respect the devs choice and stop beg for him to fix stuff.

Why can't you just be happy with how it is currently and everything that OP has given you? ??
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
I uninstalled the module, restarted, reinstalled the module. But it still persists. Can anyone help me with this problem?
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
Can anyone provide previous Module for download? many thanks
[OnePlus 5 Themes, Apps, and Mods] timescaming:
Which previous version? May you specify it?
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
01-31 or 02-12 please

Thanks
[OnePlus 5 Themes, Apps, and Mods] andre0005:
Delete this please.
[OnePlus 5 Themes, Apps, and Mods] andre0005:
Nvm. Delete this please.
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Uninstall camera app and camera service then inatal the module.
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
is there a way to backup the current camera app and camera service? and can I just install the module after I deleted both the app and service? won't I need the actual app?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
1) No need of backup. They are available in apkmirror.

2) The module install both.
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
great thanks. So I uninstall "OnePlus Camera Service" and the Camera app with a root uninstall app?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Yes, look for root uninstaller on playstore
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
after doing what you said the camera app won't open at all anymore. How can this be fixed?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
You probably did something wrong.

Remove the module;

Reboot to twrp;

Clear cache and dalvik cache;

Reboot to system;

Reboot to recovery;

Flash the module;

Wipe cache and dalvik cache;

Reboot to system.
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
I did that, except for flashing the module in the magisk app. I still can't open the camera app...
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
So, remove the module and reinstall it. Its impossible this be wrong. I did it many times and never had such problem.
[OnePlus 5 Themes, Apps, and Mods] timescaming:
1-31: https://mega.nz/#!95Fm1SIA!YoUFtJyQYQjslMYwSJVxQ_SyAuvW5BWjf32heeMRfqI

I don't think I've have 2-12 thou.
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
after I deleted the app and services with root uninstaller and reinstalled both via the module, the camera app can't be deactivated in the app settings anymore. It can only be deleted, like a standard app, which means it screwed something up, right? I reinstalled it many times but the camera keeps crashing.
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
You still doing something wrong.

Lets try again...

Uninstall the camera app and camera service;

Go to magisk manager, modules and click on the trash icon;

Reboot the phone to system;

Check if camera app, camera service and module are removed;

If yes, reboot in recovery mode;

Wipe cache and dalvik cache;

Reboot to system;

On system, do not install the mod with magisk;

Reboot to twrp;

Flash the mod;

Wipe cache and dalvik cache;

Reboot to system;

Have to be working.
[OnePlus 5 Themes, Apps, and Mods] bl3d2death:
So I don't have to flash a separate cam apk? Only mod like you wrote?!

Last time I flashed the mod via magisk I don't had the camera icon (only android place holder symbol). I'll try this later and hope it will work.

Recommended mod version?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
No. The mod contains both (camera app and camera service). The last one 02-22.

I recommend you to flash the mod in twrp. I got some issues flashing directly by magisk.
[OnePlus 5 Themes, Apps, and Mods] bl3d2death:
Did it like you said. But images still only around 2 MB (or even smaller). In cam info I see it's the mod, but in December I had the mod and pictures were around 4-6 MB not 2 mb like now.

Also cameraservice was removed.

What can I do more?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Camera service is in system apps
[OnePlus 5 Themes, Apps, and Mods] bl3d2death:
Yep. I removed it like you wrote.

After falshing zip it's also again installed. But my issue is that the pictures are only 2mb ... Don't look like the ones.i did in December.

And Everytime I close the cam, HDR is disabled when opening again.

Don't get it, why the mod don't works for me. Thought it would run with custom rom....
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
This is OOS camera mod, dude... It is not guaranteed to work well on custom ROMs
[OnePlus 5 Themes, Apps, and Mods] :
Oneplus improved the noise reduction in Oneplus camera 2.5.25 and Camera Services 2.1.13, so we should update the mod. However, I know that the developer is busy, so we can wait a bit or we can try to update the mod
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Yes, more oil paint effect. The mod is way better than the last camera update.

---------- Post added at 05:46 PM ---------- Previous post was at 05:41 PM ----------

The mod set hdr off by default... You should read the op mate. This happens because of a feature created by op that makes some magic under the hood and this is only possible with hdr set off.
[OnePlus 5 Themes, Apps, and Mods] :
They reduced it a bit.
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
No way. I tested the last upeated and compare it with the module. The module just smashed it. Take a shot with last update and zoom in to see oil effect everywhere.
[OnePlus 5 Themes, Apps, and Mods] :
Yes, of course the module is much better. But, in my opinion, if Oneplus reduced itself a bit oil painting on the base app, CameraM could have better results, right?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
But, imo, the last update camera is worse. I didnt see this reduce.
[OnePlus 5 Themes, Apps, and Mods] :
Strange, I noticed a very small reduce of this problem. However, they also updated some libraries and they changed something other. It isn't so necessary, but the developer could update his mod
[OnePlus 5 Themes, Apps, and Mods] txx1219:
There is no sign of improvements/changes of the noise reduction in Oneplus Camera 2.5.25 !

I stated already that there is no changes in the code of Oneplus Camera 2.5.25. Can you show me a comparison between 2 photos before and after the update where the difference is visible ?
[OnePlus 5 Themes, Apps, and Mods] :
It isn't very visible. However, it could be only my impression?
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Bro, is there a possibility to use the flash below 15% and pro mode? Formerly I did from framework-res, I never knew that I had to edit in the code of the camera...

Thanks
[OnePlus 5 Themes, Apps, and Mods] :
However, these are two photos that I've just taken

https://photos.app.goo.gl/5HY1Fs8vYGi9aCoE3

I wrote the app version in the infos of the photo
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Mmmm .25 is 5% better...in my opinion
[OnePlus 5 Themes, Apps, and Mods] txx1219:
This is very difficult to judge in such pictures. Please provide it better exemples. I can assure you that the code from .23 to .25 doesn't change nothing in terms of picture quality. That's why I don't understand how you can tell me that Original .25 is better than Original .23.
[OnePlus 5 Themes, Apps, and Mods] :
I don't know ?

However, if you said that the code is the same, probably it is only a case
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Yes .25 version pic is more clear than .23 and it's very much visible from the photos.u should compare .25 with camera M module
[OnePlus 5 Themes, Apps, and Mods] don_gori:
Whether this version impacts on quality in RAW photos ?
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
I will now try what you wrote. I'm uninstalling the apps via titanium backup, I guess this is a safe way? and is this the original camera app: com.oneplus.camera.opcameraapplication?

EDIT: Flashing in TWRP worked, thanks a lot for your help!
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
No problem mate
[OnePlus 5 Themes, Apps, and Mods] ArtVandelay2:
another thing. if I want to dirty flash a new rom update, do I have to delete the mod or can I just flash the rom update and then reapply the mod? I'm just worried about bricking my phone.
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Reapply.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Hello [MENTION=3578456]txx1219[/MENTION]

Is there any possibility to reduce ISO further in intelli HQ mode / hdr off mode in the stock camera with your mod.google camera always click pics with lower ISO as compared to your mod.attaching screenshot of the data of the pics taken at same time but with Google camera and your mod.one with lower ISO is taken from Google camera and higher one taken with your mod.just a suggestion for 2.5.25 Version.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Another observation with your mod :

Clicked photo of same object with same lighting condition and see the results in HDR off,HDR on,HQ on mode.

Check for ISO,shutter speed and image size
[OnePlus 5 Themes, Apps, and Mods] yelov:
Yes HQ uses slower shutter speed, that's why it's better in low light. And about gcam hdr+ ISO - you can't compare it because hdr+ combines multiple underexposed images and then boosts the shadows. You can't do that with a single image without bringing out ****ton of noise. But I have to agree that in some situations it uses unnecesarily high ISO, especially in bright light. For example I often get shots at ISO 300 and shutter speed of 1/2500th of a second. Why can't it shoot at ISO 100 goddamit, the shutter speed is fast enough.
[OnePlus 5 Themes, Apps, and Mods] :
Thank you for the mod
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
How did you decompile apks??

Any guide will be appreciated
[OnePlus 5 Themes, Apps, and Mods] :
I used apktool. You can find a guide on Xda
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
If somebody gets the jpeg compression to 100 that raises the apk, the OP only got it up to 98%
[OnePlus 5 Themes, Apps, and Mods] iRhyiku:
you wont notice the difference.
[OnePlus 5 Themes, Apps, and Mods] psxcis:
Guys , I would like to ask. im on cusrom phoenix, i have installed oos cam new version from apkmirror. So if i want to use oneplus camera M, i just to need flash the magisk mod? Thx
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
I used to be on custom rom and tried flashing the oneplus camera M via twrp, it was working but the quality is not good as the stock's one (may be that's why we should flash it on stock based rom). Besides, you will lose some features of the stock OP cam such as Portrait mode or something more if I remember correctly, the rest are working well.
[OnePlus 5 Themes, Apps, and Mods] hooliganx:
[MENTION=6726548]psxcis[/MENTION]...

Hi guys.

Im on Phoenix too, and flashed Camera M in TWRP and portrait & other functions works good.

Have another OP5 (my wife) stock and quality is practically the same (for me) and better in some points.

Don't tested many situations, but had installed last version through apkmirror and Camera M working better for me in Phoenix.

I don't use Magisk modes.

:good:
[OnePlus 5 Themes, Apps, and Mods] psxcis:
Finally i tried flash via magisk & all is working good.

Portrait mode & selfie is working

Watermark working but only on pro mode

Im also using magisk fix for front portrait gcam

Thx
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Hey I remember the flash function was not working well when taking picture in dark situation, I dont remember what rom I was on but could you please test the flash when taking photo in dark place and let me know the result? Thanks and have a nice day!
[OnePlus 5 Themes, Apps, and Mods] psxcis:
Already tried n working good autoflash n flash
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Ok thanks, maybe I'll try one more time when I have time. :o
[OnePlus 5 Themes, Apps, and Mods] txx1219:
HQ mode cut the ISO by half when it's possible. IntelligentHQ is a thing I have developed to enable HQ mode when it can give a better result than normal. I have configured it to enable HQ mode automatically when ISO is under 1250 and shutter speed is greater than 1/33. But, even if HQ mode is enabled, it happends that ISO will not be cut by half. I think is related to how HQ mode works but this is implemented in Oneplus libraries (= Blob). But, I will really try to improve more this IntelligentHQ next time because it bothers me a lot this high ISO issue ..

Oh no, you have right. The 2.5.25 have really changed how OP5/T takes photos. They have implemented a secret HDR+ mode but I want to hide you from it. In this way I'm the only one that can uses it. /s

Please, I have explained you many times there is no real changes in 2.5.25. Now you angers me because you are telling bullsh*t. You doesn't even know what you are talking about. Kotlin is a programming language, and what you see after Apktool decompiled the apk is called Smali. Why are you lying in things you doesn't even understand ?

Version numbers are here and is not for nothing :

2.5.25

• This number indicates if there is a major change in the new version compared to old one

• This number indicates if there is a medium change in the new version compared to old one

• This number indicates if there is a little change in the new version compared to old one

Please now stop telling lies.

And there will be no update to 2.5.25. Period.
[OnePlus 5 Themes, Apps, and Mods] :
Ok, sorry. I understood that you won't update your mod. I only decompiled and saw some differences from 2.5.23 to 2.5.25 and I thought it was a reason of those samples that I took some days ago. Please, not be angry?

Now, I've edited the original message to avoid that someone could think something wrong
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
I still have no idea why OP5 has fully working portrait mode in any custom roms why OP5T doesnt. This is the reason why Im still using stock rom instead of many amazing custom roms. There is no dev working in OOS Cam mod for 5T so I come here to ask this question. Sorry if this a a off topic stuff. Thanks and have a nice day!
[OnePlus 5 Themes, Apps, and Mods] txx1219:
If you are in the stock rom rooted, send me the "camera.msm8998.so" in "/vendor/lib/hw/". I can make you a Magisk version of this lib version and you can try use it in a custom rom to see if portrait mode works.
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Hi, here is the file you need. Hope you can look at this and find out something. Thanks!
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Thanks for the feedback

---------- Post added at 05:19 PM ---------- Previous post was at 05:18 PM ----------
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Have you extracted it from a Stock rom ?

If yes, install the zip attached in Magisk when you are in a custom rom and tells me if it works. Only for OP5T.
[OnePlus 5 Themes, Apps, and Mods] rehannali:
Hi, I want to know about this zip. Is this is device specific or not?

If this is generic then it is not working and i can't even start camera. It gives me an unknown error and if it is device specific then my bad.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
What's your phone ? What's your ROM ?
[OnePlus 5 Themes, Apps, and Mods] finneus_:
Can I use this on open beta 6 for OP5 ? It's camera version 2.5.25 so will it not work ?
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Hi thanks, currently Im on stock rom so it'll take time to get back to custom one (Im working and still have many data on my phone). So if anyone here using OP5T with custom rom pleaes look at this and take a quick test for [MENTION=3578456]txx1219[/MENTION], he made a fix for portrait mode for 5T devices.

Or hey [MENTION=3578456]txx1219[/MENTION], IMO it'll be our pleasure if you create a thread for this camera fix in OP5T forum, Im sure if it's working, all devs there will implement your fix into their roms asap because no one has fixed this issue for a long time.

Thanks and have a nixe day friend!
[OnePlus 5 Themes, Apps, and Mods] rehannali:
I'm using OnePlus 5t with code name Phoenix.
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Hi [MENTION=7511257]rehannali[/MENTION], look at my reply above for more detail, it's a portrait fix for OP5T stock mod camera on custom roms. Firstly you have to flash the Oneplus Camera M by [MENTION=3578456]txx1219[/MENTION] (at the first page) then flash the fix zip for 5T he gave link in a previous page: https://xdaforums.com/attachment.php?attachmentid=4456636&d=1521917445 , then reboot. If it wasnt working for you (you are on CNP rom) this means it may be not working for other custom roms also. Hope [MENTION=3578456]txx1219[/MENTION] can find out something good then.
[OnePlus 5 Themes, Apps, and Mods] rehannali:
I tried exactly same. After flash fix portrait mode zip, same error occurs. Unknown error.
[OnePlus 5 Themes, Apps, and Mods] Urnyx05:
Fantastic mod and fantastic developer. I read your post on Reddit about dots on GCam and you explained everything perfectly.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
I didn't fix anything. To be honest, I just put the library file in a Magisk zip because you tell me that severals custom roms have portrait mode working with OP5 but not OP5T. My (simple-minded ?) theory is that the custom rom was originally designed for OP5 and doesn't includes the original files for OP5T, which it's needed to fully support the portrait mode for OP5T.

We need to test it to see if it can be this. I haven't a OP5T so I really need first you try and chat here before creating thread.
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
[MENTION=3578456]txx1219[/MENTION] nope, I have this library included in CandyROM, and no portrait mode in Camera M
[OnePlus 5 Themes, Apps, and Mods] rehannali:
In the way back when I'm using OP5, There is no portrait mode in OP5 even option isn't available. I saw in OP5t there is an option for portrait mode and when I tried to switch on portrait mode, app stuck or crashes.

Without flashing zip for portrait mode, camera works fine except for sudden zoom in and out, and still, i don't know what is causing this kind o behaviour.
[OnePlus 5 Themes, Apps, and Mods] Ashieboy™:
I have the same problem, was this resolved?
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
No solution yet. I thought was the module but turns out even I switched off camera M, this still happen randomly. I may try ob4 when I have time. Hope is not hardware issue or something serious
[OnePlus 5 Themes, Apps, and Mods] Ashieboy™:
Thanks, post an update here.
[OnePlus 5 Themes, Apps, and Mods] Ashieboy™:
What is your kernel? And what rom are you using, I'll try to debug this
[OnePlus 5 Themes, Apps, and Mods] Urnyx05:
I've just installed CameraM and, unfortunately, photo quality doesn't improve very much. However, your work is great because all the camera modes work perfectly on my Oneplus 5.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
[MENTION=3578456]txx1219[/MENTION]

can u look into it

https://xdaforums.com/mi-a1/themes/magisk-google-camera-telephoto-lens-t3767531
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
theOneOS 5.0.4 AROMA ROM and blu_spark r106 kernel(not custom)
[OnePlus 5 Themes, Apps, and Mods] kaihansen2001:
You are using wrong kernel with rom so it is normal that you Get strange behaviors. 106 is for 8.1 roms.
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Have you uninstalled the services of the camera and the camera application works correctly, does anyone know exactly what does the camera service do?

Thanks!
[OnePlus 5 Themes, Apps, and Mods] txx1219:
It's related to some functionality of camera like flash, auto-brightness when you are in a camera app, etc.

In first versions, camera service wasn't present but people mentioned that new version of Oneplus Camera app needs the latest Camera Service in order to prevent some bug, so I decided to include it. Oneplus Camera app can work without it but be aware that bugs can appears.
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
So, this means that may I able to install updates over camera service, right? The changes that you made are limited only for camera app and not camera service, right?
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
my bottom pixel Bar solved by flash correct kernel. Iwas using Android 8.1 kernel (blu_spark r106) on OOS 5.0.4(8.0)