yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
Well done!

I just installed the magisk module and everything is working fine. Could it be because I'm already on beta 3?
[OnePlus 5 Themes, Apps, and Mods] Dazzel:
Installed with rooted method on current 5t nougat 4.7.6 but panorama mode does not work. Everything else is working as expected.
[OnePlus 5 Themes, Apps, and Mods] kimikim0:
Force close on op5 5.0.1 using magisk
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Try to type this command : "adb shell pm uninstall com.oneplus.camera" and retry the installation.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Have you install the Oneplus Camera Service apk ?
[OnePlus 5 Themes, Apps, and Mods] CrashTestDroid:
I can confirm this doesn't work on OP5 OOS 5.0.1 if rooted, so I made a recovery-flashable updater and the camera is updated and works except for panoramas. Installing the camera service doesn't fix it on 5.0.1.
[OnePlus 5 Themes, Apps, and Mods] RomDodsky:
Thank you for your prompt response and your attention.

In fact, it's worse with this command (adb shell pm uninstall com.oneplus.camera).

The application is still present and can even be open, while with the previous command, the application appeared to be removed (neither icon nor displayed in the list of applications).

Could it be an issue with the apk signature ? Something Else ? :confused:
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Did you have the response "Failure [DELETE_FAILED_INTERNAL_ERROR]" when you type it the second time ? Because when you see this message, it really means that there is no package with this name. Really weird.

I recompiled and resigned the app if you want to try with another apk : https://www.dropbox.com/s/ddzx57m711ucbln/Oneplus Camera M 2.5.21.apk?dl=0
[OnePlus 5 Themes, Apps, and Mods] Dazzel:
Yes, installed it before and after to make sure.
[OnePlus 5 Themes, Apps, and Mods] RomDodsky:
Indeed, I have the response "Failure [DELETE_FAILED_INTERNAL_ERROR]" when I type the commande a second time... but the camera is still installed and can be used ! :silly:

I have downloaded and still tried to install the recompiled and resigned (thank you much), but I have meet the same issue.

[What was the previous command ? adb shell pm --user 0 uninstall com.oneplus.camera ?]
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
You are welcome. Now I repeat the question... Will you include camera service in Magisk Module?

Thanks!
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Nope because you can install it by downloading the apk. I don't mod to the Camera Service so there is no issue by installing it with the apk.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Method for non-rooted user doesn't work. I'm really sorry for this. I mis-tested it before proposing it.
[OnePlus 5 Themes, Apps, and Mods] wasjapupkin:
Could you share your version? Thanks in advance
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
But if you include Camera Service in module, if the user want to uninstall the mod and previously had an older Camera apk, Camera Service version would be the recently installed and not aligned with the previous Camera apk, which maybe causing bugs.

If you include it, the user have the correct Camera Service with your modded apk. You save one step to the user (if user use Magisk of course).
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Ok, I will include it.
[OnePlus 5 Themes, Apps, and Mods] MarcSN311:
how can I undo this? I am stuck on the 1+ screen now.
[OnePlus 5 Themes, Apps, and Mods] michikrug:
Remove the magisk module in TWRP (with magisk manager for recovery, e.g.) or reset magisk by uninstalling and installing it again.
[OnePlus 5 Themes, Apps, and Mods] Mervingio:
I think he refer the phone can't boot
[OnePlus 5 Themes, Apps, and Mods] michikrug:
I know. And this is the solution for it. ;)
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
do you have dot fix for GCAM installed?
[OnePlus 5 Themes, Apps, and Mods] Urnyx05:
If you have any custom ROMs, it doesn't work
[OnePlus 5 Themes, Apps, and Mods] Siljorfag:
Yes i do. Savitar's Pixel 2 colours too.
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
I am on OB 13.

I have only dot fix, I have no idea why it isn't working for me.
[OnePlus 5 Themes, Apps, and Mods] Urnyx05:
Very strange, try to delete the module and install it again
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
I have also tried uninstalling system app and flashing the other zip which modifies system (created by other user here)

it's weird that I also do not have 18:9 camera ratio (which I have already reported here)

I haven't been able to find a fix for these two till now.
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
Do you have 18:9 From stock camera(Module off)?

I am quite sure if op5 has 18:9 from stock, since op5t has 18:9 screen but not op5
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
I don't have 18:9 in stock camera too, I am using 5T.
[OnePlus 5 Themes, Apps, and Mods] tcat007:
I have 18;9 on stock with M.
[OnePlus 5 Themes, Apps, and Mods] jesper801:
Same problem here..
[OnePlus 5 Themes, Apps, and Mods] timartinhof:
What sharpeness level do you recommend, according to your experiments?
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
1 or 2 imo.
[OnePlus 5 Themes, Apps, and Mods] yohouse2:
When I shoot low light photos on my OP5, it switches to the telephoto camera which is very dark, is there a fix to this?
[OnePlus 5 Themes, Apps, and Mods] rushier.ivan:
Oneplus Camera v2.8.20 is out on apk mirror. Will this module be updated as well? :)
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
for sure :)
[OnePlus 5 Themes, Apps, and Mods] saccentekennedy:
I've just updated to OB15 and I don't have selfie portrait.. there's something weird going on with how this mod doesn't fully uninstall. Anyone else having a problem after updating to the new beta?

---------- Post added at 11:34 PM ---------- Previous post was at 11:20 PM ----------

Ignore me... It's because I had the GCam dotfix still installed... And it doesn't (yet) work with the new Beta
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
I have uninstalled the module and fixes too, I still don't have the front portrait.
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
Let the dev update the module
[OnePlus 5 Themes, Apps, and Mods] bgumble:
If I uninstall the modul (via Magisk Manager) the stock camera crashes with the first shot.

OB15
[OnePlus 5 Themes, Apps, and Mods] liloow:
Dirty flash the OTA again !
[OnePlus 5 Themes, Apps, and Mods] panoramixmeister:
Running latest stable OOS 5.1.5 with stock kernel on my 5T.

The latest version of the mod breaks the safety net check with Magisk 17
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
pretty sure it doesn't effect saftetynet
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
In [MENTION=3578456]txx1219[/MENTION] we trust!!
[OnePlus 5 Themes, Apps, and Mods] skanadian:
Slow motion not working on 5.1.5. It records and has the icon for slow motion, but plays normal speed.

nm works fine.
[OnePlus 5 Themes, Apps, and Mods] L0GYKAL:
Hello, I've installed the mod via magisk, but when I start my camera it give me a black screen like if my phone is off but I'm sure that it's buggy, is it possible to reset the camera app? Because even if I inactive it and reactive it, it doesn't work.

Thanks for your reply
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
It's working well here, no problem
[OnePlus 5 Themes, Apps, and Mods] sjamie:
I used DorianX's AllLib version and slow motion works properly for me.

Try reflashing the Mod.
[OnePlus 5 Themes, Apps, and Mods] skanadian:
Yup, you're right, the recording shows "real time" but playback has adjustable options for what's slow motion and what's not. I must have dragged the bar over when testing.
[OnePlus 5 Themes, Apps, and Mods] sjamie:
Yep, it's pretty slick!
[OnePlus 5 Themes, Apps, and Mods] alesolbe:
I had to do a factory reset because my phone stucks in 1+ logo after flashing this mod. what a rage!!!
[OnePlus 5 Themes, Apps, and Mods] sjamie:
You didn't take a TWRP backup first before attempting to install this mod?
[OnePlus 5 Themes, Apps, and Mods] DorianX:
Mods can go bad... So next time make a backup

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] rushier.ivan:
Hello.

OP Camera has been updated as 2.8.29 https://www.apkmirror.com/apk/oneplus-ltd/oneplus-camera/oneplus-camera-2-8-29-release/

Will there be an update with this module as well?

I prefer this mod over gcam. I don't want multiple cameras installed for different situations. OP Camera M suits my camera needs. Kudos to the devs. :victory:
[OnePlus 5 Themes, Apps, and Mods] bornthisjesus:
I would really like to see this mod on OpenBeta 17, the one that comes with front facing portrait mode, I've been using this mod for so long and I really like it
[OnePlus 5 Themes, Apps, and Mods] getaceres:
When I've installed it I get a force close on opening. I have gcam with fixed libraries. Is there any incompatibility between the two?
[OnePlus 5 Themes, Apps, and Mods] obol2:
Is this project dead?
[OnePlus 5 Themes, Apps, and Mods] jun_ng_1208:
No it isn't
[OnePlus 5 Themes, Apps, and Mods] obol2:
I hope so
[OnePlus 5 Themes, Apps, and Mods] JonasSavimbi:
2.8.29 camera apk causes force close on stock OOS 5.1.5.
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
This Mod lastest version should only come with 2.8.11 instead of what you installed. Check if you have done something wrong.

07-23 version working fine on my oos5.1.5
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
How about the front portrait mode? Is it working with the 7.23 ver mod?
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
I don't think front portrait mode available originally for 5/5t. So this Mod won't add such feature neither.

ASAIK, front sharpness setting is available from this mod
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Actually we have on the OB latest version. You can check it if you want.
[OnePlus 5 Themes, Apps, and Mods] slickw:
no need to update this mode very often unless some big changes occur like introduction of portrait mode in front cam.

so right about now update would be most welcomed by everyone :)
[OnePlus 5 Themes, Apps, and Mods] BTslo:
Breaks safetynet for me too. I also have the modified libs installed for gcam. (latest open beta)
[OnePlus 5 Themes, Apps, and Mods] sproez:
I'm sorry but I can't download with anything, it just gives me 402 error :(
[OnePlus 5 Themes, Apps, and Mods] simcax:
Hmm, there is a new version for the op6, we can hope for an update?
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
Just hope for best ?
[OnePlus 5 Themes, Apps, and Mods] bornthisjesus:
What happened to the developer of the mod??? Is it gone?? I mean, since July we haven't got any update to this mod, and now that camera has included front portrait mode it needs to be updated to work fine again, I was such a fan of this mod, It helped a little bit with the horrible Camera app OnePlus developed.
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
So you are his boss right? What are you doing here boss?
[OnePlus 5 Themes, Apps, and Mods] g4seb:
Hi, this mod is it aleays better than the standard app ?

Regards
[OnePlus 5 Themes, Apps, and Mods] izzyserious:
That's more or less the entire point of this mod.. To improve upon the stock functionality of the OP camera. I guess it's still subjective though, I'm sure there's SOME people who don't think it makes a difference. I personally wouldn't use stock again after using this mod. It makes many improvements to the stock openplus camera.
[OnePlus 5 Themes, Apps, and Mods] bornthisjesus:
Almost 3 months with no update, is this project already dead??
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
Hope so
[OnePlus 5 Themes, Apps, and Mods] lazygeniuslanz:
Does this work on Pixen OS android pie?
[OnePlus 5 Themes, Apps, and Mods] vtisedan:
hello..i just rooted my op5 in order to check this mod. Installed the magisk module, rebooted, but when i open the camera it just crashes "business card camera keeps stopping"...Please any help?
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Don't know what is up with that. Have you followed the instructions provided by the OP? Did you uninstall the updates of the camera before flashing the module? Did you flash the model in twrp or in magisk? Which version of OOS do you run? And which zip did you install? The 2018-7-22 version?
[OnePlus 5 Themes, Apps, and Mods] vtisedan:
Thanks for your reply. I am running stock 5.1.5. Finally i installed the dorianx version including the libs and worked fine.

BUT the quality is worse comparing to the stock camera...

My installation: I didnt update the stock camera, i just disable it and then flash the mod via magisk. Rebooted and all works fine. But as i said the quality is worse.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
I am not sure about the quality, but I will make some comparison pictures today when I have time and upload them to check.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Here you are. Comparison. The warmer picture is shot without the mod and the colder one is shot with the mod. The difference in size is big, in fact the modded picture is 10 MB while the original camera has shot a less than 3 MB photo. But take a look at the details man. In the modded camera picture you have more details, just a little bit more noise, but that is totally acceptable for what you get back. This mod works perfectly man.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
If you want the best pictures available then check out the modded Google camera from Arnova then.
[OnePlus 5 Themes, Apps, and Mods] sjamie:
I can't seem to fix the purple tint when using GCam. Could you post the same pic using GCam for comparison?
[OnePlus 5 Themes, Apps, and Mods] vtisedan:
Your first pic wont show up. I believe you but i installed it as in description. I installed the camera mentioned, not the camera on first page of this thread. The quality in my case was much worse with the mod.

Please bear in mind that i rooted my phone only for this reason, to install the mod. (camera freak) :p

I already installed it with great results.

You must flash the binaries fix from the celsoavedo

https://www.celsoazevedo.com/files/android/google-camera/op5fix/
[OnePlus 5 Themes, Apps, and Mods] sjamie:
That fix says it is for the front camera. I'm getting purple/pink pics with the rear camera. Does it also fix that?
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
I have the latest version of Arnova's modded gcam (8.3b) plus the fix plus the Pixel 2 Colours zip. And the pics are perfect, no pink tint at all, front also working, slow motion not working. I have a OnePlus 5 though, I don't know if you have the 5t it might be different. You can find the screenshots of my settings, it may be that. I have also attached 2 pics, one done with the modded gcam and one with the modded OnePlus cam (the one done with the gcam is slightly more saturated). The gcam wins but not by much here, the sharpness is at the same level, but the noise is less.

EDIT: inside the camera 2 API fix I have everything disabled.
[OnePlus 5 Themes, Apps, and Mods] sjamie:
Thank you! I also have the OP5 and yes, these two pics are extremely close. Which one was taken by GCam?

How well does GCam do with recording video? I uninstalled GCam recently because overall, it was too laggy and problematic for me. If you think it is now better than the OP cam, I'll definitely give it another shot.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
I am not an expert in pics, the OP cam and Arnova's cam are really close, the gcam takes more saturated pics (which I personally like, although it might just be the Pixel 2 colours tweak) and the exposure is more natural ( the OnePlus camera tends to shot underexposed pics) the level of details is the same but the gcam manages better the noise, keep in mind though that I used the super high setting for hdr+enhanced. If you use this setting in the dark the shooting process will take ages and it will result in a blurry image (because your hands move while shooting) in that case the pics are still great with noise, but you have no details because of the blurring. That is why I keep both the cams, in nightshots I use the OP cam because I can take more firm pics at the expenses of the noise. Videowise I did not notice a difference between the 2 cams. If you want to increase the quality on videos on gcam then go to the developer options of the gcam and enable "camcorder.h265". You can do also the same with the modded OnePlus cam but you need to install a magisk module called "HEVC+SM GC OP3&3T and OP5". The difference is barely noticeable, but you basically have slightly better quality with absolutely no increase in size thanks to the codec h265.
[OnePlus 5 Themes, Apps, and Mods] sjamie:
Thank you for this! I now have some testing to do... ?
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Let me know your thoughts when you have done them :)
[OnePlus 5 Themes, Apps, and Mods] vtisedan:
yes it does. Thats why i mention it. Without the libs, purple gets in the way.

Lucaterpirla, can you please tell me what camera mod did you install? Because when i flashed the magisk mod (the one i mentioned before) the stock camera interface changes (Camera M) but the quality is really blurry. When i removed it, it ruined my stock camera also, so i had to factory reset the device.

Also, check the difference in these 2 pics. The one is stock camera (not m) and the other is gcam.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
I get the change of interface as well when I install the camera M module, but my pics get better, I don't know why you get worse pics. Did you uninstall any update of the original stock camera before applying the mod like the OP told as well? Is the mod working now that you did a factory reset? And as for the pictures, I can tell that the one on the left is done by the Google cam, the colours are colder and is a bit sharper.
[OnePlus 5 Themes, Apps, and Mods] sjamie:
If I just clean flashed OP 5.1.6 stable yesterday, there should not have been any camera update I needed to uninstall, right? I don't think I've ever uninstalled anything camera related before flashing this mod and everything seems to have been working for a long time. However, my eyes don't really see much difference between the pics posted here with the stock camera, Camera M, and GCam. ?

---------- Post added at 03:55 AM ---------- Previous post was at 03:35 AM ----------

I installed GCam 8.3b1 and to my surprise, NO PINK/PURPLE in pics. I didn't even have to flash the fix. However, my pics have a TON of noise in them using your exact settings. I may have to also flash the fix and the Pixel2Colors.zip for a true apples-to-apples test.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Yes, I would recommend to install the fix and the pixel 2 colour module, you get better pics with gcam. As for the camera M mod.... Well I am sorry you cannot notice a difference with the stock cam :(

Did you install the version 2018-7-23 with DorianX libraries?
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
The dev abandoned this project? I hope not bc this camera mod is so wonderful for me, at least it can enhance the OP5T stock camera quality to a higher level.
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
Hope dev gives us some info in this project
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Ye, Im still waiting for the new mod that can fix the front portrait mode issue. That's will be great.
[OnePlus 5 Themes, Apps, and Mods] QuickInfo:
Anyone have issues in CNP (Codename Phoenix) where the Google Play Services says it stopped working right after installing via Magisk?
[OnePlus 5 Themes, Apps, and Mods] jauhari:
Any update this port with Night Mode like on OnePlus 6/6t?
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
If you want night mode try out the modded gcam pixel3 from Arnovas.
[OnePlus 5 Themes, Apps, and Mods] iPap:
This one looks good and it's pretty recent!

But you can't really see much when using the "night" mode. :/
[OnePlus 5 Themes, Apps, and Mods] aneeshmbabu:
Mine bootloop after installing via magisk
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Did you read the OP carefully? Did you uninstall any previous version of the stock camera?
[OnePlus 5 Themes, Apps, and Mods] don_dolarson:
Broke my stock 5.1.5 camera app. Started working as fast as the module has been deactivated and system rebooted. Definitely not working as it should.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Did you read the OP's instructions to uninstall any previous version of stock camera?
[OnePlus 5 Themes, Apps, and Mods] don_dolarson:
Of course. Running latest Magisk 17.1 as well. The name of the camera has been changed to anything like "visitcard camera" in the name (in my language) and icon changed from Camera to Android Oreo green system icon, just like other when you check to show system apps in settings.
[OnePlus 5 Themes, Apps, and Mods] tk-germany:
Facing exactly the same problems, for additional logs view my previous post

Problem still exists with stock 5.1.7

Edit: found a mod by dorianx that includes the libs and works for me:

https://xdaforums.com/showpost.php?p=77228218&postcount=1532
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Install dorianX version and it works. It is working for me at least.
[OnePlus 5 Themes, Apps, and Mods] sjamie:
Yes, this is the version I've been using without issue since it was released. Thanks again [MENTION=2185114]DorianX[/MENTION]!
[OnePlus 5 Themes, Apps, and Mods] Mukesh27:
Installed through twrp recovery and working fine on my oneplus 2 except no HDR option. Thanks.
[OnePlus 5 Themes, Apps, and Mods] don_dolarson:
Should I flash the DorianX version through TWRP, not Magisk?
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Correct
[OnePlus 5 Themes, Apps, and Mods] tk-germany:
For me it worked both ways. Found magisk a bit more comfortable to enable and disable so chose this way finally
[OnePlus 5 Themes, Apps, and Mods] don_dolarson:
Flashed through TWRP on 5.1.5 and dorianx version works like a charm
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
Still waiting for the version that's compatible with the front portrait mode :|
[OnePlus 5 Themes, Apps, and Mods] tk-germany:
Where's the problem? This one does! Go to portrait, tap on the "change camera" button and shoot. Works fine over here.

And even if it does not for you, it's up to you to work on it or at least ask kindly for it instead of demanding things the way you do!
[OnePlus 5 Themes, Apps, and Mods] lemonade747:
I meant with this camera mod installed, when I tap the change camera button (to switch to the front camera portrait mode), it always crashes immediately. Could you please give me the link of the camera mod that's compatible with the front portrait mode you are using now? Thanks! :good:
[OnePlus 5 Themes, Apps, and Mods] tk-germany:
On which phone and rom are you running?

I'm using the one I linked 5 posts before on op5 with 5.1.7 stock ROM:
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Front portrait mode doe not work for me either. I am on 5.1.7 with dorianX camera. Is the front portrait something you get with 5.1.7??? Or do you need the open betas? Do you think the modded gcam could be responsible for the front portrait not working?
[OnePlus 5 Themes, Apps, and Mods] ngshixuan:
Front portraits are only for open betas.
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
That is probably why we don't have front portrait working, we are on stable builds.
[OnePlus 5 Themes, Apps, and Mods] valeriee:
Guys I disabled the oneplus camera app before flashing this mod and when i booted back into the os the camera app has disappeared from my apps and i cannot enable it again? Tried dirty flashing rom again but no luck? Any help thanks
[OnePlus 5 Themes, Apps, and Mods] lucaterpirla:
Uninstall the magical module, reenable the camera and reinstall the module, try it out and see if it works.
[OnePlus 5 Themes, Apps, and Mods] valeriee:
I installed it via twrp... So I cant uninstall the magisk module. I just installed a new apk from oneplus. I tried this mod and it just seemed to make my gcam laggy and I use both the oneplus and gcam so I just wont use this.