yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
Can you please post your camera apk(ver 2.5.23)?
[OnePlus 5 Themes, Apps, and Mods] persieghini:
Yes it would have done it.. The app will be stock when you disable and enable... Message didn't matter for me...
[OnePlus 5 Themes, Apps, and Mods] don_gori:
Can someone test RAW pictures with stock camera and Camera M ? Will be helpful to upload files here :)
[OnePlus 5 Themes, Apps, and Mods] observingi:
Hope this helps.
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
I am getting error 'app not installed'
[OnePlus 5 Themes, Apps, and Mods] TONGEXHISPEED:
Front cam not work!!
[OnePlus 5 Themes, Apps, and Mods] observingi:
Sorry, I have no clue about how to resolve the issue.
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
[MENTION=3578456]txx1219[/MENTION]

Hey,I just updated to v2.5.23, your MOD was working fine in v2.5.2,but it doesn't work with the new oneplus camera app.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
How did you check/ confirm??
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
There's no option to set sharpness for front camera
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
[MENTION=3578456]txx1219[/MENTION] maybe it's a completely wrong assumption, but I've just found out that there is a separate apk by the name 'Shot on OnePlus', maybe including it in the mod could help with the watermark crash?
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Got it
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Read first post, it explains well why you can't see the mod.

It's a module who lets you share pictures directly in Oneplus forums. You can test it by pressing the sharing button in a picture, you will see the "Shot on Oneplus" option. But I will try. Thank you for the suggestion.
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Update mod to 2.5.23 please
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
Really appreciate your mod thank you so much dev
[OnePlus 5 Themes, Apps, and Mods] ksclero:
little question: it is possible make the mod as an app standalone to use toghether at the original app?
[OnePlus 5 Themes, Apps, and Mods] jesper801:
Wow, how did you make those pictures without getting so much noise?! That's really impressive!
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
I dont know i use latest version mod
[OnePlus 5 Themes, Apps, and Mods] blinkin:
Is it possible to flash this magisk module without magisk manager? I can't be rooted so can operate only through twrp...
[OnePlus 5 Themes, Apps, and Mods] Ashieboy™:
Magisk has a module that hides itself, also there's an XPosed module that can hide an app from another app.
[OnePlus 5 Themes, Apps, and Mods] blinkin:
Tried that, didn't work
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Nice pics!!

What's your camera version in OOS 5.0.2?are these photos taken with stock cam??
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
Yes stock oreo b3 cam version is 2.5.2
[OnePlus 5 Themes, Apps, and Mods] qerboz:
Where can I get the magisk module ? Is it the zip file ? When I click on "magisk module" it says "couldn't parse forum URL". Besides, thanks a lot for doing this mod
[OnePlus 5 Themes, Apps, and Mods] Mackie Messer:
It is a ZIP-File. Click on "Magisk Module". Download with a browser, not with the XDA-App. Firefox works.
[OnePlus 5 Themes, Apps, and Mods] LeoPosas:
The difference with GCam it's too mind blow! Low light photos, and the photos size taken with this mod are lower.

Thanks! Awesome mod. :good:
[OnePlus 5 Themes, Apps, and Mods] slonn:
Can I ask how people installed this? Following the instructions on the OP I didn't get a prompt when disabling the stock cam. It simply disappeared and I had to re-enable it.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
You are good to go know.just install magisk module
[OnePlus 5 Themes, Apps, and Mods] observingi:
The same happened on my device. I am on OOS 5.0.2

So after disabling, there was not update to rollback.

I enabled the camera again and Installed the Magisk module, rebooted.

Works like a charm!

Hope this helps.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Which rom and kernel are u using??

---------- Post added at 10:49 AM ---------- Previous post was at 10:45 AM ----------

Can u just confirm whether the option "disable noise reduction in low light" was enabled or disabled at the time of taking these low light pics??

---------- Post added at 09:50 AM ---------- Previous post was at 09:49 AM ----------

Can u just confirm whether the option "disable noise reduction in low light" was enabled or disabled at the time of taking these low light pics??
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
It was disabled
[OnePlus 5 Themes, Apps, and Mods] Kasinga:
Thank you txx1219 for your mod, it is a big improvement compared to the stock camera! I have HDR disabledand and the sharpness for front camera on 3, the colors are better now and the pictures are sharper with less oil-painting-effect. Has anyone played a bit with the sharpness for front camera? What number do you use and why?
[OnePlus 5 Themes, Apps, and Mods] farbeyondoverkill:
I personally use 2. I've tried up to 4 and worked my way down and 2 has given me the most balanced results. Before this mod came out I was pretty happy with the FFC aside from the oil painting effect. It gives the FFC a natural boost to sharpness and provides some really detailed pics.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
New update :

- Sharpness increased in really low-light situations

- Sharpness decreased in good and mid light situations to avoid too much noise / oversharpening effect

- Noise reduction is applied a bit earlier than before to avoid too much noise. Don't worry for the oil-painting effect I have adapted the sharpness for it

- Remove of the switch for disabling noise reduction in Parameters : It causes too much confusion. I have seen many people asking if they need to enable it or not, so I remove it. When it was enabled, the picture quality was really bad compared to when it was disabled anyway.

- Auto-HDR and HDR is now working like the original Oneplus Camera app

- No-HDR is now by default. It gives better results than Auto-HDR, even when Auto-HDR doesn't not kick the HDR mode

- Code base cleaned and prepared for the next "big" feature :)

Magisk module

If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app. To remove the update, go to App Info of Oneplus Camera and disable it. A prompt will ask you if you want to revert back to the factory version. Press yes. Re-enable after that.

Concerning people with non-OOS ROM, you have to understand it that Oneplus have included some proprietaries things who post-process picture in Camera 1 API. Oneplus Camera relies on it. I don't think custom ROM included it. I can't do nothing about it because it's concerning the ROM itself and not the app.

If you are not satisfied with the current result of the mod, please post the ORIGINAL picture in https://imgbb.com and explain what you think it should be better.
[OnePlus 5 Themes, Apps, and Mods] mele80:
I just yesterday found this mod and I thank you for improving our camera.

So in order to updated modded Oneplus camera from previous version (31.01.2018), I just need to install newest magisk module versio and reboot?
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
i wonder what's the next "big" feature ?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Hotfix !!!!

Download again the magisk module to get a fully working version !

Magisk module
[OnePlus 5 Themes, Apps, and Mods] knpk13:
Can you upload this to the Magisk repo so we can get updates automatically?
[OnePlus 5 Themes, Apps, and Mods] collin5022:
I've installed the latest zip through Magisk, but how can I verify that it has replaced the stock system Camera? The version now shows 2.5.22... is this the latest Camera M?
[OnePlus 5 Themes, Apps, and Mods] timescaming:
If successful it would show Camera M 2018-02-12 inside camera settings.
[OnePlus 5 Themes, Apps, and Mods] gre0ge:
Wow. Amazing! Perfect! Better than Gcam in this moment.

Thanks
[OnePlus 5 Themes, Apps, and Mods] erison-23:
where you have this configuration option
[OnePlus 5 Themes, Apps, and Mods] timescaming:
Slide up in the camera app, select the gear icon.
[OnePlus 5 Themes, Apps, and Mods] collin5022:
slide up*. thanks [MENTION=8494731]timescaming[/MENTION], i've verified that the module is installed properly
[OnePlus 5 Themes, Apps, and Mods] mohitgalaxy3:
Hello,

If we flash through magisk is it still breaking the panorama mode. Please confirm.
[OnePlus 5 Themes, Apps, and Mods] persieghini:
Yes panorama and watermark is broken....please read op
[OnePlus 5 Themes, Apps, and Mods] mohitgalaxy3:
I did just wanted to confirm if it's still happening with the new magisk hotfix or not.

Thanks for the info.
[OnePlus 5 Themes, Apps, and Mods] Lelikus:
Panorama and watermark work if before install original onepluscamera.apk
[OnePlus 5 Themes, Apps, and Mods] yupo72:
I've tried the Pro Mode but the app keep crashing....how can I get back into the Camera to go back to standard mode?
[OnePlus 5 Themes, Apps, and Mods] DorianX:
Delete camera app data

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] yupo72:
Tried but after setting few things it crashes again
[OnePlus 5 Themes, Apps, and Mods] DorianX:
[MENTION=3578456]txx1219[/MENTION] I made some progress on Watermark and Panorama issues, you need to put cameraapp\lib\arm64 folder into the module.

If you enable watermark won't crash anymore, watermark works but only on Pro mode not on regular mode, I think is related to your mods. Maybe you can take a better look on that.

Also Panorama works, I attached your latest module just for testing purposes, if you want to delete it just let me know and I'll delete it
[OnePlus 5 Themes, Apps, and Mods] DorianX:
Is working fine here... Check if you have any update for camera app if you have any uninstall it, uninstall the module and re-install it.

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
You sure you'll be using modded camera that way?
[OnePlus 5 Themes, Apps, and Mods] kristofpetho:
Confirmed, panorama works now this way! Excellent find!
[OnePlus 5 Themes, Apps, and Mods] iGamesMaximus:
Thaks?
[OnePlus 5 Themes, Apps, and Mods] venreddy:
Why I am not able to install this module using Magisk? Getting below error
[OnePlus 5 Themes, Apps, and Mods] cd993:
Hmm try flash via twrp or maybe redownload it?
[OnePlus 5 Themes, Apps, and Mods] Angel_Alonso:
How activate the portrait mode in a custom rom?
[OnePlus 5 Themes, Apps, and Mods] DorianX:
It's working here via magisk, maybe you have a bad download. I downloaded the file from my post thinking about a bad upload from my side but not the case is working

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] DorianX:
I don't think so... It's like when you update the app via playstore, the module will not work at all since the app in \data has priority over the app in \system\priv-app

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] smohanv:
Thanks. Everything works fine.

Version is 2.5.2 right? Just checking.

I booted to twrp and with the file manager I renamed both camera and camera services with bak (in system/priv-app folder) and flashed this zip in magisk. All is well.

I haven't checked image resolution. I believe it should be better than stock camera.
[OnePlus 5 Themes, Apps, and Mods] DorianX:
Actually you don't need to rename anything because the module "overwrite" that apps (like temporary, once you uninstall the module stock apps come back. Actually that's the advantage of Magisk)

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] smohanv:
Yes. I agree and I am aware of how magisk works. Because of many reported crashing, I just did this way to make it works better. It works fine and also watermark works too.

I can rename system apks whenever I want to revert to stock camera.
[OnePlus 5 Themes, Apps, and Mods] TidalWarrior:
Anyone else having trouble with the pro mode crashing instantly? I'm on the latest version and it happened with previous versions as well
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
It works!!!!
[OnePlus 5 Themes, Apps, and Mods] xerwud:
is this compatible now with oreo?
[OnePlus 5 Themes, Apps, and Mods] mele80:
It works....

Only "problem" is that every time after force close or if some battery saving app closes camera hdr needs to be enabled again. I don't remember that to happen with regular Oneplus camera.
[OnePlus 5 Themes, Apps, and Mods] smohanv:
I think most of the users here are running Oreo. I am running on stock Oreo (OB5).
[OnePlus 5 Themes, Apps, and Mods] g4seb:
Hi,

how do you install it on OP5T in Oreo ? Just put .apk and install it ? Or flash it with magisk ?

What is the best solution ?

Thanks
[OnePlus 5 Themes, Apps, and Mods] DorianX:
Did you read the first post? [emoji848] There's the installation process

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] g4seb:
Yes i read it. But in the thread, some people say it's impossible to install it with magisk, so we can take the .apk, put it in sdcard and install it...

So i install via Magisk, all is ok, the number of the ap is the same 2.5.23...

A last question, what do you want to say with "@txx1219 I made some progress on Watermark and Panorama issues, you need to put cameraapp\lib\arm64 folder into the module...."

Many thanks, great mod !!!
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
[MENTION=7381529]g4seb[/MENTION] do you see mod related settings in the camera app?
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
Tried this. Works perfect on my Op5t. Panorama is fine now as well. Thanks to u [MENTION=2185114]DorianX[/MENTION] and [MENTION=3578456]txx1219[/MENTION] for your hardwork. Will test and feedback if i find something interesting.
[OnePlus 5 Themes, Apps, and Mods] g4seb:
Hi [MENTION=5790246]VictorLapin[/MENTION] , The notched wheel ?? On the rear corner ?
[OnePlus 5 Themes, Apps, and Mods] dj_chapz:
Thanks for the mod, it really works great!

Is there any special reason why isnt this available in the official magisk repo? Otherwise I need to monitor this thread for updates...
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
open it and look for the mod related part
[OnePlus 5 Themes, Apps, and Mods] g4seb:
I réadaptation camera M 2018-02-12
[OnePlus 5 Themes, Apps, and Mods] FearEffects_Kaos:
Some Help, please!

Hi Folks! How are you doing? Could someone help me to install this mod? What should I do? My 5t is not rooted yet.
[OnePlus 5 Themes, Apps, and Mods] cd993:
Start here:

https://xdaforums.com/oneplus-5t/how-to/oneplus-5t-unlock-bootloader-flash-twrp-t3704592
[OnePlus 5 Themes, Apps, and Mods] DorianX:
Because if you use the one in the first post if you enable watermark the camera will crash and panorama will not work, just will take a single picture and I find the reason and I posted a fixed version.

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] katheria:
Need some help . Unlocked bootloader and install magisk booted now confused how to flash this camera mod .?
[OnePlus 5 Themes, Apps, and Mods] dqv69:
Hi I'm in Oreo version in my OnePlus 5. I have the 2.5.23 version of the camera App.

I've rooted my device and install Magisk. but i can't install the MOD app.

When i disable the original Camera App, and re-enable it, I'm not revert back to the factory version. So i think my factory version is 2.5.23. Then i try to install MOD with Magisk but it not replace the App. Is any one can help me ?

Thx.
[OnePlus 5 Themes, Apps, and Mods] Akhil15:
Just flash the downloaded zip file using magisk manager or twrp

---------- Post added at 08:47 AM ---------- Previous post was at 08:45 AM ----------

Just flash the downloaded zip file using magisk manager & reboot your phone ..
[OnePlus 5 Themes, Apps, and Mods] katheria:
Thanks got it working . If any new update then directly flash over this right ?
[OnePlus 5 Themes, Apps, and Mods] The_Steph:
Yes simply flash over it and you are good to go.
[OnePlus 5 Themes, Apps, and Mods] dqv69:
I'm sorry i think i miss some thing because it not working.

The camera App version stay at 2.5.23 :(
[OnePlus 5 Themes, Apps, and Mods] vineetjoseph:
Go to the settings menu of the camera and look for the mod date. If it says 12Feb then you should be ok .
[OnePlus 5 Themes, Apps, and Mods] dqv69:
I can't do that because the app is not installed.

I can only go to android setting => applications => Camera and see the 2.5.23 version
[OnePlus 5 Themes, Apps, and Mods] yupo72:
Go to Apps-Camera, disable and re-enable it and accept to remove all app updates, then go to Magisk-modules-tap the "plus" and install the mod previously downloaded on your phone.....reboot
[OnePlus 5 Themes, Apps, and Mods] dqv69:
I allready try, but it not working :

Previous post
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
Don't disable original camera app
[OnePlus 5 Themes, Apps, and Mods] ponkz:
Same here bro.. camera app is 2.5.23

But if u go to settings in camera app, it will down 12feb version.. its working
[OnePlus 5 Themes, Apps, and Mods] dqv69:
THX :)

I haven't seen the gear in the app when i scroll up.

It's ok now thx everyone.
[OnePlus 5 Themes, Apps, and Mods] vinz_uk80:
Thanks a lot for for the mod Dev :)

The module did not want to flash in Magisk, I had to flash it in TWRP.

Can't test it now, but I'm sure the results will be great, as always :D
[OnePlus 5 Themes, Apps, and Mods] smohanv:
If you update via play store then the updated app sits in data partition hence the new version will take priority over the mod version. You will not see the benefits of this mod.

I would suggest not to update unless the new version comes through OTA.
[OnePlus 5 Themes, Apps, and Mods] Kasinga:
Thank you, for your opinion. I found the time and played a bit with it and stood at 3. That's true FFC wasn't the big problem :D
[OnePlus 5 Themes, Apps, and Mods] L22EEW:
Flashed like a treat.

Many thanks.
[OnePlus 5 Themes, Apps, and Mods] bl3d2death:
Good for using this mod with Google cam?

If not which custom ROM cam works fine with?

Thx
[OnePlus 5 Themes, Apps, and Mods] Supersaiyan.IV:
Any planned changes for "Super Night Mode"? Huawei phones have this, but I don't see OP5 matching it with the "Professional" settings.
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
Pro settings are really great. What exactly u missing?
[OnePlus 5 Themes, Apps, and Mods] Supersaiyan.IV:
Adaptive per-frame ISO compensation, and intelligent exposure time. Both of these factors take time to manually determine in OP5's "Professional" settings. Meanwhile Huawei's "Super Night Mode" is adaptive enough to work out ISO/exposure-time in both dark, and light conditions. Especially in light conditions, where the images get a very natural HDR glow. Hopefully this explains it.
[OnePlus 5 Themes, Apps, and Mods] Hefko:
I am so happy with your mod!:) Tested it on lost dog , 2am during nighshift, low light condition, fast shots because dog didn't want to sit for a long time.
[OnePlus 5 Themes, Apps, and Mods] PrabhuN:
Damn cute.
[OnePlus 5 Themes, Apps, and Mods] persieghini:
Mail me that dog please?
[OnePlus 5 Themes, Apps, and Mods] mele80:
Does hdr works differently In this mod than original camera? Hdr keeps turning off when camera app gets killed and I almost every time forgot to turn it back on.

I don't remember how it was before this mod.
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
Thanks for explaining. Would like to see side by side compare.

Atleast for me as a photographer i found pro mode good. Since u have a bunch of stuff fully under control
[OnePlus 5 Themes, Apps, and Mods] tcat007:
Anyway to get gallery pop-up after talking a photo to open in gallery? I just get "no photo" on custom ROM. There's no setting for default gallery app. Also I don't have the rear camera beauty mode as I see in recent screenshots. Also pro mode crashes.
[OnePlus 5 Themes, Apps, and Mods] tcat007:
My latest.
[OnePlus 5 Themes, Apps, and Mods] zx2c4:
Could you release the source code you're using to build this? Not super comfortable running big blobs, and if I'm going to spend the time reverse engineering each of your releases, I might as well just replicate your work myself. In other words, I'd rather collaborate than be incentivised to compete.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
I don't have any source code you can't have. In fact you can easily get it by decompiling with apktool. I don't have more code than that.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
New update :

- New feature called "IntelligentHQ" : In good light situation, Oneplus Camera app tends to use a higher ISO than needed. In order to prevent this, when it's possible, I force-use the HQ mode to lower the ISO rate. The picture will be more detailed and with less noise thanks to low ISO. Only works in "No-HDR mode", which is the default mode.

- Sharpness decreased in really low-light situations to prevent oil-painted pictures

- Panorama mode should work now (thanks to [MENTION=2185114]DorianX[/MENTION])

I've been quite busy so updates are slower than usual. But I will continue with others updates don't worry about it.

Magisk module

If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app. To remove the update, go to App Info of Oneplus Camera and disable it. A prompt will ask you if you want to revert back to the factory version. Press yes. Re-enable after that.

Concerning people with non-OOS ROM, you have to understand it that Oneplus have included some proprietaries things who post-process picture in Camera 1 API. Oneplus Camera relies on it. I don't think custom ROM included it. I can't do nothing about it because it's concerning the ROM itself and not the app.

If you are not satisfied with the current result of the mod, please post the ORIGINAL picture in https://imgbb.com and explain what you think it should be better.
[OnePlus 5 Themes, Apps, and Mods] tcat007:
Does this install 2.5.22 (that what I'm seeing)?
[OnePlus 5 Themes, Apps, and Mods] ksclero:
Hi [MENTION=3578456]txx1219[/MENTION] thanks you so much for your hard work. One question: it is possible to have your mod as standalone app? To make possible use the mod and the original app toghethere? Compare the result of two app would be more easy...
[OnePlus 5 Themes, Apps, and Mods] Mackie Messer:
2.5.23 for me
[OnePlus 5 Themes, Apps, and Mods] txx1219:
The mod is based on version 2.5.22, so it install the version 2.5.22

No, not possible.
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Update base mod to 2.5.23 please

Update base mod to 2.5.23 please is better...and check the code of the application, there are several "Quality" and "quality" that are wrong, some are not set to 100 in jpg quality.

Thanks bro
[OnePlus 5 Themes, Apps, and Mods] txx1219:
No.
[OnePlus 5 Themes, Apps, and Mods] jayson19:
[MENTION=3578456]txx1219[/MENTION]

Thanks for your hard work. The Oneplus camera looks better than when I first got the phone. Still takes fantastic pictures after 2yrs in. Much appreciated.
[OnePlus 5 Themes, Apps, and Mods] moneyvirus:
Sorry for my dump question but I have a fresh installed Oreo 5.0.3 on my 5t camera app installed there is 2.5.23 I installed this awesome mod but when I watch the info about the app it still says 2.5.23 and not 2.5.22 do I benefit your mods or not?

Verstuurd vanaf mijn ONEPLUS A5010 met Tapatalk
[OnePlus 5 Themes, Apps, and Mods] mele80:
If you can change sharpness (top at settings page), then yes. Also it should say camera m xxxxxx at top
[OnePlus 5 Themes, Apps, and Mods] cd993:
Have you (or anyone) successfully been able to run both this mod and gcam (with magisk fix module) on Codename Phoenix?