yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] Helby:
1080@60fps doesn't work on 3T.

OIS works. HDR on front facing camera doesn't work as well.
[OnePlus 5 Themes, Apps, and Mods] mcg:
Just installed the latest 1-28 on the OP5T but the camera is taking really overexposed pictures in HDR mode. Not sure if it's a bug.
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
https://drive.google.com/folderview?id=10K6zpEgPzejPYJ8kdvNcdeKdoXMkYND8

here are some samples taken with camera mod and gcam in bright sunlight. op5 modded camera still seems to have that paint effect.please have a look at it
[OnePlus 5 Themes, Apps, and Mods] txx1219:
HDR is buggy, even in original version. Don't use it.

Looking at your samples, I don't see any paint effect in photos from Camera M. They are even more sharper than GCam. Could you explain me where do you see paint effect ?
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
the trees,soily ground..they all were lookin like a paint.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
I don't see any paint effect. I can't help you on this one.
[OnePlus 5 Themes, Apps, and Mods] mcg:
Thanks, I was using HDR in OOS 4.7.6 and it was working pretty amazingly, with really good details. Pictures were a bit noisy but were great. No "oil painting" effect, as claimed - was awesome.

Now after flashing to OmniROM 8.1 all camera software is giving me trouble. Pictures come out horrible noisy (ie. the old school colour noise)
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Custom ROM don't usually integrated all Oneplus picture process. That's why pictures are worst than in OOS.
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
Simply go back to OOS. The developer is working on improvements for a camera app designed for OOS. You cannot expect him to support you!
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
I think its important to point out the developers efforts have in the main been to fix some of the annoyances that would otherwise make the 5/5t a stellar camera experience. Most notably the watercolor effect that has plagued owners. The additional sharpness post process and enable/disable denoiser (one that doesnt bring back the paint effect) for mid ISO photos are also welcome additions. Along with his own observations to improve the overall picture profile these have been CRUCIAL changes that we should all thank him for, and it's a shame OP haven't acknowledged these issues themselves.

Everything else will be as OP provided.

I do not find HDR shots buggy or over exposed at all, the combination of multiple exposures do exactly as intended, images that pop and contain a wide colour profile. HDR by definition works best in good light with subjects of high contrast. Fgs do not expect HDR to work well for you in many cases including low light scenarios. Google HDR for examples and an explanation of HDR.

The HQ mode provided by OP is the best mode for capturing low light shots otherwise play with the photo mode with HDR off or even pro mode. The key takeaway is you have lots of choice!

Another thing worth a note is autofocus is a poor OP function. I rarely get focus by simply pointing the camera. Treat touch as your friend and if that fails to be satisfactory use pro mode and the manual focus wheel.

I've attached a few examples of my own efforts in HDR mode using this excellent mod.
[OnePlus 5 Themes, Apps, and Mods] fignon:
The op camera is pretty decent overall. However, in medium light conditions it is really disappointing. The quality jump in these conditions with this mod is impressive. So thank you very much and keep up the great work.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Thanks ! Will continue to update it to produce even better pictures !

Great photos by the way, they are exceptional !
[OnePlus 5 Themes, Apps, and Mods] jerkwad:
With the release of Beta 3 for OPT5 will you be in need of a copy of the two apks for version 5. 2.23 or can you simply extract them from the official zip? I just installed the latest beta and it looks like they went from 5.2.22 to 5.2.23.

Of course they did this..... Because i just got 5.2.22 where I liked it..... of course! LoL
[OnePlus 5 Themes, Apps, and Mods] mcg:
Thank you, it's been a while since I have gotten back to the flashing scene quite heavily, coming from the Pixel XL. Forgot a lot of key concepts lol.

You are right, the image processing is not as simple as having everything done on the app level... the ROM/firmware/etc. is critical as well.

Will probably consider going back to OOS 5.0 OB3
[OnePlus 5 Themes, Apps, and Mods] jackieku:
[MENTION=3578456]txx1219[/MENTION]

Thanks a lot. Works pretty fine here, but JPEG quality of 100 does not make much sense to me. Can I ask for a toggle to disable it?
[OnePlus 5 Themes, Apps, and Mods] haitower:
this is the camera mod m review/picture comparison i'm referring to: click here

no, i didn't call you liar or cheater. furthermore, please stop insulting me. your problem is that you are obviously not able to comprehend the english language properly or maybe you just want to discredit me for giving you negative feedback. you also quoted me wrong to make it look like you were right.

what i said:

how you wrongly quoted me:

when i say "FOR ME" this means that FOR ME the stock camera produces better pictures than your mod. if you leave out the "FOR ME" part you intentially want to make me look like a fraud. i guess you wanted to bring my short review into discredit because you can't handle negative feedback. not being able to take criticizm is not a good virtue for a dev btw.

see above. never said it was fraud, never was lacking manners.

i was comparing low light shots because the XDA article was comparing low light pictures as well and the mod looks way better than the stock camera here. that is why i wanted to show that FOR ME/FROM MY POINT OF VIEW/FOR WHEN I WAS TRYING IT OUT MYSELF (i hope you understand this time..) pictures on stock cam were way better.

furthermore i was also comparing pictures under normal light conditions where the stock cam again was superior. don't know why you didn't mention that..

wow, and YOU call ME mannerless.. how... ironic..

but don't worry, i will leave your thread. obviously you're not interested in your mod becoming better by people giving you hints under which conditions your mod could be improved. you just want the cheerboys, clapping and yaying towards you, you just want the good, positive feedback! but don't worry, i won't make you angry again. this is the first time i was insulted by a dev for trying to help. i won't waste my time with you anymore ;)
[OnePlus 5 Themes, Apps, and Mods] adwaitatre:
Does it support oneplus 3t
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Oh no, you wasn't trying helping. If you was, you would have posted some samples. You would have explained when this happened.

If you have readed the thread, you would have seen that there is few negative feedbacks. And do you think I answer them like I answer to you ? No. Because people didn't call me cheater/liar, have given samples and have explained when happened.

I hope for you I'm the first and last dev to "insult" you. You should remember now how to communicate in a respectful way.
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
Now I suggest that everyone just calm down...
[OnePlus 5 Themes, Apps, and Mods] txx1219:
I will update my OP5 to Beta 5, which should contains 5.2.23. But you can use the mod anyway. It doesn't depends on the original version installed.
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
The oilpainting effect?

[MENTION=3578456]txx1219[/MENTION] can you tell me whether you have disabled the paint effect "bug" for ALL photo modes front & back (assuming it was applied to front cam)?

The reason I ask is because i've been playing quite a bit with the OP portrait mode. I think there's an improvement in picture quality in the mid ISO range in this mode, so i'd like to know if this is just me imagining this or whether your changes have found their way into the other modes?

It would be nice to know the paint bug has gone forever no matter what mode you put the camera software in.

Portrait mode is actually pretty darn cool and does seem to edge detect all sorts of objects really well in very good light to medium light. I've been getting some very pleasing results in this mode, but was it really worth sacrificing the telephoto lens for? For me personally, I would rather OP have stuck with the telephoto on the OP5 with maybe a better aperture and the same sensor from the main cam.

I'm not sure if that would bump the cost of the device, but maybe OP will have a change of heart and put the tele back in the OP6 but with OIS this time :)
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
A couple of image samples...
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Is watermark option working good with this mod??
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Currently, I disable only on Photo mode (= Auto mode). I don't think I will disable it in Pro mode because Pro mode works in a weird way : denoise is on, but pictures comes less processed than auto mode. In portrait mode, pictures are taken with second lens, who doesn't have a agressive noise reduction. That's why there is no such paint effect in Portrait mode. I will see for Panorama mode if I disable the denoiser too.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
New update :

- Sharpness increased in some bright-light situations

- Sharpness decreased in mid-light and low-light situations to mitigate "oil-painting" effect and others weirderies caused by Oneplus noise reduction. Pictures should be now more "natural", even with Oneplus noise reduction on.

- Renaming of the switch in Settings because it caused confusion concerning the light situation. I added a subtitle which explains how and when it works. I STRONGLY ADVISE YOU TO NOT ENABLE THIS SWITCH.

Magisk module

If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app. To remove the update, go to App Info of Oneplus Camera and disable it. A prompt will ask you if you want to revert back to the factory version. Press yes. Re-enable after that.

Concerning people with non-OOS ROM, you have to understand it that Oneplus have included some proprietaries things who post-process picture in Camera 1 API. Oneplus Camera relies on it. I don't think custom ROM included it. I can't do nothing about it because it's concerning the ROM itself and not the app.

If you are not satisfied with the current result of the mod, please post the ORIGINAL picture in https://imgbb.com and explain what you think it should be better.
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
Ok that's good to know, I guess that portrait mode was always pretty good then! This mode uses both cameras simultaneously, the secondary camera image is used (and scaled to 15.9mp) to provide the blurred background. It's how they've managed to do it in hardware with less software trickery required to make it work reliably, google's software portrait mode is kinda ok in its own right though.

As explained in the previous post, I don't think it warranted removal of the OP5 telephoto lens as it's still quite a gimmick that's only useful in a small number of shots vs an optical 2x-ish zoom which is far more useful.
[OnePlus 5 Themes, Apps, and Mods] mNiosu:
The final, stable, OO 5.0.2 Oreo build is already out for 5 and 5T.

Switching to stable migh wipe your data though.

So the new 5.2.23 camera must be final.

Have you studied the new app. Does it bring some new improvements?

Is it worth porting your mod to this version?

Thank you for the great work by the way!

Had no FC since you switched to 5.2.22 and got some great shots with the 26th and 28th versions. Also panorama works if you uninstall the system app and install your modded one as user app.

I can't upload photos now as I'm on holiday and also can't seem to be able to restore the default camera from Titanium Backup to make comparison photos...

Thanks again!
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
Thanks for keeping us updated with the mod bro. You are awesome. I would like to test the latest version, however could you please let me know if it is ok to go back to the 28Jan version in case I find it better than the latest version? Can i just flash the 28th Jan version over the 31Jan version in Magisk in case? Iam so happy with the 28Jan version. Thanks a lot for your help.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
[deleted]
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Yes you can. Don't hesitate to tell me which version do you prefer and why after you have tested the latest.
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
Here are my samples from the 28Jan version. Low light pictures come out really nice with with good details and sharpness. Bright images are without a doubt awesome with the increased jpeg quality.

https://ibb.co/kg7fzR

https://ibb.co/nhxBpR

https://ibb.co/mw78m6

https://ibb.co/kc2pb6

https://ibb.co/bzCNw6

When people come into night shots, the oil painting effect kicks in a bit more. The below one is iso 6400, may be coz of that. I hope you can figure out a way to push a bit more details into these kinda pics. This is one area I noticed which has room for improvement for Camera M mod.

https://ibb.co/kYiQYm

I am overall happy with the mod and will be testing the 30Jan version as well.

Thanks a lot to you.

Cheers

D
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Attaching the pics for comparison of camera M mod(31-1-18) and Google camera .although stock camera has improved with this mod but Google cam has more sharpness in low light pics

Rom- OOS 5.0.2
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
Thanks mate. Flashing the 31Jan version now. Will get back to you tomo with my opinion and some samples.

[Update] Just flashed the 31Jan version. I can see the change of date and the midlight noise reduction disable option in the cam settings ui. The cam version in settings > apps > version is shown as 2.5.22.

I will be back after some testing.

Update2 :

Sorry, curiosity makes me sleepless. Below initial comparisons after flashing 31Jan version.

1. Auto HDR with Disable Noise Reduction Option ON. This seems to be better overall, although details are slightly lost.

https://ibb.co/e5AZtm

2. HQ mode with Disable Noise Reduction Option ON. I find this more sharp and detailed. However noise is higher.

https://ibb.co/bZYXeR

3. Auto HDR mode with Disable Noise Reduction Option OFF. This seems blurry and details are lost. The watercolor effect is visible.

https://ibb.co/hdVdKR

Goodnight. See you tomorrow. ?
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Agree with your observations.more comparison shots :
[OnePlus 5 Themes, Apps, and Mods] VoxiBe:
I've a fixe black screen after installation in the launch or the app, (last version of this mod 30/01) , nothing work. (Before too), any solution ?

OnePlus 5 - Phoenix rom last build - FK r22
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
This may not work well with custom roms. It has been mentioned in the thread. Checkout Post #609.

Cheers

D
[OnePlus 5 Themes, Apps, and Mods] txx1219:
This is a mistake made by be to let the noise reduction be disabled in such low-light situation. But I think I will let it be disabled after that. Picture are sharp but a bit noisy. So people could use it if they want.

Thank you for your tests ! By the way I recommand to not use HQ mode in low-light, you will have too much noise for no such big difference in sharpness.
[OnePlus 5 Themes, Apps, and Mods] jbmatson:
Yeah, leave the option in there. People might prefer the sharpness and choose to do their own noise reduction in another application.
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
Sure bro. I was just playing with the settings to see how it affects the picture. In my opinion the noisy image is fine as long as it is not too noisy. The aggressive noise reduction also reduces the sharpness which i find not so good. May be you can leave it in the settings for us to choose so that we can test it out and feedback to you to further improve the mod.
[OnePlus 5 Themes, Apps, and Mods] HydroX7:
The photos taken in good lighting conditions seem a bit undersaturated on the last version with the main camera (f1. 7). The saturation is perfect on the zoom lens (f2.6).

Edit: Inside a room, with average lighting conditions, the saturation is perfect.

Anyone else noticing this?

Pics: https://imgur.com/a/MOXJI
[OnePlus 5 Themes, Apps, and Mods] jesper801:
First of all, thank you so much for your mod, it's amazing!

I only have one little problem (I don't think anyone mentioned it here)

When I zoom in I see some blurry parts in my picture.

Normal picture:

https://photos.app.goo.gl/74RHzDUQjk84QdAE3

Cropped picture:

https://photos.app.goo.gl/suYFcn8DKd7k5DDC3

Am I the only one facing this problem?
[OnePlus 5 Themes, Apps, and Mods] HydroX7:
Is your lens (the outer glass) dirty? This exact thing happened to me because the lens was dirty.
[OnePlus 5 Themes, Apps, and Mods] jesper801:
Nope it's not dirty, I also don't have this problem with the gcam mod ?
[OnePlus 5 Themes, Apps, and Mods] AndroidGX:
Nope, you're not alone, I had the same problem on a previous version of the mod :good: and my lens was perfectly clean before the shot, maybe a post process problem? anyway seems not appearing everytime.
[OnePlus 5 Themes, Apps, and Mods] timartinhof:
Motion

Does motion picture work in this one?
[OnePlus 5 Themes, Apps, and Mods] jesper801:
So you don't have this problem with the most recent version?
[OnePlus 5 Themes, Apps, and Mods] postall:
Please share stock camera app andvcamera service from oos 5.0.2.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Which picture seems you more color accurate ? the one from primary or second lens ?

This is a post-process thing from Oneplus. They apply a "blurry filter" on moving object like trees in windy weather. I can't disable it.
[OnePlus 5 Themes, Apps, and Mods] jesper801:
Thanks for your answer! Is it me or is that quite useless? ?
[OnePlus 5 Themes, Apps, and Mods] AndroidGX:
I just take few shots today, I will check them tonight to see and stay you tuned :good:

Where its strange is that in my shot there wasn't any wind and it was just a very classic building with perfect blue sky, very simple shot without any tree (will try to find it if you're interested) :good:
[OnePlus 5 Themes, Apps, and Mods] HydroX7:
The primary lens feels a bit under saturated while the secondary one feels a bit over saturated.

If it's possible, it would be great to increase the saturation a bit for the primary lens. Another thing, that would be even better, is to add some controls in the settings menu, so we can control the saturation ourselves.

Thanks in advance.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
The camera will become too complicated and it seems kind of useless for me because I think color are really great currently. But I will consider your idea anyway.
[OnePlus 5 Themes, Apps, and Mods] HydroX7:
That's all I'm asking. Thank you!
[OnePlus 5 Themes, Apps, and Mods] Gruber008:
Does anyone have an issue with crashing on front facing camera (occurs 8 out of 10 times)?

The screen just goes black for a second and then it closes the app and not saving the image.

Every version was working perfectly fine until this one.
[OnePlus 5 Themes, Apps, and Mods] Goutham Ganesh:
when zoomed inz the LED display in the pictures get blurry lines, what could be the reason? using the latest update, OB 3.

thanks in advance :)

https://ibb.co/n3DtPR

https://ibb.co/j5BxjR

https://ibb.co/cZ07jR

edit: I got my answer.
[OnePlus 5 Themes, Apps, and Mods] TONGEXHISPEED:
Version 2018/01/31 work with oneplus 5 oos cam 2.5.23 ?????

Somebody tell me.

Thank
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
Should work. I am using magisk version.
[OnePlus 5 Themes, Apps, and Mods] TONGEXHISPEED:
When i need go back original i remove module ????
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Yes
[OnePlus 5 Themes, Apps, and Mods] Lelikus:
On 4pda.ru the solution for the panorama and watermark work is found:

1. Install the application Camera.apk from OOS5.0.2, give it all the permissions and wait until it starts.

2. Install the module from the first post in Magiks Manager

3. Reboot

Testing was performed on the ROM Codename Phoenix.
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
[MENTION=3578456]txx1219[/MENTION] I've spent the weekend playing around with your latest build. My own observations are as follows...

1. Your new colour profile for HDR agreed is more natural but to the point where I can barely see any visual difference between HDR on and HDR off. The two are now almost identical and for this reason i've gone back to your previous build.

2. I disagree with your label suggesting turning off the desnoiser in mid ISO ranges makes awful pictures. In the previous version even with HDR on in many situations I've found it to produce superior photos. It's not until you reach close to 3000 ISO that you get awful chroma noise with HDR on ONLY. With HDR off, the photos still come out very well in very low light situations and when it's too much HQ mode provides a final chance.

I've also been playing with snap camera pro, open camera, snap camera from a op3 rom (available as download) and GCMod5 v1.7. All seemed pretty dire and found to give very mixed results, except GCMod5 v1.7. Past attempts to get the [MENTION=4860033]Arnova8G2[/MENTION] mod working proved a bit of a failure. But since rooting OB3, I found the app. suddenly sprung in to life.

I don't really know if you've played with it much but the HDR+ and HDR+ superior modes are pretty incredible in the full range of light scenarios. It's still a little buggy, but has since become a lot more useable than it was in the past. Maybe you could speak to [MENTION=4860033]Arnova8G2[/MENTION] and see if there's any possibility of sharing some knowledge?
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
I think the only thing gcam lacks is touch to focus ,other than that it outshines OOS camera in every aspect
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
Do u mind to share ur settings for gcam please?
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
Yes I agree, details are very good, its far less crash prone and HDR seems to work in low light scenarios too which came as a surprise. I can get touch to focus to work ok, but it's slow. You have to wait a few seconds between touches.

Front cam crashes though :(

And the strange white dots issue which I think has all plagued 5/5t users makes some shots unuseable. So there's still a way to go.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Yes the HDR mode is not applied in last versions, I will correct this soon.

Concerning HDR+, it's impossible for me to do something about it.
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
Ahh I did wonder what had happened to the HDR mode! lol I'll await your next version with interest.

I wouldnt worry too much, I still get more consistent results from your app. and it doesn't crash in any mode. GCMod may never work fully on my beloved 5t
[OnePlus 5 Themes, Apps, and Mods] vineetjoseph:
+1 absolutely love your mod. GCam is brilliant most of the time but it is inconsistent. 70% of the time I need a quick point and shoot with consistent results, and I get it with this mode. HDR+ would be a game changer. Best wishes OP
[OnePlus 5 Themes, Apps, and Mods] kristofpetho:
Hi [MENTION=3578456]txx1219[/MENTION], thanks for all you are doing with this, pictures are MUCH nicer with your mod on my 5t!

One question: is there a way to also have 100% jpeg quality on portrait shots?

Thank you
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Link to post please.

No working for me :(
[OnePlus 5 Themes, Apps, and Mods] Lelikus:
http://4pda.ru/forum/index.php?showtopic=827982&view=findpost&p=70006989
[OnePlus 5 Themes, Apps, and Mods] observingi:
I am on OOS 5.0.2 and rooted, camera app ver 2.5.23. When I disable camera app, I don't get a prompt to rollback to factory version. Should I go ahead and install the Magisk module, in such a case?