yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] emma_spl:
How can know if i have the mod installed on my op5t?....i flashed in twrp spark but i dont understand if its ok :eek:
[OnePlus 5 Themes, Apps, and Mods] Stupifier:
I just have this Mod running fine along with GCam5.1.018-Arnova8G2-V1.4.apk. no issues
[OnePlus 5 Themes, Apps, and Mods] Freddyfre:
Works with 5T?

What a difference between OnePlus Camera Modded and OnePlus Camera Modded Magisk
[OnePlus 5 Themes, Apps, and Mods] itseasy21:
Magisk is installer zip for users rooted using Magisk, for all other users you can flash the OnePlus Camera Modded zip in twrp direct
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
anyone can provide some photos with the camera mod?
[OnePlus 5 Themes, Apps, and Mods] Need4Sneed:
In bird culture, asking about 'bird culture' is considered a **** move.

:)

The answer to your question is . . . .

. . Watch Rick & Morty!!

While were on the subject of bird culture, my all-time favorite Bird Person quote(s) is/are:

Morty: "What is this? What am I eating? Is this bird seed?"

Bird Person: "It is random debris, I found it in my carpet; I don't know what humans eat"

Tammy: "You know what THIS human eats . . "

Bird Person: "Don't be gross Tammy"

And a close second:

"Morty, you appear to be dying. I will make efforts to prevent this, but can promise nothing"

Thank you for this amazing mod by the way!!! Working great on my OnePlus 5!!!

:)
[OnePlus 5 Themes, Apps, and Mods] limon93:
Hi [MENTION=3578456]txx1219[/MENTION], sorry for late response, i understand the HAL question but take a look at this comparision, two picture in the same light condition:

https://prnt.sc/hlj6ax

One taken with your modded apk, one with google cam. I really don't know if google cam ha some sort of harware acces to the sensor, sorry if i am annoying you.

I expressed myself badly, I wanted to know if it was possible to disable this paint like effect (some users called it Van Gogh effect).

I managed to decompile apk by myself but i cannot code in smali, anyway i searched every possible reference to functions with names related to filters and i found a refence to a "paint" effect (search for "paint" string to found it inside the code). There is also a blur function but i think it's related to the bokeh (portrait) effect.

Another thing, there is a profile for no hdr, auto hdr and hq shot modes (hq is indicated in the code as "clear shot"), can you see if this Van Gogh effect is somehow related to these profiles? HQ mode seems to lower a little bit this frustrating effect (may be a subjective thing).
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Google Camera Modded shoots in RAW and process by himself the RAW photo : this is why you get dots pattern in photos taken by GCam because Camera2API RAW is buggy. Because RAW is an unprocessed image, Google Camera keep all the details compared to Oneplus Camera who shoots in JPEG and get directly a post-processed image (by HAL). You can't change this because the post-processing is included in HAL and not in the Oneplus Camera apk.
[OnePlus 5 Themes, Apps, and Mods] cesc777:
Can you tell me do these raw implementations come with OS or. Bundled with camera apk
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Don't know exactly, but there is in : system/lib64 and system/vendor/lib64 in .so file.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Update : now based on new version 2.5.12
[OnePlus 5 Themes, Apps, and Mods] limon93:
Look here:

https://github.com/MoKee/android_device_oneplus_cheeseburger/blob/mkn-mr1/proprietary-files.txt
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
I really like it, but sometimes closes when do a selfie. I have hope and i'll install when be stable. Thanks for Magisk support!
[OnePlus 5 Themes, Apps, and Mods] Asv97:
The version is still 2.5.11
[OnePlus 5 Themes, Apps, and Mods] limon93:
[MENTION=3578456]txx1219[/MENTION]

https://github.com/OnePlusOSS/android_hardware_qcom_camera/tree/oneplus/QC8998_N_7.1
[OnePlus 5 Themes, Apps, and Mods] igoorsoouza:
Latest magisk version doesn't work. After installing and restarting the phonr, the name changes to com.oneplus.camera.OPCameraOperation, and crashes when you try opening it. Old magisk version was working fine...
[OnePlus 5 Themes, Apps, and Mods] Dieppy:
For me magisk version works as it should
[OnePlus 5 Themes, Apps, and Mods] igoorsoouza:
That is how it looks after I install the new magisk version. I'm on Oreo Open Beta 1.
[OnePlus 5 Themes, Apps, and Mods] Dieppy:
I'm on ob1 too but everything is fine, so I don't think is magisk fault
[OnePlus 5 Themes, Apps, and Mods] Best008:
I cant see the setting of jpeg quality in my stock camera app .. anyone help !
[OnePlus 5 Themes, Apps, and Mods] wasjapupkin:
Because this option isn't there. Why should you see it?
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
Did you installed it via Magisk Manager or via TWRP ? I'm getting that error myself too in OP5 OB1...
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
Latest version provides very good photos, I guess "IntelligentHQ" is a thing :) Many thanks [MENTION=3578456]txx1219[/MENTION]
[OnePlus 5 Themes, Apps, and Mods] txx1219:
New quick update :

- Quick fix concerning the new feature "IntelligentHQ". It should work more consistently now.

Magisk module
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
please post some low light and night photos...
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
I'm not that much of a photographer, my main concern was the "van Gogh effect"
[OnePlus 5 Themes, Apps, and Mods] cd993:
Just to confirm, does main and selfie cam portrait work, along with touch to focus?
[OnePlus 5 Themes, Apps, and Mods] drummerboy46:
[MENTION=3578456]txx1219[/MENTION] Can you explain what (if anything) your new HQ mode will do on a 5t once it engages the second sensor/lens. I'm pretty sure I'm getting significantly better shots when the lux drops lower than 10.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
IntelligentHQ is never triggered in low light
[OnePlus 5 Themes, Apps, and Mods] tcat007:
Any way to get gallery to show up within app on custom ROM? Just says "no photo".
[OnePlus 5 Themes, Apps, and Mods] liver20:
Then... For install this camera... Only have to uninstall oneplus original camera and after flash magisk module and reboot

Right?

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] tinuz97:
Read op, answer in there.
[OnePlus 5 Themes, Apps, and Mods] livsey:
Hey. Something I'm confused. In what mode should I take pictures to see improvements?NoHdr?
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Default settings
[OnePlus 5 Themes, Apps, and Mods] liver20:
And.... Works in op5t?

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
Do you also Install Magisk ?

check camera setting and see if you have the the First setting like this
[OnePlus 5 Themes, Apps, and Mods] whatnoww:
AutoHDR on by default.

When I delete the app data, AutoHDR is on by default when getting back into the app.
[OnePlus 5 Themes, Apps, and Mods] dunjamon:
I've installed it and the camera app shows the correct version...but in Magisk Modules it's still showing 2018-02-21.
[OnePlus 5 Themes, Apps, and Mods] jkyoho:
same here, just checked moddule.pop in zip file, OP forgot update version# on line 3&4 :D

Not a bit deal
[OnePlus 5 Themes, Apps, and Mods] szulolo79:
Hi. Can anyone please advise what is the difference between the HQ and hdr-off mode? Thank you
[OnePlus 5 Themes, Apps, and Mods] farbeyondoverkill:
I can't give much of an overly technical explanation, but from what I understand here's the difference:

HDR-off in this mod applies the custom post-process the OP has developed (much thanks btw ?). I assume this was the best way to implement it, as it was a huge improvement on past versions where it was generally recommended to use auto-HDR.

HQ mode from what I understand is OnePlus' own noise reduction mode that's best for low light (from what they recommend). It sometimes gives better results, but sometimes it isn't noticeable. In rare cases it's worse but that doesn't happen often. Personally, if you use the telephoto lens zoom a lot like I do, HQ mode is fantastic for making very zoomed-in photos look significantly cleaner than no-HDR. Most of the time this works great, other times it doesn't make a difference. It's all on a case by case basis.

TL;DR - NoHDR applies the custom post process and is the mode you should use for most situations. If you experience more noise, are in a low light situation or need extra clarity for zoomed-in photos, use HQ. Honestly, don't bother with AutoHDR or HDR, they do more harm than good on this mod as of now.
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
So, this iHQ, is already sety or I have to do it manually? Is there a difference, if I use the HQ option? IHQ is for better results in low light shots?
[OnePlus 5 Themes, Apps, and Mods] gunyz:
Hi

I am using M mod on 5T OB3 and the 02-12 version works better than 02-22 version.

Indeed I've noticed (it might be subjective but I think the 02-12 is more reliable)

-face unlock in mid-light low-light is definitely taking more time to identify me and sometimes it doesn't even recognize me

-front cam is worse in mid-light low-light (seriously it's terrible, I compared with the stock cam, and the stock actually does a better job which is kinda odd LUL)

-in good light situations, the M cam is undeniably better than gcam and its horrible dot pattern (even the colors are more realistic) and I really enjoy the M mod for that. Pictures are very detailed and colors are amazing THANKS

-But when it comes to low light ... huh (sadFace) unfortunately the gcam does a better job in sharpness and details, and even colors.

-panorama doesn't work (for both versions but I don't use that mode so I don't really care)

If you guys want pictures I can share my experience :)

I want to mention that I really enjoy your work as the stock cam is really dogsh*t and thanks to your work we can have a decent cam on a 500€ phone :) I am just giving feedback.

Regards

EDIT : OMG I actually made a mistake I meant the 02-12 vs the 02-22 and the not 02-21 vs 02-22.

Corrected it
[OnePlus 5 Themes, Apps, and Mods] rehannali:
Does this camera mod work for OnePlus 5t?
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
It should and if it doesn't, simply uninstall the module
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Yes.
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
In my opinion the 31-1 build is still the best for overall quality because you have the option to completely disable the denoiser. The latest build is trying to mitigate the denoiser by applying sharpening and when you zoom in, you can see details are really soft, but also jagged due to the additional post sharpening. In general I would say that the one plus denoise mechanism in all but the lowest light situations is a pretty nasty thing. I've found a chrominance and/or luminance noisy picture to be more detailed and better quality than one that attempts to remove the noise.

I think it's important to remind people that a denoiser is a pretty standard feature on smart phone cameras. Even my Samsung S8 will denoise photos but for whatever reason the OnePlus algorithms are far too aggressive hence the strange watercolor effect.

I think the developer might be better to stop trying to fix a fundamentally broken denoise mechanism and look at other ways to improve picture quality.
[OnePlus 5 Themes, Apps, and Mods] gunyz:
Yes it does and it's a very good mod to replace the stock trash cam
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Share 02-12 and 31-1 version please...
[OnePlus 5 Themes, Apps, and Mods] purpleman2k:
Second that. Can anyone share the 31-1 version please? I just hate the denoise filter that's being applied to every picture. If it's completely off on the 31-1 version - I want that.
[OnePlus 5 Themes, Apps, and Mods] gunyz:
I'll try to do this tomorrow or in 2 days

And I meant the 02-12 not 21, I just made mistake. Edited the post
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Deleted
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Face unlock can't be affected by my mod because I only do change in the Oneplus Camera app.

I don't have made change concerning front camera since before 02-12, have you change the Front Camera sharpness in parameters ? This could be why you noticed changes.

Thank you for your feedback by the way.

I completely understand your point. However, I can't agree that noisy picture from 31.01 build was more detailed than now, because in this version I applied a too low level of sharpness to hide the noise and by this way I was reducing the amount of details from the picture. Believe me I have tried all options possible concerning this :

- By default => Too much sharpening, pictures looks like a big oil-painting thing

- Disable the denoiser and lowering the sharpness (= 31.01 build) => Picture was really bad in term of details

- Lowering the level of denoiser => Pictures too noisy and details was lost because of the low amount of sharpness I have to apply to lower the noise

- By default and lowering the sharpness => Best solution here, pictures are good in term of details and the oil-painting effect is almost gone in many situations

I try to compare often pictures taken by my mod with pictures taken by iPhone 8/X and Galaxy S8 and I can see that the current result are really close to them. GCam Mod in low light is sometimes really magic and sometimes really weird with pictures been too blurry.
[OnePlus 5 Themes, Apps, and Mods] timescaming:
I've got the 01-31 version, not the 02-12 one tho:

https://mega.nz/#!95Fm1SIA!YoUFtJyQYQjslMYwSJVxQ_SyAuvW5BWjf32heeMRfqI
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
[MENTION=3578456]txx1219[/MENTION]

If I dont like this mod, just unnistalling it and all will be as default?
[OnePlus 5 Themes, Apps, and Mods] gunyz:
Yes .... I did change the Front Camera sharpness I've set it to 3 :rolleyes: . This definitely could explain why I've noticed changes in Face Unlock mechanism.

Yes Gcam is really good in low light but the dot pattern is sometimes really annoying and very noticeable. BUT portrait shots are amazing

I wonder if you can change the portrait mode too on the M mod, it would be great.

Thanks for keeping your mod updated ;)

Just uninstall via magisk and all good
[OnePlus 5 Themes, Apps, and Mods] Im_Mattgame:
If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app. To remove the update, go to App Info of Oneplus Camera and disable it. A prompt will ask you if you want to revert back to the factory version. Press yes. Re-enable after that.

There's an easier way, go into the App Info and press the tree dots in the top right and press "Uninstall Updates"
[OnePlus 5 Themes, Apps, and Mods] Hefko:
Possibility to add flashlight toggle to portrait mode?
[OnePlus 5 Themes, Apps, and Mods] jesper801:
That would be awesome!
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Is there a difference using HQ?
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
Try and tell us :)
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Tried, but, looks the same...

---------- Post added at 10:46 AM ---------- Previous post was at 10:34 AM ----------

When I should use default mode "nohdr" and HQ mode?
[OnePlus 5 Themes, Apps, and Mods] tobby88:
Is it possible to use this Mod to get OOS-camera on LineageOS 15.1? Can I just flash it or am I missing some libraries if I do it like that?
[OnePlus 5 Themes, Apps, and Mods] TheCondorITA:
I tried now but it gave me error:

Skipping digest...

Update process ended with ERROR: 1

Error installing zip file '/sdcard/Download.....

i tried with latest and with 31/01 zip files. Thanks
[OnePlus 5 Themes, Apps, and Mods] DumF0rGaming:
HQ is a doctor recipe in low-light situations
[OnePlus 5 Themes, Apps, and Mods] cd993:
+1

Im on Codename Phoenix and would LOVE to have the option of using this and gcam though supposedly they don't play nicely at all.

Would really appreciate if someone could advise how this could be possible, if even at all. I can install OOS cam but the image zooms in and out by itself, so therefore unstable
[OnePlus 5 Themes, Apps, and Mods] Stupifier:
Mmmm.....Not really sure what to say. I'm on CodeName Phoenix as well and this Mod works fine. I can also use Gcam no problem. Literally all I did was install the OnePlus Camera (2.5.20) from APK Mirror then install this Magisk Module. For Gcam, I think I just installed GCam5.1.018-Arnova8G2-V1.4.apk. Again, no issues with either on the latest CodeName Phoenix (from dev Telegram posts). Good luck
[OnePlus 5 Themes, Apps, and Mods] VictorLapin:
OT Long time no see :)
[OnePlus 5 Themes, Apps, and Mods] cd993:
This brings hope!

For the gcam (sorry if this is off topic for this thread, but hopefully this could help others too), did you need to install the front portrait fix? Or to ask another question, is the gcam fully working (touch to focus, main and selfie cam portrait mode)?
[OnePlus 5 Themes, Apps, and Mods] Stupifier:
Gcam touch to focus doesn't work. I did not fully test it. I just know I can take great HDR photos with it...that's it. For everything else, I use this camera mod. Touch to focus and portrait mode works on this mod. Again, didn't test much else.
[OnePlus 5 Themes, Apps, and Mods] SM@SH3R:
How did you get this mod working on CNP? Could you please explain? Would be of much help. Thanks
[OnePlus 5 Themes, Apps, and Mods] Stupifier:
Umm...I told you what I did in the post. Read it again.
[OnePlus 5 Themes, Apps, and Mods] farbeyondoverkill:
Go onto APK mirror and install the OnePlus Camera APK v2.5.20. Once the APK is installed, install the Camera M module in Magisk and reboot. If you see the front camera sharpness settings in the OOS camera settings, that means it was flashed successfully and is working.

Speaking of... Anyone tried this on crDroid? Only other custom ROM with OOS cam support to my knowledge.
[OnePlus 5 Themes, Apps, and Mods] creeve4:
I did, it works.
[OnePlus 5 Themes, Apps, and Mods] SM@SH3R:
Wanted to know if you had installed the apk as a system app first. Thanks anyways

---------- Post added at 04:20 AM ---------- Previous post was at 04:14 AM ----------

Did you install it as a system app? Does it have to be this version in particular? Because I installed 2.5.21 as a normal app and then went on to open the camera apps to see if they were working but it was only a black screen on both the cases. Thanks for replying :)

Edit: it's now working. Thanks again
[OnePlus 5 Themes, Apps, and Mods] SM@SH3R:
Resolution for Portrait mode pictures are too low apparently. Can this be fixed, [MENTION=3578456]txx1219[/MENTION]?
[OnePlus 5 Themes, Apps, and Mods] Stupifier:
Just install it as a normal app (not system app)......Pretty sure that is how I did it a while back. Try that first. And if that doesn't work, just uninstall and try it as a System App. Easy enough to try both and see what works. Trial and Error.
[OnePlus 5 Themes, Apps, and Mods] whatnoww:
Hey [MENTION=3578456]txx1219[/MENTION] , when I reset the data with the mod enabled, AutoHDR seems to be on by default when opening the camera app.

Is this normal? and should I be changing the mode to noHDR manually?
[OnePlus 5 Themes, Apps, and Mods] saurabhmaurya70:
Plz be fixed.. This.. Want portrait with quality

I have same question
[OnePlus 5 Themes, Apps, and Mods] txx1219:
How resolution do you have ?
[OnePlus 5 Themes, Apps, and Mods] saurabhmaurya70:
Please hepl dev....

Means with your mod the picture quality increase high and super sharp but in portrait mode pictures remins same and poor quality and pictures size only 3-4 mb.. And when we try to zoom in then goes to blury..
[OnePlus 5 Themes, Apps, and Mods] cnsngr:
Edlt: I fixed with uninstalling magisk and re installing
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
with the mod size 6mbs :/
[OnePlus 5 Themes, Apps, and Mods] Pastitsio:
New OnePlus Camera https://www.apkmirror.com/apk/oneplus-ltd/oneplus-camera/oneplus-camera-2-5-23-release/

[MENTION=3578456]txx1219[/MENTION]
[OnePlus 5 Themes, Apps, and Mods] Youtube_Ll0r3nt3:
Lel, For weeks I warned of this, but said that the new version had no differences, although it would be nice to update the base of the mod
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
So what i did

Upgraded xxx from 9.8 to 9.9 . From some reason M mod 2as not there. I flashed thru magisk. Rebooted and i still dont have sharpnes option. Version is 2.5.2

So i did the following, revert to factory for camera. Removed modul and rebooted. Installed M version via magisk. Rebooted. Still not there. Magisk says installed.

Any advice?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Im using this mod with 2.5.23 for 1 month and everything is working as it should be.

---------- Post added at 10:53 AM ---------- Previous post was at 10:51 AM ----------

Try to uninstall and reinstall magisk or camera app.
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
Tried camera app. No change. Still sharpnes missing.

How to uninstall magisk withou breaking anything?

Also i tried to install. Via twrp no change
[OnePlus 5 Themes, Apps, and Mods] Pastitsio:
How do you use this version for a month? I never got a notification to update the camera from play store

Sent from my OnePlus 5T using Crapatalk
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Portait mode takes pictures with the second camera lens, which doesn't have an aggressive process like the first one. Photos are blurry because this camera lens are only good in good light, in midlight and low-light, it lose details unfortunately. I have tried to improve it, but It's a kinda special process which, doesn't why, fails when I try to apply my modification. I decide to not touch it because of it.

I will not update the mod at version 2.5.23 because it have no difference with 2.5.22 except the version number lol.

You don't use the 2.5.23. In fact, you could have the 2.5.23 version install before, but you have the 2.5.22 because magisk module replace entirely the original app by my modded app.
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Open beta 5
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Its showing 2.5.23
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
Do i need to have 2.5.2 prior to inatalling mod? Or shpuld work with 2.5.23?

Sine i am dealing with some strange behavior. Installing module via magisk not changing app to M version. Installing via recovery changing it. But after another restart its back to stock ? i tried remove whole magisk with all modules. Installing it from scratch. No change. I spent couple hrs with this yesterday. About 15 restarts.

Any idea why?

I appreciate it.
[OnePlus 5 Themes, Apps, and Mods] wahing:
i think the problem was with the rom itself. i was on 9.9 and try to install some of magisk module but no one working. i revert to 9.8 and everything back to normal.
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
reverted back to 9.8. still the same. I tried to uninstall clear data for MM; even uninstall MM. upgrade or downgrade magisk 15.3 \ 16; still cant install any modules.
[OnePlus 5 Themes, Apps, and Mods] johnnyman25:
Is it possible to install this in stock 5.0.4 rom without root?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
No. Next time, read op mate. This is a magisk module, so...
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Mate, what I can say to you is that Im using ob5 with 2.5.23 and this module and everything is working as should be.
[OnePlus 5 Themes, Apps, and Mods] Adrian312:
After restar and reverting to 9.8 of xxx. Everything is fine as it was. Very strange.

But i am happy for now ?
[OnePlus 5 Themes, Apps, and Mods] Tiago A:
Great
[OnePlus 5 Themes, Apps, and Mods] Seferi:
I'm on LineageOS 15.1 and just installed the mod, everything works but I'm not seeing portrait mode. Is this normal? Thanks.
[OnePlus 5 Themes, Apps, and Mods] tobby88:
Same here...

Also photos with flashlight aren't working.
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
It's normal