yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
Doh funny how quickly you forget.

---------- Post added at 06:22 PM ---------- Previous post was at 05:49 PM ----------

Hey, been looking back at some of my S8+ hdr shots and was pleasantly surprised that the denoiser employed can be just as patchy as the OP camera denoiser. Massive over softening and loss of details.

I'm also becoming more and more impressed with the HQ mode in low light situations it's really rather clever and has given me some very pleasing results.

Also I took some dusk shots which pushed the ISO to around 800 and chroma noise really kicks in here with not the best of shots.

I've got so many photos I need to send you. I just don't get a lot of time, demanding wife, young family lol. I'll try and get them to you asap
[OnePlus 5 Themes, Apps, and Mods] creeve4:
[MENTION=3578456]txx1219[/MENTION] do you mind sharing what file you are modifying to increase the jpeg quality to 100?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
That's why I really hesitate to use Oneplus denoiser when ISO reach 800 and more.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
New update :

- Based on original version 2.5.22

- Fix for selfie pictures at 4MP (thanks for the report !)

Magisk module

If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app. To remove the update, go to App Info of Oneplus Camera and disable it. A prompt will ask you if you want to revert back to the factory version. Press yes. Re-enable after that.

Concerning people with non-OOS ROM, you have to understand it that Oneplus have included some proprietaries things who post-process picture in Camera 1 API. Oneplus Camera relies on it. I don't think custom ROM included it. I can't do nothing about it because it's concerning the ROM itself and not the app.

If you are not satisfied with the current result of the mod, please post the ORIGINAL picture in https://imgbb.com and explain what you think it should be better.
[OnePlus 5 Themes, Apps, and Mods] miodzicho:
Just tried to update to recent version, and its saying I should use magisk 15.0+, but I'm on 15.3
[OnePlus 5 Themes, Apps, and Mods] shadowstep:
Thanks for the update! Just thought you should know -- Portrait Mode is working fine for me on Codename Phoenix (Android 8.1 Custom ROM). The most recent update's changelog (of the ROM) mentioned that commits to enable Portrait Mode have been added to the ROM. :)
[OnePlus 5 Themes, Apps, and Mods] mariotme:
[MENTION=3578456]txx1219[/MENTION] is it normal for the camera app version to show 2.5.20 after installing 2.5.22?

Thanks for your hard work
[OnePlus 5 Themes, Apps, and Mods] farbeyondoverkill:
+1, I've also tried uninstalling the mod via magisk, rebooting, clearing cata & cache, disabling & reenabling the stock app, flashing mod again and rebooting.

I know at least the post-processing is being applied because I see the option for front camera sharpness in settings. I too am confused as to why the version says 2.5.20 instead of 2.5.22.

If it helps, I'm on xXx ROM v9.5 with Franco Kernel v20.
[OnePlus 5 Themes, Apps, and Mods] Rishi Sridhar:
Flashed the module. Camera app is force closing. OP5T OOS 4.7.6 nougat 7.1.1 stock.

Grabbed a logcat.

Thanks for your work!
[OnePlus 5 Themes, Apps, and Mods] walkwitmeinhel:
Why video camera is so much zommed?
[OnePlus 5 Themes, Apps, and Mods] batwingnz:
Hadn't heard of zommed before, must be a OnePlus thing:
[OnePlus 5 Themes, Apps, and Mods] Nimic3792:
Hi, it was working flawlessly on camera version 2.5.20. Then I installed the 2.5.21 through apk, and now the mod doesn't work, although in Magisk it seems correctly installed.

I tried also with older versions but still not working.

Problem is that I can't manually reverse to 2.5.20, I always get an error message. Tried also with Titanium backup but the installed version remains the 2.5.21.

I could uninstall the camera app and then reinstall the 2.5.20, but being it a system app, I'm afraid to make a mess.

Any suggestion?
[OnePlus 5 Themes, Apps, and Mods] amitporedi007:
After the last update of 26th jan

still the images of camera m mod is little less clear than gcam app on op5

Will attach images
[OnePlus 5 Themes, Apps, and Mods] axiel7:
No problems here
[OnePlus 5 Themes, Apps, and Mods] mariotme:
That's very weird man!
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
Because of EIS
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
To me it says 2.5.2... Weird? :confused:
[OnePlus 5 Themes, Apps, and Mods] cd993:
That's what mine says too! But the system info of the app says 2.5.2.2 so must be OK..?!
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
Yeah, mine too ?
[OnePlus 5 Themes, Apps, and Mods] dunjamon:
Mine still shows 2.5.20 and the panoramic doesn't work. ☹️

edit...read the OP :eek:
[OnePlus 5 Themes, Apps, and Mods] Bl1zZ87:
Mine still shows 2.5.20 too
[OnePlus 5 Themes, Apps, and Mods] saccentekennedy:
[MENTION=3578456]txx1219[/MENTION] Really brilliant work on this mod. Thank you very much.

I was wondering... Do you think it might be possible to modify at what lux the 5T switches to it's secondary camera for low light shots?
[OnePlus 5 Themes, Apps, and Mods] cd993:
+1 - interesting idea, would be curious to see if the other camera could be used more!
[OnePlus 5 Themes, Apps, and Mods] TONGEXHISPEED:
Please give me 2.5.22 link apk!
[OnePlus 5 Themes, Apps, and Mods] vineetjoseph:
Agree... That's a brilliant idea... Once the phone decides to switch to the secondary camera, the pictures do come out very good (low light) if somehow the cameras could be flipped? :D:)
[OnePlus 5 Themes, Apps, and Mods] axiel7:
Camera app shows 2.5.2X

System shows 2.5.22
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Not possible
[OnePlus 5 Themes, Apps, and Mods] mariotme:
That's after installing OnePlusCameraM_2018-01-26.zip using magisk 15.3
[OnePlus 5 Themes, Apps, and Mods] Eagle-no1:
Yes it is the latest version of 2.5.22
[OnePlus 5 Themes, Apps, and Mods] iRhyiku:
What is that watermark? Lmao
[OnePlus 5 Themes, Apps, and Mods] Eagle-no1:
My Nick and Adobe Photoshop :angel:
[OnePlus 5 Themes, Apps, and Mods] dego_:
Same here
[OnePlus 5 Themes, Apps, and Mods] batwingnz:
For those of use on .20 and not seeing a version string can we have clarification that the mod now based on .22 is updating the app without updating the version string? Clearly the mod is installing fine as I've seen difference between versions.
[OnePlus 5 Themes, Apps, and Mods] tcat007:
I show. 22. I'm on 5t, custom ROM (DU). Still using gcam though since OOS has issues on custom ROMs.
[OnePlus 5 Themes, Apps, and Mods] mariotme:
Would be highly appreciated if OP could comment on why some people have 2.5.20 showing after installing 2.5.22.

Phone is OP5 running OOS 5.0.1 magisk 15.3
[OnePlus 5 Themes, Apps, and Mods] txx1219:
There is nothing to say. If you have installed the last magisk zip, you have the latest version as simple as that.
[OnePlus 5 Themes, Apps, and Mods] batwingnz:
One liner in the OP to tell people not to get hung up on version numbers to preclude people asking?
[OnePlus 5 Themes, Apps, and Mods] Andmeego:
Its very simple if u want to force use the secondary cam on oneplus 5t...just cover the primary cam lens :laugh:
[OnePlus 5 Themes, Apps, and Mods] txx1219:
New update :

- Noise reduction enabled by default in pictures with ISO between 800 and 3000 (was already by default when ISO was upper than 3000)

- Added a switch to disable noise reduction in low light (ISO between 800 and 3000). Not possible to disable when ISO is upper than 3000 because is really ugly without noise reduction.

- Name of the version is included now in Settings to avoid confusion

Magisk module

If you have installed an update of Oneplus Camera before, you have to understand that the update is "above" the original system application. Because my mod replace the original system application, you will never see a difference because the current app will be the updated app and not the system app. To remove the update, go to App Info of Oneplus Camera and disable it. A prompt will ask you if you want to revert back to the factory version. Press yes. Re-enable after that.

Concerning people with non-OOS ROM, you have to understand it that Oneplus have included some proprietaries things who post-process picture in Camera 1 API. Oneplus Camera relies on it. I don't think custom ROM included it. I can't do nothing about it because it's concerning the ROM itself and not the app.

If you are not satisfied with the current result of the mod, please post the ORIGINAL picture in https://imgbb.com and explain what you think it should be better.
[OnePlus 5 Themes, Apps, and Mods] Stupifier:
Just wanted to give an update (saw someone already he me to the punch)

With the most recent Codename Phoenix update, The OnePlus Camera and this Mod work great. This camera is replacing Gcam5 for me.

Thanks
[OnePlus 5 Themes, Apps, and Mods] tcat007:
On DU this mod doesn't work at all. Kind of a haze over pictures. I didn't expect it to work, but be nice if some camera guru figured out how to add the secret sauce. Going to give Phoenix a try.
[OnePlus 5 Themes, Apps, and Mods] farbeyondoverkill:
Are you on OB4? Because that may/may not have something to do with it, but then again what do I know *shrug*
[OnePlus 5 Themes, Apps, and Mods] saurabhmaurya70:
Working very well..

NYC job bro
[OnePlus 5 Themes, Apps, and Mods] cd993:
Looking great to me :)
[OnePlus 5 Themes, Apps, and Mods] habylab:
Where have people got the 2.5.22 camera from? I can't see it on apkmirror.
[OnePlus 5 Themes, Apps, and Mods] Meepowski:
[MENTION=3578456]txx1219[/MENTION] thanks for your hard work, the mod is awesome, one suggestion that I have, could you start adding the last update date to this threads title so we don't have to check every post to see if the mod was updated? Thanks!
[OnePlus 5 Themes, Apps, and Mods] saccentekennedy:
[MENTION=3578456]txx1219[/MENTION] Just a question about the CameraServices apk included in the Magisk mod. Have you altered the stock version? I'm one of the people installing you mod after manually uninstalling my 5t's camera apk in Priv-App. I'm then manually installing your modded OnePlus Camera app. Do I need to also install your version of CameraServices?
[OnePlus 5 Themes, Apps, and Mods] dego_:
Sorry if it's a stupid question. I didn't deal much with Magisk modules before. I have the previous Camera M version installed already. How do I update it? Can I just flash latest version over the old one via Magisk?
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
Don't get me wrong, this mod is awesome, but still panorama is not working (it does a single shot and nothing more). Am I doing something wrong or is it just the mod?
[OnePlus 5 Themes, Apps, and Mods] wasjapupkin:
Check the first post: "bugs known"
[OnePlus 5 Themes, Apps, and Mods] IlD4nX:
Gosh, I didn't notice it... Thanks
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
A big thanks for this. Rooted my Oneplus 5T just to flash this. Totally worth it.

I have been playing around with the Modded Cam(Version Dated 28th Jan) for couple of hours and the results are really noticeable compared to stock cam. Haven't had any force close issue until now. I am super happy and hope you continue to work on it and enhance it. :)
[OnePlus 5 Themes, Apps, and Mods] drummerboy99:
I've finally loaded up the latest version. Absolutely loving the new settings, it's great to have the choice. I can confirm the app is no longer force closing. This may me because the app now matches the service as I only installed the camera APK before.

The panorama is fine, selfie camera is now 15.9mp. Just the watermark not working in photo mode.

Fabulous. I have the camera (and app) I expected from this phone now. Getting some great shots.

Just a few more betas from oneplus and my 5t will be perfect!

Keep up with the build changes if you can.

Many thanks
[OnePlus 5 Themes, Apps, and Mods] jerkwad:
Sent you a donation. This mod works perfectly. Thanks for your hard work and updates! Keep it coming!
[OnePlus 5 Themes, Apps, and Mods] dego_:
Mate, your work deserves more that hitting 'thanks' button.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Massive thank you for your donation ! Yes I will continue to provide you updates !! I will include your name in the OP.
[OnePlus 5 Themes, Apps, and Mods] farbeyondoverkill:
Yeah with magisk modules just flash the update over the old one. It's kinda like a dirty flash. Super simple to keep everything up to date ?
[OnePlus 5 Themes, Apps, and Mods] jcroy2828:
Does panorama not work for anyone else? Stock app or this? Granted the one plus pano mode is awful compared to googles.
[OnePlus 5 Themes, Apps, and Mods] prologikus:
By op camera with mod (28.1.2018)

By google camera

First, I respect the developer of this app.

In many(or all) cases this mod beats normal op camera but why google camera hdr is so damn good? (excepting the dots bug)

Edit: g cam seems to be so close to perfection but this dots bug destroy everythings, what is the reason that this bug cannot be solved? Theoretical explanation?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Could you try the same picture but with the switch "Disable noise reduction in low light" enabled ?
[OnePlus 5 Themes, Apps, and Mods] Stupifier:
What ROM are you using?
[OnePlus 5 Themes, Apps, and Mods] deepuvijay:
Panorama doesn't work for me either, but it isn't a big deal as I never use it much. I hope our awesome dev here will find a way to fix it, when the time comes. ;).

Can't thank Mr. txx1219 enough. Such a fantastic mod :)
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Have you taken this picture by disabling noise reduction in low light or by enabling it??
[OnePlus 5 Themes, Apps, and Mods] prologikus:
Stock oxigen 4.7.6 rooted

I'll try to replicate the test and do a noise reduction disabled photo too
[OnePlus 5 Themes, Apps, and Mods] aneesh12:
mannnnn, you are fab. oneplus should pay you to improve their app this much. the photos are as good as gcam,sometimes i feel like they came better than the photos from gcam. gcam still does low light photography better, gcam photos in low light still blurry though,but it captures more details as compared to your mod.
[OnePlus 5 Themes, Apps, and Mods] cd993:
I took the picture just with stock settings - I don't appear to have octave a noise reduction setting??
[OnePlus 5 Themes, Apps, and Mods] yelov:
I don't see any difference between this mod and stock camera app. Only the front facing camera sharpness is making a difference. The rear camera produces identical photos with this mod vs stock I think.

http://ibb.co/kYBu1w - stock

http://ibb.co/c1zQ8b - camera M mod

I just took a few photos in bright daylight and the processing reminds me of Samsung. Way oversharpened and still oilpainty. I don't know. The comparisons you posted look really good, but I just don't have the same experience.

And even if I disable noise reduction, I still don't see any more noise than stock, even though a lot of people here complain about the noise. What's going on?
[OnePlus 5 Themes, Apps, and Mods] chrisch91:
My eis seems to be disactivated since the mod? I record wirh 1080p, 60fps.
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
Its there in the settings menu of camera app,
[OnePlus 5 Themes, Apps, and Mods] cd993:
Ahh I has missed the latest update, and so just updated and got that setting :)

How are people finding this, better to enable or disable this setting?
[OnePlus 5 Themes, Apps, and Mods] anujyadava:
As I have installed this mod today itself ,so will check low light images in the evening
[OnePlus 5 Themes, Apps, and Mods] msoniz:
The camera app starts crashing when watermark is enabled from settings. Please look into it.
[OnePlus 5 Themes, Apps, and Mods] ALPHAWolf96:
Please look into the OP..
[OnePlus 5 Themes, Apps, and Mods] msoniz:
OP?
[OnePlus 5 Themes, Apps, and Mods] ALPHAWolf96:
Original post. The bug is already mentioned over there. A friendly reminder to read the OP atleast once before installing any mod on your phone.
[OnePlus 5 Themes, Apps, and Mods] Wechy77:
Original Post (first post)

Sent from my OnePlus5
[OnePlus 5 Themes, Apps, and Mods] msoniz:
Oops... Missed it... Will take care :) thank you
[OnePlus 5 Themes, Apps, and Mods] cd993:
Same!
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
1080p 60fps mode havent EIS
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Even if you disable the noise reduction in low light, your picture is a "extremely low-light" situation. So you will see nothing changes because I use always the noise reduction when ISO is under 3200.

The switch in Settings is for pictures with ISO between 800 and 3000. Situation like this are indoor pictures, sunset situation, etc..

I will rename the switch to "Disable noise reduction in mid-light" to avoid confusion.

Low light pictures will always be better in GCam if you activated HDR+ Enhanced. I will try improve it but promise nothing.

I put the two pictures side by side to show you the massive difference : https://i.cubeupload.com/593B9L.jpg

You can see the oil-painted effect in stock picture, strenghen by the too much sharpness applied by Oneplus. In the picture taken by my mod, pictures seems more natural because colors are not oil-painted and sharpness is soft. It seems much more real than the original picture.

I didn't edit anything, I just added labels. I will add your picture in the Comparison section if you don't mind.
[OnePlus 5 Themes, Apps, and Mods] prologikus:
hi again, i made some comparations and i think there is something wrong with my stock camera, 2.5.17 because i can't see much of a difference between it and modded. what i see is a big difference compared to gcam, which as you can see in the #3 comparation photo, have more pixels too.

Here is the full album containing the comparation photo and the original photos too.

https://ibb.co/nOunOm

https://ibb.co/m4crim

https://ibb.co/dUg3UR

https://ibb.co/daccpR

https://ibb.co/mCfmim

https://ibb.co/myw93m

https://ibb.co/ctGbim

https://ibb.co/n3kV9R

https://ibb.co/hfEe3m

https://ibb.co/kjtdw6

https://ibb.co/mg8p3m

https://ibb.co/iWoNOm
[OnePlus 5 Themes, Apps, and Mods] txx1219:
In middle/low-light pictures (ISO between 800 and 3000), you will see really minimal difference if you not enable the switch "Disable the noise reduction in low-light". If you enable it, you will have a less oil-painted pictures but softer than original.

Thanks for your comparison #3 btw, I will increase sharpness for this bright-light situation.
[OnePlus 5 Themes, Apps, and Mods] prologikus:
No problem man, i can test your beta versions too if you want.

Look at the first comparation, when i took it my gf said how come the preview is better then the photo taked.

So why does this happend ?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
It's normal. In preview, you didn't see the noise reduction applied. Try to take the same picture but enable the switch "disable noise reduction in low-light". You will normally less or no difference between preview and picture.
[OnePlus 5 Themes, Apps, and Mods] chrisch91:
[/COLOR]

So in what mode do i have eis?
[OnePlus 5 Themes, Apps, and Mods] rockafellor:
720p, 1080p and 4k
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Could you take another picture with the mod in this position ? https://ibb.co/n3kV9R

Because if you see this post : https://xdaforums.com/oneplus-5/the...ity-to-100-t3714595/post75370162#post75370162, you will see a comparison between stock and mod. The sharpness in the picture from mod is not so blurry as yours and this is weird because they share a similar light situation.

I think the picture came out too blurry. I have spend time to improve various light situation and this one was ok in my test. If you really could take the same picture one more time with the mod in this position, it will help me figured out why it's too blurry.
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
I have version Magisk 14.5
[OnePlus 5 Themes, Apps, and Mods] shah_allstyle:
Flash the magisk one on oreo, but camera still v2.5.7
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Old link, try again please
[OnePlus 5 Themes, Apps, and Mods] AasimAmor:
Can this modded to work as a different app with original oneplus camera app with a different package name??(for unrooted users)

Will it work it out?I did try changing the package name on your mod apk and other did some modification , though it successfully installed as a different app but forceclosed.
[OnePlus 5 Themes, Apps, and Mods] Saiger:
can anyone check their oos cam version ? mine still shows 4.5.7 and not 2.5.11 (magisk version)
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
work fine. 2.5.11 with camera mod magisk
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
magisk cam mod
[OnePlus 5 Themes, Apps, and Mods] icemantogy:
Can u share font ?
[OnePlus 5 Themes, Apps, and Mods] shah_allstyle:
Still same bro.. Btw which link you refer to? Did I need to delete the current mod from magisk?
[OnePlus 5 Themes, Apps, and Mods] Aarju:
PLZZ provide the link of 2.5.11 mod
[OnePlus 5 Themes, Apps, and Mods] berezker:
600 euros?

where did you buy this phone?

you can get it pretty much for under 400 euro now
[OnePlus 5 Themes, Apps, and Mods] andrexp31:
Wrong thread... Sorry guys.
[OnePlus 5 Themes, Apps, and Mods] yohouse2:
Do i have to flash this, or can i directly install the apk from the zip?

I have stock recovery, and my bootloader is still locked, is it even possible to flash it as is?
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
it will not work for you! you need to have a root and your own recovery.
[OnePlus 5 Themes, Apps, and Mods] yohouse2:
Not even simply unzipping the file and installing the apk through package installer?
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
not
[OnePlus 5 Themes, Apps, and Mods] itseasy21:
It shows version 2.5.1 after update :/ but in settings 2.5.11

PS : it works great
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
It is necessary to ask a developer to install the update. There is confusion and disorientation
[OnePlus 5 Themes, Apps, and Mods] bassgenerator:
down.
[OnePlus 5 Themes, Apps, and Mods] nikhil007mmus:
Can you rename the package not the same as the OP camera app so that it installs as a different app all together even without root ?
[OnePlus 5 Themes, Apps, and Mods] JAlvarezFlores:
All video modes except slow motion (I think) and 1080p 60fps.
[OnePlus 5 Themes, Apps, and Mods] prologikus:
Today i can't but i'll redo the comparation, maybe that photo wasn't focused like it should, i was surprised too.

I did another very low light comparation (without gcam)

The results are strange.. very little to no difference, maybe op camera v2.5.17 have some tweaks too... or maybe the image processing still remains the same even if i disable the magisk module& reboot, I checked op camera settings to see if there is any evidence of the mod (while taking the original op camera shot) and there was not, once i activated the magisk module i knew that it was activated since i have the 2 options for sharpness and noise reduction.

Also, i see no difference between On and off states of "disable noise reduction in low light".

comp1 with second camera (hi res img):

link: https://ibb.co/i2rq9R

direct link: https:// image.ibb.co/n13gG6/comp1.jpg

comp2 with main camera (hi res img):

link: https://ibb.co/naXf9R

direct link: https:// image.ibb.co/eORkb6/comp2.jpg

all links:

https://ibb.co/fWNcOm

https://ibb.co/htXiw6

https://ibb.co/gtpA9R

https://ibb.co/foKow6

https://ibb.co/i2rq9R

https://ibb.co/nBTgG6

https://ibb.co/naXf9R

https://ibb.co/i2rq9R
[OnePlus 5 Themes, Apps, and Mods] txx1219:
At this level of light (ISO 9600), I rely on the noise reduction from Oneplus. The switch in Settings change nothing at this level of light because without noise reduction, it will be very noisy in such extremely low-light situation. The only changes you can see comparing original vs mine, it's I have increased slightly sharpness to get a bit much details but it's really minimal difference.