yashsingh1/xdaforums huggingface dataset:
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Chaplan:
Minority report:

Just found sending emojis via SMS (stock app, tested on other apps also) isn't working for me.

I can send them but the other party receives an empty message.

I have tested this on the previous build, so the new font stuff merged on the latest has nothing to do with it.

I have tested this with my SIM on a kenzo running the latest oficial OMNI and have the exact same issue.

Now the funny but not so funny part, using another SIM from another service provider works on both mentioned devices with OMNI, the emoji is sent and arrives at destiny.

Trying to debug it on my end I tested my SIM on my Nexus 5, android 7.1.1 and works as intended.

I then tested my SIM on Dumpling again with OOS and Lineage and both work also, emojis are sent and received.

I then decided to check OOS apn settings and it's a match, not a single divergence with OMNI.

With such esoteric results I decided to share them here.

Everything was tested on supported setups, no root, stock everything aside from gapps (nano package which was also used across LOS for testing).

Log attached, the process of sending an emoji via SMS to myself was the main workflow for testing and log grabbing, although the thingy which I refrain of calling a bug was found having a conversation via SMS with another person on another device over the same service provider as mine.

Every other IM I use be it WhatsApp, Hangouts... have no such issue, only sms.

I already bugged my service provider (Vodafone PT) and they are clueless.

Everything is setup as it should on their end for my number.

[MENTION=4683552]maxwen[/MENTION], if you blacklisted my SIM somehow on OMNI knowing upfront I would find such a finicky minudence eventually, raising immediately my OCD sky high... rest assured, war is ON... after I'm done with Valium! :eek:

Now truly, any light on this matter is highly appreciated, I tried to nail all variables, in the end it's either something rather simple I overlooked, or nothing at all, I'm clueless here because it simply makes no sense to work on every other setup aside from my go to daily driver ROM.

Hopes lay low I must say.

[emoji place holder in the name of all the undelivered ones, rest them in piece(s) on the ethereal world of unwired telecoms]
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
Can not reproduce

Try with a always happy clean flash
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
Works fine here... And I cant remember we have a black sms app
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Chaplan:
HAHAHA ???????

Log is white, from a clean flash.

I had made 3 clean flashes already between testing the other setups mentioned, all happy ones till the part of no go emojis.

Even then I was reluctant of bringing it up on OMNIs thread.

Log is from one of the clean flashes but doesn't add much, SS is clearly not, yet representative.

The fact another sevice operator doens't show the same behaviour also troubles me, I shared that.

Further investigating it I found similar reports on a Nexus 5X (assuming the user is stock) dating back to 2016 with the same hiccup on the same service operator.

https://support.google.com/nexus/forum/AAAANseOu18SAKP99rYRe8/?hl=en

The latest answer although technically inaccurate might shead some light on the matter.

I would be more than happy if something could be done to overcome this on the ROM side, but since it's not easy to reproduce I will leave it to that.

You can ping me anytime if something comes up, I'll be on OMNI still. ?

Thanks for your time guys, loved the sms, testitos time, whatever that means. :confused:
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] JackSparrow17:
Deleted
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] dratif:
How? Im unable to grant permission to substratum to modify system settings!!!
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] JackSparrow17:
Oh sorry my bad, I was on CNP wen i changed the fonts through Substratum.:crying:
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] chaostan:
What best custom kernel for Omni rom?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] 75markus:
use inbuilt - it´s custom made from omni team and works great :p
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] xocomaox:
I can say it's a very good, solid kernel.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] MrPepperino:
Singularity Kernel with alucard gov is the way to go
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] chaostan:
What the diff between this rom and treskmod omni?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] kylothow:
Uhm... Ask on the other's ROM thread? This is official Omni, nothing more nothing less.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] nobse:
Since the 20180415 build, the fonts on the lockscreen (date and alarm clock) and the font of the numbers when entering the unlock pin have changed (I realized this on both, my 3T and 5T). Was that intended?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
You have before and after screenshots please?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] nobse:
The first two screenshots (09:08) are from the 20180415 build, and the last two screenshots (09:12) after downgrading to the 20180408 build.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] :
My favourite rom so far, smooth, stable, clean, pretty.

Doesn't stutters, animates without hassle, thanks devs for this awesome rom.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Kanczyn:
This ROM is built on Cyanogenmod?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
There is no Cyanogenmod anymore

---------- Post added at 01:30 AM ---------- Previous post was at 01:14 AM ----------

I only see a small diff in color
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] nobse:
Nope, the fonts have definitely changed. The font displaying the date below the clock is thinner, the font with the PIN numbers is wider.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] dcillusions77:
Makes it easier to see
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] nobse:
The date is now _harder_ to see.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
Thats all?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Chaplan:
Looks like AOSP and Vodafone PT somehow aren't working well together.

PIXEL users on stock ROM are having this exact same issue, this is dating back to the Nexus 6.

GSM-7 encoding is as high as it goes on this setup, rending not only emojis as blank but also some other characters like accentuated a (á) as such.

Bottom line, OMNI isn't at fault here, it has the same behaviour as AOSP on my network.

Not that I ever pointed the finger at OMNI truth be told.

Keep up guys, "flashy" news also on the next build by the looks of it. Nice.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
better?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] :
Interesting lock screen message
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] CroW_D:
In every build i used i get those random ui stutters/Lage and they dissapear when I am reboot the device or lock the screen and turn it on again depends on how bad the stutters are. I am also using aod may that's the reason . anybody else has this ?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] rori~:
That's a quite popular language like java, python, ruby, fickn...
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] :
ah
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] nobse:
That looks like the old behaviour. I was just asking because I wasn't sure if the change was intended, or if it was an accident when adding the new font stuff.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
Well yes - the default should not have been changed ofc

Guess they simple did not notice that. So you can call it accident if you like

---------- Post added at 02:07 PM ---------- Previous post was at 02:05 PM ----------

LOOL
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] DocRambone:
Latest weekly is flawless, even more snappy and fluid. The fastest rom for 5T. Thanks!
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] dcillusions77:
[MENTION=3479861]darkobas[/MENTION] ,

Any chance for centered clock on status bar?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] no.one.writeme:
Hi [MENTION=3479861]darkobas[/MENTION], [MENTION=4683552]maxwen[/MENTION],

I'm currently on OB4 firmware. Is it ok to flash 5.1.0 stable firmware?

Thanks you for your time,

Best regards.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] sytayeth:
They just told me in the telegram group that the 5.0.1 firmware was the recommended
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
No1.even knows if theres any thing different in last.firmwares. yet.everyone makes a fuss about which.version to be on.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] marko94:
Latest build working for me on OB6 :) so , I think every fw will work
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
no chance
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] xocomaox:
You can mod it yourself.

https://xdaforums.com/nexus-6p/themes-apps/mod-center-left-clock-o-t3614824
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] SamsungAdmire:
hi guys I'm new to flashing roms on this device. Why do I have to flash OB3 firmware instead of keeping my OOS stable 5.1? I'm willing to do it but I'd like to know why. Should I just follow the instructions in the OP or are there any new ones
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] yung40oz84:
Lol, that's so true, OnePlus users only ones even say anything about updating some firmware ??
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] tweeny80:
It was often mentioned in N6P forums with each version upgrade, also way back during my Note 4 days.

Firmware has been a topic for long time, i think because custom ROMs don't include those files so we pay attention when Google/Samsung/ whoever updates then.

Also some ROM authors specifically state & recommend this or that firmware ... so of course users notice and ask questions
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bdwilk:
I agree with tweeny, and when the wrong firmware can break sensors and sometimes cause a ROM not to boot then it's a significant piece of the puzzle to keep up to date.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Xokoz:
Oh Note 4 times.. Damn those bootloaders & modems :D BOB4 ftw
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] tweeny80:
And so many model numbers! Sammy udated what seemed like totally random models in random counrries. I think they had one model for each neighborhood in my town.

But that phone had it all....removable battery, IR blaster, sd card, looks .... Damn i forget why i sold it
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] pemaga12:
i have a problem, when i recieve a phone call nothing appears at my screen. The phone sounds but there´s no info about the call.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Mugetzsu:
I noticed when I'm going to make the video full screen on youtube the app goes force closed. Even on other streaming sites. Does anyone knows what causes this problem?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] janis_dschi:
- Ambient Display and AoD is very Dark. Maybe you can fix it in next build :)

- long press recents action: please add option for no action
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] ichbinsauch:
Hello, can you please install the option for the date and the clock in the middle. Thank you
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
Everything u want will be in 'next build'

Thanx.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] sytayeth:
I've been reading your messages for 2 or 3 years and now I don't know if this message it's full of irony or not.

If I'll have to make a bet I'll say it's irony.

Please don't kill me. I'm Spanish and I just woke up from my siesta. :svetius::laugh:
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Ch3lly:
Always on display moving position?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
U r boring
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] sytayeth:
I want a notch for next build.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] :
Why not just like that ?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
Sure. Wait for next build
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] filjusz:
x-D
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] sytayeth:
You are great!!!
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] xocomaox:
I am on the latest build (cleanly flashed) and have noticed that T-Mobile WiFi Calling works fine, except after reboot. I can get it working again simply by going back into settings and disabling WiFi Calling and then enabling it again.

Kind of strange, but I do have some Magisk mods like YouTube, Stereo Sound and OnePlus Camera M installed. I am not sure if those would conflict, but I still need to do more testing.

Has anyone else see this behavior with WiFi Calling?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] knapz:
Were you able to get the dual sim and MMS issue fixed?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] DrGreem:
Can someone please tell me why OmniRom doesn't support Magisk and etc..?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bmwkeith:
Magisk works fine, just don't report problems to the dev if you root or if you run unencrypted.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] samtab37:
When i install Gcam from Arnova8G2, app crash

---------- Post added at 22:15 ---------- Previous post was at 21:48 ----------

And there are a option to enable a vibration when i change of mode on slider ?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] lockekey:
Gcam works fine for me on Omni
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] musiqlives:
Is there a way to edit the quick settings layout? In system or otherwise? Amount of tiles, rows, remove labels, etc?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] doof.w:
Pull down the shade, tap the pencil icon under the tiles, and tap the 3 dots in the top right.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] xocomaox:
When I slide to Vibrate Only, it vibrates. When I slide to Alarms Only, it does not vibrate (because vibration is disabled in that mode).
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
Slider is a physical button and has its own physical feedback. No physical button has a vibrate feedback. Only brain dead people would do that
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] samtab37:
When I flash Stock Opengapps (with gcam from Google) I can't use gcam (any version), with Full Opengapps (so without Gcam from Google) no problem.

---------- Post added at 08:14 ---------- Previous post was at 08:13 ----------

Is not my problem [emoji4], I want to have a little vibration when I change of mode, like OOS do it

---------- Post added at 08:19 ---------- Previous post was at 08:14 ----------

The slider is as quite different from other physical buttons ... the fact of being able to have a vibration indicates that we have changed mode. It is not for nothing that OnePlus puts a vibration when we change mode .
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
BRAIN DEAD

First sentence already proves it.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] samtab37:
I don't understand, physical feedback and vibration feedback is the same or not ? I just want to have the same thing like OOS ?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] musiqlives:
Dude! Thank you! This is now officially the BEST ROM EVER! I have to ask... Can anyone tell me how is it that with this rom, charging works as well as DASH with stock OOS? I've tried 6 other rom's with no dice!
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
Ofc it does
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] :
Still wandering around Omni, because it's the fastest without setups.

American magic ?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Chaplan:
Mixed with a few other cultures I guess. ?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Ch3lly:
Does stereo sound mod work?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] B0hrer:
Does Omnirom have the Smart Pixels Feature?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] darkobas:
No. Theres plenty of play store apps for such crap.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bdwilk:
Kinda have to agree about the crap part. I tried it for 2 full battery cycles on another ROM and after the first cycle I saw no difference and after the second cycle I believe my battery was worse. Plus I had to deal with lower screen brightness and worse screen resolution while I used it. Crap "feature".
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Matzgitz:
is there a plan to implement this feature?

it would be so nice to have a difference between business and private number.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] maxwen:
Not at the moment
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
coming from open beta 7, following opening post flashing steps is right?no other aditional steps are needed?

thanks

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] slyyke:
For those that have rooted (yes I understand it's not supported) magisk or su? And which version are you running.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] janis_dschi:
Im running magisk v16 with 2 installed modules - ios 11 ios emoji and xposed systemless
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] slyyke:
[MENTION=5668309]janis_dschi[/MENTION] thanks for the reply! 16.0 or? And out of curiosity do you use Bluetooth audio , tether , or Android auto? Just curious as those are key features I'd have to break just for root ?.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] janis_dschi:
Currently 16.0 yes. I use Bluetooth audio and it works fine.

In addition to that i want to add that omnirom ist the only custom rom which has the ability to double click/single click on headphones to jump to next tracks. Every other 8.1 rom sucks in this feature. Good work?
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
Hi,

Flashed ROM with no issues at all.

Found only one problem. Playing videos from whatsapp or from gallery, they all seem to be in slow motion, and with some sttutering. I've been trying to find out whats going on using search feature in xda app, but it sucks, it does not work, at least for me. Have anybody fsced same problem?

Thanks in advance.

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bobandar:
Yes.

Flash the latest firmware and it will solve your issue.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] xocomaox:
I had this problem with every video, it turned out to be my Stereo Sound Mod in Magisk.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
Sorry guys, I have another doubt. I was so exited about flashing this ROM because of the Always On Display feature, and it works perfectly. But, don't what to do with it during night,while i'm sleeping. I Know there should not be any problem about burn pixels, but it scares me a bit.

Is there a way to easy toggle on/off AOD feature? Like a quick toggle in status bar?

Thanks

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bdwilk:
If you just flip your phone on it's face then the screen will turn off due to the proximity sensor.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
Updated to latest weekly, and problem of video stuttering still persist. By "latest firmware".. Do you mesn latest omni weekly?or do you mean latest oneplus firmaware 5.1.1?Im coming from latest OB7

Thanks.

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bdwilk:
Try 5.1.1. No wipes needed. Just flash in TWRP.

https://xdaforums.com/showthread.php?t=3728665&p=75020309
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
So flash 5.1.1 on top of last weekly and after that reflash last weekly following the OP imstructions. Is that right?

Thanks

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bdwilk:
No need. Just go to TWRP and flash the firmware and reboot.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
Really? I thought 5.1.1 would overwrite omnirom...Im gonna try, thanks.

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] bdwilk:
Just flash the firmware zip. About 65mb. Not the entire 1.6gb stock zip. I gave you the link to find the firmware.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
Thanks again, flashed 5.1.1. Firmware, and video stuttering problem has disappeared.

Enviado desde mi ONEPLUS A5010 mediante Tapatalk
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] SynaTech:
on the newest update, 5/6/18, the systemui crashes every single time I try to interact with a notification... such as pausing my music, swiping away a notification or even clicking on notifications, it all crashes the systemui... help?

edit: also, the ambient display is off center... both the music ticker and clock are messed up, they are both too high.

edit2: the systemui crashes were due to substratum... so that has been fixed, however, ambient display/aod is still kinda weird.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] gabi.ailincai:
The troubleshooting page for the GCam port has some things you can try.

https://www.celsoazevedo.com/files/android/google-camera/troubleshooting/#help4

I had the same issue because Gapps had GCam already. For me it worked to disable the built-in Gcam, then reinstall Gcam and then used Fix 4 from the page above.

Hope this helps

---------- Post added at 05:09 PM ---------- Previous post was at 05:03 PM ----------

You probably installed Gapps which overwrote the built in Phone app and broke the default app setting.

Go to settings - apps - advanced - default apps - phone and select the Phone app (even if there's just one app).

Hope this helps
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Niri87:
Wifi Issue.

The wifi on my phone randomly disconnects. It doesn't discover the same network again unless i restart the modem. Hence have trouble reconnecting to wifi network. I have noticed this problem with both stock 8.1 rom as well as Omnirom 8.1. Is this inherent to 8.1 build? If anyone can suggest me a solution to this it would be really helpful.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] guachine:
Hi,

Im new in omni, but I',m facing same stutters/lag, specially after a period of no activity. It seems like it takes time to come back from idle to activity again, in my case, after a a minit or so it gets as fast as it should be.

maybe kernel profile related, but at least for me, in-built kernel seems to have only one profile=agressive.
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] Abaddon:
I don't have that issue on this rom w the launcher it comes with (launcher3). I'm using nova now. :)
[OnePlus 5T  ROMs, Kernels, Recoveries, & Other Dev] daga2222:
You're right. I just tried with nova launcher and it works correctly. Maybe this issue is isolated to the pixel 2 launcher. It's just weird because I haven't had this issue on other Oreo ROMs.

---------- Post added at 05:03 AM ---------- Previous post was at 04:05 AM ----------

I reinstalled again and the icons adapt correctly. The key seems to be NOT installing the Google Now launcher via gapps which will overwrite the default launcher (launcher 3). The pixel 2 launcher makes icons round, as expected.