yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Guides, News, & Discussion] Tiago A:
This new feature is not working here. Changed to media but keeps adjusting ringtone volume. Who more are facing this?
[OnePlus 5 Guides, News, & Discussion] Funk Wizard:
Guys i was awake till 0330 hours hoping i could do and share the updates but the team decided to release it early morning

I will update the thread now.

Happy Beta !!
[OnePlus 5 Guides, News, & Discussion] Funk Wizard:
Thanks buddy, OP updated with the download links :highfive:
[OnePlus 5 Guides, News, & Discussion] Funk Wizard:
For All who are looking for Membership Card

Shelf > Scroll to the bottom > Membership Card > Scan & Add

It lets you add a card that has a bar code/QR code for easy/quick access
[OnePlus 5 Guides, News, & Discussion] null0seven:
sleepwalking0593,

is tuesday. I got 45% baterry. Last charge was on saturday.
[OnePlus 5 Guides, News, & Discussion] batwingnz:
Cheers, scroll to bottom of what? There's nothing in app drawer or settings I can see
[OnePlus 5 Guides, News, & Discussion] Funk Wizard:
It's in Shelf
[OnePlus 5 Guides, News, & Discussion] batwingnz:
I'm feeling really stupid but there's no such thing as shelf
[OnePlus 5 Guides, News, & Discussion] batwingnz:
Turns out it's a launcher function not a ROM function so that's a no go.
[OnePlus 5 Guides, News, & Discussion] Funk Wizard:
Sorry buddy my instructions were not clear

You have to use OnePlus launcher, scroll to left to open shelf, scroll to bottom, select the membership card and scan to add :fingers-crossed:
[OnePlus 5 Guides, News, & Discussion] batwingnz:
You tried, I should have remembered that many launchers use the terminology shelf.
[OnePlus 5 Guides, News, & Discussion] Zohair.ul.hasan:
After updating to OB8, I noticed that I have to press the home button twice when I'm in the multi tasking menu to get to the home screen. Is this a known bug?

---------- Post added at 06:17 AM ---------- Previous post was at 06:14 AM ----------

Only happens occasionally, sometimes it does sometimes doesn't.
[OnePlus 5 Guides, News, & Discussion] ulxerker:
Same here. This feature is a good idea with no effect yet.
[OnePlus 5 Guides, News, & Discussion] Zohair.ul.hasan:
Same
[OnePlus 5 Guides, News, & Discussion] kiran8631:
Not able to falsh magisk..8ts bootlooping..any solution..for open beta 8
[OnePlus 5 Guides, News, & Discussion] daitalos:
b8 works very well on my device (stock) ...

Thanks !
[OnePlus 5 Guides, News, & Discussion] david19au:
Can you guys open Netflix after L1 update on Open Beta? Can anyone test it for me if OnePlus has finally fixed the issue? You guys don't need a subscription, just try to download and open the Netflix app on a device with L1 update. Please report back, thanks!
[OnePlus 5 Guides, News, & Discussion] axiel7:
Magisk 16.0 works for me, boot the rom first and then reboot and flash magisk
[OnePlus 5 Guides, News, & Discussion] areyouanand:
Multitouch fixed in Last Beta?
[OnePlus 5 Guides, News, & Discussion] :
does anyone have the same problem that after the update from OOS 5.0.4 to OB8, the speed of the internal memory has become very slow?
[OnePlus 5 Guides, News, & Discussion] ulxerker:
No, did you do a clean flash (wipe system before flashing OB8)? If not, try that.
[OnePlus 5 Guides, News, & Discussion] Principiis obsta:
There was a problem with it? First time hearing it, maybe you just enabled 3-finger screenshot?
[OnePlus 5 Guides, News, & Discussion] hpbrasil:
Installing OB8 over OB7 on bootloop for anyone with magisk:

1- Boot Twrp Codeworkx ( Please remove the device password before )

2- Flash OB8 ( No Wipes )

3- Reboot System ( Waiting 2 minutes boot OB8 )

4- Flash twrp is fastboot

5- Boot Twrp

6- Flash Magisk

7- Reboot:laugh:
[OnePlus 5 Guides, News, & Discussion] areyouanand:
Multitouch was broken thoughtout Android 8.1(Every device), there was a recent leaked patch to fix it(Not sure it has been merged to AOSP sources yet).

Was curious if the patch has been merged to OOS.
[OnePlus 5 Guides, News, & Discussion] chris4500uk:
Netflix opens and goes to the registration page. I don't have an account.
[OnePlus 5 Guides, News, & Discussion] GjorgiDxc:
Okay guys I'm on a clean flash of OB8 and can't set gcam or any other 3rd party camera as the default one when I use the lockscreen camera shortcut. Same with the double tap the pw button to open up the camera whrn the screen is off. It always goes to OOS cam, even if I set gcam as default in settings. This annoys me so much. Does anyone have a fix or a workaround for this?
[OnePlus 5 Guides, News, & Discussion] david19au:
And you have Widevine L1, right?
[OnePlus 5 Guides, News, & Discussion] chris4500uk:
Ah sorry, I've not done the update to L1, I've got stock L3
[OnePlus 5 Guides, News, & Discussion] david19au:
Oh, I need L1 :/
[OnePlus 5 Guides, News, & Discussion] Pires_7:
Anyone getting force closes in almost every app? Thanks
[OnePlus 5 Guides, News, & Discussion] fjsferreira:
Heads up, because of newest security level, substratum doesn't apply right away. You'll have to reboot the phone after enabling your modules and go once again to substratum and enable them there again.
[OnePlus 5 Guides, News, & Discussion] iQuesTz:
Update Open 4 to Open 8

Hello, So I'm in Open Beta 4 and want to update to Open Beta 8 can I do it ?

My Oneplus is with TWRP.

I need to Flash the Stock Recovery and update and after Flash TWRP and Magisk ?

If Possible I don't want to lose my data

Thx U, Guys
[OnePlus 5 Guides, News, & Discussion] null0seven:
I was on ob07, twrp blu spark 8.73.

1.Save my stuff on laptop.

2.Format data in recovery.

3.Flash ob08. Reboot recovery. Flash Magisk 16.3. NO good. Same on 16, 15, 14.6. Phone reboots to recovery.

4.Wipe All, except internal SD card.

5.Reflash the rom. Reboot to system. OK.

6.Set up the phone. Install my apps from Google Play.

7.Reboot to Bootloader. (of course recovery is gone). Flash blu spark twrp 8.73 with ADB.

8.Reboot to recovery. Flash Magisk 16 (because is Stable version).

9.Reboot to system. OK.

Everything is fine.
[OnePlus 5 Guides, News, & Discussion] MattNicholson1978:
Quick install

I just:

- boot to recovery, wipe dalvik, cache and system.

- Install whatever OB version going to

- Reboot back into recovery

- Flash Magisk 16.2 and the custom kernel I'm using, then reboot system.

No app or data loss and everything working how it should be......nice!
[OnePlus 5 Guides, News, & Discussion] Spider-Vice:
You need to boot to system before flashing Magisk after flashing the ROM. You rebooted to recovery which is why it didn't work.
[OnePlus 5 Guides, News, & Discussion] almostthere:
I can confirm on stock locked BL that the parallel apps issue seems to be fixed

Battery issue will only know later today
[OnePlus 5 Guides, News, & Discussion] wesolutka:
Can you reject the call by sending an SMS? Nothing happens when I press the SMS button.
[OnePlus 5 Guides, News, & Discussion] Principiis obsta:
Interesting to know, this are the result i get using any touch tester avaible in playstore.

I hope it helps.
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
What custom kernel do you recommend for this Rom?
[OnePlus 5 Guides, News, & Discussion] d1n0x:
Dirty flashed fine over OB6. Didnt have to remove pattern or anything.
[OnePlus 5 Guides, News, & Discussion] Spider-Vice:
You only have to remove security with TWRP as it doesn't decrypt whatever thing OnePlus did. It works on custom ROMs but not OOS. Stock recovery works fine always.
[OnePlus 5 Guides, News, & Discussion] jaswanth666:
Yup. Most of my apps are foreclosing. Even gmail and keep.I thought it was only an issue for me so I was thinking of doing a clean rom flash
[OnePlus 5 Guides, News, & Discussion] Pires_7:
Yap, did that, solved the issue. Not sure why it happened. But now it's ok.
[OnePlus 5 Guides, News, & Discussion] jaswanth666:
Thanks for the confirmation. Doing it right now
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
Retain TWRP after flash

Is there any way to retain my custom recovery after flashing the latest Open Beta without having to fastboot flash it again?

I generally clean flash as follows: -

Backup what I need

Reboot to TWRP

Wipe Cache, Dalvik etc... all except internal storage

flash latest OB

(Optionally I've then tried re-flashing twrp and then rebooting to recovery here - makes no difference)

Reboot to system add account.

Reboot to Recovery intending to flash Magisk - Nope, I'm back to standard recovery

I then have to Fastboot flash TWRP

Then flash Magisk

Finish set up.
[OnePlus 5 Guides, News, & Discussion] djsubterrain:
Anyone else getting Substratum themes not applying after updating to OB8?
[OnePlus 5 Guides, News, & Discussion] MattNicholson1978:
I'm using blue spark 109 currently
[OnePlus 5 Guides, News, & Discussion] djsubterrain:
Strange, I use the same app on Open Beta 8 and get to 3 touches before the app stops responding.
[OnePlus 5 Guides, News, & Discussion] MattNicholson1978:
Don't reboot to system

Your mistake is rebooting to system after flashing the OB. At that point reboot to recovery to flash magisk and kernel as per my previous post. I've never lost TWRP that way.
[OnePlus 5 Guides, News, & Discussion] kiran8631:
Flash rom in recovery than than flash custom kernel than reboot to system than again reboot to recovery and flash magisk and reboot to system
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
Every time I do that it won't boot due to flashing Magisk without booting to system first.

EDIT - To clarify - Your method works because you are flashing a custom kernel.

I'm trying to understand whether it is possible to avoid losing TWRP if using the default kernel (ie. not flashing any kernel separately)

ta.
[OnePlus 5 Guides, News, & Discussion] zak.ns:
Yes weird,in this way i succeeded: you have to apply theme/reboot/ again apply theme/reboot! :confused:
[OnePlus 5 Guides, News, & Discussion] djsubterrain:
Bizarre, I have the latest magisk and busybox pro installed but when I apply a theme and then go to the manager tab in Substratum it shows no themes installed. I'll give that a go though, thanks. I've already reported the issue on Substratum's Google+ group and thrown up a log.
[OnePlus 5 Guides, News, & Discussion] mrjuniork:
https://xdaforums.com/oneplus-5/themes/v3-1-ozone-substratum-module-oos-t3627336/post76190334
[OnePlus 5 Guides, News, & Discussion] sommo89:
which version of Magisk you use and which TWRP you use? i made this steps:

- Flash OOS or update

- Flash Magisk

- Flash no-verity mod (it is a optional step depending if you are decrypted or encrypted)

- and after that i reflash the TWRP, then i re-boot into recovery and i wipe cache and dalvik

- reboot to OOS

i had problems with Magisk 16.0 (which reperted ERROR 1 during flash) but not with Magisk 15.3

However you must do a reflesh of TWRP and than reboot to recovery before booting to OOS, in order to avoid TWRP
[OnePlus 5 Guides, News, & Discussion] skyknife93:
You'd need a custom kernel or magisk to maintain twrp. Otherwise keeping the stock kernel replaces twrp with stock recovery.

The way I did it (dirty flash) was flash ob7 reboot to recovery (not system) then flash magisk(if you don't want a custom kernel) and boot and profit.
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
Thank you - that explains why this is happening now when it hasn't previously - the fact that I we used to be able to directly flash Magisk after flashing the ROM without a reboot it seems would have helped to maintain TWRP, but as presently this seems to not be possible, with a reboot into the ROM prior to flashing Magisk necessary, the stock recovery is then restored.
[OnePlus 5 Guides, News, & Discussion] skyknife93:
Yes. However, you can reboot to recovery after flashing the rom and flash magisk. It'll boot. At least it did for me.
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
Which version of Magisk did this work with?

Also - latest TWRP just failed with error code 7 when trying to dirty flash OOS OB8 over OOS OB7. :eek:
[OnePlus 5 Guides, News, & Discussion] skyknife93:
Latest Blu spark twrp with 16.3. also remove security, i.e set it to swipe
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
Thanks - have done that, but fails to flash rom with latest twrp.

Not sure whats going on here.
[OnePlus 5 Guides, News, & Discussion] skyknife93:
Maybe it's a bad download or the md5 isn't matching. Try downloading the full room again
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
It doesn't seem to be the ROM - MD5 check clears.

I've removed security...

The message reads (in red):

Updater process ended with ERROR: 7

Error installing zip file '/location of relevant rom file etc.

I'll try a different twrp
[OnePlus 5 Guides, News, & Discussion] Principiis obsta:
3-finger screenshot enabled?
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
Right - Blu Spark TWRP wouldn't even begin to flash so used Codeworks which flashed.

Rebooted to recovery after flashing ROM, then flashed Magisk, the reboot to system - which fails to boot.

That's be me wiping and starting from scratch yet again. :crying:
[OnePlus 5 Guides, News, & Discussion] Gus Ghanem:
Error 7 could mean the System partition is low on space, there's only 140 MB free on pure stock OB8.
[OnePlus 5 Guides, News, & Discussion] xxxxchrisxxxx:
Thanks Gus - you could be onto something..

Strangely, it wouldn't flash on Blu Spark (error 7), but flashed on Codeworks, however as I buggered it up by flashing Magisk and it then refusing to boot, I have now wiped (incl system) and re-installed Blu Spark, which did then flash the rom file.
[OnePlus 5 Guides, News, & Discussion] Queky:
are you guys confortable using OB releases for a daily use?? i'm thinking about switching to OBs.
[OnePlus 5 Guides, News, & Discussion] djsubterrain:
Yup, good call, got up to 10 now....damnit, I've made this mistake before and forgot about it. Thanks ;)
[OnePlus 5 Guides, News, & Discussion] ulxerker:
Yes, stable for me.
[OnePlus 5 Guides, News, & Discussion] MattNicholson1978:
Me too

Stable for me too.

---------- Post added at 06:00 PM ---------- Previous post was at 05:42 PM ----------

I've never had an issue losing TWRP or any data installing the new OB's the way I said before. (Wiping system then installing ROM, rebooting to recovery then installing magisk then custom kernel). But I've always used a custom kernel which I think it's the key. As you've found out, not using custom kernel means when you boot to system it replaces your recovery. Only issue I've ever had is stupidly deleting the previous ROM's before installing the new one, wiping system, then finding out the new ROM I've downloaded is corrupt!! Just meant leaving phone on recovery and re-downloading from pc and copying across. Still do data loss luckily just annoying boss by taking work time fiddling with personal phone but that's no biggy! I'd suggest finding a custom kernel you like and sticking with that. Works a charm for me!
[OnePlus 5 Guides, News, & Discussion] zyonee:
Try a wipe dalvik/cache if you get this error. For some reason, this is the only thing that has helped when I got that on earlier betas. Nowadays I do it on every flash.
[OnePlus 5 Guides, News, & Discussion] $ideWinder:
Anyone having rotation bugs on OB8? Screen doesn't go back into portrait mode many times.
[OnePlus 5 Guides, News, & Discussion] bitojoe:
Hey guys, I've posted these instructions before and I'll post them again. You gotta use the no verity zip for oneplus 5. Google no_verity_mod_For_OOS_Oreo_by_HatriGt.zip

For every open beta update I've done the following:

1. Download rom and boot to recovery (the universal codeworks posted in the op)

2. Flash rom, magisk 16, and no verity zip all in one go

3. Wipe dalvik /cache & reboot

Hopefully it will work for you like it has for me. I will say this though, after completing step 3 with beta 8, I had to reboot one more additional time before it properly rebooted. Every other beta booted just fine.

Good luck!
[OnePlus 5 Guides, News, & Discussion] skyknife93:
Can confirm. Happened to me. Especially after video playbacks.
[OnePlus 5 Guides, News, & Discussion] hololodilolo:
OB7 to OB8

stock, encrypted, rooted with magisk and official twrp 3.2.1-1

-reboot to recovery

-flash OB8 full zip

-wipe cache & dalvik cache

-flash magisk 16.0

-reboot to system

-done
[OnePlus 5 Guides, News, & Discussion] NoobMonkey:
Any1 else has this problem? When swiping down the quick/notification menu the keyboard opens at the same time. Already tried to disable SwiftKey and rebooted my phone. Doesn't help. This started to happen after updating to latest open beta.
[OnePlus 5 Guides, News, & Discussion] Zohair.ul.hasan:
Doesn't happen with stock G-Board.
[OnePlus 5 Guides, News, & Discussion] XDAMaxe:
Did anyone face sometimes unable to charge if plugged to charger? Only reboot solves this.

P.S. Running on beta 7 (magisk-rooted, unlocked bootloader, bluespark-twrp)

Maybe solved in beta 8?
[OnePlus 5 Guides, News, & Discussion] almostthere:
Battery drain worse compared to ob7 which was ok for me, comparable to ob6

Anyone else facing the same scenario? Locked BL user here
[OnePlus 5 Guides, News, & Discussion] sommo89:
My logkit app does not work in OP8 [MENTION=6143932]Funk Wizard[/MENTION]
[OnePlus 5 Guides, News, & Discussion] Gus Ghanem:
There's a new OB8 April 11 update. The first time I check for updates, it downloads a small file which fails to update, the second time it downloads the full firmware (over 1.6GB), which updates successfully.
[OnePlus 5 Guides, News, & Discussion] ulxerker:
There has been a new OB8 build released: https://downloads.oneplus.com/oneplus-5/oneplus_5_oxygenos_openbeta_8/

Changelog compared to recent OB8: Fixed issues with Default volume to adjust.
[OnePlus 5 Guides, News, & Discussion] SkandaH:
[MENTION=6143932]Funk Wizard[/MENTION]

OB8_Hotfix is live!

Official link: http://otafsg1.h2os.com/patch/amazo...ygen_23_OTA_010_all_1804112102_6dea163812.zip

AFH mirror: https://www.androidfilehost.com/?fid=962187416754474646
[OnePlus 5 Guides, News, & Discussion] NoobMonkey:
Tried that and same problem still. And even with the latest hotfix update.
[OnePlus 5 Guides, News, & Discussion] rajeev5252:
Yes i too faced this issue...even after hot fix...i just did a factory reset and everything seems normal now.
[OnePlus 5 Guides, News, & Discussion] djsubterrain:
Just had an OTA pushed to the phone dated 11th April :

OnePlus5Oxygen_23_OTA_010_all_1804112102_6dea163812.zip

Uploaded it to AFH here:

https://www.androidfilehost.com/?fid=673956719939834353
[OnePlus 5 Guides, News, & Discussion] erkkiboy83:
Pretty good. Massive decline in battery though. Going from 7.5 hours screen on time to 5 hours on the second doesn't seem right. Will do some more testing and get back to the issue. Running stock beta, no alterations
[OnePlus 5 Guides, News, & Discussion] daitalos:
Very nice thanks

I have no problems on b8 - stock device
[OnePlus 5 Guides, News, & Discussion] sjamie:
Anyone notice a difference in how the volume works with the new patch/hotfix?
[OnePlus 5 Guides, News, & Discussion] Hefko:
Hotfix :)
[OnePlus 5 Guides, News, & Discussion] macharnec:
Now it is working as expected
[OnePlus 5 Guides, News, & Discussion] null0seven:
Device OnePlus 5

Version Open Beta 8

Update time 2018-04-12

File size 1.61 GB

MD5 hash 65039ab8185a7fcbf9a3204cd37ae016

What's new:

Earphone mode

Added Auto play - Autoplay paused music when connected to earphones

Added Notification ringtone options

Added Broadcast caller information - Announce caller information when using earphones

OnePlus Clock

Changes to alarm background color and other UI changes

Stopwatch updated with new UI

Card Package

Added new membership card in Shelf

System

Updated Android security patch to 2018-04

Fixed issues with Default volume to adjust

https://downloads.oneplus.com/oneplus-5/oneplus_5_oxygenos_openbeta_8/
[OnePlus 5 Guides, News, & Discussion] NGowtham:
New hotfix update for OpenBeta 8 is now available.

Size-38MB.
[OnePlus 5 Guides, News, & Discussion] :
I think most people now know that a hotfix has been released ;)
[OnePlus 5 Guides, News, & Discussion] NGowtham:
Then I guess I'm late to the party :P
[OnePlus 5 Guides, News, & Discussion] batwingnz:
Sorry you weren't invited :(
[OnePlus 5 Guides, News, & Discussion] whatnoww:
Hey guys! How's the battery life on this latest beta? Any SoT's?
[OnePlus 5 Guides, News, & Discussion] jauhari:
My Device we need to Flash NO VERIFY to make it work. After all flash the last one is flash NO VERIFY OP5, if we didn't do this.. become SOFT BOOTLOOP and ended in TWRP :)

---------- Post added at 08:28 AM ---------- Previous post was at 08:19 AM ----------

what Hotfix is it?
[OnePlus 5 Guides, News, & Discussion] erkkiboy83:
So yeah. Battery testing is still not looking good from previous beta version. Worse on wifi(2.4ghz band. Slightly better on 5ghz) and or 4G. Very stationary in my home so testing Conditions are quite similar. Increased battery with one hour by switching GPS to device only. But still 1. 5 hour less screen on time than what I'm used to. Also tried to clear cache after the latest 18.24.11. I found no submit bug report button so hope that automatic check works
[OnePlus 5 Guides, News, & Discussion] ulxerker:
Fixed issues with Default volume to adjust, which is now working as it should.
[OnePlus 5 Guides, News, & Discussion] sjamie:
How should it be working now compared to pre-hotfix behavior?
[OnePlus 5 Guides, News, & Discussion] anuraganasane:
I encountered with camera app crashes in ob8.
[OnePlus 5 Guides, News, & Discussion] SM@SH3R:
Can someone please share a link to the 38mb hotfix zip?
[OnePlus 5 Guides, News, & Discussion] rajeev5252:
Here it is:

https://xdaforums.com/showthread.php?t=3628190
[OnePlus 5 Guides, News, & Discussion] SM@SH3R:
Thanks
[OnePlus 5 Guides, News, & Discussion] sjamie:
[MENTION=6143932]Funk Wizard[/MENTION], have you noticed that dirty flashing to OB8 from OB7 breaks auto PC detection? When connected to a PC, the notification that allows you to select Charging, File Transfer (MTP), etc. no longer appears. You must select MTP from Developer Options in order to do file transfers with a PC. A clean flash does fix the issue but this was never an issue when dirty flashing earlier versions.
[OnePlus 5 Guides, News, & Discussion] null0seven:
sjamie,

For me it workt fine. But i always Clean flash.

Even the hot fix i clean flash. Again no problem.
[OnePlus 5 Guides, News, & Discussion] meiax93:
Same bro. Always clean flash even hotfix ?
[OnePlus 5 Guides, News, & Discussion] saumik.bose:
Facing same issue of ring tones post flashing Open beta 8 (did dirty flash from Open Beta 7) ...

Custom ringtones are not working, native ringtones works fine.

This issue occurs after using the phone for 10 - 12 hours, restart resolves the issue temporarily, but after 10 hrs again custom ringtone stops working.

Reverted back to Open Beta 7 now and restored all data as had taken backup.

I will not upgrade to Open Beta 8 again and will wait for Open Beta 9 build instead.
[OnePlus 5 Guides, News, & Discussion] sjamie:
Yep, I reluctantly did a clean flash to resolve the issue. I guess I've gotten too comfortable with being able to dirty flash most OB updates. :D :laugh:
[OnePlus 5 Guides, News, & Discussion] spider623:
There is a newer version on the official site, it just includes the hotfix ?
[OnePlus 5 Guides, News, & Discussion] ulxerker:
Yes, nothing else has changed.
[OnePlus 5 Guides, News, & Discussion] :
With an unlocked bootloader Netflix returns a -9 error code, while with the locked bootloader it works fine. Logcat shows that the error is:

MediaDrm-JNI: Illegal state exception: Failed to get provision request: General DRM error (-2000)

This seems to be because of the entry

OEMCrypto_GenerateDerivedKeys: ends! returns 8

Instead it should return 0