yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Look, I am not trying to be a jerk here but I roll these things out and expect nothing. You asking me for a tutorial on programming, Android SDK, and compiling code is going a bit far bro. If I wanted to write a tutorial on this and answer all the ignorant questions that come along with that the title would have been "Compiling Magisk for Dummies" I don't and its not. So with all due respect, I decline to answer this question. I will say, its not rocket science however its not that simple either. There is no 1 magic line to delete and a big red easy button to hit and it spits out a flashable zip. Also, the code base changes so even if I were to "explain" this to you today, tomorrow it would most likely be completely different and you would be asking the same questions. No hard feelings man. :crying:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
I'll test the test one in a few minutes
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
lol, thats some testing shizzle! If you are up and running then no real need bro. It might not even work, I just felt like building it and throwing it out there so people could tell me it doesn't work hahaha. But I am a little curious though :cyclops:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Understood. I feel ya man. Glad you were able to put it together. I guess that's the next goal for me in understanding this stuff a little more.

Thanks for the new zip

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
I need to update to your latest release anyways so what the heck...off to see what happens
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
No worries my man! :good: It's a good goal to set if you are into this stuff. I enjoy it, that's why I exert the energy towards it. Its like little brain games ;) I have spent years staring at this stuff and experimenting with code to have a basic understanding and I am still no programmer. I can just make stuff work from time to time. Java is a great language to learn if its something your interested in. It can land you a really good job.... Sitting in a small cubical under fluorescent lighting contemplating how you want to kill yourself that day... (I always think about the movie "Joe vs the Volcano" when I reminisce about prior jobs I have had like that :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
I've always worked for myself. Mostly in the comfort of my own home with my Philips Hue lights, lol

But, I have a bunch of people that are well more than interested in my work ethic because I get the job done right and fast.

Thanks for the words of advice though. I'll look to these posts one day and say "I did it!"

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Hell yeah! I work for myself and have for the last 5 years as well. My house is almost 100% automated but I have not invested in the Hue lights yet. I assume they are worth it? Water detection/shutoff valve, garage doors, a couple deadbolts, many outlets and switches, everything has contact sensors, motions, and alarms... I love that stuff, its awesome. My neighbors don't understand how I can say 'Ok Google, turn off my christmas lights' and the entire outside of my house shuts down :) Really cool. I use the smarthings hub, really like the semi opensource/github integration thing they got going on!

Keep on keeping on man, and as Rob Schneider would say... https://www.youtube.com/watch?v=qztuEucrNBc
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Here are the results of the test build.

No warnings upon boot.

Change log shows up after opening magisk

Safety net passes
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Rite on! I almost changed the changelog and added a picture of my a$$ in there but I decided not to ;)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
I appreciate you leaving that out as I would have responded with "FAILED DUE TO DIRTY FLASHING" lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
lmao! Very clever man! :D :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Not to take this thread totally off topic, I love my hue lights. I also have the ISY994 with Z-Wave. So, I use the hue API for turning my lights on and off with IFTTT and the isy network module. Door locks, fans, lights, garage door opener (Insteon and Z-Wave), TV & stereo (Eventghost), you name it, I've probably got it automated in some way or another. ;)

If you look at my signature, you can see a lot of cool things I've automated in "My Tasker creations"

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Rite on man, another automation geek! Eventghost looks interesting! Got the Harmony hub doing my home theater, its pretty sweet... Only 2 things I found disappointing... Both my Pentair Pool automation system and my Carrier Infinity air/heating system have proprietary communication protocols :( The 2 biggest investments I have made with the intent of integrating into a single solution and they screw me. So frustrating. I am thinking about reverse engineering the calls and releasing it just in spite of them. Carrier wants me to buy a $600 thermostat that only partially integrates. Very aggravating. Bookmarked your blog, going to look through it in more detail when I got time. Looks pretty interesting man!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Digging the idea of the script!! Is flashing the stock boot needed if already on installed TWRP, custom kernel and unofficial magisk? I have the latest TWRP, flash kernel and this latest unofficial magisk downloaded. Can I just reboot into TWRP beta 2 and flash the latest TWRP, flash kernel 2.04 and your magisk in one session? Any input would be greatly appreciated. I've been rock solid for weeks on this and don't wanna bone it up. Lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
In theory it should work... But if it does not its no big deal. Just flash stock boot and dtbo then boot twrp and install twrp, kernel, magisk... In that order... I always do just because it eliminates any confusion. Magisk should flash fine though without all that.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
By the way... twrp-pixel2-installer-taimen-3.2.1-0.zip Is working great! You should probably update that.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Sweet, it's a plan. Thanks for your work man!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
So I just downloaded this and installed it and it worked until I rebooted for the second time then I got the error message again and I think you're zip might be corrupt right after it gave me a warning about a bad virus so I had to do a factory reset
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
That's really strange!

I just rebooted, and no issues, popups, virus warnings. I'm on the test build, but either way, haven't seen anyone else report your issue. Post a screenshot of this virus warning, I'd love to see it. I'm guessing you are running a 3rd party app for that as well.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
It was so long and scary I had the thing factory reset it before I even read the whole thing. I wish I would have screen shot it. What's weird is I had a really hard time downloading your magisk. . And after the virus message It broke everything play Star wouldnt open, kept fc. I couldn't do anything. Something that looked like it was from Google asked me if I wanted to remove it but the address looked funky it's scared me so that's when I did the factory reset. I dunno.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Wow, magisk doesn't cause any of those issues, user error certainly could. I don't know what you did exactly but it was wrong. No viruses here, nothing corrupt, and nothing that's going to trigger what you have described..

P.s. This isn't mine, I'm just a user/follower/and helper with posts.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
No I'm not saying there's anything wrong with magisk it was working fine it was something in that download. That's the only thing I've downloaded all day and it happened right after. No worries I was just letting you know ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] DodoGTA:
[MENTION=3297454]thedude420[/MENTION] Can you give the sources of modified Magisk repositories?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Good morning! I never thought this could be flashed on a Windows phone. Thanks for testing that out!

Unsubstaniated virus claims with not one bit evidence are pretty lame, like bottom of the barrel super lame lame... Waking up to this crap really makes me want to pull the thread from XDA, but its not their fault they are a turd magnet.

I am going to address this once and then I am done talking about this topic indefinitely. Let me address the obvious here and point out some facts.

1.) The file is hosted on Google Drive. Google scans all files under 64 MB for viruses. You use their phone, maybe you should trust their cloud storage? https://support.google.com/a/answer/172541?hl=en

2.) I am a system admin and I take this topic pretty serious. I run a local AV that scans everything real time. Even the code while it compiles. I also have an Enterprise Class firewall in place that real-time scans all traffic in and out of my network. If this file was infected it would have never made it out of my network.

3.) There are plenty of tools available for you to check with prior to making such claims. One is here. https://www.virustotal.com/en/file/9029fe81c4ab81c47e6ef244a95b50d10fce36815ea5b29dd99038f9ed06f862/analysis/

As you can see 1 scanner offers a PUP.HighConfidence warning. Do some research, you will see this is a common false positive. Feel free to look into this more with all of your spare time.

So getting on here and causing a scare because you downloaded some rouge porn apk you found on Webcrawler is not cool at all. As [MENTION=4020863]clothednblack[/MENTION] said, you are the only person that has made such a claim. With the holidays upon us and some time off work, this may be a good time for some self reflection. You may want to reconsider some of the apps you install.

As a long time XDA member the last thing I would do is post a infected file for people to flash, not even accidently. I can assure everyone here that anything I upload has been checked to the highest standards and is clean.

Now having put this to rest... Time to do something productive.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
Ok
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Yeah, they are located here C:\Android\Github\Magisk ;)

I just sync Magisk repo, modify what needs modified and build. Cloning his repo and keeping everything in sync is actually more work than making the builds. I literally add NO code to the source, Just remove a bunch of it to prevent DTBO from being patched. So there is no reason the way I see it to keep an upstream repo...

If I am requested to turn over the source for review by XDA admins I have absolutely no problem in doing so. TheDude is pretty lazy though and he is not going to do any more work than required :) You guys have driven me to speak in 3rd person.... Need coffee. :silly:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jlokos:
update

I appreciate all of your updates. I have twrp 3.2.1 installed. When I initially installed your unofficial Magisk, I followed all the steps on the first page. Since the initial installation whenever I want to update kernel, I uninstall magisk manager, I go to twrp, flash the kernel zip and Magisk and I'm good to go. Keep up the great work and have a wonderful holiday season.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
I'm sorry you have to deal with these comments. Unfortunately, "No good deed goes unpunished."

The updated Magisk zip and apk working flawlessly on my Pixel 2 XL.

Thank you!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
Look I'm not saying that he intentionally sent out of file that was corrupt I was just explaining what happened to me. This is the only file I downloaded yesterday and it came with a bunch of garbage a virus. It's my own fault for not sending proof I suppose but I don't care it's over I was just letting everybody know what happened to me. I don't look at porn so I don't know where we came up with that but it's over Let It Be obviously no one else is having a problem so it must have been something to do with me. When I downloaded it from Google Drive it took me three or four times to get it to go through I think something happened there.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
I didn't send anything out that was corrupt or "came with a bunch of garbage a virus." There you go again... :rolleyes: I can't control what happens between you and the internet man. That's a personal problem that you should think about addressing...

From here on out I will be providing Hash values for anything I upload. It is your responsibility to check them against the download as I can not do that for you either. Hope this is helpful for some. OP has been updated.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
[MENTION=3297454]thedude420[/MENTION]

FYI only.

I guess topjohnwu is busy getting more commits.

Another release came out today on the unofficial build thread.

How long does it take to remove those things to get it ready for the Pixel 2 XL?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Well, I just surfed your Google drive link, and as soon as I clicked on a file, my dishwasher stopped. I'm extremely unhappy that this has happened, no I have to look into what's going on.

Update: appears your off the hook, it was just a coincidence as the washing cycle had ended at that exact same time I clicked a file.

Update 2: the rain has stopped and the sun is out, thanks for the latest update, it's doing wonders for our weather.

Lmao!! But seriously, enough of my joking around, really appreciate you doing these updates and sticking it. Can't make everyone happy when it's something completely irrelevant to what is offered here. Zip works, plain and simple. Keep it up Bro, we got your back!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Half an hour... Just looked at the commits briefly, did he fix dtbo or is it still patching? Have you flashed the 14.6 release yet and tested?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Surge1223:
Just so I'm not missing anything or going crazy, literally the only reason anyone wants the dtbo patching to stop is because of the insignificant pop-up after you get after a reboot? I just want to make sure I'm not missing anything, because if that's the only reason then it's a horrible trade off, losing the ability to modify vendor (besides the fact the kernel modules go in vendor, along with any kind of HAL edits, like sound mods) just so you don't get a pop-up at boot is beyond ridiculous.

Just wanted to make that absolutely clear, because I honestly can't think of one good reason why you wouldn't want the dtbo patched.

I honestly think everyone is really confused because this makes little to no sense at all lol.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
I'll check it out. It's not that hard.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
I don't know [MENTION=4939386]Surge1223[/MENTION], peeps don't want/like the warning. It scares a lot of people. I could really care less either way as I don't utilize any HAL mods or modify the vendor partition... So I guess for me there is no trade off. The solution to this would be to figure out a way to disable the stupid message but then again it does not affect me. I started building these for myself and other people wanted them, so this is where they get posted now.

OP updated with latest commits. Hopefully that's all for now :/
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Where is 14.6?

The one on the unofficial build thread in the Magisk forum is still 14.5blahblah

Would I have to build it?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Ok dig it...

Flashed the new TWRP and rebooted back to TWRP. It had no touch issues and shows the new version. Then flashed Flash 2.04 and the newest unofficial magisk. All rebooted correctly and root was functional. I then discovered all my magisk modules were gone so no Viper.

I downloaded/installed all the modules then flashed the aroma viper zip I was using. Rebooted and all is working correctly. Looks like we are definitely getting back to custom Rom territory. Feels good to just flash stuff again!!

I am thinking your idea for a script would be good to go seeing the manual steps are working.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
https://github.com/topjohnwu/Magisk/releases/tag/v14.6

I already built and tested with the latest commits minus dtbo of course... Its in the OP on my gdrive...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
That was fast. Thanks!

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
I'm no good at looking at this git stuff. Is there anything in 14.6 worth jumping to?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
What Viper mod are you running?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Meh, a couple fixes/cleanup... Added a couple advanced features verity stuff. Nothing you can't live without.

However, I didn't really dig through the changes that thourghly...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
I got it from this thread, the file name is: v4afx-v2.5.zip

https://xdaforums.com/pixel-2-xl/how-to/guide-unlock-kernel-twrp-root-viper-t3708344
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jrbxx7:
Couldn't agree more. People see the message and freak out for nothing. Even if you're a crackflasher and reboot 10 times a day, there's no reason to worry about it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Sweet! In all my Android days I have never flashed Viper (that I can remember...) Look forward to testing it out. From my understanding Viper is most definitely an Audio mod... Wonder how this works without DTBO patched as Surge1223 said was not possible...?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Seems to be working as I believe it should. I chose the new version (vol +) and the material option in the aroma installer.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
This version of Magisk seems pretty good for viper. I haven't gotten a single soft reboot in a couple days. Also, get aharion's Viper4Android and use the 2.3.4.0 one. It stops a lot of random soft boots

What I do:

Use Tasker to setenforce to 0 on Tasker launch, about 15 seconds later, setenforce to 1

Viper needs some sort of access to the kernel in permissive mode, right after, you can go back to enforcing.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
For those who are either not up to the level of using tasker or want an option, I have never been let down by this app either...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
That only changes it from enforcing you can set it back.

I would suggest a script instead.

smanager is a good one.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
So it'll run in enforcing after the initial install under permissive? No need to leave it in permissive all the time??
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Correct.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
So I updated my test pixel 2 xl to the current version and it can up with the preserve forced encryption and preserve avb 2.0/ dm-verify.

I then updated my daily driver and both those are not checked.

8.1

ElementalX

Twrp flashed

Both devices.

Any input on why and the preference would be helpful.

Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Official Magisk v. 14.6 zip and Magisk Manager 5.5.0 are up and can be updated from the Magisk Manager App. If you want to get rid of the warning after updating, fastboot flash dtbo dtbo.img and boot into TWRP, then flash Magisk 14.6.zip from the Magisk Manager folder. Reeboot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
I don't get it..

The zip has the dtbo removed but the manager zip doesn't?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
I'm not sure of the architecture of these components. However, unless you fastboot flash the dtbo image and then the 14.6 zip, you will get the System warning. You will have to ask [MENTION=3297454]thedude420[/MENTION] or another developer for the underlying reasons why.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
I am guessing that it's not worth the hassle to upgrade right NOW, thedude just captured the latest around 2pm AZ time. I can't imagine there were that many changes in the 3hrs that were between topjohnwu's post and thedude's latest build.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
In regards to the second release of 14.6 today... I have rebuilt the app with dtbo patching removed... Link in OP...

You do not have to flash anything since the last build (Magisk-v14.6420NODTBO.zip,) just install that apk as that is all that has changed... su time limit jazz...

More details in OP...

From now on I am not going to build these until I am sure things won't keep changing. Unless there is some substantial change of course... We are working with a mostly stable environment at the moment and it's not really necessary for me to spend my time compiling or you to spend your time flashing all this crap. So unless something groundbreaking gets released please expect a 6-12 hour turnaround time on these so I can make sure a re-release will not occur.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
I would say, extremely stable environment. Great job man. If you are ever in the Phoenix area, I'll be sure to get you a few drinks ;)

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] karandpr:
Thread cleaned .... Cos ....

Feels ?

-XDA Staff
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Whatever... Shutup ;)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] burbank:
Dear Mr. Dude:

Thank you so much for making these builds available. Everything works flawlessly on my 2 XL.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Dear Mr. Burbank,

I love your professional and grammatically correct format; appreciation is always accepted. You are most certainly welcome and I wish you and your family a very warm and Merry Christmas! Comments like yours make it worth my 20ish minutes :) (I am not however an English major like you (But it is fun trying.))
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] krweby:
So if you do this with the new 14.6 beta the error goes away.

Q: After flashing Magisk, my device will show a scary popup saying "There's an internal problem with your device. Contact your manufacturer for details"

A: This is caused by dtbo image patched to remove AVB 2.0 of the vendor partition. This is required for allowing you to mount vendor to rw and make modifications

If you never plan to modify the vendor partition, in Magisk Manager, "Uninstall > Restore Images" to restore the images, check "Preserve AVB 2.0/dm-verity" box in Advanced Settings, then reinstall Magisk via the app.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Looks like it finally was fixed.

Nice.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
If that is the case.... thank god!

is it?