yashsingh1/xdaforums huggingface dataset:
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
k. descriptive. helpful.

i'll have a look at that today.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Darian71:
Ahhh. Thanks for making me aware of this. Yours is actually the first 8.1 kernel I've seen. Lol. I am still learning on thus device. Coming from my RMA 6P, Pixel is a new animal. Have a great day ?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
cool. yeah, I think flar2 (elementalx kernel) and I are the only ones who pushed out kernels on 8.1 quickly... not sure who else even has... i haven't really looked...

nice. the pixel should be a nice upgrade for u. 6p was a good device too.... Pixel's got better construction, camera's better plus higher specs, etc... the kernel is a lot nicer too. much newer not even talking mine specifically...

although, obviously, i think mine is the best custom kernel for our device. ??? ...
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Darian71:
Of course!! Lol. It's a labor of love,... that my 46 year old brain just refuses to learn to do quickly anyway. Haha. And yep, I see the notification of flars kernel on his manager I'm using. I like to get 3-4 battery cycles and various usage scenarios before swapping kernels so ill be happy to share any feedback and help any way I can. ?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
alright. so my average SOT is starting to climb n be similar to 8.0 on the latest release;

i'm still working on improving battery life though.

also, this kernel chews thru more CPU cycles than 8.0, so this isn't half bad, all things considered.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] flar2:
EXKM custom settings are in Tools->User Settings

Just add the path.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
haha. thanks for pointing that out for others, I was just giving a bit of homework / DIY. .. lol

BTW, have you thought about adding custom controls to EXKM? (similar to Kernel Aduitor, but probably would be better in your app ?)... that would be a killer feature to have.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] GizmoTheGreen:
I've got this too, hope it's something we can get rid of eventually :)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
every custom kernel has got it on 8.1... not news worthy or worth pointing out... it's been mentioned numerous times now in this thread and others....

not sure of the exact cause yet. but I have some ideas... some sort of check on the boot.img, I'm guessing... I'm going to have a deeper look at this soon, but the performance + improving battery and fixing any immediate more serious issues take priority... that message is harmless, just annoying. lol
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] montbazon:
IMHO, Mac Address Randomisation is better on default for security.

And as you said, let it off, only if someone need to static Mac address.

Thanks for adding this function!
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Donric13:
Just remarked on DT2W: it seems to work if i really tab 2 times very fast. Then it's working every time... Anybody else can confirm (or do i already see ghosts....)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
yeah, mac randomization is better for anonymity... but having it start by default (in the kernel module) is a bad default for anyone who has to deal with Mac filtering. it might be different if we had ROM support, where we could dynamically handle it in network settings via a toggle switch/bool (like CopperheadOS does, or my own old ROM), but we don't... so off by default is sensible.

it's definitely a nice feature, for sure. I used it on my old Galaxy s5, as well for a couple of years... I had ROM support for it there though.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] dictionary:
On 8.1 final getting great battery life in default settings while using the phone, but standby drains a lot. Haven't tweaked any settings at all.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
I'll look into the wake gestures stuff when I'm at home... I'm not right now... I don't think you are going to solve any issue with it in the thread...

I'll get to it, as I've already said that I would. please excersize some patience...

edit:

another thing to point out. I'm not even sure what the point of using DT2W is with Wake Gestures (?). it completely redundant, IMHO.... Oero has this built in and it works fine...

by the same token; if u have both enabled, that may cause issues. Idk. regardless, u should be picking one or the other NOT both...
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
cool. it would be helpful to have more info though. not super useful And. ***have a look at what's causing the drain on your phone, I'm betting there is a cause and it's not the kernel;

I had my phone off the charger while I slept, the only drain that I had was the unusually full inbox in my gmail, this morning and the syncing / notifications from it.... otherwise, no drain...

which is very consistent with almost evey other releases..
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] dictionary:
Didn't really have any information to quantify this, so didn't mention it. I DID have double tap to wake enabled before. I have since turned it off, so I'll monitor it. Nothing in the battery stats looks suspicious
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
please do. I can try enabling double tap to wake and see if it causes drain here. I don't think it should though....

keep me posted. thanks
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
[MENTION=2190489]dictionary[/MENTION]

double tap to wake enabled in android settings. result; no drain... in the screenshot below, the period where the graph is flat, my phone is sleeping... that's at least a couple of hours, should be enough to see any measurable drain.

hmmmm... so I'm not sure what would be causing drain on your end, but I doubt it's that...
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
[MENTION=1007992]everyone[/MENTION]

I will probably won't be able to post a build tomorrow that resolve should fix any issues with wake gestures, it may have some tweaks to CPU-boost, 3.18.87 and a few other bits.... today has been super busy for me, so that's how the cookie crumbles. lol
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] dictionary:
Yeah not sure. I know I was getting less drain with the stock kernel rooted, but your kernel is way faster and more responsive. I'll try to reset and do a logcat. Thanks for looking into it for me
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
OK. ya, I don't mind... the above screenshot is the trpical expected behaviour, from my POV; when sleeping, there shouldn't be any significant drain... and I don't do anything like disabling WiFi or data on sleep....or anything like that.

it shouldn't be draining anymore than stock.... but you also may need to sun through a couple of cycles, to really get a good view of things...

every other time that someone has thought the kernel was causing excessive drain, in either thread. it's turned out to be something else, afaict.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] dictionary:
Are you on all default settings using EX? My default governor is schedutil ..

I agree that your kernel shouldn't be introducing drain, but literally nothing about my use changed, nor app updates, or new apps. Maybe one of my settings is different? I know EX changes things to a different default sometimes
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
I'm using all default settings. that's what I test with...

but there may be other settings that differ on my system. I tend to disallow some apps from running in the background, unless they actually need to... I use data saver, I also disable NFC, location and Bluetooth and only turn them on when I need them... but here's what I'll do; I will leave them all on overnight n see what happens... shouldn't cause excessive drain though.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] dictionary:
I wouldn't call my drain excessive, but I find it to got sure be more. I disabled NFC too, but since moving to Oreo, have been leaving location on. Only use Bluetooth when I'm actually using it. Maybe it just needs a couple days to settle in. Will report back more on Tuesday or Wednesday. Thanks. Sorry for cluttering the thread
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
yes, I would give it a couple of days / a couple of cycles. the new battery stats in 8.1 take a bit to actually be somewhat accurate (and I still prefer Accubattery - as I find it to be a bit quicker to give me better averages than android's stats, which is helpful, as I flash many builds, so I need to guage things as quickly as possible)...

no need to apologize. our discussions here IMHO do add value to the thread that other users may find insightful and valuable.... so it's all good....
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Bryanx86:
Just a SS of battery stats from settings, and from user settings of exkm. I also have used accubattery in the past, but stopped because I noticed more battery drain. I have since reinstalled so that I can add something here as well. Hope this is ok? I have a lot of apps installed on my phone, probably 200. And I actually use all of them at some point or another, and I always leave bt and nfc on. All the same default settings, disallowing play store and play services to run in the background. Only download and download manager have unrestricted data usage access. I always use a black theme, I use my phone and get really good battery life with this phone, stock 8.1 and your kernel. Thanks, and anything else I can add to help contribute lmk:good:. I also have enabled mac_randomization in exkm.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Bryanx86:
Possibly set a default minimum CPU freq for big core in exkm? I notice all kernels will not set this by default. I do not know if this affects battery drain, but have read somewhere it does. Just an idea....
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] dictionary:
Thanks. I'd noticed that, but since it came like that default, I didn't want to mess with it. Just dropped it and will check out battery over the course of the next few days. Appreciate it
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
good to know, good tips. in particular; substratum + a dark theme. the screen is always the biggest source of drain, so using a black theme, more suitable for an amoled screen does improve battery life. Disabling Ambient display and sitting brightness lower helps too...

I personally don't stop Google Play Services from running in the background, that can affect some of it's services, mileage may vary... i do stop Play store auto-update though... not disabling play setvices is kind of similar to why I don't include disabling wifi wakelocks, as in some cases that can break things too; like texts/notifications being delayed or worse things can happen...

on the same note: I actually advise strongly against using any app that messes with wakelocks or tries to manage battery savings rather than letting the system / kernel manage it.... ex; greenify, amplify, etc... none of those types of apps should be needed, at all. they are hacky, at best.

I've noticed that too. I'll see why that is happening, but no; that won't affect anything, setting it... if u watch the CPU scaling, you will see that it is scaling down to the minimum values...
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Bryanx86:
Play services just keeps turning itself back on, kind of figured it would as it always has without wakeblock or Xposed. I have used amplify, greenify, and wakeblock but since Oreo haven't found a need to. Google stepped their game up with Oreo, imo. A lot of things that have been needing fixing, they finally took some advice, lol. I'll have some accubattery stats in a couple of days to post. Very snappy kernel, smooove. For some reason I can't upload screenshots now? That setting is new as far as I know, on settings/apps/advanced/special app access/unrestricted data is where the settings for play services and play store that I've tried turning off. Also have to hit 3dot menu to show system.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
play services really shouldn't cause any issues, I do test with it enabled...

apps or kernel patches that mess with wakelocks are generally bad news. they can fsck up how drivers are intended to work, or the system itself.... users also tend to not necessarily know what effects messing with wakelocks can have: recently, I bumped into someone in a thread thinking he was possibly fixing battery drain using amplify, greenify, etc - following fandom guides on XDA - the end result; he went from having normal/average SOT down 2hrs. yikes! ?

some of those apps at times have been useful, but Oreo is pretty good, as you say and my kernel is good too.... no need for any of that crap.

I'm not so sure if it's a case of Google taking advise (although they are finally listening to upstream Linux devs && forcing their partners to comply with treble), necessarily or just better engineering, improving the stack... they've really improved the soft-realtime capabilities of android (which my kernel benefits from vs. 8.0) and they are getting better at optimizing the system and battery.

yeah, let me know how things go. I do have some other misc improvements coming too.... some bigger changes planned, once I get a few other bits settled...
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Bryanx86:
Awesome, and thanks for fixing the rt_mutex GitHub link in OP. Nice!:good:
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
no probz. I fixed it as soon as you mentioned it... I just forgot to previously... and tbh, I figured that few people would be interested in reading it;

but it does give a basic overview of the rt_mutexes implementation in the linux kernel and why I chose to implement them in binder... there's a white paper on an implementation very similar (no source code available though) and I don't have a link off hand, I think the PDF is only available by request, IIRC...
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Ok. So a few things that I've been looking at / into;

Wake Gestures:

So some of you may have noticed that Wake gestures are behaving oddly on my 8.1 kernel. My thoughts on the subject;

1. It makes zero sense to me why DT2W is included on the Pixel - It breaks Oreo's Implementation of double tap to wake.

2. DT2W does seem to have an incompatibility with my kernel, it works fine on EX kernel, but again Android's double Tap 2 wake works fine with my kernel ~ So I haven't figured out what the issue here is - but it's annoying ~ especially since the Wake gestures patch breaks something already included in Android Oreo. (and is completely redundant).

3. S2W and S2S work fine, as long as you are using "sweep left" - anything else seems inconsistent or not working. I was getting inconsistent behaviour testing this on EX kernel too... hmmm....

I'm just going to point out to you guys - that I actually hate this feature / patchset and don't even really want to be including nor supporting it. I've only done so, because 1 person had made a valid reason to; semi-broken/warn out power button... But I've now spent a great deal of time messing around with this and it's become something that just isn't worth the effort....

It could be that it doesn't like the cpu-boost driver / input boosting, it could also be that the newly set CONFIG_HZ_1000=y is causing something funny here with Wake gestures.... However; i will NOT be reverting either of these ~ they are far more beneficial than supporting Wake Gestures. It's a ~ improve battery life / performance VS. Supporting a feature that ddoesn't even work properly. = You do the math. lol

So at this point, I'm not sure How I plan to handle this ~ but it may not be immediately fixed.

KCal Advanced Colour Control.

It does seem to have some oddness on 8.1 ... At least for me; after using the Night Light - The colour isn't restored correctly and look saturated and yellowish.... I may temporarily disable this feature While I figure it out. ~ I think it's important not to break android's Default features (and night light should work correctly without the need to reset Kcal's settings after using it)....

anyway, I wouldn't mind some feedback on the above. I probably will disable KCal, at lease until I know it's fixed... But Wake Gestures I'm not sure how I would like to deal with - reverting support; D2TW works fine, as it should provided by Android.... NOT reverting it DT2W doesn't work correctly, and SWS and S2W 'kind of' work...

I'd prefer to just remove support, but that's me... Let me know what you think...?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Nevermindthelabel:
Sounds good to me, since Oreo includes it I haven't been using it. If it makes your life easier do it!
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Cool. thanks... Let's see what other people have to say, as well. And yeah; It would mean one less thing to concern myself with. (there are definitely things that I would rather be working on / with my limited time and resources)...

and yeah; It's included in Oreo/Pixel...

settings->display->advanced->ambient display->double tap to check phone.

It's the same functionality as Wake gestures DTW2 - except official support backed into the Stock Rom ~ which is why it's redundant to even have it in Wake gestures for the Pixel... The onyl reason I can think of as to why it is there is because Flar2 is supporting a bunch of devices... some probably don't include it.

NOTE: While wake gestures is in the kernel - this doesn't work correctly.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Donric13:
Sounds good to me. There are definitly more important things than wake gestures. BTW getting used to left sweep :)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
That's how I feel about it. It's an interesting feature, but kind of "gimmicky" and not something that I would ever use ~ if I pick up my phone or double tap on the screen; it comes on - Google supports that directly on the Pixel in Oreo... That seems sufficient to me.

like I said; the only use case where I could see Wake gestures actually being handy is a wanr out power button. Other than that - i don't see the point. lol

BTW, just on a general note (@everyone); next build will have some improvements to the cpu-boot driver which will reduce input latency.... I've also got come other bits in that should give a little boost here and there, under specific circumstances ~ so I am working on some improvements for the next build ;)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] almightysiman:
I use Sw2s a lot，so please don't disable this feature, Thanks!
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] natri23:
Personally I use DT2W cause I want to use face unlock when the phone is on the table or my hands are wet.

Oreo has dt2check but it doesnt bring me straight to the lock screen. And the kernel also makes Oreo dt2check inconsistent as well.

Its not something I care about since I just discover it when using your kernel. I can just use the power button.

I just though its a bug you might want to know
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Ok, so what's your solution then?

Yeah, I wish that google didn't change the lock screen behaviour ~ but you need to bring that up with them. If they get enough complaints, hopefully they will restore the old behaviour... I can't do anything about them changing that myself - that's in user-space.

the kernel doesn't make dt2check inconsistent - the wake Gestures kernel patch does ~ that's part of the reason that I want it removed. It's breaking expected behaviour in the Stock Rom and wake gestures doesn't work very well with my kernel...
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] almightysiman:
if disabled,the only choice is power button:(
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
I can't remember, but was it you with the worn out power button?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ayylmaomyman:
Damn I really liked the DT2W feature

Works flawlessly on 8.1 for me because I disabled the stock Roms DT2 check (it's a ****in stupid feature because that's like 4-6 taps to wake)

As mentioned earlier in the thread I also have that not-always-functioning power button and my hands are always sweaty so fingerprint scanner is a no-go unless it's dry weather so dt2w+swipe password is personally fastest way to unlock on my phone
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
well, I haven't removed wake gestures in a build yet... still undecided... if the phone is sleeping; DT2C never takes more than 2 taps to wake or peak at notifications... the stupid part is having to tap twice again to lockscreen; ...

what I'd really like is for Google to fix DT2 check so that it goes straight to the lock screen. it's dumb the way that it works now. no idea why they changed it..

...that aside, DT2W is inconsistent for me. s2s and s2w only seem to work with swipe to left...

so idk. it's all very annoying and because it's a feature that I would never use, it's getting really hard for me to care about supporting it. had I had a bunch of donations flood in, I probably would spend time on it, but that would be more like; "hey, this is turning into a part time / paid gig; so I better work that out". but that's not reality and there are far more pressing, important things that I would like to work on;

- working on getting the the locking and CPU hot plugging changes from upstream in, so that I can support some code that I can't until then. (it results in live locks or bootloops)

- improving performance and a wide variety or misc optimizations (that all add up)...

- getting some material together to help out people interested in using WireGuard VPN. (avoid people spamming the Dev thread or needing to go on #wireguard irc).

- getting my github possibly setup for continuous integration.

...and the list goes on.

so IDK. it may not matter until after the holidays, anyway. I'm housesitting starting on the weekend and probably won't be pushing any builds, after that starts... might get one out before then, we'll see.

my local build running on my device can just revert that code anyway, until I do make a decision (as it does now).
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] montbazon:
Personally I'm using only Sweep2sleep a lot. Because I want to preserve my power button wearing. That disturbed me.

For some devices it makes bootloop because worn power button let itself pushed

It would be great, if we could have S2W continuously.

Thanks
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] natri23:
I wonder if I should use the performance or power save mode in ex kernel to have better performance or save more battery?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
meh... Schedutil does a really good job, I don't do that.... I get 6hrs+ SOT everyday...

I do use the performance mode, set to performance governor just for proaudio apps - but that uses more battery, obviously...

you could use power saving mode and limit schedutil's Max CPU frequencies, but that will mostly just affect your user experience, more than anything... on sleep, you really shouldn't be draining much battery....
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
no worries, for now. I'm not doing anything about it...yet.

I'm working on other more important code, while I'm motivated and in the right state of mind to do it. 160 commits lastnight... running a very promising build right now, merging in a bunch of code that I've been working on/off... seems nice n fast, stable...

so I'll look at / test a theory with why wake gestures are being wonky later. after I get the bigger stuff I'm working on finished up.