yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mchockeyvette27:
If I do find a way to get a log during the crashes, which one of these is the most important to have? That way I can focus on trying to get a log of that specific type.

The only reason I say it's impossible to get a log during the episodes is because when I did get a chance to navigate to grab these logs before the phone rebooted itself, nothing was there.

There's no ramoops file in the FS folder, I go to terminal to get a dmesg log and it doesn't produce anything, and even just a regular log from Logcat, nothing even shows up in the app. It's only until I reboot that these files appears/become available.

Sooooo that's what I'm stuck with :/
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
Your only hope is probably adb during these episodes unfortunately. Logcat and dmesg should give us some ideas. Does the phone fully turn off or are they soft reboots?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Soft reboots. Where is dmesg?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
dmesg is the kernel log.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
How do you pull it up?

I had several in a row today.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
It'd be best to get these during a reboot session via adb

adb logcat > logcat.log

adb shell su -c dmesg > dmesg.log
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
HIGHLY unlikely. I can't usually get past the password screen and it reboots again.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mchockeyvette27:
If I can figure out how to do that through ADB and if it happens while I'm around my computer, which is rear, I'll post it.

It is a soft reboot, takes about 2-3 seconds.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Is there a way to run a script at startup?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Sorry for the delay guys, this week is finals week for me.so I've been busy studying. I should have an 8.1 build up sometime next week
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] lobrau:
No worries, thanks for your hard work so far kill those finals!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Neejay:
Thanks for the update. I figured you were in finals, good luck!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mchockeyvette27:
So should we hold off on installing 8.1 for now? Or will this still work with the current kernel?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jlokos:
The current kernel will not work on 8.1. As noted by the Dev on the previous page, he is working on an update.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] drewski_1:
or just run with the stock kernel until Electron 8.1 is ready
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Or, you can run other well known kernels...

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Sorry for the delay guys, I've got all of my v4 changes forward ported to 8.1, been running it all day. Seems pretty stable and much easier on battery than stock (at 67% right now, normally I'd be at at about 40% this time of day). Going to upload it tomorrow and get back to work on a custom PowerHAL (project treble is really screwing it up).
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
v4 is up! Changes include:

Rebased to 8.1

Upstreamed to 4.4.108

Undervolted CPU+GPU

More CAF Updates

Change Timer refresh to 1000hz

Use DragonTC 5.0

Add wake gestures

Force fast charge

You might get a popup saying "There is an internal problem with you device". This is due to disabling AVB and verity, don't worry about it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
No twrp zip flash version? [MENTION=916904]Frap[/MENTION] 129
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] blaze9090:
Just flash img as boot in twrp, then twrp.zip and magisk Zoo and youre good to go!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
No zip version, but you can do what the quote below this says to flash in twrp
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Feel stupid for having to ask but drawing a blank. Lol

If flashing the img through TWRP then TWRP.zip then the magisk zip (as described above), there is no reason to flash stock kernel when going from one custom kernel to another correct? Since going the img route is replacing the entire partition I believe. Only watchout would be to make sure kernel mod app has its data reset right?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] shag_on_e:
Yes, I like boot.img flashing for this reason. Just set kernel mods and setting apps to default then flash the Election boot.img, then TWRP, then Magisk and you're good. I was never a fan of the anykernel format just because it requires being on stock kernel. I know it has good benefits but I just like it better this way. Options are good!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] kauemelhado:
Thank you Frap129.

This kernel is really good!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Pixel devices don't have any of they're initramfs boot scripts in the boot.img, they're stored on vendor, so you don't actually have to be on the stock kernel to flash over it. As far as I know, none of the available kernels are modifying those files (yet). Only real reason to use anykernel is smaller download size I guess

Glad you like it!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bosox284:
So say you wanted to flash Electron over Flash. It sounds like you can flash the Electron boot.img without having to go to stock, but would you need to flash the stock dtbo first or is that not important?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
The custom dtbo only control's verity/AVB on the vendor partition. You can use his dtbo if you want it disabled, but if you're using magisk it'll get disabled anyway.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
[MENTION=1408256]fraps[/MENTION]129 thanks for the update. its smooth af.

2 questions though:

1. your magisk default module is still meant to be applied? since it says "only until twrp is stable". what would be the alternative now that twrp _is_ stable? a kernel zip one can flash? im asking cause i dont know which settings will be set by your module and will conflict with me setting up things in the exkm app.

2. zram is on by default as it seems. why is that so? i thought its only a "workaround" for devices with few ram!?

thanks :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
I can answer the second one: Google enables it on 4GB RAM devices to make sure memory pressure doesn't cause performance issues.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
is it advised so leave it on? should have some impact on performance if i do so, right? if we assume that the ram is big enough.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Yes the magisk module is still needed. As stated in the OP, you should not have to change anything outside of the module to get the best balance of performance and battery life. I'm trying to figure out the best method for applying default settings. Modifying settings via initramfs scripts is the standard, but that would require me to modify the vendor partition (people who dont want to disable AVB wont like that) . I could make anykernel flash the magisk module at installation, but that wont work for users that dont use magisk.

Thanks [MENTION=6842057]nathanchance[/MENTION] for answering the second question :P
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
I advise leaving it on. Google consciously made that decision.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
well if i want to enable wake gestures i will have to change something at least, right? since they are not enabled by your default module. speaking of, allthough enabled via exkm swipe to wake does not work for me.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] izati:
DT2W & S2W aren't working for me on this kernel either. The S2S is working however..
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
charging is screwed for me too. switched again.. :l
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Freak07:
Take a look at [MENTION=5051294]frap129[/MENTION] ’s github.

He already added the fix that will most likely cure this ;) so next version should have it working :svetius:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
question is: why didnt he leave a short headsup here for everyone. not asking for too much i reckon, especially since he just released this version and would have spared me a lot of trouble.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jaythenut:
I've installed earlier today I put phone on charge at 64% been on charge for 4 hours now on 95% just wondering if I've done some thing wrong have fallowed install instructions
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
nope. there is sth wrong with charging here.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] blaze9090:
Because he doesn't owe you anything and shares his work with us for free? ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
I'm using the same commits as flar2 and nathanchance. Probably broken all together becuase its a WIP.

Noted, will revert my fastcharge modifications in the nect build

Didnt notice this on my builds because I usually charge while I'm asleep.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
You didn't include the 1000HZ fix in v4, did you?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jaythenut:
Will say one thing the battery life is crazy good I'm at 79% and got 2 hours sot ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bosox284:
I'm using the Magisk Module and I've gotten Sweep2Wake to work using EXKM with no problems. DoubleTap2Wake seems to work , but it requires a very rapid double tap. I've turned them on and off and noticed that S2W would still function when off, but a reboot solved that. Could be a quirk with EXKM. Slow charging is the only thing that I can reproduce like others, but frap is aware and will be fixed in the next build
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Thanks for the reminder, thats probably whats breaking it :p
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Not judging here, just asking... With the fingerprint thing we have, what's the value of any other wake gesture? Seems a step backwards from a tap on the back of the phone. By the time it's out of my pocket it's open.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] kauemelhado:
The charging speed is really not right.

I tested with/without the Magisk Module (just to be sure heh) and it's really slow charging.

It says "charging rapdly" but takes forever. Flashed 'Flash 2.05' and charging speed was back to normal.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Already discussed and commented by the OP. It will be reverted in the next build.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] kauemelhado:
Yeah I know. But as I saw some folks that did not have this issue, thought it was a good idea to report that I'm having the issue.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bosox284:
Wake gestures are useful for someone like me. I keep my phone on my desk when I'm at work. So rather than pick it up and use the sensor, I can use S2W/DT2W and use the phone that way.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Cool. Got ya!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] elliwigy:
i havent had any issues.. i just boot to twrp flash the kernel i want, flash magisk and reboot.. g9nna try urs out now
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] MrBrady:
Will the Magisk Module work with other kernels (Flash, in particular)? I'm hesitant to run this until fast charging has been resolved. TIA
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
not asking for an eta or sth. also don't wanna express any expectations. just wanted to know if [MENTION=5051294]frap129[/MENTION] plans on updating the latest release? :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mchockeyvette27:
Glad to report that the reboots and crashes seem to have receded with the latest build! Have had none so far. Performance is great too.

Battery life has decreased, not sure if it's something on my end or the kernels end though. Looking forward to the new build!

Thanks for all the hard work!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Sorry about the delay, been quite busy lately (robotics season has begun). I'll try to get a new build up this weekend

:svetius:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Dude, no apologies necessary. Life happens. We all thank you for your work :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] madscribblerz:
+1
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] J85maurice:
[MENTION=5051294]frap129[/MENTION]

Hello sir. I just want to say that since trying electron kernel for p2xl there hasn't been any others that have touched it. You are aware of the charging slow issue on Dec build. I see you are very busy with robotics but just know the updated version is long awaited. So please please put out an update lol. It is the greatest kernel for p2xl. I swear on electron the phone would not f'in die. I'm having electron withdrawals. Thank you much
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] leathan:
Why do I keep reading this? I have now flashed every single kernel and rom i see available for this pixel 2 xl and i mainly use twrp.

1.) in the settings of twrp remove the screen timeout completely (screen will still sleep when needed).

2.) boot from the img unless you get off stock kernel.

Maybe im just lucky :D
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Yeah other than the time out thing you listed the fix for, MTP is the only thing left for me but I have had it installed since the very day beta 2 dropped. I got the img the very first time after clean Wilkes but after that it's zip files all the way!!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Due to the [MENTION=444219]msf[/MENTION]Jarvis and [MENTION=6842057]nathanchance[/MENTION] being the unbeatable dynamic duo, I've decided to discontinue this kernel. At this point, our kernels are extremely similar, save ElectroUtil and a few misc commits. Rather than put time into a modified Flash kernel, I recommend y'all just try Flash (warning: its pretty good). ElectroUtil and my other changes will live on in the CarbonROM kernel, and will simply be added on top of flash kernel. Thanks for supporting this project while it was alive.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Aye, nice to see you around
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Lawlrus:
Indeed, was glad when I heard you had gotten the device. Plan on flashing your kernel here in a little bit.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] skinza:
Came from flash kernel

Flashed and installed module with no issue,I too put the zip in magisk folder before installing don't know if that made a difference
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] 12Fully:
Will this kernel hide the bootloader being unlocked? I tried patching default and snook kernel with magisk (root and safety net passed) but a bunch of applications wouldn't run.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] kcteun:
Day one with electron using defaults and magisk. Much worse battery vs stock.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] LLStarks:
What exactly is the Magisk module approach? I've never considered using Magisk like that.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Coldfish9507:
i patched electron img with magisk manager and fastboot flash the patched img. My pixel 2 Xl cannot boot, stuck in google screen. Why ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Yes, it will.

Pics or didn't happen. My battery has improved significantly.

Initramfs boot scripts are not part of the boot image anymore, so we can't modify them without working twrp. The Magisk Module is a workaround until twrp is functional.

Bad download, bad patch, bad copy, bad flash? Take your pick. Try again from step one
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Coldfish9507:
I have tried multiple times with different kernels, like snoke, yours. Everytime, it was stuck on google screen and cannot reboot. Is there any issue with my flash commands ? I used fastboot flash boot patched_kernel.img
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
I do believe your fastboot command should be....fastboot flash boot patched_boot.img

I've done this a dozen times already and have never seen the word kernel in the patched boot.img.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
That looks right. When you unlocked your b/l, did you do unlock or unlock_critical?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Coldfish9507:
I used patched_boot.img actually. This patched_boot.img comes from magisk and I didnt change its name.

I wrote "kernel" here just wanna indicate it is generated by patching electron.img with magisk instead of stock boot.img with magisk.

I tried directly fastboot flash boot electron_v1.img, but my phone cannot boot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bobbarker2:
The module is setting some kernel settings 2 values the dev thinks are best. Here's a link to them: https://pastebin.com/eEpmSEUe

[MENTION=5051294]frap129[/MENTION] thank you for your contributions glad to see familiar names doing kernel development for the pixel 2... Had the pixel 1 and there was very little activity for it.

Why do you think 512kb readahead is optimal? Is it something specific to the maple IO? Any benchmarking or testing I've done in the past across multiple devices has always shown 1024kb (or more depending) to be best when your sdcard is 64gb.

Also what knobs are there for pwrutilx? I don't know much about the governor besides a few minutes of reading but it's based on schedutil and have some reservations about improvements on that because it's pretty damn efficient as it is. Not questioning your work, would just like to hear your genuine opinion or factual basis for using this kernel governor over others.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
512kb doesn't perform as well on paper, but there aren't any noticeable differences in the UI and lower readahead saves battery. pwrutilx has the same tunables as schedutil, just a slightly different frequency selection method that gives lower frequencies when asleep and to big cores when awake. However, I'll be replacing it with my own schedutil based governor in v2, so stay tuned for that!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Lawlrus:
Are you on the Sept or Nov update ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Xg3nFatality:
deleted
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
November.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Lawlrus:
That might be his.issue then.

I know I haven't sideloaded the ota so no custom kernels are working for me either.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Good call. Never thought of that one :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Lawlrus:
Key word is might, Im too busy raging at mobas to sideload the ota. But that's my assumption since it's not like I don't know how to fastboot and stuff. Fastbooting the stock imgs works fine
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bobbarker2:
There are a million walkthroughs and step by step instructions. If you've ever used a command line prompt it's pretty simple.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] THEbigSWEEN:
I think you misunderstood his post. At the end of the post he also mentioned about fastbooting the factory images. But you're correct, as long as someone isn't lazy, knows how to read and knows how to use the internet then there's no reason to not be able to use fastboot.

Glad to see frap on the 2 XL forums. Loved Electron on my 6P and can't wait to try it out on my new Pixel!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Lawlrus:
I wasn't insinuating I don't know how to do it. I said I've been too damn lazy to sideload the ota to test what I think is the answer.

I'm very much faimilar with fast boot and using the command prompt lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Shaffer678:
Battery life seem much improved but I've had about 4 random reboots since late last night
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
V2 should be up tonight or tomorrow morning! This version should fix the battery/performance complaints that stemmed from the powerHAL.

Changes from v1 include:

CAF Updates to cpuidle driver

KGSL Improvements

Devfreq wake boosting

Fingerprint scanner speedups

Add ElectroUtil CPUFreq governor

Trick powerHAL into accepting ElectroUtil

Fix some app crashes
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Lawlrus:
Get logs, a post like this serves no purpose. You didn't even explain what you were doing/the phone was doing when it happened.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Shaffer678:
Phone is idle when it happens. You're right that post served no purpose neither does this one. It doesn't concern me enough to get logs.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Lawlrus:
If you don't want to be part of the community and try to help development out, why even post you have issues ? Lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Reboots will be fixed in v2
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
You might want to find another place to host your files. AFH is really bad right now.

Is SeLinux set to enforcing or permissive with your kernel?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
Ahh, I thought AFH might just be slow on my end. Thanks for the tip. SELinux is enforcing
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Just so I get this right... You build root in Magisk with this kernel?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
No, you have to root yourself.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
1. Download the Electron boot image

2. OPTIONAL: Patch with Magisk

Umm..

What am I patching? Factory boot.img or your kernel?

That's where I'm lost.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] lasphyxial:
electron boot image is what you patch.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
That's what I thought.. thank you!

[MENTION=5051294]frap129[/MENTION] when I meant "build root" is to have Magisk patch your file instead of factory boot.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] lasphyxial:
1. flash a patched electron img with magisk

2. fastboot boot twrp-3.1.1-beta1-taimen.img

4. flash twrp flashable - https://dl.twrp.me/taimen/twrp-pixel2-installer-taimen-3.1.1-beta1.zip.html

5. flash magisk - https://xdaforums.com/attachment.php?attachmentid=4324974&d=1509987379

6. both those in same flash by using add zip button with twrp first then magisk

doing these steps little modified from the original instructions.. i have a flashed twrp on my phone and this kernel installed as well :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
What is the need for any step past 1?

From what I was reading, it doesn't look like twrp is stable enough. When dees said that it could format all data immediately, I don't like that.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] frap129:
One critical step he didnt mention was to install the Electron magisk module.