yashsingh1/xdaforums huggingface dataset:
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Your commit description was wrong, *you attributed it to me* and pulled in changes that you weren't sure about and didn't understand (or even need)... So I'm giving you clarification. It's that simple and entirely fair. And yes, I did have concerns;

***What if someone else came along and cherry-picked that commit from you? I never told you that's what my changes to the makefile were doing.... Next, they may come and ask me about your commit; that you decided on your own to attribute to me... Seems only fair that I would voice my concern and point out the mistake, since I didn't want any part in it.

It's not a big deal -> there is just no reason to tag / attribute me (or anyone else) in your commits. (especially not bogus ones). If you properly cherry-pick (like you say you do), then you wouldn't be doing that anyway. I'm not worried about a single commit, your missing the point. (that would only apply if they were my commits / future cherry-picks).

Regarding modules;

Look in the defconfig => CONFIG_MODULES=y

then look in your devices file-system; /sys/module/*

Every kernel device driver in linux is a loadable or builtin module. ie: *Anything not apart of the "base kernel" is going to be a module. Linux kernel design 101.

A bad choice of wording on my part (picking random commits); my bad, Sorry. But I wasn't meaning to imply anything by it.... I'm also not trying to have any sort of contest with you. You are taking things way too personally / missing the point.... and I'm no expert on C.... I wish. ;) but being as the kernel is written in C ~ it's kind of important to have some knowledge, yes?

I don't care if you cherry-pick from me or use any of my code or not. It's all GPLv2 code, freely available to use: I just warned you that there are a ton of changes that are interdependent and may cause you problems. Which contrary to your comment below - IS courteous and I didn't need to do that at all...

There was no reason to PM you. This is your thread pertaining to your kernel, so I posted here... I wasn't being discourteous or trying to embarrass or attack you, your kernel or anything like that.... When I pointed out a mistake/issue to another dev in their thread, recently; They had no problem with it, thanked me and he was happy that I pointed out the issue. *Maybe it's your perception that i'm being discourteous; but that certainly was not my intention or even the case.

But, you can keep your condescending remarks to yourself, thanks. * If you don't like the way that I post; don't subscribe or visit my kernel thread. I do post updates, as I go ~ Sometimes, they are progress type reports, sometimes it's me thinking out loud and I've found on the Pixel forum => some users have been interested in having more info.... ***You also have the option of putting me on your ignore list... It's that simple.

and yeah; don't tag me.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
For the sake of I just don't care to argue with you . I agree your points are mostly right , I never even put a kernel out that included the offending commit , therefore I figured you would have contacted some other way . Guess you came off the wrong way to me . No offence I suppose .

I was under the impression that when modules were being talked about , it was a loadable module , like a *.ko . I just called built in modules --drivers .

Sorry again for the miscommunication . And my comment about your lengthy statements was sarcastic , I apologise .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Sounds good. dropped.

But just to clarify;

I would have no way of knowing if you had built your kernel with that commit - I only see it in my inbox && on github... I was never concerned as to whether or not you built a kernel with my makefile changes - it was you attributing that commit on github to me. That was the problem.

and yeah; drivers *ARE* modules built-in or loadable. doesn't matter.

and just as an aside; your kernel does look pretty good. some nice features in there. I'm obviously headed in a different direction, but if I wasn't; I might have given it a spin. ;)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Apologies again . I took your first comment the wrong way . I should have just taken the knowledge you were trying to give me .

Lesson learned ....

The goals I have for my kernel are pretty basic , just looking to add the best features while keeping it basic.

I did a lot of backporting and experimental work on the 3.0 omap4 Galaxy Nexus kernel , and it was more work than I could handle.

Have you tried compressing your kernel in xz ? I tried enabling it for arm64 , but couldn't get it to build an Image.xz-DTB . Not sure if it would shrink the kernel small enough to install recovery , but it had me curious .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
water under the bridge. all good, man.

yeah. pulling in features, driver mods, etc is usually easy. backporting gets hard. on my kernel, backporting the missing bits for EASv1.4 took effort; most of that code is from android-4.9-eas, or portions backported to 4.4 kernels. our kernel was missing functions + arguments were different... lots of issues to fix... my current upatream backports of scheduling/locking/workqueue code from mainline were also fairly manual... the sched code is painful to work with.... so i definitely know what u mean... but at the end; i will be using linux-4.4 for all of that code + the eas changes... (I may be stuck with linux-3.18, but it doesn't mean i can't upgrade subsystems. lol).

keeping thinfs basic isn't a bad thing - it makes maintenance much easier. so it's a good strategy. plus, u are still picking up the features that u want.... definitely smart.

pretty sure lz4 is better. myself, I'm not interested in supporting TWRP installs. there are times when I enable lots of debugging on test builds, or add features, etc that make the kernel grow - I need room in the boot partition...

oh BTW, you said you are using -O2 optimization. I don't think you are. it looked to me like, you were using some -02 / -O3 flags, but still optimizing for size; -Os. ....
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
OP updated with a new kernel for stock Android 8.1.0 , been running it for a while . Runs beautifully. Hope everyone had a good holiday and enjoys some life.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Op Updated with R2

nothing major just some updates to memory/memory controller from Android MSM 4.4 kernel source. I.m not inline with 4.4 but pretty close

flash if you wish .......
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
OP Updated

_R3 uploaded .

Linux 3.18.89.

Switched to UKSM .

Also zswap can now be enabled/disabled on the fly insted of just at boot .

Just an FYI : the "overclocked" frequencies I'm using for the CPU and GPU are straight from the msm8996pro files , the one plus three uses them . I see no reason why they would be harmful to our device. I've had great success with them , temps and battery temps are great as well . My guess is they underclocked the pixels for powersaving reasons only . I haven't had a single reboot or boot loop running this setup .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Op updated with R4

- Frontswap and cleancache inline with linux 4.15

- added new zswap allocator "z3fold" can compress 3 pages at once vs 2 for zbud

- can now choose zswap compressor lz4 or lzo

- selinux improvements

- binder is inline with msm-kernel-4.4

- updates to android low memory killer (Adaptive LMK)

- updates to mm/compaction
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
Using conservative on small cluster and blu_active for big cluster. Seems to use much lower frequencies on <15% load. No noticable lag either.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
OP updated :

- Linux 3.18.90

- patched zram to linux 4.4

- some mm updates

More info can be found here
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
It seems as if setting max cpu frequency in exkm or other kernel management apps doesn't stick. My device doesn't mind the overclock but it would be nice to have more control.

I was testing on stock ROM before but now I'm running benzo so maybe it'll behave differently. I'll report back after flashing r5.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Not sure what would cause that kernel side . I have been using exkm as well and the freq definitely stick on stock 8.1 . I use cool tool for real-time monitoring that's updated every half second, also the time in state cpu charts confirm as well .

I would probably suspect the ROM having a script that's setting the freq.

Glad to hear the over clocking is solid . I'm quite happy with it. I usually use interactive on both cores or sched on little / interactive on big , pretty solid .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
Yeah it was behaving like that on stock so it wasn't ROM side, also I noticed exkm would report little cluster at 1593 after setting it to 1.9ghz and leaving it for a while.

About to flash on benzo
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
Yep, same behavior as stock. I set the max to 1593mhz, set governor to sched, reset cpu time in state stats. Exit exkm, flick around for a few seconds and when I check there's a small percentage of 1996mhz.

Now granted, if I set the max to 1996mhz, the amount of time will be much higher but I thought I would add in my two cents.

Edit: ok so after investigating some more, I've deduced that it's governor related. On sched it will ignore the max CPU rule, but on blu_active or interactive it plays nice.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Your right , sched ignores the freq. Probably eas reasons . Im pretty sure I remember noticing that behavior as well a while ago but just forgot to note it because I wasn't using that governor at the time lol .

I'll see what I can do with it .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
I'm using conservative and blu_active now and all is right in the world. It's running really well on benzo
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Good to hear , I was going to take the dip into the custom 8.1 ROMs but I'm good with stock for now.

I believe the sched governor purposely doesn't use the boosting freq . If you set the big core governor to sched , it will use the 2.3 GHz freq , but the little core will not use 1.9 , the way the code was written the freq isn't implemented the same way as the others . I'll see if it will hit 1.9ghz on 100% load , like on a benchmark even if it's only for short periods .

Edit : yeah , it still does achieve 1.9ghz using sched governor . It takes a high cpu load to hit it , and it's for a second at a time it stays there, but again i believe it was written this way intentionally.

Using other governors will actually use the boosting freq as the max freq .

Either way it works quite well for my device . I haven't had any extreme temps or reboots. Only reboot I got was zram related , but i patched zram up and it's behaving well with the other mm patches to zswap and all the other z drivers lol .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
OP updated to R6

-- All behind the scenes changes

- updates to sysfs and arm64

- updated blu_active

- various other updates from Linux 4.x+

-- Every change is posted on github

Enjoy .. Still running well for me
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
Hey bud, so I'm using the 7.3 camera NX and I can't for the life of me figure out why it pixelates with your kernel. If you're feeling ambitious could you take a peak. The camera itself still works just weirds out on the Portrait Mode. If you have kids the setting for portrait is crazy good. At this point I'm more curious how it's happening than anything else.

Look, don't look whatever, thank you for the kernel.

https://chromloop.com/2017/12/apk-enable-portrait-mode-nexus-5x6p-og-pixel-phone-google-camera-mod/
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Darian71:
This baby is BAAAAD to the bone! Best overall performance of any out there on my opinion. This is the 3rd day using it and it just gets better! Thanks man! BTW, did you Dev for the Galaxy S3 at one point?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Definitely interesting lol . Your not the only one with that issue using that app . It's probably a commit I pulled in recently so I'll take a look and try to fix it .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Haha glad you like the kernel .

No , I never had an s3 , I think some people in that community threw my name around back then trying to get me to help out with f2fs .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Darian71:
Getting old stinks! Lol. I've owned every Galaxy device (excluding the Nexus) until Samsung locked them down. And a few LG's. I do remember your name but danged if I can remember. Thanks again. Have an awesome day sir!
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
I still have my Galaxy Nexus lol. Loved that device.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Me too . Just needs a battery..... Lol . I was gonna order one off ebay just to dust it off and mess with it .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
It works in your second release and freaks out in the third. Thanks bud.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
That helps tremendously actually. I was just going to ask if that bug appears in any of my releases other than R6. Now I believe I know at least where to look. I think I have an idea of what it is. I'll build a kernel to test when I get home in a few hrs .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
It happened to me on r5, was going to report it but got caught up with something. Then I saw others mention it so I didn't bother commenting.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
So downloaded nx cam v7.3 .... I definitely see the pixelated screen on portrait mode.

Hang tight , should have a fix soon.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
Thanks man... I'm back on your R2 anyway... I had to knock you back a little and underclock... I run high brightness mode and I can actually watch my battery draining while I screw with Substratum... LOL. I've never had this phone so smooth.

I gotta stop flashing stuff on my phone... I think I'm an addict. Seriously thanks... I can't even use 8.1 without your Kernel anymore.

----- ohhhh. Is that camera not friggin ridiculous on the portrait mode.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Lol HBM cracks me up . I normally have my screen down almost as low as it can go . My eyes are sensitive to light ( I sneeze going from dark to light ) , so HBM is super bright to me . Glad everything works great.

I have been using interactive across the board , GPU oc'd and def both cores over clocked. I've been happy with zram and it's behavior so far.

Zram is still a little strange. Like I can't switch compressors from lz4 , so I know I messed up something somewhere , but I've been messing with zram since the gnex days . I ported all the 3.18 zram zmalloc zswap zbud zcache frontswap setup to the gnex 3.0 kernel .

Anywho , I found the offending commits , 3 stragglers , all commits for reserving unified buffer space . I remember taking pics after commiting those , I didn't catch it obviously cause I didn't have nxcam . All good . New version should be as soon as I can upload .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
OP updated to R6.1

Fixed pixelated screen in portrait mode using NX camera app

no other changes
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
Pimp status... I'm stuck with a few things, your Kernel, camera for my kids and HBM when I'm outside, but I'm half blind. Battery-wise I usually take a beating from Bluetooth headset and i was flashing back and forth multiple times R6 to R2 this morning on my way to work. That with my hi-jacked Corp email destroys my battery. I hate using my iPhone 7 so I forward everything here to my Pixel XL. I was down 50% in a little under 2 hours.

Seriously though underclocked on R2, It still just runs no lag... Your the Kernel wizard bud. Wish I could learn or knew half of what you guys do. 'preciate you... Are you running stock or something else (Razorloves CM 15.1 is the best CM version I've ran on this phone...but I'm on Pixeldust here). It won't work with CAF right?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Yeah , I'm still stuck on stock images. I don't require a lot of extras in ROMs , just init.d really .

As far as it working on CAF based ROMs , idk . I say try it , worst that can happen is no boot . But I can't say honestly. I've pulled some CAF commits in , but I'm pretty sure the sources are pretty different .

If not , I'm sure somewhere in the future I could make one .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
You're on. Youll have to give me a minute. I did try on some previous versions of your Kernel but that was before I figured out that Magisk 15.0 needed to be flashed (when I flash 15.1 I hang at the Google screen) most of the stuff I learn with these slots is just trial and error. Worst case just Flash-all and start over.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
CM 15.1 and a little NSFW R6.1.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Dachfenster:
Could you tell me the steps you've made to get it working?

Tried various things with the slots (still a noob regarding this topic tbh) and got it to boot once. But I forgot to flash Magisk back then so I flashed 15.2 which didn't boot.

After I've read that you used 15.0 I started from scratch again. Unfortunately, I wasn't able to get it to boot at all (neither with root nor without).

Any help would be appreciated.

Edit: Nevermind. Played with the slots again and got it working now.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
Here's my process with the ridiculous slots. After hundreds of flashes and getting stuck on the wrong boot slot...

Let's say you want to start over and try Pixel ROM again. For me...

Make sure!!! My security is disabled because I'm going to end up back at twrp 3.2.0.0

Flash TWRP 3.2.0 (I'm usually on 3.2.1) reboot bootloader manually reboot recovery (Hit reboot system after the flash and hold volume down--- I don't trust rebooting recovery)

Flash ROM, Flash 3.2.0 reboot bootloader manually into recovery.

Flash gapps reboot system and boot up.

To flash a kernel...

Reboot recovery works on 3.2.0 and 3.2.1 but if you bootloop and can't get back on .1 your hitting format data to blow out your security.

Flash kernel and flash TWRP I usually hit 3.2.1... now so when I break a setting I can reflash the kernel without resetting my fingerprint...

Reboot bootloader manually reboot recovery.

Flash Magisk for this kernel Magisk 15.

Anything bad that happens if I follow those steps Is Magisk related, so I'll hit 15.1 next or whatever it may be. (This should be Patching the boot correctly for the Kernel)

To change recovery for 3.2.0 to 3.2.1

Flash new Recovery

Reboot bootloader and reboot recovery

Flash Magisk

Reboot system

Happy flashing. I would imagine this would work for most.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Op updated to R7

- Linux 3.18.91

- Jan 2018 security updates

Happy Crack Flashing lol :p
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
Killing it.

R7/Blu-active and CM15.1 are smooth as butter. No lag, no drag. Thanks again!!!

Made no changes to the kernel besides the governor. 3 hours screen on and phone calls since 8am and I'm at 50%!!!
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
OP updated to R8

- Added ZZmove governor VR io-scheduler and sociopath TCP controller

- Minor code change to io-schedule switcher

enjoy

i added a link to the op for all the previous releases ( for whatever reason someone might have running an outdated version )
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Idk why I can't get kernel to work I flash ROM and twrp then reboot so I'm on slot b. Then flash back to twrp flash gapps then do initial boot. Now I go back to twrp when I flash kernel on twrp I get boot loop I install magisk after kernel am I doing it wrong
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
I will assume you are using a custom ROM but it shouldn't matter.

Set the ROM up as you normally would .

If you have verified that all is well ,

flash this kernel .zip . Reboot. If you are rooted and lose root , reboot back to recovery and flash your preferred root method .

The kernel installer shouldn't touch the ramdisk .

As far as your steps you are taking . I haven't installed any ROM but stock system images on my phone so I don't know exactly what is needed to get a custom ROM booted on this device.

But you should be installing this kernel in the same slot as the ROM .

I fastboot flash my kernel images via fastboot most of the time , but again I use factory system images .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
I install ROM on slot a along with twrp then reboot to slot b I actually just restored benzo ROM kernel and its fine not sure what issue is I'm gonna try again
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Herk718:
You must "fastboot flash boot boot.img" of whatever factory image your on, right before flashing NSFW-Kernel.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Op updated to R9

- added Adreno Boost parameters to msm-adreno-tz GPU freq governor

- added TCP congestion controllers agileSD and CHINA ( agileSD is supposed to perform well on short-range High bandwidth networks . china is supposed to be experimental and highly aggressive... )

- a few other small commits that should go unnoticed

enjoy.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Mikkey81:
Boot up Rom

1) Reboot into recovery

2) Flash Kernel and flash TWRP

3) Reboot the recovery

4) Flash Magisk 15.0 (other versions may work and I've had issues with 15.1)

5) Reboot system

Dueces

EDIT>>>>.... Whoa... R9 in a little angry with the twrp 3.2..0 Recovery (installer after a recovery reboot) at Number 4 above it wouldn't decrypt and open back into TWRP.

so... I had to go to the bootloader plug in and fastboot flash twrp-3.2.0-0-marlin.img to reenter and flash the Magisk File. (Maybe the kernel size with all of the additions is getting a little on the larger side??? don't know...) That worked but previous versions and confirmed on other kernels aside from the EAS Shade kernel which has special requirements for flashing...

I'll play with it a little tomorrow afternoon but I'm out for now. I am sure flashing the boot.img file works (As mentioned previously above... though I just found this easier since I don't have to go back to a computer ever.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Darian71:
On PixelDust ROM (R2) you must flash the vendor.img before it will boot. With this kernel, it performs really well. Fast+excellent battery life. Although the ROM still needs fixed to use some social apps.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Any chance of wireguard support
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
It's supported , I guess I forgot to update the description or it got removed in a copy pasta job .

Lol .
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] :
Big thanks bro now if i could just get it to boot on benzo rom
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bsmitty83:
Op updated to R10

- Linux 3.18.92

- minor updates to fscrypt and ext4 as well as lz4

- flash if you want the latest version or just feel the need to flash something lol :laugh: