yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy Note 8 Questions and Answers] krabman:
I'm not sure why it isn't here, battery life is similar to other roms for me, none of them stand out in my use although they are all better than stock. This I think is because I never bothered debloating before I got root but have ever since. Renovate isn't horrible in terms of gimped features but you have to get the uprated pay RICE in order to change the buttons. It's a good rom and I'm not knocking it but it is no more stable and greatly underfeatured compared to Infinity so what you end up with is a rom which isn't objectively better in any way but is objectively worse or lacking in some ways. Right now we have the stockish roms and a couple that are going the Pixel route. People are going to prefer one of those takes over the other but the Pixel stuff is still a bit under cooked at the moment, no insult to those guys, it's harder to do and takes some time to sort out. Realistically Infinity is in the rare position of being a step ahead of everything else at the moment. None of the stockish roms work better or offer more and the Pixel stuff is still in the sorting stage. Like I said, most installers wont be feeling the need to go back to renovate until something changes.
[Samsung Galaxy Note 8 Questions and Answers] masri1987:
is infinity an aroma setup? won't need all those sound mods except v4a
[Samsung Galaxy Note 8 Questions and Answers] krabman:
Yeah, but the sound mods are an all in option. The aroma is not detailed, you can leave out dex, the sound mods, a few other things, thats about all. In practice all the sound mods have master switches so it can be interesting to go back and forth and see whats on offer between them. Viper is a love/hate thing for me. It's the best IMO and yet I can find myself lost in A/Bing the options and forgetting that I'm actually trying to enjoy listening to music.
[Samsung Galaxy Note 8 Questions and Answers] opasha:
One of the most well written summaries regarding everything. Thanks for this. My setup is super clean with Dr. Ketan's N4 rom with Iron Kernel 1.1.1; however, I'm looking to move onto something with a bit more modification if it's in fact better. I'll keep an eye on infinity. :highfive:

Also, my magisk manager crashes when I try to check safety net with 14.4, however, no reboot issues or loss of root whatsoever and safety-net is in tact. So, it's not really a big deal. :good:
[Samsung Galaxy Note 8 Questions and Answers] metzo32:
I was used Reno long time on many devices, Have no issue at all But with this issue of OEM I want to keep it

Front of my eyes all the time :D,And to get rid of my CSC now I'm on the Vietnamese one and every thing so smoothed! I flashed 3 times now to adjust Xposed and then removed forever and replaced with other moods

Like this Black YouTube it's fantastic! I had Korean device before and living in Moscow so I use to look at those

sites Tai and Viet..Hope to found stable New Rom soon, By the way over 3 days now never lost Root anymore

With this new 14.4 Excellent work :good:
[Samsung Galaxy Note 8 Questions and Answers] masri1987:
i experienced some strange ish overnight, phone lost root, and did a settings reset per se, alll my settings were defaulted even my default keyboard went back to samsung. So gonna switch to infintiy and see what y'all are tlaking about. It's only 1.9 gb so it must be debloated
[Samsung Galaxy Note 8 Questions and Answers] masri1987:
so i am about 6 minutes into booting up and i honestly think there's too much going on with this ROM, also it's built on a vietnamese base, and provides me with vietnam based apps upon setup.

Also, these animations in the notification pull down are ridiculous, and the signal placement \ status bar icon placement mimics iOS.

had the rom been more debloated or offered more aroma options, and came with their settings set to default touchwiz settings with the options to modify it further from there i might reconsider, but the out of box modifications without my choosing got me hella annoyed already

Also, wtf is samsungapex ? it asked me for root access as soon as the phone booted, in the welcome screen. i did a clean install.

I do not see that on Renovate in regards to samsung apex
[Samsung Galaxy Note 8 Questions and Answers] masri1987:
now i can't get rid if the fuggin device security mcafee nonsense ,

I never had this problem before trying infinity wth , how do i reemove this mcafee bs!!
[Samsung Galaxy Note 8 Questions and Answers] krabman:
You can just uncheck the two carrier apps at startup and they wont install. If you didn't they are not system and can be uninstalled. There is some BS with the new initial setup that is affecting a lot of roms, you've probably noticed half the google apps you tell Reno not to install end up in the initial start up anyways and cant be deselected. You see it over and over with the roms.

You can adjust the status bar and other things back to stock or whatever you want, it's no loss since you need to roll through all those settings and get them tuned to your needs anyways. This isn't to say I don't agree with you in that because I do, they should not have had all that trash enabled at boot like the awful scrolling animation.

So to start from the beginning uncheck the carrier app install at start. For the rom control to work you have to give it root, that will solve a lot of weirdness right off the bat. Then you need to roll through those settings and get the status bar and other things tuned up. At that point you're at situation normal but have made use of a lot more options than you have elsewhere. From there you can debloat the things you don't need just as you have to with Reno and most of the others.

As to McAfee, I've no idea where you picked that up. I've been on and off the rom a few times and seen no sign of it. I'm on it now and I just tried searching around the GUI and had a quick look at the build.prop and a few other places and turned up nothing. I'm kinda wondering about your download...
[Samsung Galaxy Note 8 Questions and Answers] masri1987:
14.5 still loosing root...
[Samsung Galaxy Note 8 Questions and Answers] Lmax579:
I'm assuming this is only for exynos?
[LG V20 Questions & Answers] beastofexmoor:
I have a hopefully simple question. I've used a LG G4 for the last couple of years and now that it's seemingly died I'm looking at going to a V20 due to the low cost for a year old flagship-level device. Previously I'd sworn I'd never buy another LG phone because of one "feature" on the G4. When the phone is charging and hits 100%, the phone makes a loud noise unless it's on silent. It's not a notification so being on "do not disturb" does nothing. This has woken me up dozens of times over the last 18 months. So tell me, does the LG V20 have this "feature"?
[LG V20 Questions & Answers] MikusP:
I don't think so. I do use DND at night but have not noticed this issue when charging during the day, so I'd say it doesn't. Sounds like a ridiculously annoying feature tho...Who thought that would be a good idea?
[LG V20 Questions & Answers] One Twelve:
I miss that feature from the G4 too. No the v20 does not play a sound when charging is complete.

Coming to terms with no notification light too which the second screen is supposed to replace
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
According to Project Treble lead Iliyan Malchev,

Now that there's an Oreo beta for the Essential Phone that supports Treble, perhaps this can be used to further development on the device.

/u/foremi on Reddit confirmed that simply flashing a Pixel 2 system and boot image to the device is not enough, as it fails to boot, so the question is what constitutes a generic AOSP build?

I don't have Linux installed right now or I'd build it myself, but I suspect that building it with the simple target device of "generic" might be what Malchev is referring to.

If any devs would like to test this theory or give their input as to how they think this actually works I think it'd be incredibly useful for not just Essential phone development, but Android development as a whole.

EDIT: [MENTION=1915408]phhusson[/MENTION] confirms that the target device should be aosp_arm64_ab
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
FWIW "generic AOSP build" is really what it says it is.

I have access to the "Google certification generic AOSP build" (that's weirdly not public, I don't know why), so I gave it a try. (Edit: So if the ROM was Treble-certified, it would work)

I get the Android bootanimation, but that's all (I have to say that's still a big step forward compared to other Android versions ;)

Looking at the logs, I see a loop of crash because of: /vendor/bin/hw/vendor.essential.hardware.sidecar@1.0-service

Which I guess is the HAL for the accessories, but that doesn't seem to be the reason for the crash

The reason of the crash, seem to be this:

11-15 12:59:04.491 5331 5331 F MediaProfiles: frameworks/av/media/libmedia/MediaProfiles.cpp:329 CHECK(quality != -1) failed.

in CAF, frameworks/av/media/libmedia/MediaProfiles.cpp we see vendor-specific (i.e. not in AOSP) quality attributes, like "vga"

And it is defined by Essential's framework (in vendor/etc/media_profiles_V1_0.xml)

Considering there are media_profiles xml files, I'd guess that _V1_0 is supposed to only contain AOSP-capable qualities

Edit2: The fingerprint of "certification generic AOSP", is Android/aosp_arm64_ab/generic_arm64_ab:8.0.0/OTR1.171023.001/4412360:userdebug/test-keys

So my guess to build this is that lunch aosp_arm64_ab && make should work

Edit3: the generated fingerprint is too long to build, needs to do make BUILD_NUMBER=4412360

Edit4: To make the situation more clear:

- NO, current ROM is NOT Treble capable

- BUT, almost everything is available for that. Every HAL is using "hwbinder" which is the basis, and most work needed for Treble

Also, I've seen some reddit comment mentioning boot.img.

Current version of Treble only concerns system.img, and NOT boot.img!

Future version are supposed to have generic boot.img as well, but that's not to be expected before at the very least Android P.
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
I was gonna link to the aosp_arm64 make file but it said it was specifically for the emulator so I wasn't sure, that's good to know though.

Thanks for this, I suspected such but couldn't find a clear answer from Google on the matter so I suggested trying the boot.img as well just in case.

Now, someone has to test this on a different Treble device such as the Pixel or Pixel 2. I'm thinking MAYBE because the Oreo build for essential is just a beta its treble implementation isn't finished and hasn't passed Google's CTS requirements to boot the generic aosp image. Perhaps this will change in the final build.

For what it's worth I only have a LG V20 right now which currently doesn't support Treble, so I'm pretty useless as far as testing anything goes, but if this is figured out it'll greatly influence what device I go with when I eventually upgrade.
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
Yup. I feel like Treble deserves its own "device" section in XDA ;)

I'm afraid I'm working on something that other people already did on other devices...

That's my guess as well.
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Interesting stuff. Excited to hear updates on this. PM me if you make a breakthrough and want a feature :)
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
There's not much I can do on my end sadly, without a Treble capable device, but if anyone is interested in trying this on another device with a mainline Treble-enabled Oreo build I'd install Linux and post the build up so just let me know ;)
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Google Pixel/Pixel 2 will do, yes?
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
Yeah they should be fine
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Alright, I'll find you some testers :)
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
Here's the system image if you find anyone, it's a straight fresh build of aosp branch 8.0.0r34

If it doesn't work it's possible that I messed the build up, but it should be fine.
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
Can someone running the Oreo beta post their results running this app?

If the beta isn't CTS compliant, we should know.
[Essential Phone ROMs, Kernels, Recoveries, & Other] TheDethEgineer:
Hero you go
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
Thanks a lot!

This is interesting... according to Malchev, CTS testing REQUIRES a device to boot a generic AOSP image, and yet the Oreo build is CTS certified and doesn't boot the AOSP image...
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
That's true only for new devices, not for devices upgrading for nougat to oreo.

I wasn't aware there was an AMA yesterday... Too bad we could have asked.
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Tester with OG Pixel XL says it gives invalid zip file format error when trying to flash in TWRP
[Essential Phone ROMs, Kernels, Recoveries, & Other] PresidentMcCain:
How about flashing the system image directly from a Pixel 2 XL? ;)
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
It's not a TWRP flashable zip, you have to extract the system.img from the zip and flash it with fastboot in the bootloader.

Also as [MENTION=4154904]PresidentMcCain[/MENTION] said, seeing the results of flashing a pixel 2 xl system image would be interesting too.

Oh and make sure the tester's OG pixel is already running Oreo before trying. Just adding that in case they didn't upgrade yet.
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Ah, I see.

Do you happen to know the exact command? I'm not that familiar with A/B partition devices and how that changes fastboot commands.
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
I believe it should work as normal

fastboot flash system system.img

EDIT: Apparently with the A/B partitions you'd do fastboot flash system_b system_other.img to flash the b partition, but the aosp build didn't include a system_other.img so I'm assuming perhaps it's not necessary
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
So far I still can't find anyone willing to flash this on their Pixel haha. People are really hesitant to flash stuff on the Pixel it seems. Times are not like they used to be =\
[Essential Phone ROMs, Kernels, Recoveries, & Other] rignfool:
The security hardening... Plus the average Joe being on XDA... And fastboot being a four-letter word...

It's more lazy than anything... Or a lack of knowledge
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
My Pixel 2 comes in next week I think. If nobody tries it then I'll do it myself
[Essential Phone ROMs, Kernels, Recoveries, & Other] Chronzy:
Lol oh the entitlement. No one owes you their device for experimentation. I had this thread saved and was thinking about helping out until I saw these c*nty posts.
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
You're reading too much into our posts.
[Essential Phone ROMs, Kernels, Recoveries, & Other] PhantomGamers:
Out of curiosity do some of the XDA writers not get review devices?

I sent a "tip" to Android Police hoping maybe one of them would be willing to try it since I thought maybe they'd just have devices lying around but I guess not lol

I suppose review devices are required to be sent back after maybe? Not really sure how that works
[Essential Phone ROMs, Kernels, Recoveries, & Other] Mdaly001:
I have a pixel 1 XL I am down to test with. Someone just guide me as to what's needed?
[Essential Phone ROMs, Kernels, Recoveries, & Other] 2390:
So if it can't boot a standard AOSP image, does that mean that the Essential Phone isn't really treble capable? I'm a little confused
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
So, I've got some progress, though still nothing I can show/give

As I mentioned, the /vendor/etc/media_profile_V1_0.xml is wrong for Treble compatibility, but modifying it makes Android boot much further using Google-provided image (called GSI)

Though now I'm hitting the usual signature of apps in /system changed, and I don't really want to go through backup/restore hassle yet.

As for building a ""generic aosp image"" by myself, it's still no good at the moment, and I've found several proofs that all the sources for that are not available at the moment!

Firstly, I've found that the system.img you generate MUST NOT be dm-verity signed, to let the kernel boot, this isn't easily possible in current Android git. (It can be done by commenting build/make/target/product/verity.mk)

Also, some properties are mismatching.

Though, I think the gap is not too big, so I'll try to fill it without waiting/hoping for Google.

Edit: Grmbl. Now that I could get the ""generic aosp image"" to boot, I couldn't boot back to stock ROM

The fix is to rm -Rf /data/system/package_cache/

(And multi-slot bootloader/system.img is awesome to work with \o/)
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Download the zip from the Mega link posted earlier.

Unzip it.

Reboot your phone to the bootloader

Then open a command prompt and change directories to where you unzipped the file.

Finally do this command:

fastboot flash system system.img

Basically... I'm not really sure about why Treble device with passthrough HALs can't boot an AOSP image
[Essential Phone ROMs, Kernels, Recoveries, & Other] Mdaly001:
Cools Ill give it a shot late tonight and will report back
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Thanks very much! Looking forward to seeing how it goes. Be sure to make a backup in TWRP first!
[Essential Phone ROMs, Kernels, Recoveries, & Other] 2390:
In theory, were this fully Treble capable, it would basically mean that a user could download a stock system.img of P or Q when it comes out and upgrade without modifying the ROM, right? Could it be that Essential is waiting until the full Oreo release to finalize the code?
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
It is this simple IF all HALs are migrated:

The Treble HALs have per-component version numbers, like "audio hardware HAL can do versions 1.0 and 2.0"

And then, the system.img says "I can support audio hardware HAL number 2, 3, but not 1"

And since both support version 2, audio will work, and it will use HAL version 2

I'm quite optimistic, and I think that HALs will be supported for several years, and community might very well extend this support. So yeah, for P/Q, it should definitely be good.

Also, please note that it is possible to make a stock system.img which works on all Treble-compatible devices (for one architecture that is, i.e. one for arm64, one for arm32, one for x86), but it doesn't mean that any system.img which is using Treble will work.

Nope, full source code for Oreo is already available.

The missing parts I mentioned are only to be able to make the "stock system.img"
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Do you have such a stock system.img you can share?
[Essential Phone ROMs, Kernels, Recoveries, & Other] Mdaly001:
k finally just got a chance to flash it. Does not complete boot after flashing the image.... Shows google and never gets past that, just shuts down.
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
Same. Just tried it myself on a Pixel 2 XL—doesn't boot.

---------- Post added at 06:05 PM ---------- Previous post was at 05:57 PM ----------

You were able to successfully boot a generic Oreo build though?
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
Ok, so I successfully built and almost booted an AOSP-built system.img!

You can find it here:

https://we.tl/qF8V8lDthB

Please test, and report precisely what happens (instant reboot, stuck on "android" bootanimation, booted?, ...)

At least because of application security keys, the device requires a factory reset . Since this device is my go-to device, I really don't want to do a factory reset, and I don't have backups yet. So I couldn't get past those PackageManager errors, and I'm stuck on "android" bootanimation.

The build instructions are as follow:

- Use AOSP android-vts-8.0_r4

- Replace system/core with https://github.com/phhusson/platform_system_core/tree/android-vts-8.0_r4-phh

- Replace frameworks/av with https://github.com/phhusson/platform_frameworks_av/tree/android-vts-8.0_r4-phh (this is needed only because of the broken support of Treble in Essential Oreo Beta)

- . build/envsetup.sh && lunch aosp_arm64_ab-userdebug && make -j12 BUILD_NUMBER=4412360

PS: Since this is my go-to device, testing is very annoying. Would someone have some recommendation on how to get a cheap Treble-ready device? (I'm in France, so Family code on Essential won't work for me)
[Essential Phone ROMs, Kernels, Recoveries, & Other] Interceptor777:
maybe a screen cracked bad condition pixel 1? should be cheap
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
I received my Pixel 2 yesterday and I can use it to test this. Will flash and let you know how it goes.
[Essential Phone ROMs, Kernels, Recoveries, & Other] tusko5:
Technically any Treble device may work? For instance, I have a Mate 9 and last stock for this device says that treble is enabled. Check: https://www.xda-developers.com/android-oreo-emui-6-huawei-mate-9/

"Finally, there are a few things we discovered that are especially interesting to Android enthusiasts. First, Project Treble support is there. Though the kernel sources for the Mate 9 have been available for several months, there aren’t any custom AOSP-based ROMs available for the device. Maybe Project Treble support will change that, maybe not. This is still interesting as it is the first confirmed device that has Project Treble support even though it did not launch with Android Oreo."
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
It should yes.

Though, my current build requires A/B. Does Mate 9 have A/B partitioning?

Please note that, even though it declares Treble, it is possible it won't work (for instance Essential's Treble requires a workaround)

Edit: A better way to check for Treble compatibility (though still not perfect), is to look at /vendor/manifest.xml, and check that ALL <transport> are hwbinder, and NOT passthrough. The only exception are android.hardware.graphics.mapper and android.hardware.renderscript.
[Essential Phone ROMs, Kernels, Recoveries, & Other] MishaalRahman:
I can check on the Mate 9 as well. Huawei is both an OEM and the SoC vendor themselves so it's no surprise they have embraced Treble.

Edit: Mate 9 does not have A/B partitioning though
[Essential Phone ROMs, Kernels, Recoveries, & Other] phhusson:
Ok, so with [MENTION=7050182]MishaalRahman[/MENTION] we did some testing on Mate 9, building with the _a target instead of _ab.

It can display the "android" bootanimation for few seconds (which is already a good milestone IMO), and we're progressing on fixing the errors.

AVB is currently problematic, so Pixel 2 (XL) are out for the moment.

I'd love to have some Pixel 1 users to test from an Android 8.0
[Essential Phone ROMs, Kernels, Recoveries, & Other] PresidentMcCain:
Looks like the OG Pixels should be fully Treble compliant: https://android.googlesource.com/device/google/marlin/+/master/manifest.xml
[Essential Phone ROMs, Kernels, Recoveries, & Other] 2390:
Call me a noob with all this Treble stuff, but why on earth can a Mate 9 boot a generic build but something so close to stock as the Essential Phone can't? If all the HALs are hwbinder, what's causing the issue? One of my biggest issues with Android was updates and Treble was one of the reasons I want to go back! I'd get the Mate 9 or 10 if they worked on Sprint :/