yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Haha yeah and we got good at deleting the lock files through the TWRP file manager. Lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Hahahahahaha....you got that right! I actually put a sticky note between my case and phone so I could remember the path to the lock screen files just in case! At my age....memory is a diminishing attribute! :laugh::laugh:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Frostfire:
For the people with touch not working in TWRP mine did not work with the stock kernel but installing Flash kernel seemed to fix it
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] rester555:
A new version of TWRP 3.2.1-0 came out. Has anyone tried it on the Pixel 2 XL? I searched this thread and haven't heard anyone comment on it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrbracht:
Link?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Not official.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] hanschke:
if not official how to get it?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
If someone has the link, don't post it here. Make sure you post it in the unofficial thread in this forum.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] LLStarks:
Our device wasn't built for that release.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] finesse:
Thanks for your support
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] fixxxer0:
thanks for the suggestion.

i ended up doing a flash-all and starting over and this time i didn't bother trying to perm. install twrp, just fastbooted it to install magisk.

i'm relieved i'm not the only one with the problem though, because i used the exact same files/procedure and it worked the second time after a flash-all. must not have liked something that i already had on my phone. who knows -- such is to be expected for betas on a new device.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xxnirvana69xx:
It is now.... Who's going to try it first?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jamiejames:
Worked for me. 8.1 Flash 2.02 and Magisk 14.5. Good.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xxnirvana69xx:
Working here too with ElementalX and Magisk 14.5.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Nekromantik:
works here too but you have to reflash kernel otherwise it will keep rebooting into twrp!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] lucky_strike33:
I flashed it but twrp froze...any ideas?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chikimonke:
Need to make sure (as stated in the OP) that you are running a non rooted kernel when flashing the TWRP install zip. Once you flash TWRP you can flash back your rooted kernel and all is good.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Nekromantik:
:good:

missed that part will need toremember

thankfully i got back into android after flashing elemental x again and then magisk
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
Just tried a restore to another pixel 2 xl with 3.2.1-0 and still says fingerprint hardware not available.

Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] krweby:
Time is still off. Wouldn't that still make this a beta? ;)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] iamjimmy:
Quick question: MTP not working with TWRP - does it mean that MTP does not work in TWRP only or does it mean that MTP does not work in the complete OS? Meaning let's say I have TWRP installed and I am transferring pictures from the Pixel 2 to the computer. Then I cannot copy using the drag and drop method in Windows while my phone is connected to the computer and the phone is booted up in Android. ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] kbtoiz:
Questions...

Its possible to boot into safe mode if you have TWRP installed? If so, how? Thanks!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
How and which file did you guys flash the 3.2.1.o twrp version?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Which one you flash?

---------- Post added at 07:03 PM ---------- Previous post was at 06:56 PM ----------

Long press the restart option right?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] kbtoiz:
Didn't knew that. For some reason I thought you had to boot into stock recovery to boot into safe mode.

Thanks again!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Lol used to be on the shutdown but since restart is new I guess that's a better option.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] lucky_strike33:
I flashed the newest one.

How do you long press to restart?? Did not do that.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Just while os is running!

---------- Post added at 07:37 PM ---------- Previous post was at 07:36 PM ----------

Not sure why yours froze
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Hold the power button down for about 10 seconds.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Where did you flash this from, link please.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
https://dl.twrp.me/taimen
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Any word from the OP if this is fully functional for the P2XL??
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WhiteReign:
Thanks worked great. Nice Font system!!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Thanks, that's an official build. It's working great!

Has anyone looked at the functionality of this version?

Best way to flash is to flash in the prior TWRP Beta 2 is to first flash the new twrp.zip and then flash the magisk.zip and reboot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Surge1223:
I'm on 8.1, I flashed the old twrp img and zip yesterday and it worked for a while, but eventually boot_a got wiped out when I flashed a faulty boot.img I made and instead of booting twrp it took me to stock recovery and boot_a was wiped completely. There's actually some code in libavb that mentions this can happen.

Today, I flashed this (while on stock 8.1, non rooted) and after flashing the twrp zip I flashed magisk zip, and it's working great. I didn't see any errors.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Have you seen a chang log for the new version my friend?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jlokos:
Here is what I found: https://twrp.me/site/update/2017/12/09/twrp-3.2.1-0-released.html. No word on what changes were made to fix the issue for our device on the previous version.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Buddyjohn:
TWRP released a new update that works, 3.2.1-0

Quick note for people updating while on magisk, I found out that if you flash the update with TWRP you will need to reboot back to TWRP then install magisk again or else you will go into a bootloop. I almost had to start over completely until I figured out how to fix it with adb
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] inffy:
Am I right assuming that password encryption isn't supported on Pixel 2 XL yet?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xxnirvana69xx:
* minui fixes (cryptomilk)

* Better android-8.0 compatibility in ROM trees (Dees_Troy)

* Fix missing library in android-8.0 (nkk71)

* Fix inconsistent SDCard naming (DevUt)

* Default to TWRP restore instead of adb backup restore to fix restore on fresh TWRP boot (jlask)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ralfbergs:
Huh? No. Flash encrypted by default, supported by TWRP.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] GridironTrenches:
the latest twrp version 3.2.1-0 works fine. no problems at all. i went through basically every app and dug into settings without any issues. no boot loops either. flashed with Android 8.1, magisk 1456 and ex-kernel
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
I just intall the newest twrp and when i go to recovery to use my pattern lock touch screen freeze anyone else.. im on 8.1
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
Try a reboot?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] inffy:
Well for.me it doesn't accept my pin and also freezes almost immediately
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
I did that still no go.. i get to boot twrp and after i flash the zip, then reboot and trying to go back in recovery thats when it just freeze
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Surge1223:
My issue is I constantly lose the ability to boot into recovery. Like it will boot into stock recovery after a day or so. So pretty much on both this and the last twrp, I have about two times I can boot into twrp, after that it's stock recovery, and I never change slots

I should note that it always freezes on the reboot to recovery that ends up kicking me back to stock recovery instead of twrp, that is that I can always tell ima about to lose twrp because it freezes and takes so much longer to boot into recovery. I also can't get any logs of the freeze or anything, pstore, and logcat are empty when I check right after.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
You need to flash the twrp img via fastboot or skipsoft tool and then twrp recovery zip to make it stick
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Much you have learned Master Jiggs! :D
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
Hahaha u always crack me up man lol but tbh im still learning with this device but i'm getting there :P have a good weekend cheers:D
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] aspen1135:
I have a pixil 2 XL and I've been following the development of it lightly. I was hoping someone can give me a quick update on the status of a root methode without tripping safety net or flagging the device. Does it exists yet?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Surge1223:
I did, I always fastboot boot it then flash the zip. Still happens
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] LLStarks:
3.2.1 works. Have to remind myself that most kernels are using AnyKernel zips now that flash the dtbo and kerel zimage. It preserves TWRP, but not Magisk root. Not sure how the ramdisk works that way.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] SavageOne:
I have this issue as well - have attempted to boot the .img and then flash and it doesn't seem to stick.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Fastboot boot twrp.img. Then in TWRP, flash the TWRP 3.2.0-1.zip and the Magisk 14.5 zip file. Then it will stick!

---------- Post added at 06:53 PM ---------- Previous post was at 06:51 PM ----------

I don't know what you did to follow development. Magisk root has been out a long time! It works. I suggest you use this tool, it's called "Google search" and do a little research by yourself.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] SavageOne:
3.2.0-1. worked for me - thank you! I missed the new version. :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
TWRP 3.2.0-1 functioning great here.

With ELX kernel with root from magisk.

Great job thank you.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] joedajoester:
Are you on 8.1? And just to clarify, you booted to twrp, flashed the twrp zip and then magisk and now you have permanent twrp? I've read through and that's what seems to be working but I just wanted to double check before I do it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
You are correct. I'm on 8.1 as well, and that's how you do it :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
Yes I am on December 8,1
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] john7760:
Where is 3.2.0-1 file? I see 3.2.1.0 on the Twrp site.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
Post #885 has link...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] john7760:
Ok then I'm not crazy the latest file is 3.2.1.0 and not 3.2.0-1 which everyone is talking about so either they updated it again or it was entered incorrectly.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] an21281:
Yes 3.2.1 is the latest released yesterday 12/14.17 which not listed as beta and works great!

The 3.2.0 zip did not work so they removed it, so only the 3.2.0 img is in the Taimen dl list (released 12/01/17)... You can see the dates for the files, if your on a mobile browser just request desktop site. Also I had some problems downloading some of the TWRP files on my phone in the past, so I had to use my computer and transfer them.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
I dont know whats going on but neither beta 2 are the latest twrp work for me screen keep freezing cant use touch screen ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] aspen1135:
Well I've been following it on xda since I got the phone. I'm waiting for a manufacturer exchange for a blown speaker before rooting it. I know twrp and magisk have been out for awhile now, I just thought they both currently trip safetynet and bootloader flags. You'll have to forgive the niave comment, I haven't been in the xda scene since the Galaxy s 2 ?

But it sounds like the short answer is: yes, magisk bypasses safetynet and other flags
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ralfbergs:
Strange. Others seemed to have reported it works?! (I personally have a pixel 2 and not yet installed twrp, so I can only comment based on what others report...)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Yes. Sorry for the sharp comment. Good luck when you get your new device.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] inffy:
Yep don't get why it behaves like this.

It seems now to freeze everytime i reboot to twrp.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] hanschke:
if no touch button work I cannot flash twrp with twrp...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] drewski_1:
yeah, looks like a typo . . . most recent is 3.2.1-0
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Surge1223:
Idk if you guys have this issue with twrp's busybox but apparently it's not static, meaning it wants system mounted to use libc, I'm not sure why twrp doesn't use its own libs or atleast make busybox static.

I make my flashable zips in a kinda different way, I use all static binaries but I'm surprised it gives me this sometimes. The zip works so I know the binaries I'm using don't rely on twrps busybox very much
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
You need to set up TWRP correctly first, which you have not done yet.

After fastboot flashing boot boot.image and boot patched_boot.image you need to fastboot boot twrp.img then you will get a responsive touch screen. From there use TWRP to flash the most recent TWRP.zip the kernel of your choice and again flash the Magisk 14.5.zip. Reeboot and everything should work properly.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] peoplesindian:
I've been following the forums and from what I understand is that the following steps are required for TWRP

1)root the 2XL following the magisk procedure

2)fastboot into TWRP then flash TWRP zip

3)reflash magisk if you want TWRP to stick????

4)reboot and enjoy

Ive been waiting for TWRP to get outta beta before I messed around with the phone. Seems like gone are the days of simple flashing via TWRP like on the Nexus. Came from a Nexus 5X and everything seemed so much simplier
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Although the forum title doesn't show it TWRP appears to be out of beta. The latest TWRP version is 3.2.0-1 you can dowload it from the links in the OP.

Edit: The TWRP version is 3.2.1-0
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] peoplesindian:
Thanks dude. The procedure I posted is correct tho?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Yes pretty much so. Just to clarify, step 2 is Fastboot boot Twrp.img

Also, correction the most recent version of TWRP is 3.2.1-0
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Cowbell_Guy:
Does anyone know if the Twrp Installer app is currently updated? This is how I have always installed TWRP on all of my previous devices, I guess I'm just lazy, but installing Twrp through their app is so painless
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Don't think so! It crashes on my P2XL.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
It's pulling from the ramdisk is it not?

---------- Post added at 06:12 PM ---------- Previous post was at 06:09 PM ----------

Did your boot IMG include twrp in it? Since that is where the recovery is housed now?

---------- Post added at 06:12 PM ---------- Previous post was at 06:12 PM ----------

He is a Dev my friend lol. Lots of great work done on the locked down s4 back in the day lok

---------- Post added at 06:21 PM ---------- Previous post was at 06:12 PM ----------

I have not seen any others yet with this issue. It's weird. The twrp zip should flash both slots as well. Also a side note are you pressing the power button to skip the warning? It seems to work better for me if i let it ride on through it on its own. Are you on telegram? there is a lot of ppl in the darkroom lobby for snoke kernel that we talk about really anything and have been trying to build carbon for taimien as well. https://t.me/darkroomdev
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
I'm still confused as to how you guys are successfully decrypting the phone with TWRP when the initial password prompt comes up.

I follow these steps:

1) Boot TWRP img

2) prompted with password but bypass that by hitting "Cancel" to get into TWRP

3) Initiate ADB Sideload (Advanced > ADB Sideload) to sideload the TWRP.zip from my computer (no matter where I put the TWRP.zip on the sdcard TWRP can't find it, so ADB sideload is the only solution I've found. Suggestions?)

4) ADB sideload Magisk 14.5 zip (again, moving the zip to various locations on the sdcard and TWRP can't ever find it)

5) Reboot

With this method I'm successfully able to get TWRP installed and can boot to it no problem. However, every time I boot into TWRP I'm prompted with the password to decrypt but no password works. This is the part that I'm stuck at.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ilal2ielli:
Use whatever security pin or password you setup for your phone?

If you didn't set one, then you would hit cancel.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Surge1223:
Well when I make my kernel, I use my own ramdisk, but I realize that gets wiped out by magisk patching it but that's okay for now, eventually I'll take the time to write the patch into my update-binary so I don't have to flash two zips every time. But I haven't looked at how to patch the dtbo yet, hopefully I can just write the hex patch in C so it can just search patterns and auto do it.

I patch my kernel via magisk, then sign it with avbtool and then dd it over boot_b, then I extract modules into vendor and then have magisk patch my dtbo, this all works fine and well, but the issue I get is sometimes I'll boot into twrp and it works great, I won't even flash anything, but maybe ten minutes later I'll boot into twrp and it's stock recovery. Which is just odd.

Funny you mention s4 lol, I'm actually using modules to test kexec, it isn't natively in aarch64, but I pulled in the upstream aarch64 kexec commits that add it. I figure it would be an option to kexec into twrp and or other kernels and just bypass this avb crap.

I compiled lk and I got bootloader logs from laf that show me dtb load address etc so I'm just kinda messing around now.

I'll join the tg chat, ive been talking to carbon about the vendor etc since I'm building/helping with pure
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
I'm an idiot. My 4 digit pin worked. Didn't think to try that, figuring no way it would work. It did. And now I'm decrypted and TWRP can access my entire SD card and now finds the .zips I've moved to it. Problems solved for me. Thanks!

Now my last question is, in order to update from TWRP 3.1.1 to the new stable TWRP 3.2.1 can I simply flash the 3.2.1 zip within TWRP?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
I believe you want to flash stock boot image first or the custom kernel you're using if you're using one and then Flash new TW RP. And magisk if you're rooting at the very end I usually do it all at once
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Well I thought magisk only patched the zimage in the boot.img? Also since twrp resides in the boot img now, anything messing with the ramdisk could potentially mess up twrp correct? Are process from darkroom that seems to work the best is boot twrp from fastboot then flash twrp, then kernel of choice in a anykernel zip if wanted then magisk. No reboot in between.

Lk? Is that Lean kernel?

Also when you say your kernel is it a full boot IMG or a zimage?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
Yeah, that's likely the safest way, if nothing else. I'll redo my twrp/kernel/root setup from scratch.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Yep, you got it right. Flash the stock boot.img, then the new twrp.img. Once in twrp, flash your twrp.zip, then kernel.zip, then magisk.zip and call it good :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
Yep. Just went through the process and just performed my first successful backup in TWRP. Now that we've got a fully stable TWRP, ROMs should be popping up shortly, I imagine.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
I restored one the other day just Boot and data and it worked great
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Did you just backup boot, data, and system? Or anything else?

Did you wipe everything before you restored your backup?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
No I was lazy I just did a factory reset. I was Leary but it all worked my custom kernel stayed and root. A factory reset in TWRP I mean.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
Yep, just boot/data/system. I read that it's wise to just stick with those for backups.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
I forgot I flashed the factory image with the -w first. Then I restored. Then I used that sauce app to restore my SD card.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Roger that. That's been my method for quite a while now :good::good:

---------- Post added at 04:38 AM ---------- Previous post was at 04:36 AM ----------

Good to know. Thanks bud :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Surge1223:
LK is little kernel, aboot, the bootloader essentially.

OK so apparently I was super confused, see I never have used AnyKernel2 or anything before since i am used to just writing my own update-binary and using my ramdisk, I always want control over the ramdisk, I didnt realize that twrp resides within the ramdisk of both boot_a and boot_b. I assumed dees would have just left boot_a to be only twrp, and boot_b to be for only kernels, and so if you wanted to boot into twrp you just boot into boot_a, apparently thats not how it works, so now I think all boot.img's that use a custom ramdisk must contain twrp? since its in the boot.img? This is my first time using an avb device.

I understand that rootfs is on system now, but of course as magisk has shown you can alter that.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Haha sorry I meant little kernel. Learned that from the touchpad days lol. Yes custom ramdisk must have twrp injected in it per say and any zimage (kernel). Due to twrp over writing the ramdisk and magisk modifying the kernel. Of both which are in the boot img.

Also on a side note vendor is it's own partition now and not in system. I believe it's symlinked in system still.