yashsingh1/xdaforums huggingface dataset:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
sorry, i meant magisk hide... similar functionality ~ hiding su from apps. I use magisk too.

regardless. My kernel isn't responsible - something on your end is.... I know the way the safetynet check works in the kernel (as in exactly where it is, how it's checked, etc ~ like I said: "that base has been covered".)

something is wrong on your end. Something is tripping safetynet. not the kernel.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=5930088]グリッチ[/MENTION]

are u actually failing a safetynet check or getting an error that says something about the check being 'invalid'?

if it's 'invalid', something is messed up with your magisk install. like u should completely remove it and re install. also, make sure magisk has access to the internet, if u happen to be using a firewall like AfWall...

additionally, I don't think the stable build is much more battery/power efficient than the other builds... if testing continues to go well with the binder_rt branch. it will eventually replace the other branches...

reasons;

- it's faster, more responsive

- higher performance

- deterministic, which in part means that it gives me more predictable results... this means it's far easier for me to analyze for performance tuning, etc...

I will still be maintaining the other branches, for at least a good while. but as it stands; the rt branch is likely to become the default / main focus... since it's turning out to be very stable and the best branch...

if u want to maximize battery savings, after the next release, I can give u a tip of two on sysctl's that u could set that might help...

for now. one obvious way; disable input boosting, since it boosts cpu frequencies whenever u touch the screen.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
So I've got the linux-4.3 locking all lined up and committed. 4.4 locking code is going to be a pain due to differences in certain arm/arm64 headers ~ so for now I'm not going to pull in those changes (even though there are a few things I want)... that stuff is going to require delicate care to merge.

I decided to put all of the scheduler changes into a separate branch (not applied to binder_rt), I'm just going to cherry-pick fixes and any optimizations ~ leaving the rest untouched - as I don't really want to screwing around with our scheduling code (it's in really good shape and any big change might introduce regressions)... All of the workqueues code is up-to-date.

Next, i will have a bit of misc cherry-picking to do. mostly micro optimizations and little isolated changes/backports here and there... nothing overly exciting or super interesting.

Accubattery is showing at 100% 6hrs of SOT ~ but I know in my general usage, I'm getting more than that on average. somewhere between 6-7hrs, more if I'm not benchmarking, using heavy apps - more browsing, texting, etc....

I still need to figure out how to stop android from changing the one sysctl that may be causing a bit of unnecssary drain ~ but I haven't figured out that one yet... Once I do though, that should give a bit extra battery life...

all in all - not bad considering I'm already biasing performance a bit, there is overhead due to some of my kernel's features, etc... But that all said, I'm going to start looking at doing some light code tweaks that should result in further battery saving and reducing CPU usage in a few situations.... ~ this all goes back to previous discussions in the thread about getting stability (got it!), then starting to focus on improving performance (which I've definitely been doing with the Binder_rt branch) and finally, working on optimizing battery life and other tweaks....

so things are coming along nicely. a bit more effort and we should be able to squeeze more performance and battery life out of the kernel....
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=1007992]everyone[/MENTION]

1. I've also posted my kernel to the Pixel XL forum - to try and get some more widespread use and testing in

2. I've joining the android kernel-dev google group and have made a post inquiring / seeking help with getting the missing kernel function; mmput_async() into our kernel, so that I can get the remaining Binder patches from AOSP merged into my branches...

Hopefully, someone wiser than I will have patches, or can give me some pointers, related commits needed, etc... ~ this is pretty much my biggest annoyance right now; lacking this support / not being able to get the last 4 commits into Binder.

With any luck - I can get some help with that ;)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
I finished up backporting a feature from the Pixel 2.... nothing user-facing, but in the case of an overflow in the tx port (transmit port) of the slimbus wcd9xxx driver (audio driver) it will now support auto-recovery...

this will be included in all builds.

EDIT: as an aside, I'm also starting to get some views and feedback on the Pixel XL forum. nowhere near the 4400+ views here, but the feedback I have gotten is good, so far. (on the Binder_rt build... people seem to be interested in that build, which is good).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
sweet - just picked up another commit from Wahoo ~ seems to solve an issue with binder getting a bit thrashed. Google never pulled it into Marlin's Kernel - but it probably isn't applicable to stock binder / kernel.

But the fix is definitely applicable to my kernel/binder; as the logcat warning that I was seeing are no 100% gone. ~ I never would've figured this one out on my own. awesome.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Horgar:
Thanks for all your work. Been out the game a bit the last few days so haven't been testing and flashing. Got some family issues, my son is in hospital but is ok now.

Still using your RT binder build won't be changing for a few days at least. I'll be back in a few days.

Thanks again
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Thanks, man.

hey, sorry to hear about your son. but i'm very glad to hear he is ok now! :)

No worries on updating soon ~ I won't push another substantial build until I get a few more changes in.

All of my current changes in the RT branch seem to be quite good (locking/sched/workqueues + some bug fixes n bits), But I'm trying to backport a feature from the Pixel 2 into our audio driver - Pixel 2's DSP has a cleaver way of handling fragments, wherein it uses smaller fragments in the DSP, than userspace fragment sizes -> this allows earlier writes to the DSP without waiting for a full userspace fragment to complete.... ~> jargon aside; this has to do with "gap-less" audio and buffer underruns (underruns cause glitches, clicks or gaps in audio.... I'm trying to reduce / eliminate any chances of such things in my kernel)

Probably won't push an update until I have that working anyway. (because that's a legit userfacing bit - even if it is in the kernel).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
I have been using the RT build, no issues at all. Battery life is good and it is so fluid.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Hey siheals!

Thanks for checking in.... The input boosting + and my Binder_rt driver implementation really do improve with fluidity. I'm glad Battery Life has been good. For myself, it's been quite good too. no gripes or complaints.... I'm quite happy that starting over with my kernel sources, redoing a pile of stuff from scratch (plus, integrating some new stuff along the way) turned out to be the smart choice.

yeah, I must say; the writing is on the wall; concerning the stable and binder builds ~ I will most likely be phasing them out. The Binder_rt build has really surpassed my expectations and is very stable... There seems to be no benefit to using either of the other builds, from my perspective. (or me maintaining several branches).

The current Binder_rt test build that I'm using (with it's somewhat enormous code merges) runs perfect and there has been a few gains here and there, since the release and last test build.... So hopefully, I can get another build out soon... But I have a few things left to do....

Also, I'm waiting to hear back from the android kernel developer google group - to see if I can't get some help with this pain-in-the-butt missing kernel function that Binder would like to use (the Last 4 patches to Binder to be identical with AOSP's binder)... I think at that point, I would be ready to kill off the other implementations.... mild hold up - but hey; at least it's stable without it ;)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Nil253259:
All interesting stuff.. super psyched to test the Kernel... right now I'm not with my laptop, will be able to grab one in the evening (it's 11 in the morning here).

Been on 8.1 DP for few weeks, just got myself back on 8.0 yesterday :fingers-crossed:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
cool, yeah - check it out - things are getting to a really good place in my development cycle and stability, features, etc....

Advice: use the binder_rt build ~ that's where all of the goodness is ;) ... I'm probably going to yank / kill off the other builds in favour of Binder_rt.... Plus, the more usage it gets, the better.

I'm curious: Why did you drop 8.1? ... bugs or something else?
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
Hi there!

Just quickly, its been a very long time since I've flashed anything and its the first time flashing a Pixel at all.

I had to factory reset to an unrelated problem today and have decided to flash some new hotness.

I've rooted, I've unlocked the bootloader, and I have TWRP Fastboot ready to go.

After my first attempt I seemed to be getting a flashing google boot loop, I see google briefly before it blips out and loops.

I am not panicked, I was easily able to flash back to factory for another try, but before I do, is this a known factor that equates to my ineptitude, or should I look into it with more scrutiny.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Hey, ya. Don't panic at all...

So you flashed the kernel and it boot looped? EDIT: Oh you mean it quickly reset by "flashing boot loop"???

Did you try letting it boot again and/or if it stays on the white screen/google logo - try holding down the power button and volume down key and letting it try to boot again???

I had noticed some oddities with the Nov firmware - that every once in a while (I flash kernels frequently), that it does occasionally boot loop or reboot. (only on first boot and for me it's only happened a handful of time vs. many many flashes)

I would say try again and see if letting it reboot ( or holding down the keys to reboot if it stays on the logo)...

I'm here/online, so you can respond back and I can reply quickly.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
Don't worry, I am not a panicker.

I let it boot loop, I am certain it wasn't an oddity. Let me go through the process again and see if I can get it to work.

I am flashed back to factory everything now, I will try again!

---------- Post added at 08:17 AM ---------- Previous post was at 08:13 AM ----------

By the way, correct me if I am wrong:

From TWRP I am:

-Flashing Kernel

-Flashing SuperSU

-Reboot
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Ok. Try again.

I'm on my linux box, doing some stuff. so definitely instant replies from me. let me know...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Should be fine, yeah. But if it does it again ~ try not rooting and letting it boot first. SuperSU does some BS when it installs (like reseting the device multiple times.), it shouldn't cause an issue - but ya never know... and you just did factory reset too. maybe it's put things in a funny "state".

btw: why use SuperSU?? Magisk is much better, imho... and not closed source.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
Yeah, still get the google white screen boot loop.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
did you try, as I asked holding down the power and volume key until it reboots?

EDIT: You may actually have to boot into android before installing, if you haven't done that yet (like first boot, setup, etc. If you literally just wiped the device.).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
I did, only because I saw that the pixel encrypts itself. I am going to take a different angle, ill get back to you with the results.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
I don't follow what you are saying by "I did, only because I saw the pixel encrypts itself"....

I think if you have freshly wiped the device; you need to set it up and THEN look at flashing kernels, rooting, etc....

try installing the kernel after setup, no root ~ then see if it boots.

and I'm just going to say this, in case you aren't aware - but don't re-lock your bootloader with custom kernels, software, etc - in case you didn't know that - you will brick your device....
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
Thank you for your concern.

I read the poor guys' account on what he did :D
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
cool. I'm just making sure - I don't know your experience level and no one has reported the issues that you are bumping into....

Lots of people are using my kernel, so I would've expected to hear about it by now....if they were

EDIT and yeah, crappy situation for him. very tough lesson to learn - last I checked the seller he bought it from (original owner) was going to contact Google for an RMA ~ I hope it works out for him. I really do.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
I have about medium experience. I've been working around Linux for a few years and I've successfully flashed my last 4 phones.

It could have something to do with my pre-flash prep.

-Fresh Factory Reset

-Turn on, setup, set PW

-Use adb to send to bootloader

-use adb to start TWRP

-From phone, login, install from zip, install kernel

-reboot

Shows warning screen that I cannot check if my device is corrupted

Shows google opening screen, pre-4 dots

Blips off, restarts to warning screen, repeats possibly for all eternity

I did the volume key power to force the reboot, and I am easily able to put it back into bootloader to get back to twrp
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
What firmware do you have installed that you factory reset too?
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
7.1.0 (NDE63H, Oct 2016) is what I used
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Yeah. That's your problem - Read the title of the thread "Oreo-8.0" - You need the latest release of Android 8.0 November Firmware - my kernel is patched for Oreo / Nov - not 7.1 from a year ago...

problem solved. I knew this made no sense.

upgrade, if you want to run my kernel. You have to be on Oreo 8.0 Nov firmware...

https://developers.google.com/android/images#sailfish

I have no idea which model, what carrier or what country you are in - but yeah. Definitely will not work on Nougat 7.1 or even possibly older builds of Oreo. My kernel stays up to date.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
derp. Should be an easy fix. I am the guy that still writes 2015 when I date things.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
I put a link in my previous reply to the images - I don't know which one you need.

but yeah, easy fix - upgrade, then try...lol
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Cinos03:
Thanks for the help, then! Ill update here. What I imagine happened on the first one anyways is that, while I was stock, I was updated fully. Due to the issue I had that caused me to factory reset, I'll bet that the factory reset took me somewhere not on that build, which caused it to fail first.

The second time would have been due to the wrong download from google's website. I should be able to upgrade and immediately set it right.

Sure enough, got it to work with no hearthache.

And only on my 1st try*

*this number may have a small variance
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Ya, i don't know what you did. I only know that you must be on Oreo-8.0 with Nov patch level. - Because I update my kernel, as android updates - so I apply monthly kernel patches, etc.... and I never plan on supporting 7.1 at all... Whenever I switch over to 8.1, I will probably still support 8.0 though, at least for a while - or let someone else do it. We'll see.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Nil253259:
Nope, not bugs...in fact 8.1 has been the most stable DP1 I've even seen...but had some free time one fine evening, and wanted to try few kernels...so came back to 8.0 ?
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
lol. understood.

aside from lack of source code bring available. I've had no compelling reason to checkout 8.1. .... I am curious about some of the changes under the hood. curious about their kernel too, if they've done any substantial changes, etc.

I'm thinking they probably haven't. hut who knows. lol
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
just an FYI;

geekbench pro version is free on the playstore for the next couple of days... usually, costs $12.99.... not a whole different from the free version...

but still, I grabbed up a copy, since I do use it sometimes. so I thought I would mention it.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=1007992]everyone[/MENTION]

So Binder_rt is now the only build going forward that I am publishing;

-> It's the best build

-> cuts down testing time for me.

-> speeds up development.

-> Has proven itself to be stable.

Soo... I've updated the OP info && Later on I will be publishing a test/RC build with my latest code/commits + 3.18.84 lts exNoShadez-eas. I'm running this build now - but I like to give things a good run myself, before ever posting... thanks.

NOTE: The OP download hasn't changed - so no need to update same build.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
So i'm just finalizing a few changes to the audio driver - no luck backporting the gapless audio changes that I AM going to backport - still working on that, as the changes are a bit tricky to backport from Wahoo (but are worth the effort).

The changes I am working on; are improving Quality of Service in the audio driver, as well as re-prioritizing some of it's critical threads. The reason:

Currently, Surfaceflinger's threads are FIFO threads with slightly high priority ~ This is improves responsiveness and keeps many of the system's other threads from disrupting Surfaceflinger (which is great!), however - it also causes Surfaceflinger to occasionally disrupt audio playback (causing "clicks and pops" under some circumstances - which I can easily reproduce, with a bit of effort).... * Currently, in my kernel - the audio driver very rarely has buffer underruns and even when we do get "clicks and pops" - the audio driver itself usually hasn't experienced a buffer underrun ~ these are caused by surfaceflinger.

So the idea here is to get these critical threads to have higher priority than surfaceflinger - so that these "clicks and pops" never occur... It's a bit tricky, as I don't want to 'steal" too much cpu-time from surfaceflinger, either. Priority scheduling in linux and android can be pretty tricky.

That said - I _think_ I've ironed out the above - just gotta test it a bit more... That will be my last bit of tweaks before pushing a test build.

any remaining underruns or "clicks and pops" ~ would likely be solved by backporting the gapless audio changes.

the remaining ones after that; caused by cpu frequency scaling and cpu_dma_latency.

just some interesting bits I'm working on ;)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
TEST BUILD: https://github.com/nine7nine/Apps/raw/master/Sailfish_exNoShadez_eas_3.18.84_Binder_RT_a1f0684.zip

EDIT: This link has been replace with a new test build - there were some booting problems that a user on the XL forum helped with solving....

NOTE: From now on test builds are available on the OP - I will only mention them in the trhead - not link to the download - goto the op downloads for them. thx

So this is the test build that I've previously mentioned. It has a rather large set of changes (but I've been running variations of it on my device for days now). Do NOT feel that you need to run this build or anything - if you are happy on the stable build; but anyone who would LIKE to run this build and help out with testing ~ that would be awesome! .... I test a wide variety of applications against each build - but obviously, I'm just one person - so having other people test helps.

It you bump into any issues / regressions. Let me know - and if they are something that I might be able to reproduce - point me in the right direction, I will have a look for myself....

Changes:

- Linux-3.18.84 lts

- the majority of locking, Scheduling, Workqueues subsystems from Mainline; leading up to linux-4.4. * some changes ommited/not needed, while others I'm not integrating yet ~ in particular with certain scheduler and locking changes.

- several commits to binder (a bug fix or two + some debugging related code)

- several commits to the audio driver (although, I am still working on some of this for the next OP download link / release)

- several misc optimizations ( i have some others to commit, as well. But they'll be included in the final build).

NOTE: every once in a while, I do get quirkyness on first boot, after flashing a build. meaning; My pixel boots to G logo, then either;

A). resets after a second or two, then boots normally

B). sits on the G logo screen, but never boots

=> if A). happens. it will boot up fine upon rebooting.

=> If B). happens - just hold down the power button + Vol. down together - it will reboot and boot up.

This seems to only happen every now and again, but if it happens to you - feel free to report it, but know that this does periodically happen, but infrequently.... So just a head's up. No need to panic or be overly concerned.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=1007992]everyone[/MENTION] - updated the above/previous post to reflect new info - new test build.

from now on, test builds are in the OP download section. thx
[Google Pixel ROMs, Kernels, Recoveries, & Other De] almightysiman:
Been running the test build for all day with normal usage,pretty stable and none FC happens.Well done Sir.Will report back once I found issues.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Cool. thanks for letting me know.

Ya, I haven't had an FC in like a week ~ the last was before I fixed Google Camera... So all good on that front.

I kind of only expect that crappy written apps might crash ~ but even some of the crappy coded ones that I've been running/testing, actually seem to have benefited from Binder_rt and no regressions with all of the new code., in the test build.