yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy Note 8 Questions and Answers] shouren04:
Burst shots sound should be shutter_multiple.ogg & video sounds should either be cam_start.ogg & cam_stop.ogg or camcorder_start & camcorder_stop.ogg.

Best way & is the method I'm using is to add this csc string to get the shutter sound toggle which turns off all those sounds for me.

<CscFeature_Camera_ShutterSoundMenu>true</CscFeature_Camera_ShutterSoundMenu>

But if you are using a fully stock rom, your cscfeatures.xml file might be encrypted as was mine. I'm using tmobile csc so I am no longer using the stock encrypted cscfeatures.xml.

Of if you flash a custom rom you should be able to add the csc string without any problem.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] topjohnwu:
Pixel 2 (XL) is now officially added on the Magisk support list, please install Magisk v14.5+. These builds here are deprecated

Check out the latest beta from the official beta thread

---------------------------------------------------------------------------------------------------

Root for Pixel 2 XL has been achieved!

There are still some things I'd like to add before I push out an official release, but since people can't wait to ROOT their shiny new Pixel 2s, I figured I'd build one for you!

I do not own either Pixel 2 or Pixel 2 XL, so testing is limited. This build is ONLY tested on Pixel 2 XL Android 8.0 OPD1.170816.010.

For Android 8.1 beta, Pixel 2 etc, it should work IN THEORY.

Magisk Version: v14.4 (code: 1444)

Magisk Manager Version: 5.4.1 (code: 58)​

Instructions

Since TWRP cannot decrypt /data yet, the proper way to install Magisk is via Magisk Manager. You will need a stock boot image from official factory images.

Download MagiskManager-v5.4.1.apk from attachments and install it to your device.

This Magisk Manager is specifically built for this release ONLY, both stable and beta channels points to the same custom URL.

Once you've got Magisk Manager installed, I'll just copy and paste the instructions from the Magisk OP here:

Please don't share a patched boot image in the forums since it will help no one. Flashing a patched boot image alone is not sufficient to run Magisk properly. The "patch through Magisk Manager" step is actually mandatory if you wonder why.

Special Thanks

[MENTION=6842057]nathanchance[/MENTION] for his Pixel 2 XL and speedy tests

[MENTION=912474]Dees_Troy[/MENTION] for TWRP on Pixel 2 XL - thanks to TWRP's root shell, the debugging process is 1000 times faster

Donations

I spent endless hours on Magisk. If you like my work, feel free to donate.

https://www.paypal.me/topjohnwu

P.S. Magisk-v14.4(1444).zip is also hosted here because I do not have my own server :p
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] topjohnwu:
Reserved
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] danon.brown:
Donating later
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
Glad to help be a part of testing and here's to the future of root :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] northmendo:
Thank you [MENTION=4470081]topjohnwu[/MENTION]!!!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ne0ns4l4m4nder:
Thanks again! Also for people using BusyBox it goes in /system/bin
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Megaflop666:
Can we use a custom kernel like the Snoke kernel from Despair after we root or will it break root?

Also I've seen a few posts about needing to do this before any Google accounts are on the phone, etc. Any truth to any of those; or just flash original boot back on and follow your instructions?

Thanks for all your work!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ne0ns4l4m4nder:
Install snokes kernel first then root with magisk
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] widezu69:
Hopefully will have a 2 XL coming and will be happy to test this on 8.1.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ne0ns4l4m4nder:
I would flash snokes first, then root with magisk , also I have Google account in my device and am not encrypted in twrp
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] metalcated:
Sweetness! Thanks all for getting this going.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
I tested it with Google accounts already on my phone.

I don't know if Snoke uses AnyKernel2 or a boot image. If it uses a boot image, just patch that with Magisk Manager and flash it (that's what I did with my kernel). If it uses AnyKernel, flash the Magisk patched boot image then Snoke.

Also, to be clear to everyone, this works with encrypted data and SELinux enforcing.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
The newer ones are anykernel2
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Megaflop666:
I already have Snoke kernel on the device. I was going to wipe userdata to unencrypt my phone as well. I'm just going to be happy to get root so I can tibu over my apps and data easily and quit using my opt for my dd.

Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
Don't necessarily think it's the wisest to rely on TWRP right now but not my call :p in which case, Magisk can be flashed whenever since Snoke isn't going to mess with any internal patching that Magisk does (or shouldn't...)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
So this magisk also patches the util_functions.sh ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
You mean this? https://github.com/topjohnwu/Magisk/blob/master/scripts/util_functions.sh

It's just a helper script while flashing, it isn't used once things are installed.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] phyl0x:
how do you do the final step: " Flash the patched boot image to your device and reboot. Voilà!"?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] joetheshmo:
Fastboot
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dredq:
For Pixel Noobs out there including myself... Could someone post a step-by-step description of how to install Magisk, Smoke Kernel, and TWRP maybe on a separate thread?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] js042507:
Oh yeah!! Finally!! I am complete now. LOL. Also, safety net check is good. Using stock 8.0 kernel as well. Me happy.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jr45:
Not sure what I missed just finished reflashing factory and it's firing back up, I give it another try tomorrow! Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bd177:
You will have to wait for the ota zip or flash the original firmware.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] fixxxer0:
trying to flash the stock 8.0 sept2017 image now and getting this as the first error... everything else seems to go okay, but wont boot still.

writing 'bootloader_b'...

FAILED (remote: Flashing is not allowed for Critical Partitions)

on booting i get a cool "your device is corrupt it cant be trusted and may not work properly" red ! ,,, this is a new one for me haha

i tried unlocking critical partitions and flashing, that got rid of the failed error, but still cant boot... getting the device corrupt.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Humo0915:
Is it posible to use flashfire with this? Thanks in advance
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bd177:
Flashfire requires root.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] joetheshmo:
Kind of a chicken and the egg situation there
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Humo0915:
Isn't Magisk root thought?

What I meant is if we could use flashfire along magisk to install other zips
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] js042507:
Not sure if this has been posted somewhere (sorry), but is anybody getting force closes from Magisk Manager when trying to enable/disable root for an app from the Superuser menu? I am able to obtain root on my apps, except Greenify. And when trying to enable from within Magisk Manager, it crashes everytime.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] fixxxer0:
dunno why its giving me a hard time flashing back to stock taimen-opd1.170816.010. i ran the flash-all.bat from cmd prompt, it looks like everything went smoothly... but still getting device corrupt.

i think it had to do with only flashing to one slot, i had to manually switch the other to active, and reflash it, now it works.

whew...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
I downloaded the Android studio and sdk tools, it keeps everything updated nicely and has the drivers you need
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
If anyone on the 010 gets the update while rooted, please post a Google Drive link here
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] zachman1750:
Snoke Kernel and Magisk walkthrough

For those wondering exactly how to get Snoke Kernel and this both going:

EDIT: Please keep in mind that I have only tested this with R9se kernel and Android 8.0.

Install the Magisk APK found in the OP on your device.

Open Magisk Manager and click install (Not 100% sure if this step is necessary)

Download TWRP alpha here.

Download the Magisk version that [MENTION=2955144]bryantjopplin[/MENTION] posted in this thread.

Download the Taimen Snoke.R9se.zip kernel found in this thread.

Rename twrp file to twrp.img and open a command prompt/adb window where all of the downloaded files are located.

Rename the Magisk-v14.4.1.zip file to magisk.zip

adb reboot-bootloader

fastboot boot twrp.img

When TWRP loads, go to advanced and choose ADB Sideload, then type the following command:

adb sideload Snoke.R9se.zip

After that completes, you'll have to select ADB Sideload again, then type the following command:

adb sideload magisk.zip

Reboot and profit. When you go to Magisk Manager, you should see that you now have root.

For those who have gotten Arise or Viper4Android working, would you be willing to post a walkthrough? I've tried a number of different methods and have not gotten them to work. Thanks in advance!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
I'll look at viper tomorrow. But if anyone wants a boot.img consisting of r9se that's fastboot flashable and magisk app mod-able. Let me know I'll ask [MENTION=5169465]DespairFactor[/MENTION]. I only made this because I change kernels too much right now and it's easier to use this imo. It's the same as [MENTION=4470081]topjohnwu[/MENTION] magisk except a fix in the util_functions.sh that calls for getprop ro.boot.slot_suffix which XL 2 does not have. It's ro.boot.slot which allows the flashing via twrp with an anykernel zip. Which snoke is using from here on out. It should work via the app as well. Haven't tried lol.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] g3v0:
I tried Arise, am3d, jamesdsp, and like every dolby atmos (ahrion's, guitardedhero's, etc). None work, they either FC or have no effect. As far as I know, the previous versions of dolby and whatnot aren't compatible with Oreo. We'll have to wait until they release an oreo phone with dolby/whatever preinstalled.

Viper works though (by itself). Ahrion's viper works fine for the most part, but if you install any of his other aml modules alongside it, it breaks. I think he might need to patch audmodlib for our pixel 2xl. I found the most success with the module by ShadySquirrel.

Remove all previous audio effect modules (including AudModLib and previous Viper4Android installs) in Magisk or one's that you may have flashed through TWRP/Flashfire.

Go to Settings -> Apps & Notifications -> See All Apps -> Threebutton menu -> Show system. Find MusicFX and disable it.

Reboot.

Go to MagiskManager -> Download -> "Viper4Android FX for Magisk v14+" by ShadySquirrel.

Reboot.

If it's not processing, download/install "Universal deep_buffer Remover" in Magisk and reboot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] FSMcas:
Okay, so I just updated my Pixel 2 to november OPD1.170816.025 and read about working Magisk two hours later. But there are no factory images for this new version up yet. I suppose I cannot just patch the old boot.img from before and have to wait for the new images?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
You could have but now you can't. You needed the zip file it downloaded to extract and take the boot.img out.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Didgeridoohan:
Have you guys tried the official Magisk OTA instructions?

You're in the wrong place... This is about the Pixel. When Magisk works on OOS Oreo beta, you'll hear about it.

You might want to read the red text in the OP...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] w02justin:
Whenever I try to flash the patched boot image, nothing happens in the command prompt. When I go out of the bootloader, it says this:

target didn't report max-download-size

sending 'boot' (25788 KB)...

FAILED (command write failed (Too many links))

finished. total time: 0.000s

What's the problem?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] metalcated:
I believe and don't quote me unless I'm right lol, that with Pixel phones (starting with the first Pixel) there are slots for boot and other partitions. So when Magisk builds your patched boot image it tells you what your active slot is for your boot partition, slot a or b. In order to properly flash you will need to specify the slot like so:

fastboot flash boot_b patched_boot.img

boot _a for slot a of course. Also if you need to make sure that your platform tools are up to date, if your having issues, switch USB ports, reboot or use Linux or if Linux gives you issues, try Windows.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] T6D16C84:
Trying to install with Pixel 2 XL factory image. Manager force closes everytime it goes to the "flashing" screen.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
What method are you using to install Magisk?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] def-g:
Tried v 16.2, but wrecked Vance YouTube playback. Could listen in background, but no playback. Also had issues with Edge Sense module.

G
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
Today received and installed v16.3 directly! All is good :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
16.3 all good on my end as well.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] samteeee:
Installed 16.3 through TWRP with no problems and booted to Android,

but modules are not showing up! I mean they get installed alright but after

reboot, they all disappear!

Thank you.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] demid30:
Does this work for the Verizon Pixel 2 XL??
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Unfortunately, no. Since Verizons P2XL's bootloader can't be unlocked, root is not possible ??
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
You need to unlock your phone first.[emoji3]

---------- Post added at 09:03 PM ---------- Previous post was at 09:02 PM ----------

What are you running?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] lucky_strike33:
Whats everyone's method to flash April image with magisk?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dmarden:
Download full image, unzip, remove -w from the flash-all.bat file... run it with fastboot, boot the TWRP image, install the Magisk zip.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pkgnex:
What I did for pixel 2 xl - flash-all the factory images after having removed -w from flash-all.bat, then reboot to bootloader, boot twrp 3.2.1-2.img, flash twrp 3.2.1-2.zip, flash magisk 16.3 zip, flash custom kernel zip, flash magisk 16.3 again, reboot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bigv5150:
Having issues with modules on April security update. Can't get tether bypass to install
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Same as above. But be sure to remove device security or load your custom kernel and TWRP file on a USB drive so you don't need to rely on TWRP decrypting your data.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jexx11:
This is important if true, I have to have tethering when I travel for work, so I guess I need to hold off updating until this is resolved.

---------- Post added at 04:09 AM ---------- Previous post was at 04:07 AM ----------

Many people are saying in the TWRP thread that it decrypts correctly in the April update. Removing device security may not be needed anymore.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bigv5150:
OK the tether module won't install however another module did so I'm guessing the module needs an update. Good news is I used build prop editor and just added on last line net.tethering.noprovisioning=true saved it rebooted and now I have tethering again.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] winstonlu89:
just wondering why we need the tether module? I thought hotspot works fine?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bigv5150:
Not if your still on grandfathered unlimited like I am
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
On Grandfathered as well. Have you heard anything about build.prop edit (net.tethering.noprovisioning=true) not working with April update?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bigv5150:
Look at my post above the module won't load but the manual way editing build.prop does
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] drewski_1:
similar, but only one Magisk flash

flash factory image with '-w' removed

boot TWRP 3.2.1-2.img

flash TWRP 3.2.1-2.zip

flash custom kernel

flash magisk 16.3

reboot

profit
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] demid30:
Damn Verizon, I don't understand why they pull this ****! I obviously should have done my research before I bought this phone. See I got the 128gb version which the store didn't have in stock so they had to order it. How do I figure out if i got lucky and this is a Google unlocked version?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] demid30:
This
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Go to this link and type in your IMEI number, and you'll know pretty quick. http://www.imeipro.info/check_lg.html

Also, if you go to developer options, and OEM unlocking is greyed out....your pretty much outa luck :eek:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Take out your Verizon sim card and update the phone by flashing the April factory image with a full wipe. Then look in Developer's options and see if the unlock bootloader toggle is available. If it is, toggle to unlock and then unlock bootloaders with adb. I know this worked recently with the March update on a Verizon Pixel 2 XL. Good luck!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jexx11:
Did this build.prop edit brake Android Pay?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bigv5150:
I don't know don't use it
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jexx11:
You can open Android Pay and try to add a card, it will tell you right there if your device is "unsecure" and not allow it if you're curious.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mitchdickson:
Android Pay doesn't exist anymore.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sd_matto:
Tethering module installs fine on April 2018 build with Magisk 16.0

My steps (from memory):

1. Install Magisk 16.0 (NOT 16.3) via "Patch boot image" option (after pulling boot.img from the factory image)

2. adb pull the patched_boot.img from /storage/emulated/0/MagiskManager/patched_boot.img

3. Reboot to bootloader

4. fastboot flash boot [location on computer of the patched_boot.img that you got from step 2]

5. Reboot

6. [May need to install Magisk Manager at this point; don't remember]

7. [Optional - may be needed if you try to install multiple modules that need updating] Reinstall Magisk 16.0 from inside Magisk Manager via Direct Installation option

8. Install ALL your desired Magisk module, rebooting between each installation

9. Once ALL desired Magisk modules are installed, shift to beta channel, and update Magisk to 16.3 via Direct Installation option
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bigv5150:
That may be the issue I'm on 16.3 the beta
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Amjad.AbdulGhani:
Am on April update version, and magisk 16.3, and with hiding every possible play store related app, and passing the safety net, still my play store is uncertified.. It was certified as i remember back with March update and 16.2 Magisk..

Can someone check and see if its a common thing, if not, any solution?

Update: i uninstalled Magisk completely, installed magisk 16.2 (downgraded), reboot, magisk hide, clear cache and data of play store, and its certified now.. I think its the 16.3 version problem..
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] D-m-x:
No it isn't. You solved it because you deleted cache and data of Play Store followed by a Reboot. Has always worked for me that way, from the beginning. And still does on 16.3.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
I don't mean to bring a rather old post back from the past, but I wanted to add some advice for people that rely on using a USB drive...

As I understand it*, if you put your .img and .zip files in the /data root folder, you wouldn't need to worry about decrypting, as TWRP can read that with and without a passcode/decryption. It'll save a considerable extra step of loading files to a usb-c flash drive and/or removing your security and plugging it in...

But, as I said, this is how I understand it so a confirmation or contradiction would be welcome...

Hope this helps anyone who uses a similar method (not just for flashing, but other things as well)...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
I agree! I usually do both, however, as root files sometimes get deleted.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
Module section wont show up on 16.0 for me to add no module at all ... anyone else
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
Solve core mode was the problem
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
I have installed Modules with the latest.

Download is indicated and functioning.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
I'm willing to bet that's a cache/installation problem...

I advise to "force stop", clear cache, and even clear data... Disclaimer: clearing data might clear away any installed modules, so you'd have to re-install the modules if anything...

or, worst comes to worst, if none of that helps, I imagine just a reinstall (of the Magisk

app

/.apk) would make it normal again...

good luck!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
None of the above work
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
hmmm... Originally, I had thought that, like any other app, missing sections or certain capabilities usually happen when the cache is wrong or it was installed wrongly. Usually, at most, re-installing the app would/should be enough. But Magisk app is most likely no ordinary app/apk.

I would say to try this, force stop, clear cache, clear data, uninstall. Reboot. Erase cache (optional; if you know how to do this). After system load-up, erase any reference to "Magisk" in your internal sd. Reboot once more. Erase cache again (again, optional; also dependent if you know how). Now install the latest Magisk (

I

would install the latest beta, but I would leave that decision up to you). See if that corrects the issue.

If not, then it may be that most likely that your system/phone has not fully, completely, or fully properly initialized in your system the "system-less root" method that Magisk employs. You may/might need to re-root, re-initialize, and/or re-apply Magisk-root.zip first, and then try seeing if the Magisk app is working normally.

P.S. One question, did

you

install the Magisk app or it was simply installed?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrimage:
Thank for the info but i fix it by uncheck core in setting