yashsingh1/xdaforums huggingface dataset:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Keasby:
Can confirm this, I'm on 3.1.1-1 too and got this issue.

I'm running 8.0.0 (OPR3.170623.008, Oct 2017) build.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] GuestK0037:
kk. I'll look into this - I (obviously) do not have this problem..... What firmware images do you use?

I'm on Rogers/Canada, maybe the boot partition is a different size on some firmwares (?)....

I can also look at shrinking the boot.img, which could fix it. My boot.img is slightly bigger than the shipped boot.img and I do have an idea on how to shrink it a bit, you'll have to wait until later on for me to look at it though / not home right now.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Nick80835:
32MB is the boot image max size AFAIK.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Keasby:
Maybe it's caused by the image size. Other custom Kernels are sized bout 13mb.

I'm running the Google Stock Build OPR3.170623.008, October 2017.

Hope you can fix it - TIA!
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Warrimonk:
Personally I tried on these 2 firmwares:

sailfish-ota-opr3.170623.008

sailfish-ota-opr6.170623.012

The phone was originally a Project Fi device.. if that matters. Dev which firmware and TWRP are you using?
[Google Pixel ROMs, Kernels, Recoveries, & Other De] GuestK0037:
I'm using the latest twrp-3.1.1-1 (but and idk if this makes a difference or not), I only use the twrp fastboot img (Ihave ZERO reason to actually install TWRP on my system).... and also, Others have installed and are using my kernel - so it must be a difference in firmwares / boot partition size (or image size)

So yeah, I'm using a different build **OPR1.170623.027**, Oct 2017, Fi/Canada.... you both are having problems on >>>>>OPR3.170623.008<<<<< ~> Something is different in that build... If you like (and happen to have that image kicking around, you could send me the boot.img and I'll compare it to mine? later on)

I'm thinking it's not the kernel size, although - I do plan on making the kernel smaller on production builds, by reducing a lot of debugging that really isn't needed on a production build (I already have a defconfig for doing so);
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
pending one more minor change to binder, sleep, coffee and some more testing; I think google camera crashes will be resolved and I can post a test build...

I'll keep ya posted ...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
Excellent
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
good day, all... So....

I'm having a coffee or two, then diving back into the binder code... the current state of things is that Google Camera is stabilizing. Currently, it crashes once on boot, then does NOT crash ever again, on my current running kernel....

but i think I know why it is crashing on 1St startup, so I just need to test out one change./tweak.. I should have a new test build up later today...

I've also merged in some other changes / updates to the kernel, still working on that stuff.... it's all getting ironed out and smooth.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=1007992]everyone[/MENTION]

NOTE: I'm also not done all of my linux-4.4 integration - but fixing Google Camera app and Binder (as I said before ) is/was my top priority.... That said - my current round of kernel changes should, in fact, be quite stable (like possibly gearing up to releasing a stable build / removing beta status - assuming there is no big regressions with my binder implementation).

Therefore => ***Please; Make sure to flash, test the test build (linked above) *and* report back - I'm halting any significant changes to the kernel, until I have some good reports back and further test binder for myself.

But i do have a bunch of code waiting to be merged
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Horgar:
Front facing camera isn't working. It keeps crashing and doesn't appear in Google duo either. Only rear facing camera available in duo.

Other than that all else seems good. Will report back anything else.

Edit: Now working again. So maybe fine. Will let you know
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
here, try this build -> https://github.com/nine7nine/Apps/raw/master/exNoShadez_eas_binder_rt_89604cd.zip

I've since fixed some potentially racy code in ashmem (which binder uses. might be the cause.).. I had overlooked this when working on binder...

I also just installed Duo - and front Camera is working for me (although I have no one to test an actual call with. lol both camera's working though).... Google Camera front camera also working for me...

let me know! I appreciated the report. Thanks a ton!
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
update: Deadline IO scheduler will be fixed in the next build - I've updated it with all of the commits. - testing it now, so far everything seems perfectly good....

Horgar is getting back to me tomorrow - late where he is - but I'd also like to hear from [MENTION=5502224]siheals[/MENTION] [MENTION=5930088]グリッチ[/MENTION] on the ltatest build.... Maybe [MENTION=3670244]marioemp2k7[/MENTION] if you are game for testing it out (?).... when you get a chance. thanks!

In the meantime, I am revisiting all of my notes and merging in bits and pieces that I had set aside. So far so good, getting a few more updates to the kernel committed. the list is shrinking quick.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Horgar:
Have just flashed. No camera crashes after first boot. No immediate bugs noticed. Will let you know after charging and a day at work tomorrow.

First impressions seems to load widgets quicker and be generally fast and smooth. I like it. I'll see how battery goes tomorrow.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
How long til next build? I can flash one now but flashing multiple in a day I don't think is well for testing battery.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Ok. Awesome - good to know! .... The camera should be all good now. I get zero crashes, both camera's work in all apps that I have tested with. HDR+ processing seems good....

Funny you should mention that ~> Yes, I too noticed a bump in speed on loading widgets, etc on start up too... There's a good reason for that though; The locking changes that I made to binder should make it much faster, in some situations - that appears to be one. (another is in my one audio app - where it's performance has improved a fair bit).

Do let me know on battery life - my testing for now on that front is limited; Mainly because I am constantly flashing new builds (not really getting a chance to let my Pixel drain or anything). Once I get the kernel out of beta - battery life will be a focus, for sure....
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Battery is important sure, but right now I need to verify that Google Camera and the cameras( in general) are no longer having issues. no crashes on Google Camera startup, both cameras working, etc...

if you flash today's test build and can report back on the camera, that would be extremely helpful and very much appreciated - then you can just stick with that build.... and test battery against that (that would be helpful too!).... Battery life not the highest priority just now - stabilizing the merging of the linux-4.4 code and binder is top of the list.... I'll be revisiting battery life after (when I pull in the latest Energy Aware Scheduler code.... that is now compatible with our kernel. it wasn't before the big merge).

my next test build won't be for a while - right now I'm working on merging in tiny things, fixups and code cleanups - not big overhauling - like massive locking/sched upgrades, changing around binder, ion, etc... next test build will be for EASv1.4 changes - and I have no ETA on that...

(let's get it stable before worrying about attaining the best battery life, right?)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
Flashed, first run crashed, second run back camera works but front camera does not work.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Interesting. both cameras most definitely work here.

I would suggest maybe trying to clear all of the data/cache for google camera and/or disable it, then re-enable and upgrade - maybe throw a reboot in somewhere there.... ie: test a few things....

maybe it will work itself out, after a run or two ~ i'm also wondering if there are revisions to the Pixel's hardware - like maybe there is some other variable here, that I haven't accounted for (?).

because right now - the camera is working pretty much flawlessly for me, but it wasn't until I changed binder.... I would get crashes sometimes with Google Camera...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
Whoops, I totally forgot that I was using the Pixel 2 Camera lol, I have disabled / reinstalled from play store (the correct version), and rebooted, now everything is working as it should be! No crashes on first run or anything :)

EDIT: Anyways, battery was low at the time so I just turned it off and am putting it to full charge again. Then I will give a better report at the end of at least a day or two of testing. After sorting out the issues I initially had, the battery has been doing pretty well for me so far though :)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
pheeeewwwwww!

Thank you for the clarification ~ I've been working extremely hard to diagnose and fix the Google Camera issues; unfortunately - i don't think I can support weird hacked up versions of the Google Camera app - only the offical version....

I'm not sure why the google pixel 2 camera app would crash - but I'm not sure I want to spend time debugging that either. LOL. ;)

EDIT: I do have some idea on why it would crash ~ that app was written to work with The Pixel 2's binder - which like my binder, has some additional (parallel) functionality. rt priority inheritance, finer grained locking, etc - that the stock marlin binder driver doesn't have, etc ~ I suspect that it works on my older kernel or stock kernel - due to binder just not dealing with that stuff (no knowledge of it), you probably are getting crashes with the Pixel 2 Google Camera app due to this, but this isn't something that I can easily fix and the effort required would yield little gain, for the time invested.

cool. so give this kernel a good test... Let's see if we can get a stable release out / update the OP download.... I'll be taking a look at the battery improvements and EASv1.4 updates soon, but not in a hurry. would prefer to get the kernel rock solid first.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
I had (rear) camera crash on me taking a few pictures (about 15 pictures in under one minute). I had to reboot the phone to be able to use it again, and then after reboot I took a video and the HDR processing bar got stuck but the video wasn't corrupt or anything, it was perfectly watchable til the end.

Dunno if it matters but I thought I'd give my setup in case it helps debugging: I had airplane mode on and GPS on high while taking the pictures. Version: 5.1.014.171916386 Also, now suddenly I can no longer get into the front camera again...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] almightysiman:
test It for a few hours,try to crash my camera by taking many pictures in one minute,and I can't,seem working fine so far.:)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
Well after extensive testing under heavy load the only problem is some slight crackling with the sound when playing in game. Camera works well, smooth scrolling. All very good.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
I'll have to look at this a bit later on. busy day today - When I have a few spare minutes - I will at least try to reproduce this ~ then later I will do it with the phone connected to my linux box / adb / logcat, etc....

I'm guessing that if you were to power down the phone, the front camera would start working again. (reminds me of the old cyanogenmod days - where the camera would get stuck on some devices ~ Cameras always are the hardest to support on custom roms - with my binder changes that appears to be true too ~ if worst comes to worst, I can always roll them back - I just would prefer to work through all of the BS and get it stable). lol
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
pretty much my experience too - but it looks like [MENTION=5930088]グリッチ[/MENTION] is having an issue - I'm gonna take a look later and see if I can reproduce / when I have debugging going.

what game > maybe I can reproduce and have a look?

I might have an idea on this....
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
The game is Dawn of titans
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Cool. just helps if I can test it out too....
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=5930088]グリッチ[/MENTION]

I have a hunch as to what the camera issue may be I haen't been able to reproduce the front camera issue (but regardlees, yeah powering down and restarting will bring it back 99.9% sure on that point). You can verify that, if you like,,,

I will test my hunch when I get home - it'll come down to changing something in my init rc strict OR rebuilding the kernel slightly differen.... So hopefully, I can reproduce it - by then, if not I'll post a build for you to test with the adjustments....

I really wanna get these stupid camera glitches resolved. ttyl
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=5930088]グリッチ[/MENTION]

I have a hunch as to what the camera issue may be... I haven't been able to reproduce the front camera issue (but regardlees, yeah powering down and restarting will bring it back 99.9% sure on that point). You can verify that, if you like,,,

I will test my hunch when I get home - it'll come down to changing something in my init rc strict OR rebuilding the kernel slightly different.... So hopefully, I can reproduce it by then, but if not I'll post a build for you to test with the necessary adjustments.. (I'll roll in both changes, since they aren't mutually exclusive)

I really wanna get these stupid camera glitches resolved. ttyl
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
Yes, rebooting fixes front camera. :p

Also, on a side note: I don't want to sound dumb comparing our phone to an iPhone 6s, but my friend and I play the same game, but her phone is much smoother while playing, is there a setting I can change to get faster gaming performance? I tried EX kernel manager's Performance setting and in fact it made the game much slower and the audio choppy lol
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
yup... I figure rebooting would start it up again. Killing camerserver might accomplish the same thing - not exactly a fix though - but thanks for verifying. It would appear the camera (front camera, specifically) must be getting hung ~ although, I'm not yet sure on specifics.... that's why I'm hoping that I can reproduce it on my end - so I can have a better look.... but like I said - I do have an idea or two on how to resolve this, just need to try a couple of things out....

No no. You're question doesn't sound dumb, Apple does do some optimizations in their chips and graphics pipelines that they can do - since they produce the hardware and software. I've always found iPhones to be smoother for certain things - For example, blur type effects used to be horrendous on Android (better recently, but on iPhone - it's been used for years in their user interface - smooth as can be...

I'll get back to you on settings to try to improve gaming later...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=5930088]グリッチ[/MENTION] K. so I am home now, gonna run through some stuff and see if I can reproduce and figure out how to fix these camera issues....

I have already made a couple of commits since being home ~ two are directly related to msm / platform code ~ I was playing with some of gcc's flags to get more verbose warnings/output and stumbled across a few compiler warnings; several were in the camera_v2 code. They should've been harmless - but who knows / nonetheless, they are fixed now though, so it doesn't matter...

anyhoo - I've got a few hours I can put into this - so hopefully, I will get to the bottom of it.

PS: Update for Google Camera today, just got it. lol
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
ok, So the hacking continues ~ I'm making some adjustments to Binder, Ion and the lowmemorykiller; based off of Code aurora's msm-3.18 branch...

I did manage to make the front camera hang - but it was after changing some of the error handling code around (which I obviously didn't commit or keep).... The Code I'm testing now, also changing the handling (and some other things too)... I've adapted their code to fit with mine ~ so I'm going to give this a good test and in the meantime see if I can track down any other gcc6/7+ warnings that may also be in the msm platform, v4l, kgsl or camera code....

may have a test build later tonight. depends on how things go.....

[MENTION=5930088]グリッチ[/MENTION] I really hope this isn't a case of you also having some other Pixel 2 software running on your pixel that could be causing crashes - I really wasn't able to get a crash until I changed some stuff in binder and the camera code, after I got home today... I will go under the assumption that you don't have any of that kind of thing though.

[MENTION=5502224]siheals[/MENTION] - Sound crackling should be fixed (in my next build). I had some settings in my init that were sound related, they've been removed. So next build should be good for that.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
ok, So the hacking continues ~ I'm making some adjustments to Binder, Ion and the lowmemorykiller; based off of Code aurora's msm-3.18 branch...

I did manage to make the front camera hang - but it was after changing some of the error handling code around (which I obviously didn't commit or keep).... The Code I'm testing now, also changing the handling (and some other things too)... I've adapted their code to fit with mine ~ so I'm going to give this a good test and in the meantime see if I can track down any other gcc6/7+ warnings that may also be in the msm platform, v4l, kgsl or camera code....

may have a test build later tonight. depends on how things go.....

[MENTION=5930088]グリッチ[/MENTION] I really hope this isn't a case of you also having some other Pixel 2 software running on your pixel that could be causing crashes - I really wasn't able to get a crash until I changed some stuff in binder and the camera code, after I got home today... I will go under the assumption that you don't have any of that kind of thing though.

[MENTION=5502224]siheals[/MENTION] - Sound crackling should be fixed. I had some settings in my init that were sound related, they've been removed. So next build should be good for that.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Horgar:
Been at work all day so haven't been madly testing but have taken a fair few photos. Had no crashes at all, all fine. As a consequence of taking lots of pictures I've used up battery so hard to give a view on battery life. I think it'll take a few days anyway to get a feel as to how much battery your excellent kernel uses.

But for now I have noticed performance improvements. Widgets load very quickly on boot and the general experience is of apps opening quicker and a snappier feel all round. From my amateur viewpoint it's an excellent kernel which feels finished. I just reserve judgment on battery life, which is important to me.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Hey Horgar,

Thanks for letting me know, appreciated. Ya, I'm not sure if the camera crash report that that I've gotten is valid or not.... As I haven''t been able to reproduce it - regardless, my binder port is a work-in-progress ~ and I did pick up some more patchwork for it today - So we'll see what happens and if I can get things stable across the board...

For sure some stuff is snappier ;) ... There are still bumps and kinks to work out though. (whenever you introduce mass amounts of code, change core functionality, etc ~ there are bound to be regressions and hiccups, at least it's a distinct possibility....

battery life and single threaded performance may be impacted (for now) - but after I get things stable, I can work on both again. (I have a few things in mind already; a few patches waiting to be merged AND because I upgraded certain parts of the kernel; we now have access to a couple of functions that could help improve battery life..... But I'm just too focused on Binder, Ion, etc && Google Camera has to not have any issues...

sounds like it's been working well for you, if you've been snapping lots of pictures though!
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Horgar:
TBH battery life isn't a deal breaker anyway, although important. I can get through a day at work on full charge pretty much whatever I do. I don't have much time to be on my personal phone! Why I'm here is because I'm happy with your approach of getting performance right and then moving on to battery and other stuff.

And I like playing my tiny small part in development. I'll stick with your kernel and do what I can to help out.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Sounds good and we are in agreement... my approach/plans are basicallly;

1. upgrade key linux subsystems, as much as possible.

2. upgrade binder, ion, etc.

3. get everything stable

4. get back to working on improving performance.

5. battery life

1/2 will assist help with 4/5 improvements.

3 is tricky because there are lots of corner cases)/exceptions.

but once I get through 1-3... the 4/5 improvements will come much easier.... on the one hand, I'm glad that Google Camera has been giving some grief, as it's forcing me to work on binder (which is difficult, but good) and it's pointed out some sour spots --- but on the other hand, Google Camera and binder, annoy me, fer sure. lol....

Anyway, glad that so far, it's working well for you, after yesterdays hiccups. ttyl
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
another bit of progress - I've merged some code for binder that adds helper functions/wrappers for the enqueue/dequeue work thread functions, there's also annotations (which helps me better understand what the code is doing and this code should improve binder (better handling of the threadpool) ~ may avoid some splats here and there..

I'm looking at some more Ion changes, that uses less locking and would help re-organize / clean up the code ~ but it's not an easy merge and I'm going to have to sift through it and grab what we need vs. what's incompatible....

may have a test build to post before bed... Depends.... My current test build with my binder changes from an hour ago - seems really good, but I forgot to charge my phone - so I gotta let it do that for a while before I can give it more of a test run....

I'm thinking this latest code might really improve stability, in regards to google camera or apps with lots of running threads.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
No I have no other Pixel 2 software. I have disabled the substratum theme I had on camera (which may have been the issue because I had the theme applied the entire time after disabling/updating again) to see if maybe that was the issue as well. Will continue testing.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
I highly doubt Substratum wouldn't make a difference here. Sure, it can cause certain apps to crash on boot after an update to them (without updating their resources / substratum), but that's an entirely different thing. all good.