yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] viceversa:
Has anyone who was already rooted with magisk (14.5) and on 8.0.0 (OPD1.170816.025) tried taking the official 8.1 OTA using the A/B method outlined below?

https://github.com/topjohnwu/Magisk/blob/master/docs/tips.md#ota-installation-tips

Edit: I asked before checking if the OTA is actually available within android. It appears that at this time (at least for me) it is not. Either way, is the method above an option most people take with magisk and OTA's on Pixel devices with A/B partitions?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] luciusfox:
Fix for the dtbo patching is to comment out the contents of the patchDTBO() function:

https://github.com/topjohnwu/Magisk...va/com/topjohnwu/magisk/utils/Utils.java#L242
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
I tried on the Android 8.1 DP2, last month on my Pixell 2 XL and it did not work. So I flashed the full Factory Image. Not sure if I did something wrong.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Shadow/Walker:
for anyone would like to fix the message: "There's an internal problem with your device. Contact your manufacturer for details" on 8.1 December's release

please follow my guide using this link

Cheers :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Nekromantik:
sideloading ota dont work for me.

i select sideload option in twrp but then it transfers nothing and exits and I get package error.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] drewski_1:
afaik, you need to be fully stock, including recovery, to sideload the OTA.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dmarden:
It's ok if you're running a Magisk batched boot.img, but otherwise... yeah. You need to be stock including stock recovery.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] UniX1rm:
I flashed on the latest 8.1 and all works well.

I have one problem though. Waking up the phones is slower, doesn't wake up right away, takes about a second before it takes up. Double tap or the power button. is anyone getting the same issue?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
No issue on my end that you are describing.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] corywf:
Anyone getting a magisk not activated error when trying to install modules?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
See Unofficial Build Thread for updated build with dtbo fix...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] corywf:
Installed the unofficial build and I'm getting a different error now. https://photos.app.goo.gl/gSeEN7MSUPq9THbH3
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] gettingerr:
Is anyone else unable to edit build.prop on 8.1 with Magisk? I can remount system as rw, but when I actually attempt to edit build.prop (or other files) it tells me it is a read only filesystem.

Edit: This appears to only have been a problem when attempting with fx file manager. Root Browser handles it just fine.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] neo_lithic3K:
not me. I'm on 8.1 with Magisk and I have root. I was also able to edit build.prop to unlock tethering.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Juzman:
I had that issue with 14.5 Magisk.

Went back to 14.4 I think it was, and modules installed okay.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Flash factory boot and dtbo before hand. I didn't get any errors... :confused:

Probably should move unofficial questions to the unofficial thread ;)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] PhoenixPath:
I am. Still on 8.0.0 Nov, did a flash-all (Nov, 8.0.0).

Have tried installing Magisk any number of ways with no luck. Been at it a while. Taking a break.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Sorry guys! Did not have time to thoroughly test before posting. This one will NOT patch DTBO.img... :rolleyes: Tested it this time ;)

Just flash factory dtbo.img then flash this zip. No more warnings on boot :)

Latest Unofficial Magisk Build

Magisk-14.5420NOdtbo
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] corywf:
My bad. Posting from mobile and thought I was in that thread :eek:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
All good bro, I screwed up the first one anyway ;) Updated now and working. :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Working great! No more nasty corrupted message! Thanks [MENTION=221500]theDude[/MENTION]

Edit: Not working after reboot, warning is back!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Ohhh... its working :) Survives reboot every time here, there, and everywhere. I removed all dtbo patching so there is no way you could be getting that error.... Unless say you updated in Manager app, then it would most likely patch dtbo again; however I have not tried that :/ Start over with factory boot/dtbo and try again. I assure you its working ;) And.... its thedude420 haha :p
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
What version of magisk manager are you using? Anything after 5.4.1 will patch it again. I get a notification that dtbo found and patched please reboot.

Tried 5.4.1 but magisk manager says can't check for updates no internet. Not an issue but safety net checks says api error and root checker says sn failed.

Hopefully someone will build 5.4.3 that won't patch it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] override182:
Have u tried apps like SafetyNet helper to verify? It happened to me before that magisk isnt able to do checks but my safetynet passes after verifying externally.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
Something happened and now I'm completely stuck without anything but stock 8.1 and unlocked bootloader.

I sideloaded the OTA using stock recovery. I then booted the phone, tried to patch the 8.1 stock boot, flashed the patched boot via Bootloader (fastboot) and it kept saying that I was not rooted, but magisk was installed.

I tried to remove everything (uninstalled Manager, supposedly removed Magisk). Now I can only get Magisk Manager 5.4.1 installed and it tells me "Target Magisk version doesn't support boot image file patching" Magisk is not installed and I'm not Rooted.

Anyone have any bright ideas for me?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
Yes I have and it fails
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dmarden:
Boot to bootloader

fastboot boot twrp.img (beta 2)

Install Magisk zip file
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] damngood98:
when in doubt, start all over....forget the ota, just install the 8.1 stock img file....clean slate never hurts
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
Hey guys i'm a little confused here but what do i have to use and or flash to keep root and a stable twrp on my pixel 2 xl? Because when i flash it (twrp) using skipsoft toolkit then flash the magisk zip after i reboot to recovery a screen pops up with android robot and says "no command". Thanks in advance
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Use adb instead of skipsoft, it's better to do it manually and learn the commands, not to mention its simple and easier to see which command failed. Follow the OP of Magisk or twrp or the root/factory flashing thread by Nathan.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
I'm a bit nervous to load TWRP since it's still beta. Plus, how would I get the monthly OTA's going forward with TWRP installed? Is there a safe way to flash the Magisk Zip with stock recovery?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mitchdickson:
Dude you are just booting it with that command. You are not replacing the stock recovery.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dmarden:
You don't install/(flash) TWRP, you one-time boot it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
WTH? I've never "booted" to TWRP as a temp/one-time. So my process is:

-Flash TWRP to Boot in Fastboot

-Reboot to Recovery (TWRP)

-Flash Magisk zip

-Reboot to system

-???

Does flashing the Magisk zip install Magisk Manager too?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jlokos:
it sounds like you didn't flash the twrp zip.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
Sigh..thats the thing tho i always seem to have trouble with adb and using commands :( lol but i will try again hopefully im successful. So question right now twrp is in alpha stage no matter if its v3.1.1beta or 3.2.0.0? And does it stick or its a one time flash and have to reflashing it when receiving new OTA or flashing a zip/custom rom? Sorry but im new to pixels since owning Nexus devices lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
Yes, this^^^ If I flash TWRP, it's going to be my Boot.img until you overwrite it. I **think** (and what I need clarified) that you flash TWRP and boot to TWRP, flash Magisk zip. Then when you boot to the OS (system) after that, you'll need to Patch the stock Boot image, then get to fastboot and flash the Patched stock boot.img.

So yes, TWRP is perm installed, but you only boot to it once, then overwrite with the Magisk patched boot.img (Am I correct?)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mitchdickson:
Dude, listen. This has already been explained to you, but here goes:

You are not "flashing" TWRP when you type fastboot boot twrp.img. You are "booting" TWRP. It does not overwrite anything.

---------- Post added at 10:21 AM ---------- Previous post was at 10:19 AM ----------

This was the exact same thing with Nexus phones. If you fastboot boot twrp.img, you are just booting it for a single use. You are not flashing TWRP.

---------- Post added at 10:23 AM ---------- Previous post was at 10:21 AM ----------

No. As already explained by dmarden, the process is:

Boot to bootloader

fastboot boot twrp.img (beta 2)

Install Magisk zip file
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
These are the steps I took for 8.0, works great, no issues.

When you're ready for 8.1 factory image upgrade, go HERE for the links and steps.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
Lol thanks guys i will try all options when i get home wish me luck:p
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Oh C'mon Jiggs, you know you can do this! You were all over the 6p threads helping a lot of folks out. If dumb arse old me can do it, should be a walk in the park for you bro :good::good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
I misread one word from a command (he said BOOT, I read FLASH) hence all the confusion. I appreciate the quick responses, and apologize for the confusion. I'm not dumb, just read too quickly. :(
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
Hahaha hey bro good to see you here on the Pixel side:good: but yeah thanks i know i can just gotta have some patience , sit back and take a swig or 2 and then get to work :D
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
There ya go Hoss! I always have some 21 year old scotch before I try blowing up my phone. Good time for sure :cool:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
One final question, now that I'm clear on my process, but where should I place the Magisk Zip so that I can flash it in TWRP? Right now it's in my Download folder. Should I go to the root of my user storage?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
wherever you can find it on your sdcard
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
K, thanks. I'm booting to TWRP now, though it's taking forever to load--TWRP logo screen has been sitting for about a minute... may have to try again!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dmarden:
Did you get the correct version (noted in my original reply to you)?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
Thank you [MENTION=4452264]mitchdickson[/MENTION], [MENTION=1314232]dmarden[/MENTION], and [MENTION=4670411]Az Biker[/MENTION] for the help and moral support. My Magisk is now back up and running!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
Yeah, just took a while for some reason.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dmarden:
Glad to hear it. :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
I am using Magisk Manager 5.4.3 It must be patching again.

---------- Post added at 12:40 PM ---------- Previous post was at 12:38 PM ----------

Thanks [MENTION=3297454]thedude420[/MENTION] I am using Magisk Manager 5.4.3 and it's patching dtbo after reboot. Tried 3 times. Works initially and does not work on reboot. Should I use another Magisk Manager?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Well, I uninstalled manager, reboot bootloader - flash factory boot/dtbo - boot twrp img - install twrp - reboot recovery to installed twrp - install a kernel if you want (I'm running flash 2), then magisk 14.5420.

I am not 100% on this but I don't think the installer will overwrite manager if its already installed hence the update dtbo. I have heard another person suggest this but have not looked into the code. It's either that or the A/B partitions are getting out of wack. Another individual stated that flashing full factory image without -w resolved the issue which would straighten out any A/B issues... Honestly reflashing factory img without wiping doesn't really take much longer so I would go that route.

Once 14.5420 is installed on a clean system (or one with the previous manager uninstalled?) then manager will not update dtbo any longer.

Hope this helps ;)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
What version manager are you running?

Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
The one I compiled with the fixes...

Not sure if it will overwrite and already installed manager though. Maybe because they are the same version? I don't know, but I know that if you flash 14.5420 without manager installed then there will be no dtbo patching going on :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
For the record, I've had TWRP "installed" since beta 2 dropped with zero issues.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] WorldOfJohnboy:
Did you flash the 8.1 December OTA via TWRP? Just curious to know if I should take the plunge myself.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
twrp is pretty solid atm. Only thing I have noticed and that sometimes after booting img then flashing twrp zip I will get no touch response after rebooting recovery... But every time I just reboot bootloader, boot the twrp img, reinstall the twrp zip, reboot recovery and touch works fine after that... Just takes twice for some reason ;) Could just be me, Idk..
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Would you please supply a link to the Magisk Manager apk. Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
Will uninstall existing manager and reflash boot and dtbo then 14.5420.

Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Just grab 14.5420 from unofficial thread and extract it from the common folder. Or install the zip in twrp with factory boot/dtbo

without

the manager apk installed.

---------- Post added at 12:14 PM ---------- Previous post was at 12:12 PM ----------

Give that a shot and report back!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
That did it. You thedude420.

I did have to extract the app since it it not install after installing from twrp beta 2.

Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Dang... Really? I will look into the script later on this afternoon. Not sure why it's not installing the app. I am pretty sure it did on mine but I can't remember. I assume an official release is in the near future as new commits are on git. Just doing these to hold things over while the devs straighten things out. Thanks for reporting back!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
Appreciate all you have done.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
No worries!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CPngN:
When you ran Magisk to patch the file, did you first enable BETA channel so that it downloads 14.5 for use with the patch? Your version numbers sound old too. Magisk is at 5.4.3. You need the latest or it fails silently.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Anyone else seeing this after upgrading to 8.1 and root?

49 days? I charged the phone last night lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Dielahn:
Thats amazing battery life! Teach me your ways
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Extracted, as you suggested. Working perfectly. No warning, even on reboot.Thanks [MENTION=3297454]thedude420[/MENTION] !
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
:good: Rite on man! Glad to hear it!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bemagrp:
[MENTION=3297454]thedude420[/MENTION]

Back to unlock critical.

Tried flash 8.1 from November build 8.0, got stock on flashing bootloader to active spotb. failed because flashing is not allowed for critical partitions.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bjrmd:
This happened to me too. What a PITA!

The only way around it (besides flashing critical and losing all your data) is to sideload the new OTA.

After that, just root the usual way with a patched image from 8.1.

So users who have the original bootloader will need to update by OTA from now on since you can't update the bootloader unless you unlock critical.

Of course, you could just do that but you would then start from scratch.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] km00000:
What's the fastest way I can update to stable 8.1 from 8.1 DP2 if I'm rooted with Magisk and have TWRP installed?

I'd prefer to not have to set up my phone again for the 10th time trying to figure this out... :confused:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Shadow/Walker:
Google developers mentioned an update from dp2 to stable 40 mb update OTA
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] km00000:
The 42.9 MB one? The install always fails. And I think when I tried to side load it, it failed as well. I don't I've tried so many different things that I can't keep track.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Get the factory image and do a flash all (without - w) that's how I went from 8.0 to official 8.1, should work for you as well since your not trying to go backwards.

I would disable any themes you have 1st
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] km00000:
I tried that on Wednesday when the stable image came out. It would give me a message saying my device was corrupted then would freeze on the Google screen. Had the latest adb/fastboot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mitchdickson:
You're doing something wrong. That's the way to do it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] IlyaKol:
I just want to confirm the process for others because I know it's sometimes a pain having to reference multiple threads, multiple posts, etc. while gearing up for an update.

My previous setup on my Pixel 2 XL:

- 8.0 (Nov)

- Stock recovery (I don't remember if I just booted to TWRP to install Magisk but didn't actually flash TWRP but I'm 99% sure that's what I did)

- Magisk 5.4.3 (64)

- No custom kernel (I'm waiting for Elemental to release his)

- Did both types of unlocks (regular and critical) when I received my phone

I used the following two posts to upgrade to 8.1 with ZERO issues.

- This post by [MENTION=4670411]Az Biker[/MENTION] - https://xdaforums.com/showpost.php?p=74772300&postcount=296 (I skipped the kernel step and used a different version of Magisk - see next line)

- This post by [MENTION=3297454]thedude420[/MENTION] - https://xdaforums.com/pixel-2-xl/development/unofficial-build-thread-magisk-twrp-t3708555 (for the magisk steps)

So basically, my order for MY situation, was as follows:

1) Uninstall current Magisk Manager

2) Flash-All.bat of 8.1 without data wipe (removed -w from script) (I like to do this on both partitions so I run this twice, once on 'a' and once on 'b')

3) Boot to TWRP

4) Flash TWRP

5) Reboot to recovery

6) Flash Magisk from post 2

7) Reboot to system and rock on. Hard.

No warnings on boot other than standard bootloader message, etc.

Good work guys!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bemagrp:
Did you have your bootloader unlocked critical?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] IlyaKol:
Ahh, yes. I did both types of unlocks when I first got my phone. I edited my post to include this info.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
You're not alone here :svetius:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] w02justin:
How should we update to 8.10 and reroot the phone?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Lol.

Scroll up a few posts, it's right there and all over this site.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] IlyaKol:
Seriously. Don't even have to go back a few pages like my lazy butt had too...oy vey. These people.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] km00000:
I'll try this out. I'm hoping last time I ran the script, it didn't work because I didn't uninstall magisk first.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
Prior to flashing 8.1, I tried to run the Magisk uninstall zip in TWRP and it failed. So I just went on with my process and never had any issues. Latest Magisk 14.5 (1456) and 5.4.3 manager running great...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] hanschke:
I have installed 8.1 full image and try to flash the patched boot.img 5 times now and su not work :(
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] xflowy:
nvm :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] hanschke:
Magisk-v14.5.2-171207 can I take it too?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Cowbell_Guy:
Can the following method be used to update from Nov to Dec updates? No custom recovery or kernel installed.

https://github.com/topjohnwu/Magisk/blob/master/docs/tips.md#ota-installation-tips
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] w02justin:
Even though I flashed the new patched_boot.img, it still says Magisk is not installed. What's the problem?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Well, you probably screwed up your installation, but without specific details on the steps that you followed and a logcat, it is difficult for anyone to help you.

I suggest that you repeat the steps above, and document the step by step results. Good luck!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] km00000:
Tried these steps going from 8.1 DP2 to 8.1 stable. Resulted in a device is corrupt message... Phone won't boot into the system now.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
What steps did you follow, and in what order?

If you flashed, Magisk 14.5 (1456) zip in TWRP, it automatically patched the image and installs magsik manager.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] heelsfan25:
I am a verizon guy, but i received an unlocked replacement under warranty. I have unlocked the bootloader and flashed the newest image. I have yet to put the sim in yet and i am wondering if i do put it in, will i still be able to root since it is unlocked?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Did you also unlock_critical?

You can put in the sim, you should be ok!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] hanschke:
[MENTION=4670411]Az Biker[/MENTION]

form 1 until the end I have done all step by step.