yashsingh1/xdaforums huggingface dataset:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=1007992]everyone[/MENTION] I'm also now complete the 4.3 locking code (it took a while - I had to revert some franco and nvidis patches that messed with arm64 asm/atomic definitions ~ to merge in the proper files from ARM/linux upstream and generally, there were just heaps of changes in that particular pull/set of commits).

I'm actually going to jump the gun here and post a test build, as I won't get finished up with the linux-4.4 upstream commits until later and thus far; my current test build is far better (overall) than the OP download. Here it is;

https://github.com/nine7nine/Apps/raw/master/exNoShadez_eas_linux-4.3-sched-locking_badd0a7.zip

feedback / observations are always appreciated. thanks.

it's possible that u may bump into a bug or crash - usually, after an official linux kernel release and people start using it, bugs are revealed and quickly fixed - i'm synced up with linux-4.3.0 sched/locking, but i bet there are lots of minor fixups in the minor/point releases....

i'll get them all when pulling 4.4 + lts fixes for that kernel. it's a process. lol.

Can't wait to get this code finalized and move onto other linux subsystems.

IMPORTANT: Don't use deadline IO scheduler for now (i just forgot to disable it in the build), please tests with defaults / cfq! .... I have to do some review and merges before having deadline again...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] Horgar:
Feels snappier and smoother already. Good stuff.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
It should be. there is a lot of optimizations to the kernel for locking, atomic instructions, scheduling, etc...

Google Camera wasn't crashing at all for me, but it is now -> not sure why yet, but i'm still in the middle of merging in code - so I kind of expect breakage - I can review the AOSP android-4.4 common tree to see what upstream patches that may have revert + plus, I'll be pulling in all of the mm subsystem && upgrading other bits - should smooth itself out, given a day or two to work out the kinks.

I'm just booting up a sched-4.4 kernel now, still need to work on the locking changes, but I always test lots of builds in between - wouldn't want to do 30 commits and then find out it doesn't boot or has some serious regression. lol...

linux-4.4's sched code has been pretty painful to introduce, half I *already* had merged. Some have been modified by EAS Code already applied and a few I have to review before commiting... The locking for linux-4.4 patch is someewhat small and manageable. phew.... way less invasive...

then I'll have to see how to best handle the LTS chery-picks (as I can't apply the incremental patches directly to my branch - different kernel version.... So gotta decide on how I'm going to do that easily...hmmmm.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
getting most of the locking changes finalized now - there's just a few sour spots, where upstream linux has omse bits and peices that we seem to be missing - so a few tricky changes to sort out....

I've annotated all of my waiting-to-be-merged patchwork = so I can figure that stuff all out - still going to take some time to resolve.... I might switch it up and take a look at the mm subsystem now, as I could use a break from all of the arm64 locking and atomics stuff....

the good news is that i'm about 95% of the way there with the locking stuff and while I am still getting the odd crash with Google Camera - I have yet to touch some of the code that I think will resolve that once and for all, so not going to post another build yet - instead focus on getting a few other subsystems caught up, then revisit the locking atomic changes for linux-4.4...

so far- no performance reqgressions - actually, possibly improved on benchmarks slightly...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] almightysiman:
Maybe this is not a bug,but I have to report It anyway.I am on latest stable kernel,I found that the idle drain is a bit higher about 5% than other kernel like Kirisakura which only drain about 0%-1% overnight on the same condition.so I hope there's something you can do about It and keep up the good work!:good:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
It very well could be a bit higher. I wouldn't say that's a bug though.... What I would say is that our kernels are fairly different and up and until recently - I haven't put much energy in power saving - it'll be something that I direct my focus on after overhauling the kernel sources - with all of the linux/android-4.4 upgrades....

but thanks for making this note - very appreciated....

The dust should settle in a few days on my massive overhaul and I will try to provide a (much more stable) build then ~ we can start to tackle battery life then.... sound good?
[Google Pixel ROMs, Kernels, Recoveries, & Other De] almightysiman:
Aside from Camera crash sometime,the test build seem pretty stable!
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Yup. google Camera is great - but annoying! itseems to be the only real issue for me, right now - but I'm also not done merging in code, still working on workqueues, timers, linux-mm, etc ...and I haven't finished with the locking code yet... It's all takes time...

But as soon as I have a build that plays nice with google Camera (which seems to do some odd stuff with threading, I will post another test build.
[Mogul, XV6800 ROM Development] 1999TL:
save it in WMA format. You will get less of a delay with the phone. Also, just start out with a good quality file and clip it to suit your needs.
[Mogul, XV6800 ROM Development] fallingup:
i use the vzw site for ringtones, if you have firefox you can search their ringtones, and download the actual "listen now" mp3 for free ;)
[Mogul, XV6800 ROM Development] gbenj:
do you mean wma? or wav cause i tried both and i think wav starts quicker than wav....
[Mogul, XV6800 ROM Development] gbenj:
and how might i do that?
[Mogul, XV6800 ROM Development] blackstone@sossquad.com:
right click, view source, find the actual .mp3 location and copy paste it into a browser?
[Mogul, XV6800 ROM Development] sovrce:
myxertones.com from PIE is a very solid source. Nothing like 325kbps, but still decent.
[Mogul, XV6800 ROM Development] wallywallyv:
You can always just put some mp3's on your phone and use HTC Audio Manager to make ringtones. In Audio Manager start to play the song you want to use and then left soft key then click use as ringtone (or something like that) then press trim and trim the song where you want. Then you have the option to save as default or to the ringtones folder.

Also something i found out messing with ringtones a while ago, if you get a program that changes the gain on mp3/wav files you can make the ringtones ALOT louder. You just have to find the right spot where the song will not distort.
[Sprint Samsung Galaxy Note5] Multidex24:
Alright... I'm so excited for my 2nd note to come. This is also my 2nd sprint but who cares right? My last note was the Note 4 from at&t and i kinda miss it. But the battery kept overheating and I couldn't flash a rom on the phone. But I know I can if I have a sprint or a tmobile galaxy. Lol I seen YouTube and XDA.. So What's the Best Rom for this note?

I need everything for this thing.( Recovery,Rom...(S8/Note 8 port), everything). I'm using my s6 edge on tmobile and the signal is really low. I mean I still get good 4g lte signal but around 1 to 3 bars. Especially when I'm on the phone with somebody. Wifi calling is included. Hotspot is included. Almost everything works except binge on and visual voicemail. I can get the phone unlocked it's been paid in full.. I just need this thing to run like it's successor (note fe or note 8). it be cool to have the sprint 4g lte icons and the sprint boot up screen and make it feel more authentic with Better speeds and everything and I think that's what sprint has one up on. But I love tmobile so thats why I want this to run as a sprint phone using tmobile. Especially with extended range? I need help and input.
[Sprint Samsung Galaxy Note5] masterhuh:
I'm not sure n920p is going to work well for you from a WiFi calling standpoint. Sprint WiFi calling isn't compatible with TMobile's system so the ROM will have to be tailored to work. I had a similar issue with Mint Sim with my Sprint Note 5.
[Google Pixel 2 Questions & Answers] VadimTk:
Checking if someone tried Android Pay.

I am getting "Card read error" with Pixel 2 at the registers where I was able to use 1-gen Pixel without problems.

Wondering if I am doing something wrong or there is problem with my Pixel 2.
[Google Pixel 2 Questions & Answers] bloomylicious:
Works fine for me, used it quite a lot, however I'm in the UK so we may use different contactless payment devices at shops, not sure.
[Google Pixel 2 Questions & Answers] -Michael_:
Yep, used it quite a bit, no issues here.

I've used it at:

-maverick gas station, pump and inside.

- local diner

-local steakhouse

-sprouts

-sams club
[Google Pixel 2 Questions & Answers] scoliosis:
Works fine for me. You can try turning off and on NFC to see if it helps.
[Google Pixel 2 Questions & Answers] mackentosh:
I use it all the time, works great
[Google Pixel 2 Questions & Answers] knetknight:
I've been able to use Android Pay on my Pixel 2 XL... but it is S-L-O-W! My Nexus 6p was always nearly instant when I'd hold it up to a payment terminal, but my PIxel 2 XL just sits there like it's not even trying for 5-10 awkward seconds before it finally (usually) responds like it is supposed to. Anyone else? Or am I ... special?
[General Questions and Answers] rmdot:
I got a cheap Dragon x10 2017. Its stock with Android 7 however it runs a custom firmware and that's created an issue with NordVPN and its kill switch. It does not have a locked boot loader so flashing it should be easy enough. However i'm new to flashing and i'm not sure if you can even get official firmware builds that will work on an off brand tablet. Thoughts?
[Google Pixel 2 Guides, News, & Discussion] giant22000:
***Bootloader must be unlocked as a prerequisite.

11/4/2017 - Scroll down to find new method that doesn't require TWRP.

You will need to download the alpha version of twrp, snoke kernel r7-p2-root and magisk 14.3 (1437)

1. Reboot phone to bootloader.

2. fastboot flash boot Snoke-R7-P2-Root.img

3 fastboot boot twrp-3.1.1-alpha1-walleye.img

4. Once in twrp, start adb sideload.

5. From cmd, adb sideload Magisk-v14.3(1437).zip

6. Reboot and enjoy root!!!!!

All credit comes from this post.

11/4/2017 - Post updated.

Just wanted to add this as another option for those who may find this method easier. No TWRP needed.
[Google Pixel 2 Guides, News, & Discussion] mac796:
I gave this a shot on the XL. Couldn't get it to sideload. Maybe I'm doing the sequence wrong. Doing something wrong. Doesn't see the file. Thanks for the guide
[Google Pixel 2 Guides, News, & Discussion] giant22000:
Are you enabling sideload once booted into twrp?
[Google Pixel 2 Guides, News, & Discussion] mac796:
Been a long time since I sideload. But I flashed the root kernel, then booted TWRP, then advanced, side load then swiped, gave me an error about no encryption but started then I opened command window in folder I had magisk beta file, entered command. I got error, no such file I believe
[Google Pixel 2 Guides, News, & Discussion] giant22000:
So the command your entering is:

"adb sideload C:\your\computers\filepath\Magisk-v14.3(1437).zip" ?
[Google Pixel 2 Guides, News, & Discussion] Chronzy:
Doesn't work on XL. Currently don't know exactly why.
[Google Pixel 2 Guides, News, & Discussion] mac796:
Yep that's what I did.

Ok I thought I was doing it right thanks.
[Google Pixel 2 Guides, News, & Discussion] giant22000:
I see. I was just about to mention.
[Google Pixel 2 Guides, News, & Discussion] Archangel:
Worked perfectly for me thanks brother!
[Google Pixel 2 Guides, News, & Discussion] DJBhardwaj:
Thanks! Is it working for the Pixel 2 XL too? Did anyone try?
[Google Pixel 2 Guides, News, & Discussion] nuumuun:
See 3 and 4 posts above yours
[Google Pixel 2 Guides, News, & Discussion] jco23:
thanks for providing/testing this.

does root stick even after subsequent reboots? are root apps (like adaway, TiBu, Root Explorer, etc.) working as they should? any screenies would be helpful.
[Google Pixel 2 Guides, News, & Discussion] bobertfishbone:
This process seems to work perfectly. Adaway works as expected, and root persists after a reboot. Big thanks to those who worked on it!
[Google Pixel 2 Guides, News, & Discussion] GohanBurner:
I keep trying and it keeps failing.

C:\Users\gohan\AppData\Local\Android\sdk\platform-tools>adb sideload Magisk-v14.3(1437).zip

opening 'Magisk-v14.3(1437).zip'...

connecting...

falling back to older sideload method...

error: closed

Edit: For those of you like myself who have never sideloaded anything before, you need to actually enable the feature first in TWRP before you can use it. >_<
[Google Pixel 2 Guides, News, & Discussion] giant22000:
Do you have the lastest adb/fastboot running or is it an older version?
[Google Pixel 2 Guides, News, & Discussion] mac796:
Yes. I have latest. Some one already said it doesn't work on xl
[Google Pixel 2 Guides, News, & Discussion] MrGimpGrumble:
For XL i did the following

fastboot flashing unlock-critical for bootloader

then followed the instructions but used the Taiwen TWRP version

going to reboot it now and test but it looks better than before!
[Google Pixel 2 Guides, News, & Discussion] gaijinsmash:
Thank you

Thank you for the efforts and information sharing here. Using the Snoke kernel and the root process outlined here I was able to enable native tethering on the Pixel 2.

This is hugely appreciated!
[Google Pixel 2 Guides, News, & Discussion] Xechorizo:
Works great! Thanks to the original discovery and for the succinct instructions.
[Google Pixel 2 Guides, News, & Discussion] MishaalRahman:
Can someone whose Pixel 2 is rooted add "ro.debuggable=1" to their build.prop? That should enable the Pixel Visual Core Developer Option (Camera HAL HDR+ in Settings --> system --> developer options)
[Google Pixel 2 Guides, News, & Discussion] kevdog98:
How long does it sit at the Google Splash screen? My Pixel 2 XL is stuck there.....
[Google Pixel 2 Guides, News, & Discussion] cstark27:
Thanks! I used Snoke-R8-P2.img since I couldn't find the -root.img. Network Signal Guru is working. 4x4 MIMO and 256QAM verified for T-Mobile!
[Google Pixel 2 Guides, News, & Discussion] smith8ca:
Most people seem to be reporting that this doesn't work for the Pixel 2 XL ... The method mentioned in the OP is for the Pixel 2 (smaller variant)
[Google Pixel 2 Guides, News, & Discussion] kevdog98:
Thanks. I think it is also because I am running 8.1 DP 1. Reflashed boot.img and the the OTA image from 8.1 DP 1 and I'm good to go, but with no root. That can wait for another day.
[Google Pixel 2 Guides, News, & Discussion] kachaffeous:
Can't get it to work on 2XL either. Was on 8.1, reverted to 8.0. Made sure everything was working.

adb reboot bootloader

fastboot flash boot Snoke-R7.img . (tried R8.img also)

fastboot boot twrp-3.1.1-alpha1-taimen.img

start adb sideload in twrp;

adb sideload Magisk-v14.3\(1437\).zip

Get error:

Boot image patched by other programs

Please restore stock boot image
[Google Pixel 2 Guides, News, & Discussion] bluh5d:
What if you don't do the after market kernel?
[Google Pixel 2 Guides, News, & Discussion] -Michael_:
Won't work need that specific kernel.

---------- Post added at 11:23 PM ---------- Previous post was at 11:22 PM ----------

Not compatible with the XL yet, as I understand it, that's still a WIP
[Google Pixel 2 Guides, News, & Discussion] Riksad:
What adaway version are you using? The latest one I have fails to copy the hosts on 8.0
[Google Pixel 2 Guides, News, & Discussion] bobertfishbone:
3.2(60), which was the version I pulled off f-droid this morning.
[Google Pixel 2 Guides, News, & Discussion] eevanskiteboards:
worked for me

I followed the original posts and ran into issues with adb commands saying failed etc. i switched to a different port (2.0 I believe) and had the same fail message. I tried again and adb was frozen more or less. what fixed it for me was rebooting my pc and starting over while in 2.0 port, that worked, but i was then stuck on the google splash screen for 5 mins. I forced a phone reset by holding the power button and then was able to get my home screen!! hopefully that helps someone else out. thank you to those who made this possible.

pixel 2 project fi

snoke R8-P2

magisk 14.4
[Google Pixel 2 Guides, News, & Discussion] bryantjopplin:
would any of you be willing to reflash magisk via twrp and pull the recovery.log including kernel and upload????????????? PLEASE!!!!!
[Google Pixel 2 Guides, News, & Discussion] farrenicus:
unlock_critical is unnecessary for this, correct? I saw it mentioned so want to confirm a standard unlock is adequate.
[Google Pixel 2 Guides, News, & Discussion] Benn00:
I couldnt even get my bootloader to unlock without using _critical
[Google Pixel 2 Guides, News, & Discussion] Archangel:
Is there supposed to be mis-matches when doing safety net check? I have had at least one before but now I have both failing safety net check but root is intact?
[Google Pixel 2 Guides, News, & Discussion] cb474:
This person reports you don't need the Snoke kernel:

https://xdaforums.com/showpost.php?p=74388277&postcount=19
[Google Pixel 2 Guides, News, & Discussion] Natakranta:
Magisk Manager > Settings > Magisk Hide

check if turned on. I noticed it doesn't stick after reboot on my N6P and SafetNet checks fail. I turn it back on and both SafetNet checks pass.
[Google Pixel 2 Guides, News, & Discussion] smith8ca:
Everything worked for me without the Snoke kernel. I followed all the instructions except the step for flashing the kernel.
[Google Pixel 2 Guides, News, & Discussion] Slomies:
I followed the instructions and used Snoke R8 and am passing safety net checks...
[Google Pixel 2 Guides, News, & Discussion] gururoop:
Anyone tried this on 8.1 DP without Snoke kernel?
[Google Pixel 2 Guides, News, & Discussion] smith8ca:
It will not work with 8.1. Those who have tried have reported bootloops and have had to re-flash the factory image in order to get their phone to boot.
[Google Pixel 2 Guides, News, & Discussion] mtpease:
Where are you guys getting the image for P2-Root? I don't see anything on the Snoke page for a root specific boot image. Thanks!
[Google Pixel 2 Guides, News, & Discussion] OldNut5:
I'm stuck at booting to twrp, when I run fastboot boot twrp-3.1.1-alpha1-walleye.img it get's stuck at black screen. Need help.

I couldn't find snoke kernel r7-p2-root anywhere, I used Snoke-R8-P2.img, using the usb 3.1 cable that came with my device.

OS: Linux Mint 18.2 Sonya XFCE

Update: Never Mind, had to re-download twrp. everything's now working as should, magisk successfully flashed.
[Google Pixel 2 Guides, News, & Discussion] nuumuun:
Same here [emoji41]

Just fastboot boot the twrp alpha. Then sideload Magisk 14.3.
[Google Pixel 2 Guides, News, & Discussion] neuron617:
Confirming that this worked great on Pix 2, no Snoke kernel, first time.

Many thanks, I am real happy. Can I buy you a drink, contribute to your education fund, or..?
[Google Pixel 2 Guides, News, & Discussion] Benn00:
I think they're all root versions now, I just used the latest P2 and it worked great
[Google Pixel 2 Guides, News, & Discussion] cb474:
If one roots on 8.0 using this method and then later updates to 8.1 will you get bootloops? Or just lose root?
[Google Pixel 2 Guides, News, & Discussion] bjgood:
Will OTAs even work once magisk is loaded? I thought the OTA scripts check for modifications and abort if found, specifically to avoid bootloops or other issues. Or are you talking about somehow manually applying the update bypassing those checks?
[Google Pixel 2 Guides, News, & Discussion] giant22000:
No, OTA's won't work once rooted. You'll need to update manually which is no big deal. Remove the -w command from the flash all bat file and it won't erase your data when flashing factory image. You'll need to root your phone again afterwards.
[Google Pixel 2 Guides, News, & Discussion] cb474:
Thanks for the info.

Right now I just want to root, so that I can use Titanium and copy apps with data over from my old phone. Is there a way I can unroot afterwards and go back to having OTA updates work?

(I will be so happy once Lineage is--hopefully--working on this phone and I can get away from the Google nonsense.)
[Google Pixel 2 Guides, News, & Discussion] gururoop:
I needed root for the exact same purpose. Once I restored apps and data, I booted the recovery and sideloaded magisk uninstaller from its official thread and was successfully able to update to 8.1 via OTA.
[Google Pixel 2 Guides, News, & Discussion] multi_rom_user:
I just found a much faster and easier way to install magisk on the wonderful Pixel 2...

1. Download Magisk Manager 5.4.0 apk

2. Open app and tap install

3. Use the patch boot img option.

4. Locate the patched_boot.img within internal sd/MagiskManager and move it to root of phone memory.

5. Send that file to your pc.

6. Boot to bootloader.

7. Input command into cmd "fastboot flash boot patched_boot.img"

8. Reboot and you have latest root package or whichever you downloaded.

No need to use twrp for this at all. I posted this because following OP's instructions very carefully it didn't work.

---------- Post added at 03:47 PM ---------- Previous post was at 03:41 PM ----------

Here's Snoke's Kernel link. https://drive.google.com/drive/folders/0B4tnYt16-NAUeUtkRUVna1FGVW8
[Google Pixel 2 Guides, News, & Discussion] giant22000:
Do you mind if I post this in the OP so others may find it easier as another option? With due credit of course. :good:
[Google Pixel 2 Guides, News, & Discussion] multi_rom_user:
Of course! Copy and paste to it and you can delete that part of the post.
[Google Pixel 2 Guides, News, & Discussion] cb474:
Thanks.

I'm also curious. Do you know if while one is rooted one will still get notifications that there is an update available, even if you can't do the OTA update?
[Google Pixel 2 Guides, News, & Discussion] gururoop:
Usually, you do get the notification but the update doesn't go through.

Anyway, I just tried rooting 8.1 with stock kernel, twrp alpha and magisk 14.4 and guess what? It worked!
[Google Pixel 2 Guides, News, & Discussion] cb474:
When you say, in 4, to put patched_boot.img in the root of phone memory, do you mean in /sdcard/ (the main sdcard directory) and not a subdirectory under /sdcard/? Because since the phone is not yet rooted, one does not have access to the / directory (i.e. the root directory).

---------- Post added at 01:57 AM ---------- Previous post was at 01:48 AM ----------

Where did you get magisk 14.4?
[Google Pixel 2 Guides, News, & Discussion] Natakranta:
link in this post
[Google Pixel 2 Guides, News, & Discussion] multi_rom_user:
-Yes the /sdcard/ directory sorry for that confusion.
[Google Pixel 2 Guides, News, & Discussion] foosion:
Why move the file? Why not just download it to your PC from that location?
[Google Pixel 2 Guides, News, & Discussion] multi_rom_user:
Because it is a hidden file by the system and it won't let your PC see it in that location even if you have access to Bowen files.
[Google Pixel 2 Guides, News, & Discussion] muzab a:
Quick silly question but I'm assuming this requires bootloader to be unlocked
[Google Pixel 2 Guides, News, & Discussion] Natakranta:
Correct. You need bootloader unlocked to accept commands like

fastboot flash

or

fastboot boot
[Google Pixel 2 Guides, News, & Discussion] muzab a:
So passing safety net doesn't require to keep bootloader locked
[Google Pixel 2 Guides, News, & Discussion] Natakranta:
Not at all. Bootloader unlocked. Magisk 14.4 rooted. SafetyNet passed.
[Google Pixel 2 Guides, News, & Discussion] multi_rom_user:
I signed up for the beta OTA updates and I downloaded it after rooting and it updated with no issues other than loosing root, which was expected.

---------- Post added at 03:16 PM ---------- Previous post was at 03:14 PM ----------

Are you on stock kernel rooted or snoke kernel?