yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
So for the past 3 or so days I have been running snoke r11se kernel and have not had any reboot or fc issues. I have not flashed twrp yet. Waiting to see how things go after the Dec security update and what issues might occur.

Flashed stock boot.img, fastboot twrp and flashed 11se.zip and magisk 14.4.2.zip and rebooted.

I did tried to flash snoke r11se-p2.img but had no luck with fastboot flash or twrp. Just stuck at the Google logo.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
All's very good with SafetyNet! Also, Playstore certified after clearing its cache & data & rebooting! :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] skinza:
P2 is normal pixel not xl
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bggold:
Thanks that explains it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
Took the 8.1 OTA on wifes XL 2. Then tried to update Nov. Patch and Magisk 4.2. Long story short, she is now on 8.1 with October 5th Patch (i know right??) and the Nov Factory image installs but hangs on splash screen. I can get into bootloader and TWRP Alpha. Not a pro but pretty knowledgeable regarding fastboot, adb commands. Had 2 Pixel 2 XL's up and running with Magisk no problem, but she reboots like its her thing.

Basically been spending all Sunday researching and trying new things. Worth mentioning I'm also receiving extra 'red' your device is corrupted screen prior to normal unlocked bootloader screen. IDK, anybody point me in the right direction? Would really appreciate even a link to troubleshooting steps. Have tried everything I've been able to read today.

Might need a different image than the ones on the Google site, or roll back to 8.0 if possible at all.

Anyways, thanks if your willing to give some advice.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] an21281:
What do you mean by Nov patch and Oct patch,?

Either way you can roll back to 8.0 Nov firmware just dl firmware and flash-all. Removing - w from flash-all didn't work for me downgrading so had to keep it so it wipes the phone. Or you can flash-all 8.1 again and start over, or do a factory reset
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Are you using the BusyBox in magisk?

---------- Post added at 09:56 PM ---------- Previous post was at 09:55 PM ----------

Use the zip it works for both

---------- Post added at 09:58 PM ---------- Previous post was at 09:56 PM ----------

If you have messed with /system OTA will not work from what I read. You can flashall the 8.1 if you want.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] drewski_1:
Those aren't the latest Adb/Fastboot.

I was using those and the root process didn't work until I updated to the latest from Google.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Itachisasuke:
This is my understanding as well. I'm a habitual build.prop editor in order to turn on tethering and have never been able to take an OTA because the hash of the /system partition doesn't match even if you revert the changes which makes sense based on the hash sum being generated when Google uploads the factory images.

For monthly updates I always do the following process.

1. Download Factory Image for that Month

2. Download Latest Platform Tools

3. Download Latest working TWRP Image

4. Download Latest Working Magisk Zip

5. Edit the flash-all scripts to remove the -w so user data isn't wiped

adb reboot bootloader

flash-all.bat

Let the phone boot and finish the update install

adb reboot bootloader

fastboot boot twrp.img

Allow adb sideload in TWRP

adb sideload Magisk.zip

Profit with the newest monthly update with root.

This has been the least painful way for me to install monthly updates. Hopefully this helps.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Kenneth196:
Hey all. Anytime I try to install a module (besides Busybox, that appears to install just fine), it states:

/data/magisk isn't setup properly!

Please install Magisk v14.0+!

I'm on Magisk v14.4 via following Nathan's guide (https://xdaforums.com/pixel-2-xl/how-to/guide-unlock-flash-root-pixel-2-xl-t3702418), Nov update, stock everything. I'm thinking maybe I chose OTA instead of factory image when I did everything, so maybe that's why I'm having issues installing modules??

Anyone ever seen this error message before? Is there a certain process on uninstalling Magisk to start all over?

Thanks for the help!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
What was I thinking trying to flash all 8.0... thanks, I'll go ahead and download/flash.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Do it without the -w. It's no wipe

---------- Post added at 07:09 AM ---------- Previous post was at 07:08 AM ----------

Try reflashing magisk or maybe using a new one
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Probably because when you removed -w from the flash-all.bat it did not get saved properly. Regardless if the command is executed as "fastboot update image-taimen-opd**********.zip" with proper spacing and saved properly then it will most certainly flash everything without wiping userdata.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] js042507:
Yes, I have this problem as well. All the modules I've tried give me the same error. However, you can just install the zip in TWRP. You'll need to mount the system partition first though. It should work that way.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
When she took 8.1 the security patch showed 10/05/17.

Also, flash-all is not working. Ugh.. Still working on it, but pretty stuck at the moment.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Use this for no wipe to flash all. Just copy all img files from the factory image into the FILES folder. Should be about 21 imgs. Use the flash all option

If you want a wipe action just do a fastboot format userdata after it's done.

https://www.mediafire.com/download/jvtfiba80xk63dc
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
Thanks Bro, just got it as you were putting this together though. Commands working all last night and even this morning. Then all the sudden my go to USB port decides it does not want to work anymore.... It's like, are the keys in the ignition? Flashed and back up running.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Hahaha no problem
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Kenneth196:
Ah I didn't think about this. So install the TWRP beta and just flash away?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
So, the SU in this version of Magisk, is it PHH's SU or a modded SuperSU from Chainfire?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] eqbirvin:
afaik it is a new magisk su the author made. Works very very well. It is open source also
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ilal2ielli:
8.1 is currently only in Developer Preview. The most recent security patch is the November patch, which is designated for the the regular release channel.

You can't install the November patch on the Developer Preview, you'll have to wait for the next Developer Preview build to be released.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] metalcated:
Which the final release of 8.1 is targeted for early December. So I don't know that we'll see another DP release for 8.1.0
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
If it's this late in the month, I highly doubt we'll see another developer preview.

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] js042507:
Yes. The module zip should flash successfully via TWRP.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Kenneth196:
Thanks! So flash the stock boot image via adb, install twrp, then flash the patched Magisk img to root again?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
[MENTION=2955144]bryantjopplin[/MENTION]

Does your Magisk zip take place if the one that gets built from the Magisk app?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mrlamotte87:
You sir are a Scholar and a Gentlemen! Thanks for this!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Yes it automatically adds a newer app. It's the built in the zip
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
Yo, downloaded the Sauce! Nice! You think its wise to flash the zip from 8.0 Sep?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
The zip? What did you download lol?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
Yo I downloaded this one, sauce right?

---------- Post added at 12:31 AM ---------- Previous post was at 12:31 AM ----------

[MENTION=2955144]bryantjopplin[/MENTION]

---------- Post added at 12:33 AM ---------- Previous post was at 12:31 AM ----------

Ugh... Replying to myself above. I downloaded the MediaFire link you listed a couple pages back.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Ooh to use it to flash imgs? Mainly was built for 8.1 preview that had an issue flashing.

---------- Post added at 05:37 PM ---------- Previous post was at 05:34 PM ----------

Just use the stock image and remove the -w flag. Then it won't format userdata
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cedargreen:
Word, thanks. Great work by you and others. Really enjoyed the trials and tribulations on telegram trying to root XL 2. Then [MENTION=4470081]topjohnwu[/MENTION] came through like he found a penny on the ground... Still great work, learn something new from you guys everyday. Thanks.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Here is Magisk with all commits up to today... I called it 14.4.3 ;) I did nothing but compile it. Tested and fully functional :good:

Magisk 14.4.3

https://drive.google.com/open?id=1fxAueGcDzuHF0UxFtFmt5A55PC5FVW5x

View attachment 4337878
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Wasn't the last commit 4 days ago?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Yes, why you already build one?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Lol yeah a few days ago haha figured I missed something. That's why I asked
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
I started getting some random reboots today out of nowhere (3 today, so far). One time the phone shut down and wouldn't power on until I held the power button for 10 seconds.

I'm on the September patch with Magisk 14.4.2 installed and no other mods. Until now, I had no issues since flashing 14.4.1 over 6 days ago then switching to 14.4.2 2 days ago. Tomorrow I'm going to flash the November factory images and try 14.4.2 with a fresh OS install and see what happens.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Well, I just flashed this one in twrp and when I open magisk, it nolonger says I have an update lol. The last one did so that's something ☺
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Oh. Well, hell... I got a server sitting in the basement running... Not going to go through a Jenkins setup but maybe I'll automate the build process when new commits occurs (<=6 hours) automagisk build and upload to a central location. I got webservers available too.

---------- Post added at 01:35 AM ---------- Previous post was at 01:30 AM ----------

:) I was lazy and built it with debug enabled and no keystore... Glad that is the result you got! I really have not had problems because I just turned update notifications off. But the first thing I did after flashing was test with them on... And I got the same result, no update notification... Good!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
I thought I had dropped the ball. I started looking and didn't see anything new so I was confused. Haha yeah I uploaded the 14.4.1 (only for xl) and 14.4.2 (new dtbo changes).

---------- Post added at 06:36 PM ---------- Previous post was at 06:35 PM ----------

Haha I did not turn turn off keystore lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Man, if you are on September you either don't know what month it is or you live in some remote region with no computers/internet... I have seen this rubbish(British word for the day) a few times now. Please tell me which is it!? Crazy or Lost???
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
:laugh: What? T-Mobile is taking their sweet ass time pushing through the Nov update and I haven't sideloaded it yet because I wasn't sure if it would cause a bootloop with the patched boot.img installed.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Did the pixel ever have Sept I believe is what he is asking lol

---------- Post added at 06:52 PM ---------- Previous post was at 06:50 PM ----------

Nevermind it did lol duh

---------- Post added at 06:53 PM ---------- Previous post was at 06:52 PM ----------

It will just replace the boot img
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
Yes. There was no October patch (unless you enrolled in the 8.1 beta). Every Pixel 2 XL that was purchased in October and likely even through today shipped/ships with the September patch.

Did you guys think you were on a magical non-existent October patch prior to this November update? :eek:

https://developers.google.com/android/images
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Yeah I was confused on the months lol I replied to myself saying duh lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
:laugh: No worries. Thanks for the info on the boot image replacement. Since I already have the patched Sept boot.img, I imagine I could just sideload the Nov update, reflash the patched Sep. boot.img and call it a day.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Not necessarily. According to Dee's Troy they have to match what the system is. Iirc
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sn0warmy:
Alrighty. Looks like I'll have to do the sideload then have Magisk run the patch on the new boot.img again. No big deal, I've just been lazy.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Just for the tl:dr version from dees

Specifically, boot images are now tagged with an OS version and patch level. If you boot a boot image that is tagged with different OS or patch level, the device will still boot to the boot animation, but will be stuck in a bootloop. From what I can tell, the keymaster will refuse to run properly which prevents the device from being able to decrypt the DE phase of FBE decryption. This failure does not seem to be handled very well as you get stuck in a bootloop. The tagging of boot images also applies to images that are fastboot booted
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Man, the p2xl has 2 factory images since last release unless something has changed. You got googles and Google+Verizon crap. I am out of my zone on this and I know nothing about tmob varients but if indeed factory images that you linked is what your crazy a$$ is talking about then I'm still lost. Fastboot factory (Nov) images and remove -w from batch file and make sure it's saved (I'm assuming that you are a windows user....) Then welcome to November (although it will probably be later Dec early Jan before you figure out ) or just flash them maually now that there are 100 of them have;)

Either way, I'm a Verizon customer... Still never flashed a vz modem.. Google only. Way I roll lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Unless you count the beta 8.1
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
I don't ;)

Google "factory" beta + os custom git build = ugly Alpha (at best(.) Besides Google has all their people running the betas. Why would we test source-codeless? It's just a guess. There are enough first world problems to squash. Foresight is good, but not in this world. 9 code contributer's to Magisk...

Os=open source

Done...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] liljq:
can we flash the zip in TWRP now or do we still need to patch the boot.img?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Yes you should be able to
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Flashing it in TWRP worked for me. Fwiw...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] shag_on_e:
It took me a few tries to get kernel, Magisk, and permanent TWRP to work together with working touch in recovery and without losing TWRP. But the process that worked for me was starting from latest stock boot.img, boot into bootloader, fastboot boot TWRP beta 2, flash Magisk patched Snoke r11, flash permanent TWRP, then flash Magisk 14.4.3 . I may have done some steps that were unnecessary, but I'm still getting used to my first Pixel device coming from 6P. I can now boot into recovery any way with touch control, Snoke kernel is in place, root intact, and all well [emoji16].
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] liljq:
For some reason, it still shows as I'm not rooted after flashing it in TWRP.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
I'll presume you kept the Google radio.img as well instead of flashing the verizon radio.img?

Have you found no difference between the two, or you just prefer keeping everything Google, FTW :D
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
Did you flash 14.4.2 or 14.4.3? Either one of those should have worked.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Depends which version your flashing lol

---------- Post added at 09:08 PM ---------- Previous post was at 09:07 PM ----------

That's how it was supposed to be done. Lol

---------- Post added at 09:08 PM ---------- Previous post was at 09:08 PM ----------

Test it for us....
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
I certainly will.

Just wondering IF and why a Verizon user wouldn't use the Verizon radio.

Gimme a few days, and I'll report back on the VZW radio.

Thanks again for the help and suggestions.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jrbxx7:
Ive been running vzw on the Google img's and everything works. Wifi calling(even wifi preferred) hd calling ect. I use it cause i like to switch to fi sometimes. Please let us knoe if u find an advantage. ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Somebody must think it's got some value... If you take the OTA with a Verizon sim activated, it installs the Verizon version automatically.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
I could care less how much you test or these other opinions... Bottom line is that GMS/CDMA/WTF are all standard protocols... for the most part.. Thats how the P2 is a "world phones" (I am neglecting bands that do not affect me)... So all I see is Verizon fing stuff up like they normally do in all aspects.. So yeah, I stick to google fact images. Seems to work. I doubt it matters either way...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
And... if you are on factory google image with verizon sim it still horrifically installs **** to the /system that one would not like... Plus BS appware that I would believe/hopes goes against something... But not modems etc...

Bad Google!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] samteeee:
I don't know about Verizon Edition but I got my P2XL through my Carrier(Rogers Wireless) and it came with the Google's Oct. Firmware and immediately updated to November's OTA still with Google's Edition firmware and I had already installed the Rogers Sim card no bloatware and interestingly the Rogers Security Patch is still on October!

VoLTE and all Rogers features all working properly!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] metalcated:
Is this statement in theory or actual? I have the Google edition and not Verizon edition but I am on Verizon's network with a Verizon Sim and I do not have any unwanted apps. And quite honestly, this is off topic. If there is actual proof this is happening please by all means (and I'm not trying to be a smart ass or jerk here) open a new thread and I'll be more than happy to dig into this further. Let's all stay on topic in this thread. Thanks.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Your right it's getting off topic. But... My Verizon, Go90, VZ Messages, Allo, Duo, Android Pay, Docs, Keep, Play Movies, Play Music.... And a couple more. Now I said crapware not bloatware, and *most are uninstallable but still, some of the gapps install to system... like movie and music. On first startup it runs a install routine based off the carrier that you cannot stop or abort, it forces installation of 12 apps.

Now, back on topic. Sorry...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Schroeder09:
Which music and movie apps are you referring to exactly? I think this happened to me last night when I started my pixel too. I didn’t even have the SIM card in it though! It’s the google unlocked version.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Google Play Movies and Music... Obviously this is not bloatware but being they are installed to system without your permission and unable to be uninstalled is kind of crappy. Mine is Google unlocked play store version as well. First time I booted I thought I was tripping when I witnessed it. I didn't even understand what was happening really *confused*... But after a factory wipe and restart I can confirm it happens every first boot... Can confirm on a friend's p2xl from Google with Verizon sim as well. Total BS Google.

Anyway, it's real... not a theory.. Back on topic.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jrbxx7:
None of those vzw apps were forcefully installed with my vzw sim.....
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
As was previously suggested, let's take the VZW crapware / bloatware conversation elsewhere, maybe create it's own thread.

Has nothing to do with Magisk, and there's no point in continuing the off-topic conversation in a development thread.

Thanks :D
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
Are 14.4.2 and 14.4.3 the same?

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] madmuthertrucker:
How do i update Magisk? Can I just flash the newest version?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
[MENTION=2955144]bryantjopplin[/MENTION] [MENTION=3297454]thedude420[/MENTION]

Can you build this in? Or is it already built in?

https://plus.google.com/+apkmirror/posts/R4whXmr1k4d

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
Unless topjohnwu has done something outside of git then the one I posted is current. There have been no new commits. The version may be different... but its not.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
I did, I used twrp to flash 14.4.3 over 14.4.2. No issues
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Yes I'll build it with it in there. Only 5.4.0 installs iirc
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] TheDude:
lol, what am I missing? Build what in there? :confused:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] abuttino:
5.4.2

Apparently, just released now. apkmirror just posted it on g+

Sent from my Pixel 2 XL
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nathanchance:
I don't mean to sound rude or demanding but maybe it'd be a good idea to take the unofficial builds into their own thread. I think a lot of people are getting confused and assuming that these builds are official. Nothing wrong with distributing them as it's all GPL licensed but it'd be more respectful to do it elsewhere.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
I agree sir