yashsingh1/xdaforums huggingface dataset:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
K... I'm super sick of Binder - binder on 3.18 is crap and is interfering with my progress. Binder's understanding of linux scheduling leaves a lot to be desired on Marlin. I'm also plagued by a few issues that would be rectified, if I could get binder upgraded... But I don't think a Marlin branch exists for that... sooo;

I'm working on backporting aosp/kernel_common/android-4.4-o-release

(and I already have it working, just need to do some cleanups and move binder out of staging + clean up header locations, to get to match upstream).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Nov firmware is out. I'll be trying it out in a bit - I haven't seen any kernel patches for this month (although it looks like the common 3.18 tree has been upgraded to 3.18.79 - not sure, if that's the stock kernel yet (and don't really care).

I should have a new build up in the next couple of hours - It's a very substantial update.

- The EAS-4.9 backports

- Binder 4.4 backport (still in staging, but working wonderfully)

- A number of bug fixes, across the board; mdss, kgsl, ipa, touchscreen, etc...

- Various improvements to our audio stack. (backported from wahoo/muskie sources; Pixel2)

This all adds up to some nice performance enhancements and should yield battery savings, as well.

and it's going to make future upgrades and fixes to Binder MUCH easier for me. ;)

anyhoo, after the Nov image finishes downloading, I'll test it out, then post a test build. However is ready or wants to help me out; give it a whirl - give feedback, any issues, etc then I can move forward with ann official build.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
The only thing I noticed alt the last update was at boot time. Boot up speed excellent but losing all the startup apps etc made the phone unusable for about 60 seconds.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
losing startup apps? explain.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Test Build: https://github.com/nine7nine/Apps/raw/master/exNoShadez_eas_binder_test.zip

this is a couple of commits behind my local kernel - as I'm testing something (that will probably be in my next build) and I have a couple of commits marked on paper, as possibly being removed... so still finalizing...

I'm on Nov firmware now (but was using on Oct firmware), so it seems to work fine - just make sure that if you upgrade to nov firmware - don't flash my kernel, magisk, etc until you've let it boot fully once (it does a bunch of updating on first boot - I don't think it's a good idea to interfere with that....

and keep in mind this is a very substantial build / a ton of new code... so there might be a kink or two to iron out (I can't possibly test every use case, app, etc).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
Sorry my fat fingers.. Loading not losing.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
What apps do you start on boot?

i'm still sort of not following, in a sense. (for me anyway), It boots up nice and fast. Apex Launcher takes a second (but it does on stock kernel too). EXKM settings take a second (but they are set to a delay (the same would be true of L Speed - if I used it... AfWall, etc). No different than stock - That's an android userspace thing, may be impacted by the kernel - but less so than one might think...

What do you mean? like give examples...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
It's ok with the new version, with the last one after reboot with a few notifications coming in and all the stuff going on at startup the phone would freeze as though some process with a high priority was running.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Ok Cool. I never hit anything like that, but the new build _should_ be much better.

Part of the problem with the older builds is pulling in all of the latest kernel stuff, but Binder being very old... It presents a lot of problems that I was butting heads with, almost constantly. That's why I replaced it with Binder/4.4... Our new Binder should cope much better.

It could be that you did hit some weird locking bug or priority inversion, that I just didn't hit - due to us having our phones setup differently. There may be corner cases like that - and it's challenging, because I won't necessarily be able to reproduce issues like that on my end....

anyway, give this a good run and let me know how things go - as i would like to update the main link - just testing for a bit and waiting for some feedback from people using the test build... I've done some stress testing, run through a bunch of my apps and also benchmarking.... kept an eye on stats, etc.... It seems really good, so here's hoping I can get it up soon as the current available build (for people updating firmware).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] derekr44:
I can already tell the audio is much better.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Okay, So I've updated the main download link, I've had a few PMs with some feedback, I removed a couple of troublesome commits and built the kernel slightly different... there are still a few edges cases / semi-rough edges, but they mostly come down to down things that aren't exactly real world usage... and I'm working on fixing them anyway...

It seems pretty stable, I can't give too much feedback on battery life (improved or not) as the new binder code (and the fast that I have been stressing my phone, flashing, rebooting, etc - means it's very hard to tell... but so far so good, afaict.... I've got some more bug fixes in queue, as well I'm working on getting the sound related drivers updated... I have some patches for Binder to test (now that I can actually test them, needed the upgraded binder for android-4.4 (which is for EAS, btw).

I'll probably work on the above mentioned stuff and wait a day or two to push another build. but I think thus far, it's working reasonably good for a more experimental / Beta kernel.... Hopefuly, in the next week, once I get some kinks ironed out and figure out the input boosting stuff, I can mark a stable build.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
yup. With more improvements coming.... I've been pulling code from the pixel 2 kernel's codebase... There were some legit bug fixes, an obvious one was that certain audio apps wouldn't always end up with the proper settings (and sound glitchy). I knew of a few in the play store - I've since tested them and they work properly now.... I also pulled in some code that has to do with thread priorities for the LOW_LATENCY_PCM_MODE path => but it was completely unusable, until I merged in the new Binder ;) ... still working on improvements though. (that's where I personally find find some rough edges.... audio)

My problem is that I'm so use to tuning linux systems and if this was straight linux - I'd have been done already. But android is a weird little beast and I can only modify the kernel (and possibly a few settings for userspace), so it's harder for me to tune it how I want, if that makes sense? ....

Anyway, It'll get there. Day by day and I am just becoming familiar with Marlin's code base, getting hooked into all of the right repositories to pull from and figuring out what needs to be done....
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
....and I've moved Binder out of Staging Drivers = cherry-picking for Binder just got a whoooooole bunch easier! Phew!

Now I better check and see what I might need to update / pull in for msm related binder code (msm_ion and friends).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] mannunikhil:
Have you updated the kernel with the November security patch?

I wanted to try it after reading several good reviews but it did not apply via twrp. I followed, boot twrp > flash kernel > flash supersu > flash Suhide > reboot. After reboot got the stock kernel. :rolleyes: :confused:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
Read the op you can't use twrp only the bootable image.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] almightysiman:
Running the latest kernel,So far so good!:good:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] vaanus:
Seems like some apps still accidentally crash on new build (previous build make camera crash every time I shoot). Here is the crash log, hope it can help.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
I'm not sure what your problem is - but I suspect it has something to do with supersu.... IIRC, if supersu is already installed and you go to install it again, it restores the stock boot.img that it has backed up... maybe something like that is going on. idk....

What happens if you don't flash supersu? does it boot and can you verify by checking?

if it boots into my kernel - then it's a supersu thing....
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
hmmm.... what Camera app are you using? (stock? ... it works for me). Thanks for the log - that's most helpful. I will look.... What apps are crashing and can you make them crash in any reproducible way that I could test, by chance?

I Haven't had any crashing on my end (at least not in stable builds), but I do expect that there might be a chance of that kind of thing, especially after merging in the new binder code.

anyway, if you have anymore information - that would be great.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
EDIT: ya, we are good for november. one commit I had a couple of weeks ago, another isn't needed (not applicable).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] vaanus:
I am using stock camera (stock Oct patch). How to reproduce:

1. Take multiple pictures with HDR Auto on.

2. View pictures while they are still in HDR process.

3. Tap "Back" to get back to main camera, or "Home" to go back to home screen.

4. Sometimes the camera app will just crash, and picture will turn out to be a gray one.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
K. I tried your steps - I couldn't reproduce, but I'll try a bunch more times and I will also check a few other things / get to the bottom of it.... I'll post a build later on, when I get a chance for you to test ok?
[Google Pixel ROMs, Kernels, Recoveries, & Other De] vaanus:
Thanks! No problem, happy to test;)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] mannunikhil:
Yes, supersu was already installed before flashing the kernel. So this time, I re-flashed the nov patch, then kernel > supersu > suhide > reboot. Guess what kernel stayed this time.

I was unaware of this behavior from Supersu.

Thanks much for this, will get back on the kernel feedback.

Cheers mate! :highfive:
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
No problem. I was definitely aware of that issue (it's super annoying!). I used supersu for years, but I don't like the direction it has taken; Now I use Magisk... FOSS lives on Github and once you get used to the concept of the systemless modifications, it's pretty good.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
K. So I think I may have found the problem, But I won't have time to push a build for you to test until later on (busy day today).... i WILL get to it though, fur sure. Just be patient....

I really wish that I was able to trigger it here, annoying that I can't but nonetheless I think I do know hwat the culprit is. ttyl
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=4873652]vaanus[/MENTION]

download, these to test;

Try this one first;

https://github.com/nine7nine/Apps/raw/master/exNoShadez_eas_cam_fix_test.zip

it's where I'm at with selectively rolling back a few commits. Since I can't reproduce it. I definitely need your help! thanks ;)

then try these, if that one doesn't fix it.

https://github.com/nine7nine/Apps/raw/master/exNoShadez_eas_3.18.78_oct.zip

https://github.com/nine7nine/Apps/raw/master/exNoShadez_eas_3.18.79_nov.zip

I just want to narrow down the scope of where I need to revert some commits to test....

That said; I am rolling back some commits (in ranges, that although supposedly "do the right thing" / are more correct, it's possible that they've introduced a subtle bug that's causing the issue)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
HAHA!

[MENTION=4873652]vaanus[/MENTION] - because of your camera error - I found a fix to another subtle bug... (that was irritating the crap out of me, although it was a corner case)... Anyway, let me know what you've tested that build.... I will have more to test later when I can put more time into a few builds.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Ok, soooo....

I've had zero luck in getting Google Camera to crash (or any other apps), but I did revert some commits that I feel may be linked and have updated the link.... that said i CAN somewhat reproduce [MENTION=4873652]vaanus[/MENTION] problem.... I've found in my current build that if i take a ton of HDR pictures (very fast), maybe throw in some burst shot then go into the picture viewer, sometimes while the HDR processing is happening I am getting a blank/grey pictures, but once it completes the picture shows up (hmmmm.....).

There are possibly a few contributing issues here; my freshly merged Binder code - it could be that the buffer allocation isn't upto snuff (because 1 - i can't backport that code with out backporting a bunch of dmaengine related code. ugh), or some hiccup in synchronization or there is something else at work, possibly some racy code in the camera sources or something related... I'm working on it.

in the meantime, if people could test the latest builds and see if any apps are crashing and/or can send me logs related to said crashes - that would be great.... I need to get this ironed out.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
K. I've updated my kernel/dowlond link again. This time a handful of fixes to Binder, a fix for an audio regression (from reverting patches to try and figure out Google Camera)... There's also an audio fix....

I'm still working on the camera issue, but AFAICK -it's only Google Camera that is affected. But It IS working fine for me; as in; I can take pictures in HDR+, do Burst Shots, Panoroma, Photo Spheres, etc etc.... The only problem is when I snap like 30 pictures in a row; as HDR+ processing happens, it sometimes isn't rendered until it's complete (it never saves them as black or grey and it never crashes, at all.). It appears to be loosing the buffer for the image....

That said; it is very useable/functional, even if slightly annoying. ***and this has become a high priority issue for me to fix 100%. top of my list.

I've been reading through the logs; it complains about failing to aquire locks, an error queuing buffer to SurfaceTexture and some other noise... I'll get to the bottom of it, but I'd still like to know if the Camera app or any other app is crashing for anyone who mentioned it...? (on latest build)

EDIT: The first couple of people to respond (who can give me a yay or nay on XYZ crashing...or provide useful info regarding The Camera app) get a present from me; an app - I'll PM it to you).
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
I can test today. Is it up to date with Nov security patches? I don't mean compatible, but actually updated?

If it does I'll proceed with updating my phone to Nov and install the kernel and test whatever you want.

Just asking, which is the latest link? The one in op? or the links from a few posts ago? I'm assuming the one in OP because Github says it's the most recently updated.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] marioemp2k7:
He confirmed that there are no issues with the latest November security patch. I'm still on the 3rd of November build and it's all good. I haven't had time to upgrade and try the new Binder code, but I'm getting there, very soon hopefully.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
Right, but I thought it was just that it's just compatible with November since he said that he had a patch "weeks ago", and that it didn't actually contain the November patches in the code. :silly:

EDIT: I've updated to November with latest kernel from OP, testing for a while.

EDIT2: Full charge > unplug > used for 30 seconds > left screen off ever since. Battery is at 67% in one hour of non use, phone is running warmer than ever. Using ElementalX App default settings.

EDIT3: 9:14PM JST; I changed the default governer to sched, turned off phone and am currently charging it again while letting it cool down. I believe it could've been schedutil (had almost the same results using Kirisakura when using that governor) or Magisk being derpy somewhere. Will test again after it charges.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
It works great for me, it must be an app running in the background. I don't have any problems with the camera at all I tried really hard to crash everything, so stable.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
Yeah, something is still not right.

I guess I'll go back to Kirisakura for now :(

EDIT2: Now Kirisakura is having the same problem. Very strange, it was running perfectly with the same settings on October. I wonder if it's Substratum then... Magisk is set to Grant by default so if anything is pending root in the background it should just automatically run, I wonder what it is...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Yes, I already had 60% of them in my kernel, merged in the sometime last night. There is a fresh build up today (that smooths out a few rough edges in performance, also yeah; has all nov marlin patches).

OP download link is always the newest build, unless I post one that is a tester (the file will always have 'test' in the filename and will be posted in the thread - builds in the thread should be disregarded whenever I mention updating the main download in OP)...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Could you better explain what you are talking about? .... I'm a bit confused here...

battery life on my kernel is updating correctly, my only observation is that it's a bit dopey/sleepy after being in deep sleep - so sometimes it take a bit after the phone is a awake to give a good estimate on battery life (for example, right now it says I have about 14hrs, if i was to watch a bunch of hi def videos, after a few minutes that estimate would reflect my usage)...

should be fine man. No idea what you are going on about with root, substratum, magisk or any of that...
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Ya, it was fine before I merged in the Nov kernel patches and I have them all in now, so we are good...

just keep in mind that with the latest release is slightly finnicky with Google Camera on HDR+ - it shouldn't affect your ability to take pictures or anything - but it won't always show you a preview of the image that it is processing (if you take more than a handful or two of pictures at once - the preview will flicker grey, then black -> but the final HDR+ processed image will appear && be saved)....

This is the top priority regression that I'm working on and I have an idea of what is going wrong now, but it might take my a bit of time to fix up - as I have to familiarize myself with some parts of android and the kernel - that up until now; I've never had to dive into....

functionally, for me - Google Camera (using HDR+) is still very good and usable. It just loses some of the buffers for previewing HDR+ images while processing... (it's likely due to the new binder code, but I'm not reverting it - I'm moving forward with fixing it... That's why we are 'beta' not stable. lol)
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
Are you on Last night's or today's build?

Make sure you are on the latest build - but after some verification/testing - pm me
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
So as aforementioned, something somewhere isn't working right, hence my mentioning of extraneous applications in search of the cause. Because everything was running smoothly in October update.

I updated to November via system image / fastboot as I have been doing over the last year. Let it boot up first time, all fine and dandy. Reboot to bootloader, boot twrp, install latest kernel from op, and magisk. This was at almost near full charge.

Few minutes later I put it to charge, and when I went to grab it the phone was warm. I took one picture on FB Messenger, and then put the phone down. I grabbed it about an hour later and it was still warm and the battery had drained to 60%. Played a few games, and the battery was almost dead before the hour.

In short, today I've gone from full charge to 0 twice already with barely any usage, and probably one hour of gameplay... and the phone continues to be warm the entire time.

EDIT: Now my phone is off, it was at low battery so I will just charge it again and flash the new kernel in the morning. Letting it cool down as well, been hot all day.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] siheals:
It will be a rogue app running
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
[MENTION=5930088]グリッチ[/MENTION]

+1 to the above answer.

No one has described anything like you are describing and I've had a few PMs from people today who have been running last night's build...

I get all of about ZERO battery drain, while in deep sleep.... Yesterday, I ran my build from 6 or 8pm until this morning; Hours of music, videos and firefox, etc - didn't charge it up until this morning - look at batterystats; hours and hours until I would need to recharge...

I'm now running a build that's a few commits ahead of the posted build from today (just some binder fixes/changes) and same thing - ZERO drain, I'm at 87% - Battery in settings says 17hours left - which is close to what Accubattery says... It states;

screen on/off usage = 16+hrs

screen on usage = 4h 38min

sleep usage = 21hrs

Something is out of whack on your system - I'm doubting it has to do with my kernel, specifically.
[Google Pixel ROMs, Kernels, Recoveries, & Other De] :
I'm working on a number of binder commits, now that I'm (mostly) caught up with binder (and can merge in recent changes from upstream and the arm/patchwork list....

Marlin kernel is missing a function that android-4.4 binder's latest commits use, so I'm investigating adding it to our kernel. Interestingly, the msm-3.18 kernel DOES have this support - just a matter of tracking down the commits, i suppose....

I have added some code for binder that should help me work through the Google Camera issue too. I've copied down all of the errors/info that QCamera, mm-camera, libEGL, etc show me in logcat.... I have a lot of reading up to do, but I'm confident that given a bit of time / effort I should be able to fix this glitch for HDR+ processing. (which again, works fine - just the previews after 6 -10+ images being processed don't show up, until the render is complete).

an aside, if you are ever interested in seeing a cool EGL/gfx demo - go to the play store and checkout YEBIS Demo, it's a pretty cool little demo. (also handy for me to test, certain changes I make that possibly could affect FPS performance).

EDIT: and I just merged 3.18.80 incremental patch / LTS
[Google Pixel ROMs, Kernels, Recoveries, & Other De] グリッチ:
I flashed this morning's build and installed gsam, it said Google Play Services was eating all my battery, so I think I found the culprit.

I will charge the phone again and re-test :)