yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] heelsfan25:
I tried unlocking critical but it would not unlock. Not sure if I missed something but it was as simple as just adding _critical on the end I believe. I read on another site about a guy having the same problem. Is it too late to unlock critical or is that a one time option? Thanks for the response.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
You want to type.....

fastboot flashing unlock_critical

And you can try as many times as you want to, it will however, only unlock once. Standard bootloader unlock and critical unlock. You will know if it worked because it will wipe your phone again.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Yes, that's correct, only thing I might add is to make sure you have a bakup or be prepared to set up your phone from scratch!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wy1d:
I didn't see anyone reply so I am going to try this method as it's my favorite (ability to take OTAs)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Cowbell_Guy:
Awesome, thanks. Let us know how it goes goes!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wy1d:
It worked fine but it did the automatic dtbo patch which is resulting in the "There is an internal problem with your device" on every reboot. I found a thread explaining this happens with newer versions of Magisk Manager:

https://xdaforums.com/pixel-2-xl/how-to/tut-fix-dtbo-message-theres-internal-t3715620

Looks like it's possible to roll back to an older version of Magisk Manager to provide vent the error but the older version was giving me a no internet connection error. I'll stick with this for now since it's only cosmetic (I think) until there's an apk update to fix dtbo on Pixel 2 XL.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jexx11:
Thanks for testing this method, I haven't heard of anyone else updating successfully using Magisk and the OTA yet.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Sorry for likely noob question here, even though I've been rooting my android phones since the HTC Desire I'm having trouble here.

I've got my bootloader unlocked (did critical) and that's working fine but now I'm trying to root and having no luck. I followed the instructions and installed Magisk 5.4.1. It installs fine but when I do Install --> Install --> Patch boot image file it says Target Magisk version doesn't support boot image file patching. The file manager never pops up asking which image to load. I'm sure I'm missing something simple here but I'm not sure what.

I see mention that I need a boot image file from the factory images but I'm not sure which version I'm supposed to grab? I've got a Pixel 2 (not XL). And once I grab it am I just extracting the boot.img file from the zip and putting in Download, then pointing Magisk to it?

Thanks in advance guys, looking forward to getting up and running!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wy1d:
Try going to magisk manager main website and grabbing the latest version 5.4.3
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Yes, although usually easier to extract the boot.img file on your computer and then place it in your phone downloads folder.

---------- Post added at 04:18 PM ---------- Previous post was at 04:15 PM ----------

Go and use the unofficial dbto version of 14.5 to get rid of that error message.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wy1d:
Well I'm not sure how to do that with Magisk Manager. Looks like that version is for when you are using TWRP. I'm kind of trying to avoid going the full replacement recovery route so I can more easily take OTAs
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
No, you use Mm to patch then fastboot flash the patched boot-img.

Also, if you just fastbboot boot TWRP it does not stick and won't prevent you from taking ota.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
How do you know which version to grab? (for boot.img file)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] heelsfan25:
Thanks for the replies. I relocked the phone to attempt the critical unlock but it says already unlocked even after i locked and checked the lock. I don't know. Is it possible that the unlock is a one time good deal in that ever how it was unlocked to begin with is stuck or is it possible that the phone will not accept that. As of now it is unlocked again, but was wanting to do the critical unlock. Thanks again.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
You grab the boot from the extracted factory image file on your computer. There will only be one boot image file.

---------- Post added at 06:10 PM ---------- Previous post was at 06:07 PM ----------

When you relocked, did it wipe your data? If it did not, then you didn't relocked!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] heelsfan25:
When you relocked, did it wipe your data? If it did not, then you didn't relocked![/QUOTE]

It did not. I opened Dev options locked went back into fastboot and locked with fastboot flashing lock. It seemed to be successful because I tried it again and it said already locked... Sorry about the noon issues but this side of rooting is new to me as the OG Droid, bionic, and s4 were simple. Thanks for the patience and advice.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
It did not. I opened Dev options locked went back into fastboot and locked with fastboot flashing lock. It seemed to be successful because I tried it again and it said already locked... Sorry about the noon issues but this side of rooting is new to me as the OG Droid, bionic, and s4 were simple. Thanks for the patience and advice.

[/QUOTE]

That's what I had, plus the Nexus 6. Try, try again!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Well I was able to get the boot image patched using Magisk 5.4.3. Patched it, pulled off, did the fastboot to the patched boot image and my phone rebooted. It's been stuck on the G screen though for like 5 minutes now. I'm presuming that's not normal, or is it?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Did you fastboot flash boot patched_boot.img,
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Yeah seemed to work OK. (Screenshot below)

I guess the thing I'm confused on is how to know which factory image to grab from https://developers.google.com/android/images to extract the boot.img from. I'm presuming I must have grabbed the wrong one? I grabbed 8.0.0 (OPD1.170816.010, Sep 2017) since it was referenced in the original post on here.

If it matters my phone just shipped to me so I'm guessing it's running something newer than that?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Wilazn:
Odd. Worked fine for me.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Lol! That's not the Factory image that you're flashing! That's why you were bootlooping! You need the boot from 8.1 factory image that you downloaded!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Yeah that'll do it. I grabbed 8.1.0 which didn't work either. Finally found a winner with 8.0.0 (OPD1.170816.018, Nov 2017). Flashed boot.img from that and I'm back up. I'll patch that one and flash it and see what happens now.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Thanks - that did the trick.

---------- Post added at 09:22 PM ---------- Previous post was at 09:12 PM ----------

OK the saga continues. So, got the proper boot image on there, patched with Magisk 5.4.3, rebooted, flashed fastboot flash boot patched_boot.img, rebooted. Phone came up OK. When I open Magisk Manager though it immediately asks if I want to install Magisk-v14.0.zip.

What in the hell am I missing here?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Do you have magisk set to the beta channel under settings?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] an21281:
Need to go into settings, choose beta for update channel.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
OK I did that, grabbed 14.5, patched boot image, fastboot flashed, etc. Now I'm in the G spinning thing of death.

Do I need a different boot.img to use 14.5? I'm using 8.0.0 (OPD1.170816.018, Nov 2017)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Your on a standard P2 aren't you? Just checked that buuld# on the factory image page. I wonder if that has anything to do with it?? And your using the boot.img from that build as well correct.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Correct, standard P2 on Google Fi if that matters.

Not really sure what build number I'm supposed to be using but when I had it bricked earlier the boot.img from 8.0.0 (OPD1.170816.018, Nov 2017) was the only one that would unbrick so I guess I'm assuming that's what I'm running. If there some way to check?

I tried magisk 14.5 with the latest 8.1 image and that messed things up really good. I'm back to that 8.0 image above for now so my phone works.

Not sure what combination of magisk manager, magisk, and boot.img I need to root but I definitely haven't found it yet. Or I'm missing something obvious.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
You can go to settings/system/about phone and scroll to the bottom to see your buuld# You will definitely need the boot.img that corresponds to whatever buuld# your currently on.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Ahh and there we go. Running 8.0.0 OPD1.170816.025. So tomorrow I'll try the boot.img from that zip with magisk and see what I get.

Thanks for the guidance!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
No worries. Then, if that all works...might as well take the plunge into 8.1 so you can have some more big fun! :laugh::laugh::laugh:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
Hah oh yeah for sure! I'll wait until I have things running just right then I'll brick it with 8.1 :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
That the kinda spirit I like to see!! GO BIG, OR GO HOME!!! :good::good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paelcolp:
And we're rooted! Thanks Badger50, Alxoom33, and wy1d for the assist!

Just in case someone runs across this post later on... here's what I did to fix my issues (Pixel 2, not XL version):

Follow the instructions at https://www.xda-developers.com/how-to-unlock-bootloader-and-root-the-google-pixel-2-and-pixel-2-xl/

When you get to the "Root the Pixel 2 / Pixel 2 XL" part, go to Settings --> System --> About Phone --> scroll to the bottom and find your build number. Go to https://developers.google.com/android/images and grab the factory image that corresponds to your build number. Extract boot.img from that zip file and use that for the "Root the Pixel 2 / Pixel 2 XL" step.

Note that you might need a newer version of Magisk Manager (5.4.1 didn't work for me, I had to use 5.4.3). You also may have to grab a beta version of Magisk (Open Manager --> Settings --> Update Channel: Beta). In my case I had to use 14.5 (14.0 didn't work).

If you brick your phone with the G of death, panic first and then reboot into the bootloader by holding down power and volume down until it comes up. Once in there, use your adb console to flash your good boot.img that you extracted earlier from the zip for your build and reboot:

fastboot flash boot boot.img

fastboot reboot

This should unbrick (or did in my case at least) your phone so you can come back for more pain.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
VICTORY!! Well done my friend. I always admire aggressive persistence! It pays off in many aspects of life :good::good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] weaver11b:
So I used the magisk uninstaller to remove magisk so I could start fresh. I was able to install magisk 14.5 in TWRP, but when I try to install magisk manager 5.4.1 or 5.4.3 I get this: app not installed error. Going nuts trying to figure out why it won't install, when I had no issues on 8.0?? Any ideas??
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ragzz03:
I have a fresh Pixel 2xl with 8.1. I have not tried rooting or aything yet. Does this method work on 8.1 or would I be testing??
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] malybru:
It worked for me when I installed the app before the zip in TWRP

:)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wy1d:
Yes it worked for me using the hatched boot image from Magisk Manager 5.4.3 on 8.1
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ne0ns4l4m4nder:
I believe Its only for the pixel 2 xl
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] kachaffeous:
Worked for me on 8.0. Tethering enabled now on Grandfathered unlimited plan.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
In a terminal run fastfoot getvar current-slot

When you know your current slot lets say its a.

run fastboot flash boot_a patched_boot.img

---------- Post added at 08:04 PM ---------- Previous post was at 08:00 PM ----------

I would like to install busybox I have used Stericson busybox in the past. Where is the install location?

Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] joeyddr:
I'm on sprint and always had to edit the settings.db file.... i cannot find that file on oreo.

https://nexus5.gadgethacks.com/how-to/tether-your-nexus-5-without-your-carrier-knowing-0155546/
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] EstiR86:
Magisk comes with BusyBox go to modules and get the osmosis BusyBox zip and it will install. You can't install BusyBox from stericson and still not break saftey net.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jexx11:
Everything is working so far on my XL2, except my modules disappear from Magisk Manager on a reboot. The modules still work correctly, just when I open Magisk and click modules, it shows none installed.

I only have two modules installed, tethering enabler and YouTube background playback and they both disappear on a reboot but continue to work. Not sure why but at least they are working.

And for those wondering the tethering enabler module allows me to tether again on my Verizon grandfathered unlimited plan, so that makes me very happy!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Oakley707:
Very weird as to why you cannot see the patched_boot.img in the folder where it says it is. I had to use a file explorer and copy as you explained above. Thank you very much for that note!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
The pixel 2 and xl 2 are different, can't use the same method/version for both phones
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] agtsoul:
No problem. Anytime! :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Oakley707:
I have Sprint and only modified the build.prop. Simply add; "net.tethering.noprovisioning=true" (no quotes) to the bottom of build.prop. You can open the file with Root Explorer and make sure you hold or three dot menu to open with text editor, NOT viewer.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
Thank you I downloaded busybox from inside the Magisk Manager and all is functioning.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] w02justin:
When I ran that command, it said this:

getvar:current-slot FAILED (command write failed (No error))

finished. total time: -0.000s

why did it fail?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] twiz0r:
stupid question...will this work with today's update?

If so - should I go with the update or go to 8.1?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cb474:
The thread subject heading is: "Root Pixel 2 (XL)." I think the reason "XL" is in parantheses is to state that this is intended for both the Pixel 2 and Pixel 2 XL.

Further, in the OP the dev states that: "This build is ONLY tested on Pixel 2 XL Android 8.0 OPD1.170816.010. For Android 8.1 beta, Pixel 2 etc, it should work IN THEORY." In other words, the method here is intended for both Pixels, it's just that no one has tested and confirmed yet that it works on the regular Pixel 2.

For that matter, on the OG Pixel a lot of the development is for both versions, regular and XL, but tends to be found only in the XL section of XDA.

So my question remains, what is the difference between this special build of Magisk Manager, 5.4.1, given that it was reported several days ago that rooting with the regular Magisk Manager 5.4.0 works on the regular Pixel 2. And what does the dev mean when he states, " This Magisk Manager is specifically built for this release ONLY, both stable and beta channels points to the same custom URL"? Which "release"? "Stable and beta channels" of what?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] an21281:
Havent seen updated firmware(Nov) for Pixel 2 XL Taimen, only Walleye...? But I would think since it works on the beta 8.1 that it most likely will
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] mac796:
Awesome work I also donated. Appreciate all the hard work from everyone trying to get root
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] agtsoul:
Worked like a champ. Thanks
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Android Attack:
Thank you for all of the work you've done for the 2 XL!

I am on the September build right now and my phone just got a OTA notification for the November build right after I flashed the patched boot image. Would it be safe to take the OTA? Would I just have to go through the same process to root again?

Thank you!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wwfman98:
I was getting the same error using a USB-C to USB-C cable. I switched to a USB-C to USB-A and it worked fine.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] w02justin:
what if I don't have another type of cable? should I go out and buy one?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] malybru:
https://xdaforums.com/showpost.php?p=74772300&postcount=296

That link is a good method to follow.

Assuming you have unlocked bootloader and critical , this is not testing , but verified.

You only need these steps:

* put TWRP 3.1.1 beta 2 IMG in same folder as platform tool, for flashing in fastboot

* put TWRP 3.1.1 beta 2 ZIP in sdcard, for istalling in TWRP

* put (Magisk 14.5-1456) in sdcard for installing in TWRP

You will of course need the Magisk app on your phone

:)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] weaver11b:
Yeah i tried that route as well :( after i posted here. Did another uninstall via TWRP, booted then tried installing 5.4.1 and 5.4.3 again. I even tried via adb and it gave me this error:

[INSTALL_FAILED_UPDATE_INCOMPATIBLE: Package com.topjohnwu.magisk signatures do not match the previously installed version; ignoring!]

I looked thru my apps and there is no previous version of magisk installed. May have to end up reflashing the 8.1 image after work. bummer

-FIX for my issue-

https://xdaforums.com/showpost.php?p=74721167&postcount=4534
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] malybru:
I did start from scratch . ie , I did the flash all without the "-w".

Put the Magisk app on my phone , then did the fastboot and TWRP stuff.

:)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CPngN:
Oh... you're saying you put Magisk (apk I assume) on the phone first. Meanwhile I'm seeing some posts suggest (when upgrading to 8.1) to first UNinstall magisk (I'm not sure which of the 2 methods to use (restore stock of rcomplete uninstall). I don't know which is right, or if either way is "unsafe". Namely I don't want to lose my data, that took a while to get set up! I'm afraid a complete uninstall might try to switch to the backup, which I think I may have also overwritten. ie: A and B may both be patched 8.0 now.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] malybru:
Whenever I update , I remove root,substratum themes and pin/patterns before I start anything.

My reference to "put Magisk on first" meant , that once I've updated I put on the Magisk app, then go to install TWRP , and flashing the Magisk zip in recovery.

:)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Cowbell_Guy:
Will the next version of magisk get rid of those annoying error messages on 8.1?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
You can use the [MENTION=3297454]thedude420[/MENTION]'s unofficial magisk version and you will lose the error message on 8.1.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Cowbell_Guy:
Thanks. I guess I'd prefer to stick with the official magisk modules(had a bad experience with unofficial mods in the past although I know thedude420 does awesome work). As long as there is an update in the works that's planning on fixing I'll just hold out
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dtkent:
Can someone help me understand what I'm doing wrong? I've tried to read through most of this thread (extensive) but can't understand why my Magisk patched_boot won't take. Feels silly to have this basic a question after all that, but I can't figure out the issue:

Fresh 8.0, unlocked bootloader, fastbook unlock and unlock_critical

Took 8.1 OTA

Installed MagiskManager 5.4.3

Downloaded 8.1 image and extracted boot, pushed to MM, downloaded patched_boot

fastboot flash boot patched_boot in bootloader

Restart, check MagiskManager, no root and not installed.

What gives? I've repeated the process a few times now and it just won't take. Seems to have been easypeasy successful for others here. I wanted to avoid TWRP until it's fully supported.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] v12xke:
If you don't want to "install" TWRP, then just boot the TWRP image using fastboot. Just place the Magisk zip file on your phone and then use TWRP to flash it. It will root the phone and install the MM apk. After installing Magisk, reboot and TWRP will be gone and you will have root. Sometimes you just have to use a different method. If you understand what fastboot booting actually is, it does not write anything to the boot partition... there is literally no trace after you reboot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
It's fastboot flash boot patched_boot.img
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
If you want to bypass the whole patched_boot stuff, follow these steps which I used to get to 8.1, rooted, cust kernel, and TWRP.

If you don't want TWRP to stick on reboot, only perform the fastboot booting into TWRP.img to flash Masgisk 14.5 (1456)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CPngN:
I used that special magisk version and still get the yellow warning triangle at boot. I thought that was all that was needed to undo it but perhaps I need to do more? I flashed the full img not the OTA, but tried to use the temp TWRP method for Magisk/root. That failed so I used magisk (apk) to patch the 8.1 boot.img, adb pull, fastboot flashed patched image. Did not specifically do anything special for the DTBO but it was part of the 8.1 package of course.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
That's a different message, with the bootloader unlocked, we are stuck with that. The other message (about system corruption) is the one that we can make go away by using the unofficial magisk dtbo zip.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CPngN:
Oh! OK thank you, I didn't realize there were 2. I guess I'm as good as I can get right now then. 8.1 has been more stable - 8.0 was really starting to flip out on me some days. 3 warm-reboots in a row, etc.

Thanks to all involved!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
The message that is eliminated showed up on Magisk rooted 8.1 devices after the launcher is opened after boot up.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] viceversa:
Would also like to know about this. Anyone try it?