yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
Glad it worked out! That's.....interesting. Good to know!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bigv5150:
So you caused the issue by checking that in the first place. It says that it won't load any modules.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
Heh...yea...it seems so....I wish he had told me that before my big write-ups...

...Makes me wonder why he didn't do that in the first place and/or why it didn't occur to him...but at least I get a better-than-vague idea what that "core" in the settings is used for (at least partially)...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cognitivedissonance:
Hi all, I apologize in advance for this.

It seems like there's a good chance that installing TWRP on my Pixel 2 XL will cause SafetyNet checks to fail, and eventually my banks will all probably disable their apps (not sure which of them use the SafetyNet check currently,) so I should probably try to avoid that. I'm concerned that if I don't install TWRP I won't be able to make Nandroid backups, flash files on the fly, or wipe cache / dalvik when necessary (among other features I've used for years.) Those of you installing TWRP, do you just not use apps that have a SafetyNet check? Those of you that don't use TWRP, do you not do backups and just do all modding from a computer with adb?

I'm just trying to figure out what I'm going to do before I begin using my Pixel 2 XL -- I'd rather not get things all setup just to find out I've made the wrong decision and need to start over.

EDIT: While I'm peppering in the questions, I guess I may as well ask if there's a general consensus on the 'best' kernel setup for those who are going to stay on the stock ROM. I recall with the Nexus 6P pretty much everyone agreed that the Elemental EX kernel + EX Kernel Manager app + DarkSpiceR governor was pretty much the champ.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pkgnex:
Just unlocking your bootloader trips safety net. You don't even have to get as far as installing twrp!

... But having a custom kernel and Magisk can hide your unlocked bootloader and root so you can still use whatever apps you want without tripping safetynet.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cognitivedissonance:
Huh, guess I've got some more reading to do. Is there a specific custom kernel I need to be able to hide the unlocked bootloader and root? Is there a way to hide TWRP too?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pkgnex:
Yep. Read away!

Magisk is all you need to hide bootloader unlock / root / twrp. The custom kernel is really just to get twrp to continue working after installation... Otherwise, it often doesn't respond to touch input... which is kind of problematic!

I recommend Flash kernel as a good start... It's really close to stock, just updated more frequently for security.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
[MENTION=4433558]cognitivedissonance[/MENTION] ... This...

Exactly as pkgnex has said. Actually, in older versions of Magisk (I think v14), even though I would pass its SafetyNet check, I was unable to use my Google (then Android) Pay because of it's check. I got tired of not being able to get touch working on TWRP, so I (reluctantly, for my own personal reasons) installed a custom kernal -- Flash kernel -- simply to get TWRP working. It was a nice touch that it helps with SafetyNet checks because even though I am rooted and have a custom recovery, I am currently able to use Google Pay on my phone (Wells Fargo debit, USBank credit, Citibank debit)!

So, just to share my experience as well as maybe secure some confidence in it... even though it's not what I specifically intended, it was nothing but a positive move/experience that benefited further than what I initially wished...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pkgnex:
Very well said, and a great personal anecdote!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] cognitivedissonance:
[MENTION=4793042]pkgnex[/MENTION] [MENTION=4618389]simplepinoi177[/MENTION]

You guys are the best, thanks for helping me figure this out. Couple final questions before I dive in here - I've seen dm-verity mentioned a number of times in various Pixel 2 XL threads, and it isn't something I'm familiar with. I have a feeling it ties in with the A & B slot stuff as does this "dtbo" thing. Of these three new complications, the A & B slot stuff sounds the most confusing and potentially damaging (but maybe that's been worked out now?)

How much do I need to know about the slots, the dm-verity stuff, and dtbo before beginning to flash my phone?

Additionally, now that apparently TWRP development has stabilized a bit for the Pixel 2 XL, are there really any reasons not to install it? It obviously is very useful for flashing stuff on the go when a computer isn't nearby.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] clothednblack:
I wouldn't worry about the dm-verity as I believe custom kernels adapt to it and make the appropriate changes needed, and if you choose to use the stock kernel and stock rom, the most you would see is a pop-up during the boot up, nothing to worry about at all though. As for A and B slots, it's really not as confusing as it appears, once you get to flashing, the most you would need to deal with the slots is to update your device with the monthly security releases, I usually just fastboot it to one slot, but now I do it to both, it's an easy process. Fastboot can get you out of pretty much any problems you end up with, most of the time without losing anything on your sdcard area, but if all else fails, a full wipe can be done to get you back on track. Twrp.... I always leave it on my phone as trying to keep up with Nathan and his constant kernel updates without it... Well, it would be impossible lol. Flashing on the go is what really keeps my excited about having a phone with these capabilities. Just my 2 cents.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pkgnex:
Yeah, you don't need to worry about any of those things - at least not anymore. TWRP detects the slot in current use and flashes to that slot (I never flash to both slots, but I know some people do). DTBO worst case gives an annoying pop-up when you boot, and twrp, magisk, and all the kernels I've tried work fine with dm-verity.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] beezar:
I know very little about dm-verity, slots A/B, dtbo, etc. Been flashing left and right, no issues whatsoever.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
16.4 installed. All is good.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pa.pn2:
Anyone uses xposed with latest magisk and have problems?

The xposed installer apps says framework isn't installed...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Pkt_Lnt:
From the Magisk Beta thread.

https://xdaforums.com/showpost.php?p=76372958&postcount=5632
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pa.pn2:
Ah ok.thx for the info.i thought also its the xposed app cause its not anymore in my superuser list in magisk
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jbarcus81:
I keep losing root.. Magisk manager says to install Magisk.. I'm Stock 8.1 rooted. Very strange. Just since updating to Magisk 16.4
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ZeroSkylineX:
Which is better for the P2XL? The beta or the official?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Been on the beta for many months. As far as I know we need it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
+1

beta has functioned great here
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] def-g:
Official will be verified Stable. Beta may have bugs. Try em both. Back up in TWRP.

G
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Been on beta since I first rooted this phone.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
I don't think the official has been updated with stuff specific to this device, but not sure what that might be...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
Beta always worked for my device. Also, no issues with latest v16.4 Direct install.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ZeroSkylineX:
Thanks guys. Ended up sticking with Beta just to be on the safe side.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] nihalvm:
Having some issues after updating to 16.4

magisk itself installed correctly, and superuser is also working, but not able to load any modules.

I get installation failed error as if magisk is not installed?

Logs attached. Can someone please let me know what the issue is here?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
someone had a similar issue earlier and it ended up having something to do with the SELinux Permissive and setting it or something...

Apologies for being vague, but hopefully it might point you in the right direction...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Jiggs82:
So im on android p dp2 , does root work for it? Which magisk zip should i flash? TIA
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Here ya go brother Jiggs! ??

https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589/post76460015
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paddybecks87:
Fellas, I've been experiencing a strange issue...I'm on the Android P Beta, which runs perfectly smooth. Additionally, it's rooted with Magisk 16.4. There's a problem though: as soon as I open Gmail, it immediately force closes. Has anybody experienced the same? Any ideas how to resolve this (I've already activated core mode only in Magisk, which does not really help)? Any help is greatly appreciated!

Greetings
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
I can't patch the boot.img from the latest May 2018 update. Any ideas why? I select the boot.img and MagiskManager keeps telling me I need a "Stock boot image dump in .img or .img.tar format". Any ideas?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
No, Gmail works fine for me on P2. Sorry.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paddybecks87:
Thanks for your reply! Are you rooted? If so, I'll probably give it one more shot, maybe something went wrong.

Strangely though, my Essential PH1, which is also rooted with Magisk 16.4 and running the P Beta, shows the same behavior. Gmail force closes. Well, we'll see!

Thanks again!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ram4ufriends:
Gmail works for me as well.. Android P, Flash Kernel, Magisk 16.4... did you Flash custom Kernel?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Yes, Pixel 2 XL rooted with Magisk 16.4 EX kernel, Android P DP2.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] DIXZ06:
Gmail working fine here. Android P, Stock Kernel, Magisk 16..4.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chopt51:
I had the same issue, but it went to assistant and Google app. I think it was something to do with webview in developer settings. Had to reflash via abd.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
You could try booting into TWRP (temporary if you don't want it as your recovery) and install Magisk that way... (you would need to download the Magisk .zip installation file)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Paddybecks87:
Thank you so much for all the replies, so it's something wrong on my end. I'll reflash and and see if that resolves the issue.

Greetings
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
Unfortunately that doesn't seem to work either. After booting twrp:

fastboot boot twrp-3.2.1-2-walleye.img
creating boot image...
creating boot image - 10240 bytes
downloading 'boot.img'...
OKAY [ 0.010s]
booting...
OKAY [ 0.405s]
finished. total time: 0.415s

I only end up with a black screen. I have left the phone sitting there for a few minutes but that didn't change a thing. Tried both 3.2.1-1 and 3.2.1-2

I also re-uploaded the boot.img from the factory image and tried to patch it, but MagiskManager still won't even touch it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] azpatterson3:
Are you using walleye on taimen?

There's your problem
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
am not
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] azpatterson3:
The code you posted says it is..
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
Well, the Phone doesn't
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] azpatterson3:
Just noticed the the code you posted says you tried to boot the temporary walleye twrp image.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Just to be clear you have a walleye phone, but you are asking for help on a Taimen board?? Nothing wrong with that but people do need to know what they are trying to help you with...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
I have a Pixel 2 "walleye". I thought this was the thread for Magisk on Pixel 2 (XL), not Magisk on Pixel 2 XL?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
This is Taimen, not Walleye XDA section...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
...if you have a Pixel 2 XL (which, let's assume you do), you need to use the image "taimen". "walleye" is for the smaller Pixel 2 (non-XL). It's most likely the easiest and direct explanation why things aren't working for you. Just for kicks, try downloading and using the "taimen" .img and .zip (for installation) and see how that works out for ya...Everything else seems to be correct (syntax, platform-tools, what open directory you are using, etc.)

Hope this helps...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ZeroSkylineX:
You gotta get your eyes checked bro.

https://xdaforums.com/pixel-2/development/twrp-alpha-pixel-2-t3698147
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
It also is the "[UPDATED][2017.11.6][Magisk] Root Pixel 2 (XL)", not the "[UPDATED][2017.11.6][Magisk] Root Pixel 2 XL" section.

Anyhow, [MENTION=482227]galaxys[/MENTION], I am sure you can point me to the Magisk on Pixel 2 (walleye) thread. Thank you!

[MENTION=4470081]topjohnwu[/MENTION] Could you please change the title and description of this thread to reflect that this is absolutely for the Pixel 2 XL only and has nothing to do with the Pixel 2 (walleye, without XL) at all? I suggest you remove the parenthesises around "XL" and also add "Taimen" to the title and description.

---------- Post added at 10:14 AM ---------- Previous post was at 10:11 AM ----------

I don't think so, "bro".

What's with that? :confused:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
So.....it looks like the "XL" is optional because of the parenthesis?:confused: And, in any case, this is a Pixel 2 XL forum -- a taimen forum in other words -- so those flittering about these parts wouldn't necessarily get confused that all the threads within are "taimen" specific, exclusive, and related...So I wonder if a title change is really all that necessary for most other users...

[MENTION=5428675]ZeroSkylineX[/MENTION] is trying to help you, "bro," in directing you where the thread for TWRP for walleye is...

You could try to show a little appreciation and thanks as it was you who made the mistake of going to a taimen thread when you're on walleye, and it was you who actually requested for help, and it was you who specifically asked to be pointed to the TWRP thread for your walleye...

Just sayin...something to think about......
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
Yes the parenthesis suggest that, as well as the missing "Taimen" in the topic title, the wording in the first post and not least the fact that there doesn't seem to be a official "Magisk" thread in the walleye subforum.

I wasn't asking for TWRP, I came here to resolve issues with Magisk on a Pixel 2. As there is no thread for Magisk on walleye and this thread implies that it could also deal with Pixel 2 (withouth the XL part as it is set in parenthesis) I just came here, looking for help with Magisk, nothing else.

Sorry that I do not appreciate snarky comments about my eyesight more, especially when I pointed out the parenthesis issue explicitly before. Once again: I didn't come here to help with TWRP. I just answered to [MENTION=4618389]simplepinoi177[/MENTION] that his proposed workaround didn't work either. But I guess, as you seem to be so sure about it, you can quote the part where I have been "specifically" (as you put it) asking about TWRP on Walleye.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
You're right. My bad; I've been jumping between the TWRP and Magisk threads and I got mixed up. I was wrong about you "specifically asking about TWRP" and other TWRP related material. My apologies.

The issue about walleye and taimen actually is rooted to when you attempted to boot into a TWRP walleye image but was posting in a taimen forum -- hence things got focused on TWRP and walleye vs. taimen. If you were still attempting to install Magisk through its .zip installation file, you need to have perfected TWRP, which is why we were working on that for you and even pointed you towards walleye's TWRP main thread.

Also, if I am to understand correctly, if a thread titled "[Magisk] Root Pixel 2 (XL)" was in the Pixel 2/walleye forum, you would have thought that subject was in the correct forum for walleye as the "XL" would only be an appendage? And that, if this misunderstanding was reversed, it would need to be labeled "[Magisk] Root Pixel 2 (XL) Walleye" inside a walleye forum to be correct...?

In any case, my experience has been that installing Magisk in TWRP is seamless and provides no problem as it inherently patches the correct boot.img and dtbo.img at whatever Slot you may be in -- versus using the app where you have to copy or point to the boot.img and patching gets tricky. As such, and now that it's been confirmed that you are, in fact, on walleye, and it shouldn't be because the wrong image is being invoked, the best advice to give is to confirm that you are using the latest most up-to-date platform-tools, using another USB cable (USB-C to USB-A seems most compatible and bugless), try another USB port, and make sure (for whatever random reason) your .img file you downloaded isn't incomplete somehow (not implying you did anything wrong and/or you wouldn't be able to recognize if downloading didn't go right). Other than that, it's hard to conceive a reason why you can't boot into TWRP....

In the end, good luck to you....
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] azpatterson3:
[MENTION=4618389]simplepinoi177[/MENTION] Thanks for taking the high road. The lesson here is that punctuation means everything but so does location. Hope he figures it out.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
Please refrain from asking/kindly demanding that the dev change the title of their thread because you are the only person, out of thousands who have used this thread properly, who missed that this thread is:

1) in the Pixel 2 XL section

2) the first line in the OP states "Root for Pixel 2 XL has been achieved!"

3) the first warning in the OP states "This build is ONLY tested on Pixel 2 XL Android 8.0 OPD1.170816.010............"

4) the OP also states

"Special Thanks

nathanchance for his Pixel 2 XL and speedy tests

Dees_Troy for TWRP on Pixel 2 XL - thanks to TWRP's root shell, the debugging process is 1000 times faster"

I suggest you try searching first next time, as from the Google Pixel 2 section I searched "Google Pixel 2 TWRP" and got THIS. The first link found was TWRP 3.2.1-2 for Pixel 2
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] techlogik:
Sorry, wrong thread.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Osbor:
Alright, i give up, i'm stumped

trying to use magisk manager (16.0) to patch a factory boot image, doing all this to get that magisk tether module to stick it to verizon.

i put the image onto the phone using adb push, i go into magisk and hit install, hit install, select patch boot image file, then select the "bootloader-taimen-tmz12bb.img" file

it starts doing its thing, extracting files...

then boom:

Why does it think i'm using something Sony?

i'm using taimen-opm2.171019.029.b1 as the image

the phone itself is on 8.1.0 at this moment
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Pkt_Lnt:
bootloader-taimen-tmz12bb.img =/= boot.img

You are trying to patch the

bootloader

image, that. will. not. work.

The boot img will be named boot(something something).img or just boot.img
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
This is why I suggest booting (at least temporarily) into TWRP and installing Magisk (via .zip installation file) that way versus any other way. Doing so discounts so many headaches with the finding of the boot image and selecting it and such...

Doing it this way [MENTION=2957137]Osbor[/MENTION] might make it simpler and easier and more straightforward for you so you don't have to do all that extraneous stuff...

If you're interested, let me/us know and I'll write out a step-by-step guide and/or direct you to one of the many the awesome veteran experts have made in this forum...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
Thank you and no problem. At least there still are people here who are able to read and understand! ;)

Yes, absolutely correct. As Taimen and Walleye are "sister" devices, to me it was l logical that there wouldn't be two different threads about the "same" topic (provided that there is no Magisk thread in the Walleye section).
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Osbor:
at first i was like "wait what boot.img?"

but it's one zip file down, the zip within the zip

edit: there we go, patched, pushed and flashed and all is well

Safety check shows ctsProfile and basic integrity are green so maybe i can get the security features back, hmm

doubledit: opened android pay and it didn't bark about the boot loader being unlocked so i can only assume magisk took care of that. hooray
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sbreit:
In return I suggest you to read first before taking the same line as "everyone" else. My question NEVER was about TWRP, but we already covered that:

So maybe in terms of reading and understanding maybe we both have some catching up to do, right? Right. :cool:

Still, I'd like to hear from [MENTION=4470081]topjohnwu[/MENTION] about why the XL is in parenthesis and why he would explicitly mention the Pixel 2 TWICE (without XL) in his OP.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
Fair enough. After bouncing back and forth between TWRP and Magisk, I got turned around. My fault. I'll read more thoroughly next time.

Still doesn't explain why you disregarded or missed all the indicators that you were NOT in a Pixel 2 section or thread.

The Pixel 2 is only mentioned in the OP in the context of "should work in THEORY" and he doesn't own either device.

I'm not sure about you, but I'm not flashing ANYTHING to my device that says "should work in theory" or "ONLY tested on [not my device] ".

The dev doesn't owe anyone an explanation. It is fully expected that a user who is rooting their device is aware of which device section they are in, and that they are responsible for ensuring whatever they flash to their device is actually for their device.

Any further discussion regarding title name / punctuation needs to be taken to PM, as this is NOT regarding the development of Magisk, and has boiled down to you wanting an explanation / justification from the dev.

If you desire to continue pursuing this; please do it via PM.

Thanks.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] wtherrell:
In the OP I cannot find how to download the Magisk Manager file and the image file. I plan on using TWRP to install but the links? If that's what they are don't work.