yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
Haha don't feel too bad [MENTION=4670411]Az Biker[/MENTION], I did the exact same thing -- "...happens to the best of us" (as shown in the topmost quote I put in.)

Still, I find it hard to believe and understand (*not that I'm looking for an explanation -- @->sbreit) that, just because they're "sister devices", if reversed it would totally be acceptable to have "XL" in parenthesis in a walleye forum...?! Also, if anyone has any experience doing any small bit or reading and basic research, it's obvious that this whole website/forum (XDA Forums) is set up that there not be just

one

discussion thread located in just

one

model section that would also cover multiple other devices -- many times you see similar titled threads across many various model sections (because it may use similar programs, apps, and methods) but as to keep it within that model specific (the Galaxy S5 had Verizon, AT&T, Sprint etc. variants with identically named root threads but the rooting method was completely different as Verizon's method of locking bootloader was different to AT&Ts or Sprints...). In the end, it should be pretty clear jumping between model threads and

assuming

things are exactly & applicably the same and/or the one app/thread will cover it to all devices (unless expressed complicity) is just plain bad (*I doubt this is the first instance this has happened); and in doing so will lead to "...you're gonna have a bad day" (South Park reference :silly:)

Also, I find it amusing that he asks the OP that "question" here as a post instead of merely PMing him...

In any case, I'm not looking for any kind of response towards all this. I just wanted to drop a line to reassure you, Az Biker (*not that any was asked, needed, or required), because the same happened to me. Also (which I also wanted to include as to make this post relevant & on-topic), I wanted to put this here that, after a search, I found THIS. It may not be quite a centralized and main of a thread, but it seems to get the job done and is relevant & appropriate to what he (sbreit) was looking for/-in search of-/-specifically asked for- (quoted above).

Again, I wish to make it clear, that I am

NOT

looking for any kind of response towards this/my post.

Hope this (the link to Pixel 2 Magisk associated thread) helps (also to mean as reassurance)...

**~big exhale~**

"Now, back to the regular scheduled broadcast..."
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] srqrob:
Quick question on taimen bootloader unlocking. Do I need to do both "unlock" and "critical_unlock" or does the critical also do the standard unlock? Not clear to me.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
Both are separate functions, and honestly if you plan on doing anything custom with your device, might as well perform both functions now. unlock_critical wipes the device which you might as well do when you run unlock.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
NO

it does

NOT

"...also do the standard unlock"! I don't mean to be pushy, but you don't know

how many people

have run into so many bad and unfortunate issues because of this assumption...

Do

BOTH

commands. Also good to note that by running the "critical_unlock" command, it

WILL

wipe (including your internal storage; also called /internalsd also called /sdcard)... just a side-effect and consequence of the process unfortunately :-T ...

which is why so many people have bad experiences (not just in getting their phone wiped, but other errors and issues as well) by not doing so and/or critical-relocking
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
I guess this answer wasn't intense enough... Lol
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Phelicks:
What Magisk modules not drive DP2 to the bootloop?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
The ones most recently updated.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Sticky Fin:
Magisk Manager version 5.7.0 force close on Android P DP2. Does anyone encounter this too?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] ram4ufriends:
Yes...it happens multiple times
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
No, not at all. Been running P DP2 with Magisk since it was available for download.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Sticky Fin:
At first it was working perfectly. I even flash the Google Sans module inside the Magisk Manager. But now, it forces close every time I open it. The root work tho.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Maybe your apk is corrupt. I had that issue a while back on DP1. All I did is deleted and reinstalled the apk. You can flash Magisk 16.4.zip in TWRP if needed (if you lose root).
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Radixtrator:
Hey everybody,

Im running the P Preview on my Pixel 2XL.

Every few hours or so I lose Magisk (16.4) until I reboot and everything is fine again. I have no modules installed. Any ideas?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] samklee:
I actually have this issue on May oreo. Doesn't happen that frequently, maybe once or twice a day. Tried various kernels and about to wipe cache now.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
how are you guys installing Magisk? through the app, TWRP, patching the boot.img?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
That seems to be an issue with the preview. And you can't pass safety net can you?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] imaverik:
This is an issue on May security update for 8.1.0... not jsut DP1 & 2.

I went back to April update from factory image and the issue went away.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Radixtrator:
I actually pass safety net as long as Magisk works.

I only realize it's not working anymore as soon as Fire emblem Heroes stops working.

But ok if it's a common problem then I won't worry as much about it
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Hmm, me and another can't pass safety net checks. That's super weird
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
No problem with safety net. Pixel 2 XL running O DP2.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
If you guys don't mind me asking, how are you guys installing Magisk? Through the app (patching the boot image), TWRP, flashing patched image, etc.?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Always twrp
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
interesting....

I'm asking because I've found that many users run into issues when they try to manually patch the boot image and/or flash it manually....

but I've always installed it through TWRP with never an issue. Just making sure, are you guys using the beta 16.4 Magisk and/or the latest TWRP (3.2.1-2)?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Usually. I compile my own. So it's a little newer
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] CyberpodS2:
Any commits that pertain to us in the newer builds?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bryantjopplin:
Not really just little things here and there
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Mackcbr954:
I have just rooted my pixel 2 xl and am wondering if there's a way that I can make my phone not update to any new software. I see it checks everyday for new software and when/if found, does it allow me to not install? Or is there an app or something I can do to make it not install? Thanks.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
You can turn off automatic updates under settings/developer options. And, long press the notification you get and turn it off. Either way, the update will fail to install anyway since your rooted :good:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Mackcbr954:
Thanks, I couldn't find that in developer options under settings. Any way you could screen shot that for me so I know what it looks like? Thanks again.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Namolas:
Screenshot.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
I think [MENTION=5544811]Mackcbr954[/MENTION] might have skipped the step where you tap "Build Number" in the "About Phone" section in the "System" section in Settings for it to show up "under settings" and Namolas may have skipped suggesting this factoid as well...

Hope this helps...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Mackcbr954:
In truth, I just missed it. My phone was rooted, so I had obviously already unlocked developer options. Thanks for the lookout though.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] samklee:
I noticed this issue happening less with nitrogen and aquarios April. I'm on may DU and it's been running perfectly the last several days
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] basily:
Just curious about a few things... I'm getting my phone in a couple of days, and just want to make sure it's an easy road to root:

Is there some benefit to using the beta Magisk rather than stable - or is it actually required?

In the OP it says "TWRP cannot decrypt /data yet" I'm guessing this no longer applies?

I normally like to be on the latest update, so I plan to wait till the June update drops and then root - or are people having trouble getting root to stick with later updates?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Az Biker:
If you have the Magisk Manager CHANNEL set to BETA, you can update directly from the app (no flashing, etc) and I've been using the beta for a while with no issues.

Depends on your device environment. I was still under the impression TWRP still can't decrypt, but then, I don't really care about this feature so I've not paid close attention to it :p

I'm still on May running DU, but haven't had any issues with root not sticking when I was running factory image.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Reechings:
So I flashed beta magisk v16.4 in twrp and now my phone just keeps rebooting to twrp? Was I supposed to use magisk manager to make the patched boot image instead?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] sillyshyme:
Is this for Verizon’s as well?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] joetheshmo:
If you can unlock the bootloader, sure
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
Running taimen-ppp3. all working great.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
Well I was running magisk 16.4 for the last 2 months on Stock and all the apps were rooted fine. Then all of a sudden recently it would not root any of my apps. I tried every flashing scenario, and then finally I tried flashing Stable Magisk 16.0 and everything is rooted and working!

Something Goofy with Beta 16.4 :eek:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
I'm willing to bet those issues have more to do with how you are "installing/applying" Magisk 16.4 than anything. Might I ask how you are installing or "flashing" 16.4? If I'm correct, the method I employ might get you to have 16.4 running successfully if you were still willing and interested......
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Then lay some wisdom on an ol dog my friend. I suspect that Galaxys installs 16.4 much the same as most of us, via twrp. As for me, I haven't had any issues with 16.4. Typically, I flash it with twrp, then reboot to twrp, and flash it again. However, if you have some special Zen technique, I'd be most interested in hearing about it :good::cool:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jbarcus81:
Did you do anything specific? Just like a post above yours, I flashed, and was just booting back to TWRP.. never into the system.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] tlbland0426:
I had issues with Magisk installing after dirty flashing DP3 and it had to do with some of the modules I had installed prior (I was on O and had Xposed and Dolby Magisk modules installed). I ran the Magisk Recovery through TWRP and deleted all the modules that were still there, rebooted and profit. Not sure if it's the same issue you are having though but figured I would mention it.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jbarcus81:
Very strange.. I did a clean flash, wiped, etc. Flashed Magisk and just boot to TWRP.. Went back to the June release. Very odd!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
Try to see what your active slot is.

fastboot getvar current-slot

Slots can be confusing as times.

When you flash all back to stock, your active slot should be A,

If you sideload an ota.zip your active slot will change to active B -

If coming from stock and flashing a rom, in the same situation your active slot will be B

The next time you update an ota.zip or update your flashed ROM you will switch from B active slot to A and so on.

From your active slot try fastboot flash boot_a or b boot.img

This should get you back to stock recovery and boot up to see if you have any issues.

For me when I install TWRP from TWRP I reboot back into recovery, to verify it works and you will see what slot you are on.

From TWRP I install Elx or Flash kernel then Magisk
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] jbarcus81:
Honestly, that's more or less what I've been doing since getting the Pixel 2 XL.. Just for some reason after installing the beta, booting up fine, installing TWRP fine, ran fine, SLOT A was active.. and then sideloaded Magisk, it wouldn't let me leave from TWRP.. I'll try again this evening, maybe I had a strange transfer.. I've learned over the years of doing this you honestly never know WTH is going to happen :fingers-crossed:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Try deleting the Modules. They are incomparable with DP3 .
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
"Incomparable" huh!??? Dang spell check! ?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] joetheshmo:
Nothing compares to the might of DP3!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Hahahahahaha....nice one Joe!! ????
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
LOL! I typed incompatible. Dang! Auto incorrect!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Badger50:
Gotta love them dumb thumbs! ??
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
No "special Zen technique" unfortunately ( I wish I was that cool :cool:). I was just inquiring just in case [MENTION=482227]galaxys[/MENTION] did not use twrp to install; his wording about multiple "flashing scenario" gave me the impression that he might be attempting to manually flash using fastboot and/or adb push. I've seen seemingly countless users running into issues with the Magisk app installation method(s) when when doing it via TWRP seems to be the best and least likely to develop issues. That's all...

I think all these issues might be because you are "sideloading" Magisk... you need to be "installing" -- hopefully you're not going to the Advanced section and using ADB Sideload.... Apologies if this is something you are aware of and may consider it obvious and foolish, but just in case.....

Hope this helps...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] naiku:
OK, so after reading through the thread I decided to install via TWRP. Unlocked the bootloader, which of course wiped everything from the phone (I knew it was going to do so) Temporarily booted into TWRP using fastboot, installed Magisk, rebooted and Magisk Manager and Magisk are not installed. Not really sure why neither of them are installed, as far as I can tell there were no errors when installing the zip from TWRP.

Any ideas?

Edit: Finally, not sure exactly what I did to get it working but now on 16.4.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
Yes, I was using onboard TWRP as always for zips! My PC is 2,000 miles away:D:cool:

Thanks for checking :)
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] E30Nova:
How are you guys rooting DP3?

I've always just flashed the magisk zip in twrp and that was it, but that doesn't work now. I installed the magisk recovery manager and uninstalled all the modules I had, flashed 16.4 again and still nothing.

I've tried watching a boot image and it fails every time.

:(
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Fastboot flashed the factory image, deleted all Magisk modules. Fastboot booted to Twrp and flashed the TWRP.zip, custom Flash kernel for DP3 and Magisk 16.4.zip and reebooted to system. That's all!
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] E30Nova:
Which flash kernel? I'm flashing the 2.44 beta.

I've tried magisk 16.0 and 16.4, magisk manager 5.5 and 5.7.

Nothing works.

It just says latest magisk is 16.0 but not installed. Trying to patch the boot image fails, and the log says "bad system call".
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
Maybe try using TWRP and install via .zip file installer (Magisk-v16.4.zip). And, like it says in the Beta thread, including the error logs from your install will help tremendously and give us a better explanation than the simple statement you've made...

Hope this helps....
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] E30Nova:
That's literally all the log says.

It starts to extract, says bad system call, and fails.

Here's the copy/paste version:

- Device platform: arm64-v8a

- Extracting files

Bad system call

Failed!

! Installation failed
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] simplepinoi177:
I've never needed to make any logs, but I'm pretty sure that the logs would still include more pertinent information. In a pure example, I still have to ask where did this error come from? From flashing it yourself, or from TWRP? Etc.. Copying and pasting isn't really what's called upon and can only be as helpful as how much you give. I'm going to paste what's on the OP for the Magisk beta thread I referred to in my last post:

This

is what I was referring to; and

this

will give a whole lot more information for troubleshooting and help than the 5 lines you've given.

If/When you get these logs, I'm certain it will be helpful and lead somewhere; but it seems to me that you probably need to update and run the latest platform-tools (r28.0.0) or the USB cord you are using needs to be USB-A to USB-C.

Hope this helps...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] E30Nova:
Well I install it via TWRP, and the manager gets installed. Doesn't root the phone, though.

The log is from /sdcard/magiskmanager/

Whenever I try to patch a boot image, it throws that error.

I can't get to the folder for the TWRP log since I'm not rooted, but I'll try to get to a computer and get it.

Thanks for the help. :)

EDIT: Strange.

I just rebooted to TWRP to copy the log to /sdcard/ so I could view it and upload it. I figured since it was in the /tmp/ folder, it was temporary and wouldn't be there, so I flashed the 16.4 zip again. Rebooted to system and opened up magisk manager and now it says I'm rooted.

20th time is the charm, I guess, lol.

I still copied the log and can upload it, but since it appears to have worked, I don't think it's necessary.

I guess chalk it up to being on a Dev preview?

*shrug*
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Alxoom33:
Flash 2.44 b3, Magisk 16.4.zip.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] drewski_1:
Side loading 16.4 worked for me :rolleyes:
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] chazall1:
PPP4 running great here.

I sideloaded the ota coming from PPP3

Magisk passing safeytnet

All good
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] override182:
Guys, I'm facing a pretty weird condition here. I was previously on DP3 with flash kernel and magisk 16.4.

Then I flashed DP4 factory image with -w removed, installed flash kernel then flashed magisk.

When booted up, magisk is running fine but after few hours I'll lose root access.

I've tried the following:

- reinstalled magisk again in twrp

- removed battery optimization for magisk manager.

Pls help if any of you have an idea of what's going on or went wrong. I'm currently on SlotA according to twrp
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Pkt_Lnt:
It is happening to many but randomly. It has been mentioned in the Beta thread and the General Magisk thread that it is being investigated. The tough thing is that it is random, and no one has been able to capture logs that can pinpoint what actually causes the root loss to occur. If you have any way to get a log (many are trying) that would help.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] thenags:
Are there any issues with the July update? I just installed the July update with no issues. Installed Magisk as usual, with no issues. It shows all good and apps that require root access are working just fine. But when I try to install a module it tells me installation failed and that I should install Magisk 15.0+
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dukat0s:
16.6 is up fellas. As usually go to beta thread to download it and for more information about changelog etc.

???
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] dukat0s:
Screenshot..
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] techlogik:
Anybody with Dp4 16.6 Magisk and Flash 2.50 kernel have issues with BT not turning on a after 16.6 install? Worked fine right before. I wipe dalvik, flash 16.4.2 and kernel and it works fine again.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bemagrp:
Install latest 16.6, Google services stopped, safety net failed, system irresponsive.

Flashed stock back, custom recovery, elemental, magisk 16.4, everything back to normal.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] HACK3DANDR0ID:
I had not 1 problem flashing v16.6, i am on NitrogenOS but i dont see that making a difference...
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] Megaflop666:
Zero problems here with 16.6
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] galaxys:
16.6 looking good
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] pkgnex:
Try reflashing your entire image clean from the start. This is the most trouble-free Magisk update to date. I'm seeing nobody else having problems.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] lssong99:
Not sure what happened but after (boot twrp) flash 16.6, everything good. After setting up PIN and fingerprints, ticking the "Force device encryption" in Magisk manager then reboot again, phone wont accept my PIN.... :(

If not ticking the "force device encryption", my setup PIN is ignored... and system reboot straight into launcher...

After reflash back to stock boot.img (DP4), everything goes back to normal (PIN accepted)...

Anyone with same issue?
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bemagrp:
Yes, I had same thing, force restart your phone and next time system will take your pin.

---------- Post added at 11:50 PM ---------- Previous post was at 11:48 PM ----------

Again, i reflashed whole image, insyall twrp 3.2.2.0, elementalx 10, and magisk 16.6, google services stopped as soon as i restart the phone. Did same thing, but flashed 16.4 back, no problem.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] SysWiz:
I had the same problem, and trying to launch Google Play Store resulted in it just hanging. I tried clearing data/cache on it, but no dice. Reverting back to 16.4 resolved the issue for now.
[Google Pixel 2 XL ROMs, Kernels, Recoveries, & Oth] bemagrp:
Finally, I am not alone with google services failed after 16.6 update.

16.4 works as should be, perfect.