yashsingh1/xdaforums huggingface dataset:
[Google Pixel 2 XL Guides, News, & Discussion] ScottIsMyName:
More research for anyone who might find it helpful:

*It seems like verity is not being patched with Magisk. Using a kernel with verity removed does not help and still bootloops after Magisk is applied to it.

*/system in the Pixel 1 file system was squashfs. With Pixel 2, now using ext4. However, system no longer is mounted with verify, but instead uses avb

system / ext4 ro,barrier=1 wait,slotselect,avb

*/vendor is no longer shows up in fstab in pixel 2. Instead it MAY be in dtbo.img and is also mounted with avb. Pixel 1 did not have vendor mounted with avb

https://github.com/matthewdalex/wahoo/blob/master/arch/arm64/boot/dts/lge/msm8998-taimen.dtsi

fstab {
compatible = "android,fstab";
vendor {
compatible = "android,vendor";
dev = "/dev/block/platform/soc/1da4000.ufshc/by-name/vendor";
type = "ext4";
mnt_flags = "ro,barrier=1";
fsmgr_flags = "wait,slotselect,[b]avb[/b]";
};

I looked at dtbo.img in a hex editor and do see references to avb around the reference to vendor.

Many thanks to [MENTION=5169465]DespairFactor[/MENTION] for all the help today trying to get root to work (and of course for his kernel which bypasses safetynet with an unlocked bootloader)
[Google Pixel 2 XL Guides, News, & Discussion] ScottIsMyName:
More research results...since we do have dtbo.img, I decided to run magisk manually from my rooted Pixel 1.

Here is the results:

127|marlin:/data/local/tmp/upload # ./magiskboot --dtb-patch dtbo.img
MagiskBoot vtest(1) (by topjohnwu) - Boot Image Modification Tool

Loading dtbs from [dtbo.img]

Found fstab in dtb.0000
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0001
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0002
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0003
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0004
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0005
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0006
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0007
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0008
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0009
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0010
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0011
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0012
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0013
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0014
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0015
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0016
Found block [vendor] in fstab
Found block [persist] in fstab
Found fstab in dtb.0017
Found block [vendor] in fstab
Found block [persist] in fstab

I'm wondering if we flash the patched dtbo.img if that will work? I really have to run now, but someone else might try it?
[Google Pixel 2 XL Guides, News, & Discussion] slothdabski:
If you post a build, I can try to flash and report back
[Google Pixel 2 XL Guides, News, & Discussion] ScottIsMyName:
Nevermind, I just noticed the code isn't actually patching any fstab entries because it's looking for verify and all our entries contain avb instead.
[Google Pixel 2 XL Guides, News, & Discussion] jlee08517:
According to Twitter, Topjohnwu just got done with his tests. You might want to ping him and maybe he has some time to share us some insights?
[Google Pixel 2 XL Guides, News, & Discussion] northmendo:
I don't see any updates from [MENTION=4470081]topjohnwu[/MENTION] on Twitter.
[Google Pixel 2 XL Guides, News, & Discussion] ScottIsMyName:
This may be of great interest and explains why magisk doesn't work. It appears previous devices are using avboot v1 while ours is using v2. This (avbtool) is what chainfire was alluding to when he made the verifiedbootsigner tool a few months back. I don't know enough about this stuff to know if something like that would work for us or what.

https://source.android.com/devices/architecture/kernel/modular-kernels
[Google Pixel 2 XL Guides, News, & Discussion] RainManPA18:
I just got my pixel 2 XL a couple days ago. Anything I can do to help with getting Magisk going?
[Google Pixel 2 XL Guides, News, & Discussion] Ketawa:
If this is eventually going to be a full guide to root access, I highly recommend adding to the OP now that you have to issue "fastboot flashing unlock_critical" in addition to "fastboot flashing unlock". "unlock_critical" wipes the data partition like the regular command, and it is required to flash a new bootloader e.g. with the flash-all script. The 8.1 developer preview already has a new bootloader.
[Google Pixel 2 XL Guides, News, & Discussion] moon2eth:
https://www.xda-developers.com/root-is-now-available-for-the-google-pixel-and-pixel-xl/

October 29 2016

Is this the longest a Google device have been without root? The community is so helpless workout chainfire.
[Google Pixel 2 XL Guides, News, & Discussion] Veritech:
It's funny, I was referencing that article myself the other night trying to determine how long until root for the Pixel 2 devices would be achieved. I'm thankful to the smarter people in this thread actively working on this and trying to find a way to make it happen. Much appreciation to you all for your efforts!
[Google Pixel 2 XL Guides, News, & Discussion] beezar:
Well it's still Oct 29, so we still have got a few hours... Maybe chainfire will have one last encore? One can hope
[Google Pixel 2 XL Guides, News, & Discussion] moon2eth:
It would be a dream come true. There aren't many guys like chainfire and rovo89.
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
Is it certain that we are going to have to do unlock_critical for root?

I want to make sure it's all ready to go for root once it's ready.
[Google Pixel 2 XL Guides, News, & Discussion] loganfarrell:
From what I have understood historically, the critical unlock will only add the ability to flash different custom bootloaders and bypass a few extra security measures. Unless root ends up requiring a bunch of extra work on our device it should be fine to do just a flashing unlock.
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
Thank God you said that. I just finished setting it up and it would be a pain to go though all that again.
[Google Pixel 2 XL Guides, News, & Discussion] loganfarrell:
I'm just speculating though. It could require that if it requires a custom bootloader. I just don't think that's the solution so I'm GUESSING that the flashing unlock is sufficient.
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
Before the latest Platform tools update, I couldn't flash any bootloader or factory image until I unlocked critical. I am wondering if the platform tools update for pixel 2 devices allows us to flash a bootloader without unlock critical?
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
Why not just update the sdk and be done with it? That's silly. It takes about 5 minutes to do and you are ready to flash/unlock the Pixel.

I wouldn't even dare to try using old fastboot utils. Seems like a fast way to brick your device.
[Google Pixel 2 XL Guides, News, & Discussion] loganfarrell:
Regardless of whether or not we need a new bootloader for root you'll be able to boot into a custom recovery and make a backup and then do the critical unlock and then restore data in TWRP

I'm not 100% certain but I highly doubt that. Google tends to really push their security and that would be a risk potentially. That being said, the critical unlock can be done afterwards like I mentioned above so it isn't 100% necessary for anyone to wipe their phones again if they already set them up. I'm in that boat and many others are for sure so we can hold off until TWRP is hopefully working. That will ideally come before root
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
I did update the day Google came out with the platform tools update. But prior to that, I was trying to flash a factory image and couldn't. Wouldn't flash any bootloader. Then I unlocked critical and all was good. My question is ,did the new update to platform tools for pixel 2 devices, allow us to flash a bootloader without unlocking critical? As I have already unlocked critical and don't want to lock it again if I can't flash a bootloader with the new platform tools

---------- Post added at 07:41 PM ---------- Previous post was at 07:38 PM ----------

Critical unlock doesn't apply to OG pixels.Yet! Only Pixel 2 devices
[Google Pixel 2 XL Guides, News, & Discussion] loganfarrell:
Locking it again would be silly but unlocking it may/may not be necessary. Either way we will be able to unlock_critical if we already unlocked normal flashing and not lose data if we are patient.
[Google Pixel 2 XL Guides, News, & Discussion] dinkoh:
Any downsides of unlocking critical? I can relock it if there are any?
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
It wipes data.
[Google Pixel 2 XL Guides, News, & Discussion] xstokerx:
https://desktop.firmware.mobi/device:1809

Has any one tryed cf auto root they put the firmwares up and have the option to patch for cf auto root or is this site a joke now that chainfire no longer runs it
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
That's for small pixel, might be worth a try if they got taimen

---------- Post added at 08:29 PM ---------- Previous post was at 08:27 PM ----------

https://desktop.firmware.mobi/device:1810/firmware:13747

---------- Post added at 08:29 PM ---------- Previous post was at 08:29 PM ----------

Here is taimen, now who wants to be brave
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
I posted right link above
[Google Pixel 2 XL Guides, News, & Discussion] Alxoom33:
Do you think that it would work on 8.1 DP1 on the Pixel2 XL?
[Google Pixel 2 XL Guides, News, & Discussion] psychotropic:
I'm crazy enough to try this. Let me download tools and we'll see what happens in a few hours.
[Google Pixel 2 XL Guides, News, & Discussion] vanydotk:
Godspeed you crazy bastard, godspeed.
[Google Pixel 2 XL Guides, News, & Discussion] psychotropic:
I haven't even activated my Pixel 2 XL yet until root happens, so I'm still on my S7 Edge. Even if it blows up in my face, it's not like I've transferred my life to a new phone yet.

I live in rural Alaska where my internet is slow-ish (Google: GCI Terra Project) so I'm downloading all the relevant backup files, e.g. ROM before I go forth. That seems like a responsible thing to do. Once all that is downloaded, I'll be game to tool around with this.
[Google Pixel 2 XL Guides, News, & Discussion] jlee08517:
Just a little skeptical since I don't even think that worked for the og pixels. Hence all the special releases straight from chainfire

But... I can only hope
[Google Pixel 2 XL Guides, News, & Discussion] Brian706:
Just curious if anyone tried to fastboot boot the modified boot.img instead of fastboot flash. I was thinking about the original Pixel XL and how this was the case, though I'm unsure about with magisk. I've never used it, I used SuperSU. But with chainfire retiring, might be time to check out magisk for my XL 2 rooting needs.
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
Sorry. Tapatalk didn't refresh
[Google Pixel 2 XL Guides, News, & Discussion] loganfarrell:
Someone earlier in the thread said it bootlooped as well
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
Awaiting your results with all hopes
[Google Pixel 2 XL Guides, News, & Discussion] Alxoom33:
Yeah, good luck!
[Google Pixel 2 XL Guides, News, & Discussion] Snow02:
Here's the 8.1 link.

https://desktop.firmware.mobi/device:1810/firmware:13775
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
Doesn't work.Tried several configurations.Bricked! $1000 in the toiler. Kidding. Doesn't work
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
Android is doomed with chain fire retiring.
[Google Pixel 2 XL Guides, News, & Discussion] northmendo:
It shouldn't be bricked. Just flash the factory image.
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
Which image did you use? The IMG or the ZIP? Did you have it build one with custom options or did you just pick the top one with just the boot image?
[Google Pixel 2 XL Guides, News, & Discussion] northmendo:
Follow this
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
Tried several ways with a zip.

Force sbin install.

With and without suhide.

Flashed just the boot image from the zip,alone

---------- Post added at 09:53 PM ---------- Previous post was at 09:53 PM ----------

You just have to flash factory boot image. Factory image is overkill
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
Oh well.
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
There is two other options.

Force system

Force systemless

Doubt they will work.Thats for pre 8.0. Supersu works in sbin mode in 8.0 Tried forcing that too. Shouldn't have to force it with 8.0
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
Also on pixel 1 you had to fastboot boot, not fastboot flash
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
It's very sad that Chainfire left. It's even sadder that someone put this root out without testing.

Got our hopes up :(

---------- Post added at 04:37 PM ---------- Previous post was at 04:26 PM ----------

Did you try fastboot boot instead of fastboot flash?
[Google Pixel 2 XL Guides, News, & Discussion] Alxoom33:
Trying with CF Auto root now on My Pixel 2 XL. Wiped my Data. Looks like it may have worked. I'm in 8.1 setting up clean.

I'll report back when I am set up.
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
That doesn't make any sense. It has to be permanently flashed to stick
[Google Pixel 2 XL Guides, News, & Discussion] techstudio:
Excitedly waiting for your return!
[Google Pixel 2 XL Guides, News, & Discussion] Alxoom33:
It definitely unlocked the bootloader. Now to wait and see if I have root.
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
On the pixel 1 when he first made it it was called boot to root and you had to fastboot boot the image
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
That has nothing to do with this.Everything is automatic. I also tried flashing the rooted boot image inside the zip. It's not a boot to root image
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
You just asked why and I told you. On pixel one it's one you had to do before twrp. If you refuse to try it cause of what you think you know, well hey thanks for the effort anyway
[Google Pixel 2 XL Guides, News, & Discussion] loganfarrell:
How did it go? I'm curious to see if that method works
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
If you look at the batch file, it says

fastboot boot ..\image\boot.img

So, I'll try that and let you know.
[Google Pixel 2 XL Guides, News, & Discussion] Golf c:
Yep, I ran the root.bat file. Their are two of us now that failed.
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
Like I tried to tell him, when root first came on the pixel, before twrp, you had to fastboot boot it. If you flashed ,it wouldn't work. After fastboot booting it, device would reboot a couple times and it would stick. I don't claim to know why, but that's how it worked.
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
It didn't work anyway. I did it right, no root
[Google Pixel 2 XL Guides, News, & Discussion] Alxoom33:
I ran CF Autoroot for the Pixel 2 XL for Android 8.1. It unlocked my bootloader and wiped data, but it did not root. Not sure what else to try atm. Did it twice.
[Google Pixel 2 XL Guides, News, & Discussion] cwalker0906:
https://plus.google.com/+Chainfire/posts/fvEPo42GKXS

In the link, chain fire explains what was different with original pixels and why package don't work. Mostly because of boot image which is exactly the same in new pixels. Also explains why you have to fastboot boot and not flash. Hopefully someone smarter than me can figure it out
[Google Pixel 2 XL Guides, News, & Discussion] Not So Pro:
Good read but I don't think we'll be able to do much until a custom recovery like TWRP comes out. Otherwise we have to manually build it into kernel if I'm not mistaken. I just wish there was more I could do to help out. Feels like there's only several people on XDA that know how to do this as of now.
[Google Pixel 2 XL Guides, News, & Discussion] northmendo:
Not only that, but it seems like the current Magisk doesn't patch the boot image appropriately. Even if we get twrp tonight I don't think we'd have a usable root.
[Google Pixel 2 XL Guides, News, & Discussion] gakio12:
Sorry all, I'm going to have to step off of this project. Some unexpected expenses came up and I had to cancel my pixel 2 order. I'm sure someone will get root working soon. :fingers-crossed:
[Google Pixel 2 XL Guides, News, & Discussion] abuttino:
That is what I got from the Snoke thread. It needs to be manually patched. Despair seemed to want to help if the right person came along that knows what they are doing.

I might ask jcase if we can get further than ground zero.
[Google Pixel 2 XL Guides, News, & Discussion] idkwhothatis123:
I oddly enough agree with this lol. I personally think Magisk is a far inferior product than SU. It has always been a tempermental, steamy, pile of poo for me. I revert to SU, flawless. Here's to hoping for a better Magisk in the future.
[Google Pixel 2 XL Guides, News, & Discussion] genesis72:
Anyone see this?

http://rootmygalaxy.net/how-to-root-google-pixel-2-xl-and-install-twrp-recovery/

I'm at work and can't try yet. Just wondering if this is real or fake.
[Google Pixel 2 XL Guides, News, & Discussion] JedixJarf:
It's garbage, TWRP doesn't exist for the Pixel 2/XL yet.
[Google Pixel 2 XL Guides, News, & Discussion] dinkoh:
Did you even read it?

It's obviously fake/fabricated. The author's pic should have been a big giveaway.
[Google Pixel 2 XL Guides, News, & Discussion] lucky_strike33:
it wont work cuz twrp is not available. Just some kid trying to be cool and post a story that is not true as of yet....
[Google Pixel 2 XL Guides, News, & Discussion] Richard Robertson:
What issues did you have with Magisk? It's working great for me, root and even running Xposed systemless-ly on my Nexus 6.
[Google Pixel 2 XL Guides, News, & Discussion] slothdabski:
Please discuss off topic via PM
[Google Pixel 2 XL Guides, News, & Discussion] ScottIsMyName:
[MENTION=5169465]DespairFactor[/MENTION] and I have been trying a lot of stuff the last few days without any success.

We actually managed to get a magisk patched boot image booted, but root still did not take. This required him building a kernel without any verity/avb enabled, and rebuilding dtbo.img.

We've tried a large number of combinations, without success.

Really hoping [MENTION=4470081]topjohnwu[/MENTION] has some insight into getting Magisk supported with our device.
[Google Pixel 2 XL Guides, News, & Discussion] slothdabski:
We appreciate your efforts!!! Any luck with SuperSU? Or just been focused on magisk?
[Google Pixel 2 XL Guides, News, & Discussion] ScottIsMyName:
Some people have tried cf-auto-root without success, I haven't tried at all

I am going to be posting a new thread in the magisk subforum that will contain a summary of all of the stuff we know and have tried.
[Google Pixel 2 XL Guides, News, & Discussion] JedixJarf:
You don't see the past 10 pages of people actually working on this to try and figure it out? Seems like a work in progress to me, regardless of the actual amount of progress you deem they have made.
[Google Pixel 2 XL Guides, News, & Discussion] Jexx11:
Thanks for the effort, really hope something gets working soon, I miss my tethering and adblock lol
[Google Pixel 2 XL Guides, News, & Discussion] DespairFactor:
Bad loss yesterday:(
[Google Pixel 2 XL Guides, News, & Discussion] galaxys:
Vegas is bummed and hungover!:(:eek:
[Google Pixel 2 XL Guides, News, & Discussion] Megaflop666:
A few of us tried various cf auto roots without any success as well. According to [MENTION=649160]despair[/MENTION] , there's a lot going on under the hood.
[Google Pixel 2 XL Guides, News, & Discussion] slothdabski:
it looks like the moto x4 with A/B partitioning has the EXACT same results when trying to flash magisk. no root with 14.0 and bootloop with 14.3. i wonder if they have made any progress

https://xdaforums.com/showpost.php?p=74319385&postcount=4358
[Google Pixel 2 XL Guides, News, & Discussion] Jexx11:
Just yesterday? Lol, sadly it's been a disaster of a season when expectations were so high, it's time to can some coaches
[Google Pixel 2 XL Guides, News, & Discussion] cjkacz:
Depends on who you ask lol #bills
[Google Pixel 2 XL Guides, News, & Discussion] sickestlag:
I was looking through the Magisk github, and it looks like there was a commit yesterday on the MagiskManager repo that adds boot signing, which hopefully has some positive implications on our bootloop issue. If I had more time, I'd setup and compile the latest sources and see if it works, but I probably won't be able to until later in the week. Hopefully we get a new official (beta) release soon enough!
[Google Pixel 2 XL Guides, News, & Discussion] vanydotk:
I sure hope so, I'm still using my OG Pixel until there's root. I only have 3 weeks left before I have to trade it back into Google!
[Google Pixel 2 XL Guides, News, & Discussion] jlee08517:
I was doing that and I just gave up and moved on for now. Haha honestly it so far hasn't been too horrible. But all these ads are killing me. At least I don't have to wait 10 seconds to download stuff on some websites haha
[Google Pixel 2 XL Guides, News, & Discussion] slothdabski:
Use dns66 from fdroid. Can toggle on and off from notification shade. Doesn't kill battery since it only filters DNS traffic.

Still miss root tho :(
[Google Pixel 2 XL Guides, News, & Discussion] vanydotk:
I'm thinking about giving as well, but one of my big concerns is restoring data, I use Titanium Backup. Maybe I should just let Google back up my phone and see how it goes.
[Google Pixel 2 XL Guides, News, & Discussion] beerbaronstatic:
I ended up just downloading the apps I cared about onto my 2 then used adb backup to pull the data from my 1 and adb restored it after my last wipe installing 8.1. The first time I set it up out of the box I let it use the data importer from my pixel 1 and it did a pretty good job, few things (Nova being probably the main) didn't bring their settings over
[Google Pixel 2 XL Guides, News, & Discussion] jlee08517:
Same here. I am extremely anal about keeping all my data. Surprisingly data transfer tool did a decent job copying over alot of stuff.. It was pain setting up stuff that didn't though but some apps I'm gonna keep titanium backups locally untill root arrives. And setup then.
[Google Pixel 2 XL Guides, News, & Discussion] hilla_killa:
Thats whats im Wondering coming from a nexus5x i only unlocked bootloader and now reading about critical unlock now that my phone's all set up how i want it
[Google Pixel 2 XL Guides, News, & Discussion] ScottIsMyName:
I started a new thread in the Magisk forums:

https://xdaforums.com/apps/magisk/pixel-2-pixel-2-xl-support-t3697427

Please do not reply to it unless you have something useful to add. In the thread I summarized everything we have learned/tried so far. Mods, feel free to close/lock this thread if you think appropriate.