yashsingh1/xdaforums huggingface dataset:
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bl8demast3r:
Hi, I'm very sorry for leaving another how to install post but I keep getting confused on all these different tutorials.

So, I came from a Nexus 6P and when I installed Magisk it was as simple as:

1. Download Magisk

2. Unlock bootloader

3. Reboot into fastboot and flash twrp to recovery.

4. Boot into recovery and flash Magisk.

With the Pixel XL I defiantly find this a lot more complicated to follow instructions because of how many releases of TWRP there was. So If I were to follow the same steps as I did for the 6P would everything work? I'll be using the fastboot image for TWRP found here: https://dl.twrp.me/marlin/twrp-3.1.1-0-fastboot-marlin.img.html

When I first got the Pixel XL I immediately unlocked the bootloader so I wouldn't have to factory reset when I rooted. I waited patiently for the talented topjohnwu to release Magisk with official Pixel support and I'm ready to root my device. Unfortunately, I keep reading about how TWRP will wipe user data and some people lose TWRP on reboot.

It looks to me that the TWRP released on the 25th of September (3.1.1.0) is the official release specifically made for fastboot flashing rather than a .zip file.

Here are the steps I would like to follow without losing any data:

1. Download Magisk 14.2 beta

2. Reboot into fastboot and flash twrp to recovery.

3. Boot into recovery and flash Magisk.

I'm really sorry if some of this belongs in another thread. I've been searching for days on info about the latest release of TWRP and I only find info about RC2 or RC1. I also can't find any info on Magisk 14.2 with TWRP 3.1.1.0
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] whitak3r:
Got this running on Pure Nexus 7.1.2-20170509. SaftyNet is failing still, which I expected since it wasn't working for the last month or so after that update from Google.

Got the Greenify Module working, haven't tried many others. So far so good though.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Golf c:
The Pixels need two Twrp files for flashing. One is a fastboot image and the other is a Twrp installer zip.

1. fastboot boot twrp.img

2. flash Twrp installer zip in Twrp. already placed on phone storage.

3. Reboot recovery. Probably not necessary, but to make sure it sticks

4. Flash Magisk.

No problems with your data.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Bryanx86:
Use your fastbooting twrp to boot into twrp. Then flash the latest(9-25) twrp zip. I haven't had any problem with it sticking on stock Oreo, elemental x kernel, and magisk 14.2. sorry for the ot
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bl8demast3r:
Thank you guys so much! I've just noticed that in the OP it says not to install Magisk through TWRP installed on boot image. Does this still apply? Or was it for the modded version of TWRP only.

If this still applies to the official TWRP release then should I only run the TWRP img in fastboot to flash Magisk and not install the TWRP zip?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Golf c:
Definitely doesn't apply to official Twrp 3.1.1
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Bryanx86:
I flashed magisk 14.2 with (9-25)twrp. It's no problem, not much development I can find for the Marlin.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] whitak3r:
Yeah I think you're correct. When I first went to install everything I had to flash TWRP 1... Then reboot, then 2, then flash the Rom. It was a mess.

I just installed Magisk 14.2 and all I did was reboot into recovery, flash 3.1-1 and then flash Magisk14-2.zip and rebooted. Worked flawless.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bl8demast3r:
Thank you so much everyone! :D :D :D :good:

Edit: Unfortunately, Magisk will not work correctly and it crashes every time I try to open superuser. I've posted the logs in the Magisk beta thread.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] shotonhead:
hi,

i am gonna explain the simple steps i used to flash magisk here ,

1.download Flashfire.

2.download latest OTA from here https://developers.google.com/android/ota

3.download magisk 14.2

4.install or flash both the latest OTA and magisk through flashfire at the same time(enqueue both).(enable automount in flashfire when prompted before flashing the zip and also make sure Everoot is disabled in the app before flashing)

5.all done.magisk should be installed and working correctly by now.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] quinejh:
Is there a MagiSk 14.2 somewhere just for the pixel? All I can find of it is 14.1 for Google pixel and a 14.2 that doesn't specially says pixel . Was gonna just flash it and see but I thought it would be worth a shot to ask first
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] liam_davenport:
From 14.1 Pixel/XL is officially supported so you can flash 14.2 from the beta thread and it'll work fine
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] quinejh:
Awesome!! Thanks
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Akomack:
Has anyone gotten titanium backup to work? I get the Su prompt, but it doesn't restore apps
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] GroovinChip:
What would my steps be to transition from SuperSU? Is a custom kernel still required in order to use Magisk?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Falitheman:
I'm on 14.2 but I dont seem to pass safetynet. I basically went through all the steps you did expect i didnt use busybox or es file explorer. Im still on 7.1.2 could that be it?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Phinocio:
Android pay is working fine for me using Magisk and Kirisakura-Harmony-O Kernel.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] djide:
Finally did and works great. Everything works while i stayed with stock kernel.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] VanGolfer:
Hi: I rooted successfully but the device is still encrypted. Is it suppose to be encrypted? Or do I miss anything and I want device not encrypted. Thank you!
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] WarningHPB:
I think i finally got it to work, I applied the full October security patch (minus the -w on update to keep data) so I would be back to stock without SuperSU.

I then booted the newest version of TWRP (3.1.1-0) downloaded from https://eu.dl.twrp.me/marlin/

Then when booted into TWRP (fastboot boot twrp-3.1.1-0-fastboot-marlin.img) I queued the "twrp-pixel-installer-marlin-3.1.1-0.zip" and then " Magisk-v14.2(1420).zip" to be installed which i moved onto the Pixel XL while in TWRP.

Then rebooted into recovery just to check that TWRP had installed properly which it had. Rebooted again but into system everything seems to be up and running with out any issues.

Will report back if there are any issues.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] akenis:
I'm in the same boat, thinking about doing the same steps. But think I want to use September images and actually see the OTA mechanism work.

I'm on September images now, but I think I mounted system when I booted TWRP last month, so OTA probabky wont take. Does OTA check both partitions?

Kind of wondering if I can pull this off without full flash-all. Can I boot from my inactive slot to get clean system image and then take OTA on my current slot which would then be the inactive one? Would I still need to flash boot.img to both slots? Does OTA mechanism check active slot or inactive slot to see if we are capable to take OTA?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] patroll:
After giving root rights to Adaway and booting I get ramdump and my rom does not boot again.

Before that everything is working. I'm on Lineage 14.1.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] WarningHPB:
From my understanding the OTA gets installed to the inactive partition

Example: Your using partition A and OTA gets downloaded and installed to Partition B, when the device reboots it selects partition B as active and then starts loading as normal.

TBH if you only booted into TWRP then it shouldn't be an issue, its only if you installed TWRP that it might be come an issue and stop the OTA

I doubt that the OTA checks both partitions and then installs, i suspect it would check the inactive partition and then see if that's able to take the OTA, I'm not sure if your method your saying will work, but you can try it.

The long winded way in which I got mine working was to flash both partition A and B with the October security patch stock image, then select A as the active partition, booted into TWRP and installed TWRP and Magisk at the same time and then rebooted and to recovery to check it TWRP installed correctly and it did and booted into system, root and Magisk Hide seems to work as it should not tried modules since there are no modules I would use.

However with my method I think OTA might not work due to me installing TWRP, however I personally am fine with manually updating my Pixel XL.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] akenis:
https://github.com/topjohnwu/Magisk/blob/master/docs/tips.md#ota-installation-tips

He says even if system was ever mounted it would fail due to block verification. Also fail for vendor or obviously boot.img. He doesn't mention recovery, but he wrote that before we had flashable TWRP maybe. Guess you're right...it probably wouldn't work without stock recovery.

I'm guessing OTA verification definitely looks at active slot...that's why he has us un-magisk and restore stock boot.img before accepting OTA. Maybe he needs a restore stock boot and recovery?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] DerpleNerple2000:
Just a PSA: If anyone is having issues with flashing modules with TWRP or Magisk itself and it says it had an issue with mounting something, try using the latest version of FlashFire from Chainfire's G+ page. When using it, check Auto-Mount and flash the zip you'd like. I can't tell if it's something with Magisk, TWRP, or even the module itself causing mounting issue, but that work around works well. Also, OTA works fine using the FlashFire method. Just manually sideloaded the latest OTA without issue (Flashfire has a "Flash OTA" option but I haven't tried it). Safetynet also passes fine after using FlashFire..
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] lachiefish:
hey guys, cheers for the development, but quick question:

If I have latest TWRP installed (3.1.1), and EX kernel, can i still take OTA's the way the guide in OPs post describes for the dual partition setup? (https://github.com/topjohnwu/Magisk/blob/master/docs/tips.md#ota-installation-tips)

Thanks :)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] zee24:
I had the same. I went into super Su app clicked remove all root

Then once I dig that deleted both apps and booted into TWRP and flashed magisk and it's been working perfectly fine but I had stock kernel so not sure if it'll work if you had a different kernel
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] lachiefish:
I haven't had any issues either, however installing Magisk before going through the phone set up seemed to have deleted the data transfer tool, as it got stuck on downloading that, so make sure you boot up and go through the whole set up if you want to use a backup :)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Gibby1310:
I am having the same issue, have you figured this out yet?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Akomack:
I have not, what I did was installed supersu, restored apps, then reflashed DU, flashed TWRP, booted, then rebooted to twrp and flashed magisk. It backs up apps fine, but won't restore.

I tried changing the SELinux to permissive, but that didn't help.

Kind of frustrating, but I was able to get it to work that way. If you end up finding a solution I would appreciate if you would share. I'll do the same.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Gibby1310:
Funny, I am halfway done restoring, but I had to remove magisk and use SuperSU also.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] mochamoo:
I got my pixel xl today. I powered it up and did as little as possible (since I was going to reset it anyway) and let it update from 7.1.2 to Oreo with the October security patches.

I then went ahead and unlocked the bootloader (which reset it) and then proceeded to set it up. It automatically updated some apps. When it was done with that I proceeded to root it with magisk 14.2 as in the following (skipping the parts to get rid of superSU since it wasn't installed in the first place).

https://xdaforums.com/pixel-xl/how-...t-pixel-xl-t3660324/post73992555#post73992555

Copied my (backed up) titaniumbackup folder from PC to pixel and installed TB from the play store. Restored the apps I wanted to. Back in business without a hitch.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Akomack:
I wonder if my issue is that I'm running DU, I've become so accustomed to having smartbar it's going to be near impossible to use anything that doesn't have it. I also need to stay with AOSP due to losing the unlimited full-res backups with LOS based roms.

I'm having a lot of issues with Magisk, some apps don't see that they have root, even though I was prompted and allowed them to have it.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Echo_Platoon:
Sorry about the late reply. Life has been very busy for me lately.

A few versions ago of Magisk and Magisk Manager (one developed by goodwin_c, which back then I think part of the procedure was to install BusyBox separately), I had issues with running the SafetyNet check. After I installed osm0sis' BusyBox, the SafetyNet check ran without issues. From then on, I always installed osm0sis' BusyBox before installing Magisk.

I use ES File Explorer because it is an easy file explorer program (that also has root functionality) to use that will also help with executing/installing an APK file.

I haven't tried Magisk 14.2 on Android 7.1.2; only tried it on Android 8.0.0 with the September security updates.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] akenis:
Still trying to find out if Magisk OTA mechanism will work with TWRP installed?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Echo_Platoon:
For my steps, I didn't need to flash a TWRP installer zip in order to install Magisk 14.2. I only had to fastboot the version that topjohnwu mentioned in the first post of this thread. After fastbooting the one topjohnwu mentioned, I was able to do all of the steps that I mentioned. If someone would like to have TWRP as his or her permanent recovery before installing Magisk, then that person would follow the steps you have to install main part of Magisk. For my steps, I just decided to keep things as stock as possible but still have root.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] mochamoo:
I have had the occasional issue where it doesn't grant SU even though I allow it. I go into Magisk Manager #superuser and grant it that way. Had to do it with greenify yesterday.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Akomack:
Did it show that Greenify already had the toggle enabled in the superuser section of the Magisk Manager? I haven't had any issues other than TiBU not restoring apps, and I'm trying to install Wakeblock, but I think the wakeblock issue is more about DU/Pixel than my superuser.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] mochamoo:
No it didn't.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Sh0X31:
Hi Guys,

How I update magisk? I'm on Android 8 with EX Kernel & Magisk 14.2. Do I need to reflash twrp or kernel?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] nycdiplomat:
You can update right from within the magisk app. If you have the notification turned on, it should have already prompted you that an update is available.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] djide:
Or if the notification is off you can upgrade from the main page in the magisk manager.

By the way, I updated last night and all worked except I couldn't pass safetynet, had to downgrade back to 14.2.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] JimSmith94:
I get the prompt to update Magisk Manager but nothing happens when I click on Install.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] siheals:
Uninstall the app them download the app from the official xda thread.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
If you enable storage permissions you can update from within the app.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] djide:
Did anyone get 14.3 to pass safetynet? Also whoever did, can you share the process you used to flash the update. Thanks
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ChongoDroid:
Mine passes the safety net, I just used the recommended installation process from within the app.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] djide:
Thanks, I would guess because I have EX kernel installed that's why it's failing.... Just need that additional sound boost; this phone's volume is damn to low.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] akenis:
I had September and SU. Did remove root and unsu.zip and flashed stock boot to both slots and system.img. OTA to OCT kept failing. Did flash-all to Sep and OTA still failed. Finally switched slots with TWRP and it finally booted with system up to date....but on wrong build!

Did flash-all Oct (from Linux) and 14.2. kept getting boot loop. UnMagisk.zip and boots fine. Repeat.

Finally did another Oct flash-all from Windows and flashed 14.3 from TWRP latest boot img. Works fine now. I didn't need to flash a busy box and kept stock kernel. Should work with custom kernel.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Jinded:
I'm having an issue where I install a module through Magisk Manager, and it completes successfully, but when I reboot the module is not active and is not listed in Magisk Manager > Modules. Has anyone ran into this and know of a way around it?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bloodien0se:
Hey Guys,

I'm trying to get Magisk setup on my Pixel XL on 7.1.2. Systemless Root appears to be working fine but I'm unable to install any modules. The modules have no errors in the logs, but after reboot they do not show in the modules list and appear to have no effect.

I started with a full flash-all of NKG47S factory image, and installed Magisk 14.3 and ElementalX 1.15 via TWRP fastbooted. Then I used Magisk Manager to modify the stock NKG47S boot.img, and flashed the patched_boot.img via fastboot as well.

Here's my log from MagiskManager

Anyone seen this before or know why I might be unable to install any Magisk Modules?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] billiepreks:
I've been using magisk many months ago, the module installation worked before but since I've flashed Magisk 14.3, I get the same problem as you. The only solution I've found is uninstalling Magisk 14.3 and stay on 14.2, modules are working with it
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] bloodien0se:
Sweet, I'll give it a shot. Thank you.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Bryanx86:
Anyone rooted with magisk on 8.1 beta?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] kartikb:
Yup, I'm using Magisk 14.2 as 14.3 was causing a lot of issues with safety net failing after a while and soft boot loop which required a restart.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ScottIsMyName:
Has anyone successfully installed magisk without using twrp on 8.0? I generated the patched boot image and flashed that I the bootloader but when it boots it said magisk is not installed
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Homeboy76:
Without Installing TWRP: yes Post 1 - #10 - Root with Magisk remain Stock - Pass SafetyNet and Receive OTA Updates Thanks, LeMoise
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ScottIsMyName:
I mean without installing TWRP at all. That should be possible with the newer version of Magisk that takes a stock boot.img and patches it....you then flash that modified boot img in bootloade mode and it should work. Not working for me though.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Homeboy76:
You are not installing TWRP you're fastbooting the TWRP IMG to flash Magisk 14.3. when you reboot no TWRP. To install TWRP you have to fastbooting TWRP.img and flash TWRP. zip :)
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ScottIsMyName:
I understand that completely.

I was attempting to use the MagiskManager apk and upload a stock boot.img, have it patch it, and apply that patched boot.img in fastboot. In this case, TWRP is not used at all.

I got it working eventually without TWRP, so that's pretty cool.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Homeboy76:
Does MagiskManager 5.4.0 fastboot the patched boot.img?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ScottIsMyName:
No you must do it manually
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Homeboy76:
With Flashfire, TWRP or gremlins? How did you do it manually?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] ScottIsMyName:
The normal way to flash. Reboot to bootloader, and then run:

fastboot flash boot patched_boot.img
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Homeboy76:
QUOTE=skaforey;74309159]Has anyone successfully installed magisk without using twrp on 8.0? I generated the patched boot image and flashed that I the bootloader but when it boots it said magisk is not installed[/QUOTE]

Without Installing TWRP: yes Post 1 - #10 - Root with Magisk remain Stock - Pass SafetyNet and Receive OTA Updates Thanks, LeMoise

QUOTE=skaforey;74315397]I mean without installing TWRP at all. That should be possible with the newer version of Magisk that takes a stock boot.img and patches it....you then flash that modified boot img in bootloade mode and it should work. Not working for me though.[/QUOTE]

You are not installing TWRP you're fastbooting the TWRP IMG to flash Magisk 14.3. when you reboot no TWRP. To install TWRP you have to fastbooting TWRP.img and flash TWRP. zip :)

QUOTE=skaforey;74319299]I understand that completely.

I was attempting to use the MagiskManager apk and upload a stock boot.img, have it patch it, and apply that patched boot.img in fastboot. In this case, TWRP is not used at all.

I got it working eventually without TWRP, so that's pretty cool.[/QUOTE]

Does MagiskManager 5.4.0 fastboot the patched boot.img?

QUOTE=skaforey;74319558]No you must do it manually[/QUOTE]

With Flashfire, TWRP or gremlins? How did you do it manually?

:):):) Time to catch up on my sleep, I'm asking dumba$$ questions.

Awake! So the original question pertained to a Pixel 2/Pixel 2 XL :eek: That, ladies and gentlemen, is the reason I haven't made the leap to Pixel 2/Pixel 2 XL. ;)

One more Checkmark in the 'do not buy' Pixel 2/Pixel 2 XL.
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] Scottay5150:
Uninstall zip failed magisk uninstaller error 1.

On pXL: New issue: install zip failed magisk uninstaller error 1. How to fix? I am searching cannot find the answer. I have flashed per the instructions on this page. I have flashed 8.0 already and wanting to flash Magisk, ElementalX. I used Magisk on Nougat previously, hence the uninstaller. Ideas?
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] lobrau:
I tried using V14.2, and installed the APK bundled but it doesn't give me the option to patch boot image. It only allows me to update to manager V5.4.0. I also tried using V14.3 to patch a boot.img which it says that it does. I flashed this patched_boot.img in fastboot but after a reboot it doesn't appear to be installed.

Any extra info would be really helpful, thanks
[Google Pixel XL ROMs, Kernels, Recoveries, & Other] HACK3DANDR0ID:
Is there an easy way to switch from SuperSU to Magisk?