yashsingh1/xdaforums huggingface dataset:
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] 56789:
I'm seeing the same thing with the main camera on T-Mobile H918 on the latest ROM (and also the one before that and also the official lineageOS before that). I actually mentioned it here because I couldn't use the white balance setting to try and make it better.

It seems to be the worst under my 2700K LED warm light bulbs at home and significantly better (still not great) under my bright white 5000K bulbs in my bathroom. Looks pretty OK in natural sunlight.

Two attachments are the same picture taken with the stock LG ROM camera and with the lineageOS camera in the same lighting conditions.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Dr_DjEnder:
same here but when I try to manually set white balance, camera view finder goes black and the pictures if taken are also black

Edit Google camera also already reported but worth while mention it's happening on us996 model

other edit try to set manual white balance on open camera the view finder also goes black
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
Yes, known issue with white balance, see post #3. Doesn't mean it won't be fixed, but it is a known issue.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] pjames:
I changed roms and camera works like it's supposed to. Its something in the lineage rom that's causing the camera is. I don't think it's a setting due to it happening in any app that uses the camera.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] 56789:
I think it's more of a system level setting. I had started looking through files relating to the camera sensor profiles a few weeks ago, but didn't really get anywhere. I might revisit over the holidays if I have some time.

I wouldn't mind learning more and contributing something to the project.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
I've looked too. If you do find anything, we can try to get it into UNOFFICIAL builds, then official ones.

I appreciate any help anyone is willing to give.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] philiptibbs:
I've run snap camera and all the modded gcams and Google cams and I can't get any cam to take good clear pictures. My cousins stock Note 5 takes better pictures than my phone. I've tried a ton of settings and it all works like crap on LS997 . I'm getting close to getting a different phone or reverting to 100% stock and updating to ZV9.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] D4rk9009:
Try footej camera

---------- Post added at 01:56 AM ---------- Previous post was at 01:54 AM ----------

Do u people like take **** pics all day.. God damn unless I see a UFO I don't care.. I substratum work and my keyboard blue on black..
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] cityneversleepz:
The modded gcam is doing a good job other than low light rear. Google photos fixes the tint to perfection though. Very clear also.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] philiptibbs:
Which version are you using and what settings ?
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] cityneversleepz:
I followed the steps in this thread:

https://xdaforums.com/redmi-note-4/themes/omnivision-pink-tint-google-camera-t3695936

The only thing I did was enable HDR; change to pixel XL original and support level override ZSL. indoors nighttime I'm using flash and then in Google photos I can find a good adjustment.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] AVIMPEG:
When the model h990 will return to Download
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] MrC11:
Never ask for ETA, but the question you may ask yourself: "Do I want to download a non booting lineageOS on my phone?" If your answer is yes, then you can ask the devs for the .zip.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] philiptibbs:
Thanks for the settings they work. Camera is still a little funny. I press the button and sometimes it takes a pic and sometimes it doesn't .
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] D4rk9009:
I use it just fine since second since first build
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] D4rk9009:
My camera works to.. Just focus not all 100% there in close up pics
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] TheIronMaiden:
Are you also going to be building lineageOS 15 ?
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] D4rk9009:
Does anyone know how to fix tether?? I tried with foxfi it actually turns on but I can't connect.. Anyone?
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] cityneversleepz:
If you're using Magisk look at the download modules.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] WhiteWidows:
Anyone else still experiencing choppy video playback and lagging in apps like Facebook, YouTube & Snapchat that affect over all system performance to where it requires a reboot?
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] NippleSauce:
I'm still getting poor performance in Snapchat (don't use Facebook so I can't comment on performance there), however, YouTube seems to work just fine.

I was also getting slightly choppy system performance, but flashing the updated graphics driver seems to have alleviated that issue on my H918.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
2.4g tether should work fine, I use it almost daily. I know there is an issue with the 5ghz one that is not working.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] shawamawa:
Please check your PM [MENTION=2881807]x86cpu[/MENTION]
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] d4rklabs:
Iguess its only on h990..couse I have to flash our kernel ontop..
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] d4rklabs:
U see it says error I can still get it ticturn on but when I try to connected it says. Resolving IP forever
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
Is this 2.4 hotspot? I see the same thing using 5...
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] d4rklabs:
Ye 2.4..

---------- Post added at 03:24 AM ---------- Previous post was at 03:23 AM ----------

Feels like my phone got so e hidden fire wall nothing can't connect

---------- Post added at 03:26 AM ---------- Previous post was at 03:24 AM ----------

I just got nexus 7 for 150 .. Damn its like so easy everything available..so many ROMs I don't know with one to flash foreal

---------- Post added at 03:27 AM ---------- Previous post was at 03:26 AM ----------

There's 3 spheres outside my window just inline I think they want my phones loll

---------- Post added at 03:31 AM ---------- Previous post was at 03:27 AM ----------

If. I send this guy. My back up I made couple days ago would another person be able to flash it,??he. Got h990 since u fixing it it .. I just want the to flash and have problems

---------- Post added at 03:38 AM ---------- Previous post was at 03:31 AM ----------

Omg I'm sorry for typing not all at ones x86 do u know this app in play store called ground zero? They got 3 open source ROMs ....gzm.validus..Tesla.and tipsy ..wait that 4..ha..anyways these ROMs are so nice u ever thought maybe. Leave this and. Port th em?? They like fixed a lot of things all oms...I sot everynite and trying to port a ROM but never works I ffeel like just swircgin files is kinda cheatin...I like that whole syncin repo etc... But god that confusing if I don't. Have a retallin
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
Hey [MENTION=2881807]x86cpu[/MENTION] I was digging further into possible performance enhancements and since our V20 is now (and has been for quite some time) using a EAS equipped Kernel I saw a bunch of logcat printouts that complained about interactive not being active etc in the perfd service.... so I figured out it could for sure be further optimized and started looking at Pixel-like blobs.

To make things simpler, a guy called Josh C already put these blobs nicely. in a GitHub so it seems like we might be better of by using the following perfd binaries extracted from Pixel Sailfish/Marlin:

https://github.com/EAS-Project/blobs

I personally think it helped tremendously, here it goes if you wanna try it first and see if there are no other anomalies.

Download: flashable-eas-perfd-update.zip

Edit: With sufficient testing I believe we might as well add it to the official repo? Btw I want to check the indoors auto white balance too on the camera but haven't had much time on it due to excessive work :(
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] WhiteWidows:
All is well on my ls997. This and the updated video driver had reduced lag considerably.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
Do you know what video driver you went to? Would you care to share (or did I miss it at one point?) Thanks...
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
I'll be looking at this hopefully today. I know it's been a while since I got a UNOFFICIAL out (real life busy), but hope to soon.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
So the perfd and libqti-perfd-client.so are already pulled from the marlin device. The libcutils.so and power.msm8996.so are built from the marlin source ( https://github.com/LineageOS/android_device_lge_msm8996-common/tree/cm-14.1/power )... So, in theory, there should not be able changes needed as it is already set this way. ( https://android.googlesource.com/device/google/marlin/+/android-7.1.2_r33/power/ )
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] mking007cn:
screen can't re-light after the phone-call

[MENTION=2881807]x86cpu[/MENTION]

bug reproting:

Hello

I am a Chinese, sorry for my pool English.

I use us996 and flash the lasted x86's unofficially rom(lineage-14.1-20171103_103442-UNOFFICIAL-us996). when start a phone call and hold the phone near to my ear, the screen will turn black. but when i move the phone off my ear, the phone screen is still black. i have touching the screen, use the volume key(i set the volume key to wake the screen), but no response to the screen . The only way to light up the screen is to use power key to lock the screen and then unlock it again, and by this way screen can light again. this problem have been lasting for about two weeks. last Sunday, i wipe the phone(cache, date and system) and re-flash the whole system, but the problem is still on.

the attachment is the logcat
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
Thank you, let me look at this from source perspective now. I know for a fact that there must be differences as the schedboost values change sometimes dynamically with the current binary in LineageOS vs Marlin prebuilt... Plus the extra logcat spamming with "interactive".

I wonder if it might need some extra CFLAG's or some other things to compile exactly like Pixel w EAS, let me look at it too and thanks for pointing out the sources.

Nevrrmind... I just found out that the version in LineageOS is using a weird Hybrid of source code after they did the " Revert". Look at the comments [MENTION=2199706]Alucard24[/MENTION] provided in:

https://github.com/LineageOS/androi...mmit/d9e7c6a55dce121a6eb48e0a7e2da1af405c8686

No wonder why I get the interactive warnings. Also looks like it is missing a lot of commits there.

In power/power.c, the schedboost value that caught my eye was "16" in the foreground apps... Which matches this commit using "0x10" instead of the Pixel value of "10" in new Android versions (was 50 long time ago). This is one of the reasons why I started investigating the perfd binary.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] WhiteWidows:
https://xdaforums.com/v20/development/mod-adreno-vulkan-drivers-snapdragon-t3681901
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] d4rklabs:
Wow I. Confused what's going on???

---------- Post added at 06:28 PM ---------- Previous post was at 06:18 PM ----------

How can I check wirhpneci got. Now and why is that op says its only for. One9 model
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] d4rklabs:
Yo my XDA brothers ...
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] d4rklabs:
Maybe course she got be reception at some point then gets it back and all ure msgs come thru..text somebody else
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
Hey [MENTION=2881807]x86cpu[/MENTION], I've got another potential goodie for you. Here are two big Kernel defconfig settings that impact power awareness in MSM8996 and thus the performance of our device (OnePlus3 and Marlin/Sailfish are using this in case you want to do some extra double checking). My test build feels way more fluid after using this and the perfd updates.

Here are the two parameters missing in the Kernel defconfig's for the V20:

CONFIG_APSS_CORE_EA=y
CONFIG_MSM_PERFORMANCE=y

And it will also need the following small change in include/linux/cpu.h to compile : https://github.com/oxavelar/V20-Kernel-Gamma/commit/630d6b5d6bd6d61aae4de993a164129443b6edc6
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Zenns:
I hope H990DS comes back and support LineageOS 14.1, I miss using it since my OP3T Died.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
And the last one for the week [MENTION=2881807]x86cpu[/MENTION], I've fixed the auto-white balance issues (and manual white balance) in V20 (only have tested this with us996) with this now finally we should also have natural looking photos (most noticeable indoors, due to the yellow tint that we were left with).

Left: Cloudy

Center: Fluorescent

Right: AWB Under a Warm Light Bulb

​

Flashable file : flashable-lge-v20-10l-camera-libs.zip

I have used the US996 10L version of the blobs and they seem to be performing excellent, nothing had to be done in the Kernel this time. If you could help me get those fixes upstream and/or investigate further :) that would be great!

As a side-note, seems like with these fixes it seems to focus faster too due to the lack of no background task in the camera daemon trying to auto-white balance when failing... neat ;)
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
Awesome... I will attempt to pull those out and recreate it with an unofficial (and testing) then get it into an official. I do appreciate the help and knowing a positive result.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
They are indeed missing, I see that. Since there is a large overlap, if testing does prove helpful this should not be an issue to get into the other msm8996 devices. What other "perfd" updates? The blob binary is already from the marlin device. Thank you!!
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] toastyp:
Flashed this zip on the latest official for the h910 variant. It has fixed the white balance issue! Camera is a lot less yellow and the tints no longer make the camera dark on the modded Google camera. Thanks for this!
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
Thanks [MENTION=2881807]x86cpu[/MENTION], for example look at all of Alucard24 feedback/comment in this last commit for our msm8996-common power folder in https://github.com/LineageOS/android_device_lge_msm8996-common/commit/d9e7c6a55dce121a6eb48e0a7e2da1af405c8686

After the sign-in in GitHub, you will see that Alucard24 posted about some enhancements that should still be done in some of the corresponding portion of perfd and it's libraries.

What I did personally was to compare that with Marlin latest sources were to double-check Alucard24's comments. So I compiled a local experimental perfd to test-out and did see a more stabler performance after but don't want to call these experiments final. That's also when I noticed the missing energy aware defconfig missing from a lot of our V20 variants too.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Zenns:
I know I should not be asking this but possible if you help H990DS we just can't boot at all :'( it will be such a waste tbh.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] UL7RA:
This ROM is for the H990, not the H990DS.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
How confident are we that the thermal engine is running in our V20 in LineageOS? I was doing some stress testing in order to find where the performance could be suffering and got myself 87`C on the CPU sensors... and no throttling occurred, To my surprise it just started disabling CPU cores when reaching those dangerous limits.... :(
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] toastyp:
Looking at the thermal section in kernel audiutor I see that there are 3 options but the only one enabled by default is core control. There's also a peg for thermal throttling and vdd restriction. So I'm assuming the cores turning off is due to core control being enabled by default
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
But in theory thermal-engine from user-space should have kicked in first and throttle the processor frequency depending on temperature. core control is the Kernel extreme of CPU offlining because we've reached a dangerous threshold. But I find it hard to get evidence that thermal-engine is kicking in..... mmmm :(

Edit: I am asking on this one, there might be a real reason this is behaving like it is... don't know how Marlin's thermal behaves, but at least LG's stock thermal-engine works like that. I even ended up replacing the thermal engine to use LG's stock on my personal phone for now...

Edit2: This is what it looks like with LG's stock thermal-engine:

logcat
:
:
:
D ThermalEngine: ACTION: CLUSTER - Setting CLUSTER[1] to voltage 980 freq = 1996800
D ThermalEngine: ACTION: CLUSTER - Setting CLUSTER[0] to voltage 955 freq = 1593600
D ThermalEngine: ACTION: CLUSTER - Setting CLUSTER[1] to voltage 1005 freq = 2073600
D ThermalEngine: ACTION: CLUSTER - Setting CLUSTER[0] to voltage 955 freq = 1593600
D ThermalEngine: ACTION: CLUSTER - Setting CLUSTER[1] to voltage 1025 freq = 2150400
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
I pulled your zip file, pulled the US99610l one. Compare what the V20 has, and tried just these 2 single files, which makes white balance work again:

vendor/lib/liblgae_main.so
vendor/lib/liblgawb_main.so

The *imx258* and *hi842* files are not even applicable for the v20 camera (g5/g6 maybe). I see the US99610l has it in there, but not sure why it needs it. I'm also trying the build with the two CONFIG_ performance options.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
How did you put back LG's? Just a binary, or other kernel options?
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
Awesome man, thanks for the extra investigation. As I am on work travel (and have been lately) so I don't have access to my home Linux environment where I typically prefer to do more extensive analysis! :)

Just the binary and 3 *.cfg files. Here they are if you want to check and also help investigate : flashable-lge-v20-thermal-engine-hotfix.zip

Looking at the commits for cm-14 tag, it looks like at some point in July the thermal engine and *.cfg's changed...
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
I stand corrected. Seems like these won't harm nor benefit. Rashed took them explicitly out during the EAS changes. Sorry for the confusion... But don't know why some devices still have it still tho, might be too early to tell if they're in fact needed

After more concrete benchmarks I don't ser benefit nor disadvantage tho... You might want to not want to add them next
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] iwlsko:
Isn't H990DS a variant of H990 such as H990T, H990N?

:confused:
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] wrigglevision:
There are clear differences evidenced by the fact that the H990DS did not work with the older H990 versions (can attest personally. It booted with the right kernel, but it had the hardest time recognizing my SIM).
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
You've steered the direction on alot of things with the camera, thanks. Now we need you to tackle the auto (or lack of) shutter speed issue. Reverting back part of the Snap camera may not be possible, but blobs and/or overlay code changes maybe if it works. Thanks!
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
White balanced should be fixed shortly with new builds. Blobs will be updated.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
What is the current status of H990DS? First step I would do is compile a AOSP that in theory works with H990DS and do a very close inspection on the defconfigs being generated... and flash it IN STOCK ROM via AnyKernel... so that it leaves all of the rest init*.rc intact. Once you guys get this booting up I don't think there should be much of difference to be made. This way you will know that it is the Kernel that prevents you to boot.

Btw, I have booted up using stock's zImage-dtb's from LG's overlayed on LineageOS without trouble (Expect the screen being shown with the top "2nd" screen). I could try and do this hybrid zImage-dtb for you based on HD990DS's stock boot.img so that you guys can try.

Once this is understood and it all points to the Kernel, then we keep investigating...

Do you guys see it "try to boot" but keep restarting on the LG Logo? Go black and restart? Or do you guys just get solid LG Logo?

But please give me a full history of where we're at with H990DS, and also links to a known working systemfull.zip or boot.img... :) I will see if I can help you guys out
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
It is being worked on and in process. It just needs more time for the kernel and boot process to be worked out. It has not been forgotten.

Progress:

https://review.lineageos.org/197392

https://review.lineageos.org/197393
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Zenns:
Thank You hope to see it soon :)
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] EvilHowl:
Hi [MENTION=2881807]x86cpu[/MENTION]

I'm one of the devs of LG G6. I've seen you are trying to fix the performance of our kernel. I've tried a lot of changes on the kernel and it didn't get better, but if you want I can try on G6 any of your fixes so we can work together.

I think G5, G6 and V20 devs should work together :)

I've also seen that Snap Camera isn't working properly for you. I fixed that using with this commit: https://github.com/EvilHowl/android...mmit/14368cd5478a8bba7fca0a1c1a4ba6894f7fd6cd
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
I can try that. If it works I can merge too. But need to see if that legacy is going away in 15, which might not matter much. Is there a gerrit commit yet?
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] EvilHowl:
Nope. Rashed switched to openLegacy breaking Snap Camera and I don't know why. I just reverted that commit and it worked.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
I have been scratching my head about what caused this massive performance feeling to go like this in a few months back. But can't find to hit the nail.

I even have a custom compiled Kernel that has a more similar defconfig to LG's but still no avail (using LineageOS sources). Plus I don't know if the lag comes from something in user-space or the Kernel...
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] x86cpu:
https://review.lineageos.org/198215

Tested ok. Was commented out due to not working, to begin with, which was inadvertently due to "fale" misspelling. But yes this fixes the auto-shutter speed in the LineageOS Camera.

And merged in.
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] D4rk9009:
How do u add hid to kernel to use usbwifi??
[LG V20 ROMs, Kernels, Recoveries, & Other Developm] Omar-Avelar:
Nice!! :) I am so glad we're starting to iron out some of the outstanding bugs of this amazingly good phones families ;)

I love my V20 :cool: