yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S 5 Unified Development] tomm1e:
As for rotation, in my case it seems to be the accelerometer freezing up from its rate being changed, I've opened a bug with information about it on JIRA, including a video of it:

https://jira.lineageos.org/projects/BUGBASH/issues/BUGBASH-1897

If anyone else wants to test this out on a device which they can easily reproduce the problem you can recompile your kernel with sensor debugging, just edit kernel/samsung/msm8974/drivers/sensorhub/stm/ssp.h and set SSP_DBG to 1, then comment out the 2 extra defines or it won't compile since they become defined twice, and set SSP_FUNC_DBG to 1. (I have not looked at logs with SSP_DATA_DBG yet, not sure how much data that will push out)

So the top of the file should look like:

#define SSP_DBG	1
#define SSP_FUNC_DBG 1
#define SSP_DATA_DBG 0
....
#if SSP_DBG
// #define SSP_FUNC_DBG 1
// #define SSP_DATA_DBG 0

Then flash new boot.img through TWRP. Now boot up and start a sensors app with accelerometer reading, watch for new sensorhub messages with "adb logcat -b kernel | grep SSP".
[Samsung Galaxy S 5 Unified Development] iscariot:
Hi friends,

Thank you very much for your effort working with our old device to get this update.

I've just noticed that you mentioned to be an official release "soon". I was wondering if the bugs detailed on the first page are finally solved (so the information is not updated?)

In particular, it was supposed to not be working:

GPS

Sound record

A lot of stuff

Thank you very much.
[Samsung Galaxy S 5 Unified Development] Gargoyles:
Yes, the information is not updated. The rom is stable enough to be used as a daily driver.
[Samsung Galaxy S 5 Unified Development] runeupo:
Perhaps a workaround for the rotation issue for some;

https://play.google.com/store/apps/details?id=org.crape.rotationcontrol
[Samsung Galaxy S 5 Unified Development] twogruff:
Amazing rom

This ROM is great much the best I tried. Camera, GPS and rotation all work great on international version. Everything just works. Thank you.
[Samsung Galaxy S 5 Unified Development] Brunowp8:
A "fix" for the screen rotation is to disable the location

If you have problems with the screen rotation try this

Just turn off the location and try to use the screen rotation, it may not work immediately, but after 1 or 2 minutes it will work without problems
[Samsung Galaxy S 5 Unified Development] yoahmad1995:
I have my location set on "device only" mode and rotation never failed me so far on AEX
[Samsung Galaxy S 5 Unified Development] fitittome:
An excellent example of how to explain, demonstrate and properly log a device specific problem. Gold star. :good:

Edit: I notice that there's a much later baseband for your device btw. Worth investigating but I think G900PVPS3CQB3 is the latest, but not my device.
[Samsung Galaxy S 5 Unified Development] tomm1e:
Edit: Well, unfortunately it did not fix the issue, I have had location disabled and it is occurring again. Disabling location just seems to prevent it from happening as much. It appears to be related to package "avpq"

21:29:57 - 0x00000000 pid=12859 uid=10018 package=avpq

21:29:54 + 0x00000000 pid=12859 uid=10018 package=avpq samplingPeriod=20000us batchingPeriod=0us

The accelerometer rate lowers once this package registers, and goes back to normal when the registration is removed.
[Samsung Galaxy S 5 Unified Development] iscariot:
Thank you very much. Very good new and congratulations to all the team working on this release. You're great!! :D
[Samsung Galaxy S 5 Unified Development] S5Do:
Slow motion don't work?
[Samsung Galaxy S 5 Unified Development] knaik95:
So is there a commit to revert to while building that will fix auto-rotate not working?
[Samsung Galaxy S 5 Unified Development] yoahmad1995:
I also have exynos variant of the s5 and on nougat ROM's auto rotation isn't a problem there.

Guess files from there can work on klte since the difference is the processor only?
[Samsung Galaxy S 5 Unified Development] tomm1e:
Update on rotation issue for kltedv, seems like the problem is with package avmq, part of com.google.android.gms.persistent, looking at dumpsys sensorservice:

21:30:59 + 0x00000000 pid= 1341 uid=10018 package=avpq samplingPeriod=20000us batchingPeriod=0us
21:30:59 + 0x00000000 pid= 1341 uid=10018 package=avmq samplingPeriod=20000us batchingPeriod=-1us

avpq seems to be the one causing accelerometer rates to change, and it freezes when avmq doesn't disconnect.

Disabling location, and then killing the process makes the accelerometer start working again.

kill `pidof com.google.android.gms.persistent`

Though it will just freeze up again once you enable location.
[Samsung Galaxy S 5 Unified Development] MarvinMod:
just so you all know, im on the latest klte 15.1 g900t and im not having any issue with auto rotation. the only issue im having is car Bluetooth wont connect properly till after a few reboots.
[Samsung Galaxy S 5 Unified Development] fitittome:
klte rotation issues

Mainly because of the effort [MENTION=7500155]socialentry[/MENTION] put into reproducing and documenting a rotation issue on the SM-G900P here https://jira.lineageos.org/browse/BUGBASH-1897 I thought I would thoroughly test the sensors on one of my SM-G900F's where the gyros actually work (two of the five I own have failed at a hardware level, they're showing their age.)

Model: SM-G900F

Baseband: G900FXXU1CQK3 (latest from Samsung)

Bootloader: G900FXXU1CRA2 (latest from Samsung)

Unofficial 15.1 klte: 14JUN

Gapps: Not installed

Settings: Location On/High Accuracy

Sensor Test Program: asd.vector.sensor

Set-up

Ensure Screen rotation is enabled.

Check screen rotation.

Check asd.vector.sensor: All sensors functional.

Leave asd.vector.sensor at Significant motion screen.

Testing

Leave phone enter deep sleep (15 mins).

Wake phone and unlock.

Shake phone until Significant Motion detector fires.

Check screen rotation.

Repeat - 6 times

So over a few hours, using this procedure, I couldn't get the device to fail. Without a reliable way of reproducing the fault, I can only conclude that it is either related to older firmware or specific to the G900P.
[Samsung Galaxy S 5 Unified Development] The~Skater~187:
I'm on the 900P and latest firmware for it and can honestly say I haven't had rotation issues on any of the Oreo roms I've tried.
[Samsung Galaxy S 5 Unified Development] tomm1e:
Can you try with open gapps 8.1 installed? It seems to be caused by packages avmq/avpq from com.android.google.gms.persistent included in gapps.

Steps to reproduce:

Install Gapps 8.1

Rotation: Auto

Location: High Accuracy (does not seem to occur as much on battery saving or device only)

Running google apps that request Location, such as Google Maps

Phone has been idling for a while (~15 minutes, not always necessary but the problem gets worse the longer the phone has been on/idle)

Pick it up with the sensors app opened with Accelerometer in view, and try shaking it or even just moving it as if you were calibrating the compass, watching the accelerometer values/rate. If you do see the update rate changing or the accelerometer stops responding, save the output of "adb shell dumpsys sensorservice"

Also I flashed my baseband to the latest (Thanks for letting me know :good:) but it still occurs.
[Samsung Galaxy S 5 Unified Development] Raynelfss:
Video stabilization doesn't seem to work in snap camera... Seems to be disabled or yet not added to the app itself, but the option is still there.

Is it like a teaser or something unfinished?
[Samsung Galaxy S 5 Unified Development] fitittome:
Well, that wasn't mentioned in the Jira and its a significant system modification. Anyway, I have been testing klte without Gapps since the New Year. The objective being to ensure the core system is stable and reliable.

Anyway, I have repeated the process with Gapps Pico installed along with Google Maps in background and a GPS lock. I couldn't make rotation fail.

I did notice however, that the Accelerometer readings do start 'racing' (in the hundredths and less values). I did a hard reset but the behaviour was the same. Reinstalled minus Gapps and also the same. The sad thing is that I didn't look for and/or maybe failed to notice this during the original test.

Look, I've given this my best shot, but I feel like I'm chasing a ghost. I sincerely believe that we need to get some process or procedure to reliably make rotation fail, then there maybe half a chance of finding a fix. If indeed it's not a dodgy sensor that is on its way to failing anyway.
[Samsung Galaxy S 5 Unified Development] cal002:
See also https://jira.lineageos.org/browse/BUGBASH-1127, which was closed because no one followed up. Thanks to you for finally digging into it to provide some factual data.

Batching in accel sensor firmware is broken and causes the sensor to stop working. We found that >1 year ago, the workaround was to change framework not to request batching in WindowOrientationListener. https://review.lineageos.org/#/c/LineageOS/android_frameworks_base/+/156735/

When screen is off or auto rotate disabled some other app could still cause accel sensor batching to be enabled -> boom. And it seems the trigger is gapps.

The proof from your kernel-sensor-debug12-sensorservice.log:

Sensor Device:
Total 16 h/w sensors, 16 running:
0x00000000) active-count = 3; sampling_period(ms) = {20.0, 66.7, 200.0}, selected = 20.00 ms; batching_period(ms) = {2147483.8, 0.0, 0.0}, selected = 66.67 ms
Sensor List:
0000000000) MPU6500 Acceleration Sensor | Invensense | ver: 1 | type: android.sensor.accelerometer(1) | perm: n/a | flags: 0x00000000
continuous | minRate=5.00Hz | maxRate=200.00Hz | FIFO (max,reserved) = (150, 150) events | non-wakeUp |
0

(not sure about the batchingPeriod=-1us but it seems to be interpreted as MAX_INT = 0x7fffffff = 2147483647)

Maybe a better workaround might be to ignore the batching period for the accel in the SSP kernel driver.
[Samsung Galaxy S 5 Unified Development] fitittome:
cal002, you don't make many posts, but the ones you do make are worth it! :good: https://source.android.com/devices/sensors/batching the trade off will be battery drain, I assume. I guess its possible that those 'racing' sensors maybe indicating that batching is not working properly anyway....
[Samsung Galaxy S 5 Unified Development] S5Do:
Hi I can't install google camera 4.2 or later (arm) how can I install a recent version of gcamera (until 4.4 no later)
[Samsung Galaxy S 5 Unified Development] tomm1e:
I've been making mods to the camera lib and 60fps is working :good:

New thread for camera mod:

https://xdaforums.com/galaxy-s5/unified-development/mod-15-1-camera-supporting-60fps-120fps-t3809145
[Samsung Galaxy S 5 Unified Development] yoahmad1995:
For me (G900F) the only Oreo ROM that has rotation works without stopping work after a few hours is AOSPExtended.

Maybe they have some stuff implemented that aren't implemented yet in other Oreo ROM's.
[Samsung Galaxy S 5 Unified Development] Brunowp8:
A little bird told me that we will have official 15.1 soon

https://review.lineageos.org/#/c/LineageOS/hudson/+/218680/

https://review.lineageos.org/#/c/LineageOS/lineage_wiki/+/218681/
[Samsung Galaxy S 5 Unified Development] Paul_Lunardi:
Yay that's great news I may have to install it soon.
[Samsung Galaxy S 5 Unified Development] abdullah0347:
where could I install latest version?
[Samsung Galaxy S 5 Unified Development] fitittome:
https://androidfilehost.com/?w=files&flid=237838 but remember you will have to clean install when it goes live, which will be in a week or two if all goes well.
[Samsung Galaxy S 5 Unified Development] systemcrash:
OK awesome. So after this weekend (first new 15.1 builds land next week) it arrives.

Although we definitely have some quirky stuff happening with rotation. I take photos in landscape orientation, they sometimes insist that they're portrait orientation pictures because the rotation sensor is 'stuck' occasionally. Not the end of the world. I read earlier here that you heroes have tracked down some potential weirdness in the sensors.

My device is G900F. Radio info in my signature.
[Samsung Galaxy S 5 Unified Development] fitittome:
Gapps?
[Samsung Galaxy S 5 Unified Development] systemcrash:
Yeah, the usual homie. The last one I installed was:

open_gapps-arm-8.1-nano-20180506
[Samsung Galaxy S 5 Unified Development] omgbossis21:
T-Mobile variant here with gapps pico installed and very screwy rotation.
[Samsung Galaxy S 5 Unified Development] yoahmad1995:
Disable location and give it a minute or two.

Or flash AOSPExteneded. Never had rotation bug on it.

I'm sure a fix is coming very soon!
[Samsung Galaxy S 5 Unified Development] systemcrash:
For you who have screwy rotation: does it work for you to simply disable and then enable autorotation? Pull down and hit the auto-rotate tile - near wifi mobile data etc..
[Samsung Galaxy S 5 Unified Development] omgbossis21:
Doesn't seem to help, neither does location off for me. I have a next to release date gen phone though that has the "green screen" of death during lowest display brightness so I'm not ruling out the sensor. However I had no issues on 14.1 ever, all began after 15.1
[Samsung Galaxy S 5 Unified Development] swiftbones74:
I'm gonna say your your phone is a good place to install it ;)
[Samsung Galaxy S 5 Unified Development] :
Does camera in the Whatsapp work properly? I got static and broken image when wanting to take a photo or videochat in whatsapp. Did all clean installs
[Samsung Galaxy S 5 Unified Development] omgbossis21:
Been trying to get my ubuntu build back up & running now that i've added another ssd drive so I figured I'd share :

New build 6-26-18

Pure vanilla, No clue on the changes (see changelog) just wanted to make sure my build environment was ready to go.

Your own your own installing this rom, if your car blows up from installing I am not responsible.... Not responsible for anything, any of your decisions =-)

Thanks to Haggertk & the LineageOS crew for doing an amazing job, this is strictly a build on their work with nothing added!

https://www.androidfilehost.com/?w=files&flid=53758
[Samsung Galaxy S 5 Unified Development] jeremywh7:
Ok I'll bite...booted it; rotation (and back) is working in one test. Will see if it continues to work... thanks man.

Update: ok I tried a couple more times; it rotates landscape, but then doesn't rotate back to portrait. So pretty much intermittent as before. :-/
[Samsung Galaxy S 5 Unified Development] yoahmad1995:
Disable location if you have flashed GApps.
[Samsung Galaxy S 5 Unified Development] omgbossis21:
Not sure if their were any rotation changes, maybe some to cherry pick and test? I'll check when I'm home...
[Samsung Galaxy S 5 Unified Development] brainycaleb:
Everything works great for me, as my Daily Driver.

I'm only experiencing few problems like

1. The amount of time my G900F takes to boot, is discouraging. It takes approximately 80seconds after clicking the power button for the boot image to display before the LineageOS boot animation which displays 9-10 times before my Homescreen.

2. When my device goes into deep sleep, sometime it fails to wake up immediately, only after a few seconds.

3. Sometimes my battery runs down dead when idle. No apps running though.

4. Offline Charging does not display battery percentage and charging led light.

Otherwise great rom but boot time for the first 8.1.0 build was less than 15seconds from boot image to Homescreen.

***Please tell me if these had already been fixed***.
[Samsung Galaxy S 5 Unified Development] Paul_Lunardi:
Some of these issues sound discouraging. What version are you using? When did you install it? Was it a clean install?
[Samsung Galaxy S 5 Unified Development] fitittome:
1) I think this is par for the course with a device that cannot do hardware encryption. I've been testing the device with 15.1 and it is pretty reliable approx 80 days between reboot on a vanilla device with no gapps as a daily driver. So reboot times are not really important to most. VPN firewalls seem to trash that figure though. :(

2) That will be a memory issue. I don't see it often. FWIW I did try one of the replacement kernels for klte a few weeks back and it was worse! There was an upgraded version the other day and things seem much better for them, but these things are always a trade off and often cause more trouble than they are worth. Personally, I think you will find it is a buggy app causing that problem, Firefox and Facebook seem to be the main culprits.

3) Never seen that in months of testing, maybe that buggy app again.....

4) Not really a problem is it? It's just how it is. ;)

With regard boot time on the first release. It will be about 15 seconds as you had to reformat and remove encryption. That's the boot time for an unencrypted device!

Personally, I think it's good to go, my only reservation is the rotation issue when Gapps is installed. Nobody has come up with a simple and reliable way to reproduce that problem so I doubt it will be an easy fix. I've tried and failed. :(
[Samsung Galaxy S 5 Unified Development] :
https://review.lineageos.org/#/c/LineageOS/hudson/+/218680/ [MENTION=2693412]haggertk[/MENTION] just updated this change, and wrote "Done" in the history section

Oh boy, does this really really means that next friday its Oreo day? Super excited
[Samsung Galaxy S 5 Unified Development] fitittome:
No, 2=Tuesday. ;)
[Samsung Galaxy S 5 Unified Development] :
Tuesday?? Holy crap, I cant wait to try the official version. So long Nougat, you served us well. Helloo Oreo cookies. Gotta buy more milk for tuesday :D:D:D
[Samsung Galaxy S 5 Unified Development] Ranniel:
everyone is excited by the official update but what will be the difference with the unofficial one without counting the ota updates?
[Samsung Galaxy S 5 Unified Development] swiftbones74:
Its a big milestone. Samsung at&t Verizon T-Mobile (and most of the planet) stopped caring for this phone, but not us and not [MENTION=4770483]afaneh92[/MENTION] and definitely not @ [MENTION=2693412]haggertk[/MENTION] from [MENTION=7967832]lineageos[/MENTION] ! The s5 is still a great phone and deserves to keep progressing. Its mostly going to be the same except I hear with official Oreo we will all get Volte now.... :silly:
[Samsung Galaxy S 5 Unified Development] marlencrabapple:
I'm waiting on RCS UP myself. T-Mobile just activated via an update for two devices. Hopefully we can get it too eventually.
[Samsung Galaxy S 5 Unified Development] J-Lindo:
Wait WHAT
[Samsung Galaxy S 5 Unified Development] sunilpaulmathew:
Ha ha ha... Trolling ... :p
[Samsung Galaxy S 5 Unified Development] J-Lindo:
*sigh* I knew it sounded too good to be true.

[MENTION=8135223]swiftbones74[/MENTION] Don't make a poor guy's heart skip a beat, man ?
[Samsung Galaxy S 5 Unified Development] Bosket:
Liar !!! :p:D

And I like joke's too !:laugh:
[Samsung Galaxy S 5 Unified Development] swiftbones74:
HA! You got me brother. Can't get one past you :cool: :silly::p
[Samsung Galaxy S 5 Unified Development] runeupo:
Hello all, I have been reading here with you and also about rotation issue. Myself I don't have a klte s900f, but a friend has and I installed this los15.1 rom for him a while ago, many thanks to [MENTION=2693412]haggertk[/MENTION] for his continuous support.

My friend doesn't seem to experience the rotation issue, although I should add that he never talks about his phone when we meet and I've only asked a few times and basically he is very , very happy with his s5 nowadays, coming from stuttering marshmallow touchwiz.

Anyway, back to the rotation issue. Myself I have a Xiaomi redmi note 4x 3Gb variant, called 'mido' and in the los 15.1 development there was an interesting post, stating that rotation issue seems to be an Oreo 8.1 issue. And referring to a workaround.

I hope it helps.

https://xdaforums.com/redmi-note-4/...ment/rom-lineageos-15-0-t3690465/post76924041
[Samsung Galaxy S 5 Unified Development] Drhedphuk:
I have tried everything and I can't get the permissions to set. I only have this issue using Lineage. Is there more that needs to be done other that just pressing ok? When I press okay nothing happens, don't get taken to another screen or another pop up doesn't appear. Every other ROM just says allow. I would appreciate any help. I thank you in advance.
[Samsung Galaxy S 5 Unified Development] :
What version are you using? Could you try another SD card, just to be sure? I have never experienced any issues with the SD cards on Lineage OS. Try with another app, maybe ZArchiver, it always asks to set up the SD card. Hope it helps
[Samsung Galaxy S 5 Unified Development] Drhedphuk:
Thank you very much for your reply, unfortunately Zarchiver didn't work either. It said 'Failed to access request to SD card'

I have tried 3 SD cards and 5 (6 now ?) different file managers. I wiped and flashed 4 other ROMs with no problem gaining permissions. It only happens in this ROM & Mokee. It's definitely a head scratcher. Thank you once again for your help. I will give thanks tomorrow, I've gone over my daily limit for today. ?
[Samsung Galaxy S 5 Unified Development] The~Skater~187:
What are you using for a root method, Magisk?
[Samsung Galaxy S 5 Unified Development] KazuDante:
[MENTION=2693412]haggertk[/MENTION] I dont know if this issue has been addressed b4 but howcome the S5 cannot see yet even connect to 5Ghz channels 36-48 ? is that a hardware issue or is that dfs limitations?
[Samsung Galaxy S 5 Unified Development] Drhedphuk:
Yes. 16.4
[Samsung Galaxy S 5 Unified Development] The~Skater~187:
Have you tried the module for Magisk to enable writing to sd on nougat and Oreo?
[Samsung Galaxy S 5 Unified Development] systemcrash:
Just your phone. S5 cannot connect to 5GHz channels higher than 112. Mine works fine on channels 36-48.
[Samsung Galaxy S 5 Unified Development] KazuDante:
ok so its def my phone because mine only connects on 5ghz at channel 149 -153-157 and 161 on my Linksys E3500 N750

so this is def a dfs restriction to each variants...just checking what variant is your S5 ?

!!!!!!Update !!!! did some quick research and I fixed it , its a country code restriction that was causing me this issue changed it to AR instead of ALL and now its working on channel 48..... not sure why they put ALL for the ccode since each code are only 2 characters and not 3.
[Samsung Galaxy S 5 Unified Development] The~Skater~187:
What file did you edit for these changes?
[Samsung Galaxy S 5 Unified Development] KazuDante:
It coonected briefly after a reboot but then drops it .

The file i edited is /system/vendor/etc/wifi/nvram_net.txt and nvram_mfg.txt

but my guess is that those files are just ouputed files but that would not explain how after changing the ccode it actually connected to chan 36 which it never did b4

p.s ccode=00 is for world , even tried that and still connected but dropped it after a few minutes .

even typi g this message right now its still connected to chan 36 .
[Samsung Galaxy S 5 Unified Development] fitittome:
I think editing that file is pointless. The device works out the country automatically. My somewhat limited understanding is that the device is constantly getting location 'hints'. The RIL is important as it uses data from your mobile operator and also location services is used. I think this may explain why it stops working after a while. I am certain the S5 supports all bands.

I guess that there must be a table in LineageOS, generally, that maps the country to the permitted wi-fi bands. This would be an important database. AR is Argentina, right? So, again a guess, it maybe that there are only a limited number of users in your position.

So, it's a matter if tracking down the file...... there's a possibility it maybe wrong.
[Samsung Galaxy S 5 Unified Development] Drhedphuk:
I haven't no, I'll check that out, thank you for the top tip. I will wait until Tuesday now for the official release. It is odd that it only happens on Lineage & Mokee though. Would bootloader cause this issue?
[Samsung Galaxy S 5 Unified Development] runeupo:
Can't remember where but have read that formatting the sd-card under windows can help. Of course not everybody's got windows.