yashsingh1/xdaforums huggingface dataset:
[Magisk] TheJoker71:
hi smali... it is confirmed on Poco F1... with Global Beta firmware... if you update weekly... you need to update the smali patcher again... or else you will get bootloop...

another one question [MENTION=1620550]fOmey[/MENTION]... if i uninstall the smali patcher inside magisk... this will replace or return to the original state? thanks...
[Magisk] fOmey:
Yes it will return to original state.
[Magisk] Ilzknoxvile:
[HELP] Patch Smali

Hellooo,

I`ve ever patched smali for my Samsung device before and it`s cool, I did it.

But now I dunno whats wrong, it says Error (ERROR Magisk template download failed), my connection, java, etc is good.

Would you guys help me patch it?

I attached service.jar here.

Thank you.

drive[DOT]google[DOT]com/file/d/1T7GdaWql5TKjASSRk4TW3-EAFhErD0TQ/view?usp=drivesdk

---------- Post added at 12:26 PM ---------- Previous post was at 12:22 PM ----------

Hi bro, would you help me to patch please?

I really need it.

This is my service.jar

drive[DOT]google[DOT]com/file/d/1T7GdaWql5TKjASSRk4TW3-EAFhErD0TQ/view?usp=drivesdk
[Magisk] @ayahfachri:
This is your module with all 4 patch options ticked, flash it via TWRP or direct from Magisk Manager. Cheers.
[Magisk] ~brunozvn:
can someone help me?

!!! ERROR: Target JAR must be deodexed.
[Magisk] bustyouup4free:
Ok, so I'm using 4.0 and found everything working fine. but maybe 1 or 2 times a day system ui crashes and I have to force reboot. other than that it's fine... is this still a issue on newest version. I'm on Exynos Note 9 f/ds
[Magisk] Ilzknoxvile:
Thank you very much!

Ok Im going to try it
[Magisk] risoobeon:
I'm on the newest patcher 4.2 and I still get system crashes, I think its been mentioned before that it's a problem with deodexing and can't be fixed. Mine works but with some slow downs occasionally and the ui crashes, I found if you click wait and not close it will continue fine. I'm on Exynos Note 9 F too.
[Magisk] CyborgAlex:
I've been trying to install smali patcher for the last two hours, but I can't deodex my services.jar. Anyone could help me? I'm running Android 9 Benzo Rom on a pixel xl

Here is my services.jar

sendDOTfirefoxDOTcom/download/611f36416b/#oyjaokWF30XhXn9CC92Jxg
[Magisk] JimZiii:
i could really use some help. i really don't understand all of this, i'm just here because i need secure flag patched which i no longer can do with xposed and still have magisk bypass safetynet.

after a lot of searching and finally finding smali/baksmali.jar files since they're not on github, i think i figured out the process, i copied the framework folder, deodexed it with fulmics, took the services.jar and patched it.

but i really don't understand everything. if i've missed anything or if it'll work on my honor 8 (frd-l09 B394) running nougat. i'm also wondering

when i wipe my phone, since i used my current services.jar, do i have to do it all again with the services.jar i get after wiping my phone or can i use the same file as long as its the same android version?

i don't know a lot about signature verification but if these patches are installed as magisk modules that i'm able to activate/deactivate whenever i need them, wouldn't it be better if i did the process three times with each option separately? that way i can activate/deactivate them separately. and does anyone know if this actually works?
[Magisk] fOmey:
I linked to smali/baksmali in the original post.. :confused:

You should be using a services.jar for the rom your currently using.. if you update android versions you need to re-patch.

If you wipe your phone, although remain on the same android version and same rom you dont need to re-patch... however if you change roms entirely created by a different developer I would highly recommend re-patching with smali patcher as different roms include different mods, better be safe than sorry.

As this is a magisk module, yes.. you can enable/disable smali patcher in magisk manager.
[Magisk] qood:
To get around using mock locations, I tried installing your GPS faker app as a system app using Lucky Patcher, and the app then disappeared from my phone after a required reboot. Any idea why?
[Magisk] xanthrax:
You won`t get any support for Lucky patcher issues, this application it is considered warez on XDA and according to forum rules
[Magisk] the_sider:
Use AppSystemizer from Magisk ;)
[Magisk] Hallerinho82:
Has someone an idea to avoid the rubberbanding with the gps spoofer 0.2, patched services.jar and fused loacations enabled?

Edit: Good old tinfoil makes a good job
[Magisk] JimZiii:
Yes but you linked to the github and I couldn't find any .jar files on there at all.

With the magisk modules I asked if it works if I run smali patcher on each option separately. First on only secure flag, then only on signature verification and that way get the option to activate/deactivate them separately in magisk.

Would that work?
[Magisk] fOmey:
I linked to bitbucket directory where the .jar files are..

No because the module names would be identical.. perhaps something I may consider adding in the future.
[Magisk] FreeTheWeb:
Is this working on msgisk 14 and nougat s7
[Magisk] adhd_1977:
Yes it does.. :svetius:
[Magisk] sheraro:
working great on xperia Z5 compact 7.1.1 stock rom and Magisk 14, I flashed the zip trough recovery (not inside magisk)

info : you can extract only framework folder from your rom and paste it in a blank system folder, fulmics deodexer 1.6 will detect that there's only the framework to patch, you can then use the deodexed services.jar in SmaliPatcher
[Magisk] fOmey:
Ill add this to the OP.
[Magisk] Mensarius:
I have the prereqs installed and I'm running Nougat on an OP3T.

When I open Smali Patcher, I get a message saying "binary download complete," however what I get is an EMPTY bin folder; is that normal? My services.jar is deodexed however when I click "patch jar" in Smali Patcher, NOTHING happens; the program says "Idle...."

Thx for the help.
[Magisk] mrceli:
can u add a feature to input coordinate to gps app? ? thanks
[Magisk] sheraro:
you can use Fake GPS Location - floater, it works well (check spoof gps in options)
[Magisk] Rush94:
Is there any way left where i can spoof location on non rooted non unlocked device (device is just out of the box)

I know it's not possible just wanted to Know is there any new app or method which could do that ?
[Magisk] fOmey:
Run as administrator.

I've actually got a entire pokemon sniper coded up on my personal private spoofer.. just don't have a reliable pokemon coordinate feed to use.

If I get time I might update it and release, I doubt it tho.. barely have the time to play pokemon go now a days.

There are plenty of alternative spoofers available.
[Magisk] Mensarius:
I've ran the program as an administrator but it still doesn't work.
[Magisk] mrceli:
the most well-known alternative ones have been black listed by "Go maker" ? but if u want to share ur private spoof with that feature (no public release), DM me the app, will use it personally. thank u. ?
[Magisk] fOmey:
Whitelist in antivirus.
[Magisk] bustyouup4free:
ok thanks, on another note I'm also on s7 and s8 and I haven't had a single crash there. only on my N9
[Magisk] risoobeon:
I have an S8 plus too, and that also has no crashes at all! Its completely stock and not rooted either. Very strange.
[Magisk] WANTES:
[MENTION=1620550]fOmey[/MENTION] Dear developer?I have 1+ 6t when I create a module for magisk, it works, but if I try to unpack it into the system, and use the method without magisk, I do not work the smali patch method, why? how to fix it? I don't want to use magisk, but I want to use smali patcher. please help me with this. Android 9.0.1

https://drive.google.com/file/d/1yioY1UClWRw-32Z-nB7pftBHs8xfVw_N/view?usp=sharing - My Module MAGISK

https://drive.google.com/open?id=1eICcQ4kj4hk0nKAemrgadoBUDfQDQTjI - Service.jar
[Magisk] Lvitza:
Hello, everyone.

Thank [MENTION=1620550]fOmey[/MENTION] for your hard work.

OnePlus 6t, Android version 9.0.1, without the use of Magisk, make the necessary replacement files from the unpacked module zip via TWRP. But this method does not work on this device.

The oneplus 6t internal folder structure is not system/framework, but system/system/framework. How to make Smali Patcher work without using the zip module, and use the method of file transfer via TWRP.

Thank you for any help.
[Magisk] jamesoh:
All is working great for me on this.

I have a question about re-enabling real GPS. How is it done?

I've tried removing the module and rebooting, however the real GPS was still not working.
[Magisk] jaka45:
Dear fomey please read my pm...
[Magisk] marquesp:
Hi, has anyone tried to patch Alexis Rom 7.4.3?

It's directory structure is not standard and it's time to deodex seems exaggerated (3h+ on services.odex when I quit)? Thanks.

Just managed to patch Alexis Rom 7.4.3 with patcher 0.42 without deodexing on a S8+. Everything 's working fine.
[Magisk] ngpfig:
SmaliPatcherModule Wanted ..

Hi,

I am able to generate the SmaliPatcherModule for Xiaomi Redmi 5 Plus on Android 7.1.2 after following the instruction found here, but not for Galaxy A5 2017 (SM-A520F) on Android 6.0.1

The below are errors hit while selecting every option to generate the module for Galaxy A5 2017

ERROR: Mock location class not found

ERROR: Secure flag class not found

ERROR: Signature verification class not found

ERROR: Signature spoof class not found

Please advise if I am missing anything and do refer to the below services.jar file for troubleshooting/assistance:

drive[Dot]google[Dot]com/open?id=1tA223Xa65EKuLlBNpoiCEkQvI9YPosVq

Any helps is appreciated and thanks in advance! :)
[Magisk] TicoLobato:
Error

Hi guys, im getting the error : "!!! ERROR: Magisk module template download failed."

I already checked my internet connection and is ok.

Otherwise can someone patch for me? Here is my services.jar

drive.google.com/file/d/1mB-yBeBqqVglr1q9u31LscUiocDnQRwd/view?usp=sharing
[Magisk] wurstherpes:
https://drive.google.com/open?id=1-U-5u-NlQkrFZGDIz05h7u_1gMvg-LrV

https://drive.google.com/open?id=1836qF0UntCVQuntLQwDCgteKx2d41Be2

0.0.4.1 + 0.0.4.2 and all 4 Option.
[Magisk] dheervijay55:
Does any one have deodexed services.jar for redmi note 4 and will it work all redmi note 4 Mido 10.2.3.0 phones for making magisk module for disable flag secure
[Magisk] Amineka00:
Thank you so much, i had the same rom as you. i updated miui eu and lost smali. i wonder if you can provide flashable magisk of last miui eu 9.3.14 since i don't have access to a windows comp. Or maybe someone can help me and create the module using my service.jar. Thank you and thanks to the dev for this GREAT patch.
[Magisk] TheJoker71:
hi fOmey... i just recently updated again since it is weekly updates... so needs to update ADB PATCH again... but now i receive 2x adb warning and Could not find resources... but 0 error(s), 0 warning(s) at the end... attached here is the logs from smali 0.4.2... it is working but i just need your confirmation if this is okay...
[Magisk] fOmey:
All good mate, harmless warnings. :good:
[Magisk] jamesoh:
Have just tried this on a Magisked fireos tablet and got the following error (not surprising at all!)

Exception in thread "main" org.jf.dexlib2.DexFileFactory$UnsupportedOatVersionException: Unsupported oat version: 45

at org.jf.dexlib2.DexFileFactory.loadDexFile(DexFileFactory.java:120)

at org.jf.baksmali.DexInputCommand.loadDexFile(DexInputCommand.java:149)

at org.jf.baksmali.DisassembleCommand.run(DisassembleCommand.java:162)

at org.jf.baksmali.Main.main(Main.java:102)

==> Deodexed services.jar

!!! ERROR: Mock location class not found.

I'm guessing this is because the menu system is wrote completely differently. Is there any change of me uploading the services.jar and seeing if it can be patched?
[Magisk] seb_131:
Just tested the same file generated with the older MIUI and I confirm it still work with MIUI V10.2.3.0
[Magisk] hshah:
I am running Android Pie on my Samsung Note 8 - successfully managed to use the patcher and flash the Magisk module with the Disable Signature Verification feature selected.

Is this option meant to stop the "AASATokenParser - Violate security policy of MSTG. Package xyz is blocked"?
[Magisk] GTDarthYoda:
Just wanted to put this here

I was on Stock firmware and switched to Colt OS

Stock kept crashing, freezing, battery drain and my Android Wear Watch wouldn't stay connected. Made my phone almost unusable... But I could spoof

Colt OS (and maybe other non-stock roms), Phone has some slight hickups, slight battery drain but nothing compared to Stock.

Lets just say, it's a night and day difference between Stock and Custom.
[Magisk] WANTES:
Dear developer?I have 1+ 6t when I create a module for magisk, it works, but if I try to unpack it into the system, and use the method without magisk, I do not work the smali patch method, why? how to fix it? I don't want to use magisk, but I want to use smali patcher. please help me with this. Android 9.0.1

https://drive.google.com/file/d/1yioY1UClWRw-32Z-nB7pftBHs8xfVw_N/view?usp=sharing - My Module MAGISK

https://drive.google.com/open?id=1eICcQ4kj4hk0nKAemrgadoBUDfQDQTjI - Service.jar
[Magisk] conducked:
Not sure what i did wrong

Hey I'm not sure what I'm doing wrong but I keep getting this I've deleted the bin file a few times now retrying the program and I Keep getting this

==> Binary download complete

==> Unpacked binarys.

==> Detected Java: 1.8.0_201

!!! ERROR: Base directory not found.
[Magisk] wurstherpes:
Upload your service.jar i try.
[Magisk] conducked:
I cannot find service.jar anywhere
[Magisk] Ilzknoxvile:
Hi brother,

Could you help me once again? I have another file to patch below.

drivegooglecom/file/d/1BaqpAsqVsrcmCOlNF6wuBgm9NTOFBmi0/view?usp=drivesdk
[Magisk] @ayahfachri:
It seems this time your services.jar has not deodexed yet. :)
[Magisk] CpaoV:
Help with my services.jar

I have an Oneplus 6T and I am unable to deodex framework, could someone patch it for me?
[Magisk] atn0716:
Can someone help me? I keep getting jar is not deodexed error on version 4.2. I didn't have the problem with version 4.0 put I deleted the file. I am running rom purenexus_angler-7.1.1-20170215-OFFICIAL. Thank you very much for your help.
[Magisk] A30NI_Y:
All 4 patches ticked but on 4.1
[Magisk] J0ul3k:
Disable Signature Verifcationd doesnt work anymore with 4.2 on Android 9.0 Huawei P20 Pro.

Can i provide any data for you?
[Magisk] howdeedodat:
just wondering

hello dev thanks for ur awesome hardworks... :)

i have a lil question.. m running smali patcher on my laptop acer AO722 with ram 2GB n it still work flawless, i was wondering is it possible running your program with 1GB ram pc too ?

sorry for my bad english and my silly question i just hit the thanks button :good:
[Magisk] wurstherpes:
I think it will work. Why do not you just try it?
[Magisk] jamesoh:
Gave up with the Amazon FireOS and just stuck to normal Android on it.

I do still have a question about removing Smali on a temporary basis, is it possible? I tried uninstalling and also unticking from Magisk and it didnt work.

Thank you for the great work on this so far, its really helped my application.
[Magisk] paranoid_andr:
Is there any way I can enable the Magisk Module generated from this tool without tripping SafetyNet?
[Magisk] GTDarthYoda:
It doesn't trip for me. What phone/OS
[Magisk] Dims_Camper:
cannot download magisk module on both 4.1 and 4.2 version, known issue?
[Magisk] Muhamad Faisal:
HELP. Magisk module template download failed.

fOmey @ XDA

Patcher Version: 0.0.4.2

==> Detected Java: 1.8.0_172

I: Using Apktool 2.4.0 on services.jar

I: Baksmaling classes.dex...

I: Baksmaling classes2.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

==> Patched secure flag boolean

I: Using Apktool 2.4.0

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Checking whether sources has changed...

I: Smaling smali_classes2 folder into classes2.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_4.1-6.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.
[Magisk] wurstherpes:
Connect to handy to pc and activate developers option. And ADB debugging.

---------- Post added at 16:21 ---------- Previous post was at 16:19 ----------

Connect to handy to pc and activate developers option. And ADB debugging.
[Magisk] 88Root-Team:
HELP. Magisk module template download failed.

fOmey @ XDA

Patcher Version: 0.0.4.2

==> Detected Java: 1.8.0_172

I: Using Apktool 2.4.0 on services.jar

I: Baksmaling classes.dex...

I: Baksmaling classes2.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

==> Patched secure flag boolean

I: Using Apktool 2.4.0

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Checking whether sources has changed...

I: Smaling smali_classes2 folder into classes2.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.
[Magisk] I[E:
Same error, tried 4.1 and 4.2

---------- Post added at 11:26 AM ---------- Previous post was at 11:24 AM ----------

This isn't an issue with ADB debugging not being enabled. Even revoked and reauthorized debugging for the PC to make sure.
[Magisk] wurstherpes:
Upload build.prob and service.jar i will give a try
[Magisk] I[E:
From #2:

I'm sure [MENTION=1620550]fOmey[/MENTION] will address it
[Magisk] PriMieon:
I have the following error

!!! ERROR: Magisk module template download failed.

I have manually pulled service.jar from my phone and then tried it with no positive results. I have of course tried connecting my phone to the pc via usb debugging.

I have also created a smali file 5 times before. I am still using the same phone but with a custom rom now (AOSIP official) on my google pixel 3.

You guys also talk about BUILD.PROB a lot. What is that? I cant seem to find it on my phone. Where do I find it and what is it used for?

I have tried two PCs but both give me the same error which is weird because it was working just a week ago.
[Magisk] Ole97er:
same error here today
[Magisk] howdeedodat:
i already used the lastes version my internet doing great but still no luck downloading the modul,,, is it possible if fomey updating the new version of smali patcher? that's why we always having error when downloading the modul ? :)
[Magisk] molonad:
same error.. All was working fine.. Iam using latest magisk 19.0.
[Magisk] Iw2N:
Same error for me
[Magisk] Suryo75:
hello guys, i'd would like to know whether smali patcher can be install using twrp without magisk installed ?

---------- Post added at 08:18 PM ---------- Previous post was at 08:14 PM ----------

try delete all template inside folder,and let smali update its binary. it works for me
[Magisk] molonad:
can you please patch my service.jar? I tried deleting all.. i tried older version.. also it worked fine for me weak ago..
[Magisk] Suryo75:
fOmey @ XDA

Patcher Version: 0.0.4.1

==> Detected Java: 1.8.0_201

Error: Invalid or corrupt jarfile bin\apktool.jar

!!! ERROR: Target JAR must be deodexed

i get this with you sevice.jar

have you tried deodex entire rom ?
[Magisk] molonad:
my error is only about Magisk module

this is not what i get. my rom is deoxeded

as you can see here with same services.jar

fOmey @ XDA

Patcher Version: 0.0.4.2

==> Detected Java: 1.8.0_201

I: Using Apktool 2.4.0 on services.jar

I: Baksmaling classes.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

I: Using Apktool 2.4.0

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.
[Magisk] wiwin22:
fOmey @ XDA

Patcher Version: 0.0.4.2

==> Binary download complete

==> Unpacked binarys.

==> Detected Java: 1.8.0_201

I: Using Apktool 2.4.0 on services.jar

I: Baksmaling classes.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

I: Using Apktool 2.4.0

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.

==> Detected Java: 1.8.0_201

I: Using Apktool 2.4.0 on services.jar

I: Baksmaling classes.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

I: Using Apktool 2.4.0

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.

some error
[Magisk] xWidget:
Looks like it's dead because https://github.com/topjohnwu/magisk-module-template/archive/17000.zip is 404'ing.

Is it trying to get what's now https://github.com/topjohnwu/magisk-module-installer/archive/master.zip ?
[Magisk] Fre$h:
Hi [MENTION=1620550]fOmey[/MENTION], as the new MAGISK was released earlier, it bring us a new way/api to create package to install. Do you already preview to build a news smalipatcher compatible with it ? Or are you smalipatcher already compatible with MAGISK 19 ?

EDIT: just updated and tested with MAGISK 19 + LINEAGE 16 with March 2019 security patch + smalipatch 0.0.3.8 => zero problem and everything works as before the update
[Magisk] fOmey:
I'm aware guys, I appreciate all the reports.

If you have a module generated already the new magisk update does include legacy support.. meaning you'll be able to install it fine (hopefully).

I'll be pushing a update shortly (WIP) for the latest magisk.
[Magisk] bon0123456789:
Help me ? Thanks
[Magisk] Macmix123:
I'm sorry to bother u guys, but I have the following error

==> Merged patch: sigspoof_7.0-9.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.

Can someone give it a try to generate de zip?

Pls and thx
[Magisk] kauw5164:
!!! ERROR: Magisk module template download failed.
[Magisk] fOmey:
CHANGELOG ::

4.3 [UNTESTED - I OWN A S10 WHICH CURRENTLY IS NOT MAGISK COMPATIBLE.. USE AT YOUR OWN RISK]

Magisk v19.0 compatible (magisk template download failed fix).
[Magisk] Muhamad Faisal:
Thanks version 4.3 work fine
[Magisk] 0ddj0b7:
Came here to check if anyone had tested, thanks much I'm on the same setup as you gonna give it a go
[Magisk] Iw2N:
Magisk fails to install the generated module
[Magisk] wurstherpes:
The same...

- Copying zip to temp directory

- Installing SmaliPatcherModule-0.0.4.3-fOmey@XDA.zip

! Installation failed
[Magisk] Gabcor:
Same here :(

-

Thanks for your work, fOmey!
[Magisk] curutdapur:
me too.. instalation failed :(
[Magisk] Coraza:
+1
[Magisk] @ayahfachri:
the 4.3 module installation failed using Poco F1 Xtended-beryllium-20190314-XP5-OFFICIAL-Release-v12, Magisk 19, both on TWRP or direct from Magisk Manager.