yashsingh1/xdaforums huggingface dataset:
[Magisk] sobirin90:
Definitely looks fine to me. Just wait OP to reply then.

---------- Post added at 02:53 PM ---------- Previous post was at 02:52 PM ----------

ADB driver properly installed? Use the link I post above to double confirm with the ADB toolkit.
[Magisk] shoey63:
You may have lineage root remnants. Search for unsu and flash it

Edit: run rootbeer app from playstore first. It may give an indication as to what's wrong.
[Magisk] Rooble88:
System UI error

So I ended up trying on a different tablet (SM-T380) running Magisk v18.1. Everything seems to be running fine, Smali installed fine, GPS spoofing appears to be working fine.

After running "FakeGPS and Routes" and Pokemon GO for a bit, I am getting the error "System UI is not responding. (wait) (close app)"

Could this error be caused by the Smali Patcher or is another app not have the proper permissions? Or am I running out of memory or something?
[Magisk] michaelcssirait:
Yesterday i try the version 3.8 and many bugs cant download module. And today i look the new version 4.0 .

Thank you somuch for developer for you hardwork ;)
[Magisk] basti3888:
Flashed it with unSU, no success.

Rootbeer detects "dangerous props" and "selinux flag enabled (experimental)"

On my S5 (Po Go works there with smali patcher), Rootbeer says the same. I have done exactly the same procedure to make PoGo work on both the S5 and S7 Edge, but it will only work on my S5.
[Magisk] flippage:
Same issue here on Pixel XL and stock Pie.
[Magisk] Rehvix:
When I try to use Smali Patcher I get an error: Unable to download module template. What should I do now?
[Magisk] Phantom Thief:
Read the Faq: https://xdaforums.com/showpost.php?p=74074402&postcount=2
[Magisk] Tal26:
Flushed on my friend's phone the same adb patch I've flushed on mine (same phone, galaxy s8) but it seems the phone won't load his system. It got stuck. No loop, just stucked. Any suggestions what to do, or we need to burn rom stock and root all over again?
[Magisk] fOmey:
Did you accept the ADB authentication popup on your phone?

Can you run this command in CMD and post the output: "adb.exe devices"

You can find the adb.exe in the bin folder.

Can you post a logcat of when a crash occurs?

Use the latest release.

If you followed the instructions, you should have a backup.. otherwise uninstall magisk.
[Magisk] fOmey:
Test this module, I've modified it slightly and report back.
[Magisk] Tal26:
I didn't backup. was willing to flash rom stock, but when I tried it Odin gave me FAIL in return. what should I do, sir?
[Magisk] mioramoe:
This is what happens:

https://i.imgur.com/i86o3LI.png

Tried use adb.exe from - 22 ‎September ‎2016 (can't find version number) which seemed to work a charm but then says needs to be deodex service.jar but my system image odex, any workaround? (Ultimate Deodexer.exe doesn't work since still get error when use the "deodexed" .jar)

==> Detected Java: 1.6.0_26

pull: building file list...

/system/framework/: 830 files pulled. 0 files skipped. 16.5 MB/s (430827928 bytes in 24.920s)

==> Dumped framework

==> Detected API: 26

[INFO] Processing 1 file(s) from bin\services.vdex

[INFO] 1 out of 1 Vdex files have been processed

[INFO] 2 Dex files have been extracted in total

[INFO] Extracted Dex files are available in 'bin'

==> Extracted classes.dex

==> Extracted classes2.dex

java.lang.UnsupportedClassVersionError: brut/apktool/Main : Unsupported major.minor version 51.0

at java.lang.ClassLoader.defineClass1(Native Method)

at java.lang.ClassLoader.defineClassCond(Unknown Source)

at java.lang.ClassLoader.defineClass(Unknown Source)

at java.security.SecureClassLoader.defineClass(Unknown Source)

at java.net.URLClassLoader.defineClass(Unknown Source)

at java.net.URLClassLoader.access$000(Unknown Source)

at java.net.URLClassLoader$1.run(Unknown Source)

at java.security.AccessController.doPrivileged(Native Method)

at java.net.URLClassLoader.findClass(Unknown Source)

at java.lang.ClassLoader.loadClass(Unknown Source)

at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)

at java.lang.ClassLoader.loadClass(Unknown Source)

Could not find the main class: brut.apktool.Main. Program will exit.

Exception in thread "main"

!!! ERROR: Target JAR must be deodexed.
[Magisk] dildildil:
i'm using SmaliPatcher-0.0.3.7-fOmey_XDA.. magisk module suddenly can't download.

I just reflashed my rom and wanted to patch. Now i'm stuck. Pls help

---------- Post added at 03:42 AM ---------- Previous post was at 03:30 AM ----------

i think server is down. Done smali very often, only now has problem downloading.
[Magisk] sekk:
What exactly would happen if I set location to high accuracy and use location history while playing pokemon go? Could anyone help?

Aside from these questions, congratulations!!

And also, I've just flashed the module created by 3.7, can I just use the 4.0 over the current "modified services by smali" without flashing stock again to get the original services.jar?

[MENTION=1620550]fOmey[/MENTION]
[Magisk] Chilled26:
Works well. Spoofing works. A bit laggy, but less so than with older versions of the module.
[Magisk] basti3888:
Yes, but now the "device is not compatible" ERROR is back. Magisk is completely uninstalled, the S7 Edge unSU'd, services.jar replaced, *.odex/vdex deleted.

I have no idea left, what I could have missed.

But again: the same procedure (same OS etc.) worked on my S5. The S7 belongs to a friend with whom I used to play PoGo, so I try my best to let him play again.
[Magisk] GrigoryVal:
"ERROR: Target JAR must be deodexed."

Please to odex Smali Patcher for Stock Rom

Redmi 3s Android 6.0.1 :crying:
[Magisk] fOmey:
Can you upload the "adb" directory to googledrive or something so I can take a look.
[Magisk] Fatcat90:
Thank you! Reinstalling phone drives helped me ;)

---------- Post added at 10:30 AM ---------- Previous post was at 10:11 AM ----------

Thank you! Evertyhing works fine now.

You did an awesome work :)
[Magisk] Rony_Subhosmit:
Can someone patch the services.jar for me? Its deodexed but for some reason it get this error:

==> Merged patch: sigspoof_core

==> Magisk template download complete

!!! ERROR: Magisk module template download failed

Here is my link to services.jar https://drive.google.com/open?id=180je5Rznt0vOnrr7d_8fpVw_itN0TvzT
[Magisk] mioramoe:
I compressed it if you have any issues downloading lemme know, cheers!

https://drive.google.com/open?id=1SYG7keRzK92l2otSoLhQ9bcpQORzqYks
[Magisk] basti3888:
Now it works!!!

The problem was the OS (lineageos15.1) on the S7 Edge. Before the PoGo update 0.133 and therefore before the smali patcher flashing, PoGo worked with Magisk on 15.1, but after adding smali there was the "device not compatible" error.

The solution was flashing an older rom, lineageos14.1, before flashing smali patcher.

Thank you all here for the great support!
[Magisk] nutzlos:
Hi,

in which folder are "services.odex/services.vdex" ? They are not in my /system/framework, but they are in a subfolder /system/framework/arm/ .

Should I delete them wherever they are? Or only in /system/framework, if they are present there.

Thanks,

Ar.
[Magisk] benny670:
Lollipop compatibility?

Hi all,

First off, thanks to fOmey for this brilliant tool! However I'm throwing this out there as I have been unable to find a solution to get Smali Patcher working successfully on 5.1.1 Lollipop.

I, along with many others, seem to have an issue where our Smali Patched Magisk modules are ineffective on 5.1.1. It appears that apps are still able to see the status of the 'Allow mock locations' flag, even after using this tool and loading the Magisk module (currently using Magisk 17.1 as v18 caused a bootloop on my device, Galaxy S6 Edge SM-G925I)

For example: Pokemon Go throws error 12 "Unable to determine location" when the app detects that mock locations are allowed in developer options. The correct mock location is shown, however the game simply displays Error 12 until mock location option is disabled, causing the real location to appear. This is tested with several apps, predominately AppNinjas (non system app, private mode).

I'm not sure if the tool is working correctly, or if there are differences in the services.jar in lollipop that cause the tool to be ineffective, or some other external cause - I am happy to help troubleshoot this issue if anyone can point me in the right direction! I've included similar posts below in case this helps.

Thanks,

benny
[Magisk] Rehvix:
I updated Java to 201, downloaded .net (already had 4.7), completely turned off my antivirus/firewall, ran Smali Patcher as Administrator, and still got Module template download failed. Any pointers?
[Magisk] TheUndertaker21:
anyone's phone taking performance hit when use this module ?

my phone got very slow.

maybe because on android pie signature thingy is the issue.
[Magisk] PokemonTotalWar:
Everybody gets a performance hit using this. Mine isn't horribly noticeable, but I can no longer doubly tap my recents to go to my last app, I have to wait for a split second or it doesn't register the second tap.
[Magisk] Rehvix:
Didn't think you'd made so much progress in a few months so I didn't check version number. Turns out I was on 2.9. Thank you very much for your work! Once I figure out what happened to my PayPal balance up you can expect a donation from me!
[Magisk] Thr00wavvay:
Finally got it working on my Essential PH-1 with Android 9.0 using Smali 4.0 over ADB.

Still didn't work over ADB while in Recovery or with the services.jar, but just needed it to work once.

Module for the Essential PH-1 Incase anyone needs it: s000.tinyupload.com/?file_id=80884170839775379635

EDIT:

Rubberbanding went away when I disabled every option in GPS Joystick. It is so nice not needing to reboot every time I want to use GPS Joystick, due to changed settings.

Other Note for Mac Users:

If you are a Mac user like me, I had to install Windows 10 using VirtualBox just to run Smali Patcher. I also had to install the VirtualBox Extension Pack in order to get USB 2.0 working as ADB was not working over USB 1.1.

I was able to do this for free, as I did not need to activate windows to get it to work. Just be sure to allocate enough space(probably 15GB or Dynamic) to avoid headaches, as it was a pain to clear out enough space on a 12GB allocation.
[Magisk] Rehvix:
Yeah, I'm having the same issue. I'm starting to think it's because I didnt get the adb popup on my phone screen.
[Magisk] HarpingOn:
I too get rubber banding, have had to use tinfoil to block the GPS satellites.

The patch works in so much that I can set a mock location without triggering an error, and that mock location is represented in Google Maps.

BUT ... if I don't use foil, the satellite and mock locations will rubberband between themselves.

My OS is AICP 8.1 (castor_windy) - yeah, it's old hardware.
[Magisk] GTDarthYoda:
Same here

Big battery drain too
[Magisk] Thr00wavvay:
Once I disabled every option in GPS Joystick, rubberbanding went away.
[Magisk] williamsnguyen26:
Help Me !!!

fOmey @ XDA

Patcher Version: 0.0.3.8

pull: building file list...

adb: warning: stat failed for path /system/framework/miuisdk.jar: No such file or directory

adb: warning: stat failed for path /system/framework/miuisystem.jar: No such file or directory

/system/framework/: 106 files pulled. 13.8 MB/s (47721196 bytes in 3.296s)

==> Dumped framework

I: Using Apktool 2.3.4 on services.jar

I: Baksmaling classes.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

==> Patched secure flag function

==> Patched secure flag boolean

==> Patched signature verification function

I: Using Apktool 2.3.4

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

info: read 'tmp\dist\services.jar'

info: read 'bin\sigspoof_7.0-9.0.dex'

info: type 'com.android.server.pm.PackageManagerService': method '<init>():void': (PackageManagerService.java:28): implicit ignore of trivial default constructor

info: write 'classes'

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

info: read 'tmp\dist\services.jar'

info: read 'bin\sigspoof_core.dex'

info: type 'com.android.server.pm.GeneratePackageInfoHook': method '<init>():void': (GeneratePackageInfoHook.java:35): implicit ignore of trivial default constructor

info: write 'classes'

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

==> Magisk template download complete

!!! ERROR: Magisk module template download failed.

I use xiaomi redmi note 5, rom EU v10.0.2.0 OEICNFH(stable)

Veriy active internet connection.

Verify not blocking the patcher.

.NET framword new windows 7
[Magisk] risoobeon:
Have you tried disabling location accuracy? I too got rubber banding but once mine was disabled it works perfectly even outside. I'm on stock Pie Note 9.
[Magisk] Spartacus500:
Here you are ;) You services.jar file 4 patch for You :o
[Magisk] Lazarus Long:
Error

fOmey @ XDA

Patcher Version: 0.0.3.8

* daemon not running; starting now at tcp:5037

==> Magisk template download complete

!!! ERROR: Magisk module template download failed.

On Xiaomi Redmi Note 4 and Xiaomi Redmi 2

Edit: I will try version 0.4.0
[Magisk] risoobeon:
I too get battery drain and slow performance but I would say I reckon this is the only way to effectively spoof on go currently. Thanks to the dev for the continued support.
[Magisk] Spartacus500:
[MENTION=9743476]williamsnguyen26[/MENTION] [MENTION=5171539]Lazarus Long[/MENTION]

Try the latest version of Smali Patcher 4.0, on the older 3.8 there are problems with downloading the finished file.
[Magisk] Lazarus Long:
==> Merged patch: sigspoof_7.0-9.0

info: read 'tmp\dist\services.jar'

info: read 'bin\sigspoof_core.dex'

info: type 'com.android.server.pm.GeneratePackageInfoHook': method '<init>():void': (GeneratePackageInfoHook.java:35): implicit ignore of trivial default constructor

info: write 'classes'

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

==> Magisk template download complete

==> Generated magisk module zip file

*** Complete ***

Now it's OK. Thanks
[Magisk] williamsnguyen26:
Thanks [MENTION=6138728]Spartacus500[/MENTION]

---------- Post added at 07:02 PM ---------- Previous post was at 06:39 PM ----------

You help me !!!

I can't add module Magisk

" Failed!

! Installation failed "

Any other way? Like flash twrp

My framework does not have arm files, arm64 and oat
[Magisk] anggodo69:
Download is broken
[Magisk] HarpingOn:
Yes - it's device only.
[Magisk] anggodo69:
V 4.0 download link is broken, i cannot download it
[Magisk] s.i.t.h.l.o.r.d:
It did work for me just a few hours ago.

Attached is my zip from then. Unaltered, of course.
[Magisk] anggodo69:
Thanks is work fine
[Magisk] mioramoe:
update

had a mate try on his PC incase was issue with the adb.exe I replaced but he too got the deodexed error:

https://i.imgur.com/dP0FyiC.jpg
[Magisk] Hogwart91:
Ok.

Gave up with the s5 from yesterday, grabbed an a5 instead, rooted easy enough, magisk and smali patch installed, GPS app installed as user app and converted via private mode, also set as mock location app.

Now, when I boot pogo and get logged in I get 'device not compatible'. This is a stock at rom with only magisk root installed with smali, can anybody give me some pointers, hoping I dont have to unroot, but if I do that's not an issue.

TIA
[Magisk] fOmey:
Can you upload "/system/framework" and upload it to googledrive?
[Magisk] Rehvix:
Go to magisk settings and press the repackage with random name.
[Magisk] Stillhard:
Use this tool to check is your device vulnerable to root detection:

https://play.google.com/store/apps/details?id=com.avigia.procgate

credit to: [MENTION=4470081]topjohnwu[/MENTION]
[Magisk] fOmey:
Well, I can't find a services.jar in that framework directory.. so that's one problem.

I can however find "services.odex/vdex/art" which is really strange.. did you move/delete services.jar?

Delete the "bin" directory and restart patcher.. (In the FAQ - post 2)
[Magisk] ItaloIanetta:
Hi, could you help me ? is giving the following error in the process ERROR: Target JAR must be deodexed, could you fix the process?

https://drive.google.com/open?id=1WX6Dob7FBf9qeMNSdi_ToVuVm8_8EsO8
[Magisk] mioramoe:
Whoops, I did move it when I wanted to try deodex with Ultimate Deodexer

here's the jar from adb sorry

https://drive.google.com/open?id=13XE51yFUPcR2_gwt772Fw6VEh1YOfLrA

Will get them to do that when he's woke up and see if works.
[Magisk] Tzfardaya:
Nexus 6p, works beautifully, Thanks.

Pixel 3 XL, no Joy on fresh install of latest update (February 5 2019 update)

Magisk rooted, No patch options set.

Edit:

Pixel 3 XL works fine.. I just derped hard.
[Magisk] benny670:
RE: Lollipop compatibility?

Thankyou fOmey, I've attached the file! SM-G925I, 5.1.1

drive.google.com/open?id=1bww6mDsvTqzBiaqpqmH_ulWj6NUuN5a9
[Magisk] Halloo~:
Someone help me

I try to make smali again and always error

Magisk module template download failed.

I try at many pc and hv same problem.

help me pls;)
[Magisk] kiscvik:
Hi, im with Galaxy s7 edge and Glamour Rom... Im magisk root and idk why it trows me facenet Error, but this is not the problem, the problem appears when i try to flash my services with twrp and it just finish ok. But after restart the phone, there's no module on magisk manager, so what could i do... Im tired of searching about fussed lockation due pokemon patch update...

Hope you can help me with something about this. Thanks
[Magisk] Blissey:
make sure update your smali patcher and run as administrator

had same issue with me ! now solved :good:

---------- Post added at 06:46 AM ---------- Previous post was at 06:26 AM ----------

you need to uninstall magisk !! use magisk uninstaller after flash new magisk 18.1 than check seftynet ! if seftynet pass than

after flash smali patcher magisk module which you generate !

---------- Post added at 06:53 AM ---------- Previous post was at 06:46 AM ----------

you need to deodex services.jar

check this link https://amp.reddit.com/r/PokemonGoS..._guide_android_root_smalli_patcher_deodexing/
[Magisk] PokemonTotalWar:
It's a lot more in depth, but is there a way to merge the mods from this patcher into the source of a ROM and then build the ROM with the mods already committed?
[Magisk] Lewerosky:
Hi, quick question. I'm installing SmaliPatcher manually suing TWRP on a Moto G5 (8.1.0, no root). And when I'm moving the files in /system/ there aren't any 'arm64' folder neither on /framework/ nor /oat/. I managed to move all the folder but I got "Error 12" in POGO, then when I tried to patch it again, I got a bootloop. What can I do?
[Magisk] Hogwart91:
That worked a treat, got me back into the game.

I have 1 query left, when using appninjas GPS app to spoof I have to disable every option relating to GPS, including indirect mock locations, so that I dont rubberband. With smali patch on in magisk I am safe to spoof to another country or do I need indirect mocking on?

Galaxy a5

Magisk installed and hidden, package renamed vis magisk

Appninjas GPS app installed as user app (not system)

TIA
[Magisk] nutzlos:
I had to activate indirect mocking in developer options, otherwise appninjas GPS app complained, that indirect mocking is not enabled.

Now I travel around the world with PoGo, Smali, appninjas and activated indirect mocking
[Magisk] fOmey:
That's really odd, it worked fine here when I tested.. can you refresh my memory on what is happening exactly?

EDIT:

Sorry I got you mixed up with someone else, mock locations being detected right?

fOmey @ XDA
Patcher Version: 0.0.4.0
==> Detected Java: 1.8.0_201
==> Dumped framework
I: Using Apktool 2.3.4 on services.jar
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
==> Patched mock location boolean
I: Using Apktool 2.3.4
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Building apk file...
I: Copying unknown files/dir...
I: Built apk...
W: Could not find resources
info: read 'tmp\dist\services.jar'
info: read 'bin\sigspoof_4.1-6.0.dex'
info: type 'com.android.server.pm.PackageManagerService': method '<init>():void': (PackageManagerService.java:27): implicit ignore of trivial default constructor
info: write 'classes'
0 error(s), 0 warning(s)
==> Merged patch: sigspoof_4.1-6.0
info: read 'tmp\dist\services.jar'
info: read 'bin\sigspoof_core.dex'
info: type 'com.android.server.pm.GeneratePackageInfoHook': method '<init>():void': (GeneratePackageInfoHook.java:35): implicit ignore of trivial default constructor
info: write 'classes'
0 error(s), 0 warning(s)
==> Merged patch: sigspoof_core
==> Magisk template download complete
==> Generated magisk module zip file
*** Complete ***
[Magisk] Hogwart91:
I have mock locations activated in dev options, indirect mocking is an option within appninjas. When I tick that within appninja I get rubber banding
[Magisk] ukz:
[MENTION=5818781]Eng.Raman[/MENTION] please help me to patch my service, sorry newbie, im stuck... error magisk module download failed please patch for me
[Magisk] nutzlos:
deactivate everyting in appninjas, deactivate indirect mocking in app ninjas.

just acticate mocking in developer options of Android
[Magisk] sobirin90:
I compiled few recent problems that people faced for the patch. So far I already successfully make 8 pogo spoof phones now, from nougat until pie version.

1. ERROR!! Magisk download template failed

Possible solution: Download latest version of the patcher, you might using older version

2.ADB devices not detected

Possible solution: Make sure your ADB drivers is properly installed. In some rare cases if you are really sure that drivers is installed you can report to [MENTION=1620550]fOmey[/MENTION]

3. Framework directory not found!!

Possible solution: Revoke your USB Debugging Access and Grant it back to the PC. If still cannot, try use command ADB.exe devices and if your device is properly connected it should return some numbers and devices(not offline). If it shows offline your cable or USB port might have issue.

4. Pokemon go devices not compatible error

Possible solution: there are three things you need to check, first, is your magisk hidden? (Repackage the manager to random name, in magisk manager settings), second, are Pokemon go is ticked in magisk hide check box list?, Lastly, double check if there is any files that have word 'magisk' you can either rename it or delete it. Niantic doesn't like that word.

5. I cannot flash the patch magisk modules! The patcher working fine.

Possible solution: you might didn't have the ability to patch any modules at all on magisk, not only smali is effected. Your data partition might be formatted as f2fs. Most Lenovo and motorola phones is using f2fs. You need to find workaround on this issue as it varies from model to model. As for my Lenovo p2, I solved it by format the data partition to ext4 via twrp. Some phones has their own method to solve this, I didn't find any for my Lenovo, therefore I just gambled format the partition, luckily it work out great.

6. I still get rubber band

Possible solution: uncheck every option in the appninjas app, except for prevent screenshot.

Feel free to add any more issues if I missed any.