yashsingh1/xdaforums huggingface dataset:
[Magisk] 8bitcode:
I have a problem on Bootlegger rom Android Pie on a Moto Z2 Play, this is my log

pull: building file list...

/system/framework/: 213 files pulled. 7.7 MB/s (312491458 bytes in 38.630s)

==> Dumped framework

[INFO] Processing 1 file(s) from bin\services.vdex

[INFO] 1 out of 1 Vdex files have been processed

[INFO] 1 Dex files have been extracted in total

[INFO] Extracted Dex files are available in 'bin'

bin\compact_dex_converter: 1 file pushed. 5.2 MB/s (5087392 bytes in 0.934s)

bin\classes.cdex: 1 file pushed. 16.8 MB/s (9670120 bytes in 0.548s)

Opened '/data/local/tmp/classes.cdex', DEX version '001'

/data/local/tmp/classes.cdex.new: 1 file pulled. 10.1 MB/s (10122520 bytes in 0.955s)

==> Extracted classes.dex

I: Using Apktool 2.3.4 on services.jar

I: Baksmaling classes.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

I: Using Apktool 2.3.4

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

info: read 'tmp\dist\services.jar'

info: read 'bin\sigspoof_7.0-9.0.dex'

info: type 'com.android.server.pm.PackageManagerService': method '<init>():void': (PackageManagerService.java:28): implicit ignore of trivial default constructor

info: write 'classes'

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

info: read 'tmp\dist\services.jar'

info: read 'bin\sigspoof_core.dex'

info: type 'com.android.server.pm.GeneratePackageInfoHook': method '<init>():void': (GeneratePackageInfoHook.java:35): implicit ignore of trivial default constructor

info: write 'classes'

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

==> Magisk template download complete

!!! ERROR: Magisk module template download failed.

It´s running on administrator rights ):
[Magisk] fOmey:
XDA might of been having some server issues.

Upload your log & generated module.

Use version 4.1 and report back.. I've left both links on the OP.

"I can not use the second method because I can not deodex services.jar, it stops at that file for hours, like 9 hours ..." - this probably has something to do with your problem... if you can't manually deodex chances are the patcher is not going to be able to either.

Upload the generated module.

This is also concerning:

touch: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/services.jar/.replace: Not a directory
update-binary: line 383: can't create /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/services.jar/.replace: nonexistent directory
chmod: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/services.jar/.replace: Not a directory
touch: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/services.odex/.replace: Not a directory
update-binary: line 383: can't create /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/services.odex/.replace: nonexistent directory
chmod: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/services.odex/.replace: Not a directory
touch: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/oat/arm/services.odex/.replace: Not a directory
update-binary: line 383: can't create /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/oat/arm/services.odex/.replace: nonexistent directory
chmod: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/oat/arm/services.odex/.replace: Not a directory
touch: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/oat/arm64/services.odex/.replace: Not a directory
update-binary: line 383: can't create /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/oat/arm64/services.odex/.replace: nonexistent directory
chmod: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/oat/arm64/services.odex/.replace: Not a directory
touch: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/arm/services.odex/.replace: Not a directory
update-binary: line 383: can't create /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/arm/services.odex/.replace: nonexistent directory
chmod: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/arm/services.odex/.replace: Not a directory
touch: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/arm64/services.odex/.replace: Not a directory
update-binary: line 383: can't create /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/arm64/services.odex/.replace: nonexistent directory
chmod: /dev/tmp/magisk_img/fomey.smalipatcher/system/framework/arm64/services.odex/.replace: Not a directory

Strange! Although I'm glad to hear you're sorted!

Use version 4.1, link in the OP.
[Magisk] Fan of fomey:
Restarting oneplus6

Using smalipatcher 4.2 on one plus 6 android 8.1 once enabling fake gps after couple of minutes device getting restart.. please help me
[Magisk] sekk:
-deleted-
[Magisk] konks:
I've recently installed 4.2 (Mock Locations) on my Google Pixel 2 XL running Android 9 (5 March) and seems to be running very well. I haven't really experienced any major slow downs on it so far compared to my OG Pixel XL.
[Magisk] Pr4nt0:
help by deodexing pls

Hi i cant get it to work,tried so many times, later heard people get dexodexing from here, so if anyone can pls tell me or email me @ ahpranto42@gmail.com

thankss
[Magisk] terrorsource:
Tried Smali Patch 0.0.3.7, 0.0.4.1 and 0.0.4.2 all with same error:

fOmey @ XDA

Patcher Version: 0.0.3.7

==> Binary download complete

==> Unpacked binarys.

java.lang.UnsupportedClassVersionError: brut/apktool/Main : Unsupported major.minor version 52.0

at java.lang.ClassLoader.defineClass1(Native Method)

at java.lang.ClassLoader.defineClass(Unknown Source)

at java.security.SecureClassLoader.defineClass(Unknown Source)

at java.net.URLClassLoader.defineClass(Unknown Source)

at java.net.URLClassLoader.access$100(Unknown Source)

at java.net.URLClassLoader$1.run(Unknown Source)

at java.net.URLClassLoader$1.run(Unknown Source)

at java.security.AccessController.doPrivileged(Native Method)

at java.net.URLClassLoader.findClass(Unknown Source)

at java.lang.ClassLoader.loadClass(Unknown Source)

at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)

at java.lang.ClassLoader.loadClass(Unknown Source)

at sun.launcher.LauncherHelper.checkAndLoadMain(Unknown Source)

Exception in thread "main"

!!! ERROR: Target JAR must be deodexed.

Tried deodexing with FulmicsDeodexer.exe, process finished but files are not usable in SmaliPatcher ", same error as above.

Can someone help me get a patched JAR for Samsung S7?

Copied /system/framework and /system/build.prop via TWRP to micro-sd card, copied from micro-sd to PC.

Upload: https://drive.google.com/file/d/1XtO2_U6p5hXVr9UWdxqvtr7eHt4mKOjf/view?usp=sharing
[Magisk] lemon_gm:
Meet error: "!!! ERROR: Target JAR must be deodexed."

fOmey @ XDA

Patcher Version: 0.0.4.2

==> Detected Java: 1.8.0_201

system/build.prop: 1 file pulled. 1.7 MB/s (10828 bytes in 0.006s)

pull: building file list...

==> Dumped framework

==> Detected API: 25

I: Using Apktool 2.4.0 on services.jar

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

!!! ERROR: Target JAR must be deodexed.

Deodex Checker showing status is deodexed

Redmi Note5A

MIUI 10.1.2 Statble version

Android 7.1.2

How can I resolve this error？

Thanks a lot
[Magisk] fOmey:
What OS are you running this off? Is it a ARM machine or something?

Can you upload the "adb" directory to google drive.
[Magisk] terrorsource:
Galaxy S7, Android 8.0.0

flashed latest available image a few days ago with "SM-G930F_1_20181210141827"

Running the Smali Patcher on Win10 x64, regular PC (i7-8700k cpu)
[Magisk] fOmey:
Probably just need to update your java in that case.
[Magisk] terrorsource:
Java 8 update 201 is installed, which is the latest version for Win10.

Did run the FulmicsDeodexer with logging enabled and i see the following line a few times, which indicates that something is not working:

E/Utils(6-3-2019 08:11:29): EXCEPTION: Kan bestand C:\samsungs7\FulmicsDeodexer_1.6\system\framework\arm\classes.dex niet vinden.
E/Utils(6-3-2019 08:11:29): bij System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
bij System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
bij System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)
bij System.IO.Compression.ZipFileExtensions.DoCreateEntryFromFile(ZipArchive destination, String sourceFileName, String entryName, Nullable`1 compressionLevel)
bij dHV916N9IjBVxi7Mdw.MdsgTuvJQhS232h3Os.BGVuFibKN(String , String )

Maybe the dump of the phone is incorrect but i doubt that. copied the whole folder via TWRP-copy.

In \arm\ and \arm64\ are only files starting with letter "b". Don't know if that is correct?
[Magisk] shoey63:
What's stopping you using the adb method? Fulmics is outdated and unsupported by the developer.
[Magisk] terrorsource:
Because of the error mentioned in post #2511 ?
[Magisk] terrorsource:
No mor JAR ERROR!

Solution:

Use the Java Removal Tool to uninstall Java completely with all it's junk ( https://www.java.com/en/download/uninstalltool.jsp )

Then re-install latest version
[Magisk] Truant_Luce:
I wanted to share my stupidity, but I was having issues with the module not working until I remembered I have a custom MAGISK rom installed. That module would load after this one and not fix it. I just plugged in the services from the module that the magisk rom was using, and fixed my issue. Works great!
[Magisk] 8bitcode:
Thanks! it worked like a charm, just for the log, it works great o a Z2 Play XT1710-06 running Android Pie with Bootleggers rom GSI Treble.
[Magisk] Olorin92:
So something I noticed today (and this is probably obvious) - but when I'm not running the GPS spoofing app, the lag is completely gone. I'm using AppNinjas GPS Joystick, and also notice if I increase the process intervals (for instance keeping it at the default 1000ms), the lag is much less pronounced.

So I assume the lag is originating as a result of the amount of calls to whatever part of the API handles mock locations, and I'd assume given this module centers around that functionality, it comes down to the de-optimising of those functions in particular? I can see for certain though if I increase the interval (decrease the amount of times a fake location is broadcast) or turn the spoofing app off completely, the lag decreases/disappears.
[Magisk] fOmey:
Well no, the jar we modify is constantly running on the android OS.. as soon as the device boots, its the main services.

Which means if the module is causing lag, it would be constant as soon as the device boots up..

If you're lagging only when spoofing, the spoofer is causing the lag.. meaning most likely the spoofer is flooding location updates to prevent rubberbanding.

EDIT: You can try using my bare bones spoofer on the OP as a test.. see if the lag persists.
[Magisk] Olorin92:
Alright thanks I'll give that a shot. There is definitely some difference though as I didn't get this sort of lag before smali - and I've used the same app and settings before and after. I'll test with your spoofer though and see if I can notice better performance!
[Magisk] lemon_gm:
Meet error: "!!! ERROR: Target JAR must be deodexed."

Sorry,I‘m a new user, so I can’t post any outside links in messages. I've send a private message to you. Thank you very much.
[Magisk] fOmey:
That's definitely not deodexed.. strange thing is you have no .odex files either.

Try running the patcher with no patches selected.. this will tell us if one of the patches are causing a bootloop.

If you bootloop using a module with no patches selected, this tells us the deodex is failing somewhere.. even tho its not presenting any errors.

Might be worth trying version 4.2 also.
[Magisk] fOmey:
Thank you for sharing the fix.. I'll add this to the FAQ.
[Magisk] kiki059:
Yo , i reask.. it's working with Device Mi in general?
[Magisk] fOmey:
What should you do? That is the question... with no errors to go off, it makes this very difficult to fix.

The only thing you can do is manually deodex services.jar, try get a successful boot.. you can just replace the services.jar in the module to test.

Can try changing roms I guess? Whatever action you take, if you find a resolution share it.. sorry I can't be much more help than that.
[Magisk] lecsopt:
Hey, I keep getting stuck ar Dumping Framework (73%). What can I do to solve it?
[Magisk] cmanuellah:
Thank you for helping. I'll try the manual deodex again, but this time by adb. If I can't, I think I'll choose to test with custom roms ... btw if deodex services.jar from a custom rom, can I use that file in the module with a stock rom?

--update--

I installed a custom ROM resurrection remix and generated the smali patcher module without problems... Works withou problems!

I found that deodexing anything on a modern stock Samsung ROM will trigger DM-verity, that's why it keeps enter in bootloop.

I think the problem is the kernel... But it's what I think
[Magisk] lopans:
Hi!

A week ago I successfully used Smali for patching. Unfortunately I forgot to turn off auto update on my phone and got an installed update. I made a hard reset, removed magisk via uninstall-zip then installed it again. I'm not facing any bootloops so it seems good. But smali returns me an

!!! ERROR: Target JAR must be deodexed.

So I checked my Java version is latest, tryed to run Smali from recovery (with mounted system), also tryed to deodex with Fulmics Deodexer. This tool successfully finish deodexing but Smali says

!!! ERROR: Mock location class not found..

I'm using Redmi Note 4 MTK with android 6.0 MRA58K MIUI version Global 10.2.1.0 (MBFMIXM).

Should I downgrade the phone to previous version or I missed something?
[Magisk] GiordanoPT:
Thank you fOmey for this wonderfull module. Works like a charm on my Oukitel U15 Pro.

Tested on 3.7 and 4.2 flawlessly on stock ROM.
[Magisk] lopans:
So I resolved this by myself with next steps:

- downgraded to december 2018 version of MIUI (seems to be unnecessary)

- twrp -> install super su -> reboot to system

- SmaliPatcher -> successfully patched

- super su -> full unroot

Next by FAQ.

So I missed the necessity of root but why Magisk didn't provide it? Or I missed some Magisk settings before patching?
[Magisk] ptballer:
4.2 runs smoother on Lineage OS then previous patch - Thank You!!
[Magisk] kiki059:
with snali patcher my GPS don't working anymore with maps or Waze. it's Normal?
[Magisk] TheJoker71:
hi smali team... great job... i tried the smali patcher 0.4.2 on my Pocophone F1 with latest Global Beta firmware... and it works great without any issue at all...

only one question... since im using Global Beta firmware from Xiaomi... i will always get a firmware update every week on friday... like Magisk... i need to reinstall Magisk everytime i gets a firmware update... does smali need to do ADB patcher again after i updated my Pocophone F1 firmware?

thanks so much in advance...
[Magisk] fOmey:
I would say no.. but this is very difficult to say 100%.

If they modify services.jar then yes... if not then no? Hopefully this helps?
[Magisk] TheJoker71:
noted... thanks for quick reply...

i just worry that i will experience the same with someone when he tried to do upgrade of the firmware... smali patcher never works again... only solution is to downgrade to the last firmware were smali works... but i will update you of the result... hopefully i will not experience the same...

thanks again fOmey...
[Magisk] Jho_san:
Please help me.. module smali

Hai Eng.Rahman

Sorry my bad english. Can you help me...

Please make me a modul smali patcher, i dont have pc.. :(

iam still odex rom. Stock rom j500g.. magisk v18 with xposed
[Magisk] 0ddj0b7:
I've been running 4.1 on lineage OS 16 without an issue honestly didn't think it could get better but if what you say is true maybe I should give it a try

Edit: quoted the wrong person and had to change it
[Magisk] dheervijay55:
Hi,

Using redmi note 4 Mido 10.2.3.0 miui

I need magisk module for disable flag secure but I stuck on deodexing

Please help sorry couldn't understand how to deodexing

One more query will if pass safety net
[Magisk] thatlovelyguy:
Smali Patcher Crashing

Hello,

I'm trying to run smali patcher after deodexing my services.jar through TOAD. When I run smali patcher and PATCH JAR, smali patcher keeps crashing on me. Can anyone help me figure out why?

[IMG="smali patcher crash"]https://imgur.com/a/0TUiPaW[/IMG] ?
[Magisk] ptballer:
Out of curiosity - did you only tick mock location box? or the other 3 as well? Do you get over heating? My device gets very hot on [ROM][UNOFFICIAL][dreamlte/dream2lte][[SM-G950F/SM-G955F][8.1] LineageOS 15.1
[Magisk] 0ddj0b7:
i believe so but i cant remember off the top of my head. im about 90% positive that's all i had checked when creating the zip file with the patcher.

im running fake gps pro by incorporated labs with no options checked in the in app settings. the only thing i have running outside the patcher is having fake gps pro as the mock locations app in developer settings. I also used magisk hide on fake gps pro

I use the gpx waypoint generator a lot and make my own routes and just let it run with my gotcha connected. during the machop shiny event i saw 1100 machop, got 2 shinys. i never get rubberbanding whatsoever and this is by far the best option ive ever used in my 2 years.

I noticed after awhile of it constantly running it can get sluggish and a tad warm but nothing crazy and a restart fixes the slug

also im on magisk v18.1, and manager 7
[Magisk] sobirin90:
Just to report that I encountered error recently. Luckily I had patched before and saved the file.

fOmey @ XDA

Patcher Version: 0.0.4.2

==> Detected Java: 1.8.0_201

system/build.prop: 1 file pulled. 3.0 MB/s (12571 bytes in 0.004s)

pull: building file list...

adb: warning: stat failed for path /system/framework/miuisdk.jar: No such file or directory

adb: warning: stat failed for path /system/framework/miuisystem.jar: No such file or directory

/system/framework/: 134 files pulled. 25.6 MB/s (78216209 bytes in 2.909s)

==> Dumped framework

==> Detected API: 28

I: Using Apktool 2.3.4 on services.jar

I: Baksmaling classes.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

I: Using Apktool 2.3.4

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.

---------- Post added at 11:53 PM ---------- Previous post was at 11:09 PM ----------

Edit: I am not able to use old file patch because I just recently updated my ROM, therefore I need to patch again. But as you can see, the patcher is not working. I even try the version 0.4.1 and it output the same error. You might wanna look into it [MENTION=1620550]fOmey[/MENTION].

Edit: This morning I able to patch it without error. Could be my office internet issue. Just connect to my phone hotspot and can be done without problem. No issue on your end fOmey. As always good job.

fOmey @ XDA

Patcher Version: 0.0.4.1

==> Binary download complete

==> Unpacked binarys.

==> Detected Java: 1.8.0_201

system/build.prop: 1 file pulled. 1.8 MB/s (12571 bytes in 0.007s)

pull: building file list...

adb: warning: stat failed for path /system/framework/miuisdk.jar: No such file or directory

adb: warning: stat failed for path /system/framework/miuisystem.jar: No such file or directory

/system/framework/: 134 files pulled. 22.1 MB/s (78216209 bytes in 3.382s)

==> Dumped framework

==> Detected API: 28

I: Using Apktool 2.4.0 on services.jar

I: Baksmaling classes.dex...

I: Copying assets and libs...

I: Copying unknown files...

I: Copying original files...

==> Patched mock location boolean

==> Patched mock location boolean

I: Using Apktool 2.4.0

I: Checking whether sources has changed...

I: Smaling smali folder into classes.dex...

I: Building apk file...

I: Copying unknown files/dir...

I: Built apk...

W: Could not find resources

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_7.0-9.0

0 error(s), 0 warning(s)

==> Merged patch: sigspoof_core

!!! ERROR: Magisk module template download failed.

May I know you on what ROM currently for global beta? I'm using mi Globe though. Cheers.
[Magisk] @ayahfachri:
In order for the patcher to work the services.jar must be deodexed. japri aja kalo mau lebih jelas.:)
[Magisk] risoobeon:
I have been using the module for some time now, whilst it's been causing some UI crashes it has been working as well as can be expected. I have a new problem only recently discovered, my two bluetooth headsets have stopped working, they pair but then power cycle and back to not connected. I have a Galaxy watch which is paired and causing no problems and my bluetooth car stereo connects and plays again no problem, any ideas?
[Magisk] BrettB0727:
Tried 0.0.4.2 after factory reset and I am still having similar slow down issues as 0.0.4.0. I am on an Essential PH-1 with 9.0.
[Magisk] PokemonTotalWar:
[MENTION=1620550]fOmey[/MENTION] is there any way to do the compiling on the device itself, using the same method as the OP5T Longshot mod? It says it compiles to VDEX on-device, using this code:

Would this be a better way to optimize the end result, and could it be included in the module created in some way, to get better optimization in the end?
[Magisk] fOmey:
Certainly is, I've not been able to test any of those commands due to device limitations unfortunately.

Converting to VDEX is possible supposedly.. but converting to CDEX however I can't find any info on.

See if you can get a successful services.vdex to generate, report your findings if you do.
[Magisk] blanktape:
need help with mock location error

Hi everyone, I have the mock location error on my redmi note 4 mtk.

Can someone help me out on convert it make it work with Smali Pacther?

Much appreciated!
[Magisk] klickig:
is the source code available somewhere?
[Magisk] ragedz:
Using LG G5 with Fulmics Rom after going stock 20A KDZ. Fulmics Rom comes completely Deodexed. Ran Smali Patcher 4.2, had 1 warning of: warning: type 'com.android.server.pm.PackageManagerService': method 'generatePackageInfo(com.android.server.pm.Package Setting, int, int):android.content.pm.PackageInfo': (PackageManagerService.java:35): 'private' modifier added to replaced method. No Errors. Zip was generated. Tried both TWRP and flash from Magisk, both most current versions. Either way sends G5 into bootloop. Had to TWRP to restore backup both times. Anything here that I'm missing? Is this simply not working with Nougat 7.0? Tried with default options ticked and with all options ticked when generating zips, everything results in bootloop. Any help?
[Magisk] @ayahfachri:
what firmware are you using? Rom has to be deodexed for the patcher to work.
[Magisk] jhonathantanada:
the deodexer and the module works on android 9?
[Magisk] gunkids:
can anyone give me cusrom of Andromax A (A16C3H) with a smalipatcher. i try to deodex cusrom (viperos) but failed T.T

please, i need that.

thanks
[Magisk] Senliast:
Awesome, does what it should quickly and easy. Thank you!
[Magisk] austin_5118:
Instructions aren't very detailed... Could I do this on a phone with a locked bootloader and thus no twrp like the s9 simply via adb?
[Magisk] fOmey:
No, you need to replace files in /system.. therefore you need some sort of root access, which requires a unlocked bootloader.

If you have suggestions for instructions, I'm all ears.. tell me how I can improve them.