yashsingh1/xdaforums huggingface dataset:
[Magisk] lividhen99:
So, magisk is a "systemless" root / superuser solution, with a specific framework to support Systemless modules. Systemless meaning that it doesn't touch your /system folder,so that you can still use apps like Pokémon go and use banking apps. There are 2 parts to magisk, magisk root and magisk manager. Magisk root, or SU, or, well... ? the zip, you either have to flash through a program on the computer such as odin3 for Samsung phones, or you can use twrp, which is a custom recovery. This flashable zip installs the magisk framework, which has superuser, magisk hide, and support for Systemless modules. Magisk manager,which is the app part, can then manage and grant SU requests, hide root from certain apps, and manage and install modules. One such module is Smali Patcher. Don't forget to unlock your bootloader if nessisary.
[Magisk] raoabdullah:
Why no one is replying to this issue... It has been asked before by many users..
[Magisk] iamelton:
probably cos no one here has a crystal ball to see through your "issue"?!

seriously, you need to provide detailed error log for a meaningful issue report..
[Magisk] jatintomar:
Is there any way to use this patched framework without root like putting into system through adb by gaining temporary root
[Magisk] raoabdullah:
How to provide a logcat when it just stuck on Patching classes... It doesn't provide any zip to flash on android device..
[Magisk] lividhen99:
No, this is a magisk systemless module and will only work by flashing and enabling the module in magisk manager, magisk will then load the module at every boot, systemlessly patching the services.jar, the good thing about magisk though, is that you can, basicly, completely hide root from the rest of the system.

If you are using this for Pokémon go, you can try vmos or virtual xposed.

---------- Post added at 04:27 PM ---------- Previous post was at 04:19 PM ----------

No, not a logcat ?. He means the log from the smali patcher program. Also, which device and rom you are using would be helpful. Here is 5.5 if you want to try it. I seem to have a lot less problems with it.

https://xdaforums.com/apps/magisk/module-smali-patcher-0-7-t3680053/post80168363
[Magisk] Suryo75:
hello guys, can you help me with my problem with this ?

!!! ERROR: The specified executable is not a valid application for this OS platform

i use pie android version, cr droid ROM, device lenovo a6000

result is still done but it is not working for spoof location
[Magisk] kjhanjee:
Hi guys,

My system is giving me some issues, it gives me an error: error extracting classes.odex. I have extracted my services.jar, device is oneplus 6t. Can someone, please, help me out by creating a module for it?

https://drive.google.com/file/d/13O037EdudBBFgreySMjybCSSq59ZpsAe/view?usp=drivesdk
[Magisk] PoochyX:
It will get better

([emoji3590]09-09-18[emoji813])
[Magisk] aguspc77:
not work in mi 8 pie
[Magisk] kjhanjee:
Oh, the good times!

I hope it does. Cause I followed everything correctly as per the instructions, latest jre, .net, adb drivers, binaries downloaded, mounted system in twrp, and it gives me this error. Have been at it and on google for an hour now. No luck. And I just pulled this services.jar from my phone's framework folder. I hope that wouldn't be an issue for anyone trying to help out.
[Magisk] fOmey:
If you have a custom recovery, absolutely.. you can replace the original services.jar & delete the .odex/.vdex files.. backup backup backup.

I'm sure instructions can be found somewhere in this thread..

As for anyone having issues, you need to provide more info... "not working on pie", "stuck at patching classes" does not help at all.. my own phone runs pie, everything was tested on pie and works fine here.. I don't get stuck at patching classes.. do you see what I mean? :)

You need to be very detailed with your messages, paste the entire patcher log in your message (don't just quote the error), upload the "adb" directory to google drive or alike so I can review the files.

Its the only way I can try and figure out what is causing you issues, its impossible otherwise.. all I have is the information you provide to help you, the less you include the less likely your problem will be resolved.
[Magisk] A30NI_Y:
You need to provide the whole framework + build.prop. The service.jar you provided was not deodex so cannot be patched.
[Magisk] runningslow:
Its working fine on my OP7Pro (sim unlocked T-Mobile variant) on OB1.

Smali Patcher 5.8, Mock Locations only, Magisk 19.4
[Magisk] lividhen99:
Go into the magisk settings and there should be an option near the top to hide magisk manager.
[Magisk] mdxdave:
Working on the Xiaomi Mi 9 with Xiaomi.eu Rom (Android 10).

Thanks for your efforts.
[Magisk] Scarlet D.:
Hey fOmey

I've sent you a private message with a link to services.jar uploaded to mega.nz some days ago, since I only have one post and I can't post links to mega.nz here, I see there is a way to upload things here directly but I can't quite find a button.
[Magisk] lividhen99:
On the xda app it's right here, and on the website there should be an upload/manage files or something button below the text box. The services.jar and the framework, might be too big though.
[Magisk] Scarlet D.:
Don't wanna get off-topic but I downloaded the app just for that and it gives me a "bad request" error when I am trying to upload it, the file is only some bytes thought. Well, then let it be I guess, I hope he will see my message and dig-in his private messages.
[Magisk] aNGERY:
Anyone else with OB1 on the OP7 Pro having issues forcing location? It sort of "times out", and you need to go to location/advanced/google location accuracy and toggle it from on to off then back to on. then it sticks.
[Magisk] sgtkwol:
Having issues getting this running on Ubuntu. It just hangs at "Executing prepatch checks...". Any way to just manually run the commands with "java -jar..." or could someone patch in mock locations for me?

Edit: trying to figure this out on my own, in the meantime. Deodexed the services.jar but can't figure out how to apply the patches.
[Magisk] lividhen99:
Try again soon, xda is weird sometimes. Also try selecting using a different file app. There should be a thing that swipes out on the left, and at the bottom there will be options for other file explorer apps.
[Magisk] Slowking:
With patcher 0.0.5.8 I get "!!! ERROR: Failed extracting classes.cdex" I tried running the patcher in admin mode and putting the phone into recovery mode. Nothhing helped.

Thing is patcher 0.0.5.2 (I still had that version lying around) completes without an error. Doesn't even have to be in admin mode.

What could be the problem here?

[INFO] fOmey @ XDA
Patcher version: 0.0.5.2
==> Binary download complete
==> Unpacked binarys.
==> Detected java: 1.8.0_161
==> Dumped framework
==> Detected API: 28
[INFO] Processing 1 file(s) from bin\services.vdex
[INFO] 1 out of 1 Vdex files have been processed
I: Using Apktool 2.4.0 on services.jar
I: Baksmaling classes.dex...
I: Copying assets and libs...
I: Copying unknown files...
I: Copying original files...
==> Patched mock location boolean
==> Patched mock location boolean
==> Patched high volume warning function
I: Using Apktool 2.4.0
I: Checking whether sources has changed...
I: Smaling smali folder into classes.dex...
I: Building apk file...
I: Copying unknown files/dir...
I: Built apk...
==> Magisk template download complete
==> Generated magisk module zip file
*** Complete ***

fOmey @ XDA
Patcher version: 0.0.5.8
==> Binary download complete
==> Unpacked binarys
==> Detected java: 1.8.0_161
==> Dumped framework
==> Detected API: 28
[INFO] Processing 1 file(s) from bin\services.vdex
[INFO] 1 out of 1 Vdex files have been processed
==> Extracting classes.cdex
!!! ERROR: Failed extracting classes.cdex

I would have tried versions in between, but I can't find older versions for download.
[Magisk] lividhen99:
I'v has everything up intil 5.6 work, here is 5.5 https://xdaforums.com/apps/magisk/module-smali-patcher-0-7-t3680053/post80168363
[Magisk] fOmey:
Yup received it, haven't had a chance to take a look yet.. will do soon.. I needed the entire "adb" folder btw, not just the "services.jar". :p

In the meantime try running the patcher while booted in TWRP with /system mounted.. might just solve your problem.

Usually the problem your experiencing is due to a permissions issue which can be bypassed by running in recovery mode.. some manufactures are over protective with their precious files.

No, its the .exe thats patches the files.

It seems to be expecting to see a file and not finding it (could be caused by a mistake in the "error checking" I added).

Can you show me a screenshot of all the files in the "bin" folder (the failing patcher version)?
[Magisk] fc_themaster:
Magisk 19.4? Canary?
[Magisk] runningslow:
Yes, Canary.
[Magisk] RG_007:
I have one question sir

How install smali on twrp without magisk ?

If im install any magisk installed succesfully, but if without magisk always error 1

Because if any magisk always detected rooting or jailbreak
[Magisk] lividhen99:
Are you making sure that pokemon go is enabled in magisk hide?
[Magisk] RG_007:
Im just want test without magisk, without push system from rootex but just install in twrp
[Magisk] Olorin92:
Not sure if this is up to Google to fix or if it's a change that breaks Smali Patcher, but Google Play Services 19.2.75 seems to cause rubber banding (even with everything installed correctly).

Noticed this today after no issues for months. Hopefully an easy fix in any case!

Let me know if you need any files from my device to help diagnose.
[Magisk] A30NI_Y:
If not mistaken (I might be wrong), you can do so by unzipping the patch generated by Smali and copy / paste the service.jar file to your framework folder, infact you need to replace all the files found in the patch and replace it to your original framework. However, those files in the patch with 0 byte, you need to delete those file in your original framework in the correct folder location. So, do backup those files first if something goes wrong!
[Magisk] fOmey:
Yup, Google looks like they broke the mock location patch.

Either have to patch play services or patch the core framework to get around this one.. xposed might be a better route to take tho, unless that's broken aswell? Would you like to test and report back, trying to decide if its worth working on.
[Magisk] Olorin92:
Sure I'm happy to have a play around if it helps.

I've never used xposed though - could you give me a quick run down and what it does differently to just the stock smali patcher and stock framework?

I'll admit I'm using this purely for Pokemon Go though, so it all depends on whether or not having xposed increases the risk of getting banned/if there's any compatibility issues between the two :P

Also happy to contribute to your beer fund if that helps to get you over the line ;)
[Magisk] fOmey:
Look up edxposed, follow the instructions.. pretty straight forward, its a magisk module. It depends on another module.. so you'll need to install both edxposed & riru. Everything is explained in the instructions, pretty sure they are both available on the magisk repo.

Then just install the xposed mock location module and test.. pretty sure edxposed is not detected by pokemon go, at least it wasn't... not sure if that has changed.
[Magisk] essamo09:
p1

تم الإرسال من INE-LX1r باستخدام Tapatalk
[Magisk] z1rqdym:
just installed riru core + riru edxpossed from magisk + xpossed installer . after installed https://repo.xposed.info/module/com.balamurugan.pokemongojoystick2 this module from xpossed app and activeted. choose app ninjas gps joystick from mock locations settings. it seems to be work but my devices temperature increased a bit.

update: just uninstalled this joystick app from xpossed. edxpossed + smali patcher + app ninjas gps joystick works like a charm.

Update 2: wont work anymore after a few hours.
[Magisk] Syoenth:
what's the module name I must install?

---------- Post added at 11:11 AM ---------- Previous post was at 10:35 AM ----------

share your settings, with me the GPS joystick still rubberband and returns me to my original location
[Magisk] z1rqdym:
Just installed gps joystick from playstore i didnt touch any settings.
[Magisk] caspaas:
Running Razer Phone 2

Android 9 Deodoxed zipaligned ROM.

[r11] arter97 kernel for Razer Phone 2

Magisk Canary-Bleeding edge

Smalipatcher

But i can't install unsigned on top of other apps?

Like how do i install them.....
[Magisk] Olorin92:
To clarify - when you say it won't work, are you meaning you can't spoof at all? Or you start getting the rubber banding?
[Magisk] Kermit223:
Turning your GPS to device only mode or just turn off high accuracy for location setting has fixed the issue with rubber banding for me and others reports on Reddit.

If you play legit just make sure to turn on high accuracy when you login and if you start spoofing just turn of high accuracy

---------- Post added at 01:20 AM ---------- Previous post was at 01:20 AM ----------

Turning your GPS to device only mode or just turn off high accuracy for location setting has fixed the issue with rubber banding for me and others reports on Reddit.

If you play legit just make sure to turn on high accuracy when you login and if you start spoofing just turn of high accuracy
[Magisk] AncientAnt:
I've tried with EdXposed + Smali with GPS Joystick, however it still rubberbands despite using a mock location module. Hope this information helps.
[Magisk] fOmey:
You'll start rubber banding.

You sure you're on the latest Google play services?

When you say mock location module, I'm assuming you mean xposed mock location module?
[Magisk] AncientAnt:
Yes, however as mentioned before, using phone sensors only in Location settings does fix that rubberbanding issue.
[Magisk] Syoenth:
what module I must install? do you have the link of the repo?
[Magisk] fOmey:
Not sure to be honest, you'll have to test.

On another note, thankfully I prepared for this day by adding multi-file patching a few versions ago.. I have a experimental working solution.

This is the first time the patcher has patched a file outside of the services.jar! Exciting stuff haha.. seems to be working great during my testing.. going to continue test over the next few hours to make sure I don't notice any strange behaviour.

If I consider this stable, I'll push an update shortly. Using ADB method is going to be highly highly recommended in the future versions because we are now dealing with multiple files.

I might have to rework the browse functions to instead point to a framework directory instead of a single file.. however this will come in the future as I'm not exactly sure how I want to do that yet.

There is also been reported issues with certain users while using the ADB method, which I'm hoping to fix before releasing the new version.. if I'm provided enough info to do so that is (please please please if you report a issue and I reply with further questions, make sure you reply!).

Anyway, time will tell..
[Magisk] Syoenth:
I prefer to wait the fix you're doing, my friend, you saved the life of all who play Pokemon Go, keep doing the good work

Ánimos! (cheers)
[Magisk] fOmey:
CHANGELOG ::

5.9 [EXPERIMENTAL]

Mock location patch updated.

Adapted backend functions to support multi-file patches.

Browse for .jar has now been changed to browse for "/system/framework" directory.. no longer requires a deodexed file to be targeted, will deodex necessary files if required.

Backup, backup, backup!
[Magisk] Spartacus500:
[MENTION=1620550]fOmey[/MENTION]

Could you add two patches for Smali patcher for services.jar and core-oj.jar ? It's about these two patches :

-Disable apk file signature verification

-Signature verification is always correct
[Magisk] fOmey:
I can look into it, can you give me a example of the patches? Pretty sure we already have one of them.. just not sure which one.

CHANGELOG ::

6.0 [EXPERIMENTAL]

Fixed index out of bounds crash.
[Magisk] Kiwi8:
Hi there!

I am using Smali Patcher 0.0.6.0, and trying to patch my phone's services.jar.

It seems that the Patch Option for "Mock Locations" disappeared.

What should I do next?

Thank you in advance.
[Magisk] Spartacus500:
Services.jar uses a different patch, and the two I have given are not applied, (priv). I don't know how to do these two patches on Android 9.0 Pie.
[Magisk] Phantom Thief:
Read a few posts back. Mock Locations patch was broken on the newest google play services version
[Magisk] A30NI_Y:
Tested 6.0 on a Xiaomi Pocophone. Unfortunately, pogo gave error failed to detect location (12). Switched back to a previous version without this error.
[Magisk] fOmey:
What android version are you on?
[Magisk] A30NI_Y:
version 9
[Magisk] z1rqdym:
i tested on android 9 lineageos 16 works great thanks for your work
[Magisk] Fre$h:
Tested on an HTC U11 with stock Android 9 ROM. Gplayservices is 19.2.75 and security patch is June 2019. Same issue for me => the game is loading correctly but end in an error 12 too.

Installing back 0.0.5.8 Smalipatcher is fixing the issue
[Magisk] stranger-mj:
Had the same problem on HTC U11 Dual SIM, with Pie (Unoffical LineageOS by thomascus) with version 5.9 (which I discovered and tried like 5 seconds before 6.0 appeared).

Not going to try 6.0 now, as I feel I'm going to have the same result. Just wanted to let you know that version 5.8 had no issues regarding that, but 5.9 does, and obviously 6.0 too... So I installed 5.8 again and am running smoothly! Playing PoGo in Texas atm, while I'm actually in Europe... LOL

Other than that: thanks for a great tool!!! Been using it since 5.0 or so, very happy with it!

ONE more remark... Not sure if it's SmaliPatcher related or not, but thought worth mentioning:

Until 5.9, I have had trouble running SmaliPatcher while using adb with phone booted to OS (stuck on Pushing files) and have made a habit of booting into TWRP, mounting System and taking it from there. With 5.9, the latter didn't work (SmaliPatcher exited without creating the zip file), yet running while Android was booted did work this time... No clue if it's related, but it might help you pinpoint the issue... (and if not, sorry for bothering with a bunch of useless text! LOL)
[Magisk] fOmey:
Confirmed here, very strange.. I must of broken something.

I'll remove the download link and restore the older version till I fix it.
[Magisk] stranger-mj:
Forgot to mention: I'm on GPlay Services 19.2.75 as well, and have the August security patches...
[Magisk] Rehvix:
Hello!

Using an s7 edge on android 9.0 and Play Services 19.2.75. If you're looking for someone to test your revised version of smali patcher I'm all for it. Or any other fix for PoGo.
[Magisk] Pekkle168:
I have the same issues.. Any pogo players here care to share how they got it to work on the latest pogo? Is this because I am running on the Smali 58 and should have used 59? TIA!
[Magisk] lividhen99:
Do you have any other popular apps that use root, or change location. If so, uninstall or change the package name. If you don't, download root beer sample in the Google play store, hide it from magisk, and then do a root check. If it fails your saftenet has been broken. Or something is not being hidden correctly.
[Magisk] cmstew:
Make sure you hide the Magisk Manager app itself too. If you don't, that's a sure fire way to get caught.
[Magisk] cristianodk:
where can download new version??
[Magisk] fOmey:
I haven't had much luck fixing the new versions, at this stage I don't see an easy fix.

The modified files are being verified on boot and failing, I'm guessing the tools are struggling to recompile accurately.. because the failure isn't being caused by any of the files we are patching.

I think the only way around this would be to decompile the entire framework directory.. which is way outside the scope of this patcher, but I'm pretty sure this will fix the problem. This is a route I'm not willing to take tho.

I'll keep doing some research, but at this stage I don't want to give anyone false hope waiting for a update.

I'm honestly thinking about merging the patches over to xposed, rather than wasting time trying to figure this out.. I just don't know how long xposed will be around for until it gets patched.

Also xposed is currently only supported up to android 9 (aka. pie)... I'm sure this will change in the future tho.

Anyway thats all for now.. we shall see!
[Magisk] Pekkle168:
Thanks! I started fresh again from stock rom and root the phone and after everything is loaded I tested with root bear and it says I was fine with no root. However the first time launching the pogo it actually told me it was not supported.. However after double checking everything and nothing was out of place, I retried the pogo and it actually worked and it has worked for 3 to 4 times consecutive launches. Thank you very much!

---------- Post added at 12:59 AM ---------- Previous post was at 12:57 AM ----------

Thank you, I think that's what made the difference. I actually hid the Magisk, however the first time I tried pogo it still says not supported, however subsequent launches it is now working fine. Thank you once again!
[Magisk] cmstew:
I'm not sure what the deal is but I'm running Android 10 with the fully up to date play services and I don't have trouble with pokemon go. I do have to make sure I turn off Wifi and Bluetooth scanning, and location accuracy. But once that's done, I have zero rubber Banding. I used the last stable smali patcher right after Android 10 came out.

No problem. I noticed they started detecting the Magisk package name a while ago and had to start hiding magisk manager too.
[Magisk] Xionyus:
I'm trying to use Smali patcher and I get stuck on Copying original files for like over 10 minutes now and I do not remember this happening to my other phone. This is my mom's phone and she does have like... 10gb of useless **** on her phone so I'm not sure if it's that or if I'm running into an actual problem. I've restarted my phone and smali twice already with the same results. I think I'm going to let it run for an hour before I finally just give up and wait for an adult to help me.
[Magisk] fOmey:
Some users reported rubber banding on the latest play services, I also experienced them yesterday..

The odd thing is tho, today the original mock location patch is working fine.. however I did notice that my location accuracy setting was re-enabled tho? Not entirely sure how that happened.

I'm so confused! I guess working on that new patch was a waste of time.. :silly:

Thanks for confirming it still works and mentioning the location accuracy setting.. I probably wouldn't have checked them otherwise.

I've decided to re-release 6.0 using the original mock location patch.. should make life easier for anyone patching files for people, they can skip having to deodex.

Try the newer release, remove any old files.

CHANGELOG ::

6.0

Fixed index out of bounds crash.

Revert mock location patch to the original.

5.9

Mock location patch updated. Reverted patch back to the original in 6.0.

Adapted back end functions to support multi-file patches.

Browse for .jar has now been changed to browse for "/system/framework" directory.. no longer requires a deodexed file to be targeted, will deodex necessary files if required.
[Magisk] Xionyus:
Stuck at this now after 10min

edit: Is there any files I need to delete on my phone? Deleted everything from PC. Using a Galaxy Note 5 btw. Would I run into any luck trying a different USB? :S
[Magisk] fOmey:
Has nothing to do with the phone, this is all happening on the PC at this stage.

I can see its trying to generate the classes (bottom left), might be running out of memory or something so its crashing.. can't see any errors tho.

Slow PC?
[Magisk] moontheto:
Hello, I wanna ask something. Can I update the service.jar that patched by 5.8 to newest smalipatcher 6.0?
[Magisk] Xionyus:
My computer is super fast, I built it myself. i7-8700 and 16gb of ram. Do you think the USB cord could be the culprit?

Edit: Is there anything I can do to show errors or send an error log?
[Magisk] Ijp1999:
Exact same issue and phone. Tried a different computer too.