yashsingh1/xdaforums huggingface dataset:
[Magisk] mv0hra:
[MENTION=5228676]VR25[/MENTION], with the latest version of Magisk the latest beta version is now working on the Oneplus 6 (Pie).

EDIT: Spoke to soon, it worked only on the first charge cycle. I have attached the logs.
[Magisk] gorilla p:
This doesn't seem to be working with the latest OOS release on the OnePlus 5T either.

I'm trying the latest beta now and trying to figure out how this works.

Is it enabled at 70/80 by default?
[Magisk] mv0hra:
Yes. You can set the values in config.txt (root/data/media/mcs)

The latest beta version specifications are in the second posting and not the first one like I had presumed.
[Magisk] davidk21770:
I had to disable this a while back because with it I couldn't use my gps in the car. My phone slowly discharged even though it was connected to good power. With it disabled, no problems.

I thought that I reported it, but I can't find my post to check for replies so I must not have ?.

Does anyone else see this? Has it been resolved?
[Magisk] Da-BOSS:
I can confirm that mcs is working greatly with the new magisk 18.0 ;) just wanted to let you guys know... no issues for me here :) I just simply updated my magisk... that's all ;)
[Magisk] paolocorpo:
I am on the same page

No issue with Magisk 18.0
[Magisk] VR25:
ANNOUNCEMENTS

Unfortunately, my internet connection is poor atm. I can read posts, but replying is a pain.

The good news are, I can still push updates to the repository and I'm working on the next stable version (almost ready). New features coming...

Yes, I'm aware of Magisk 18. The latest beta is compatible with it, but it must be installed from recovery.

Again, I've been reading your posts just fine. I may not be able to post decent stuff here for some time, though. So, check for updates on Magisk Manager every 2 days or so.

Those who want to chat, message me on the Facebook page. I have no issues surfing there.

P.S., the module has a new name: Advanced Charging Controller (acc). Criticism and suggestions are welcome.
[Magisk] paolocorpo:
Thank Developer,

I have not Facebook account and so I will check here or with Magisk Manager too

I hope to see you asap

Ciao

Paolo

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] davidk21770:
Unfortunately, I also do not have a Facebook connection and will be waiting here - thanks! ?
[Magisk] paolocorpo:
Thank

I am confused:

I have to uninstall mcs before to install the new one ?

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] paolocorpo:
Probably is too late for me ... but ... I am not able to find the download link for last acc
[Magisk] Bortex19:
Download it from magisk
[Magisk] paolocorpo:
I found it but usually [MENTION=5228676]VR25[/MENTION] has the habbit to attach the zip file in 3° post too ...

Anyway ... thanks
[Magisk] Bortex19:
Maybe he still has bad connection.

You are welcome.

By the way, everything seems to work. I had to copy the config.txt to another folder, edit it there and then copy and paste it in the original folder again.
[Magisk] mv0hra:
I can't find it. Looked for Advanced Charging Controller and Acc. What did you look for?
[Magisk] Bortex19:
Exactly that.

Try with "advanced charging controller (acc)"
[Magisk] Axel85:
Hi , I have a maybe stupid question. With those kernel tweaks is possible to implement a usb power pass through? I mean disable battery charging and drain power from power supply? Should be enought . With my nexus 6 I can reach 2 Ah no problem and should be enough. Sadly digging on internet I found something yesterday and can't find it no more. I dont remember if a one plus in a rom or directly a custom rom like linage tried to implement it controlled via a tile . I don't know where to ask better than here
[Magisk] phantom146:
[MENTION=5228676]VR25[/MENTION] on magisk 18.. everything worked from the 11-24 build however the build right now doesnt work with the same setup.

Edit: my phone reached to 100% not the desired amount.

Attached are the logs:
[Magisk] J4jks:
Installed latest stable, acc ,on Magisk18.0, but with it xposed failed, shows installed but not active.

Anybody faced this.

I'm on Moto G 2014, los microg+systemless xposed.
[Magisk] RMarques:
I just installed the let latest ACC version but I can't set values. No matter what there is shears a message saying "charging switch not set"

[MENTION=5228676]VR25[/MENTION] use to put examples of commands but it seems that not anymore...or I'm not even sure what is going on anymore.

Can anyone shed some light over here?

I want to set it to 80 95
[Magisk] VR25:
[MENTION=2563184]Axel85[/MENTION], this is device-dependent. I'm investigating it.

What I know so far is that some devices draw power directly from the external power supply when charging is disabled below 100% battery capacity (my harpia does that, but not always). However, when the battery is full, most (if not all) devices draw power directly from the external power supply.

Samsung's batt_slate_mode charging switch may work exactly as we expect, every time. I can't test that further since I don't have any rooted Sammy around.

Tests on my current device (Moto G4 Play) suggest that it won't boot into system nor recovery without a battery. The bootloader works in such condition, though. I tested with AC adapter and USB power supply.

It seems there's something in the kernel (could be init.rc) which turns charging off temporarily while system/recovery boots.

I'll keep sharing my findings on this.

[MENTION=2876919]pantho[/MENTION]m146, you missed the acc-daemon-$deviceName.log file. Unfortunately, I wouldn't be able to download it atm anyway. Try changing the charging switch by running <acc --set switch>.

Test with <acc --enable> (enable charging) and <acc --disable> (disable charging), then restart the daemon with <acc --daemon start>.

[MENTION=6697942]J4jks[/MENTION], I don't see anything in acc which could mess with Xposed. Does disabling acc "solve" the problem?

What about temporarily disabling just its boot script (/sbin/.core/img/acc/service.sh) by renaming it?
[Magisk] VR25:
[MENTION=5094347]RMarques[/MENTION], try <acc --set switch> then <acc --set capacity 5,60,80-95>

5: shutdown capacity (works only when battery is not charging)

60: cool down capacity (when the cooling engine kicks in)

80: resume capacity

95: pause capacity
[Magisk] xtam:
[MENTION=5228676]VR25[/MENTION] i have a question:

for example in default settings, cooling engine (pausing) kicks in, starts, when:

a) capacity is at or above 60 AND temperature is above 45C

or

b)capacity is at or above 60 OR temperature is above 45C

?
[Magisk] Axel85:
Thank you for the reply, but what I would like to accomplish is a little bit different . With something like a tile or a switch you can choose when to use it. I don't want to remove the battery, just bypassing it on needs , so less heat is generated and less degradation . I read a university research on batteries and it's more compless than it looks like to charge a battery in a good way. The best method to have less degradation is to stay between 20 and 80% and phone should be charged from powered down. Even a good awg cable makes a great difference in battery life and degradation . The abits to use it while charging is a disaster for the battery due to microcharges and heat , battery would depleat its life ( life not charge) in less time .

Sadly I couldn't find no more that page... An investigation could be great because if I'm not mistaking the smartphone or rom i read about was a something like lineage os or another with community support , so maybe a port it's feasible . I clearly remember the dev telling to use it with at least a 2Ah charger , due to lags or hangs generated by low power pass trough by the supply
[Magisk] mv0hra:
Found it, had to sort the modules in alphabetical order. It does not appear if you use the search option.
[Magisk] paolocorpo:
Dear [MENTION=5228676]VR25[/MENTION],

I installed last acc module over the last mcs beta

Magisk 18

I set max capacity to 85 and resume to 80

I plugged device with 46 to AC charger

Very probably in a couple of hours it got 85

And in 6 hours it lost 2% (over night)

I found it at 83%

I plugged to lighter adapter of car with 79%

It got in few minutes 84%

So ... All seems to run well and as expected

Thank you

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] xtam:
ok i see that it is OR (b).

How can i set it to make like in (a), so cooling begins only above 60 or x capacity?

Btw, second thing:

i currently have:

acc -s:

capacity=3,60,70-80

coolDown=50/10

temp=400-450_90

note 8 - galaxy samsung g950fd

and after 60% cooling engine kicks in (even when temp is 297),

and when i have screen on i can see on battery lighting switching correctly, but when i have screen off RED LED only turns offs, not turns on after wait time, i have to pres power and press power again to light red led again.

So i can see this behavior of turning on and off (cooling engine) only when screen is on on battery icon.

Red led is not relighitning when screen is off.

TLDR:

1.i would like to be able to set, that cooling engine begins checking if temperature is between min and max and if above max - do PAUSE,

only when

capacity is above 60 or set by me value.

2.Red charging led indicator does not turns ON again after cooling engine pauses charging, althought on turned on screen i see that battery icon is changing correctly from and to with lighting symbol.
[Magisk] VR25:
[MENTION=3525574]xtam[/MENTION], the cooling strategy aims at reducing both voltage and temperature induced stress. Hence, by default, it kicks in when battery capacity is greater than or equal to 60% (which is generally the threshold at which battery voltage starts going out of wack) OR (not and) temperature is between 40 and 45 degrees Celsius. When temperature is at 45 or above, charging is paused for 90 seconds, allowing battery to cool down. All these values can be changed.

[MENTION=2563184]Axel85[/MENTION], I wasn't clear enough and forgot to mention the tile. However, I understand what you want and I touched the internals of how it works. Removing the battery was just a test. Of course, you wouldn't do that in normal circumstances. And yes, keeping battery capacity between 20 and 80% is good, but 40-60% is much better, being 40% the best overall.

That ROM you mentioned very likely comes with a modified kernel in addition to the tile. That's why I mentioned, "...kernel temporarily blocking charging on boot."

I'll dig deeper into this.

[MENTION=5056724]paolocorpo[/MENTION], glad it's working for you too...

___
[MENTION=3525574]xtam[/MENTION], I'll get back to you soon.
[Magisk] mv0hra:
[MENTION=5228676]VR25[/MENTION], unfortunately this is not working on the OnePlus6, Pie. The older version of 'mcs' did work but only when one charge cycle had completed. The Beta version of mcs did not work at all.

Something similar called 'Blex' on Magisk and 'Battery Charge Limit' on the Playstore both work however, they both have their own issues.

Blex will make the phone vibrate for no reason and Battery Charge Limit will sometimes work and sometimes discharge rather than charge.

Still have not found a solution. :(
[Magisk] Da-BOSS:
Testing acc right now on my Note 9.... will report later ;)
[Magisk] puhu:
Acc is newer mcs or its a New thing? What Can i Do?

MI 5 cihazımdan Tapatalk kullanılarak gönderildi
[Magisk] VR25:
[MENTION=255070]mv0hra[/MENTION], try a different charging switch. Run acc --set switch to see a list. The first switch on the list is the default.

Also, please upload logs (separately).

Thanks

[MENTION=3525574]xtam[/MENTION],

1) Not possible atm

What you can do is increase the temperature thresholds. Generally, however, you shouldn't worry about this at all.

2) Device-specific issue, try running acc --set switch "./battery/batt_slate_mode 0 1"

[MENTION=4383800]puhu[/MENTION], mcs is now called acc (Advanced Charging Controller). Read the documentation and Download the module from Magisk Manager. I can't update the thread, nor upload zips at the moment, due to poor internet connectivity.
[Magisk] mv0hra:
I tried this before but it made no difference. The attached log file is all I could find.
[Magisk] Da-BOSS:
[MENTION=5228676]VR25[/MENTION]

I am using the latest acc now from magisk manager directly...

Well.... unfortunately it doesn't work as intended (again!) same issues like before.... :) I edited the config file to stop charging at 86% and resume charging when it is under 84% but... it only reaches 70% only :( and stops there... once it goes under 70%... it will begin or resume charging until 70% and then stops :(

Here is the logs on my attachment.. :)

I tried & rebooted 3 times... without deleting the logs so that maybe you can catch something about what is going on... :fingers-crossed:

Thank you :)
[Magisk] puhu:
Its always charging and stop. Its about cooldown option? How can i disable it? I cannot charge my phone there is something 50/10 its mean 50 sec charge then 10 sec pause? How can i change it? I cannot find about something it

MI 5 cihazımdan Tapatalk kullanılarak gönderildi

---------- Post added at 04:53 PM ---------- Previous post was at 04:32 PM ----------

I cannot understand acc - s <var> <value>?? And how can i change cooldown parameters?

MI 5 cihazımdan Tapatalk kullanılarak gönderildi
[Magisk] bjm51591:
Hi, I'm just new here

After reading and some study. ACC won't work unless if the switch path is set. After some time I found the switch path for my device:

/sys/class/power_supply/battery/status

(There's no 'charging_enabled' file, can't find it anywhere.)

But instead of 1 and 0 for On and Off value, it says "

'Charging' for On value and 'Not charging' for Off value.

So I provided the switch path with 'Charging' for On value and 'Not charging' for Off value.

Will ACC work with those switch path settings?

---------- Post added at 05:04 PM ---------- Previous post was at 05:04 PM ----------

Hi, I'm just new here

After reading and some study. ACC won't work unless if the switch path is set. After some time I found the switch path for my device:

/sys/class/power_supply/battery/status

(There's no 'charging_enabled' file, can't find it anywhere.)

But instead of 1 and 0 for On and Off value, it says "

'Charging' for On value and 'Not charging' for Off value.

So I provided the switch path with 'Charging' for On value and 'Not charging' for Off value.

Will ACC work with those switch path settings?
[Magisk] paolocorpo:
Yes it is cooldown strategy

You can change it editing the config.txt file

It is into:

root/data/media/0/acc

Ciao
[Magisk] puhu:
Ohh i found it already but thanks.

I did my Configuration like that screenshot but cooldown not not working with temp. Already battery is 41 degree but still not cooldown active? Am i thinking something wrong?

Sorry about my English

MI 5 cihazımdan Tapatalk kullanılarak gönderildi
[Magisk] VR25:
[MENTION=255070]mv0hra[/MENTION], [MENTION=4575578]Da-BOSS[/MENTION] and others facing charging control inconsistencies, run acc --set alwaysOverwrite true and see whether it solves the problem.

[MENTION=4383800]puhu[/MENTION], yes, that's coolDown in action.

acc --set variable value

To disable coolDown, assign a null value to it by running acc --set coolDown

[MENTION=7440458]bjm51591[/MENTION], acc automatically sets a switch if it is available and it works. It has a database.

If your device doesn't have any of the supported switches, then obviously nothing will be set.

...battery/status won't work.

Please, upload /sdcard/acc/logs/acc-debug-$deviveName.log. This file is a dump of your system's power supply info. If a suitable switch exists, it is usually found there.

The other file (acc-daemon-$deviceName.log) is a runtime log.
[Magisk] RMarques:
[MENTION=5228676]VR25[/MENTION] Any clue about why is it charging as if ACC isn't working at all?
[Magisk] mv0hra:
Nope, still not working.
[Magisk] bjm51591:
Wow!

Thanks for the quick reply!

Here are the log files.

I hope this will support my device in the future.
[Magisk] Da-BOSS:
Thank you!! It immediately solved the problem! now it is working wonderfully ;):):highfive::fingers-crossed::victory::cool:

yea... I like using emoji alot... I'm Da-BOSS I can do whatever I want...:D

Thank you BOSS!! :)
[Magisk] VR25:
Is the battery actually charging or is that just the charging indicator misleadingly telling you so?

Do you see "charging" under settings or on the battery tile?

Run acc --set alwaysOverwrite true

Your device has some interesting and unique power supply extensions/features, but we'll discuss these later.

Lets debug this thing first.

Issue 1) Your device has many more charging switches than a regular Android smartphone.

- Run acc -s s to change the charging switch.

- Run acc -e and acc -d to test it. These commands enable and disable charging on demand, respectively.

Issue 2) The absence of acc-daemon-$deviceName.log suggests that acc daemon (accd) is not being started by Magisk.

- Try starting it manually by running acc --daemon start
[Magisk] RMarques:
It just charges as it normally would do without ACC installed.

...yes it says "charging" in the battery settings.

I did run the command you just said, restarted the cellphone and nothing changed
[Magisk] mv0hra:
Still no good. :(

Just to clarify what I did.

acc --set alwaysOverwrite true

Acc --daemon start

Acc -s s

Chose 1

Then test

Acc -s s

Chose 2

Then test
[Magisk] psychoela:
[MENTION=5228676]VR25[/MENTION] latest acc not working properly, charging not start below resume capacity. Thanks
[Magisk] rodrichu:
Should we just install this module or we need to remove former mcs first? I had just started using mcs, guess will stand with it for a while anyway.
[Magisk] paolocorpo:
You can over write because the installation of acc will delete any information of mcs

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] alex moymoy:
[MENTION=5228676]VR25[/MENTION] like mcs latest acc don't work for me. I have tried all apps of This kind (blex, B.C.L.)and nothing works sense I change to this rom (MadOS to wiko fever). Maybe you can help me and others with the same especificly files (rom, devices, etc). I already did all the clues that you posted and nothing. I hope you can find the solution to this problem ☺️

Ps: thanks in advance and sorry for my English ?
[Magisk] J4jks:
For me too it didn't work , it doesn't stop the charging at set values

Log shows some error.

Moto G 2 with los14.1 microg+systemless xposed, magisk 18
[Magisk] :
With all the posts about not working ACC, I would like to mention that on my OnePlus-3T with Magisk 18 and NOS installed, latest ACC from Magisk downloads is working without any issues till now.

All default settings except min/max charge settings; changed to 79-80 and working fine.

Happy with your module VR25!
[Magisk] xtam:
it is my default - i have that and this red indicator led works as follow:

if pausing is working, after 60% (default settings):

50s = light on, loading

10s not loading, light off and it stays off, but phone is loading correctly, just no indicator.

if i change this switch to batt store mode it does not work correctly, loads above 80% or no at all.

my phone is g950fds - note 8 samsung galaxy.
[Magisk] Da-BOSS:
Should I be worried about that.....

[MENTION=5228676]VR25[/MENTION]

Just wanted point out :) everything is working greatly but... when I see the acc-daemon-crownlte.log and I see this error inside the log (/sbin/.magisk/img/acc/accd: line 198: can't create : nonexistent directory) and something similar... should I be concerned? Should I be worrying about it? :) Just asking... every thing is working great :)

I will upload 2 log files... just in case :D
[Magisk] J4jks:
The error part showing and that's it no log for me [MENTION=5228676]VR25[/MENTION]
[Magisk] Bortex19:
Hi!

I have the config.txt setting in maxcharge=50%

If in one concrete moment I need to charge the phone over that value (70% for example) but only that time and keeping the rest of parameters (like maxtemp), can I write something in "terminal" to do it o have I to changes the settings of config.txt?
[Magisk] DougMG:
[MENTION=5228676]VR25[/MENTION] Using Pixel 3 XL and can not get acc to function. Did not have a problem with mcs. I have attached my debug log. Any assistance you can provide would be greatly appreciated.
[Magisk] VR25:
To all,

I'm analyzing the reports and working on the next version.

Thanks

P.S., those who didn't try, go ahead and run acc --set alwaysOverwrite true. This might solve your problem. I'll hardcode "true" and remove this option.
[Magisk] J4jks:
I've set alwaysoverwrite true in config and enabled verbose, rebooted

Then charged.

But it charged to 100not stopped at set value 90
[Magisk] Profetorum:
Anyone tested it on a nexus 6p? Any raccomanded settings?

Btw is it normal than my charging switches on and off here and there under the maximum ?

I guess it's the cooldown. How can i change it a bit? It feels like it stops too often or when the battery is not even hot
[Magisk] xtam:
[MENTION=5228676]VR25[/MENTION]

on note 8 it doesnt stop loading,

i set it to 70-80 (default config, nothing changed) and it has 87% and still is loading.

Could you check it?

logs added
[Magisk] nfsmw_gr:
Thanks for the update.

I realized that when my device reaches max charge limit it shuts off charging completely.

Should it maintain charge at the percentage I set?

I don't like using my phone plugged in and see the percentage dropping from 90% to 85% and then back to 90% constantly.

Is there any setting I can change?
[Magisk] VR25:
Default settings are good.

Regarding cooldown, you're missing an important point. It's meant for reducing both temperature and charging voltage induced stress. It kicks in at 60% capacity by default because that's generally when battery's voltage reaches the "red zone" (>=4.2V), especially with fast chargers (in my language: great battery abusers).

Some devices set the battery aside and draw power directly from the external supply when max capacity is reached. Unfortunately, most don't seem to behave that way. OEMs don't really care about that. Yet another branch of programmed obsolescence...

You can try a different charging switch from the database (acc --set switch).

If you own a Samsung device, use batt_slate_mode. It seems to work the way you want.
[Magisk] nfsmw_gr:
I see.

Using the app https://play.google.com/store/apps/details?id=com.slash.batterychargelimit&hl=en I can do what I need to, but the app some times work and others don't on my new device (Xiaomi mi 8) so I need something reliable, I'll try what you mentioned, thanks man.
[Magisk] Cronoss:
Great job [MENTION=5228676]VR25[/MENTION]

In my case I had to use acc --set alwaysOverwrite true to get it working.

Samsung S3 T999 with unofficial Lineage rom
[Magisk] psychoela:
Thanks, set true alwaysoverwrite is fix for my issue:D
[Magisk] GryphonBR:
Did you get it to work? I'm using it on a regular 3 and it's working for me. I had to set the switch, and everytime I reboot I have to manually activate the daemon; aside from that, no complaints at this point.

[MENTION=5228676]VR25[/MENTION] what can I do to get ACC to start automatically with my Pixel 3? As I mentioned above, my daemon has to be manually started after every reboot.
[Magisk] VR25:
[MENTION=4062470]GryphonBR[/MENTION], that may be a Magisk issue.

Test again after running ln -s /sbin/.magisk/img/acc/service.sh /data/adb/service.d/accd.
[Magisk] GryphonBR:
Tried that, accd is now correctly linked but still the daemon didn't start after reboot. Anything I can provide to help narrow this down?
[Magisk] kanyazsombor:
[MENTION=5228676]VR25[/MENTION]

Same here. Daemon doesn't start automatically after boot. Starting it manually, after works fine.

OnePlus 5 OB22 (Pie), magisk 18
[Magisk] VR25:
[MENTION=4062470]GryphonBR[/MENTION], remove the link.

[MENTION=3673203]kanyazsombor[/MENTION]

- Does Magisk log say anything relevant (i.e., "acc... exec service.sh")?

- If you remove /sdcard/acc/logs/acc-daemon-<deviceName>.log, is it recreated on boot? If so, are there any errors in it? To quickly find errors, use your editor's search feature to locate ": " (colon and whitespace).