yashsingh1/xdaforums huggingface dataset:
[Magisk] Macusercom:
/data/adb/modules/acc is blank. There is no service.sh that is executed after rebooting. Tried clean installing several times.

EDIT: I'll upgrade to Magisk v19.1 soon anyway. I just wanted to report it as there could be other people with that issue on v18.1. Seems to only affect this version.
[Magisk] shayanb2004:
I was Using 20190512r1 when charging

here are the screenshot and the file man (at the time of screenshot I updated to 20190512r2)
[Magisk] Hung0702:
Does anyone have 2019.3.7-r1? I don't see it on GitHub and the May versions are wonky. Couldn't install either of the 5/12 releases (log attached), and 5/11 is telling my phone that the battery is low and battery use is high and keeps asking me to turn on battery saver. "Less than 15 min remaining (58%)."

Using Pixel 3 XL on stock May security update, Magisk 19.1, Riru 19, EdXposed 0.4.1.2, Kirisakura Kernel 2.3. I don't think those other things are causing issues tho, but how can I be sure?
[Magisk] kanyazsombor:
Here you go
[Magisk] Hung0702:
Delete

---------- Post added at 01:33 PM ---------- Previous post was at 01:32 PM ----------

Thanks!

Reverting didn't resolve the constant battery saver issue tho. Wonder if I should reflash May update and reflash kernel, Magisk, Riru, Xposed. Kind of troublesome but I guess that's the cost of doing business.
[Magisk] kanyazsombor:
I recommend to remove acc and djs from magisk. Remove accapp and acc folder from sdcard. Reboot and install the older acc just posted and accapp if you want. I'm using accapp103 with the posted acc
[Magisk] Hung0702:
Thanks. I tried that, even deleting the acc/djs folders from sdcard. Unfortunately it didn't resolve the battery saver issue. Flashed the factory image and flashing my typical mods now. If you don't hear back, it means things are fixed! I really appreciate the suggestions.
[Magisk] RMarques:
Any idea about the message in the attached screen shot?

It started showing up today, after I updated to the latest version through Magisk.
[Magisk] VR25:
Refrain from quoting entire "books". This polutes the thread and makes reading a pain in the neck. If acc --log --export doesn't work for you, please compress the logs (/sbin/_acc/acc-*.log.

P.S., according to the log, you're not using the latest version.

Interestingly, there are no voltag_max files there. Try acc -v battery/batt_tune_float_voltage:4000.
[Magisk] VR25:
This is the 4th report of this kind.

ACC doesn't make any permanent modifications to the system. If you turn it off, disable or uninstall it, all changes are toast.

One of the users who reported a similar issue suggested that weird things started happening after installing latest system security updates.

P.S., the log doesn't have any descriptive error. Did you try redownloading the zip?

Install latest versions of both.

ACC 201905122

ACCApp 1.0.6
[Magisk] shayanb2004:
I attached the screenshot

What do i do? :(
[Magisk] RMarques:
Am I blind or the download links are not in the first page?
[Magisk] lm089:
Similar situation here: I'm currently stuck at magisk 18.1 because 19.1 breaks recovery on older Sony Xperia devices.

So currently xperia users are stuck at magisk 18.1, acc 2019.3.3-r1 and acca v 1.0.3

Not too bad as this combination is still working fine but it looks as if support for our old devices is fading :(
[Magisk] Hung0702:
I uninstalled the module/app and deleted the acc/djs folders and multiple reboots didn't resolve the issue. I'm not sure what happened. I downloaded the 5/12r1 zip from Magisk, but also downloaded it from GitHub. Tried the original 5/12 version too. Neither of them would install, only the 5/11 module did. Tried installing the 5/12 versions afterward but both failed.

I uninstalled/deleted again and installed the March module and ACCA 1.0.3 but still got battery saver notifications. I searched for 'battery saver' but didn't get any relevant results.

I finally just flashed the factory image without wiping followed by my kernel, Magisk, Riru, EdXposed, and then tried the March module and ACCA 1.0.3. Everything is back to normal now so I'm sure what the issue was. I really gave it my best shot and troubleshooted multiple approaches before nuking everything. Sorry I couldn't provide better feedback.
[Magisk] RMarques:
Oh, wait...I'm on e latest build already. As a matter of fact, the screen shot of the problem on my previous post started after updating, like I stated.

About the ACC app...I'm not sure which version I'm running atm and I can't find it within the app. If anyone can post the latest build here, it'd be awesome!
[Magisk] kenshin79:
Using Freetel Raijin FTJ162E

Hi,

Just wanted to let you know of my experience with latest update (5/12) via the Magisk modules and the latest ACC App.

After install and reboot, battery percentage was stuck at same level (not changing even with heavy use) and charging disabled (not able to charge, Ampere app shows ???? and stuck at AC plugged in status even if unplugged). ACC App logs show that device is not supported.

I disabled and uninstalled via magisk then reboot. Everything back to normal thereafter, Ampere app registers charging and battery status again as before.

Thanks.
[Magisk] k0rner:
Got similar experience with battery level.

Looks like "capacitySync" feature (correct the battery capacity reported by Android) is buggy and uses dumpsys battery set level incorrectly or way too often.
[Magisk] Unspec:
I can't seem to install the module, either through MM or recovery. Recovery says it fails with error code 1. I'm currently using magisk 17.0 with it's associated MM, which the thread states it supports, so not sure if 17.0 support was dropped or something.

Currently unable yo update to 17.3 or higher. 17.3 - 18.1 refuse root access (something about broken pipeline), and 19.0 - 19.1 crashes the phone when using Google maps/waze (seems GPS related). So the only version that works for me is 17.0.
[Magisk] Face_Plant:
I can't seem to update to the latest version. The installation fails instantly. I tried removing the ACC/DJS modules I currently have installed just in case the new version didn't play well with an older version for some reason, but this doesn't change anything. Install log attached to this post.
[Magisk] VR25:
duplicate
[Magisk] VR25:
[MENTION=5094347]RMarques[/MENTION], download the latest ACCApp from https://github.com/MatteCarra/AccA/releases/

[MENTION=4149551]lm089[/MENTION] et al, things may have changed in module_installer.sh (maintained by topjohnwu himself) that break the module's compatibility with Magisk 17-18. I'll check that.

[MENTION=4746825]kenshin79[/MENTION], "stuck battery level", it's most likely a "dumpsys battery reset" bug, and related to your system itself. capacitySync will be disabled by default. [MENTION=1607529]Hung0702[/MENTION], your system doesn't seem to like dumpsys either.

[MENTION=5788953]Face_Plant[/MENTION], I'll take a look.
[Magisk] lm089:
Just upgraded acc to latest version (2019.5.12-r2) through MM. Also updated ACCA to V 1.0.6 (the one linked above). Device in this case is a OnePlus 6, running OOS 9.0.5 (= pie); Magisk is latest V 19.1, as well as MM V 7.1.2

Result: ACCA isn't working any longer. I'm receiving that same error posted earler by others. Went back to ACCA V 1.0.3. That error message isn't appearing now but Daemon shuts down approx. 3 seconds after I started it.

One thing I observe is that in config editor of ACCA V 1.0.6 there is an error in the Voltage control section; apparently ACCA can't read that entry from config.txt, apparently cannot access the file referenced at that key. Observed the same on my Xperia tablet.

Right now I can't tell whether acc itself is working as I don't have a charger at hand.

If there is a log that you wish to see let me know
[Magisk] VR25:
"acc --log --export" exports all logs to /sdcard/acc-logs*.tar.bz2.
[Magisk] VR25:
Magisk 17.0-18.1 Users,

Do you see "-j Do not restore paths" after running /sbin/.core/busybox/unzip?
[Magisk] shayanb2004:
[MENTION=5228676]VR25[/MENTION]

I updated to the last ver (20190513)

without restarting my phone wouldn't charge

I had to reset my phone to be able to charge it
[Magisk] MarcoCount:
The new app is only compatible with the latest acc and viceversa for the old version.

The config file chaged

Screenshot the error and redownload the app from the same link to help the devs to understand your problem?
[Magisk] VR25:
Yeah, sorry - I was just about to post...

Users should run "su -c dumpsys battery reset" after installing (only this time).
[Magisk] shayanb2004:
Thanks

can I do anything about the voltage profiles?

regarding this https://xdaforums.com/showpost.php?p=79515039&postcount=2679
[Magisk] Unspec:
Do you mean while installing acc, or just running that on it's own?

Mine is failing due to a "no such file or directory" error. Logs attached.
[Magisk] lm089:
Sure can do, though it's going to be basically the same screenshot already posted by others before me (as I wrote in my post). Just upload to pics, tried to give them 'speaking' file names...

Thanks. I bet it's always been in the OP, but I didn't see it (sorry, now looking again I found it...)

UPDATE: just tried but terminal tells me "no command 'acc' found"...

Does that mean acc is not properly installed? After upgrading to the latest version this morning I followed the hint at the end of the installer screen that I don't have to restart, so I just did that, but still the same error; see screenshot #3

UPDATE 2: finally managed to extract the logs (my fault, see post below), and added those 2 logs in case you'd need them
[Magisk] shayanb2004:
I'm sorry to ask this

but shoudln't you have typed su command first to gain super user permission???
[Magisk] lm089:
just tried with "su -c acc..." etc., and indeed it worked. So it's my turn to be sorry; I would have expected that terminal would tell me if I needed su rights to perform that task. Linux is still a bit of a foreign land to me. But I'm working on it
[Magisk] MatteCarra:
Ok that's weird.

Could you also attach acc/config.txt

I should be able to find the issue then!

I would recommend to try while having installed latest acc and acca because they work together and the versions must match (latest with latest)
[Magisk] lm089:
You're all incredibly fast in answering, many thanks for that!

Here you go with config.txt; just for your info: earlier today I manually modified the "capacity" key to set a different charge on/off cycle. And I edited the voltage value to restrict it to 4000 mV

The rest should be default values
[Magisk] elimiriel:
Not exactly same with kenshin79, but I've experienced something similar, without error messages he experienced. Disabled recharging was solved by restarting demon via ACCA manually each plugging-in and never experienced 'not supported device', but system battery level was stuck when it reaches 70% when discharging. ACCA seems to read actual level, and system reads that when full reboot at that times.

SS is actual situation. when statusbar battery was stucked at 70%, ACCA shows closer to actual value when reboot(or remove module) at that moment. logcat was saved by rom's internal report tools when actual battery level was around 60%. Is it same issue, about rom support(my rom is based on stock of HTC 10)?
[Magisk] MatteCarra:
At First glance I would say you are not using latest acc version, but you are using latest acca version.

They are incompatible because vr25 changed the config file structure.

I recommend to update acc from magisk manager or use an older version of the app (1.4 I think)
[Magisk] lm089:
No, I'm running latest V of acc, I'm afraid. At least I believe that I do: MM module overview says it's 2019.5.12-r2, and that's what it says in the logs I posted a little earlier today

versionCode=201905122

UPDATE:

just did a complete round uninstalling ACCA and acc >> reboot to recovery >> delete caches >> reboot to system >> made sure acc folder was gone >> install acc latest version and ACCA V 1.0.6

Result:

Apparently I had some remainders of the previous version(s) sitting around, as everything appears to be running now. I'll keep an eye on it on next charging session.

Thanks for your patience
[Magisk] shayanb2004:
Don't worry my friend

it's ok ;)
[Magisk] stillnoexpert:
ACCA 1.06: Is djs support gone?

btw: an easy support for disabling/enabling airplaine mode by djs (or by djs via acca) would be nice.
[Magisk] MatteCarra:
It's not gone.

It just has to be re-added.

I wrote it in the changelog

Good news
[Magisk] VR25:
Unfortunately, voltage control won't work for you. Your kernel forbids it.
[Magisk] VR25:
It doesn't matter whether or not acc is installed. I just want to know if that unzip has the -j option. If it doesn't, it might be one of the reasons why acc installation is failing with Magisk 17.0-18.1.

The latest version (2019.5.13) should not have the "no such file or directory" issue.

It would've told you if it wasn't Termux. Try a regular terminal emulator to see.
[Magisk] VR25:
[MENTION=9731715]MatteCarra[/MENTION], editing new config with a relatively old ACCApp version essentially messes up the config format. Wouldn't that be the most logical answer to where that old config came from?

The user experience is constantly improving. Occasionally, there will be issues. We work to minimize the impact of those. As a rule of thumb, you should always use the latest versions of both softwares. If ACCApp throws config parse errors, it could be because the app is outdated or ACC is too new. From now on, each ACC changelog will include the compatible ACCApp version.
[Magisk] lm089:
On my Xperias I'm using the emulator that's built into Lineage. But the One Plus doesn't have that.

Any recommendations? (my apologies for this OT)
[Magisk] guest4711:
Terminal Emulator for Android (Access Android's built-in Linux command line shell. Unleash your inner geek!) - https://f-droid.org/app/jackpal.androidterm
[Magisk] Macusercom:
Yes, I got the argument.
[Magisk] Macusercom:
After testing 2019.5.13 it is recognised after a reboot but I can't enable the daemon.

acc -D start

Says it's running

acc -D

Then says not running

I've attached the logs.
[Magisk] Hastaloego:
has something changed with Max voltage control? sudden I get config error message.
[Magisk] Guido83:
me too
[Magisk] VR25:
Very Weird

The versionCode reads 201905130, but the accd that generated the log is older. :eek:

Uninstall first, then install the latest version (2019.5.14-r1).

ACCapp doesn't fully support the new ACC config format.

Try acc --voltage :millivolts (e.g., acc -v :4100). That's a voltage setup wizard.
[Magisk] Macusercom:
With 2019.5.14-r1 I get acc not found again. Magisk logs don't show acc running. Also /sbin/.core/acc is empty except module.prop after a reboot. Logs attached. Will use the March version until in v19.1 now. Maybe it's just me, no idea.

Logs attached.
[Magisk] Macusercom:
I just noticed that everything is installed in /sbin/.magisk/ and removed upon rebooting (possible Magisk self-cleaning)?

Shouldn't the files be located at /sbin/.magisk/img/acc?
[Magisk] guest4711:
Neither nor. Since 19.x Magisk does not use /sbin/.magisk anymore. All modules are put into /data/adb/modules, the binaries into /data/adb/magisk

The ild structure is simulated by symlinks.

Best is to use the actual mod_dir (e.g. /data/adb/modules/acc) for all files, AFAIK.
[Magisk] Macusercom:
In 19.x but I use 18.1. I'm upgrading anyway so once I'm on 19.1 I hope it works. No point in testing it with obsolete Magisk versions for me.
[Magisk] stillnoexpert:
Here( OP2 LOS16) go to settings, type "Terminal" into the search box. Find local terminal,choose it and then activate it. Then there will be a terminal visible in the apps overview. (my apologies for this OT)

--

Oh, this setting is under developer options. You have to activate that first.
[Magisk] VR25:
Try a different shell.

1) Install the latest build (2019.5.14-r1) - do NOT reboot

2) Run /sbin/.magisk/busybox/sh /data/adb/modules_update/acc/acc

3) If 2) fails, try /sbin/.magisk/busybox/sh /data/adb/modules_update/acc/acc

4) If 3) fails, try bash /data/adb/modules_update/acc/acc
[Magisk] lm089:
Thanks, but I'm running stock OOS 9.0.5.
[Magisk] guidozoner:
After updating to the 2019.5.14 r1 version the app display a message saying:

Config read error

I wasn't able to find/parse the ACC config file.

Before the update de app mas running fine.

Running magisk 19 and Hades Rom.

Any thoughts? Thanks!

Update: I have uninstalled the acc magisk modules and the acca app, erased cache with recovery, installed everything again but the error message it's still showing up.
[Magisk] quietsche:
Had the same error after upgrading to2019.5.14 r1, but deleting the app and reinstall from https://github.com/MatteCarra/AccA/releases/tag/1.0.6 worked.

Running on Pixel2, ElementalX 2.16. Magisk 19.1.
[Magisk] Hastaloego:
thanks man :) of course, it was the last option which works :D

has already been answered on the previous page
[Magisk] guidozoner:
Thanks for replying, did that but nothing changed!
[Magisk] guidozoner:
If you mean by typing the voltage on terminal, I did it, but it didn't work.
[Magisk] VR25:
Unfortunately, voltage control is not for everyone. If the kernel doesn't allow that, one has to look elsewhere.
[Magisk] shouk_1987:
How to know if the kernel aupports it or not

Or the command wont't bee accepted it in terminal ?
[Magisk] stillnoexpert:
Back to my battery drain problem with usb still connected and after changing has ended.

At least sometimes there is a wakelock in that case: f9200000.ssusb

my oneplus 2 has 5 options Running 'acc -s s',

1) Auto

2) /dc/charging_enabled 1 0

3) /battery/charging_enabled 1 0

4) /battery/battery_charging_enabled 1 0

5) exit

acc -t says for 2) "not working"

for 3) "working"

for 4) "not charging" but the actual % is below the charging range.

I have to do further analysis.

Setting it to 3) /battery/charging_enabled may be a solution. (No wakelock in my latest test)

Maybe /battery/battery_charging_enabled is the problem.

Could it be that "1) auto" checks both (/battery/charging_enabled and /battery/battery_charging_enabled)?
[Magisk] VR25:
Latest version: 2019.5.16-r2

The command's output will give you the answer.

Yes, "auto" means "cycle through all."

Due to the inability to read "plugged in" status universally, this is not yet 100% reliable.

Hence, the best thing to do is enforcing a switch that you know works as desired.

As your findings suggest, 3) may indeed be it.
[Magisk] stillnoexpert:
Unfortunately i was wrong in my latest post. Setting it to 3) /battery/charging_enabled *causes* wakelocks and battery drain.

Setting it to 1) auto had the same result.

Because 4) /battery/battery_charging_enabled 1 0 doesn't start charging, I set it to 1) auto to start charging and then to 4). It continued to charge. It terminated at the desired %.

After the charging of the battery has ended there still was some mA leaving the charger through my usb-m/mV-meter-plug. It's like the description of battery_charging_enabled said, the smartphone gets it's actual load form the charger and not form the battery.

And there was no wakelock! The GSAM-App even didn't recognise that the charging has ended.

If that is the solution the procedure is a little bit ugly. I have to start with 1) or 3) and I have to switch to battery_charging_enabled while charging.
[Magisk] VR25:
[MENTION=7582369]stillnoexpert[/MENTION], I can redesign part of ACC to make it work with both:

3) for resuming charging

4) for stopping charging

But first, does 4) resume charging while screen is on?

Here's the best way to test that:

$ su
# acc -D stop # stop the daemon
# acc -s s # pick 4
# acc -d # disable charging
# acc -e # enable charging
# accd # start the daemon
[Magisk] stillnoexpert:
Meanwhile it start to charge with 4) set.:

With Battery at 53% I typed

acc 56 55

and it charged. Now I am a little bit confused.

Later with 56% the mA shown by the usb-plug (17mA) indicates power form charger and not from battery. (1mA would indicate power from Battery.)

# acc -D stop # stop the daemon
> Battery begins to charge (mA rise)
# acc -s s # pick 4

# acc -d # disable charging
>stop charging, mA like before (power from charger)

# acc -e # enable charging
> it starts charging (mA rise)

# accd # start the daemon
>it stops charging, mA like before (power from charger)
. . . . .
# acc -s s # pick 3!!!
> power from charger

# acc -D stop # stop the daemon
> (power from charger)

# acc -d # disable charging
> (power from battery)

# acc -e # enable charging
> (power from charger)

# accd # start the daemon
> (power from charger)
. . .
and again
. . .
# acc -D stop
> (power from charger)
# acc -s s # picked 4
> (power from charger)
# acc -d
> (power from charger)
# acc -e
> it starts charging (mA rise)
# accd
> stop charging (power from charger)
. . .
# acc -D stop
> it starts charging (mA rise)
[Magisk] Hastaloego:
no i mean the error message by the ACC app, its because the "old" all is not 100% compatible to the "new" acc from latest update. acc it self will still work

if you use the max voltage wizard it gives you 5 options, the first 4 came back negative for my op5, the 5th worked.
[Magisk] VR25:
Interesting...

The issue appears to be that values written to battery_charging_enabled won't be noticed immediately. Writing twice or even three times with a small delay in-between (e.g., 1 second) may help.

Could you try the procedure below to confirm that?

1) Disable acc from Magisk Manager

2) Reboot to reset charging switches' values

3) Plug the external power supply

4) su

5) cd /sys/class/power_supply/battery

6) echo 0 > battery_charging_enabled (disables charging)

7) echo 1 > battery_charging_enabled (enables charging)

Run 6 and 7 as many times as needed. That is, until charging is enabled/disabled. Take notes.
[Magisk] stillnoexpert:
Today I am busy. I hope there will be time tomorrow.

Another question: How can I check whether limiting current or voltage works for my device? I tried, there are effects but it is not really what I would expect.
[Magisk] VR25:
For voltage, the wizard (acc --voltage :millivolts) will tell you whether your kernel allows it.

e.g., acc -v :4100

You can check current and voltage with acc -i or an app (e.g., AccuBattery).
[Magisk] MatteCarra:
Here you are a new update of AccA!

I should have fixed many reported bugs, but there's still a lot of work to do.

If you delete data of the app or install the app for the first time, you will have some profile presets!

Let me know if you face any problems!

Download: https://github.com/MatteCarra/AccA/releases/download/1.0.8/app-release.apk
[Magisk] stillnoexpert:
It did 6 and 7 several times, always the mA changed suddenly.

1. option

I got: Either [Battery/voltage_max] is not the right file ..

2. option

usb/voltage was set to config.txt but there was no effect on the mV while charging.

[Topic: limiting mA]

setting usb/current_max is allways limiting the mA to appox. 480 mA

Even usb/currrent_max: 20000000 ( a two with 7 zero) has that result.

[new Topic: a strange USB charger (may be OT)]

I have checked all my chargers and cables and i have found one quite strange effect with one of my chargers. It's a standard USB 2.0 charger form one of my old phones AND it influences the touch screen and/or the keyboard of my oneplus 2. It's like that charger is sending commands to the OP2.
[Magisk] kenshin79:
Using Freetel Raijin FTJ162E (aka freetel priori4s)

Hi,

With latest versions of acc and app, charging and detection of ac/battery no longer disabled as reported before. ACCA logs only show one line "tail: not integer: -F". Device still unsupported, no suitable charging switch from device.

Thanks!
[Magisk] VR25:
Intriguing...

usb/voltage_max has never worked for me either. Unlike other voltage control files, ACC cannot determine whether this actually works. It assumes usb/current_max works if it can be written to and the value sticks.

For me, this behaves almost 100% right.

This usually means the cable has a broken ground connection. The static electricity from it interferes with capacitive hardware.

Please, upload /sdcard/acc-logs*tar.b2z - generated by acc --log --export.
[Magisk] kenshin79:
Hi,

Attached is the log file. Thanks!