yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] :
My observation : Since the last 2 builds that i have used, the Big core (top freq) is hammered in spikes w/o significant load whenever the kernel is flashed. After few hours (3-4) it settles down. You can reproduce the same effect by just dirty flashing the kernel again.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] velimirchek:
Interesting observation, but for me it happened after first full charge, I have been using 1.1.2 since early morning and all was normal.

Thanks for your post (yeah, I am out of thanks :rolleyes: )
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
No, it's OK. Not sure what all Reven Kernel has though I am sure it's fine. I have known him to pull crap into his kernels. What I can say about our kernel is that this is the second decide we have brought up EAS onto. There has been countless hours with us and others from Vertex OS working on eas, testing eas, etc. There are tons of caf/hmp kernels out there. We wanted to work with something new.

One thing to note here, there is a rather large difference to have CAF/HMP and EAS work. While you may see the big cores spike to max freq, you will hardly see all 8 cores at max freq like in CAF/HMP. You will see tasks move from small to large cores. This is due to the capacity requirements of the tasks, the small core is overcapacity and migrates the tasks to the big cores. This is does not mean that it's misbehaving, or that you are going to be running hotter than stock.

Flash back to a stock based kernel and see what I mean.

There is also alot of discussions about whether or not it's better to spread tasks out (many cores, low freqs) or to pack cores with small tasks (few cores, high freqs) and eas will use both methods depending on a large number of factors. So if you are seeing the big cores doing a ton of work, this means that EAS has measured the capacity of the tasks and deems that they are too large, or their priority is too high, or many other factors, that they are not a good fit for the small cores.

Nothing has really changed in regards to EAS and how it handles tasks. What I can say though is that the media scanner servers turns on at boot up and EAS loves to run it on the big cores. This can be reproduced just be rebooting the phone.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sleepwalking0593:
Do you guys recommend using greenify with your kernel?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] velimirchek:
Thanks fo your kind explanation and making me understand this better.

I spent more time with U11 and OP5 is pretty new, as in hospital (hopefully my last day) I feel asleep around 8PM and woke now at 6AM.. same setup of apps and syncs, same mobile operator - U11 idled at 0,27% per hour and OP5 at 0,94%

Now I have to find cause for that.

Sorry if my posts are too long and newbie.. I feel comfortable at U11 forums now as owning device for 2 months and most of the time on EAS kernel, OP5 is quite new (2-3 days) so I will sound like a total newbie from time to time. Apologies.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] velimirchek:
[MENTION=6745491]joshuous[/MENTION] & [MENTION=5438598]RenderBroken[/MENTION] there's something little for each of you for coffee or beer (hope your donate to me links are correct on your profile)..

Keep up the good work. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] joshuous:
Hey [MENTION=8395457]velimirchek[/MENTION], I think you added an extra zero XD. But really, thank you so much for your gift. It's really no small value and it means a bunch to me, and as much to Zach I'm sure. I don't think I've mentioned it before, but the funny thing is that it was a struggle for both Zach and me to buy the OP5 as we had to get past our significant others worrying about our finances (since I'm a fresh graduate), and we took a while to convince them :p. Your generous gift as well as the kind gift from others have certainly made it easier and easier for my significant other to tolerate my buying the OP5. So just want to say that it does make a difference :)

We do not actively ask for donations because we find our delight in developing, learning new things and sharing what we learn with others. Your appreciation for our work is what really gives us the extra boost, whether it is by some words of thanks, gifts or actively testing and providing feedback. :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] velimirchek:
[MENTION=6745491]joshuous[/MENTION]

Just keep up the great work, I got 7h SOT which is great, hoped for 8h, but high drain after recharge for first half hour and high idle drain killed my hopes :p

It's on me to investigate why this happened.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Stupifier:
I want to donate also!

I see different PayPal donation links in each of your Profiles.....Can you guys add Donation details to the OP to make it easier. I want to make sure my donation reached the right place!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pshemo__:
Here might be your problem - xXx rom, I am not sure but it might be not be fully compatible with this kernel. The real stock is guaranteed to work fully with it
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gigoo25:
I am also having issues connecting to WiFi on clean stock OB11 w/ RZ. Only difference is having Magisk installed. Going to attempt to remove Magisk and see if that makes any difference.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] char101:
Extract the zip, open anykernel.sh, change `do.modules=0` to `do.modules=1`, then move the modules directory from ramdisk to the parent directory. Compress and then flash again.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jacky113:
Fixed
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] carlese:
I am going back to xXx 5.1.2, do I need to do it for stable build as well?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] char101:
Well it depends, is your wifi working or not?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pshemo__:
Hmmm... I flashed OB11 and Magisk 16.0, I am using RZ and wifi works flawlessly. Magisk shouldn't interfere with that
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] turbotorsten:
XXX ROM has problems with nearly all kernels in terms of Wifi. With stock OxygenOS everything works fine, so maybe you should consult the XXX developer instead.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gigoo25:
It actually seemed to be related to Xposed systemless. Doesn't seem like its compatible.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] char101:
The wifi is not working because of incompatible wlan.ko kernel module. The previous versions (<=3.2.0) flash its own modules (thus making it not systemless). The 3.3.0 version does not flash any kernel module (although it distributes it in the ramdisk/modules directory), probably in an effort to make it systemless. It has nothing to do with magisk or xposed.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gigoo25:
That may very well be the case. I did try to enable modules in "anykernel.sh" and moved them from ramdisk with no luck, but as soon as I disabled Xposed through Magisk WiFi came right back on.

I tried to clean flash, rebooted (WiFi working), installed Magisk, rebooted (WiFi working), installed RZ kernel, rebooted (WiFi working), installed Xposed V90-Beta 3 systemless, rebooted (WiFi NOT working).

That's what I've experienced so far at least.

EDIT: WiFi comes back after uninstalling Systemless Xposed and rebooting.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] char101:
I am using xXx 10.9 OP5 OB11, Magisk 16.4, xposed 90.2-beta3, and RZ-OP5-OOS-O-EAS-V3.3.0 without problem (apart from the kernel module stuff).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gigoo25:
Seems like the only difference is xXx 10.9 vs Stock and Magisk 16.4 vs 16.0. I might install 16.4 and give it another go :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pshemo__:
But it works on stock OB11 so something is different in xXx?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] char101:
In xXx 10.9 (at least in my phone), the bind mount of /system/lib/modules/qca_cld3/qca_cld3_wlan.ko failed (it still refers to the old file although it was listed in the mount list).

Logcat message:

E android.hardware.wifi@1.0-service: Load module from default /system/lib/modules/qca_cld3/qca_cld3_wlan.ko: No such file or directory

E android.hardware.wifi@1.0-service: finit_module return: -1: Required key not available

E android.hardware.wifi@1.0-service: Failed to load WiFi driver
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] char101:
Why is the minfreq in this kernel set to this frequencies?

OnePlus5:/ # cat /sys/devices/system/cpu/cpu*/cpufreq/scaling_min_freq
518400
518400
518400
518400
806400
806400
806400
806400

EDIT: The minfreq is usually set to 300 Mhz. Also when I open ExKM and select the CPU tab, suddenly the minfreq changes into 300 Mhz without changing any setting in ExKM.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] rpjuvvadi:
Qualcomm did that change in their CAF repositories. CAF is the base for OEM and most custom kernels, I think.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] char101:
Thanks for the info. When using the CPU Stats app this makes the CPU to seems to be constantly under (light) load.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] uudruid74:
This is likely a Magisk issue. Usual sequence is ROM, then Magisk, then custom kernel last.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] camseye:
I am on stock OB11 with magisk 15.3 wifi works fine without any issues.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pshemo__:
I think this is my new favorite kernel :D The smoothest I seen, very stable, 100% no lags, no stutters, very fast and battery seems to be working good. If you haven't already tried it, you definitely should do it :)

Here are my stats from last 26hours (charged till 95%, using mostly 4G during the day, no black themes. Stock OB11 here):
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] uudruid74:
Delete - question was stupid ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sleepwalking0593:
Did you tweak the kernel or using it as stock
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pshemo__:
In fact I changed all min. freq. to 300MHz (that's it about the kernel) and I am using Doze GP services module from Magisk and finally I enabled both advanced optimization OnePlus settings in Battery/optimization/advanced (not sure if they help but so far they don't trouble me :P)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Veliion:
With advanced optimization, do you notice any delays in notifications? Like with WhatsApp for example?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pshemo__:
Frankly I didn't get any messages on WhatsApp in the last few days but I just noticed that some "less known" apps and apps that aren't a communication apps indeed don't show notifications unless you open it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
I just flashed this kernel on OP5 OOS 5.1.2 official build and it went fine and the phone is working fine as far as I can tell, but starting to have a bad feeling because I'm looking through this thread and I can't see anyone talking about having flashed this kernel on an OOS official build. Have I ****ed up, or is it ok?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
Spotify usually works well but last time I used Advanced Optimization I found that SoundCloud would stop playing after having the screen off for some time (that was many OOS and Soundcloud versions ago tho). Have you noticed any music app stopping like that?

---------- Post added at 02:42 PM ---------- Previous post was at 02:38 PM ----------

Btw does anyone know if this affects future OOS updates? I mean will I have to reflash the kernel after every update?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
So apparently this kernel does not work with the OnePlus 5 DualSpeaker SoundMod Magisk Module by Dante63. The headphones will work, but the speakers won't do anything at all. Speaker is working now after removing this module and replacing the "mixer_paths_tasha.xml" file with the original one. But now I don't have stereo sadly. Do you know what the reason could be and if there's any workaround?

Tbh, after reading through this thread, I still have no idea as to what "Sound Control" is supposed to be (listed under the kernel's Features list).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pshemo__:
I'm using only Google Play Music and it was working fine.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
I'm guessing that's gonna be the case with every update, although 5.1.2 is a bad example really since it was a full ROM update for everyone.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
Hi I'd like to report that installing Systemless Xposed Framework for SDK 27 (the Magisk port) with this Kernel makes the WFi to stop working until it is uninstalled (Xposed, not the kernel). I'm using OOS 5.1.2 official release (no xXx, I dont even know what that is). I dirty flashed RZ over the official Kernel without Xposed installed. Actually I didn't install Xposed until many reboots and hours later (everything worked fine during that time). I'm using Magisk 16.4

Maybe it isnt meant to be compatible with Xposed I dunno.

EDIT: SORRY THIS IS A KNOWN BUG, OTHER PEOPLE ALREADY POSTED ABOUT THIS.

EDIT 2: Apparently no one has solved this issue tho. All I can find in this thread is people that say it works for them, and others saying that it shouldn't work on non-stock ROMs; yet it doesn't work for me, and I am on stock ROM. I would REALLY like to keep using Xposed. Does anyone have any suggestion? Has anyone solved this issue?

EDIT 3: An idea occured to me. Could it be a problem with the TWRP version I'm using? I'm on cheeseburger 3.2.1-1, but I've seen other people using a codeworkx version and others using a blu_stack version (dunno what the diferences are). Also, I kept my device encrypted. Maybe I should use one of those versions to decrypt it, and then it'll work? It's weird tho.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] uudruid74:
Neither TWRP nor encryption will have anything to do with it
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
Still tracking the exact issue. I believe I have it narrowed down with the help of a few testers. I will try to get a test build out asap. ATM, we are working on our OP3 EAS release.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
Do you have any idea why WiFi stops working when RenderZenith + Systemless Xposed Framework are installed? And then it works again after uninstalling Xposed?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sleepwalking0593:
According to Reporting bugs point 1 in the OP, you won't be provided any support.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
I have a few ideas but I am pretty sure it has to do with how we are binding our binaries. We bind like this to make it system-less. Something is wiping them out.

Could you provide me a link to the Xposed zip you used?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
Sure. It downloads upon clicking, just so you know:

https://xdaforums.com/attachment.php?attachmentid=4493762&d=1525539009

---------- Post added at 02:22 PM ---------- Previous post was at 02:20 PM ----------

I wasn't reporting any bug, I was just asking if he knew why it didn't work.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
The zip blew my phone up lol

What order to flash everything?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
Weird.

OOS 5.1.2 official (i dirty flashed from 5.1.1)

Magisk 16.4

RenderZenith from TWRP

Xposed Framework (SDK 27) from Magisk repo (same link I shared)

Reboot

WiFi won't work
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
Maybe I was wrong. Thanks for sharing.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
OK, I think I have been able to fix the WiFi issue. Would you be willing to test my private build?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] SeddyXDA:
Absolutely
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] surajloharia:
Wifi issue is restraining me from using your kernel

When can we expect an update ??
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] fjsferreira:
Can you kindly include these two commits? They are both so convenient and don't have any side effects whatsoever.

https://github.com/andip71/boeffla-...mmit/110ba7edbe98920910b47df85e5b3566c0ff7a03

https://github.com/andip71/boeffla-...mmit/9913f8cc602ba82a0bac2e9fb64754a28fa3c7fe

Thank you very much for the excellent work sir.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] AravindhStanley:
I had the same issue on 5t. I just can't seem to turn on wifi. Seems like there is a conflict with some magisk modules. Had to flash the full oos zip to get wifi working.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Nightbeat:
It's Xposed, I'm with another kernel that has the same issue. Disable it and wifi will work again.

This was discussed a few comments ago on this thread, take a look. I guess it's being looked into.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Urnyx05:
I didn't have Xposed and I had the same problem on my Oneplus 5 with this kernel and ElementalX, too
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ulxerker:
Stock ROM or XXX ROM?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Urnyx05:
Stock ROM
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] AravindhStanley:
I didn't had xposed installed during the time of reporting, but anyways they have fixed it in latest beta.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] joshuous:
Yup, our experimental builds work fine with it now
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
Hey guys,

We have been hard at work at getting out the next OP5 build out. Some really cool things in he works as well for it. Just trying to tie everything up and release. I know it seems like there has been alot of time since the last release. Personally I have been swamped with work and second work. But things are finally slowing down just enough for me to get the parts I am working on done for our projects. So with that, a release is immanent and I appreciate everyone's patience.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ndarkside93:
Thank you for the hard work and effort, glad to see you're finally getting a little bit of a break. Good luck
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] dsjd:
Will the next build be compatible with treble?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] chakraxz:
yes, try out the experimental builds
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] 8hodgsonkh:
Could you link me please

Edit: managed to find
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RogerF81:
Please, use the search.

Edit: Very good :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kranthir42:
is it working with latest open beta??
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ulxerker:
Nope, for that you need an experimental build, available in the Telegram group (please search the thread for that).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kranthir42:
just found, thanks dude :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ulxerker:
If you search for "joshuous" manually in Telegram you'll find the discussion group as well as the channel with the experimental builds.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Cichy26:
[MENTION=5438598]RenderBroken[/MENTION] or [MENTION=6745491]joshuous[/MENTION] will you add here new builds (if you release some new) or you will move the thread completely to telegram group?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sneakerspark:
Once the build is stable, it will be released here over the xda. From what i can tell you, you guys are in for a treat. Just be patient cuz stable build just around the corner. :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
We are only using Telegram for testing purposes. It is much much easier to dialogue with 200 users via telegram than to do so in a forum setup like XDA. We are just about done finalizing the next release and we are realllly happy with how it is performing.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Flamehell:
Yes....we are really happy...;) This kernel is pure magic ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] clock51:
the last beta works great
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] vitalinya:
Does RZ kernel support ttl changing?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ponkz:
Did u fix the low mic volume when using headset?

Thanks :laugh:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
Sorry, I wasn't aware of such a problem. You talking about using a bluetooth headset? I use one all the time without issue for work.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] shuini:
Does this kernel only work for OOS? :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] angourakis:
Yes. No Custom ROMs for now =)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
RZ-3.4.0 is HERE!

Things to note:

Merged Linux stable release 4.4.138

Merged CAF Tag LA.UM.6.2.r1-08900-sdm660.0

Updated SCHEDUTIL

Update Dynamic Stune - More to come on this feature.

Further optimization of our systemless flashable.

And of course, much more. Check changelog for details.

Downloads:

Version for Treble OOS

Version for Non-Treble OOS

Changelog
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] clock51:
latest version works great, thanks :bene:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] RenderBroken:
Thanks for the report! This latest build is def performance tuned. [MENTION=6745491]joshuous[/MENTION] has been developing our Dynamic Stune project and making strides and gains. So far we have been able to tie into QCOMs BoostFramework driver. IT now allows us much better control over performance by better dictating task placement and frequency used for top-app tasks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] meph02:
Yes with last build. Its very very smooth. Amazing. Thx for your work on this kernel
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Impel_Down:
thanks for your work.I have a question

hello，I'M fresh for kernel using, I want to know if I need to change configration after flashed. if so how to config that . btw i usr kernel editor. thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ulxerker:
No need for changes, just flash and forget.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] joshuous:
IMPORTANT: Do not use Magisk 16.7 with this kernel. It currently breaks our sepolicy patching and bind mounts. So your WiFi will not work as a result
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mrjuniork:
First off, thx for that super smooth and stable kernel. Today is my first day with this Kernel, I tried all the available ones for my OP5 and I'm sure this is just as top notch as someone can expect it from such talented devs, as you guys truly are... Been following this for a while now...

I searched this thread for the possibility of blocking wakelocks, coz most of the other kernels implemented that function and I can tell you that I never faced a single issue with it. I kind of miss this feature and I would really appreciate if that could be implemented in future releases.

Keep up the great work and thx for your dedication :highfive:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] clock51:
yes, already experimented, it happens to me that it restarts in bootloader, returned to 16.6
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mrjuniork:
As a little visual support to my post above, here is a screenshot where you can see the idle drain. I never had 2% and that's due to the kernel wakelocks. Of course it's not really a major player, but it does make a difference overall.