yashsingh1/xdaforums huggingface dataset:
[Magisk] robi10101298:
Hello, I flashed it via twrp on Lenovo s5 but it's still legacy ? what can I do?
[Magisk] VivaAndroid:
HELP HELP HELP ME PLS! My LeEco Le Pro 3 Elite now don't boot!

Hello guys,

my phone don't boot anymore after the mood i made.. somebody can help me pls ?? I can't lose my data because i have very important photos i didn t backuped yet :(

I try to explain what i did:

- Opened Magisk Manager from my app (now i noticed that it was not the v15 but probably it was something like 5 or smth like that)

- downloaded the zip file C2API+GcamSlowmo_enabler_v1500.zip on my computer and sent it on my Telegram

- saved on my phone from my messages on Telegram

- started Magisk Manager and opened the Modules Menu and added the file C2API+GcamSlowmo_enabler_v1500.zip from my download folder of phone

- rebooted

after reboot my phone never stop to show me the "EUI" screen like loading and changing colors of logo.. i can only shutdown my phone holding so long the power button (first time it restart automaticaly and if i keep power button, then wen it s restarting it turn off).

Pls i hope that somebody can help me!!

Sorry for my english not perfect but i m from Italy and ofc my phone was in Italian language and already modded with GizROM 1.0 (26s) per LeEco Le Pro 3 Elitè X722 - https:// forum.gizchina.it/index.php?/topic/1432-gizrom-10-26s-per-leeco-le-pro-3-elit%C3%A8-x722/

Thank you very very much !
[Magisk] VivaAndroid:
It happened to me also :'( and i don't know how to solve it.. please read my previews post and help me pls!
[Magisk] Didgeridoohan:
Most things you can try are described in the link from the post you quoted. Try that...
[Magisk] VivaAndroid:
i just checkd and on my phone the folder "modules" under /data/adb/ doesn't exist.. maybe it's because when i started the procedure of installation of google camera i opened Magisk and it suggested to me an update and i did it and restart magisk then it alerted another update and i did it and restarted Magisk.. after this Magisk alerted me that that version of Magisk was not compatible and it need v17 or something like that.. then i back on App Manager and unistalled Magisk and manually installed a preview version apk from my phone backup..

could be this one the problem ?

these are the links of my screen photos.. (i can t post direct link then i will split the links sorry..

https: // ibb.co/rxZ9FTz

https: // ibb.co/fS5TQvG

https: // ibb.co/y8Kpv1M

https: // ibb.co/k3hZzgH
[Magisk] Didgeridoohan:
You're on an old Magisk version... Just delete the magisk.img file in /data/adb. That will remove all installed modules.
[Magisk] VivaAndroid:
Thank you very very very much Didgeridoohan, you saved me ! It's working again !

I'm offering you a coffie on your paypal.. thank you again !

What do you advice me now to install google camera? Can you explain me step by step the most safe way to install it pls? Have me to install a new version of Magisk? How can i do it?

---------- Post added at 06:57 PM ---------- Previous post was at 06:31 PM ----------

I remember you that i have a LeEco Le Pro3 Elite with GizChina Rom ;)
[Magisk] Didgeridoohan:
I'm very glad you got things running again, and that was very generous of you. Thank you.

If you can update to a current version of Magisk you could try the Pix3lify module (available in the Manager Downloads). It can, among other things, enable the Camera2API. Since you have an old Magisk install you can probably not do a direct update through the Manager. Instead you can download the Magisk zip of your choice from here and install that manually, either from the Manager's Modules section (the "+" button) or through TWRP.

If you encounter issues you have lots of information in my troubleshooting guide:

https://www.didgeridoohan.com/magisk

There's of course also lots of help to find in the general support thread:

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382

And last but not least, your device's forum. There you'll find the people who know your specific device best:

https://xdaforums.com/le-pro3
[Magisk] VivaAndroid:
i downloaded the Magisk v19.3 but i noticed that it's a zip file and not an apk installer.. then how can I install it manually ? and is it better if i unistall the Magisk ver. 5.8.2 i already installed on my phone? is it better to delete cache and data before to unistall it?

Thank you very much for your help!
[Magisk] Didgeridoohan:
Don't get the Manager confused with Magisk itself. The zip version number, v19.3, is for the Magisk version. The corresponding Manager version is 7.2.0 (and you are currently on Manager v5.8.2, which should be corresponding to Magisk v16.6-ish).

The Manager is just a front-end for superuser access and installing modules. The apk for it is included in the zip... You shouldn't have to uninstall anything, just open the Manager, go to Modules, click the "+" button and select the zip. Or flash the zip in TWRP.

Edit: and make sure to have backups of your data before you move forward...
[Magisk] VivaAndroid:
Thank you I will try it again this week end because i can't risk to be without phone at work :D

for "Or flash the zip in TWRP" are you meaning that i can install Magisk by recovery mode on TWRP install button ? If it s like that it seems easy and maybe more easy.. but i m still a bit afraid to ruin again my phone :)
[Magisk] Didgeridoohan:
Yes you can and in your case it might be easiest (at the moment). Just make sure to also have the Magisk uninstaller and an old, known working Magisk zip on your device. That way you can easily get out of any trouble that might follow.
[Magisk] mac73:
I've tried using Android Pie, but it doesn't work. Are there solutions? Thank you
[Magisk] Erpe7:
I which. I'm looking for it for my mi8 for a while now...
[Magisk] mcichy10:
I installed "v1500 template for C2API+slowmo+" using Magisk Module installer and now my smarthphone doesnt boot. I can see loading screen but nothing more happen. What to do? uninstalling mod via TWRP using this: https://xdaforums.com/showpost.php?p=72542167&postcount=242 dont work for me. I dont want to install whole android again :/
[Magisk] Michael Westen:
My results

Here's what I got

[IMG="getprop | grep camera"]https://i.imgur.com/aIPacdH.png[/IMG]

[persist.camera.camera2]: [true]
[Magisk] pr1jker:
Reboot to recovery and uninstall the module
[Magisk] mcichy10:
I tried this, but didnt work. I eventually wiped the phone and install MIUI again. Thanks for your reply.
[Magisk] Randi_kurniawan:
#!/system/bin/sh

# Please don't hardcode /magisk/modname/... ; instead, please use $MODDIR/...

# This will make your scripts compatible even if Magisk change its mount point in the future

MODDIR=${0%/*}

# This script will be executed in post-fs-data mode

# More info in the main Magisk thread
[Magisk] buchoriidrus:
why to download
[Magisk] TrueHD:
Hello, friends! How can i raise my level of HW Support from LEGACY to something higher? I have Snapdragon 615 (Lenovo Vibe Shot). Tried many things, got root, got busybox, SELinux to permissive, installed HAL3.Enabler from Google Play and let it run, checked in build.prop that there is a line about HAL3 enabling and there is "1" next to it.

Google Camera apps are installing ok. But 'HDR+' and 'HDR off' fotoes has no differences. And H/W Level always just LEGACY.

I tried 5 different ROMs with Android 6. There are some others with Android 6 and some more on Android 7. Should i keep trying other ROM's or am i forgetting something or doing something wrong?
[Magisk] j1505243:
Snapdragon 615 is an edge case. You'd have more luck with 625 most probably.
[Magisk] TrueHD:
Thanks for answer!

Well, i'm not sure Google Translate interpreted "edge case" correctly. And yap, i can't chanhe my phone's processor. Is there atleast anything that i can try even with little chance? May other ROM's work in the end with HW Level? Or am i 100% just wasting time?
[Magisk] j1505243:
Yeah, most probably it's a waste of time.
[Magisk] muhnafi090398:
Ok
[Magisk] TrueHD:
Thanks, but i wouldn't mind a bit of more technically based explanation. In the end, according to Camera2 API specification, it's "favorite" CPUs are Snapdragons 6xx and 8xx. And 615 fills right in there, doesn't it?
[Magisk] j1505243:
There's nothing like that. Qcom implemented HAL3 only on the chipsets from a given time. I'm unsure about 615, but it's really on the edge. It's not as obvious as 625 or 820. For example, 800/801 needed a specially written HAL since qcom didn't add any support on their own. It makes Nexus 5 an exception.
[Magisk] TrueHD:
That's what i read in Manual for enabling HAL3. It has been saying that HAL3 "loves" for sure only Snapdragons 6xx and 8xx, if you have different processor then you can hope only for rare exceptions.

Forgive me may be i'm not understanding English correctly (it's not my native), but what so not-obvious about this 615 processor? Qcom either implemented HAL3 here or didn't. It's yes or no, right? The same as any other processor. Or am i misunderstanding something?
[Magisk] j1505243:
First thing, SDM450 is a part of msm8953 platform and because of that it supports HAL3. Snapdragon 439 is a similar case. It's more about the recency rather than pricing tier. As said above, no prop will ever enable HAL3 on Snapdragon 800/801 because it requires a specially written HAL (not by qcom).

The only thing I'm unsure about is that if Snapdragon 615 belongs to the chipsets like the example above, but since I can't remind any device with it that has HAL3, I'm just saying that you should abandon the hope. Especially with the module, if it doesn't do the thing, the HAL doesn't care about the prop and would need to be rebuilt. Since it's not an easy work, nobody will try doing that and certainly not me.
[Magisk] TrueHD:
Sorry, what is SDM450?

It's not my platform, mine is msm8939...

So, msm8953 kinda magical, and my msm8939 is not? Were i can find a list of supported platforms?

What? It's also a part of msm8953 platform and also supports HAL3? How old 4xx generation coud be a part of more modern platform? Sorry, all those Snapdragon generations and platorms are little mess to me.

Ok, this one i can understand. So let me know the date when HAL3 started to be implemented from and i will check the date of my CPU in Google... right?

I'm sorry, who is "prop"?

I don't understand, why we talking lower (4xx) or higher (8xx) generations of CPUs, if i am having 615?

Ok, one more explanation, please. What is "HAL (not by qcom)"? I thought, "HAL3" it's a name for Camera2 API technology?

Well, i also was curious and when i checked there's just not so many devices on this CPU. Just a few notable. So may be the owners didn't even bother. But it doesn't mean it's not capable, right? May be i still can activate the technology on it?

By "module" you mean camera module?

Ohh damn i understood almost nothing out of this sentense. Sry guys for my such a bad english, i feel myself like a redneck who doesn't understand a thing here. Seems to be i need to learn english harder.
[Magisk] j1505243:
SDM450 is Snapdragon 450. msm8953 is quite newer than msm8939. The CAF tags indicate that msm8939 comes under msm8916 common platform, same like the example in previous sentence. That platform was released on December 2013. For comparison, msm8953 was released at February 2016. Makes great sense now, right? Supported platforms aren't listed for any of our conveniences, but there are open source CAF repos that let us to verify few things. Prop is a short them for property, there's a file called build.prop that contains them. All of the examples I listed before are because of the fact that I wasn't unsure if CAF repo would let me deduce the HAL level availability easily. HAL is "hardware abstraction layer". HAL3 is a short term for camera HAL of version 3.x. HAL is a backend for the API that actually defines what's available and what isn't, while Camera2 API itself is available on every Android 5.0+ device, but of course without HAL3, it gets only the Legacy hardware level. By the module, I mean the Magisk module that this thread is about.

To sum up, there's no HAL3 directory in the camera HAL source for your platform at all. That's it, implementing that would be a lot of work and an easier thing to do would be to earn money for a new device, sorry.

https://source.codeaurora.org/quic/...ra/tree/QCamera2?h=LA.BR.1.2.9.1-02310-8x16.0
[Magisk] Omarx43s:
Think
[Magisk] TrueHD:
j1505243

Thank you for all the answers. Now i understand most of the terms. Except the CAF tag. What is it? What are CAF repos? And what are camera HAL sources?

Does it mean that now we know that Snapdragon 615 DEFINITELY doesn't support HAL3? Or it support it, but support has never been implemented on software level? And the latter actually could be done maually?

I'm not buying new device definitely. First - i really like Vibe Shot's design. Secondly, it absolutely satisfy me in all aspects except the camera quality. Even all unusual problems with flashing Lenovo Vibe Shot - yea, that phone is well-known coz it's hard to juggle ROMs with, but i learned all the details). And the third - this phone literally saved my life once. In overall - it's a memory, it's a nostalgic. I will keep using it anyways.

I have the time. And strong desire to use Google Camera with HDR+ on our device. If it's possible i would be greatfull to a link to exact article i have to learn to do it. Atleast just to extimate amount and difficulty of stuff to learn.
[Magisk] j1505243:
CAF is Code Aurora Forums, this abbreviation is used to describe the open source part of the code that needs to be built to run any Qualcomm Android smartphone, the project is called Android for MSM. CAF tag is repo tag utilized to sync every git repository at a specific version. Snapdragon 615 could support HAL3, at least partially, and yeah, it wasn't ever implemented because it's real, huge pile of work. People doing things like that professionally are paid, hence even the Snapdragon 800/801 flagships never got it, except for Nexus line (Google wrote the HAL on their own) and maybe OnePlus One, but I can't remind the full story. The issue with your plan is that you need to be motivated more than me. The questions you've asked, they're a pretty common knowledge findable on Android forums. I went further than that to explain everything that matters already. You're trying to beat a dragon with a stick. You won't do that. If it happens otherwise, if you're an experienced programmer, you no longer need to ask me about any single thing. But you aren't, so good luck, appreciate what you have already.

EDIT and tl;dr: how do you image coding if you don't know what's source?
[Magisk] DekiS3:
Hi guys!

I have a Xiaomi mi a2 lite and have always used this Magisk module (C2API_enabler_v1500.zip) to enable camera2 API. But now, after january update, it seems it does't work anymore.
[Magisk] nicolaus20:
How to download this file?
[Magisk] DE SEXIEST:
Download

Check the attachment in the first post
[Magisk] DE SEXIEST:
The slow motion plugin,is it to flashed with a custom recovery or it's also a magisk module
[Magisk] IsmaVHS:
Hello everyone! First of all I pay my respects to the community for all the work. On the other hand, the module didn't work for me... now I have my camera completely useless. My phone is a Xiaomi Redmi Note 7, I later understood that it was not compatible with it. I have looked for 1000 ways to uninstall the module but none of them work for me, the biggest problem I have is that the module does not appear in Magisk Manager or in Recovery Mode... Is there any way to uninstall the module without having to start from 0 on Android? Thank you all very much in advance.
[Magisk] Fumetsu_Guritto:
Doesn't work for OnePlus 8T

Same.

I'd like to uninstall the two zips provided in OP. Not a fan of junk installs and files.
[Magisk] 我是十七:
If there is no mask in the mask manager, it means that the brush in is not successful, and there are no files in the system, so there is no need to uninstall
[Magisk] ashwatthama69:
I can see no line. Pls help.
[Magisk] otaconremo:
Use a terminal from your android. Either install juicessh or termux.
[Magisk] DE SEXIEST:
Please can I flash this on Android 9 device.

It's a mediatek device.

The device is Tecno Camon 12.
[Magisk] TMHAKIM:
Will it work for Kirin CPU??
[Magisk] Alex MostWanted:
Hey I was very dumb to install this without reading the whole thing

My phone (Nokia 5.1 Plus) is a mediatek device

When i installed it nothing happened but i started encoutering occasional bootloops

I cannot find the installed module in magisk

Is there a way to revert back the changes?
[Magisk] lupastro82:
Installed in OP6 with A12 CR, but not appear in magisk modules manager.

So sad 😢
[Magisk] Wandrios:
How to enable all of these features?
[Magisk] somedudd:
Does it need root?
[Magisk] Robdyx:
Because it's more noob friendly and because why not. I also wonder what are the benefits of this mod.
[Magisk] Didgeridoohan:
Another reason is so that you don't have to edit the actual build.prop file. Magisk is all about systemless system mods after all...

Edit: Wait a minute... I just looked at the module zip. Why is it so complicated? Why not just use the Magisk built-in resetprop tool through the module system.prop to set the desired prop value?

Edit 2: [MENTION=6039818]otaconremo[/MENTION] You've just taken an old Universal SafetyNet fix module and used that instead of the normal template, haven't you?
[Magisk] otaconremo:
You are right. This is from an old safetynet fix. I'm not really a coder but I can understand a bit. I was using safetynet and I saw it was modifying build.prop so i just edited that part.
[Magisk] otaconremo:
The main reason it is a module is because it is intended to edit build.prop systemlessly. This is in the magisk forum, therefore the main target here is for systemless mods.
[Magisk] otaconremo:
The command is to verify if you have that property in your build.prop. Also, it is for checking if the module was running after installing it.
[Magisk] otaconremo:
If you installed this on a systemless magisk, none of your default config is touched. All you have to do is uninstall the module in manager and reboot.

If you edited the build.prop in another way, you can also just remove the line you edited/added and check the permissions after if it's changed.
[Magisk] otaconremo:
Sorry for bursting your bubble. I'm with you when hdr+ didn't work on my device too. However, the latest version of gcam works but without hdr+. So it's also fine with me.

Sorry, no. I think only snapdragon supports it.
[Magisk] yochananmarqos:
Thanks for pointing that out. I added a comment on the front page news article and quoted you. XDA staff should not be posting random mods on the front page unless they have checked it out and understand what it does.

EDIT: Hold on, [my comment] is waiting to be approved by XDA-Developers. I used HTML.

[MENTION=6039818]otaconremo[/MENTION] No offense to you intended. I learned how to make Magisk modules the same way: Take it apart to see how it works. Start with the Magisk module template instead. ;)

Thanks for finding something to contribute. Let me know when you get the module sorted and I'll add it to my Collection of Magisk Modules v2 thread.
[Magisk] otaconremo:
Thanks. The mod is working fine as it only adds build.prop line. That is all it does anyway. For google camera purposes however, it doesn't guarantee it will make it work. Google cam is ported but it doesn't really support all devices. So users will just have to test it out themselves if it works for their phones.
[Magisk] yochananmarqos:
FYI, my Nexus 5X supports the Camera 2 API:

$ getprop | grep camera
[init.svc.cameraserver]: [running]
[init.svc.qcamerasvr]: [running]
[persist.camera.tnr.preview]: [0]
[persist.camera.tnr.video]: [0]
[ro.camera.notify_nfc]: [1]
[Magisk] FellipeSilvaRJ:
Can I test this on my Xperia Z2 (SD801) or I'll just lose my time? I know the op says 820+ only but I just want Gcam on latest version (and with some lucky manual controls)
[Magisk] aadityaraj1:
[MENTION=6039818]otaconremo[/MENTION] Installed this module on my moto x play but google camera latest version is not working its force closing I am not asking for hdr+ mode but just for google camera latest version. will it suppose to on moto x play with this module?
[Magisk] otaconremo:
If you have already installed magisk, then try it. It's just a module so you can just uninstall it if it doesn't work.

Hmmmm. I'm not sure if it will work on your device. I checked that moto x play only has snapdragon 615. I'm not really particular which among the snapdragons support camera2api.

If you wiped your system, then you won't have an OS. If you restore your system from a backup, then that will clear the mods and magisk.
[Magisk] Didgeridoohan:
I'd suggest that you update the module anyway, from the latest template (you're also using an old template, no biggie but still). And, it's not recommended to run stuff in post-fs-data unless you really, really need to. Using system.prop is much better for the purpose of this module.

All you need to do is edit config.sh and module prop like you already have (except you need to change POSTFSDATA to false and PROPFILE to true in config.sh) in this module and then add this line to the system.prop file in the common directory:

persist.camera.HAL3.enabled=1

That's it...

Magisk doesn't actually touch the stock build.prop file or the system partition. The new values are just loaded instead of what's in build.prop. The Magisk image is kept in /data, so as long as you keep the data partition intact and have a Magisk-patched boot image, the new prop values will be loaded.

That's actually one of the big things about Magisk for me. I can (dirty) update my system and still have all my system modifications done and ready without doing a thing.
[Magisk] Binh430350:
Help!?!! Everything is working fine, HDR+ is working, I did confirm that the line in terminal is enabled, but when I try to record a video, the app crash, is it only for picture?
[Magisk] The.Scram:
Video is working here. You sure using the right APK!?

Using this:

https://www.androidfilehost.com/?w=...195200-41155109_7.0H_PIXEL_XL2_Full_v2.1.apk+
[Magisk] josephnero:
Sorry I wasn't clear enough. I meant to say modded Google camera still crashes
[Magisk] FellipeSilvaRJ:
Unfortunately, don't work here, as expected. Google Camera doesn't even install here, and nothing changes with camera2 support, despite the build.prop line is added. As for camera2 working, I guess that's a kernel stuff, but it's not something related to this thread, just keep the nice work for supported devices :D
[Magisk] LeonardoSM04:
I'm sure you can use Cyberian Camera Mod. Maybe you know what is it. Maybe you don't. If not, try it. It is compatible with stock ROM and custom Nougat ROMs.
[Magisk] vikrantchaudhary21:
Which Rom you are using ??
[Magisk] FellipeSilvaRJ:
Yeah I already know about Cyberian, thanks. But I was looking for manual focus control, because focus on my ROM is a little bit bad :(

Anyway, thanks for helping :D
[Magisk] otaconremo:
I'm using stock Axon 7 chinese v2.0.0B08.
[Magisk] otaconremo:
Thanks for helping. I already updated the OP to the new module.
[Magisk] Didgeridoohan:
No worries... Just one last thing: You didn't quite make the config.sh file match your last module. You should also set AUTOMOUNT to false (since you're not Magic Mounting any files). Leaving that option true will mount the placeholder file in the module to /system, something that turns out can cause bootloops (no idea why, investigation ongoing).

Edit: And oh yeah... Magisk v13.6(1360) can uninstall modules no problem.
[Magisk] otaconremo:
Wow thanks again for checking on it. So that's why something is odd on the magisk log. ?

I'll try magisk 13.6 later. I'm using an Http Injector app and its latest update is detecting root already besides being enabled in magisk hide. Maybe 13.6 can hide it again.
[Magisk] otaconremo:
I'm using this gcam version from apkmirror.

https://www.apkmirror.com/apk/google-inc/camera/camera-4-4-020-163412804-release/google-camera-4-4-020-163412804-android-apk-download/