yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 Themes, Apps, and Mods] LKspro:
This works perfect on oos, everytime I open the camera and switch off hdr then switch to force hdr+, touch to focus must work
[OnePlus 5 Themes, Apps, and Mods] TigerKing:
It's still n giving blue yellow shade on front cam with no setting changed. Also image mirrored. Can you please fix this?
[OnePlus 5 Themes, Apps, and Mods] matchung:
Official reply from oneplus, this makes me a little disappointed that GCAM could fix this
[OnePlus 5 Themes, Apps, and Mods] wawatutsi:
I think the above quote of reply from one plus is for a different topic.

The reply i got from "veteran97" regarding the dots being caused by the resolutions being different was i little bit technical for me when i first read it , but i investigated what he said , and there is a strange anomaly , when the op5 shoots in HDR+ in the google pixel mod it creates a resolution of 4656 pixels [16x9] but when it shoots HDR+ in stock it creates a resolution of 4608 pixels. This is also the resolution of the modded camera when it shoots non HDR pictures 4608 pixels. These non hdr pictures produce no dot artifacts, so it seems the op5 is creating a slightly larger picture than it should, when using the mod and this could possibly be creating "space between the pixels" [i'm just a photographer not a technical person so i don't know what this means either] but if someone could figure out how to reduce the pixels to 4608 maybe ? the problem would go away
[OnePlus 5 Themes, Apps, and Mods] linds0r:
I'm using your mod on an LGV30. It works great with the suggested settings, except that low light photos are very yellow, not red/pink.

I know you're not supporting my device, so I wonder if you can tell me how I could change the color config to try to alleviate that problem. Thanks!
[OnePlus 5 Themes, Apps, and Mods] veteran97:
Hey, this "space between the pixels" are just focus points which are used in phase detect autofocus, OnePlus said the same thing as me (it seems really nice that they actually care about this instead of generic "We look into into that" from random person which have no idea what problem is). You have a lot possibilites to fix this problem ex. you can skip these dots, but if you have already these photos with dots you could fix it in very nice way - you can bring information about luminance and color from neighboring pixels, normalize the value and apply this value to white dot. It should be possible to automate it with Photoshop action for example. If you will use my idea then after fix nobody will see any defect (because of bayer pattern blah blah blah, too technical to explain but these photos will look great if you fix that with my solution). I am just cinematographer, I know what problem is, how to fix it but I have no idea about programming so I cant just fix app.

The way I see it without any investigating into app - HDR+ is so great while being so fast because its designed to work with Pixel devices, it probably has a lot of values hard-coded. It doesn't have any compatibility, any "scan for" any "if xxx then zzz". Its just hard-coded do that, then do this, after this do this no matter what you are using as you are supposed to use Pixel only with this app. You know what I mean? If at least one thing is other way then app wont do this or will do this bad. Probably this step where it fixes these white pixels wasnt fixed by developers who modded app or maybe this HDR+ works on other devices because it skips these things. I think that it could be second thing , but like I said, I didnt investigate that, as I dont have that many free time anymore. It's fixable, but dont count on me as my knowledge about programming ends on "hello world" in visual basic and copying code from stackoverflow. I'm not a programmer by any means :(
[OnePlus 5 Themes, Apps, and Mods] txx1219:
EDIT : It's Oneplus Camera2 API who is in cause. I try to shoot in DMG with Open Camera and the same dots pattern appear. Everybody can try to shoot with a third-party camera to DMG format, you will see the dots pattern.

The only way to change this is to reclaim against Oneplus to correct the Camera2 API DMG processing. Even if Oneplus tells that is not its fault, all third-party camera have the same issue.
[OnePlus 5 Themes, Apps, and Mods] miskobartanus:
Interface and videos laggy af

I installed yesterdays build on my OP5 and interface while moving around taking pictures is extremely laggy and also videos I shoot is laggy as hell. I cleared cache of my OP5 as well as cache of the app itself and played with settings a little. Anybody experiencing same issue here?
[OnePlus 5 Themes, Apps, and Mods] TONGEXHISPEED:
OmniVision mode???
[OnePlus 5 Themes, Apps, and Mods] titooo7:
@ wawatutsi do you also see the dots on pictures shot with the Google Camera mod but with HDR turned off?

If that's the case you might be correct and maybe forcing HDR pictures to be only 4608 width (and not 4656 width) might fix the dots issue.

I'm trying to find where to change that in the apk but I can't find it even if I use the hexadecimal number equivalent to 4608 or 4656

EDIT: the height of the pic should also be changed from 3496 to 3456 maybe
[OnePlus 5 Themes, Apps, and Mods] txx1219:
No, because it appear in other third-party camera too, eg. Open Camera.

The only way to correct this, is to replicate how OOS cam generate RAW in the GCam post process.
[OnePlus 5 Themes, Apps, and Mods] Manya1999:
I was trying snap camera and noticed something wrong.

I compared jpg and dng from stock camera and from snap camera app.

Snap camera jpg :4608×3456

Stock camera jpg: 4608×3456

Snap camera dng: 4656x3496

Stock camera dng :4640x3480
[OnePlus 5 Themes, Apps, and Mods] titooo7:
I don't know man, I'm not an expert but considering the following:

OP Stock camera with HDR Off = 4608x3456 without dots artifacts :good:

OP Stock camera with HDR On = 4608x3456 without dots artifacts :good:

GoogleCam mod with HDR Off = 4608x3456 without dots artifacts :good:

GoogleCam mod with HDR On = 4656x3496 with dots artifacts

It would be really worth to try to get the last scenario doing the pics in 4608x3456. Just as a trial and error test...
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Do you know how they edit the Gcam ? I really want to compare how GoogleCam take the RAW infos vs. how OOS Cam take the RAW infos.
[OnePlus 5 Themes, Apps, and Mods] wawatutsi:
It was mentioned previously that the resolution of a Pixel camera is 4656x3496, if this is the case then it would be useful to know if anyone with a op3 or a phone that is working successfully with the Gcam mod HDR+ what the resolution of the pictures are.If they are 4608 maybe it is a clue, if they are 4656 then we are probably clutching at straws
[OnePlus 5 Themes, Apps, and Mods] shriekyphantom:
Same mods. The pinkish tint is not always noticeable though.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
The resolution of a GCam photo is the same when you take a RAW photo with the OOS Cam.
[OnePlus 5 Themes, Apps, and Mods] Manya1999:
No.stock camera RAW is 4640x3480

Gcam with forced hdr+ is 4656x3496
[OnePlus 5 Themes, Apps, and Mods] txx1219:
With OOS Camera 2.4.1
[OnePlus 5 Themes, Apps, and Mods] txx1219:
After some code reading in the OOS stock camera 2.4.1, I found out various informations :

- Google Camera uses Camera2 API to get RAW pixels, that's why we see dots pattern.

- OOS stock camera uses Camera1 API with a proprietary class called "OneplusCallback" to get RAW pixels. I think Oneplus had issues to implement the OP5 camera (have they faced the dots pattern issue too during their tests ?) and found out to use the Camera1 API + a few own methods to get the RAW pixels.

- OP5 uses the LegacyCameraImpl who uses Camera1 API. Camera1 API don't generate the dots pattern, as we can see in the OOS Camera app. I don't have the OP3/3T, but I'm quite sure they use the CameraImpl who uses Camera2 API. This can explain why OP3 users dosen't have the dots pattern in Gcam mod, because the Camera2 API is fine.

- Possible solution : replicate how OP gets RAW pixels with Camera1 API in GCam mod.
[OnePlus 5 Themes, Apps, and Mods] Manya1999:
With oos camera 2.0.0
[OnePlus 5 Themes, Apps, and Mods] Manya1999:
Can this be also the reason behind half broken touch to focus?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
The resolution changes between 2.0 to 2.4.1 is quite interesting. Don't know why but is really strange.

For touch to focus, the thing is in others third-party camera app who uses Camera2 API (eg. Open Camera), touch to focus works great.
[OnePlus 5 Themes, Apps, and Mods] BLac-Xen:
As for me, I do have dot pattern also in stock camera when shooting RAW pictures and editing in Lightroom but the pattern is far less noticable and appear when you play with exposition and constrasts.

I often have the dots for overexposed parts of a picture, for example Sky or lightbulbs.

Using 2.0.0 stock camera.
[OnePlus 5 Themes, Apps, and Mods] Manya1999:
Like this?stock camera raw.
[OnePlus 5 Themes, Apps, and Mods] BLac-Xen:
For lightbulbs yes.

For sky, it's different, identical to the dots from gcam but only happen when i miss my shoot and have to go for -100 highlights and whites and lower blue luminance.
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
if you zoom in enough you will see that the dots do not appear on the edges.
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
Another example
[OnePlus 5 Themes, Apps, and Mods] Kisakuku:
B-S-G's Modded Google Camera 5.1.016 with HDR+ for Android 7.0 / ARM64 v1.3a All-in-One Full Manual

Download

Changelog:

Re-calculated the values for black level offset (OmniVision mode)

Fixed black screen on app start-up for some devices (kenzo, hydrogen, helium, dreamlte, kate, mido, heroqlteue, sagit, herolte)

Activated Motion Photo mode, requires Android 8.0

New settings take effect after application is restarted

Must clear data / cache after installation and if the app force closes
[OnePlus 5 Themes, Apps, and Mods] Chamaka:
Looks like OnePlus try to reverse engineering Google camera ?
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
2017/11/21 – GCMod5 based on Mod By B-S-G

Change Log :

Some update from MGC_5.1.016_7.0+C2API_v.1.3a_AllinOne

Remove the pinkish in the pictures by default

News codes for "remove the pinkish"

Add in config camera hdr+ Experimental Features (Pixel) and Pixel/nexus2016 2016 Tuning

Add resolution 3096×4096 for lens blur

Fix bug reported by [MENTION=4487956]S4turno[/MENTION] (here)

GCam5.1.016-Arnova8G2-1.2.apk

Motion photo for Oreo ( config camera hdr+ : use Pixel )
[OnePlus 5 Themes, Apps, and Mods] titooo7:
Thank you man.

Would you able to change the resolution of HDR pictures to 4608x3456?

As you can see in previous posts we were speculating with the possibility of the dots issue being caused by a higher picture size than the one that we get on stock camera or googlecam with HDR off.

Maybe changing the resolution of HDR pictures to 4608x3456 won't change anything and we still will have the dots, but it would be nice to test
[OnePlus 5 Themes, Apps, and Mods] drjt0794:
Sorry for stupid question... but if I download this apk, can I remove the "Google Camera" that comes with Open GApps, or does that include APIs that this apk needs?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Thanks, I see there is 2 new configs : PD and no PD. It is for Phase Detection ? I tried PD but I have a black screen. When I take a photo with any others configs, the HDR+ proccess won't achieve and delete the photo.
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
I did not indicate it in the changelog because it has bug, but i'm trying to fix this bug

---------- Post added at 05:50 PM ---------- Previous post was at 05:31 PM ----------

It is possible but the image processing will be long and it takes a lot of memory.

I would do a test version.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
I don't think the size is the cause of dots pattern. I investigate more and I try to understand where comes the dots pattern. When you take photos with any other third-party camera (eg. Open Camera) in RAW, the dots pattern appear. I suspect that the process of getting image from Camera2 API (passing ImageReader in RAW_SENSOR format) are buggy. When I take a photo without HDR+, the image obtainment is different from the photo with HDR+ because there is no dots pattern and the image quality is different from the image before HDR+ process.
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
I can send you a zip of an apk decompiler is to compile with apktool latest version compatible with framwork api26

A little research how apktool works

GCam5.1.016-Arnova8G2-decompiled
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Yes it's what I use now. I will continue and test, I keep you up to date in any case.
[OnePlus 5 Themes, Apps, and Mods] titooo7:
What's the picture size of OpenCamera RAW pictures?
[OnePlus 5 Themes, Apps, and Mods] txx1219:
4640x3480
[OnePlus 5 Themes, Apps, and Mods] titooo7:
Post Preview:

So still bigger than the picture size of stock camera or Google Camera with HDR off.

I don't have any evidence to confirm that the picture size could be the cause of the dots issue, but just as a trial and error it would be nice to see what happens if we get GoogleCam HDR pics as 4608x3456
[OnePlus 5 Themes, Apps, and Mods] txx1219:
So I log what image format was used by Google Camera and confirm what I think is the issue.

When the HDR+ is OFF

The Google Camera takes the picture from camera lens directly to JPEG, no dots pattern issue here.

When the HDR+ is ON

The Google Camera takes the picture from camera lens in RAW_10 (for HDR+ process) and put in JPEG picture, dots pattern issue here.

Dots pattern appear when the camera lens is required to give RAW image. Bad implementation of RAW by Oneplus in Camera2 API is clearly the cause.
[OnePlus 5 Themes, Apps, and Mods] siankatabg:
I as a guy that is part from the op3/5 OOS port can just say that OP is using a specific/custom implementation/method of getting a dng/raw image for its camera and not the native aosp way. I didn't tried to check how and why this port have issues, but most most probably we are depending again on the mercy of OP and how they'll implement their custom things in the blobs we all are using (no matter custom or OOS).
[OnePlus 5 Themes, Apps, and Mods] gianton:
Is camera the only issue from not letting you make the port?
[OnePlus 5 Themes, Apps, and Mods] siankatabg:
I can't understand your question and I don't think this is the place for it, but yes, OOS camera port in the moment on O is not likely possible (at least a month ago with the N blobs we are still using on it I was unable to make it working, because missing stuffs in the framework that the N blobs needs to properly work).
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Yes it was mentionned earlier in this post. The issue here is that the Google Camera HDR+ treatement depends on RAW image. the RAW obtain by Camera2 API contains dots pattern. Issue cause by a bad implementation of Camera2 API RAW by Oneplus. Like you said, they only get the job done for RAW in Camera1 API with theirs own methods.
[OnePlus 5 Themes, Apps, and Mods] siankatabg:
Yep, there's nothing new in my comment for sure, it was like that since forever I guess (I'm on this brand from OP3, so I can't comment for before it, but I can guess it was even worse). For good or bad, my comment was for those that don't know this, just to let them know that there "might" not be a fix for this and to not rise their hopes much :)

It's bad when you have hope for something good, but it never happens...
[OnePlus 5 Themes, Apps, and Mods] txx1219:
In OP3, the Gcam mod works well. It's really weird that bad implementation in OP5.
[OnePlus 5 Themes, Apps, and Mods] siankatabg:
I'm actually curious about this too, but well, we have a second sensor which is mostly a decoration on all the custom ROMs without the OOS port and only makes issues with some apps (thx OnePlus, you are awesome :good: )

Nobody knows what they have changed and how they've implemented it on OP5, but for now nothing good came from it for us here.

Btw the camera2 issue that was presented on op3 with 3rd party camera apps about the ISO was never fixed by them even on OP5...
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
See this
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
Another example:
[OnePlus 5 Themes, Apps, and Mods] txx1219:
In OOS Cam ?
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
In Google cam
[OnePlus 5 Themes, Apps, and Mods] txx1219:
It's what we are talking about in the last 10 pages.
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
but it is not in the complete picture. why? it will not be a software effect of the own GCAM?
[OnePlus 5 Themes, Apps, and Mods] mystique47:
It depends on raw files, not resolution. Seems that every app shots raw with dots. The 20mp sensor doesn't have dots in raw shots. Could be a sensor hardware issue
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
I don't see same dots in RAW photos in oos camera or in the open camera app (RAW) with camera2 api. OP5T may give us a definitive answer.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Are you sure you don't see dots in RAW photos with Open Camera ? If so, sens us one to examinate
[OnePlus 5 Themes, Apps, and Mods] 8atistinha:
you're right. Same dots. Sorry guys.
[OnePlus 5 Themes, Apps, and Mods] Manya1999:
I can see weird dots in stock camera raw also
[OnePlus 5 Themes, Apps, and Mods] titooo7:
I opened a thread on OP5T subforum to ask people if they also had the same bugs that we have on OP5 with the ported GoogleCam app.

So far one user reported that touch to focus doesn’t work for him (but not sure if he’s using the right settings combination) and he uploaded some pics but I can’t confirm if he is having the dots pattern issue in those pictures.

I usually can’t even see the dots on the pictures shot with my OP5, lol
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Me too lol. With the lasts versions and the quality to 80%, I only clearly see the dots on yellow-orange objects.

---------- Post added at 11:56 AM ---------- Previous post was at 11:55 AM ----------

Can you show us ? I'm curious about this
[OnePlus 5 Themes, Apps, and Mods] gianton:
I'm getting my OP5T tomorrow and will try it.
[OnePlus 5 Themes, Apps, and Mods] mcduffie2010:
I am running one of the builds from OP3 right now. Every new build I try. One is working an other one won't. I you want a working one see my link in the liquid oreo thread.
[OnePlus 5 Themes, Apps, and Mods] markawili:
Can anyone tell me the best settings for OOS 4.5.14? Ive tried various settings and i cant seem to make touch to focus work
[OnePlus 5 Themes, Apps, and Mods] Rohit jat:
I also never seen and don't care about dot pattern as they are not visible and just got op5t few hours ago same problem exists as op5 both phone is within my reach i will be testing it out
[OnePlus 5 Themes, Apps, and Mods] titooo7:
Well I usually don't see the dots but as I said I usually watch the pictures on my phone only, I never print them and rarely zoom in. But lot of users can identify the annoying dots very easily so it's something important to be honest.

Let us know how you find your comparisions between OP5T with the Google Camera app HDR vs OP5 with the Google Camera app HDR
[OnePlus 5 Themes, Apps, and Mods] Ygor Cortes:
Unfortunately touch to focus does not work with this version, and lens blur still has a resolution of 1920x2560.
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
In the previous version, it work?

As for Op3 the maximum resolution is 1080, here is 1920
[OnePlus 5 Themes, Apps, and Mods] jhs39:
If you take a picture with No HDR+ you are essentially using the version of Google Camera that anyone can download from the Play Store. HDR+ processing in Google Camera was designed only for Google devices.
[OnePlus 5 Themes, Apps, and Mods] Ygor Cortes:
Touch to focus works on MGC_5.1.016_7.0+C2API_v.1.1_AllinOne
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
I'm going to add an exception for op5 for CONTROL_AF_MODE
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
2017/11/23 – GCMod5 based on Mod By B-S-G

Change Log :

Test Lens blur resolution 3072×4096 for OnePlus5

Test touch to focus for OnePlus5

News codes for "remove the pinkish"

GCam5.1.016-Arnova8G2-v1.3beta3.apk

Motion photo for Oreo ( config camera hdr+ : use Pixel )

Thanks for doing a test on all known bug, is making a report or logcat.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
Touch to focus not working. It's staying in ACTIVE_SCAN after a touch press.
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
Add beta 2 : GCam5.1.016-Arnova8G2-v1.3beta2.apk

Thanks for doing a test on all known bug, is making a report or logcat.
[OnePlus 5 Themes, Apps, and Mods] txx1219:
No touch to focus.

Logcat :

11-23 16:26:08.393 E/BufferQueueProducer(773): [SurfaceView - com.google.android.GCMods5/com.android.camera.CameraLauncher] queueBuffer: BufferQueue has no connected producer

11-23 16:26:08.396 E/Surface (892): queueBuffer: error queuing buffer to SurfaceTexture, -19

11-23 16:26:08.396 E/Camera3-OutputStream(892): returnBufferCheckedLocked: Stream 1: Error queueing buffer to native window: No such device (-19)

11-23 16:26:08.403 E/Camera3-Device(892): Camera 0: createCaptureRequest: Zero output streams specified!

11-23 16:26:08.404 E/Camera3-Device(892): Camera 0: convertMetadataListToRequestListLocked: Can't create capture request

11-23 16:26:08.404 E/CameraDeviceClient(892): submitRequestList: Camera 0: Got error Invalid argument (-22) after trying to submit capture request

I think the last entry is the most important.
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
And resolution Lens blur is 3072×4096 ?
[OnePlus 5 Themes, Apps, and Mods] titooo7:
Always ? Or sometimes?

As far as I know when HDR is on there is not any version that has touch to focus working always.

It usually stops working randomly and you need to close the camera or switch HDR till it works again
[OnePlus 5 Themes, Apps, and Mods] txx1219:
3456x3456 in Lens blur.

3456 is the max width in No HDR+ photos.

Same resolution for both front and back camera.
[OnePlus 5 Themes, Apps, and Mods] Manya1999:
A fully working touch to focus with hdr+ on version will satisfy me.I can live with the dot pattern.
[OnePlus 5 Themes, Apps, and Mods] Arnova8G2:
CONTROL_AF_MODE Does not work

Landroid/hardware/camera2/CaptureResult Does not work

I will try with CONTROL_MODE

The default resolution works but it's 4Mpx

[MENTION=3001941]titooo7[/MENTION] , [MENTION=3578456]txx1219[/MENTION] Test beta3:

GCam5.1.016-Arnova8G2-v1.3beta3.apk
[OnePlus 5 Themes, Apps, and Mods] txx1219:
1920x2560 now :svetius:
[OnePlus 5 Themes, Apps, and Mods] Coolshark:
Same here...

Inviato dal mio ONEPLUS A5000 utilizzando Tapatalk
[OnePlus 5 Themes, Apps, and Mods] zagzag99:
I don't think there's a setting to make it work.

I find the only working cameras with touch to focus to be Bacon Camera, Open Camera, Miui Camera and OP5 Camera.
[OnePlus 5 Themes, Apps, and Mods] Ygor Cortes:
Yeah, sometimes. When it stops working, it always comes back after switching HDR+ off and on again though.
[OnePlus 5 Themes, Apps, and Mods] Coolshark:
Ok but in this case how do you focus a specific object with Google camera?

Inviato dal mio ONEPLUS A5000 utilizzando Tapatalk
[OnePlus 5 Themes, Apps, and Mods] zagzag99:
You can't with HDR+. The camera focus on center view after you enter settings and exits.

Sometimes you're lucky and toggling HDR+ off/on causes it to refocus.
[OnePlus 5 Themes, Apps, and Mods] xiaoqiang571:
Here's my try on the veraion：5.1.014.171916386，sorry I've forgotten his really name by developers，

turn on camera.op.nes in Developer Settings and set Pixel 2017 ZSL HDR+

and then the autofocus will continually work and fucos on the middle of the screen，but it will trash when you touch .

At least the continual focus works under this settings，maybe it will give you helps，good luck buddy
[OnePlus 5 Themes, Apps, and Mods] NoobSHISH:
Same here, but it probably won't happen...