yashsingh1/xdaforums huggingface dataset:
[Magisk] EstiR86:
I wish I could help you pal all I know is there is two slots A and B and there is a bootloader,radio, and I believe vendor for both slots. (Going off what it says when flash-all) other than that I'm still trying to figure out what's the point of two slots (I know seamless updates) and trying to figure out what exactly is different.

When I tried using your module app systemizer the zip said it flashed correctly but no companion app was installed and thus I believe the issue is that the module was giving read/ write command to system. This is evident because most root browers don't work anymore with Magisk as when you go to root mode on solid explorer it allows you to view the files but it can't write to them, however fx explorer with root add-on can write to system but it ask for verification every time you do it. I wonder what's difference between the two browers and what command FX is using to mount system that solid isn't using.
[Magisk] veez21:
Cool stuff...

I still don't get it though.

Some scripts i saw use /system_root/system or /system/system.

Is there any directory in /system_root/system/app?
[Magisk] EstiR86:
I have nothing in system/root and under system/system there are the usual folders for priv apps, vendor, libs and fonts.

Not sure if this is relevant but Magisk does have its own folder in system/Magisk only thing that is there tho is lost+found folder which is empty.
[Magisk] veez21:
Cool, i think that's the info i needed ?
[Magisk] EstiR86:
I hope so ?
[Magisk] quinejh:
I've searched several threads with no luck, thought I would just ask. And Android Or has anyone been able to use airise? And if so which version? I saw where someone haduccessfully done it but I'm just unable to find that post again..
[Magisk] Veid71:
i switched the firmware versions to another 7.1.1 and installed the right vendor image and i figured out the correct kernel and in order to get the kernel to stick i have to flash that and twrp by itself after i flash the rom but when i flash magisk it still just boot loops with the green text also when i try to swap slots to A i get a "failed to mount ' / system ' (permission denied) error
[Magisk] pcriz:
Can I ask why you won't use 7.1.2?
[Magisk] Veid71:
I'm not sure tbh just preference I guess I've tried 7.1.2 and I didn't like it
[Magisk] pcriz:
Well just as a rule of thumb a lot of devs will opt not to support simply because of the difficulty of trying to remember what does or doesn't work with a certain build and so forth.

Frankly the only real advice I can give is the following.

Boot in to the bootloader

Flash all bat a factory image with -w removed from bat

Boot into bootloader

Fastboot --set-active=other

Fastboot reboot bootloader

Flash all bat again

Reboot into bootloader

Fastboot boot twrp

Flash twrp

Reboot recovery

Factory reset

Flash rom

Flash twrp

Reboot into recovery

Flash magisk

Flash twrp

Boot system

Install magisk app

Wipe data on magisk app

Enable magisk hide
[Magisk] Veid71:
yeah it still wont work for some reason :/ it allows me to boot into both but when i install the app and open it it says magisk not installed and asks me to download 13.3 for some reason but thank you very much for all the effort i guess ill just have to update if i want it
[Magisk] piccit:
Pretty sure that while in TWRP what is normally thought of as "/system" is actually "/system/system" at least that's what I remember from looking at the diffs in the a/b support pull request for magisk. I assume that was goodwin_c's request. You should be able to find it on github to confirm what changes he made to the Magisk install scripts.

At runtime, the traditional "/system" is still at "/system"
[Magisk] pcriz:
Are you downloading magisk manager from the op?
[Magisk] Veid71:
yeah i believe so, version 5_1_1 from july 20th off of android file host correct?
[Magisk] pcriz:
The only idea I have left is to run the uninstaller. Reboot recovery flash magisk and twrp again and reboot. See if it helps. After that I'm out of ideas
[Magisk] Veid71:
alright it wouldnt make a difference if i flash 13.4 or 13.3 b4 of magisk correct?
[Magisk] pcriz:
I'd stick with the newest version just to minimize variables. I can testify to the latest one working but if you want to try just for troubleshooting purposes I would use the uninstaller first reboot and try the next.
[Magisk] daddylonglegs:
Anyone get Magisk to work on a Pixel with Oreo yet?
[Magisk] veez21:
I'm back again.

Please test this

https://xdaforums.com/apps/magisk/module-terminal-app-systemizer-ui-t3585851/post73571301

module and tell me if there is any problems in your pixel ?
[Magisk] Playe:
Look right under the post you qouted...
[Magisk] EstiR86:
I downloaded the zip, just curious if I want to uninstall how do I do that.
[Magisk] zhangbo5891001:
I tried Magisk-v13.3, Magisk-v13.6, Magisk-v13.3-Pixel-b4, Magisk-v13.4-Pixel-beta2-build1 on my Pixel with oreo, but all didn't work.

Magisk-v13.3-Pixel-b4, Magisk-v13.4-Pixel-beta2-build1 can flash success, but root don't work.

I wonder is anyone successed?

PS: factory image: sailfish-opr6.170623.012-factory-8ada9373.zip
[Magisk] veez21:
uninstall it in Magiskmanager
[Magisk] Ezrem:
Did you try a custom kernel? That was required in 7.1.2. ElementalX 2.00 was released recently for Oreo.
[Magisk] scottocs:
I'm not who you were replying to, but I tried the new Elemental X and it still didn't work.

The kernel works, but Magisk does not.
[Magisk] Ezrem:
Bummer. For the time being, if you're on Oreo, SuperSU is the only game in town I guess.
[Magisk] pcriz:
What's the benefit of magisk at this point really if su hide does the same and you don't have to deal with all those apps that won't modify system with magisk root.

Just a matter of who can recover the fastest after a safety net patch.
[Magisk] Ezrem:
Pretty much, though module support in Magisk is cool...when it works.
[Magisk] pcriz:
Ahh you're right, I did forget about module support, or rather the potential for module support for us rather.
[Magisk] IlyaKol:
Can you clarify this for me? I only switched to Magisk because I wanted to start using Android Pay...does AP now work with SuperSU? If so, SuperSU was far easier to work with than Magisk, IMO.

I'm holding off on Oreo until I can have root. Elemental is done, last up is Magisk.

EDIT: Forgot about TWRP, unless I haven't been paying attention.
[Magisk] ilatimer1:
Android Pay works fine with SuperSU and SUhide.
[Magisk] pcriz:
So here is my situation. I'm on oreo, rooted with super su and using su hide to make Android pay work (Samsung pay also for my watch)

There is a twrp that lets you fastboot boot but not a flash able zip. So you fastboot boot twrp, then you flash the newest super su reboot into system once. Fastboot boot twrp again. Flash the su hide mod. Boot back into system. Open su hide and give it root then choose what apps to hide root from.

https://xdaforums.com/pixel-xl/how-to/guide-how-to-systemlessly-root-pixel-xl-t3660324/page11
[Magisk] MArtyChubbs:
I like to flash the EX Kernel before SR3 su. Is that your process as well?
[Magisk] pcriz:
I don't use a custom kernel, I know I saw some discussion of su root and EX in flar's thread but only in passing. Not sure what the details were or if it caused hurdles.
[Magisk] IlyaKol:
Thank you...that answers some questions and I know which TWRP you're referring too. I'll keep an eye on this and decided after the Sept. update hits whether to go to O or stay on N.
[Magisk] TENN3R:
In order to make root and kernel work on oreo you have to flash oreo boot.img in twrp boot partition (extract from factory image the img file), then flash elementalx and then supersu SR3, then reboot and it will work
[Magisk] TENN3R:
Hey guys, those on Oreo that says magisk doesn't work, have you tried the ADB method written in official OP?

I heard it can be related to twrp because magisk works on oreo for nexus, so ADB method doesn't need twrp
[Magisk] DudeThatsErin:
So, I'm able to boot into TWRP now (found a bootable TWRP image and flashed TWRP RC2 and booting into TWRP works fine now) but Magisk isn't working for me on Oreo. I just want to confirm that this is expected and I'm not doing anything wrong. I tried both 13.3 and 13.4 and neither root my device.
[Magisk] goodwin_c:
Hi guys,

Sorry for no news so long - i had hard days with business trips and later small vacation to have some rest. Writing just small note for now - i'm starting working on new update, going to backport all my changes over latest magisk sources. Hope that it will not take too long time.

Also, I'm planning to try Oreo somewhere soon (maybe just after i will prepare new update) - so will check how things are going with Magisk.
[Magisk] chinieer:
:good: thx a lot & best wishes to you
[Magisk] GatorsUF:
Hey everyone, I just recently ordered a Pixel XL coming from a Nexus 6P. Am I correct to assume that Magisk and/or TWRP are bit more "buggy" on the Pixel as apposed to the Nexus? I typically keep my Nexus6P rooted with Magisk but I like Android Pay so safetynet is essential. Is it a big hassle keep that working on the Pixel? I would have assumed it would be very similar to the Nexus, but my research so far has me questioning that.
[Magisk] pcriz:
It doesn't work on oreo yet

Su-hide lite works fine for Android pay
[Magisk] EstiR86:
Magisk works "okay" on the Pixel XL on Nougat but doesn't work for Oreo yet, on nougat some bugs are the modules don't work but the basics like passing safety net and systemless hosts all work. Also giving root permissions works perfectly so only real issue is modules, and the occasional read/write error.
[Magisk] Evo_Shift:
Anyone know how to get rid of the Oreo update notification? I am content with Nougat for now but not sure how to get the system to ignore the OTA. I figure others using magisk are in the same boat and have started receiving he OTA but don't actually want it?
[Magisk] :
There should be a system update package that you will be able to freeze using titanium backup. I'm not sure about Google Pixels specifically but most Android phones do. Search update in TiBu and see whether there are any packages named system update or something along those lines.
[Magisk] cruse2382:
Unfortunately doesn't seem to be the case for pixel
[Magisk] danaff37:
Don't you just have to disable updates in developer options?
[Magisk] serubin323:
I keep getting "Cannot mount /system" when trying to install modules - any solution to this? (I'm new to the pixel devices, struggling to figure out the SLOT things, which I assume is part of the issue.)
[Magisk] EstiR86:
The module isn't mounting correctly because it's not asking the right root command for mounting the system. That's why some file browsers don't work so well in root mode with magisk
[Magisk] serubin323:
Even in TWRP? This is happening in TWRP - how do we install modules then?

---------- Post added at 11:38 PM ---------- Previous post was at 11:06 PM ----------

Okay I see. The system gets mounted to /system/system. Rather than just /system.
[Magisk] Erik Rye:
What twrp image did you find, where? I can't boot into the official twrp image (non alpha). my pixel xl just blinks and never prompts for my password...
[Magisk] DudeThatsErin:
https://xdaforums.com/pixel/development/mod-twrp-recovery-pixel-android-o-dp4-t3651896

I think.

I just found a bootable image of Twrp by typing into Google "Twrp Android o*" and in Twrp flashed rc2
[Magisk] serubin323:
I've got all my modules working and I have the pixel magisk version running successfully (I have root). But none of the modules are actually going through the mount process and thus aren't showing up. Is this expected or is it a known issues?
[Magisk] EstiR86:
Known issue.
[Magisk] serubin323:
So, currently, magisk doesn't do anything but root?
[Magisk] EstiR86:
Root and safety net. What else do you really need?
[Magisk] Erik Rye:
Ahh ok, I wasn't sure if you were able to boot into the mod twrp boot img and then flash official rc2 zip but sounds like you did. Thanks!
[Magisk] serubin323:
Systemless modules - as magisk is intended for :)
[Magisk] eg1122:
Will have to wait for official support for that. Should be coming soon.
[Magisk] serubin323:
Looking forward too it - wont stop me from playing with the project until then.
[Magisk] EstiR86:
This is an unofficial build, without this we wouldn't have root that bypasses safety net, so be content for a while :)

Also when has modules actually ever worked reliably?
[Magisk] serubin323:
I'm content!

I've been eager for an excuse to go through the Magisk source and this is a perfect chance.

I just jumped on the pixel from a nexus6P and I've had nothing but stability from the very beginning, both with Magisk and it's Modules
[Magisk] serubin323:
After a little digging, it looks like the vendor mirror get's mounted without any issue, however something is preventing the the system from ever getting mounting, which is why modules aren't currently working. This is probably where a work around needs to exist to select which system to mount, as the Pixel uses dual slots.
[Magisk] EstiR86:
Yup oddly enough FX explorer can mount system as read write
[Magisk] admiralspeedy:
I have been telling people this since Goodwin started doing Magisk builds for us and nobody listened to me :P

I believe the reason FX works (and Root Explorer) (based on using logcat to monitor the command used) is because it mounts / and not just /system. When you try to mount /system with the terminal, it tells you that it's not in /proc/mounts.

You can mount /system while using SuperSU so it's definitely something weird in the SU binary that Magisk uses.
[Magisk] piccit:
Cross posting my thoughts from a thread on the matter:

Back to the Pixel. I reread chainfire's explanation of what his root method does for Pixels (https://plus.google.com/+Chainfire/posts/fvEPo42GKXS). I don't have much knowledge on partitions, mounts, Kernels, or Androids boot process, but I believe what he is saying is that supersu changes things such that "/" is actually from the boot partition rather than from the system partition (which then matches the way most/all other phones work). That makes sense to me why there is a /system_root mount and a /system bind mount (in other words, once you change "/" away from the system partition, you need to mount what it used to be somewhere to actually get to the system folder)

Now, just a guess here, but I'm thinking that Magisk isn't doing this at all. Which would mean that "/" is still actually mounted from the system partition and /system is still just a subfolder of that partition. This would explain why "/system" can't be mounted rw, since it's just a folder. And that would explain why I need to be in the "/" folder in Root Explorer to mount rw, since this folder would actually be the mount point.
[Magisk] serubin323:
Has anyone successfully built this goodwin's repo?
[Magisk] gabestover:
Whoops, mispost, please ignore
[Magisk] 314mp:
So should I wait to upgrade to Oreo for Goodwin to update magisk 14? Or is the 13.4 working on oreo well enough?
[Magisk] EstiR86:
There is no permanent recovery as of now only the bootable IMG, the zip file won't work.
[Magisk] TENN3R:
Wait, you mean once you boot O twrp, you can flash the "old" twrp zips? And then flashing zips is working?
[Magisk] DudeThatsErin:
Yes.

I was able to get into the bootable IMG and then flash TWRP RC2 and it works perfectly. Albeit extremely slow booting into it but it works fine.
[Magisk] EstiR86:
You might want to hop into the twrp thread and tell them what you did as I last recall they were still trying to make a flashable zip that works.
[Magisk] DudeThatsErin:
Alright will do
[Magisk] dadoc04:
damn... i kinda want to try to fastboot boot the O twrp and then flash rc2 but im a bit scared... ??
[Magisk] pcriz:
Its a Pixel/Nexus, either its going to work or its not and if it doesnt work then it will either not flash at all or you need to do a flash all run..
[Magisk] kpoverdorf:
Has anyone tried the new Magisk version on the PIxel XL running O stock rom? Just want to test the waters before I make the plunge and frustrate myself.
[Magisk] steveo17:
pretty sure it says in the OP of that thread that it will not work
[Magisk] kpoverdorf:
I didn't see that. Just saw a link to this thread. oh well.
[Magisk] EstiR86:
This is the thread I am talking about.

https://xdaforums.com/pixel/development/mod-twrp-recovery-pixel-android-o-dp4-t3651896/page16
[Magisk] cruse2382:
For some reason i cant get the Barclaycard app to pass saftynet has anyone tried this does it work on pixel?

https://xdaforums.com/apps/magisk/xiaomi-safetynet-fix-t3600431
[Magisk] ItWasAllIntended:
That app might do it's own root checks instead of using Safety Net. Given this isn't possible to anticipate, you might have to do something specific to bypass it but I have no idea
[Magisk] Slomies:
I'm trying to install this with the Feb build of PN and ElementalX kernel. Both install fine, but I can't get magisk to install. I've tried installing 13.4 and 13.3 b4 but both just end up bootlooping. Any ideas?
[Magisk] serubin323:
Why are you using such an old version of PN?

Do you have any logs from either Magisk or Logcat?
[Magisk] Slomies:
I'm messing with some apps that work on the Feb build.

Can I get a logicat from boot?
[Magisk] serubin323:
Use

adb logcat

during boot
[Magisk] WyldOne91:
No worries, I appreciate the suggestions regardless.
[Magisk] anuraj1:
I'm on v12 on my Pixel XL (Stock July update with EX kernel). Can I flash Magisk-v13.3-Pixel-b1 directly over that or so I need to find a way to uninstall v12 first?

BTW, thank you so much for starting your own thread [MENTION=2461994]goodwin_c[/MENTION] !
[Magisk] bggold:
I flashed b1 over new_10 and after reboot I loose safety net. Running his 5.1.0 app. I reverted back to new_10 and all is good.

I have also had issues flashing from v12 to the different v13's. I have had to flash factory without wipe and flash elementalx TWRP and the upgrade in order to get root.

Thanks
[Magisk] The Lich:
Yesss [MENTION=2461994]goodwin_c[/MENTION] finally has his own thread for this now! Excited.

I've been following your progress on your AFH and on Github for a while, man. Currently running 13_new10.

Since things look buggy at the moment, just gonna stick with what works.

You're the real MVP! Excellent work. :good:
[Magisk] inscythe:
It's gotten pretty weird for me at the moment. Last night, I went to 13.3 and lost SafetyNet and root. Then I reverted back successfully to 13_new10 and got both root and SafetyNet. This morning, I tried 13.3b1 and got root but not SafetyNet. Reverting back to 13_new10, however, made me lose SafetyNet now. Root is still okay. Anybody else having similar issue?
[Magisk] yourmghq:
13.3b1 gives same magisk log as previously posted by another user. Reflashed 13_new10 and rerun the resetprop commands after boot and all has been fine for me
[Magisk] kartikb:
After many failed attempts getting safety net to pass on the latest release of Magisk, I've had to revert back to 13_new10 and use the terminal commands. Will wait for a new release which is more stable.
[Magisk] goodwin_c:
As promised, fresh update:

- Magisk-v13.3-Pixel-b2.zip - with small fixed, updated flash part (yes, now it doesn't fail on fresh installs)

- latest MagiskManager-5_1_1.apk

- and, finally! Magisk-uninstaller-20170720.zip

What i did on my device - flashed uninstaller script, reflashed ROM+gapps from scrach. After that flashed b2 magisk. Result - everything works just fine immediately after flash - SN passes, root works.

P.S. Tests are made on RR+stock kernel. For other combinations extra checks may be needed

P.P.S. For those having issues - i recommend to flash uninstaller zip and reflash rom, reboot and only then flash latest magisk
[Magisk] MusikMonk:
Seems to be working (so far at least) on stock ROM + ElementalX kernel. Root works and SafetyNet seems to pass.

I used the uninstaller (probably not needed), reflashed the factory image (without -w flag) and allowed it to boot, then flashed recovery and reinstalled everything.
[Magisk] inscythe:
Have you tried rebooting? I lost my SafetyNet after reboot. I did enable systemless host though...
[Magisk] inscythe:
Error log for the loss of SafetyNet above.
[Magisk] Annihlist:
Absolutely brilliant. Your uninstaller solved all my issues. Magiskhide is working perfectly and safetynet passes
[Magisk] Soooperstar:
B1 still going strong for me since yesterday RR rom with hells core kernel that comes in the latest update
[Magisk] MusikMonk:
I spoke too soon. Also enabled systemless host, rebooted and SafetyNet no longer passes.

I didn't reboot before enabling systemless host so I don't know if it's connected. I can retry again and/or get logcat if needed but not before tonight.
[Magisk] Annihlist:
I tried uninstalling and reinstalling. Looks like safetynet doesn't pass after a reboot for some reason. I tried even without enabling systemless root. Magiskhide also seems not to work and lets su requests go through.
[Magisk] cruse2382:
Running purenexus rom with elementalx kernal flashed uninstaller rebooted without reinstalling rom then flashed 13.3 b2 and everything seems fine so far
[Magisk] goodwin_c:
Two reboots after successful flash - SN still passes. Enabled Systemless host + two reboots - still SN passes

P.S. Please note, that Magisk Hide starts working sometimes little late - you have to wait up to 1 minute after you will unlock your device first (after reboot)

P.P.S. Also, i'll ask for logs and info about rom/kernel combination.
[Magisk] MusikMonk:
Attached my logcat for boot, unlock, short wait then SafetyNet check with MagiskManager.

I cleared Magisk's log before rebooting, and for some reason they're still empty. Did I disable them by accident or is this a bug?

I'm using Magisk 13.3_b2 on stock ROM with ElementalX 1.14 kernel. SafetyNet passed on first boot and stopped passing after reboot.
[Magisk] y2kbugleung:
Individual thread finally!

No need to F5 AFH always!

Originally on PA 7.2.0 Magisk v13 _new_10 SafetyNet failed.

Flashed uninstaller -> v13.3_b2, SafetyNet failed.

Flashed uninstaller -> PA -> GA -> v13.3_b2, SafetyNet pass. (Core-only, MagiskHide enabled)

I want to try if module works, disabled core-only mode, reboot, SafetyNet failed.

Enabled core-only mode, reboot, SafetyNet no longer pass, ever.

Strange.

---------- Post added at 09:59 PM ---------- Previous post was at 09:36 PM ----------

Just have another test.

I have turned core-only mode off, reboot to recovery, and then flash uninstaller -> PA -> GA -> v13.3_b2

After reboot, SafetyNet pass.

I left the phone idle for around 10 minute, checked again, SafetyNet still pass.

Then I simply reboot without changing anything. SafetyNet failed.
[Magisk] jrock60:
If i am on pa June with April bootloader and magisk 12 and just lost safety net. What would be the correct steps to update magisk and not lose any data? Much appreciated for any help. Thanks.
[Magisk] ItWasAllIntended:
[MENTION=2461994]goodwin_c[/MENTION] May I ask what's taking so long for v14? With all the other updates you were quite fast getting them out. What's different with this?
[Magisk] freemini:
At this point there's little reason to bother. Official support is coming out very soon, in fact you can compile it from source if you wish. Thank you goodwin for your work.
[Magisk] ItWasAllIntended:
Where'd you get that from? All I've found if that he's waiting for his Pixel to come in the post
[Magisk] Didgeridoohan:
https://twitter.com/topjohnwu
[Magisk] ItWasAllIntended:
Thanks
[Magisk] fiveighteen:
Compiled and installed it on 8.0 (August OPR6.170623.012 build) today. Working fine as far as I can tell.
[Magisk] martinchaine:
you can share it?