yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
I'm not entirely sure, maybe OOS did something weird. Could you try the latest working image (that is v72) and check whether you get the same issue?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
May I ask where you got the theme your using?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Since there was a difference between my experience & yours : I'm trying to figure out what things were different so will ask a few perhaps dumb questions:

1) The Mokee build you were running: Was it encrypted or non-encrypted?

2) Did you do any mount/format/rm on the FS's between the TWRP boot and the restore of the encrypted nolimits ROM?

3) When you say "boot faster than your build", is it about the same as booting official, which is about 5 seconds or so? #83 took me 25 seconds or so to boot.

Thanks much!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] liver20:
Anyone tried #83 for restore boot.img from nandroid backup?

Latest official TWRP if restore, bootloop

Enviado desde mi ONEPLUS A5000 mediante Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Yes, I can try that. The thing that seems strangest to me is that both katinatez and myself were restoring the same OS (xXx NoLimits based on latest OOS V.) . The only thing I can guess that is different is that katinatez was booting to recovery from a non-encrypted OS. Does that mean he was or was not asked for his pin/pwd by TWRP? What happened to me only happened after I entered the PIN. I'm assuming that in order for him to have wound up encrypted that he had to enter the PIN at some point and that all that stuff lives off in a partition not affected by Lineage-based OS's.

I'll try V72 probably early tomorrow morning (I'm on PDT) because I've got to head out in about 15 minutes. Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Yes, restored boot,system, system image,data properly

This morning I was running mokee ROM, now I'm back on xXx no limits oos 4.5.6 this afternoon.

Steps I took

1.fastboot boot recovery.img

2.mount system in mounts tab

3.backup to internal

4.restore from internal xXx no limits oos 4.5.6

5.fastboot flash recovery recovery.img

6.plugged in usb-otg to test

1.The "no os do you want to reboot" message is still there

2.Firmware under mounts is not listed

3.using a TWRP theme, showing correctly

Logs don't lie, take a look. I took individual logs after backup, then restore.

Other users need to cowboy up and test new recovery, c'mon it's xda
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Thanks: Good reply, pretty much just want I wanted.

The thing that immediately stands out to me is "mount system in mounts tab". Did I miss that as something that's required now in #83? If so, it could explain a lot. I'll just follow your steps once before I have to run out to do other stuff.

Many thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Also backing up system and boot together with data seems to help but I would like to know whether only data also works.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
1.I was using mokee build 7-29-17 which is encrypted and restored back to encrypted xXx no limits v2 4.5.6

I think that was your problem you can't restore from non-encrypted to encrypted or vice a versa. You have to format when switching from non-encrypted to encrypted.

2. Yes I mounted system under Mounts first

3.Seemed like it booted faster, maybe because I did not see firmware under Mounts tab- that will speed things up.

Steps I took to test

1.fastboot boot recovery.img

2.Mount system under Mounts tab ( noticed no Firmware )

3.Backup boot, system, system image, data to internal

4.Restore previous backup created with my recovery, which is linked in my signature

5.Themes work

6.fastboot flash recovery recovery.img

If we can have more testers give feedback WITH LOGS. [MENTION=6584600]xdvs23[/MENTION] can update op!

And yes I restored complete data, with no bootloop
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
I didn't try to go from non-encrypted to encrypted. I tried to go from encrypted to encrypted as did you. I was just curious if you had done that also.

I'm trying it exactly as you did before I go. I can live without a phone for the night if it comes to that.

So far, I just did the fastboot boot 83twrp.img (our test image) and entered my pin. It again displayed a red pageful of vaguely weird encrypted sounding mangled names and then looked normal. I mounted /system and am halfway through a complete backup. I'm going to try restoring my last backup from Official TWRP in about 2-3 minutes when this one is done.

When I'm done I'll post the log. (If I have to run out, that could be tomorrow morning).

Oh yeah! I meant to ask if you could post your successful recovery.log from build 83. Thanks.

Note :: Near end of backup when creating digests, got this red error message: "Unable to locate /modem partition for backup calculations." and then if said it finished. Some of the stats at the end are totally wrong, like the data rate came out to -17MB/sec ;).. When you said you didn't see /firmware in mounts, did you see /modem there? No matter: I'll make a log now and reboot into this again after I catch it.

So here's two logfiles: The first one called recovery_backup_83.log is full of the errors I see on my TWRP screen, but it also contains the identical /data block details for .. /data. The 2nd log is from Official TWRP and shows none of the ~800K or so of /data/data/{mangled-name}, but again has the encrypted data block info OK. Now I've really gotta go.

There's got to be something wrong with #83 still because every one of the 100000+ files it looks for it can't stat. I had to delete 300K of line entries to upload the log to XDA. I'd look at all the data in #83 log from just after PIn entry, maybe put a few more debug lines just after PIN entry (PWD).

Manana.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Yes restored to encrypted xXx No Limits v2 oos 4.5.6

https://xdaforums.com/mate-8/themes-apps/theme-themes-twrp-3-1-0-x-t3585880

I mentioned it was a bug in my recovery that system has to be mounted manually, normally on a twrp once you allow modification to system by swiping right. The system is mounted automatically.

Both our recoveries work similar with the fact that it has the same bugs, BUT restoring data no longer ends in bootloop or wipes data on [MENTION=6584600]xdvs23[/MENTION] recovery.

They just achieve the same results with different approaches to encryption.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Your's gets the same results. Mine doesn't. From my log of Version 83 (this recovery), I'd like to understand what the 5MB of recovery.log lines that look as follows are there for:

Updating partition details...

Error opening: '/data/data/Nlqo8CLHRQetJV+iEpo3GcDuOxaI8WfG+IasNB/ynMTZTn9Z1oM3mBD,iZK6A/_AAAAAAAAAAQJsG,xyMipyrD2nvGLwUS1' (No such file or directory)

I:Real error: Unable to stat '/data/data/Nlqo8CLHRQetJV+iEpo3GcDuOxaI8WfG+IasNB/ynMTZTn9Z1oM3mBD,iZK6A/_AAAAAAAAAAQJsG,xyMipyrD2nvGLwUS1'

Error opening: '/data/data/Nlqo8CLHRQetJV+iEpo3GcDuOxaI8WfG+IasNB/ynMTZTn9Z1oM3mBD,iZK6A/_AAAAAAAAAAgPi4XpRNph61vP,pwWlJKP' (No such file or directory)

I:Real error: Unable to stat '/data/data/Nlqo8CLHRQetJV+iEpo3GcDuOxaI8WfG+IasNB/ynMTZTn9Z1oM3mBD,iZK6A/_AAAAAAAAAAgPi4XpRNph61vP,pwWlJKP'

Error opening: '/data/data/Nlqo8CLHRQetJV+iEpo3GcDuOxaI8WfG+IasNB/ynMTZTn9Z1oM3mBD,iZK6A/_AAAAAAAAAAwBg2keavWpEjuKoR0qqocz' (No such file or directory)

There's a dual-line entry for every one of my 3GB of data files. There's nothing like that in the other recovery, which works. I get a strong feeling that the problem is something to do with that initial key entry process in TWRP. (or just post that moment).

I'm wondering how to go about mounting the data file backup it produced so I can see inside of it using standard linux commands. Is it a tar/bz2/gz format? Inside the compressed file ; is there an .img file I can loop mount and compare to the other one that is working?

Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Ok I'm not able to restore any backups now I'm decrypted and was able to before but now it seems no TWRP versions work
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
when trying to restore on one plus 5

---------- Post added at 07:30 PM ---------- Previous post was at 07:29 PM ----------

content://com.google.android.apps.docs.storage.legacy/enc%3DSf3swbxytufy9AtVkFKjfSVyi4bKJ3_J-HXD_FhMSHnZe_Gm%0A
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
No idea what's going on but these are what I'm seeing. Gets to system then chokes. To scared to wipe and start fresh flash in case I can't rite now I can at least still boot my installed rom. Any help would be much appreciated
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
I finally got time to try a few things today: I tried katinatez' TWRP and tried xdvs23's again today. Neither one work get past the errors and restore for me. They seemed to behave identically filling the screen as soon as I entered my pin with decrypt errors. *see logs from prior posts*. I managed to forget to save this morning's logs so they're in the wind.

Finally I needed a working phone, so I retreated for the moment to official twrp 3.1.1.1-1 and restored my backup of yesterday and things are back to normal. I guess no one got anything from my prior logs? I might download one of you guy's TWRP code and pepper it with enough debug statements around the "pin entry" to see if I can find what's happening with mine.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
I did check the log from you, I have the same errors as you mention, with 83 and katinaz twrp or something like that.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] unknownblkman:
I fixed it ty.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
You referring to me or the other post

---------- Post added at 10:58 PM ---------- Previous post was at 10:56 PM ----------

Fixed what?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
Previous post hachamach
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] unknownblkman:
The post I posted about not being able to backup I posted last night ..everything is working well and was able to successfully take a nandroid and restore
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
What's your secret to successfully backup and restore? Encrypted or decrypted?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
How'd you fix
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] unknownblkman:
Sd card fix zip and https://www.androidfilehost.com/?fid=817550096634788926 followed these steps

---------- Post added at 11:34 PM ---------- Previous post was at 11:33 PM ----------

Encrypted
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
I totally forgot this, I did flash the SD card fix, also flashed xXx no limits aroma installer has this as an option and I did flash the SD card fix.

Someone please try this step.

I did plan on building recovery in lineageOS repo, including some other commits.

But for now, try this step
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] unknownblkman:
The info I was provided was from [MENTION=230517]FuNk[/MENTION]wizard should thank him.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Have a link to the sd card fix zip and what steps did you follow?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Link to this post, please
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] unknownblkman:
And also I forgot to mention Funk Wizard:

https://www.androidfilehost.com/?fid=817550096634788926
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
Did flash the SD card fix as you can see, still those errors in red like above, with twrp katinatez version (and 83 test version). I am not having these errors with 73 version from this topic, also not with the official version 3.1.1.1. I can post a log, but it is very big, thousands of errors like the other guy that already posted logs in the other tread. The errors looking like this :

I:Backup folder set to '/data/media/0/TWRP/BACKUPS/d84b5558' I:Settings storage is '/data/media/0' Updating partition details... Error opening: '/data/data/_AAAAAAAAAAAh5uX2VwmhVTDb4sDUTxBw' (No such file or directory) I:Real error: Unable to stat '/data/data/_AAAAAAAAAAAh5uX2VwmhVTDb4sDUTxBw' Error opening: '/data/data/ZeiiK72Hl3gXvipdr4FAtLaxwe+nmvRvhCQt6C/Hb+KTIdi4xrF7JGSSXDBGA/_AAAAAAAAAAwctO,6WZH4LGA5sl9TYtys' (No such file or directory) I:Real error: Unable to stat '/data/data/ZeiiK72Hl3gXvipdr4FAtLaxwe+nmvRvhCQt6C/Hb+KTIdi4xrF7JGSSXDBGA/_AAAAAAAAAAwctO,6WZH4LGA5sl9TYtys' Error opening: '/data/data/_AAAAAAAAAAQgQnXfgnVLUwp1Boc,JURj' (No such file or directory) I:Real error: Unable to stat '/data/data/_AAAAAAAAAAQgQnXfgnVLUwp1Boc,JURj' Error opening: '/data/data/Dodn7OY0ACqE+VmNywHMJSdeEDtsqaGu/9TrtTJd9MNFVqX3uyqrEqC/_AAAAAAAAAAwJ0NfoBHyY5CEsqMXmSdq3' (No such file or directory)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Didn't work for me
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] bpambrose:
Working Restore

Did a restore and it worked perfectly. Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ulxerker:
including data and finger prints?

please link to the working version (twrp.img).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] bpambrose:
Working Restore

Yes everything seems to be working
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ilia1985:
Havent tried restoring as I normally don't keep backups but OTG is working finally ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ulxerker:
please post a link to the most recent version of TWRP that works for you - thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Did anyone have a chance to look at the logs I provided to give me an idea how to fix this issue
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
I took the chance and I wiped and installed xxx no limits ROM and no issues doing that. Still can't use magisk for root unless on a ROM like RR but not stock based. I'm wondering if magisk root is the issue I'm having in recovery with backing up. Since I was on RR with it as root and couldn't backup. Idk just a thought
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ilia1985:
Build 83 from few pages back
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
OK happy to announce that after a wipe and installing xxx no limits ROM with super super that backups are again working in two. Now I am using the one by katinatez but don't think it matters. The only difference that i see is that the ROM I was on prior was rr based on lineage and magisk for root. I was able to backup and restore having that ROM installed before so what happened,? I noticed that when they were failing the order was boot,data system. Now it's working and the order is boot, system, data. Is magisk the culprit
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ulxerker:
So these red errors in twrp's console don't matter and it works, though?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] ilia1985:
I didn't get any errors so far
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Dinerve:
Is this it then? Are we golden?

This is build 83 you are referring to from the OP?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] bpambrose:
TWRP What Worked For Me

other TWRP Forum
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kgr:
Hi I'm using the 73-20170716-125431-CEST build and I can't seem to mount /system as rw anymore.

When I search it, a lot of posts point to a problem with TWRP. Is there any merit to this reasoning?

See attached pic

*edit* full wipe & format data fixed it lol
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
If your looking for an answer or response you probably won't get it here I've tried and posted logs and no answer
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
[MENTION=3814731]katinatez[/MENTION]

I think I found the problem.

I was messing around with it yesterday and came up with something logical.

So OOS has file encryption enabled by default, that is

fileencryption=ice

in fstab. That means that file based encryption MUST be there in order for it to work otherwise it will refuse to work. Now when you restore a backup in TWRP, it will wipe /data first and then restore the backup, which removes file encryption. Now when you try to boot OOS, it refuses to work. Removing that fileencryption=ice from fstab should make it work again, but decrypted.

Now if you want full disk encryption instead, you can be both decrypted and have encryption, but not file based encryption.

encryptable=footer

This will require the data partition to be shrinked 16 KiB (16384 byte) so that the encryption footer can be stored there.

So what you can do is:

- backup internal storage to external media

- make data backup to external media

- format /data (not wipe! Do a format!)

- change fileencryption=ice to encryptable=footer in fstab (needs bootimage change)

- restore data backup and copy internal storage back

- shrink data using resize2fs

- reboot and you should be decrypted

- now in settings you can do full disk encryption.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
We are in the right track I have been looking at the stock fstab as well. And this commit piqued my interest

https://github.com/omnirom/android_...mmit/eb3106c8f4a8f75d0fcbbbfcad203c47b98413b5

Your suggestions are great, about backing up to external usb. I have experienced the total wipe of phone while testing recoveries just yesterday.

And another discovery I made is why there is mixed reports of backup/restore failure. We need to flash the sdcard fix.zip floating around for our twrp builds to work.

Quick way to find out if user needs this is to try to take a screenshot from twrp recovery and if the screenshot is not saved to internal/Pictures/screenshots then you have to flash the sd card fix.zip then recovery & screenshots work.

On my front I have been working on pulling the 4.5.7 crypto libs/qseecomd. will push commits later tonight
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] 3DSammy:
I've never flashed the sdcard fix zip but had no problem taking a TWRP screenshot although I currently have the other TWRP (called OFFICIAL) installed. Does the issue you describe only effect this (v83) version of TWRP? Personally the variation of user restore failure/success is driving me nuts especially with the so called OFFICIAL seeming to be so unresponsive although they finally accepted your OTG fix. Personally I'm hoping you guys reach the stable backup/restore goal first, just based on your active thread and responsiveness.

Thanks for all your hard work.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Have never flashed any sd fix zip, verity zip, anything.

Just using my TWRP.

Currently using halogenOS and I have block based encryption (fde) without any problem.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Lavarock:
I didn't understand what is not working with twrp on 3.1.1 .

If I take a Nandroid of my phone with twrp and I restore it later because I've problem, etc... Will I get a bootloop or something like that? Thanks in advance!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Baldesarra:
Same question here. Restoring working on newest release?

Some people say yes, other say no.

If I want to restore data, do I have to use 0716 release or 0729?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] paratox:
[MENTION=3873953]eng.stk[/MENTION] got a free OP5 from oneplus for his fantastic work he did for OP3/T so we will have a full working TWRP recovery in a short time! ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gonsa:
What's the difference between this recovery and this one: https://xdaforums.com/oneplus-5/development/recovery-twrp-3-1-1-0-touch-recovery-t3632912
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gvaram:
Who is your source? As far as I know, this project isn't planned. In his OP5 kernel thread he said -"For the time being my priority is OOS kernel and will consume pretty much all of my time since it has lot's of new stuff."
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Dan3ll1:
HeyHo,

i have a problem with my TWRP it is Decrypted and i dont know why. When i first get my 1+5 i unlooked it and flashed the Official TWRP .img by using the TOOL ALL IN ONE from XDA --> Everything was fine. Flashed SuperSU and 1 week later the .x265 Mod for the Cam. Last week i flashed the Full Official OOS 4.5.7 zip file. So today i was just booting into my TWRP recovery to see that it is DECRYPTED but i cant remember that i ever put a pin or a password in it. Is there any way to get it to "stock" TWRP without the PW?

Okay i solved it on my own...

Since when dose TWRP set the SimPin as the PW?!?!?!? o.O
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] paratox:
my assumption was because he did it for the op3 / op3t also. sooner or later i think we will see a twrp build from him because he don`t like broken things and is the right dev to fix it. but hey ... it was just an assumption. hopefully it will get true! :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gvaram:
Hopefully, your assumption will come true...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Legend_dimebag:
That link is official, this unofficial ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] schlimmchen:
Worked for me using v83 ("0729" as you referred to it). Restoring OxygenOS backup to file based encryption /data.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] biohaz55:
Really not good posting these comments in xdvs23 thread :(

A lot of work has been done to get TWRP to this stage and you just dismiss it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] paratox:
you are right. it was not very tactful. sorry to the devs who did all the work where TWRP is now. i don`t wanted to be disrespectful.

but i hope with new experienced devs on the OP5 and their input we should sooner see a full working TWRP.

@ topic: there are many questions about data restore and no actual answers from the devs. what is working on latest version on encrypted / decrypted and what not?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
[MENTION=6584600]xdvs23[/MENTION]

I figured out the recovery error logs in red print!! Testing new recovery right now!

I read every line in the recovery.log but found the answer in the kernel.log!

The problem resulting in all those errors is all the fscrypt: commits in kernel, I just rebased kernel source to this and everything is golden!

https://github.com/katinatez/android_kernel_oneplus_msm8998/tree/QC8998_N_7.1

Also your Fix USB-OTG commit does not fix the usb-otg, I believe since the official twrp device tree is using a pre-built kernel. That is why its not picking up the kernel command line. I verified this by compiling official cheeseburger device tree and testing on my own phone.

I just submitted a USB-OTG fix into gerrit which I compiled and verified it does fix it!

https://gerrit.twrp.me/#/c/2634/
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] PAYload1976.dl:
This is great news katinatez :good::good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
This is phenomenal news! Are you also able to backup and restore encrypted ROMs successfully? If so, would you mind sharing your new working test version?