yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
My commit was submitted to official tree, take a look

https://github.com/TeamWin/android_device_oneplus_cheeseburger/commits/android-7.1

Now compare that with mine

https://github.com/katinatez/android_device_oneplus_cheeseburger/commits/android-7.1.2

There is a test image here of official that will be released after the readme commit is merged, click expand all, and you will see it, I would upload mine but it's the same build. Never the less once I successfully restore encrypted rom from encrypted oos 4.5.8 from [MENTION=1030560]xXx[/MENTION] (just giving credit which ROM I run too) I will place it in my work signature named 3.1.1-k2

https://gerrit.twrp.me/#/c/2634/

Changelog

USB_OTG working, all smooth, no errors in recovery log. I am going to try restore mokee encrypted from usb_otg will post recovery log in a couple of minutes.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] djsubterrain:
Build 14 stuck on splash screen again for me

Tried flashing build 12 again and using adb pull to grab the logs but the device isn't being seen, doesn't show up in adb devices
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] aydinbahadir88:
I'd rather wait for the official version
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] rav101:
Same. Thought I did something wrong because you had the earlier builds working that I hadn't tried.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
New image

Should work again now.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Official versions are also first made by someone and then submitted to TWRP.

I'm just trying to speed this up instead of waiting for someone else to do it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Zombie:
Latest build boots but I still get nonsense folder names
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Well then encryption is still broken :eek:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] aydinbahadir88:
Official versions are also first made by someone and then submitted to TWRP.

I'm just trying to speed this up instead of waiting for someone else to do it

Okey good to know

I wish you luck

---------- Post added at 10:13 PM ---------- Previous post was at 10:13 PM ----------

Ah okay good to know

wish you much success
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] rav101:
For reference,

I currently use pattern protection on my phone. On the Chinese version it asks me to input the pattern when TWRP loads up. Again I reckon it must be possible, it's just a matter of figuring how that one was done? Silly people not opening up their sources!!!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Well I'm trying to figure out all the time how the chinese one works.

Seems that the guy behind did similar stuff to what I am doing.

I am using the chinese as reference now as I extracted the ramdisk so that I get the idea of what I have to do.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] rav101:
Fair shout. I'm around for a little while longer but it is getting late here and I have an early start in the morning. Must be an hour later for you in Germany so make sure you get good rest tonight too if you can buddy.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
New image

Again, encryption stuff

And also test if screenshot works.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Well yeah I'll probably try a few times more and then I'll go to bed.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hibby50:
I keep getting fastboot error "Requested download size is more than max allowed" very odd
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
This is a weird thing and you're not the first one. However, for most people this does not happen.

Need to find out what's wrong with that one, maybe it's OnePlus.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hibby50:
figures it happens to me lol. In your bootloader does it show the baseband and bootloader version? Mine are blank. Also secure boot is labled yes.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pho3nX:
Just for info, there a mate can share his Nandroid backup, i have wipe system partition (i wipe so fast like my S7 Edge lol) or if there a link to OxygenOS? Thanks
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Makrilli:
Still random folder names

Unable to take screenshots :(

Btw what drivers should I use to sideload, with phone booted adb works fine, but in recovery no devices show up in device manager

Edit: My bl is also messed up, just shows blank even before flashing twrp.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] brmbjn:
Thank
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Well I don't have the device yet but one of our testers reported that he got the exact same problem.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Nice! :highfive: I am ready to try your new TWRP 3.1.1-k2 once uploaded. I'll also be testing it with xXx and Mokee ROMs.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
I can confirm I successfully was on oos 4.5.8 No Limits from [MENTION=1030560]xXx[/MENTION] and restores to mokee build date 8-1-17 from the USB-OTG, continued to update to mokee 8-5-17

No boot loop, data restoration is fine, And no more ugly message

"No OS your sure you want to reboot?" or something like that

Here is a direct link of my build I'm running tests on for those that trust me. Also in my signature

https://www.androidfilehost.com/?fid=889764386195921506

Now to test restoring back to oos 4.5.8
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
OK, I'm back on oos 4.5.8 No Limits!! Still encrypted using same pin on oos 4.5.8 as I was using in Mokee.

Now the recovery log show a corrupt zip file for mokee build but It was my doing.I removed a lot of system apps and mokeee checks for system apps before starting the flash.

Restored just fine back to where I was at which was oos 4.5.8

Have fun testing, going to bed.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Kallmeidroppe:
Should i also Backup both System partitions with this twrp?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] chris264:
Many Thanks for your work.

Work this with decrypted?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
[MENTION=3814731]katinatez[/MENTION],I can confirm the red errors are gone that I had in the past (and showed logs). Did not try a backup and restore (for now), but no errors anymore :highfive: edit: xXx rom with bluspark #8 kernel.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I think all versions of TWRP worked well with decrypted data. Give it a try and report back!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kimyeungg:
lol
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] marcrb:
Then I understand that with this twrp you can backup without problems? Without removing pin, pattern or password? And install OxygenOS 4.5.8?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Thanks for carrying on the battle. So far it seems good to me, so nice work! -- I just installed, plugged in and mounted OTG device and did a full (all partitions) encrypted backup to the usb-stick, then restored it. I saw no red characters, and I may have forgot to save the log (doH!) but will look in the backup folder in a bit.

Currently I'm running noLimits with Elemental 1.06. No problems. Oh yeah, themes working fine as well. Unless something odd crops up, this could be a real recovery.

Good work to you guys for persevering.

Other things tested: Sideload mode OK; Adb shell OK. Installed xXx ROM latest version with another kernel: OK.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Thanks for testing thoroughly, & confirmation to xda community
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Derrick Watts:
Backup and restore

Does the backup and restore only work from a backup using OTG, or will it work from a backup on the phone itself?

Great work!!

Thanks,

Derrick.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
No this means it's fixed and carry on. Or should be. Lol. He posted a test version so test. And yes their was issues with decrypted as well but should be ok now

---------- Post added at 06:36 PM ---------- Previous post was at 06:13 PM ----------

Yes
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Mayday_XL:
+1

Mayday@OnePlus 5
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Derrick Watts:
Well i just wiped my phone then restored from a backup on the phone with no problems.

Running No Limits, ElementalX, Magisk and encrypted with pin code.

Been waiting for this since getting the Oneplus 5.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Anyone unencrypted try this out yet? Gonna try when home tonight and give feedback. Issue I was getting was not restoring and getting the system needs cleaning message in recovery
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Jsilver73:
Working perfect here encrypted - backup xxx - flashed carbon then backed that up. - restore xxx up working perfect. :good::victory::highfive:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
One more thing I want to add is I'm using this theme for recovery.

Placing a link to themes, you would flash the 311X_v2 test version in recovery, then reboot recovery.

Here is the theme thread by [MENTION=2719389]z31s1g[/MENTION] awesome work!

Here is the downloads you flash in recovery
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
I just made a backup with otg on my USB drive. Also working (but very slow, it is a fast Adata flash drive, with my Oneplus 3T, twrp much faster backing up on the same drive and same otg (original) cable). It did backup with a average speed of 7Mb/s. Now I need to test (maybey tomorrow) if restore is working from the otg USB drive (katinatez TWRP latest version).
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sytayeth:
I did a backup with a OTG USB drive, with XxX OOS, then I flash RR Os, and after I did a Restore from the OTG Drive. And everything has gone perfect.

Thanks for your work.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
That's also my favorite TWRP theme!!! :good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
Amazing [MENTION=3814731]katinatez[/MENTION]. Did a restore from OTG backup, with FreedomOs 1.6,and working :highfive:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Agreed! The question is do decrypted backups and restores work? Hmm.....
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
No idea, I prefer encrypted because of security. Maybey someone else can test it without encryption :). I am very happy that it works with OTG, and the 'red errors' while booting twrp are gone also. Happy camper here.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Same here! :highfive:

I'll probably test decrypted just for kicks if no one beats me to it....
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kimyeungg:
hi katinatez,

do i need to backup including "system image" for restoring those data too?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Yes, I believe so. That's what worked for me. I'm not sure if it would work without the system image.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kimyeungg:
cuz i saw katinatez mentioned that in the "official twrp" thread before :crying:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] paratox:
:good: looks like [MENTION=6584600]xdvs23[/MENTION] and you did it! a big thanks and sorry again for my disrespectful postings in this thread. :o
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Stupifier:
Using the TWRP test image recently posted, Unencrypted.....I was able to Backup/Restore FreedomOS OOS ROM successfully from phone internal storage.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I'll also be testing that soon. Thanks for the confirmation it is working!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
I"m still very happy with the latest TWRP and haven't been able to uncover any problems.

Couple of things: Although I like the theme [MENTION=3814731]katinatez[/MENTION] listed as being one he uses because it's more 'natural' feeling, it seems like it doesn't theme all the functionality of the original UI (or does it do everything and I'm not yet seeing it?). Anyway, it does enough and it is better on the touch and UI world so thanks again.

Also: It seems like after all the work that [MENTION=3814731]katinatez[/MENTION] & [MENTION=6584600]xdvs23[/MENTION] did to whip this thing into shape, that it should be in the OP, replacing both of the other links so that newcomers looking for TWRP can get that this is the one to use. (Unless and until Official TWRP status is confirmed and then this can replace that thread or so I'd hope).

Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
I installed the TWRP Image on my phone (I'm encrypted but only have swipe up to open) I backed up NoLimits latest build to internal storage.

Did a Factory Reset and hit restore about half way through the restore failed I don't remember the message since I went into panic mode:).

I noticed that when I started the restore it said 6.9GB but the backup was about 5.7GB. The phone is so fast that there is no time to go whooaa stop a bit:D. Anyhow spent the last three hours putting things back to normal had to start with cleanflash of NoLimits then my appbackup program (OandBackup) would not recognize it's own backups:confused:So I had to install them manually from the directory myself. Luckily both the app's and data was restored. Next I went hunting for a new backup app and I found one faster than sin. It backs up and restores just about anything. I Use Viber as a test app, If you can restore Viber with data and it works from the get go then it's a good app. It's got an interface that takes some playing with but I reccomend it for a Try out, much faster than Tiranium;) you can find it here:

https://play.google.com/store/apps/details?id=com.idea.backup.smscontacts

Anyhow All is well again I probably did something wrong. Only had the phone a week used to Se Samsung since the I9000 days.

I'm retired so spending a few hours fixing the phone and learning a trick or two is OK.

I'll Try again in a week:D:D

Hmm I flashed the Image using TWRP 3.1.1.1 and after the flash it said TWRP 3.1.1.K2 but interestingly I had flashed the Black and red TWRP theme earlier and it was still there after Flashing 3.1.1.K2? Not sure if that has anything to do with anything........
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
To replace op links is not up to me, that is [MENTION=6584600]xdvs23[/MENTION] decision. Besides we have different device tree for compiling. I have only been very active in recovery threads because; I like everyone else wanted a stable full functioning recovery. With xdvs23 collaboration we have come to this recovery release. But its not over I plan to release another 3.1.1-k3 changelog I have planned is to rebase & update kernel source to oos 4.5.7 and add other kernel related commits. And look into speed up backups to USB_OTG. Here is my new kernel source for next release.

https://github.com/katinatez/android_kernel_oneplus_msm8998/commits/QC8998_N_7.1
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NHNXDA:
I was reading on twrp site, you need to use a custom kernel otherwise you may face issues when you swipe to allow modifications, is this still the case with the twrp versions current on the thread as I cant see anything about that on here.

TIA.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
The kernel source was the problem on earlier releases that was coming up with errors in recovery log. My logic in rebasing kernel source is to start from scratch and just add what is needed for recovery. Besides I'm already running new version and I don't see any problems, but won't release until I'm satisfied all testing is done.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NHNXDA:
So with latest versions on here you can now "swipe to allow"?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I'm loving your work, my friend! If you need another tester, just let me know.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I can personally confirm that [MENTION=3814731]katinatez[/MENTION]'s TWRP build can backup and restore data successfully on both encrypted and decrypted devices! Again, great job, my friend! :victory:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
Can you do a factory Wipe before Restore?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Rebel7022:
Can you like me to that twrp thread
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
I was running stock kernel when I had my problems posted earlier. I did the backup with your Version and then a Factory wipe Followed by a Full restore. I ended up with a wipe and had to reinstall xXx NoLimits again(it did not wipe the SD card) with the next version will I be able to follow the procedure I described? I'm encrypted but only have swipe up on lockscreen, no pattern or fingerprint.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Yes, I wipe everything except internal storage and OTG before doing restores.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
You dont swipe Factory wipe, you go to advanced wipe and tick them individually?

What exactly do you guys mean with OTG?

When I do a backup I tick

Boot

Cache

System

Data

Modem

And then I just start the backup(sometimes I edit the name of the backup)to internal storage in the TWRP Directory.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Yes, I usually use Advanced wipe and select stuff individually.

OTG = On The Go

With the right cable, you can attach an external drive to your phone for additional storage possibilities.

I always name each backup.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
So when you were successful was that going to an external drive or did you try internal storage?

And did you use stock kernel?

Sorry for pestering you with questions I'm trying to figure out why I had problems.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I back up to internal storage and I've restored many times (decrypted and encrypted). My device is currently decrypted and running Validus ROM with their stock kernel.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] inffy:
What partitions need to be backed up and restored to get it fully working? Just the normal Data, system and Boot?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Personally, I backup and restore everything except Cache and Recovery. I've had zero issues with this special build of TWRP. In my opinion, it should become the "official" version.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Sorry for being inactive in the last time, I haven't been very motivated and I also sent my OP5 in for replacement, hoping to get the new one tomorrow and then I'll be about a week on vacation so I won't do much during that period.

As far as TWRP goes, I see that [MENTION=3814731]katinatez[/MENTION] did some pretty good stuff over there and tried to get stuff forward, highly appreciate that.

[MENTION=3814731]katinatez[/MENTION], could you give me some links to commits to pick?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Rebel7022:
What happened to your op5? Why did you have to send it back?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z31s1g:
What functionality are you missing? It's true, some stuff is not in the same place.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
I think that I'm probably not missing anything. It's as you said. Things aren't in the same place and as I use the theme, I like it more & more. I think the way the actual "themes" button in TWRP (when themed to your theme) works is different, but that's not important.

I like it! Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
I thought you were upset at me because the thread blew up after I found the problem, and sounded like I was taking over your thread.

The solution is to change to this kernel here (twrp_defconfig), and your recovery will work awesome. No more recovery error logs.

https://github.com/katinatez/android_kernel_oneplus_msm8998/commits/QC8998_N_7.1

Feel free to pick what you want, I'm testing another build with these added commits

https://github.com/katinatez/android_device_oneplus_cheeseburger/commits/android-7.1

This is what I released that everyone is happy with, found here.

https://www.androidfilehost.com/?fid=889764386195921506

I had double tap to wake on recovery working on earlier builds but now does not work. If you could find me the kernel commits to fix, it would be appreciated.

I got 10 mb on exfat usb from usb-otg, but I think we need to do better than that, these last two things I need to fix before another release.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a g bell:
Just tried to flash this over stock twrp and it wouldn't boot ?once from recovery once from fastboot both times it just boots to bootloader
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Over 200 downloads, and this is the first mention of boots to bootloader. Are you

Booting into bootloader then?

fastboot flash recovery op-5-twrp-k2.img

Or install image from inside twrp

select recovery partition
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a g bell:
Dude trust me l have flashed before?

I am on du caf should that make a difference?.from stock twrp flashed recovery.img from that boots to bootloader then tried fastboot flash recovery k2.img renamed it because l am lazy booted back to bootloader then fastbooted stock twrp not problem?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Enter bootloader

fastboot flash recovery k2.img

fastboot reboot

then boot to recovery

That's how I do it, just cause you flash new recovery, your still going to be in fastboot

Try this

enter bootloader

fastboot boot k2.img
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a g bell:
Will do but will be be tomorrow before l am back at PC will try again and let you know?l did reboot the device though and tried to boot to recovery and it still booted to bootloader.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
I just found a other theme on xda forum (oneplus 5 section). Also great with the twrp I use from you! :laugh:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] letmedanz:
Just adding to the other confirmations, everything seems to be working fine. Thanks [MENTION=3814731]katinatez[/MENTION] and [MENTION=6584600]xdvs23[/MENTION] for all the effort. Although XDA can get very annoying at times, your contributions show case the true spirit of the community.

Thank you
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Yes very nice been using for a few days
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] PAYload1976.dl:
Can confirm. Have used this recovery since Katinatez uploaded it. Backup and restore encrypted (rooted stock 4.5.8) works fine. Haven't tested any decrypted yet.

Thanks to the devs making this possible :good::good::good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
There used to options to center the clock and move the Back button to the far right side of the screen instead of being on the left. Are those tweaks still possible? Can't seem to find those options now.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] z31s1g:
Yes, they are still available:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Ahh... I see the problem! I was thinking those options should be located in the settings "gear" instead of in the color palette icon. Thanks and... Doh! :cyclops:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thedao:
It is still required to restore system image partition right?