yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gvaram:
Now that I'm convinced that katinatez's TWRP is working gonna flash it, when i get back home from work.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] inffy:
Not really sure. I only restore Data, System and Boot. Currently using the Blu_Spark twrp.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gvaram:
Am I missing something? Is this TWRP even ready? Are you a private tester.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] inffy:
It's ready and linked to the Blu spark kernel thread
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gvaram:
Great, thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Well, long story short: camera has water in it and hence it is completely blurred. So before anything else breaks, I sent it in and I'm getting a replacement.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Alright, thanks, but the exFAT stuff as well as all that USB storage stuff does not make much sense to me.

(Who uses exFAT these days... also it is actually proprietary and should not be included in the kernel)

As for the usb storage things in defconfig, I don't think it's necessary to build all those drivers and whatsoever, but might give it a try later.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
Interesting reply considering his version actually works:confused:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Yea, I did that late last night. I should of created a testing branch. I will do that today, move over to a testing branch.

Will update that later.

Again these commits I pushed last night are meant for testing possible next release.

And I did that because I'm running an exfat USB 3 with my otg.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Alright. If you have the time, could you try disabling one after the other config in defconfig (these USB storage ones you uncommented) and see which one breaks? That way we can get rid of redundant things.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a g bell:
Just dl again and flashed via official twrp all working great must of been a bad dl

Thanks?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Already moved over to testing branch, if your going to compile using your device tree just use this one here, all usb drivers are disabled

https://github.com/katinatez/android_kernel_oneplus_msm8998/commits/QC8998_N_7.1
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gvaram:
Thanks [MENTION=6584600]xdvs23[/MENTION] and [MENTION=3814731]katinatez[/MENTION]! Used k2 version, everything works so far. Great job.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] 3DSammy:
[MENTION=3814731]katinatez[/MENTION]! if I have the k2 version installed and use security (e.g. pin and fingerprint scanner), do I need to disable that to get a restorable nandroid backup? I've read every post in the thread and see all the restore successes but have missed any comment on the need to removing security before taking a nandroid backup as was a previous requirement.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] letmedanz:
Not required.

I have restored backups which have pin and fingerprint multiple times with no issues.

Twrp will however ask you for the pin.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
Had problems when I tried k2 before as you can see from My Postings, so I re-read every single post about K2 about 3 times;)

Reinstalled k2 (new Download)in Recovery(Flashed image in TWRP) Checked and both K2 and 3.1.1.1 come up with the same amount of storage to be backed up.

Boot

Cache

Recovery

DID NOT BACKUP SYSTEM IMAGE

System

Data

Modem

It all adds up to 5.8GB, K2 Backup runs fine no Red messages, warning about not backing up photos etc. are in Yellow backup finishes OK. Wipe Dalvik and Cache. Reboot phone.

Phone Boot's up fine and everything is OK.

I'm encrypted, double tap to wake up, swipe up on lockscreen.

If I do a Factory Wipe and then do a full restore on the things I ticked above should I end up a happy camper or am I likely to have to spend a few hours getting my phone back to normal:angel:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
I'd briefly started poking around in this recovery source awhile back by setting up enough omnirom git to build (another device anyway) "make recoveryimage". That was fine. Now I'm looking at your git and wanting to unpack the vendor/device/kernel into my omnirom tree. When I look at your vendor file from this named item in your github "android_vendor_oneplus_cheeseburger-XOS-7.1" , I see lots of stuff under vendor/... that doesn't seem to belong there (libs etc).

I realize this is OT for this topic and I can ask it elsewhere if you prefer. Feel free to send me a PM if that's better. I'm curious where the unpacked vendor tree should go if not under ./vendor/oneplus/cheeseburger/.. ...

Many thanks,

---------- Post added at 07:52 AM ---------- Previous post was at 07:20 AM ----------

Sorry: Never mind my prior question: I just figured out what I was doing wrong. Had to do with roomservices.xml.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Is there any reason you chose NOT to backup the system image? I thought I read somewhere it should be backed up for successful restores. Well, I back it up every time and my restores are flawless every time on both encrypted and decrypted devices. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
I was going to upload manifest to github, but have not had my morning coffee yet. So I will just add it here for now

<?xml version="1.0" encoding="UTF-8"?>
<manifest>
<!--<cheeseburger twrp device tree -->
<project name="katinatez/android_device_oneplus_cheeseburger" path="device/oneplus/cheeseburger" remote="github" revision="android-7.1" />
<project name="katinatez/android_kernel_oneplus_msm8998" path="kernel/oneplus/msm8998" remote="github" revision="QC8998_N_7.1" />
<remove-project name="android_system_core" />
<project name="katinatez/android_system_core/" path="system/core" remote="github" revision="android-7.1" />
</manifest>

repo sync

. build/envsetup.sh && lunch omni_cheeseburger-userdebug && make -j* recoveryimage

make -j* replace the * with the number of cores from your computer I have a server so my original command is a one line

. build/envsetup.sh && lunch omni_cheeseburger-userdebug && make -j40 recoveryimage

Remove this line on your local files

https://github.com/katinatez/androi...mmit/6e6ff4c0cfb7a1520062994794ea7ca8114a32f3

Enjoy :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Thanks! I just got a build working a moment ago, but have to take off for much of the day today. I'll try your .xml file. I appreciate it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Also why backup cache and recovery?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
I'm used to Samsung and there was only one system to backup. I was not sure what the image was for. Is that only required if you do a full wipe or do you always have to restore system image?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I don't backup those two items.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
I'm used to Samsung only one system to backup. Do you need the system image for when restoring after a full wipe?

On Samsung you usually don't backup modem and bootloader(recovery is not even an option). I just ticked everything(except system image) because it was there :(

So you always include system image in the backup, that's probably where I screwed up on my first attempt. I was sort of taken aback by an 8+GB backup:laugh:

So if I include system image I should be ok

---------- Post added at 05:21 PM ---------- Previous post was at 05:13 PM ----------

What is the difference between system and system image?

---------- Post added at 05:29 PM ---------- Previous post was at 05:21 PM ----------

I now have a full backup with everything ticked, should that be OK to restore with my doubletap to wake and swipe up or lock screen?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Stupifier:
On the latest twrp-k2.img build and Encrypted. I did not Swipe to "allow modifications". Will restoring data from a backup work?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Just got home for a bit: Looking at your .xml, I'm wondering if there should also be a line for local sync of this: https://github.com/katinatez/android_vendor_oneplus_cheeseburger

as : <project name="katinatez/android_vendor_oneplus_cheeseburger" path="vendor/oneplus/cheeseburger" remote="github" revision="android-7.1" />

? I had been using it with success just before I left but maybe you've got it in your main XML file.

Thanks!

Oh yeah: I had originally done the following to get my base build down from github:

repo init -u git://github.com/omnirom/android.git -b android-7.1

I'm curious whether you did the original repo init using that target? Thanks.

--------------- Cancel that ^^^ last part ----------------

I just realized that we're based from different places but are using the same vendor/device/kernel code. I just made my BoardConfig.mk like yours and basically we're in sync. I have the 3 paths I need in my roomservice.xml file to keep it in sync.

I realized that the one 'remove path *core*' XML wasn't going to work for me since I'd done a different 'repo' statement to start with. All seems good and it's a good clean base for me to mess around with. Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
I did a measly attempt to restore system and System image just to test. The restore went OK but I ended up with boot loop, I let it spin for about 5 minutes on the boot logo with the two dots ? Got back into Recovery and just re-installed xXx 2.6 with the old setting (using the xXx Folder) and the phone booted up OK. I'll wait till the next build
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Try another backup and restore with K2 without including cache and recovery. This setup works wonderfully for me and I've done numerous successful restores.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
Do you tick everything except cache and recovery when you backup? Also I did not try to restore cache or recovery just system and system Image(like a Dirty restore I did not wipe anything ), I'm happy to try again with a new backup but the last one was made just before I went to sleep;)

So it was fresh. Im not syre if I'm doing something wrong when I'm installing but I dont think so.

Using TWRP I can flash 3.1.1.1 over K2 and vice versa in the recovery partition so obviously thats OK. And it will boot into TWRP do backups an behave.

Do you normally restore system image?

But restoring? AM I missing something here?.

---------- Post added at 08:17 AM ---------- Previous post was at 08:12 AM ----------

Jamie, do you have any screen lock at all?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I have learned the hard way that the best way to do a dirty flash is to first wipe everything except data. Then Flash the new ROM build and gapps. Then wipe Dalvik and cache again. Then reboot. Not wiping first is probably your issue.

Yes, I restore everything including the system image (minus recovery and cache).

I've done restores successfully on K2 with and without a screen lock.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
OK a bit different on Samsung(learning as I go along)Missed your last line deleted my question.

Progress I did a backup without cache and recovery, Then I just restored System By wiping first and Restore then wipe dalvik cahe reboot and it works. System Image does not show up in advanced wipe is that normal?

---------- Post added at 08:57 AM ---------- Previous post was at 08:26 AM ----------

Tried a full restore this way:

Wipe, all except storage and OTG.

Restore everyting and the restore starts . And I get this:

Restoring Boot

Boot done 0 second

Wiping System

Restoring System

System done

Restoring System image

System image Done

Wiping Data (excl. Storage)

Wiping data without wiping/data/media....

Done

Restoring Data (Excl. storage).........

extractTarFork() process ended with ERROR:255

Installing xXx again brings me to initial setup,select language etc.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I am glad to hear that you are finally able to restore properly. Yay!

You are correct that System Image does not show up in the Advanced Wipe menu as an option.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
See my next post full restore failed. Unfortunately they were doing major Roadwork outside and ripped power and internet cables. I still have not got my internet back. And they fried my graphics card on the pc. Anyhow I managed to see that the error has something to do with storage before all hell broke loose. Will ha e to wait for Internet to be restored to investigate. Any suggestion on the error would be great
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
See if any of this helps with Error 255.

https://android.stackexchange.com/questions/123540/nandroid-backup-restore-fails-with-error-255
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
You can try to SD card fix permissions zip. Also when restoring make sure to restore everything you backed up. In future no need to backup cache or recovery just select everything else. Then restore everything
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
Thank you both, I will try these things as soon as I get my internet back. It's still mayhem out on the road every cable and internet provider is out there trying to sort things out:silly:

By the way what is the point with Backing up system image if there is no option to restore it?

Wrong By me I just noticed that system image is there.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
I'm pretty sure I had that ticked in xXx install, anyway I reinstaled xXx and made sure it was ticked:o And then for added stupidity I downloaded the updated zip and ran that, It actually kept doing stuff for well over a minute. Just Ran a full backup without cache and recovery. Thing is I'm perfectly set up now with the working Google dialer (magisk)I actually used the zip.

I'm very reluctant to restore and having to rebuild allover again.....

Any clue when official will come around, I think I'll just wait and not restore unless I have to ;) then I'll give it a go with the official build.

Knowing myself I will probably try within the next 24 hours anyway...........

---------- Post added at 07:16 PM ---------- Previous post was at 07:06 PM ----------

I don't think system image is needed for backup and restore. I found this on Nexus thread:

"According to TWRP in regards to System Image: The Team Win Recovery Project has released version 2.8.7.0 of its custom recovery, known simply as TWRP. This update brings a system read-only option that's intended to help you make a pure backup of your system image that you can later flash to receive over-the-air updates after having rooted or ROMed your device.

If you move backups to your computer, you'll either need to move them back to the internal storage of your phone or USB stick to use USB OTG to restore backups. "
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] EdHicks:
Link please?

Thanks!

---------- Post added at 06:44 PM ---------- Previous post was at 06:41 PM ----------

I've always backed up everything and I haven't had any problems with this TWRP from the beginning aside from USB-OTG. I highly recommend it if you have the space to spare.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
No need you already have an install zip for the recovery obviously. And cache? Why you wipe it mostly just just waisting space . Been flashing smart phones since they became smart and it's never been required. But won't hurt just a waist of space
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
I had a problem before that substratum not detected any themes. I installed xXx 2.8 Yesterday and Ran the SD card fix. Checking today and be and behold Substratum is now showing both K-klock and Ozone. Is that because of the SD card fix? If It is then do you think that this was the same issue that caused my restores to Fail?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Here's something that may help someone. I've been using the K2 version of TWRP for some time now successfully. I was testing a ROM yesterday that I did not like and decided to switch back to a different ROM through wiping the device and restoring my nandroid backup. The restore seemed to go well but the device would not boot. It simply stayed on the OnePlus "powered by Android" screen. Multiple reboots made no difference. Dirty flashing the ROM after the restore is what fixed the problem and the ROM booted successfully with all of my data and settings in place. Thanks again [MENTION=3814731]katinatez[/MENTION] for helping to make TWRP work as it should! :victory:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] 3DSammy:
With [MENTION=3814731]katinatez[/MENTION] version of TWRP seemingly working for all the various installs (encrypted and decrypted, stock and custom ... etc) plus USB-OTG access and the all important /data restore is there any plan to make this thread "Official" plus remove the caution about restoring data in the thread's heading? The TWRP thread named as "OFFICIAL" has almost no activity and still has issues that this version has resolved. For new users having two TWRP versions just adds unnecessary confusion.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
I know I've been quiet lately but that's because I have been working to speed up back ups like I had set out to do. Here are some results to show you what I have done. Next release, Still tweaking to improve speed.

Credit to [MENTION=7296006]Kutep0v[/MENTION] for pointers from this thread

https://xdaforums.com/oneplus-one/development/recovery-twrp-3-0-3-k1-t3563692

Changelog

Speed up backups

Updated kernel 4.4.74

Exfat kernel support Why? Because I have exfat USB

NTFS r/w support Why? Because I have them too

F2FS support Why? Easier to format data/cache to switch back to oos

Edit 1: First picture of last k2 release, second picture is new test build.

first one no compression second one does, I will make better test with same settings for better comparison.

Edit 2: This is not my thread to decide to change links or title of thread, this is my personal twrp build with the extras I need. Just sharing to other users. I know there are other twrp builds available, If you don't use mine it won't hurt my feelings.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tinuz97:
Great, I did get like 7/12Mb/s also. Test version almost double the speed with OTG . Nice :highfive:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
All and every TWRP version when I do a restore I end up with this Error. Please see screenshot. xXx ROM sd card fix installed I have absolutely no clue how to fix this.

AS soon as I try to restore data it fails, tried at least umpteen backups and restores;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Good to hear. I'm still using -k2. Am I missing something obvious here like a link to your latest (quicker OTG) version? Appreciate the work!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Could be many reasons but we can't help you figure this out with out kernel & recovery logs. Have you tried deleting that backup & backing up a new one & trying to restore that new one?

One reason that happens is because you have a corrupt backup file and the recovery log would point this out.

I just mentioned the future changelog in earlier post, you will find it in my signature AFH, Oneplus 5,Recovery folder. I will make an announcement later tonight

Have to clean up my github and push all my commits, and will release late tonight!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
I'm looking forward to that announcement. :highfive:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kimyeungg:
i would say you and [MENTION=6584600]xdvs23[/MENTION] are the only guys who deserved my support in contributing to an "unofficial" but better TWRP for us not like others ^^

((though my support is useless lol :good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] sjamie:
Hey, did I miss the announcement? :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Not yet, my kids are still awake
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Bad,bad,bad. Late night morning look a fright. Lol
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
Sjamie, I ended up completely wiping the phone starting from scratch. Installed K2 and FINALLY Backup and Restore works Thank you for engaging in my problem.

Now I will have to add custom ROM xXx but hey I have a base backup on the phone that I can restore:D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
Ok, kids are in bed :D

op5-twrp-k3.img

Changelog:

Speed up backups over USB-OTG & Internal

Updated kernel 4.4.74

Exfat kernel support

NTFS r/w support

F2FS support

https://github.com/katinatez/android_device_oneplus_cheeseburger/commits/android-7.1

My baseline for comparison is my previous build k2 had 7-12 mb/second usb-otg

New build k3 is coming at 11-21 mb/second usb-otg

Remember to set your settings to compression for similar speeds.

Good Night Enjoy, have to wake up in like 5 hours
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
You mentioned easier to go back to stock with data and caches formatted f2fs. Can you elaborate on that some. Do you recommend having them formatted all the time to f2fs?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
I'm still on vacation, gonna be back very soon.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] thaidroid:
[MENTION=3814731]katinatez[/MENTION] Thank you For this build.:good::good::good:

Having finally overcome my issue with ectract fork error 255 on restore(by doing a clean install of base ROM and restart from there) I have found the Following:

K3 cannot Restore backups done in K2, gets stuck in oneplus5 Logo on re-boot.(not expected but I tested anyway)

K3 backs up and restores like a dream to internal SD card.

Backed up stock and xXx roms and restored them over each other back and forth NO PROBLEMS whatsoever.

I'm curious about system image and modem(in fact TWRP does not tick them by default when you select backup) never backed up modem on Samsung , no need. Mind you it's not that big so it really makes no difference. System image on the other hand is Huge and I read somewhere that you could put it on the PC and do a sideload with it. Also since TWRP does not select it by default is it really necessary to back it up?

Thanks again for a nice working solution(and yes I turned on compression and is saves you a couple of Gigabyte and gives you a nice warm phone;)).

BTW Post this TWRP in a separate Thread call it "WORKING TWRP" because it is..........
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kimyeungg:
Hi katinatez,

the older version - k2 provides me better speed during backup (internal storage)

(k2: file systems: 68 MB/sec & imaged drives: -20 MB/sec)

(k3: file systems: 40 MB/sec & imaged drives: -15 MB/sec)

may i ask why "imaged drives" is showing as "minus" ?

screenshots can check it here.

http://imgur.com/a/yYJHW