yashsingh1/xdaforums huggingface dataset:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Funk Wizard:
Indeed, appreciate the hard work and countless hours put in development [MENTION=6584600]xdvs23[/MENTION] well done buddy.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
After the developer of TWRP [MENTION=912474]Dees_Troy[/MENTION] has made another TWRP, I'll see how his work is going. If we team up or he manages to get his TWRP up to the level of mine, then I guess it'll be pointless keeping this thread here alive.

As far as I have read, the problems on his TWRP have been already partially addressed in this one:

- Restoring data which causes the system to reboot into recovery and wipe data

While restoring data still causes the reboot into recovery, the latest TWRP version on this thread prevents the data wipe.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Rebel7022:
I had same problem just now fixed it with this tool, I had it format data https://xdaforums.com/oneplus-5/development/tool-tool-one-driversunlocktwrpfactory-t3626191
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] utkarsh_86:
Thank you to all you kind people for your help.. I had a S7, rooting was much easier on it, i guess because of the Exynos but its been a learning experience.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] oF2pks:
Why don't you move to twrpMR:

https://github.com/multirom-dev/Team-Win-Recovery-Project

(Maybe these guys up there, are looking for others active devs.)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a g bell:
Don't sees no difference in the official twrp still can't restore a backup without nuclear war breaking loose?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Yeah unless theirs is better than mine or as good as mine I won't give this one up.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] pchtc:
Thanks

keep up the great work

I wonder why the official release

which is now listed on the TWRP webpage

still does not list that it cannot restore data

do they not know about this?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Matze060906:
Has anyone tried to restore data from tipsy OS? I'm pretty sure I read something about that this problem is caused bei oos...

Gesendet von meinem ONEPLUS A5000 mit Tapatalk
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
I think that's the case. Maybe they just did that to compete against this one. Not claiming anything tho.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] pchtc:
what a shame, i saw you reached out to the developer [MENTION=912474]Dees_Troy[/MENTION]

but he has yet to respond to you

more gets done when people work together

i see you are willing to collaborate and looks like he is not

plus his has issues that your does not, like not compatible with screen lock

ill stick with your version
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Thank you.

The only issue really is that data restore thing which I dont know how to fix in TWRP, but maybe we can fix this in custom roms and even provide a patch for OOS so that it wont happen. Let's see.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] braschlosan:
To say I received a notification for an update to the OS. I clicked the update button on and it downloaded the update and then rebooted into recovery for some reason. I booted back into the OS and received an error that the update had failed. Is there something I should do to allow the update to work properly?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] blackst225:
You have to download the full zip from the oneplus page.

You can't flash the ota over TWRP.

You can only flash full rom zips over custom recovery.

If you want to flash otas, switch to stock recovery
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] pchtc:
you also have to flash root after the zip before booting system if you dont want to loose twrp recovery
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
You shouldn't flash partial OTAs if you rooted, installed magisk or flashed anything. As far as I know, if you rooted, the OTA updater automatically detects it and downloads the full zip.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] tang2157:
I won't pay your RMA？？RMA for RMB ？ Are you Chinese ？
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
RMA is how the service is called by OnePlus for repairing/replacing your device.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kimyeungg:
maybe he is just "busy" and not online for these two days.

love your work and im still using it instead of that "official" one :good:
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Yeah maybe.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] a g bell:
Or maybe not https://github.com/TeamWin/android_...mmit/55828ce985605398f3efb0fcd0f1366d579d8def ??
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Mounty_078:
In got it installed but when I go into the recovery, it asks for a password, then I cancel and slide for modifications. But my storage is completely encrypted, so I can't install anything. Anyone know what to do?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Nomelas:
Yeah, put in your password for your phone. You can also boot into your phone and remove the screen lock, then it won't ask anymore :)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] jdubya45:
Ok so what is the difference between this one and the official TWRP really and why should I not just keep this one installed over the other?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] kimyeungg:
everything is working except "restoring data"

for the official one, some features like "otg" aren't working.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] jdubya45:
I see BUT restoring data on the official is working right? I don't need OTG.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] meiax93:
I flash TWRP on official website.

When reboot, it require password, so i insert my passcode.

Then i reboot, remove my passcode and can access no problem

TWRP 3.1.1-1 on OnePlus 5 128GB
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] brmbjn:
If you use password for lockscreen. Twrp password ???
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] inffy:
It should be the as your lockscreen password or pin
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] brmbjn:
Can i bypass password on twrp only ?

---------- Post added at 01:54 PM ---------- Previous post was at 01:52 PM ----------

Can i bypass password on twrp only ? Please
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] fjsferreira:
I think so, you click cancel, but the internal storage stays encrypted, so you'll have no access to it.

Sent from my OnePlus 5
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] inffy:
WEll you can skip it with cancel but that means you don't have access to your partition at that point. The password is needed to decrypt the data to be used in TWRP
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
TWRP password is default password. Two words "default _ password"
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Dns94:
Did you ever get a response or figure it out? Was wondering the same, always use TWRP to take backups.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
For making backups I would recommend trying the adb backup feature which will backup all your apps and data (but not system settings etc.) or use TiBu.

adb backup -f backup.ab -apk -all -obb

If you want to backup you internal storage as well, append

-shared

to the command above.

For backing up system apps (not entirely sure how this works, will probably just backup system apps data), append

-system

To restore:

adb restore backup.ab
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] NightMean:
Well there is github for official twrp so why don't you make pull request with fixes that you have ?

Edit:I see that you already done that
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] néonaloj:
Thanks for the tip!! So I did backup my phone with that adb command, but I can't find the backup folder in my adb folder on my pc, nor everywhere else... Where is it please? Thanks!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
It creates a file backup.ab in the folder you executed adb from.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
I did pretty much the same command right after I got the phone to get a basic data backup: By default it shows up in your working directory ($pwd) wherever you ran the command from (as follows in my directory listing):
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] néonaloj:
Thanks a lot, I found it! ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Before using that backup method make sure to have backups of important data as you never know what can happen.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] fjsferreira:
Restoring data of decrypted OOS backups is known to work, right? Because I did just that a few mins ago and had no problem.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Giansi:
Well for me it worked once and and second time didn't.

I am decrypted.

First time I backup XXX OOS based rom and restored it correctly.

Second time I backup XXX again, flashed Mokee rom to try it, then decided to restore XXX and I got a fork error.

I had to wipe and flash a new installation of XXX and then setup everything...

I'm scared of doing it again cause it takes time to setup again in case restore goes wrong...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
I would say encrypted restore is 99% not going to have a good result and decrypted restore is 50% going to have a good result. It depends on various factors, like the exact order of actions, the exact things you flashed, and also what you ever flashed before as well as what you are using etc. etc.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] J03llV:
I have not, what I do is just backup with Titanium Backup.. I have photos and stuff backed to my pc. The only thing that works for me atm.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
New test image (v73)

Changelog:

Rebase kernel

Sync omni sources
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Tendor83:
Flashed without any problems.

I wanted to try the latest test version, because with the last stable release wasn't able to start a nandroid backup. The error was something like "... was not able to create [a particular folder path]"

With the latest test ver, I was able do successfully backup my phone.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Keep in mind that restoring a data backup in encrypted state will lead to problems. But good to know that it is working so far.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Interceptor777:
So is the restore problem specific to OOS only? I only run RR decrypted and TitaniumBackup is way slower than a good TWRP backup.

Anyone here running AOSP ROM use data restore and have it work?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hibby50:
Hey [MENTION=6584600]xdvs23[/MENTION] thanks for all the work you've done bringing up TWRP for our device. Quick question: is the need to decrypt to install AOSP ROMs a TWRP issue or a ROM/Kernel issue?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Rather ROM issue, but I'm pretty sure we'll be able to find all of this out and fix it.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
[MENTION=3814731]katinatez[/MENTION] just found out OnePlus uses the default dev verity key, that basically means we have full control over it xD

[IMG="Recovery"]http://xdevs23.me/upload/img/Selection_374.png[/IMG]

[IMG="Boot"]http://xdevs23.me/upload/img/Selection_376.png[/IMG]

[IMG="verity.mk"]http://xdevs23.me/upload/img/Selection_375.png[/IMG]

https://github.com/halogenOS/android_build/blob/XOS-7.1/target/product/verity.mk#L26-L29

https://github.com/xdevs23/android_...wrp/blob/android-7.1/recovery/root/verity_key

Verity key from boot image (OOS 4.5.3): https://drive.google.com/open?id=0B0RUo8rOkvfNWGpfajVtdDJfZnM

EDIT:

here is the default verity_key: https://github.com/halogenOS/android_build/blob/XOS-7.1/target/product/security/verity_key
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Do we need this to flash?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
No, that's just for developers because of the data restore bug
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] shadowstep:
MultiROM for the OnePlus 5!

I'll just leave it here. ;)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Have seen that yesterday, made XOS compatible already :D
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Eric214:
So data restore is still a no go on 3.1.1-1? I only see 3.1.1 being discussed.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Alessandro999:
there is no f2fs option in recovery

any fix???
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
No issues restoring decrypted backup with data here just make sure you choose both system partitions when backing up
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Eric214:
Making sure I follow you. I'm still encrypted. Are you taking about when I enter TWRP and use my pattern to enter and it decrypts? And then make a backup with 2 system partitions? You mean system and system image?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] néonaloj:
Sorry but wich rom is XOS?? XXX no limits??? Or? Thanks!

Yes, you need to backup and restore system AND system image! It was said earlier in this thread I think...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] zellleonhart:
-deleted-

wrong thread
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
halogenOS

Is in testing phase
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Talking about if you formatted data to decrypt. And yes you need to back up and restore both system partitions
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
I'm getting message on 3.1.1.1 that system can't be mounted and that structure needs cleaning. Keep getting that error message when trying to flash magisk on a clean flash of stock rom and or wiping system
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Also getting the no os installed.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
The no os installed message is on 3.1.1.0. don't get that on newer version but the unable to mount system and structure needs cleaning message are on both versions
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gershee:
in regards to having to be decrypted to install aosp roms...

in the roms thread it is commonly being said this is due to recovery..

and here it is being said it is due to the roms..

I'm just confused..

thanks for the hard work! cheers.. ?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mukesh22584:
In TWRP select

Wipe>System>Change file system>EXT4>swipe to change..

In Fastboot..

fastboot format system

:o
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] inffy:
And how is that related to encryption and the problem that aosp roms dont work with encrypted devices (at the moment)
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gershee:
::confused::
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Nobody is sure
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] mukesh22584:
I've quoted just wrong post...I wanted to answer for post #888 where system was not mounted..

Sorry folks....[emoji120]
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
This is by far the best answer I have come to, found this in oneplus 3 thread

https://xdaforums.com/oneplus-3t/how-to/guide-custom-kernels-roms-recoveries-t3572525

and here

https://www.xda-developers.com/a-look-at-marshmallow-root-verity-complications/

and last one credits the dev that came out with the no-verity-opt-encrypt-5.1.zip that all the Oneplus 5 owners are flashing.

https://xdaforums.com/showpost.php?p=70995373&postcount=152

Dont flash anything from these links! Its just to inform of the verity-check
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
Can't the format data be done in twrp as well? Idid both prior when decrypting. I also changed file system to ext4 even thou it was already ext4. Idid a full wipe and installed a lineage Rom and issue seems to be gone in twrp now hopeful it don't ret um
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hsareminia:
Hi

I do decrypt and change data to f2fs. All things work but boot logo was long time.

Then I do format system and change data to ext4 again.

Stock rom booting and worked but any rom is boot loop.

Please help me.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Alessandro999:
sorry for that but i need f2fs recovery because it improve performance in loading speed by 2x sometimes... there is no option in recovery!!!!!!

please anyone add it

watch one plus 3 ext4 vs f2fs and see the big difference when load asphalt 8!!!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] inffy:
F2fs also has problems in the longer use as it has bugs (unless they have already been fixed). That is the reason that oo5 doesn't use f2fs
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Pho3nX:
No never increase by 2 the speed, sorry but it's not true. The best gain that you can have between ext4 & f2fs is max ~15% in reading and on writing ext4 is more fast
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Hastaloego:
has anyone managed to restore the /data partition yet ? i either get it wiped or end back in recovery
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Funk Wizard:
The thread title says it all !!
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Hastaloego:
yeah but the op begs to differ :) thats why the test versions
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] gershee:
lmfao
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Testerofroms:
I don't get a backup without getting a bootloop.

No password set, no data partition encryption ...

Cache and Dalvik cleaned...

Just making a backup and reboot -

0-1 Seconds after SIM PIN request showing up - Booting again.

Tried with

twrp-3.1.1-cheeseburger-73-20170716-125431-CEST.img

from this thread..

twrp-3.1.1-1-cheeseburger.img from TWRP

I tried to make the script of 3T to wipe the misc but, it seems that this script/command is not implemented yet..

adb shell wipe_misc

Add: seemed to be a generic issue at my device, making now a full update, since it happened w/o making a backup also...
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
I have no issues backing up or restoring data. I'm not encrypted
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] Funk Wizard:
I am encrypted and I use official for now so no issues for me either except the OTG everything else works. I have 128 gig version so storage is not an issue for me and just in case of an emergency MTP always works for me or I can always use adb push
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] str8str:
I see multiple people posting issues but not one log to go with them

Nothing can be looked into or fixed without them so you might as well tell the wind
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] daleski75:
I know we cannot restore the data partition on an encrypted partition but here is the recovery.log if it helps?

https://hastebin.com/aginopusap.sql

Tried the test version here rather than the official version and getting a lot further now.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
New test image (v83)

Changelog:

Sync omni sources

Update kernel (rebase) & use linaro 6.3.1 for that (otherwise compilation won't work)

Import and patch OOS 4.5.6 crypto blobs

Use inbuilt libs only

I said I would do a hybrid way of using the libs, that is prioritizing system libs and using inbuilt as fallback but I realized it doesn't make much sense doing that so I just decided to use the inbuilt libs only.

Please test data backup & restore

WITH ENCRYPTION (that means you need to be asked for a password/pin/gesture on TWRP start)

on this test image! Note that I don't know whether the issue is fixed so that's why you should test it but do not involve your important data in this, make separate backups in other ways first!

I updated the git repository accordingly, so view it here for further information.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] katinatez:
oink, oink

I'll be your first guinea pig tester

I was on mokee 7-29-17 build and restored from one of my backups created by my recovery.

And sucessfully restored back to xXx No limits 4.5.6. oos

I just fastboot boot recovery.img for testing puposes, but will now install

"No OS installed! Are you sure you wish to reboot?"

Is no longer there!

Still there

We have a winner here

Have not tested otg because of usb cable and besides I know it's fixed, running a theme and looks good!!!

Round of applause for [MENTION=6584600]xdvs23[/MENTION]

Edit: still encrypted

Second Edit:

Seems to backup and restore, and boot faster than my build

Did you use this flag?

TW_UNMOUNT_FIRMWARE_ON_BOOT := true

I don't see firmware in the mounts tab.

And otg is confirmed working

confirmed working to restore from previous backups made on my recovery on your recovery
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Hmm it's already late, it's hard for me to decode what you wrote there, sorry :D :D :laugh:

Did it really work? Encrypted data restore without bootloop?
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
Great to hear that! [MENTION=6584600]xdvs23[/MENTION] & [MENTION=3814731]katinatez[/MENTION] : Good going.

I'll give it a try right before I do the next OS update (later today I think). Cheers.

Note: By the way: Was that restore to an encrypted FS? I just re-read and wanted to be sure that had worked OK. Thanks.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
Nope, I even checked again, that flag is not set in the device tree.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
I just flashed #83 and booted into it. It took quite awhile (~20-25 seconds) to get to the TWRP screen, where it did as it should and asked me for my pin/pwd:

After I entered it: I got about 3/4 of a page full of /data/data errors. *I should have the logs saved since I told it to save them so I'll attach them if I can*. Once I saw that, I didn't quite trust it. For the first time in literally years, I used Flashify to flash recovery, and maybe it's no longer valid in Nougat so I'll try again with fastboot flash * * and see how it goes.

The stuff that showed up in red onscreen after I entered the PIN was the mangled /data/data names you see in the log. The entire log is pretty big to quote here but if you want it attached, let me know. That is from the beginning down about a page or two.

Stuff to know: My OP5 is currently running what is basically the latest OOS, but in the form of xXx nolimits ROM and is encrypted. Hope that's of some use. I'll also try this again doing a normal fastboot flash of TWRP 83.

Thanks.

Edit: I retried after flashing #83 TWRP "fastboot flash recovery 83twrp.img" but there was no change in the outcome. I'm still encouraged by katinatez's outcome ^^. Hopefully when you look at the log, you can tell me what silly thing I did wrong. Entering sensitive stuff like the PIN from that TWRP KBD always strikes me as an iffy proposition but if I got something wrong twice, these are the first two times I've done that.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] xdvs23:
According to your log decryption is working as intended, however, there seems to be something messed up in your data as the log does not say anything about failed decryption.
[OnePlus 5 ROMs, Kernels, Recoveries, & Other Devel] hachamacha:
OK. Thanks for checking it out.

I think it's interesting that it showed up onscreen. Is that some sort of buffer overflow or by intent? The official TWRP just quickly takes the pin and goes to the function screen. Btw: OTG worked fine. What sort of thing would you suspect as being messed up in my data could do that?