yashsingh1/xdaforums huggingface dataset:
[Magisk] SacredDeviL666:
Thread Cleaned.

Lets all get back on topic shall we?

a) No discussion related to SN fails or passes unless you can suggest ways to improve/fix it by actual steps and not lets try methods

b) Banking apps doesn't work take that discussion to general thread of magisk including tez, pokemon has their own thread

c) Hey i have a weird bug (Unfortunately its not a bug unless you have it documented properly and can share it along with logs)

d) How to get a log ( Please search the infinite posts on this topic available across almost all threads in XDA)

e) Something which isn't specifically related to this Beta version shouldn't be posted here and if you are posting please follow the above before posting.

Always take a good read at OP before posting further :- https://xdaforums.com/showpost.php?p=72588015&postcount=1

Magisk Release Thread :- https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445

Basic troubleshooting/tips/tricks :- https://xdaforums.com/apps/magisk/guide-magisk-troubleshooting-t3641417

Magisk general thread for any other discussions related to Magisk :- https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/page2505

Search before posting :- https://xdaforums.com/search.php?do=process

Magisk Thread list :- https://xdaforums.com/apps/magisk

Thanks

SacredDeviL666

Forum Moderator.
[Magisk] exocetdj:
Lost my rc because of this kind of rubbish (and my temper lol)

Well said :laugh: shame some of these ???☕ s dont read
[Magisk] Trinath5804:
pls help with installation of magisk 16.0 or 16.4beta

hello i am using vivo v3 phone with android 5.1.1 when i try to flash magisk 16.0 or even beta 16.4 it ends with an error i am uploading the recovery log also i have unlocked the bootloader and rooted using king root and changed it to supersu

and then did full uninstall even then its not working

i am not able to flash patched boot image using adb

pls help me

here is the recovery log of twrp

i removed some text that was not part of the installation
[Magisk] BertlBrown:
I can provoke this by simply putting Chrome on the magisk hide list and starting it. Afterwards Magisk is lost. Removing Chrome from the hide list, you can use it without loosing Magik.

This is not a question of time, it is a question of time but one of what you're doing.

Remember: You have to reboot to gain Magisk again.

RemembeR: You have to remove Magisk Magisk Manager from the list of open windows to get a reliable check if Magisk is still there. If it keeps in the backround it will not check when opened.

Device: P20,EML-L29 8.1.0.120(C432), original Ramdisk patched with Magisk Manager
[Magisk] RASTAVIPER:
Hmm that's strange.

Updated my OP3T to OOS 5.0.3, had then a factory reset, installed Magisk 16.4, but no modules can be installed.

Tried with Appsystemizer and Doze and I receive failed messages and that I need to install an older version of Magisk.

- Copying zip to temp directory - Installing Enable_Doze_for_GMS_Magisk_Module-v6.zip ******************************* Please install Magisk v15.0+! ******************************* Failed! ! Installation failed

Unleashed by my rooted OP3T on 8.0
[Magisk] whiteak:
You need to tell Magisk where your boot.img is, you have to find what block your boot.img is first, once you have this, Extract the Magisk 16.4.zip, go to common, you then need to edit the util_functions.sh file with an editor program like Notepad ++. You need to change 2 lines in find_boot_image, lines 109 and 115.

In my case for my TCL TV, the boot.img is block mmcblk0p5 so that's what I changed it to.

eg: Change: BOOTIMAGE=`find /dev/block -iname boot$SLOT | head -n 1` 2>/dev/null

to: BOOTIMAGE=`find /dev/block/mmcblk0p5 | head -n 1` 2>/dev/null

Do this to both lines 109 and 115, save and rezip and flash the new zip through modules in Magisk and reboot, should be good to install modules again.
[Magisk] RASTAVIPER:
But why is this happening now and not before?

Unleashed by my rooted OP3T on 8.0
[Magisk] whiteak:
It seems Magisk can no longer find your boot.img, all I can tell you is I had the exact same error you describe with saying install Magisk 15.0 etc, try what I've said and hopefully it fixes it. You can try and get your boot block number by using: cat /cache/recovery/last_log

in root with Terminal Emulator or adb shell root access, and look for the boot block.
[Magisk] Didgeridoohan:
[MENTION=8898246]whiteak[/MENTION] [MENTION=4043335]RASTAVIPER[/MENTION]

It's not a case of Magisk not finding the boot image. If that was the case, you wouldn't be able to install Magisk at all. The module installer simply can't find the necessary Magisk files for installation. Why? Don't know... Faulty installtion of some sorts...

[MENTION=4043335]RASTAVIPER[/MENTION] try to simply reinstall Magisk. Make sure to save all the logs, so you can provide them if you keep having issues.
[Magisk] whiteak:
I can assure you in my case that was exactly the error, it even said can not find boot.img, anyway, I don't want to clog up this thread any longer. I managed to get it fixed on my end, so all is good.
[Magisk] Didgeridoohan:
In that case I suspect you guys are talking about different things. You were trying to install Magisk, right? [MENTION=4043335]RASTAVIPER[/MENTION] has already installed Magisk and is trying to install a module.
[Magisk] whiteak:
No, exact same thing as Rastaviper, Magisk was already installed just modules wouldn't install. I have a TCL Smart TV that has no custom recovery, so to get root, I patched the boot.img, flashed through fastboot, then I installed Magisk Manager, everything works except the modules, eg Apps/adb etc have root access, just Magisk would not install modules, and if you tried to reinstall Magisk, that is when it would tell you that it could not find the boot.img. There is no by-name on this TCL TV, hence why I had to change the 2 lines to actually tell Magisk where my boot.img was, reinstall my modified Magisk and bingo, it finds the boot.img, reinstalls and everything works as it should, module installation etc.

If Rastaviper has twrp, a reinstallation of Magisk may fix his issue, but as I have no custom recovery I had to find another way.
[Magisk] Didgeridoohan:
Exactly what I said... You were trying to install Magisk when you got that message. Trust me, this is not the issue that [MENTION=4043335]RASTAVIPER[/MENTION] is experiencing. They're not using an Android TV that need special installation instructions. It's a OnePlus 3T, a device that I happen to use myself (with pretty much the same setup) and there are absolutely no issues with the boot image when installing Magisk...

The only reason I even answered is that if the issue [MENTION=4043335]RASTAVIPER[/MENTION] is seeing is any kind of bug with the current Magisk beta, it'd be good to get some logs for that. Your advice, even though it's well meant, unfortunately likely isn't correct in this specific instance.
[Magisk] RASTAVIPER:
Tried to upload a log through tapatalk, but it doesn't allow me.

Unleashed by my rooted OP3T on 8.0
[Magisk] DB126:
Put it on a file share somewhere and post the link. Logs are essential to diag your issue.
[Magisk] jellybean13:
Magisk keeps stopping (in "Magisk" tab).

Logcat:

--------- beginning of crash

06-04 23:08:05.046 16274 16480 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #6

06-04 23:08:05.046 16274 16480 E AndroidRuntime: Process: com.topjohnwu.magisk, PID: 16274

06-04 23:08:05.046 16274 16480 E AndroidRuntime: java.util.ConcurrentModificationException

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at java.util.LinkedList$LinkIterator.next(LinkedList.java:124)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at java.util.LinkedList.removeOneOccurrence(LinkedList.java:835)06-04 23:08:05.046 16274 16480 E AndroidRuntime: at java.util.LinkedList.removeFirstOccurrenceImpl(LinkedList.java:830)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at java.util.LinkedList.remove(LinkedList.java:665)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos.lambda$loadJSON$1$UpdateRepos(Unknown Source)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos$$Lambda$1.run(Unknown Source)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos.lambda$queueTask$0$UpdateRepos(Unknown Source)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos$$Lambda$0.run(Unknown Source)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)

06-04 23:08:05.046 16274 16480 E AndroidRuntime: at java.lang.Thread.run(Thread.java:818)
[Magisk] Paulushi:
I'm trying to install magisk on lineage 15.1, on my mido/Redmi Note 4 Global. It says it can't mount /vendor, but when I look at the logs it says that it can't actually find it in /etc/fstab, when I check with the ADB shell /vendor is already mounted and I can read files in there.

Problem occurs for Magisk 16.0 (not beta) and magisk 16.42 (beta). Haven't tried older versions.

Recovery.log: pastebin com/0TzKUYwb
[Magisk] gtnftw:
Couldn't install the new beta. I'm using a Google Pixel on 8.1.0. Log file below.

- Device platform: arm64-v8a
- Extracting files
- Unpacking boot image
MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool
Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]
No boot image magic found!
! Unable to unpack boot image
Failed!
! Installation failed
[Magisk] Ricky Divjakovski:
Has nothing to do with faulty installation, i have no idea whats going on but i replaced his method of detecting the kernel block with mine and it worked

All in all, this is definately a bug that somehow has nothing to do with the modules.
[Magisk] Didgeridoohan:
Could we have some details around this? Device details? Magisk installation log, magisk_debug.log, etc...
[Magisk] Ricky Divjakovski:
When i build a custom recovery for his device(now that we havr kernel source) ill get him to flash stock and do all via recovery ans we will upload the logs

topjohnnywu can PM me or download my PoisonKitchen IDE for the code used for automatic kernel block detection
[Magisk] Didgeridoohan:
Are you talking about [MENTION=8898246]whiteak[/MENTION]'s TV or [MENTION=4043335]RASTAVIPER[/MENTION]'s Oneplus 3T? Because the post your quoted was about trying to troubleshoot the OP3T... The advice given was pertinent to another device (the TV), hence I posted my advice about reinstalling Magisk, on the OP3T.

The TV thing is definitely a possible future improvement, but I don't see how it has anything to do with the issue that was being discussed (about the OP3T)...

Apples and pears come to mind. :laugh:
[Magisk] Ricky Divjakovski:
I was talking about the TV however its the same issue and has nothing to do with the modules..

Apples dont fall too far from the tree
[Magisk] Didgeridoohan:
I would very much like to see some logs and details about this issue on the Oneplus 3T, or a way to reproduce, because I use that device myself, run quite a lot of Magisk test-builds on it and haven't seen anything like it on any build for quite some time (as in: can't remember if it ever happened)...
[Magisk] Ricky Divjakovski:
We shall be back with logs :)
[Magisk] pipomolo42:
Hi,

On Oneplus 5T, magisk 16.0 and 16.4 both fail to patch the boot image of the latest lineageos weekly release (2018-05-28), whereas it worked on the previous build (2018-05-21).

Edit: I forgot to mention : while the installation seem to work fine (no error message in twrp), after an installation attempt, the device won't boot anymore (no bootanim visible, reboots to bootloader).

Full builds are available at https://download.lineageos.org/dumpling

I've uploaded both unpatched boot.img files and related recovery logs at https://boeglin.org/~alex/magisk/

A quick look at the diff shows 2 interesting lines:

Patch @ 01BD3CB0 [736B69705F696E697472616D6673]->[77616E745F696E697472616D6673]

Is present in 2018-05-21, but missing from 2018-05-28 (skip_initramfs was not replaced by want_initramfs)

-DTB [2843705]
+DTB [15963611]

Extracted devicetree size goes from 2.8MB to almost 16MB, which looks a bit wierd…

I also rebuilt magisk from github's master, same result

I'm available for more tests, if required :)

Edit2 : I looked a bit more, the explanation seems that the DTB_MAGIC is present in the kernel image, and magiskboot's parse_img function stops at the first occurence.
[Magisk] Spawn_Ishan:
Hi, I am running oxygen OS 5.1.2 on the oneplus 5. Installing magisk causes a bootloop, there is no error message in twrp while installation but the device goes into a bootloop. If i restore the stock boot image it boots properly. I uninstalled magisk and then tried installing magisk version 15.4, 16 and lastly 16.4 but am getting the same issue in all of them. I am also uploading the recovery log. Please Help.
[Magisk] pipomolo42:
I checked the latest build (2018-06-95), the issue is not present. Still, the problem could randomly appear on any platform with dtb appended to kernel image : the compressed kernel image containing "by chance" the 0xd00dfeed string.

I've created a pull request that mitigates the issue by checking that the dtb header is correct:

- dtb size within kernel image size

- dtb structure offset within kernel image size

- first entry of dtb structure is indeed FDT_BEGIN_NODE

https://github.com/topjohnwu/Magisk/pull/389

This should greatly reduce the risk of this issue to reoccur.
[Magisk] BORETS24:
Device: Asus Zenfone 2 ZE551ML, OS: 6.0.1, ROM: BORETS ROM, 16.4 worked fine but in one moment after reboot root dissapear, Magisk Manager stop working, stuck on APP splashscreen. Reinstall, deinstallator did not help. I tried all version from 16.4 to 15.0- did not help also. My research show that dissapear /data/adb/magisk.db and never appear anymore. adb logcat show that

06-06 13:36:24.190 221 11324 E Magisk : sqlite3 open failure: unable to open database file

06-06 13:36:24.190 221 11324 E Magisk : su: cannot find requester

06-06 13:36:24.190 11325 11325 W Magisk : su: request rejected (10022->0)

My fresh research show that wipe data only partition fixed this bug, magisk.db appear, Magisk Manager work but i do not want to lose user data. How to fix without wipe,what reason?
[Magisk] Mistar Muffin:
I use Samsung Pay on a Gear S3 via an Essential PH-1 with Magisk 16.4. As of the latest Samsung Pay for Gear it is again detecting Magisk. logcat shows an entry from Pay called "AppShield" and it says policy=1 reason=MAGISK. I have hidden everything Samsung related in Magisk hide and also hidden the Magisk Manager package. Rolling back to the April 2018 APK of Pay fixes the issue. Definitely just them cat and mousing with us but I waned to bring it to topjohnwu's attention in case there is anything that can be done. Here is some more chatter about it:

https://xdaforums.com/apps/magisk/samsung-pay-magisk-t3659745/page12
[Magisk] cd993:
Keep losing root and/or Magisk crashes on me.

Pixel 2 XL user here running latest NitrogenOS rom with v16.4

Tried v16 up to v16.3 and I still experience this every other day. Sometimes a reboot fixes it but more often than not I reflash in TWRP to get root back.

Any suggestions and can I provide any more details?
[Magisk] Didgeridoohan:
Disable MagiskHide and the issue might go away.

Not really. Wait for a possible fix.
[Magisk] cd993:
Thanks, have disabled that now and will hope it improves/a fix is found soon.
[Magisk] farmer's breakfast:
Is there a way to execute async privileged commands via "adb shell su -c" ?

The problem is that commands after "&" lose root.

Example:

# adb shell su -c "whoami"
root
# adb shell su -c "sleep 1 & whoami"
shell

From magisk_debug.log:

06-08 19:33:28.559 3280 10415 D Magisk : su: request from client: 20
06-08 19:33:28.559 3280 10415 D Magisk : su: request from uid=[2000] (#1)
06-08 19:33:28.563 3280 10415 D Magisk : su_db: query policy=[2]
06-08 19:33:28.565 3280 10415 D Magisk : su: waiting child: [10416]
06-08 19:33:28.566 10416 10416 D Magisk : su: child process started
06-08 19:33:28.567 10416 10416 D Magisk : su: argc=[4]
06-08 19:33:28.567 10416 10416 D Magisk : su: argv[0]=[su]
06-08 19:33:28.567 10416 10416 D Magisk : su: argv[1]=[-c]
06-08 19:33:28.567 10416 10416 D Magisk : su: argv[2]=[sleep]
06-08 19:33:28.567 10416 10416 D Magisk : su: argv[3]=[1]
06-08 19:33:28.567 10416 10416 D Magisk : su: pts_slave=[]
06-08 19:33:28.568 10416 10416 D Magisk : su: use namespace of pid=[10413]
06-08 19:33:29.598 3280 10415 D Magisk : su: return code: [0]

EDIT:

I got it. Just need to escape ampersand like "\&".

# adb shell su -c "sleep 1 \& whoami"
root
[Magisk] dizM0nkey:
Can't install new modules & can't uninstall Magisk

I'm on a Oneplus 6 using official TWRP and rooted using Magisk 16.x

I can't seem to install any new modules... the module says it installs correctly, but after rebooting, is not present in Modules or Downloads (as an installed module). I've tried installing Magisk 16 and 16.4 but both don't seem to allow me to install any new modules. Occasionally, after an attempt, I will see it after rebooting, but subsequent reboots and the module is gone. I have no idea why this is happening. No other modifications to my system other than TWRP and Magisk!

I figured I'd start from scratch and attempted to use the Magisk Uninstaller but it doesn't work:

Updater process ended with ERROR :1
Error installing zip file '/sdcard/Download/Magisk-uninstaller-20180429.zip'

So... I can't even remove Magisk completely and start again.

If anyone has a solution for:

1. fixing the module install problem

2. allowing the removal of Magisk

... I'd appreciate it!

---------- Post added at 09:12 PM ---------- Previous post was at 08:22 PM ----------

Ok, after many attempts, I was able to uninstall using the (wait for it) "Uninstall" button in the Magisk app and then rebooting. After re-installation, modules are installing correctly and persistent after restart.

Side note: I recommend Magisk 16.3 ... I've had far better luck with 16.3 than with 16.0 or 16.4 with it working as it should.

Just putting this out there for posterity and for anyone else having issues with 16.4
[Magisk] cd993:
Unticking magisk hide so far has perhaps solved it for me.... maybe its too early to say, but so far so good....
[Magisk] Didgeridoohan:
You could probably have used the next to latest uninstaller: https://github.com/topjohnwu/Magisk/releases/download/v16.3/Magisk-uninstaller-20180328.zip

The latest one has an issue with 64-bit devices.
[Magisk] jugoslavpetrovic:
Oh, I wasn't aware of this. Thanks a lot.
[Magisk] weisguy:
I use an application called 'Tiles' to add a screenshot tile to my quick settings panel. The operation of the screenshot function requires root, which I have granted. On my OnePlus 6 running Magisk v16.4, the tile does not function. I reached out to the developer of the Tiles app, who had me execute the following steps to verify if it was the application or my SU app preventing this from functioning:

OnePlus6:/ $ su

OnePlus6:/ # screencap /sdcard/screencap.png

gralloc-mapper must be in passthrough mode

Aborted

134|OnePlus6:/ #

He concluded my SU-manager was preventing screenshots and not his application. Is this something that can be remedied? I was going to attach my log file, however no lines are appended to the file when I attempt to take a screenshot so I doubt it would be useful.
[Magisk] Didgeridoohan:
How would the SU-manager prevent screenshots? Anyway, a quick test shows it works just fine for me...
[Magisk] jenslody:
Did you check the superuser-tab in MagiskManager?

Just to be sure, you did not accidently deny root access for the app.
[Magisk] weisguy:
Did you check the superuser-tab in MagiskManager?

>> yes. the terminal emulator log above also shows I was superuser. I was not able to do this there, either, with elevated priv's. Perhaps a unique "feature" of my Oneplus 6?
[Magisk] Shipper403:
Seriously need help..

Hello everyone !

I'm here just to ask for some help.. there's no other way anymore.... after months (since last year) of researches, I found nothing viable of a solution..

I tried everything, up to even bricking my device bringing it to the SAV, twice or thrice..

I'm using a Phantom 8, from Tecno. I installed successfully Magisk, since the earlier versions.. but never managed to install any module, even the Viper4 ones which I really wanted to test on Magisk.. it always fails on this 'merge' part, a failing mounting. I tried that F2FS 'fix' module too to no avail... All the modules fail to install with the same mounting error (logfile attached).

Looking forward to some really needed help, tried too many things to brick on my device again..,

Cordially,

Shipper.
[Magisk] razzor1984:
Magisk is causing this isue so what can we provide to fix it?

Is their a log like on real Linux pcs like a syslog?

What can we do to provide the dev with data? Magisk 16/16.4b ist causing the Lineage build to quit booting so any chance that a dev can look into that topic?

Im trying to help!
[Magisk] Didgeridoohan:
It's likely already been fixed by this commit:

https://github.com/topjohnwu/Magisk/commit/f6ee2525722e863e0866c9ba0bd204da9a796852

So, either wait for a release by [MENTION=4470081]topjohnwu[/MENTION], build yourself, or try one of the unofficial snapshots available in the forums.
[Magisk] GameNCode:
Magisk manager keeps crashing when I go into modules or downloads. Tried reinstalling the zip but it didn't help

Log from magisk_debug.log
[Magisk] schickel:
Same here (Samsung Galaxy Tab S2 SM-T813 with LineageOS 15.1). Hoping it will be fixed in the near future.

[MENTION=4470081]topjohnwu[/MENTION] if you need some logs or testing for solving this issue, please contact me
[Magisk] TerrorToetje:
Hey Guys,

For me magisk is not disabling forced encryption on an Asus Zenpad S8 Z580C stock rom, it's android 6.0.1 based even all scripts around xda are not disabling it!

flash magisk > reboot twrp > wipe data > reboot and it alsways forces the encryption again. once i reboot back to twrp data is encrypted again:(

FSTAB Data:

/dev/block/by-name/system /system ext4 ro,noatime wait
/dev/block/by-name/cache /cache ext4 nosuid,nodev,noatime,barrier=1,data=ordered wait,check
/dev/block/by-name/config /config ext4 nosuid,nodev,noatime,barrier=1,data=ordered wait
/dev/block/by-name/data /data ext4 nosuid,nodev,noatime,discard,barrier=1,data=ordered,noauto_da_alloc wait,check,encryptable=/factory/userdata_footer
/dev/block/by-name/persistent /persistent emmc None None
/dev/block/by-name/factory /factory ext4 nosuid,nodev,noatime,barrier=1,data=ordered wait
*/block/sd* /storage/USBdisk1 vfat None wait,voldmanaged=USBdisk1:auto
*/block/sd* /storage/USBdisk2 vfat None wait,voldmanaged=USBdisk2:auto
*/block/mmcblk1* /storage/MicroSD vfat None wait,voldmanaged=MicroSD:auto

I included the ramdisk aswell :)
[Magisk] SacredDeviL666:
Thread Cleaned/ Keep the discussion on topic as specified in OP of this Beta Thread :highfive:
[Magisk] prinz3nroll3:
error @ zte blade l5

hi,

i want to install magisk, first i try 18.0 but i get an error,

after that i try 18.4, got the same error.

i attach the log.

twrp version is 3.0.1 i think it it the only recover for the blade l5.

thanks a lot for the help
[Magisk] OpLKS:
About Magisk.

The latest version of Magisk, is causing several errors in the ROMs, the project stopped?
[Magisk] Didgeridoohan:
No...

https://github.com/topjohnwu/Magisk/commits/master
[Magisk] Woobhurk:
I've met a problem after rebooting. All modules that contains app seemed not appear in the launcher, such as YouTube Vanced, ViPER4Android.

And logs show that the modules have been mounted, but I didn't see in the launcher.