yashsingh1/xdaforums huggingface dataset:
[Magisk] socali:
Issue with v14.5 (code: 1456)

[MENTION=4470081]topjohnwu[/MENTION] Looks like magisk v1456 is getting stuck in an infinite loop.. I found the issue since my phone start getting super hot and I used top to see what's going on with the cpu.

Tasks: 648 total, 1 running, 640 sleeping, 0 stopped, 1 zombie
Mem: 3756476k total, 3008260k used, 748216k free, 23744k buffers
Swap: 524284k total, 0k used, 524284k free, 1738512k cached
800%cpu 53%user 9%nice 363%sys 350%idle 0%iow 16%irq 9%sirq 0%host
PID USER PR NI VIRT RES SHR S[%CPU] %MEM TIME+ ARGS
1469 root 20 0 30M 3.3M 2.4M D 221 0.0 4:32.79 magisk_daemon -daemon
658 root 20 0 24M 2.0M 0.9M S 96.8 0.0 2:02.75 magisk_daemon -post-fs-data
572 logd 30 10 22M 5.3M 1.3M S 65.6 0.1 1:21.06 logd
23506 root 20 0 10M 2.4M 1.4M R 21.8 0.0 0:00.07 top
6 root 20 0 0 0 0 S 18.7 0.0 0:01.63 [kworker/u16:0]
664 root 20 0 8.4M 1.5M 1.1M S 15.6 0.0 0:18.14 logcat -v threadtime
1490 root 20 0 8.4M 1.5M 1.1M S 12.5 0.0 0:16.19 logcat -b all -v threadtime -s am_proc_start Magisk
661 root 20 0 8.4M 1.5M 1.1M S 12.5 0.0 0:16.25 logcat -b all -v threadtime -s am_proc_start Magisk
545 root 20 0 9.0M 5.7M 136K S 6.2 0.1 0:07.93 init

Logcat keeps looping on this:

11-24 12:31:49.260 1469 19214 I chatty : uid=0(root) magisk expire 2 lines
11-24 12:31:49.261 1469 19213 I chatty : uid=0(root) magisk expire 2 lines
11-24 12:31:49.262 1469 19216 I chatty : uid=0(root) magisk expire 2 lines
11-24 12:31:49.366 1469 19471 I chatty : uid=0(root) magisk expire 2 lines
11-24 12:31:49.478 1469 19722 I chatty : uid=0(root) magisk expire 2 lines
11-24 12:31:49.585 1469 19978 I chatty : uid=0(root) magisk expire 2 lines
11-24 12:31:49.694 1469 1469 E Magisk : accept failed with 22: Invalid argument
11-24 12:31:49.695 1469 1469 E Magisk : accept failed with 22: Invalid argument
11-24 12:31:49.695 1469 20227 E Magisk : read failed with 9: Bad file descriptor
11-24 12:31:49.695 1469 20227 E Magisk : getsockopt failed with 9: Bad file descriptor
11-24 12:31:49.695 1469 1469 E Magisk : accept failed with 22: Invalid argument
11-24 12:31:49.696 1469 20224 E Magisk : read failed with 9: Bad file descriptor
11-24 12:31:49.696 1469 20224 E Magisk : getsockopt failed with 9: Bad file descriptor
11-24 12:31:49.696 1469 1469 E Magisk : accept failed with 22: Invalid argument
11-24 12:31:49.696 1469 20228 E Magisk : read failed with 9: Bad file descriptor
11-24 12:31:49.696 1469 20229 E Magisk : read failed with 9: Bad file descriptor
11-24 12:31:49.696 1469 20228 E Magisk : getsockopt failed with 9: Bad file descriptor
11-24 12:31:49.696 1469 20229 E Magisk : getsockopt failed with 9: Bad file descriptor
11-24 12:31:49.697 1469 20226 E Magisk : read failed with 9: Bad file descriptor
11-24 12:31:49.697 1469 20226 E Magisk : getsockopt failed with 9: Bad file descriptor
11-24 12:31:49.697 1469 1469 E Magisk : accept failed with 22: Invalid argument
11-24 12:31:49.698 1469 1469 E Magisk : accept failed with 22: Invalid argument
11-24 12:31:49.698 1469 1469 E Magisk : accept failed with 22: Invalid argument
[Magisk] Shished:
OmniROM 8 unofficial. SafetyNet checks fails when 1456 is installed. Looks like Magisk Hide does not works, RootBeer Sample app still detects root even if Hide is enabled for it.

Here is the log file.

https://drive.google.com/file/d/1BQwb0G2QEFd7WUUIDzKHZbFNTA2znOL2/view?usp=drivesdk

EDIT. I found the problem. 'hidelist' file weren't created so magisk manager weren't able to write the hiding settings.

Executing "touch /sbin/.core/img/.core/hidelist" fixed this problem.

Edit2. After reboot problem returned :/
[Magisk] Wire1122:
P8 lite 2017 Pralx1c432b182 safetynet is ok but fails 2 options how get log file?

Now works
[Magisk] mustang_ssc:
Are you theming the Magisk app with a Substratum app? If so disable the overlay, this was the root cause on my RR Nougat build after updating the app.
[Magisk] fonfox:
Magisk App FC while safty net status

Oneplus2 Oreo v14.5(1456) v5.43(64)
[Magisk] tom.android:
"error when tapnto start safetynet check."

android.content.res.Resources$NotFoundException: String resource ID #0x7f0e0087

at android.content.res.Resources.getText(Resources.java:351)

at android.widget.TextView.setText(TextView.java:4562)

at com.topjohnwu.magisk.MagiskFragment.updateSafetyNetUI(Unknown Source)

at com.topjohnwu.magisk.MagiskFragment.onTopicPublished(Unknown Source)

at com.topjohnwu.magisk.utils.Topic.publish(Unknown Source)

at com.topjohnwu.magisk.asyncs.CheckSafetyNet.lambda$onPostExecute$0$CheckSafetyNet(Unknown Source)

at com.topjohnwu.magisk.asyncs.CheckSafetyNet$$Lambda$0.invoke(Unknown Source)

at java.lang.reflect.Proxy.invoke(Proxy.java:813)

at $Proxy0.onResponse(Unknown Source)

at com.topjohnwu.snet.SafetyNetHelper.onConnectionFailed(Unknown Source)

at com.google.android.gms.common.internal.f.a(Unknown Source)

at com.google.android.gms.common.api.internal.ac.a(Unknown Source)

at com.google.android.gms.common.api.internal.p.b(Unknown Source)

at com.google.android.gms.common.api.internal.p.a(Unknown Source)

at com.google.android.gms.common.api.internal.t.a(Unknown Source)

at com.google.android.gms.common.api.internal.ai.a(Unknown Source)

at com.google.android.gms.common.api.internal.aj.handleMessage(Unknown Source)

at android.os.Handler.dispatchMessage(Handler.java:102)

at android.os.Looper.loop(Looper.java:163)

at android.app.ActivityThread.main(ActivityThread.java:6372)

at java.lang.reflect.Method.invoke(Native Method)

at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:901)

at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:791)
[Magisk] Tkbf:
Samsung S8 plus with latest Android N stock rom, Magisk 14.5, and Magisk Manager 5.4.3 installed successfully, device rooted, but flash Xposed 88.2 SDK24 faceing stuck on boot logo.
[Magisk] kosmasgr:
Lol. SDK 25 for nougat :highfive:
[Magisk] Veid71:
so i installed magisk 14.5 and installed 4 or 5 modules and they all failed saying magisk was not activated one got close to being done it started to flash it and got like 8 lines into it and said the failed issue then i looked in my file exlorer and under systemroot there wasnt a Magisk folder and i also couldnt find a magisk_debug.log file anywhere on my phone either i even had show hidden files checked but in my sdcard there was a magiskmanager folder though so i created a new folder under systemroot and named it Magisk and i tried to reboot and it got stuck on the splash screen the first time then the second time it went into a boot loop so i powered it off and booted it into twrp and looked around in that file manager and found the magiskdebug log and i copied and pasted it into my download file so i could move it to my computer and my computer didnt recognize that it was there until i restarted my phone back into twrp mode this issue also happened with the install logs, even though in my file managers it said they were there, i refreshed and closed out the folder and re opened a new one on my computer and it still didnt show up until i refreshed but anyway here are the logs i put the install logs in there aswell as the magisk debug one and i also tried to flash one of the modules in twrp and included that recovery.log aswell it threw an error the bootloop must have had something to do with magisk because soon as i uninstalled it and reflashed my stock boot img it rebooted fine

edit: i just installed magisk and installed the manager and the saftey net failed which i thought was odd... until i noticed it didnt have magiskhide or superuser or a log or even an uninstall button then but i did manage to save the log for installing it so here it is
[Magisk] Zacharee1:
SDK 25 is 7.1. The S8 is on 7.0.
[Magisk] triggeredbot:
When trying to install the blu_spark touchpanel FW .zip i get this error 'Magisk is not active...abort'. Also does this with other modules as well.

EDIT: Flashing in twrp seems to work
[Magisk] ryaniskira:
How do I collect a log if my device is bootlooping and adb has not started (meaning I can't grab a logcat)? I even tried booting into TWRP and pulling /data/magisk_debug.log but it did not exist so it was not created aparently. If anyone knows a way to grab a log in that situation I will reflash 1456 just to collect the log.
[Magisk] Pkt_Lnt:
You can get a logcat using a PC and adb. - start adb and then boot the phone. I have done it hundreds of times. :good:

From the Logcat Tutorial:

https://xdaforums.com/showthread.php?t=1726238
[Magisk] ryaniskira:
Well the issue is that requires adb to be active on your phone. Now on PureNexus adb is active on boot (this is actually how I catch bootloops when I flash something by running adb logcat), but after flashing 1456 adb never activates. In fact Windows nor Linux even detect that the device has been plugged in and neither can grab a logcat with adb. Windows never gives the auditory prompt that a device has been connected and lsusb doesn't show my device.
[Magisk] Pkt_Lnt:
Enable USB debugging in Developer Options and it stays active through reboots and flashing anything but a complete ROM. Again, I have done this hundreds of time on many devices, android versions and root methods. As long as you do not turn off USB debugging it will stay active through boot. Don't worry about adb getting a response from the phone. Just starts adb with the command line above and boot the phone.
[Magisk] ryaniskira:
I have USB debugging enabled, the point is that ADB on my PC does not connect to the phone in the bootloop after flashing Magisk 1456, period. Not a single PC in my house can even detect that it has been plugged in and all of them have the drivers. This is the only situation outside of a clean ROM flash where this has happened, because again I use adb to detect bootloops when I flash something on my phone like a kernel or Arise.
[Magisk] Nevermindthelabel:
Had this very issue with my OP3 on the first few open beta Oreo builds. Upload the stock and modified boot.img so [MENTION=4470081]topjohnwu[/MENTION] can do his magic. What device?
[Magisk] ryaniskira:
Mine is the Pixel XL but since he has the Pixel XL he has the boot image.
[Magisk] TheFixItMan:
Using magisk 14.5 on lineageos 15 oreo

Basic integrity passes but CtsProfile fails

I tried the CtsProfile fix module but although it flashes correctly it doesn't show in module list

I tried the Viper4android module & that works fine

Using the Moto G5 Cedric
[Magisk] IH8TouchWiz:
Using a magisk v14.5 patched boot image, get FCs whenever I try to check safetynet on the Oreo beta firmware (Essential PH-1). Safetynet is also not passing.
[Magisk] reliant_turbo:
Opneolus 3t

8.0 stable oxygen OS rom

Magisk 14.5 beta 5.4.3 manager

Cannot install modules.

! Magisk is not activated!... abort

Failed!

! Installation failed

Same error for every module I try to install.

Thx, Brian
[Magisk] bkkzak:
I typed both codes in terminal as SU, and it returned "No such file or directory". I'm running 14.3 on my Pixel XL as 14.5's I couldn't get root access. SO, do I not have a magisk.img? Does this mean I am running in core only mode (essentially)? Is this consistent with everything except the modules installing/working (they say they install, but they don't)?

Edit: Here is a log of me trying to install a module, no errors.

And here is my magisk log after a reboot, a bunch of errors actually..
[Magisk] Didgeridoohan:
I've not yet had an opportunity to update to Oreo on my OP3T. Judging from what I've read, it might prove interesting... :p

There was a bug like this in the code, but on official releases and for most normal modules it shouldn't have manifested. Is this on a clean install of the official beta? If not, try uninstalling and reinstalling...

And please also provide the magisk_debug.log when reporting issues. You'll find it in /data.

If the Magisk image wasn't mounted you wouldn't get any return are all with that command. Did you type them in exactly as written? What happens when you just type "mount" (without quotation marks)?

From your logs (plenty of errors in both) it looks like the merge image and Magisk image isn't mounted properly, possibly read-only. You could check this with a file explorer as well. For v14.3 the path is /magisk and for v14.5 /sbin/.core/img.
[Magisk] bkkzak:
Okay so I didn't put in the vertical bar, but with that I get no return with either command.

When I type just

mount

I get a huge return, a screen shot is attached (sorry I couldn't copy the log).

Looking with a file explorer, /magisk has 755 permissions; is that what you're asking?

What can I do to mount the merge image and magisk image properly? Thanks
[Magisk] Didgeridoohan:
I checked again and realised what it's about. Everything is working as it should, but the module is to old and needs to be updated to a newer module template.

---------- Post added at 11:13 ---------- Previous post was at 11:04 ----------

I forgot that you have a Pixel... I've got little to no knowledge about A/B devices. I don't see anything from that mount command about the Magisk image being mounted though.

The Pixel XL shouldn't have any issues though, [MENTION=4470081]topjohnwu[/MENTION] has one to develop and test on and from what I've heard it works.

Your magisk_debug.log would be interesting to see (in /data).
[Magisk] Elmarigo:
No version younger than magisk 14.3 beta is workign for me at all anymore.

Everytime I try installing magisk 14.3+ all I get is "magisk not installed" in Magisk manager.

I tried anything from dirty flashed, to uninstalling, to full wipes, dozens of times. But recent Magisk versions just won't work on my Lineage ROM.
[Magisk] Didgeridoohan:
Logs please.
[Magisk] sToRm//:
Hi [MENTION=4470081]topjohnwu[/MENTION]

First: THANK YOU! Your work is absolutely awesome - you are a hero! Never had problems with my own devices. :)

Question:

Can you tell me (just short random points) which files/binaries are modified in the boot.img and where I could check for problems with verity?

I actually work on a DRM patch for different devices (Sony XZ Premium, XZ, XZs, XZ1, XZ1 Compact, ...) and have some weird problems with some of them.

You can take a look at XperiFIX if you are interested: https://xdaforums.com/xz-premium/development/hack-mod-sony-xperia-xz-premium-twrp-t3695171

On XZ Premium no problems at all. Flashing Magisk 14+ works smooth on N and O. But we get bootloops on (for example) the XZ1 Compact @ Oreo.

I have a stock kernel with a patched ramdisk (included preloads for the DRM patch in the environment - nothing else modified). If we flash Magisk 14.3/14.5 over it, it stucks in bootloops.

There are no errors while flashing Magisk. But what we noticed is, that sometimes it says "dtb is patched" and sometimes not... crazy...

But independently of dtb patched or not... The system boots to the animation and then it crashes to a bootloop. For me it looks like a problem with verity, but I am not really sure.

What I noticed is, that this problem exists on devices which have a /vendor partition, but not on XZ Premium (only /system with verity).

Also there are differences with the selinux files in the ramdisk. On XZ Premium there are all relevant files included in the ramdisk (nonplat, plat, sepolicy, ...),

but on the other devices there is no such file in the ramdisk. Maybe you could give a hint, where I can search for possible bugs with verity or something else.

Would be nice to hear from you! Thank you!

:)
[Magisk] reliant_turbo:
That makes sense. the author of the module need to update the module I assume?

I couldn't view or copy the debug log. I was using solid explorer and it has root access via magisk.

I'll try a reboot and see what happens

Edit I attached a screenshot of the debug log read error.

Brian
[Magisk] fabudary:
hello,topjohnwu，my device is xiaomi mix2 ， i flash miui official rom ，then i flash magisk14.0 . but when i first turn on 。 my phone forced encryption ， FBE data partition。

so.I have to flash supersu.but I want to use magisk.

how can I use magisk . but don't let data partition be encryption.

thank u
[Magisk] DroidIt!:
Judging from this thread, he's probably too busy reading logs :angel::p
[Magisk] David522d:
Tried flashing on my pixel xl, latest twrp and paranoid android.

Says its successful once done flashing but once I reboot I don't see it anywhere nor do I have root

Any idea?
[Magisk] djide:
Same here with Pixel XL. Thinking of trying 14.3
[Magisk] Veid71:
this was the error i was having i did mount then a whole lot of things came up then i did the grep command and i got nothing it was almost like the cmd in adb was just processing it for like 20 minutes

---------- Post added at 10:56 PM ---------- Previous post was at 10:53 PM ----------

try downloading and installing a magisk manager and see if it shows up then
[Magisk] killdir:
Crash report here..Kindof

Pixel XL

Oreo 8.0.0, November security updates

Magisk 14.5 (1456), MagiskManager 5.4.3 (64)

ElementalX 2.03 kernel

No non-default magisk modules installed

Symptoms:

Everything looks great, root is good, safetynet passes. After a variable amount of time (10-30 minutes) apps start crashing all at once and screen goes blank, eventually rebooting

Logcat shows processes reporting various out of memory errors (e.g. 'unable to fork')

When I grab a shell on the running phone, it looks like magisk is constantly running a logcat command: logcat -b all -v threadtime -s am_proc_start Magisk

It looks like 45-50 per second are spawned.

Additionally, the processes are never cleaned up and remain as zombies (i.e. wait() was never called to clean up). After a few minutes of uptime, there are 10-20k zombie popen processes in the process table.

Eventually this seems to either cause memory exhaustion or the process table to hit a limit (65535?) and the phone crashes

Quick googling suggests that popen()/pclose() should never be used in Android.. but its use in proc_monitor code isn't new so.. I dunno

Edit: My phone is stable with the above configuration after disabling MagiskHide completely (though of course SafetyNet checks no longer pass) so the problem appears to be contained in magiskhide
[Magisk] rknee:
Pixel 2 XL

magisk mgr installed, boot.img patched and flashed, root established

msg that pops up and says patching dtbo.img, directs to reboot

reboot

now pop up msg prior to sim/pin password

Android System-

There's an internal problem with your device. Contact your manufacturer for details.

Not really seeing or detecting any issues, other than what other people have noted with cts

contacted google got the usual return to factory image talk

Android 8.1 DP2; Magisk 14.5; MagiskMgr 5.4.3
[Magisk] drewski_1:
this error message was previously stated as a by-product of the disabling of AVB-verity starting in Magisk 14.4.3 (unoffical) and now 14.5 (official)
[Magisk] daviderickson:
Pixel XL - Android 8.0.0 OPR3.170623.013 November 2017, everything stock except for Magisk.

Magisk 1456

Was listening to an audiobook and it froze, then went into a soft reset boot loop (kept restarting quickly), hard power off/on got it back working again. Attaching the magisk debug log. It looks like the debug log is truncated at boot, it might be nice to just append to it, to catch any messages that happen prior to a reset. And set a hard limit on size.
[Magisk] GridironTrenches:
Im receiving the same error upon boot after flashing magisk 14.5(1456). Does that mean a flashing error? I have root access

I suppose this is the answer

Quote:

Originally Posted by topjohnwu

The additional avb-verity removal from DTBO on the Pixel 2 devices results in a scary pop-up. No need to worry here, it's Google warning you that your vendor partition doesn't work as expected. I decided to strip off avb-verity to make modifications to the vendor partition possible, as people tend to modify their partitions a lot, and not sure if this might save a few soft brick devices.... As the old dm-verity and avb-verity works so different, it is very difficult for me to come up with a proper way that doesn't complicate things on the user side.

link:

https://xdaforums.com/pixel-2-xl/de...pixel-2-xl-t3701176/post74605237#post74605237
[Magisk] SacredDeviL666:
thought of a reminder now that we have new version of magisk which was the key discussion when the previous version 14.3 was out.... now that we all have the version we wanted which was on beta channels...

lets stick to these....

This thread isn't for general discussions or opinions about magisk those could be done in Magisk General Support / Discussion thread :good:
[Magisk] Cobmaster:
Hi, I have a problem with latest Magisk beta 14.5. The log shows that it fails to mount with a "permission denied". I have no problems at all with the root access.

Log attached.

Phone: Lenovo Moto Z Play with RR 5.8.4 (Android 7.1.2, with September update).

Can someone please help me? Thanks in advance...
[Magisk] Cobmaster:
Here the log, I forgot to attach it

Edit: tried with a different kernel and set the SELinux to permissive and now it works!
[Magisk] anvitiousky:
so you're saying this issue comes from buggy f2fs in kernel? do you have a link to more information about this? I have a chinaphone and it gives me the same issue, however, after the system is booted, i am able to manually mount magisk.img.
[Magisk] Pkt_Lnt:
Scroll down to the Troubleshooting part in post #1 the Magisk Release Thread and there is more f2fs info and links.

https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445
[Magisk] tag68:
This link is not pointing to the right problem description. AFAIK noone did analyze the cause of the problem in detail by now.

Original f2fs problem which is linked in the troubleshooting part was fixed by Motorola about April 2017 (at least for Moto Z Play, delivering Nougat since 1/2017, other Moto devices seem to have similar dates but may differ of course).

The original problem was not allowing to mount bind any directory on f2fs file system because the loopback device on f2fs was completely broken. Magisk could not be installed at all.

Whatever Motorola did is being said to mount the /magisk fine, but read only. It is possible to install Magisk, but you can't install modules, use Magisk hide or save settings being written to /Magisk like Magisk manager.

If it's just some bug preventing write or some change by purpose is unknown to me. My own device Moto Z Play is at patch level 12/2016 (last marshmallow) by now, that's why the facts I write is not my own experience.
[Magisk] bkkzak:
Pixel XL running Resurrection Remix 5.8.4 Android 7.1.2

No root with Magisk 14.5, root but no modules on 14.3, so I'm on 14.2.

When I flashed the first couple modules they worked in the manager, then a few wouldn't install saying can't mount magisk_merge.img (log attached). So I tried them in TWRP, some installed and the rest failed because /system couldn't be mounted (??..). So I tried flashing in Flashfire, and they all flashed but don't work (V4A says driver not installed and freezes when I hit install. The driver should be pre-installed)/force close (dolby atmos) when I open them.

Why can't magisk mount magisk_merge.img? What can I do? Thanks

EDIT:

I found this post which explains the issue more, and a workaround is to Install the Busybox Magisk module first because it properly mounts magisk_merge.img and leaves it mounted so you can install problem modules immediately after, and they'll install.

The problem I'm having is that even though modules will now install, some still won't function properly. Such as V4A (@ahrion's AML version) says driver not installed and freezes when I hit install. The driver should be pre-installed. And Dolby Atmos just force closes and doesn't go past the splash screen. Any ideas?
[Magisk] Rammit:
Hi,

Am on OP3T , OB 18. Magisk 14.5 beta.

Installed magisk, flashed patched boot image.

Root works fine..

Issues

Lost WiFi.

Safety net failed.

Pls suggest. Log attached.
[Magisk] HIGZWJfu:
Bug report

Device Moto G5 (cedric)

Android 7.0

Magisk v14.5 (1456)

Installed with TWRP v3.1.1 (official), everything seems to be ok, but...

Bug: Root disables itself for no reason, then it get enabled after a short time or after a reboot.

Log:

pastebin 1BZuUSYx