yashsingh1/xdaforums huggingface dataset:
[Magisk] dyingearth:
I already had Magisk manager installed. So I go through my usual method of doing monthly update:

Download the factory image.

extract factory image into its own directory

extract the image file in it into its own directory.

copy boot.img into a directory on the phone.

modify flash-all.bat and remove -w

run flash-all.bat while in bootloader screen.

run magisk manager and patch using the latest beta.

copy the patch image back to the computer.

go back to the boot loader screen

fastboot flash boot patched_boot.img

reboot

Note, while this method works, you will need to disable any kind of security unlock prior to doing the flash root step, or you won't be able to unlock the phone. topjohn have mentioned in a tweet that this is an known issue and will be fixed in a future version. For now, disable security unlock. Flash root and then set up security PIN. DO NOT powered down the phone or you'll lose the ability to unlock the phone and have to flash back to factory boot.img.
[Magisk] driz:
Hello, I just upgraded to android p. I did a full wipe of all data and a clean install. I installed 16.7 beta without issue. Upon login, i checked safetynet and i was green. I then marked some of my apps to hide and began settings things up. I went to google pay, which on the latest android o with stable magisk, worked fine. It told me i was rooted. I checked my magisk hide settings and noticed everything was unchecked. I rechecked things, rebooted, and checked and again everything was unchecked. The logs don't seem to imply anything wrong, but cisco jabber and google pay both flag me as being rooted (in the logs, they are cisco.im and walletnfcrel)

08-09 14:03:59.322 582 582 I Magisk : ** Initializing Magisk
08-09 14:03:59.324 582 582 I Magisk : * Creating /sbin overlay
08-09 14:03:59.328 582 582 I Magisk : * Mounting mirrors
08-09 14:03:59.329 582 582 I Magisk : bind_mount: /sbin/.core/mirror/system
08-09 14:03:59.329 582 582 I Magisk : mount: /sbin/.core/mirror/vendor
08-09 14:03:59.330 582 582 I Magisk : bind_mount: /sbin/.core/mirror/bin
08-09 14:03:59.330 582 582 I Magisk : * Setting up internal busybox
08-09 14:03:59.399 602 602 I Magisk : Magisk v16.7(1671) logger started
08-09 14:03:59.409 598 598 I Magisk : Magisk v16.7(1671) daemon started
08-09 14:03:59.417 598 604 I Magisk : ** post-fs-data mode running
08-09 14:03:59.422 598 604 I Magisk : * Mounting /data/adb/magisk.img
08-09 14:03:59.488 598 604 I Magisk : * Running post-fs-data.d scripts
08-09 14:03:59.488 598 604 I Magisk : * Running module post-fs-data scripts
08-09 14:03:59.488 598 604 I Magisk : * Loading modules
08-09 14:03:59.491 598 616 I Magisk : * Starting MagiskHide
08-09 14:03:59.494 598 616 I Magisk : hide_utils: Hiding sensitive props
08-09 14:03:59.506 598 616 I Magisk : hide_list: [com.google.android.gms.unstable]
08-09 14:04:01.058 598 853 I Magisk : ** late_start service mode running
08-09 14:04:02.190 598 853 I Magisk : * Running service.d scripts
08-09 14:04:02.191 598 853 I Magisk : * Running module service scripts
08-09 14:06:20.759 598 616 I Magisk : proc_monitor: com.google.android.gms.unstable
08-09 14:07:38.366 598 616 I Magisk : proc_monitor: com.google.android.gms.unstable
08-09 14:09:42.127 598 10601 I Magisk : hide_list add: [com.usablenet.android.aetna]
08-09 14:09:56.565 598 10632 I Magisk : hide_list add: [com.cisco.im]
08-09 14:10:04.979 598 10646 I Magisk : hide_list add: [com.DPMOBESA]
08-09 14:10:13.708 598 10650 I Magisk : hide_list add: [com.google.android.apps.walletnfcrel]
08-09 14:10:24.763 598 10656 I Magisk : hide_list add: [com.paypal.here]
08-09 14:10:28.569 598 10660 I Magisk : hide_list add: [com.nianticlabs.pokemongo]
08-09 14:10:41.704 598 10670 I Magisk : hide_list add: [com.usaa.mobile.android.usaa]

I'm going to reflash os and try stable magisk. thanks all, hth!

update: stable magisk appeared to flash fine but didn't actually install/provide root. I'm just going to wait for the next beta and try again. Thanks for all you do guys!
[Magisk] BigThunder:
Magisk Hide (Magisk v16) no longer working on Android 9 (Pie) with Pixel XL. ?

Everything was working great on Android 8.1 (Oreo).
[Magisk] eturk01:
on Android Pie, magisk 16.7 beta

If I install magisk zip, with screen pin lock on, when I reboot the pin is no longer recognized and I need to reset the Pixel 2 XL

this also happened on last beta for P

tips? wait for an update?
[Magisk] Badger50:
Might be best to use the magisk version 16.7(4) which you can find in the Flash kernel thread....https://xdaforums.com/pixel-2-xl/development/taimen-flash-kernel-1-00-t3702057/post77240449

:good:
[Magisk] martyfender:
Disable the pin before you flash Magisk. I don't have a Pixel 2 XL, but I have seen this posted many times on this and other, Magisk threads. And there is a custom version of Magisk, mentioned here, that I see a poster has recommended you try, also.
[Magisk] H0wdy:
Hello,

Verizon Pixel XL, Android P.

I still cannot boot after I sideload Magisk

install Android P

reboot to recovery

fastboot twrp, latest

sideload Magisk 16.4 or 16.7

reboot to system, goes to G logo with vertical bar... eventually reboots to recovery.

Every time :(
[Magisk] Si73:
Pixel xl 2 no issues with Magisk on Android 9.

Uninstalled Magisk whilst on 8.1 via TWRP with Magisk unistaller.

Installed Android 9 through Fastboot (deleted - w).

Turned off/removed pin.

Fastboot into TWRP and installed Magisk 16.7.

Reboot and setup pin etc.

Magisk works fine, safety net passes & no issues with pin unlock when rebooted.

The only thing I haven't done is install TWRP.
[Magisk] fipm:
same here on Pixel XL. I tried all the instructions I could find. Clean install every time, but nothing.
[Magisk] peterlee928:
have yall tried using the latest beta in this post https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589/post77292483
[Magisk] fipm:
Yes. Still bootlooping.
[Magisk] bunklung:
I had a heck of a time getting this beta to work (ended up on 1674).

My problem was that I was installing modules that worked on stable 16, but ultimately didn't work in 1671. What I found out later was that the magisk.img was corrupt even though I did the uninstall_magisk via recovery. I think I could have deleted the file, but found that I could use a TWRP recovery mod to run e2fsck -f on the image: https://xdaforums.com/showpost.php?p=72542167&postcount=242 I found out the image file was bad when I couldn't mount it using magisk-mount flash in recovery.

Why doesn't magisk_uninstall remove the image file? Anyhow. I was able to flash over the full OTA (Pixel 2) without issues even though my system flash was fine. It was the dam magisk.img/old-modules.

I was able find newer version of my modules that work with Android P. I never thought to redownload these new modules. They always just worked when I reflashed magisk with each system update. I don't know if I still need 1674 over 1671 to be honest.

My final issues:

Force encryption doesn't stick in MM.

SafetyNet pass MOST of the time across a bunch of SafetyNet checking apps.

Anyone who has a SN pass, try it 10 times in a row and see if it passes 10 times, just curious...

I did not have a PIN to reset. I just have a full password. Should I have blanked this out?
[Magisk] scoobyjenkins:
I gave that a try on my OP5 running an 8.1 ROM (Tipsy), as flashing the 16.7 beta from here would have me not getting past the splash screen after trying to reboot to system from TWRP. That version flashed fine and allowed me to boot, so I guess what Nathan was saying about crashes could also apply here. 16.6 was also fine for me.
[Magisk] Didgeridoohan:
What do you mean by "uninstall_magisk via recovery"? If by that you mean you flashed the latest Magisk-uninstaller-yyyymmdd.zip, it should definitely remove the Magisk image and any other Magisk related files. If you used any other method of uninstalling, nothing is guaranteed, so don't...

Unless you're going to flash Magisk with the "Preserve forced encryption" option enabled, you can ignore the toggle in the Magisk Manager. It only does something when you're actually installing Magisk. It's supposed to detect your encryption state, but this doesn't always work, currently.

The random SafetyNet "fail" seems to just be an issue with the Google servers. If you use a good SafetyNet checker app you'll see that it reports a failure because of connection issues.
[Magisk] BrikHaus:
I had similar boot stall issues.

Installed version 9 (-w), fastboot TWRP, and sideload TWRP, Magisk, and Flashkernel. Got the Boot lock.

I ended up repeating above steps, but ran the Magisk Uninstaller after fastbooting TWRP. skipped Magisk and installed Flashkernel.

Rebooted back to recovery, and then flashed Magisk 16.7, and it boots fine.

So I have Magisk working, but there doesn't appear to be a SDK (28?) Xposed module for Magisk... Yet.

(I assume it is the Xposed module SDK27 that is causing the issue?)
[Magisk] tyler19820201:
I was trying just now this method on my Samsung with the Santander app and works fine. You should try with the lloyds...

1. Reinstall the banking app and restart to TWRP

2. From TWRP uninstall the Magisk

3. Install the banking app and register your device & log in

5. Reboot

6. Install the Magisk and hide the app but do not log in

7. Reboot

Enjoy:laugh:
[Magisk] bggold:
You assume correct no Xposed for pie yet.
[Magisk] DanGLES3:
Indeed,android P sources just came out so Rovo89 (xposed developer) needs to adapt xposed to the runtime diferences introduced in Android P such as compact dex and whatnot
[Magisk] peterlee928:
have u tried this method? it worked for me on my p2xl. it worked both with and without flashing the flash kernel.

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post77264409
[Magisk] bunklung:
I did use the official/latest uninstall zip. So it's not clear why it didn't wipe this image file.
[Magisk] eturk01:
Dude, that version did the trick! thanks a bunch!

ya know, it just really is so cool that people around the globe that never met can help each other do cool things. :)
[Magisk] peterlee928:
glad that worked! make sure to show some love to [MENTION=3730810]Badger50[/MENTION], he hooked it up for me.
[Magisk] craig.s:
I'm trying to get Magisk working on my Pixel XL just updated to Pie but having the same problem as above, reboot runs the G logo screen for a few minutes then reboots to recovery.

I have a Verizon model which has unlocked bootloader and then TRWP installed.

Magisk uninstaller fixes ok, but anyway it's a no-go, same with the v16.7-1674 zip as 16.0 stable.

Do I gather from the above that installing FlashKernel first should make it compatible? Or Magisk needs updating more.
[Magisk] nathanchance:
We need proper logs at this point, I have no issues using it on my Pixel XL.

That build circulating around is straight from topjohnwu's repo, it's just normal Magisk (although it would be kind of nice if it wasn't discussed here as it detracts from the official beta).
[Magisk] craig.s:
I'll happily repeat the failure and provide logs, can you specify in advance, for a noob, what you want and if anything about the process needs doing differently to generate.
[Magisk] nathanchance:
Sure! logcat and dmesg, which can be captured via adb:

adb logcat -d > logcat.log
adb shell su -c dmesg > dmesg.log

If adb doesn't recognize your device, we'll need to come up with something else.
[Magisk] Didgeridoohan:
Only a recovery log, saved right after you ran the uninstaller, might have been able to tell us that...
[Magisk] xunholyx:
what versions are you using of Magisk and also Magisk Manager?
[Magisk] craig.s:
I tried with 16.0 and then the topjohnwu repo 16.7-1674 zip as that was suggested as working.

I originally sideloaded the Magisk Manager v5.8.3 apk but the app has disappeared now presumably from the uninstall zip flash (?). Anyway I'm not getting past the recovery flash stage.

adb and fastboot are working ok in all phone states.

Here's the entire dump of current logcat:

https://drive.google.com/file/d/1iA3rpyDQFoUoZFdBqPqXhq4udluVzhjK/view

I presume you know what to look for. Or if you want me to clear it then repeat the experiment let me know. As above the last failure was a flash of Magisk-v16.7-1674-.zip then the uninstall zip after boot failure.

I can't do shell su because the phone's not rooted, that is why I'm trying to do Magisk in the 1st place :o
[Magisk] danilo_scala:
Work in Xperia z5 Premium? i have suhide installed, no work pokemon but pass safety net
[Magisk] SOLIDFND:
On Pixel 2XL (Android 9, August Security Patch, Magisk 16.7(4)), I can confirm this. This could lead to screen burn in, if I didn't notice it :eek:
[Magisk] gverma1:
So Magisk hide is working for you on the original pixel xl running Android 9 Pie (August update)? Which Magisk version are you using? Thanks.
[Magisk] kostra2630:
Hi. Im trying to install magisk for hours with several boot.img files, but without success. Im trying to flash it for this rom: https://tickernel.org/lineageos-14-1-by-platum-for-leeco-le-s3-x626/ .Everytime i flash it it even doesnt boot, it immidiatelly go to recovery again... Can u please fix it somehow?
[Magisk] s--c:
I can't access the EE application no more in UK with magisk..pixel 2xl... any help? Or just how it is now?

Thanks
[Magisk] hfam:
Hey all,

I wanted to weigh in on the latest official beta 1671 and updating from Oreo July to Pie August.

I've never used TWRP on the Pixel platform (lived for it prior) as all I really wanted is root over stock. For those like me who kept it simple (absolutely no disrespect to you wizards, I'm just not that adventurous!), here is exactly how I performed the Pie update over Oreo July which was rooted with Magisk 16.0.

(I owe so much gratitude to nathanchance for his perfect tutorial on updating the Pixel 2 here https://xdaforums.com/pixel-2/how-to/guide-unlock-flash-root-pixel-2-walleye-t3702417.)

Pixel 2, July update, rooted via Magisk 16.0.

(NOTE: Leave MM 5.8.3 and Magisk 16.0 in place! I also disabledy screen lock just to be safe)

Download/Extract August Factory Image

Edit flash-all and remove "-w" if you want to preserve your user data and settings

Extract boot.img from large zip

Flash using nathanchance instructions in link above

Let the phone settle in

(This is reeal important here)

---

Open MM and in settings change channel Stable to Beta

MM will ask to install 1671, NOT YET, choose no thanks.

Make sure both Force Preserve Encryption and Preserve AVB are checked in less you KNOW you need them some other way. (I ran into bootloops after finding both were unchecked by default on 1671 and ended up reflashing factory image to get back.

---

Now go ahead and select Install in MM, install 1671, patch boot image.

Pull patched_boot.img to adb .achine, flash to boot using again nathanchance tut link instructions above, reboot.

Success.

I know this is trivial for many in here but I was pretty overwhelmed. A fellow named almondbiscuit shared he had done this without TWRP and it gave me the confidence to go ahead and try what I know. It worked great, didn't need to use the 1764 version, current beta 1671 works perfectly. SafetyNet checks out, all green.

I hope this adds to knowledge about the beta 1671 Magisk working g fine in this situation, and also maybe helps a few to get updated to Pie who don't use TWRP as well.

Thanks to everyone else who offered advice and gave assistance. Feels like a family here, you all are just damn good people!
[Magisk] Artim_96:
I have a bug to report: Magisk 16.7 isn't compatible the Moto Z2 Play, while 16.4 has no problems. The phone boots up to the bootup-pin screen, then shows the "second half of bootup screen" for a few seconds and restarts right back to the warning message you get before any bootup sequence when bootloader is unlocked.

Bot updating from 16.4 and make a fresh install with 16.7 results in that error.

I got the TWRP log from the updating and a backup from the boot partition if needed and helpful. I didn't got a bootup log since I don't know how that would interfere with the bootup password (or better: the other way around) and I honestly don't remember the adb command and it's always hard to find on Google.
[Magisk] sensi277:
Magisk installs fine and modules install, but they don't seem to do anything. Viper4Android app installs, but no functions within the app work. YouTube Vanced installs but no changes are made to the YouTube app even after a reboot. Android Pie Fonts installs but the font remains Roboto after reboot. I'm on a Moto G5S Plus on Oreo 8.1. Magisk SU functions work fine. I've attached my Magisk log from the latest beta.
[Magisk] lilcdroid:
I'm also on Moto g5s Plus running Magisk 16.7 with viper4android, greenify and YouTube vanced all installed and working great. On the newest RR unofficial ROM with the updated . 118 kernel from Motorola source. I know you provided a log but just confirming that it might be more ROM specific problem but not sure what version of Magisk you were using or what Rom your on.
[Magisk] sensi277:
Like I said, I'm on the latest Magisk Beta - 16.7 (1671) - and I'm running stock Oreo 8.1 on a Moto G5S Plus. The same thing also happened when I was on 7.1.1 Nougat before I upgraded to Oreo and on the current stable release of Magisk (16.0). A clean reinstall of Magisk or complete phone wipe/reflash gives me the exact same issue.
[Magisk] fipm:
Yes, I meant flashing the stock android pie image for pixel xl to both partition A and B. Specifically, flashing the active partition, toggling the active partition, flashing again, completing the setup, and then rooting.
[Magisk] sam00561:
I found out how to take log info here goes thanks.
[Magisk] Didgeridoohan:
Everything looks perfectly normal in that log. If you have issues with a specific module, please post in the module's support thread.
[Magisk] -Happy Feet-:
Is it possible to fix this with the payback App? The App detects an unsecured device.

Already enabled in Magisk Hide.
[Magisk] paarnoutse:
Nothing shown for me. Possibly not available / not shown in Play Store at all countries?

Could you plse supply a link to that beta opt-in? Thanks!
[Magisk] luckylui:
Pics attached, you don't need to buy the Pro. I just bought it because it's only $2.00
[Magisk] whitewallman:
The opt in is at the bottom of the description in the play store.

---------- Post added at 05:41 PM ---------- Previous post was at 05:40 PM ----------

Is the pro as new as the beta? If so, I'm in.
[Magisk] martyfender:
I didn't think so either but I had to scroll WAY down the page, but it may not be in your country.
[Magisk] luckylui:
Pro is just for ad free. Should still be the same as free version though for checking what you are looking for.

---------- Post added at 16:48 ---------- Previous post was at 16:45 ----------

Magisk has to update API key to reflect the safety net pass. I can still play Pokémon GO and use my banking app since I used Magisk to hide root from them. The Root Checker apk is up to date with Googles new API key, so until Magisk gets back to work it'll fail within Magisk.
[Magisk] 19blacktiger77:
Can someone share the apk of the beta version of Root Checker??? Thank you very much!
[Magisk] rainman74:
https://developer.android.com/training/safetynet/attestation#add-api-key
[Magisk] Didgeridoohan:
This is gonna get so lost in the massive stream of off-topic, but could everyone just stop posting about SafetyNet and Play Store certification in this thread? Please. It's the beta development thread... There are other, much more suited threads available.

Let me finish by quoting a small part of the OP in regards to SafetyNet issues:
[Magisk] kittygotwet:
I'm trying to root my Pixel 2 and I'm having trouble installing v16.7. It keeps failing.

I've attached a recovery log.
[Magisk] luckylui:
Have you tried 16.0 and then updating it to 16.7 within the Magisk apk?
[Magisk] kittygotwet:
Yep tried both 16.0 and 16.7
[Magisk] luckylui:
Is your bootloader unlocked?
[Magisk] vandyman:
The only way to get my Pixel 2 was to make a patched_boot.img

Try it....
[Magisk] SacredDeviL666:
Sorry for the extensive cleaning !!!

Way too many offtopic posts and nothing related to Beta App.

a) Play store ceritifcation keep it out of this thread

b) Safetynet passes good for you if not suggest a method to pass

c) You want to discuss possible methods take it to Magisk General Thread

d) This thread is for troubleshooting Magisk Beta App with relevant logs only!

Any deviation from above i will start out with warnings without further heads up as it has been mentioned more than zillion times in thread!!!!

Thanks for the attention, now you all can get back to sipping those beers, margaritas or just water :p

Thanks

SacredDeviL666

Forum Moderator.
[Magisk] dethknite:
I had some partition issues and after flashing anything it seems the system and vendor mounts are removed. The fix for me was remounting them before flashing. Verify in TWRP under Mount that the System and Vendor and Data are checked before trying to flash.
[Magisk] Artim_96:
... That doesn't sound like it could make any sense. The point of Magisk is that /system and /vendor aren't mounted/changed.
[Magisk] sToRm//:
The point of Magisk is to not change the system or vendor partition, yes. But the recovery and maybe Magisk installer is using functions in system libraries/binaries. So if the partition is not mounted, flashing would not work, because some needed functions are not declared.
[Magisk] Artim_96:
But then the direct update from within the manager should work...

I'll try now and report back in a few minutes

Edit: as expected, did not work. I let TWRP mount /system as ro prior to flashing (my device has no vendor partition), still same bootloop
[Magisk] theofruitrouge:
Can't install apk with magisk installed (LOS 15.1)

With Magisk installed on Lineage 15.1, I can't install any apk (apps can still be installed via F-droid privileged extension).

magisk.log (16.7) : ghostbin.com /paste/7xq6c

magisk.log (16.0) : ghostbin.com/paste/nkmb5

I can't see any problem. I previously used Magisk under CarbonROM (AOSP 8.1 aswell) without problem...
[Magisk] FlavioV:
It happens on some Oreo roms. Turn off Magisk hide on the manager settings and reboot.

Once you're back to system you can turn Magisk hide back on (to pass SafetyNet) and it won't affect your ability to install apps again, at least not until the next reboot.
[Magisk] RenaKunisaki:
It fails to patch the boot.img for Android 9 on Essential PH-1:

- Copying image locally

- Target image: /data/user_de/0/com.topjohnwu.magisk/install/boot.img

- Device platform: arm64-v8a

- Extracting files

- Boot image is signed with AVB 1.0

Bad system call

Failed!

! Installation failed

My boot.img is in /storage/emulated/0/.
[Magisk] apophis9283:
Just report the post if things start getting bad. They will get looked at and posts cleaned if need be.

This is a proactive post, politely asking people to read the OP before posting. Also using the search function is a great way to see if your question has already been answered.

Thank you

apophis9283
[Magisk] spleenandcigars:
I own a Pixel XL updated to the latest Android P by flashing the firmware from Google. While in Android O, every module and root was working fine. In Android P, even with the bootloader unlocked, i can't get Magisk installed. I tried:

- Installing Magisk Manager

- Flashing the 16.7v via TWRP

- wiping Dalvik/Cache

- Rebooting

and only:

- Flashing 16.7v via TWRP

- rebooting

It gets stuck at boot for a minute and reboots into recovery. If i flash the uninstaller, everything works fine again. I'm uploading the only two logs i could find at my storage (TWRP > Advanced > Copy log). Is there a way to make it work?
[Magisk] fipm:
I had the same problem on my pixel xl. For me the solution was to flash the stock image to both slots A/B and only then completing the setup of the active slot and rooting.
[Magisk] Didgeridoohan:
[MENTION=9383599]Snowpuppy[/MENTION] [MENTION=5563377]spleenandcigars[/MENTION]

Your problems are likely caused by sepolicy timing issues at boot. This has been fixed and will be in the next release.