yashsingh1/xdaforums huggingface dataset:
[Magisk] tmviet:
How I disable upgrade on magisk ?

I' ve install v.13.6 but magisk see that there is an upgrade 13.3 ?

I've already disabled the upgrade in settings magisk
[Magisk] Denkai:
13.3 is the latest stable release. 13.6 is simply a Beta.
[Magisk] tmviet:
OK so I can disable that magisk remember upgrade ?
[Magisk] Timmmmaaahh!:
If it's really bothering you so much, you should revert to the stable build and quit the beta. This thread is for bug reporting only and that is not a bug.
[Magisk] teddy0209:
It works even on MIUI 9...
[Magisk] ghbuur:
try the module universal safetynet fix from magisk. helped me to pass without ticking anything in magisk hide ;)
[Magisk] cd993:
Thanks for the response.

I had tried that without success, though I changed to a different rom (which has the same baseband) and this works without any intervention.
[Magisk] eried1:
Is it safe to try 5.2.0 version of the manager? I notice it hasn't been linked...
[Magisk] guest4711:
yes. But it should be installed with magisk13.6 If not, you'll find it in the zipfile in folder common.
[Magisk] andriana936:
Hello dev,

I'm unable to keep systemless host toggle always ON. it always revert back to OFF everytime I relaunch Magisk.

And sadly the hosts file seems doesn't works.

I block Facebook but I can ping it and get response.
[Magisk] gothicVI:
Post a log...

You're aware that a screen shot of the log is not a log are you?

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] matt4321:
Blocking it in hosts only prevents incoming connections from what I understand. This is how it would block ads. But outgoing connections (like a ping) will connect. Hosts file doesn't act like a firewall
[Magisk] ceanth:
Did you resolve this? I am getting the same error and also can only find the instant app icon
[Magisk] cd993:
Unfortunately not. My only resolution came from changing ROMs and despite being the same baseband, it worked right out of the box without any further intervention
[Magisk] ShadySquirrel:
Sorry to sound rude, but you have no clue how wrong you are.

Add 127.0.0.1 google.com to a hostlist and see whst happens when you try to access it :)
[Magisk] beardymarrow:
Hi, it's the opposite. Hosts file only impacts outbound connections (strictly speaking it impacts the name resolution). Outbound connections to ip addresses (not names) are not affected and nor are inbound connections.

---------- Post added at 10:31 AM ---------- Previous post was at 10:28 AM ----------

Putting "sorry to sound rude" doesn't make the rest of it polite. It's the same as when people say "no offence, but..." and then proceed to be offensive. :)
[Magisk] ceanth:
:(

I'm using oxygen os 4.1.7 and don't really want to change ROMs

Anybody else got any advice or tips?
[Magisk] davidk21770:
The hosts file shortcuts name resolution - in and out. But if the ip is specified numerically, no name resolution occurs and the connection is made. This is why hosts is not a perfect solution to keeping out undesired content. I'm guessing that facebook tries the numeric ip if name lookup fails - to circumvent hosts blocking of their ads/data mining.
[Magisk] beardymarrow:
Yes, that's what I just said :) (except I disagree with the "in and out"). It's just used for name resolution so that only impacts outbound.
[Magisk] Didgeridoohan:
Magisk v13.6(1360) works perfectly fine on OxygenOS 4.1.7.
[Magisk] ceanth:
It didn't work for me. I can try again though....I had 13.3 before so I uninstalled it via script first. Is that the correct process?

Do I need to enable any specific settings or options apart from magisk hide?
[Magisk] Didgeridoohan:
Only thing if upgrading from v13.3 without first uninstalling is that you'd have to clear data for the Manager to reload the integrated busybox (reboot button on the flashing screen won't work otherwise, for example).

If you need help with SafetyNet you're in the wrong place, since SafetyNet discussion is prohibited in this thread.

Take a look in the troubleshooting guide for things to try. Most of it applies to the beta as well.
[Magisk] ceanth:
Thanks. I read through the troubleshooting guide and was able to resolve the issues i had (Xposed being installed).

Working well now :)

---------- Post added at 02:26 PM ---------- Previous post was at 01:47 PM ----------

Now that I have this working I did spot something. Im sure on the previous version there was a Super user section in the Magisk app which allowed me to control which apps have root permissions. I do not see this option anymore.

How do I see which applications have been granted Root access in Magisk?
[Magisk] dugi9991:
Enter Magisk - Side menu with three lines - tap on #Superuser - that's it.
[Magisk] matt4321:
Hence why I said from what I understand. I know I'm never always correct about everything, thanks for clearing things up though

Thanks for clarifying, as said above I'm aware I'm not always right. Thanks for correcting me in a slightly more polite way ;)
[Magisk] ceanth:
It's not there:
[Magisk] dugi9991:
That's the older version? I'm not sure for the older version as I'm currently on 5.2.0
[Magisk] ceanth:
Nope, it's 5.2.0 which was bundled in with the .zip file

---------- Post added at 05:55 PM ---------- Previous post was at 05:51 PM ----------

I installed 5.1.1 and super user now appears there.
[Magisk] jolev:
Hello! I have tested 13.6 and 13.3 and yet got the CTS warnings, i just realized that magisk hide is not working properly i checked it with the root checker app, what else can i do? My phone is a huawei p9 lite vns-l53 c69* thanks to anyone who can help me/give hints about this!

Edit: i have seen those screenshots where there are more options in settings than mine, busybox and that stuff, i can't see those in 13.6 neither on 13.3
[Magisk] Didgeridoohan:
Did you try clearing data for the Manager?
[Magisk] ceanth:
I think I did but can't remember now lol.

I'll probably just leave it as it is now that it's all working
[Magisk] chudy_85:
Correct I must restart using power button.

On v13.3 I use magisk reboot and work correctly
[Magisk] Artim_96:
Then upload your Magisk logs, they should record such an error. Just try the reboot through Magisk, wait a few seconds and then go to logs and save them, that should make sure everything is recorded
[Magisk] ShadySquirrel:
Non-native english speaker, that sentence sounds really innocent in my language, sorry again if I sounded harsh. Cheers.
[Magisk] matt4321:
Hey don't worry it about! No offence was taken by it :)
[Magisk] gothicVI:
You quoted the full op which is unnecessary and not well received since it clutters the thread. Furthermore, you should have read it since it clearly mentions no discussion about sn.

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] Didgeridoohan:
Known issue (https://xdaforums.com/showpost.php?p=73622082&postcount=3136).

Clear data for the Manager.
[Magisk] Didgeridoohan:
Completely the wrong thread for this enquiry. Go here instead. Or better yet, your device's forum...
[Magisk] bill_kevin:
Loosing root randomly
[Magisk] officiallyme:
Sorry, I thought this thread was that thread, i.e. this was the thread to ask questions like this. I was relinked here from the original (stable) thread.

The device forum unfortunately does not quite seem to have the answers I am looking for ;)

Think S6 developement never fully took off. Not like S2 etc did. Probably due to the rooting issues....
[Magisk] westeight:
Nothing to do with Magisk.

The latest Barclays update (29th August) is a POS. See the comments on the Google Play Store about it hanging on the Splash Screen.

Uninstall it and revert to the previous version.
[Magisk] jas0npc:
Many thanks, Where can i get a previous version.
[Magisk] DenyDarko:
I'm offtopic here but personally I wouldn't install a banking app outside the official store. Under any circumstances.

Wanna take the risk of a modified app that sends credentials?

Wait for an update and use the website till then. You'll live.
[Magisk] FlavioV:
APK Mirror is your friend, they only host legit APK's https://www.apkmirror.com/apk/barclays-bank-plc/barclays-mobile-banking/

Or like [MENTION=2641771]DenyDarko[/MENTION] said just stick to the mobile site by now ;)
[Magisk] demonoidmaster:
You must be new to the internet lol

There's many places where you can get archived apks, most popular is apkmirror like Flavio said, they don't host shady stuff nor do they host paid apps nor host modified apks.
[Magisk] foxsprout:
[MENTION=4470081]topjohnwu[/MENTION] I got FCs when clicking "Superuser" tab in latest Magisk Manager. It happened back in latest official, but the difference is su is working in latest beta (13.6) while su wasn't working in latest official (13.3).

P.S. I installed 13.6 beta using uninstaller first, then install. Also, I can't seem to upload logcat here using XDA Labs app, but here's the link:

https://drive.google.com/file/d/0B1l6m5mE0UEZOTFlVWE3OHdVcHM/view?usp=drivesdk
[Magisk] westwood24:
Clear Data in settings/general/apps/magisk manager solved the problem
[Magisk] foxsprout:
That... Actually works! Thanks! But I do remember in 13.3 I lost root when I did that. Probably me.
[Magisk] Mcdan333:
FYI - I just tried installing Magisk 13.6 on my ASUS TF300T running KatKiss - Nougatella #025 (Android 7.1.2). The install script function find_boot_image() failed to return the boot partition. Installing 13.3 works correctly.

The boot partition on the TF300T is defined in /etc/recovery.fstab as '/dev/block/mmcblk0p10'. If I hard-code that return value into the find_boot_image() function, Magisk 13.6 installs just fine (although SN check never finishes).

Gotta run now. Will debug more later.
[Magisk] DenyDarko:
https://github.com/topjohnwu/MagiskManager/commit/f07e7571aba1946db16fe770ff8531243c7f6201
[Magisk] kingbor1cua:
I have Moto g5plus I can't install magisk it faios multiple times .any help will be great thank.
[Magisk] guest4711:
It looks like an incompatible old magisk image:

- /data/magisk.img detected!
- Mounting /data/magisk.img to /magisk
! Magisk image mount failed...

Boot into TWRP and rename /data/magisk.img into /data/magisk.img.old

Then try to flash magisk again and report your results.
[Magisk] kingbor1cua:
This is what I see when I go into file manager under twrp /data/magisk. I don't see what you mentioned . also I'm not sure how to do this ii have never had to anything in twrp except flash roms and wipe
[Magisk] guest4711:
No, /data/magisk.img is mentioned in your log. Your looking into /data/magisk/

Please look one folder up into /data/
[Magisk] kingbor1cua:
okay i did and found it an i got the same error
[Magisk] Diomorgan:
sorry, I mean that flashing xperia z4 tab with *******. 160 firmware through twrp flash magisk and magisk manager apparently without problem, but in the magisc manager there is no root option, so I had to install latest SU too. Actually googling seems a common problem with xperia z4 tab. if you have version to let me test I can unroot, clean magisk and try again otherwise I'll whaait, is not vital on a tablet. thank you for your great job!
[Magisk] zixxorb:
So tried to install this and keep getting error about a modified boot image. I followed this guide to root my Samsung Galaxy j3 emerge : https://xdaforums.com/android/help/guide-painless-root-samsung-j3-emerge-t3573551

Any help would be great.

Also sorry if wrong thread but posted here cuz I tried the beta
[Magisk] guest4711:
Strange. Please rename/remove the img, try to flash and post the log.
[Magisk] Didgeridoohan:
See a couple of posts above. It's solved...
[Magisk] Artim_96:
If it's a common problem, head over to his GitHub site and see if somebody already created an issue. If not create it yourself and help to find the problem. Otherwise I can just tell you to ask in your devices forum
[Magisk] manos78:
Hi,

I want to comment the same behaviour detected (and described the causes) by yunzo at:

http://xdaforums.com/showpost.php?p=73238596&postcount=17626

My environment:

- Moto G5+ with 7.0 STOCK (pure Stock, nothing touched!)

- Installed: TWRP and ElementalX, so the only changes are "recovery" and "boot" partitions.

- Tested with Magisk v13.6 Beta and v13.3 Release: same behaviour.

The symptom is:

- Magisk works for "su", however it's impossible to run any module. All the time, in the Magisk log you see:

"mount /dev/block/loop1->/dev/source failed with 13: Permission denied"

Please, can you fix this?

Thank you!
[Magisk] nugroho2:
Just to report that I could install Magisk 13.6 to my Redmi 4x, with Miui 9, 7.8.31, Android Nougat 7.1...

I use TWRP Cofface and Xposed 87 sdk24 by solarwarez. All installed properly.

Thanks so much, John.
[Magisk] manos78:
Hi,

The cause of the problem seems to be some miss-implementation in the "f2fs" code of the Android kernel.

See here the description of the problem:

http://github.com/topjohnwu/Magisk/issues/312

http://github.com/topjohnwu/Magisk/issues/333

So, as the problems seems to be that Magisk can't mount the loop partion in a directory inside a f2fs filesystem ( /data in that case), I suggest a simple modification: Include the option to mount the "magisk.img" in a custom path. This will enable the option for mounting in a subdirectory in a different partition (for example the "/oem", if it has ext4 format).

You agree?
[Magisk] psndna88:
it was long ago fixed by arter97 and needed to revert some f2fs commit

supersu had faced it
[Magisk] manos78:
Hi,

Thank you for your response! However, I don't use at all "supersu", as I prefer at time MagiskSU. And the problem is with Magisk. I'm running the ElementalX kernel for Stock (v1.01 for Moto G5+). So my suggestion it's to provide "generic" support in Magisk as more devices will implement f2fs and then more devices can fail.

Please, can you point me to the fix from arter97?

Thank you!
[Magisk] tag68:
No, afaik these are different things.

The original f2fs bug was fixed by Motorola some time ago. Before you couldn't install Magisk, because the loopback device was not working at all.

The current bug on Moto devices lets you install Magisk fine. But the resulting loopback device gets read-only. So you are not able to install modules or use Magisk hide.

I'm not aware that anyone solved this problem by now without using a different partition.
[Magisk] Didgeridoohan:
I believe it isn't an issue with Magisk, but with the faulty implementation of f2fs on your device/kernel.

The fix talked about can be found here:

https://xdaforums.com/showpost.php?p=70492947&postcount=8793 Edit: but as noted above, it might not be relevant for this case... If Moto fixed it and introduced another bug.
[Magisk] filiphch:
Me too, i'm using Lineage OS on Mi5 with stock kernel with f2fs and getting this ''can't mount'' problem... ?
[Magisk] Artim_96:
Well, if the problem is a faulty F2FS implementation just ask them to fix that bug
[Magisk] drocny87:
is there a video tutorial on how to root with ADB and no recovery?
[Magisk] Strephon Alkhalikoi:
No, because as far as I recall Magisk requires a recovery. If you're rooting without a recovery you're likely using Kingoroot, which a) is a piece of garbage and b) is beyond the scope of this thread.
[Magisk] Didgeridoohan:
Not that I know of. There are instructions for the current implementation of this feature in the release thread (but I guess you've seen those already). There's a lot of work to refine that feature though and it's becoming a lot easier. Wait...

Since v13.6 beta you can install Magisk without a custom recovery.
[Magisk] :
DELETED. (For anyone curious about non custom recovery installation, I can guarantee it won't work on Samsung devices as we have download mode and not fastboot, so flashing boot images via fastboot won't work :( ).
[Magisk] Didgeridoohan:
I believe you can convert the boot.img file to an Odin-flashable file...

Anyway, that's also being worked on. :good:
[Magisk] :
That's what I was attempting to do but then I remembered my GS7 rejects any boot image that's unsigned by Samsung, so decompiling the AP file, modding the boot image, and recompiling it and flashing via Odin would most likely fail.
[Magisk] Artim_96:
Signed by Samsung or just signed? Because then you wouldn't be able to use Magisk or supersu at all.
[Magisk] revanmj:
It seems Visa SDK for HCE does not like Magisk 13.6 (or FK) - when trying to get into my bank's HCE settings, it crashes with this exception:

com.visa.cbp.sdk.facade.exception.RootDetectException: SDK not usable. Unknown error
[Magisk] manos78:
Yes, man! You're right. The problem is very simple: because a bug in the kernel sources it's impossible to mount any loopback device over a path in a filesystem formated with f2fs.

You're right again! However, a lot of devices have this "faulty" implementation. Futhermore, in the future will be possible that new incompatibilities will be found. So my suggestion is quite simple: include in Magish support for a custom path for the loop mount. With this simple technique will be possible, for example, to mount in another partition formated with ext4, vfat or squashfs (as you prefer). Or also be possible to "hide" the mount point over a very obscure path.

The idea can solve a lot of problems! So, why not implement it?

Regards.
[Magisk] Didgeridoohan:
Oh yeah... Not saying anything about not implementing it. :D Was just trying to clarify. :good:

We'll have to wait and see if [MENTION=4470081]topjohnwu[/MENTION] decides to implement a workaround solution.
[Magisk] manos78:
This is the idea! :good:

I'm only suggesting this simple idea if [MENTION=4470081]topjohnwu[/MENTION] wants to implement it.

:highfive:
[Magisk] demonoidmaster:
You can install magisk via adb on a pc... Didn't you know?
[Magisk] Strephon Alkhalikoi:
*arches eyebrow* What part of "as far as I recall" wasn't understood?
[Magisk] :
Signed by Samsung. People have tried modifying the Snapdragon 820 boot image and it refused to boot because of Qualcomm secure boot, which stops the phone from booting when a non Samsung boot image is flashed.
[Magisk] Artim_96:
Depends if you have the SD variant of the Exynos one. Since the S6 the SD variants are US only and the is carriers let Samsung lock the bootloaders completely. So you would need to find out how supersu and Magisk install on them and try reproduce that
[Magisk] lastmoonchild:
Is there a way to ROOT the s8+ snapdragon version Canada sm g955w with no computer all?
[Magisk] Artim_96:
No, and there probably will never be any unless King oot out something similar finds an exit l exploit.

Either way, that had absolutely nothing to do with Magisk, even less with Magisk beta. That belongs to your devices forum dive it's a device specific question
[Magisk] :
Which is why I mentioned specifically that it was a snapdragon device. We have rooted the SD s7's using an engineering boot image and a supersu script, but magisk wouldn't work as it would mod the boot image.
[Magisk] Artim_96:
Then you have your answer. As long as nobody modifies that method to install Magisk, there is no way at all to install Magisk
[Magisk] AndroidDeveloperLB:
To OP, the creator of Magisk:

Can you please consider auto-check for updates and auto-updating ?

Also, is there a way to avoid re-flashing of the kernel after flashing Magisk ? I was surprised to see the kernel got back to the original one...
[Magisk] Jenanga:
Seriously? Wrong thread
[Magisk] drocny87:
I am interested in rooting using the adb method w/ no custom recovery. I am aware i need the stock boot img/ dump. How would one obtain that file off the device if you are not rooted nor have a custom recovery installed?
[Magisk] Strephon Alkhalikoi:
I can't speak for [MENTION=4470081]topjohnwu[/MENTION], but automatic checks for updates should be possible. Automatic updating however isn't something I feel he should implement. Doing so can cause issues, which is possibly why the "competition" doesn't do it.

Regarding your last question, you have a non sequitur there. In other words, what you're saying isn't making sense, so please elaborate.
[Magisk] badlipe:
Thanks for the hard work on magisk, topjohnwu. I have just tried the new version (1777d9f) and safetynet is not passing the checks. Not complaining, just reporting that on previous beta (0b4baad) it was working. BTW, I'm using oneplus 3T with beta 8 stock OS.

There is any way I can help? Not an expert in Android, I don't know where to find logs or anything similar for magisk.

Edit: after a restart, safetynet checks are OK again.
[Magisk] Ansuel:
same with new version galaxy s8
[Magisk] topjohnwu:
May you open META-INF/com/google/android/update-binary with a text editor, remove line 201

export PATH=/system/bin:/system/xbin:/vendor/bin:$PATH <---- remove this line

And re-zip and flash again? Thanks!
[Magisk] Didgeridoohan:
No luck.
[Magisk] Ansuel:
same? want the log ?
[Magisk] JonathanRAZ:
[MENTION=4470081]topjohnwu[/MENTION] so i tryed via twrp it stays on mounting vendor forever but installing it as a module on v12 magisk it did install it and all working perfectly

Note 5 tmo latest EQE1 stock boot img

UPDATE:Safety net failing after 5 minutes or less

UPDATE 2:After a reboot its ok again

UPDATE 3:Safetynet not working

UPDATE 4:Testing some stuff now its good
[Magisk] Didgeridoohan:
[MENTION=4470081]topjohnwu[/MENTION]

Yes. I can confirm that doing it like this seems to work with no issues. Can't install modules through the Manager (attaching the Magisk log), but if flashing through TWRP all modules seems to work just fine, systemless hosts works (after a reboot) and Magisk Hide works fine.
[Magisk] demonoidmaster:
Your faith in Magisk is low. It's as if you're saying "don't use Magisk to install Magisk modules, use TWRP! Even if a module says not to be installed through recovery"

If you're having issues installing stuff through Magisk then either

A) ya doing something wrong buddy

B) or the zip isn't fully downloaded right

C) or module version is borked and needs to get fixed by the dev

D) isn't compatible with your device

---------- Post added at 10:34 PM ---------- Previous post was at 10:32 PM ----------

I hope you're joking :/
[Magisk] yochananmarqos:
Please read the OP before posting.
[Magisk] demonoidmaster:
Chances are the banking app detects Magisk (the app) and not specifically that your device is rooted, snapchat does the same thing if all you have is Magisk app installed but haven't flashed the v12 zip

But then again Magisk Hide would still hide the app and root from being detected... But yknow, this is a beta so if you need your banking app use v12 and the prior apk version
[Magisk] shadavis08:
When I say stable I mean is it causing any boot loops for anyone . Not as in stable release. Geesh

---------- Post added at 11:07 PM ---------- Previous post was at 11:04 PM ----------

Dude really? Don't just read one post and make some comment. At least read the posts after to get an understanding before you get patronizing. With all due respect thank you
[Magisk] JERW28:
[MENTION=4470081]topjohnwu[/MENTION] Magisk beta 1777d9f some mods do not mount. please see details here https://github.com/topjohnwu/Magisk/issues/235