yashsingh1/xdaforums huggingface dataset:
[Magisk] DenyDarko:
I'm having an interesting (and rare based on the nonexistent reports) 100% reproducible error.

It's a RejectedExecutionException according to the runtime log.

Every single time I go to MagiskManager download section and refreshing it (to check for module updates) the app is crashing.

I'm attaching the log. It's the same output on every crash.

I'm using dnscrypt with dnssec (enforced by iptables redirection rule) to resolve DNS requests. Not sure if it's related but..

The only way to refresh the "Download" section is to first clear the repo cache. The first load after clearing the cache (and only the first) won't crash the app.

Ideas?

[MENTION=4470081]topjohnwu[/MENTION] you may want to have a look on this.
[Magisk] jenslody:
The crash was reported many times and should already be fixed in github, but John did not find the time for a new release.
[Magisk] DenyDarko:
Really?

Well that's great news.

Thanks for the feedback :)
[Magisk] flipmode_11:
Yeah, your Kernel is v3.4.0

That means your Kernal is not > v3.8.x :)

So not being 'greater than' v3.8.x means you cannot use Magisk Hide.

If you did solve it, please document the steps and share it here and in other Magisk topic so it may help others with same problem.

I don't know why Moderator is deleting posts when this is the ONLY topic for bugs and issues with Magisk.
[Magisk] Didgeridoohan:
From the OP:

For general troubleshooting issues, rather than actual bug fixing and development, please use the general support thread.
[Magisk] dev_freak:
as it didn't work out, here the log. I needed to zip it as it was too big.
[Magisk] SacredDeviL666:
Thread Cleaned again!.

Please do not post unofficial versions which isn't developed/compiled by this Dev here.

If someone wants to they can create their own thread and stay on topic including safety net discussions.

Thanks

SacredDeviL666

Forum Moderator
[Magisk] Blackdragonbird:
Thanks, got it now and installed. =)
[Magisk] driz:
Hello, I love magisk, thanks for the hard work.

I loaded up android p, removed pin, booted to twrp, flashed latest beta.

booted phone up, no magisk manager. Manually installed magisk APK using adb install

once i did this, I had root (well the ability to click grant)

I am failing the ctsProfile and basicIntegrity checks (which, i kind of expected on Android P)

magisk_debug.log below

https://pastebin.com/QR5guJN4
[Magisk] jellybean13:
Magisk Manager has stopped.

--------- beginning of crash

04-28 23:00:02.306 7226 7296 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #2

04-28 23:00:02.306 7226 7296 E AndroidRuntime: Process: com.topjohnwu.magisk, PID: 7226

04-28 23:00:02.306 7226 7296 E AndroidRuntime: java.util.ConcurrentModificationException

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at java.util.LinkedList$LinkIterator.next(LinkedList.java:124)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at java.util.LinkedList.removeOneOccurrence(LinkedList.java:835)04-28 23:00:02.306 7226 7296 E AndroidRuntime: at java.util.LinkedList.removeFirstOccurrenceImpl(LinkedList.java:830)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at java.util.LinkedList.remove(LinkedList.java:665)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos.lambda$loadJSON$1$UpdateRepos(Unknown Source)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos$$Lambda$1.run(Unknown Source)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos.lambda$queueTask$0$UpdateRepos(Unknown Source)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at com.topjohnwu.magisk.asyncs.UpdateRepos$$Lambda$0.run(Unknown Source)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)

04-28 23:00:02.306 7226 7296 E AndroidRuntime: at java.lang.Thread.run(Thread.java:818)
[Magisk] iamdip62:
I dunno why it keeps failing every damn attempt
[Magisk] jcmm11:
PSA for people that don't bother reading release notes. Before you update to 16.4 note that the post-fs stage has been removed. Mods that use this will need to be redone. Also Tasker needs an update before it can use root. New location for /cache/magisk_mount.

Read the release notes!
[Magisk] Didgeridoohan:
To clarify the Tasker thing:

Tasker can use root, unless you repackage (hide) the Magisk Manager. It relies on detecting com.topjohnwu.magisk to know if you're rooted or not.

Previously this could be worked around by using "su -c" when running Tasker shell script actions, but unfortunately not with the move to 32-bit binaries in Magisk v16.4. That's what that changelog note is about...
[Magisk] ayyyy lmao:
Is anyone else having issues with the galaxy s8? After I flash 16.4 I loose root and can't get it back no matter what, re-flashed kernel and 16.4 and nothing. Re-tried with 16.3 and everything is working fine.

I don't want to be the guy the just reports an issue and complains without providing helpful data, but I have no idea what logs I should provide to help, so if you could tell me where I should get them from, I will gladly provide them.

Thanks!
[Magisk] ayyyy lmao:
Here is the file debug file:
[Magisk] lssong99:
Just updated to 16.4 on my pixel 2 xl and as soon as some app requesting root, the system become very sluggish with CPU usage goes up to 90% constantly.

My exact situation is I have Tasker doing some initialization works after system start up which calls several root actions. As long as Tasker starts, the CPU goes to 90% and it will just keep around 90% even I stopped Tasker.

If I disable Tasker then reboot, the phone runs normal. However as I start Tasker (with all bunch of root commands) then CPU goes to 90%.

I also confirmed by issuing single su request (via mixplorer, to get the log) the CPU will go up to 90% just momentarily. However when multiple su are issued in short time, the CPU will keep at 90% for long time, I have to restart the phone.

Also, termux complained cannot find su with following error message...

CANNOT LINK EXECUTABLE "/sbin/su": "/data/data/com.termux/files/usr/lib/libtermux-exec.so" is 64-bit instead of 32-bit

Aborted

Everything works normally before 16.3. I hope above information helps....

Log is as attached..
[Magisk] bggold:
Read topjohnwu's forum and he stated he made some changes that have effected some root apps. One is Tasker and I just checked my termux and get the same. He stated that it is not a bug with magisk, but the app devs will have to fix.
[Magisk] Didgeridoohan:
Flash the zip like you would a Magisk module ("plus" button in the Modules section)...
[Magisk] MrBlubke:
ZTE nubia z17

Snapdragon 835

8gb ram

128gb

Lineageos 15.1

Magisk uninstaller ends with error 255

Magisk installer ends with error 1

I tried both from magisk manager and twrp

Currently installed is magisk 16.3 error is for installing 16.4

Manager is latest 5.7
[Magisk] akhilmaini01:
Franco KERNAL v. 3.18.102

How to confirm boot image is stock and unmodified from ROM ? And I Do have Stock Boot Image .
[Magisk] Didgeridoohan:
A screenshot is NOT a log! You need to post proper logs and much more details. But you already knew that: https://xdaforums.com/apps/magisk/able-to-update-to-16-0-t3783811

Logs for the uninstaller?

Is it possible to uninstall Magisk from the Manager? If so, you can attempt a clean install of v16.4.
[Magisk] akhilmaini01:
Here's the log detail , after this phone Goes to BOOTLOOP.

BUT MAGISK 14.0 ZIP WORK LIKE CHARM.
[Magisk] Didgeridoohan:
PSA - Don't forget what this thread is about.

Spoiler: it's logs!

This is a repost, with some minor adjustments, of an old favourite... It seems like it's needed on a more regular basis.

There's a big nice BETA tag added to the title of this thread. That means something...

It means that anyone downloading and using the software provided here are expected to help out with providing information about issues that might arise when developing Magisk and the latest beta release.

It means that there might be bugs, but that's expected, it's beta software after all...

It means that anyone having issues need to provide lots of details and relevant logs.

Just posting "it doesn't work" or "it bootloops" or "I'm going back to version xx because it works" does not help. It actually hurts development because useful and relevant posts get lost in the noise of uselessness.

And talking of logs: Logs are not supposed to be posted straight into your post... Attach it to the post, upload it somewhere and provide the link, etc.

The OP (that means Original Post for those of you that are new to all of this) of this thread has several useful tips on what kind of logs to grab and provide. The OP is always, ALWAYS a good place to start.

If you don't know how to grab a logcat, here's a link with some info, but remember that the xda search tool and a web search can get you very, very far. Always search before posting.

https://www.didgeridoohan.com/magisk/MagiskHelp

A logcat can be used for lots of purposes. Crashing apps, bootloops, etc. Please use the tools available and you'll make it so much easier for [MENTION=4470081]topjohnwu[/MENTION] to fix whatever issue you're having.

Also make sure to heed my good friend [MENTION=1205214]SacredDeviL666[/MENTION]'s great posts. They're always a good read. If you do, you won't have to deal with the embarrassment of getting your posts deleted...

What it means when the above advice isn't followed, is that your issues won't be fixed. Android is way to fractured and there are way to many manufacturers and versions for [MENTION=4470081]topjohnwu[/MENTION] and those of us trying to help him out to test all possible setups.

Help the community. You'll get all nice and fuzzy inside when that bug you properly reported about gets squashed.
[Magisk] Didgeridoohan:
[MENTION=3553183]MrBlubke[/MENTION] For future reference: https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] SacredDeviL666:
Followed by the usual cleaning again!

The reason is already stated above and in various pages of this thread!

Not a troubleshooting thread

Thanks

SacredDeviL666

Forum Moderator.
[Magisk] Ghibif:
Couple of magisk manager crashes

Nexus 6p on firehound 4.5 official with April vendor latest magisk beta and latest manager. I put the section of the log with the crash in a separate file, but included the rest of the logcat in case I missed some.
[Magisk] jcmm11:
I don't think the new bind mounts that replaced /cache/magisk_mount with /data/adb/magisk_simple happen early enough in the boot process.

Attached are the first 10 lines of Magisk debug log. You can see that the very first line is the bind mount. After boot I've verified that the file is the one I want. However during boot the boot animation I'm trying to replace is still the one that is getting displayed.

I'm guessing that this has something to do with the post-fs stage going away.
[Magisk] tdhite:
Beta 32-bit magisk exec blows up recovery installs

Hi,

logs won't be needed here, I have code to explain a bad bug in magisk going pure 32-bit.

First, presume recovery operations (fresh install over fresh, factory wiped phone).

Note this code in util_functions.sh:

api_level_arch_detect() {
API=`grep_prop ro.build.version.sdk`
ABI=`grep_prop ro.product.cpu.abi | cut -c-3`
ABI2=`grep_prop ro.product.cpu.abi2 | cut -c-3`
ABILONG=`grep_prop ro.product.cpu.abi`

ARCH=arm
ARCH32=arm
IS64BIT=false
if [ "$ABI" = "x86" ]; then ARCH=x86; ARCH32=x86; fi;
if [ "$ABI2" = "x86" ]; then ARCH=x86; ARCH32=x86; fi;
if [ "$ABILONG" = "arm64-v8a" ]; then ARCH=arm64; ARCH32=arm; IS64BIT=true; fi;
if [ "$ABILONG" = "x86_64" ]; then ARCH=x64; ARCH32=x86; IS64BIT=true; fi;
}

With TWRP on most Samsung devices (among others, I'm quite sure). this is the 'grep' of interest:

~ # grep ro.product.cpu /system/build.prop
# ro.product.cpu.abi and ro.product.cpu.abi2 are obsolete,
# use ro.product.cpu.abilist instead.
ro.product.cpu.abi=arm64-v8a
ro.product.cpu.abilist=arm64-v8a,armeabi-v7a,armeabi
ro.product.cpu.abilist32=armeabi-v7a,armeabi
ro.product.cpu.abilist64=arm64-v8a

Given this (again in util_functions.sh):

# Set library paths
$IS64BIT && LIBPFX="LD_LIBRARY_PATH=/system/lib64:/system/vendor/lib64" || LIBPFX="LD_LIBRARY_PATH=/system/lib:/system/vendor/lib"
LIB32PFX="LD_LIBRARY_PATH=/system/lib:/system/vendor/lib"

This is the result:

~ # mount /system
~ # export LD_LIBRARY_PATH=/system/lib64:/system/vendor/lib64
~ # /data/adb/magisk/magisk
CANNOT LINK EXECUTABLE "/data/adb/magisk/magisk": "/system/lib64/libsqlite.so" is 64-bit instead of 32-bit
Aborted
~ #

The point is -- while Magisk may be 32-bit only, the update-binary in modules (and who knows where else) is expecting magisk to actually work and it will not, yet silently so. Those update-binaries pull in util_functions.sh to mount the magisk.img (and create it where it does not exist).

I'll write my own fixes into the update-binary for this, but the code maintainers might want to know. At a minimum, they should remove all possible references to 64-bit shared libs (or the possibility thereof) across the module templates and where ever else such references exist.

Hope that helps folks.
[Magisk] yochananmarqos:
I suggest making a pull request if you're able to fix it.
[Magisk] sekaiacg:
[MENTION=4470081]topjohnwu[/MENTION]

Hi.

My device is Xiaomi MI5 (Gemini, MIUI9 Android version 8), ROM has deodex and patched sepolicy at the same time. It runs normally.

I installed magisk 16.4 (including 16.0-16.4), and dex2oat was not available after dalvik-cache was deleted.

I tried to fix the problem, but I failed.

As a result of：

W dex2oat: Unable to open /data/dalvik-cache/. to delete it's contents: Permission contents:

W dex2oat: Unable to open /data/dalvik-cache/arm64 to delete it's contents: Permission contents:

I uploaded some log, hoping to help.

logcat&magisk_debug.log:View attachment log.zip
[Magisk] flipmode_11:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=1205214]SacredDeviL666[/MENTION] Beta Request:

Please change a setting within Magisk Manager Beta Updates config to display the Change Log before the install / later dialogue. Once the New Update notification w/ Change Log is closed or dismissed, then prompt for Install/Later. Currently, they are overlapping one another in the wrong order.

Must give user a chance to read the Change Log within the app prior to deciding to update. e.g. 16.4 has had major changes, causing many people to have issues. Maybe the update is not even compatible w/ device?

Magisk Manager >> Background Update Check >> Prompt Update w/ Change Log >>
A) Later >> Hides Notification >> End -OR-
B) Install >> Hides Notification >> Show Update Prompt (Displays Download Zip, Direct Install, etc...).

Please consider fixing the Update Notification to advise of all Major and Minor changes, prior to the Install / Later buttons and Direct/Download buttons. Plus warn with a prompt "I have taken a full device backup [Yes] [No]".

Thanks guys for your tireless work and effort!

All the best, cheers!
[Magisk] lvbaal:
I had uninstalled Magisk 16.4 using an older uninstaller zip in TWRP (the latest uninstaller gives error 255). Then I installed 16.3 and updated through this custom channel.

So, now also on this version (jenslody's custom channel) I experience Magisk Manager FC. I attach matlog partial logcat output (filter "Magisk"). What other logs are of interest in this scenario?
[Magisk] pkgnex:
I'm having repeated Magisk Manager FC's since the 16.4 update.

Occurs when pulling down to refresh / check for updates, or when checking modules or dowloads from within the MM app.

Pixel 2 XL, stock ROM, happens on both EX or Flash kernel, no other mods.

Logs attached.
[Magisk] SonOfTheRain:
I managed to install Magisk via patching recovery_ramdisk.

Latest version of Magisk Manager keeps closing

Busybox looks not installed although it is.

Safetynet fails.

Huawei Mate9 Oreo 8.0.0.366 C432
[Magisk] Jleoz:
This issue has not gone away with the new 16.4 Beta.

Attached are the debug logs. It is a pain to have to restart every day for it to work.

Could someone please have a look at the log and see if it something with my phone or an error with Magisk (sorry not a developer and don't understand most of what is outputted)?

Cheers,

Jleoz.
[Magisk] SacredDeviL666:
Thread cleaned and moved few posts to https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/page2465 including the documentation change in magisk troubleshooting guide and unofficial build.

As mentioned earlier please do not post unofficial builds here this thread isn't for that, we know you are trying to help out but please create a thread or post it in general magisk thread.

Thanks

SacredDeviL666

Forum Moderator
[Magisk] repulse:
When trying to uninstall magisk with uninstaller zip provided in first post, i'm getting error 1 or 255. Same thing if trying to flash magisk 16.3 right after. What should i do ?

OP5T latest Official OOS (Oreo 8.1) & Codeworkx TWRP
[Magisk] gothicVI:
Please share the twrp log.

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] repulse:
Here you go !
[Magisk] gothicVI:
I don't see the root cause...

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] repulse:
So what could be the problem ?
[Magisk] repulse:
Facing same problem when trying to uninstall. What uninstaller did you used ?
[Magisk] lvbaal:
I used version 20180328 from this thread https://github.com/topjohnwu/Magisk/releases
[Magisk] repulse:
Worked perfectly for me, thanks !
[Magisk] manthes:
I want to install magisk to mxq pro+ tv box with twrp 3.0.2 but installation failed so i tried to patch boot.img from magisk manager and i have this log.

Can you help me?

- Device platform: armeabi-v7a

- Extracting files

- Patch boot/ramdisk image: /dev/block/boot

- Unpacking boot image

MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool

Parsing boot image: [/data/data/com.topjohnwu.magisk/install/boot.img]

KERNEL [7288605]

RAMDISK [2708368]

SECOND [33113]

EXTRA [0]

PAGESIZE [2048]

NAME []

CMDLINE []

CHECKSUM [26d2fde4a48b30dd17c6b9ea4f22d850083dc9cc]

KERNEL_FMT [lzop]

RAMDISK_FMT [raw]

MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool

Loading cpio: [ramdisk.cpio]

bad cpio header

- Checking ramdisk status

- Magisk patched image detected

MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool

Loading cpio: [ramdisk.cpio]

bad cpio header

- Patching ramdisk

MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool

Loading cpio: [ramdisk.cpio]

bad cpio header

MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool

MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool

- Repacking boot image

MagiskBoot v16.4(1642) (by topjohnwu) - Boot Image Modification Tool

Parsing boot image: [/data/data/com.topjohnwu.magisk/install/boot.img]

KERNEL [7288605]

RAMDISK [2708368]

SECOND [33113]

EXTRA [0]

PAGESIZE [2048]

NAME []

CMDLINE []

CHECKSUM [26d2fde4a48b30dd17c6b9ea4f22d850083dc9cc]

KERNEL_FMT [lzop]

RAMDISK_FMT [raw]

Repack to boot image: [new-boot.img]

! Unable to repack boot image!

Segmentation fault

Failed!

! Installation failed
[Magisk] dcop7:
Hello,

I have a problem with I believe is with magisk. I have a oneplus 3t and I used the last versions of magisk and still this happens to me. I usually have a custom kernel. So, I flashed OOS stock rom, flash the custom kernel and then magisk (is case of Franco kernel). In case of elementalx kernel, I flashed the kernel last.

My problem is when it boots (I have my device decrypted), it stuck at bootloop. After about 10 to 15 min I force shutdown and restarted the phone. It shows that the encryption was unsuccessful. I need to format everything (format user data). This happens with ext4 and f2fs partitions. I couldn't get logs as there is no error flashing magisk and since the phone was unsuccessful encrypted, I couldn't extract logs.

I don't expect for this to be fixed since I couldn't provide any logs. I think is is magisk because others have the same kernel without problems. Maybe the flag that disables the force encryption have some problem in OP3T . I've tried other kernels. I search and I saw other posts with other devices with the same problem. I'm just sharing my experience.
[Magisk] wartomato:
Ever tried to just bootup by flashing oos stock only and then applying kernel or/and Magisk afterwards? - helps on other devices...
[Magisk] dcop7:
No, I didn't. I will try it when I can. But it is strange, the first time I flash it, it worked without problems. Just to resume, I format user data, flash stock oos rom, Franco kernel then magisk, it worked. If I reflash the rom, then the kernel, then magisk, it try to encrypt the device
[Magisk] wartomato:
Yes, like I said, OOS will always try that, if you don't flash the noverity zip. But that has nothing to do with Magisk. Magisk grabs the encryption out unencrypted data best on a separate install after the ROM.
[Magisk] siealex:
It started encrypting the whole phone, this process can take up to 12 hours.
[Magisk] NLBeev:
There's is a possibility that your problem is not a bootloop, because you decrypted the data.

When you have flashed a rom with a kernel that forces encryption, and you didn't flash Magisk directly after the rom, the device is starting an encryption process when booted. That may take very long time.
[Magisk] dcop7:
But I always flash magisk before I booted the system.
[Magisk] dcop7:
I think I found out the issue. Magisk isn't patching the "fstab.qcom" file in "/system/vendor/etc".

I just compared the stock "fstab.qcom" with the file after flashing magisk, it is the same. After, I flashed "Force_Encryption_Disabler_For_OOS_Oreo.zip_v2.zip" that flashes the force encryption disabler (this I know that does disable the force encryption, and the file "fstab.qcom" result is different.

So, there is somekind of problem with magisk paching "fstab.qcom" file. I've attached all the "fstab.qcom" files after each step and the recovery.log:

STOCK_fstab.qcom.txt -> right after flashing stock OOS ROM

MAGISK_fstab.qcom.txt -> right after flashing magisk v16.4

FORCE_DISABLE_fstab.qcom.txt -> right after flashing "Force_Encryption_Disabler_For_OOS_Oreo.zip_v2.zip"

Hope this will help fixing this issue.
[Magisk] martyfender:
On my Intel devices the fstab files are in root and not in /system/vendor/etc.

Both the fstab and fstab device name (fstab.NXM882CAP) file are patched with formattable, encryptable=. In the past, when I did this in Android Image Kitchen, myself, I did this in the fstab file only with: formattable, encryptable= and disabled dm_verity in the fstab device name file (fstab.NXM882CAP) by removing the verify line in the file.

So, as you state, and what I see in your files, Magisk is not patching your boot.img properly. Do you also have the fstab file and is it patched there With: with: formattable, encryptable=?

In addition, you don't by chance have the "preserve force encryption" box checked in Magisk Manager, do you?

Finally, does this also happen in older versions of Magisk, as well?

Also, on my devices, I had to format data and cache in TWRP, to remove the encrypted data partition and create a new, unencrypted data partition. Of course, I did that months ago, before I ever even used Magisk, when I used SuperSU.

Hopefully, someone more knowledge than me will comment on this.
[Magisk] dcop7:
I don't have that box checked. I've tried a few hours ago and the only thing different was that file I've mention and I didn't have any problem. Also, I think up until around version 14.3 I had no problems. Only the newer versions.