yashsingh1/xdaforums huggingface dataset:
[Magisk] dr.ketan:
UI freeze and reboot with Magisk 6.5+

[MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] [MENTION=4667597]Didgeridoohan[/MENTION]

Regarding my previous reports here and here (My device SM-N950F running Oreo)

I have investigate further as because of this bug I was not able to include newer version to my ROMs as lots of users getting UI hang.

Exact symptoms with this bug

- Foreground app gets hang with msg like " xyz App not responding wait or close" none option will work and ultimately device reboots with lag

- Can be fix with force reboot with vol down + power

This typically started since unofficial versions 6.5* and also with Beta 16.6 and 16.7

When it remained same on Beta then thought to have look and to provide log, so did it couple of days ago.

Now on 16.6 change log I have read that new mechanism introduced to fix losing root issue on certain device (multiple zygote server running) and I believe this error started with same. Looking further and spared few days I found that this happens at certain period of time only.

After this look closely and found that If any shell script (probably which needs mounted partition) when magisk reloads (newer magisk gives sound and visual notification) giving this UI freeze error

To reproduce this and get more idea, I have wrote a simple app that executes script every 10 sec and give toat msg every time when it executes scripts, and found that if script runs during from magisk reload to next 20 second, this will give the error

I have tried more than 10 times and 100 % I was able to reproduce it in same manner

So my request is does this happens with new mechanism? If so, can that can be changed to fix this ?

Meanwhile workaround to other ROM makers/Users wh are facing same issue

- Avoid running any root required app in first minute of reboot if that app runs script like above said

- If you have any app running script after device reboot (mostly I have seen with ROM Control) then add sleep 50 command before executing script so it will safely executed after magisk launch. If you have this app as system app then recommend to add sleep 60 (system app reloads bit faster)

With above changes I made, all my test users now running magisk 16.7 without any issue now

Sharing here as I have already wasted lots of time in this and hopefully this may help other users facing same issue.
[Magisk] kwanice:
Thanks for your investigation!

But what type of app ? Running command?

Tasker is included?

Or if I run an app asking for root access during the 1st minute of booting?

Thanks !
[Magisk] dr.ketan:
yes tasker was included and command was simple cp /path /path

simple root asking won't cause issue
[Magisk] kwanice:
Thanks

Tasker : only shell command? If I change settings or else (4g, open app, rotation etc...), it's ok, right?
[Magisk] Didgeridoohan:
[MENTION=4470081]topjohnwu[/MENTION] rewrote the boot procedure yesterday.

https://github.com/topjohnwu/Magisk/commit/6263d684d9f81ff7ae015dee9eea5d43deabd488

Could you try against that?
[Magisk] Dieter00:
I'm running vcustom version of Magisk from the LOS 15 thread. Do I have to uninstall this unofficial version first?
[Magisk] dr.ketan:
still same.
[Magisk] sunil1304:
Install the latest magisk manager..go to settings..change update channel to beta.

You will be prompted..choose to flash automatically..it will self flash after downloading and reboot..hope this helps
[Magisk] Mahmoud94younis:
Hello

I'm running LineageOS 15.1 on my Moto G5 Cedric

Can anyone give a link of magisk zip file to root my Oreo 8.1 phone

Moto g5 . lineageOS 15.1 oreo 8.1
[Magisk] Terrigible:
First post
[Magisk] topjohnwu:
What do you mean by "Magisk Reloads"? Is it Magisk Manager running its boot operations, or do you mean something else?

Execute what script? And what toast message are you saying, is it from your app, or toast message from Magisk Manager to notify root requests?

I don't really understand what you are reporting. I understand that English is not many people's primary language (me too! I'm Taiwanese), but the report you created give me more confusions than what it delivered.

I'm really grateful for your reports though, please address the questions I quoted above, thanks!
[Magisk] dr.ketan:
Sorry for misunderstanding or not being clear

1.yes I mean when magisk manager launch (giving notification)

2. Toast msg I have described was from my app and that was made just to know what exact time this happens because it was happening everytime just after few seconds of reboot with my test app

In sort my finding is

If an application running a shell command script with root access, for example "cp -f /source /destination"

And timing of script execution is anytime after nearly 20 seconds of magiak manager launch (when magisk manager gives notification after reboot) (For example if I receive magisk manager notification at time 00.00.01 and script execute anytime between 00.00.01 to 00.00.20 ) then this gives UI freeze and device simply hangs and reboots

Hope this should make clear.
[Magisk] bggold:
Try and hook up to a PC and get a logcat while reproducing. That might help troubleshoot since the very end should show the failure at the time of reboot.
[Magisk] dr.ketan:
Previous page firstly post already have link to logs
[Magisk] jbradshw:
I'm not sure if this warrants logs or not (and if so, which ones?), but after moving up from 16.4 on every update that's come out (16.6 through the latest 16.7 with 5.8.3 (129)), when I launch the Magisk app, it always opens up with default settings. Everything is working fine (root works, modules all work), but I always have to go in and make changes in the Magisk settings (like switch from stable to beta). I've tried clearing cache, app data, and reinstalling the app to no avail. Once I make the changes, if I force close the app, it loses them.

Minor issue but figured I would see if anyone else might have a quick fix for this. Magisk log shows nothing when I alter these settings.
[Magisk] E-Turbo:
I have some issues with other version of magisk and the forum don't let me post it...
[Magisk] Pkt_Lnt:
https://xdaforums.com/showpost.php?p=77134417&postcount=26014
[Magisk] BunnyPig:
How do I rollback to 16.6? Safetynet doesn't pass with the new update and I can't find a way to downgrade, or do I have to download the previous version from some other site?
[Magisk] martyfender:
You should be able to flash 16.6 in twrp. 16.6 is in the github repository.

https://github.com/topjohnwu/Magisk/releases
[Magisk] BunnyPig:
Thank you my man!
[Magisk] Dieter00:
Automatic didn't work, but uninstall and install v16.7 in recovery worked
[Magisk] Charles IV:
I'm not sure if you are aware, but the addon.d-v2 in 16.6 appears not to be working as magisk 16.6 did not survive the lineageos ota update for me.
[Magisk] ZidanBlaster:
Is anyone having issue install module on magisk 16.7 using recovery

I got install failed and then all module is gone after restart
[Magisk] mr._.nobody:
Some modules working,others not

So I've tested v16.0,16.3,16.6,16.7,i have three modules activated (google face unlock,hide navigation bar,android p emojis)...but only android p emojis work while other two are not working at all... please help i want to hide my navigation bar

Device: Redmi note 5 pro
[Magisk] jenslody:
Nearly no information and no logs => no help possible, sorry.
[Magisk] jcmm11:
For hide navigation bar - what's the result, from a terminal emulator, of the following command

getprop|grep mainkey

The only thing that module does is set a prop.

What ROM are you running? If the prop is correctly set then it's either your device or your ROM.
[Magisk] mr._.nobody:
I'm on pixel experience, I've talked to a guy on the same rom on the same device,he was able to hide the nav bar with magisk but I'm unable to do it
[Magisk] jcmm11:
Well the log says it's loading the prop

"hide-navbar-prop: loading [system.prop]" so what's the result of the command I asked for?
[Magisk] mr._.nobody:
I basically didn't understand what you said in the above quote...but if you're asking me to enter the code in terminal emulator,then I'm attaching a screenshot for the same

Also I've disabled the navigation bar through xposed edge(module of xposed)...

But still i want to Know why magisk is not working
[Magisk] Didgeridoohan:
According to your screenshot, Magisk is working, because the module has set the prop to the desired value.

You're in the wrong thread. This belongs in the general support thread or the module support thread, not the Magisk beta thread...
[Magisk] mr._.nobody:
1. Ok, but why module is not working?

2. Sorry for that..is there any other thread that can solve my problem.
[Magisk] xunholyx:
https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382
[Magisk] topjohnwu:
Hey, thanks for the report!

May you run the follow command in a root shell (either Terminal Emulator or adb shell) and report the output?

logcat -d -f /dev/null
echo $?
[Magisk] darkknight200:
output says 0

thanks for replying.
[Magisk] martyfender:
I know this was for another poster, but I ran it on one of my Nextbook Ares 8A's, Android 6.0.1, in a terminal emulator as root and I get no output. Is that normal?

EDIT: I found my mistake, the lines have to be entered on at a time, I had copied and pasted it from the thread. My output is also 0.
[Magisk] whitewallman:
Don't know the proper protocol to report issues, but I'd like to report one with Latest Magisk Beta: v16.7 (code: 1671):

I'm using Pixel 2 XL, stock/rooted 8.1/July update.

When powered off, and plug in usb-c charger, the device locks up with the white battery charging screen (black screen with large white lightning battery icon. Unplug only to see battery icon remain. Only way to get out is to hold power button for longer than 30 seconds and force it to reboot. Went back to magisk 1.6.0 stable and it works fine. If I recall, 1.6.6beta worked okay too, but not sure. Can a Pixel 2 XL owner try to reproduce this?

Update: 16.6 works fine. It's something in 16.7 (code 1671)
[Magisk] martyfender:
The procedure for reporting bugs is in the OP: logs.
[Magisk] xunholyx:
How do you get a log with the device powered off?
[Magisk] jenslody:
I don't think a log can be fetched from a device which is powered off.
[Magisk] xunholyx:
Especially when the issue is when plugging into a charger. lol No way to use ADB when your charging port is being used already by the charger.

EDIT: [MENTION=2544666]whitewallman[/MENTION] You may be able to get help in this thread.

Posts in this thread should include logs. They aren't as necessary in the thread that I linked, although it is preferred to provide them there as well.
[Magisk] topjohnwu:
Cool! So it seems that the only issue here is that logd is not launched early enough, and Magisk won't try a second time if it fails the first time.

Thanks for your testing :)
[Magisk] darkknight200:
thanks for the reply. glad i could help

Anything I could do on my end to get logd to launch earlier?
[Magisk] martyfender:
Sorry, my bad, I saw this:

So I thought you were able to get it to reboot.

---------- Post added at 04:05 PM ---------- Previous post was at 03:50 PM ----------

For clarification, does that mean you need to make Magisk try again if it fails, to fix it, or is it more complicated than that?

Thanks

---------- Post added at 04:29 PM ---------- Previous post was at 04:05 PM ----------

@topjohnwu I just reverted one of my Nextbook Ares 8A's, to the latest 16.7 (1671) to provide logs of MM 5.8.3 getting killed.

Processor: Intel x86 Cherry Trail Atom x5-Z8350 @1.92 GHz, 1gb RAM, 16gb internal storage

Model number: NX16A8116K

Android version: 6.0.1 Marshmallow

Kernel version: 3.14.64-x86_64
[Magisk] xunholyx:
I'm not the one with the issue.

And getting the phone to boot up after the issue has happened while powered off won't allow you to get a log for the issue afaik

Anyway, enough on this. It's OT at this point.
[Magisk] Paz9:
[MENTION=4470081]topjohnwu[/MENTION]

Can you explain to me why 16.7 disables verity and stable 16.0 doesnt

16.0 does disable verity if you uncheck it in the magisk manager then re-flash magisk via direct install (must boot into OS)

is it possible to edit 16.0 to disable verity the same way 16.7 does?

as i am decrypted, i cant boot into OS after an update to re-flash magisk with 16.0 otherwise OS will format my /data partition

and i believe i read somewhere you stating that the beta versions have more logging enabled which is what i am trying to avoid.
[Magisk] jcmm11:
Uncheck it in the manager, patch a boot image, boot to recovery, flash boot image.

Debug-log is no longer being created, even for beta (so 16.7 has no debug log, just the regular magisk log)
[Magisk] Paz9:
where is it stated that debug-log is no longer being created?

can [MENTION=225651]op[/MENTION] confirm no difference in logging with stable and beta?
[Magisk] martyfender:
From the OP:
[Magisk] Paz9:
not sure how i missed that.

are any other debug flags being used?

is it safe to flash beta 16.7 over stable 16.0 or should i uninstall magisk using the zip before installing beta?
[Magisk] ettore88:
Hi guys.Just a question.I have a Samsung S7 Edge last stock fw.(OREO)Unfortunately i noticed that from the beta version of Magisk next to 16.4...it is impossible to install magisk from TWRP.To install the latest beta vs, I need to flash vs 16.4.And then proceed with the direct installation from Magisk Manager!Why?THX in advance
[Magisk] Oswald Boelcke:
Personal experience: I simply flashed v16.7 BETA over v16.0. No issues at all.
[Magisk] Didgeridoohan:
That question is practically impossible to answer without a recovery log showing the failed installation.
[Magisk] Paz9:
i must be crazy but i feel 16.0 makes my system run faster compared to 16.7
[Magisk] Oswald Boelcke:
Unable to confirm this observation. My device in its configuration and set of installed modules runs as well with v16.7 Beta as with v16.0.
[Magisk] otonieru:
The only thing i can say is, that magisk hide is still problematic in several devices/ROM. And it cause slow down to apss which enabled in magiskhide setting. Aside from that, no slow down occure. If you face issue with several app. I suggest flash back 16.3
[Magisk] Paz9:
issue goes away with 16.0

as soon as I flash beta system slows down alittle
[Magisk] Didgeridoohan:
Any logs that might show this slowdown?
[Magisk] Paz9:
How can logs show a slowdown?...

---------- Post added at 11:26 PM ---------- Previous post was at 11:16 PM ----------

what if you flash 16.0 stable?
[Magisk] Didgeridoohan:
A logcat might show that there are an excessive amount of calls for a certain function, or app, or service, or similar. The Magisk log might show that MagiskHide or some other part of Magisk is working way harder than it should. Etc...

Just saying "it feels like my device is slower, I'm going you revert to an earlier version" is probably going to mean that your device is going to feel slower on any subsequent releases as well.

As a general rule: No logs/details, no fix...
[Magisk] martyfender:
I attempted to download and install [MENTION=1143630]osmosis[/MENTION] busybox for android NDK 1.29.1 through the mm downloads and it failed. When I installed through TWRP it suceeded. Install log attached.

Nextbook Ares 8A Intel Cherry Trail Android 6.0.1, Magisk 16.7 (1671).
[Magisk] dethknite:
Just wanted to throw it out there in case anyone else has issues.. Moon+ Reader Pro (which requires adding it to MagiskHide if Magisk is installed for it to work), does not work in 16.7. It just freezes with black screen, similar to MagiskHide not working. Reverting back to 16.4 and it works fine again.

- Pixel2
[Magisk] jcmm11:
Need logs if you want it to work.
[Magisk] fdc77:
hi

magisk 16.7 does not survive to los ota seamless update on a Xiaomi Mi A1 , i can try to keep a log, but when i must keep it? after reboot? or before reboot?

Thanks
[Magisk] peterlee928:
hello all... unfortunately i dont have a log to post on this because it happens so infrequently, but every once in awhile, i will get an on-screen notification that magisk manager has stopped working. i will try to capture a log of this, but just fyi to the good folks doing yeomans work on this awesome app.

im running the latest beta magisk and the latest mm.

google p2xl

stock rom july update

no custom roms/kernels

running stericson busybox pro

happy to provide additional details if necessary
[Magisk] eak1080:
Pixel 2xl july8.1 magisk 16.7 can confirm this. Power phone off, as soon as you plug in a USB C charger it boots the black bootloader is unlocked screen (power to pause/continue) and then there's just the white battery charge screen but everything is frozen. Hard 30 second power cycle needed to reboot the phone.

No idea how to capture logs from a phone that is powered off and frozen... This doesn't happen on 16.6 however fwiw
[Magisk] whoopoi:
I'm having a terrible time playing Pokemon go.

I run an aicp custom rom and magisk doesn't seem to hide it. Besides going back to stock rom, what are my choices to hide root/custom.

Thanks in advance.
[Magisk] jcmm11:
Wrong thread

https://xdaforums.com/apps/magisk/discussion-pokemon-magisk-discussion-t3465722
[Magisk] osm0sis:
That osmosis guy must really be annoyed with me. ;)

Anyway, I just looked at the log and the mount commands failing at the beginning suggest there's something wrong with the installation environment, i.e. Magisk Manager/Magisk. Probably better to stick to the stable and/or official Magisk builds to avoid stuff like that.

Also, please next time there's a potential issue with one of my modules please report it in my Odds and Ends thread. It's off-topic in the AIK thread. :)
[Magisk] Linuxpenguin:
Anyone else having CTSprofile false on 16.7?
[Magisk] martyfender:
Sorry for being off topic, the only reason I mentioned it there was this post:

Did that only apply to the AIK-mobile? busybox 1.29.1's gzip?

Yes the device I posted the log from was Magisk 16.7 beta, I consider it the stable and my unofficial installs as the beta, but maybe those are really alphas, it is a matter of semantics, I guess. I realize that by testing [MENTION=4470081]topjohnwu[/MENTION] 's latest commits, that I can expect issues. But I am trying to help, in a small way, with further development.

I guess the only way to resolve this, would to be to go way back to Magisk v16.0 and test if it installs in the downloads with that version. I intend no dis-respect.

Thanks again for your input and I respect your opinion, greatly.
[Magisk] DawoodSahi:
Can I do ota update on my oneplus 6 with latest magisk, without losing it afterwards?
[Magisk] osm0sis:
No sweat man. I just know that if mount is throwing errors like that then it's not busybox mount, it's toybox or toolbox, so I can't really explain why the Magisk Manager zip installation environment would be broken on your device and not any of mine, but that does seem to be the case.. :(

As for busybox gzip being broken in 1.29.1, it's broken in the source; YDS busybox 1.29.0 has the same issue, which is that while the archives created are still valid the compression seems broken so they're much larger than they should be. I'm working on finding the offending commit right now so I can revert and report it.

Busybox's gzip is integral to AIK-mobile/AnyKernel2 since if the new ramdisk is too big then the new boot.img might not fit in the partition, but if you don't use gzip in your day-to-day or at least the size of the archives you make with it aren't a factor then you can keep using 1.29.1. None of that has any bearing on the installation issue you're seeing however. Hope that makes more sense, it's late here. :silly::good:
[Magisk] martyfender:
I had been using yds busybox for some time, until recently, when he had not updated since April. I had recently switched to your module because it was newer. Should I switch to an older version until this is worked out? 1.28.3 seemed to function well, as far as I could tell, as well as previous versions I had installed, from yds.

I had seen some zip not found errors recently in various logs recently, not sure if that was related, or not. I have recently looked at too many logs recently to remember. Yes, it is late here also, 1:46 AM EDT.

Thanks Again.

Thanks again
[Magisk] osm0sis:
Already answered that in my last paragraph; you're probably fine on 1.29.1. That said, my 1.28.4, still up in my Odds and Ends thread, is definitely fine if you'd prefer.
[Magisk] halfbytecode:
There seems to be no battery drain on 16.0. The issue went away after flashing 16.0 over 16.4 beta.
[Magisk] Setialpha:
Magisk Manager shows the latest official stable release and that's v12.
[Magisk] dahawthorne:
Thanks, guys. This is only my second attempt with v13, and the first was with stangri's unofficial version, so this is useful info.

Does this mean that when the final v13 is issued Manager will recognise it?
[Magisk] Deltachrome:
I noticed that activating core only mode in Magisk (latest beta) made the check fail on my device. (LG G5; LineageOS 14.1, security patch level June 5) I managed to pass safetynet check by uninstalling everything that uses the api, as well as every app with root permissions.
[Magisk] Honeycd:
Hello, I installed v13 but it does not pass safetynet, what can I do?
[Magisk] laupuy:
Hi,

maybe read some page back of this thread :rolleyes:

or here: https://xdaforums.com/apps/magisk/advisory-safetynet-to-updated-t3621403

;)
[Magisk] Avan7:
Just giving you a big thank you. You're certainly doing a great great job with Magisk, I mean, without guys like you (and all the great developers that have contributed so much to Android), our experience just wouldn't be the same, Android wouldn't be the same, not for me. Today I can rejoice in the achievements of your hard work, and the hard work of others and tinker, play, change, updrage, push my device to its limits.

It is so cool that it seems unfair just to enjoy all this without paying or donating to show our thanks. I'm a student right now, and perhaps not in the best position to give out money, but one thing I know... One day I want to be part of all this and help others have a greater user experience just like you do.

C'est à dire. Vraiment... Merci pour tout ton travail.
[Magisk] pescixx79:
Sorry, but I do not understand what you're referring to. In op i find nothing about apk that fc. Can you help me regret it? I also tried clean installation, but I did not fix it.
[Magisk] gothicVI:
You might want to log that incident.

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] Captain_Throwback:
Read the 4th sentence, about what's expected of you if you use this Beta.
[Magisk] hiimpig1:
Thanks god! I just switch from LOS to MIUI stable rom and I was crazy for 4hrs because Safetynet failed

Waiting for next beta build
[Magisk] L.F.B.:
I really amazed with your work master Johnwu...

Please accept my humble donation. Is for a beer... I will still make a donation that you really deserve!

Thanks for amazing work!??
[Magisk] suljo94:
but I got around the tamper detection by installing the [BETA] v13.0(b3da28e) enabling the standalone mode(disable modules then when booted up I disabled/enabled the magish hide option

Tested on samsung s7edge and 1+1
[Magisk] wirelesskebab:
How do I mount my vendor partition in TWRP? I tried in terminal "mount /vendor" which gave me the error "can't find /vendor in /etc/fstab" but I see vendor it's a blue icon in the top most parent directory, so \ /vendor. Anyone lend me a hand? Thanks
[Magisk] Bryanx86:
Not a file, an action. Go to mount option in twrp, open it, tick vendor box
[Magisk] Z0DY:
Current beta does not work on Huawei P8 with stock b393 firmware.. It says that boot.img doesn't exist and I can't boot up

If u need any log, just say how I can gain it
[Magisk] TheUndertaker21:
Also, I know Topjo just talked about other tampered just a little bit but I can't wait until we manage to bypass samsung pay safetynet too. I can use Spay on my gear 3 but the app is useless once you upgrade it.
[Magisk] Artim_96:
Best from the log tab... There is a big save button. Rest should be explained in OP