yashsingh1/xdaforums huggingface dataset:
[Magisk] DodoGTA:
[MENTION=4470081]topjohnwu[/MENTION] Magisk Manager doesn't transfer its settings from the original app to the repackaged app on hiding Magisk Manager

Also, the Hide Magisk Manager button in Magisk Manager's settings disappears on the repackaged app (not sure if this is intentional or not? :confused: )

Magisk version: v14.5 (1455)

Magisk Manager version: v5.4.2

Device: Samsung Galaxy Trend Plus

ROM: AOSP 7.1.2

/data/magisk_debug.log attached, but I'm 100% sure that logs are unneeded in this case (because I checked the Magisk Manager source code and didn't find any code related to transferring Magisk Manager settings)
[Magisk] :
One post removed, one edited to remove the quote.

Thanks. :good:
[Magisk] :
Please read the first post and use search before posting.

Thanks!

:)
[Magisk] topjohnwu:
Thanks for the overwhelming amounts crash reports LOL, let me address some stuffs

This version has been in beta for sooo long, we had catched tons of bugs along the way. I don't want people to miss out the fancy new features, that's why I'm so tempted to release a new version. I personally have tested v14.5 on my Android 5.0 HTC M8 for over a month, fearing the approach I'm aiming for is too ambitious to work on old hardware and software., but surprisingly it works just fine, making me to think it would work for many others too.

As I mentioned in my release notes, Android had gone through very serious changes recently, and maintaining a consistency across all versions is a really great challenge. I do not want to have fragmentation all over the place, with different devices having separate workarounds and setups. Dynamic initramfs is what came to my mind while adding Pixel support to Magisk, and the wild attempt to port it on traditional device is most likely why v14.5 is broken on so many devices.

The additional avb-verity removal from DTBO on the Pixel 2 devices results in a scary pop-up. No need to worry here, it's Google warning you that your vendor partition doesn't work as expected. I decided to strip off avb-verity to make modifications to the vendor partition possible, as people tend to modify their partitions a lot, and not sure if this might save a few soft brick devices.... As the old dm-verity and avb-verity works so different, it is very difficult for me to come up with a proper way that doesn't complicate things on the user side.

Another main issue is related to hiding Magisk Manager. You wouldn't have imagined how difficult it is to transfer root management dynamically across different package names. I had done some weird hacks to the root database, but so far no issues has been on my radar until I released it publicly. I could've separate ALL root management from Magisk Manager, leaving it only as a frontend of the Magisk binary. However this could've cost me days, even weeks to add a ton of sqlite into the magisk code, and design a way to communicate across Magisk Manager and the daemon. I've chosen the easy route, but apparently it breaks stuffs.

Adding to the mix is that the latest NDK r16 generates ELF binaries that only get complains on OnePlus devices (edit: turns out it also affect other devices, such as Samsung. Not surprised at all lol) with a linker warning spitting out every time you execute magisk. Not sure how I can fix this crap, maybe the easiest way is to downgrade NDK and call it a day. Oneplus is more like Samsung these days, with previous Oreo beta not be able to boot, now this crap........

I'm currently extremely exhausted for tons of stuffs, being in the last year in university and graduate school admission deadlines plaguing in my head. Overall this release is BETA, I need a larger sample size to know how exactly my new attempts works in the wild.

Please give me some time to figure things out. Creativity do cost a lot for me this time :)
[Magisk] Veid71:
thank you for all the work that you do i appreciate it ^_^ but ive got an issue with magisk modules not showing up in the modules section and no matter where i go no one has any clue as to why, it does not matter what version im on whether it be 14.2 3 4 or 5 im on a google pixel xl running 7.1.2 when i install it the module says it goes through fine but then when it reboots there is no module in the section and when i previously uploaded my logs they were saying the module was already installed for some reason, i am uploading the logs for you if there is a log that i miss or anything else you need such as testing a fix or questions or what have you just let me know. i am not sure if the magsik uninstaller is working or not both inside the module and the one you flash, i think that is why it says my modules are already installed i also search through the file explorer and under my systems folder magisk nothing pops in it after the install but it is under my sd card for magiskmanager this problem has been plauging me for weeks now and i have flashed stock everything on my phone countless times and reinstalled different versions countless times to try and make it work

ive noticed this error is consistent though in the log no matter what version i have or if its brand new flashed or not i get * setting up internal busybox

fopen: /cache/magisk.log failed with 1: Operation not permitted
[Magisk] Team DevDigitel:
-22 20:35:15.797 1539 1539 E Magisk : accept failed with 22: Invalid argument

11-22 20:35:15.797 1539 12734 E Magisk : read failed with 9: Bad file descriptor

11-22 20:35:15.797 1539 1539 E Magisk : accept failed with 22: Invalid argument

11-22 20:35:15.797 1539 12734 E Magisk : getsockopt failed with 9: Bad file descriptor

Logs just show this is repeatedly happening over and over in magisk. Otherwise it works, safetynet passes as well.
[Magisk] hwti:
I used Magisk-uninstaller-20171123.zip, and I just checked the MD5, it didn't change.

So unless trying to reflash Magisk-14.3.zip broke something, something didn't work in the uninstaller.
[Magisk] Shen Ron:
Can't install modules through manager, says magisk isn't activated even though it's working fine
[Magisk] tommymilan311:
adb instructions

Can someone point me to some clear instruction on how to install with adb

I'm using a Galaxy S8 with Snapdragon, bootloader is completely locked. I was able to root with supersu but because bootloader is locked it seemed worthless. So I'm back to OE and can't find the instructions to install that make sense.

It seems all instructions assume I can install Magisk manager... which is not the case. I've been through pages upon pages and searches upon searches and can't find any info, yet the Magisk release page says its so. I honestly only want Viper4Android, its all I care to root for.
[Magisk] Veid71:
I also have same issue
[Magisk] NicoNewbie:
[MENTION=4470081]topjohnwu[/MENTION] will this work on devices with A/B?
[Magisk] cantenna:
what's going on with this latest release ? Its seriously broken for me. Magisk.img resizes manully but still only 60mb availble... also auto resize seems to not work at all whwn installing modules.. then theres this /root/magisk/ error in terminal wherever access root (makes me think other stuff is broken too)

going to downgrade.
[Magisk] Pkt_Lnt:
I highly suggest reading the thread to see what topjohnwu posted earlier.

https://xdaforums.com/showpost.php?p=74604265&postcount=4485
[Magisk] cantenna:
i just figured what my issue was, all good now, great release!!
[Magisk] jenslody:
If you see the MagiskManager stuff on your sd-card, is it possible, that it is mounted as internal storage ?
[Magisk] Didgeridoohan:
Holy fudge! That blew up... :D

Bootloop issues have been covered already, I believe. Flash the latest uninstaller and revert to earlier releases. If nothing else works, restoring your stock boot image should be enough to get things working again.

Manager force closing looks like it could be caused by theming for some, but probably not all. If you have a theme applied disable it before updating...

Doing a clean install might work for some. That is, first completely uninstall Magisk (uninstaller zip in recovery is good for this).

If possible, provide logs together with any reported issues and if you see that many others are reporting the same issue there's no need to add to the noise. It's known...

After you've provided your info and logs: Don't panic, grab a towel, sit back and wait for a fix. There's working earlier releases (beta and stable) to use meanwhile.

Settings transfer is a known issue and will probably be solved for a later release.

The repackaged Manager doesn't need a hide button in the settings. To unhide, you simply reinstall the Manager. It's by design...

That message shouldn't cause any issues on most apps. It's probably a result of [MENTION=4470081]topjohnwu[/MENTION] updating NDK and some OEMs (OnePlus and Samsung from the looks of it) not quite following specifications.

That module is going to have to be updated to work with Magisk v14.5+.

Unless it's a module like the one mentioned above (one that has major modifications to the module template and, as a result, breaks it) you've got other interesting issues.

[MENTION=6556047]Veid71[/MENTION] we already know you do have interesting issues, we just need to figure out what. :p

Why can't you install the Magisk Manager?

There was briefly a way to install Magisk through adb commands on one of the betas, but that was scrapped for the current Manager method.

Considering all the reports about issues since the last release, I'd be careful. :D But yes, it should work on A/B devices.
[Magisk] cantenna:
so i read now, (good read) despite this warning, everything works, so is the warning cause for downgrade or is it simply a cosmetic issue that can be ignored?
[Magisk] fOmey:
Very interesting behaviour using the latest BETA on one of my mediatek devices.. SU seems to be working... magisk hide seems to now be working.. I'm passing safetynet..

However still receiving "permission denied" error when mounting, so modules are not working at the moment.

I'm more or less stuck in core mode, definitely some indirect progress since the last BETA.

11-23 06:00:41.391 306 306 I Magisk : Magisk v14.5(1455) daemon started
11-23 06:00:41.433 306 318 I Magisk : ** post-fs mode running
11-23 06:00:42.343 306 344 I Magisk : ** post-fs-data mode running
11-23 17:00:42.382 306 344 I Magisk : * Creating /sbin overlay
11-23 17:00:42.383 306 344 I Magisk : * Mounting mirrors
11-23 17:00:42.383 306 344 I Magisk : mount: /dev/block/platform/mtk-msdc.0/11230000.msdc0/by-name/system -> /sbin/.core/mirror/system
11-23 17:00:42.384 306 344 I Magisk : link: /sbin/.core/mirror/system/vendor -> /sbin/.core/mirror/vendor
11-23 17:00:42.384 306 344 I Magisk : bind_mount: /data/magisk -> /sbin/.core/mirror/bin
11-23 17:00:42.384 306 344 I Magisk : * Setting up internal busybox
11-23 17:00:42.396 306 344 I Magisk : * Mounting /data/magisk.img
11-23 17:00:42.438 306 344 E Magisk : mount /dev/block/loop0->/sbin/.core/img failed with 13: Permission denied
11-23 17:00:42.439 306 344 E Magisk : umount /sbin/.core/img failed with 22: Invalid argument
11-23 17:00:42.485 306 344 E Magisk : mount /dev/block/loop0->/sbin/.core/img failed with 13: Permission denied
11-23 17:00:42.485 306 344 I Magisk : * Running post-fs-data.d scripts
11-23 17:00:42.485 306 344 I Magisk : * Running module post-fs-data scripts
11-23 17:00:42.485 306 344 I Magisk : * Loading modules
11-23 17:00:42.486 306 355 I Magisk : * Starting MagiskHide
11-23 17:00:42.486 306 355 I Magisk : hide_utils: Hiding sensitive props
11-23 17:00:42.487 306 355 E Magisk : fopen: /sbin/.core/img/.core/hidelist failed with 2: No such file or directory
11-23 17:00:42.487 306 355 I Magisk : hide_list add: [com.google.android.gms.unstable]
11-23 17:00:42.505 306 355 I Magisk : proc_monitor: init ns=mnt:[4026531840]
11-23 17:00:43.562 306 498 I Magisk : ** late_start service mode running
11-23 17:00:43.562 306 498 I Magisk : * Running service.d scripts
11-23 17:00:43.563 306 498 I Magisk : * Running module service scripts
11-23 17:00:46.582 306 355 I Magisk : proc_monitor: zygote ns=mnt:[4026533973] zygote64 ns=mnt:[4026533972]
11-23 17:01:06.521 306 355 I Magisk : proc_monitor: com.google.android.gms.unstable (PID=2799 ns=mnt:[4026534022])
[Magisk] Didgeridoohan:
I honestly thought that your first reply was sarcasm...

The linker warning is mostly cosmetic. Some apps with strict root checks might have issues with it...

But what about your other issue? For posterity, how did you fix that?
[Magisk] cantenna:
ah, terminal systemizer; i systemize a number of apps and I just found out today that the Magisk.img does not auto resize when systemizing app. The workaround; install terminal systemizer first as the only module, systemize your apks (have 60mb to play around with) and leave enough room to then flash xposed for example from twrp which then triggers magisk.img to properly resize and then some. After that, your free to install more modules.

Regarding your note, can gou elaborate? Are you saying some app requesting root apps will only partially work (is that possible?) or fail all together?
[Magisk] ulxerker:
flash boot.img of your ROM in recovery, then try to boot the device.
[Magisk] extreme79:
I updated my message exactly when you posted your suggestion :)

I fixed it reinstalling lineageOS directly after uninstalling magisk with the latest uninstaller.

Reinstalled magisk 14.3 ant it works again.
[Magisk] ulxerker:
Andi, as you are aware of the linking-error-message when hitting su in terminals: does this have any other side effects or is it just kinda cosmetic issue?

---------- Post added at 09:39 ---------- Previous post was at 09:36 ----------

Yeah, this works too as it also re-flashs the boot.img. So, next time just flash boot.img of the ROM and you're done :)
[Magisk] goldybewon:
Magisk v14.5=1+4+5= 10/10

[MENTION=4470081]topjohnwu[/MENTION]

Creativity do cost a lot for YOU this time:cool:

Transaction ID :94V25242VB978773C

Have fun and concentrate in study.:D

Thanks,

goldybewon
[Magisk] Veid71:
I'm not quite sure, how can I check to see if it's mounted? Also I've noticed on 14.3 with manager 5.4.0 it tells me the installation was successful, even though it wasn't, but when I upgrade to 14.5 it fails and tells me magisk is not activated, also another fun thing 14.3 has just started telling me the update channel is invalid ive also noticed, theres a lot of files that are not in the magisk folders, in my root file theres a file called magisk, and in my data folder there's magisk.img, magisk_merge.img, magisk_debug.log, but if i look under data in my magisk filetheres also a file called magisk
[Magisk] MEKCHR:
Magisk Manager crashes everytime i check for safetynet (was working fine before updating)

i don't know what are logs so i hope the one i attached works

ViperOS 3.1.1

Samsung Galaxy Grand Prime G530H XCU *fortunave3g*

7.1.2
[Magisk] topjohnwu:
Magisk v14.5 (1456)

For the complete info, please check v14.5 (1455) release notes.

Full damage control mode now lol, please test if this version works for your device :D

Here's the changelog:

v14.5 (1456)

- [Magiskinit] Fix bootloop issues on several devices

- [misc] Build binaries with NDK r10e, should get rid of the nasty linker warning when executing magisk
[Magisk] Didgeridoohan:
All those files are normal for Magisk. Nothing to worry about...

The invalid update channel comes from the new Manager (v5.4.2), not Magisk itself. What do you have set under Update channel in the settings?

Do you have any logs from v14.5? And could you also check how the Magisk image is mounted? You can do this by typing a command in a terminal emulator. For v14.3 it should be:

mount | grep "on /magisk"

And on v14.5:

mount | grep "/.core/img"
[Magisk] Veid71:
it looks like the update channel fixed itself somehow all i did was pull it down to refresh just now and it popped up asking me to install 5.4.3 manager, also how do i make this character? | or do i just do mount enter then grep on "/magisk"
[Magisk] Displax:
[MENTION=4470081]topjohnwu[/MENTION]

Magisk crash when I click on any module in the repo list.

Magisk 14.5 - MM 5.4.2 (on 5.4.3 too). Android 5.1.1 (Nexus 7 first gen).

Log attached.
[Magisk] topjohnwu:
Update/Install the WebView app from PlayStore

Here is the link to Play Store: https://play.google.com/store/apps/details?id=com.google.android.webview
[Magisk] SilvrDrgn:
Device = Google Pixel 2 (non-XL) with November update. Patched stock boot.img via Magisk Manager.

Magisk v14.5, Magisk Manager v5.4.2.

Installed V4A module by ShadySquirrel. FX Compatible Mode = Normal. It works, but only if I set SELinux permissive via the V4A settings. Not a setting I would like to keep. Would rather be able to run in enforcing.

Via Magisk Manager, uninstalled the ShadySquirrel module and rebooted. After reboot, attempted to install V4A 2.5.0.5 (by ahrion, zackptg5) via Magisk Manager. It inflates the ZIP file and shows the text below after the module banner. Got it installed via TWRP flash, but still only operates in permissive mode. In any case, just wanted to throw this information in this thread here if anyone else has come across the same thing.

End of Magisk Manager install log:

- A/B partition detected, current slot: _b

- Mounting filesystems -

Mounting /system, /vendor, /data, /cache

! Device skip_initramfs detected

! Magisk is not activated!

Failed!

! Installation failed
[Magisk] topjohnwu:
As I mentioned in the release note, the module you're installing does not use my util_functions.sh. Instead they use their own, which of course would not meet the changes Magisk have done internally.

I have pulled all logic from the module template and place them in Magisk's universal utility scripts for a reason, please ask the developer of the module to update the module :)
[Magisk] Taomyn:
Thanks for the latest update it's fixed the bootloop on my Nexus 9 and my Nexus 6p is still ok.

Any idea why the "Re-authenticate after upgrade" option is not available on my Nexus 6p running Oreo but is available on my Nexus 9 on Nougat? Both stock ROMs.
[Magisk] DenyDarko:
App Upgrade will not finish if the apk is signed with different key. Installation will not proceed and an error will be shown.

If you've already allowed an app to have root its pointless to enable this option. It's only an annoyance for you to re-allow.
[Magisk] topjohnwu:
This is a limitation of Oreo. On Android 8.0 we can no longer receive broadcast when apps are upgraded, we can only know when it is uninstalled.

So to prevent confusion, I simply removed the option on Android 8.0+
[Magisk] topjohnwu:
There are so many reports without any logs, how can I fix things? :confused::confused:

I updated the OP with more clear instructions, please read them and follow the rules. I will let moderators strictly moderate this thread so it would be less pain for me to go through.
[Magisk] Magister54:
Asus Zenfone2 ZE551ML : with Magisk 14.3 Manager 5.4.0 I now have a CTS failed, it was working for weeks.

I upgraded to 14.5 and 5.4.3 and same thing, CTS failed.

Log attached
[Magisk] eak1080:
View attachment logs.zip

[MENTION=4470081]topjohnwu[/MENTION] I have a Nexus 5x. Running Nov 8.0.0 image. I have FBE enabled. In order to flash I have to set KEEPDMVERITY AND KEEPFORCEENCRYPT. 14.3 works flawlessly. 14.5 (both versions do not boot) attached are the logs for the installation of 14.5 (1456) and the debug log from when I flashed 14.3 for the first time and all the attempts to flash 14.5 (1455) and 14.5 (1456) .

Hoping it is useful. Plz dm me if you need anything additional.

Cheers.
[Magisk] SuperSandro2000:
Magisk App crash on startup after update to 5.4.3 from 5.4.0. device is s8 with Oreo beta 2.
[Magisk] FrancoGag:
I can't install any module, it says Magisk is not activated. Also the log shows a couple errors.

Device: Moto E4 Plus Android 7.1.1 stock

Magisk: 14.5 1456 Magisk Manager 5.4.3

It wasn't working on 14.3 either.

I read it has something to do with Moto phones using f2fs on /data. Is this correct?

Any alternative other than switching to ext4?
[Magisk] SacredDeviL666:
Hello.

Cleaned bootloop posts/SN fails/Crash messages without logs/works fine/modules updated/specific games/apps not passing root check.

Please try the latest update before posting/replying to an issue reported before this release :- https://xdaforums.com/showpost.php?p=74611835&postcount=4442

Respect the OP - https://xdaforums.com/showpost.php?p=74613023&postcount=4452

Cheers :good:

Edit:- any bug reports without a log will be removed and any response to a sn/post log/working fine will also be removed.
[Magisk] zen2fans:
Also got this issue..

https://hastebin.com/amaxipolod.vbs --- debug log
[Magisk] JoHnNiEE91:
magisk is not installed (1456)

op3

bluespark twrp

stock kernel

I flashed 14.5 (1456) tried all previous as well, but in the end the magisk manager is not installed, when I install the app manually, it says magisk is not installed and safetynet fails.

tried the uninstaller , tried reflashing countless of times.

reflashed my rom also, but still after I flash the zip, the app cannot be found

and here is my log

https://pastebin.com/fWfjJyDe
[Magisk] gracce:
please i need help, i don´t know how to do that: Installing Magisk fails:

If you're flashing in TWRP: Upload the recovery logs (pull the file /tmp/recovery.log, or select "Advanced > Copy Log" and upload)

what i have to do??? - Because i flashed the zip in TWRP but got Error

i have Samsung j5 2016

Please
[Magisk] Artim_96:
Then you need to do the first thing. Go to advanced, file manager and there to tmp. There should be a file recovery.log. copy it somewhere under /sdcard (your internal storage) and upload it here from there.

Of course you can't reboot between that and the Magisk Installation. Then you need to get out from /cache.
[Magisk] godofsalt:
Topjohnwu

Samsung Galaxy S 5 (sprint)

LOS 14.1

Magisk 14.5 inculdeing latest Manger

Issue - for reason don't know, Magisk is not able to find or see that I DO have a Wi-Fi connection...

Open Magisk Manager, top bar is black, in grey wording, it states that it the manager is not wi-fi connected.

Did not notice any other issues, but, in the log, it reads multiple times, bout gcm not working error...

Hope this is something you already know! If not, sorry for bad news... As you did state, you did want/need a large pool to see what does work or what does not..