yashsingh1/xdaforums huggingface dataset:
[Magisk] Zackptg5:
[MENTION=4470081]topjohnwu[/MENTION]

Found a small bug in module template v5:

The api_level_arch_detect function call is before the system is mounted.

It needs to be after the system is mounted or else the API variables won't set. This is because they call on the grep_prop function which requires a mounted system to read the build prop

I opened an issue on github: https://github.com/topjohnwu/magisk-module-template/issues/29
[Magisk] ahrion:
Latest beta, 1350, cannot uninstall apps within the Magisk manager. Reboot doesn't do anything.
[Magisk] MarcelDnB:
+1
[Magisk] Shtiff1:
Mine has been doing the same on 5.1.1, 13.3

Just tested again to confirm. Doesn't bother me though.

I'm guessing if I have the host folder in magisk /.core, then it should be working?
[Magisk] exodius48:
[MENTION=4544860]osm0sis[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] I'm using YashdSaraf's BusyBox, will it interfere with NDK BusyBox?
[Magisk] Didgeridoohan:
Just to clarify: After flashing v13.5(1350), Magisk Manager reports that there is no Magisk installed and that there is no root. Or?

If you're talking about [MENTION=4544860]osm0sis[/MENTION] busybox Magisk module - yes.

If you're talking about Magisk's internal busybox - no.
[Magisk] Didgeridoohan:
Yes. Delete the module folder in /magisk and reboot.
[Magisk] insision:
Dark theme make magisk crash in beta version thnx 4update
[Magisk] dugi9991:
Try to clear cache/data, was discussed in this thread before.
[Magisk] juan.r.l:
Where I downloaded the app 5.2.0
[Magisk] Loader009:
MagiskManager wanted me to update to v13.5... did that and had massive problems with storage permissions.

At the same time my mSDcard stopped working. But although I replaced the card, the problems persisted until I downgraded to v13.3.
[Magisk] dimm0k:
cool story bro!
[Magisk] veez21:
Nah, I don't trust magisk app flashing and how it handles the shell. I'd recommend recovery in any occasions

Better discuss this in it's respective thread to reduce clutter, or not since this is a beta thread, and is expected to have problems, if the problems are caused by it.
[Magisk] Ansuel:
so downgrade twrp and problem solved? really?
[Magisk] lalitjoshi06:
[MENTION=4470081]topjohnwu[/MENTION]

Some of high security apps detected magisk app as a root cloaking apps.

I am using stock rom leeco x522. marshmallow.

using beeta version 13.

as i uninstall magisk app all those apps (banking apps) works.

same happen with other root cloak apps like xposed installer app. ( not installed xposed) just app. as i uninstall this app same apps works.

conclusion: - we are under root cloak detection. (according those apps security level which detecting magisk app as a malware)

thanx for this magic binary........ magisk......
[Magisk] justjr:
Yeah, I know. Despite your recommendations, I always used it, including with your modules (when I used it in the past), and never had a problem (since earlier magisk versions).
[Magisk] smohanv:
Warming for anyone trying with Fulmics ROM that has preloaded magisk 12. Don't try. You will loose all your apps. You have to bring back all apps from the scratch.
[Magisk] topjohnwu:
Known issues updated in OP, will try to fix them ASAP :)

Still need some logs from those who have resetprop errors, many thanks!
[Magisk] Timmmmaaahh!:
Thanks for warming us, it was getting a bit chilly. Please try something relevant next time, like something actually related to the topic, or the scratch will be out to get you...
[Magisk] DodoGTA:
He meant to say "warning"
[Magisk] Sytis:
He was being sarcastic.

Just a heads up: On OP3 with latest LineageOS, blu_spark kernel and Magisk Beta it looks good so far. No problems during installation (clean) and root. I always use the core only mode since most modules aren't working with the new structure yet. Also systemless hosts doesn't work for me, but also gives no errors so I can't provide anything. Maybe Adaway is just a bit bugged.
[Magisk] smohanv:
Thanks. Yes I meant to say warning. Spell error.
[Magisk] gio1135:
You have to flash the stock boot.img.
[Magisk] JonathanRAZ:
I have tmo note 5 i have try all with the v13 i am just waiting until
[Magisk] demonoidmaster:
Use Magiskhide...............
[Magisk] Deic:
Magisk Hide doesn't hide Magisk Manager, except if is systemlessly mounted. But I think the banking apps that checks for dangerous apps, checks for data, dalvik cache or anything related to the app, you could bind mount those too and unmount when launch the banking app, but the banking app could check for process running or others ways, so.. is very hard to hide...
[Magisk] demonoidmaster:
People like them shouldn't be allowed to even get any kind of support if they install something they shouldn't install, everyone knows these kinds of things that are in beta (not even release candidates) aren't meant to be ran on everyday devices

The problem with people is they search for something, they see it's the highest version, try to install it then complain it either doesn't flash or that it flashes but mod edit: messes up their device.

Imo that's what they get for touching mod edit: stuff they don't know mod edit: anything about.

It's like the other day in the play store for Busybox, in the reviews one guy was saying thanks and how he doesn't know what it's for but someone said to install it. I wish you could reply to peoples reviews in the Google Play Store

---------- Post added at 03:38 AM ---------- Previous post was at 03:32 AM ----------

No you don't.

You install via Magisk be it from the repo or sourced from a local zip. If on reboot it's saying it isn't active and/or doesn't work then try via TWRP

The way Magisk installs mod edit: stuff is no different from FlashFire by Chainfire, FlashFire is meant for flashing zips (wipes cache and dalvik) when you really don't wanna reboot to recovery and just want mod edit: things done quick

---------- Post added at 03:39 AM ---------- Previous post was at 03:38 AM ----------

Ohh that's what you meant... Well ig you can always use a seperate app that would hide Magisk. mod edit: parts of the post deleted
[Magisk] veez21:
No, magisk manager/module update-binary does things differently. That's what I meant. And I also know how things work, I'm not an idiot ?
[Magisk] Flippy498:
Guys, I had to clean this thread. Therefore, please remember the rules you accepted while registering for this website.
[Magisk] Ansuel:
[MENTION=4470081]topjohnwu[/MENTION]

Galaxy S8

Installing zip file '/sdcard/Download/Magisk-v13.0(0b4baad).zip'
Checking for MD5 file...
Skipping MD5 check: no MD5 file found
I:Update binary zip
I:Zip does not contain SELinux file_contexts file in its root.
I:Legacy property environment initialized.
ps: invalid option -- A
Segmentation fault
Archive: /sdcard/Download/Magisk-v13.0(0b4baad).zip
inflating: META-INF/MANIFEST.MF
inflating: META-INF/CERT.SF
inflating: META-INF/CERT.RSA
inflating: META-INF/com/google/android/update-binary
inflating: META-INF/com/google/android/updater-script
inflating: arm/magisk
inflating: arm/magiskboot
inflating: arm64/magisk
inflating: arm64/magiskboot
inflating: chromeos/futility
inflating: chromeos/kernel.keyblock
inflating: chromeos/kernel_data_key.vbprivk
inflating: common/boot_patch.sh
inflating: common/init.magisk.rc
inflating: common/magisk.apk
inflating: x64/magisk
inflating: x64/magiskboot
inflating: x86/magisk
inflating: x86/magiskboot
************************
* Magisk v13.0(0b4baad) Installer
************************
- Mounting /system(ro), /cache, /data
- Device platform: arm64
- Constructing environment
cp: target '/data/magisk/./magiskhide' is not a directory
- Creating /data/magisk.img
CANNOT LINK EXECUTABLE "/dev/tmp/magisk/arm64/magisk": cannot locate symbol "selinux_android_restorecon_internal" referenced by "/system/lib64/libpersona.so"...
Aborted
losetup: /data/magisk.img: No such file or directory
losetup: /data/magisk.img: No such file or directory
losetup: /data/magisk.img: No such file or directory
losetup: /data/magisk.img: No such file or directory
losetup: /data/magisk.img: No such file or directory
losetup: /data/magisk.img: No such file or directory
losetup: /data/magisk.img: No such file or directory
losetup: /data/magisk.img: No such file or directory
! Magisk image mount failed...
Updater process ended with ERROR: 1
I:Legacy property environment disabled.
I:Install took 1 second(s).
Error installing zip file '/sdcard/Download/Magisk-v13.0(0b4baad).zip'
Updating partition details...
[Magisk] shadavis08:
Anyone using an LG V20? Is v13 stable?
[Magisk] Didgeridoohan:
Known issue. And looking at the code on GitHub it might be solved soon.

Nope. That's why it's still in beta.
[Magisk] demonoidmaster:
Lmao some of these people who post shi such as "magisk where download¿?" Or "dark theme make magisk crash" make me giggle

Yeah uhh fr 1. Magisk autoinstalls the apk after you flash in twrp, but you can find the apk in the zip

2. L O G S. Post, em, jfc

---------- Post added at 01:22 PM ---------- Previous post was at 01:19 PM ----------
[Magisk] danilo_scala:
[/COLOR]

Yes, only install manager when i flash in twrp but inside manager show magisk no installed and no root. Download etc..
[Magisk] ratelutz:
With latest 13.5phone does not recognize the sim.

When i revert back to 13.3 all woekes fine again.

Log attached
[Magisk] tymestopm:
Then post in the support/discussion thread

Jesus christ... So much for mods doing their 'jobs'
[Magisk] DodoGTA:
I want logcat
[Magisk] ratelutz:
here you are
[Magisk] ratelutz:
Sony Z5 E6653

ROM: 32.4.A.0.160

KERNEL: 3.10.84-perf-g5e25a09
[Magisk] DodoGTA:
Did you flash a custom kernel?
[Magisk] ratelutz:
No prior installing magisk i reflashed stock boot.img
[Magisk] Marucins:
Hmmm

After upgrade 13 to 13.5 -> systemless host, auto disabled

I can't turn on because it turns itself off.

OP5 OSS 4.5.8
[Magisk] Shtiff1:
Already discussed, keep reading
[Magisk] demonoidmaster:
Shouldn't cause issues since flashing Magisk then Kernel or Kernel then Magisk doesn't do any harm (unless certain kernels maybe do weird stuff to your boot img)

It's like me, i run Resurrection Remix but after i flash it it autoflashes Magisk 13.3 because it's in the rom zip sooo yh, flashing the elementalx kernel right after causes no issues

---------- Post added at 06:51 PM ---------- Previous post was at 06:50 PM ----------

Don't post about safetynet
[Magisk] ratelutz:
sorry i have to correct myself. kernel was repacked with rootkernel_v5.23
[Magisk] marisaleh:
can you use Busybox pro from the market instead of

Installing Busybox for Android NDK module

and what is the difference between them
[Magisk] DodoGTA:
I would choose the second option
[Magisk] marisaleh:
Do I just install the module and no further tweeking

or configuring
[Magisk] jenslody:
A logcat from boot would be extremely helpful.

Which version of Android do you use ?

I have a quick and dirty hacked version for MM (6.0.1) here and will try to update it to template v5.
[Magisk] nathanchance:
Thread cleaned.

I will say this only once: threats of physical violence will not be tolerated here, at all. Please keep things respectful here on out.

The Flash

Forum Moderator
[Magisk] ivan47:
Htc m9+ 6.0, but I can't upload logcat am trying since yesterday but a have network error
[Magisk] demonoidmaster:
One installs it the good old way, directly to /system/xbin (or any place busybox is detected on your system)

The other does it systemless Magisk style meaning the modular Busybox is seperate from your actual system, just like all modules do

Well, theres your issue lol, flash your roms stock boot image, as for kernels I'd say use one that plays nice with Magisk (elementalx for example, it can be flashed before or after Magisk, no issues whatsoever) but make sure they're compatible
[Magisk] matt4321:
Please take note of what [MENTION=6842057]The Flash[/MENTION] said further up. There is also just no need for petty arguing and being rude to users.

Let's all just play nice, enjoy Magisk and keep this on topic yeah?

Have a good day all!

Matt

Senior Moderator
[Magisk] jenslody:
You can try the attached xposed, it has a modified "post-fs-data.sh"-script and should only be used for v13.5+ (because I did not test it on earlier versions).

And it's only for MarshMallow.

But the "post-fs-data.sh" can be extracted and might be useful for older Androids also (no guarantee).

If that does not work or Magisk itself does not work correctly, e.g. no or not all modules started (but this is most likely a Samsung-special), you can try the modified Magisk-zip.

Even if it has nothing to do with your issue (or my modification): xposed has to be installed through TWRP or it might lead to a bootloop !

EDIT:

updated modified Magisk with a version, that can remove modules with MagiskManager.

EDIT:

I found the cause for the bootloop, if flashing Xposed through the MagiskManager.

If a module uses special selinux context for files, they haven't be set correctly after merging the temporary image into the magisk.img on boot due to a typo in magisk sources.

I just informed @topjohnwu about this issue, so I think it will be fixed in next beta.

For now you can test the attached version.
[Magisk] grzpra:
i can't do restore with titanium backup on MIUI 8&9 when using magisk, but work with supersu, whether it's systemless or system.

and i do have problems like the one that posted on first page, magisk hide is not working even i have activated it, universal safetyfix not helping too.
[Magisk] dimm0k:
v13.5(1350)(beta)

- [installer/uninstaller] Fix a bug in scripts causing backing up and restoring stock boot images failure

just curious about this... is there a way to verify if the backup stock boot I have from 13.3 is a good one? if it's bad, will 13.5 beta fix it or do I need to restore from backup first?
[Magisk] mondohow:
Looks like you'll have to restore your stock boot.img from a backup first. See last entry here: https://xdaforums.com/showpost.php?p=73379475&postcount=2699
[Magisk] jenslody:
There are many reports about not being able to delete modules. I attached a modified version of v13.5, that has this fixed to a one of my previous posts.
[Magisk] demonoidmaster:
People should just delete the modules from the /magisk folder though if they won't uninstall
[Magisk] chugs:
I've been experiencing problems with my boot.img being edited by another program.

I've unrooted.

I've flashed the boot.img out of the Resurrection Remix .zip

And yet I'm still stuck with root and without Magisk.

I would appreciate anyone who might lend some wisdom.
[Magisk] DenyDarko:
It's being written a thousand times.

You need the STOCK boot img
[Magisk] camapghe:
Quite strange that I removed SuperSU, reflash kernel and flash your Magisk file but nothing appear when boot back to the system. Might be due to TW abnormalities.
[Magisk] chugs:
Yes it has. I guess I don't understand the difference between the one I need. And the one I have.

I one I have came out of the rom zip. What is more stock than that? The TouchWiz boot.img.
[Magisk] gothicVI:
You can install the manager app manually.

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] Pat750:
I could be wrong, but isn't the stock RR ROM already rooted? So if you flash stock boot.img (not TW but RR) root is already activated out of the box and you have to manually unroot...if that is what you want?
[Magisk] jenslody:
Can you get a logcat from boot and the recovery.log from flashing ?

Just retested on my J5 after setting to clean stock MarshMallow:

no issues installing Magisk and all my modules (from TWRP).

Systemless hosts works, systemless debloat also, safetynet passes as long as I install xposed.

Xposed works fine, so no issues here.

So as usual:

without logs, nobody will be able to help in any way.
[Magisk] ahrion:
I test my modules uninstall procedures by deleting them the way Magisk intended. This has to do with my AudModLib.

But this is me as a Dev.
[Magisk] Didgeridoohan:
Yes, for development purposes just deleting the module folder isn't up to par... But, the issue is known and [MENTION=4470081]topjohnwu[/MENTION] knows what causes it. Next beta release, I guess...
[Magisk] Narohuh:
I'm a normal user when I use the magisk v12 'kakaotalk' can hide but use the V13(also V13.3) I can't hide I don't know why but please fix this problem
[Magisk] gothicVI:
Please provide details and logs...

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] Eienkei:
v13.5 on Xperia Z5 E6633 breaks fingerprint functionality (some how it removes it from system) and prevents the phone from shutting down properly, screen turns off but the phone won't unless we physically turn it off.
[Magisk] Denkai:
Odd

So I rebooted and went to my magisk 13.5 app and noticed the APP lost root. I can still get root on terminal. Reinstalling now to see whats up.

Update: reflash worked no issues, not sure what happened.
[Magisk] topjohnwu:
2017.8.17 Magisk v13.6 (1360)(beta)

New beta is released

Please check changelog for details.

Also, check out the announcement in the main thread, thanks!
[Magisk] Setialpha:
I'm getting a bootloop with my NanoMod module, both on 13.5 and 13.6 (in fact the same issue occurred with early 13.0 betas, aswell).

Latest NanoMod in-dev can be found at gitlab (issue

build-package full

to create the module zip). boot.img + logcat attached (it took a very long time until the device started adbd, so I'm not 100% sure everything was properly logged).

With NanoMod disabled everything works, no issues flashing Magisk itself.

If you need something else, let me know.
[Magisk] rffslow:
I can't find the magisk su option on the manager after installing The latest 13.6 beta, May I have done something wrong?

Enviado de meu MI 5s usando Tapatalk
[Magisk] tymestopm:
Uninstall the manager then install it from inside the zip again. Reboot and that might work
[Magisk] Gilfreitas:
Totally stable here.
[Magisk] camapghe:
Latest 13.6 seems great. No more conflict with Magisk Xposed, although I used the modified version few post ago. Any incompatible apps that showed a black screen previously can be easily fixed with Magisk Hide, even works well with Samsung Galaxy Gifts app.

Great job, dev!!!
[Magisk] Shen Ron:
Busybox still shows needing update in manager but not sure if this will help. This log is from my testing phone Samsung Galaxy On5 debloated touchwiz, no xposed framework. I'll upload the one for my regular phone in another hour and a half or later.
[Magisk] Didgeridoohan:
But everything is working, right? Just delete the "update" file in /magisk/busybox-ndk.
[Magisk] Shen Ron:
I don't see that file even when I enable show hidden in mixplorer nor when I go into recovery.
[Magisk] Didgeridoohan:
In that case I think I misunderstood you... Does it say "module will be updated on next reboot" or does it show as having an update available in the Downloads section? If the latter, have you tried updating it? There's been a couple of updates to it since it was released in the repo, but since the version shows the busybox version, that doesn't change.
[Magisk] skulldreamz:
Exit
[Magisk] Shen Ron:
It's the latter and I did update it but no change.
[Magisk] Didgeridoohan:
Run a logcat while updating the module. And after that try updating the module in recovery (the module zip will be in your internal storage, in the MagiskManager directory) and make sure to save a recovery log.
[Magisk] Shen Ron:
I tried again in recovery but it said that it failed and that was the test phone I used. And if I use magisk manager to update it will only show that it will update after next reboot but that never worked no matter how much I reboot.
[Magisk] Didgeridoohan:
Come on... This is the beta thread: post logs! I even said it in my last post.
[Magisk] Shen Ron:
I'll post it after I get off work, the wifi is terrible and data is running slow right now so once I'm home I can post the log with no problems.
[Magisk] demonoidmaster:
All roms have their own stock boot image, are you serious rn or?

---------- Post added at 01:20 PM ---------- Previous post was at 01:19 PM ----------
[Magisk] DenyDarko:
WoW.

Someone woke up in the thread ans decided to play the beloved smartass role.

Many custom roms screw with boot.img.

In any case stop being rude. You don't know me, keep the "are you serious" expressions for your friends.
[Magisk] demonoidmaster:
"Many" Resurrection Remix not being one of them, nor Lineage, nor ParanoidAndroid, nor CrDroid (that i know if), nor other normal custom roms

Only other that do custom boot images actually do specify it on their pages so
[Magisk] danilo_scala:
magisk 12 install and magisk 13x no install and no root
[Magisk] DenyDarko:
I'll stay to what I've already said.

Flash the stock boot.img made for the device by the manufacturer, not the XYZ custom rom img and only IF there are still errors, logs.

PS: I'm glad you completely trust custom roms documentation. I don't. Never did, never will. Let's agree we disagree.
[Magisk] demonoidmaster:
I'm just saying that popular roms don't really do wacky insane boot img mods like some other smaller custom rom devs do

Btw stock boot img is not by manufacturer but by google, stock Android on googles android dev site or whatever it's called has every Android version for Nexus devices, last Android version for mine is 6.0.1 but you see.. Can't really flash a 6.0.1 boot image on a device running 7.1.2 now can i man, that's just asking for trouble
[Magisk] NeedleGames:
I'm slrry, but what's the purpose of this version?
[Magisk] DodoGTA:
https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta
[Magisk] NeedleGames:
I mean, how is this version different fron the one before? They both need unlcoked bootloader, customer recovery, root
[Magisk] zelendel:
Ok first those are standard and will always need those. IF you cant understand the difference then you are most likely better off staying completely stock. Dont root, unlock your bootloader or mess with your device in any way.

Remember where you are. A developers site. So some basic understanding is expected.
[Magisk] xanthrax:
^^^ nothing more to say but "thread cleaned"

Dan - forum moderator
[Magisk] Artim_96:
Then you should make an issue on GitHub. And don't forget to post your TWRP log from installation
[Magisk] redking974:
GMT+08:00 China Standard Time

Hi, I got exactly the same issue (I don't know if it's related to Magisk's installation but I got it) after I reinstall the ROM of my Lenovo TAB2 A10-70. Your fix helps me. Thanks you very much !
[Magisk] Dylanballardlgv20:
For some reason magisk is not hiding my permissive selinux. Is there a way to fix it? Is something messed up or does it not always hide it?
[Magisk] Artim_96:
What let's you think that it doesn't? If you mean that it shows as permissive in system settings, that's normal. For some reason it will keep showing that even if you can see in terminal that it's definitely enforcing
[Magisk] Pavlus:
13.6 flashed over ADB didn't work properly

Flashed on OnePlus 3T OxygenOS Beta 12 with ADB, SafetyNet test didn't pass, root didn't work, solved by installing Magisk 13.3 via Magisk Manager. Now seems to work properly. Awesome.
[Magisk] Dylanballardlgv20:
No mine will switch. Thats the wierd thing. It is enforcing in system settings and actually enforcing not psuedo enforcing like magisk normally does. So either i have it enforcing and passing safetynet or its permissive and failing safetynet. When it usually passes safetynet by faking that its enforcing so i can still use things like cf lumen. Make sense? Or it very well could be faking enforcing and cf lumen isnt getting the picture cause viper still works and doesnt it need permissive?
[Magisk] Artim_96:
It seems the latter. F.lux just stopped working for me but that could be because my ROM which is delivered with Magisk but made enforcing by default. But SPen Commander still works which definitely needs permissive.
[Magisk] Noxxxious:
Hi Topjohnwu,

Magisk 13.6 loses root functionality after it has given root permission to "Synapse". This all started to happen since Magisk v13.x

Device: SM-G920F
[Magisk] Didgeridoohan:
Pseudo-enforcing was removed in v13.1. Now MagiskHide just hides the permissive status instead. And that works in v13.6.