yashsingh1/xdaforums huggingface dataset:
[Magisk] rk2612:
Sorry, I'm not a developer and not qualified enough to really say what could be most appropriate but here is what I've noticed:

1. I downloaded OnePlus3 OOS5.0 and extracted the boot.img from the zip.

2. I then extracted the dtb and upon converting those into dts (... text format), I noticed that the fstab entry had flags for system as follows:

firmware {
android {
compatible = "android,firmware";
fstab {
compatible = "android,fstab";
system {
compatible = "android,system";
dev = "/dev/block/platform/soc/624000.ufshc/by-name/system";
type = "ext4";
mnt_flags = "ro,barrier=1,discard";
fsmgr_flags = "wait, verify";
status = "ok";
};
};
};
};

3. I then ran Magisk on my OnePlus 3 to patch the boot.img and then extracted the dtb again on my Ubuntu system. Converting this dtb to dts, I notice that this reads:

firmware {
android {
compatible = "android,firmware";
fstab {
compatible = "android,fstab";
system {
compatible = "android,system";
dev = "/dev/block/platform/soc/624000.ufshc/by-name/system";
type = "ext4";
mnt_flags = "ro,barrier=1,discard";
fsmgr_flags = [B]<0x77616974 0x0 0x0>[/B];
status = "ok";
};
};
};
};

While I notice that the hex value of 0x77616974 corresponds to "wait", I'm wondering if this edit made by Magisk is perfect or can it cause some problems.

Is it better to convert the dtb to dts and reconvert it to dtb?
[Magisk] cb474:
I'm having a problem where sometimes AFWall is not granted root status and it fails to apply iptables rules. This seems to happen when I have a change in connection (e.g. from wifi to cell) and it is reapplying the rules. But it only happens somtimes. I get an error from AFWall saying that it was unable to get root and my device needs to be rooted. If I force close AFWall and restart it that usually solves the problem. But most of the time AFWall works fine.

I'm using a Pixel 2 and did not have this problem with the first release of Magisk for that device. The special version of 5.4.1 MagiskManager and Magisk 14.4 that was release just for that device. But with 5.4.2 and 5.4.3 MagiskManager and with 14.5 Magisk I get this problem.

Attached are some logs, captured right after this happened, from the system through Catlog and from Magisk.
[Magisk] Didgeridoohan:
I'm not gonna pretend to know anything about this, but I have it from

very

credible sources that this should be fine. It's caused by the data length being longer than the actual string after modification. It's got to do with the utility used to convert dtb to dts.

I'm just parroting here, so I will not be able to answer any follow-up questions. :laugh:

The only thing that looks out of place is in the AFWall log:

E/AFWall (22459): libsuperuser error -2 on command 'iptables -P OUTPUT DROP'

No rejected su requests or errors in the Magisk log. Have you asked in the AFWall thread?

The magisk_debug.log (it's in /data) shows a lot of useful information, so saving that right after the issue occurs might show something.
[Magisk] TheDevFreak:
Alright issue:

On Magisk 14.2 or LOWER i CANNOT flash modules from TWRP with reason: "Magisk is not installed", also cannot be flashed from magisk manager with reason "Magisk is not actiavted!"

On Magisk 14.3 or HIGHER i CAN flash modules, however any that use /system do NOT work, seems to be an issue without mounting the system mirror.

/data/magisk_debug.log attached
[Magisk] bggold:
First time since upgrading my pixel xl 2, 8.0 nov with stock kernel to magisk v14.5 (1456), I woke up to the lockscreen due to a softboot. I tried to unlock the device and it continued to softboot. The only way to get it to boot was to do a vol - power.

Here is the log, not sure if it contains what the cause might have been.

Thanks
[Magisk] Hung0702:
Is this a normal sized cache? Anyone know why magisk logs are so big? Or is this just a weird thing that Android/DiskUsage does when looking at cache?

Stock 7.1.1 (NMJ32F), Essential Phone, Magisk v14.5

EDIT: weird, the image didn't attach.

[IMG="Here it is on Imgur"]https://i.imgur.com/gNN8H2Q.png[/IMG].
[Magisk] ves626:
I'm having same problem as [MENTION=8751670]killdir[/MENTION] above, after the november update on my Xiaomi Mi A1

The apps are crashing very often...It does crashing until the phone is completely freezed.... Even sometimes the phone restarts itself into bootloop....

I'm attaching magisk_debug.log
[Magisk] jenslody:
I use AFWall on my phone and never had any errors like this.

Does AFWall has permanent root access ?

Did you try to revoke root rights for AFWall and regrant them ?
[Magisk] Didgeridoohan:
Not normal... There is a bug where a constant restarting of the Magisk daemon might cause log spam. Might be what you're seeing. Should be fixed for the next version.

No failed su requests there. Everything looks normal...
[Magisk] ludditefornow:
Failed install MI A1

Hi, I cannot find Magisk 14.5 in the app draw after install with TWRP. Please see attached recovery.log as requested.

On November version. Have flashed stock rom and attempted reinstall.

Did not wipe data, though.

Have attempted uninstall, then copy stock boot image and then install Magisk.

Have attempted uninstall, then copy stock boot image, then install TWRP, and then install Magisk.

Still nothing in app drawer.

Any suggestions?
[Magisk] Az Biker:
14.5 won't be in the app drawer, only Magisk Manager will. Open Magisk Manager and it will confirm that 14.5 is installed.
[Magisk] cb474:
Yes, AFWall has permanent root. I'll try revoking and regranting root access. Thanks for the suggestion.

Can you tell me what version of Magisk and MagiskManager you're using and what phone you have? As I said in a post above I'm using the beta version, 5.4.3 MagiskManager and 14.5 Magisk, because I'm on a Pixel 2. The Pixel 2 apparently is not even the same as the original Pixel and required changes to Magisk to root, so it may have issues that other phones don't have.
[Magisk] ludditefornow:
Thanks, but there is no magisk manager in there, either. The Op states that the manager is bundled. Yet there is not app whatsoever.

If I try to manually install 5.4.3 manager it says there is a conflict with an already I stalled app.
[Magisk] Az Biker:
I just flashed 14.5 (1456) today, and it automatically installed Magisk Manager. Manager is the only app I show in my app drawer.

Here are the steps I followed without any problems. maybe it'll help you.
[Magisk] rahulk096:
Can't install on my redmi note 4 with orio ROM...
[Magisk] teddy0209:
The rom you're using is patched for supersu or alike... You need a clean boot.img...
[Magisk] SacredDeviL666:
Thread/posts cleaned again :eek:
[Magisk] DodoGTA:
[MENTION=4470081]topjohnwu[/MENTION] Device: Samsung Galaxy Trend Plus (GT-S7580)

ROM: AOSP 7.1.2

Kernel: The one that came with the ROM

Magisk version: v14.5 (1456)

Magisk Manager version: v5.4.3 (64)

Magisk screws up itself in some cases (or after some time and even a soft reboot, I don't know) and thus, Magisk Manager shows "Magisk not installed" (But this actually isn't true, as you'll see below)

But, root access still works when called with "/root/magisk su" command (Regular "su" command doesn't work) and everything else works (Except that Magisk(SU) can't be detected through normal means, /sbin/.core vanishes completely (So no modules, systemless hosts, hide list etc.) and more...)

I think that this issue has existed since Magisk v14.3 (Not sure though)

For the reason, I'm pretty sure that Magisk Hide screws up with the unmounting process, so unmounts are done globally instead of in the process' namespace (This shouldn't happen) and this issue occurs (This issue might also prevent Magisk invicible mode from fully working)

And finally, /data/magisk_debug.log and some screenshots have been attached :)

Note: The "Mount namespace mode" setting in Magisk Manager is left at the default option ("Inherit namespace"), by the way
[Magisk] SacredDeviL666:
Moved few posts to Magisk General Support/Discussion and few been cleaned/deleted again :eek:

A good thread to read for a lot of documented issues/similar issues :- Magisk and MagiskHide installation and troubleshooting

For the one's who loves to start from last post/page of a thread and hates reading OP/minimal requirements while posting in this thread :- [BETA][2018.4.29] Magisk v16.4 (1642)
[Magisk] the show stopper:
14.5 is not working for me neither. i am using a moto z2 force.
[Magisk] DodoGTA:
Do you have SuperSU installed?
[Magisk] the show stopper:
yes i do. i uninstalled it and tried to flash magisk. it did not install again. then i went back to super su.
[Magisk] DodoGTA:
Then give recovery.log again
[Magisk] Displax:
Hi [MENTION=4470081]topjohnwu[/MENTION]

In latest Magisk v14.6 (1468) Magisk Manager is not installed after zip flashing. If I install it manualy in system via apk - it work fine.

In recovery.log there is some errors:

mv: can't rename '/data/magisk.img': No such file or directory
- Found boot image: /dev/block/mmcblk0p2
java.io.IOException: unexpected end-of-contents marker
at org.bouncycastle.asn1.ASN1InputStream.readObject(Unknown Source)
at com.topjohnwu.crypto.SignBoot$BootSignature.<init>(Unknown Source)
at com.topjohnwu.crypto.SignBoot.verifySignature(Unknown Source)
at com.topjohnwu.magisk.utils.BootSigner.main(Unknown Source)
Invalid image: not signed

Full log attached.
[Magisk] imreezm:
Latest beta + manager.

Apps keep losing root access. After adding them, they'll disappear from the superuser menu.
[Magisk] Ja_som:
I had the same issue just now, I flashed 14.6 over 14.5, so I flashed stock boot and after that 14.6, and it is OK.
[Magisk] yung40oz84:
These are 2 odd things that have happened. I first did not pass safety net, and then did.... Also, every time I uncheck the option "preserve force encryption" it re enables it every time I open the app...
[Magisk] aer0zer0:
I am having issues with magisk manager telling me that magisk is not installed

Essential PH-1, Oreo beta 2 8.0.0., stock kernel.

TWRP Logs and ADB logcat of opening magisk, attached, i cant grab the magisk debug logs, as i dont have root to get it. [MENTION=6429309]DodoGTA[/MENTION]
[Magisk] FlavioV:
Just updated to 14.6 from the latest stable build (14.0 I guess?). Works fine but I need to grant root permissions for all apps after each boot. It's like I just installed Magisk.

Also systemless hosts doesn't seem to work, even though it's on in settings AdAway keeps using the native hosts.

Already cleared data for Magisk Manager but it didn't help.

Moto Maxx (quark), latest RR 7.1.2 build
[Magisk] Ja_som:
https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589/post74924316
[Magisk] DenyDarko:
Hey [MENTION=4470081]topjohnwu[/MENTION]

Some feedback for 14.6

LG G5 H850 here.

Installed correctly (using the update inside app).

Thing is, it killed all my modules on reboot and I see plenty of errors.

Log:
[Magisk] Didgeridoohan:
That should just mean that the boot image wasn't signed and shouldn't cause any issues. Now that you've got the Manager installed, is everything working as it should?

Looks like a segfault in the Magisk daemon or similar. Thanks for reporting.

Have you guys tried a clean install of v14.6, to see if there's any change?

Looks like a database issue. The su database had seen some heavy rework lately... Thanks for reporting.

Have you guys tried a clean install of v14.6, to see if there's any change?

Logs or it didn't happen...
[Magisk] topjohnwu:
Just reinstall Magisk and it shall be fine.
[Magisk] Rom:
@topjohnwu

Hello,

I have an Magiskhide issue with Magisk v14 (last Magisk Manager update from today), i don't have log file located in my /data/adb/ folder, mentionned in the main OP.

I want that some of my apps are take in consideration by the Magiskhide module, but theses settings aren't keeping after a simple reboot.

I attach all the Magisk log file i have..
[Magisk] Dieppy:
Can't install any of my modules with new beta version, logs attached.
[Magisk] Jamoeda:
Hi

Thanks for the update [MENTION=4470081]topjohnwu[/MENTION].

When I try to install modules by magisk manager always show this error.

Log attached
[Magisk] Displax:
Yes, working fine. But Magisk Manager should not be installed during zip flashing?
[Magisk] gianton:
It is installed check your installed apps in settings. It shows up in launcher after a reboot.
[Magisk] Didgeridoohan:
Do a clean reinstall of v14.6.

Because there are still things that need testing on a larger userbase.

It should, but sometimes it doesn't.
[Magisk] okgnew:
Random reboots on Essential Phone

I get a lof of random reboots on Essential Phone with Oreo after Magisk installation (without Magisk the device/OS is stable).

I tried Magisk 14.3, 14.5 and 14.6 - they all cause random reboots.

I can't find last_kmsg on my device, so I can only supply dmesg log - please find it attached.

The only Magisk related entries in the log are below:

[ 106.253975] init: starting service 'magisk_daemon'...
[ 106.261242] init: Untracked pid 7228 exited with status 0
[ 106.427683] SELinux: 65536 avtab hash slots, 228073 rules.
[ 106.455734] SELinux: 65536 avtab hash slots, 228073 rules.
[ 106.455756] SELinux: 1 users, 4 roles, 2187 types, 0 bools, 1 sens, 1024 cats
[ 106.455760] SELinux: 91 classes, 228073 rules
[ 106.481652] init: Service 'magisk_daemon' (pid 7229) exited with status 1
[ 106.481666] init: Sending signal 9 to service 'magisk_daemon' (pid 7229) process group...
[ 106.481786] init: kill(7229, 9) failed: No such process
[ 111.254329] init: starting service 'magisk_daemon'...
[ 111.254846] init: property_set("ro.boottime.magisk_daemon", "120234560188") failed: property already set
[ 111.431457] SELinux: 65536 avtab hash slots, 228073 rules.
[ 111.459447] SELinux: 65536 avtab hash slots, 228073 rules.
[ 111.459469] SELinux: 1 users, 4 roles, 2187 types, 0 bools, 1 sens, 1024 cats
[ 111.459472] SELinux: 91 classes, 228073 rules
[ 111.482385] type=1400 audit(1513938111.127:656): avc: denied { search } for pid=7222 comm="Binder:7222_1" name="proc" dev="debugfs" ino=17945 scontext=u:r:priv_app:s0:c512,c768 tcontext=u:object_r:qti_debugfs:s0 tclass=dir permissive=0
[ 111.482405] type=1403 audit(1513938111.880:657): policy loaded auid=4294967295 ses=4294967295
[ 111.485009] init: Service 'magisk_daemon' (pid 7883) exited with status 1
[ 111.485021] init: Sending signal 9 to service 'magisk_daemon' (pid 7883) process group...
[ 111.485146] init: kill(7883, 9) failed: No such process
[Magisk] xnhw:
v14.6(1468) leads to bootloop on Honor 6x(with unofficial Lineage OS 14.1). Actually, it never works after v 14.0 on my device.

---------- Post added at 12:49 PM ---------- Previous post was at 12:47 PM ----------

logs:
[Magisk] Shen Ron:
No idea what's going with this one but can't use some modules and other issues that I can't include since this is not the thread for it.
[Magisk] Didgeridoohan:
The Magisk debug log would be much more useful (there are no errors in those logs you've posted). You'll find it in /data/adb/.

I would first restore a stock untouched boot image and then flash v14.6 again. If that doesn't work uninstall and reinstall. If it still doesn't work, more logs.

Logs or it didn't happen. (/data/adb/magisk_debug.log)

Try swiping both Managers from the recents list and open one of them again.

If the Manager can't get internet access, your setup must somehow be restricting it... I'd download Manager v5.5.0 from the release thread and download that manually.

Logs or it didn't happen. (/data/adb/magisk_debug.log)

Logs or it didn't happen. (/data/adb/magisk_debug.log)

I would first restore a stock untouched boot image and then flash v14.6 again. If that doesn't work uninstall and reinstall. If it still doesn't work, more logs.

Logs or it didn't happen. (/data/adb/magisk_debug.log)

Logs or it didn't happen. (/data/adb/magisk_debug.log)

---------- Post added at 16:55 ---------- Previous post was at 16:53 ----------

Logs or it didn't happen. (/data/adb/magisk_debug.log)
[Magisk] Shen Ron:
Here it is and I already tried reflashing the stock bootimage multiple times already but I'm wondering if magisk can be installed on a firestick:rolleyes:
[Magisk] aer0zer0:
[MENTION=4667597]Didgeridoohan[/MENTION] I have tried clean through twrp on fresh os install, upgrade over existing magisk...nothing, just says it's not there.
[Magisk] copota:
Attached is my log.

I went back to 14.5, so to get you a log for 14.6, I had to re-flash 14.6, then re-flash my recovery since it gets wiped out.

I hope this helps.
[Magisk] pWEN:
Stuck at boot logo ("Google"), then not. Am on a Pixel (sailfish) 32GB model.

I flashed to stock 8.1 (sailfish-opm1.171019.011-factory-56d15350.zip), then did "fastboot boot twrp-3.2.1-0-sailfish.img". It decrypted the filesystem with my PIN. Then I flashed ElementalX (ElementalX-P-3.00.zip), and Magisk (Magisk-v14.6(1468).zip), and then unplugged the USB cable and rebooted to system. That's where it hung at the Google text logo, and after five minutes (much longer than it's ever taken before), forced it to reboot by holding the power button. After it did so, it gave the "internal problem" error message, but everything seemed to be installed fine. ElementalX is installed, can toggle settings in its app, and Magisk is installed and passes SafetyNet. Did another reboot to just make sure.

Despite it working, I get the feeling something didn't go entirely right, so I've attached logs for Magisk and ElementalX just in case.
[Magisk] Legend_dimebag:
for the "internal problem error message" this is the solution:

Q: After flashing Magisk, my device will show a scary popup saying "There's an internal problem with your device. Contact your manufacturer for details"

A: This is caused by dtbo image patched to remove AVB 2.0 of the vendor partition. This is required for allowing you to mount vendor to rw and make modifications

If you never plan to modify the vendor partition, in Magisk Manager, "Uninstall > Restore Images" to restore the images, check "Preserve AVB 2.0/dm-verity" box in Advanced Settings, then reinstall Magisk via the app.
[Magisk] chudy_85:
New magisk not work with my p9. After flash using magisk manager or TWRP on stock boot I have boot loop and after this I go to erocovery. Only solution it's back to 14.5 magisk

Wysłane z mojego EVA-L09 przy użyciu Tapatalka
[Magisk] Sam Nakamura:
All root permissions for my apps are gone after updating, I can re-enable them just fine but they're gone as soon as I swipe magisk manager from recents and I have to grant root all over again for all apps... It never gets to a point where it sticks...

OxygenOS open beta 19

Magisk 14.6

Blu_spark's kernel

-if logs are needed I'll place them -

--------------

I already cleared magisk manager app data and dirty flashed ROM, kernel & magisk

--------------

Seems clearing app data again followed by re-downloading magisk manager and re-installing the latest version made the root privileges stick finally... Weird :cyclops:
[Magisk] pWEN:
I just tried that and it didn't work. I went into the Magisk app, clicked Uninstall, clicked "Restore Images". It said it was successful, so I checked "Preserve AVB 2.0/dm-verity" on the main page of the app under "Advanced Settings". Just to make sure, I closed the app, re-opened it, and it was unchecked. I re-checked it, and powered off the phone without leaving the app. Went into bootloader, fastbooted into TWRP, and reflashed Magik. Phone booted up, and got the error again. I just opened the Magisk app, and "Preserve AVB 2.0/dm-verity" is unchecked again. Still passes SafetyNet.

I just looked on the official Magisk stable thread and saw this: If dtbo.img is detected on your device, KEEPVERITY is enabled by default. It's not checked when I open the app, so I'm guessing my phone either doesn't have verity, or the app isn't detecting it properly. I know thedude420 on here did a dtbo.img patch to make that error go away, but the Pixel firmware lacks that individual image file, so maybe the issue is related to that?

Edit: attached new Magisk log
[Magisk] godofsalt:
Needed to shorten your quote, hope you don't mind...

Anywho, I will try to get the updated Manager App. And go forward with that. I see have asked for that, the "Magisk Debug Log" with many folks, that state they have an issue but really have any support for thier issues...

Bit clouded up, but thought the Manger was only with the full Magisk zip.???

Thanks for the in site. Actually this "Internet not contected" has only came up in the last update (1455)....

Thanks again sir!
[Magisk] xTMODx:
Have the Galaxy Note 8 N9500 and Magisk 14.5 worked good, tried update with Magisk Manager stuck on Samsung Logo clean install after rom flash also stuck on Samsung Logo here are two log files, one created after clean install and the second is created after i installed over the first run
[Magisk] Strephon Alkhalikoi:
From your description your /system partition is empty.
[Magisk] SacredDeviL666:
Morning/Afternoon/Evening/Night XDA Folks....

https://xdaforums.com/showpost.php?p=74778756&postcount=4531

https://xdaforums.com/showpost.php?p=74881761&postcount=4533

Release note :- [2018.4.29] Magisk v16.4

Appreciated :highfive:
[Magisk] gorilla p:
I'm having issues with 14.6 on my Beelink GT1 box.

I was able to flash Magisk 14.0 via TWRP with no issues.

14.3 and 14.6 have failed via TWRP, but I was able to update 14.0 to 14.3 via Magisk manager by patching the boot image located at dev\block\boot.

There is nothing in Imagemanager that lets you set that location in the GUI as there was in previous versions of Magisk Manager.

In theory, it should be needed, but when attempting to select it during the boot image patch process in Magisk Manager for 14.6, the update fails.

I have attached logs from TWRP and Magisk from the update attempts/
[Magisk] latifdnb:
Working.... ROM BOSS 8.1.0
[Magisk] Legend_dimebag:
you have to use this method via Magisk manager and fastboot, not via twrp .....

Rooting with Magisk

Download the Magisk Manager from the official thread and install it.

Grab a boot image to patch (either the one from the latest factory image or a custom kernel one) and push it to your device:

Code:

adb push <path_to_file> /sdcard/Download

Open Magisk Manager and click the Install button.

Click "Install" at the first prompt then choose "Patch Boot Image File". A file manager will pop up.

Select the boot image you want to patch and let Magisk Manager patch it.

Pull it off your device:

Code:

adb pull /sdcard/MagiskManager/patched_boot.img

Reboot into the bootloader:

Code:

adb reboot bootloader

Flash the boot image and reboot.

Code:

fastboot flash boot patched_boot.img

fastboot reboot

Open Magisk Manager and you should be rooted!

remember to activate the 2.0 dm verity flag before patching the boot image
[Magisk] nightraving:
Can anybody help me out here? When rooted with magisk 14.6 and without xposed framework installed, root check seems to be returning as rooted properly. However, anytime I go to flash xposed it then returns as not rooted. I'm using new kernel, and xposed framework 89. I didn't seem to have this issue until I tried a couple of different kernels out, but as far as I'm aware they should be compatible, right? I've tried reflashing OOS, magisk, new kernel, xposed (in that order) numerous times and it always seems to return as not rooted when I flash xposed, but like I say xposed was working fine with root previously. Termux (terminal emulator) returns root with su command and I can still seem to give apps root permissions that ask for it so I'm just a bit stuck as to what to do. Is there a particular order which I should be flashing? Any help would be greatly appreciated.
[Magisk] godofsalt:
Hey Didgeridoohan hope you see this.

Issue- Manager app, ... "No Internet Connection".... Even though I was on WiFi...

FIX- Uninstall Magisk Manager. Boot to Recovery and Flash the current (App 5.5.0 in this case) Magisk Manager. Wipe all Cache's (including dalvik system cache). Reboot. Profit!

Thanks for that tip. Was rather concerned about going on the the Latest Build seeing I had a stupid issue!

Tanx