yashsingh1/xdaforums huggingface dataset:
[Magisk] MikeyLee:
I've been scouring for 2 days trying to find a legit solution to data/adb/magisk_merge.img mount failed and nothing. I posted in here last night and my post is gone. I'd appreciate any help with this issue. I'm unlocked, rooted, Nougat, Ulefone T1

this was working fine until I updated. It also works fine on my Redmi Note 3. These will also NOT install via TWRP either.
[Magisk] Badger50:
Does it work if you just download V4A and flash it in twrp?
[Magisk] MikeyLee:
No none of the modules will install. I get the same error with all of them, either with Magisk or with TWRP.
[Magisk] Badger50:
Sorry I missed the twrp part. Does clearing the magisk app data and cache help at all??
[Magisk] will5:
Guys, in my case sixaxis controller app wont sync anymore after installing magisk on an h990ds (will sync again when changing to supersu). A log will help with that or just logs the boot proccess? Thanks
[Magisk] unhappybirthday:
Same thing happened to me after I used Magisk Manager to update Magisk. I uninstalled magisk (through the Manager) and installed the latest version via TWRP. Modules installed fine after that.
[Magisk] Sebastl:
[MENTION=5065917]BertlBrown[/MENTION]

Normal behaviour of that losetup cmd.

Your loops are in /dev/block/loopX

Try the following to see if it is the same problem

Now check via mount cmd if it is mounted (should be as mount utilizes BLKROSET)

If yes try to mkdir or touch something in /sbin/.core/IMG

If it says "read only file system" and the mount cmd lists RO instead of RW you are in the same boat.

Actually the loops feel/behave like they should/do when ISO9660 is mounted....
[Magisk] MikeyLee:
I uninstalled Magisk using Manager. Flashed the latest via TWRP. Tried to install a module and still get the same error I'm stumped
[Magisk] BertlBrown:
[MENTION=1959263]Sebastl[/MENTION]

You're right with the placement in /dev/blocks. Should have read magisk log instead of trusting losetup blindly ;)

But it's mounted rw at first and remounted ro at the write attempt. This is due to low level errors:

MIX_2:/data/data/com.termux/files/home # mount -o rw /dev/block/loop0 /sbin/.core/img/

MIX_2:/data/data/com.termux/files/home #

dmesg | grep mount

[ 547.004254] (0)[6812:mount]EXT4-fs (loop0): couldn't mount as ext3 due to feature incompatibilities

[ 547.004514] (0)[6812:mount]EXT4-fs (loop0): couldn't mount as ext2 due to feature incompatibilities

[ 547.006884] (1)[6812:mount]Buffer I/O error on dev loop0, logical block 0, lost sync page write

[ 547.007213] (1)[6812:mount]EXT4-fs (loop0): mounted filesystem with ordered data mode. Opts: (null)

MIX_2:/data/data/com.termux/files/home # grep img /proc/mounts

/dev/block/loop0 /sbin/.core/img ext4 rw,seclabel,relatime,data=ordered 0 0

MIX_2:/data/data/com.termux/files/home # ls /sbin/.core/img/

lost+found
​

I copied the image to my Linux desktop. It had no errors but was empty there, too. At least it has been writable.

I don't know what's the reason for those low level errors on the device and if this is related to error 13 at boot. Maybe there are two issues?
[Magisk] Sebastl:
Its mounted as RW first because the Mount command invokes a ioctl BLKROSET immediately before mounting after it fails the first try. See the toybox mount src topjohnwu posted somewhere.

With the same approach i can manually force it to get "written":

0x125d = BLKROSET

0x125e = BLKROGET

The files are indeed readable from there - until kernel flushes or something. And of course until dismounted ;)

In my opinion the loops are kernel write protected either on purpose or accidentally. It is exactly as mounting of ISO files is supposed to work in terms of RO/RW.

Could you retry the Mount dmesg grep when you try to write to an ISO ?

I also tried renaming to exclude that they dont treat .img as ISO9660 ;)

But your device is also a MTK interestingly.

Open for any further ideas !
[Magisk] BertlBrown:
[MENTION=1959263]Sebastl[/MENTION]

Mounting an iso will result in a ro from the very beginning as the fs is forcing to the of the device. So that will tell nothing.

But I did try to write to the loop device with dd or cat and this resulted in a permission denied error.

try after losetup but before mounting:

echo test >> /dev/block/loop7
​

Keep in mind this will destroy the image, on working devices!
[Magisk] PRADEEPHONDA:
Solved by few trials by me but below method is what works for me;

Flashed Stock boot again

Flashed Magisk V15.3

Flashed No verity

Boom

Booted my Samsung note 5.

Every modules working.

;)
[Magisk] Artim_96:
Strange. Dm-verity should only be tripped when mounting system rw or something like that. But at least it's working
[Magisk] PRADEEPHONDA:
I don't know but someone with same handset & firmware might shed some light whether if they are experiencing the same...! If yes then they can try what I have tried....,

If you are keen on this then may be you can look into my log & tell me if there is something I should be considering here.

I've tried every possible methods to get this working so this the only method where my phone gets back to home screen...otherwise it's just flashing Samsung logo... What a relief it was to me get it working....! Pheeew...!
[Magisk] nidico100:
Hey,

I tried to search, if the problem is already known, but i can't guarantee, that i didn't miss it.

I just update my OnePlus 3 to Android 8.0 and installed newest Magisk. Root and so on is working, but I can't install modules inside Magisk. No matter which Module. And even manual install via TWRP is not possible.

Here is the log:

- Copying zip to temp directory
- Installing Xposed_Framework_SDK_26-90.1-beta3_Systemless.zip
- Mounting /system, /vendor
update-binary[73]: unzip: not found
! Unable to extract zip file!
Failed!
! Installation failed
[Magisk] Zacharee1:
Everyone, if you have a log to share, especially a long one, please use a service like Pastebin or Gist, instead of putting it in your post.

It creates unnecessary clutter, especially for mobile users, and can disrupt other discussions occurring in the same thread.
[Magisk] sq_dev:
I have problem with magisk root rights. Magisk reactualisate (cyclic) the app gui permanetly. This is the logcat output from magisk:

12-18 09:46:48.166 8117 8117 W System.err:	at com.topjohnwu.magisk.container.Policy.<init>(Unknown Source:22)

12-18 09:46:48.166 8117 8117 W System.err:	at com.topjohnwu.magisk.superuser.SuReceiver.onReceive(Unknown Source:64)

12-18 09:46:48.260 1461 2875 I ActivityManager: START u0 {flg=0x10000000 cmp=com.topjohnwu.magisk/.superuser.RequestActivity (has extras)} from uid 0

12-18 09:46:48.298 1461 2875 D ActivityTrigger: activityStartTrigger: Activity is Triggerred in full screen ApplicationInfo{eccd920 com.topjohnwu.magisk}

12-18 09:46:48.298 1461 2875 E ActivityTrigger: activityStartTrigger: not whiteListedcom.topjohnwu.magisk/com.topjohnwu.magisk.superuser.RequestActivity/91

12-18 09:46:48.298 1461 2875 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{eccd920 com.topjohnwu.magisk} is now in focus and seems to be in full-screen mode

12-18 09:46:48.298 1461 2875 E ActivityTrigger: activityResumeTrigger: not whiteListedcom.topjohnwu.magisk/com.topjohnwu.magisk.superuser.RequestActivity/91

12-18 09:46:48.324 1461 2875 D ActivityTrigger: activityResumeTrigger: The activity in ApplicationInfo{eccd920 com.topjohnwu.magisk} is now in focus and seems to be in full-screen mode

12-18 09:46:48.324 1461 2875 E ActivityTrigger: activityResumeTrigger: not whiteListedcom.topjohnwu.magisk/com.topjohnwu.magisk.superuser.RequestActivity/91

Has any one a fix for this problem? (Sony XZ)

On Sony XZP works.
[Magisk] DB126:
Yea you can. Just be a little innovative with the url so XDA doesn't recognize it as such. Imbedding a huge dump is the best way to have your post ignored.
[Magisk] SacredDeviL666:
And again cleaned and added Tags.

Kindly use hide tags while posting log if you cannot share a link/url for log.

Tag :- [ HIDE] post your log text/code [/HIDE]

*without the space after [

Edit:- Apparently it would show in XDA Labs still not on Tapatalk/Xda Legacy or desktop versions, so as [MENTION=5488402]Davey126[/MENTION] mentioned remove the .com from url or www. or https: to post logs link
[Magisk] igknight:
I posted this over at the Google Pixel 2 XL thread too, but figured I'd post it here too.

I've had my Pixel 2 XL since it came out, had it rooted via Magisk without issues, but had some problems with the January update. Decided to flash the factory images for February, but needed to unlock critical first. I unrooted my phone, unlocked critical, flashed the Factory images without issues, but Magisk won't patch the book image.

I'm not using TWRP, encrypted phone, so I installed Magisk Manager v 5.5.5(91), but when I select the boot image from the factory image download, I get the below:

- Device platform: arm64
- Extracting files
- Use boot image: /data/user_de/0/com.topjohnwu.magisk/install/boot.img
! Invalid Uri
! Installation failed

I've tried both beta and stable editions of 15.3

Any help is appreciated.
[Magisk] Didgeridoohan:
Might be that your Manager doesn't ask properly for storage permission. Make sure it's granted.
[Magisk] igknight:
It does have permissions, I thought that at first, saw it didn't gave it permissions, same thing.

I just got done with another factory wipe, and image install, same thing.
[Magisk] Badger50:
The Didge man will probably figure it out, but have you considered fastbooting temporary twrp then flashing the magisk 15.3 zip?? You'll have to remove your lock screen security first, but it may work. TWRP will not be installed with this method.
[Magisk] Didgeridoohan:
Grab a logcat.
[Magisk] igknight:
Logcat won't log anything, comes out blank.

Didn't think about removing the lock screen and doing it that way. I'll give it a try.

That did work. Thanks.
[Magisk] BertlBrown:
Permission denied when writing to magisk.img

[MENTION=4470081]topjohnwu[/MENTION]

[MENTION=1959263]Sebastl[/MENTION]

So we have those devices where mounting magisk.img failes with "13: Permission denied". Setting up a loop device with any image in /data/adb/ will deny when writing to it, while root can write to the image files when not using a loop device (#4881 ... #4942 ... #4948). This results in mounted filesystems to be shown as ro, but the access is denied also when writing to the loop device directly without mounting it.

Everything works if the image is in /storage/sdcard0. I could even mount magisk.img and write to it when moving it there.

As the simple access rights are correct, there has to be something else denying write access for the loop device.

I have no knowledge about SELinux or Android security, don't know where to look for meaningful log. Any ideas?

ls -Z shows

u:object_r:adb_data_file:s0

for /data/adb/magisk.img and

u:object_r:sdcardfs:s0

for /storage/sdcard0/magisk.img. Is there a chance that magisk sets a proper label for magisk.img?
[Magisk] Didgeridoohan:
It's known and will be looked into in due time. No need to bump.

Edit: just want to clarify that this was a response to a now deleted post.
[Magisk] Sebastl:
[MENTION=5065917]BertlBrown[/MENTION]

Great finding !

I can confirm that mounting/writing to magisk.img works manually if the the file is on /sdcard

About the SELinux thoughts: When i started observing this problem i switched to Permissive mode to exclude SELinux as a problem.

I just rerun my tests: Same Results with Permissive/Enforcing
[Magisk] vibrantliker:
Where can I get a copy of 14.5(1456)?
[Magisk] Governor_666:
Hello.

May i ask how is your device reacting with magisk?

Does it work properly?

I'm asking this because i have sm-g388f model too and i'm interested in trying to install magisk, but i have absolutely no clue about debugging and if getting it to work properly requires some expert level skills with scripts, it's out of my league.
[Magisk] CM Scofield:
SafetyNet doesn't work

I'm sorry if I post in the wrong place. I'm new here.

I'd install Magisk perfectly, but I don't know why SafetyNet doesn't check green. Any version I put on my phone. Root works normally, but SafetyNet don't. I'm desperate! ='(
[Magisk] sam0056:
Have you tried the universal safety net patch search on the forum usually it fixes the problem.
[Magisk] :
Hello

I've installed magisk from recovery in my Redmi note 3 (6.0 MM). Now whenever I want to install update or install module , I've encountered magisk force close stating OutOfMemory exception. What should I have to do now ?

(Couldn't upload SS by XDA app)
[Magisk] PinoF75:
Hello,

I installed magisk 15.3 several times. But when I go in superuser page I cannot sede the apps which have granted access.

Why?
[Magisk] swat4samp:
I am facing the same issue. Along with this, magisk is asking for root every time even if i allowed app to grant access forever. Log file is empty too. I'm on latest Omnirom on Op3.
[Magisk] guest4711:
Try the newest version, which should take care of it:

v5.5.5 (93)

Remove JNI requirement, Magisk Manager is now pure Java

Update the method to handle global su database (v15+), should fix root request not saving issue on many devices

.

You may find it using the custom update channel https://raw.githubusercontent.com/kantjer/MagiskFiles/master/updates/kantjer.json

See also [UNOFFICIAL] next version Magisk and MagiskManager snapshots - https://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901/post70157494
[Magisk] 12Fully:
Try clearing the app data/cache
[Magisk] fusk:
Make magisk sort modules after the version of android you have installed. A module maintainer have to tag their modules with android versions. So if you're running 8.1 you don't see modules for android 8.0 or 7.x.x. The maintainer then have to tag their modules with the new version, implying that they have actually tested that it works with the different version of android.

This would avoid the clutter of outdated modules on newer versions of android.

Thoughts?
[Magisk] counterfeit187:
I'm using magisk on a new rom, its a fork of LineageOS 15.1 for OnePlus3t Android 8.1 and while everything works, it doesn't show apps with root Access in the superuser menu, and doesn't make any log after granting superuser access to any apps. Any help?
[Magisk] tacofart:
So Im running into an issue with 15.3 on the pixeldust rom, with a Pixel 1.

No issues with safetynet or root, but as soon as I enable systemless hosts, I lose safetynet. I think I ran into another issue where upon restart (with systemless host on), I could no longer log into my phone as my password wasnt recognized. Anyone else run into this?
[Magisk] CM Scofield:
I try. Doesn't work and I truly don't know why. =/
[Magisk] counterfeit187:
Not fixed for OnePlus 3T yet on that one
[Magisk] khanjui:
Almost fixed it on my Mi 5s Plus [LineageOS 15.1 (8.1.0), F2FS /data and /cache]. Some apps are showing up on "Superuser" tab and never asks for root confirmation again (AdAway, EX Kernel Manager), some apps are not showing up and still asks for a confirmation every single time (Devcheck, Nova Launcher).

I wasn't able to use the latest APK by the way, it was FC'ing. Instead, I used the one from 15.3 (1531).
[Magisk] martyfender:
Did you read this in the op of the unofficial thread:

"Magisk Manager: The snapshot APK is signed with a different key than the release APK so you can't install snapshot magisk manager over magisk manager from Play Store. You will need to uninstall existing Magisk Manager and install the snapshot APK afterwards."
[Magisk] CJ-Wylde:
Not sure if this is where I should post this... But Magisk 13.0 (b3da28e) passes SafetyNet without modules installed. With any of my 3 modules I use it fails: Google Dialer, Google Pixel Sound Set, OP3 TP Firmware update. I'm on a OnePlus 3T with FreedomOS v2.10 without Viper/A.R.I.S.E. Your Magisk is working just fine... It appears devs may need to update their modules to keep the SafetyNet passing.
[Magisk] ottopilot:
No modules for now ... holding off. Looks like v13 maintaining root without CTS error, but some apps not showing on play store (usual suspects). Still verifying.

Used TWRP - uninstalled with Magisk-uninstaller-20170608.zip, then installed Magisk-v13.0(b3da28e).zip... reboot.

New version of Magisk Manager bundled with v13 beta. Looks very different.
[Magisk] Shen Ron:
Same problem with the 4th beta. Magisk installed over v12 and boot image and magisk files present but the app says magisk is not installed. Also tried clean flashing it and it says magisk image can't mount.
[Magisk] Windforce0511:
Beta 1e87780 with 3 moduels - safety net pass

Latest beta b3da28e using the same moduels - safety net fail

Device - Galaxy S6
[Magisk] spuri78:
V12 wasn't working for me on 6p Nitro rom June update. So, I had to tick 'Magisk Core Only Mode' in settings and reboot which fixed it.
[Magisk] biggdevon:
How long ago did you try 1e87780?
[Magisk] Captain_Throwback:
Just tested this and both fail. I think the issue is when you flashed the latest - not which one you were using.
[Magisk] wrongway213:
It actually doesn't matter when flashed, just when Google updated your Play Services. I had SN passing for a while on the last build, 1e87780, and it failed on that build after GPS upgraded, after working for over a day. It seems to me you understand this issue by the way, just clarifying this for others who are reading. :good:
[Magisk] teddy0209:
I can confirm SN is failing now... Even on v12...
[Magisk] crankiro97:
Idk about other's issues but my SN is passing. Beta v13
[Magisk] ipdev:
Not sure if it helps.

I run lineage 14.1 nightly on my main device. (Nexus 7 2013 WiFi - aka : flo)

Magisk v12 (No modules) just root and su hide. (Running magisk and magisk su on it since February or March don't remember when I moved my daily driver over to magisk su.)

Just updated tonight from 0606 to 0613 and v12 failed the SafetyNet check.

I :

Flashed magisk unistaller. (TWRP)

Flashed boot.img from lineage-14.1-20170613-nightly-flo-signed.zip (Fastboot)

Uninstalled​ MagiskManager 4.x

Flashed Magisk-v13.0(1e87780).zip (TWRP) - by mistake, my download folder is a little full on this device.

Re-flashed uninstaller (TWRP)

Re-flashed boot.img lineage-14.1-20170613-nightly-flo-signed.zip (Fastboot)

Uninstalled MagiskManager​ 5.x

Flashed Magisk-v13.0(b3da28e).zip (TWRP)

All seems to working so far. (Again no modules, only root and su hide. SN seems to pass.)

Edit :

Forgot to mention I am signed up as a Google Play services tester.

(Google Play services 11.0.56 (438-156935310)
[Magisk] akk29:
Do we know which know which version of Play Services is causing the issue. I'm on 11.0.55 and still passing on v13.
[Magisk] Nevermindthelabel:
I was wondering that too. I'm on the beta 11.0.56 and failing on 12 and 13 (OP3 and Flo)
[Magisk] demonoidmaster:
Edit: nvm
[Magisk] ipdev:
[MENTION=5996385]Nevermindthelabel[/MENTION]

What are you running on your flo?
[Magisk] Nevermindthelabel:
Latest AOKP nightly, Magisk v 13(1777d9f) and just systemless hosts adblock
[Magisk] teddy0209:
Lucky you, I have two devices running magisk, and now they're failing... Even the M9 running stock sense...
[Magisk] ipdev:
[MENTION=5996385]Nevermindthelabel[/MENTION]

Try updating to Magisk-v13.0(b3da28e).

I will try aokp_flo_nougat_nightly_2017-06-13_ota on my other n7 and see what happens.

(Might be a day or two before I have the time.)

What recovery do you have installed?

aokp_flo_nougat_nightly_2017-06-13_recovery

mob30x (Stock recovery)

twrp-3.1.1-0-flo
[Magisk] topjohnwu:
Hello guys, I was told Google has updated the SafetyNet policy....

No worries guys :)

(Modules + root works)

https://twitter.com/topjohnwu/status/874865768181243904
[Magisk] JERW28:
[MENTION=4470081]topjohnwu[/MENTION]

Does anyone else have this issue with v13.0 Betas? Please see details and logs here https://github.com/topjohnwu/Magisk/issues/236
[Magisk] khanjui:
That's what I did exactly. It was force closing.

Update: Tried again with today's build, app is working fine till I install the zip from TWRP.
[Magisk] trax69:
same for me OP3T LineageOS 15.1 (8.10_r11). Latest Magisk beta was force closing.
[Magisk] guest4711:
See three posts above yours - https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589/post75523385

Edit: Just noticed you tried without luck. So you should wait for the next updates and retry... Good luck!
[Magisk] johnholley123:
This is generally caused by your data partition being f2fs, you can fix it by formatting to ext4.
[Magisk] miguemely101:
I'm not a fan of doing evasion of filters, to be honest. I see your point--

Ok, it seems a mod is fine with that. Noted. I'll do that next time.

---------- Post added at 01:04 AM ---------- Previous post was at 12:57 AM ----------

Out of curiosity, could that also reflect on the same issue I'm having with the bootloop, as it stops here and reboots:

02-05 18:21:49.151 348 535 I Magisk : * Setting up internal busybox
02-05 18:21:49.161 348 535 I Magisk : * Mounting /data/adb/magisk.img
[Magisk] SnakeByte:
Just flashed Magisk v15.3.1 on Samsung SM-G530W running Lineage 15.1. Root access gained, but the system is pretty slow right now. Have to do some testing to find the reason.
[Magisk] DodoGTA:
This issue is right now better suited for this thread: https://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901
[Magisk] sathish86:
Could someone give me the link for universal safetynet fix please?
[Magisk] swat4samp:
I didn't change filesystem. It is ext4 by default. I even tried unofficial magisk but it didn't work either. Guess i have to wait for new update.
[Magisk] SnakeByte:
Thanks, i'll check it today.
[Magisk] johnholley123:
I would make sure because I never manually changed mine but it was f2fs and I experienced this bug as well.
[Magisk] swat4samp:
My bad, it is f2fs indeed. Thanks for enlightening me. I thought OP3 had data partition as ext4. I was wrong :o

Edit: Is there any fix other than formatting partition to ext4? I really don't want to move to ext4 as f2fs seems solid.
[Magisk] martyfender:
Have you tried this?

F2FS Loopback Bug Workaround

https://xdaforums.com/apps/magisk/guide-magisk-official-version-including-t3577875
[Magisk] Mondor1979:
Still doesn't work on Oreo. Shows boot modified by other application when trying to install it. Any ideas?
[Magisk] martyfender:
You need to flash a stock boot.img, as you boot.img was patched by another root solution, such as SuperSU. If you did have SuperSU installed, I would flash Unsu.zip first then flash your stock boot.img followed by Magisk.zip, all before rebooting.
[Magisk] swat4samp:
Nope, but thanks for the link. I'll try it :good:
[Magisk] Mondor1979:
Like I've explained before I have clean installed non modified OREO Stock ROM. Only thing - opened bootloader and TWRP installed. Still the same. Modified boot mistake. SuperSU shows a kind of mistake also, but it installs after that and works just fine. And Magisk fails to install on non modified system. Also the problem is that there is NO BOOT. IMG on Oreo for Honor 9. I mean no partion (read "file") with such a name in stock ROM. There is kernel.img with the size close to boot.img (16 Mb), but when trying to modify it it becomes only 7mb and if I flash it to kernel or boot the system will never boot again and I have to clean install it once again.

One thing more I've tried is to make a copy of a block which magisk tried to modify but fails in fastboot mode and tried to modify it with magisk and flash it back to boot or just copy back to the block I've copied it from, but still no luck. System fails to start after that. (((
[Magisk] Kuttoosssan:
Magisk manager fc when trying to disable/remove entries from superuser tab.
[Magisk] Kuttoosssan:
Also on a clean flash all superuser user requests stick to "always" if I don't open magisk manager.

After I open manager, no further requests from new apps will stick.

As long as I don't open manager app the requests stick. So nowadays after a clean flash I always open my root requiring apps and grant them root access. Then only I open manager.

My data partition is f2fs. I read about this in the after making the first post. Hope this helps.