yashsingh1/xdaforums huggingface dataset:
[Android Apps and Games] jcmm11:
New problem. Install via Magisk manager works fine. Install via TWRP crashes. 'bash not found'.
[Android Apps and Games] Zackptg5:
Does your twrp not have tar binary? That's the only thing that could be causing this error. That'd be a twrp problem too since tar is a part of Android toybox and every twrp I've seen at this point.

This was also the same error you had initially a while ago
[Android Apps and Games] jcmm11:
These are the results from within TWRP. Queries were (in order)

type tar

tar --help

ls -l /sbin/tar

toybox --version

I notice that TWRP has apparently switched from busybox to toybox

tar is /sbin/tar

usage: tar -[cxtjzhmvO] [-X FILE] [-T FILE] [-f TARFILE] [-C DIR]

Create, extract, or list files from a tar file

Operation:
c Create
f Name of TARFILE ('-' for stdin/out)
h Follow symlinks
j (De)compress using bzip2
m Don't restore mtime
t List
v Verbose
x Extract
z (De)compress using gzip
C Change to DIR before operation
O Extract to stdout
exclude=FILE File to exclude
X File with names to exclude
T File with names to include

lrwxrwxrwx 1 root root 6 1970-01-01 02:30 /sbin/tar -> toybox

toybox 0.7.6TOYBOX_VENDOR
[Android Apps and Games] Zackptg5:
I'm on the go so can't make a test zip but unzip jdsp, open the update-binary, and remove the 2>/dev/null from the tar line. Then see what error you get when you flash it
[Android Apps and Games] jcmm11:
Log is attached. Message is 'invalid tar format'

The problem is that toybox's tar (used by new TWRP) doesn't like it. Magisk Manager is using busybox, which works fine. If you switch to gzip, or bzip2 (which, based on the help output, is all toybox tar understands) you should be fine.

Most people probably won't run into this since TWRP used to use busybox rather than toybox and I doubt they've changed it for older devices. Just for comparison here's the output for busybox tar help (toybox is in previous message)

BusyBox v1.29.3-osm0sis (2018-11-17 02:42:59 AST) multi-call binary.

Usage: tar c|x|t [-ZzJjahmvokO] [-f TARFILE] [-C DIR] [-T FILE] [-X FILE] [--exclude PATTERN]... [FILE]...

Create, extract, or list files from a tar file

c	Create
x	Extract
t	List
-f FILE	Name of TARFILE ('-' for stdin/out)
-C DIR	Change to DIR before operation
-v	Verbose
-O	Extract to stdout
-m	Don't restore mtime
-o	Don't restore user:group
-k	Don't replace existing files
-Z	(De)compress using compress
-z	(De)compress using gzip
-J	(De)compress using xz
-j	(De)compress using bzip2
-a	(De)compress using lzma
-h	Follow symlinks
-T FILE	File with names to include
-X FILE	File with glob patterns to exclude
--exclude PATTERN	Glob pattern to exclude
[Android Apps and Games] jcmm11:
So bzip2 is also not an option. TWRP is missing bzip2/bunzip2, which is called by tar if needed. It's a standalone program, not provided by toybox (is provided by busybox). Which is why bzip2 works fine once your booted.

gzipped works just fine. Attached works.

One more thing. Didn't matter whether I specified hua, nhua, Nhua in the name. It always told me I had a huwai device. So I went with the volume keys.
[Android Apps and Games] Zackptg5:
Oh duh, I see the problem there. Zipname will be fixed in next version.

The tar thing is unfortunate. I tried out several compression methods and went with xz because it was the most effective (smallest size). Guess it'll be back to the drawing board then. Thanks for all of the testing and bug reports, I'll figure something out (gzip wasn't too great at compression)
[Android Apps and Games] jcmm11:
Yeah but gzip is still better than nothing, and we're not talking massive file sizes in any case. File size is why I tried bzip2 first.

gzip still reduces the uncompressed size by about 50%. And, unless you want to pack a decompression package, it looks like gzip is currently the only viable option that works across the board. Of course packing an additional package also negates size savings in the first place, plus complicates the coding somewhat

One thing I'm curious about that I haven't checked is what shell the new versions of TWRP are using. It's possible they've gone with the regular Android shell now (mksh, a free Korn shell variant).

Anyway glad to help out.
[Android Apps and Games] Zackptg5:
Edit: Nevermind, threw the error here too
[Android Apps and Games] Zackptg5:
[MENTION=4487388]jcmm11[/MENTION]

Updated JDSP to unity v2.2. Includes change to gzip for unityfiles and fixed huawei zipname trigger for real this time
[Android Apps and Games] jcmm11:
Fixed!
[Android Apps and Games] wimstefan:
Hmm I've installed the latest JamesDSP module for Magisk 1.80 as it seemed without problems ( at least no error message ) but after rebooting the app is not installed [emoji848]

ROM: AEX official Pie from 22.12.2018
[Android Apps and Games] gk1984:
Same here on my Essential PH-1. Last version that did install the James Dsp app was version 1.8. Stock rom, Android 9.
[Android Apps and Games] backslashV:
Any way to get rid of this white line above the nav bar?

It appears when opening the app.
[Android Apps and Games] Zackptg5:
I changed nothing with the boot script and I can't replicate the error on my end. Try uninstalling and reinstalling it.

Also, the apk is in the jdsp magisk mod directory so you can always install it manually that way
[Android Apps and Games] gk1984:
I have a few times. Even multiple reboots. I just installed the apk manually for now.
[Android Apps and Games] wimstefan:
I went through the uninstall/reinstall cycle several times both via Magisk & recovery to no avail. As a side effect all my music players couldn't play ogg files [emoji848]

After giving up and installing Viper4Android FX all the problems were gone [emoji57]

Latest AEX pie Rom on mido with latest Englezos kernel.
[Android Apps and Games] jcmm11:
Edit
[Android Apps and Games] jcmm11:
People - if you have problems and you want them fixed you need to provide phone info, Rom info, root info, and - most importantly LOGS

[MENTION=6039302]wimstefan[/MENTION] [MENTION=3443130]gk1984[/MENTION] [MENTION=1982196]backslashV[/MENTION]
[Android Apps and Games] whalesplaho:
I just flashed latest version buh no app in app drawer... In magisk shows installed!
[Android Apps and Games] djdelarosa25:
Would be nice to release an update to support notification channels. It bugs me to see the icon on my status bar 24/7, even if I've only enabled it for the headset.

Merry Christmas, everyone!
[Android Apps and Games] TheCelt:
Been out of the rooting modding game for a bit with my OG Pixel XL on vzw, but jumping back in with the 3XL grabbed from Google.

I flashed JamesDSP via Magisk, all seems to be working fine, but I can't add any presets. I get an error "Load speaker.xml fail. File not found or permission denied"

I found some presents in various threads. I have them in the James DSP presets folder in my device's internal memory. I done some searching but wasn't able to find guidance on my issue. I must be missing something, just not sure what.

Any guidance would be appreciated!

TIA
[Android Apps and Games] jcmm11:
I created a preset called My_defaults. Here's what the contents of the folder, within the presets folder, looks like
[Android Apps and Games] hengkidermawan:
excuse me,

where can I get JamesDSP V.1.8

thanks
[Android Apps and Games] Zackptg5:
JDSP has been updated to unity v3.0
[Android Apps and Games] gk1984:
On my Essential PH-1, JamesDSP apk doesn't install and if I manually install it, it force closes. Last working version for me was 1.8 but the previous version I could manually install the apk and everything worked. Attached are install log and Magisk log after a reboot.

EDIT: I just checked, after manually installing JamesDSP.apk after this attempt (getting these logs), the app doesn't force close. However, the app still won't install with the module.
[Android Apps and Games] gk1984:
I started exploring the scripts, comparing version 1.8 with 1.9.3. I'm not a programmer, so I really don't know what I'm looking at or talking about but I do know enough to vagule figure out what's supposed to happen. I was using Text Compare (website) to compare differences in code. The install.sh script lead me to the jdsp.sh script with regards to how the apk gets installed. Attached is a screenshot of a side-by-side comparison of the code between versions 1.8 (left) and 1.9.3 (right). I'm not sure if there's anything missing or broken between the 2, but they do appear obviously different. In particular, I noticed a "done" is present after the command to install the JamesDSP.apk in v1.8 and it's missing from v1.9.3. Unsure if that matters. But I get curious, slightly interested in this stuff, and like to/want to help where possible.
[Android Apps and Games] jcmm11:
For comparing differences you may want to try https://play.google.com/store/apps/details?id=com.difftool

UI isn't the greatest, but it works pretty well.

The missing done is related to the missing while. done signifies (in this case) the end of the while loop. So 1.8 kept trying to install until it got a return code of 0 (which I suspect could be problematic if for some reason the apk refused to ever install)

1.9.3 eliminates the loop and just runs the install one time
[Android Apps and Games] Zackptg5:
Don't undersell yourself. What you're doing now is what I did when I was first learning all of this shell scripting stuff :)

1.9.3 definitely isn't broken because it works fine on other devices so it's likely something specific with yours. The big difference you're seeing between 1.9.3 and 1.8 is that 1.8 starts as soon as possible while 1.9.3 starts when your device is booted (what those 2 props check for).

Can you run these commands and post the results?

su
getprop sys.boot_completed
getprop init.svc.bootanim

You should get '1' from the first getprop and "stopped" from the second getprop. If you get anything else, that would be the problem.

In 1.8, I installed the apk as part of the install if in magisk manager and that's where the "done" came from. The problem there is that with pie, some permissions stuff got changed and so that didn't work consistently anymore so I was forced to remove that and rely on the boot script for all of that stuff
[Android Apps and Games] gk1984:
I ran those commands and I did get 1 and "stopped" as you described. I hadn't rebooted and already manually installed the apk. Does that matter? Should I remove the apk and module, reflash it, then see what these commands return?
[Android Apps and Games] Zackptg5:
Interesting. No need to reflash it. If you want to debug more, send me that script and I'll add some debug stuff to it for you
[Android Apps and Games] gk1984:
I apologize, but what script am I sending? And I don't mind debugging some more stuff or trying to get to the bottom of this.
[Android Apps and Games] Zackptg5:
The jdsp script that you were comparing
[Android Apps and Games] gk1984:
Attached. It errored on the file type, so renamed it from .sh to .txt to upload.
[Android Apps and Games] Zackptg5:
Copy/rename this to where you got it from and chmod it to 0755. Then reboot and send me the jdsp.log file on your sdcard
[Android Apps and Games] gk1984:
I haven't tried it yet but where will I find the jdsp log? I'm getting the file where it needs to go in a minute.

---------- Post added at 02:31 PM ---------- Previous post was at 01:56 PM ----------

For some reason, the log isn't showing up.
[Android Apps and Games] gk1984:
OK. Got the log
[Android Apps and Games] Zackptg5:
Did the apk get installed by the script? This is interesting because nothing printed except the last 2 echos which indicated that the script completed running
[Android Apps and Games] gk1984:
No, the apk did not install. I manually installed it again but now it's force closing when I open it like the first time I tried this version of JDSP. I'll probably try to reinstall the module again later tonight or tomorrow in hopes of it working again.

First time I tried the module with the debug script, the log you added wouldn't write. I tried installing the module 2 or 3 times before the log would write. Still, no apk from all attempts.

And took me a couple of installs before the apk wouldn't force close earlier. It's force closing now so I'll have to give it another go I guess. Not sure why I'm not getting consistent results though.
[Android Apps and Games] Jman420:
I am actually seeing the same issue. Only the module.props file seems to be installed in the Magisk Img... Still digging on my end...
[Android Apps and Games] Audioboxer:
Viper4Android wasn't working on my Nokia 8 Sirocco on Pie, kept asking to reinstall driver (worked fine on Oreo).

Tried to switch back to JamesDSP which worked fine on Oreo too, but on opening the app it keeps force closing. This is with the magisk module. I'll try get some logs.
[Android Apps and Games] gk1984:
With JamesDSP, try uninstalling the module, restarting, then installing it again. I've had to try it a couple of times before it worked for some reason
[Android Apps and Games] jcmm11:
[MENTION=6037748]Zackptg5[/MENTION]

Just tried installing JamesDSP 1.9.4

Steps taken (Sauron already installed)

Flash AML (uninstall)

Flash James (upgrade) (get warning to install AML)

Flash AML (sees Sauron, does NOT see James)

Reboot. James apk is not installed.

Contents of attached zip:

TWRP installation log

Magisk directories for AML, James, Sauron

data/adb/aml/

Edit: just a note to confirm that reverting to 1.9.3 everything worked like it should.
[Android Apps and Games] crankiro97:
Is there a link for 1.9.3?
[Android Apps and Games] james3460297:
This issue on your Z3?

Which media player?
[Android Apps and Games] TheXorg:
I've tried Spotify and Sony Walkman. But i've noticed that it works fine if I only enable bass boost set to 4096 or 8192 taps (it showed a toast saying something that 1024 is not enough, can't remember the exact message). I'm guessing it has something to do with Sony's high-res-audio stuff (don't need it but it's there...) (audio output at 96kHz Samplerate)?
[Android Apps and Games] online10:
Sometimes the speaker config play for headset and the headset configs don't work until headset is replugged.
[Android Apps and Games] james3460297:
This is a bug:eek:
[Android Apps and Games] james3460297:
1024 taps under low frequency for a FIR filter is not enough, so it is recommended to at least 4096 taps for cut off frequency less than 100Hz, with increase small amount of audio latency. For CPU usage, they are almost similar, however less taps less CPU usage.

For other effect should work fine if bass boost have effect.
[Android Apps and Games] TheXorg:
They work, but the audio is interrupted every few seconds. Shall I record it?
[Android Apps and Games] james3460297:
I know what it sound like.

3.5mm or Bluetooth audio?

This could cause by:

1. system give buffer not frequent enough

2. system audio thread timing issue

I will make more test on different devices
[Android Apps and Games] TheXorg:
Both 3.5mm and Bluetooth, especially when using Analog Modelling. Also it happens almost instantly when turning the screen off, but it works fine for some time when the screen is turned on. Could there be something useful in logcat?
[Android Apps and Games] james3460297:
Well, you know kernel tuning, some devices need kernel adjustment, to keep processor run about 600MHz-1.0GHz, it would fine.

Analog modelling is very CPU consumption effect, since it is compute in real time.
[Android Apps and Games] AmolAmrit:
Can you please also make an uninstaller
[Android Apps and Games] kurtn:
Will it work on aosp Oreo?
[Android Apps and Games] kurtn:
Not on lineageOS or AEX moto e condor
[Android Apps and Games] MrBrady:
The Magisk version (JamesDSP) is working fine on my Nexus 6 with SIX ROM. Are there any tutorials or recommended audio setups? Coming from ARISE it's similar but different.
[Android Apps and Games] Zackptg5:
[MENTION=5796885]james3460297[/MENTION]

Here's the latest JDSP (Nov 3rd) with the new aml v2.2

- Edit: OP updated now with Nov 3rd aml 2.2 release
[Android Apps and Games] s8m:
FYI the ZIP says v1.2 but the module itself says v1.3.
[Android Apps and Games] Zackptg5:
Whoops, put the wrong number on there. Reuploaded the attachment in my last post with the fix (just replace the module.prop if you don't want to reflash anything). Thanks!
[Android Apps and Games] james3460297:
Could you email me with logcats, or join me and debug with my custom debug build?
[Android Apps and Games] kurtn:
Mailed
[Android Apps and Games] james3460297:
Thanks for important information, it is probably the key of the solution.

Sorry for wrong typing, let me correct it.
[Android Apps and Games] ahrion:
OP and thread title have been updated to give a more refined look.

Added install, uninstall instructions among other things.
[Android Apps and Games] Audioboxer:
App is force closing for me after install. Android 9.0 on a Nokia 8 Sirocco. Worked fine on 8.1.
[Android Apps and Games] Zackptg5:
Pushed fixed build

---------- Post added at 03:08 AM ---------- Previous post was at 03:07 AM ----------

[MENTION=5796885]james3460297[/MENTION]
[Android Apps and Games] jcmm11:
working now. No version bump?
[Android Apps and Games] Zackptg5:
Nope, just a quick unity hotfix :/

Did bump versionCode though so it'd show up as an update for everyone
[Android Apps and Games] lvbaal:
I'm new to all this and have a beginner's question. Jdsp seems to be working fine. I would like to use another app then Google play music. But these other apps don't use James dsp settings. They appear to use their own equaliser settings. Which app do you guys advice?
[Android Apps and Games] Animouse31:
The latest version 1.9.5 doesn't work for me.

It was successfully installed, but no Audio Manager icon.

I'm using Xiaomi Redmi Note 5 AI with Masik X 1.5 and latest version of Ainur Sauron MK3.

Does someone have the link of JamesDSP previous version? v1.9.4?
[Android Apps and Games] Zackptg5:
Once again, the boot script that install that app didn't change between 1.9.4 and 1.9.5. just install the app manually (it's in jdsp module folder) and/or remove any other magisk mod interfering with it
[Android Apps and Games] BlazeMaster64:
Not working we need v1.9.1
[Android Apps and Games] Zackptg5:
Really? As I stated before, the only way it didn't install is if another module is messing with it, so it's not due to bug in this mod but crap code in another.

Regardless, you can just install the apk like any other app - it's in the jamesdsp magisk module folder

su -c pm install /sbin/.core/img/ainur_jamesdsp/JamesDSPManager.apk

Nothing else changed with this mod - the same files are installed and the same stuff is done during the install

If you can't do the above, you shouldn't be on a developers forum.
[Android Apps and Games] BlazeMaster64:
I have only install Gltools.

Btw i fix it by installing Aml
[Android Apps and Games] lvbaal:
Anybody?
[Android Apps and Games] gk1984:
Did you disable MusicFX from the system apps? That usually helps ensure the EQ you want to use takes priority.
[Android Apps and Games] hengkidermawan:
you may click three dots on right corner, and choose global
[Android Apps and Games] Zackptg5:
JDSP has been updated to unity v3.2. This'll be the last update for a while assuming no magisk changes
[Android Apps and Games] wimstefan:
Does that mean that the development on JDSP did stop?
[Android Apps and Games] Zackptg5:
Nope, it's that I'm stopping for now. Unity's finally at a good point and I'm busy preparing for medical boards. If the jdsp app does get updated, I'll update this zip obviously but I have no idea when that will be
[Android Apps and Games] wimstefan:
Oh I see. Thanks for your lightning fast answer and success with your medical boards! (I first had to look that up not being a native speaker [emoji6] )
[Android Apps and Games] jcmm11:
Good luck with your boards!
[Android Apps and Games] jcmm11:
[MENTION=6037748]Zackptg5[/MENTION]

Good news, bad news ?

Good news is James upgraded correctly.

Bad news - the install routine got "confused" kept asking for volume keys presses, then decided it didn't need them after all since it could tell what I wanted from the name.

Log attached.
[Android Apps and Games] Zackptg5:
Hmm. Logs aren't showing anything. Can you add debug to the filename and try again in twrp? It should prompt for vol key once at the beginning, then pick up the zipname
[Android Apps and Games] jcmm11:
I have to run out so it'll be a bit longer before I can get to this. It prompted twice. Once before the uninstall (generic key press) then again as it started the install (asking for which quality driver). I'll install the previous version first so it goes through the upgrade routine.

It used to not prompt at all.
[Android Apps and Games] Zackptg5:
I forgot to move the app to priv-app. Fixed in 1.9.6 (only applicable to nougat an older roms)
[Android Apps and Games] jcmm11:
Here you go. Recovery log shows the entire sequence (AML (uninstall), James 1.9.5 (uninstall), James 1.9.5 (install), James 1.9.6 (upgrade), AML (install)

Debug log for James 1.9.6 only

Note that there was a Volume key prompt before debug mode kicked in (it shows in the recovery log only) as well as the Volume prompt asking for the driver (shown in the debug log)
[Android Apps and Games] Zackptg5:
Right, that's because I switched it over to the volume keys unity addon. The addon programs the vol keys at the beginning of install and uninstall in the event that the mod uses vol keys during uninstall (which this one doesn't). So it's by design
[Android Apps and Games] bramhc:
JamesDSP working on op6! Thank you very much for all devs hardwork!
[Android Apps and Games] Techvir:
My James DSP is crashing

Note 9 infinity ROM

Can someone please look at the logs

https://pastebin.com/mzdK9m0C

Thanks
[Android Apps and Games] DrStuhl:
It's interesting that LDAC doesn't work in global mode. Only in conventional, but then it takes a second when you skip the the song. It stutters for a second and it's running without the effects for that time. After that it takes effect. It's kinda annoying, is that normal?
[Android Apps and Games] james3460297:
I don't know what's the reason, sorry about that.
[Android Apps and Games] Zackptg5:
Maybe this will work for you? https://xdaforums.com/showpost.php?p=76466932&postcount=3277
[Android Apps and Games] s8m:
why do you say LDAC doesn't work? it works fine for me, in fact it's the main reason i'm using JamesDSP over V4A (using Sony MDR-100ABN btw)
[Android Apps and Games] gk1984:
I typically use apt-x but the few times it doesn't work, I force quit the app and reopen it, then everything works fine. I wonder if that would work with ldac
[Android Apps and Games] FurFur_:
I can't get JamesDsp to work on my s8. The zip gets installed in Magisk but after a reboot the app itself doesn't shows up. Don't know why but it seems like the apk isn't in the zip either or I didn't find it.

Any kind of idea what to do?

Using it on my S8 running Pie.
[Android Apps and Games] gk1984:
The apk is in:

Root/sbin/.magisk/img/ainur_jamesdsp/
[Android Apps and Games] Jman420:
Recent releases do not install the apk appropriately to that location on my Htc 10 running LeeDroid. I spent some time trying to investigate the cause, but couldn't turn anything up and reverted to an older version.

Just mentioning... Apk might not be there...
[Android Apps and Games] puturaya20:
can sugeest settings for mido miui 10 guys?
[Android Apps and Games] bravovn:
Jamesdsp always forceclose on Xiaomi Redminote 5 (whyred). I has tried may roms but no one working with Jamesdsp. Flashing by magisk or twrp method is same. How can I help you to solve this problem. Thanks
[Android Apps and Games] AntoRei:
It causes bootloop on emui 9... Mate 10 pro
[Android Apps and Games] elandroido:
so sad
[Android Apps and Games] AntoRei:
Mate 10 pro will be my last huawei!