[Moto G5 ROMs, Kernels, Recoveries, & Other Develop] b.zill:
FLAC

Thanks [MENTION=4471434]#Henkate[/MENTION] for your hints! Indeed, we have a file media_codecs_8956.xml (https://raw.githubusercontent.com/W..._cedric/cm-14.1/configs/media_codecs_8956.xml) in the device tree, but it refers to the Snapdragon 650, not the Snapdragon 430 cedric uses. The 8956 file seems to adapted to the hardware capabilities of the msm8952 (see comment box on line 84 ff) which is way beyond our msm8937 and so are many parameter settings in the video codecs.

We have a media_codecs.xml at https://raw.githubusercontent.com/W...orola_cedric/cm-14.1/configs/media_codecs.xml which seems correct for msm8937, but is very short and probably outdated, without flac or mpeg4 included (which may be the reason that it does not work?).

I see a media_codecs_msm8937.xml file at https://raw.githubusercontent.com/D...mmon/cm-14.1/configs/media_codecs_msm8937.xml that seems more comprehensive/updated in codecs and settings and has both regarding flac: a parameter to the OMX

<MediaCodec name="OMX.qti.audio.decoder.flac" type="audio/flac" >
<Limit name="concurrent-instances" max="10" />
</MediaCodec>

... and an include of ffmpeg at the end, like [MENTION=4471434]#Henkate[/MENTION] suggests:

<Include href="media_codecs_ffmpeg.xml" />

[MENTION=6810779]wzedlare[/MENTION]: Would it be helpful to add this file instead of the 8956 file or port the 8937 content to media_codecs.xml?

Updated sources

I just did a rough compare of the original Moto kernel sources of G5 “cedric” (2017-04-13) and G5s “montana” (2017-08-07).

https://www.github.com/MotorolaMobilityLLC/kernel-msm/releases/tag/MMI-NPP25.137-33

https://www.github.com/MotorolaMobilityLLC/kernel-msm/releases/tag/MMI-NPP26.102-41

Out of around 55.000 files, only around 700 are different, mostly in functional groups. Most of that appears to be minor changes / bug fixes. As the hardware differences seem minimal (5.2/5.0” display, 3000/2800 mAh battery, 16/13m rear camera), I assume that the G5s kernel is basically a patched G5 kernel, even more as the G5 models seem to share pretty much the same code base (some files for potter, cedric, and others are included in the montana sources).

As I don’t know the process to merge the original kernel into the LOS tree, I cannot help here, but certainly a review and some backports into the LOS cedric sources would make sense and improve stability (and maybe resolve some of our issues). Especially affecting USB functions, there seem to be many changes.

Thanks, if [MENTION=6810779]wzedlare[/MENTION] or somebody else could look at this.

CVE

[MENTION=4894344]razzor1984[/MENTION]: I basically agree, but it seems like „barking up the wrong tree“. The maintainers for Linux kernel, AOSP, Moto stock ROM, Lineage, and this Lineage port are all different, and most people participating in this thread are only “end users”.

An official Lineage for cedric, more people involved in maintaining it, and a fully patched kernel including a correct CVE table would be great. Until then, we can only try to contribute. At least, most sources are open, so we can find out ourselves, if a CVE is patched, or learn how to build and patch a Lineage ROM ...