yashsingh1/xdaforums huggingface dataset:
[Magisk] Shished:
Hidden downloads such as play store or play services are also downloaded with this app.
[Magisk] DroneDoom:
What is your point?

---------- Post added at 04:21 PM ---------- Previous post was at 04:17 PM ----------

Download manager is independent from those services. If everything is optomize, nothing should be invoking download manager in the first place during doze. Thus download manager shouldn't be bothered with the battery optomize option.
[Magisk] otonieru:
This is true [MENTION=7847630]Shished[/MENTION]

I even put ADM to whitelist. I dont want any of my downloads interrupted when the screen is off or when am sleeping :rolleyes:

Thus, it shouldnt be bothered. :o
[Magisk] davidk21770:
I just updated to magisk 13. It will not accept your module. Do you have a version that will work with it?
[Magisk] mondohow:
Read 8 posts back and you'll find your answer.
[Magisk] davidk21770:
I did a search and it didn't show up... :confused: Sorry about that.

Looks like I might need to debug my latest magisk install... This worked well with v12.
[Magisk] VR25:
Install from recovery.
[Magisk] mondohow:
NP. I've seen/read a lot of Magisk issues fixed with a re-install. So that really can't hurt.

You also have to remember a dev might not be ready to update their testing device which might be their main/only device to Magisk beta. I'm not sure how much code rewriting has to be done to update a module for v13 but I'd assume they'd like to test before releasing into the wild.
[Magisk] davidk21770:
Yep, you called it. I reinstalled and wiped dalvik and all is well. It was looking like the manager couldn't read the sdcard which was making it really difficult for it to install anything! I read that 13 wasn't supporting older module file versions and I thought that was the problem. I should have done just a little more testing before jumping here... :rolleyes:
[Magisk] mondohow:
Glad you got it sorted out and that's good feedback for the thread.

Out of curiosity, did you install Magisk v13 over v12 or was this a completely fresh install?
[Magisk] davidk21770:
I had 12 installed and was quite happy with it. The reading I did on 13 looked like it was a very stable beta so I decided to give it a try. I uninstalled 12 using its built in uninstall, but that wasn't enough to get it to reroot, so I had to completely uninstall the app. Then it reinstalled its su so I thought that all was well until I went to put back the modules and it told me that the zip files didn't contain a module. I checked app permissions and directory permission bits and everything looked ok, so I tried a simple reinstall with a dalvik wipe just in case there was something left over - and that appears to have cleared things up! (And, all installs were all through TWRP ;)).
[Magisk] otonieru:
Just FYI

Am on latest Magisk v13 Beta myself

and my module is working without problem. Installation from magisk manager work as well.

If you decide to move to v13, just make sure you do full uninstallation, including uninstall the manager prior to flashing uninstall zip.
[Magisk] myheroduane:
I am on aex ROM and I seem to have these apps optimized already without this mod. Am I right or should I flash this?
[Magisk] otonieru:
Some ROM might already start implementing the solution or the mod themself,

Yours already did. You dont have to flash it :)
[Magisk] WuNgUn:
Running beta v13 Magisk, module installed thru recovery, but still saw a lot of activity from Google services
[Magisk] otonieru:
Just because it dozed, doesnt mean it will nullify all activities.

There's plenty of its services that still need to be run in order to make the phone and other app functional.

If you feel that certain services is too aggressive, please be specific and name the exact services,

with screenshot of BBS would be better :)
[Magisk] WuNgUn:
Looks like maybe I have kernel issues... Will work on it.
[Magisk] timy:
thx

works lenovo p2 stock mm

magisk v12
[Magisk] demonoidmaster:
If you don't know what you're doing then don't touch it.
[Magisk] scorpion112:
what the file should i flash there is 5 file in attatchment im on superman rom
[Magisk] otonieru:
Please read the description

Magisk file is for magisk manager installation

Twrp, well, for....twrp of course

As for (+) version, please...read the OP
[Magisk] VR25:
Some people really hate reading! I'm seeing that over and over... :p
[Magisk] mattgfx:
I flashed this on my LG V20 sprint variant. While notification sounds come through for text messages, no sound plays for incoming calls. I have checked where I can to make sure sound should happen out of there, but nothing is happening. The screen does light up, but when the proximity and light sensor are covered, there would be no way to know I got a call as the screen stays black. Any ideas?

I did install the "+" edition.
[Magisk] Ubimo:
This is no good english, let me help you with this:

• The plus (+) version is modified by [MENTION=5228676]VR25[/MENTION] which has an extra feature: It is removing Google Play Services from background data access whitelisting.

It is restricting background data which will impact Google Play Services as well. This might save you some extra juice, but BEWARE of interrupted background data activities.

Edit:

Maybe some native speaker can even write this more understandable.
[Magisk] VR25:
I see... my changes are still misunderstood.

I'll explain again.

Besides enabling Doze to affect all Google Apps, I removed those apps from the power and data whitelists, which means:

1. Just like regular apps, they won't be able to access data WHEN data saver is enabled.

2. Just like regular apps, they won't run in the background WHEN battery saver is enabled.

3. They will run normally when those conditions don't apply. That means, no side effects whatsoever!

Your battery will be saved when you want it to be saved. Power and data savers settings will affect all apps except download manager, which makes more sense (to me personally).

Messages/notifications aside -- if I enable battery and/or data savers, why would I want hungry apps to still keep running in the background and eating my data? Again, that's why I made those changes and it's a matter of personal preference.
[Magisk] demonoidmaster:
Edit

---------- Post added at 09:14 PM ---------- Previous post was at 09:13 PM ----------

His English was fine and understandable so...
[Magisk] briankamkobe:
If I'm using the plus version by vr25 will I get late gbwhatsapp push notifications? But since I read gbwgatyor whatsapp doesn't use Google gcm right? So it shouldn't interfere? Can anyone confirm?
[Magisk] asusgarb:
Just to be sure, standard version enable doze always, even on standard use without savers activated.

Yours (+ version) leave apps untouched unless I enable battery or data savers.

So the one that should let me have better battery life should be the stock version, right?

Inviato dal mio SM-N9005 utilizzando Tapatalk
[Magisk] :
I think that Doze+ version provides the benefit of allowing Google Play Services to doze like every other app when the screen is off. Additionally, when the battery drops below 15 percent/ when you manually toggle the data saver mode on your device, it further restricts the background data activity of Play services causing further saving of battery (this is not seen with normal Doze version).
[Magisk] demonoidmaster:
No, this module makes Google Play Services go into doze mode whereas it doesn't by default

The other module, +Version does the same thing but also makes it so when using battery/data saver mode on your device all apps will get managed by it (except Download Manager so it doesn't get forced closed while downloading anything)

In short no apps will get white listed by Nougat's data/battery saver mode
[Magisk] 24imelqui:
Do both twrp & twrp + versions have the same uninstallers?
[Magisk] Esseker2901:
I need to try this...
[Magisk] BIGWORM:
Nope. Uninstall the Magisk version through magisk manager. Uninstall the twrp version through twrp, for which the twrp version Uninstaller is attached in OP.
[Magisk] 24imelqui:
I can't find the twrp + version uninstaller? It's not on the OP, Im using superSU. Do you have any link?
[Magisk] otonieru:
Its using same uninstaller
[Magisk] lucastracq:
i used microg before switching to this module and i'have to say there is not much difference in battery life and i don't have any delay in notifications, which was sometimes annoying with microg.

thanks a lot [MENTION=4066277]otonieru[/MENTION]
[Magisk] asusgarb:
This let me disappointed. I was thinking to try microg because I thought it would have increased battery life. If it's not it I'll stay with gapps.

Inviato dal mio SM-P605 utilizzando Tapatalk
[Magisk] lucastracq:
i think you should give it a try anyway, it could be different with your setup.

for me doze was already doing an awesome job, i just had some random standby battery drain which is solved by this module.
[Magisk] :
With all the new mods and custom kernels, microG is more of a privacy enhancement rather than a battery saving mod. The battery savings between the two are minimal and you are better off enjoying the fully featured gapps device over a nogapps device.
[Magisk] lover:
I tested plus version its so aggressive, if i minimize play store while updating apps it will pause. So i would go for normal version but it seems like only plus version is for magisk?
[Magisk] Grander0:
No, there's a regular version for Magisk as well. Also, I'm using plus myself and haven't experienced that problem.
[Magisk] lover:
Yeah my bad rev3 by otonieru is magisk's module.
[Magisk] VR25:
Are you sure you don't have battery saver or data saver enabled while doing that? Play Store should only pause under one or both of these conditions.
[Magisk] lover:
Well i tried amplify maybe that cut off the connection
[Magisk] toooby:
Tested with Sony Xperia Z3+ on nougat and it works as intended :)
[Magisk] Pablete197:
It is my first time installing this mod. And I don't understand how to get it work. I think i have correctly installed it, as magisk says it is intalled. However I don't understand how to "enable" it. I go to battery optimisation but i don't find any doze option. When i click google services the only options that appear are optimise and don't optimse. Can someone help me?

I'm on resurrection remix (7.1.2)
[Magisk] Didgeridoohan:
There are only those two options in the battery optimisation (doze). If an app is set to not optimise it won't be put into doze mode when it kicks in.
[Magisk] otonieru:
Thats exactly how it work,

As long as you can see Google Play Services listed as "optimised" then you are good :)
[Magisk] Bobthahog:
[MENTION=4066277]otonieru[/MENTION] will you be making another magisk module for 13.1 using template version 4? Really enjoy using this module and would like to use it on the new stable magisk.

---------- Post added at 01:59 AM ---------- Previous post was at 01:28 AM ----------

I actually went ahead and updated to 13.1 and this module still works fine on the newest stable version.
[Magisk] otonieru:
I just get the magisk update notification and update mine as well.

I'll update to new template once i got time,

Although, yes, it still works fine :)
[Magisk] white7561:
[MENTION=4066277]otonieru[/MENTION] Hey. I'm kinda interested in this module but i have one question... How much battery life is saved when using this module and not using it? is it THAT much ? Thanks
[Magisk] otonieru:
It depends on how many feature of google services you use,

But it safe to say that this module will decrease the frequency of your phone waking up
[Magisk] white7561:
Nice. Tho . Does it really impact the usage ? Like noticable impact?
[Magisk] Fishawy:
I have the same question about Hangouts notifications. Will it be affected?
[Magisk] tibere86:
This module still compatible with Magisk 13.1?
[Magisk] inffy:
Yep
[Magisk] Rom:
But with the next version (13.3), all Magisk modules will not continue to work..

@otonieru could you keep up to date your module please ?
[Magisk] mondohow:
This has already been addressed: https://xdaforums.com/showpost.php?p=72981906&postcount=227

As of now the module still works fine.
[Magisk] otonieru:
Module has been updated to latest template. tested on 13.2 and it work as it should as well

v4 is available on main post.
[Magisk] Gigobaito:
Can i dirty flash it over v3?
[Magisk] moludo:
I have done it without problems
[Magisk] Ubimo:
[MENTION=4066277]otonieru[/MENTION]

Could you please include v4 in thread title? So it's easier to find and see that there was an update.

[MODULE][Battery Saver] ENABLE DOZE v4 on Google Play Services [6.0+]
[Magisk] otonieru:
Done :)
[Magisk] mattie_49:
I got the very first one to work properly. Verizon HTC One 10 running latest viper with magisk. After flashing module I had to dirty flash rom back over itself to acquire boot. Hope this helps someone.
[Magisk] Bobthahog:
[MENTION=4066277]otonieru[/MENTION] Could you please post the Magisk module v3 for us that are still using Magisk v12? I am having an issue where modules using template v4 are not loading properly on 13.2 so I reverted back to v12 until the problems are ironed out.
[Magisk] ponkz:
This thread is usefull, subscribed ??
[Magisk] Doctor Zoidberg:
dont work on magisk 13.3 :(
[Magisk] cantenna:
good to know! Im still on 12.1 with safteynet fix
[Magisk] ghbuur:
working fine here, s7e with batman rom, magisk 13.3 but manager 5.0.6 as the new one crashes. safetynet green, google services optimized ;)
[Magisk] Doctor Zoidberg:
yes i know thats works on Magisk 5.0.6 but Magisk Manager 5.1 dont work this Modul.
[Magisk] ghbuur:
it was not clear the way you wrote, but now it's ok. couldn't even test 5.1.0, I'm sure update will come soon as others have troubles too..
[Magisk] otonieru:
For everyone with Magisk v13.3 and Magisk Manager 5.1.0

Please REDOWNLOAD THE V4 zip from my OP

v13.3 has weird behaviour, where it would stuck if the module.prop of the module installled doesnt have an extra blank line on it,

Weird :silly:

But at least i managed to found the problem,

The module should work fine now.

Am on 13.3 and 5.1.0 myself
[Magisk] ponkz:
Lol my magisk cannot load after updated to 13.3, stuck at the startup mask logo screen
[Magisk] Grander0:
Is the Plus module in v4 template as well?
[Magisk] otonieru:
It is, now. :)
[Magisk] stoyanovvitalii:
Can:t install your last rev4 on Magisk 13.0. And can't find any previous versions rev3 for example
[Magisk] Neejay:
13.3 or 13.0? What happens when you try to install it?
[Magisk] mondohow:
That's because Magisk module template v4 is NOT backward compatible with any Magisk version lower than v13.1. Since you're already on 13.0, why not just update to 13.1+? Most of the existing modules will need to be updated to v4 template sooner or later.

Hopefully, [MENTION=4066277]otonieru[/MENTION] can sort you out with the module based on v3 template in the interim.
[Magisk] sgronkia:
Reflashed but Magisk 13.3 still stuck
[Magisk] ponkz:
Same here.. magisk 13.3 stuck on mask logo screen
[Magisk] githyanki:
Magisk Manager updated to fix this issue.
[Magisk] alem972:
[MENTION=4066277]otonieru[/MENTION] can you please upload the old version of the magisk module that work with magisk 12.0?
[Magisk] Skull97:
Here you are...
[Magisk] demonoidmaster:
Why aren't you updating to 13.3?
[Magisk] alem972:
Thanks man!

---------- Post added at 09:42 AM ---------- Previous post was at 09:39 AM ----------

Because the module that I have to be working (Dolby+v4a) isn't updated yet, so it didn't work with the latest magisk
[Magisk] Filegod:
I have installed enable doze for PlayServices v4. Always shown Module will be updated by next Reboot. After a lot of reboots there is nothing updated und not activated.

Amy solution? Please help
[Magisk] demonoidmaster:
Seems like an issue with your device, module works on my end

What's your magisk version and apk version

---------- Post added at 12:38 PM ---------- Previous post was at 12:36 PM ----------

Probably better off asking someone to make a build of the module for you based on the new magisk requirements and github commits of your two modules, worth a try
[Magisk] otonieru:
Your magisk installation might be corrupted

Try to do clean install
[Magisk] Didgeridoohan:
That seems to be a Samsung specific issue with module template v4.

https://github.com/topjohnwu/Magisk/issues/297
[Magisk] alem972:
Infact I wrote to the dev in his post of the module, but he didn't respond...
[Magisk] Bobthahog:
+1 Same issue I had. No module using template v4 would work on 13.3. I had posted a few times on the general discussion on magisk thread but never got a fix.
[Magisk] otonieru:
What is your phone model, rom and kernel used ?
[Magisk] MESA:
Enabling the module breaks my safetynet. Anyone else have this problem? Device is LG G3 running magisk v13.3. do you want any logs?
[Magisk] Bright09:
Any advantages over greenify donate?
[Magisk] otonieru:
Not happening here,

Am on 13.3 as well,

You sure safetynet is green prior to installation ?

Send me your magisk log section :)
[Magisk] otonieru:
You cant compare between these two,

Since it give you different functionality,

With greenify, you still can't doze Google Play Services,

You can forcefully hibernate it, but it will still awaken every now and then by another app

For best combination is, install this module and enable force doze in greenify :)
[Magisk] Bobthahog:
It was Sprint Galaxy Note 5, Nougatized ROM and stock kernel. I just received my Galaxy S8+ 2 days ago so no longer have the Note 5 and cannot root new phone.
[Magisk] MESA:
Got it working and I think I know the reason: The rom installed on my phone has a build.prop tweak: logcat.live=disable, after I deleted this line safetynet passes successfully with the module enabled. Not sure why this works but it does. Before the line magisk log was empty and now its not. Yesteday I used a rom withou the tweaks and all was fine and today with the new rom I got this problem. Good module, thank you for it.
[Magisk] InfinityFath:
i can't find this module in magisk repo, can i install it directly? should it have compatibility issue?

i'm using lineage 14 on zenfone 2
[Magisk] :
Nope. You can install it directly. Kindly make sure your Magisk version and this mod version matches.
[Magisk] InfinityFath:
thank you!
[Magisk] Iradj:
I installed the + variant and when i tap on battery safe mode, Instagram stories don't load have someone got the same problem or is it just me ?
[Magisk] Bewildered Wolf:
Hey [MENTION=4066277]otonieru[/MENTION]

So, I'm new to Magisk modules. I've used a lot of Xposed module is but not magisk. So this was my first time using a magisk module.

I downloaded your enable doze on gms module and from the Magisk built-in download.

But I don't think the module is activated because in battery Optimisation it is showing Google Play services as can't be optimised

I am on one plus 5 on stock oxygen OS.

Please help me how to proceed.
[Magisk] demonoidmaster:
Lol that's not his module you installed, that's the obvious problem here
[Magisk] Bewildered Wolf:
But it was in the Magisk Modules. Nvm

So, i need to download Magisk one form the attachment in OP and then flash ?
[Magisk] demonoidmaster:
Nope not the same, someone seems to have tried to copy him and made a module that doesn't even work

[MENTION=4066277]otonieru[/MENTION] might wanna publish your module to the Magisk repo since someone else put an inferior module copying yours there
[Magisk] Bewildered Wolf:
Even after flashing this module.Battery optimisation not available.
[Magisk] demonoidmaster:
You didn't remove the other module... *sigh*

If it still doesn't work, flash Magisk uninstaller then reflash Magisk + the modules ( all done in twrp)
[Magisk] Bewildered Wolf:
The module not getting removed even after reboot.

Any way to uninstall it manually. If not , what should I do ?
[Magisk] Bobthahog:
It looks to me that u have a Magisk module from someone else other than the OP. Try using his. It always worked for me. Also yo delete manually just use file explorer. Go to Magisk folder and delete the correct module. I would uncheck it 1st so it's not active then reboot and then delete it.

---------- Post added at 11:14 PM ---------- Previous post was at 11:12 PM ----------

+1
[Magisk] demonoidmaster:
Just told ya, uninstall magisk, reinstall magisk, reinstall your modules

But if you would rather check, use a file explorer, go to /magisk and see if the module is still there, if it is then delete its folder and reboot
[Magisk] Bobthahog:
Or use a file explorer and delete it manually. Either way works. :good:
[Magisk] demonoidmaster:
I said where he should go above
[Magisk] Bobthahog:
My bad. :good:
[Magisk] Bewildered Wolf:
Yes, manually deleting it and flashing it again worked.

Btw do you people suggest to use Force Doze or Naptime to enter Doze quickly. Or the phone's default one is fine.

I've a OnePlus 5 device with android 7.1.1
[Magisk] demonoidmaster:
You can use the force doze app and then set the timer in it's settings
[Magisk] otonieru:
Thx [MENTION=7086291]demonoidmaster[/MENTION] for the head up,

[MENTION=7141309]simonsmh[/MENTION] is a fellow member here at xda as well,

I dont think he actually copy my module,

I believe he create another module using regex logic, so that he wont need to replace the whole google.xml

He used to put comment(s) in this thread as well about that,

My reason why i didnt move to using regex is because it has bigger risk of module not working,

Most of ROM which using Gapps will still use google standards in placing the config in the respective .xml thus my module will work in like 8 out of 10 situations,

Am not sure about the success rate of using regex method, (used to try it, but decide to revert)

After all, we are just two dev(s) trying to achieve same goal, only using different path

I think Simon surely already test his module prior to released as well (on his OP3 i guess?)

But unfortunately it wont work on OP5 ?

Thank you for advising me to put the module up to repo,

I'll try to do that, (not soon enough maybe) i dont have much time on my pc lately. Most of my recent xda activities were done in a brief time through phone.

Also for everyone who still use Magisk v12, the compatible v3 module is avail page back,

I advising you to either keep the file yourself after download, or upgrading to v13.3 altogether,

i'll only maintain the latest module which using latest template, else it can confusing in main post

Thank you & salam from indonesia
[Magisk] abel1015:
Im so sad. No matter how much i tried to install this wonderful mod on my s8. It keeps on failing me. Magisk user ver 13.3. Pls could you upgrade this module for magisk 13.3 users. TIA
[Magisk] p50kombi:
What are you on about?

It is updated.
[Magisk] Didgeridoohan:
It is compatible with Magisk v13.3.

Without details as to how it's failing it'll be hard to help... And logs, don't forget logs! Magisk log, recovery log if you're flashing in recovery, etc.
[Magisk] abel1015:
I am an s8 user. I installed the magisk version provided in the op. But everytime i flashed it in magisk manager no matter how many times i rebooted my fone. It still says "module will be updated on the next reboot" or something like that. I backed read and realised that s8 users had this problem. Is there a way to make it work on s8 using magisk 13.3? Thank you so much. Sorry for my bad english. It's not my mother tongue.
[Magisk] Didgeridoohan:
No worries... Your English is fine.

That is a bug that seems to be specific for Samsung devices. And it's known: https://github.com/topjohnwu/Magisk/issues/297

Wait for a fix and flash in recovery for now. That should work.
[Magisk] abel1015:
By the way, i forgot to mention that after flashing the module it said "successful" in the magisk manager but after reboot it still says module will be updated on the next reboot.

---------- Post added at 10:07 AM ---------- Previous post was at 10:02 AM ----------

Thank you so much Sir. But I am afraid to flash it in recovery because it might trigger the safety net to false. I needed to pass the safetynet. Guess I have to wait for the fix. Again thanks a lot Sir.
[Magisk] Didgeridoohan:
I have to ask: why would flashing in recovery trigger SafetyNet? :confused: