yashsingh1/xdaforums huggingface dataset:
[SuperR Kitchen] SuperR.:
I just ran the v1.2.0.0 in Kubuntu 18.04 live VM and everything works as expected. I am not sure what is causing your issue.

v1.2.0.0 is currently using ascii escape codes to clear the screen. I can switch to using tput (same as v1.1.9.5 uses) or clear, but the disadvantage is that we lose the scrolling history. In other words, tput/clear clears the screen but it only allows scrolling up to the last screen before clearing. With the ascii escape code clearing, you can scroll up as long as your terminal supports.

I like the escape code clearing method personally as I like to scroll up to see if there are any errors that moved too quickly to read. I will see if I can come up with a better solution to all of the above mentioned. For the record, screen clearing in default Kubuntu 18.04 seems to work perfectly as is.

EDIT: [MENTION=3594812]ShevT[/MENTION] - I will add a configuration option in the next update to use tput instead of ascii escape codes to clear the screen. It will not have a menu option due to the nature of this issue. Example, if the screen clearing does not work you may not be able to use the menu to change it. It will be easy to change manually and I will explain how to do it when I post the update :)
[SuperR Kitchen] theimpulson:
Great project!

is it possible to add support for extract-files? Which extracts proprietary blobs from ROM?

https://github.com/LineageOS/android_vendor_lineage/tree/lineage-16.0/build/templates
[SuperR Kitchen] bcrichster:
No, I've already tried that.. The extract-files.sh requires the whole repo for function instead of just a cpl files.. That question involves a massive scope of changes/additions that isn't feasible for a 25MB kitchen
[SuperR Kitchen] russel5:
[MENTION=5787964]SuperR.[/MENTION] with your latest kitchen i have error when installing rom.

Bug in configure.sh, because if i use old configure.sh from old free kitchen all works.

Log from recovery

I:operation_start: 'Flashing'
Installing zip file '/sdcard/Documents/mod_stock.zip'
Checking for Digest file...
Skipping Digest check: no Digest file found
I:Update binary zip
Verifying package compatibility...
Package doesn't contain compatibility.zip entry
I:Zip does not contain SELinux file_contexts file in its root.
I:has_legacy_properties: Found legacy property match!
I:Legacy property environment initialized.
mod stock Installer
mod stock Installer
Built with SuperR's Kitchen
Built with SuperR's Kitchen
Checking config ...
Checking config ...
about to run program [/tmp/install/bin/configure.sh] with 1 args
Segmentation fault
script aborted: location argument to mount() can't be empty
location argument to mount() can't be empty
Updater process ended with ERROR: 7
I:Legacy property environment disabled.
I:Install took 2 second(s).

P.S. ok [MENTION=5787964]SuperR.[/MENTION] i recompiled recovery with busybox and now all works, but don't forget that default for recovery in android 8.1 is toybox and many who compiled recovery on 8.1 sources will have this problem. Since now many who have android 9 and on it's sources we can't use busybox anymore.

So you need fix your configure.sh to work with toybox.

P.P.S. one more [MENTION=5787964]SuperR.[/MENTION] your new kitchen not work at all. After make rom without any change phone not boot anymore. If use old kitchen all works.

All things in #sym and #perm in updater-script and why you broke it if all works on old kitchen i don't know.

First broken symlinks in new kitchen like

symlink("[COLOR="Magenta"]/[/COLOR]hw/android.hardware.keymaster@3.0-impl-qti.so", "/vendor/lib/android.hardware.keymaster@3.0-impl-qti.so");

when older kitchen use

symlink("hw/android.hardware.keymaster@3.0-impl-qti.so", "/vendor/lib/android.hardware.keymaster@3.0-impl-qti.so");

And the last and more important it's broken permissions in /vendor

your new kitchen make recursive perm to folders like

"uid", 0, "gid", 2000, "dmode", 0755, "fmode", 0755

BUT all subfolders have permissions like

"uid", 0, "gid", 0, "mode", 0644

and if you labeled it like vendor_file phone not boot up. we already talk about this in the past... :rolleyes:

Attach two files, one from new kitchen (not working) and from old (working) to compare.
[SuperR Kitchen] SuperR.:
Are you saying your device does not have a way to run "run_program("/tmp/install/bin/configure.sh");" from the updater-script in recovery? This sounds like a recovery issue. The updater-script does not call busybox to run configure.sh, and configure.sh does not call busybox. Take a look for yourself. How do you suggest I fix it?

Symlinks have been working the way they are for everyone using the donate kitchen for a long time so I am not sure why you are having issues. If you send a recovery.log showing kitchen generated symlinks failing, along with a fast link to the firmware that does not require registration I will take a look.

I remember having a vendor permissions conversation with you, but I remember very little about it. I will take a look at the updater-scripts you attached when I get a chance.

The new kitchen and the old kitchen are completely separate code bases. I did not decide to break something that used to work. I work very hard to make everything right on all devices. I work even harder when my work is appreciated ;)
[SuperR Kitchen] russel5:
Bro I know what I'm talking about. Your script uses additional applets to make it works. Do you see what inside the script?

/sbin/sh

And this is what run script. Where it placed, yes in recovery/sbin folder and what execute binary are used is general. If using symlink sh to toybox (default in 8.1 sources) we have error that I'm posted, but if we using symlink to busybox all works. And I read your paid forum and some people's have error with execute your script.
[SuperR Kitchen] SuperR.:
So I ask again, how do you suggest I fix it?
[SuperR Kitchen] narshi shukla:
The new kitchen have some issues, sometimes it fails to start, sometimes it creates empty system folder.

And i have two roms baked in old kitchen which won't even extract in New kitchen tried everything.

One more thing, kitchen will always fails to extract system and other img pulled with android root methods, which its fine when device booted in recovery options.

All above issues are fine with old kitchen.
[SuperR Kitchen] russel5:
Yes new kitchen is.....

Use old working version, works prefect
[SuperR Kitchen] SuperR.:
TO ALL: From this point forward, I will be DELETING new kitchen bashing posts. I will fix problems as they come if you provide adequate posts describing the problem, links to firmware, etc. Saying the old kitchen is better will get us nowhere, so please refrain from this. The old kitchen is no longer being updated. You can still use it if you want. Nothing has been taken from you, so relax and try to help make the new kitchen better than the old. Anything other than this frustrates me, and I do this for pleasure in my free time, for you :)

If you send links to the problem firmware and instructions on how I can reproduce the errors, I will get it fixed :)
[SuperR Kitchen] SuperR.:
v1.2.0.1

Changes:

Added configuration option to use tput instead of ascii escape codes to clear the screen.

Updated md5 for Android Image Kitchen v3.4 by [MENTION=4544860]osm0sis[/MENTION].

Updated md5 for Busybox Installer v1.29.3 by [MENTION=4544860]osm0sis[/MENTION].

Fixed extraction of rom.zip that includes payload.bin.

NOTES:

To use the new tput screen clearing (not recomended if you are not having issues):

open kitchen/tools/srk.conf in a text editor

add the following line:

use_tput=1

Save and close the file.

Restart the kitchen

mount() argument cannot be empty:

If you are getting this error when flashing your ROM, you can try replacing superr_project/install/bin/configure.sh with this one (right-click, save link as). Thanks [MENTION=4688377]russel5[/MENTION] for pointing out this workaround until I figure out what is going on with the existing one. You can replace kitchen/updater/install/bin/configure.sh if you want a more permanent switch. It will be replaced during an update if that file changes, otherwise it will survive an update.
[SuperR Kitchen] ShevT:
Yes! This now solves the KDE screen redraw problem. Thanks...
[SuperR Kitchen] SuperR.:
v1.2.0.2

Changes:

Better exception handling when Busybox.zip does not download properly from xda link.

Updated vdexExtractor by [MENTION=407497]anestis[/MENTION]b to the latest commit.

Another attempt at configure.sh.

Added support for extracting Samsung firmware with HOME.md5 and lz4 compression.
[SuperR Kitchen] SuperR.:
v1.2.0.3

Changes:

Fixed kitchen updater always saying it is up to date even if there is an update available.

Fixed crash if vdex file exists but jar file does not when deodexing O and P.

Remove vdex symlinks after deodex.

Just noticed the kitchen updater was not working, so you get another update right away. Once you are running v1.2..0.3, the updater will work for future updates :)
[SuperR Kitchen] Syed Ahmed Ali Shah:
Error in making zip of Moto E4

Sir you have to look into this problem also. While when zipping the final rom, following error occurs:

moto.zip is building in moto ...

Traceback (most recent call last):

File "superr.py", line 6854, in <module>

File "superr.py", line 5852, in rom_tools

File "superr.py", line 1092, in build_zip

File "superr.py", line 1040, in build_rom_zip

File "superr.py", line 931, in dobdisplay

TypeError: Can't convert 'list' object to str implicitly

[2156] Failed to execute script superr

Press "q" to Quit, or "r" to Restart

Moreover, choice of system.dat or img may be added in building the final zip. Thanks a lot
[SuperR Kitchen] SuperR.:
v1.2.0.4

Changes:

Updated kitchen updater to work with the launcher/installer found in the new *4kitchen Linux distros.

Fixed crash when building rom.zip on some firmware.

Show update menu even if there is no update when checking for updates.

[MENTION=6126715]Syed Ahmed Ali Shah[/MENTION] - This update should fix the crash. If you want system.dat, choose sparse_dat perm type. If you want img files, choose raw_img perm type. NOTE: sparse_dat perm type is currently disabled for slot A/B devices because there were many issues and I don't own one for testing. This may change in the future.
[SuperR Kitchen] Zackptg5:
Much appreciated as always. Looks like some stuff changed with pie in terms of the sdat2img as it throws an error now. I'm attempting to unpack this stock s9 pie rom. I attached the support.zip. Not sure if there's much you can do about this since the problem is likely with an external tool though. I tried with the github repo version of sdat2img as well just to rule out anything else but got the same error. Thanks!
[SuperR Kitchen] bcrichster:
Which Moto device are you try to work with, the soak tests of the Moto X4?
[SuperR Kitchen] Syed Ahmed Ali Shah:
Moto E4 XT1762
[SuperR Kitchen] bcrichster:
MediaTek Moto E4.. New android version like Pie or Oreo?
[SuperR Kitchen] Syed Ahmed Ali Shah:
Yes Mediatek Moto E4 codename 'woods" and Android 7 Nougat is the stock firmware
[SuperR Kitchen] bcrichster:
Ok thanks. The Qualcomm version is "perry" and we're working on custom ROMs in another place. Yeah the kitchen should work fine for Nougat, maybe just a minor fix somewhere.
[SuperR Kitchen] SuperR.:
This firmware appears to be an update rather than a full ROM. I believe this is the problem. For example, there is no boot.img, only boot.img.p (.p is a patch file). Try extracting a full firmware and you will probably be successful. If you do not have access to the full firmware, you could flash this update firmware on your device and pull img files to work on.
[SuperR Kitchen] Zackptg5:
Yup, that was the problem. I don't actually own the device, I'm trying to port an app from it :/

Looks like sdat2img doesn't support move, bsdiff, or imgdiff commands so I guess it'll never work for patch zips. Oh well, thanks for the help!
[SuperR Kitchen] DoR3M3:
If I unpack the boot.img and then pick - 5) Patch sepolicy for Oreo deodex and then - 1) Pack boot.img

Is the boot.img that I placed in the Project Directory now the patched/repacked image? Because the size is still the same... :eek:

I don't want/need a flashable zip, I only want the boot.img
[SuperR Kitchen] SuperR.:
After you pack the boot.img in the kitchen, the old one is replaced with the new in the project directory. The size may be identical even if it is modified and repacked. You can verify the checksum before and after unpacking and packing to see if the boot.img has changed:

md5sum /path/to/boot.img
[SuperR Kitchen] DoR3M3:
Thank you... :)
[SuperR Kitchen] Syed Ahmed Ali Shah:
Sir again encountered a problem. It was system.bin file which was changed to system.img and while after extracting it and during preparing files this error occurs

Preparing files ...

Traceback (most recent call last):

File "superr.py", line 6834, in <module>

File "superr.py", line 3526, in extract_new

File "superr.py", line 4600, in imgextract

File "superr.py", line 5207, in metasetup

IndexError: list index out of range

[2412] Failed to execute script superr

Press "q" to Quit, or "r" to Restart

Need your kind attention

And sir, one system.img which was easily extracted by img.extractor was failed in superr.
[SuperR Kitchen] SuperR.:
If you send a fast link to the firmware that does not require registration I will take a look. I can't fix anything without the problem firmware for testing.
[SuperR Kitchen] Syed Ahmed Ali Shah:
here

and this

First one gave that error and second one's system.img was failed to extract
[SuperR Kitchen] SuperR.:
These are not valid ext4 system.img files.

For the second one, when trying to mount in Linux, we get the following in dmesg:

EXT4-fs (loop19): bad geometry: block count 393216 exceeds size of device (294915 blocks)

It can be fixed using the following command:

truncate -o -s 393216 system.img

The first img that showed the error you posted has the same issue. dmesg shows this when trying to mount:

EXT4-fs (loop19): bad geometry: block count 819200 exceeds size of device (819198 blocks)

This will fix the system.img:

truncate -o -s 819200 system.img

In case you are interested, the donate kitchen automatically fixes images like this and has no problem extracting these system.img's as they are :)
[SuperR Kitchen] DoR3M3:
[MENTION=5787964]SuperR.[/MENTION] I only use Kitchen to make Deodex ROMs, and then I use to make EXT4 image.

If I Deodex a rom and then make only EXT4 image, I do not see any option to Zipalign.

I've only noticed that the zipalign feature/option is only presented with making a Full ROM zip.

I'm either blind, or the option isn't there, and if it's not, they why can't we have the feature/option to Zipalign for "Build EXT4 img"?

Thanks
[SuperR Kitchen] SuperR.:
You are not blind. The manual zipalign option is only available in the Donate kitchen. It is in the Misc Tools menu to use whenever you want :)
[SuperR Kitchen] DoR3M3:
Oh I'm really sad now, didn't think/realize this would only be a donate feature.

And I'd LOVE to donate, but I don't have any means of doing so.

Hmm maybe I can PM you a Google Play Store Gift Card PIN. I can buy these locally...

Thanks
[SuperR Kitchen] lijianjunyonghu:
Oneplus6 device ab cannot start

When can I support ab?
[SuperR Kitchen] SuperR.:
The kitchen already supports a/b (system-as-root) devices. There is something else going on with OnePlus6, and I am trying to figure it out. Unfortunately I do not have a OnePlus6 so I am waiting for information from others. If you know what the problem is, please let me know.
[SuperR Kitchen] bcrichster:
OnePlus just dropped out the game for Development:

https://www.google.com/amp/s/www.androidauthority.com/oneplus-roms-device-seeding-929081/amp/
[SuperR Kitchen] aer0zer0:
I'll be getting my 6t Friday, where should I Start looking?
[SuperR Kitchen] bcrichster:
Another device manufacturer..?? Lmao, JK
[SuperR Kitchen] aer0zer0:
Lol, this'll be a treat, right?
[SuperR Kitchen] Er. Aditya:
you guys are making this work a legend each passing day...thankyou so much dev
[SuperR Kitchen] SuperR.:
It might be the easiest if I make a boot.img for you to test as that is really what we need working properly.

A few questions...

1. have you been successful unpacking/repacking boot.img with this kitchen since the switch to Carliv Image Kitchen?

2. Should I make a Note4 or Note5 boot.img for you to test?

3. I have the SM-N920I (Note5) stock boot.img and the SM-N910C (Note4) stock boot.img. Will either of these work on your device?
[SuperR Kitchen] :
I'm on the n910c so would need that boot.img. I will try and unpack and repack a boot.img now as I have just used it to extract the new n5 firmware. Once again a big thank you for all your work

Edit. It seems to unpack and repack fine, I can flash a repacked boot.img if you want me to
[SuperR Kitchen] SuperR.:
Here is a test boot img for the SM-N910C.

https://s.basketbuild.com/dl/devs?dl=SuperR/Testing/SM-N910C_test_boot.zip

Let me know how it goes. If it works this can be added to the kitchen. If not, back to the drawing board lol
[SuperR Kitchen] :
I got bootloop I'm afraid, just kept rebooting to the splash screen. I can try adb but not sure I'll get anything
[SuperR Kitchen] SuperR.:
That's unfortunate. Thanks for trying :)
[SuperR Kitchen] :
Any time. I'll gladly test anything
[SuperR Kitchen] SuperR.:
Just realized that it might be helpful to unpack/repack stock boot.img with the kitchen and see if it boots . If it does not boot, then the mods I made still have a chance of working and maybe we need a different unpack/pack method.
[SuperR Kitchen] bcrichster:
- ∆ - Told ya SuperR! - ∆ - You're "Tha Mann!!" :cool:

Gratefully sent from my Rooted JollyRoger_B13
[SuperR Kitchen] :
I'll do one this morning when I get in and report back
[SuperR Kitchen] Hamidreza2010:
[MENTION=5787964]SuperR.[/MENTION] can you make this kitchen for Windows OS?

thanks
[SuperR Kitchen] :
Just unpacked and repacked stock kernel on the N910C without modifying anything just selected option2 to keep ramdisk and it bootloops. Hope this helps
[SuperR Kitchen] shoey63:
Was it a MM img ? if so it needs to be unpacked and repacked as ROOT, due to the permissions in the ramdisk.
[SuperR Kitchen] bcrichster:
NO. :rolleyes: SuperR is a very busy person & has stated repeatedly since this thread started that he doesn't use or support WynnDoze in any way, shape, or form. He's strictly a Linux guy. So, you have three options:

- Install Linux alongside Windows, which I highly recommend. That gives you "Dualboot" which allows the choice of OS you wanna run at each startup.

- Install a VirtualBox which allows you to run another OS within Windows, but it can be a serious RAM hog (FYI).

- Install Cygwin and confer with ppl in this thread who got it running correctly to learn usage and installation dependencies.

While the last two are usable, they can cause incompatibility issues.. You'll generally have less possible issues with a full Linux distro anyways :cool:
[SuperR Kitchen] Androidwizzard:
[MENTION=5787964]SuperR.[/MENTION] maybe you already have seen this thread LINK which deals with root and kernel for N920 but may help in N910 too.
[SuperR Kitchen] :
It was just a standard boot.img as far as I know. It unpacked and repacked correctly , I was just testing what superrs asked me to ?
[SuperR Kitchen] SuperR.:
Thanks for testing :) Was your device rooted when you tested? If so, that could explain the bootloop (the entire reason for testing this lol). I really should have specified that unpack/repack stock boot.img should be tested on an unrooted device so we are sure that part is working properly. Sorry for the trouble and thanks again for your help.
[SuperR Kitchen] Hamidreza2010:
OH :(

i dont know how to work with linux

ok dear i dont have other choice.

i have to install VirtualBox and run another OS within Windows.but what linux u are prefer?
[SuperR Kitchen] SuperR.:
I have seen that guide and included everything in the test img I posted. The only difference is the way I modified sepolicy. I did not use supolicy on a device, instead I used a Linux binary called sepolicy-inject. Running on the device does not make the kitchen very easy to use. I could make automate the process if you plug in a device, but I am trying to avoid it if possible.
[SuperR Kitchen] :
Ubuntu or Linux mint are your best bet as they are probably easiest to use. Linux mint cinnamon is very similar to Windows desktop so you might find that easiest. But every one will have their favourite

---------- Post added at 02:46 PM ---------- Previous post was at 02:45 PM ----------

I'll flash a stock un rooted rom with repacked kernel later and report back
[SuperR Kitchen] lijianjunyonghu:
ifelse(is_mounted("/system"), unmount("/system"));
set_progress(0.100000);
ui_print("install system");
package_extract_file("boot.img", "/dev/block/bootdevice/by-name/boot_a");
package_extract_file("boot.img", "/dev/block/bootdevice/by-name/boot_b");
package_extract_file("system_new.img", "/dev/block/bootdevice/by-name/system_a");
package_extract_file("system_new.img", "/dev/block/bootdevice/by-name/system_b");
package_extract_file("vbmeta.img", "/dev/block/bootdevice/by-name/vbmeta_a");
package_extract_file("vbmeta.img", "/dev/block/bootdevice/by-name/vbmeta_b");

I packed the kitchen into a system and followed the script to work properly：d
[SuperR Kitchen] Zackptg5:
[MENTION=5787964]SuperR.[/MENTION]

I've been trying/failing to extract some lenovo roms. First one here and second one here.

The first one has a multi-img setup which the kitchen has handled fine on other roms and the second one is just a single system.img. The kitchen errors out in all cases the moment it tries to unpack the system imgs. I attached the support zips along with a file in each with the error the terminal displayed. When I tried running imgextractor manually, it gave me header errors so does lenovo do something goofy with their imgs? Thanks
[SuperR Kitchen] SuperR.:
This type of multi-part system.img has never been supported in the kitchen. However, I did write a binary to handle them and posted about it here. There will be a plugin for the donate kitchen after the next update that will handle multiple multi-part img files in your project directory at once :)

The older single system.img is not an ext4 image file. I have no idea what it is, but the kitchen currently only deals with ext4.
[SuperR Kitchen] Zackptg5:
That did it! The fix geometry feature was huge. Thanks a ton!

Edit: spoke too soon. Now I get the header issue like with the other one

mount: /home/zack/superrs-kitchen/superr_k53/output: wrong fs type, bad option, bad superblock on /dev/loop8, missing codepage or helper program, or other error.
cp: cannot stat 'output/*': No such file or directory

7-Zip [64] 16.02 : Copyright (c) 1999-2016 Igor Pavlov : 2016-05-21
p7zip Version 16.02 (locale=en_US.UTF-8,Utf16=on,HugeFiles=on,64 bits,4 CPUs x64)

Scanning the drive for archives:
1 file, 3699437568 bytes (3529 MiB)

Extracting archive: system.img

ERRORS:
Headers Error
Unconfirmed start of archive

WARNINGS:
There are data after the end of archive

--
Path = system.img
Type = zip
ERRORS:
Headers Error
Unconfirmed start of archive
WARNINGS:
There are data after the end of archive
Offset = 2998272
Physical Size = 23940344
Tail Size = 3672498952

Archives with Errors: 1

Warnings: 1

Open Errors: 1

Guess it's not an ext4 either
[SuperR Kitchen] SuperR.:
Try concatimg again. This time, add the rawprogram0.xml file from the firmware zip to the same directory along with the system_*.img files.
[SuperR Kitchen] Zackptg5:
That did it, thanks man!
[SuperR Kitchen] ariber14:
Hello guys. I'm trying to build a rom with permanent permissive rights for galaxy a6plus (a605fn) but i can't find a way.can i do it from superr kitchen?or is there a way to do it before i build the custom rom? Thnx in advance
[SuperR Kitchen] bcrichster:
If you're trying to make a kernel permissive, you need to edit BuildConfig.mk before building/compiling a custom ROM and build it yourself.. this Kitchen does not handle that in-depth task for kernel modz, far as I am aware
[SuperR Kitchen] jesvi:
Can you post a free windows version??