yashsingh1/xdaforums huggingface dataset:
[Magisk] KaMyKaSii:
[MENTION=7296895]veez21[/MENTION] I do not have Magisk but would like to test your work, any chance of doing something similar for SuperSU? Or even a classic mod that replaces files in /system, I see no problem in that. Thank you for your time and work.
[Magisk] Rebel7022:
Is this for nougat
[Magisk] CooperBrick:
5.0+ ad Google has witched to ART since lollipop

Or maybe it will work with KitKat with ART enabled
[Magisk] Rebel7022:
I'm trying to get spoon fed
[Magisk] umeshbluezzz:
Tried rebooting twice thrice still the same issue... how to uninstall?
[Magisk] Tesla:
In Magisk/Modules
[Magisk] stylemessiah:
Most Nougat ROMs ive seen use speed, so this would be almost useless im afraid on Nougat

I fear the dev is going to have a very long thread of user questions/support....
[Magisk] Mezabaru:
Can confirm no issues on S7 on latest version of superman ROM nougat. Apps are bit more responsive then before, I'm noticing Firefox is beniftinh from it.
[Magisk] Hitti2:
I'm lost. Do I flash the zip in recovery?

What's this actually do in laymen terms?

Should I use this on trupirexmm?
[Magisk] alroger:
Ok, I just made a few tests, wipes, reboots with the latest version.

It's not placebo for me.

Without this module, when I tap on Plex it takes long to open, and longer to connect (roung circle loading).

Using speed or everything in this module, Plex opens immediately, without the loading/connecting circle.

I notice this too in Youtube. The circle/loading is way faster.

So it not only speeds up my app loading, but I think it makes apps starrt network connections faster!

OnePlus One (bacon), using always the latest weekly official LOS 14.1.

When I getprop dalvik.vm.image-dex2oat-filter without this mod it returns nothing/blank.

Using the filter speed or everything really helps me with performance.

BTW, is there a way to change my vote? I voted incorrectly to start with.

Cheers.
[Magisk] veez21:
Delete this directory /magisk/runtime-optimization
[Magisk] veez21:
Yeah, got some questions from users more than I expected. I know that speed is the default, that's why there's an option to change it ?
[Magisk] stylemessiah:
Trying to do something for others on XDA...its a double edged sword my friend :) :)

Lets hope people read your OP and any new questions are relevant to your thread!
[Magisk] veez21:
I'm gonna expect more questions like this:

Something's wrong, how to uninstall ?

??
[Magisk] yandreev3:
Didn't successfully wipe cache/dalvik on its own.

Broke xposed on first boot but was fine after a reboot.

Still breaks Facebook messenger.
[Magisk] android_htc:
[MENTION=7296895]veez21[/MENTION], I am also experiencing issues on stock Note 4. Note that the latest versions seems to startup okay... but problems start once phone is restarted and I am faced with System UI fc'ing. Happy to help with any test versions.
[Magisk] veez21:
Ok, try the attached zip
[Magisk] Sam Nakamura:
On my marshmallow setup with supersu in systemmode (non magisk) editing the filter was only possible by editing "art_op.sh" in init.d after flashing, I also tried to edit "no_magisk.sh" several times before flashing, after updating from 1.2 to 1.2.5 the filter was rested to "speed", even I had edited to "everything" before...

Just as observation, but I guess that's why the init.d solution is not the preferred method :), but that's fine too, nothing to worry for me
[Magisk] veez21:
That's a bug actually. Fixed a few hours ago and will be coming in the next version ;)

Look at this commit: https://github.com/veez21/runtime-optimization-1/commit/e9a2c964627ccb78d82ed5e4260fbdabd7783dc2
[Magisk] android_htc:
Excellent work, all good now!:good:
[Magisk] veez21:
Ok, thanks for testing. Observe it by rebooting a few times and tell me if it's okay :)
[Magisk] Sam Nakamura:
But this only affects systemless workaround, I'm unfortunately limited to system mode on my setup..

Anyways, it's really impressing how much time & efforts you send on this besides your fast support...

Really great, thanks :highfive:
[Magisk] veez21:
No, it's for system install (/system/su.d). v1.2.5 had a typo in it that when detecting the previous filter in /system/su.d, it detects from the /su/su.d. Your issue should be fixed in the next version.

Well, I'm free atm :laugh:
[Magisk] Sam Nakamura:
What a mean is supersu system mode vs systemless mode, su.d isn't created in my case, cause I can run supersu only in system mode, therfore no su.d is created, art_op.sh is placed in init.d not su.d :)
[Magisk] veez21:
Oh, Ok :good:

I'll do a fix for that :)

Thought it's still okay to be in init.d as long as it's executed since it writes to build.prop :)
[Magisk] Sam Nakamura:
Yeah it's fine, absolutely..

Just as previously mentioned the filter has to be set again after updating but that is far from an "issue", anyways thx.. :good:
[Magisk] veez21:
Well, I don't think I can do anything about Samsung firmwares/ROMs with xposed installed.

[MENTION=6247359]atarek[/MENTION] has been doing tests for me and it's clearly sammy roms + xposed + this module's combo problem. Wanam's Xposed won't work with this module (I'll try contacting him for clarification). It stops working and cause some FCs for a few apps (fb messenger).

Soooo, the installer will just abort if a samsung firmware and xposed are detected.

The Installer will display a WARNING message if it detects a Samsung phone + Xposed

Cheers :highfive:
[Magisk] Shen Ron:
Version 1 is the last version which is non magisk to have worked perfectly.
[Magisk] Face_Plant:
Settings and Titanium Backup are continuing to force close with version 1.2.5 on my Nexus 6P running 7.1.2 :crying: It doesn't matter which filter I use. The only cure is to wipe cache/dalvik, but that only lasts for one reboot. The next time I reboot they start crashing again. This module is definitely the issue because the problem goes away when I uninstall it.

I have attached a new logcat to this post. I took a quick look at it and saw several Android runtime errors.
[Magisk] Mecca EL:
Everything including TiBu working great on LOS14.1 on Bacon.
[Magisk] veez21:
Try this test build
[Magisk] 24imelqui:
Veez, your uninstaller don't work. Something about error 2. Can you give the link of the old uninstaller?
[Magisk] veez21:
Yeah, noticed that. I'll update the link later
[Magisk] Face_Plant:
Working great so far! I'm using the everything filter and have rebooted about 5 or 6 times with no force closes. Thanks for fixing it quickly!
[Magisk] :
Any way to get it working with audiomodlib? I saw some people mentioning this problem and I faced it too ehile trying to flash sauron mod.
[Magisk] veez21:
?

I'll do some testing with audmodlib tonight. Maybe i can address the issue
[Magisk] darzur:
Hi,

I'd like to check this mod with Magisk on SGS5 with LOS Official 14.1 but please let me know one thing. Does it not break SafetyNet? If it does then will not even try it...
[Magisk] veez21:
Afaik, it doesn't break safety net. You're welcome to try and tell us:)
[Magisk] veez21:
Uninstaller fixed! (OP uninstaller link updated)

It should be properly working now. It can uninstall Magisk or Non-Magisk (as long as the script is found) and removes the lines added, by non-magisk, in the build.prop.

Thanks to [MENTION=7232334]24imelqui[/MENTION] for noticing :)
[Magisk] darzur:
Thnx. Will try it and report then.. :)
[Magisk] KaMyKaSii:
[MENTION=7296895]veez21[/MENTION] I was looking at the getprop output and I came across some props related to dalvik-cache (which is actually ART) with "speed" values, even using the "everything" filter on your mod. You may also have to modify them? Anyway, I'll make a Magisk mod with these props and test
[Magisk] veez21:
That some of it (pm.dexopt.xxx) was actually added before. It was removed since it was causing bootloop and little wuirks on some devices. And v1.3 will remove pm.dexopt.bg-dexopt since it causing weird quirks with nexus 6p
[Magisk] darzur:
I can confirm that it doesn't break SafetyNet. To be honest I'm not sure if gained something, but need some time to judge. Have some questions though. Booting is very long now. It seems to be stuck on "Samsung GALAXY S5" logo for about minute but then goes on - is that normal? And second question - what about newly installed apps? Will they be compiled with chosen filter during install or not? If not then I have to wipe ART after installation of every new app - am I right?
[Magisk] Gigobaito:
Are you ever going to release a final build of this module? Tbh the only reason im not actually working with it is the frequent update (which isnt a bad thing in any other cases, but it is when you have to wait 5-6 minutes after every flash + wipe)
[Magisk] n0j0e:
With art-opt-test-6p.zip no more System UI fc with an active substratum overlay! ?

Send with much love & Android.
[Magisk] KaMyKaSii:
No bootloop here. I'm on RR v5.8.3 (7.1.2). About the magisk module, could you tell if the configuration I made is actually applying the props (and generating consequence in ART processing) than just a visual change (at the terminal output)?

# This will be the folder name under /magisk
# This should also be the same as the id in your module.prop to prevent confusion
MODID=everythingprops

# Set to true if you need to enable Magic Mount
# Most mods would like it to be enabled
AUTOMOUNT=false

# Set to true if you need to load system.prop
PROPFILE=true

# Set to true if you need post-fs-data script
POSTFSDATA=false

# Set to true if you need late_start service script
LATESTARTSERVICE=false

Could you describe these quirks a little bit?
[Magisk] jacomail95:
In which version was added the pm.dexopt stuff? I want to test it on my phone

Inviato dal mio Nexus 5 con Tapatalk 2
[Magisk] lahceneamine:
For the long reboot time it's an issue of Magisk in Samsung (I've an S8) and when I use this module it takes also long time to reboot.

For your second question : it's indeed a good question XD
[Magisk] adekboreanaz:
Hmm, i'm getting confused here, i was be abled to installed the latest version and i tried to changed the filter to everything on myphone, the next menu shows that i need to wipe then i choose 'y' then next menu says that do you want to reboot then i choose 'y' but nothing happened???, I tried to reboot myown but it just goes sleep and blank tried to wait 15 minutes?

Getting more confused here ?

---------- Post added at 01:02 AM ---------- Previous post was at 01:00 AM ----------

Getting more confused here , i fixed the reboot issue but whenever i reboot my devices i got bootloop even i don't change the filter :(
[Magisk] justjr:
That's not right, some options in this module does indeed have much longer boot time. Test with and without it and you'll see. I just uninstalled and yeah, it no longer stay at the motorola logo for like 20 seconds. Magisk still here perfect fine and with a normal time boot, way faster.
[Magisk] JRJ442:
Well it kind of makes sense. Cache buildup takes time. You select everything of course it's gonna be longer. That being said, I personally think the bootup times are very close to normal on the newest module and Magisk v13.
[Magisk] justjr:
Yes, it's not a bug or anything, just the way it works.
[Magisk] lahceneamine:
I said it's an issue with "SAMSUNG" only, It has already been discussed with topjohnwu and veez21, grab one and test by yourself.

With this module it takes 2 minutes to boot.

Without (With Non Magisk) it takes. 24 seconds.
[Magisk] DuckBread:
It's not a Samsung only issue though.. it does it on my Nexus 6 as well. It stays at the Google logo for about 60 seconds or longer, THEN proceeds to boot (boot animation starts). It's a trade off. Slower boot time, better app speed. Definitely not limited to Samsung.
[Magisk] KaMyKaSii:
No, new installations by default are done with the "interpret-only" filter, so they are fast. Yes, cleaning dalvik-cache is the most effective way (besides changing the filter in the related prop), but I believe that even without cleaning dalvik-cache, Android will optimize dalvik-cache of new installations between reboots

Can you enter on TWRP, wipe dalvik-cache and reboot? If the problem has not yet been solved, then only uninstalling the module itself. To do this download the linked zip, install it on TWRP, go to TWRP file manager and navigate to /magisk folder, delete the folder related to ART Opt. Once again wipe dalvik-cache and reboot

https://xdaforums.com/apps/magisk/collection-magisk-modules-v2-t3575758/post72327720
[Magisk] veez21:
You don't have to wipe dalvik-cache every app install.

Maybe later. Some other stuff i gotta do

I don't know if there's a "very verbose" way to detect it. But setting the props should do it since, it specifically documented by google :confused:. Plus I can tell the free space difference when i choose another filter and wipe

I forgot. Probably under v0.6?

try manually wiping dalvik-cache

Yeah, not limited to samsung. But 2 min is hell long for s8. Gotta be this module + magisk issue
[Magisk] justjr:
[MENTION=7296895]veez21[/MENTION] I'm using only this now and not getting the super long boot logo delay:

dalvik.vm.image-dex2oat-filter=speed

dalvik.vm.dex2oat-thread_count=4

dalvik.vm.dex2oat-filter=speed

dalvik.vm.dex2oat-swap=true (why u took this off? this is nice)

Before it really was almost a minute or more on logo and only then proceed to boot, indeed. I think the culprit could be the flags.

No, first, I get this long delay too on my moto, second, boot time and so and so is super device specific.
[Magisk] veez21:
I haven't removed dalvik.vm.dex2oat-swap
[Magisk] justjr:
On the zip file, I see it on the non-magisk.sh, but not on the system.prop
[Magisk] catalyst05:
hi there,

i missed something here. Is there any version working with xposed plus samsung rom. or completely un-use-able for xposed + sammy rom... i tried some version. some version breaks xposed or some version not working well. i didnt find any version..
[Magisk] Shen Ron:
Try version 1 non magisk, that is the only one that works for my samsung with stock touchwiz rom that has xposed installed.
[Magisk] veez21:
It's in post-fs-data.sh. After your first reboot, it should be present in system.prop.

[MENTION=7799143]Shen Ron[/MENTION] [MENTION=6754295]catalyst05[/MENTION] [MENTION=6247359]atarek[/MENTION]

Try this test version
[Magisk] Shen Ron:
This one didn't work either and it seems that whatever that was added in is what causes magisk and xposed to be affected and gets unmounted
[Magisk] veez21:
Can you give me recovery.log and magisk.log?
[Magisk] Shen Ron:
It started working now and all i had to do was mount magisk in recovery delete the folder for the module reboot then go back in recovery and reinstall after changing the filter to everything and mount magisk before rebooting back into system. I want back those 10yrs it toke away from me for not working and making me have to reflash my rom:crying::crying:
[Magisk] veez21:
Working? If so :good:
[Magisk] veez21:
UPDATE TO v1.3!

Samsung users! You might have to uninstall (using uninstaller) then install the update

Workaround installation modified and fixed bugs

Samsung + Xposed Warning in Installer

Uninstaller Fixed

Nexus 6P/other devices on 7.1+ issues fixed (removed pm.dexopt.bg-dexopt)

Samsung + Xposed possible fix (needs testing)

dalvik.vm.dex2oat-filter as the "Reference" property

Download here or at Magisk Manager

Uninstaller
[Magisk] adekboreanaz:
Still no clue, first install is okay, then rebooting causing bootloop, i guess i have to give up using this module lol
[Magisk] veez21:
Logcat? nvm, what phone?
[Magisk] adekboreanaz:
I forgot to logcat, Redmi Note 4, did fstrim and zipalign on boot could causing this bootloop?

Thanks anyway, i feel significant result on speed filter tho, still figuring what causing this bootloop
[Magisk] veez21:
I don't know, send me a logcat so i can see what's happening ?

Another question, you're using miui?
[Magisk] adekboreanaz:
I will maybe later, yes i'm using miui need hardwork to get work around this rom, that don't give me blank apps who needs root permission :/, thanks anyway
[Magisk] catalyst05:
is there anybody to accept that module is working in samsung rom?
[Magisk] k2065183s:
Yeah,it works on my S7.
[Magisk] lahceneamine:
Does the long boot issue still in v1.3 ?
[Magisk] k2065183s:
It works well for me,I never get a long boot issue.
[Magisk] adekboreanaz:
I'm getting crazy here lol, the first install is okay again, i changed to everything then go to TWRP deleted Dalvik/Cache ART, then i know it will bootloop so i take a logcat the first logcat is error.txt, i go back to TWRP mount magisk then wipe dalvik again, it goes boot now but it's getting crazy My SIM card is missing couldn't read lol, so idk the problems, thanks OP:good:
[Magisk] adekboreanaz:
This is the screenshot that after boot successful but getting crazy

Well why the f i dopost here :(

I'm sorryyyyyy
[Magisk] veez21:
Thanks, I'll look into it. Your prob is really weird :p
[Magisk] android_htc:
Tried v1.3 on my Samsung Note 4. First boot okay (wiped cache). Noticed that it read Samsung detected + xposed message in Magisk log...please note that I don't have exposed installed!

Reboot..then system ui fc, unistalling module still does not fix system ui fc.. had to reflash.

Please note that test version "Sammy.zip" posted 2 days ago was good for me.
[Magisk] veez21:
Ok, use the sammy.zip atm. I'll just remove the prop for samsung in post-fs-data.sh (which was what i did with sammy.zip) for the next quick update

ALSO, FOR USERS THAT ARE UPDATING, NO NEED TO WIPE DALVIK-CACHE :)
[Magisk] nostrings:
This might shed some light - in case no one has tried.

I have a Samsung S6 running MM+systemless Xposed.

All of the props in the script, I have entered at the end of my build.prop. I am using SuperSU.

And they work. I tried putting the .sh file in my init.d directory, to no avail. Hence why I just edited my build.prop and put the lines myself.

Not sure if this helps - maybe for Samsung folks, have the build.prop be "overriden" with the values of the script.
[Magisk] rychu302:
I'm using MagMa-NX 8.5 on my note 3 systemless su xposed installed and flashing 1.3 without dalvik and cash cleaning with no problem at all everything working perfect

Wysłane z mojego SM-G950K przy użyciu Tapatalka
[Magisk] edoardotavecchio:
Which should be the issues with 7.1+ that you fixed? Are you talking about incompatibility with AudioModLib and Viper?
[Magisk] veez21:
No, some devices have issues with apps (titanium backup) crashing. Though you can try it yourself and tell us the results:)
[Magisk] atarek:
Hello [MENTION=7296895]veez21[/MENTION] for curiosity i updates through magisk manager without uninstall. Every thing runs successfully and Attatched screen shoot of getprop command. Is it a must to unistall?

Thanks for ur efforts :)

P.S: I'll test integration with xposed and update u. But after ur confirmation I'm ok or need to uninstall first
[Magisk] veez21:
Well, it's not a must to uninstall it. But you need to if you're on non-magisk when updating to v1.3
[Magisk] atarek:
Integration with xposed

results for testing integration with xposed and samsung note3 still not working but at least FB messenger crash has been fixed as attatched.
[Magisk] tsjanda:
Long boot fixed in 1.3 at lease for the Nexus 6
[Magisk] jaysonic88:
I'm running into system ui crashes on ver 1.1 and up. Using an LG V20 (on Nougat) with Magisk 12 for su. If there's any known workarounds let me know as i really liked this module. Keep up the great dev work!
[Magisk] lahceneamine:
I still have it :(

1m08s on the SplashScreen + 30s on the boot logo.

I hope it get fixed with Magisk v13, I'm gonna be patient until then :)
[Magisk] :
Got new issue with v1.3. After some time of using system just randomly freezes and I have to manually force reboot with power button to make it work again. Redmi Note 3 Pro with 7.1.2 and speed compiler.
[Magisk] veez21:
can you give a logcat?
[Magisk] :
Yeah I'll get it once I get home in a few hours
[Magisk] Aguys:
Am I the only one here bootloop with magisk?

Non-magisk working fine(write to build.prop).

Nexus 5X running RR ROM 5.8.3
[Magisk] mercenaryhmster:
weird issue

i just installed version 1.3 on my lg v20, and when i try to use the terminal ui i get the error "sh: art_magisk: not found"

please let me know what info you need from me to recreate or solve this problem.
[Magisk] Shen Ron:
The only app i have force closing is the samsung keyboard which was working perfecrly before using any of the previous or current versions of this module. Which is a pain in the ass, since that is the case i might as well copy the dalvic cache for the keyboard elseware then install this module and copy back the original dalvic cache to see if that would fix it. If not then i'll just stick with my panda keyboard and eat some bamboo leaves while i'm at it:cool:
[Magisk] psychoela:
same here:D
[Magisk] veez21:
Magisk is weirder than you and I thought :laugh:

Try changing the filter manually

Afaik, gboard is better than samsung's :p
[Magisk] LoV432:
Installed from magisk and when i came back to device i found that fingerprint was completely removed from setting and then i noticed battery dropped from 88 to 68 and then i noticed battery is going up instead of going down and yah....wtf xD

Used it on huawei honor 5x with Resurrection remix 7.1
[Magisk] veez21:
Lol, dafuq. Try wiping dalvik-cache
[Magisk] Mecca EL:
[MENTION=7296895]veez21[/MENTION] everything is working perfectly fine on my end. OTA updated with MagiskSU.
[Magisk] LoV432:
Deactivated module and everything went back... reactivated and went straight to recovery and wiped cache and dalvik but same result...no finger print and battery wrong
[Magisk] veez21:
Ok, you can disable it if you want to but, if you want to use it, try non-magisk (which you can extract from the zip and put it in post-fs-data, set perms to 755, execute and reboot
[Magisk] darzur:
Hi,

1.3 working perfectly on SGS5 with LOS 14.1 and Magisk. But I have one question: what is default Android filtering without this module?
[Magisk] veez21:
speed, which is also the default of this module. But more props are applied too, so you can also treat this as flash and forget kinda stuff :)
[Magisk] LoV432:
Ok so i installed the non-magisk 1 and the fingerprint is working but battery still going up...xDD i will just let it be and hope it settles down...btw no ui for non magisk 1?
[Magisk] veez21:
Yeah, but it's still manageable and easy to use. So, I didn't bother to :)
[Magisk] kastik4:
I am running on bootloop with magisk version on my nexus 5x i've tried to uninstall magisk the flash the zip and that doesn't work either can some guide me to install it manually?
[Magisk] :
Seems like the problem fixed itself. Haven't had any problems since yesterday. Though there is still one problem left - with Sauron mod for audio. I still lose my sim card, flashlight and camera when I flash this mod while using ART Optimization. Do you need log for that?
[Magisk] veez21:
Try non magisk

No, idk why audmodlib + this module is doing that ?
[Magisk] LoV432:
Aight...just an update....did a full discharge and started charging and it started charging from 55 :| so i turned on my mobile and it showed 17 battery...i let it run and battery was actually going up and down while it was charging xD at the end battery got stuck at 98....for 5 hours....then i just uninstalled it.....and battery went straight 100 xDD...
[Magisk] veez21:
Ok, so, you experienced it only when this module is installed? Observe it for a while without his module and see if it has that prob
[Magisk] LoV432:
Yah def the module....everything looks fine without module now
[Magisk] veez21:
Ok. What's the phone and rom again? I'm gonna put this in the OP ;)

And also, have you tried non magisk?
[Magisk] LoV432:
Huawei honor 5x with Resurrection remix 7.1 and yes I tested both...the magisk module will remove my fingerprint completely from settings and also make the battery issue and non magisk only makes the battery issue
[Magisk] :
I switched my rom again recently and noticed that your module + sauron mod actually work now. No idea what got it to work - different base because it's AICP or maybe sething different in magisk which is built in. Either way everything is fine now.