yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] pahapoika91:
The siankatabg:

The new build is here!

Changelog:

30.04.17

[*]All sources synced up to date

[*]Many small bugs fixed (Thx to AEX)

[*]Kernel updated to the latest available Render branch

[*]Some small EAS rom side changes

[*]Added camera wrapper (Thx to laos) (This should fix all the 3T front facing camera issues)

[*]Camera HAL1/HAL3 change on the fly is now working (All camera apps should work fine now, no matter what HAL they need)

[*]Added latest Google camera (fully functional with 1080p/60fps and slo-mo with audio)

[*]OnePlusCamera fixed to work with the new camera wrapper (functionality as before)

[*]Substratum app updated to the latest available one

[*]Back to the aosp toolchain for the kernel compilation (I need to test something)

[*]pocket: increase proximity sensor interval from 200ms to 400ms (All credits to the AOSPA team of course)

[*]Maybe something small that I forgot :)

He got it to work..

(Hal 3/1)
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmmh thanks for the info, I'll have to take a look at the sources.
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys I'm checking the stuff out for the camera wrapper, but since my repos were KIA, I need to make clobber, but I need the big PC. I'll do this later today, but not guarantee if I can upload this tonight, we'll see.
[OnePlus 3 & 3T Cross Device Development] OmarvinG94:
No rush man. Take your time. :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Build up ;) Not tested though so no guarantees this won't burn your cat!
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
Snap camera won't connect and Google camera would just fc for me... Dirty flashing from 0105 build...
[OnePlus 3 & 3T Cross Device Development] matssa:
OK thanks for the heads up I may be missing some snap stuff. For the OOS camera I know there is something to do in order to make it work. Please go back to the older version, I'll remove it from the downloads.
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
Back already, everything's peachy...

I think OOS port is fixed to work with the wrapper on Phoenix btw... I myself like Snap camera and using it, I wonder if it'll work with hal3 and camera2 api though.
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah I asked siankatabg to share if possible the OOS camera port :) for snap, I need to check, there should be a wrapper commit that fixes it.
[OnePlus 3 & 3T Cross Device Development] vxlts:
Is this updated with official LOS changes and sultan changes all the time or just periodically? Does the OTA work like in LOS? I've read it downloads the whole rom but i'm just wondering if it updates automatically via twrp after downloading in installing etc. or is there a longer process..
[OnePlus 3 & 3T Cross Device Development] matssa:
I'm not sure, I didn't test it. It should be the same as on LAOS.

No Snap camera commit, and still no info from siankatabg. If someone could give me the apk from his ROM including the Google Camera stuff from his ROM, I could try to include them here and test it out with the new camera stuff.

However, until these commits are stable and we have a working Snap, I'll go back to the original stuff with the HAL3 disabled (flash the HAL1 enabler in the Downloads section for HAL3 compatibility).
[OnePlus 3 & 3T Cross Device Development] Yarmek:
Is there a 2nd May build? Changelog states there is, but I can't seem to find it in devdb Downloads, just the 30 April, 1st May build and the HAL enabler.

Moreover I have a question about the whole HAL stuff:

Why do some Camera apps work, but others need a HAL1 or HAL3 enabler, what are they for? I am currently using an OOS Port and am applying a HAL3 enabler in order to make it work.
[OnePlus 3 & 3T Cross Device Development] zaidshb:
[MENTION=6313536]matssa[/MENTION] what's in today's build? OOS and Snap cameras are now working?

i.e "Squashed revert of HAL3 re-enable" is merged into this build?
[OnePlus 3 & 3T Cross Device Development] matssa:
Yesterday's build was removed since the camera stuff was buggy.

We have two different HALs : HAL1, which is a legacy HAL (an old one), and HAL3 which is the new one.

Some apps are only compatible with the old one (OOS camera port for example), others can work with both (Snap) and others can only work with the latest one since its most up to date.

On our side we can't for now tell that app to use that HAL. It's either one or the other. With the new stuff, we should be able to do that :)

The HAL enablers changes a line value in the init.target.rc that says if the HAL3 is enabled or not at boot. You can't change it when the system is on.

By default, on my ROM, the HAL3 is disabled. So if you want to use another app, then you may need to enable it.

Check the first post. The camera will work fine, I'll test some builds with the camera wrapper later.
[OnePlus 3 & 3T Cross Device Development] Calum 2:
The android file host link takes me to a login page, could you fix that please?
[OnePlus 3 & 3T Cross Device Development] matssa:
Use XDA DevDB, I'm only uploading on AFH if XDA DevDB doesn't work.
[OnePlus 3 & 3T Cross Device Development] Calum 2:
Roger. Tapatalk doesn't work with those links, but I can copy the thread to a browser and do it that way. Thanks.
[OnePlus 3 & 3T Cross Device Development] zaidshb:
A noob question here: I don't know if I got you right, but as I understood that either HAL1 or HAL3 can be enabled, and that camera apps can use only one of them, so how come (Almost) all camera apps are working on all ROMs? and how camera apps were working in previous versions but now don't? Can't we just stick to HAL1 for an example and live a happy life?
[OnePlus 3 & 3T Cross Device Development] matssa:
Well HAL3 is updated in order to have new features, like this ROM. This means that the apps must be updated to use this API.

My understanding is that some apps check which HAL is used in order to adapt. Some others are only compatible with one of the two.

If we stick with HAL1, this means that we close the system to all the new functionalities, speed increase, resolutions, etc., which is not a very good idea.

What we need to do imo is to make our ROM compatible with all HALs so that it can decide which one to chose. The best solution would be to use the same HAL everywhere and push the OEMs to use the latest update, but a bit hard...
[OnePlus 3 & 3T Cross Device Development] aadityarulez:
[MENTION=6313536]matssa[/MENTION] sorry if this is sounds stupid, but why would OnePlus base their cam on a old version of Hal and not make use of the newer version of Hal?
[OnePlus 3 & 3T Cross Device Development] matssa:
I really don't know, maybe because of the post-processing stuff? Or maybe we can't use the HAL3 because we are missing key features for compatibility. Unless OP releases the processing blob, we can't know for sure.
[OnePlus 3 & 3T Cross Device Development] Gomezie:
This is more of an FYI:

Had something strange happen on the 03/04 build.. Clean flashed, but when launching ex kernel manager it would load the splash screen and then reboot the phone?

Was too late in the night for me to attempt a logcat or anything, but wondered if you may know about it... Obviously I have the correct firmware and latest blu twrp.

Would like to try this room, do will eagerly await the next instalment.

Many thanks
[OnePlus 3 & 3T Cross Device Development] Yarmek:
It is caused by the Kernel, had the same problem Yesterday. Today I flashed the ElementalX Kernel and the Kernel Manager worked perfectly
[OnePlus 3 & 3T Cross Device Development] matssa:
Stange, I'll have to check the commits since I didn't change much to stay as much as possible the same as Sultan.

EDIT/// I can't manage to see which one made this issue. Can you try using EX Kernel on the ROM from Sultan?
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
Did someone try using snap with hal3 enabled? I think sultan made it to work with hal1, I tried it on the 0205 build which got taken down and couldn't connect to the camera...

I wonder if it's even worth the trouble if we lose sultans tweaks to the camera...
[OnePlus 3 & 3T Cross Device Development] Gomezie:
No worries mate.. once im out of work ill flash sultans and try it and report back :good:

//EDIT [MENTION=6313536]matssa[/MENTION]

So I just managed to flash Sultan rom, and EX Kernel manager works fine

Just clean flashed your 03/05 rom, and the EX Kernel manager loads, checks license and then reboots the device.

Do you have a reccomended way of capturing the logs for this? looking at guides now

Kind regards
[OnePlus 3 & 3T Cross Device Development] matssa:
On his builds, HAL3 is disabled, like on mine. Mine was already disabled from day one for the OOS Camera. We can't do much more than what is already done since OP didn't release anything.

Mmmh strange... Maybe something went wrong in my build, I'll try to make a new build and upload it. However, I compared both Githubs and there aren't changes that are missing or that can break this...
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
Yeah I know it's disabled, that's why I was asking if it is at all possible to use snap whilst hal3 enabled... I think the answer is no though.
[OnePlus 3 & 3T Cross Device Development] matssa:
Good question, Snap should work with HAL 3 and some little changes (change camera_shim and deactivate ZSL in advanced settings). Check https://review.lineageos.org/#/c/169839/ for more info.
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
If anyone is interested to know, snap camera really does work with hal3. No changes needed except for flashing hal3 enabler.
[OnePlus 3 & 3T Cross Device Development] matssa:
OK for the same issue while making clean. I'll have to revert some stuff and detect which one is the issue...
[OnePlus 3 & 3T Cross Device Development] matssa:
I'm doing a new build without any extra stuff in the kernel to see if the issue comes from the slider options or from the wakeclock blockers. Depending of where it comes from, I may need to remove the extra slider options for now.
[OnePlus 3 & 3T Cross Device Development] Gomezie:
Thanks matssa.. Pretty sure it will be the slider options, as I tested before with the wakelock blocks and all was fine
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah I fear as well. If that is the case, I'll remove them until I can find a better solution, maybe AOSP fixed it in the kernel somehow, but not sure, I didn't see anything. It could be on the app side however.
[OnePlus 3 & 3T Cross Device Development] Gomezie:
No worries,

Happy to test another build today with the kernel wakelocks implemented if that would help
[OnePlus 3 & 3T Cross Device Development] matssa:
Latest build has the same issue as before, so it's not the extra slider stuff...I don't fully understand where it bugs... I cleaned a bit my repos, I'm testing a frash build without my custom stuff. I'll add one by one my different custom stuff to see what makes it go bad.
[OnePlus 3 & 3T Cross Device Development] Gomezie:
Awesome, let me know if I can be a crash test dummy or anything
[OnePlus 3 & 3T Cross Device Development] matssa:
Just tested my clean build and didn't work, it seems I have the same issue regardless of my custom commits. Something on the kernel side broke the Ex Kernel app... All we need to do is wait and test out the next Sultan build and see if we have the same issues... I can try reverting kernel stuff to see if it works though, but can't know for sure :/
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
I know there was a change in the path the app reads its tunables from, at least regarding EAS related tunables(vox populi) . I remember joshuous saying on his thread flar2 changed it in order for people to edit these said tunables with ease, maybe that's what's conflicting with some of sultans kernel changes.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok thanks for the info, I reverted until the May 2nd to pin-point which commits are NOK.
[OnePlus 3 & 3T Cross Device Development] Gomezie:
Thanks mate.. does this have the kernel wakelocks built in? really want those :good:
[OnePlus 3 & 3T Cross Device Development] mrcigi:
In the user settings, flar2 added in the Dev folder. That's it. That wouldn't have effected anything at all because all it does is let you visually pick the folder instead of manually typing it in.
[OnePlus 3 & 3T Cross Device Development] matssa:
New build uploading where ElementalX works and everything else as well :) I had to revert 4 kernel commits, I'll check which one is making the stuff go bad, I think it can be https://github.com/Matssa56/android...mmit/da921da99b48c2573fb6286b06144aa1f35f333b or https://github.com/Matssa56/android...mmit/46f2ae2100c2ac87f4a7003c20846aaf26ca9981 (mostly thinking the first one since the second is a bug fix).

I'll check later with new builds. At least the new build has everything working :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for the info, it shouldn't do anything, it must be an extra commit that [MENTION=4800121]Sultanxda[/MENTION] did that broke the app. I'll see tonight or this week-end which one it is.
[OnePlus 3 & 3T Cross Device Development] Gomezie:
You legend.. thanks Matssa!
[OnePlus 3 & 3T Cross Device Development] ieatyoshis:
Is it possible to dirty flash from this to future official builds?
[OnePlus 3 & 3T Cross Device Development] matssa:
What official build? Sultan or LineageOS?
[OnePlus 3 & 3T Cross Device Development] ieatyoshis:
Future Sultan builds.
[OnePlus 3 & 3T Cross Device Development] matssa:
It could be possible, but I prefer you clean flash to be sure you don't have any issues. Coming from Sultan's builds, you could dirty flash though.
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys, I might have found the culprit for the Ex Kernel Manager issue: https://github.com/Matssa56/android...mmit/da921da99b48c2573fb6286b06144aa1f35f333b

I'm making a new build to test this out without the said commit, but since Sultan updated the blobs to the latest OpenBeta (16), I'm making a make clobber and should take about an hour. I'll also try to make a test build with the camera wrapper stuff since it appears it works. However, I would like to have the OOS port and the Google Camera stuff from [MENTION=4837394]siankatabg[/MENTION] so that I can include it here (he modified a bit the OOS port to make it work with the camera wrapper; so genius :) )
[OnePlus 3 & 3T Cross Device Development] Yarmek:
Great to hear you found the issue! Does the stuff with the Camera wrapper mean we don't have to flash HAL enablers?
[OnePlus 3 & 3T Cross Device Development] matssa:
Well there are several processes that we can follow. Sultan added a patch where we can list apps that uses HAL3, and those that aren't listed will use HAL1. Another solution would to use the wrapper but I'm not sure how it works, I think that the apps that uses HAL1 needs to be changed a bit in order to specify HAL1 (like what siankatabg did for OOS Camera port), but I'm not sure... I'll need to dig a bit more, but it seems that the wrapper should detect automatically which HAL to use depending of the app used...
[OnePlus 3 & 3T Cross Device Development] Yarmek:
Thanks for the explanation!
[OnePlus 3 & 3T Cross Device Development] matssa:
No problem ;) And I can confirm, the commit that I removed is the one making Ex Kernel Manager go bad. I'll inform Sultan on his thread. I'll make a new test build with the camera hal wrapper stuff to see how it goes.
[OnePlus 3 & 3T Cross Device Development] Gomezie:
Thanks for all your work on this Matssa, latest build runs really good mate!

Sent you a donation as thanks
[OnePlus 3 & 3T Cross Device Development] :
I've read quite a bit and I'm new to the op3. I see some talk about camera. How is it compared to the stock camera? Thanks in advance for any input and appreciate your work here op.
[OnePlus 3 & 3T Cross Device Development] Stupifier:
Difference is negligible.....some people are super picky though. Judge for yourself. Everyone's needs are different
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks a lot, I saw this later :) my pleasure to help you out, I lean and stuff :) anyways, thanks for your donation, it will help me out to get some beers ;) just to be clear, I'm not doing this for donations or anything else, your feedback is enough :D

I'll make new test builds tomorrow with the camera wrapper cause I was missing some stuff. Furthermore, I'll try to use a script that takes all the new OMS stuff automatically, so we'll always be up to date :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys, the latest build is taking more time than anticipted since I'm updating a OMS merge script in order to adapt it to my stuff. The script needs to be merged on a clean repo, but that means I need to delete my repos on github all the time, the changlog will be big, etc... So what I'm doing is an update to only keep the new ones and do that each time I build and keep the repos up to date :)

I hope to be able to finish this today so that I can share a build tonight, without the camera stuff. Tomorrow I'll upload the new build with the camera stuff if it works of course.
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys, I managed to make my script for the OMS merging, it can maybe help you guys out as well for ROM makers out there ;) I'm currently making the new build, I'll give this out when it is done :) I'll test the camera stuff tomorrow though. I'll keep you posted!
[OnePlus 3 & 3T Cross Device Development] The_Steph:
Matssa,

Thanks for your hard work, did you have anough time to vote today (if applicable of course) ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe yeah of course, went before lunch ;) Let's see the results tonight, even though they shouldn't be a surprise...

Last build is up guys! Please be aware that the blobs are now from the latest OOS beta 15, so you may need to flash the latest firmware.
[OnePlus 3 & 3T Cross Device Development] Norapapa:
Are the blobs from Beta 15 a Problem für oneplus 3T Users? 3T ist Beta 6 OOs.
[OnePlus 3 & 3T Cross Device Development] Yarmek:
I just flashed Modem + Firmware from OOS Beta 5, the Update to the newest version went perfectly after that. AFAIK you have to get the Modem + firmware specific to your device (3 or 3T) as they are slightly different.

EDIT: To clarify for those that aren't aware: OOS Beta 15 = OOS Beta 6 on 3T
[OnePlus 3 & 3T Cross Device Development] Norapapa:
Where Can i find the Modem and Firmware from Beta 6?
[OnePlus 3 & 3T Cross Device Development] Yarmek:
I don't know where to get OOS Beta 6, but I can Upload OOS Beta 5 for you (firmware + Modem)
[OnePlus 3 & 3T Cross Device Development] matssa:
There is a thread on XDA in the guides section where you can find the latest firmware and modem. Download it from there ;)
[OnePlus 3 & 3T Cross Device Development] mukesh22584:
[MENTION=6313536]matssa[/MENTION]

Great work..

i was missing two things in Sultan's ROM, 1- More options in Alert Slider, 2- OMS support,

and my search comes to end here...

Dirty flashed over Sultan's build, No issue, running so good.....

Thanks Mate, Great work..[emoji120] [emoji106] [emoji4]
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys sorry if I didn't give any update yet, I cleaned my build script with the OMS stuff. Tomorrow you should have a build :) and for OMS, good news, I'll always be up to date with the latest stuff, there's only one question that I need to ask myself, which can increase the build time, however I'm sure we won't have any issues when the rebase will come...

Anyways, I'll try to upload a camera test build as well.
[OnePlus 3 & 3T Cross Device Development] bounti:
So just that I fully understand. This rom is basically, with all intents and purposes, Sultan's rom (exact in every way including kernel) with the few features added in the initial post and OMS support? So performance should be the same as with his original?
[OnePlus 3 & 3T Cross Device Development] xT-g-K:
Couple of questions, can I flash this over the build by Sultan? Does this support the OTA like Sultan's ROM does, I love the OTA feature and don't want to part without it but really feel like I want substratum and not have to fear bootloops when upgrading.
[OnePlus 3 & 3T Cross Device Development] BolintsMiki:
Yup, basically Sultan + OMS + Wakelock blocker + Alert slider additions + Dash Charge on lock screen. IMO the best ROM on the OP3.
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
[MENTION=6313536]matssa[/MENTION] is it possible to add the touchkey driver from boeffla kernel? It'll make hardware buttons light up when used and not while interacting with the screen, found the commit on joshouos GitHub

https://github.com/VertexOS-Devices...mmit/7ab28ca661da52eeed25a978549fa80fef772de3
[OnePlus 3 & 3T Cross Device Development] matssa:
I'm not sure it is a good idea since this means we will diverge from Sultan's stuff, which can break things. I can add a poll asking for this feature, as promised before.
[OnePlus 3 & 3T Cross Device Development] matssa:
New build uploaded guys. Not much has changed though, or maybe it was more than a day ago since the changelog only checks the commits made in the last day.
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
Just thought it'll be a nice addition, not a deal breaker for me or anything.

Sultan just follows Los stock behavior on this matter, I do not know whether merging this commit will cause havoc or not ?

Thank you for the prompt response, I just went on a flashing spree and always find myself coming back here :)
[OnePlus 3 & 3T Cross Device Development] The_Steph:
Can't wait to flash it since Siabantag's camera addition :D
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah it was missing in the old build when I cleaned the repos...
[OnePlus 3 & 3T Cross Device Development] Yarmek:
I have a weird problem (was ocurring for some builds now):

I can't use the front facing camera. When trying to shoot a photo it animates like a photo was saved, but no photo ist being saved. After that the camera App looks normal, but all Buttons are unresponsive.

Suggestions?
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Hal3 is enabled for using latest Google cam?
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
I think you should flash hal3 enabler, That's what I did
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Ok i see in first Post. Any disadvantage whene i flash hal3?

Edit have installed now with hal3 and working very smooth. Only in oos camera i dont have the hdr button. Raw working too [emoji4].
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
https://source.android.com/devices/camera/camera3
[OnePlus 3 & 3T Cross Device Development] matssa:
OOS camera only works with HAL1. Google Camera works with HAL3 apparently, and Snap is a bit strange ;) with the camera wrapper, you might soon be able to use everything without any changes :)
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Good work matssa. My new daily rom for now.
[OnePlus 3 & 3T Cross Device Development] AmazingToast:
[MENTION=6313536]matssa[/MENTION] How close are you planning to keep this ROM to Sultans in terms of features?
[OnePlus 3 & 3T Cross Device Development] matssa:
My build is always updated using the latest stuff from sultan. I then add LineageOS stuff on the stuff that are not made by Sultan. I then add OMS and the custom stuff that was requested.

I will always make this process. However if someone wants to add a custom feature, they need to give me something that already exists (I don't have time or knowledge to code specific stuff), and I'll open a poll to see how many people would like to have this. Depending of the result, I'll add it (if I validate it of course, because if the change is too deep, it can divert to much from Sultan stuff like the display driver).
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Can you add clear all button and Header Image?
[OnePlus 3 & 3T Cross Device Development] Yozak:
Exactly
[OnePlus 3 & 3T Cross Device Development] thefraggle:
All good. Running smoothly. Nice work!