yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] bounti:
I have 2 requests ☺️

- Quick Unlock option (unlocks phone immediately when correct pin is entered)

- Double tap on lockscreen to sleep (some users disable the status bar at the lockscreen for added security, so dt2s on bar doesn't work)
[OnePlus 3 & 3T Cross Device Development] matssa:
Please give me a ROM that already has these functions implimented. I'll them check if it is possible, and open a poll if I deem it ok.

If you find the commits linked to it, it would be even faster.

However, I don't want to add so many custom stuff that maybe 2 person will use...
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Dirty Unicorns have both.
[OnePlus 3 & 3T Cross Device Development] bounti:
Sure. Both Resurrection Remix and crDroid has these features...

https://xdaforums.com/oneplus-3/one...pment/rom-kernel-resurrectionremix-n-t3524715

https://xdaforums.com/oneplus-3/one...ment/rom-crdroid-android-beta-builds-t3483640

One more features request I forgot out. Network Traffic Indicator toggle. Always found it to be a nice little feature to have. And it's also part the the aforementioned roms.
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Is there a Telegram Group for this Rom? Equalizer not work here.
[OnePlus 3 & 3T Cross Device Development] matssa:
Why don't you use those ROMs? Imo, the features you want to add is a bit more bloatware to me. Ill check a bit those features and keep you posted if I open a poll.

No telegram group, I don't like that app, sorry. And if it doesn't work, please test it directly on Sultan's build to see if the issue is still there.
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys,

I added a poll where you can vote concerning the type of the ROM in terms of extra stuff, since some of you want to add features, and others want to keep it as similar as possible to Sultan's stuff.

Please be aware that in all those options, I'll add extra stuff from LineageOS to test it (i.e. Camera Wrapper) since it is bound to be merged at some point.
[OnePlus 3 & 3T Cross Device Development] The_Steph:
+1 for Quck unlock option if you already found the commit to pick. It is really a nice addition.

For the record, I love the proxy dialer option, I am using it on a dialy basis, really helps a lot.

Btw I answered the poll :D
[OnePlus 3 & 3T Cross Device Development] matssa:
The quick unlock stuff was removed in Android L if I remember correctly because of security issues. On LL, we could use xPosed with gravity in order to add this back.

I'm don't really like to add stuff that has been removed for security reasons...
[OnePlus 3 & 3T Cross Device Development] matssa:
I added a third post where you can find the extra stuff that has been requested and the status.

As said, if you want a lot of custom stuff, I suggest you change ROMs and use something that has more stuff included like RR, DirtyUnicorn, or something else. I don't want to add to much stuff that will either break stuff, increase merging difficulties or increase bloatware.
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
I think the last option is way too general mate.

Does it mean any suggestion would be accepted on request? Sounds a bit off to me...

I can guarantee that'll be the top pick as well, most people will opt for that option in order to see their feature merged.

Edit: just saw your post concerning the 3rd post...
[OnePlus 3 & 3T Cross Device Development] anand22196:
Just one small thing which would be a nice addition. The options to customise Recents and Home button are there under Buttons Settings menu, but there are no options​ for the Back Button. Can you please look into it?
[OnePlus 3 & 3T Cross Device Development] eroigaps:
All of you who are requesting unneccessary bloaty features, I would like to redirect you to this thread:

https://xdaforums.com/oneplus-3/one...pment/rom-kernel-resurrectionremix-n-t3524715

There are unofficial sultanized builds of RR too if you dig alittle.

Please keep this project clean and true to the source!
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
There's a long press back button to kill application via developer options...
[OnePlus 3 & 3T Cross Device Development] matssa:
True, but I'm limited in the quantity of characters :) I'm not going to add any feature because it has been asked, I will of course check if it is even possible, if it already exists somewhere else (if not, I won't bother trying to bring it in), and if it is necessary to me.

If someone wants a custom feature, then he must tell me where he can find this option already. I'll then decide if I make a poll to see how many people want it, and of course if I want to add it in ;)

I won't even try to answer to people who will propose something without giving me some information (what is the feature, where can I find it, what it does, photos, etc...). Some features are not explicit, you can't understand what it does just by the name...

My objective is to add some extra stuff on the Sultan ROM, without becoming like RR or other ROMs where there are just too much custom stuff that makes the ROM very hard to configure and understand... Today, everything is about simplicity with customization possibilites. It is hard to make both, but it should be possible, especially today with all of our technologies.
[OnePlus 3 & 3T Cross Device Development] matssa:
Btw, the poll will be on for 2 weeks to let everyone vote. I hope that we get at least 50+ votes since we have 100+ downloads.
[OnePlus 3 & 3T Cross Device Development] Yarmek:
My opinion on adding more stuff:

With every addition we differ more with Sultans build. I made the decision to choose matssa's build over Sultans build solely for the oms support (and that is what the build originally was Made for). I really appreciate the work you put into the Project but if more and more Features I don't need are added I will not stick to the rom, although I really love the current state and never had a rom that suited me like that one. If the community decides to add more Features I have a request to make:

You could make two branches of the Project. One without all of the extra stuff (just oms and maybe Dash Charging Indicator) and the other branch with all of the requested Features.

The top solution would be an Aroma installation, but to me it seems like to much work for the moment being.
[OnePlus 3 & 3T Cross Device Development] eroigaps:
I agree with this 100%
[OnePlus 3 & 3T Cross Device Development] matssa:
Well it isn't a bad idea, but this means I need a better PC in order to build in less than 30min... And a good connection to share them... So today, I don't have the choice, it's one or the other. Someone else can make a copy of this project with the extra stuff if they want (with credit ofc ;) ).

For the AROMA, i'm not sure if it will work because it isn't as simple as installing new apps or changing some setprops stuff, you need to change core stuff, which are built with the ROM. I'm afraid we can't add these custom stuff via AROMA, it would be too simple :)

Again, this is why I added a poll, to see what the majority wants, like a democracy ;) The only change is that there are other ROMs that you can use, whereas when you make an election, you don't have a choice at the end ^^
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys I added a new test build with the camera wrapper. It should work with every app without any HAL3 enabler! Please give us a feedback if some apps don't work. You should first clear the app data just in case.

Known issue = OOS Camera Port doesn't have HDR, a change in the app is necessary (@siankatabg managed to change it but I'm waiting for his update, either the app or a script).
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Dirty flash ok?
[OnePlus 3 & 3T Cross Device Development] The_Steph:
matssa, I like lightweight ROMs and what you are doing is simply perfect to me.

Having small useful additions such as dialer proximity option or automatic unlock is really good from my point of view.

Nevertheless, I decided to use your ROM far before you implemented these imporvements as my concerns were to have the best camera quality without juggling with plugins (your addition of siankatabg camera and gallery is a nice one as well) and OMS.

I understand that you accept to include small extra features keeping it mind that you don't want to spent a lot of time on it (hence the cherry-picking) because of side effects that they ca cause.

I have no issues not to have extra features, I only think there are good improvements (I personnaly use the proxy speaker stuff daily) and I will respect your decision whatever it could be. Thanks for submitting this decisision to the poll though :good:

Regarding the automatic unlock feature, it for sure it lowers the security level as it lowers the number of tries to find the pin code as it automatically unlocks the phone once typed ;)

Thanks for your hard work publishing your ROM on a nearly daily basis!
[OnePlus 3 & 3T Cross Device Development] matssa:
Dirty flash of what? Please quote the post or be more specific.
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Dirty flash last build over 11 build. No hal3 flash in 12 build right.
[OnePlus 3 & 3T Cross Device Development] Syssx:
[MENTION=6313536]matssa[/MENTION] , I don't know if someone already mentioned it but double tap on lockscreen to lock is present on latest OOS. It's really usefull when you have DT2W set up and you just want to check time or any notifications when you dont have access to power button or when you're just lazy to press it.

Also please does the encryption work? I wasn't around for a while. Is the latest TWRP finally okay with encrypting LOS?
[OnePlus 3 & 3T Cross Device Development] eroigaps:
Front facing camera not working on 0511, in anyof the apps. Any fix?
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
Its working fine here.
[OnePlus 3 & 3T Cross Device Development] Norapapa:
No Downloadlink in the First post
[OnePlus 3 & 3T Cross Device Development] eroigaps:
3 or 3t? There has been 3t specific issues in other ROMs because of different front cam on 3t.

To be specific, the app appears to take a photo but nothing is saved and the app becomes unresponsive.
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
I have 3t.
[OnePlus 3 & 3T Cross Device Development] eroigaps:
Damn it. Guess I got some fiddling to do.
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
I have dirty flash now 12 build and all Cameras working fine without hal3 flashing.
[OnePlus 3 & 3T Cross Device Development] mp3deviant721:
I don't think you should add any of the features you have listed in red, since one of them is a security issue and the other two can be regarded as unnecessary in my opinion. However the double tap lock screen to sleep is a dead useful feature, I'd like to see that.

I'd like add a feature request for consideration as well. It is the ability to disable the feature that displays album/media art background on the lock screen when music is playing. Why? Because some of the music services I use have inconsistent or low quality album art. Can be found in Pure Nexus. Links to the two commits as follows:

https://github.com/PureNexusProject...mmit/14e8399067d192e369d7136368ea86125fb5fb9f

https://github.com/PureNexusProject...mmit/dc0a59989dcaa198e495b5b6291193669356b961
[OnePlus 3 & 3T Cross Device Development] bounti:
I don't use other roms beside Sultan's because other roms add way too many features which I think negatively affects performance. So I use Sultan's rom due to the fact that it's minimal, but there has always been features that I found missing that I used Gravitybox for. Quick unlock, dt2s lockscreen and network indicator are the main 3 that I enable.

Looking at it, I'm not really seeing how it would bloat the rom by much, but then again, I'm not a developer, so I wouldn't know lol. You'd know best. But yea, my vote goes to all 3 features. Nothing else is really need from me [emoji106]
[OnePlus 3 & 3T Cross Device Development] Yarmek:
I will install it and let you know :good:
[OnePlus 3 & 3T Cross Device Development] The_Steph:
The only "Clear all" button I know is for recents and is already in the ROM. You only need to swipe down on recents to scroll all recents and you'll have it appear.

Maybe what is wanted is to have it on screen all the time...
[OnePlus 3 & 3T Cross Device Development] matssa:
Strange, I can see it. However, you can go on the Download tab in the black ribbon.

Build 05/11 should work since I didn't remove anything for the camera... However, you can test 05/12, it should work correctly. Since I have a OP3, I can't test it :/ Maybe you can try to clean the data of the apps, it should help.

For the 05/12 build, OOS Camera shouldn't work properly since HDR isn't there (doesn't use the correct HAL).
[OnePlus 3 & 3T Cross Device Development] matssa:
I'm not hot for quick unlock for security reasons. For the double tap, I'll have to make a poll and see if I can add it. For the network indicator, I don't see what it is, can you show a photo or something?
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for the github stuff, it will be a lot easier :) I added it in the third post. I think it can be a good idea, I'll have to make a poll to see how many people wants it or not ^^
[OnePlus 3 & 3T Cross Device Development] matssa:
It won't bloat the ROM that much, but it adds extra stuff that is not translated, it increases the risks of having merging issues with upstream, and of course add some bugs ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Oh and guys, I tested a bit the camera stuff and it works on my side, and I also managed to make the OOS camera port work :) I will try to include the Google Camera as well from the Nexus topic (will need to check a bit to find it). I might try to include the Google Camera in the ROM directly, we will have 3 different camera apps, but imo they are the 3 big ones that everyone should use (OOS port for the quality, Google Camera for the slowmotion with audio and 1080 60FPS i think, and Snap to see if we have bugs).
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok Google Camera doesn't work fully, at least the slow mo doesn't work, gonna need to check a bit more to see why...
[OnePlus 3 & 3T Cross Device Development] eroigaps:
05/12 build front cam works! Yay!

How can I force hal1 on this build? Personally I only use OOS cam.

Build.prop edit?

Thanks
[OnePlus 3 & 3T Cross Device Development] BolintsMiki:
Weirdly enough for me OOS camera works and Google Camera force closes...
[OnePlus 3 & 3T Cross Device Development] matssa:
I'll upload the OOSs Camera and gallery update later so that you don't need to ;)

I only need to figure out how to make Google Camera work...
[OnePlus 3 & 3T Cross Device Development] eroigaps:
Nice! Many thanks
[OnePlus 3 & 3T Cross Device Development] matssa:
Done, you can find them in the downloads section. I'll include the updated version in the next builds so no need to update them ;)
[OnePlus 3 & 3T Cross Device Development] bounti:
It's not the clearest image, but it's the best I could find. It's just an indicator next to wifi or data signal icon that dynamically displays up and down network activity. View attachment 4147475
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
I have install Camera and Gallery 8.1. Whene i make a Picture i see a black preview in the Gallery.
[OnePlus 3 & 3T Cross Device Development] Xeon721:
If needed [MENTION=6313536]matssa[/MENTION] I got a linux remote that was used to build some LineageOS. If you don't have enough power or network capacities, we can clone your GitHub on this server, if you want. :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Strange it's ok on my side. Clear your data maybe?

Yeah I remember that you proposed last time when I was doing some​ custom LAOS builds ^^ thanks for the proposal, but since I have a script that needs to be run before every building, it's a bit complicated... But thanks for the idea, I'll keep it in mind :)
[OnePlus 3 & 3T Cross Device Development] Xeon721:
Oh I forgot that I already proposed haha

If you want I can create you a user in this server so you can transfer the scripts as you want
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks, I'll contact you if I need some help, but for now it's ok, since I have a big home PC and a smaller work PC with a big connection. So for now, it's ok ^^
[OnePlus 3 & 3T Cross Device Development] Dhairya:
ROM is just excellent just one issue networks drops signal bars keep increasing and decreasing rest rom just is perfect
[OnePlus 3 & 3T Cross Device Development] Schrotty35:
The Gallery 8.1 have a problem. I have wipe cache and settings but not help.
[OnePlus 3 & 3T Cross Device Development] matssa:
I dont use galery app so I didn't see this issue. Maybe try to use the old version?
[OnePlus 3 & 3T Cross Device Development] xT-g-K:
[MENTION=6313536]matssa[/MENTION] Is there anyway to dirty flash this over Sultan's build?
[OnePlus 3 & 3T Cross Device Development] matssa:
Yup it should work. However it can cause issues in the other way.
[OnePlus 3 & 3T Cross Device Development] xT-g-K:
Okay, I'll make a backup and try to update to your build. I'm really wanting OMS and the small tweaks you've made but really don't want to have to do a clean flash.

Edit: it worked a treat. Thanks for this build!
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey,

I won't release the kernel alone, always both together. However, you can still build it using my GitHub if you want.
[OnePlus 3 & 3T Cross Device Development] matssa:
Well if he is using my kernel sources, it would be great if he could put the credit somewhere, I don't remember if he already did (someone did but forgot who).

If he is using my GitHub, then he should have the wakelock blocker in it since I fully merged them.
[OnePlus 3 & 3T Cross Device Development] phoberus:
He uses sultans git, thats why the wakelock-blockers are not included

Thread: https://xdaforums.com/oneplus-3/one...elopment/op3t-resurrection-remix-rom-t3517461
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah he contacted me to use my github for the wakelock stuff but didn't manage to find them.
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys I updated the 3rd post with my different findings. Unfortunatly, a lot of custom stuff will not be included since the changes are either too much, which can cause merging issues with upstream, or because LAOS is too different than DrityUnicorn based ROMs (framework/base mostly). Those custom stuff needs to be added in a LAOS ROM before I can merge them.
[OnePlus 3 & 3T Cross Device Development] Nezorflame:
[MENTION=6313536]matssa[/MENTION] hey, could you please tell if the kernel included in your ROM is underclocked like Sultan did in his ROM? If so, will the Sultan's underclock disabler ZIP for OP3 devices work for your version too? Thanks in advance!
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey,

Yeah it is underclocked since I use the same kernel. The zip should work as well.
[OnePlus 3 & 3T Cross Device Development] Nezorflame:
This is understandable.

As for the network speed indicator, it is kinda handy, would be really nice if it could be implemented.

I know it's included in AICP (which is LAOS-based), I'll try to find the commits.
[OnePlus 3 & 3T Cross Device Development] zaidshb:
Please tell me if my post is OT.

The little core sometimes gets stuck at max clock and device gets hot, I'm using elementalx kernel but I've contacted the dev and he said it's not kernel related. Sometimes it appears that apps use a lot of battery randomly (YouTube app from magisk, BBM, Whatsapp, etc) I can't seem to put my finger on the root cause here.

Any thoughts guys?
[OnePlus 3 & 3T Cross Device Development] matssa:
A bit off topic, however I don't know why this happens, since I'm using the same stuff as sultan... Try checking there?
[OnePlus 3 & 3T Cross Device Development] hassan_1000:
For me thus us the best rom on the OnePlus 3/3T.

I had one feature request, can we get notification ticker option like there is in RR with is based on LOS? Thanks
[OnePlus 3 & 3T Cross Device Development] Yarmek:
I am sure matssa would look into your request, but be sure to share the commit from RR's github so matssa doesn't need to search for it
[OnePlus 3 & 3T Cross Device Development] matssa:
As he said, please give me the commit on GitHub of you can, it would greatly help me. However, I don't understand this option, can you please explain a bit more, with a photo?

Furthermore, I can't guarantee that the requested stuff will work, since some modifications are too deep (like the album disable, double tap to sleep on lockscreen) with some major differences with LAOS.
[OnePlus 3 & 3T Cross Device Development] Yozak:
[MENTION=6313536]matssa[/MENTION] I've been using this time over the past few weeks and it's great, especially now with the alert slider customization :) . But I was wondering why you didn't include a full wakelock blocker like the one in RR, where it lists all of your wakelocks and you can check the ones to block.
[OnePlus 3 & 3T Cross Device Development] vsot13:
[MENTION=6313536]matssa[/MENTION] I've search the thread, but nothing comes up. Is included kernel force encrypt like other Los ROMs? Or I have to flash different kernel?

Thanks in advance
[OnePlus 3 & 3T Cross Device Development] matssa:
I checked that feature and it is an extra app that replaces the battery stuff. In that app, it has a lot of rr customization. I can't carry-over this since it would surely break a lot of stuff...
[OnePlus 3 & 3T Cross Device Development] matssa:
Kernel force encrypt? I don't understand, please explain.
[OnePlus 3 & 3T Cross Device Development] BolintsMiki:
[MENTION=4495734]vsot13[/MENTION]

No LineageOS ROM includes force_encrypt in kernel, however you can always enable encryption in settings -> security and you will be just as secure.
[OnePlus 3 & 3T Cross Device Development] The_Steph:
[MENTION=6313536]matssa[/MENTION]

Long time no updates, I need my fix ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah, I had some work to do, I'll try to make a build today but no guarantees...
[OnePlus 3 & 3T Cross Device Development] The_Steph:
No worries, like everyone here I know that you have a real life and that it is more important than anything else.
[OnePlus 3 & 3T Cross Device Development] Xeon721:
I just have one question...

Am I the only one who have applications disappearing from Recents list? They are still open and in RAM, but they disappear from my Recents list. It often happens at night.
[OnePlus 3 & 3T Cross Device Development] matssa:
Build uploaded ;)
[OnePlus 3 & 3T Cross Device Development] Dhairya:
well still I am facing random network drops on sim 1 can it be fixed even tried flashing firmware clean flashed 2 times results are the same
[OnePlus 3 & 3T Cross Device Development] Jagdish84:
Sultan explained on his thread that these are the real signal values and oneplus alter them(on OOS) in order for it to look like you have a better signal than you really have... He also stated that'll not be changed...
[OnePlus 3 & 3T Cross Device Development] Dhairya:
oh so one plus cheats and alter its aha this is something new intersting
[OnePlus 3 & 3T Cross Device Development] OmarvinG94:
Just want to make sure. Does it still require OB15 firmware or OB16 for the latest build?
[OnePlus 3 & 3T Cross Device Development] matssa:
The blobs used are those from OB15. You can always try to use the modem/firmware from OB16 if you want though.
[OnePlus 3 & 3T Cross Device Development] mp3deviant721:
So this isn't technically a feature request but more or less re-enabling a feature that was disabled... Official Lineage has lockscreen blur but this build doesn't. It looks like Sultan disabled it. Would you be willing to try to re-enable it [MENTION=6313536]matssa[/MENTION]?

https://github.com/Matssa56/android...mmit/3b4d73286ada2f0b0da9a746fcc8698c21c64b4b

I'm willing to test this too for issues if you are willing to revert this commit.
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah I'll check it out and see if I will enable it. I'll add this on the the post.