yashsingh1/xdaforums huggingface dataset:
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Jrhotrod:
I don't see how fewer device trees makes it easier for long-term maintenance. But then again, I've never been too well-versed in Android code and it's low-level system.

At any rate, perhaps we could pester the team enough to give in - once 15.1 comes out I'd love to have official builds. I'll look into requests and such and report back for the brigade :fingers-crossed:
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Banana Joe:
I'm in for the pestering... I had an impression (confirmed by Vache's reply) that only stock was accessing the camera in a reliable way, but I can't tolerate Lenovo's trackers crippling our device all the way to "Google Services" battery drains, so I'm on board for the long run, it's either Lineage or nothing at all :cool:
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
https://github.com/boype/android_de...mmit/d3c322a1def3910e0cc6463e1638084592e57439

This will fix it. You'll lose the color profiles option though, which is pretty much useless anyway if you ask me, since we already have color temperature control.

I suggest a 'make clean' before you build.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] elisam98:
Thanks [MENTION=4615478]boype[/MENTION]! Updated my manifests, syncing, and building right now. :good:
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] sjrmac:
You should ask [MENTION=1829889]vache[/MENTION] to let you start pushing to boulzordev repos to update the original sources :)
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Jrhotrod:
Ok, I've opened a new thread on r/lineageos concerning a new kernel tree for potter. More ways to ask will be updated on this post, keep tabs on it!

Edit 1: PM me your Telegram usernames if you're interested in the cause, I'm about to make a Telegram group for this issue so we can communicate a bit more effectively.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] vache:
Not sure that's a good idea (it could have the opposite effect of what you want). I'm already in direct relation with the team to speak about that. But anyway, let see where it goes.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] king.ska:
Thanks for reviving LineageOS 14.1 i was looking for a nougat ROM so far it's stable. I appreciate your work.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] elisam98:
Just checking in. The issue is no more. Thanks!
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] sjrmac:
Has pulling potters specific kernel drivers and adding them to the common 8953 kernel been done? That's how KLTE became unified when things were merged...
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
Everything works fine when having built for potter on the addison's kernel tree, except for the camera, which throws errors in kmsg and won't initialize. I tried replacing the camera drivers and thoroughly checked the potter's board files by comparing them with the ones from vache's tree. It's a tough nut to crack. If I remember correctly, I traced the issue back to the flash led which was the one acting up. But then again, I might be mistaken.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] sjrmac:
Defconfig options maybe to mess with? I'm sure you've tried a load of options already... Galaxy S5 sport had some issues like this since camera options were slightly different from regular S5. Did you merge the Addison and Potter kernels? I'm thinking that was done from what you said. But yeah, odd issue...
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
I checked the config, too and I'm sure that's not it.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] infected36:
I don't suppose this works for the regular Moto G5?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
Nope. Don't think it does
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
I FOUND OUT WHAT BROKE THE FINGER PRINT SENSOR GESTURES AND I DON'T KNOW HOW TO GO ABOUT GETTING IT FIXED PLEASE HELP. Long story short i switched ROMs and after messing with magisc and accidentally turning selinux to enforcing I found out that that's what broke it because that's what broke it on the other rom too. If you use selunix changer you can change it to permissive and it'll work again but the dev has to change the kernel to permissive for it to be permanently fixed unless he finds a way around it
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
Can we please get the option to turn off the nav bar?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] titofariasl:
Where is the changelog? Thanks

---------- Post added at 02:37 AM ---------- Previous post was at 02:32 AM ----------

qemu.hw.mainkeys=1 Add this line to build.prop

---------- Post added at 02:43 AM ---------- Previous post was at 02:37 AM ----------

qemu.hw.mainkeys=1 Add this line to build.prop
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
I did this already. I just don't understand why you wouldn't make it an option in settings so it's easy to turn on and off? I think that would be pretty cool. There are two rooms that go this already I just like this one more
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
Soooooois quick charge implimented in the kernel?

https://www.reddit.com/r/MotoX/comments/46si3t/does_turbo_charge_work_on_custom_rom_x_2014/

EDIT: It works and there's an app made for Moto phones to like you know when it's working on a custom ROM. It's called turbo toast
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] manikchathli:
Awesome ROM!
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] smitharro:
Well, i don't know is [MENTION=1829889]vache[/MENTION] is aiming for official support on this phone. If not, he can probably rather easy make a toggle for this. If he aims to be official however, he's restricted to the official settings of LineageOS, which aims to give uniformity across all different devices.

To be short: if a developer adds to much extra options it can't become official. Unfortunately most fingerprint scanners on other devices don't have a swiping possibility... so removing the software buttons would actually make them unusable. Only older phones and Samsungs have hardware buttons nowadays....
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Karlinski:
Thanks for this find!
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] piggehperson:
This works on the 32GB model too, right? Even though it doesn't have as much RAM? Sorry if this is a stupid question, this is my first phone with hardware variations like this.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
Yes it works. Mine is 3gb of RAM and 32gb of storage and everything is ok... Except turbocharge maybe but I have to test a little more...
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] piggehperson:
Thanks! I was worried that it would try to access RAM that wasn't there or something and mess everything up. I'm downloading it now.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] jstiel:
I used BuildPropEditor to do this and every time, it wiped out the camera. I now edit it with the text editor in Root Explorer without a problem.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
Hey everyone! Is voice over lte still broken on this rom?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] sharan.nyn:
Nope it never was
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
Okay wait your response​ is broken. Is voice over lte working now?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] sharan.nyn:
Lol sorry for the confusion. I meant to say that it has been working from the very beginning. The repo doesn't have any recent changes regarding voLTE. So it must be working now too.

If you find it not working be sure to let us know here. :)
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] zeft64:
Well what the heck. Every time I've flashed the rom and I'd place a call it would switch from lte to hspa+

So does that mean I have to turn it back on or something?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] sharan.nyn:
Well in India we use it with Jio SIM and it works completely fine. One thing you can do is, check if a HD icon is showing in the notifications. The notification must say your device is HD capable. If this is not showing then go to More under wireless settings. Then cellular networks inside there enable Enhanced 4G LTE mode
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] 中本哲史:
I've registered to this forum only to thank [MENTION=4615478]boype[/MENTION] and [MENTION=1829889]vache[/MENTION] for their work.

I own a Moto G5 plus, and as the most of the people here, I can't build my ROM on my own.

Considering the poor support and lack of updates from Motorola / Lenovo, you guys are our only source of updates. Thanks a lot.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] arslanon.e:
Hi guys,

I have the XT1687 and I installed LOS 14.1 from here.

I have a problem with proximity sensor -- After the call is connected, the screen goes black, and no matter what I do, the screen won't turn back on until the call is disconnected.

Is this a bug?

Or is there a way I can find out if the proximity sensor is damaged on the phone?

I'd appreciate some help.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] tuxattack80:
Install sensors multi-tool from the play store then find proximity sensor and move your hand towards and away from the phone. You should see the value change. If not try another rom. Do the same thing with the app, if still nothing it's probably a faulty sensor. My guess is you have something conflicting with it.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] arslanon.e:
Worked...!

Thank you! I installed crDroid and in it the proximity sensor works.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] FatHorse9000:
I just came here to say that I very much appreciate the work beeing done on this rom.

It's been 6 months now without any heavy issues.

It's been a very good experience so far with noticeable developments between the nightlies. It's great and I enjoy this rom every day.

I just wanted you to know that there are more quiet users out here, too, that appreciate everything they can get here for free and very much appreciate the work being done here.

So thank you so very much.

Best

A happy user
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
New build up

Changes since last build

includes all LineageOS commits up to 2018-02-25

updated kernel to Linux 3.18.96

enabled zram multi streaming (parallel compression)

minor bfq iosched tweak for flash drives

Download links are in the OP.

Take care,

B.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Jrhotrod:
Is the Lineage Easter egg new? Or has it always been there? It's pretty cool
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] reuber:
[MENTION=4615478]boype[/MENTION] What is the possibility of porting the network traffic that [MENTION=1829889]vache[/MENTION] included in Lineage 15.1 to nodes of 14.1? once you already include the fit of the picture, I would be very grateful!
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
I'm not sure I'm following. What network traffic?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] reuber:
Network traffic meter that positions itself in the status bar, allowing real-time measurement of download and upload speed
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] tuxattack80:
Thanks for the update, extremely solid and smooth. I like many would love to be full time Oreo but unfortunately, thanks to school I need my blasted camera to work inside apps??. So thankfully we have this awesome rom to fall back on ??
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] sjrmac:
I believe that's a 15.1 (Oreo) feature I think. It is kinda cool :)
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] dot64:
Hello, Does anyone have Dolby Atmos working on this LOS14.1? 2 Dolby modules from Magisk install but don't actually function.

Edit: Fixed & Working. For anyone who may be wondering, I needed to install the universal deep_buffer Remover along with the Audio Modification Library via Magisk. The order I did was 1st Universal deep_buffer Remover, 2nd Dolby Atmos (ZTE Axon 7) (by ahrion, zackptg5), ViPER4Android FX (by ahrion, zackptg5), then Audio Modification Library. Oh and be sure AudioFX is not running/turned off before installing the modules. Both audio mods (Dolby Atmos & ViPER4Android FX) working good so far! :)
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
Ah, thanks for clearing that up.

I'm not planning to backport cm15 features though... Sorry.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] reuber:
It's okay, thanks for keeping up that great job.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Meowdib:
Are you trying to install an old one? I think the unity one works.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] dot64:
No, just trying to get the latest ones installed through Magisk modules that works. One thing I couldn't figure out is if it is normal or not to also have Dolby and/or ViPER4Android work during voice calls whether on speaker or not. So far I can't get this to work. Not sure if it's by design or if its possible to do.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
[MENTION=4615478]boype[/MENTION]: does full encryption work? I can't find anything in this thread except the comment on removing encryption after flashing twrp. As of now I disabled encryption for the initial flash of the 25022018 build, I configured everything to my liking and now I would like to encrypt my phone. I've had some bad experiences on previous phones and CM phone encryption, so i want to be sure that it works first.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] tuxattack80:
Cringing at the idea of Justin Bieber having a linux distro.....:laugh::laugh::laugh: LMAO!
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] karl0272:
I'm running the older Jan 8th build with encryption. Seems to work OK.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
Should be working fine. I have encryption turned on since day one with LOS.

Twrp is a little more complicated, though.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
Thanks for the heads-up. I can confirm that this is now officially the first CM/LOS I was able to fully encrypt. No problems so far :good:

Edit:

Netflix isn't showing up (marked incompatible) in the play store (just one example). Is this the case for all apps that check for the verified devide check with LOS?

I guess it isn't a general incompatibility, as you can sideload netflix from APKMirror or their own site and everything works fine.

Edit 2: I just saw that the device fails the extended safetynet check, but passes the basic safetynet security check. I guess our Potter device passes the bootloader unlocked flag to the system?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] tuxattack80:
Yeah I think it's something going with safety net. After you flash magisk it will let you install it without needing the universal safety net fix. Think maybe it's on the server side seeing as it will actually let you side load it client side with no issues.

Edit: or what you just said because it sounds better lol
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
I think i read somewhere that Netflix won't install on rooted devices. It's not the ROM's fault.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
Yeah, netflix does not install on rooted devices, as well as most banking apps. But LOS 14.1 does not come pre-rooted, right? i did not activate root or flash su (banking apps and authenticators are working fine). In a reddit thread i read, that it's sometimes the kernel passing the bootloader unlock flag to the system (device specific). For 14.1 this won't be a problem, but if I read correctly this behaviour is not allowed for official status on 15.1 :eek:
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
Could you post the link to the source?

The patch for the cmdline could be easily applied to the kernel. It's quite hacky, however.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
Pretty good safetynet reference I found:

https://www.reddit.com/r/LineageOS/comments/81o53s/safetynet_test/dv425gn/

Here's LOS official stance:

https://www.lineageos.org/Safetynet/

https://wiki.lineageos.org/faq.html#my-device-doesnt-pass-safetynet

Seems i was wrong and LOS does not circumvent the passing of the unlock flag from the kernel to the system. Seems that it is device specific, as in some devices do this on stock kernel and some don't and it will carry over to the LOS kernel (correct me if I'm wrong).

Here's the workaround (if it should be implemented after your evaluation of the situation):

https://github.com/sultanxda/android_kernel_oneplus_msm8996/commit/abc05b16bbd33521c2fffaf491c5657a94bfcfc5

https://www.xda-developers.com/sultanxda-bypasses-new-safetynet-unlocked-bootloader-check-on-latest-cm13-builds-for-op3/

SultanXDA stated that it will work on almost any device (except for some pretty janky, rare configurations).
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
Check out the attached file. This passes SafetyNet. Just flash via TWRP and reboot. No wipes.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
It works! Thank you. :)

Seems to be a simpler soution than I first thought :eek:

For clarification: will this from now on be implemented into your builds, or do we flash it after each nightly?

Was I right about my correction regarding official status?

We can't have a workaround like this to get official, do we?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Banana Joe:
Dude... Read on a few pages back, vache cleared up the issue, potter is sharing a kernel tree with Addison, that means our device doesn't have its own tree, which means it cannot get official (nothing to do with safety net or workarounds...).

I know you're coming from a different place here, but both of the lineage threads were flooded the last few days by people asking questions that were answered over TWENTY times on occasion in the threads... Pls search the thread before asking something at all times ;)
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
I read that. But my question wasn't even asking if this workaround is the reason our device is held back from becoming official :eek: My question was - as stated above - if a woraround like this is even possible if you want to become official, because of LOS' stance on this particular matter.

We clearly discussed sources for Safetynet and a workaorund which boype implemented. My question was just a small part of a reply and did not even touch the subject of the shared device trees, but a different topic to consider when using LOS.

No need to be rude :(
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Banana Joe:
That's why I said "I know YOU are coming from a different place". This isn't about being rude, it's about the horror :D of seeing potential important information get buried under pages and pages of questions that were already answered somewhere within the same thread... I'm getting the same allergy most senior members have...

And honestly, what is a safetynet issue to a device that doesn't even have its own kernel tree if we're talking "official". That's my point...

We're close to it as far as functionality goes, I'm using 15.1 for a couple weeks already, and had used 14.1 before for several weeks for my daily driver, but the shared kernel-tree is the "root" of all problems, and this manifests itself clearly with everything using the camera and some other odd bugs, safetynet problem might be a consequence of that just as well. Until Potter gets its own tree, we have to be happy with what we currently have...
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
Okay, maybe I misunderstood your post :highfive:

yeah, the problems with the addison tree are the main reason I use 14.1 again, as boype started maintaining it again. And I wholeheartedly agree that this safetynet workaround is the least of the problems reagrding 15.1 :(

Let's hope the LOS team gives potter its' own kernel in the future.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Banana Joe:
:highfive:

you know that 14.1 also has the same tree problem, right? that's actually why I switched over to 15.1... As far as functionality goes, not so much difference, but I'm tempted to try Boype's builds on N... If you want to see how far we're able to get towards "stable", try these things:

1) without enabling Camera 2 API try using the camera in Skype, What'sApp etc;

2) try recording videos and taking photos with LOS stock camera;

3) If Skype video isn't working, install the Magisk module enabling Cam2 API (to be found over on the GCam mod thread here on Potter);

4) Once you get the camera to take photos and work inside apps, try to record videos.

If all above work, 14.1 is closer to stable than 15.1. I doubt though, from past experience ;)
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
That's exactly why I switched over. I tried 14.1 to see if the bugs persist, but (at least for me) the following can be done without FCs or black images:

1) Pictures in Whatsapp and Instagram

2) Recording in camera apps different from LOS camera (e.g. Google Camera/Moto Camera). This did not work in 15.1.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Banana Joe:
did you try Skype video-calling?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
Haven't tried it yet. I only tried Duo video calls and they are working.

I will try skype video calls and report back later.

Edit: [MENTION=7645313]scolfaro[/MENTION] Skype video calls not working
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Jrhotrod:
Did you try the Magisk module?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
No, I didn't try the magisk module, but the point was to see if the bare ROM can handle this without any extension :good:
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] boype:
I'm not going to bake it into the ROM builds. I could provide a link in the OP, though.

Yes, that's right!

BTW: next build won't happen until some time next week because I'm really busy and out the whole next weekend. It's not that you're missing a whole lot of commits from the LOS sources anyway, since there is hardly any activity on the 14.1 branch.
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
Thank you for clarifying this. I am fine with the file as it is, but newcomers to this may miss it,.so a link in the OP might be best :)
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] darkglobe87:
Why is super / stock not recommended for gapps? I am used to some Google apps after stock and having a long line of Moto g phones... I use aroma usually to select my own list but am never sure exactly what I should be installing. I don't like there being a stock email app as I never use it. Is there a drawback to installing lots of Google apps? Which package would you guys recommend?

Finally is that safety net kernel file above just a fix for safetynet? Will it work with newer builds?

Sorry for all the questions am moving back to 14.1 because of obb folder issue on all Oreo ROMs, which is extremely annoying as I prefer Oreo for every other reason
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] Jrhotrod:
Getting lots of cell standby battery drain... I'm talking 20% of my battery is being consumed by this. I checked BetterBatteryStats and didn't see anything out of the ordinary... suggestions?
[Moto G5 Plus ROMs, Kernels, Recoveries, & Other De] :
I used Super OpenGAPPS wihtout earth, fit, pixel launcher + icons and news stand. Everything worked fine.

I can't answer you, why it is not advised, but it works.

The Kernel fix has to flashed after updating. At least if it still works like in the past, when i was using different roms from time to time.