yashsingh1/xdaforums huggingface dataset:
[Magisk] AndroMani:
Cast Screen features now works using this build.prop edit

Thank you so much.

I exactly followed your steps and added the following two lines of code in a file I named "Wireless Display" to enable screen mirroring in my Moto G2 4G LTE 2014 (running stock Marshmallow 6.0) that was disabled by default in the original build.prop file. After rebooting the system, I am able to successfully cast my android screen to my big screen smart TV. The code I added in an empty file in the following location /Magisk/.core/post-fs-data.d/ is:

#!/system/bin/sh

resetprop persist.sys.wfd.virtual 1

resetprop persist.debug.wfd.enable 1

It is working fine without touching the original build.prop file under the System folder. Super cool!!!

Similarly, can I also add new codes to the build.prop file - as there are many build.prop tweaks available - to make use of those features as well? For example, I want to achieve the following with the given codes below.

ro.config.hw_quickpoweron=true (To Enable Faster Boot)

windowsmgr.support_rotation_270=true (To Force 270-Degree Rotation on All Apps)

wifi.supplicant_scan_interval=XXX (To Increase The Time Between WiFi Network Scans)

debug.performance.tuning=1 (For Improved Overall Performance)

windowsmgr.max_events_per_sec=150

ro.min_pointer_dur=8 ro.max.fling_velocity=12000

ro.min.fling_velocity=8000

(To Improve Scrolling)

What syntax I should add in the script file to achieve this? Can I add these codes to the same file I used for screen mirroring OR I should create separate files for each of these functions? Please guide me. Thank you once again.
[Magisk] Didgeridoohan:
You can find the syntax for the resetprop tool here:

https://github.com/topjohnwu/Magisk/blob/master/docs/applets.md#resetprop

It's real simple though... Just do what you did with the other two props. Here's an example from your list above:

resetprop windowsmgr.support_rotation_270 true

You can put them all in one script.
[Magisk] AndroMani:
Thank you for the quick reply. I will try them and update the thread if there are any issues.

By the way, SafetyNet check failed for me, that is, if I do not enable the "core only" mode in Magisk Manager settings. I tried flashing a universal SafetyNet check fix zip file from another XDA thread. But it failed and I later realized that it was meant for Xiaomi and other devices. So, I uninstalled it. I need the SafetyNet work for me so I can use one of my Live streaming TV apps that failed when I disabled the "core only" mode.

Is there a fix for my device - Moto G2 4G LTE 2014 - until [MENTION=4470081]topjohnwu[/MENTION] provides this feature for most devices in his next stable release of magisk manager?

Thanks again.
[Magisk] Didgeridoohan:
Upload a Magisk log.

Edit: from when SN fails, that is...
[Magisk] Didgeridoohan:
[MENTION=8778136]AndroMani[/MENTION]

I suspected it'd be this:

Magisk : xposed_23: constructing magic mount structure

No can do passing SafetyNet with Xposed active... It can't be hidden. The best you can achieve is passing cts with a Xposed module that I can't remember the name of right now. It'll still fail basic integrity...

You can also disable the Xposed module in the Manager and reboot whenever you need to pass SafetyNet.
[Magisk] AndroMani:
Thank you for clarifying what could have caused the SN failure.

Infact, before checking your response, I disabled the Xposed module also as part of uninstalling the Viper4Android magisk module that was not working for me. (Still its not working after trying all available options within Magisk and checking other XDA threads. I think I need to dig more deep into it and get the right zip file for my phone to make it work. Though I know this is not the place for it, any suggestion in that front is welcome too). And to my surprise, I found that the system passed the SN check after reboot. Then, I realized the same that the Xposed module was causing the SN failure.

I was under the assumption that since Magisk provides a systemless Xposed framework for download, all modules

of Xposed will also work in a systemless manner just like the Magisk modules themselves. But I realized actually they are not.

That makes me to raise the following question: Why include Xposed framework within the Magisk manager in the first place when its modules will not work systemlessly? I also guessed the following answers for the same.

1. Provide the Xposed framework and its modules to be compatible with the Magisk manager users also so its features (those not available in stock rom or some useful customizations) can be used by those who have migrated from SuperSU way of rooting or using only the Magisk Manager for their rooting needs.

2. Those who need not bother about passing SafetyNet and finally,

3. Using the Magisk manager, those who needs to pass SafetyNet can simply turn it off (by disabling the Xposed framework), that way one can have the best of both worlds. The only hassle with this option is, the reboot time of the system after both enable/disable of Xposed is anywhere close to 30 minutes - the optimizing apps part - for me and I think that is too much. If it can be within 5 minutes or so, one can use it without any reservations. Not sure if it is related to the no. of apps I have OR the hardware specs I have.

(But ideally, I wish if the Xposed framework and all of its modules are developed the same way as Magisk Manager, we need not worry about passing SN even with Xposed installed. OR if Magisk hide can take care of hiding the Xposed framework also just like it currently hides the Xposed installer App. In that case, the System folder will not be touched at all and no hassle of losing the Xposed features after reboot. I am sure the XDA developers would have thought about this too and we might get a solution some time in future. Ofcourse, no ETAs in mind).

Your comments on the above answers to my question are welcome and thank you once again for all your support.
[Magisk] manos78:
"No Device Check": http://repo.xposed.info/module/com.pyler.nodevicecheck

It works on Nougat! :laugh:
[Magisk] Didgeridoohan:
[MENTION=8778136]AndroMani[/MENTION]

The reason you find Xposed as a Magisk module is to make Xposed systemless. And it is just that, completely systemless. That's why you can disable it and reboot to pass SafetyNet again.

The issue is that Xposed is more than just the framework files. Those can easily be hidden by MagiskHide. Unfortunately, SafetyNet also checks the running zygote process and that can't be hidden...
[Magisk] AndroMani:
Thank you for your response. Now I got it and like I said before if only the reboot time after enable/disable of the Xposed module in Magisk is improved somehow, it will make users doubly happy - already it made life easier a lot easier though...
[Magisk] AndroMani:
Thanks for the excellent Info!!!

Does it return "True" for both SafetyNet checks - that is, ctsProfrile & basicIntergrity? And how can we install that APK? -- Is it included as one of the Xposed installer modules OR it should be run separately with Xposed enabled in Magisk?

Correction: [MENTION=4667597]Didgeridoohan[/MENTION] has said that it still fails basicIntegrity check. So, only ctsProfile will pass.
[Magisk] manos78:
No. Sorry! It only returns TRUE for ctsProfile.

At time, it's impossible (as we know) to pass full SafetyNet checks with Xposed enabled.

It's in the Xposed official repository.

And regarding Xposed for Magisk, yes you need to use it, as you need to use this module plus the MagiskHide.
[Magisk] AndroMani:
Thank you for the information. I will try it with Xposed enabled in Magisk and see what happens.
[Magisk] rufk:
Failed SafetyNet

Hey [MENTION=4667597]Didgeridoohan[/MENTION]

I have a Vodafone Smart Ultra 6, running LineageOS 14.1 (Equivalent Android M 7.1.4), and have Magisk v16 running, with root access and Magisk Hide masking that from most apps.

However, despite having no traces of SuperSU or the like, and not having Xposed installed, my phone passes the 'basicIntegrity' test but not the 'ctsProfileMatch'

I believe this is due to SafetyNet recognizing that the custom ROM isn't stock.

I have installed your prop editor Magisk module, and hopefully this should trick the SafetyNet so that it will pass.

What actual prop values do I need to change for this to work?

Thanks in advance :)
[Magisk] GrayJack:
del
[Magisk] Didgeridoohan:
Magisk uses the resetprop tool to set any props you've added to the system.prop file, so using a module or a boot script is basically the same thing...
[Magisk] AlbertDude:
My attempts to set a prop value with a script file in /magisk/.core/post-fs-data.d were unsuccessful.

I ended up using the MagiskHide Props Config module which worked without any problems.

This on a Moto Z Play running Oreo 8.0 and Magisk 16.0
[Magisk] jaager:
I'm running LineageOS 15.1 and Magisk 17.1 with my new Redmi Note 5. I tried to change HAL3 but I didn't work.

I created a file under "/sbin/.core/img/.core/post-fs-data.d" with the following entry:

#!/system/bin/sh
resetprop persist.camera.HAL3.enabled 1

I checked the settings with a terminal and getprop, and persist.camera.HAL3.enabled ist set to 1 there. Unfortunately my GCAM is still not working. After that I installed the App Camera2 probe and Level_3 support is not listed there. How could that be with getprop seeing the value?

After that I tried to set the value with MagiskHide Props Config module but still the same issue. Can someone help me?
[Magisk] jaager:
I need to put the setting "persist.camera.HAL3.enabled 1" under "/vendor/build.prop", it's working only there. Very strange.
[Magisk] LeMoise:
There is an app on the Google Play Store called BuildProp Editor. It lets you easily back up, restore and configure your build.prop. I've used it in the past to emulate different phones.
[Magisk] tag68:
How does it prevent the system partition being marked as changed, if build.prop really gets modified? (avoiding this is the point of this thread)
[Magisk] Didgeridoohan:
It doesn't. Editing prop values systemlessly means you'll have to use the Magisk resetprop tool somehow. Either with a boot script (relatively simple), a Magisk module (might be a bit overkill), or use one of the modules already available that do what you're looking for. If there aren't any module available that sets the props you want, the MagiskHide Props Config module (shameless advertising :D) can set the prop for you.

I created the custom prop function in that module to make it easy for the average user to change prop values systemlessly. Unfortunately it's been kind of overlooked with the popularity of other functions of the module (changing the build fingerprint to pass the ctsProfile check, which in itself is just a systemlessly changing of a prop value)...

As it seems from [MENTION=8219796]jaager[/MENTION]'s report though, doing it systemlessly might not always be enough...
[Magisk] abuttino:
I'm using a Pixel 2.. It appears that all the magisk directories are gone. Where would I edit build.props now?
[Magisk] exocetdj:
im in the process of porting my rom over to the MNT extended template.

I have got everthing over and working but want to change the ro.build.display.id on the build prop

i have read that we need to add a file in .core/img/.core/service.d or post-fs-data.d

how can we get this to show when the module is installed?
[Magisk] Didgeridoohan:
Your info is out of date. The paths you want are:

/data/adb/post-fs-data.d

/data/adb/service.d

If you're not using a module that is, since then you'd use the post-fd-data.sh and service.sh files in the module. But if you're using a module you should be using the system.prop file to make prop changes anyway...
[Magisk] exocetdj:
Actually the first way worked lol! Although if it's dated I'll stick to the new path under data/adb, I can see these folders there.

So yes the changes I am making are via a module. I tried adding a system.prop with

ro.build.display.id=420rom-MAGISK

In the common folder but that didn't make any changes and I'm unsure what else I need to change in the module to call this from the system.prop.
[Magisk] Didgeridoohan:
The paths you used are old and current Magisk releases have them symlinked (for backwards compatibility), but they will be dropped in the next release.

The system.prop file needs to be in the root of the module directory. Take a look in the Magisk docs for details on how modules work:

https://topjohnwu.github.io/Magisk/guides.html
[Magisk] exocetdj:
Ok that's a bit clearer, apologies, having ADHD means that anything that isn't clear, leads to massive overthinking and going on random tangents with working :laugh:

I can see that the file I placed is in that newer folder too so that makes sense

So looking at that guide, the changes in system.prop are loaded by resetprop as system values.

I came across some files, resetprop.cpp and a couple of other .cpp files which iv stored in my working folder but it lacked instruction on use for these.
[Magisk] wangdaning:
It is easiest to just start with a fresh template and make a module. The template does most the work for a prop change, you just have to add the values you want and it will work.
[Magisk] Didgeridoohan:
Yes, Magisk will run resetprop during boot an load the system.prop file.

The .cpp files are part of the code and used when building the tools. The actual tool is an applet of the Magisk binary, although I believe you can build the resetprop tool separately (outside my skillset).
[Magisk] exocetdj:
Excellent so really it's as simple as placing that system.prop on the root of the module zip with whatever prop edits and magisk does the rest!?

I'll leave those cpp files if I don't need them as that will create confusion lol.
[Magisk] Didgeridoohan:
Affirmative on both.
[Magisk] exocetdj:
Respect to you mate

Thank you!?

---------- Post added at 10:40 AM ---------- Previous post was at 10:27 AM ----------

I butchered my first zip template with my overthinking.

I'll start again, this time with system.prop on root of module zip with prop tweaks in
[Magisk] wangdaning:
You literally just have to add what you want to the /common/system.prop file and set the tag in install.sh for propfile=true. Re-read the documentation, a simple file change is easy.
[Magisk] exocetdj:
Apparently I simply need to add system.prop to root of zip (see didgeridoohans post above)

I forgot to add, I'm using mnt extended template and install.sh is a blank document in /common

From what I have gathered with my convo earlier, resetprop (presumably part of magisk) will load the props from system.prop on the root of the module zip.

As this makes sense and to avoid confusion I will try this process and return to yours if no success

Furthermore a couple of places are saying not to bother using install.sh due to resetprop
[Magisk] Didgeridoohan:
To be fair, what [MENTION=4850735]wangdaning[/MENTION] is talking about is how the module template used to work. The new module format is explained in the docs I linked earlier (and in the MMT-Ex template wiki, but in this instance, with system.prop, I'm fairly sure they work the same).
[Magisk] exocetdj:
My main issue is tying the most up to date information together. Google gives a mish-mash of current and old.

wangdanings information made sense (but I'd have to populate that install.sh) but I cant focus on that til trying this out at least first lol.

The quirks of neurodivergence! ?
[Magisk] wangdaning:
I was trying to give the simplest way. You can make it more complicated of course :D

My last module was built a month or so ago and I think that is how the template from the repo worked/works.
[Magisk] exocetdj:
I understood your method though so thanks as it's valuable knowledge ?
[Magisk] exocetdj:
BOOM! AND ITS IN!lol

Thanks for your help and patience my friend!
[Magisk] wmhaganjr1013:
any help with getting (net.terhering.nonprovisioning=true ) to persist i keep loosing it for some reason

pixel 2 xl android 10 cricket wireless
[Magisk] Didgeridoohan:
It would help knowing how you set it...

If you're just using the resetprop command, it will indeed reset to the original value when you reboot.

Otherwise it should stick (if you use a boot script or a Magisk module).
[Magisk] wmhaganjr1013:
cant seem to get working at all now used magisk module

---------- Post added at 08:23 AM ---------- Previous post was at 08:21 AM ----------

went in and deleted it and now i cant get it to work at all

how do i make this persist thru reboot please I am somewhat noobish sorry

---------- Post added at 08:45 AM ---------- Previous post was at 08:23 AM ----------

can i do this

#!/system/bin/sh

persist.net.tethering.nonprovisioning=true

or

#!/system/bin/sh

persist net.tethering.nonprovisioning=true
[Magisk] Didgeridoohan:
What module did you use?

And is that supposed to be a boot script? If so you need to also add the resetprop command. Example:

If I want to change my screen density to 496 (the prop is ro.sf.lcd_density) with a boot script I would add this to a file in service.d (or post-fs-data.d if the first one doesn't work):

resetprop ro.sf.lcd_density 496

The file needs execution permission, but after setting all this up the prop will be changed at every boot.
[Magisk] wmhaganjr1013:
i am using your module Sir.

A tutorial on how to do custom props on your module is what i was looking for last night on how to add

net.tethering.nonprovisioning=true

i dont know what i did wrong but now i cant get it to work at all as soon as i get signal (lte) i get message and hotspot shuts off
[Magisk] Didgeridoohan:
On the current version of the module (v5.3.1) you would enter/type:

props

5

n

net.tethering.nonprovisioning

true

y

y

I can't help with the actual tethering though... Never played with that stuff.
[Magisk] wmhaganjr1013:
Thanks A lot
[Magisk] wmhaganjr1013:
Android 11 (R)

Are you going to update Your Module to Android 11 for pixel devices

I Sir have pixel 2 Xl was Trying Android 11 beta 3 but everyday driver i use a modified Factory 10 Rom

if beer fund needs help i may be able to assist come payday
[Magisk] Didgeridoohan:
What is it that doesn't work on 11 (I don't have any 11 devices, so if there's something that isn't working it would be great to know)?

If you mean the SafetyNet CTS check, it's no use updating the fingerprint just yet. If it doesn't work now, it's not gonna work until Google certifies the build.
[Magisk] wmhaganjr1013:
well after playing with your Module!!! Between 2 pixel 2 xl devices 1 on 10 and second on 11 beta 3 i was using Solid Explorer and went into files and added fingerprint info manually and wifi calling props, and tethering prop. everything is working. Thanks for Your FAST Answers.

Sometimes it just takes playing with things to understand them !!!! (I mean my Dumd azz!!!) LOL
[XV6700, PPC-6700 General] George Burnette:
My verizon 6700 usb plug broke on my phone and I can not get wm5 back on my phone. I read how to upgrade using the mini-sd card to flash to wm6. I need to know how to do this to downgrade from wm6 to wm5.
[Samsung Galaxy S7 Edge Questions and Answers] Rsroms:
Hello XDA,

I bought a second S7 edge Exynos Internation version and it it died (completely un responsive to key combinations, charging, led etc) all of sudden in the 2nd week of purchase. I sent the device to Samsung and it came back after 4 weeks with new screen. Whilst in the service centre i was making sure that it is working correctly, the pixels jittered up and halted, and it was dead again. Gave it back to them. Now they haven't given me any technical details on the issue and said that they will no longer fixed it although i have a golden warranty.

1st question is what can be possibly wrong with the device.

2nd: How can i challenege Samsung as i have tweeted about it on social media but no response whatsoever and yes they are is no consumer protection or Bureau where I am right now.

Any thoughts?
[Samsung Galaxy S7 Edge Questions and Answers] Rsroms:
Any one faced similar issue?
[Android Software Development] dc13:
Hey guys so last time I used it a few months ago this was how I got Samsung Gear VR working on my LG V20 rom. For those DEVs that would like to add this feature I thought we could all work together to get this on every device that is running 1440p screen just for quality reasons.

This is for devs only not a flash able zip.

Extract the contents and just copy and paste the info in the build prop.
[Android Software Development] dc13:
Change Log

Version 1 - What has worked as of 4/4/17 on the LG V20 Ti-X Rom
[Android Software Development] dc13:
Downloads

Version 4/10/2017

Mega NZ - http://bit.ly/2nZ9f9S
[Android Software Development] dc13:
Colabs with other devs
[Android Software Development] dc13:
colab with other devs 2
[Android Software Development] Miustone:
Possible to slim it down (Apps)? To include 174Mb in the System is a bit much for that few Users who'd own a Gear VR. Maybe I'll be better if You provide it as flashable Zip. If You need help with that i could be Your Man!

BR and cool stuff btw!

De-odexing could be also a good Step besides pulling it from the System Image instead of dumping it from a running System. But just a suggestion....
[Android Software Development] dc13:
Im about to compress those apps to see how much i can save but i need to finish installing a new os. If you want to make a zipable you can ill post it up and can givw u access to the google drive.
[Android Software Development] kingdruid:
I know this is probably a stupid question, but I'll ask anyway:

Where do you copy the contents of the app-private folder

Are there any other instructions? I remember I had to get this to work on a rooted samsung and I thought there was suppose to be some service running for the gear vr software to kick off when the device is connected.
[Android Software Development] mweinbach:
The /system/priv-app/ folder
[Android Software Development] Miustone:
mariuskopp517@gmail.com

I will make a lovely flashable AROMA based ZIP this Weekend. I can also improve the Size a bit by using my optimized Compression methods. Think the Size isn't that important as standalone ZIP, but some Users have slow connections and bad Data Plans...

I don't own the Gear VR but things like that have to be supported! It's a step in the right direction (Android shouldn't be used to include OEM exclusive Features dear Samsung! Share them!)

BR :)
[Android Software Development] kingdruid:
So I understand you copy it to app-private in data, but that doesnt give you the software. Does anyone. Have a zip with the required apks needed to actually launch the vr setup wizard?
[Android Software Development] dc13:
200MB is not that much gain when most roms will have 500MB+ removed and the system portion would be un changed so free space would be sitting there to be taken up.
[Android Software Development] dc13:
if you copy this into your rom flash it you will have access to samsung gear vr on your phone.
[Android Software Development] kingdruid:
Oh so this has to be done before you even flash your phone, you can't add Gear VR functionality after your phone has already been flashed. Sorry I misunderstood.

It would be cool if this was a separate package that could be added to an existing phone with root access.
[Android Software Development] dc13:
My way was just how to add ot to a none flashed rom if you throw these files in your system clear cache is should work also if you set the permissions correct
[Android Software Development] kingdruid:
Would you still copy it to app-private in that situation? I tried that and it wiped the folders from the app-private, but did not install any of the applications.

Nougat 7.0 lg v20 sprint. Maybe I am better off installing your rom which will just have it working???