[Magisk] Setialpha:
20.4.20181230 "Constitution"

Hi all,

right before the new year, version 20.4 hits a Mirror (Universe) near you. Codename for this release is "Constitution".

As we all (hah!) know the iconic grande Damé of Sciene Fiction, the NCC-1701 U.S.S. Enterprise, is a Constitution-class Vessel and to celebrate the arrival of my "Discoprise" just in time before Christmas (the Enterprise has a cameo in Star Trek: Discovery and they slightly modified the original design to be more in shape with the Disco-Verse, thus Discoprise), I've choosen this codename.

Unpopular opinion: I like the new design as much as the old (especially the NX-Type nacelle grills). :P Enough Trek-talk.

What's new?

Thanks to [MENTION=5627087]ale5000[/MENTION] the Patcher can now detect whether the ROM has native sigspoof support and refuses patching in that case

likewise for the addon.d, in case a custom ROM gains native sigspoof with an OTA-Update.

LineageOS for microG since December updates refuses sigspoof to work when the permission is not defined in privapp-permissions, this is now the case (on all ROMs with native sigspoof support)

The SysTest package now checks whether ROM has native sigspoof support, other (minor) changes

Some Stock ROMs have a Setup Wizard that's incompatible with microG. In Magisk mode it'll be auto-disabled, for System Mode you need to do this manually, if required (see the Issues section of the documentation).

if you don't know what's that about: ignore this.

To aid Multi-ROM users the Patcher now appends the ROM name/build id to the name of the services.jar backup

The Uninstaller is not 100 % in shape for this change, will be fixed with the next release

Updated and improved the Issues section of the documentation and (hopefully) make the ChangeLog easier to understand for end-users.

Other changes, usual updates, updated and improved the first post here on XDA

Full ChangeLog

## 20.4.20181230 "Constitution"

### Notes

* Starting with build 0.2.6.14799-dirty-134 the custom microG build of NanoDroid will show an icon
* in the app launcher (any Android version)
* in the System Settings (on Android 6 or newer)
* in the App overview (Settings > App > microG Services Core (on Android 7 or newer))

### Bug Fixes

* SetupWizard
* fix selection for unified Nlp backends not properly created

### General Changes

* Installer
* if the ROM has native signature spoofing support include that permission in the default permission files
* solves incompatibility with LineageOS for microG @Vavun
* function to detect whether ROM is pre-patched [MENTION=5627087]ale5000[/MENTION]
* applies to: Full, microG packages
* if the ROM includes a SetupWizard (mostly on stock), properly disable it (in Magisk Mode)
* solves incompatibility with stock ROM SetupWizard and microg @DoR3M3
* for System Mode installation, check the Issues section of the README on how to solve this
* applies to: Full, microG packages
* add ConfigUpdater to GApps removal list
* applies to: Full, microG packages
* improved version of the `external_sd` init script @Vavun
* applies to: Full package
* when detecting system properties also look if /vendor/build.prop exists
* applies to: all packages
* support both /data/adb/magisk and /data/magisk
* applies to: all packages
* remove old code regarding Magisk
* applies to: all packages

* addon.d
* sync GApps removal list with Installer
* applies to: Full, microG packages

* Patcher
* when detecting system properties also look if /vendor/build.prop exists
* support both /data/adb/magisk and /data/magisk
* remove old code regarding Magisk
* when creating a backup of `services.jar` append `ro.build.flavor` and `ro.build.id`
* if the ROM has native signature spoofing support don't do anything
* function to detect whether ROM is pre-patched [MENTION=5627087]ale5000[/MENTION]
* re-add UnifiedNlp patch by Tom Vincent

* Patcher addon.d
* if the ROM has native signature spoofing support don't do anything
* function to detect whether ROM is pre-patched [MENTION=5627087]ale5000[/MENTION]

* SysTest
* test ROM for native signature spoofing support
* function to detect whether ROM is pre-patched [MENTION=5627087]ale5000[/MENTION]
* when detecting system properties also look if /vendor/build.prop exists
* support both /data/adb/magisk and /data/magisk
* use busybox for tests

* Uninstaller
* when restoring a backup of `services.jar` look for new-style named backup

* Scripts
* improve check whether Magisk is installed or not
* applies to: nanodroid-font, nanodroid-prop

### Updates

* automatic
* Simple Calendar Pro (6.1.2)
* Simple Gallery Pro (6.1.3)
* Bromite WebView (71.0.3578.110)
* Amaze (3.3.2)
* Orbot (16.0.5-RC-2-tor-0.3.4.9)
* F-Droid (1.5)
* Substratum (1015)
* nlpBackend Déjà Vu (1.1.10)
* QKSMS (3.6.0)

* manual
* Play Store (12.9.12)
* microG GmsCore (0.2.6.14799-dirty-145)
* Open Launcher (0.6.1-nightly-181023)

Download links

Download from Nanolx, AFH will follow later.

Bug reporting

In case of errors, please provide

/data/adb/MODID_log_INSTALLDATE

/data/adb/MODID_twrp_INSTALLDATE

SysTest package logfile

logcat (if applicable)