yashsingh1/xdaforums huggingface dataset:
[Magisk] Trademark97:
I think I've found the problem, when going through the updater-binary file in the Overlay directory. In the function magisk_install_setup, the function request_size_check is called, but it is not defined inside the file. So, because the function does not exist, there is no valid size data to parse, and therefore the magisk.img file stays at its default size (64MiB). I discovered this by searching how to resize the magisk.img, finding the update-binary for this mod: https://xdaforums.com/apps/magisk/flashable-zip-magisk-img-resizer-t3593207

and going through the code for its updater-binary file. There I discovered the existence of the request_size_check function, saw that it was used to determine the amount of space required in the script for magisk.img, and decided to see if a similar resize functionality was used in your updater-binary, and it is. If you do a Ctrl-F for the request_size_check function inside your script, it only is referenced once (at line 244), but isn't actually declared. I am unsure if this is the whole cause of the problem, but I am wondering if this could be a significant portion of the issue. I don't know the exact parameters necessary within the function for the script to function properly (allocate the correct amount of space) so I cannot patch this on my end and try to run the fix myself. But I figured rather than just ask for a fix, I could maybe investigate myself and try to help contribute to the solution. I hope that this information proves useful.

EDIT: I made a mistake. I forgotten that you'd moved to Magisk's native functions for a lot of stuff, but I hadn't figured that it meant cutting out your function to resize completely; I merely thought you had altered the function to make use of Magisk methods. Mea culpa. But still, I wondering if Magisk's functionality is still not working right with the script and causing errors. I'll try to duplicate the pull I have into another directory, modify the script to use your original size functions, and see if the reverted change makes the installer work successfully.

EDIT-2: I'm not sure now that I feel comfortable trying to fix this on my own; the alterations to the file are complex and numerable enough that I feel that trying to patch it back together without knowing exactly what you did to change it and how it might work with the new Magisk versions might prove rather dangerous.
[Magisk] HaoZeke:
Has anyone gotten assistant working with this? O.o my Google app won't recognize my accounts.

I used the patcher along with the fdroid and microg packages...
[Magisk] Oswald Boelcke:
Did you grant the Google app permissions for contacts?
[Magisk] HaoZeke:
Thanks, the got it to recognize my account... But the ok Google detection is grayed out and assistant doesn't work...
[Magisk] Oswald Boelcke:
I apologise. I'm using microG because I didn't want to have any Google stuff on my device - and I don't have, i.e. I'm not familiar with these settings at all or if it's implemented at all. Here is the microG implementation status.

Regarding the contacts permissions, I knew it is required 'cause I read it in this thread.
[Magisk] Setialpha:
It should work now, since you already build the package yourself, do a usual 'git pull' and use 'build-package' to create a new package. Report back if it worked now (I'm 99% sure that it does).

Dunno if this was a sarcastic comment or not.

1) They need to be

Free (as in FOSS)

(possibly) more secure or privacy-aware than the standard counter-parts (Twidere, Face Slim)

(possibly) extending security/privacy possibilities (KeepassDroid, OpenKeyChain, OpenVPN)

more feature rich than the standard stuff (K9-Mail, Lightning)

I know the list of included applications is arguable.

2) Yes.
[Magisk] Trademark97:
So, I pulled the latest commits, and rebaked the NanoMod packages. As well as my ROM (AospExtended) and Magisk v13.3, I pushed the NanoMod and SetupWizard packages, and attempted installation with two configurations: using SetupWizard for configuration of the setup process, and NanoMod full zip by itself (for "stock" installation of NanoMod). The same thing happened in both instances: the same problem as before (and I have a new recovery.log to demonstrate). After I ran the commands you suggested to examine the size of magisk.img and the space used inside of /data, I found that the same thing was still happening: magisk.img still is sized to 63M. Here is the output from before and after each flash attempt:

Before:

du -h /data/magisk.img

5.1 /data/magisk.img

df -h | grep /data

10.9G 939.3M 9.9G 8% /data

After (SetupWizard):

du -h /data/magisk.img

63M /data/magisk.img

df -h | grep /data

/dev/block/mmcblk0p48 11G 997M 10G 9% /data

After ("stock" NanoMod install):

du -h /data/magisk.img

63M /data/magisk.img

df -h /data/magisk.img

/dev/block/mmcblk0p48 11G 997M 10G 9% /data

Perhaps my device or my ROM (AospExtended) do not function quite to standard and this could interfere with the magisk.img resize process?

PS: Attached is the recovery.log for the latest install attempt
[Magisk] Setialpha:
It has nothing to do with the ROM, if anything with TWRP. But: I've found another message in the log that might be indicating what's going wrong (

it looks like the command

unzip -o NANOMOD_ZIP -d TEMPORARY_DIRECTORY

fails and instead it does

unzip -o NANOMOD_ZIP

so I'm doing this instead now:

cd TEMPORARY_DIRECTORY
unzip -o NANOMOD_ZIP

)

Please try again with the latest commit. If it's not fixed now, I'm puzzled.
[Magisk] 1plus:
FOSS I support but feature-rich is arguable. E.g. K-9 and to my knowledge any of the FOSS email apps cannot do activesync which normal lineageOS Email/Exchange can do.

As for the browser -- Lightning is kinda OK but nothing currently compares to CAF browsers. I think CAF browser is the best one around amongst all browsers on all mobile platforms. Besides Lightning and many other browsers use built-in webview, not engine of their own.

However I understand building CAF is perhaps more complicated compared to simple browsers.
[Magisk] Trademark97:
OK, now the full zip almost immediately fails, saying it failed to resize magisk.img . As always, recovery.log is attached. I am also stumped as to what the issue could be.
[Magisk] Setialpha:
Good (well not for you, but me): because it's an issue with Magisk's resize function not NanoMod.

It fails doing

$MAGISKBIN/magisk --resizeimg $IMG $newSizeM || error "!! failed to resize magisk.img"

What happens when you try to call the command manually from TWRP:

/data/magisk/magisk --resizeimg /data/magisk.img 265

?
[Magisk] Trademark97:
In TWRP, going to Advanced > Terminal, here is the results of the command:

~ # /data/magisk/magisk --resizeimg /data/magisk.img 265
sh: /data/magisk/magisk: not found
[Magisk] Setialpha:
Ah yes, magisk requires /system to be mounted. Try this:

source /data/magisk/util_functions.sh
recovery_actions
mount /system
/data/magisk/magisk --resizeimg /data/magisk.img 265
recovery_cleanup
[Magisk] Trademark97:
When I get to line 3, the terminal spits out "sh: mount: not found". I notice that when Magisk cleans up after its install, it "Unmounts partitions". I tried to re-run lines 1 and 2 again, to see if maybe it would work the second time around, but it didn't, and when I tried to wipe everything to start over, it errored out wiping /sdcard/ and I had to reboot to successfully wipe everything.

EDIT: I also tried mounting /system manually, from TWRP's Mount menu, and the installation still failed to complete.
[Magisk] Setialpha:
mount /system before recovery_actions then, that should do it, so that we finally get a meaningful error message:

source /data/magisk/util_functions.sh
mount /system
recovery_actions
/data/magisk/magisk --resizeimg /data/magisk.img 265
recovery_cleanup
[Magisk] Trademark97:
OK, when I follow those instructions exactly, there is no error message.
[Magisk] Setialpha:
du -h /data/magisk.img
[Magisk] Trademark97:
Before recovery_cleanup:

5.0M /data/magisk.img

After recovery_cleanup:

sh: du: not found
[Magisk] Setialpha:
So it is a magisk issue, I assume you're using the latest version (13.3)? I strongly suggest opening an issue over at Magisk github repo.

I may add the old resize functions back as fallback for now, until the ussue is fixed in Magisk. Not today anymore, though.
[Magisk] Trademark97:
Thank you for your help. I'm glad that the issue seems to be a little closer at least, to being solved completely.
[Magisk] AlreadyFree:
Well I installed NanoMod as directly into the system and now the swipe libraries are working. Weren't working as a Magisk Module though.
[Magisk] Setialpha:
OK. Let's see what happens with manual resize:

resize2fs -f /data/magisk.img 265M
e2fsck -yf /data/magisk.img

Edit: I've added the fallback functions with the latest git commit, btw.

I'll have a look at this.

Edit: fixed, thanks for pointing that out.
[Magisk] Trademark97:
OK, now the installation succeeds completely. The phone has done its first boot after the new flash, and so far, everything looks to be working smoothly. Thank you for all the help you have given and for continually working so hard to make sure everything works just right.
[Magisk] fhLan:
[MENTION=7408621]noc.jfcbs[/MENTION] how do I make calender to work? it always prompt me to sign in but there's nothing in calendar to display list. thanks in advance

edit: solved sorry for interrupting
[Magisk] Oswald Boelcke:
Did you grant calendar all permissions?

Is a sync addon installed either directly from Nanomod or a separate one by ale5000 or shadow53?

Maybe this post is of a bit of help? (Hihi, just used the powerful xda search engine myself to find this post...;))

Here, Shadow53's adapters are availbale including installation instructions.

Please advise unless this helped.
[Magisk] fhLan:
not so powerful here in app
[Magisk] marcdw:
Little side note on that. In Tapatalk I was trying to search for an old post so I could respond to it with some new-found info. I was searching for carbon rom or carbonrom. Kept coming up nil. Then I tried CarbonROM and got results.

Seems like it's case sensitive. Not sure really but that's how it turned out.

LG G3 D851, OctOS Nougat ROM, Solid Kernel V2.51, MultiROM, Tapatalk 4.9.5
[Magisk] rohitdave:
Hi

I have installed micro G with Magisk 12 on the RR rom Nougat June 14 ver.

When I use ES file explorer, I am unable to select R / W to change the value of some files. What happens is that the /system reverts back to RO only, even after selecting RW

ES file explorer root option is selected.

It seems this issue came up after installing MicroG not sure.

Can some one please help a noob plz ?
[Magisk] Oswald Boelcke:
Does this also happen with other root explorer e.g. MiXplorer?
[Magisk] rohitdave:
Hi

What a wonderful light weight app.

It works.

Thanks a lot buddy.
[Magisk] ainurrofiq:
Does this mod have telegram support group?
[Magisk] American_Jesus:
Also having the same issue using adb

$ adb root
$ adb remount

the system stays in R/O instead of being remounted as R/W
[Magisk] Oswald Boelcke:
Same issue to what?

And what's the rationality behind to assume that's Nanomod related?

Just asking to get an idea, in which way to start thinking.
[Magisk] Setialpha:
It's because of Magisk magic mount. Using the mount program does not work, you need the Mount() syscall, as topjohnwu clearified several months ago in Magisk main thread.

Obviously that's not the case when not using any module that uses magic mount feature.

Issue

mount

on your device and you'll see myriads of additional mounts by Magisk.

Also what's the point in mounting /system r/w when using Magisk anyway?
[Magisk] piet8stevens:
Running 12.0 on magisk 13.3 and it is working really well.

2 small points:

a. fstab error still there. Not really an issue as everything works.

b. Not sure this is related to nanomod: adaway works for a while and then stops working. Need to reboot to get it to work again. It gets disabled, and when I try to re-enable it (download files and apply add blocking), I get an error "Copy failed. Copying of hosts file failed! Please read help for more information.". It used to be that adaway worked much longer without having to reboot. What is the experience of other nanomod users: do you have to reboot adaway after hosts file update?
[Magisk] gimpy1:
For ad blocking, I use MOAB and have for a few years. I seldom use WiFi, so, not sure that it works for it, but, I assume it does. It is an XDA thread and can be searched for (can we use the word Google on here?). He just recently changed from a zip download to an apk install. It can not be beat, IMO.
[Magisk] Setialpha:
The fstab error is practically harmless.

I don't have that issue. Do you have systemless hosts enabled in Magisk Manager? Try changing the setting to the opposite.
[Magisk] piet8stevens:
Systemless hosts was disabled. I enabled it, but still same.
[Magisk] Didgeridoohan:
You have to reboot after enabling Systemless hosts. Did you do that?
[Magisk] piet8stevens:
[MENTION=4667597]Didgeridoohan[/MENTION] and [MENTION=4187311]Setialpha[/MENTION]: Thank you. I had not rebooted when I wrote my previous post. I was just rebooting when I saw your post. Now it works. The real question is whether it will stick.
[Magisk] fhLan:
is there any table of magisk module vs dydtem mode?
[Magisk] Setialpha:
What for? There's only one feature missing in System Mode (pseudo debloat), and that's mentioned in the docs (and setup wizard).
[Magisk] gimpy1:
I think I am starting to get the hang of the somewhat simpler things on here. But, there is always something, it seems.

Micro g is all checked and green. Magisk is green as well and passes the safety check. But f droid apps are not downloading and installing for me, although they have in the past (I do have the Yalp store installed). Any suggestions as to why? I am on Verizon's droid turbo, xt1254, currently using Neporood's AOKP rom from a clean install. I also use bhb's RR rom.

I also have my contacts and calendar from Google installed. I currently have the G play store disabled in my settings. Can I download my apps, especially the paid ones, from the G play store and use them without being googleized when using them? (Paid apps such as root explorer, naked browser, Nova launcher, etc, no games).

Thx
[Magisk] Shadow53:
The Play Store will need to be enabled when you are downloading apps as well as while running any apps that use runtime license checks. If you use Yalp Store and have Play Store disabled, why have the Play Store installed at all?

As for F-Droid, the only reason apps shouldn't download is if F-Droid cannot connect to the servers to download it, and the reasons a downloaded app wouldn't install is if the app was previously installed with a different signature (F-Droid apps are signed with F-Droid's keys while the Play Store apps are signed with the developer's keys). Or you have "Unknown sources" disabled.
[Magisk] gimpy1:
Thx, Shadow53. I don't think I intentionally installed the play store unless it came installed with my rom? I disabled it in settings because it would not let me uninstall it. Is there another way to uninstall it? I just checked my unknown sources and it was already checked to allow unknown sources. And I wish to thank you because I did use your links for installing my calendar and contacts from Google.
[Magisk] Shadow53:
The play store can't be preinstalled on a ROM, so it's not that. It may have been installed by NanoMod, depending on how you configured it. If your ROM says that the Play Store is installed, it must have been by NanoMod. It doesn't let you uninstall it because it's installed as a system app. You can delete its files from /system/priv-app/Phonesky (if you used system mode) and /data/data/com.android.vending-1/ (regardless of install method) using the TWRP file manager and reboot. Or just clean flash your ROM.

And you're welcome for the sync adapters! Quite a few people have requested them, so I'm glad they're able to work for you.
[Magisk] gimpy1:
I finally got f droid working:). The other day, I was playing around with tor and orbot. Tor was checked in the f droid settings. Unticked it and the app started working again.

Other than looking (in twrp and my file manager), I haven't yet done any of your other two suggestions. Do I delete the phone sky apk in my file manager and the "6 folders" in the other data/data line? Or does having the play store disabled accomplish the same thing?

Thx.
[Magisk] ale5000:
If I'm not wrong if you don't have any app installed with name "com.android.vending", some apps will complain about missing play services.
[Magisk] Setialpha:
When installung NanoMod with Yalp Store, Fake Store gets installed, too, which registers as com.androif.vending.
[Magisk] gimpy1:
So, we can delete the com. android. vending from data/data?
[Magisk] Setialpha:
If you disable/remove Fake Store SafetyNet won't attest and anything else that expects Play Store to exist, won't work either.

Same applies if it would be Play Store, of course.
[Magisk] DEVILOPS 007:
I've got a question about app drain. I'd rather not uninstall all my apps or clean flash but would uninstalling them all then restoring with Titanium backup work the same and fix the battery issues stated? Thanks
[Magisk] demonoidmaster:
You can backup your apks sure, but you'll have to reconfigure every single app after if you do that, unless TitaniumBackup also backups everything in /data/data per app
[Magisk] Setialpha:
For me Titanium full backup and restore not always solved that issue.

What should work, though, is only data restore using Titanium. So uninstall and re-install apps manually, then restore data using Titanium.
[Magisk] AluminumTank:
Hello, I am having trouble getting UnifiedNlp to work, as some other users in this thread have had as well. How do I go about fixing/diagnosing/bug reporting this issue?
[Magisk] gimpy1:
Don't know if this will help, but, the first thing I install is the droid guard apk.
[Magisk] Shadow53:
First step would be to tell us *how* it doesn't work. What's unchecked in the checklist? Or what is telling you that it doesn't work? Have you enabled any location backends?
[Magisk] Alamien:
Amazing stuff, working nicely with my setup (vertex OS), just need to manually flash the contacts sync and it's working as it should, the idle drain is the best I've ever had.

One question, if there's an update to the ROM, will the nanomod stuff stick? I've vaguely read that we need to flash a patcher, is it still the case? Sorry for newb question.
[Magisk] Ophidian_DarkCore:
bottom check is unchecked is for me. but two backends are configged..
[Magisk] DJ aliasz3d:
You need to enable location services in your phones settings for it to be checked
[Magisk] Ophidian_DarkCore:
hey bud, its checled. considering i use waze everyday
[Magisk] DJ aliasz3d:
Is it mine gets checked when I enable the battery saving location option.

Have you got a screenshot?
[Magisk] ShapeShifter499:
Is there a reason why this hasn't been added to the Magisk list of modules? Would be nice to get notifications and downloads for NanoMod updates through the Magisk Manger.
[Magisk] Shadow53:
Okay, to me that looks like that microG/UnifiedNlp has not been installed as a system app, which is necessary when using a patched Nougat system. Not being a system app means not binding the service and thus not being able to find the location.

I'm assuming you installed it using NanoMod, in which case I would file a bug report with [MENTION=4187311]Setialpha[/MENTION], including whether you installed through Magisk or system mode, what ROM, any logs you have, and any other information requested or that you consider pertinent.
[Magisk] DJ aliasz3d:
OK yes it's not the location I was speaking of but the one above.
[Magisk] demonoidmaster:
Magisk has a survival script, it'll back itself up before you do your rom zip flash (rom flash: be it manually or automatically) and then reconstruct itself afterwards, modules included

However if stuff doesn't seem right you can always just reflash the nanomod module, though shouldn't be an issue

PS: also don't worry about kernels, if you were to let's say flash a rom update (yknow, dirty flash) and then Magisk kicks in rebuilding itself, you can then flash a custom kernel (elementalx works fine, dunno if other kernels need to be flashed before Magisk if that's the case then reflash Magisk afterwards)and then your other zips, clear cache, reboot
[Magisk] Blackcrown:
Hi. A few questions while browsing the nice docs for nanomod:

1. On the Alter Installation page I noticed that that the defaults for full package and microG package are different: Full package uses nanomod_overlay, microG package does not (default is nanomod_overlay=0 according to the docs). Why is it handling things different?

2. When I installed nanomod-microG in version 11, I made a config file with only one option nanomod_play=2. So should I add nanomod-overlay=1 to my config prior to flashing version 12?

3. Will flashing version 12 of nanomod-microG invoke the new aroma installer menu or will it use my old config file?

4. What's the best way to update to version 12 - just flashing the updated package or use the uninstaller package first to get rid of 11 before flashing version 12?
[Magisk] Setialpha:
1) because only the full module has replacements for them. The feature is thus delivered with microG package, but inactive by default.

2) the missing entries have then been added to your config, so just adjust it.

3) No. The Setup Wizard is separate.

4) Just update.
[Magisk] HaoZeke:
Hi... Does anyone have a persistent notification saying

Google Play Store

Checking for system and security updates
[Magisk] AluminumTank:
Yup, installed through NanoMod. Weird thing is, I can see that GmsCore is installed under /system/priv-app...
[Magisk] Setialpha:
May happen with microG, disable this Service usin an application like 'Disable Service' or whatever.
[Magisk] Ophidian_DarkCore:
install phonesky and droidguard helper as user app
[Magisk] J4jks:
Hey anybody facing this or me only?

Even after switching off the phone, it is not actually off,

I can see the proximity sensor glowing and phone is not showing anything with connected charger. Idk it is being charged or not.

It is happening with any ROM and any Nanomod version whichever I use.
[Magisk] Setialpha:
Nope. And without any logcat and additional information I can't say anything or look for the cause.

I'm having a similar issue on my Tablet, but it's a bug in the ROM in that case and happens with clean ROM, too.
[Magisk] sirdoha:
AWESOME WORK, bro!
[Magisk] :
[MENTION=4187311]Setialpha[/MENTION] so basically if I want to switch roms while using nanomod, after installing apps from play store I can just restore data for all of them to skip setting them up again and there will be no problems with MicroG or anything?
[Magisk] Shadow53:
The issue that comes with restoring from TitaniumBackup is that the apps don't register with microG to use GCM, so all of your apps that use that for notifications won't receive notifications like normal. Installing from the Play Store *and opening them once* is enough for some apps to register with GCM. Others require you to log in first before they register.

In other words, it depends on the app. Some you may have to completely set up manually in order to get GCM registered. At that point you can decide whether it is worth restoring the data backup for that app.
[Magisk] J4jks:
No, its not happening without mod

Tried without mod in different ROM and no problem at all
[Magisk] RobotPhone:
Are you sure about this? I thought that if you set up microg including gcm (use test app to make sure it's working) before restoring apps that they register with gcm just fine. If you restore apps before setting up microg/gcm then they don't register correctly with gcm.
[Magisk] Shadow53:
I'm plenty sure. I'm a bit of a flashaholic and every time I flash a new ROM I install microG, configure it, and then install apps. I have not had my apps re-register for GCM after a restore unless I open them or log in to them first.
[Magisk] Alamien:
Is Chromecast not supported by microg? Can't seem to connect to any of my Chromecast
[Magisk] Oswald Boelcke:
Please check the implementation status.