yashsingh1/xdaforums huggingface dataset:
[Magisk] Jman420:
hehehe, i see what you did there.

Yeah, deeper review does show that those scripts aren't installed or used. But leaving them there makes reviewing the module much harder since you have to go looking for that 1 flag which indicates they aren't used. As a developer if I see code in a script I expect that it's meant to be executed and a reviewer won't necessarily know which piece is correct (the flag disabling the script or the script itself).

The module is definitely benign, but on a quick surface review the dead code seems strange in the context of the module itself. Just a suggestion, but cleaning up that dead code would make the module easier to review and avoid having that code get executed accidentally or misinterpreted.

Even a full review would raise some concerns with me. Mainly which is correct; having the script disabled or enabled. That concern can only be addressed through a discussion like this. A full review would make me feel a bit more secure since the script isn't executed, but would make me question whether the full functionality of the module is actually in place.

[MENTION=7897801]laggardkernel[/MENTION] This is all good work, so I hope you don't take any of this the wrong way. I just happen to do development (more accurately software engineering) as a career and see this kind of stuff all over the place in enterprise software and it makes my eyes bleed every time I see it. Now that I've gotten into a cyber security role I'm even more sensitive to this stuff since they end up constituting security holes (either maliciously or accidentally, usually the latter).
[Magisk] Vuska:
Flash it from recovery, it say Error... because there is already has init.D folder ?

So i have to delete the folder first ?
[Magisk] Didgeridoohan:
If you already have init.d support you don't need this module.

And if you want proper help, where's your recovery log?
[Magisk] Magisker:
Does this module already support Magisk 13.1?
[Magisk] laggardkernel:
Not yet. I haven't migrated to v13+ and I'm still waiting for the update of the all-in-one wiki.
[Magisk] abacate123:
The template v4 is already there tho

https://github.com/topjohnwu/magisk-module-template
[Magisk] shankar_vl:
magisk 14 does not mount magisk.img. It creates a different set up. There is no magisk folder at root containing post-fs-data.d and service.d folders. If they are not there in magisk 14, where are the scripts to be placed for running at boot. Anybody could help on this.
[Magisk] Didgeridoohan:
Sounds like you've got a faulty Magisk installation. Try installing again...

If you can't get Magisk to install properly, post details and all the logs in the support thread.
[Magisk] shankar_vl:
magisk 14 was flashed as part of flashing a custom rom and has rooted phone.

As the problem was related to running scripts at boot, i thought somebody on this thread which deals with init.d would have noticed.

log files created at /cache attached.

magisk.log says 'running service.d scripts'. Where the hell this folder could be. I searched almost everywhere.
[Magisk] Didgeridoohan:
Have you set your file explorer to show hidden files and folders? The post-fs-data.d and service.d folders are found under /magisk/.core and you won't see the .core folder unless you activate this option...
[Magisk] shankar_vl:
yes, core is hidden folder. I could see it in version 13. but in the latest version 14, no folder at all. I have enabled my explorer to show hidden folders. but no trace of any folder.

btw, have you flashed latest version 14 and do you have those folders?
[Magisk] Didgeridoohan:
That's why I said there's something wrong with your installation of Magisk... They should be there, just like before.

But that's not a question for this thread, like i said before...
[Magisk] laggardkernel:
From your log file. The system image is failed to be mounted to /dev/magisk/mirror/system. Did you change your ROM these days? Since the mirror mount failed, don't install no module anymore.

I only encounter the same problem when installing Magisk into a 2nd ROM supported by Multirom. Magisk is not compatible with Multirom, at least after v9.
[Magisk] Infy_AsiX:
I need the module while already having init.d support, as a workaround to an issue where AFWall tries to write in init.d but fails. https://github.com/ukanth/afwall/issues/650

I guess an app that tries to write to the init.d folder can be prevented by Magisk's changed su setup?

If the module doesn't require init.d to not exist I found it fixes the issue. I cut my init.d out with it's two LOS scripts, installed the module and placed them back. It all seems to work with safetynet passing. The other init.d Magisk alternatives seem to be obsolete, don't install or break safetynet.

I suppose it's an extra feature the module author didn't intend but it's useful in my case. Perhaps a small change to enable the feature normally?
[Magisk] Infy_AsiX:
Upon further testing I lost safetynet I think maybe because of my removal and replacement of the init.d folder. I started a clean rom and installed the module after editing out the non-init.d folder installation requirement.

I find the scripts I place in post-fs-data.d, service.d or the Magisk init.d module link don't manage to execute on my rom, with fixed permissions too. The post-fs-data.d and service.d don't work for my manually copied scripts before this module too.

Copying to the module's magisk link, scripts show up in the /system/etc/init.d/ but still don't execute. The solution I've settled with is to copy my script's contents into the module's given placeholder file, which manages to execute fine.

Back to my initial issue of using AFWall's startup leak script. I figure at least it works for now and I won't auto-update it in case of an edit to the feature.
[Magisk] m45k:
Is this working with Magisk 16.7 / 16.x?

Or is there a better alternative out there? I just like to close the start data leck witch AFWall+
[Samsung Galaxy S7 Edge Questions and Answers] YousefMSalah:
My S7 Edge Can't Make Calls

When I Call Any One it Doesn't Even Ring

it give a Peep Sound and Close The Call

but it Recive Calls Perfectly

I put the Sim Card in the 2nd Tray it Worked without any Problem

So the problem isn't from The Sim Card

...

S7 Edge Android 7.0​
[Mate 8 General] Apad121:
Hi there

I have the official flip cover from Huawei with the window to preview the time and weather as well as the playing music...

However a flaw is that there is no option to enable notifications from being viewed directly through the window...

Of course phone calls can be picked up directly but being able to see notifications without opening the cover would be very nice....

Is there a way to make the phone show notifications through the cover? Does Nougat add this feature?

I have already enabled the option to show notifications on the lock screen but it doesn't show on the cover window...

Any Advice is appreciated... Thanks in advance :laugh:
[Mate 8 General] danterape:
Got the same. I guess this case is useless. No chance to do that for me. Nougat didnt give this in the patch.
[Mate 8 General] Apad121:
Hi there

I wonder if there are any apps that will display a notification in top of the cover... That would be useful to see....
[Droid RAZR M Themes and Apps] aggressivepixels:
Here's the Google Pixel bootanimation resized for our devices! It should work in any 540p device, too.

Preview

[IMG="Preview"]http://i.imgur.com/gd9LT5X.gif[/IMG]

I've included a flashable ZIP (which contains an addon.d script) and the standalone bootanimation in the attachments.

Original here.

Enjoy!
[Droid RAZR M Themes and Apps] kresnadetea:
great sir :D

can you make the black version?

because white is too much bright for me
[ZTE Axon 7 Questions & Answers] Nik2424:
anyone succeeded to dual boot stock and los/rr using dual patcher app?

I have set stock B19 as primary and I can't seem to figure out how to boot the dataslot Los. Everytime I try, it vibrates 5 times and reboots to twrp.

help plz :) I will you a cookie.
[Huawei P10 Questions & Answers] vicusbass:
It seems P10 does not have display oleophobic coating, super weird. I wonder how annoying is this in real life usage..
[Huawei P10 Questions & Answers] joooe:
It comes with a screen protector preinstalled.
[Huawei P10 Questions & Answers] vicusbass:
Still... I usually don't use screen protectors. Sounds stupid not to use coating
[Huawei P10 Questions & Answers] vasra:
Yes it comes with a protector, but it is a huge smudge magnet (compared to Mate 9).
[Huawei P10 Questions & Answers] CompanionBowman:
I'm glad I got to try it first in a store. It's incredibly annoying and as soon as I placed one finger on the screen smudges appeared and were there to stay. Seriously you have to see it and try it in real life, the difference between this and having the usual coating is night and day.

I don't want to use no screen protector, it's ugly and it completely defeats the purpose of having 2.5D glass. Such a shame.
[Huawei P10 Questions & Answers] vicusbass:
Horrible. I just ordered mine. I don't get it, how can a serious company skip this? And how come ONLY ONE reviewer mentioned this?
[Huawei P10 Questions & Answers] xnpu:
It's an odd choice, but it has not bothered me yet. I did remove the pre-installed screen protector because it doesn't swipe smoothly.
[Huawei P10 Questions & Answers] vicusbass:
Makes sense, why keeping a screen protector when you have Gorilla 5 and beautiful design? So you haven't notice any extra dirt on the screen because of the non-oleophobic coating?
[Huawei P10 Questions & Answers] scgf:
I had a P10 on pre-order with CPW but after watching several video reviews my eyes were drawn to the horrid screen protector and the way there are gaps all around it. Once I saw it, I couldn't stop seeing it and knew I couldn't live with it on a daily basis. Given the 2.5D glass, all screen protectors would have these gaps. Then I was getting concerned about future updates - I spend an unhealthy amount of time getting excited about updates, lol and there are no guarantees with Huawei.

My top two phone features (assuming all else is at least good) are camera and regular updates. This led me to the Google Pixel. I bought one on Monday - a beautiful black 32GB model which now sports an excellent Nillkin frosted hard protective case - also in black. It looks amazing.
[Huawei P10 Questions & Answers] pellen:
According to Huawei there is oleophobic coating on the screen, but less than usual. Apparently it's because the fingerprint sensor doesn't work well with the coating (as the fingerprint sensor is under the glass and not a separate button as on most other phones).

I'm not a screen protector fan either...so if it sucks I will probably try to apply a oleophobic coating on my own (shark proof coating or something like that)
[Huawei P10 Questions & Answers] mostling:
I should be receiving my P10 on Friday and i did order Shark Proof ahead of time just because i personally don't like screen protectors at all so i'm hoping it will do the trick.
[Huawei P10 Questions & Answers] vicusbass:
Never heard of Shark Proof until now. Is it really working?
[Huawei P10 Questions & Answers] mostling:
Didn't receive the phone today so i'll have to wait until next week to try it.
[Huawei P10 Questions & Answers] lifenight:
Does the p9 have oleophobic treatment ?
[Huawei P10 Questions & Answers] scgf:
Huawei's official response is that they couldn't apply a full coating to the P10 display because of the fingerprint sensor. On the P10 the sensor is part of the display itself rather than a separate button and the oleophobic coating wouldn't allow it to work. The P9 sensor is on the back so I would assume the lack of a coating is P10 specific.
[Huawei P10 Questions & Answers] Jannomag:
I tried 3 different liquid protectors on my old iPhone 5, But they're not that good as the companies say. All three, Kristall, Shark proof and Wowfixit, didn't work properly. A coin or a key in the same pocket while walking and this protectors will scratch.

The biggest problem with those liquid protectors is that you can't see them so you don't know if they're working or not.

I have a "like glass" protector on my P10 and its feeling good. The sensors on top and the finger print sensor are cut out precisely and there's only a small gap between the smart cover case I'm using and the protector.

I work as an electrician and I need protection for my phone because sometimes I have no time to think about the things I put in my pockets, but my i6S with case and glass looks like new after 1.5 years of using and I hope the P10 will do the same.
[Huawei P10 Questions & Answers] vicusbass:
What "like glass" protector would you recommend? I tried a few protectors back in the day and I hated how it felt when touching the screen...
[Huawei P10 Questions & Answers] Jannomag:
I have one from "dipos". It's not perfect but it's okay for 7€ for 2 protectors.

The lack of accessories is annoying. It was much easier to find a good protector for my i6S.
[Huawei P10 Questions & Answers] localbus:
Tried my pre-installed screen protector.... it was bad !!!..... feels like fifty cents cheap protector... anyone can comment if remove it will be better ? the pre-installed is not even smooth to use...

waiting for the matte protector......
[Huawei P10 Questions & Answers] paul678:
I removed the preinstalled protector as soon as I put my finger in it...the screen is quite smooth to use for me, though I have problems if water droplets land on it...other then this it feels the same way my old LG G5 did.

I recommend you to try it and check how it feels...at least until your new protector arrives
[Huawei P10 Questions & Answers] vicusbass:
Does P10 collect more dirt on the screen than other phones?
[Huawei P10 Questions & Answers] paul678:
It does collect grease more easily than a other -new- phones (new being the important word, for example it actually reacts about the same way an 8 month old G5 does ) and also some dirt marks rub off harder but you yeah you get used to it.

The phone actually feels like it has some coating...or maybe its just the glass that's high quality... because it feels way way better when compared to UMI Super (which totally lacks any form of coating and also uses a cheaper glass)
[Huawei P10 Questions & Answers] vicusbass:
Hey Paul, hello from Cluj :)

I never ever used a screen protector, I hate how they feel when touching the screen (I tried the default one on OnePlus 3 and removed it after one minute). However, this default screen protector on Huawei P10 is actually kind of decent, I am using it for 3 days already. But I'll remove it probably soon, I guess it gathers dirt even worse than the screen, isn't it?
[Huawei P10 Questions & Answers] gommers1978:
I use this screen protector with oleophobic coating:

[IMG="screenprotector"]https://www.mobilesupplies.nl/media/catalog/product/cache/1/image/700x/9df78eab33525d08d6e5fb8d27136e95/t/e/tempered-glass-volledig-scherm-huawei-p10-zwart-1.jpg[/IMG]

Is made of glass and almost not visable on the phone.
[Huawei P10 Questions & Answers] hpsauce37:
Details please?
[Huawei P10 Questions & Answers] gommers1978:
I bought it from a webshop here in Holland.

https://www.mobilesupplies.nl/tempered-glass-volledig-scherm-huawei-p10-zwart.html

On the black version of the P10 only the holes for the front camera and notification light ed. Reveal that there is an screenprotector in place. Also i think it feels like you do not have a screen protector because it is made of glass.

Installation was also very easy no bubbles or anything.
[Huawei P10 Questions & Answers] paul678:
Hello from Craiova here,

I didn't like the plastic one from my P10, I removed if after 30minutes or so..so I didn't get to check how it handles grease or dirt. Until now I'm actually content with the glass, it usually feels normal (in my usage scenarios)
[Huawei P10 Questions & Answers] szaboagoston:
I consider it a huge flaw. I always take off screen protectors, partly because they do not have the same oleophobic coating as the original screens. I found out of this issue a few days after I started using my new P10. I returned the phone because of this. I don't know what Huawei were thinking. (P.S.: the factory-applied plastic screen protector is just as prone to smudges.)
[Huawei P10 Questions & Answers] vicusbass:
I agree. I never used screen protectors and after 2 days I removed the P10 protector as well. It was getting actually more dirt than the screen.

To me, the lack of coating is not actually that bad, the phone seems to gather dirt like all phones when they are 3-4 months old :) Still, I don't understand the reasoning for this... And there is no real Huawei forum/community where you could ask questions. That's one thing I miss from OnePlus...
[Huawei P10 Questions & Answers] paul678:
Is anyone able to properly understand what Huawei CEO says about oleophobic coating?

It seems to me that he confirms early batches had no coating and new ones do, he also says something about "Huawei experience shop to provide a smear oil solution, consumers can apply" but I don't understand a word...

https://www.gizmochina.com/2017/04/20/huawei-ceo-richard-yu-speaks-huawei-p10-flash-memory-issue/
[Huawei P10 Questions & Answers] vicusbass:
Yeah, sounds like that. I really hope that's an automatic translation, I cannot believe a CEO communicates like a drunk person.

I am writing Huawei demanding explanation, I am curios. Everybody should do it :)
[Huawei P10 Questions & Answers] ch1lko:
Translation from Engadget:
[Huawei P10 Questions & Answers] vicusbass:
This is kind of bull****, if you ask Huawei official channels, they always answer "there is no oleophobic coating on P10". I have an official email. So it looks like Huawei people are really confused.
[Huawei P10 Questions & Answers] nicoX:
Official from Huawei they said that the coating was interfering with the glass technology, so they had to take this approach. Remove the cover and get premium tampered glass protector.
[Huawei P10 Questions & Answers] vicusbass:
You know, getting a 7 mm thin phone and having to add screen protectors so the screen does not get ultradirty sounds unpleasant.

I get it, they could not find a coating which works with Gorilla Glass 5. I wonder, what solution is Samsung S8 using or any other Gorilla Glass 5 phone?
[Huawei P10 Questions & Answers] fkloznica:
Lol nice response.. xiaomi mi6 has the same fp senzor and the display has a very good oleophobic coating.

Huawei's big fail this time.. a deal breaker for a lot of people. That oleophobic coating is probably 1$ per unit.
[Huawei P10 Questions & Answers] paul678:
Official Huawei support response. I don't quite understand the part they talk about the "2.5D corner complaints" but yeah seems we won't get any "apply for oleophobic coating" in Europe.

I'll reply to them later and ask some more information
[Huawei P10 Questions & Answers] nicoX:
I'm glad there is no coating, because everyone should use a hq tampered glass protector, which doesn't make any noticeable difference, and it protects your glass from breaking.

Having a glass that is coated and another coated glass on top, I assume would deterior the quality of the of the view experience.
[Huawei P10 Questions & Answers] troublecro:
Big fail from Huawei,i have any kinf of screen protectors and other BS
[Huawei P10 Questions & Answers] AllTheWay:
They make 99.99% transparent glass screen protectors with oleophobic coatings on them for cheap. I also put a glass screen protector on all my phones and even have one on my iPad Pro. I haven't noticed it messing with the color. Generally the cheaper the screen protector the less transparent it is. Just do some research and you will find one that works good for you. I really like my Omoton screen protector on my P10 Plus.
[Huawei P10 Questions & Answers] greyhulk:
I'm glad you're glad there's no coating, but some of us don't use screen protectors, nor do we want to. Saying "everyone should use one" is like saying "everyone should use a case" or "everyone should wear hats". Don't be ignorant. It's our choice whether or not to use something.

I hate screen protectors. I have never used one and I have never scratched one of the dozens of smartphones I've owned over the years. I'm certainly not going to buy a phone that basically forces a screen protector on me.
[Huawei P10 Questions & Answers] tophe42:
Hello, I also am not a fan of the glass and protective films that make that bubbles am very disappointed with this phone but right now I bought a screen protector liquid especially to reduce the fingerprints and It looks to be not bad at the moment and so it has neither bubbles nor dust for the moment it's top to see in time
[Huawei P10 Questions & Answers] vicusbass:
What liquid protector did you buy?
[Huawei P10 Questions & Answers] vicusbass:
Basically they avoided an answer.

I am ok with applying myself a coating, but I'd rather use an official one, so I don;t loose the warranty...
[Huawei P10 Questions & Answers] tophe42:
Hello, I put this product

https://www.dropprotect.fr/?gclid=C...yEgb99nYXlj8LA5ScUqYkqikLhVXHf6rcFRoCz__w_wcB
[Huawei P10 Questions & Answers] vicusbass:
How is it after a few weeks of usage? Does it worth apllying it?
[Huawei P10 Questions & Answers] vicusbass:
I finally got a call from the local Huawei manager (Romania), he says THERE IS NO COATING on P10, on any batch. The same for Mate 9.

This company seems very confused to me and it's hilarious, they want to compete with Samsung and Apple...
[Huawei P10 Questions & Answers] c411umuk:
I ordered some liquid from AliExpress. Search 'nano liquid phone'. Haven't received it yet but ordered 3 small vials for $6.
[Huawei P10 Questions & Answers] tophe42:
Hello, I do not have this phone too disappointed by this brand.

Huawei never again
[Huawei P10 Questions & Answers] mertzi:
Can you provide a link? I haven't found anything that cheap on Ali.
[Huawei P10 Questions & Answers] vicusbass:
I have doubts something so cheap could be good
[Huawei P10 Questions & Answers] mertzi:
But everything is cheap on Ali! I have bought cheap stuff of decent quality from Ali.
[Huawei P10 Questions & Answers] c411umuk:
It's cheap because it comes in a vial, with just enough for a single device as opposed to a bottle of the stuff.

That said, it may well be ****e, but at $2-a-pop, I won't be too disappointed.

There were loads on there the other day. I can't find the listing with reviews, but it's the same liquid. I'm in SE Asia, when it arrives I'll give a heads up.

Here

https://youtu.be/nrBLJaeNLxA
[Huawei P10 Questions & Answers] mertzi:
Yep that's what I found and ordered. Wouldn't be surprised if they just fill the bottle with water, but like you said, it's $2.

One thing I don't understand is that most of these coatings primarily promote the hydrophobic effect, but is that what people care about most? Personally i just want to minimize the damn finger friction with having to eat pizza and not wash my hands. If you use Swype, swiftkey or something similar the experience is not fun.
[Huawei P10 Questions & Answers] c411umuk:
I noticed today that my 'jollop' was sitting in my mailbox. Not sure how long it had been there.

I applied it, not caring about the fingerprint sensor, let it dry for 5 minutes, before cleaning it off.

Just cleaning it off I could feel a considerable improvement.

For me the issue was how slimy the screen would get (I live in Thailand; it's always hot here) and this stuff has definitely reduced the amount of smudges that remain on the screen after using.

No idea how long it will last for, but I recommend trying it for yourselves. $2 well spent, unless it wears off in a few days\weeks.
[Huawei P10 Questions & Answers] Jannomag:
I doubt that liquid protectors are working after looking at tests and user feedbacks. Even "German Quality Products" are designed working well. . You don't see or feel it and you don't know if the protection is gone.

But tell your experience with this $2 thingy after view weeks.