yashsingh1/xdaforums huggingface dataset:
[Magisk] JazzMartian:
NOVK added to the zip allowed me to flash it without having volume keys. Thanks again for your help.

It would be a good idea for that information to be added to the OP.

I had to install udbr_v3.1 for the mod to not bootloop my Nvidia Shield Portable. I tried all of the different installation option combinations. It's all good though as the mod works for me.

[MENTION=5357345]ahrion[/MENTION], I just wanted you to be aware of this feedback and thanks for all of your scene contributions. :)
[Magisk] keshav_c17:
I tried installing older version of acp when it was universal deep buffer remover.. and i think it was a zip file and not a magisk zip file. And now installation is failing while installing acp v1.7.3.. also in magisk module list a module with name acp shows with "No info provided" in the details.

EDIT: Flashing zip from TWRP is successful. Everything is working fine now.
[Magisk] GR4V17Y:
V4a stops working. I thought audio compatibility patch can help. I selected settings exactly like on thread. It made bootloop. What should i do?

Oneplus 6

Thanks
[Magisk] Poipoii:
Same here, I've been using V4A with ACP & AML for a long time now without issue, but V4a suddenly stopped processing spotify & youtube a few days ago. I tried reinstalling everything, the same way I did when I made it work the first time, and in different orders, with different settings. Something broke without me making any changes. Some automatic update/magisk update broke it?

OnePlus 3 8.0

EDIT: So that's weird. I uninstalled everything (V4A, ACP & AML), deleted every trace of those from my storage, rebooted to recovery to flash the Universal Deepbuffer remover, booted back and reinstalled ONLY V4A, and now everything is processed by V4A like I want it to, without ACP or AML.
[Magisk] dracopast:
USB output + viper stopped processing after android 10 on the three phones I tested, it works on pie.
[Magisk] Ad.Shk2:
How do i change the settiings I initially chose with the volume keys?

Also what is the purpose of the USB DAC setting?
[Magisk] Keule-Tm:
You can change them by reflashing.

USB DAC is about an external USB DAC, AFAIK.
[Magisk] Kastilo:
Hello, just to check in, it seems like this module doesn't want to work even with all possible combinations tried. Notifications still "duck" when using this module while using v4a

OS: HAVOC OS 3.6 "Q"

Device: OCEAN
[Magisk] MAOQ:
Everyone ku.) It turns out that the Audio Compatibility Patch is the same and this?

https://androidfilehost.com/?w=files&flid=165953
[Magisk] Iustin_Theft-07:
I have a rooted Samsung Galaxy A5 2016 with v4a. Spotify works when applying the attach audio effects in v4a settings, however youtube won't. I installed this module with every single combination in the installer but youtube still doesn't work with v4a. Can something be done ?
[Magisk] Riki Irawan:
[MENTION=5357345]ahrion[/MENTION] ACP v1.7.3 is fails to load with AML 4.0
[Magisk] Qutayba Khader:
I thought that:confused: what version should i use? For both please
[Magisk] warrencoakley:
I have DDP, JDP, AML and ACP installed.

I've noticed over the pass few days that I'm getting a crackling sound from some games and notifications.

I unistalled the patch and everything is back to normal.

Is this a bug?
[Magisk] Zackptg5:
ACP has finally been updated to v2.0! It's been switched over from unity to mmtex so works fine now with latest magisk and aml
[Magisk] Riki Irawan:
[MENTION=6037748]Zackptg5[/MENTION] ACP v2.0 is still not loaded at all with AML 4.0. Files are taken by AML and .aml.sh is failed to patch it again.

Without AML, its failed to patch audio policy, but usb audio policy only..
[Magisk] Zackptg5:
Can you flash acp, save the log in magisk manager, then attach that and the acp folder (zip it up) in /data/adb/modules_update? (Do this all before rebooting)
[Magisk] Riki Irawan:
[MENTION=6037748]Zackptg5[/MENTION] Here is it

includes logs install and my modded acp
[Magisk] Zackptg5:
Can you upload it somewhere else? Xdas servers are trash currently
[Magisk] Riki Irawan:
ups sorry, here is it

https://drive.google.com/file/d/1C6_u9Whoy-tzU5zML2TPyXK2VowNNUUs/view?usp=drivesdk
[Magisk] Riki Irawan:
[MENTION=6037748]Zackptg5[/MENTION] https://drive.google.com/file/d/1EWsrQggtcXyBTuSgK7KNl4Kq3fpV2PKB/view?usp=drivesdk

v2.1 test

Still didn't patch audio policy, but only usb policy

btw v1.7.3 is patching audio policy correctly, even aml failed
[Magisk] Zackptg5:
It patched audio policy fine, looked over your results from 2.0 again and patched fine there too (I was looking for remove stuff instead of patch stuff lol)

So the remove logic is the old school deep_buffer remover and stuff where the entries are removed from the routes at the bottom of the xml file. With the patch logic (recommended because less buggy stuff happens with it vs removed), certain lines are changed. In the case of an xml (like yours):

deep_buffer and low_latency mixPort flags are replaced with "AUDIO_OUTPUT_FLAG_NONE"

raw mixPort flags are replaced with "AUDIO_OUTPUT_FLAG_FAST"

Checkout the common/install.sh file in v2.1 update I just pushed. It's much more readable/simple then the v1.x releases because I switched from unity to mmtex templates to make it magisk only - patches are simple removes rather than backups/substitutions
[Magisk] Zackptg5:
Updated to v2.1! Minor update, just cleaned some stuff up. Changelog:

* Minor fixes

* Rework prompts to make more sense
[Magisk] Riki Irawan:
[MENTION=6037748]Zackptg5[/MENTION] oups ok its patched

but .aml.sh still failed bro https://drive.google.com/file/d/1EnSpC8EgnQGP8PMndL8B-Sr4uzMPH-zP/view?usp=drivesdk
[Magisk] Zackptg5:
I already fixed the errors noted in your log in the stable v2.1 release I just pushed to the magisk repo, give it a try and make sure it works for you :)
[Magisk] Riki Irawan:
that is v2.1 from magisk repo that you uploaded actually
[Magisk] Zackptg5:
Can you try redownloading and installing? The aml log is giving an error for a line I removed in the latest update. Github can lag behind by a few minutes due to catching
[Magisk] Spiricore:
I had installed it at one point when trying (without avail) to get Atmos to work with V4A, and had assumed the first sentence in the OP might also apply to CRD since it also seemed to fall under "streaming audio not being processed".

I toggled it and rebooted it to make sure I didn't derp, but it has no effect either way.
[Magisk] Gilg@mesh:
[MENTION=5357345]ahrion[/MENTION]

I do run your Viper4Android mod and it's processing with PowerAMP but not with Youtube, possible to make it work? thanks
[Magisk] ezio84:
Nice module, it works well on 6p. Thanks.

Just a few more infos about deep_buffer: https://android.googlesource.com/platform/frameworks/av/+/439e4ed^!/#F0
[Magisk] 24imelqui:
Have you tried using deep buffer remover? I think that module cause V4a to process with YT.
[Magisk] Gilg@mesh:
yes that's why I wrote in this thread, it did not help with deep buffer remover :)
[Magisk] Spazturtle:
Audio quality degrading or suffering crackling (gaps in playback) just means that this module is doing it's job. Since deep_buffer is designed to prevent audio crackling disabling it can cause audio crackling. Audio is lower priority then things like drawing the UI on Android, so if the CPU is under heavy load it may cause delays in processing audio, this causes gaps in the playback. deep_buffer prevents this by having a buffer with 100ms (target) of latency, so when the CPU is under load and can't process audio immediately it doesn't cause gaps in the playback.

If you are getting audio issues with deep_buffer disabled then you need to reduce the amount of things running on the CPU or get a new phone, there is nothing OP can do to fix it for you.
[Magisk] otonieru:
Hi [MENTION=5357345]ahrion[/MENTION]

Funny enough that this works with my youtube but not my spotify, LoL

How should i provide log ? I check magisk log, nothing in particular related to the audiomodlib nor deep buffer
[Magisk] r33fd:
this module makes zirene work with spotify on my note 4 exynos .

But I have a problem .

Now I can't play flac files . My phone was able to play this with defualt music app before :(
[Magisk] 24imelqui:
Guys try flashing audiomodlib again. It may fix your problems.
[Magisk] Codebucket:
Please fix the ugly Bluetooth Share fc, it's annoying to see every second a fc when listening music...

Logcat: https://pastebin.com/DNe8GwTM
[Magisk] ahrion:
If you're getting that, it's because your phone isn't compatible with this hack.
[Magisk] umeshbluezzz:
Doesn't work with magisk + magisksu.... Stuck on boot on lineage os 13.0.works better with no issues when using supersu + magisk.

Any help bro?
[Magisk] ahrion:
So I'm not quite sure why it wouldn't pass safety net check when in the last 3 iterations of Magisk it does. This would be a magisk specific issue.
[Magisk] JohnFawkes:
Safety net got updated like a week ago. The latest beta is supposed to fix sn issues but some modules that use postfsdata are failing. I believe it has to do with some modules replacing files/folders on /system and not just merging said files/folders. Such as the GPE dialer module. He disabled the postfsdata file and it passes sn now when it didnt before
[Magisk] ahrion:
Delete post-fs and see what happens. However I don't use any script to replace anything with post-fs.
[Magisk] JohnFawkes:
I just flashed to test without deleting anything because I saw that you werent replacing anything and i pass SN. We will have to wait until topjohnwu releases the new templates.
[Magisk] JohnFawkes:
Use deep buffer remover 2.4 and see what happens. I pass SN with 2.4 and i see your using 2.4, also what other modules do you have installed?
[Magisk] ahrion:
I have like 15 modules installed. I'm not using beta 13 because it is unreleased and template hasn't been updated.
[Magisk] JohnFawkes:
My bad lol. That was supposed to be a reply to [MENTION=6192935]casual_kikoo[/MENTION]
[Magisk] Riki Irawan:
https://drive.google.com/file/d/1F42DVZF5Cs0k0aFKNkatr5nQEg3bFGJx/view?usp=drivesdk

audio policy is patched but usb audio policy is still not patched

(idk about helper remover and lib workaround because I'm not using it)
[Magisk] Zackptg5:
Looks patched to me. On line 29, profile name was deleted (the XML usb file) - xml always takes precedence over confs with audio files
[Magisk] Riki Irawan:
oh ok, keep the good work dev ?

thanks for support ?
[Magisk] Player04:
Im having trouble with installation of acp 2.1. im not able to flac audio. Old version of acp works perfectly.
[Magisk] reiryuki:
[MENTION=6037748]Zackptg5[/MENTION] usb_audio_policy_configuration.xml is really not patched with aml. Without aml its patched correctly. https://drive.google.com/file/d/1Oiu454ctwj3d0eubuj35HTopBn0lwANa/view?usp=drivesdk
[Magisk] Zackptg5:
It is patched. Same thing I commented on in a couple posts above too. Line 21 of the aml copy, name value is removed like it should be
[Magisk] reiryuki:
not patched. its in /data/adb/modules/aml/system/vendor/etc. which the same as the original file in /sbin/.magisk/mirror/vendor/etc
[Magisk] reiryuki:
and this is patched without aml. Value is changed to 48000. see?
[Magisk] Zackptg5:
Oh duh, that's what I get for comparing file on my phone rather than my pc. Can you try this build?

Edit: testbuild removed. Try v2.2
[Magisk] Zackptg5:
Updated ACP to v2.2! Changelog:

* Attempted fix for usb patching

* Updated volume key addon (no more key programming needed)
[Magisk] reiryuki:
[MENTION=6037748]Zackptg5[/MENTION] usb aml still not loaded

Maybe you should patch those files in post-fs-data.sh (recopy) in every boot instead of patching them in customize.sh once, like what I did in my acp mod. It will loaded with aml. Or try using MODDIR=${0%/*} $MODDIR instead of $MODPATH in .aml.sh
[Magisk] Zackptg5:
It's actually loaded properly. The 44100 is supposed to remain that way in the usb XML file. I didn't write the USB patch, that was johnfawkes so I'll check with him on what's the intended behavior and get it figured out.

That's not how aml works. Since the Audio mods can change each boot and the patching process can take too long for post-fs-data, the patching is run from scratch with a clean set of audio files each boot as service.sh. This ensures that the patches are current
[Magisk] reiryuki:
[MENTION=6037748]Zackptg5[/MENTION] it would be the same as what is patched in customize.sh and .aml.sh. If you don't patch usb xml, then you should delete the thing in first installation too.
[Magisk] Zackptg5:
Absolutely. An update will be pushed out once I find out what the intended behavior is
[Magisk] Zackptg5:
Think I found the issue. It was actually due to a bug in acp's aml script. Can you try this build?

Edit: removed test build, equivalent to v2.3 release
[Magisk] reiryuki:
usb still not patched in aml

somethings wrong in .aml.sh ig
[Magisk] Zackptg5:
It's always something dumb lol. It was 2 things: xmlstarlet alias needed to be declared before the function calling it, I forgot the asterisk before usb file in the case statement. I reuploaded the fixed one to my site so redownload it and give it a shot (same link as before). Pretty sure I got it this time
[Magisk] reiryuki:
[MENTION=6037748]Zackptg5[/MENTION]

Great! All is patched now. Nice work dev. Thanks! ?
[Magisk] LuminousMazim:
Hey do i need to install aml too with this module or is it already included?
[Magisk] avetny:
I guess sorry trying to understand how it works.

So I'm using sound cloud....it will help me to stream with higher quality ?

Regards
[Magisk] drahtwurst:
not changing anything here with eq section of dub music player. meybe it has not seen the right choices. there is too little time to read an press yes or no while installing.

Gesendet von meinem ZTE A2017G mit Tapatalk
[Magisk] Lughnasadh:
[MENTION=6037748]Zackptg5[/MENTION] I noticed this as well on my Pixel 4 XL (the last part of the quote) that if you don't choose a yes/no answer with the volume buttons immediately the installation will fail and you have to start over again. It speeds through the questions extremely fast and doesn't give you time to read them on the latest version.
[Magisk] Keule-Tm:
+1

[+1 for your nick, Lugh]
[Magisk] Zackptg5:
You have 3 seconds plus another 3 seconds for the second chance. 6 seconds should be more than enough to read through those options
[Magisk] Keule-Tm:
Sorry, but I disagree. Might be because I'm no native speaker, or because osd elements (of mm?) hide parts of the text (iirc), but I always need to flash it at least twice. And as selecting an item always proceeds to the next step I see no downside (at the user side) in adding some more time per step.
[Magisk] Zackptg5:
The timeout is just a failsafe in case something goes wrong but that's understandable, I could lengthen the time
[Magisk] Zackptg5:
[MENTION=7773220]Keule-T[/MENTION] Pushed update that increased timeout time. Didn't change version number at all because it's a super minor change
[Magisk] Keule-Tm:
Thanks!

Edit: Just tried it, working great.
[Magisk] xunholyx:
Cool! One of the biggest problems is with the new MM app. The "flashing icon" in the center of the screen is a big part of the problem as it blocks the read out on it. I had a hard time keeping up with flashing the new ACP module. Also, the 3 second thing you referred to earlier.....more like a second and a half. I've already flashed it after a second try, but the extra time is welcome for next time. Thank you.
[Magisk] yaser86100:
hi everyone i have question about sound quality plz help me

i know maybe this thread not ok for this question

i have mi 10 global and miui eu base version

when i played call of duty and someone called with me or notification arrived game sfx sound very buffy and reversed i test udb 3.1 version someone tell me test that but not different with udb i install with twrp

anyone have solution for this tnx

p.s: i dont root my phone and install magisk
[Magisk] edegg:
ahrion,

thanks! Patch helps on Nokia 8 with repairing OZO sound recording in stock camera. Bitrate is near 300kbps again, and stereo too :D
[Magisk] zamzam_asad:
Please helpme. I use viper but it doesn't work in all applications and games, it must be on off legecy mode.
[Magisk] hasandroid:
Hi, i use this module to use my dac with viper4android. It works great but about once in 2-3 hours a stutter happens. Some milliseconds of sound is skipped. It maybe the dac turning off and on because the length changes depending on the dacs used. I tried it on other phones, different kernels and android versions it still happens. Is it because of this module or viper4android?
[Magisk] Bradford1040:
Hey people, hope everyone is well!

I installed this module on magisk 21.4, I was having a few apps that didn't work well with V4A (my device = 1+7tpro5g LOS 17.1)

The apps that weren't working well now are working better(not perfect, but better), but vlc decided to I guess disconnect from the enhancements I have set in V4A.

Do I try to set another profile and match the enhancements in V4A (trying different ones?)

If that is what's expected to be the best choice its cool, I just don't want to search for hours to come up with the answer after tons of hair pulling sessions, I'm sure plenty can relate!
[Magisk] Pascal3366:
Does this patch disable the resampling to 48Khz through usb audio?

Amazon Music HD is completely useless for me because USB Audio Player Pro does not support amazon music and Android resamples everything to 48Khz.
[Magisk] Spaceminer:
I'm sure it doesn't do that. You need to edit /vendor/etc/usb_audio_policy_configuration.xml to change that. If you're on Android 10+ then you'll need a magisk module because the vendor partition is read only. I can make you one if that's the case, but I'll need a copy of usb_audio_policy_configuration.xml from your device, and the sampling rate you'd like to use.
[Magisk] ciaran.c:
HI guys,

New to this whole modding community and I'm having an issue. I've rooted my s8 with pixel experience rom and magisk, and am trying to get my phone to play audio out through usb when connected to my jds element 2. Been trying to get audio compatibility patch to work, but to no avail. Any help would be greatly appreciated.
[Magisk] innit:
For some reason I am not able to install this module anymore. It worked fine few weeks ago though. I then flashed new firmware on my S20 (as I do every month), set up the phone the exact same way as usual, installed all the same magisk modules as always and every single one worked except for this one. Any ideas as to why? I attached a log and a screenshot.
[Magisk] DAXX:
Does this work on Oneplus 8 Pro running Android 11?
[Magisk] Hammerhand.17:
Hello. I am trying to install the module through magisk, but I have not access to volume keys, and I don't have access to a custom recovery either. FKM or ExKM gives error too. is there any way to achieve installation?
[Magisk] Labib235:
Would it be possible to add another method to select options instead of volume key options like typing yes or no via onscreen keyboard through recovery? My volume down key is broken so my only choice is to use volume up regardless of whetheri like it or not
[Magisk] miapuffia:
I've been using this module for years and it's a must have. Do you know if this could be made to work for the system ringtone? My ringtone is obnoxiously lower quality than the source sound.
[Magisk] biohazark:
Hi,

I try to install ACP on my Android Car radio, but during installation of the Magisk module, I must press "Vol UP" key of the device. However Vol UP key it a touch button and it is not recognized...

So how to install ACP module without pressing button OR how can I simulate VOL UP key without physical button?
[Magisk] JazzieBoi:
Maybe try this app? https://play.google.com/store/apps/details?id=com.nitin.volumnbutton
[Magisk] toolhas4degrees:
@ahrion op9pro module can't detect vol buttons
[Magisk] RheinPirat:
I have the same error. But with the older Magisk version, it worked
[Magisk] Zackptg5:
Updated acp for magisk canary, should fix volkey problem
[Magisk] Labib235:
Magisk still doesn't detect volume keys so not worth it at all
[Magisk] JazzieBoi:
For me it works, Magisk has been detecting my volume keys since v20+. Although you're on an Android Car radio xD. I'm sure there's gotta be a way, even if you can't figure out the volume button method. Maybe you could somehow try manually installing it?
[Magisk] Labib235:
What makes you think i am using an Android car radio? I tried to use it on Galaxy S Duos 2 running Lineage OS 14.1 with magisk 24.1 & xposed magisk module
[Magisk] JazzieBoi:
Oops I thought I was replying to biohazark the one with the Anroid car stereo. I still don't see why it wouldn't work since I have a Oneplus N10 5G with Magisk 24.1 with Lsposed Zygisk as well and when I try to install any kind of module that requires volume button input it works just fine for me.
[Magisk] dhrjbhtt0:
solvd
[Magisk] pattedeluxe:
where to get acp now without repo?
[Magisk] Lughnasadh:
Use this repo...

GitHub - Fox2Code/FoxMagiskModuleManager: A module manager for Magisk because the official app dropped support for it

A module manager for Magisk because the official app dropped support for it - Fox2Code/FoxMagiskModuleManager

github.com
[Magisk] frostedpichunut:
I'm trying to install this module to get v4a to work(instead of saying processing:no) when listening to music via the Samsung music app but I'm having no luck, what options am I meant to pick during installation?
[Magisk] locuturus:
Could the timeout on the volume options be longer? I get install failed within a few seconds unless I immediately press volume keys and I honestly don't know what I did or didn't apply because there was no time to read...
[Magisk] locuturus:
EDIT: double posted somehow
[Magisk] Labib235:
also maybe introduce a way to type in what the user wants as an alternative to pressing volume keys
[Magisk] Sneeder:
@Zackptg5 so no fix for the notification ducking effect on Android 10/11/12?
[Magisk] castaway1:
where can i find ACP 2.5 for magisk please?
[Magisk] ottoxgam:
Hi,

Any chance there's a new release for 64bit only systems?

Pixel 7 Pro running 13(TDA.221105.001)

Magisk a468fd94 (25205)

Thanks!
[Magisk] Lughnasadh:
ACP is working for me on my Pixel 7 Pro running Android 13 QPR2 Beta 1. Confirmed because preventing audio ducking is working.
[Magisk] ottoxgam:
Where did you install the module from? The FMM module errors out as shown in the attachment.
[Magisk] Lughnasadh:
Magisk Modules Repo - #1 Trusted Source Of the Best Modules - Androidacy

The Androidacy Magisk Modules Repo is your go-to source for reliable, secure magisk modules and KernelSU Modules to enhance your android.

www.androidacy.com
[Magisk] ottoxgam:
How strange.

Using the install option from Fox's MMM failed with the error.

Downloading and flashing through Magisk Manager works fine.

User error I guess 😂
[Magisk] sean222:
Any workaround if my volume key isn't detected? Running Pixel 8 Stock ROM Rooted with Magisk 26.3 Stable. Other Magisk mods detect the volume key and it works ok. Tried Canary as well but didn't make a diff, especially if other mods are working.

If there's a way to manually edit the config files to force apply patches to just get it installed let me know please :)

Edit: Solved this by editing the install script for my needs. Deleted the VolumeKey addon by fully deleting it's folder. This I edited the install.sh script of ACP to specify the options I wanted with TRUE/FALSE.

Working great on my Pixel 8! Can finally enjoy YouTube music with amazing audio :)
[Magisk] enskje:
maybe you could share edited module? thanks in advance.
[Magisk] GohanBurner:
Care to share? I can't use the volume keys to choose what I want.

Edit: I decided to just alter it myself. Here is the file. Basically sets everything to true. You can modify this line in install.sh (acp modified.zip\common\install.sh )with "FALSE" to turn features off.
[Magisk] mmarcz:
FYI, Jamesdsp does not work when connected to Android Auto, V4A does.
[Magisk] skuppej:
I thought I was the only one with this issue. Are you using wired or wireless AA? I wasn't able to get either to work