yashsingh1/xdaforums huggingface dataset:
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
Correct me if I'm wrong, but the sound issue was caused by the fact that they are using AW8737 as speaker amplifiers instead of the WSA881x speaker amplifiers internal to the SoC. They replaced wsa881x.o with aw8737.o in sound/soc/codecs/Makefile, which had the unintended consequence of also removing the call to wsa881x_init_thermal(), which was apparently needed.

So hats off to Christian Ciach for debugging and fixing that. Very good job. I'm just saying this: now that we have a fix for that, we can't just pretend we don't. Is there anything else we need an up-to-date source code from Lenovo for?

The hard part was getting the diff. That can be then rebased on top of anything compatible (which includes, as you said, Google kernels). But the original source code was undeniably based on CAF.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] tombraga:
In my opinion an update for Nougat by Lenovo never will happen, that's my feelings.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DeathHacker:
Correct me if I'm wrong, but didn't you say that there were still minor issues, such as the static-y sound from the speakers, because of this?

I thought these were never fixed, but maybe I'm just blind.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] VojNov:
Guys on topic of sound - it works but when sound is playing the speaker makes sort of hissing, not too loud but is noticeable when there is only voice for example, even from distance. And when no sound is playing the speaker still makes quiet noise (sort of white noise) but that is only noticeable when being really close to the speaker.

My question is - is that normal and most importantly safe? Isnt that going to wear out the speakers fast or something? Noises don't bother me as long as it is safe for the hardware. Sorry if it is a noob question, very happy with the ROM otherwise.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Don't worry, the hissing sound is way too quiet to to any damage. Also, the hissing sound is also present on the stock ROM while the speakers are active. For example, if you play a completely quiet MP3 file, the hissing sound would also be present. The only difference is that I don't allow the sound card to go to deep sleep while the screen is on. On stock ROM, the sound card goes to deep sleep as soon as there is no sound playback.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Seems like I missed some interesting discussion here. Let me reply to your points:

The call to wsa881x_init_thermal() is an ugly workaround to fix this. The stock kernel clearly doesn't call wsa881x_init_thermal(), as there are no thermal devices registered when running stock. It looks like Lenovo hacked the caf-audio-HAL on stock for the HAL to switch to WSA-mode, even when there are no wsa-thermal-devices registered. I want to touch the /system-side as little as possible, so I kept the HAL untouched and hacked the kernel instead. Hats off to you for understanding my fix ;)

There are quite some differences in the kernel device tree sources (DTS) between the stock kernel and their released sources, not just regarding sound. This means that there are surely also some differences in the kernel drivers. Yes, we got all the hardware working, but that hardly releases Lenovo from their obligations to release the correct sources. I argue that the hardware would probably work better in general by using the up-to-date drivers and DTS.

Last but not least, it's a matter of principle. The GPL is serious business for any ROM developer and the very basis for our work. By releasing no or non-correct kernel sources, the OEM makes our work impossible or at least much harder than it needs to be.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
So would you go as far as saying that commenting pm_runtime_put_autosuspend(&pdev->dev) has no other side-effects apart from the hissing sound and slightly more power draw?

Could you please care to comment why is disabling autosuspend needed, and what exactly does "registering thermal zone" mean? Also, I suppose you are only registering even-numbered aw8737 devices because there are 4 of them, connected to only 2 aw8737 channels?

TL;DR: Make me understand why you call it "ugly" :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
[MENTION=7398554]vladimiroltean[/MENTION]

First of all, thank you A LOT for your kernel-diff on Github! I am seriously considering rebasing our kernel on your branch, as it would probably make merging future kernel updates a lot easier.

Yes, I would say so. Keep in mind, this only prevents runtime-suspend but does not prevent sleep-suspend (or maybe called standby-suspend... It has been a while since I looked at that code).

Otherwise, the amplifier (aw8737) would put itself to suspend after a few seconds of playing sound. Normally, the aw8737-driver needs to be notified continuously while sound is played, to prevent it from suspending the amplifier. This is surely done inside the real kernel-sources, that we don't have. So, my fix is just a quick hack. The correct fix would be to modify the aw8737-driver to prevent it from putting the aplifier to suspend only while sound is played, instead of preventing runtime-suspend altogether. This is harder than it sounds and I wasted many hours to try to do just this. After wasting so many hours I decided that this is not worth the effort. Instead, I think Lenovo should release the correct kernel sources (including the up-to-date aw8737-driver).

All I really know is that I need the audio-HAL to switch to WSA-mode, because this is what the stock ROM does. The stock ROM clearly has a hacked audio-HAL to always switch to this mode, but I didn't want to touch the HAL, so I hacked the kernel instead. The vanilla audio-HAL goes to WSA-mode if and only if exactly two WSA-thermal-devices are detected. These are detected by scanning the directory "/sys/class/thermal". This directory lists all thermal-devices registered to the kernel. The HAL expects exactly two WSA thermal devices - see here.

Looking at the HAL code again, I think it may be unnecessary for me to only register even-numbered aw8737 devices, as the loop inside the HAL stops after finding two devices anyway...
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Because it is not a proper fix. As said, the proper fix would be so that the amplifier goes to suspend as soon as no sound is played. I could probably fix that by putting more time and energy into it. But I decided that my ugly workaround is "good enough" until we get the proper sources from Lenovo, if ever..
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
Guys, am I the only one for whom Developer Settings just hangs the whole Settings app?

Logcat gives me nothing relevant.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] VojNov:
Does not happen to me at all. But Google Photos freezes when trying to open sync settings. Only thing that freezes for me.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] BlackAfghan:
Seems to work with MicroG.. Probably some Gapps issue!
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] matty_g_8:
I have a lenovo tab 3 10.1 za0x0006au and will this rom or any lineageos roms work on it?
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] sth0r:
This rom only works with yt-x703f and yt-x703l (will lose lte)

I do not know about any other roms.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] Svebu:
How do I enable Dolby Atmos?
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DeathHacker:
I assume you mean how to flash Dolby Atmos?

First, get the flashable zip from the link in the first post (https://www.androidfilehost.com/?w=files&flid=185271)

Then, reboot into recovery and flash/sideload it from there (as per https://xdaforums.com/wiki/Flashing_Guide_-_Android#App_Installs.2FROM_Feature_Installs_via_Flashing)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] Svebu:
thank you very much
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] zfxinx:
Init.d doesn't work, Dolby hits the demo FC, when will the next package be updated?
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
init.d support is something we take directly from upstream: https://github.com/LineageOS/android_vendor_cm/blob/cm-14.1/prebuilt/common/bin/sysinit

It is something that we do not mess with.

It looks like there is a SELinux policy in place which is denying sysinit.

I will look into that, because sysinit support is of interest to me too.

I don't think anyone of us here has a roadmap that is set in stone.

You have all the necessary sources and manifest files to do your own investigations and builds. We do not take that freedom from you.

Next time please try to be either more diligent, or less demanding :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
Hello all,

been reading this thread ever since it started, which was just when i got my tablet.

i am very interested in using this ROM, am fed up with how the stock rom works. but there is one thing holding me back. i specifically got the YTX703L device as i would very much like to have LTE data when not home with the tablet.

i have read the initial post where [MENTION=2806083]DerEineDa[/MENTION] clearly states that the LTE functionality is not supported.

i have also read a post by user [MENTION=7398554]vladimiroltean[/MENTION] who posted alpha status sources for the LTE functionality, and confirmed having data.

basically i want to go ahead with flashing the ROM, bout would like to ask [MENTION=2806083]DerEineDa[/MENTION] if the LTE sources are in the last build. i know you can not test them, since you said you do not own an LTE device, but have you used them in the build? is there any plan to do so? would love to have LTE functional on this thing, with android 7. if you need testers i can volunteer since i have the device. but you'd have to walk me through everything you need. i have an upcoming trip to north Germany starting 3rd september, if you like you can have my device for a week 3rd to 8th september to experiment with if you are up north, and have the time. PM me if interested.

thank you for investing time in this device!
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Hi!

Sorry, the latest build has no LTE support. [MENTION=7398554]vladimiroltean[/MENTION] is currently working on this, but there is no ETA.

When we support the LTE variant, it will most likely be a separate ROM file.

Just out of curiosity: Where in Germany are you visiting? I am living up north :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
Well main site is Wolfsburg, i will be landing in Hanover, and if i'm lucky i will also be able to travel around, quite big distances. not up to me right now.

but if you are close by and have time to work, we could arrange something. again, PM me if interested. just do so until i leave, so i know to take the tablet along.

and thank you for the VERY speedy reply.

PS: good to know you guys have plans to make this work eventually, and are working on it.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] paulobrien:
If I can help in any way with the LTE version / testing, let me know.

P
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
Hello,

https://drive.google.com/open?id=0BycBHkd7fD4AbnV3dlhwdl90ZUE

Here is a build for the YTX703L which I deem of "beta" quality.

* Patches to enable LTE cellular data are applied directly on top of Christian's, Matthias' and Gabriel's great work. Whatever they did for the F, this build has it too :)

* SELinux is running in enforcing mode

* Latest (Aug 5) security patch level in the Android framework

* Kernel based on latest CAF (Aug 4) LA.BR.1.3.6-04510-8976.0 tag

* Voice calling still doesn't work, but I'm stilll not 100% convinced, so the Dialer app is still in there

Please test and report on what is not working :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] york824:
I had to switch back to the June 13 version because with the latest version the speaker sometimes make a *broken* noise. This happens regardless the speaker is in use or not. I read the whole thread here but couldn't find a fix so I flashed back. Anyway it is still a great ROM. Thanks a lot.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
thank you very much for this!

i hope i'll find the time to install it during the week, been working late lately.. if not next weekend.

on thing. my device is not yet rooted, so i'm still on stock.

do i just follow and use all files in the first page to root, and install this after i have custom recovery?

or do i need to go through an X703F build before flashing this?

thank you!
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Just follow the guide to install TWRP, than install [MENTION=7398554]vladimiroltean[/MENTION] zip from TWRP. There is no need to install the wifi-ROM first :)

By the way, installing TWRP and the ROM has nothing to do with rooting.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
hi, thanks for the answer, i was use to all custom roms coming pre-rooted.

TWRP is the custom recovery, that should enable me to flash the zip. and i figured once the zip is flashed, i am rooted...

i've done tons of samsung phones in the past but those were easy.

here i see i need a tool called fastboot... think i found it, will see if i can make it work.

also, on matshias's page it says:

"Code:

fastboot boot twrp-3.0.3-0-yt_x703f.img

to temporarily boot into TWRP. You can also flash if you are sure "

i am sure i want to flash it, from what i understand all i loose is OTA updates.

but how do i flash it?

"fastboot flash boot twrp-3.0.3-0-yt_x703f.img"

never used adb before...
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
LineageOS is not rooted by default.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
noted.. will need to see if i need root, and figure out how. will read through the thread when i have time.

any quick hint on the flash thing?

what command line do i use to flash TWRP?

thanks!
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
Back everything up. EVERYTHING!

Activate developer settings and adb.

Hook your tablet up to a PC.

Run "adb reboot bootloader".

Run "[sudo] fastboot oem unlock-go".

Now all your files are gone. You may proceed.

Still from the bootloader, run "[sudo] fastboot boot twrp-3.0.3-0-yt_x703l.img"

Prepare 32GB of free space on your PC.

From the recovery, run "adb pull /dev/block/mmcblk0 tablet.img"

Go drink something, wait about 1h or so, maybe more. Afterwards, you have a bit-by-bit backup of your whole eMMC.

Now prepare another ~5GB, and do a TWRP backup of all partitions you can, except for userdata. Just to make double-sure.

Move the TWRP backup onto your PC.

Run "adb reboot bootloader" again.

Run "[sudo] fastboot flash recovery twrp-3.0.3-0-yt_x703l.img"

Keep the power button pressed while also holding Volume Down.

Run "adb push lineage-14.1-20170814-UNOFFICIAL-YTX703L.zip /sdcard" (or "/sdcard1", assuming you have an external SD card).

[Optionally] get OpenGapps for ARM64 or whatever.

Flash both zips from the UI.

Reboot.

Wait for the dex preoptimization to finish.

Literally first thing I did once I put my hands on the device.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
now that's a step by step guide right there!

THANK YOU!

hope i can start this tonight, right now i'm backing up all the crap on my SD card. 177GB... it's doing that for quite a while, and only at 40% :(

if not, maybe, maybe tomorrow. but, again, hope i can do this today.

once again, thank you!
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
When I said "EVERYTHING", I really meant "excluding the SD card". Unlocking the bootloader won't wipe that.

If you're still paranoid, you can just pull it out and then put it back in afterwards :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
naaa, thing is, the stock ROM only formats to FAT32. so to use >4gb files, i did the adopted storage android 6 has.. or whatever it's called.

as i've read, the data is encrypted, so if i flash another ROM, chances are it will not be able to use the sd card again. and i will be forced to format.

i read there are ways to recover the data, but i don't want to make my life harder. that's why the backup now, and that's why from the device and not a faster card reader..

*EDIT: one of the big + this ROM brings is being able to format external to exFAT
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
I think backing up the entire eMMC is a bit overkill. Even I never did that...
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] BlackAfghan:
Yes there is no init.d support anymore in LOS for at least 2 years! We can't do anything about it..
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
The cm vold is even cooler than that. You can use ext4 sdcards :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
nice to know, will play around with that.

i started messing arround with what you've given me earlier

"C:\Program Files (x86)\Minimal ADB and Fastboot>[sudo] fastboot oem unlock-go

'[sudo]' is not recognized as an internal or external command,

operable program or batch file."

any idea why? because i use this minimal adb thing?

what does the sudo thing do?
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
sudo is a Linux command. There is no such thing on Windows.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
tried without the sudo before you wrote, phew, rebooting.

thanks!

---------- Post added at 10:56 PM ---------- Previous post was at 10:47 PM ----------

after i ran the oem unlock, the device rebooted into the normal OS, and i had to do the initial setup, as well as activate dev mode.

i assume this is normal, right, i can go on with the next steps. correct?
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Yes, that's correct.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
so, just finished installing, big thanks to the both of you for the support you've given, saved me hours looking for stuff.

and just to confirm, i am now downloading google chrome off of the play store with my wifi off. so sim data works !!

i will start installing stuff back on the tablet and using it, and i will report back here with my findings. sometime this week i hope.

for now, goin' to sleep, else i'll be zombie at work tmr :P

thanks again!
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
Great! Thanks a lot for going through the hoops of installing it today :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
Hi,

so i took the tab with me to work today, playing around and setting stuff up during breaks.

i must say, this OS is amazing, i was under the impression the tablet performance was the way it was because of the hardware. but it was clearly the ROM. this thing runs SO SMOOTH now!!

data is working. only saw one glitch, but am unable to reproduce. i restarted the tablet, long press power, menu comes in, pick reset. after that the tablet did not see my sim. took sim out, put it back in, still no sim. did a power off then on, and the sim worked again. i tried to repeat the procedure 5 times no, but it worked each time. not able to reproduce the scenario...

other than that, i have one question for users. i use nova launcher. if i fast press the back button, 4 times, the tab behaves as if i press home, i get the quick settings for nova - wallpaper, add widget, etc... - is this behavior a ROM thing? when i had the stock ROM this did not happen. can i turn it off? anyhow, it is not that big of a problem.

it is amazing that i can move the buttons about any way i want, i always wanted the back button on the right. the spacing feature seems a bit off though. i do some settings, and they always seem to snap to either default, or very far apart. only after a restart do they seem to go with finer placement.

formatted the card to exfat, and it's working like a charm. thank you for that. this tab is actually starting to be what i wanted it to be when i got it.

with the stock ROM i had this bug, where if i used the SD card (say to download torrents), and turned the screen off, it would not switch back on. i would be forced to do a hard reset. first thing i'll try when i get home, i wonder if it will still happen on this ROM.

and i checked the DRM, it says L1. so i guess it's fine. just thought you'd like to know.

if i see something else, i will write, but so far that was it. really GREAT WORK, you actually made my purchase of the table worth the money!
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DeathHacker:
Could it be the new panic feature introduced in Android 7.1? https://www.xda-developers.com/andr...ode-that-detects-frantic-back-button-presses/

It seems to me like it's enabled in this ROM, but I'm not sure if there's a way to disable it (doesn't seems like it, aside from ROM modifications).
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Actually, that's a default android thing, called panic detection. See here:

https://www.xda-developers.com/andr...ode-that-detects-frantic-back-button-presses/

Edit: damn, too slow typing on the phone :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] paulobrien:
LTE version installed and mobile data / SMS working great (no calls).

Nice work! :)

P
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] vladimiroltean:
Next time that happens, I will need a logcat before you reboot the tablet :)
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
in my stupidity i didn't do that.. I just hope I can catch it again...

---------- Post added at 09:47 AM ---------- Previous post was at 09:44 AM ----------

i'll give the link a read, my s7 does not have this, maybe because it is 7.0.1... lovely new feature, there any way we can make it go away? I remember changing the animation duration to a non standard number via adb on the s7. maybe there's a way to turn this thing off via adb?

---------- Post added at 09:54 AM ---------- Previous post was at 09:47 AM ----------

and one more thing, I installed Google calendar. I remember the same thing on stock ROM, but not to this extent. when I swype to change months, the animation runs very poorly. I'm seeing pictures... this is strange, because games run at a decent fps, and this calendar thing lags like i'm trying to run crysis with a 10 year old pc. hardware acceleration issue?
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] karapoutsoglou:
are the download links down?
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
How do I save a log? I tried logcat but it sees nothing up to the moment when I start the app. The sim is not detected again.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Use the command "adb logcat". It does not necessarily show the log up to the last boot, but still a good part of the history. Use "adb logcat > loggy.log" to save the output into a file called loggy.log.
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] misha0209:
don't know if the history is long enough

https://drive.google.com/open?id=0Bxc41HlZupAsdThvellZT2U5VFE

---------- Post added at 10:21 PM ---------- Previous post was at 10:17 PM ----------

and another one. this time i tried to do the power off then on, and it still did not work

https://drive.google.com/open?id=0Bxc41HlZupAsZVFmUS1TVVZ4dmM
[Lenovo Yoga Tab 3 Plus ROMs, Kernels, Recoveries, ] DerEineDa:
Both logs look fine, good job!

Let's hope that Vlad can make sense of them :)