[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Excuse me. You are right, I mixed that up. Should get more sleep and took more time to look into. Sorry.

I got setup, when the original posting states, I can get rid of any halswitchers - and exactly that (getting multihal to work, with no need to enable/disable HAL3) was achived on this rom nearly 4 months ago...

Funny: the patches do the exact opposite.... Do you implement the additional (or better: proprietary) callbacks in cameraservice. To get my patch working, I use the patched opcam from @kxzxx - the callbacks to cameraservice are removed. The patch alone does not help (for opcam, for snap the patch is working alone).

BTW: have you tried opcam v2 from op5? I can't get flash to work: neither with the two needed jars added to system and BOOT_JARS, nor with them included in the apk (I'm not sure if this is possible at all: adding a jar as a lib is possible, with correct lib perms, but a boot jar is needed to load at boot (sic!) and not at app start).

I would really like to use v2, because it has more features and raw/dng is working, without proprietary callbacks to camera service. Using v2 would also make tricking opcam obsolet. The problem with v1 is, that it works on HAL1 and cameraservice has some functions (triggered by callbacks from opcam to cameraservice), to deliver selected HAL3 features to opcam. This would save us from the need of implementing the callbacks in cameraservice, like @kxzxx did here: https://github.com/kxzxxx/android_device_oneplus_oneplus3t/tree/dev

Sorry, again, for not really reading, but having a short glance and not reading one single line to the last char.

EDIT: may I ask, how do you deal with android.util.OPFeature.* java class and method calls? Do you use oneplus_sdk_utils.jar and org.codeaurora.camera.jar - or do you just ignore them (atm ignoring is my way: if I add them to boot jars, both gets dex2oated successfully, but com.oneplus.camera is stil complaining it can't find OPFeatures class (yes, the libopbase.so is installed with the rom))? @kxzxx has a real good point at sorting the boot jars - order seems to matter - II'm looking for a more elegant solution.

Did anybody know, if and how I can add a java shared lib that is used as boot jar to an apk? If I add it to lib/ (like .so libs) do I need to put uses-library to AndroidManifest.xml? And do I need to add a library permission? And if so, where do I add it: in AndroidManifest.xml or as standalone file outside of the apk in /system/etc/permissions?

And: I'm used to work with source code of any kind - I'm quite new to reverse engeneering with apktool and smali/baksmali. After reading the apktools wiki as well as the baksmali documentation, I've searched the net for adding jars as lib to an apk, but I did not find anything appliable to this situation. Does anybody know of a good howto?

On camera

I append two files to this posting: a flashable zip to remove OnePlusCamera, Gallery and libs and op5 camera apk. I decompiled op5 cam, added the libs, recompiled and signed it, so you can install it just as every other app. Before installing op5 cam apk, you need to remove com.oneplus.camera, com.oneplus.gallery and the libs. Either by flashing the attached zip, or manually - if you delete these files i.e. es-explorer, you need to reboot in order to unregister the previous (op3t-)Camera. If flashing the zip rebooting to system, does the job.

EDIT2: https://xdaforums.com/mi-5/themes/app-collection-camera-modded-t3591177