yashsingh1/xdaforums huggingface dataset:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
You are trolling me, aren't you?

There is no "siankatabg's HAL3 enabler". It's exactly the opposite: it's a HAL3 disabler ( [MENTION=4837394]siankatabg[/MENTION]'s zip is wrongly called HAL1 enabler, because HAL1 is enabled on this rom [and on any other roms without this persistent property for that matter] all the time, but HAL3 is disabled by this zip - it does NOTHING!!!! to HAL1).

You asked me for Google Camera, what CAN NOT work with HAL3 disabled.

What camera app are you talking about now?

When did you change your mind? (Did you change your mind at all?) If you leave the topic "Google Camera crashing", how should I know, if you don't tell me?

What is this about? What would you like to achieve? Which Camera app you want to run? Be as exact as possible - I'm not omniscient.

I'm really clueless about answering you: if I try to help you with your question on Google Camera, but you are trying something different, how can I answer at all?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Lada333:
Yeah, I'm still talking about Google Camera, and there is a file I have called "HAL3_Enabler_by_siankatabg.zip", which really does what its name suggests;

Enables HAL3. No idea where I've downloaded it from, since the links for HAL1/3 enabler from the OOS port thread have been removed (afaik?)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] horqai:
[MENTION=7264930]Lada333[/MENTION] it's not necessary to do a full quote all the time. That's really annoying.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] reddevil08:
[MENTION=4405529]nvertigo67[/MENTION] I have just clean flashed your latest build with beansgapps.

I have enabled magisk hide and it passes the safetynet test in magisk as well but some apps were detecting the rom as rooted even then.

I read in a magisk support thread that it is maybe due to some build.prop values. I changed

"ro.build.type=userdebug

ro.build.tags=test-keys

ro.build.flavor=lineage_oneplus3t-userdebug"

TO

"ro.build.type=user

ro.build.tags=release-keys

ro.build.flavor=lineage_oneplus3t-user"

After the change the apps started working.

Can you look into this issue and if possible change these values in build.prop by default so it doesn't require editing everytime?

The app that was detecting root(with magisk hide) if you want to test it

https://play.google.com/store/apps/details?id=cris.org.in.prs.ima

EDIT: Used a magisk module to do the build.prop changes and it works as well.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] knpk13:
Huh, that's weird. Why would the IRCTC app not run on a user debug build?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] reddevil08:
That's what I thought too. They recently added it, like 6 months back.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] PerryRhodan:
Did you build your own module or is it available for download?

Just have some apps that are no longer detecting root after editing the props.conf.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] reddevil08:
Got a module from a good samaritan in another thread. Edited it to the needed values.

You can edit the system.prop in common folder to your liking.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I think you do not really know, what a build type is, what release tags are and what signing with release keys means at all, arn't you? I like explaining, but this would fill a book.

Short answer: no.

Magisk is a good idea for this changes!

Kids (not only you, but quite some people at the moment), get your concepts straight: if an app refuses to run on user-debug builds, that is only VERY marginally related to root (android nomenclatur: user-debug: debuggable, rootable, more logging; user: no debug code, not rootable, less logging). It's just to avoid that users with a debug build can have a closee eye on their apps.

The same goes for release keys: most devs - like me - don't want to go through requesting release keys (or personal keys at all for that matter), but you can sort out UNOFFICIAL builds by that.

These all are checks an app can do, but they don't relate to root...

Just some thoughts: Do I want to have an app installed, made by people not wanting anybody to know, whats really going on under the hood. On the other hand: it's everys devs right to develop only for specific roms - perhaps we should accept this and ask the dev to change his policy, but respect the answer.

Disclaimer: this thread does not support hacked keys, build strings and build type changes. If you find a bug while this setup is running: perform a clean flash and reproduce the problem without these hackz. Thanx for your understanding.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] reddevil08:
You are right, I have zero knowledge of building custom ROMs.

Also I already tried clean flashing. I never wanted to imply that the problem was related to root. I had already tried running that app on an unrooted flash of this ROM( just forgot to mention it ?, sorry) and it didn't work.

Anyways thanks for your answer and explanation.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] wistlo:
I like the current set up for HAL1/HAL3 management: both active, easily disabled if necessary with terminal commands and deleting a property file.

I would not mind having .zip files available to flash to change HAL configuration, but I can do without. The changes are simple one-liners in prop files and making sure the camera property file is not present.

Closed-source OOS could be updated at any point by the manufacturer to support or require HAL3. If that happens, we are in good shape with the current configuration.

I switch between cameras, as none of them are completely stable for me. OpenCamera works most reliably for me. OOS will sometimes just stop recording a video. HDR mode in OpenCamera is only available with HAL3 and Camera2 API enabled, and it sometimes fails with "SERIOUS CAMERA ERROR". I have FV-5 paid version, but it is slower to wake up than OpenCamera and OOS. I just realized Google Camera will run again, but have little experience with it in its current version.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] liver20:
Battery is better than oos?

Enviado desde mi ONEPLUS A3003 mediante Tapatalk
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] uli_p:
Just wanted to say thank you for this amazing ROM. Super stable, smooth and incredible battery life with MicroG:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
cameraHALswitch.zip

This zip is only for Nvertigo's LOS 14.1! Since setting this property is currently done by most roms from the init scripts, those roms wil NOT work with this zip.

The zip checks if /data/property/persist.camera.HAL3.enabled is present (it does NOT check for the value, but only for presence). If so, the property file gets removed. If it's not there, it gets generated with a value of "0". After changing the camera HAL's state, the zip reports the new state. You can flash it as many times as you want: HAL3 off -> MultiHAL active -> HAL3 off -> MultiHAL active -> and so on...

If you change your camera HAL's state (or in other words: you have flashed this zip),

ALWAYS WIPE DATA OF ALL(!!!) INSTALLED CAMERA APPS!!!

You find the zip in the Download section of OP.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
:mad:

I think both of your points are valid.

I had to learn the hard way, that there are users around, who are messing their installations by failing on this simple task.

I used the spare time of the last days,to learn about edify, and how to fake getting return values in edify from an external shell script.. ;) This was to make a simple binary switch in a flashable zip. This rom will come with working multi-HAL. If someone wants to disable HAL3 - he can just flash cameraHALswitch.zip from the download section of OP.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] dago:
This rom is based on CAF like Sultuan rom ?

Thanks

What are the differences with sultuan rom ?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
[MENTION=4800121]Sultanxda[/MENTION]'s kernel is caf based - not his rom: it's laos based (read this: https://xdaforums.com/oneplus-3/one...t/op3-op3t-unofficial-lineageos-14-1-t3588696 )

The kernel of this laos based rom is laos based. (read this: https://xdaforums.com/oneplus-3t/development/rom-lineageos-14-1-t3547024/post70781742#post70781742 )

NvertigoLOS is 3t optimized. It comes prerooted with Magisk, which means it passes saftynet with root enabled. OMS is fully supported: Substratum ready. The rom will work with microG gsm... ...and much more... You will surely find out, if reading the first 5 postings of this thread and the OP from [MENTION=4800121]Sultanxda[/MENTION]'s thread.

Camera wise [MENTION=4800121]Sultanxda[/MENTION]'s rom is more evolved. This rom has more features (microG ready, OMS, Magisk prerooted). No difference regarding stability - I think, havn't tried [MENTION=4800121]Sultanxda[/MENTION]'s rom long enough. The same for batt life.

Welcome to this thread and it's OP!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] dago:
Thank you for your answer [MENTION=4405529]nvertigo67[/MENTION] , you think a caf kernel can be changed something on fingerprint unlock speed ? Or camera ? Or it's only blobs that rom using ?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mumapizza:
Both kernels are technicaly caf based. Both are using op kernel which is from caf
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
[MENTION=6468900]mumapizza[/MENTION] is absolutly right. The days of "pure" aosp or (execlusive OR) caf are gone: caf code made it's way into the android (aosp) kernel (BTW: quite some linaro changes made their way into the main line linux kernel) and cm has decided some years (perhaps 18 to 12 months ago) to use codeaurora forum code....

I don't like questions on this very general level: reallity is much more complex then such simplified questions may suggest. I see this very often nowadays: unwanted outcomes of all kind (very different kinds) are thrown in a jar (ThinLizzy says: whiskey in the jar... ;) ), and the question suggest their is a single solution... Wake up! That's not the way the world is: different outcomes generally have multiple causes...

So my answer is: most propably NO. But I think the assumptions made in the question are false.

I'd love to discuss kernel code on a line by line basis, and if you find something improvable i.e. on the fps just drop me a note with a link to your git. But: Changing the kernel (framework, blobs, compiler, toolchains... the list could go on for pages) will solve all issues; will not happen.

(Discurs on camera: I fighted with getting the cam to OOS quality for the last 4 month. I think the problem is neither the HAL (camera.msm8996.so, proprietary binary), nor laos Snap, but some closed source additions Oneplus does in frameworks/base which offers HAL1 + only some HAL3 features to com.oneplus.camera. Since this "special treatment" is closed source, we devs can only guess here (very interesting is the discussion of [MENTION=5091734]dianlujitao[/MENTION] and a Oneplus Staff member on the camera implementation of OSS (watch out: OOS = OxygenOS; OSS=Oneplus openSourceSoftware): https://github.com/OnePlusOSS/android_hardware_qcom_camera/issues/1 )

[MENTION=4800121]Sultanxda[/MENTION]'s and my roms are different and will be - most likely - different. If you want to make an educated decission, flash both for at least 10 days each and tell us.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
UPDATE

Build 20170509

Releasenotes:

This build requires firmware OpenBeta 6 (aka ob6).

This rom is no longer shipped with HAL3 disabled, but with HAL1 and HAL3 enabled (multi-HAL). The flash routine of this rom will auto-remove /data/property/persist.camera.HAL3.enabled. This is done on EACH and EVERY flash, no matter of dirty or clean flash is performed.

It's mandatory to wipe the data (really!!! only wiping cache does NOT help) of all installed camera apps! If you want to have HAL3 disabled (like it was in all builds from the begin of February till the first EXPerimental build) flash the cameraHALswitch.zip from the Download section of this posting. If you want to go back to an enabl2d HAL3 just flash the same zip again. Always wipe the data of all camera apps after switching HAL mode!

Currently Beans Dynamic Mini Gapps are confirmed to work for clean flashes. (I highly recommend to stay with installed gapps on dirty flashes!)

Changelog:

releasetools: allow appending custom additions to updater-script. — nvertigo

releasetools: remove persist.camera.HAL3.enabled. — nvertigo

releasetools: move the injection of Magisk to device tree. — nvertigo

device.mk: don't ship Gello. — nvertigo

op3: Update decoder profiling result — dianlujitao

my_build.sh: create own temp dir for building and remove it after the build finished.

use Nathan's script for patching in OMS.

ROM: lineage-14.1-20170509-UNOFFICIAL-nvertigo-oneplus3t.zip

MD5: c2ff3896d3beab9bc295097a855495f9

Happy Flashing!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] knpk13:
Is the newest firmware included in this build? I ask because the filename in the post has the keyword "firmware" in it, but the downloaded file doesn't have the keyword "firmware" in it.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] vavill:
I decompile oneplus camera , then figure out how it works.

In OOS

will return LEGACY to let camera work under hal1 .

OOS have some callback in android.hardware.camera to implement hal3 features like RAW

This commit https://github.com/OnePlusOSS/android_frameworks_av/commit/69132657875257d67fd9262529d3e63c71e46714

Especially

This commit will give camera full parameter like OOS.

This is my mod camera force hal1 and block some OOS callback.

https://github.com/kxzxxx/android_d...156/modcamera/OnePlusCamera/OnePlusCamera.apk

https://github.com/kxzxxx/android_d...roid.manager/src/android/util/OpFeatures.java
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] hanut1:
Love your ROM but for some reason arise is not working properly even after flashing magisk module .
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
The filename of the download is true: it comes without firmware (you find ob6 firmware in the 0503 build or in the Download section of OP). I fixed the URLs display name. Thanx for heads up.

Sorry, I don't know arise. I would get a log and ask in the arise-magisk-module-thread or the main Magisk support thread.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] xontec:
Hey guys im new to this device and i like to flash a custom rom and i decided for this (thanks for your Work) but I have some question. Whats wrong with the camera exactlly I read something about HAL3 but i dont get it is it on all roms or only on this rom? Will there be a fix? And is it significant worser as the original camera app?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] knpk13:
By the way, is your ROM using the latest stable magisk version (v12), or the magisk version compiled from the latest sources (dev version) ?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
It's on all laos based roms.

Read the thread. Read the changlog. We are permanantly working on it. Did you see the posting on Oxygens HAL handling just two or three postings before yours?

Hmm, did you read OP at all? This rom ships WITH OnePlusCamera...

I completly understand, that it's time consuming to read - but if you want to know, you need to take this time. And understanding the HAL handling is not trivial at all.

I'm just the dev, I'm no photographer - I'm not qualified to judge the pictures quality.

It's source build from git at 5th of April. I belive to remember it's v12 + one or two commits. Sadly there is no tag for v12, so I'm not sure. But I'm sure it's before the daemon unifying.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] rosco_pc:
Sorry but the OP does not contain the OB6 firmware
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] xontec:
Thanks for your answer yes i was reading your posts and the rest on the last few pages but i got confused. Sorry didnt want to waste time or over ask the same questions.

But i dont get it whats the problem directly with it if it get worser or whats wrong with it but ill read me trough and take sufu

Ty
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Dude, you made my day!

I have done this:

https://github.com/nvertigo/android_frameworks_av/commit/0336495c64b5cd7f3085888a968791bde7ace41f

https://github.com/nvertigo/proprie...mmit/40f4026e736f8ccb095256934658566f51dc331b

https://github.com/nvertigo/android...mmit/41406641d7d505e3083955e69fff3b2515354f02

https://github.com/nvertigo/android...mmit/a7e13fe14ea220021d6bd44cb215e9a5ef8b0454 (cosmetics - win suckz)

What should I say? IT IS WORKING!!! OOS cam has raw AND hdr. HAL3/api2 still usable by i.e. OpenCamera.

Only issue remaining: all apps using HAL1 crash on first ffc shot after reboot. This could be zsl... testing atm.

THANK YOU VERY MUCH!

Is it ok for you to use the above commits referencing to your authorship? Do you plan to update OPCamera and OPCameraService when OnePlus updates them?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I've uploaded them, but forgot to add the link - thanx for heads up. Will be fixed asap.

EDIT: fixed in OP.

Firmware

OxygenOS OpenBeta6: https://drive.google.com/open?id=0B_f72wz8rwc6Z0V5UTUtcTg0a2M

Renamed blobs (for use with custom kernels build for unifie roms)

OxygenOS OpenBeta6: https://drive.google.com/open?id=0B_f72wz8rwc6c1BnMFpaOXVUZ0E
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] xontec:
Nice great work :D so my questions are gone
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] vavill:
Do it whatever you want as you wish.

I will update it as long as OOS update.

RAW still dont work.

I still try to add callback to android.hardware.camera to get RAW working.

Please wait a few days, I will make camera full functional.

Can not find a good way to over-write frameworks/base/core/java/android/hardware.

Can you suggest some method to over-write?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] technotravel:
I dirty-flashed the latest ROM, but without updating the firmware (wasn't there yet). Everything seems to work nicely (OOS camera - which only showed a green screen before, and browser doesn't crash anymore), so I wonder whether I still need to flash the firmware?

Btw, stupid beginner question: how does one wipe the camera data? Couldn't find such thing in twrp.

Thanks for all the work!

Chris
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Take your time.

Just realized: the switch is in settings, but no raw pics are saved. Anyway: it's working as good as before (with disabled HAL3), but now leaving HAL3 active for other apps. I take this as a big towards full functionality.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Lada333:
Reboot/restart to fix camera green image, and yeah, it's best to always be on the latest recommended firmware.

To clear *any* app's data, go to App info, storage, and there clear data.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Thank you.

Made my day - second time the same day!

To my knowledge you can only overlay values exposed in the frameworks/*, you can't overlay the source code itself - but I may be wrong, since I havn't tried. Or you carry a complete copy, like you have done with libcameraservice.

For Magisk, MicroG and OMS I do it the good old "brute force way":

Fork, edit on top, push to a second remote (aka kxzxxx/android_frameworks_base). You can use your own fork by editing .repo/local_manfests/foobar.xml or by still syncing against laos and "git am" your changes on top (as I do it here: https://github.com/nvertigo/local_manifest/blob/cam-test/my_pick.sh).

What looks like a brain fart on a first glance ensures, that my proprietary (still not or never ever in laos upstream) changes are applied always on top of the current laos status of the source tree. I also ensures, that I forget to rebase reguary, because I would see the merge conflicts while running my_pick.sh... ;)

Not elegant, but effective. ;)

On the latter point: you have to watch for upstream changes every time before you start a build for i.e. libcameraservice.

BTW: I think we don't need this:

https://github.com/kxzxxx/android_d.../blob/cm-14.1/rootdir/etc/init.target.rc#L210

...to enable HAL3. In my oppinion it's best to not have this prop at all. If you need it, it's in the wrong section: it has to be in "on post-fs-date", because in "on boot" /data isn't mounted and the prop file is never written... you can test: delete prop file, reboot. No prop file. But if you ask with getprop it is there. That's a semi-persistent prop... *lol*
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
In the booted rom, not in twrp - regarding the original question.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Lada333:
Yeah right, for some reason I thought it's obvious that "app info" is available when booted, not in twrp, thanks for correcting me.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] chrisc93:
Instead of applying

pushd frameworks/av
#OnePlus OSS addition
#CameraService: addition from OSS for OnePlusCamera (found by Kevin Mckee <kxzxxx@gmail.com>)
wget https://github.com/nvertigo/android_frameworks_av/commit/0336495c64b5cd7f3085888a968791bde7ace41f.patch -O - | git am
popd

you could simply run repo start BRANCH_NAME frameworks/av and then each time you do a repo sync your commits in BRANCH_NAME will be rebased on top of the Lineage commits. Just food for thought that makes building a little easier.

I do this with Resurrection Remix and also have backups on my github page of the repo topics I have started. Also nice work with the cam! I think I'm going to remove snap from my builds now haha

EDIT: I guess the nice thing about the way you have it is that other people can easily get your code on top so they can build exactly as you do.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] vavill:
Thanks for your advance.

Haha, I just treat github as a backup tool.

Just focus on libcamereservice and org.ifaa.android.manager.

I will clean up code once I have done all the work.

Today I get Automatic Exposure (AE) work

and get DNG data successfully, but it goes wrong
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
That's one of the reasons. The other: if you repo start BRANCH_NAME the gits are no longer in a detached HEAD state, but locally checked out to branch name.

Let's take a look at "repopick -r network-traffic": if I repo pick to the checked out branch the commits are saved to the branch. If some changes in the topic network-traffic are updated, I have to reset the branch in all projects the topic has changed files in. With my method the detached HEAD (which contains an old version of the topics patch sets) is just thrown away and the git is back to upstreams HEAD.

Most propably I'm missing something, but - at least - it works (as well for other homebuilders, who have not my local unpushed changes).

The cleanest solution would be rebasing all patched gits with all changes, which are not repo- and/or cherry-picked, use them in local_manifests and apply only the pickable changes afterwards with a script.

For me it seems less work to rebase the gits only if merge conflicts show up, then doing it every time - again: I may miss something here.

I know no other way to ensure, that the homebuilders will get current upstream source base (which doesn't mean there is no other way, but I havn't found it yet.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] spida_singh:
Is anyone having issues with the flash not working properly on oos cam goto take a picture in the dark and it pre flashes but doesn't actually flash when it takes the picture, happens on both auto and forced flash
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Lada333:
Yeah, happens sometimes, try toggling between auto flash, and flash always on, or if possible, pre-focus on something by tapping on it.