yashsingh1/xdaforums huggingface dataset:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] goosebickel:
I had the same problem, toggling flash on/off didn't help. So I disabled hal3 with the switcher zip from op, and flash works fine now with both camera apps that are built into rom.

Great ROM, thanks again for building.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Thanx for your kind words.

Hopefully the next build (later today) will work with HAL3 not disabled and OOS-Cam working like with disabled HAL3.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] manikchathli:
Awesome ROM!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
UPDATE

Build 20170515

Releasenotes:

This build requires firmware OpenBeta 6 (aka ob6).

This rom is shipped with HAL1 and HAL3 enabled (multi-HAL). The flash routine of this rom will auto-remove /data/property/persist.camera.HAL3.enabled. This is done on EACH and EVERY flash, no matter of dirty or clean flash is performed.

It's mandatory to wipe the data (really!!! only wiping cache does NOT help) of all installed camera apps! If you want to have HAL3 disabled flash the cameraHALswitch.zip from the Download section of this posting. If you want to go back to an enabled HAL3 just flash the same zip again.

Always wipe the data of all camera apps after switching HAL mode!

Compared to the changes in the builds from the last two or three weeks, this one has only very few changes (of course I synced to laos):

I've put in the modded versions of OnePlusCamera and OnePlusCameraService edited by [MENTION=4979070]vavill[/MENTION] (many thanx to you!!!). Together with a small change in frameworks/av I hope/think/belive OnePlusCamera is working like before with HAL3 disabled (including the issues: crash on first ffc shot, no saving of RAW-images, though the option is there).

Before digging deeper in [MENTION=4979070]vavill[/MENTION]'s changes to libcameraservice (frameworks/av) and trying to port them to our rom, I want a defined (and working... :angel: ) status. I hope I have achieved working multi-HAL (HAL1 and HAL3 useable the same time) without breaking anything else.

For this

I NEED YOUR HELP!

Please be so kind (and smart: it's the rom you are using as daily driver - you want that as stable and functional as possible, before hacking in the proprietary OnePlus additions (*)) to test and check each and every aspect of each and every cam related app:

Camera apks: all available modes and options.

Apks relating to camera like snapchat.

Bar- and qrcode scanners (also inside apps like WhatsApp web).

Video call apps like Hangouts, Facebook and WhatsApp.

Everything, you can think of...

Everything, I have forgotten...

This is really very important for me: to know what is working (and what is not working)!!! Pleasemassist me on this! If you find something broken - make a note every time. After these tests flash the cameraHALswitch.zip, delete the data of all apps using the camera and test again.

I know I ask to spend your time and time is a rare good! Remember: you spend this time to help me improving this rom. Thank you for spending your time on making this rom better!

Currently Beans Dynamic Mini Gapps are confirmed to work for clean flashes. (I highly recommend to stay with installed gapps on dirty flashes!)

Changelog:

OnePlusCamera: add modded Camera and CameraService. — Kevin Mckee

CameraService: framework/av: libcameraservice: addition from OSS for OnePlusCamera (found by Kevin Mckee <kxzxxx@gmail.com>

make sure jack-server is restarted in created TMP. — Nvertigo

ROM: lineage-14.1-20170515-UNOFFICIAL-nvertigo-oneplus3t.zip

MD5: b9d5b33d844d578dd41f49f6d1af6af1

Happy Flashing!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] vavill:
Thanks for you bring us this awesome rom.

But I make a mistake, OnePlusCameraService is unnecessary.

Latest commit fix almost everything.

If you have spare time, take some time to look into it. ;););)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Thanx for reverse engeneering that OnePlus code!

When putting in Camera and Gallery (weeks ago - the unmodified ones), I had checked for CameraService and found out it's not needed.mWhen seeing you removed some callbacks from CameraService as well, I thought it is coming in play again... ;)

Shouldn't be a problem for now - I'll remove it again before the next update. Thanx for heads up!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] vavill:
Latest commit fix almost everything.

If you have spare time, take some time to look into it.

Also can you take some time to optimize the meta data AsShotNeutral(SENSOR_NEUTRAL_COLOR_POINT).

RAW produces green tint because of this.

Besides this, I use dx and desuger to spend up building.

If you interested, you can check it out my repo.

Maybe a year later, I will work for OnePlus in shenzhen.:laugh::laugh::laugh:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Nee... Inefficient attitude. After reverse-engineering the complete OnePlus specific parts in frameworks, libs and hal, you decide to write it from scratch unleashing all hardware capabillities of our 3T/3s. qcom hires you to make their reference implementations for their SoCs... :cool::cool::cool:

I'll look in your work. ATM I spend more time on this rom then I can afford... :( To understand your changes, their implications and how to implement them "minimal invasible" (since I don't belive, we get it upstream anyway), I need a block of time (not 20 minutes here and 5 minutes there.

Anyway: if the the tests I've asked for, show that the working apps/scenarios outweigh the broken ones, that's a milestone. Of course we have not solved all camera issues and hassels, but we have a - obviously better then its repute - working HAL3.

My own tests the last days let me hope, that forcing an unspecified hal version in a cameras request to HAL1/api1 will solve many issues with not forcing HAL1 at once...

I call that a milestone in evolving this rom's camera expirience! This two lines from OSS you pointed me to, caught my focus immediatly... thanx again. (cross fingers, anyway... ;) )

If anybody wonders, why a working HAL3 is so important for me: get OpenCamera to get an idea of what our hardware is capable of if HAL3 is used. And: current android OSs on current hardware should/must support HAL3 for cameras - it's a matter of >android5.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] goosebickel:
Did a few tests that involve the camera. Everything I will ever use works well.

Clean install with beans.

What's app - taking pictures through what's app and sending them works, video chat works.

Downloaded a barcode and qr app, all worked well.

Tried google goggles, didn't want to play nice. App booted up, but once I pressed "take photo", nothing happens, no error message's either!

I haven't used goggles in a while, so I couldn't tell you if it worked before experimental builds or not.

It won't stop me using the ROM either, just the only app that sprung to mind that uses the camera!

Attached 2 cat logs, one with both hals going, one with hal1 only.

Hope it helps.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] yannmrt:
Just question opencamera is better than OSS?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
UPDATE (ob7)

Build 20170518

Releasenotes:

Would you please remember my request for help from the last update posting? Thank you very much.

This build requires firmware OpenBeta 7 (aka ob7). Since this is the first build based on ob7 blobs and firmware it is included. ob7 firmware and uniblobs can be found in the Download section of OP.

Changelog:

update blobs and firmware from OxygenOS OpenBeta 7.

blobs: remove OnePlusCameraService. — nvertigo

media_codecs_performance.xml: update from OpenBeta 7. — nvertigo

op3t: init: update to OxygenOS OpenBeta 7 build fingerprint. — nvertigo

init: revert filename changes. — nvertigo

init: remove QVOP service from init.target.rc, too. — nvertigo

op3: Remove QVOP service — dianlujitao

op3: Enforce vendor tree presence — Christopher N. Hesse

drivers: staging: Update qcacld-2.0 driver — Luca Stefani

Merge tag 'LA.UM.5.5.r1-04600-8x96.0' of https://source.codeaurora.org/quic/la/kernel/msm-3.18 into HEAD — dianlujitao

ROM: lineage-14.1-20170518-UNOFFICIAL-nvertigo-firmware-oneplus3t.zip

MD5: 2a3710cd0fa1c84a16efa1647049fce0

Happy Flashing!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I've never used OSS cam on this rom. BTW: OSS cam is nearly unmodified SnapdragonCam and our Snap is much more adjusted to laos. I really think OSS cam is a bad choice on this rom - perhaps it's better on an OSS build...

When I wrote: "get OpenCamera to get an idea of what our hardware is capable of if HAL3 is used. " my intention was to keep minds free and open - and not influenced by my oppinion. My answer is: "get OpenCamera to get an idea of what our hardware is capable of if HAL3 is used. " ;)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] coalee:
Dirty flash to v0518 without any problem. Thank you very much nvertigo67
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] lombyzgz:
This ROM is really smooth and I didnt found any bugs in the cameras.

Only burst mode in oss cam, that only can do 18/20 photos, but like others roms...

I miss something stuffs that have other Roms but this look more stable and fast. I will check battery life!

Thanks for your work!

Enviado desde mi ONEPLUS A3003 mediante Tapatalk
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
OSS Cam?

Some here seem to be confused.

OSS: OpenSourseSofware: https://github.com/OnePlusOSS

OOS: OxygenOS

The cam included in OSS is SnapCamera - this IS NOT SHIPPED with this rom.

The additional cam included with this rom is a modded version of the closed source apk from OxygenOS. Most users call this "OOS Cam". Remember: OSS != OOS.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] lombyzgz:
Hahah, sorry I mean OOS cam.

Enviado desde mi ONEPLUS A3003 mediante Tapatalk
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] DeadPicsel:
I've had to go back to using stock OS, due to the crackling noise when using my wired headphones.

It's a shame really as I really wanted to use LineageOS.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Does anybody know, at what rate dash is charging? I need to set a treshold (in mA) to tell charging from fast charging.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] t-shock:
Ampere app shows me around 3000-3200 mah with pure stock

(but the dash charger says 4A)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Jole7:
Hi! I've seen 3.760 through EX kernel manager apk OP3 device
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Run out of Thanx. Many Thanx to both of you!

I have read the 4A on the charger, but I needed real world numbers (or should I say facts instead of alternate facts... ;) ), what I guess from your numbers and my own numbers (dc as well as car dash charger) was allways over 3000 mA but never over 3600 mA) that I'll try a treshold of 2900. With my samsung tab s charger I (chargers label say 3000 mA) I get on the 3t about 2350 mA - so 2900 seems a nice treshold to me(*). What do you think?

(*)at least if we want that fast charging indicates dash charging.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] m0d hipp¥:
Has anyone run into any issues with the setup wizard crashing after flashing the new rom?

Here is what I did...

- Upgraded twrp from 3.0.3-1 to 3.0.4-0

- Made a full backup and transferred to PC

- rebooted into recovery and wiped all data, cache, system

- flashed the new rom "lineage-14.1-20170201-UNOFFICIAL-nvertigo-oneplus3t.zip"

- immediately after, I flashed gapps nano

- rebooted into system

and this is where setup wizard displays it has stopped. I tried clearing cache and rebooting and still same thing. Attaching a pic of the error.

EDIT:

Fixed, see 2 posts down for the fix.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] t-shock:
Other mirror for the latest build

Thank you so much for your work

https://mega.nz/#!jRdB1aRZ!-QzqNBaP_7QWZPxpuFQz1X3a7IghVy21xLDqyTlJew8
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] hacksome:
Exact same problem for me too.

[Fixed]:: I tried again without using the GApps linked in the OP. Instead I used the one from GApps.org directly. It worked.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
I couldn't reproduce this. I tested youtube and google music for about 20 seconds each.

Do you only have this in specific apps or after a long time? I use the first build from 20170227 still, since my download is busy getting android sources. which build were you running? Please, if this is an issue, we sure want to look into it. But first step is reproduce the issue.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] DeadPicsel:
The crackling noise wasn't on my end. It was other people that were complaining they could a crackling noise when on a call when using headphones.

The issue went away with the next boot fix but came back with the build that had new commits merged and the boot fix in the built zip.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
gapps can be buggy. they are build anew each day. not all of them are stable.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] hacksome:
Camera NX working much better.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
Oh. I try to reproduce this - tomorrow, when I can call somebody (maybe [MENTION=4405529]nvertigo67[/MENTION]? :) - I have some simple headphones with microphone from my ps4 pro flying around somewhere - hope they work.

Also I should upgrade to latest build then. Maybe I take a break from getting android sourced and download 20170201 build instead. I can probably confirm that issue by tomorrow.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] m0d hipp¥:
If I could make some suggestions.

1. The option tfor "Protected Apps" found in Settings --> Privacy - I love this option, however it seems to default to using a pattern as a source of security. Would it be possible to implement the fingerprint biometric option for this if you have that set? I have my fingerprint scanned to unlock the phone, and it would be nice to be able to use that for this feature.

2. Would it be possible to provide multiple "view" options for the app drawer? For example you have it sorted alphabetically using list view or something. Would it be possible to add an option for the standard icon lineup? (hope this makes sense)

3. If you have the fingerprint scanner enabled, would it be possible to use that as the initial login after a reboot without having to type in a pin?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
[MENTION=4405529]nvertigo67[/MENTION] didn't you include the sRGB fix? Just updated and it's still as before and not like in the sweet screenshot I saw yesterday

---------- Post added at 12:16 AM ---------- Previous post was at 12:12 AM ----------

1. Might be worth looking into. Still downloading the sources. Very slow internet...

2. You think it's worth investing time? How many people use stock app drawer - especially on custom Roms? (I use pixel launcher and consider switching to action launcher if really the Google now integration works.)

3. I guess the intention is added security, since you are asked only when doing changes like system upgrades. Anyhow, I also want to know. Will check sources
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
I just figured out, that Google Camera is working on this ROM. Quiet a surprise, since it doesnt work on OOS nor on unified builds last time I tested. (Google Camera is loved for its photo sphere ability)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] freepenguin84:
So, now that the 3T will be officially supported by Lineage itself (https://review.lineageos.org/#/c/158508/), what is the advantage of this build? Or doesn't it change anything in this matter?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] dannycardoz92:
Yes that is a nice surprise! :) Does the front camera work as well?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
yes, it does.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] dannycardoz92:
Thank you!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Thanx for the feedback.

If you look in Playstore, you'll find that you are not alone... ;) All reviews for current android versions are complaining about not beeing able to take stills (checked May's reviews only). Last update is from 2014... I don't think we should consider goggles an "photo reference app"... *lol*
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] goosebickel:
Lol, trust me to find the one thing that was nothing to do with the ROM! :silly:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] lombyzgz:
It's possible fix home button when I hold it for turn off the screen? When I wake up again the device, the first push don't work. Thanks!

Enviado desde mi ONEPLUS A3003 mediante Tapatalk
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] hanut1:
Finally Got ARISE work on this ROM but with selinux disabled
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] tim.:
I can't disable WiFi ... even in airplane mode. Anyone else have this issue?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] lombyzgz:
Nope, did you flash new firmware?

Enviado desde mi ONEPLUS A3003 mediante Tapatalk
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] tim.:
I did ... dirty flash over the last release.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] coalee:
I also did dirty flash the latest version. My airplane mode is working without any problem.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
*deleted* oms / theme support was broken. Download removed.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] 186Y:
I dirty flashed over 170518 build and 7.1 OMS isn't showing `build and enable` or `build and update` will attempt a clean flash later and report back. I restored to the 170518 build in the meantime.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
No need to test, you were right. No idea what happened yet. Oms isn't working.

Removed download for now.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mumapizza:
Clean flashed :| oms not working
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
So, i double checked, why OMS is broken. I did everything right - or better as I should do. This seems to be a new issue between OMS and LaOS.

Well, 24 hours have passed, I just build again and hope it fixed itself.

---------- Post added at 10:10 AM ---------- Previous post was at 09:29 AM ----------

UPDATE: OMS still not working.

Until this is solved, I wont upload further builds.

If you dont care about OMS and theming, and you just want a new build, take the one from yesterday: https://drive.google.com/open?id=0BxQj0GFNkzYhcTVibk1JY2d6Wms

I link this, because I know, some people just need a updated ROM every few days. This ROM is working as expected except themes/OMS not working. You must decide yourself if you want it or not. You have been warned ^^
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Don't use long press for lock device... ...or press home twice.

This is so minor, it's not on my list. It will go to my priority list, if the big issues (i.e. cam, ims-settings) are ironed out. Asnstated before: I'm very low on time the next months.

Wow. Great news! Thanx for reporting.

Do you use arise as magisk module?

Yes: get the denial log (reboot device, log in, get a root shell (adb or terminal), type

logcat -d | grep "avc:" >/sdcard/Download/denial-log.txt

. Give this to the module dev (not the arise dev) and ask him to inject the neseccary rules in his module.

No: make yourself a magisk-module for arise, which applies the rules to allow the denials.

On my build it's working. After a dirty flash substratum was crashing all together - I can't even check the settings because of this early crash. Some minutes ago I received a substratum update from playstore. After deleting substratum's cache, it works like charme again.

Would you all please check the version of substratum apk; it should be "seven hundred thirty one (731)". Also check if deleting cache will solve the issue.

If the update is not the root cause, but the build is broken (need feedback to the above questions to tell), I'll push a working one as soon as possible.

[MENTION=3044422]mad-murdock[/MENTION]: clean or dirty build? W/o ccache? If yes: cleared ccache? resynced and reapplied patches?

[MENTION=535343]all[/MENTION]: Has anyone looked in the logs? (Make saving logs as soon as an issue occurs your second nature: it's easy to delete an unused logfile, but it's impossible to get logs from the past boot... ;) )

OT: Did you know our rom is unstable and has bad batt life? I didn't know till this helpfull and friendly user pointed it out to me: https://xdaforums.com/showpost.php?p=72382758&postcount=6

Considering this posting, I think it's time to thank all active users here! With less users like you, and more users like him, I wouldn't be able to make this rom. Not to mention encouragement, ideas and the way of communicating here in this thread. Thank you!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
CCache on, not deleted upfront. Resynced and reapplied patches both yesterday and today as usual. Last time I did so on 0519 and created a properly working build.

Running substratum 731 at least since yesterday, wiping cache does not help, substratum claims, it does not find OMS and only works in legacy mode.

Will try building with empty ccache now. I doubt it helps, but maybe the underlying problem was solved between my build this morning and your test build later today - since it works for you NOW.

Edit: I do the pulling and patch applying with this script for a while: https://pastebin.com/2am5JsPd - Since it's always the same procedure, and I check the output, I am quiet certain I didn't mess up.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Me neither. I'm guessing. I have no logs, since it's working for me. Look in your logs.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
Dang, building clean didn't change anything. OMS still not working for me. Will check logs and double check my build process tomorrow morning. Too late now, friends moving in to - well - play games and stuff.

But right now, REALLY got no idea how it can work for you and not work for me, doing exactly the same stuff. Last build I did before 0522 was the 0519 (private, unreleased) and OMS worked fine.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] m0d hipp¥:
Nice job guys! I just uploaded the 2 latest updates on the 2nd post.

I've been hearing a lot of things with regards to the "substratum" theme. I've never used this before myself; but I've been reading about it a bit and it seems like a nice feature that's added to this rom now.

I'm slightly cringing asking this question because I know I asked it before... with substratum being integrated with this rom now, is it possible to adjust location of the battery percentage now? I know this is a really small thing, but I guess it's a little bit of an annoyance to me seeing it on the right side of the battery. (This is because the time is right next to the percentage and I feel it's cluttered up). Once again, I realize this is a personal preference, but is there any way to adjust the battery percentage to display on the left side of the battery icon? If there is a mod for this or a theme for this, I'd be willing to pay for it. I just like a clean, stock look and feel to my phone and that minor tweak would really make my day.

Thanks in advance guys and keep up the amazing work!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
maybe you try this commit. it sounds like this would fix the problem quoted above.