yashsingh1/xdaforums huggingface dataset:
[LG V20 Themes, Apps, and Mods] dfogelstrom:
[MENTION=1048155]illwafer[/MENTION] what is the build.prop line I can add for adaptive brightness? Just wanted to be sure. H918 WETA ROM here. Thanks!
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
Id leave the clock as is to be honest as id rather add spaces then have it pushed too far to the left and be unable to adjust to fix..

B11 app installed without issue for me btw.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Such weirdnesses :p

I did misunderstand. I'll leave spacing up to the user (the XML has space elements too, so I got confused.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
This is what "default" center looks like.

Its to the left of signal bars by default for center.

But this position changes depending on clock size and if you have % on , bluetooth etc. So unless center can be a dynamic position that is defaulted to true center depending on what your layout is then there would be no point to manually space it out as it may cause the clock and other items to get forced too far left under those circumstances.
[LG V20 Themes, Apps, and Mods] Zacharee1:
New app version: B12.

There's not much new here. It's mainly some fixes. I've added a switch at the top that will hide mods that need my ZIP when it's disabled. I'll see if I can find a way for actual detection (maybe a dummy app flashed with the ZIP). I also made it so the app doesn't always get root access on launch, which means fewer annoying toast messages.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
Any chance of building in some reboot options in like the settings tab or a additional page for reboot options?

Like quick reboot, reboot recovery, reboot download?

Maybe a option to run scripts in shell like busybox?

Just thinking of things things it could also have..
[LG V20 Themes, Apps, and Mods] Zacharee1:
Hmm. Shouldn't be very hard.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
maybe a convert to system/priv-app script for the app hehe

1 thing to keep in mind here, is exceeding 50kb apk size will require additional api for google once on playstore as it would require the additional data to be installed from servers after 50kb and your app would be the .stubapk at that point. Its at 40kb now so some things may rock you over that and then require re-working it for the new api or thinning redundancy to achieve 50 or less.

Just food for thought for the future of ModControl =)
[LG V20 Themes, Apps, and Mods] Zacharee1:
Huh? The limit's 50MB, isn't it? My app is 10.5MB right now.

Although that does give me an idea. I could probably make another app that replaces the flashing method to install. A reboot would be recommended, but I don't think it'd need to be done. I'll have to look into that data-download API.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
im not sure why i thought it was 40kb, i probably was thinking the zip size for the mods,

but ha good idea also.

i was thinking of porting the app to magisk as a module to download and do it that way also.

heading to wally-worlds as we speak also to get a prepaid card for google too! got busy this morning at work and havent gotten off the floor yet
[LG V20 Themes, Apps, and Mods] Zacharee1:
Well I've gotta finish it first :p I think the Play Store is the goal for now.
[LG V20 Themes, Apps, and Mods] netgar:
So that Mod doesn't work with Tilde's ROM?
[LG V20 Themes, Apps, and Mods] Zacharee1:
He might have made some mods to SystemUI that need to be there.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Unfortunately (in this context), [MENTION=1325580]Tilde88[/MENTION]'s ROM is deodexed. Since my mod uses odexed apps, it'll cause the crash NSS users have experienced. It should still be possible to use the app, as long as you disable the "Mod Installed" switch, as the color mods use the already-existing APKs on the device. I just can't maintain two versions (odexed and deodexed), which means deodexed users are out of luck regarding the AOSP signal bars and 3Minit mods.

On a lighter note, I have an idea to get the 3Minit Clock toggle working in the AOD. I've been using some Secure Settings edits and Smali hacks to toggle the current 3Minit mods (since making separate XMLs for every possible combination would be hell), but I don't need to do this for the AOD clock. I can keep the 3Minit Battery layout in both XML versions, and have one with 3Minit Clock and no Stock, and one with no 3Minit Clock. It'll make the app size a little bigger, but I'm still well under the limit.

EDIT

I can use the XML method, but every time the switch is toggled, the AOD signature color will be set to white again. It's not a big inconvenience, but I want to try to fix it.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Well, it still happens: the stock clock overrides 3Minit. I've noticed some other XMLs handle the clock as well, but my changes don't seem to be doing anything. I'll have to keep looking.
[LG V20 Themes, Apps, and Mods] fogame:
Sir! Excellent work.

Using this on [MENTION=4731846]Team DevDigitel[/MENTION]'s stock-ish rom. When I try to disable AOD or anything for 3minit it force closes the app. Also not sure but for some reason I can't set it as system app. Been working with the dev on that one but TB won't convert it.

Thoughts?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Looks like com.lge.systemservice.core.miniclock is what's doing things. I just need to find what package that's in.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Manually move the APK to /system/priv-app/ModControl/. That should work.

The app writes to Secure Settings, so unless it's in priv-app, it'll crash. I should probably add a check for that.
[LG V20 Themes, Apps, and Mods] fogame:
Sorry for asking....Long day with the CIA leak...But where is the app that I need to move? Is it on my phone already or can I download the app and put it there?

Edit: found apk but didn't have Mod control folder in system/priv-app
[LG V20 Themes, Apps, and Mods] Zacharee1:
Uninstall the app, download the mod ZIP, open it, remove everything under priv-app and app except ModControl and flash that. Should install it correctly.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
Sorry i had some things come up at work..

You need to mount system as rw. Dl busybox by jrummy and go to scripts "its the tab on right" and choose the remount script and run it as root by clicking it and clicking run. Make sure you run it as root.. do what you need to do..
[LG V20 Themes, Apps, and Mods] fogame:
I must not be doing it right. I downloaded the stable mod and flashed it. Still same. Lol my brain is shot. I'm not too worries. I can wait.
[LG V20 Themes, Apps, and Mods] Zacharee1:
I'll make you some better instructions once I'm home.
[LG V20 Themes, Apps, and Mods] fogame:
No worries lol. Imy brain is shot due to WikiLeaks and trying to fix things.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
Thats the issue and why i built in this mod in for us lol

The flashable zip wont put the app in to system/priv-app. I was gonna write a script and try my own zip but i didnt. The phone just needs to be put into rw/ for titanium backup to work.

Few ways to move a app to system. To be honest the app i use has a exotic root option for systemless root.
[LG V20 Themes, Apps, and Mods] fogame:
Lol gotcha. What app do you use to move stuff? Rw/ usually I do that through ADB but from the phone?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Thanks to [MENTION=4731846]Team DevDigitel[/MENTION], the Mod Control app is now in the Play Store!

If you already have the app installed, you'll have to uninstall it first. Once you install it from the Play Store, go to /data/app/com.zacharee1.modcontrol/ and move (NOT copy) base.apk to /system/priv-app/ModControl/. Rename it to ModControl.apk. Set the permissions of the ModControl folder to 0755 and the APK to 0644. I'm going to make something to automate this process.

https://play.google.com/store/apps/details?id=com.zacharee1.modcontrol
[LG V20 Themes, Apps, and Mods] fogame:
Don't have /system/priv-app/ModControl/ folder.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Create it :p
[LG V20 Themes, Apps, and Mods] fogame:
Lol figured as much. Sorry still fried brain.

---------- Post added at 05:00 PM ---------- Previous post was at 04:35 PM ----------

Reboot after process done?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Yeah.
[LG V20 Themes, Apps, and Mods] fogame:
Excellent work. I got it working.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
Google Play

Yey :)
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
Man i'm just happy as could be for this project!

Kudos for the hard work bro!
[LG V20 Themes, Apps, and Mods] Zacharee1:
New Beta build out! Go subscribe to Beta releases if you haven't already.

I've reworked the design to be a bit more intuitive (I hope). It was a pretty big change, and I know I've missed a few things, so report any problems you find.

Now I can start work on the Installer app.
[LG V20 Themes, Apps, and Mods] dfogelstrom:
Porting to Magisk would be an awesome idea!!
[LG V20 Themes, Apps, and Mods] zplit:
Using beta but color won't change at all now
[LG V20 Themes, Apps, and Mods] Zacharee1:
Did you restart SignBoard?
[LG V20 Themes, Apps, and Mods] zplit:
Yes bro
[LG V20 Themes, Apps, and Mods] Zacharee1:
That's strange. Are there any errors?
[LG V20 Themes, Apps, and Mods] zplit:
No none.
[LG V20 Themes, Apps, and Mods] Zacharee1:
And you've tried rebooting? Maybe delete the app from priv-app, redownload it and move it back.
[LG V20 Themes, Apps, and Mods] zplit:
What's the best app to move the app from what place to another?
[LG V20 Themes, Apps, and Mods] Zacharee1:
I used /system/app mover. It puts the APK directly in priv-app.
[LG V20 Themes, Apps, and Mods] zplit:
Should I delete the old modcontrol or just update from the playstore?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Delete, download again and move it.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Did it end up working?

---------

Because of all the 3Minit Clock stuff, and getting the positions right, I forgot to actually make the new positions able to be hidden. If you have the clock in the center or on the left, you'll probably notice that it won't go away when you disable the Clock option in the app. I'll fix this and put a new mod build out.
[LG V20 Themes, Apps, and Mods] Zacharee1:
New mod build uploading now. Also a new Beta app that actually has an About page instead of just a link.
[LG V20 Themes, Apps, and Mods] hickmanje2:
Clock gravity center is much more top aligned after 3/11 mod update.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Well I had to put the elements into LinearLayouts so I could hide them, and LinearLayout tends to screw with layouts. It's strange, though, because I have my gravity centered as well, and I didn't notice a change. What if you set it to bottom for now? I'll work on it after I get a prototype of the Mod Installer app up.
[LG V20 Themes, Apps, and Mods] hickmanje2:
Thanks for clarifying. Bottom align works with font size boost. Just opted for flashing 3/8 again since it worked well for what I wanted. Thanks for all your hard work!
[LG V20 Themes, Apps, and Mods] zplit:
I give up lol. I was trying to get the old one to work but nothing happens. K might flash a clean ROM and try again.
[LG V20 Themes, Apps, and Mods] Zacharee1:
That's a good idea. I'd like to help, but idk what's wrong :p

Maybe you could test out the Mod Installer app once I finish it.
[LG V20 Themes, Apps, and Mods] zplit:
I'm sure the problem is on my end bro, the mod was working perfectly so I know for a fact that is not the mod. And by the way thanks a lot for ur hard work, is just great stuff.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Anyone willing:

I've completed a first version of the Mod Installer app. I need testers to try it out and see if it works: https://www.androidfilehost.com/?w=files&flid=158327
[LG V20 Themes, Apps, and Mods] Zacharee1:
Forgive my noobiness but, huh?
[LG V20 Themes, Apps, and Mods] Negan:
Sorry its called Android device monitor. It's a feature in android studio thst uses adb and takes a screenshot and you can click on stuff and it can tell you where the asset is defined
[LG V20 Themes, Apps, and Mods] Zacharee1:
Oh that's interesting. Can you believe I've been doing this all with FileSeek, APKTool, Explorer and Brackets? :p
[LG V20 Themes, Apps, and Mods] Zacharee1:
So I can get a UI dump of the phone, but it doesn't record any statusbar elements.
[LG V20 Themes, Apps, and Mods] Zacharee1:
OK, I got the ID, but it's nothing new.

com.android.systemui:id/data_inout
[LG V20 Themes, Apps, and Mods] Negan:
I say just move the icons around a bit instead of chasing a needle in a hay stack with such little to gain
[LG V20 Themes, Apps, and Mods] james_pnut:
Excuse me for my question I just started to introduce myself to theming on the lg v20. But back to the questions to you add color to the icons with a certain hex color
[LG V20 Themes, Apps, and Mods] Zacharee1:
Where do I do that though? I've used `android:tint`, `android:fillColor`, `android:backgroundColor` in the XML with no effect.
[LG V20 Themes, Apps, and Mods] james_pnut:
That's what I'm trying to figure out. After you decompile the apk in what folder did you change the individual icons because I know how to change the colors with a little time.
[LG V20 Themes, Apps, and Mods] Zacharee1:
The icons are in `/res/drawable-xxxhdpi-v4/` and the T-Mobile ones include `tmus` in the name. But recoloring the icons does nothing. The data inout arrows are already black in the PNGs, and changing them to white has no effect at all. There's something in Smali that's force-tinting the `data_inout` white (that's the ID for the data arrows).

It looks like the relevant files include these:

- /res/layout/mobile_signal_group.xml
- /res/layout/signal_cluster_view.xml
- /res/values/public.xml (to get the hex integer IDs for corresponding XML IDs)
- /smali/com/lge/systemui/LGTelephonyIcons.smali
- /smali/com/lge/systemui/statusbar/SignalClusterView$PhoneState.smali
- /smali/com/lge/systemui/statusbar/SignalClusterView.smali

But since I don't know how to read Smali, I don't know what I'm looking for.

I did find this in SignalClusterView$PhoneState.smali, relating to the ID for `data_inout`, but I don't know how to read it:

.line 867
const v0, 0x7f120224

invoke-virtual {p1, v0}, Landroid/view/ViewGroup;->findViewById(I)Landroid/view/View;

move-result-object v0

check-cast v0, Landroid/widget/ImageView;

iput-object v0, p0, Lcom/android/systemui/statusbar/SignalClusterView$PhoneState;->mDataActivity:Landroid/widget/ImageView;
[LG V20 Themes, Apps, and Mods] james_pnut:
I've learned to read smali code a long time ago but normally color is const v0 followed by a 0x(hex color)
[LG V20 Themes, Apps, and Mods] Zacharee1:
Hmm. Well I don't think it's a hex color, because that ID is closer to a semi-opaque dark gray-ish than it is white (following the aarrggbb style).
[LG V20 Themes, Apps, and Mods] Zacharee1:
A fair number are also sequential, which would be weird for hex colors.
[LG V20 Themes, Apps, and Mods] james_pnut:
I'll have to look at the whole smali code to read where the color is that hex color is probably for the background. More that like its found behind a const v3. I'm going to have to dig more to tonight if the wife doesn't go into labor. Haven't had much time lately to look deeper. I was hoping maybe somebody else could look a little deeper
[LG V20 Themes, Apps, and Mods] Zacharee1:
I've updated the mod to 10j, since that's what I'm on now. I also included a T-Mobile version that doesn't have the 3Minit mod. I don't have the SystemUI files for any other variants, but if anyone PMs me the files listed in the OP, I can make the mod for their variant.
[LG V20 Themes, Apps, and Mods] Cheeky_Fink:
Just a heads up to anyone on H918 NSS rom, this doesn't work for us right now. I ended up having to reflash the rom, as SystemUI just wouldn't load. Upon further research, I realized that NSS is based on 10d, which probably explains it. Either that, or there's some critical mods in our rom that replacing SystemUI messes with. It's a shame, because while the AOSP icons are nice, I was really looking forward to 3Minit. Not enough to switch roms though, and supposedly our next update will be rebased to 10j anyway, so I'll try it again then.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Gimme the files I listed in the OP. I can make you something.
[LG V20 Themes, Apps, and Mods] lingo2012:
I sent you a pm with us996 systemui
[LG V20 Themes, Apps, and Mods] Zacharee1:
Saw it and responded.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Thanks to Sprint (I know, right?), I might have a shot at getting the proper coloring for the data arrows. Sprint uses the AOSP icons by default, so I just need to find the proper Smali file to replace to get the right colors.
[LG V20 Themes, Apps, and Mods] Zacharee1:
I've fixed the mod installation, and the app appears to work. I've submitted it to the Play Store as a beta for now. I'll post the link once it's published.
[LG V20 Themes, Apps, and Mods] Zacharee1:
https://play.google.com/store/apps/details?id=zacharee1.com.modinstaller
[LG V20 Themes, Apps, and Mods] zplit:
U around broda?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Mostly
[LG V20 Themes, Apps, and Mods] zplit:
Can I use TB to make mod control system app or I need to move the apk?
[LG V20 Themes, Apps, and Mods] Zacharee1:
I think TB will move it to /system/app/, which won't work. The ModInstaller app should let you do it though. You'll just have to hit the "Hot Reboot" button in the app.
[LG V20 Themes, Apps, and Mods] zplit:
I did won't change the color damn it
[LG V20 Themes, Apps, and Mods] Zacharee1:
That's so strange. You granted the Storage permission and allowed it to write settings?
[LG V20 Themes, Apps, and Mods] zplit:
Allow to write settings? How?
[LG V20 Themes, Apps, and Mods] Zacharee1:
It should be an option somewhere in the app listing.

Can you also grab a logcat while changing the colors a few times? You don't need to restart signboard.
[LG V20 Themes, Apps, and Mods] zplit:
Mod installer won't stay on... How do I get the logcat?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Wait, ModInstaller is stopping?

I meant use ModControl and change the colors of whatever while running logcat.
[LG V20 Themes, Apps, and Mods] zplit:
No it won't stay on.
[LG V20 Themes, Apps, and Mods] Zacharee1:
What does that mean?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Do you have BusyBox installed?
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
Duplicate apk showing up in app drawer after move to system? I did try your other app out. Didnt seem to move to shstem but maybe it caused it? I tried 2x clean and still same result tho.. Duplicate apk in drawer but i can only find 1 path in system that has app
[LG V20 Themes, Apps, and Mods] Zacharee1:
Hmm. I told it to not delete the APK after moving it, because that seemed to make it disappear, even though it's what I did originally. I'll change the script and upload a test build.
[LG V20 Themes, Apps, and Mods] Team DevDigitel:
I even moved the app using another app that always works for me and it did it. Very weird lol i just hid one and kept on testing stuff anyways lmfao

Edit: it makes seince tho.. If i use the app to delete the one i can see in system it wipes both of them out.
[LG V20 Themes, Apps, and Mods] fogame:
Only one here. I did not delete the apk.
[LG V20 Themes, Apps, and Mods] Zacharee1:
My guess is that if I release an "update" (same app with a different version code) the duplicate will disappear. Google installs updates to system apps inside /data/app, as if they were normal user apps. That's why updates can be uninstalled.

Try this https://www.androidfilehost.com/?fid=745425885120714838
[LG V20 Themes, Apps, and Mods] Zacharee1:
Actually, don't use that app ^

There are a lot of stupid mistakes in it. I'm going to release what should be a working version to the Play Store as a beta.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Mod Control and Mod Installer are now both on XDA Labs as well as Google Play! I will be releasing updates at the same time to both, but XDA is a lot faster at publishing new versions.

-----

At this point, I think I'm going to stop adding new features and focus on tuning up current ones. If you want another Signature/QT color, I'll add that, but unless someone suggests something I really like (or something I find I like), I'm going to take it slow for the timebeing.

Keep reporting issues, and keep requesting features, though! I definitely want to hear them.
[LG V20 Themes, Apps, and Mods] lingo2012:
So I installed the mod control app and installer i picked 3 minit resources and after that the systemui would crash go back to the lockscreen the crash. Im running us996 notsostock. Ill try again to be sure.
[LG V20 Themes, Apps, and Mods] Zacharee1:
A reboot should fix it. I got the SystemUI crash and the loop, and force-rebooting brought me back to normal.
[LG V20 Themes, Apps, and Mods] lingo2012:
Ok ill try it again i rebooted but it did the samething but let me try again.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Did you install 3Minit without installing anything else? I'm not sure why that'd break things...
[LG V20 Themes, Apps, and Mods] lingo2012:
Not sure lol and yeah i just clicked 3minit resources
[LG V20 Themes, Apps, and Mods] illwafer:
you don't have to add it, just edit it.

ro.build.target_operator = OPEN. yours probably says TMO.
[LG V20 Themes, Apps, and Mods] Zacharee1:
If enough people say they use this, it might be the next thing I put in the app. I think I can change the file programmatically. And I can fix the 4G instead of LTE problem with some Smali.
[LG V20 Themes, Apps, and Mods] kdayyy:
Will this work on any LG device? Or just the v20?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Only the V20
[LG V20 Themes, Apps, and Mods] fogame:
Would be nice to have the brightness change.

Don't know if this has been brought up but I can't seem to get the select a color to work when changing the color of the settings toggles. All colors work but the select your own.

Other then that, good work.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Brightness?

You're the second person having that problem, so it's gotta be something. I just have no idea what...
[LG V20 Themes, Apps, and Mods] fogame:
No worries. All I've done is disable AOD battery.
[LG V20 Themes, Apps, and Mods] Zacharee1:
Oh, do you mean the "Suggest One!" buttons? Those are just placeholders :p If you want a color added, suggest one.
[LG V20 Themes, Apps, and Mods] fogame:
Yes lol those. Is it possible to have the color selector? That way we can choose which color we want? Or maybe a hexadecimal place to input our the hexadecimal code?
[LG V20 Themes, Apps, and Mods] Zacharee1:
Unfortunately, I don't think so :/

The color values are compiled into an XML, and when you select a color in the app, that edited compiled XML is copied into the app. Maybe I could use a Smali edit to read an integer value and place it... Hang on, maybe I could. I'll look into it. Would you be willing to test (ie can you be online for a while)? If so, I'll PM you a Telegram link.
[LG V20 Themes, Apps, and Mods] Zacharee1:
No, it's not gonna work :(

I can set a color filter, but if the toggle is on, that color also overlays the black icon stroke, which means either no item there at all or very washed out colors and low contrast. I can possibly make it so it'll take a hex value and color the toggles, but it'll mean getting rid of the colored fill when a toggle is on. They'll just have to be gray or something when disabled and the chosen color when enabled.
[LG V20 Themes, Apps, and Mods] fogame:
No worries. I can be on later tonight. I'm setting up my raspberry pi so I can do whatever is needed.
[LG V20 Themes, Apps, and Mods] Zacharee1:
I can't do that either. I'm trying to think of workarounds. We'll see how it goes.