yashsingh1/xdaforums huggingface dataset:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I have to admit, I've never tested gps that thoroughly like i did after the change. Especially the non-gps location services were never tested by me, since I don't want my location data saved outside a server under German law (hey, microG and owncloud knocking at my door again...).

Now, that I tested it, I found a strange (forbidden by neverallow) selinux denial, and I found izat (https://www.qualcomm.com/products/izat) not working. I also tested using the libloc_core feom oos, and not the source build one - what looks promising.

Tue current gps-test build has slightly longer first fix, but then it is the same for me. Neither worse, nor better.

My problem: this is replacing something partly working with something other partly working - and here my character kicks in: I can't leave it that way. If I start dealing with it, I do so till it's solved...

For me the fastest first fixes come with using the prebuilt libloc_core.so - I'm also pretty sure it has the highest amount of LOCKED sats. IZAT still can't inject XTRA_DATA. If you want to test this, flash attached zip - feedback welcome.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] endursa:
You are just an awesome guy, always looking for the best software implementation.

How do I test if the xtra data is injected properly? Because all the gps apps I know do not give feedback on injection
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
logcat -d '*:E' |grep -i xtradata
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] redsmith:
Hi, I've been reading everything about HAL1 and HAL3 in this ROM, but I got lost at the end. What is the current state of the OnePlus Camera here? Is RAW working? What about video modes? Thanks!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] endursa:
Raw, HDR as well as HQ mode working, video has the following options: 720, 1080, 1080:60, 4k
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] redsmith:
Are you sure Raw is working? I just tried taking some pics with OOS Cam and none of them were saved. Maybe Raw works with 3rd party apps?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] endursa:
I do not use raw to be honest, j just saw the option. I'll try it out
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
com.oneplus.camera can't take raw/dng images. It's working like OOS camera port. Our api2/HAL3 implemen4ation os working great. If you want to save images as dng use OpenCamera from playstore.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] spida_singh:
Has anybody just had safety net randomly fail on them?

Rebooted - Still fails

Reinstalled Magisk V12 - Still fails

Magisk hide is working fine as well as root. Any idea?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] goosebickel:
I had the same problem, there is a beta version which seems to fix the problem.

https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] vavill:
[MENTION=4405529]nvertigo67[/MENTION].

https://github.com/kxzxxx/android_d...mmit/4e16a30e4c876a9e92cff7ce5e5815e203f36b14

https://github.com/kxzxxx/android_d...mmit/ec46247a76b7b20b393a157c9ead54d32ee76bfc

https://github.com/kxzxxx/android_d...mmit/efafbc9396803d4320b2cceb3e745ccf6be5bc8f

https://github.com/kxzxxx/android_d...mmit/73f1b940e6460ae1c9b6d06e93a87c2ea568b995

It is all completed.

Those 4 commits make all function , Including RAW ZSL etc.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] endursa:
this command only returns 1 nothing more,

logcat does not seem to have any xtra related entries,

but i only testd this after flashing the libs, which btw still work for gps fixes.

i only had one problem today where no satellites where in view and only reboot could get me a fix again
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] knpk13:
https://www.xda-developers.com/magisk-developer-assures-next-magisk-beta-will-pass-safetynet-again/
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] yannmrt:
I test the GPS , and is working fine to me. Sat fix quickly and look like to be a bit more accurate.

Hope this help.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
The comman should return lines or nothing... just 1 is strange... Doesn't matter: as I stated: inject is NOT working.

I had (soft-)reboots with the stock libloc when switching location modes a few times... The test build without the zip flashed is more stable.

Oh, yes! Feedback on test builds is ALWAYS helpfull!

On gps: found ou a lot on gps implementation on qcom devices... ;) I was just ready to push the next gps-test build; then I read that google entered the next round in handicapping the open source community... but stay tuned: izat is running (stable: no more reboots) - but doesn't show up in settings...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
What should I say: WOW!

To avoid enthusisastic expectations: I won't use that patches. What I need to do: put all framework/av changes ifdefed to framework/av, put the changes to ifaa into a seperate jar (like this: https://github.com/nvertigo/android...mmit/6942d50340308204102666bad04ee176de7290ca), find a clean solution for the boot jar hack and test if cameraservice is still working for all !oos-apks.

I would be happy, if someone steps in on this.

EDIT: no whitespace- and LF-errors anymore. 1.: thank you very much; 2.: if somebody helps here: 1. makes the work MUCH! easier.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] vavill:
Be careful. If you push change in a new jar then change order of bootclasspath,

ART won't compile dex. It only run in interpreter mode, which means phone will run very slowly.

So, what I did is just apply commits to framework/base, libcameraservice , libandroid_runtime.

And oneplus camera apk is not need to modify.

Just put missing libs in /system/vendor/lib lib64

Good luck to you.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] spida_singh:
Flashing latest magisk beta did not work for me, using the universal safety net module worked ok for me. Thanks
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
im currently using your nvertigo-gps branch with updated magisk (dirty flash). magisk is still failing the safetynet thing but gps is pretty quick. . maybe quicker than before but it's stable like you stated in your latest post
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] spida_singh:
So I was using the inbuilt version of magisk that comes with the ROM

Uninstalled and then installed v13 from the magisk beta thread.

I had root and magisk hide all working ok, but still failed safetynet

I never tried s clean install of the ROM and latest magisk 13 beta, some have had success, but these are different devices.

The safety net module is what allowed me to pass safety net again for my scenario
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Still? Look at the date: my last build was released BEFORE g introduced that... ;)

BTW: there is NO! v13 beta! the betas are named v13(githash). v13 beta is no version info. The one starting with b3... works for me

I'm still fighting the gps - as soon I have something stable, I'll ship...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
UPDATE (ob9)

Build 20170622

Releasenotes:

This build requires firmware OpenBeta 9 (aka ob9). It's included in this build. A flashable zip fpr ob9 firmware is below in the firmware section of Downloads.

This build has the fastest, most sats using and most reliable gps fixes I had my hands on! If you want to expirience this, wipe data of all location services and uninstall GPSToolbox. Use a gps apk that does NOT try to proxy the systems location services. If you encounter any problems with gps fixes, delete data of those apps (i.e.: navigon works great without deleting data, but GPSTest needed a data wipe).

SafetyNet is updated to 96f8efc and is CURRENTLY (at the moment I'm writing here) working - but I belive it's just a matter of time, when g strikes back. g suckz! It is mandatory to use the matching MagiskManager-5.0.2. An unsigned debug version is available here: https://github.com/nvertigo/android_vendor_magisk/raw/master/MagiskManager-5.0.2.apk, or you can use the one from [MENTION=4470081]topjohnwu[/MENTION]'s beta thread. I recommend to deinstall the old MagiskManager prior to a dirty flash!

Changelog:

op3: Fix IPC communication by slim_daemon — Alex Naidis

op3: sepolicy: Grant permissions to slim_daemon — Bruno Martins

gps: enable all GLONASS protocols; add XTRA_TEST_ENABLED. — nvertigo

gps: add 32-bit part of the stack. — nvertigo

gps: Update to CAF LA.UM.5.5.r1-04700-8x96.0. — nvertigo

gps: Update to CAF LA.UM.5.5.r1-04000-8x96.0 — Sultanxda

oneplus3: Use SUPL version 2.0 — Sultanxda

gps: add izat headers from caf LA.UM.5.5.r1-04000-8x96.0. — nvertigo

op3: Define ril-daemon normally — dianlujitao

op3: sepolicy: Remove old and duplicate permissions — Luca Stefani

Revert "op3: sepolicy: Fix rmt_storage and rfs_access policies" — Luca Stefani

op3: Add system GID to rmt_storage — dianlujitao

op3: rmt_storage should have wakelock GID — Jeff Vander Stoep

op3: Drop NET_RAW and NET_ADMIN from qti — Naveen Ramaraj

op3: Grant netmgrd proper unix perms — Jeff Vander Stoep

op3: Convert rf_version to integer before comparison — dianlujitao

op3: Adjust lmk parameters — dianlujitao

ipacm: fix the heap-use-after-free issue on bootup — Skylar Chang

IPACM: fix the security issue in ConntrackClient — Skylar Chang

IPACM: fix security issue in querying if index — Skylar Chang

Re-enable delete_aiding_data for user build — Yingjie Wang

op3: Remove BCL hotplug disable/enable from init — Wei Wang

op3: Update qti telephony extension from MIUI 7.6.5 dev — dianlujitao

op3: Update from Open Beta 18 / 9 — dianlujitao

op3: Update ril header for 7.1.2 — dianlujitao

Update to magisk.zip to v13-96f8efc; add uninstaller 20170620. — nvertigo

ROM: lineage-14.1-20170622-UNOFFICIAL-nvertigo-firmware-oneplus3t.zip

MD5: 94bb5c83ab3547f95c85081994ad4a67

Happy Flashing!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
thank you for this update.

gps seems indeed be super fast now. i didnt do a benchmark or something but maps and similar gps apps are really fast (i think faster than before). well it might be a placebo..

i found out that snap fc's if i use the front camera in hdr mode.. is this a known bug?

anyways, thank you very much for this great build.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
Anyone else having an issue with magisk?

I uninstalled magisk manager before flashing. Flashed, installed magisk manager 5.0. It claims, there is no magisk installed. I saw the magsik install script running by while flashing the ROM.

So I wonder, is it just me?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
had something similar.

uninstalled magisk Manager app before dirty flashing the latest build. after successfull installation of the rom i installed the mentioned magisk manager 5 from afh. first everything seemed to work fine but after using some apps where i had to grant root permissions again, magisk told me that there is no root on my device.

so i dirty flashed the rom again (the only difference is that i did NOT uninstall the new magisk manager) and the problem didnt occurred again.

this could be a work around for you [MENTION=3044422]mad-murdock[/MENTION]
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
5.0 will NOT work. It is mamdatory to use 5.0.2.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
No. Just the well known bugs: fc on first ffc shotmand green pictures on ffc hdr shots. Only free cam that can do hdr on ffc is OpenCamera.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Good point.

Now, that you mention this, I really can't remember if I eventually installed 5.0.2 BEFORE dirty flashing at any point (37 flashed test builds in 5 nights... ).

If two or three people could confirm that we need to install MM before flashing the rom, I'll change the releasenotes. Perhaps it needs a reboot with the new MM before flashing (belive me: I rebooted a lot the last nights... *lol*).

Has anyone done a clean flash? Would be interested in feedback on Magisk and clean flashes.

Always remember the Magisk v13-beta-9xxxxx is still beta and [MENTION=4470081]topjohnwu[/MENTION] needs feedback and logs to make it non-beta. (Hint! Hint! Hint!)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] rori~:
Had MM 5.0.2, latest v13xx...installed. Did not uninstall.

Dirty flashed ROM, no issues with MM.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] wistlo:
mm 5.0.2 + 20170622, dialer speaker freezes

Same here:

1. Dirty flashed 20170622

2. Could not update Magisk (I had created a second test user I had forgotten about, and Magisk must be uninstalled from ALL users)

3. Successfully installed Magisk 5.0.2 from apk

4. Dirty flashed 20170622 again

5. All ok, EXCEPT now phone dialer freezes when I select speaker mode. OK on handset & Bluetooth. Survives reboot. I am looking for a way to clear dialer data. I don't have time to clean flash today.

6. [Edit 1]: Reflash, wipe cache and Dalvik, no change (still freezes on speaker mode).

7. Fixed Cleared "Frequents" in Dialer, phone now switches correctly to Speaker mode. Possibly unreleated to this ROM update, just a coincidence that my frequents database was too big or corrupted. (Whew-daily driver on a busy day and did not nandroid before update)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] endursa:
i could get magist manager 5.02 to recognize magist fine, but since i could not get safetynet to work i flashed magist v12 again, and use it in core mode to pass safetynet!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
about that phone speaker failure: i had the same problem couple of builds back. the reason was not the rom itself but the substratum overlay that i used that time for dailer and phone etc.

if you got an overlay activated try to disable it and retry :)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] wistlo:
Interesting. I have never used or configured Substratum or any overlays or themes, running complete stock Lineage with only a custom wallpaper, Nova, Whicons icon pack, and CF.Lumen (root).
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] yannmrt:
Some feedback about last update:

GPS Fix very fast and faster with more sat. Didn't try on road but look like realy good.

Magisk: I update MM 5.0.2 then dirty update. Try safetynet and pass green without any problem, even after reboot.

I see only positive point as far I see with this update and all past ones

Thanks for your time.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
SafetyNet, Rooting Methods...

While fideling with Magisk, rooting in general and SN I found:

The esiest way to pass SN check 8s running this rom WITHOUT root. Our rom is passing SN out of the box without the need of any additional packages.

The second easiest way is using LineageOS addonsu zip: if you disable su in dev-opts, this rom passes SN - if su is enabled it fails. You can switch on the fly, no need to reboot, wiping or anything else. Attached you find fresh builds of addonsu and addonsu-remove. These are the same as on the LineageOS extra download page, but mine are not signed. (To remove Magisk frommthe current build, use this Magisk-Uninstaller zip.

From the next build on I'll remove magisk again, and everybody can decide if and which root solution is the best for ones own individual use case.

On a side note: I appriciate all kind of feedback and I'll take any report on crashes, freezes and other issues without logs (and additional information like gapps version and rom setup) as just that: feedback.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] TheGatorade:
Flashed 20170622 and my phone is using more battery, overheating and freezing randomly... ?

But safetynet works :D
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] knpk13:
Thank you. :) :good:

I personally like magisk, but I don't like it bundled with the rom. I like the freedom to choose my root solution.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] shipleythump:
I've been using another rom for several months now. And I now have the itch to reflash. I really want to try this ROM but every time I attempt to flash it tells me this ROM is only for OnePlus3T, and that my device is OnePlus3. I do have a 3T. I've searched this thread and can't seem to find anyone else with the same issue. I've backed up all my data, and restored to stock. After that I attempted to flash this ROM again and it's giving the same error. Ideas. not really sure what info you need to help troubleshoot, or maybe someone knows the answer off the top of their head?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Lada333:
Maybe try flashing a different TWRP. Use the one linked in OP.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Search the twrp thread: the unification make the recovery claim your device is op3... I'm still on unofficial 3.0.4.1 without issues.

The attached zip is NOT! for flashing. It holds just the image of the recovery partition, but the limit for img files on xda is 8MB - for zips it's 20MB... unpack, flash as recovery image in twrp or be a "cli-pilot-in-command" and dd it to recovery:

Open a shell (adb or local terminal) and get root access (in doubt just type su)

su
dd if=/sdcard/Download/twrp-3.0.4-1-oneplus3.img of=/dev/block/bootdevice/by-name/recovery

Watch out: this has no safty belt - what doesn't matter, because you are smart and before flashing the new recovery, you have done a backup:

su
dd of=/sdcard/Download/old-recovery.img if=/dev/block/bootdevice/by-name/recovery

If this recovery ends up with the same issue, I have no idea what's going on.

Twrp is a tiny, fully functional android os. As such it comes with its own properties.

To avoid anybody is flashing this on op3 (what would result in a soft brick with non-firmware builds and in a hard brick with the firmware containing builds...) That's why I do this:

assert(getprop("ro.product.device") == "OnePlus3T" || getprop("ro.build.product") == "OnePlus3T" || getprop("ro.product.device") == "oneplus3t" || getprop("ro.build.product") == "oneplus3t" || abort("E3004: This package is for device: OnePlus3T,oneplus3t; this device is " + getprop("ro.product.device") + "."););

If neither ro.product.device, ro.build.product, nor ro.build.device is oneplus3t or OnePlus3T my rom declines to flash - as you can read above: for very good reasons!

If your recovery claims to be an op3, you can not use it for my rom. Hopefully the attached twrp will work for you.

I have no idea, why your recovery's developer does not use i.e. something like this: https://github.com/nvertigo/android_device_oneplus_oneplus3t/blob/cm-14.1/init/init_oneplus3.cpp#L93 As you can see it's no rocket sience to sort the hardware coded rf_versions to the valid models...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] spida_singh:
Uninstalled old / previous magisk manager app

dirty flashed update

Safetynet and root wasnt quite right

A simple reboot resolved it, safetynet root etc all working ok, magisk just keeps telling me that there is an update to v12 of the app, just ignoring this for now

thanks again for your efforts, me personally like magisk included, but leave it up to you how you want to build rom of course :)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] shipleythump:
Not sure what did it. But I returned to stock again. Booted up fully reflashed TWRP and then the ROM installed. Thanks for the help. Most likely was a unified TWRP.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] azaidi:
You might want to fix the 'sdacrd' in your paths before people try to copy a non-existing file to their recovery partition
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] goosebickel:
Completely off topic.

The 1+5 was just released! Nice phone, but not an amazing improvement on the 1+3t. Very tempted to put mine on eBay and do a quite few extra shifts to get one!

Was just wondering if [MENTION=4405529]nvertigo67[/MENTION] was thinking of upgrading also?

As most developers only deal with phones they own for testing purposes.

Been running your Uber build from day 1, and you will be the deciding factor in my decision.

What is the future of builds with this device and [MENTION=4405529]nvertigo67[/MENTION]?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Of course I thought a split second on getting a 1+5 (I like 1+ - it's less confusing then OP... ;) - who not.

On the other hand: I'm just on my way to get known to the 1+3t. My learning curve is in no way fast enough to hold up with the speed of sales departments... ;)

For the future of this rom:

This may sound egoistic (and I think it is... ;) ): I make this rom for me. I want a source build rom and I'm curious to learn. As long as I ise this phone, I'll make my rom for it. I came from 1+1 after using it for two and a half years. Npbody knows what future will bring (consider an accident with serve brain insuries - and I go forn an iphone... ;) ), but atm I belive this rom will be on my phone for - at least - one more year.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] TheGatorade:
[MENTION=4405529]nvertigo67[/MENTION]

Regarding the freezing, it only happened once (just before I posted that message) and it hasn't happened since. I had to reboot holding the button, it never happened before with this phone. Idk, not important I guess.

The overheat and battery consumption are probably the heat. I don't use gps, in fact I don't even use location services, so it's not gps for sure. My battery consumption is about 3 to 4 times higher than last week, about 2-3% battery used per minute with screen on, my battery is lasting circa two hours of screen time, nothing interesting to be seen on battery screen in settings or wakelock detector.

I thought it was the rom update in general but I guess it's just the summer kicking in? Temperatures rising and such, because the same thing is happening to a friend on mine on stock 3T rom (even if their battery use is still somehow lower)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] wistlo:
As a custom ROM user since 2010 across eight phone models including the 1+1 and 1+3T, my experience has been that several months typically must pass before both the manufacturer and the open source community come up with viable and stable firmware, custom ROMs, recovery images, and even choice of protective cases.

While I would love to have the extra processor juice and dual cams on the 5, I can do fine not dropping half a grand once a year or more. Part of 1+'s appeal is its value, and that includes a great user experience over time. More time is more value.

My 1+1 is now in my son' s hands, having replaced a Moto G that was underpowered from almost the day it arrived. My wife has an HTC M8, which remains an amazingly responsive and capable phone over three years after its release. All of us run essentially the same software, completely current and up to date on known security vulnerabilities. Our collective experience is more consistent than even iPhone users, who probably won't be seeing new features introduced on their 2014 vintage devices.

As for our esteemed developer nvertigo67;72583153, I appreciate the work and this ROM but also fully understand if he moves on. What if his 3T tumbles into the ravine (now that we finally have stable camera blobs for taking panorama photos)? I would expect he would be jumping to the 5. That's fine and little different from manufacturers (and certainly the carriers) who move on from supporting "legacy" products.

Based on my continuing experience with the 1+1, which is still superior to current mid range devices from other manufacturers, I am not worried about the 3T losing community support anytime soon, and that is on a scale of years.