yashsingh1/xdaforums huggingface dataset:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
//EDIT:

actually this commit seems to force the enhanced 4g lte mode switch to appear but it was abandoned "I think these [props] are never ever needed".

for those who want to try this out:

0. mount /system rw

1. open and edit build.prop in /system

2. add these lines:

# VoLTE
persist.dbg.ims_volte_enable=1
persist.dbg.volte_avail_ovr=1

3. set 0644 permissions again

4. reboot

////

i dont want to spam, just to report (with hopefully enough information):

i gave the lte issue another chance:

1. carrier? drillisch (O2)

2. did the enhanced 4g mode appeared with previous nvertigo builds? yes.

3. do you know the build date? sorry, i dont. more then 2 builds back in the past i think.

clean branches means the following:

repo sync --prune -d

repo forall -c git reset --hard
repo forall -c git clean -f

repo sync --prune -d

repo status

clean flash in my cases means the following:

0. twrp version: twrp-3.1.1-x_blu_spark_v39

1. system + cache + dalvik-cache -> wiped,

2. internal storage, data and media -> formated and set filesystem to f2fs,

3. flash: %rom%,

4. flash: latest (20170610) beansgapps mini,

5. flash: latest magisk v13.3 and magiskmanager v5.1.1,

6. wipe cache and dalvik (i dont know why),

7. boot

8. finish the setup-wizard

a.) rom = YOUR rom (Build 20170722):

- no enhanced 4g mode,

- sometimes (i dont know why) front cam issues like technotravel and Vipeout reported already; no log cat beacuse i try to solve that LTE thing

b.) rom = build from YOUR clean branches (device: my-gps [with latest commit to force network mode to 22 for european devices])

- no enhanced 4g mode,

- sometimes (i dont know why) front cam issues like technotravel and Vipeout reported already; no log cat beacuse i try to solve that LTE thing

in both cases (a and b) i swiped up ~15 seconds after entering the pin with and without LTE symbol shown in statusbar. i also tried your '

work-around

' to get the enhanced 4g mode back but it didnt work for me either.

'work-around' means:

1. change to a networking mode completly without LTE, reboot, swipe up after ~15 seconds after entering my pin while not seeing LTE symbol in statusbar = no enhanced mode (not really a surprise)

2. changing networking mode to something with LTE as first option again, reboot, swipe up after ~15 seconds after entering my pin while seeing LTE symbol in statusbar = no enhanced mode

work-around from: your post
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] endursa:
I think I found a bug with screen off gestures and flashlight.

Yesterday evening I wanted to activate flashlight through quicktoggles, but the button was greyed out, due to low battery. Which is perfectly ok and intended.

But I did not think of that and set a screen off gesture to activate flashlight ("V") because i thought at first that the quick toggle had a problem.

What happend then was an instant reboot directly after using the screen off gesture. I had ~13% battery so I can not test it right now, battery to full :)

Latest build, clean flash, beans mini gapps
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
This was widely discussed when we tested different camera implementations, and tried to get Snap as well as OnePlusCamera as well as HAL3 running at the same time: Camera server is crashing on one of the first ffc shots, if app is using HAL1.

It was common sense, that it's annyoing, but no showstopper. Most (if not all) lineageos based roms behave like this.

I doubt any non-regular user will read the first page of the thread up to #4, but anyway I added this to the "Known Issues" Section and included a short description for possible workarounds:

https://xdaforums.com/showpost.php?p=70781760&postcount=4

If one uses anything, which is manipulating persist.camera* - one is lost in the deep darkness of "not supported in this thread"... ;) That's also stated in the flash messages - and that's why the flashable zip deletes these props on each flash...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
OK. Understood and put on the list. Would you be so awesome to put this in a 150 - 200 characters description, I can put in the "Known issues" section, please?

Sorry, to say this:

It's extremly (not very, but extremly) low on my priority list: set the gesture now with charged device... ;) It's far behind the lte issue and the compatibility with official twrps...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] endursa:
yeah I understand that this issue is not that important, since it does not affect too many people and I more or less discovered it by chance :D

- Trying to activating torch through screen-off gesture while battery is below 15%, will cause a reboot.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
No spam at all. That's something I can work with.

I can put the degugging props in again, though I don't know, how this can be conncted in any point: Those are debugging props - on one of the very first builds, when I tried to debug the phone->settings->call-settings->ims crashes, I've put them in hoping to get some enlightening logs. I havn't got more infos from the log, but forgot them afterwards. From time to time I do a general cleanup - this time I found theses two props. A quick check on laos and rr sources showed me, they are nowhere else used in current roms and recently no one has complained on lte in the roms threads, so I removed them. Also: I can reproduce the missing advanced lte voice setting, by just setting the preffered network to something without lte.

And if it's up to this two debugging props, why hasn't the setting vanished for exactly two people, and all others (including me) have it?

This all makes me think, it must be something else... On the other hand: we know since Heisenberg that watching something changes this something, so I don't exclude this from the list of possible reasons a priori.

For now I'd suggest, we leave them out of the rom (just sums: it's working for more people then it's failing) and make a flashable zip for those, who seem to need these props for working lte features.

For camera: see my other posting and the reedited "Known Issues" section. For the details search the thread for "camera" and ("hal" or "api").

You can also build from https://github.com/kxzxxx/android_device_oneplus_oneplus3t to serve the callbacks from OPCam to completely get it working (if you port on that way the cameraservice changes back to framework/av, the day we have it on this rom comes closer...)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Ascoolas:
Keep it up

Yo!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Thanx.

Keep this thread readable, please. (Noise-information ratio... Ypur posting is 28,5 KB quoting compared to 8 B added information... ) Thanx for understanding that.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] buzzqw:
Hi

any hope for customize date/time ?

thanks

BHH
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I was just about to put it in known issues, but decided to wait till I have checked this myself. What should I say? Working like charme here - with power savings disabled, as well as with power saving active. Screenshot file names should be self eexplaining. Gestures are working, too - in both modes. I just don't know how to take a meaningful screenshot with screen switched off... ;) ;) ;)

EDIT: For your previous posting: torch's icon is grayed out - it only lights up, when t is enabled.

(I learned: if you forget to turn off the torch from last test without timeout set, your bat will drain - just tested. First hand knowledge... *lol* )
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I need some information: if you own any device other then 3t (or 3) running laos 14.1, please check what kimd of file /system/bin/ grep is. Easiest way: open a shell (adb or local terminal - for the latter check devopts) and issue this command:

file /system/bin/grep

Thanx in advance

Not needed any more.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] wistlo:
Already "did the research", so for those who are curious, anyway:

file /system/bin/grep
/system/bin/grep: symbolic link

on 3T, HTC M8, Moto G LTE Peregrine (all are the same)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
After checking the build logs for 5 official devices on jenkins, I was so damn sure, that I thought I need no more external conformation. But when reading your response, I realized the external confirmation feels good... ;) Thanx.

For me from now on toybox is bodqfh (bastard operator's drama queen from hell). This was a really hard one. I really expected toybox and toolbox configured with respecting each others install targets...

BTW: updated build is uploading...

Sidenote: build order also differs, if you build for two devices - say op3t and chagallwifi - and change build order (first run op3t before chagallwifi, second: chagallwifi before op3t) the order of building packages slightly differ. I do not mean, that host parts and common parts are not needed to build again, but that parts, rhat need building differ in order...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] knpk13:
Blu spark twrp has the best of both worlds. You can backup the firmware and modem partitions; no flashing incompatibilities; and latest upstream including dt2w. It's like an updated 3.0.4-1. Bonus: it has a black background for AMOLED screens.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Neraeh:
Hello !

I flashed the latest build, but now the flashlight is constantly greyed out

I can't trigger it anymore, is it normal ?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] BIGWORM:
https://xdaforums.com/search/thread/3547024?query=flashlight

Looks like someone reported that issue a couple of days ago. Post a logcat for OP when you get a chance.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
As you can see, from the aboves reply, I can't reproduce this "issue".

Since I tried a clean install for an other issue some days ago, but also tested torch is working, clean installing following OP to the word will fix your issue.

i've learned most people are not willing to read, but reading the first 10 and the last 30 pages before flashing, and using thread search before posting an issue, is not overdemanding - and just fair enogh.

You have also missed this one: https://xdaforums.com/showpost.php?p=73155085&postcount=1609
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Neraeh:
I've read the last 50 posts, but I did not understand everything, I'm sorry if I was redundant

I tried to upload a logcat but it keeps telling me there is a network error, so I'll upload it when my computer is back
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Accepted. Before just posting the logcat, reread the link in OP on reporting an issue. Since I can't reproduce it, I need to know the exact steps you did to clean flash (*) and what exact software versions you have used.

(*) implies no additional software installed/restored other then rom, beans mini and root package of choice.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] phoberus:
You might want to look at this commit: https://github.com/VertexOS/android_frameworks_base/commit/b4d4fe19a717c2207ca4b2f50c68fd6ef840474a

azaidi and joshuous got OOS Cam without Hal Switcher to work
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Thanx for the heads up.

I implemented that patch 4 months ago after @kxzxx found it in this rom (https://github.com/nvertigo/android...336495c64b5cd7f3085888a968791bde7ace41f.patch). The comment in the other patch (the one you found) is misleading ( most polite way to describe), because it does NOT allow opcam (v <2.0.0) to work with hal3 (that's just not possible...). in deed this patch FORCES hal1 for opcam in a multi hal environment. You can find this en detail discussed here in this thread. That's the origin reason, why I appended some output to the end of flashing my rom: we HAVE multi-hal and any hal switcher does harm to our multihal. Do you still use a hal switcher on this rom????

Sadly it got common sense, not to cherry-pick a commit and maintain autorship and history, but commit other peoples patches as the own ones and droping comments/messages as well... (happens to my changes each year more and more... ) As you can study exemplarily in this very situation, this is not only just bad habbit or a german spleen to stick to rules, but it's just misleading and on a larger scale the death of community colaboration. :(

BTW: it's great for marketing, to claim opcam is working with hal3 (in the end they claim switching to hal1 for apps, requesting unspecified, is exactly what they have meant, and the comments in the code make it a complete new commit...) But maybe the reason, why you've overseen this in our rom: a technical correct description is seldom good for marketing...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
@homebuilders

gps changes completely merged in 141-work and cm-14.1.

cm-14.1 and 141-work are on the very same commit. Wil propably work on 141-work, so building from cm-14.1 is the save way - for the next days... ;)

Try my best to keep you informed.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] joshuous:
Hi NVertigo, just happened to come across this message. I'm quite confused by what you're getting at. I had the impression that you're saying that Amir kanged your work. I have previously implemented your patch you referenced in frameworks_av without much success on my part. The patch that Amir made was done in frameworks_base and tells the system that OOS camera supports Camera2 api. I just hope to clear any grounds of misunderstanding here
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] joshuous:
Hey man no worries, I'm just glad to clear any misunderstanding!

Nope, I didn't use a patched cam apk, just Amir's commit in frameworks_base. Amir also got 60fps and auto HDR working with this commit too: https://github.com/VertexOS-Devices...mmit/774a1f0858cf227962319f36e159d0ae5e6f02e9

I haven't given it a try yet, but I'll sure look into it!

There's no need to use it I believe. It's called when the OOS camera app wants to access the updateThemeMode() method, which doesn't seem very relevant. But I have decompiled the OOS frameworks to Java code to some extent. If you are interested, perhaps we can discuss more in PM
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
[MENTION=6745491]joshuous[/MENTION]:

Have looked through your device tree (this time including reading to line's endings... ;) ), and telling from some gps related commits (and reverts) I guess, I was there... ;)

i digged in gps/izat some weeks ago. I installed oos 3.x.x and 4.x.x to get "clean" logs and to understand what happend to the izat settings (xtra_t_*.apk) in 4.x.x.

*.XT is in that vanished app. In 3 you can switch izat on and off. In 4 this is gone and replaced by izat.srv.xt.jar (my first REAL encounter with baksmali....): this looks to me just like a "redirection" to allow com.oneplus.location.apk to start, though the extras of *.XT is in deed not there any more. The error in Settings (in the log, no ux effects, besides izat settings not there) is just the missing xtra_t_app.

For both cases, the configuration of gps and izat is done in oos' framworks. The config files (mainly gps.conf and izat.conf) are the configurations (on 3), which kick in if izat is switched off. In 4 you doesn't have this switch. On laos (or vertexos for this matter) we also lack the 1+ "izat auto configuration from within some proprietary additions". Which means: on our installations the config files are immanent.

I made a "brute force permissive kernel" (https://github.com/nvertigo/android...mmit/e8fc8b317fbf810d2bb15c6ccc813a21073d01ea Neither elegant, nor sublime - but absolute effective (and unswitchable... ;) ), and started to configure gps and izat (also added the AP_* binary in /system/bin). I.e. SUPL, emergency SUPL (according to the connect line in logcat), setting MNEA source to modem... Activating GTP_AP. Since quite some settings depend on your's carriers settings, signal strength and connection type and network mode and so on, the settings differ from user to user. Then I greped the avc:'s from logcat and dmesg and made sepolicy rules from it.

After I had this all up and running and spended many nights on this, I decided in terms of privacy to go back to minimal config from laos: especially the correct emergency SUPL config (the default suggested in the comment of izat.conf works great for me - vodafone.de) seems to make remote tracking even easier. Since I have no idea for what this may be used by whom, I decided to stay with the minimal config with disabled AND broken eSUPL config and leave the decission to each user.

Hopefully this information is not too late to save some time.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I tested with [MENTION=6745491]joshuous[/MENTION]' patch to no advance: as soon as I disable our av patch opcam looses HDR. No matter if plain apk in priv-app, plain apk with libs added installed as user app, modded apk (callbacks removed) as priv-app or as user app.

The vertexos patch does no good, but also no harm to Snap (our main cam app). It does not solve the the vanished hdr, and it completely breaks op5 cam.

I belive it's more then this single patch. As far as I can see, I need to check your devices camera/ implementation (at least one callback is dealed with in vortex sources compared to out), QCamera2 (different caf base), framework/av and framwork base.

What is really strangE: if I understand the smali files from opcam, op3 opcam denies most features if only api2/HAL3 is offered. If api1/HAL1 is available, op3 opcam issues some callbacks to cameraservice to get selected features from HAL3. Since we do not have the callbacks implemented, this fails. The observed behavior makes sense to me. What doesn't make sense is the complete failure of op5 cam: in the logs I find a crash just after the class not found error (OPFeatutes). Without vertex but with our patch it is working with some glitches (flash not working reliable; raw only working if iso and shutter time is set manually).

For completeness: with both patches appliec it works for Snap and op3 opcam, but op5 opcam breaks as soon as the vortex patch is applied.

Anyway, at least I have instalable apks for opcam and opgallery, now. I think I'll remove opcam from the rom and provide the installable apk's seperately: freedom of choice.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mumapizza:
Accidental touch from aospa would be nice addition https://github.com/AOSPA/android_frameworks_base/commit/dcbf72de672ccd99ac1e9305cccddf2c8655a2de
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
*lol*

Did you read my posting on the vortex cam patch? The frameworks differ. I don't think aospa's frameworks are based on laos - or has so many additions, that I can't find a common base. Feel free to send me a commit working with our framwork.

As always it is just a matter of time. I spended again a complete night on the rom, and that's not good... If the commit is implemented in our framework, this needs to be maintained with all future laos updates...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] joshuous:
Hey nvertigo, I'll link you the additional camera commits I made on top of LineageOS's standard ones. I did not use a patched OOS Camera apk. I'm still using the Camera from OOS 4.1.6.

Enable auto-HDR indicator for OnePlus devices

https://github.com/VertexOS/android_frameworks_base/commit/1bf069651aa11c898724ab1bc03acf88bbed826f

Hack: Allow OnePlus Camera to work with HAL3

https://github.com/VertexOS/android_frameworks_base/commit/b4d4fe19a717c2207ca4b2f50c68fd6ef840474a

CameraService: addition from OSS for OnePlusCamera (found by Kevin Mckee <kxzxxx@gmail.com>)

https://github.com/VertexOS/android_frameworks_av/commit/fb3c8d93461ae6278478d08c612ff7c66dd3d244

Enable 60fps with camera blobs from OB18

https://github.com/VertexOS-Devices...mmit/774a1f0858cf227962319f36e159d0ae5e6f02e9

Add OnePlus Camera and blobs (OOS 4.1.6)

https://github.com/VertexOS-Devices...mmit/cb77c40b1cf443112c3994ed118f70b52bc05a5a

Add OOS Camera-specific blobs

https://github.com/VertexOS-Devices...mmit/414d1fe1580c404ee6907f7ae99571a88ed4155d

Import 32-bit libopbaselib.so camera blob

https://github.com/VertexOS-Devices...mmit/27263887232e784ea99bdfbb7d774defd1950776
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
deleted helpful stuff.

It's working with unmodded v1.4.0, if I use stock roms libcameraservice and libmediaplayerservice. It's working on the same level as the modded version on our rom: raw not working, mediaserver crashing on one of the first three or four ffc shots. So no real progress.

But I have still to look into QCamera2.

It isn't a lack of interest, but lack of time. If I can get raw running and the ffc issue fixed with the blob's libs instead of the source build libs, without breaking something else in framwork/av and its dependencies, I'll go that way - sooner or later... ;) I don't need a Rolex, but a 25th hour. ;) (I would also like to install vertex, just out of curiousity to compare logs - so much good source code to understand...)

BTW: com.oneplus.camera has not changed the last ob updates, but some libs are changed:

ingo@adler /usr/local/src/oxygenos $ git diff ob9 ob12 -- $(find * -name libmm\* -o -name camera.msm\* -o -name libopbase\* -o -name libopca\* -o -name libfilter-sdk\*)
diff --git a/system/lib/libmmcamera_interface.so b/system/lib/libmmcamera_interface.so
index 3effd65d..7e927d36 100644
Binary files a/system/lib/libmmcamera_interface.so and b/system/lib/libmmcamera_interface.so differ
diff --git a/system/vendor/lib/libmmparser_lite.so b/system/vendor/lib/libmmparser_lite.so
index 5f73ffc3..41b604b7 100644
Binary files a/system/vendor/lib/libmmparser_lite.so and b/system/vendor/lib/libmmparser_lite.so differ
diff --git a/system/vendor/lib64/libmmparser_lite.so b/system/vendor/lib64/libmmparser_lite.so
index 3c9ba9b6..cb2d9327 100644
Binary files a/system/vendor/lib64/libmmparser_lite.so and b/system/vendor/lib64/libmmparser_lite.so differ

(op3t/ob9 ~ op3/ob18)

Sadly the new cam stuff from vertex has occupied me since yesterday. I'll try to deliver a new build (with August's sec patch) by tomorow evening.

EDIT:

The first of this two is useless, because the second one overwrites the source build one (which would have contained the first patch). Sadly, if I try to put the bolbs libs into an installable cam package, I get a parsing error on install - otherwise that would be the idle solution. If we want to use the blobs libs, we have to ensure 2 points: first it's needed to ensure the blobs are installed (not the source build ones), second every package using these, needs to be linked on buildtime against the blobs. If we just hope, the blobs gets installed after the ones from source are build, all packages would have been linked against the source build versions. The best solution would be ensuring that the source build libs are not build at all (I'm currently working on a solution.

Will report back.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] joshuous:
Thanks I've confirmed that the blobs overwrite the source-built one. Did an MD5 check to confirm :)