yashsingh1/xdaforums huggingface dataset:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
From a users point of view the two former answers are sufficient, but they imply two "no"s. So let me add the dev's point of view:

It's all about freedom of choice: we have OMS7 in our rom to use Substratum themes (or in other words: we have the oreo theme engine allready on 14.1). It makes perfect sense to me, to ship the rom with aosp look&feel, and leave the choice to the user.

The same goes for dpi: if someone is using enumeration on status bar icons and/or network traffic monitor, it's not longer readable with 420 dpi. Since it's changable by user settings, 360 dpi as default is the better choice.

This is all open source, which means you can always make your own build. I suggest you start from non-oms gits, because most AAPT changes (oms vs. pixel-theme patches [I don't even know, if there are source patches for pixel-theme available]) will interfere.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I don't understand the first sentence. But dpi is not only depend on screen size, but also on resolution. Pixel has 4k resolution on 5.5" screensize - 3t has HD on the same screen size, which results in LESS density. Relating density only to screensize doesn't make sense at all.

https://play.google.com/store/apps/...ize&pcampaignid=APPU_1_6NjAWaaVHIXJwAKPj5O4Cw

For the second sentence: why do you want to edit build.prop? Why not just change the dev-ops setting? The latter even sticks through dirty flashes. See attached screenshot.

i think so. Try and report back.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Encryption

This is difficult, since the last reboot delets the pstorenfrommthe secomd last one. I really don't know how to start debugging this - not to talk of fixing it. Since I try to keep our device tree (and our kernel for that matter) in sync with laos oneplus3 tree, I hope someone more gifted then me will fix that.

I'll add this to known issues, but I need a confirmation or two:

I know, if you encrypt f2fs on oos and change to this build, it works flawlessly - is this true for ext4, too?

Has anybody tried to encrypt an unencrypted f2fs with this rom?

Can twrp-3.0.3-0 restore a ext4 taken backup on f2fs and vice versa?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Dual sim

I've just looked at the dual sim logic in the kernel sources: wow, that's strong stuff! And I admit frankly. I won't mess with that. Sorry to everybody, using dual sim, but don't expect me to fix that.

(But: same as above; hopefully it gets fixed upstream.)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I brainlocked here and didn't see my own error, but - that's why I like collaborating in this community (*) - [MENTION=5226211]cmattern[/MENTION] found this: it's .repo/local_manifests not .repo/local_manifest. [MENTION=4350960]t-shock[/MENTION]: this is the reason, why repo hasn't found the xml file. Just go to my_tmp/local_manifest and "git pull"; then sync the sources.

He also found device/oppo/common was missing.

If you send me formated patches as a file, I'd be happy to apply them with maintained author ship!

make your changes, then

git checkout -b tmp #change to a new branch to avoid issues on the next git pull
git add -A #adds all changes, even new files
git lg1 #lookup the commits hash
git format-patch -1 --stdout >/tmp/my-commit.diff

Thanx again to [MENTION=5226211]cmattern[/MENTION] for the findings!

(*) I like the users and the communication in this thread - I've seen other threads here on xda.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Vipeout:
Just a quick observation: In previous build (30/01) the home button would stop responding after a certain amount of using the phone (no idea what was the reason). Locking and unlocking would fix the issue but it was annoying.

As far as I can tell, this problem is gone on your latest build. :)

Can anyone tell me where to get the stock ringtones/notifications from OOS, or maybe upload them here for me? I searched and asked elsewhere but no game :(

Cheers
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Have not expirienced that - perhaps not uswd long enough before next test flash... ;)

Yeah, can make an archive: what do you prefer, zip, tgz or 7z? Please be patient, I want to do an update build, OP, changelog etc. And I promised to my relevants to reduce the time working on this.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
gapps again

Disclaimer: gapps still suckz!

I don't know, if this relates to the dual-sim issue, but if you use a stock or bigger package, the laos dialer is replaced. It's really annoying, to have to debug not only the rom, but allways to have 3 or 4 different opengapps packages, which replace different system files in mind. I don't like reducing peoples choices (open source is freedom of choice), but I really think of following [MENTION=4800121]Sultanxda[/MENTION] and only support nano or smaller, since I don't know, how to support different systems... :( Clueless at this at the moment.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Vipeout:
good old zip would be fine :) And thanks for the effort, this is actually something anyone here could do so kudos for offering to do it yourself.

And lastly, thank you for all the work you put into this, it is much much appreciated!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] psdl:
stuttering in every app / vsync

Hi,

i have a problem with my graphic rendering. I have installed your rom on my 3T ander everytime i open a new app it is stuttering in scrolling. When i scroll down the top menu with two fingers the lag and stuttering is gone in the App beneath opened.

I did a:

> adb shell dumpsys gfxinfo com.google.android.apps.nexuslauncher reset -- > run1 (stuttering without opening top menu)

> adb shell dumpsys gfxinfo com.google.android.apps.nexuslauncher reset -- > run2 (after opening top menu)

here is the output:

run 1:

Applications Graphics Acceleration Info:

Uptime: 7076822 Realtime: 14964930

** Graphics info for pid 15219 [com.google.android.apps.nexuslauncher] **

Stats since: 7056851301741ns

Total frames rendered: 282

Janky frames: 74 (26.24%)

50th percentile: 10ms

90th percentile: 40ms

95th percentile: 53ms

99th percentile: 77ms

Number Missed Vsync: 52

Number High input latency: 49

Number Slow UI thread: 41

Number Slow bitmap uploads: 0

Number Slow issue draw commands: 11

run2:

Applications Graphics Acceleration Info:

Uptime: 7095324 Realtime: 14983432

** Graphics info for pid 15219 [com.google.android.apps.nexuslauncher] **

Stats since: 7076827335501ns

Total frames rendered: 386

Janky frames: 64 (16.58%)

50th percentile: 11ms

90th percentile: 18ms

95th percentile: 20ms

99th percentile: 28ms

Number Missed Vsync: 0

Number High input latency: 0

Number Slow UI thread: 16

Number Slow bitmap uploads: 0

Number Slow issue draw commands: 29

As you can see i have a lot of missed vsync frames. So the top menu when pulled down is triggering to enable vsync in the underlaying open app as long it is running in the foreground. If i exit the nexuslauncher or play store or whatever, vsync is disabled and it is stuttering.

I don't know how to avoid and fix the failure.

Any help is appreciated. :)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Update 20170203

Rom

Changelog:

update display calibration from oos

add trust zone check to zip (has to be from 4.x)

support four more gestures (one finger swipe: up, down, left and right)

update gps.conf to use https

disable vibrating on double touch to wake

fixes for two potential race conditions (see git for details)

kernel: improve sqrt, take some functions from libc (see git for details)

IMPORTANT:

I have no mapping for the new display calibration file, I tried my best to guess them, but I don't like guessing. So I need your help: go to settings->display->livedisplay and check the modes. sRGB is now called "natural" since the description matches what I see. Check all the modes, also eye5 and eye7, and tell me, if I set them right: i.e.: Hey, nvertigo, what shows up as cinema is photography. Thanx in advance for your assistence!

ROM: https://drive.google.com/open?id=0B_f72wz8rwc6b0FlY3VKLU9jVE0

MD5: 5de3a4ae8fbaae12d1a5498ea40dab8b

Mirrors are welcome!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
While enjoying your coffee (thanx, man), my build host spit out an update... ;)

On wifi, mobile data or both? Is chrome allowed to keep the device awake?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Vipeout:
Wifi, didnt check data since I dont use it for big downloads. As I wrote, I set chrome to be exempt from doze ("dont optimize" in Battery setting).

What else do I have to do to allow chrome to keep the device awake?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Just checked the code. vsync should be active, but your gfxinfo suggests, that's only active after pulling notifications or quicksettings down. Have you tried playing with dev-ops (2d gpu renderingnand 4xMSAA)?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] psdl:
Did enable it, but no effect at all. I am searching the internet now, found some tweaks for build.prop but they didn't work either. :rolleyes:

p.s.: i did install opengapps stock. Maybe that is culprit ?!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
No - I use nano and havw the same, checked one minute ago.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
On laos there are many places to change peemissions granted to an app:

Settings->Apps->Chrome->Permissions

Settings->Privacy->Privacy->3dots->Advanced

Settings->Privacy->Privacy->longpress Chrome

Does Gello have the same issue? (Gello: laos own chromium, which is systems default browser - I don't know, if gapps > nano replaces this with chrome)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mad-murdock:
deleted
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] psdl:
I think i found it. Did the whole installation again. Installed opengapps stock and after that google play store wanted to update

- google camera

- Android System WebView

- Google

I think WebView was the culprit. I should only use opengapps to update the google apps. System WebView Version from Play Store was from 09.12.2016 Version 55.0.2883.91.

The Version from opengapps is 56.0.2924.87... Hope this helps someone. :)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Wow! That's a great finding! Then I call my stutters micro stutters, because I use nano. Ans you make my life easier!

Stock replaces that many system files (for this matter the systems webview), that it is not debuggeble for me. From now on I support only the nano package. This is not about you, but only about gapps: this example shows, that many issues, that take away time from dealing with rom issues (which can be fixed in the rom), are issues in system files we can NOT control on our side.

That doesn't mean you can't use bigger packages, but only if you use any gapps package bigger than nano, won't be supported here...

Again: Great finding, thank you so much!

EDIT: micro-stutters in playstore scrolling vanished for me, after enabling "parrallel webview rendering" in dev-ops - not enough time to tell if thia has side effects.

Interresting: https://www.xda-developers.com/diss...s-leveraged-excellent-real-world-performance/

EDIT2: Dankeschön noch 'mal! (Engl.: Thank you very much again!) You saved my night (or two... ;) ). My plan was going up the queue from kernel to framwork - never ever thought about webview...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] crian:
I don't want to edit the build.prop.

For changing the default DPI you have to edit it in your sources. So if you compile the rom, the DPI is set to 420 (or whatever) in the build.prop.

Even oos is using a default DPI of 420.

Don't want to attack or offend you. It's just a suggestion.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] lapapunk:
I can make the report for you. I've been flashed renderzenith and renderbroken as well, and all works good with all of them (I've flashed a few variants)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
No offense taken. But I would really appriciate, if you would read my responses. Some features are NOT usable (aka readable) any more. Sizing of elements like status bar is handled differently in oos from aosp based roms: the status bar in oos with 420dpi is in deed a very little bit larger then on los with 360dpi.

Anyway, I don't understand your insisting on changing that in the sources and force everyone to use 420dpi as default, instead of changing the settings? WE HAVE AN OPTION TO CHANGE THIS ON PER USER BASIS!!! What's you problem with changing dpi for you in dev-ops? Why are you ignoring all answers, options and alternatives you have been given and just insist on changing the default for everybody? Whats the drawback in using the available setting? Why are you completly ignoring my point on readability of quite some features with 420dpi?

If you don't want to answer at least: "What's wrong - or: what drawbacks come - with setting the dpi to 420 via settings?" I consider this discussion as ended.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] crian:
Alright discussion is ended. Before it escalates which is not my intention.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
OK.

BTW: Three people here tried to help you. I was just about to make a flashable zip just for you to change dpi. To do this right, I would have needed to know, for what porpose this is needed, or in other words: why you can't use the roms settings for changing the dpi. But if you ignore my questions, what should I do? If I ask a second time, this is no escalation. But ignoring the content of answers is bad manner. Last: I hoped you find out youself with my explenations (what can't work out, if you ignoring any answers) and the linked app: There is no dpi default setting. There is only ro.sf.lcd_density, which is set to 480. Where does 360 come from? It's computed from AAPT settings...

So this is one last attempt to help you: What should be changed, and what do we get by this change, what can't be achieved with rom's settings? I'm still willing to make a flashable zip for you - if I would know what should be changed and what should be achieved by this. You see, I need this answers not for escalation, but to help you. And yes: being treated like trash can, who has always to beg for information - and if doing so being treated like an offender - does not make my motivation to help going up...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] crian:
It was just a request, nothing more nothing less. If you say "no" it's ok for me.

I requested this, because the setup wizard didn't look well on the current default DPI. And the overall UI is far to big. But this is personal taste.

Already made a flashable zip for changing DPI by myself. But thanks.

I know about the option to set the DPI in the dev settings.

I never treated you like trash can. If you made bad experiences with users, I'm sorry for this.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I belive, that you doesn't mean to frustrate me. But try to take my perspective: I guess you are talking about the lcd density, but in the end - though asking three times and writing the 4th or 5th answer - I still don't know, what property you are exactly talking about.

This is feels very bad and respectless for me: A piece of information is thrown at me feet, and if I ask for more information (or logcats) I'm ignored at best... Of course this is not only you! I'm sure there are more options, but currently I see only two alternatives: answering only postings, that contain all needed information and leave everything else to the thread, or asking again and again till all information is collected (and whining a bit from time to time for mental hygiene...)

what exactly are you changing to what value? Is it the lcd density? But that would mean changing 480 to 420; I can't find anything where I can change 360 to 420 (I'm really confused here.). Anyway, if some dimensions are wrong, I would bet our aapt config is incorrect. I remember on t800, that using the aapt config like explained in the android developer documentation leeds to false calculated dimensions... Do you have an other example then setup wizard (first it's a pain in the ass to always start a clean flash; second which setup wizard are we talking about (los- or google-wizard, if google: which package (not all gapps came with all aapt configs))), to check different aapt configs.

EDIT:

For reference:

https://developer.android.com/guide/practices/screens_support.html

https://developer.android.com/guide/topics/resources/providing-resources.html#BestMatch

After rereading the part on dpi independent apks, I wonder why setupwizard has wrong dimensions... If it's the google setup wizard I also wonder if google is honoring it's own guides... *lol*

EDIT2: The physical density of our 3t is 401 dpi. xhdpi is for ~320 dpi; 480 dpi is xxhdpi. 400 is exactly the middle of this recommendations. If you want to test, I can make you a rom with xxhdpi, but I doubt that a dpi of 480 (instead of 420) is a good idea and will probably make elements too small - on the other hand: who knows without testing... ;) ...t800 expirience showed me, that one can't trust google documentation... Drop me a note, if you want to test such a build.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] crian:
Now I get your confusion. I mean the density of 480 and change it to 420. Which makes 411 dp in the dev settings.

I mixed it up. My bad.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] crian:
I would test it. No problem.

I made a flashable zip with your oos camera and gallery mod, which flash the apks to /system. But got some issues with the flashed apps.

On the gallery, the photos aren't loading. I can only see a back image but if I tap on it to open the image it show up normally. This happens only to the images I took with the camera.

On the camera I got a green screen if I'm switching between the build in "gallery" and the actual camera/ viewfinder.

If I install them as a normal apk, all is running fine.

Edit: found the fault. I forgot the libs.

Is it better to flash it to /system/apps or /system/priv-apps?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
cam has always been in priv-app. gallery was moved from priv-app to app on ob13 and moved back to priv-app on ob14. So I guess priv-ap is the safe side. (Since ob13 libfilter-sdk is no longer present, and gallery crashes on startup if the obsoleted lib is present.

Have you found any issues, that does not occur if libs and apps are installed to system? If so, I can add back them to the rom. I was pretty sure I havn't found any new issues introduced by installing it as user app - but it's "pretty sure", not "absolutly sure"... ;)

(Don't forget to sign the apks with los keys, otherwise the package installer will not parse the apps as previleged apps, and though they are physically live in system, they are treated as user apps.)

[MENTION=535343]all[/MENTION]: the cpu fan in my build host died (cross fingers the cpu shuted down before it got damaged). That means I can't build nor access my gits atm. A new fan is on the waymand should arrive tomorrow or the day after. If one of the homebuilders would be so nice, please, to make an aapt test build. Just replace the two AAPT containing lines with the three lines I posted yesterday?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] crian:
Did you get my pm?

Without the libs the issues appears. So i included them in the zip.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
building it right now. ill need about 3 hours to build, test the first boot myself and upload.

sidenote:

i think that you forgot to track themeinterfacer within your sources (.xml files)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I think you are right. I still have substratum.xml in my local repo, but ti has to be moved in nlos.xml. Thanx.

[MENTION=535343]all[/MENTION]: do you know this boxes with all the old pc parts, one can't give to trash, but will never be used again for years? I have such boxes (sadly, yes, plural ;) ). Found my riginal cooler. The fx8150 is NOT damaged!!!

(The original fan makes me feel listening to starting jets, as soon as the cpu is less then 80% idle... *lol* I'm ao happy the cpu wasn't damaged!!! Please push your build, anyway - I have to restore a raid5 first. Building while a soft raid is resynced will slow down both.)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I have answered meanwhile. I got the notification of your mail, when I just found the cooler... ...hope you understand. Did I tell you already, I'm so happy the cpu hasn't burnt... :) :) :)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
glad to hear that your cpu survived. ive got such a box, too ;)

i have to continue with some bad news: i ran out of memory after 3 hours of building time (at 100 percent). ill give it another try, maybe im still quicker than you. sorry for this

//EDIT:

currently uploading...

//EDIT2:

TEST-Build 20170920

Releasenotes: just a test build - see this post/request

Changelog:

AAPT CONFIG := large

AAPT PREF_CONFIG := xhdpi

DOWNLOAD​
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Check if jack-server is correctly reused or if jack has a mem leak (with some versions of sourcebuild icedtea it has!). When in doubt - wipe it out. Means: stop jack-server:

prebuilts/sdk/tools/jack-admin kill-server

What is your environment? On a physical linux ALWAYS! (*) configure a swap partion (do not swap to a file!) activate swap in fstab and set swapiness to 80.

(*) No matter if it's a notebook, pi3 or something else - no matter if ssd either. My personal point of view: even with the added aging of your ssd due to swaping (for this matter: used for var and tmp), you want a new one (bigger, faster, faster interface [8x epci, i.e.] etc.), long before the first sectoes remapping occurs.

For guest linuxes in a vm: increase virtual mem of rhe host os and increase ram granted to the vm your buildenvironment is running in.

On build times: on my fx8150 (overclocked by 7.5 %, 16GB ram; 32GB swap on vortex4 ssd) wicthout ccache: ~100 minutes

with ccache: ~41 minutes

In virtualbox vm with 8GB and two cpus granted and virtual swap device on surface pro 4 (16GB ram, i7):

running for over 9h at 73 %... (started that before finding the old cooler - decided then to let the build go on - just to know.)

I guess wit an i7 7700k with 64Gb and 2x 4xpcie ssd, out configuered to 32GB ramdisk, ccache dir on ssd1, build tree on ssd2 it should easily be possible to get under 20 minutes, if not under 15... Assuming all components are high end, especially ram and mb/chipset. Are there already mb/chipsets available, supporting more then 64GB with ddr4 and multi-channel? 256GB accessed via 4 channels at the same time would surely be great! EDIT (forgotten): replace the sofware mdraid with a linux supported (most adaptecs) pcie 8 disc hardware raid controler configured for raid 10 (or raid 2 over two raid 5 arrays) with 8 4gb wd red nas discs).
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] mcdachpappe:
thank you for your suggestions. my fault was that my "out" folder still contained another build -> my assigned partition was full.

environment: guest linux in a vm with 16gb ram, 4 cpus, ccache set on a ssd, device tree on a seperate ssd; msi gt70 notebook

building time - if i use the same sources/gits with just a few additions/removals: ~ 60minutes

building time - with new sources/gits (like in this case with your clean repos): ~ 180 minuts

I hope I helped a bit :)