yashsingh1/xdaforums huggingface dataset:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
That's a nugget!

[MENTION=243864]xda[/MENTION]: If you ever make t-shirts, coffee mugs or basecaps in black with yellow xda logo and this saying, I'm in for 5 shirts and 5 mugs...

(EDIT: I would love to take a vertex shirt with that nugget, but I'm afraid the monetary base of VERTEX and NLOS are the same.)

Your thoughts on debugging this (or bat drain in general) are great!

I had to admit, I was thorougly surprised, because I've understood the two "reports" were complaining on idle drain. Because of that I was so eager to see deep sleep (entered at all???), bat stats and wakelock stats... That's a good real-life example, what inacurate, incomplete or false use of terms can lead to. Because if we talk of screen on drain, it's a completely other game... And the complete two hours of searching and looking into code were wasted...

One question for deep sleep debugging: domyou know any way to get deep sleep and wakelocks information other then using googles apis (one way or another: sysfs or bat monitoring app)? I like shell loops on files, but - obviously - the device is not entering ds, if such a loop is running?

OT: While debugging the min freq issue, I used adb over network. The sleep command (i.e.: while cat /sys/foo/bar; do sleep 5; done" immidiatly stops working (sleeps for ever instead of 5 s), when the screen goes off... I like this behavior with eas, because a fprgotten loop in the background can't avoid the device going to ds.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] joshuous:
:)

Weird, I usually don't debug sleep issues. I think shell loops aren't really a great way to go about it. Google has this though: https://github.com/google/battery-historian

Not exactly simple, but definitely powerful tool
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] qbanlinxx:
Just trying this ROM out for the first time. Everything seems buttery smooth and battery life seems to be on par with stock OOS which has been rare for me on custom ROMs.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
UPDATE

Build 20171017

Releasenotes:

This build requires firmware OpenBeta 15 (aka ob15). As always an archive of all firmwares can be found below in the firmware section of Downloads - the flashable firmwares are the original (file names starting with oxygenos* hold original fw files) OnePlus fw images.

Changelog:

init: allow the gpu to drop to 133 MHz on idle. — skykinetic

Add german translation for Network Traffic — crian

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip

Camera- and Gallery-Download (If you havn't done so, update com.oneplus.camera and com.oneplus.gallery.)

[SIZE=+2]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] goosebickel:
Cheers for the new build, love the new boot logo, simple, yet elegant.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] qbanlinxx:
Does this include the Krack fix? Thanks in advance
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] stevenkyk:
I'm getting some strange wifi issues, not sure if anyone experiences the same. My wifi tends to disconnect every 2 minutes for a number of times before staying connected for a while longer, repeating the cycle again.

I checked the logcat, one line that might be of interest would be:

10-19 22:54:40.974 I/wpa_supplicant(3641): wlan0: CTRL-EVENT-DISCONNECTED bssid=xx:xx:xx:xx:xx:xx reason=3 locally_generated=1

From dmesg something related:

[27806.396054] R0: [wpa_supplicant][22:54:40.956849] wlan: [3641:E :HDD] __wlan_hdd_cfg80211_disconnect: 19497: Disconnect request from user space with reason: WLAN_REASON_DEAUTH_LEAVING

I believe it is not an issue related to my router, as other devices I have doesn't have similar issues.

I tried using DHCP and assigning static ip, but didn't seem to help. The problem occurs on both 2.4GHz and 5GHz with different SSID.

I'm on the 20171017 build with magisk v14.3 installed, OB15 firmware.

Any clues on whether is it a hardware issue or just a bug?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
https://www.cmxlog.com/14.1/

https://review.lineageos.org/#/q/st...wpa_supplicant_8+branch:cm-14.1+topic:krack-n

Propably a side effect of the above patches witg your current router firmware. Since the fix for the krack vulnarability is very restrictive on key exchanges and even strips some functions from the negotiation.

(I have probs with my tp-link (GoldenOrb_2016-04-01), but not on my asus rt ac66u (with current merlin build).)

Perhaps there are future patches on wpa_supplicant or a new fw for your router... Or you can try playing with the key settings of your router - but without profound 802.11 knowledge, I wouldn't recommend to do so. Time settings, country code and other swttings may influence the behavior, too.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Duplexity:
Hi there, appreciate your hard work on the ROM.

I've been having an issue with the default Snap camera app - where if I change any ISO settings and take a picture, it does not reset back to the camera view.

This seems to happen on any ISO setting other than the default Auto.

I wanted to confirm if this is a dirty flash issue or if it's happening to everyone, if anyone could try it that would be helpful.

Thanks in advance.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] stevenkyk:
My initial findings up till now shows that the frequent wifi drop isn't linked to the patch in any case. I have had this issue since a really long time ago (probably started even from oos), just it didn't escalate to this unbearable frequency of disconnecting every few minutes.

I tried playing with my router settings, nothing seemed to have helped (no krack patches for the firmware thus far too). However, I disabled ipv6 on my network, and guess what, haven't found any of the same error messages in my logs anymore.

I do remember oneplus having issues with ipv6, not sure if a fix was found. Perhaps someone with native ipv6 enabled and having no issues shed some light on this.

---------- Post added at 05:00 PM ---------- Previous post was at 04:51 PM ----------

Can confirm this, to describe it more accurately, after taking a picture with a manual ISO setting, the image freezes there but the app is still responsive, only that picture is taken. Correct behaviour happens only with the auto setting.

Just curious, any reasons why you won't switch to using gcam?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
I have ipv6 working in my lan (+wlan for that matter). But regarding the negotiation- issue: connected my phone to a second ipv4 only wlan router and had no drop (copied NLOS rom ~ 500MB) for 30 minutes).

https://xdaforums.com/oneplus-3t/development/rom-lineageos-14-1-t3547024/post74042540#post74042540

Until this is understood (and explained to me... ;)), I'm really clueless here. Any help is highly appriciated!!!

Some more workarounds:

Switch mode (video vs. still vs. panorame) or camera (ff vs. bf) and back.

Press recents directly followed by Snap again, or press back and go to snap again (i.e. if you have Snap on startscreen).

Use other cam app, including - but not limited to - ported auto-hdr pixel gcam (as already stated by [MENTION=4999962]stevenkyk[/MENTION] - and perhaps my future overall favorite), ported OnePlusCam (see my sig - my favorite in terms of ease of use), opencamera (my favorite in terms of still quality) or any other HAL3/api2 supporting camera app.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] stevenkyk:
That's strange, may I know your ipv6 configuration? Seems like you have native ipv6 from your isp too, are all the clients assigned ip addresses via dhcpv6 or slaac (managed or unmanaged)? Did u enable privacy extension too? I might try out with your settings.

I found on sultanxda's thread people having similar issues, but no mentions of IPv6, one guy did propose disabling tcp checksum offload on the phone itself, I might try out and report back later.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Nope. My carrier hookup is a huawei/vodafone k5150 on a TP-Link TL-MR3420 v2 with GoldenOrb_2016-04-01 ( OpenWRT r48430 ) . This baby does not support ipv6 and I 7se it as "stick-modem" connected with tp to a asus rt-ac66i running asus wrt-merlin 380.68_4 on primary wan port and 5GHz ac (80MHz width) on wlan. On the internal networks (lan + wlan) I run ipv6 - on the wan port ipv6 obviously is not working. Since I does not have a v6 address on my data dummy interface (if I switch off wlan on my op3t and use lte). The ipv6 encapsulated in v4 dummy data interface is NOT routed, so I belive my carrier (it's the same on my phone and the usb stick) is a bit behind in supporting v6 (or it's a matter of data plans - I have not found anybody competent enough at my carrier's hotline to shine some light on supported protocolls, i.e.: "Sir, we don't offer this tcp/ip. We have only lte and dsl.") .

Anyway: the negotiation on hardware layer in tcp/ip protocoll stack is not effected by ipv4/ipv6. The wpa_supplicant is the glue between IP layer and hardware layer, so the wpa patches (or the escalation) may be the problem.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] stevenkyk:
I don't see how I can diagnose the problem further though, logs aren't very helpful, shows just the same message as when disconnecting from a wifi network.

As a temporary workaround to save my sanity from the frequent disconnect, I decided to just disable wifi ipv6 on my phone itself. For anyone else who faces the same agony, try the following: (every time wifi is toggled this command may need to be run again, still figuring out how to make it stick permanently, only managed to make a toggle using KA)

echo 0 > /proc/sys/net/ipv6/conf/wlan0/accept_ra
echo 1 > /proc/sys/net/ipv6/conf/wlan0/disable_ipv6
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
You can try one of these:

/data/local/userinit.sh or init.d (mybe it's rendered unusable upstream by sepolicy rules).

magisk module.

init.d emulation (i.e. kerneladiutor).
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
camera: drop Snap from NLOS

First of all some general words on recent cam mods:

I would like to point you to this google Camera port: Modded Google Camera with HDR+, 60FPS video and Slow Motion

hdr+, hdr+ auto, hdr+ with flash, 60fps (30fps at 4k), 120 fps slowmotion and saving dng (raw) additionally works like charme with v4.0. [MENTION=4487956]S4turno[/MENTION] has not only done a real great job on this port, but he is activly maintaining and supporting his port.

It seems to me (photographic noob setting everything to auto, while thinking ISO is a new power drink...) that picture quality is at least on level with opencamera, if not suppirior (an enthusiastic, competent photographer may give a more adequat report). In low lights the pic quality is so much better then OnePlusCamera, that even me doesn't need a second pair of eyes to tell.

What gcam lacks currently are the manual controls (I'm not missing them - see above: I need working auto settings... ;) ). An other drawback is the fact, that gcam and OnePlusCam mods include same named but different libs, which leads to broken functionality if both apps installed at the same time. You HAVE to use one execlusivly!

Snap (on NLOS) is by far the worst app of this three: gcam, OnePlusCamera and Snap. You milleage may varry, but to me Snap seems to offer the most options and filters, with a third of them not working, producing not the best quality.

I still belive OnePlus' HAL3 implementation is better then it's reputation. Since Snap is still using legacy calls (HAL1) it's quality can't be as good as cam apps using HAL3 (like opencamera or gcam).

I havn't tested the sultanxda Snap port, but probably it's working better, then our (los) Snap. There's also an commercial SnapCam implementation working better then our Snap.

Considering the above I decided to drop Snap from NLOS from the next build on. NLOS will be shipped with Camera2 as standard camera app. This is very, very basic, but works and has no not working options (haha, it has NO options... ;) ).

I don't know, where this will go to. The next time I'll check if it's possible to use the libs from gcam mod systemwide...
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] S4turno:
Hey,

Thanks for mentioning my Google Camera thread. The port is actually made by BSG (bsg19071979 here on XDA) on a russian forum called 4PDA. Because 4PDA puts downloads behind a login page, I rehost his files here.

He has a Xiaomi Mi5S and the port is not 100% compatible with the OP3/3T, so users like ivanich and Arnova8G2 try to make the original work compatible with our device. I just host the apks, maintain the thread, try to find stable settings and try to help users. All credits go to these guys.

This port doesn't support all features Pixel users have access to (devs are reverse engineering the app...) but all the basic stuff works if you use one of the compatible apks and settings available on the main post. Compared to Oneplus Camera running on OxygenOS, the biggest downside is video stabilisation (it's bad, just like snap camera).

The reason why photos look better is the HDR+ technology developed by Google, which is way better than what Oneplus uses. If the user disables HDR+, the quality drops to the Snapcamera level.

From a custom ROM user perspective, even with all the limitations the port has, I think it is the best thing we have available. At least for me it's good enough to use as my default camera app.

OOS users probably don't need it, but it's useful for custom ROMs as the gap between stock and custom is, sometimes, huge.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Build 20171026

Releasenotes:

This build requires firmware OpenBeta 15 (aka ob15). As always an archive of all firmwares can be found below in the firmware section of Downloads - the flashable firmwares are the original (file names starting with oxygenos* hold original fw files) OnePlus fw images. NLOS and 'old'-style bootlogos can be found down in this posting.

Snap is replaced by aosp Camera2. Please read this ff.

[MENTION=4487956]S4turno[/MENTION]: I'll come back on your friendly posting, but not tonight... After reading the miui thread and looking at all download places and apktooling some of the packages, I was so damn lost in versions, that your posting was my last resort to get some order in the files... ;)

Changelog:

Drop LineageOS/CAF SnapCam aka Snap. — nvertigo

op3t: use current libmmcamera_interface.so. — nvertigo

Bootlogo choices

nlos_bootlogo-v0.1.zip

back_in_black_bootlogo-v1.0.zip

Camera- and Gallery-Download (If you havn't done so, update com.oneplus.camera and com.oneplus.gallery.)

[SIZE=+2]DOWNLOAD[/SIZE]​

Happy flashing!
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] phoberus:
I work with photo/video and can confirm thats a good thing. But it is important to note that H.265 / HEVC is not yet the standard and therefore there are compatibility problems.

For example, H.265 is still not 100% compatible with Adobe Premiere Pro. If I load a video with this HEVC modification in the newest Premiere Pro CC 2018, it can only read the audio track.

-> Depending on the use H.265 is very good, but to completely change, it must first become the standard.

(To avoid ambiguities: H.265 = HEVC)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] horqai:
Thanks for the new build, works perfect as usual.

Only the idea with the Gcam Mod I can sadly not test as the recent builds keep closing in photo mode and I tried everything suggested in this thread. Only this version is working for me MGCB_7.0H_C2API_Full_PXL2_v.1.4_60FPS_noburst_v3.apk
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Pollie81:
This rom is indeed very good!

I love it, i installed the gcam mod 4.0v3 and so far it seems really good.. i didn't test much though, only made a few single shots.

I'm glad i found a rom which provides great smoothness and performance without heating up during games.

Thanks!

Verstuurd vanaf mijn ONEPLUS A3003 met Tapatalk
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] S4turno:
You're probably using the wrong settings.

On the 3/3T we need to use a setting called Nexus6 HDR+ Auto. All the other settings crash the app under certain conditions (eg: when taking pictures outdoors or of bright things). Other devices don't have this problem, but we do...

Because BSG's apks based on Google Camera 5.x don't include the settings we need, we have to use one of Arnova8G2 apks (he modifies BSG's work to make it compatible with our device).

I suggest you try one of these two versions. Use the recommended settings to avoid issues:

- GCam5.1.014-Arnova8G2-v6-test4 with these settings;

- MGCB_7.0H_C2API_v.4.0_AllinOne_Full_Manual with these settings;

The first file, from Arnova8G2, is based on the latest Google Camera 5.1.014. The second, from BSG, is based on Google Camera 4.4.020.

If you have a Google Camera app installed, uninstall it before installing the new one. And make sure you restart the app after changing your settings.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Great to hear that from a professionel point of view.

I'm not. I even can't tell slightly differeneces: There is an picture quality comparission of galaxy devices on androidpit, where I can't see the differences.

But on low light pics the differences from gcam to Snap or OnePlusCamera is that great, that I can easily tell.

Gcam also matches perfectly my needs: set all to auto, point at the motive, hit the shutter button and forget...

Last but not least: the bug on hal3 that ISO sticks to 799 seems to be circumvented (phrase?), I have taken stills with over ISO 2000.

On video codecs: you are thenadventures type, aren't you? Using the word "standards" in the same phrase as video codecs is as tough as using "standard" with wifi... ;) Haven't looked in h.265 so far, but with h.264 I had real fun to transcode a h.264 1080i transfer stream container in a mp4 container with 1080p60 content to watch it on manta (nexus 10): with all the different baselines and settings it was a pain in the ass to get it working... ...and compared to h.265 h264 was more of a "standard". Time will show. I hope you f8nd a way to transcode the h.265 in a way that Premiere will eat it.

See the posting from S4turno. I'm currently using this port:

MGCB_7.0H_C2API_v.4.0_AllinOne_Full_Manual with these settings;

I just did, what I'm asking everybody to do here as well: I just followed the OP: install app, put recommended settings in place, hit back 2 times and rebooted the device.

Do you have OnePlusCamera installed? You can't have both working the same time due to colliding libs namespaces in the app added libs. Rule: OnePlusCamera XOR gcam.

Because I'm no gamer (Linux: some call it an OS - for me it's the world greatest text adventure) and my data plan is used for source down- and rom uploads, gaming is the least tested use case. I'm happy for all gaming feedback.

The very first gcam5 app was crashing on NLOS directly on app start - but since 4.0 and 4.0_v3 were running that great, I've never investigated.

Just for completeness: uninstall OnePlusCamera, if installed.

One question: if the manual controls are available, they should apper in the apps "three dashes menu", shouldn't they?

I'm afraid the very same patch delivering hal1 to all apps not explicitly requesting hal3 also delivers wrong camera characteristics on the characteristics call back for manual controls - but that's more some kind of fear, then log proofed insights.

It's "Use the source, Luke" isn't it? ;)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] horqai:
Thank you for your help.

For the v5:

I've tried the suggested settings, uninstalled all other cams like open camera and used the zip to remove the oneplus cam libs (followed by a reinstall of your provided cam app v5), restarted and rebooted several times. I also looked into the buildprobs for hal3.

It keeps crashing :(

The only way to reach the settings for the v5 is anyhow to longpress the app icon and choose take video. That way there's no crash and I'm able to take a video and change settings to the values you wrote. If I than switch to photo the app crashes. Also after restart. Funny thing is that I can take pictures in panorama mode, when opening the cam with the video mode workaround. The sad thing is that it seems like that I'm the only one with this issue and I don't want to spam this thread.

But that's as I found out just for v5

Important!

4.0_AllinOne_Full_Manual is working without any issue :)

Therefore I'm sticking to this version.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Read my last posting, 4.0 and 4.0_v3 are working for me, previous v5.0 is crashing - so you are not the only one and you can stop feeling sad... ;)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] S4turno:
As far as I know, Google Camera doesn't come with a manual mode. If you touch to focus, then you can control exposure, but that's it.

Two screenshots from the original GCam (4.4.20) app running on my Nexus 5X:

https://i.imgur.com/qrPSx60.jpg

https://i.imgur.com/Gy8VZXI.jpg

Same options/UI as BSG's v4.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Dude, you saved my weekend! Did three test builds allready, because the featured article was talking of "full manual control"... But with your 8nformation, I stop searching for my fault on vanishing manual controls. Thanx! (That would have been a quite frustating we... ;) )

[MENTION=535343]all[/MENTION]: I consider 4.0 and 4.0_v3 (beside 16:9 pics) fully working on NLOS. (I'm not entirely sure if ois is working.)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] S4turno:
I might be wrong, but I never found any manual controls on my Nexus 5X. It can be a Pixel thing only...

When I need something more advanced, I use Open Camera (free and open source) or one of the paid apps I bought in the past: Manual Camera or ProShot.

4.0_v3 comes with that 16:9 issue, that's why I suggested v4.0 above. Also, in my opinion versions of the port based on GCam 5.1.x are not as stable as v4.0.
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] Jaizu:
In my opinion you should update this: https://xdaforums.com/showpost.php?p=70781760&postcount=4

Other than that, grats for your ROM, looks like are doing a great job with it, and we really appreciate that! Looks like camera stuff will be always a headache in custom roms with oneplus p:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
Thanx for heads up. Fixed.

[MENTION=535343]all[/MENTION]: has anybody recently tried to encrypt an unencrypted data partition?
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] DeadPicsel:
I encrypted using your latest build
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
[MENTION=5047351]Jaizu[/MENTION] and [MENTION=5073087]bu44er[/MENTION]: Known Issues posting looks great now! Thanx! :)
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] xcentrik05:
all,

I just did a clean install of the latest build and I can't sent/receive MMS messages. I'm pretty sure this is only happening to me because I've searched the thread and forums and haven't found anyone else experiencing this on this ROM or LOS/phone combination.

I've tried...

Changed settings to manually download MMS

I've cleared cache on the messaging app

Tried other third party messaging apps

Changed my APN and rebooted

The only thing I can get to work is Allo, but most of my contacts don't use it.

My NLOS backup can still send/receive MMS

I was wondering if anyone else has seen this or can offer up some suggestions of things to try.

thanks
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] :
From OP:
[OnePlus 3T ROMs, Kernels, Recoveries, & Other Deve] xcentrik05:
Sorry, attached is the log file from when I try to send an MMS. I've filtered it to just errors. Let me know if this helps; it's my first time trying to provide a logcat.